Functions for basic php arithmetic operators in tv_arith.h @override-unit-failures
commitc51583cfb8fbc831f452e7ddd4485bc8f0c2db7b
authorJordan DeLong <jdelong@fb.com>
Mon, 24 Jun 2013 01:32:24 +0000 (23 18:32 -0700)
committerSara Golemon <sgolemon@fb.com>
Mon, 1 Jul 2013 20:41:01 +0000 (1 13:41 -0700)
treecebaf427fab7a441b67543d6f3b1533cadf76404
parent8220a180602869b513fddb0896fee55101a53059
Functions for basic php arithmetic operators in tv_arith.h @override-unit-failures

Deletes operator overloads on variant for the same and points
bytecode.cpp at them.  Also fixes one known accidental deviation from
zend.  These functions take Cells by value because it seemed to make
sense---I'll likely convert the various functions in the new
tv_conversions.h (and tv_comparisons.h) to do the same but in another
diff.
14 files changed:
hphp/compiler/expression/binary_op_expression.cpp
hphp/runtime/base/builtin_functions.h
hphp/runtime/base/execution_context.h
hphp/runtime/base/hphp_value.h
hphp/runtime/base/tv_arith.cpp [new file with mode: 0644]
hphp/runtime/base/tv_arith.h [copied from hphp/runtime/base/tv_helpers-inl.h with 54% similarity]
hphp/runtime/base/tv_comparisons.cpp
hphp/runtime/base/tv_conversions-inl.h [copied from hphp/runtime/base/tv_helpers-inl.h with 63% similarity]
hphp/runtime/base/tv_conversions.h [moved from hphp/runtime/base/tv_helpers-inl.h with 62% similarity]
hphp/runtime/base/tv_helpers.h
hphp/runtime/base/type_variant.cpp
hphp/runtime/base/type_variant.h
hphp/runtime/vm/bytecode.cpp
hphp/test/quick/string_int_arith.php [new file with mode: 0644]