| commit | 8220a180602869b513fddb0896fee55101a53059 | |
| author | Jordan DeLong <jdelong@fb.com> | |
| Fri, 28 Jun 2013 20:41:13 +0000 (28 13:41 -0700) | ||
| committer | Sara Golemon <sgolemon@fb.com> | |
| Mon, 1 Jul 2013 20:41:00 +0000 (1 13:41 -0700) | ||
| tree | 5aa02d9eccaba2c661cac6a32d1a2339a4176905 | treesnapshot (tar.gz zip) |
| parent | 97a23e5ea7e87483c1b33253647085a640c7d903 | commitdiff |
Convert a few tvFoo functions to take parameters by reference
Since TypedValue::operator= is dangerous, something like
tvTeleport is usually what you want to use, but it doesn't work with
temporary TypedValues (e.g. return values of things like make_tv or
cellAdd), because it took the arguments by pointer. This also means
we can change it to take parameters by value later without updating
callsites. This diff does the tvDup family and changes tvTeleport to
tvCopy. I'll gradually get the other ones done, but I just need these
for now to work with temporaries for changing SetOp to not use Variant
arithmetic.
Since TypedValue::operator= is dangerous, something like
tvTeleport is usually what you want to use, but it doesn't work with
temporary TypedValues (e.g. return values of things like make_tv or
cellAdd), because it took the arguments by pointer. This also means
we can change it to take parameters by value later without updating
callsites. This diff does the tvDup family and changes tvTeleport to
tvCopy. I'll gradually get the other ones done, but I just need these
for now to work with temporaries for changing SetOp to not use Variant
arithmetic.
18 files changed: