Update the caching for a few ReflectionClass functions to be sane
commit824bb3c90b4107f8dd2d7b3022d049038e193523
authorDavid Snider <dizzy@fb.com>
Thu, 14 Feb 2019 16:34:27 +0000 (14 08:34 -0800)
committerHhvm Bot <hhvm-bot@users.noreply.github.com>
Thu, 14 Feb 2019 16:58:23 +0000 (14 08:58 -0800)
treee3f3700be31fa03c53fd3a4e9a3cff9b64570642
parentc8d2c8c7a76b7a67452cc32e865bded3e0cb39bd
Update the caching for a few ReflectionClass functions to be sane

Summary: Don't use a static member to cache over instance methods. That's....nonoptimal. Instead, move these methods to static in the runtime, pass in a classname, and just memoize over a static function

Reviewed By: alexeyt

Differential Revision: D14060703

fbshipit-source-id: e38a86ebf9af60183ba0810b5091c76657e89ee6
hphp/runtime/ext/reflection/ext_reflection.cpp
hphp/runtime/ext/reflection/ext_reflection_hni.php
hphp/test/slow/dv_array/ext_reflection/reflection_class.php
hphp/test/slow/dv_array/ext_reflection/reflection_class.php.expectf
hphp/test/slow/dv_array_hack_arr/ext_reflection/reflection_class.php
hphp/test/slow/dv_array_hack_arr/ext_reflection/reflection_class.php.expectf