| commit | c8d2c8c7a76b7a67452cc32e865bded3e0cb39bd | |
| author | Leo Osvald <leoo@fb.com> | |
| Thu, 14 Feb 2019 16:28:01 +0000 (14 08:28 -0800) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Thu, 14 Feb 2019 16:50:45 +0000 (14 08:50 -0800) | ||
| tree | 80b1be5ca4f2ccfb94120b9a70c2f442149ee7ae | treesnapshot (tar.gz zip) |
| parent | c6c99af25fd893fb678f34a22411c5cd2b9fa39c | commitdiff |
Enable gradual migration of FFP errors away from CST
Summary:
Now that error reporting in lowering is decoupled from building AST
(by capturing side effects and replaying them via flush_parsing_errors),
reuse the same mechanism for prioritizing syntax errors emitted
from the Full_fidelity_syntax_errors module but also merge them
with errors from a *new* phase of error checking on lowered AST.
This way, existing error checks can be *gradually* moved from CST to AST
or to the parser itself (for those which cannot be detected after lowering).
Reviewed By: oulgen
Differential Revision: D13985463
fbshipit-source-id: 3f28889e6a6a4d8011d8dc24bab167d44f20d5a4
Summary:
Now that error reporting in lowering is decoupled from building AST
(by capturing side effects and replaying them via flush_parsing_errors),
reuse the same mechanism for prioritizing syntax errors emitted
from the Full_fidelity_syntax_errors module but also merge them
with errors from a *new* phase of error checking on lowered AST.
This way, existing error checks can be *gradually* moved from CST to AST
or to the parser itself (for those which cannot be detected after lowering).
Reviewed By: oulgen
Differential Revision: D13985463
fbshipit-source-id: 3f28889e6a6a4d8011d8dc24bab167d44f20d5a4