| commit | 501c7a4763a06bef1548120c915eecfa1b7bbcd5 | |
| author | Lucian Wischik <ljw@fb.com> | |
| Thu, 6 Aug 2020 23:55:29 +0000 (6 16:55 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Fri, 7 Aug 2020 00:03:27 +0000 (6 17:03 -0700) | ||
| tree | 6bc181a8dc1fbe0ee832f31759060395717a448a | treesnapshot (tar.gz zip) |
| parent | 46cb6ad07947c2214077339bd43fc574d30dfa3f | commitdiff |
Exit_status.show
Summary:
Exit_status.to_string is an irritating method. I've replaced it with `[@deriving show]`
The only user-visible change is that the string "OK" will be replaced by "No_error" in a few places - HackEventLogger telemetry, a couple of Hh_logger.logs. The code looks like it would affect some user-facing messages out of hh_client, but I don't think it will, since those messages are only displayed in case of error.
Reviewed By: arxanas
Differential Revision: D22926808
fbshipit-source-id: b5533275ff36e208f96bcbc7ea56f8a9cae3f9b6
Summary:
Exit_status.to_string is an irritating method. I've replaced it with `[@deriving show]`
The only user-visible change is that the string "OK" will be replaced by "No_error" in a few places - HackEventLogger telemetry, a couple of Hh_logger.logs. The code looks like it would affect some user-facing messages out of hh_client, but I don't think it will, since those messages are only displayed in case of error.
Reviewed By: arxanas
Differential Revision: D22926808
fbshipit-source-id: b5533275ff36e208f96bcbc7ea56f8a9cae3f9b6