| commit | 459a6cc0b0d21273fe047e45d12b5df9848f43f7 | |
| author | Max Wang <mwang@fb.com> | |
| Fri, 4 Mar 2016 08:33:47 +0000 (4 00:33 -0800) | ||
| committer | Hhvm Bot <hhvm-bot-bot@fb.com> | |
| Fri, 4 Mar 2016 09:00:25 +0000 (4 01:00 -0800) | ||
| tree | 8067cdd35d7f8705a678a0b9b05785a590bd677f | treesnapshot (tar.gz zip) |
| parent | ff5c5835b1f7ea4d8882d558b18df6febe7f65f7 | commitdiff |
Rewrite handleSRHelper as a unique stub
Summary:Kill the asm stub and replace it with a vasm stub. Omits the CFI info,
since (a) MCGenerator::handleServiceRequest() is noexcept, so we don't
need it for unwinding; (b) we unwind through all TC frames at once with
our custom handler, so we don't need it for unwinding; and (c) it's
incorrect anyway, now that we spill to the native stack.
Reviewed By: swtaarrs
Differential Revision: D2965449
fb-gh-sync-id: b50f5256c5a30ade539356e5b7a8294cf6a4696b
shipit-source-id: b50f5256c5a30ade539356e5b7a8294cf6a4696b
Summary:Kill the asm stub and replace it with a vasm stub. Omits the CFI info,
since (a) MCGenerator::handleServiceRequest() is noexcept, so we don't
need it for unwinding; (b) we unwind through all TC frames at once with
our custom handler, so we don't need it for unwinding; and (c) it's
incorrect anyway, now that we spill to the native stack.
Reviewed By: swtaarrs
Differential Revision: D2965449
fb-gh-sync-id: b50f5256c5a30ade539356e5b7a8294cf6a4696b
shipit-source-id: b50f5256c5a30ade539356e5b7a8294cf6a4696b