Replace hand-rolled vector implementations
commitff5c5835b1f7ea4d8882d558b18df6febe7f65f7
authorRick Lavoie <rlavoie@fb.com>
Fri, 4 Mar 2016 01:39:18 +0000 (3 17:39 -0800)
committerHhvm Bot <hhvm-bot-bot@fb.com>
Fri, 4 Mar 2016 02:00:42 +0000 (3 18:00 -0800)
tree7b81be4284ecace72f189efa2256bf3dc7bd5d79
parentfc7e63d756b0b4f79e8916ebaf725e4d817917d4
Replace hand-rolled vector implementations

Summary:In a few places we allocate a raw array of memory (without running any
constructors), tracking the number of constructed elements, and running placement
new and destructors manually as elements are added or removed from the
array. This is exactly what req::vector does, so just use that instead.

Reviewed By: markw65, edwinsmith

Differential Revision: D3006162

fb-gh-sync-id: 96ba944ba5b510a1aa7d2a595dff1d8a5d925d70
shipit-source-id: 96ba944ba5b510a1aa7d2a595dff1d8a5d925d70
hphp/runtime/base/string-util.cpp
hphp/runtime/ext/array/ext_array.cpp