No error on use of `unsafe_cast`
commit3a9e1dff10d721e1c0c47209bad11c88964fcc0b
authorMichael Thomas <mjt@fb.com>
Mon, 25 Oct 2021 12:32:22 +0000 (25 05:32 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Mon, 25 Oct 2021 12:35:50 +0000 (25 05:35 -0700)
treefef64b2a2ffb949ddac61d8300d0a0c14fae1c03
parent588ee292ef8bb36b429281b1ca8928f424801c69
No error on use of `unsafe_cast`

Summary: In line with decision log on T90317661, we no longer require an HH_FIXME for uses of `unsafe_cast`

Reviewed By: madgen

Differential Revision: D28929990

fbshipit-source-id: 40b90349d33681b5302ffce5b079f0fb4fc9d2c6
24 files changed:
hphp/hack/hhi/soundness.hhi
hphp/hack/src/errors/error_codes.ml
hphp/hack/src/errors/errors.ml
hphp/hack/src/errors/errors.mli
hphp/hack/src/oxidized/gen/error_codes.rs
hphp/hack/src/typing/typing.ml
hphp/hack/test/holes/unsafe_cast_flow_typing.php.holes.exp
hphp/hack/test/typecheck/inout/pseudofunction_etc.php.exp
hphp/hack/test/typecheck/inout/pseudofunction_etc.php.legacy_decl.exp [copied from hphp/hack/test/typecheck/inout/pseudofunction_etc.php.exp with 90% similarity]
hphp/hack/test/typecheck/unsafe_cast/arity_error.php.exp
hphp/hack/test/typecheck/unsafe_cast/arity_error.php.legacy_decl.exp
hphp/hack/test/typecheck/unsafe_cast/arity_error.php.like_types.exp [copied from hphp/hack/test/typecheck/unsafe_cast/arity_error.php.exp with 52% similarity]
hphp/hack/test/typecheck/unsafe_cast/ignored/arity_error.php.exp [copied from hphp/hack/test/typecheck/unsafe_cast/arity_error.php.exp with 52% similarity]
hphp/hack/test/typecheck/unsafe_cast/ignored/arity_error.php.legacy_decl.exp [copied from hphp/hack/test/typecheck/unsafe_cast/arity_error.php.legacy_decl.exp with 52% similarity]
hphp/hack/test/typecheck/unsafe_cast/ignored/arity_error.php.like_types.exp [copied from hphp/hack/test/typecheck/unsafe_cast/arity_error.php.exp with 52% similarity]
hphp/hack/test/typecheck/unsafe_cast/ignored/non_string_literal_ignored.php.exp
hphp/hack/test/typecheck/unsafe_cast/ignored/non_string_literal_ignored.php.legacy_decl.exp
hphp/hack/test/typecheck/unsafe_cast/ignored/non_string_literal_ignored.php.like_types.exp [copied from hphp/hack/test/typecheck/unsafe_cast/ignored/non_string_literal_ignored.php.exp with 76% similarity]
hphp/hack/test/typecheck/unsafe_cast/non_string_literal.php.exp
hphp/hack/test/typecheck/unsafe_cast/non_string_literal.php.legacy_decl.exp
hphp/hack/test/typecheck/unsafe_cast/non_string_literal.php.like_types.exp [copied from hphp/hack/test/typecheck/unsafe_cast/non_string_literal.php.exp with 75% similarity]
hphp/hack/test/typecheck/unsafe_cast/unsafe_cast.php.exp
hphp/hack/test/typecheck/unsafe_cast/unsafe_cast.php.legacy_decl.exp
hphp/hack/test/typecheck/unsafe_cast/unsafe_cast.php.like_types.exp [new file with mode: 0644]