| commit | 2c752c1ba89a2a0b5057c5dabaca156fbb0e2682 | |
| author | Jason Evans <je@fb.com> | |
| Sat, 12 Dec 2015 19:29:26 +0000 (12 11:29 -0800) | ||
| committer | hhvm-bot <hhvm-bot@fb.com> | |
| Sat, 12 Dec 2015 19:30:31 +0000 (12 11:30 -0800) | ||
| tree | 1d567127cee7eda9b3890faf87e4be31c08f3c85 | treesnapshot (tar.gz zip) |
| parent | a8cd9341740577b86053d4a3b76c19c901f5c633 | commitdiff |
Fix StackTrace::PerfMap::Range::Cmp.
Summary:
Fix StackTrace::PerfMap::Range::Cmp to use <= rather than <, so that
directly adjacent (yet non-overlapping) ranges are ordered rather than
being considered equal. Prior to this fix, "equal" entries in the
PerfMap could be masked, resulting in failed symbol resolution (i.e.
"TC?") for addresses within the masked ranges.
bypass-lint
Reviewed By: bnell
Differential Revision: D2752771
fb-gh-sync-id: 80b3b3d5e97a2bf336f1770c5cddcb73a73dcd53
Summary:
Fix StackTrace::PerfMap::Range::Cmp to use <= rather than <, so that
directly adjacent (yet non-overlapping) ranges are ordered rather than
being considered equal. Prior to this fix, "equal" entries in the
PerfMap could be masked, resulting in failed symbol resolution (i.e.
"TC?") for addresses within the masked ranges.
bypass-lint
Reviewed By: bnell
Differential Revision: D2752771
fb-gh-sync-id: 80b3b3d5e97a2bf336f1770c5cddcb73a73dcd53
| hphp/util/stack-trace.cpp | diffblobblamehistory | |
| hphp/util/stack-trace.h | diffblobblamehistory | |
| hphp/util/test/stack-trace.cpp | [new file with mode: 0644] | blob |