| commit | a8cd9341740577b86053d4a3b76c19c901f5c633 | |
| author | Josh Watzman <jwatzman@fb.com> | |
| Sat, 12 Dec 2015 18:45:58 +0000 (12 10:45 -0800) | ||
| committer | hhvm-bot <hhvm-bot@fb.com> | |
| Sat, 12 Dec 2015 19:00:31 +0000 (12 11:00 -0800) | ||
| tree | 0efbea4b58ce4ed498386b3632d2465f076f04d3 | treesnapshot (tar.gz zip) |
| parent | 26c7b33268aebf93dc076456c09b3c032aca855a | commitdiff |
Properly report versions in PHP7 mode
Summary:
This ended up being somewhat more annoying than you would hope, due to a couple of places that assumed the version was a compile-time constant. Also, wiring the switch into mangleUnitMd5 is weird, but in repo mode, `PHP_VERSION_MAJOR` can get inlined, so it does actually affect bytecode emission :\
Fixes https://github.com/facebook/hhvm/issues/6636
Reviewed By: paulbiss
Differential Revision: D2732232
fb-gh-sync-id: a54e2216d12fd875df698aa35c06669f1ea4d435
Summary:
This ended up being somewhat more annoying than you would hope, due to a couple of places that assumed the version was a compile-time constant. Also, wiring the switch into mangleUnitMd5 is weird, but in repo mode, `PHP_VERSION_MAJOR` can get inlined, so it does actually affect bytecode emission :\
Fixes https://github.com/facebook/hhvm/issues/6636
Reviewed By: paulbiss
Differential Revision: D2732232
fb-gh-sync-id: a54e2216d12fd875df698aa35c06669f1ea4d435
14 files changed: