| commit | 2a79bcdcef2aa7f21641c52fb072a6016c894b37 | |
| author | Jake Bailey <jakebailey@fb.com> | |
| Wed, 1 Jun 2022 22:18:20 +0000 (1 15:18 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Wed, 1 Jun 2022 22:18:20 +0000 (1 15:18 -0700) | ||
| tree | 6a53b7bdbaf2749ef3c8c419983b37af1c763843 | treesnapshot (tar.gz zip) |
| parent | 814544ed90c499789b1bd8d539f2a18090fbd6b7 | commitdiff |
Remove push/pop_local_changes from FileProvider trait
Summary:
The push/pop_local_changes methods don't really belong in FileProvider. Only hh_server is interested in having the ability to push/pop local changes, and we really shouldn't be giving the (Rust) typechecker permission to invoke these methods anyway.
Instead, follow the same pattern used for the naming table in previous diffs, and for shallow and folded decls later in this stack: have HhServerProviderBackend hold on to a backing ChangesStore (in order to invoke push/pop_local_changes on it), and use that as the storage for the FileProvider.
Differential Revision: D36725433
fbshipit-source-id: d53529a4f96bac23012438bdc3b9170677bdaef9
Summary:
The push/pop_local_changes methods don't really belong in FileProvider. Only hh_server is interested in having the ability to push/pop local changes, and we really shouldn't be giving the (Rust) typechecker permission to invoke these methods anyway.
Instead, follow the same pattern used for the naming table in previous diffs, and for shallow and folded decls later in this stack: have HhServerProviderBackend hold on to a backing ChangesStore (in order to invoke push/pop_local_changes on it), and use that as the storage for the FileProvider.
Differential Revision: D36725433
fbshipit-source-id: d53529a4f96bac23012438bdc3b9170677bdaef9
16 files changed: