| commit | 14c2efce157fa763a3d5264d8bc1613a6050589a | |
| author | Jan Oravec <jan@fb.com> | |
| Fri, 23 Oct 2020 18:02:13 +0000 (23 11:02 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Fri, 23 Oct 2020 18:05:46 +0000 (23 11:05 -0700) | ||
| tree | 906f60b5dcf754af1333bcae44cf91ece79483b8 | treesnapshot (tar.gz zip) |
| parent | 938e2a05f970035292fdbb0971bda3a0c9159d60 | commitdiff |
SrcKey, BCMarker: unconfuse validity vs sanity
Summary:
Both SrcKeys and BCMarkers use sentinel values for invalid objects, but
BCMarker::valid() also checks for sanity.
Move the sanity checks to asserts and reduce complexity related to dummy ids.
Reviewed By: paulbiss
Differential Revision: D24485361
fbshipit-source-id: adfd0ff0f6d4c0ce6d16c2f7c888bce2ac46f102
Summary:
Both SrcKeys and BCMarkers use sentinel values for invalid objects, but
BCMarker::valid() also checks for sanity.
Move the sanity checks to asserts and reduce complexity related to dummy ids.
Reviewed By: paulbiss
Differential Revision: D24485361
fbshipit-source-id: adfd0ff0f6d4c0ce6d16c2f7c888bce2ac46f102