| commit | 938e2a05f970035292fdbb0971bda3a0c9159d60 | |
| author | Jan Oravec <jan@fb.com> | |
| Fri, 23 Oct 2020 18:02:13 +0000 (23 11:02 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Fri, 23 Oct 2020 18:04:47 +0000 (23 11:04 -0700) | ||
| tree | 064f67f427ec458be1a368345881b42848706af7 | treesnapshot (tar.gz zip) |
| parent | f5d12ff859d78fcbf7eb2eaf8be0197bd0c93e24 | commitdiff |
Fix updateMarker() in prologues by using SrcKey instead of Offset
Summary:
The prologue tag is dropped from the current marker's SrcKey when updateMarker()
is used. This is because makeMarker() accepts an Offset and uses it to build
the new SrcKey.
Fix this by accepting a SrcKey instead of an Offset. Update some APIs that
create a marker (such as makeExit()) to do the same. These APIs were usually
passed bcOff(env) or nextBcOff(env), which were simply replaced by
curSrcKey(env) or nextSrcKey(env), preventing a SrcKey -> Offset -> SrcKey
roundtrip.
Reviewed By: paulbiss
Differential Revision: D24470012
fbshipit-source-id: 1720ecd58fda64b5ef92d89906494702ddd11e2d
Summary:
The prologue tag is dropped from the current marker's SrcKey when updateMarker()
is used. This is because makeMarker() accepts an Offset and uses it to build
the new SrcKey.
Fix this by accepting a SrcKey instead of an Offset. Update some APIs that
create a marker (such as makeExit()) to do the same. These APIs were usually
passed bcOff(env) or nextBcOff(env), which were simply replaced by
curSrcKey(env) or nextSrcKey(env), preventing a SrcKey -> Offset -> SrcKey
roundtrip.
Reviewed By: paulbiss
Differential Revision: D24470012
fbshipit-source-id: 1720ecd58fda64b5ef92d89906494702ddd11e2d
14 files changed: