kdc: _kdc_find_etype prevent NULL dereference
[heimdal.git] / kadmin / add_enctype.c
blobd128ab7f49ef690c4a47a474ff6c5a100665ed01
1 /*
2 * Copyright (c) 1999-2006 Kungliga Tekniska Högskolan
3 * (Royal Institute of Technology, Stockholm, Sweden).
4 * All rights reserved.
6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions
8 * are met:
10 * 1. Redistributions of source code must retain the above copyright
11 * notice, this list of conditions and the following disclaimer.
13 * 2. Redistributions in binary form must reproduce the above copyright
14 * notice, this list of conditions and the following disclaimer in the
15 * documentation and/or other materials provided with the distribution.
17 * 3. Neither the name of the Institute nor the names of its contributors
18 * may be used to endorse or promote products derived from this software
19 * without specific prior written permission.
21 * THIS SOFTWARE IS PROVIDED BY THE INSTITUTE AND CONTRIBUTORS ``AS IS'' AND
22 * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
23 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
24 * ARE DISCLAIMED. IN NO EVENT SHALL THE INSTITUTE OR CONTRIBUTORS BE LIABLE
25 * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
26 * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
27 * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
28 * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
29 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
30 * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
31 * SUCH DAMAGE.
34 #include "kadmin_locl.h"
35 #include "kadmin-commands.h"
38 * del_enctype principal enctypes...
41 int
42 add_enctype(struct add_enctype_options*opt, int argc, char **argv)
44 kadm5_principal_ent_rec princ;
45 krb5_principal princ_ent = NULL;
46 krb5_error_code ret;
47 const char *princ_name;
48 int i, j;
49 krb5_key_data *new_key_data = NULL;
50 int n_etypes;
51 krb5_enctype *etypes;
53 if (!opt->random_key_flag) {
54 krb5_warnx (context, "only random key is supported now");
55 return 0;
58 memset(&princ, 0, sizeof(princ));
59 princ_name = argv[0];
60 n_etypes = argc - 1;
61 etypes = malloc (n_etypes * sizeof(*etypes));
62 if (etypes == NULL) {
63 krb5_warnx (context, "out of memory");
64 return 0;
66 argv++;
67 for (i = 0; i < n_etypes; ++i) {
68 ret = krb5_string_to_enctype(context, argv[i], &etypes[i]);
69 if (ret) {
70 krb5_warnx (context, "bad enctype \"%s\"", argv[i]);
71 goto out2;
75 ret = krb5_parse_name(context, princ_name, &princ_ent);
76 if (ret) {
77 krb5_warn(context, ret, "krb5_parse_name %s", princ_name);
78 goto out2;
81 /* The principal might have zero keys, but it will still have a kvno! */
82 ret = kadm5_get_principal(kadm_handle, princ_ent, &princ,
83 KADM5_KVNO | KADM5_PRINCIPAL | KADM5_KEY_DATA);
84 if (ret) {
85 krb5_free_principal(context, princ_ent);
86 krb5_warnx(context, "no such principal: %s", princ_name);
87 goto out2;
90 /* Check that we got key data */
91 if (kadm5_all_keys_are_bogus(princ.n_key_data, princ.key_data)) {
92 krb5_warnx(context, "user lacks get-keys privilege");
93 goto out;
96 new_key_data = calloc(princ.n_key_data + n_etypes,
97 sizeof(*new_key_data));
98 if (new_key_data == NULL) {
99 krb5_warnx (context, "out of memory");
100 goto out;
103 for (i = 0; i < princ.n_key_data; ++i) {
104 krb5_key_data *key = &princ.key_data[i];
106 for (j = 0; j < n_etypes; ++j) {
107 if (etypes[j] == key->key_data_type[0]) {
108 /* XXX Should this be an error? The admin can del_enctype... */
109 krb5_warnx(context, "enctype %d already exists",
110 (int)etypes[j]);
111 goto out;
114 new_key_data[i] = *key;
117 for (i = 0; i < n_etypes; ++i) {
118 int n = princ.n_key_data + i;
119 krb5_keyblock keyblock;
121 memset(&new_key_data[n], 0, sizeof(new_key_data[n]));
122 new_key_data[n].key_data_ver = 2;
123 new_key_data[n].key_data_kvno = princ.kvno;
125 ret = krb5_generate_random_keyblock (context, etypes[i], &keyblock);
126 if (ret) {
127 krb5_warnx(context, "genernate enctype %d failed", (int)etypes[i]);
128 while (--i >= 0)
129 free(new_key_data[--n].key_data_contents[0]);
130 goto out;
133 /* key */
134 new_key_data[n].key_data_type[0] = etypes[i];
135 new_key_data[n].key_data_contents[0] = malloc(keyblock.keyvalue.length);
136 if (new_key_data[n].key_data_contents[0] == NULL) {
137 ret = ENOMEM;
138 krb5_warn(context, ret, "out of memory");
139 while (--i >= 0)
140 free(new_key_data[--n].key_data_contents[0]);
141 goto out;
143 new_key_data[n].key_data_length[0] = keyblock.keyvalue.length;
144 memcpy(new_key_data[n].key_data_contents[0],
145 keyblock.keyvalue.data,
146 keyblock.keyvalue.length);
147 krb5_free_keyblock_contents(context, &keyblock);
149 /* salt */
150 new_key_data[n].key_data_type[1] = KRB5_PW_SALT;
151 new_key_data[n].key_data_length[1] = 0;
152 new_key_data[n].key_data_contents[1] = NULL;
156 free (princ.key_data);
157 princ.n_key_data += n_etypes;
158 princ.key_data = new_key_data;
159 new_key_data = NULL;
161 ret = kadm5_modify_principal (kadm_handle, &princ, KADM5_KEY_DATA);
162 if (ret)
163 krb5_warn(context, ret, "kadm5_modify_principal");
164 out:
165 free(new_key_data);
166 krb5_free_principal (context, princ_ent);
167 kadm5_free_principal_ent(kadm_handle, &princ);
168 out2:
169 free (etypes);
170 return ret != 0;