Improved usability of grompp by rejecting more invalid input
[gromacs.git] / src / gromacs / gmxpreprocess / tests / readir.cpp
blobada23298276cec401f91e8567e7b2967fb076e6b
1 /*
2 * This file is part of the GROMACS molecular simulation package.
4 * Copyright (c) 2017,2018,2019, by the GROMACS development team, led by
5 * Mark Abraham, David van der Spoel, Berk Hess, and Erik Lindahl,
6 * and including many others, as listed in the AUTHORS file in the
7 * top-level source directory and at http://www.gromacs.org.
9 * GROMACS is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Lesser General Public License
11 * as published by the Free Software Foundation; either version 2.1
12 * of the License, or (at your option) any later version.
14 * GROMACS is distributed in the hope that it will be useful,
15 * but WITHOUT ANY WARRANTY; without even the implied warranty of
16 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
17 * Lesser General Public License for more details.
19 * You should have received a copy of the GNU Lesser General Public
20 * License along with GROMACS; if not, see
21 * http://www.gnu.org/licenses, or write to the Free Software Foundation,
22 * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
24 * If you want to redistribute modifications to GROMACS, please
25 * consider that scientific software is very special. Version
26 * control is crucial - bugs must be traceable. We will be happy to
27 * consider code for inclusion in the official distribution, but
28 * derived work must not be called official GROMACS. Details are found
29 * in the README & COPYING files - if they are missing, get the
30 * official version at http://www.gromacs.org.
32 * To help us fund GROMACS development, we humbly ask that you cite
33 * the research papers on the package. Check out http://www.gromacs.org.
35 /*! \internal \file
36 * \brief
37 * Test routines that parse mdp fields from grompp input and writes
38 * mdp back out.
40 * In particular these will provide test coverage as we refactor to
41 * use a new Options-based key-value-style mdp implementation to
42 * support a more modular mdrun.
44 * \author Mark Abraham <mark.j.abraham@gmail.com>
46 #include "gmxpre.h"
48 #include "gromacs/gmxpreprocess/readir.h"
50 #include <string>
52 #include <gtest/gtest.h>
54 #include "gromacs/fileio/warninp.h"
55 #include "gromacs/mdrun/mdmodules.h"
56 #include "gromacs/mdtypes/inputrec.h"
57 #include "gromacs/utility/cstringutil.h"
58 #include "gromacs/utility/stringutil.h"
59 #include "gromacs/utility/textreader.h"
60 #include "gromacs/utility/textwriter.h"
61 #include "gromacs/utility/unique_cptr.h"
63 #include "testutils/refdata.h"
64 #include "testutils/testfilemanager.h"
66 namespace gmx
68 namespace test
71 class GetIrTest : public ::testing::Test
73 public:
74 GetIrTest() : opts_(),
75 wi_(init_warning(FALSE, 0)), wiGuard_(wi_)
78 snew(opts_.include, STRLEN);
79 snew(opts_.define, STRLEN);
81 ~GetIrTest() override
83 done_inputrec_strings();
84 sfree(opts_.include);
85 sfree(opts_.define);
87 /*! \brief Test mdp reading and writing
89 * \todo Modernize read_inp and write_inp to use streams,
90 * which will make these tests run faster, because they don't
91 * use disk files. */
92 void runTest(const std::string &inputMdpFileContents)
94 auto inputMdpFilename = fileManager_.getTemporaryFilePath("input.mdp");
95 auto outputMdpFilename = fileManager_.getTemporaryFilePath("output.mdp");
97 TextWriter::writeFileFromString(inputMdpFilename, inputMdpFileContents);
99 get_ir(inputMdpFilename.c_str(), outputMdpFilename.c_str(),
100 &mdModules_, &ir_, &opts_, WriteMdpHeader::no, wi_);
102 // Now check
103 bool failure = warning_errors_exist(wi_);
104 TestReferenceData data;
105 TestReferenceChecker checker(data.rootChecker());
106 checker.checkBoolean(failure, "Error parsing mdp file");
107 warning_reset(wi_);
109 auto outputMdpContents = TextReader::readFileToString(outputMdpFilename);
110 checker.checkString(outputMdpContents, "OutputMdpFile");
113 TestFileManager fileManager_;
114 t_inputrec ir_;
115 MDModules mdModules_;
116 t_gromppopts opts_;
117 warninp_t wi_;
118 unique_cptr<warninp, free_warning> wiGuard_;
121 TEST_F(GetIrTest, HandlesDifferentKindsOfMdpLines)
123 const char *inputMdpFile[] = {
124 "; File to run my simulation",
125 "title = simulation",
126 "define = -DBOOLVAR -DVAR=VALUE",
127 ";",
128 "xtc_grps = System ; was Protein",
129 "include = -I/home/me/stuff",
131 "tau-t = 0.1 0.3",
132 "ref-t = ;290 290",
133 "tinit = 0.3",
134 "init_step = 0",
135 "nstcomm = 100",
136 "integrator = steep"
138 runTest(joinStrings(inputMdpFile, "\n"));
141 // This case is used often by SimulationRunner::useEmptyMdpFile (see
142 // comments there for explanation). When we remove the group scheme,
143 // that usage will have to disappear, and so can this test.
144 TEST_F(GetIrTest, HandlesOnlyCutoffScheme)
146 const char *inputMdpFile = "cutoff-scheme = Group\n";
147 runTest(inputMdpFile);
150 TEST_F(GetIrTest, RejectsNonCommentLineWithNoEquals)
152 const char *inputMdpFile = "title simulation";
153 EXPECT_DEATH_IF_SUPPORTED(runTest(inputMdpFile), "No '=' to separate");
156 TEST_F(GetIrTest, AcceptsKeyWithoutValue)
158 // Users are probably using lines like this
159 const char *inputMdpFile = "xtc_grps = ";
160 runTest(inputMdpFile);
163 TEST_F(GetIrTest, RejectsValueWithoutKey)
165 const char *inputMdpFile = "= -I/home/me/stuff";
166 EXPECT_DEATH_IF_SUPPORTED(runTest(inputMdpFile), "No .mdp parameter name was found");
169 TEST_F(GetIrTest, RejectsEmptyKeyAndEmptyValue)
171 const char *inputMdpFile = " = ";
172 EXPECT_DEATH_IF_SUPPORTED(runTest(inputMdpFile), "No .mdp parameter name or value was found");
175 TEST_F(GetIrTest, AcceptsDefineParametersWithValuesIncludingAssignment)
177 const char *inputMdpFile[] = {
178 "define = -DBOOL -DVAR=VALUE",
180 runTest(joinStrings(inputMdpFile, "\n"));
183 TEST_F(GetIrTest, AcceptsEmptyLines)
185 const char *inputMdpFile = "";
186 runTest(inputMdpFile);
189 // These tests observe how the electric-field keys behave, since they
190 // are currently the only ones using the new Options-style handling.
191 TEST_F(GetIrTest, AcceptsElectricField)
193 const char *inputMdpFile = "electric-field-x = 1.2 0 0 0";
194 runTest(inputMdpFile);
197 TEST_F(GetIrTest, AcceptsElectricFieldPulsed)
199 const char *inputMdpFile = "electric-field-y = 3.7 2.0 6.5 1.0";
200 runTest(inputMdpFile);
203 TEST_F(GetIrTest, AcceptsElectricFieldOscillating)
205 const char *inputMdpFile = "electric-field-z = 3.7 7.5 0 0";
206 runTest(inputMdpFile);
209 TEST_F(GetIrTest, RejectsDuplicateOldAndNewKeys)
211 const char *inputMdpFile[] = {"verlet-buffer-drift = 1.3", "verlet-buffer-tolerance = 2.7"};
212 EXPECT_DEATH_IF_SUPPORTED(runTest(joinStrings(inputMdpFile, "\n")), "A parameter is present with both");
215 TEST_F(GetIrTest, AcceptsImplicitSolventNo)
217 const char *inputMdpFile = "implicit-solvent = no";
218 runTest(inputMdpFile);
221 TEST_F(GetIrTest, RejectsImplicitSolventYes)
223 const char *inputMdpFile = "implicit-solvent = yes";
224 EXPECT_DEATH_IF_SUPPORTED(runTest(inputMdpFile), "Invalid enum");
227 TEST_F(GetIrTest, AcceptsMimic)
229 const char *inputMdpFile[] = {"integrator = mimic", "QMMM-grps = QMatoms"};
230 runTest(joinStrings(inputMdpFile, "\n"));
233 } // namespace test
234 } // namespace gmx