| commit | 46bdd627ff522193134d31bdfd3ac4e4fddb5975 | |
| author | Paul Eggert <eggert@cs.ucla.edu> | |
| Mon, 14 Sep 2020 01:40:08 +0000 (13 18:40 -0700) | ||
| committer | Paul Eggert <eggert@cs.ucla.edu> | |
| Mon, 14 Sep 2020 01:41:32 +0000 (13 18:41 -0700) | ||
| tree | abb4371ce67b0399151c36aeb3ccd57a48eefa3a | treesnapshot (tar.gz zip) |
| parent | 5332a21b1188224ecddbbe8b234b618d0b84437a | commitdiff |
dfa: avoid use of uninitialized constraint
* lib/dfa.c (merge_nfa_state): Do not initialize the constraint
to zero here.
(dfaoptimize): Do it here instead, via xcalloc. This prevents the
use of an uninitialized constraint by later code when ! (flags[i]
& OPT_QUEUED) means merge_nfa_state was not called to initialize
the constraint. Problem found by running 'valgrind src/grep -E
'(^| )*(a|b)*(c|d)*( |$)' < /dev/null' on Ubuntu 18.04.5 x86-64.
* lib/dfa.c (merge_nfa_state): Do not initialize the constraint
to zero here.
(dfaoptimize): Do it here instead, via xcalloc. This prevents the
use of an uninitialized constraint by later code when ! (flags[i]
& OPT_QUEUED) means merge_nfa_state was not called to initialize
the constraint. Problem found by running 'valgrind src/grep -E
'(^| )*(a|b)*(c|d)*( |$)' < /dev/null' on Ubuntu 18.04.5 x86-64.
| ChangeLog | diffblobblamehistory | |
| lib/dfa.c | diffblobblamehistory |