convert refresh_index to take struct pathspec
[git/jrn.git] / builtin / add.c
blobf5d6a33a6a4a9b0c8459bcfeafd8bf17d469db7e
1 /*
2 * "git add" builtin command
4 * Copyright (C) 2006 Linus Torvalds
5 */
6 #include "cache.h"
7 #include "builtin.h"
8 #include "dir.h"
9 #include "pathspec.h"
10 #include "exec_cmd.h"
11 #include "cache-tree.h"
12 #include "run-command.h"
13 #include "parse-options.h"
14 #include "diff.h"
15 #include "diffcore.h"
16 #include "revision.h"
17 #include "bulk-checkin.h"
19 static const char * const builtin_add_usage[] = {
20 N_("git add [options] [--] <pathspec>..."),
21 NULL
23 static int patch_interactive, add_interactive, edit_interactive;
24 static int take_worktree_changes;
26 struct update_callback_data {
27 int flags;
28 int add_errors;
29 const char *implicit_dot;
30 size_t implicit_dot_len;
32 /* only needed for 2.0 transition preparation */
33 int warn_add_would_remove;
36 static const char *option_with_implicit_dot;
37 static const char *short_option_with_implicit_dot;
39 static void warn_pathless_add(void)
41 static int shown;
42 assert(option_with_implicit_dot && short_option_with_implicit_dot);
44 if (shown)
45 return;
46 shown = 1;
49 * To be consistent with "git add -p" and most Git
50 * commands, we should default to being tree-wide, but
51 * this is not the original behavior and can't be
52 * changed until users trained themselves not to type
53 * "git add -u" or "git add -A". For now, we warn and
54 * keep the old behavior. Later, the behavior can be changed
55 * to tree-wide, keeping the warning for a while, and
56 * eventually we can drop the warning.
58 warning(_("The behavior of 'git add %s (or %s)' with no path argument from a\n"
59 "subdirectory of the tree will change in Git 2.0 and should not be used anymore.\n"
60 "To add content for the whole tree, run:\n"
61 "\n"
62 " git add %s :/\n"
63 " (or git add %s :/)\n"
64 "\n"
65 "To restrict the command to the current directory, run:\n"
66 "\n"
67 " git add %s .\n"
68 " (or git add %s .)\n"
69 "\n"
70 "With the current Git version, the command is restricted to "
71 "the current directory.\n"
72 ""),
73 option_with_implicit_dot, short_option_with_implicit_dot,
74 option_with_implicit_dot, short_option_with_implicit_dot,
75 option_with_implicit_dot, short_option_with_implicit_dot);
78 static int fix_unmerged_status(struct diff_filepair *p,
79 struct update_callback_data *data)
81 if (p->status != DIFF_STATUS_UNMERGED)
82 return p->status;
83 if (!(data->flags & ADD_CACHE_IGNORE_REMOVAL) && !p->two->mode)
85 * This is not an explicit add request, and the
86 * path is missing from the working tree (deleted)
88 return DIFF_STATUS_DELETED;
89 else
91 * Either an explicit add request, or path exists
92 * in the working tree. An attempt to explicitly
93 * add a path that does not exist in the working tree
94 * will be caught as an error by the caller immediately.
96 return DIFF_STATUS_MODIFIED;
99 static const char *add_would_remove_warning = N_(
100 "You ran 'git add' with neither '-A (--all)' or '--ignore-removal',\n"
101 "whose behaviour will change in Git 2.0 with respect to paths you removed.\n"
102 "Paths like '%s' that are\n"
103 "removed from your working tree are ignored with this version of Git.\n"
104 "\n"
105 "* 'git add --ignore-removal <pathspec>', which is the current default,\n"
106 " ignores paths you removed from your working tree.\n"
107 "\n"
108 "* 'git add --all <pathspec>' will let you also record the removals.\n"
109 "\n"
110 "Run 'git status' to check the paths you removed from your working tree.\n");
112 static void warn_add_would_remove(const char *path)
114 warning(_(add_would_remove_warning), path);
117 static void update_callback(struct diff_queue_struct *q,
118 struct diff_options *opt, void *cbdata)
120 int i;
121 struct update_callback_data *data = cbdata;
122 const char *implicit_dot = data->implicit_dot;
123 size_t implicit_dot_len = data->implicit_dot_len;
125 for (i = 0; i < q->nr; i++) {
126 struct diff_filepair *p = q->queue[i];
127 const char *path = p->one->path;
129 * Check if "git add -A" or "git add -u" was run from a
130 * subdirectory with a modified file outside that directory,
131 * and warn if so.
133 * "git add -u" will behave like "git add -u :/" instead of
134 * "git add -u ." in the future. This warning prepares for
135 * that change.
137 if (implicit_dot &&
138 strncmp_icase(path, implicit_dot, implicit_dot_len)) {
139 warn_pathless_add();
140 continue;
142 switch (fix_unmerged_status(p, data)) {
143 default:
144 die(_("unexpected diff status %c"), p->status);
145 case DIFF_STATUS_MODIFIED:
146 case DIFF_STATUS_TYPE_CHANGED:
147 if (add_file_to_index(&the_index, path, data->flags)) {
148 if (!(data->flags & ADD_CACHE_IGNORE_ERRORS))
149 die(_("updating files failed"));
150 data->add_errors++;
152 break;
153 case DIFF_STATUS_DELETED:
154 if (data->warn_add_would_remove) {
155 warn_add_would_remove(path);
156 data->warn_add_would_remove = 0;
158 if (data->flags & ADD_CACHE_IGNORE_REMOVAL)
159 break;
160 if (!(data->flags & ADD_CACHE_PRETEND))
161 remove_file_from_index(&the_index, path);
162 if (data->flags & (ADD_CACHE_PRETEND|ADD_CACHE_VERBOSE))
163 printf(_("remove '%s'\n"), path);
164 break;
169 static void update_files_in_cache(const char *prefix, const char **pathspec,
170 struct update_callback_data *data)
172 struct rev_info rev;
174 init_revisions(&rev, prefix);
175 setup_revisions(0, NULL, &rev, NULL);
176 init_pathspec(&rev.prune_data, pathspec);
177 rev.diffopt.output_format = DIFF_FORMAT_CALLBACK;
178 rev.diffopt.format_callback = update_callback;
179 rev.diffopt.format_callback_data = data;
180 rev.max_count = 0; /* do not compare unmerged paths with stage #2 */
181 run_diff_files(&rev, DIFF_RACY_IS_MODIFIED);
184 int add_files_to_cache(const char *prefix, const char **pathspec, int flags)
186 struct update_callback_data data;
188 memset(&data, 0, sizeof(data));
189 data.flags = flags;
190 update_files_in_cache(prefix, pathspec, &data);
191 return !!data.add_errors;
194 #define WARN_IMPLICIT_DOT (1u << 0)
195 static char *prune_directory(struct dir_struct *dir, const char **pathspec,
196 int prefix, unsigned flag)
198 char *seen;
199 int i, specs;
200 struct dir_entry **src, **dst;
202 for (specs = 0; pathspec[specs]; specs++)
203 /* nothing */;
204 seen = xcalloc(specs, 1);
206 src = dst = dir->entries;
207 i = dir->nr;
208 while (--i >= 0) {
209 struct dir_entry *entry = *src++;
210 if (match_pathspec(pathspec, entry->name, entry->len,
211 prefix, seen))
212 *dst++ = entry;
213 else if (flag & WARN_IMPLICIT_DOT)
215 * "git add -A" was run from a subdirectory with a
216 * new file outside that directory.
218 * "git add -A" will behave like "git add -A :/"
219 * instead of "git add -A ." in the future.
220 * Warn about the coming behavior change.
222 warn_pathless_add();
224 dir->nr = dst - dir->entries;
225 add_pathspec_matches_against_index(pathspec, seen, specs);
226 return seen;
229 static void refresh(int verbose, const struct pathspec *pathspec)
231 char *seen;
232 int i;
234 seen = xcalloc(pathspec->nr, 1);
235 refresh_index(&the_index, verbose ? REFRESH_IN_PORCELAIN : REFRESH_QUIET,
236 pathspec, seen, _("Unstaged changes after refreshing the index:"));
237 for (i = 0; i < pathspec->nr; i++) {
238 if (!seen[i])
239 die(_("pathspec '%s' did not match any files"),
240 pathspec->items[i].match);
242 free(seen);
245 int run_add_interactive(const char *revision, const char *patch_mode,
246 const struct pathspec *pathspec)
248 int status, ac, i;
249 const char **args;
251 args = xcalloc(sizeof(const char *), (pathspec->nr + 6));
252 ac = 0;
253 args[ac++] = "add--interactive";
254 if (patch_mode)
255 args[ac++] = patch_mode;
256 if (revision)
257 args[ac++] = revision;
258 args[ac++] = "--";
259 for (i = 0; i < pathspec->nr; i++)
260 /* pass original pathspec, to be re-parsed */
261 args[ac++] = pathspec->items[i].original;
263 status = run_command_v_opt(args, RUN_GIT_CMD);
264 free(args);
265 return status;
268 int interactive_add(int argc, const char **argv, const char *prefix, int patch)
270 struct pathspec pathspec;
273 * git-add--interactive itself does not parse pathspec. It
274 * simply passes the pathspec to other builtin commands. Let's
275 * hope all of them support all magic, or we'll need to limit
276 * the magic here.
278 parse_pathspec(&pathspec, PATHSPEC_ALL_MAGIC & ~PATHSPEC_FROMTOP,
279 PATHSPEC_PREFER_FULL |
280 PATHSPEC_SYMLINK_LEADING_PATH |
281 PATHSPEC_PREFIX_ORIGIN,
282 prefix, argv);
284 return run_add_interactive(NULL,
285 patch ? "--patch" : NULL,
286 &pathspec);
289 static int edit_patch(int argc, const char **argv, const char *prefix)
291 char *file = git_pathdup("ADD_EDIT.patch");
292 const char *apply_argv[] = { "apply", "--recount", "--cached",
293 NULL, NULL };
294 struct child_process child;
295 struct rev_info rev;
296 int out;
297 struct stat st;
299 apply_argv[3] = file;
301 git_config(git_diff_basic_config, NULL); /* no "diff" UI options */
303 if (read_cache() < 0)
304 die (_("Could not read the index"));
306 init_revisions(&rev, prefix);
307 rev.diffopt.context = 7;
309 argc = setup_revisions(argc, argv, &rev, NULL);
310 rev.diffopt.output_format = DIFF_FORMAT_PATCH;
311 DIFF_OPT_SET(&rev.diffopt, IGNORE_DIRTY_SUBMODULES);
312 out = open(file, O_CREAT | O_WRONLY, 0666);
313 if (out < 0)
314 die (_("Could not open '%s' for writing."), file);
315 rev.diffopt.file = xfdopen(out, "w");
316 rev.diffopt.close_file = 1;
317 if (run_diff_files(&rev, 0))
318 die (_("Could not write patch"));
320 launch_editor(file, NULL, NULL);
322 if (stat(file, &st))
323 die_errno(_("Could not stat '%s'"), file);
324 if (!st.st_size)
325 die(_("Empty patch. Aborted."));
327 memset(&child, 0, sizeof(child));
328 child.git_cmd = 1;
329 child.argv = apply_argv;
330 if (run_command(&child))
331 die (_("Could not apply '%s'"), file);
333 unlink(file);
334 free(file);
335 return 0;
338 static struct lock_file lock_file;
340 static const char ignore_error[] =
341 N_("The following paths are ignored by one of your .gitignore files:\n");
343 static int verbose, show_only, ignored_too, refresh_only;
344 static int ignore_add_errors, intent_to_add, ignore_missing;
346 #define ADDREMOVE_DEFAULT 0 /* Change to 1 in Git 2.0 */
347 static int addremove = ADDREMOVE_DEFAULT;
348 static int addremove_explicit = -1; /* unspecified */
350 static int ignore_removal_cb(const struct option *opt, const char *arg, int unset)
352 /* if we are told to ignore, we are not adding removals */
353 *(int *)opt->value = !unset ? 0 : 1;
354 return 0;
357 static struct option builtin_add_options[] = {
358 OPT__DRY_RUN(&show_only, N_("dry run")),
359 OPT__VERBOSE(&verbose, N_("be verbose")),
360 OPT_GROUP(""),
361 OPT_BOOL('i', "interactive", &add_interactive, N_("interactive picking")),
362 OPT_BOOL('p', "patch", &patch_interactive, N_("select hunks interactively")),
363 OPT_BOOL('e', "edit", &edit_interactive, N_("edit current diff and apply")),
364 OPT__FORCE(&ignored_too, N_("allow adding otherwise ignored files")),
365 OPT_BOOL('u', "update", &take_worktree_changes, N_("update tracked files")),
366 OPT_BOOL('N', "intent-to-add", &intent_to_add, N_("record only the fact that the path will be added later")),
367 OPT_BOOL('A', "all", &addremove_explicit, N_("add changes from all tracked and untracked files")),
368 { OPTION_CALLBACK, 0, "ignore-removal", &addremove_explicit,
369 NULL /* takes no arguments */,
370 N_("ignore paths removed in the working tree (same as --no-all)"),
371 PARSE_OPT_NOARG, ignore_removal_cb },
372 OPT_BOOL( 0 , "refresh", &refresh_only, N_("don't add, only refresh the index")),
373 OPT_BOOL( 0 , "ignore-errors", &ignore_add_errors, N_("just skip files which cannot be added because of errors")),
374 OPT_BOOL( 0 , "ignore-missing", &ignore_missing, N_("check if - even missing - files are ignored in dry run")),
375 OPT_END(),
378 static int add_config(const char *var, const char *value, void *cb)
380 if (!strcmp(var, "add.ignoreerrors") ||
381 !strcmp(var, "add.ignore-errors")) {
382 ignore_add_errors = git_config_bool(var, value);
383 return 0;
385 return git_default_config(var, value, cb);
388 static int add_files(struct dir_struct *dir, int flags)
390 int i, exit_status = 0;
392 if (dir->ignored_nr) {
393 fprintf(stderr, _(ignore_error));
394 for (i = 0; i < dir->ignored_nr; i++)
395 fprintf(stderr, "%s\n", dir->ignored[i]->name);
396 fprintf(stderr, _("Use -f if you really want to add them.\n"));
397 die(_("no files added"));
400 for (i = 0; i < dir->nr; i++)
401 if (add_file_to_cache(dir->entries[i]->name, flags)) {
402 if (!ignore_add_errors)
403 die(_("adding files failed"));
404 exit_status = 1;
406 return exit_status;
409 int cmd_add(int argc, const char **argv, const char *prefix)
411 int exit_status = 0;
412 int newfd;
413 struct pathspec pathspec;
414 struct dir_struct dir;
415 int flags;
416 int add_new_files;
417 int require_pathspec;
418 char *seen = NULL;
419 int implicit_dot = 0;
420 struct update_callback_data update_data;
422 git_config(add_config, NULL);
424 argc = parse_options(argc, argv, prefix, builtin_add_options,
425 builtin_add_usage, PARSE_OPT_KEEP_ARGV0);
426 if (patch_interactive)
427 add_interactive = 1;
428 if (add_interactive)
429 exit(interactive_add(argc - 1, argv + 1, prefix, patch_interactive));
431 if (edit_interactive)
432 return(edit_patch(argc, argv, prefix));
433 argc--;
434 argv++;
436 if (0 <= addremove_explicit)
437 addremove = addremove_explicit;
438 else if (take_worktree_changes && ADDREMOVE_DEFAULT)
439 addremove = 0; /* "-u" was given but not "-A" */
441 if (addremove && take_worktree_changes)
442 die(_("-A and -u are mutually incompatible"));
445 * Warn when "git add pathspec..." was given without "-u" or "-A"
446 * and pathspec... covers a removed path.
448 memset(&update_data, 0, sizeof(update_data));
449 if (!take_worktree_changes && addremove_explicit < 0)
450 update_data.warn_add_would_remove = 1;
452 if (!take_worktree_changes && addremove_explicit < 0 && argc)
454 * Turn "git add pathspec..." to "git add -A pathspec..."
455 * in Git 2.0 but not yet
457 ; /* addremove = 1; */
459 if (!show_only && ignore_missing)
460 die(_("Option --ignore-missing can only be used together with --dry-run"));
461 if (addremove) {
462 option_with_implicit_dot = "--all";
463 short_option_with_implicit_dot = "-A";
465 if (take_worktree_changes) {
466 option_with_implicit_dot = "--update";
467 short_option_with_implicit_dot = "-u";
469 if (option_with_implicit_dot && !argc) {
470 static const char *here[2] = { ".", NULL };
471 argc = 1;
472 argv = here;
473 implicit_dot = 1;
476 add_new_files = !take_worktree_changes && !refresh_only;
477 require_pathspec = !take_worktree_changes;
479 newfd = hold_locked_index(&lock_file, 1);
481 flags = ((verbose ? ADD_CACHE_VERBOSE : 0) |
482 (show_only ? ADD_CACHE_PRETEND : 0) |
483 (intent_to_add ? ADD_CACHE_INTENT : 0) |
484 (ignore_add_errors ? ADD_CACHE_IGNORE_ERRORS : 0) |
485 (!(addremove || take_worktree_changes)
486 ? ADD_CACHE_IGNORE_REMOVAL : 0)) |
487 (implicit_dot ? ADD_CACHE_IMPLICIT_DOT : 0);
489 if (require_pathspec && argc == 0) {
490 fprintf(stderr, _("Nothing specified, nothing added.\n"));
491 fprintf(stderr, _("Maybe you wanted to say 'git add .'?\n"));
492 return 0;
495 if (read_cache() < 0)
496 die(_("index file corrupt"));
499 * Check the "pathspec '%s' did not match any files" block
500 * below before enabling new magic.
502 parse_pathspec(&pathspec, 0,
503 PATHSPEC_PREFER_FULL |
504 PATHSPEC_SYMLINK_LEADING_PATH |
505 PATHSPEC_STRIP_SUBMODULE_SLASH_EXPENSIVE,
506 prefix, argv);
508 if (add_new_files) {
509 int baselen;
511 /* Set up the default git porcelain excludes */
512 memset(&dir, 0, sizeof(dir));
513 if (!ignored_too) {
514 dir.flags |= DIR_COLLECT_IGNORED;
515 setup_standard_excludes(&dir);
518 /* This picks up the paths that are not tracked */
519 baselen = fill_directory(&dir, implicit_dot ? NULL : pathspec.raw);
520 if (pathspec.nr)
521 seen = prune_directory(&dir, pathspec.raw, baselen,
522 implicit_dot ? WARN_IMPLICIT_DOT : 0);
525 if (refresh_only) {
526 refresh(verbose, &pathspec);
527 goto finish;
529 if (implicit_dot && prefix)
530 refresh_cache(REFRESH_QUIET);
532 if (pathspec.nr) {
533 int i;
535 if (!seen)
536 seen = find_pathspecs_matching_against_index(pathspec.raw);
539 * file_exists() assumes exact match
541 GUARD_PATHSPEC(&pathspec, PATHSPEC_FROMTOP);
543 for (i = 0; pathspec.raw[i]; i++) {
544 if (!seen[i] && pathspec.raw[i][0]
545 && !file_exists(pathspec.raw[i])) {
546 if (ignore_missing) {
547 int dtype = DT_UNKNOWN;
548 if (is_excluded(&dir, pathspec.raw[i], &dtype))
549 dir_add_ignored(&dir, pathspec.raw[i], strlen(pathspec.raw[i]));
550 } else
551 die(_("pathspec '%s' did not match any files"),
552 pathspec.raw[i]);
555 free(seen);
558 plug_bulk_checkin();
560 if ((flags & ADD_CACHE_IMPLICIT_DOT) && prefix) {
562 * Check for modified files throughout the worktree so
563 * update_callback has a chance to warn about changes
564 * outside the cwd.
566 update_data.implicit_dot = prefix;
567 update_data.implicit_dot_len = strlen(prefix);
568 free_pathspec(&pathspec);
569 memset(&pathspec, 0, sizeof(pathspec));
571 update_data.flags = flags & ~ADD_CACHE_IMPLICIT_DOT;
572 update_files_in_cache(prefix, pathspec.raw, &update_data);
574 exit_status |= !!update_data.add_errors;
575 if (add_new_files)
576 exit_status |= add_files(&dir, flags);
578 unplug_bulk_checkin();
580 finish:
581 if (active_cache_changed) {
582 if (write_cache(newfd, active_cache, active_nr) ||
583 commit_locked_index(&lock_file))
584 die(_("Unable to write new index file"));
587 return exit_status;