| commit | dc342a25d1b48cb53448fe0e5dde578edce3122c | |
| author | Jonathan Nieder <jrnieder@gmail.com> | |
| Thu, 24 Jan 2013 23:21:46 +0000 (24 15:21 -0800) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Fri, 25 Jan 2013 18:41:49 +0000 (25 10:41 -0800) | ||
| tree | 0d066af74121e09b9443fc3bbde4292b2f635dde | treesnapshot (tar.gz zip) |
| parent | 7e2010537e96d0a1144520222f20ba1dc3d61441 | commitdiff |
ident: do not drop username when reading from /etc/mailname
An earlier conversion from fgets() to strbuf_getline() in the
codepath to read from /etc/mailname to learn the default host-part
of the ident e-mail address forgot that strbuf_getline() stores the
line at the beginning of the buffer just like fgets().
The "username@" the caller has prepared in the strbuf, expecting the
function to append the host-part to it, was lost because of this.
Reported-by: Mihai Rusu <dizzy@google.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Acked-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
An earlier conversion from fgets() to strbuf_getline() in the
codepath to read from /etc/mailname to learn the default host-part
of the ident e-mail address forgot that strbuf_getline() stores the
line at the beginning of the buffer just like fgets().
The "username@" the caller has prepared in the strbuf, expecting the
function to append the host-part to it, was lost because of this.
Reported-by: Mihai Rusu <dizzy@google.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Acked-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| ident.c | diffblobblamehistory |