| commit | e6e2bd6201d32342df7a713c847161ab296885ea | |
| author | Shawn O. Pearce <spearce@spearce.org> | |
| Sun, 14 Jan 2007 06:01:49 +0000 (14 01:01 -0500) | ||
| committer | Junio C Hamano <junkio@cox.net> | |
| Sun, 14 Jan 2007 08:42:41 +0000 (14 00:42 -0800) | ||
| tree | 1d1e4220abd26adccf9476fdeaa8ae358b27d506 | treesnapshot (tar.gz zip) |
| parent | 38434f2eed45f42ed706d07564079c23ee686511 | commitdiff |
Remove read_or_die in favor of better error messages.
Originally I introduced read_or_die for the purpose of reading
the pack header and trailer, and I was too lazy to print proper
error messages.
Linus Torvalds <torvalds@osdl.org>:
> For a read error, at the very least you have to say WHICH FILE
> couldn't be read, because it's usually a matter of some file just
> being too short, not some system-wide problem.
and of course Linus is right. Make it so.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
Originally I introduced read_or_die for the purpose of reading
the pack header and trailer, and I was too lazy to print proper
error messages.
Linus Torvalds <torvalds@osdl.org>:
> For a read error, at the very least you have to say WHICH FILE
> couldn't be read, because it's usually a matter of some file just
> being too short, not some system-wide problem.
and of course Linus is right. Make it so.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
| cache.h | diffblobblamehistory | |
| sha1_file.c | diffblobblamehistory | |
| write_or_die.c | diffblobblamehistory |