| commit | bf82940dbf12f066ba42a2a03a5bb626ba22c067 | |
| author | Thomas Rast <trast@student.ethz.ch> | |
| Sat, 17 Jan 2009 16:29:46 +0000 (17 17:29 +0100) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Sat, 17 Jan 2009 18:43:24 +0000 (17 10:43 -0800) | ||
| tree | 641c90caf5c9810fdb009d9ffa25be36c94e9adb | treesnapshot (tar.gz zip) |
| parent | 2b6a5417d750d086d1da906e46de2b3ad8df6753 | commitdiff |
color-words: enable REG_NEWLINE to help user
We silently truncate a match at the newline, which may lead to
unexpected behaviour, e.g., when matching "<[^>]*>" against
<foo
bar>
since then "<foo" becomes a word (and "bar>" doesn't!) even though the
regex said only angle-bracket-delimited things can be words.
To alleviate the problem slightly, use REG_NEWLINE so that negated
classes can't match a newline. Of course newlines can still be
matched explicitly.
Signed-off-by: Thomas Rast <trast@student.ethz.ch>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
We silently truncate a match at the newline, which may lead to
unexpected behaviour, e.g., when matching "<[^>]*>" against
<foo
bar>
since then "<foo" becomes a word (and "bar>" doesn't!) even though the
regex said only angle-bracket-delimited things can be words.
To alleviate the problem slightly, use REG_NEWLINE so that negated
classes can't match a newline. Of course newlines can still be
matched explicitly.
Signed-off-by: Thomas Rast <trast@student.ethz.ch>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| diff.c | diffblobblamehistory |