Do not use memcmp(sha1_1, sha1_2, 20) with hardcoded length.
commita89fccd28197fa179828c8596791ff16e2268d20
authorDavid Rientjes <rientjes@google.com>
Thu, 17 Aug 2006 18:54:57 +0000 (17 11:54 -0700)
committerJunio C Hamano <junkio@cox.net>
Thu, 17 Aug 2006 21:23:53 +0000 (17 14:23 -0700)
tree4a6c2b256a986fc221c0e1d5fa7d910f3b31eee8
parentd4baf9eaf47ea1ba204f1ab5ecd22326913dd081
Do not use memcmp(sha1_1, sha1_2, 20) with hardcoded length.

Introduces global inline:

hashcmp(const unsigned char *sha1, const unsigned char *sha2)

Uses memcmp for comparison and returns the result based on the length of
the hash name (a future runtime decision).

Acked-by: Alex Riesen <raa.lkml@gmail.com>
Signed-off-by: David Rientjes <rientjes@google.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
31 files changed:
builtin-commit-tree.c
builtin-diff-stages.c
builtin-diff.c
builtin-pack-objects.c
builtin-show-branch.c
builtin-unpack-objects.c
builtin-update-index.c
cache.h
combine-diff.c
commit.c
convert-objects.c
diff-lib.c
diff.c
diffcore-break.c
diffcore-rename.c
dump-cache-tree.c
http-fetch.c
http-push.c
index-pack.c
merge-tree.c
object.c
pack-check.c
pack-redundant.c
read-cache.c
refs.c
send-pack.c
sha1_file.c
sha1_name.c
ssh-fetch.c
tree-diff.c
unpack-trees.c