| commit | 8ed9ebe27ae70f634f4f734aa581ca796ccf906a | |
| author | Junio C Hamano <gitster@pobox.com> | |
| Wed, 14 Oct 2009 18:51:03 +0000 (14 11:51 -0700) | ||
| committer | Johannes Schindelin <johannes.schindelin@gmx.de> | |
| Thu, 22 Oct 2009 16:55:06 +0000 (22 18:55 +0200) | ||
| tree | 84113ab94af2a8d761a325136a22eb2f3222c84c | treesnapshot (tar.gz zip) |
| parent | 127aa63757870526b106c045310a3b6c4cee0324 | commitdiff |
CRLF in info/grafts causes parse error
"Yann Dirson" <ydirson@linagora.com> writes:
> When creating an info/grafts under windows, one typically gets a CRLF file.
> Then:
>
> * gitk loudly complains about "bad graft data"
> * "git log > /dev/null" does not report any problem
> * "git log > foo" does report the problem on sdterr, but exit code is still 0
>
> Recreating the graft as a LF file (eg with "echo" or "printf") causes the
> graft to be properly interpreted.
I do not see any reason to forbid trailing CR at the end of the line (for
that matter, any trailing whitespaces) in the said file.
How about doing this?
commit.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
"Yann Dirson" <ydirson@linagora.com> writes:
> When creating an info/grafts under windows, one typically gets a CRLF file.
> Then:
>
> * gitk loudly complains about "bad graft data"
> * "git log > /dev/null" does not report any problem
> * "git log > foo" does report the problem on sdterr, but exit code is still 0
>
> Recreating the graft as a LF file (eg with "echo" or "printf") causes the
> graft to be properly interpreted.
I do not see any reason to forbid trailing CR at the end of the line (for
that matter, any trailing whitespaces) in the said file.
How about doing this?
commit.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
| commit.c | diffblobblamehistory |