| commit | 8338f771fe9720766dfcb25b6dca58832e24a0fd | |
| author | Erik Faye-Lund <kusmabite@gmail.com> | |
| Tue, 8 May 2012 17:22:33 +0000 (8 19:22 +0200) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Tue, 8 May 2012 17:36:55 +0000 (8 10:36 -0700) | ||
| tree | 6bb1594c45fffde796364ee577ff34cf548fee17 | treesnapshot (tar.gz zip) |
| parent | abe199808c6586047fb7255b80e3d17ffc26bf6c | commitdiff |
checkout: do not corrupt HEAD on empty repo
In abe1998 ("git checkout -b: allow switching out of an unborn
branch"), a code-path overly-optimisticly assumed that a
branch-name was specified. This is not always the case, and as
a result a NULL-pointer was attempted printed to .git/HEAD.
This could lead to at least two different failure modes:
1) vsnprintf formated the NULL-string as something useful (e.g
"(null)")
2) vsnprintf crashed
Neither were very convenient for formatting a new HEAD-reference.
To fix this, reintroduce some strictness so we only take this
new codepath if a banch-name was specified.
Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
In abe1998 ("git checkout -b: allow switching out of an unborn
branch"), a code-path overly-optimisticly assumed that a
branch-name was specified. This is not always the case, and as
a result a NULL-pointer was attempted printed to .git/HEAD.
This could lead to at least two different failure modes:
1) vsnprintf formated the NULL-string as something useful (e.g
"(null)")
2) vsnprintf crashed
Neither were very convenient for formatting a new HEAD-reference.
To fix this, reintroduce some strictness so we only take this
new codepath if a banch-name was specified.
Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/checkout.c | diffblobblamehistory | |
| t/t2015-checkout-unborn.sh | diffblobblamehistory |