| commit | 829a1c616967176ccd859c18a6e8ca0dda77f75a | |
| author | Jeff King <peff@peff.net> | |
| Mon, 9 Jan 2012 22:55:42 +0000 (9 17:55 -0500) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Mon, 9 Jan 2012 23:15:28 +0000 (9 15:15 -0800) | ||
| tree | 40d782c981b910f9bcbb78881014fe92f66a3d38 | treesnapshot (tar.gz zip) |
| parent | 5f4d133fca7eb3cb750f056a6fd0281ba06cd12f | commitdiff |
send-email: multiedit is a boolean config option
The sendemail.multiedit variable is meant to be a boolean.
However, it is not marked as such in the code, which means
we store its value literally. Thus in the do_edit function,
perl ends up coercing it to a boolean value according to
perl rules, not git rules. This works for "0", but "false",
"no", or "off" will erroneously be interpreted as true.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
The sendemail.multiedit variable is meant to be a boolean.
However, it is not marked as such in the code, which means
we store its value literally. Thus in the do_edit function,
perl ends up coercing it to a boolean value according to
perl rules, not git rules. This works for "0", but "false",
"no", or "off" will erroneously be interpreted as true.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| git-send-email.perl | diffblobblamehistory |