| commit | 29f4ad867cd15f4029c280c417f4a0866d5229a9 | |
| author | Yann Dirson <ydirson@altern.org> | |
| Fri, 23 Jun 2006 22:04:05 +0000 (24 00:04 +0200) | ||
| committer | Junio C Hamano <junkio@cox.net> | |
| Sun, 25 Jun 2006 07:35:52 +0000 (25 00:35 -0700) | ||
| tree | 5b714456a96bc2fd121452e8a1b77f47fada270c | treesnapshot (tar.gz zip) |
| parent | 817151e61a74241df5b5dd206d27086283f28b84 | commitdiff |
git-commit: filter out log message lines only when editor was run.
The current behaviour strips out lines starting with a # even when fed
through stdin or -m. This is particularly bad when importing history from
another SCM (tailor 0.9.23 uses git-commit). In the best cases all lines
are stripped and the commit fails with a confusing "empty log message"
error, but in many cases the commit is done, with loss of information.
Note that it is quite peculiar to just have "#" handled as a leading
comment char here. One commonly meet CVS: or CG: or STG: as prefixes, and
using GIT: would be more robust as well as consistent with other commit
tools. However, that would break any tool relying on the # (if any).
Signed-off-by: Yann Dirson <ydirson@altern.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
The current behaviour strips out lines starting with a # even when fed
through stdin or -m. This is particularly bad when importing history from
another SCM (tailor 0.9.23 uses git-commit). In the best cases all lines
are stripped and the commit fails with a confusing "empty log message"
error, but in many cases the commit is done, with loss of information.
Note that it is quite peculiar to just have "#" handled as a leading
comment char here. One commonly meet CVS: or CG: or STG: as prefixes, and
using GIT: would be more robust as well as consistent with other commit
tools. However, that would break any tool relying on the # (if any).
Signed-off-by: Yann Dirson <ydirson@altern.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
| git-commit.sh | diffblobblamehistory |