| commit | 289796dd29dd656734cfd59b657deb943a71cf6a | |
| author | Don Zickus <dzickus@redhat.com> | |
| Thu, 14 Aug 2008 15:35:42 +0000 (14 11:35 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Tue, 19 Aug 2008 05:05:02 +0000 (18 22:05 -0700) | ||
| tree | 7ff6e57895095b4ef499bd18c8d665e43a457103 | treesnapshot (tar.gz zip) |
| parent | dba9194a49452b5f093b96872e19c91b50e526aa | commitdiff |
mailinfo: re-fix MIME multipart boundary parsing
Recent changes to is_multipart_boundary() caused git-mailinfo to segfault.
The reason was after handling the end of the boundary the code tried to look
for another boundary. Because the boundary list was empty, dereferencing
the pointer to the top of the boundary caused the program to go boom.
The fix is to check to see if the list is empty and if so go on its merry
way instead of looking for another boundary.
I also fixed a couple of increments and decrements that didn't look correct
relating to content_top.
The boundary test case was updated to catch future problems like this again.
Signed-off-by: Don Zickus <dzickus@redhat.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Recent changes to is_multipart_boundary() caused git-mailinfo to segfault.
The reason was after handling the end of the boundary the code tried to look
for another boundary. Because the boundary list was empty, dereferencing
the pointer to the top of the boundary caused the program to go boom.
The fix is to check to see if the list is empty and if so go on its merry
way instead of looking for another boundary.
I also fixed a couple of increments and decrements that didn't look correct
relating to content_top.
The boundary test case was updated to catch future problems like this again.
Signed-off-by: Don Zickus <dzickus@redhat.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin-mailinfo.c | diffblobblamehistory | |
| t/t5100/sample.mbox | diffblobblamehistory |