4 #include "run-command.h"
7 #include "gpg-interface.h"
12 static char *configured_signing_key
;
13 static const char *ssh_default_key_command
, *ssh_allowed_signers
, *ssh_revocation_file
;
14 static enum signature_trust_level configured_min_trust_level
= TRUST_UNDEFINED
;
19 const char **verify_args
;
21 int (*verify_signed_buffer
)(struct signature_check
*sigc
,
22 struct gpg_format
*fmt
,
23 const char *signature
,
24 size_t signature_size
);
25 int (*sign_buffer
)(struct strbuf
*buffer
, struct strbuf
*signature
,
26 const char *signing_key
);
27 const char *(*get_default_key
)(void);
28 const char *(*get_key_id
)(void);
31 static const char *openpgp_verify_args
[] = {
32 "--keyid-format=long",
35 static const char *openpgp_sigs
[] = {
36 "-----BEGIN PGP SIGNATURE-----",
37 "-----BEGIN PGP MESSAGE-----",
41 static const char *x509_verify_args
[] = {
44 static const char *x509_sigs
[] = {
45 "-----BEGIN SIGNED MESSAGE-----",
49 static const char *ssh_verify_args
[] = { NULL
};
50 static const char *ssh_sigs
[] = {
51 "-----BEGIN SSH SIGNATURE-----",
55 static int verify_gpg_signed_buffer(struct signature_check
*sigc
,
56 struct gpg_format
*fmt
,
57 const char *signature
,
58 size_t signature_size
);
59 static int verify_ssh_signed_buffer(struct signature_check
*sigc
,
60 struct gpg_format
*fmt
,
61 const char *signature
,
62 size_t signature_size
);
63 static int sign_buffer_gpg(struct strbuf
*buffer
, struct strbuf
*signature
,
64 const char *signing_key
);
65 static int sign_buffer_ssh(struct strbuf
*buffer
, struct strbuf
*signature
,
66 const char *signing_key
);
68 static const char *get_default_ssh_signing_key(void);
70 static const char *get_ssh_key_id(void);
72 static struct gpg_format gpg_format
[] = {
76 .verify_args
= openpgp_verify_args
,
78 .verify_signed_buffer
= verify_gpg_signed_buffer
,
79 .sign_buffer
= sign_buffer_gpg
,
80 .get_default_key
= NULL
,
86 .verify_args
= x509_verify_args
,
88 .verify_signed_buffer
= verify_gpg_signed_buffer
,
89 .sign_buffer
= sign_buffer_gpg
,
90 .get_default_key
= NULL
,
95 .program
= "ssh-keygen",
96 .verify_args
= ssh_verify_args
,
98 .verify_signed_buffer
= verify_ssh_signed_buffer
,
99 .sign_buffer
= sign_buffer_ssh
,
100 .get_default_key
= get_default_ssh_signing_key
,
101 .get_key_id
= get_ssh_key_id
,
105 static struct gpg_format
*use_format
= &gpg_format
[0];
107 static struct gpg_format
*get_format_by_name(const char *str
)
111 for (i
= 0; i
< ARRAY_SIZE(gpg_format
); i
++)
112 if (!strcmp(gpg_format
[i
].name
, str
))
113 return gpg_format
+ i
;
117 static struct gpg_format
*get_format_by_sig(const char *sig
)
121 for (i
= 0; i
< ARRAY_SIZE(gpg_format
); i
++)
122 for (j
= 0; gpg_format
[i
].sigs
[j
]; j
++)
123 if (starts_with(sig
, gpg_format
[i
].sigs
[j
]))
124 return gpg_format
+ i
;
128 void signature_check_clear(struct signature_check
*sigc
)
130 FREE_AND_NULL(sigc
->payload
);
131 FREE_AND_NULL(sigc
->output
);
132 FREE_AND_NULL(sigc
->gpg_status
);
133 FREE_AND_NULL(sigc
->signer
);
134 FREE_AND_NULL(sigc
->key
);
135 FREE_AND_NULL(sigc
->fingerprint
);
136 FREE_AND_NULL(sigc
->primary_key_fingerprint
);
139 /* An exclusive status -- only one of them can appear in output */
140 #define GPG_STATUS_EXCLUSIVE (1<<0)
141 /* The status includes key identifier */
142 #define GPG_STATUS_KEYID (1<<1)
143 /* The status includes user identifier */
144 #define GPG_STATUS_UID (1<<2)
145 /* The status includes key fingerprints */
146 #define GPG_STATUS_FINGERPRINT (1<<3)
147 /* The status includes trust level */
148 #define GPG_STATUS_TRUST_LEVEL (1<<4)
150 /* Short-hand for standard exclusive *SIG status with keyid & UID */
151 #define GPG_STATUS_STDSIG (GPG_STATUS_EXCLUSIVE|GPG_STATUS_KEYID|GPG_STATUS_UID)
157 } sigcheck_gpg_status
[] = {
158 { 'G', "GOODSIG ", GPG_STATUS_STDSIG
},
159 { 'B', "BADSIG ", GPG_STATUS_STDSIG
},
160 { 'E', "ERRSIG ", GPG_STATUS_EXCLUSIVE
|GPG_STATUS_KEYID
},
161 { 'X', "EXPSIG ", GPG_STATUS_STDSIG
},
162 { 'Y', "EXPKEYSIG ", GPG_STATUS_STDSIG
},
163 { 'R', "REVKEYSIG ", GPG_STATUS_STDSIG
},
164 { 0, "VALIDSIG ", GPG_STATUS_FINGERPRINT
},
165 { 0, "TRUST_", GPG_STATUS_TRUST_LEVEL
},
170 enum signature_trust_level value
;
171 } sigcheck_gpg_trust_level
[] = {
172 { "UNDEFINED", TRUST_UNDEFINED
},
173 { "NEVER", TRUST_NEVER
},
174 { "MARGINAL", TRUST_MARGINAL
},
175 { "FULLY", TRUST_FULLY
},
176 { "ULTIMATE", TRUST_ULTIMATE
},
179 static void replace_cstring(char **field
, const char *line
, const char *next
)
184 *field
= xmemdupz(line
, next
- line
);
189 static int parse_gpg_trust_level(const char *level
,
190 enum signature_trust_level
*res
)
194 for (i
= 0; i
< ARRAY_SIZE(sigcheck_gpg_trust_level
); i
++) {
195 if (!strcmp(sigcheck_gpg_trust_level
[i
].key
, level
)) {
196 *res
= sigcheck_gpg_trust_level
[i
].value
;
203 static void parse_gpg_output(struct signature_check
*sigc
)
205 const char *buf
= sigc
->gpg_status
;
206 const char *line
, *next
;
208 int seen_exclusive_status
= 0;
210 /* Iterate over all lines */
211 for (line
= buf
; *line
; line
= strchrnul(line
+1, '\n')) {
212 while (*line
== '\n')
217 /* Skip lines that don't start with GNUPG status */
218 if (!skip_prefix(line
, "[GNUPG:] ", &line
))
221 /* Iterate over all search strings */
222 for (i
= 0; i
< ARRAY_SIZE(sigcheck_gpg_status
); i
++) {
223 if (skip_prefix(line
, sigcheck_gpg_status
[i
].check
, &line
)) {
225 * GOODSIG, BADSIG etc. can occur only once for
226 * each signature. Therefore, if we had more
227 * than one then we're dealing with multiple
228 * signatures. We don't support them
229 * currently, and they're rather hard to
230 * create, so something is likely fishy and we
231 * should reject them altogether.
233 if (sigcheck_gpg_status
[i
].flags
& GPG_STATUS_EXCLUSIVE
) {
234 if (seen_exclusive_status
++)
238 if (sigcheck_gpg_status
[i
].result
)
239 sigc
->result
= sigcheck_gpg_status
[i
].result
;
240 /* Do we have key information? */
241 if (sigcheck_gpg_status
[i
].flags
& GPG_STATUS_KEYID
) {
242 next
= strchrnul(line
, ' ');
243 replace_cstring(&sigc
->key
, line
, next
);
244 /* Do we have signer information? */
245 if (*next
&& (sigcheck_gpg_status
[i
].flags
& GPG_STATUS_UID
)) {
247 next
= strchrnul(line
, '\n');
248 replace_cstring(&sigc
->signer
, line
, next
);
252 /* Do we have trust level? */
253 if (sigcheck_gpg_status
[i
].flags
& GPG_STATUS_TRUST_LEVEL
) {
255 * GPG v1 and v2 differs in how the
256 * TRUST_ lines are written. Some
257 * trust lines contain no additional
258 * space-separated information for v1.
260 size_t trust_size
= strcspn(line
, " \n");
261 char *trust
= xmemdupz(line
, trust_size
);
263 if (parse_gpg_trust_level(trust
, &sigc
->trust_level
)) {
270 /* Do we have fingerprint? */
271 if (sigcheck_gpg_status
[i
].flags
& GPG_STATUS_FINGERPRINT
) {
275 next
= strchrnul(line
, ' ');
276 replace_cstring(&sigc
->fingerprint
, line
, next
);
279 * Skip interim fields. The search is
280 * limited to the same line since only
281 * OpenPGP signatures has a field with
282 * the primary fingerprint.
284 limit
= strchrnul(line
, '\n');
285 for (j
= 9; j
> 0; j
--) {
286 if (!*next
|| limit
<= next
)
289 next
= strchrnul(line
, ' ');
292 field
= &sigc
->primary_key_fingerprint
;
294 next
= strchrnul(line
, '\n');
295 replace_cstring(field
, line
, next
);
297 replace_cstring(field
, NULL
, NULL
);
309 /* Clear partial data to avoid confusion */
310 FREE_AND_NULL(sigc
->primary_key_fingerprint
);
311 FREE_AND_NULL(sigc
->fingerprint
);
312 FREE_AND_NULL(sigc
->signer
);
313 FREE_AND_NULL(sigc
->key
);
316 static int verify_gpg_signed_buffer(struct signature_check
*sigc
,
317 struct gpg_format
*fmt
,
318 const char *signature
,
319 size_t signature_size
)
321 struct child_process gpg
= CHILD_PROCESS_INIT
;
322 struct tempfile
*temp
;
324 struct strbuf gpg_stdout
= STRBUF_INIT
;
325 struct strbuf gpg_stderr
= STRBUF_INIT
;
327 temp
= mks_tempfile_t(".git_vtag_tmpXXXXXX");
329 return error_errno(_("could not create temporary file"));
330 if (write_in_full(temp
->fd
, signature
, signature_size
) < 0 ||
331 close_tempfile_gently(temp
) < 0) {
332 error_errno(_("failed writing detached signature to '%s'"),
334 delete_tempfile(&temp
);
338 strvec_push(&gpg
.args
, fmt
->program
);
339 strvec_pushv(&gpg
.args
, fmt
->verify_args
);
340 strvec_pushl(&gpg
.args
,
342 "--verify", temp
->filename
.buf
, "-",
345 sigchain_push(SIGPIPE
, SIG_IGN
);
346 ret
= pipe_command(&gpg
, sigc
->payload
, sigc
->payload_len
, &gpg_stdout
, 0,
348 sigchain_pop(SIGPIPE
);
350 delete_tempfile(&temp
);
352 ret
|= !strstr(gpg_stdout
.buf
, "\n[GNUPG:] GOODSIG ");
353 sigc
->output
= strbuf_detach(&gpg_stderr
, NULL
);
354 sigc
->gpg_status
= strbuf_detach(&gpg_stdout
, NULL
);
356 parse_gpg_output(sigc
);
358 strbuf_release(&gpg_stdout
);
359 strbuf_release(&gpg_stderr
);
364 static void parse_ssh_output(struct signature_check
*sigc
)
366 const char *line
, *principal
, *search
;
371 * ssh-keygen output should be:
372 * Good "git" signature for PRINCIPAL with RSA key SHA256:FINGERPRINT
374 * or for valid but unknown keys:
375 * Good "git" signature with RSA key SHA256:FINGERPRINT
377 * Note that "PRINCIPAL" can contain whitespace, "RSA" and
378 * "SHA256" part could be a different token that names of
379 * the algorithms used, and "FINGERPRINT" is a hexadecimal
380 * string. By finding the last occurence of " with ", we can
381 * reliably parse out the PRINCIPAL.
384 sigc
->trust_level
= TRUST_NEVER
;
386 line
= to_free
= xmemdupz(sigc
->output
, strcspn(sigc
->output
, "\n"));
388 if (skip_prefix(line
, "Good \"git\" signature for ", &line
)) {
389 /* Search for the last "with" to get the full principal */
392 search
= strstr(line
, " with ");
395 } while (search
!= NULL
);
396 if (line
== principal
)
399 /* Valid signature and known principal */
401 sigc
->trust_level
= TRUST_FULLY
;
402 sigc
->signer
= xmemdupz(principal
, line
- principal
- 1);
403 } else if (skip_prefix(line
, "Good \"git\" signature with ", &line
)) {
404 /* Valid signature, but key unknown */
406 sigc
->trust_level
= TRUST_UNDEFINED
;
411 key
= strstr(line
, "key ");
413 sigc
->fingerprint
= xstrdup(strstr(line
, "key ") + 4);
414 sigc
->key
= xstrdup(sigc
->fingerprint
);
417 * Output did not match what we expected
418 * Treat the signature as bad
427 static int verify_ssh_signed_buffer(struct signature_check
*sigc
,
428 struct gpg_format
*fmt
,
429 const char *signature
,
430 size_t signature_size
)
432 struct child_process ssh_keygen
= CHILD_PROCESS_INIT
;
433 struct tempfile
*buffer_file
;
437 struct strbuf ssh_principals_out
= STRBUF_INIT
;
438 struct strbuf ssh_principals_err
= STRBUF_INIT
;
439 struct strbuf ssh_keygen_out
= STRBUF_INIT
;
440 struct strbuf ssh_keygen_err
= STRBUF_INIT
;
441 struct strbuf verify_time
= STRBUF_INIT
;
442 const struct date_mode verify_date_mode
= {
443 .type
= DATE_STRFTIME
,
444 .strftime_fmt
= "%Y%m%d%H%M%S",
445 /* SSH signing key validity has no timezone information - Use the local timezone */
449 if (!ssh_allowed_signers
) {
450 error(_("gpg.ssh.allowedSignersFile needs to be configured and exist for ssh signature verification"));
454 buffer_file
= mks_tempfile_t(".git_vtag_tmpXXXXXX");
456 return error_errno(_("could not create temporary file"));
457 if (write_in_full(buffer_file
->fd
, signature
, signature_size
) < 0 ||
458 close_tempfile_gently(buffer_file
) < 0) {
459 error_errno(_("failed writing detached signature to '%s'"),
460 buffer_file
->filename
.buf
);
461 delete_tempfile(&buffer_file
);
465 if (sigc
->payload_timestamp
)
466 strbuf_addf(&verify_time
, "-Overify-time=%s",
467 show_date(sigc
->payload_timestamp
, 0, &verify_date_mode
));
469 /* Find the principal from the signers */
470 strvec_pushl(&ssh_keygen
.args
, fmt
->program
,
471 "-Y", "find-principals",
472 "-f", ssh_allowed_signers
,
473 "-s", buffer_file
->filename
.buf
,
476 ret
= pipe_command(&ssh_keygen
, NULL
, 0, &ssh_principals_out
, 0,
477 &ssh_principals_err
, 0);
478 if (ret
&& strstr(ssh_principals_err
.buf
, "usage:")) {
479 error(_("ssh-keygen -Y find-principals/verify is needed for ssh signature verification (available in openssh version 8.2p1+)"));
482 if (ret
|| !ssh_principals_out
.len
) {
484 * We did not find a matching principal in the allowedSigners
485 * Check without validation
487 child_process_init(&ssh_keygen
);
488 strvec_pushl(&ssh_keygen
.args
, fmt
->program
,
489 "-Y", "check-novalidate",
491 "-s", buffer_file
->filename
.buf
,
494 pipe_command(&ssh_keygen
, sigc
->payload
, sigc
->payload_len
,
495 &ssh_keygen_out
, 0, &ssh_keygen_err
, 0);
498 * Fail on unknown keys
499 * we still call check-novalidate to display the signature info
503 /* Check every principal we found (one per line) */
505 for (line
= ssh_principals_out
.buf
;
508 const char *end_of_text
;
510 next
= end_of_text
= strchrnul(line
, '\n');
512 /* Did we find a LF, and did we have CR before it? */
514 line
< end_of_text
&&
515 end_of_text
[-1] == '\r')
518 /* Unless we hit NUL, skip over the LF we found */
522 /* Not all lines are data. Skip empty ones */
523 if (line
== end_of_text
)
526 /* We now know we have an non-empty line. Process it */
527 principal
= xmemdupz(line
, end_of_text
- line
);
529 child_process_init(&ssh_keygen
);
530 strbuf_release(&ssh_keygen_out
);
531 strbuf_release(&ssh_keygen_err
);
532 strvec_push(&ssh_keygen
.args
, fmt
->program
);
534 * We found principals
535 * Try with each until we find a match
537 strvec_pushl(&ssh_keygen
.args
, "-Y", "verify",
539 "-f", ssh_allowed_signers
,
541 "-s", buffer_file
->filename
.buf
,
545 if (ssh_revocation_file
) {
546 if (file_exists(ssh_revocation_file
)) {
547 strvec_pushl(&ssh_keygen
.args
, "-r",
548 ssh_revocation_file
, NULL
);
550 warning(_("ssh signing revocation file configured but not found: %s"),
551 ssh_revocation_file
);
555 sigchain_push(SIGPIPE
, SIG_IGN
);
556 ret
= pipe_command(&ssh_keygen
, sigc
->payload
, sigc
->payload_len
,
557 &ssh_keygen_out
, 0, &ssh_keygen_err
, 0);
558 sigchain_pop(SIGPIPE
);
560 FREE_AND_NULL(principal
);
563 ret
= !starts_with(ssh_keygen_out
.buf
, "Good");
570 strbuf_stripspace(&ssh_keygen_out
, 0);
571 strbuf_stripspace(&ssh_keygen_err
, 0);
572 /* Add stderr outputs to show the user actual ssh-keygen errors */
573 strbuf_add(&ssh_keygen_out
, ssh_principals_err
.buf
, ssh_principals_err
.len
);
574 strbuf_add(&ssh_keygen_out
, ssh_keygen_err
.buf
, ssh_keygen_err
.len
);
575 sigc
->output
= strbuf_detach(&ssh_keygen_out
, NULL
);
576 sigc
->gpg_status
= xstrdup(sigc
->output
);
578 parse_ssh_output(sigc
);
582 delete_tempfile(&buffer_file
);
583 strbuf_release(&ssh_principals_out
);
584 strbuf_release(&ssh_principals_err
);
585 strbuf_release(&ssh_keygen_out
);
586 strbuf_release(&ssh_keygen_err
);
587 strbuf_release(&verify_time
);
592 static int parse_payload_metadata(struct signature_check
*sigc
)
594 const char *ident_line
= NULL
;
596 struct ident_split ident
;
597 const char *signer_header
;
599 switch (sigc
->payload_type
) {
600 case SIGNATURE_PAYLOAD_COMMIT
:
601 signer_header
= "committer";
603 case SIGNATURE_PAYLOAD_TAG
:
604 signer_header
= "tagger";
606 case SIGNATURE_PAYLOAD_UNDEFINED
:
607 case SIGNATURE_PAYLOAD_PUSH_CERT
:
608 /* Ignore payloads we don't want to parse */
611 BUG("invalid value for sigc->payload_type");
614 ident_line
= find_commit_header(sigc
->payload
, signer_header
, &ident_len
);
615 if (!ident_line
|| !ident_len
)
618 if (split_ident_line(&ident
, ident_line
, ident_len
))
621 if (!sigc
->payload_timestamp
&& ident
.date_begin
&& ident
.date_end
)
622 sigc
->payload_timestamp
= parse_timestamp(ident
.date_begin
, NULL
, 10);
627 int check_signature(struct signature_check
*sigc
,
628 const char *signature
, size_t slen
)
630 struct gpg_format
*fmt
;
634 sigc
->trust_level
= -1;
636 fmt
= get_format_by_sig(signature
);
638 die(_("bad/incompatible signature '%s'"), signature
);
640 if (parse_payload_metadata(sigc
))
643 status
= fmt
->verify_signed_buffer(sigc
, fmt
, signature
, slen
);
645 if (status
&& !sigc
->output
)
648 status
|= sigc
->result
!= 'G';
649 status
|= sigc
->trust_level
< configured_min_trust_level
;
654 void print_signature_buffer(const struct signature_check
*sigc
, unsigned flags
)
656 const char *output
= flags
& GPG_VERIFY_RAW
? sigc
->gpg_status
:
659 if (flags
& GPG_VERIFY_VERBOSE
&& sigc
->payload
)
660 fwrite(sigc
->payload
, 1, sigc
->payload_len
, stdout
);
663 fputs(output
, stderr
);
666 size_t parse_signed_buffer(const char *buf
, size_t size
)
673 if (get_format_by_sig(buf
+ len
))
676 eol
= memchr(buf
+ len
, '\n', size
- len
);
677 len
+= eol
? eol
- (buf
+ len
) + 1 : size
- len
;
682 int parse_signature(const char *buf
, size_t size
, struct strbuf
*payload
, struct strbuf
*signature
)
684 size_t match
= parse_signed_buffer(buf
, size
);
686 strbuf_add(payload
, buf
, match
);
687 remove_signature(payload
);
688 strbuf_add(signature
, buf
+ match
, size
- match
);
694 void set_signing_key(const char *key
)
696 free(configured_signing_key
);
697 configured_signing_key
= xstrdup(key
);
700 int git_gpg_config(const char *var
, const char *value
, void *cb
)
702 struct gpg_format
*fmt
= NULL
;
703 char *fmtname
= NULL
;
707 if (!strcmp(var
, "user.signingkey")) {
709 return config_error_nonbool(var
);
710 set_signing_key(value
);
714 if (!strcmp(var
, "gpg.format")) {
716 return config_error_nonbool(var
);
717 fmt
= get_format_by_name(value
);
719 return error(_("invalid value for '%s': '%s'"),
725 if (!strcmp(var
, "gpg.mintrustlevel")) {
727 return config_error_nonbool(var
);
729 trust
= xstrdup_toupper(value
);
730 ret
= parse_gpg_trust_level(trust
, &configured_min_trust_level
);
734 return error(_("invalid value for '%s': '%s'"),
739 if (!strcmp(var
, "gpg.ssh.defaultkeycommand")) {
741 return config_error_nonbool(var
);
742 return git_config_string(&ssh_default_key_command
, var
, value
);
745 if (!strcmp(var
, "gpg.ssh.allowedsignersfile")) {
747 return config_error_nonbool(var
);
748 return git_config_pathname(&ssh_allowed_signers
, var
, value
);
751 if (!strcmp(var
, "gpg.ssh.revocationfile")) {
753 return config_error_nonbool(var
);
754 return git_config_pathname(&ssh_revocation_file
, var
, value
);
757 if (!strcmp(var
, "gpg.program") || !strcmp(var
, "gpg.openpgp.program"))
760 if (!strcmp(var
, "gpg.x509.program"))
763 if (!strcmp(var
, "gpg.ssh.program"))
767 fmt
= get_format_by_name(fmtname
);
768 return git_config_string(&fmt
->program
, var
, value
);
775 * Returns 1 if `string` contains a literal ssh key, 0 otherwise
776 * `key` will be set to the start of the actual key if a prefix is present.
778 static int is_literal_ssh_key(const char *string
, const char **key
)
780 if (skip_prefix(string
, "key::", key
))
782 if (starts_with(string
, "ssh-")) {
789 static char *get_ssh_key_fingerprint(const char *signing_key
)
791 struct child_process ssh_keygen
= CHILD_PROCESS_INIT
;
793 struct strbuf fingerprint_stdout
= STRBUF_INIT
;
794 struct strbuf
**fingerprint
;
795 char *fingerprint_ret
;
796 const char *literal_key
= NULL
;
799 * With SSH Signing this can contain a filename or a public key
800 * For textual representation we usually want a fingerprint
802 if (is_literal_ssh_key(signing_key
, &literal_key
)) {
803 strvec_pushl(&ssh_keygen
.args
, "ssh-keygen", "-lf", "-", NULL
);
804 ret
= pipe_command(&ssh_keygen
, literal_key
,
805 strlen(literal_key
), &fingerprint_stdout
, 0,
808 strvec_pushl(&ssh_keygen
.args
, "ssh-keygen", "-lf",
809 configured_signing_key
, NULL
);
810 ret
= pipe_command(&ssh_keygen
, NULL
, 0, &fingerprint_stdout
, 0,
815 die_errno(_("failed to get the ssh fingerprint for key '%s'"),
818 fingerprint
= strbuf_split_max(&fingerprint_stdout
, ' ', 3);
820 die_errno(_("failed to get the ssh fingerprint for key '%s'"),
823 fingerprint_ret
= strbuf_detach(fingerprint
[1], NULL
);
824 strbuf_list_free(fingerprint
);
825 strbuf_release(&fingerprint_stdout
);
826 return fingerprint_ret
;
829 /* Returns the first public key from an ssh-agent to use for signing */
830 static const char *get_default_ssh_signing_key(void)
832 struct child_process ssh_default_key
= CHILD_PROCESS_INIT
;
834 struct strbuf key_stdout
= STRBUF_INIT
, key_stderr
= STRBUF_INIT
;
835 struct strbuf
**keys
;
836 char *key_command
= NULL
;
839 char *default_key
= NULL
;
840 const char *literal_key
= NULL
;
842 if (!ssh_default_key_command
)
843 die(_("either user.signingkey or gpg.ssh.defaultKeyCommand needs to be configured"));
845 key_command
= xstrdup(ssh_default_key_command
);
846 n
= split_cmdline(key_command
, &argv
);
849 die("malformed build-time gpg.ssh.defaultKeyCommand: %s",
850 split_cmdline_strerror(n
));
852 strvec_pushv(&ssh_default_key
.args
, argv
);
853 ret
= pipe_command(&ssh_default_key
, NULL
, 0, &key_stdout
, 0,
857 keys
= strbuf_split_max(&key_stdout
, '\n', 2);
858 if (keys
[0] && is_literal_ssh_key(keys
[0]->buf
, &literal_key
)) {
860 * We only use `is_literal_ssh_key` here to check validity
861 * The prefix will be stripped when the key is used.
863 default_key
= strbuf_detach(keys
[0], NULL
);
865 warning(_("gpg.ssh.defaultKeyCommand succeeded but returned no keys: %s %s"),
866 key_stderr
.buf
, key_stdout
.buf
);
869 strbuf_list_free(keys
);
871 warning(_("gpg.ssh.defaultKeyCommand failed: %s %s"),
872 key_stderr
.buf
, key_stdout
.buf
);
877 strbuf_release(&key_stdout
);
882 static const char *get_ssh_key_id(void) {
883 return get_ssh_key_fingerprint(get_signing_key());
886 /* Returns a textual but unique representation of the signing key */
887 const char *get_signing_key_id(void)
889 if (use_format
->get_key_id
) {
890 return use_format
->get_key_id();
893 /* GPG/GPGSM only store a key id on this variable */
894 return get_signing_key();
897 const char *get_signing_key(void)
899 if (configured_signing_key
)
900 return configured_signing_key
;
901 if (use_format
->get_default_key
) {
902 return use_format
->get_default_key();
905 return git_committer_info(IDENT_STRICT
| IDENT_NO_DATE
);
908 int sign_buffer(struct strbuf
*buffer
, struct strbuf
*signature
, const char *signing_key
)
910 return use_format
->sign_buffer(buffer
, signature
, signing_key
);
914 * Strip CR from the line endings, in case we are on Windows.
915 * NEEDSWORK: make it trim only CRs before LFs and rename
917 static void remove_cr_after(struct strbuf
*buffer
, size_t offset
)
921 for (i
= j
= offset
; i
< buffer
->len
; i
++) {
922 if (buffer
->buf
[i
] != '\r') {
924 buffer
->buf
[j
] = buffer
->buf
[i
];
928 strbuf_setlen(buffer
, j
);
931 static int sign_buffer_gpg(struct strbuf
*buffer
, struct strbuf
*signature
,
932 const char *signing_key
)
934 struct child_process gpg
= CHILD_PROCESS_INIT
;
938 struct strbuf gpg_status
= STRBUF_INIT
;
940 strvec_pushl(&gpg
.args
,
943 "-bsau", signing_key
,
946 bottom
= signature
->len
;
949 * When the username signingkey is bad, program could be terminated
950 * because gpg exits without reading and then write gets SIGPIPE.
952 sigchain_push(SIGPIPE
, SIG_IGN
);
953 ret
= pipe_command(&gpg
, buffer
->buf
, buffer
->len
,
954 signature
, 1024, &gpg_status
, 0);
955 sigchain_pop(SIGPIPE
);
957 for (cp
= gpg_status
.buf
;
958 cp
&& (cp
= strstr(cp
, "[GNUPG:] SIG_CREATED "));
960 if (cp
== gpg_status
.buf
|| cp
[-1] == '\n')
964 strbuf_release(&gpg_status
);
966 return error(_("gpg failed to sign the data"));
968 /* Strip CR from the line endings, in case we are on Windows. */
969 remove_cr_after(signature
, bottom
);
974 static int sign_buffer_ssh(struct strbuf
*buffer
, struct strbuf
*signature
,
975 const char *signing_key
)
977 struct child_process signer
= CHILD_PROCESS_INIT
;
979 size_t bottom
, keylen
;
980 struct strbuf signer_stderr
= STRBUF_INIT
;
981 struct tempfile
*key_file
= NULL
, *buffer_file
= NULL
;
982 char *ssh_signing_key_file
= NULL
;
983 struct strbuf ssh_signature_filename
= STRBUF_INIT
;
984 const char *literal_key
= NULL
;
986 if (!signing_key
|| signing_key
[0] == '\0')
988 _("user.signingkey needs to be set for ssh signing"));
990 if (is_literal_ssh_key(signing_key
, &literal_key
)) {
991 /* A literal ssh key */
992 key_file
= mks_tempfile_t(".git_signing_key_tmpXXXXXX");
995 _("could not create temporary file"));
996 keylen
= strlen(literal_key
);
997 if (write_in_full(key_file
->fd
, literal_key
, keylen
) < 0 ||
998 close_tempfile_gently(key_file
) < 0) {
999 error_errno(_("failed writing ssh signing key to '%s'"),
1000 key_file
->filename
.buf
);
1003 ssh_signing_key_file
= strbuf_detach(&key_file
->filename
, NULL
);
1005 /* We assume a file */
1006 ssh_signing_key_file
= expand_user_path(signing_key
, 1);
1009 buffer_file
= mks_tempfile_t(".git_signing_buffer_tmpXXXXXX");
1011 error_errno(_("could not create temporary file"));
1015 if (write_in_full(buffer_file
->fd
, buffer
->buf
, buffer
->len
) < 0 ||
1016 close_tempfile_gently(buffer_file
) < 0) {
1017 error_errno(_("failed writing ssh signing key buffer to '%s'"),
1018 buffer_file
->filename
.buf
);
1022 strvec_pushl(&signer
.args
, use_format
->program
,
1025 "-f", ssh_signing_key_file
,
1026 buffer_file
->filename
.buf
,
1029 sigchain_push(SIGPIPE
, SIG_IGN
);
1030 ret
= pipe_command(&signer
, NULL
, 0, NULL
, 0, &signer_stderr
, 0);
1031 sigchain_pop(SIGPIPE
);
1034 if (strstr(signer_stderr
.buf
, "usage:"))
1035 error(_("ssh-keygen -Y sign is needed for ssh signing (available in openssh version 8.2p1+)"));
1037 error("%s", signer_stderr
.buf
);
1041 bottom
= signature
->len
;
1043 strbuf_addbuf(&ssh_signature_filename
, &buffer_file
->filename
);
1044 strbuf_addstr(&ssh_signature_filename
, ".sig");
1045 if (strbuf_read_file(signature
, ssh_signature_filename
.buf
, 0) < 0) {
1047 _("failed reading ssh signing data buffer from '%s'"),
1048 ssh_signature_filename
.buf
);
1050 unlink_or_warn(ssh_signature_filename
.buf
);
1052 /* Strip CR from the line endings, in case we are on Windows. */
1053 remove_cr_after(signature
, bottom
);
1057 delete_tempfile(&key_file
);
1059 delete_tempfile(&buffer_file
);
1060 strbuf_release(&signer_stderr
);
1061 strbuf_release(&ssh_signature_filename
);
1062 FREE_AND_NULL(ssh_signing_key_file
);