1 ifndef COMPILER_FEATURES
2 COMPILER_FEATURES := $(shell ./detect-compiler $(CC))
5 ifeq ($(filter no-error,$(DEVOPTS)),)
6 DEVELOPER_CFLAGS += -Werror
7 SPARSE_FLAGS += -Wsparse-error
10 DEVELOPER_CFLAGS += -Wall
11 ifeq ($(filter no-pedantic,$(DEVOPTS)),)
12 DEVELOPER_CFLAGS += -pedantic
13 ifneq (($or $(filter gcc5,$(COMPILER_FEATURES)),$(filter clang4,$(COMPILER_FEATURES))),)
14 DEVELOPER_CFLAGS += -Wpedantic
15 ifneq ($(filter gcc10,$(COMPILER_FEATURES)),)
16 ifeq ($(uname_S),MINGW)
17 DEVELOPER_CFLAGS += -Wno-pedantic-ms-format
23 ifneq ($(or $(filter gcc6,$(COMPILER_FEATURES)),$(filter clang7,$(COMPILER_FEATURES))),)
24 DEVELOPER_CFLAGS += -std=gnu99
27 DEVELOPER_CFLAGS += -Wdeclaration-after-statement
28 DEVELOPER_CFLAGS += -Wformat-security
29 DEVELOPER_CFLAGS += -Wold-style-definition
30 DEVELOPER_CFLAGS += -Woverflow
31 DEVELOPER_CFLAGS += -Wpointer-arith
32 DEVELOPER_CFLAGS += -Wstrict-prototypes
33 DEVELOPER_CFLAGS += -Wunused
34 DEVELOPER_CFLAGS += -Wvla
35 DEVELOPER_CFLAGS += -fno-common
37 ifneq ($(filter clang4,$(COMPILER_FEATURES)),)
38 DEVELOPER_CFLAGS += -Wtautological-constant-out-of-range-compare
41 ifneq ($(or $(filter gcc6,$(COMPILER_FEATURES)),$(filter clang4,$(COMPILER_FEATURES))),)
42 DEVELOPER_CFLAGS += -Wextra
43 # if a function is public, there should be a prototype and the right
44 # header file should be included. If not, it should be static.
45 DEVELOPER_CFLAGS += -Wmissing-prototypes
46 ifeq ($(filter extra-all,$(DEVOPTS)),)
47 # These are disabled because we have these all over the place.
48 DEVELOPER_CFLAGS += -Wno-empty-body
49 DEVELOPER_CFLAGS += -Wno-missing-field-initializers
50 DEVELOPER_CFLAGS += -Wno-sign-compare
51 DEVELOPER_CFLAGS += -Wno-unused-parameter
55 # uninitialized warnings on gcc 4.9.2 in xdiff/xdiffi.c and config.c
56 # not worth fixing since newer compilers correctly stop complaining
57 ifneq ($(filter gcc4,$(COMPILER_FEATURES)),)
58 ifeq ($(filter gcc5,$(COMPILER_FEATURES)),)
59 DEVELOPER_CFLAGS += -Wno-uninitialized
63 GIT_TEST_PERL_FATAL_WARNINGS = YesPlease