7 #include "object-store.h"
8 #include "hash-lookup.h"
12 #include "run-command.h"
13 #include "repository.h"
14 #include "chunk-format.h"
17 #define MIDX_SIGNATURE 0x4d494458 /* "MIDX" */
18 #define MIDX_VERSION 1
19 #define MIDX_BYTE_FILE_VERSION 4
20 #define MIDX_BYTE_HASH_VERSION 5
21 #define MIDX_BYTE_NUM_CHUNKS 6
22 #define MIDX_BYTE_NUM_PACKS 8
23 #define MIDX_HEADER_SIZE 12
24 #define MIDX_MIN_SIZE (MIDX_HEADER_SIZE + the_hash_algo->rawsz)
26 #define MIDX_CHUNK_ALIGNMENT 4
27 #define MIDX_CHUNKID_PACKNAMES 0x504e414d /* "PNAM" */
28 #define MIDX_CHUNKID_OIDFANOUT 0x4f494446 /* "OIDF" */
29 #define MIDX_CHUNKID_OIDLOOKUP 0x4f49444c /* "OIDL" */
30 #define MIDX_CHUNKID_OBJECTOFFSETS 0x4f4f4646 /* "OOFF" */
31 #define MIDX_CHUNKID_LARGEOFFSETS 0x4c4f4646 /* "LOFF" */
32 #define MIDX_CHUNK_FANOUT_SIZE (sizeof(uint32_t) * 256)
33 #define MIDX_CHUNK_OFFSET_WIDTH (2 * sizeof(uint32_t))
34 #define MIDX_CHUNK_LARGE_OFFSET_WIDTH (sizeof(uint64_t))
35 #define MIDX_LARGE_OFFSET_NEEDED 0x80000000
37 #define PACK_EXPIRED UINT_MAX
39 static uint8_t oid_version(void)
41 switch (hash_algo_by_ptr(the_hash_algo
)) {
47 die(_("invalid hash version"));
51 static const unsigned char *get_midx_checksum(struct multi_pack_index
*m
)
53 return m
->data
+ m
->data_len
- the_hash_algo
->rawsz
;
56 static char *get_midx_filename(const char *object_dir
)
58 return xstrfmt("%s/pack/multi-pack-index", object_dir
);
61 char *get_midx_rev_filename(struct multi_pack_index
*m
)
63 return xstrfmt("%s/pack/multi-pack-index-%s.rev",
64 m
->object_dir
, hash_to_hex(get_midx_checksum(m
)));
67 static int midx_read_oid_fanout(const unsigned char *chunk_start
,
68 size_t chunk_size
, void *data
)
70 struct multi_pack_index
*m
= data
;
71 m
->chunk_oid_fanout
= (uint32_t *)chunk_start
;
73 if (chunk_size
!= 4 * 256) {
74 error(_("multi-pack-index OID fanout is of the wrong size"));
80 struct multi_pack_index
*load_multi_pack_index(const char *object_dir
, int local
)
82 struct multi_pack_index
*m
= NULL
;
86 void *midx_map
= NULL
;
87 uint32_t hash_version
;
88 char *midx_name
= get_midx_filename(object_dir
);
90 const char *cur_pack_name
;
91 struct chunkfile
*cf
= NULL
;
93 fd
= git_open(midx_name
);
98 error_errno(_("failed to read %s"), midx_name
);
102 midx_size
= xsize_t(st
.st_size
);
104 if (midx_size
< MIDX_MIN_SIZE
) {
105 error(_("multi-pack-index file %s is too small"), midx_name
);
109 FREE_AND_NULL(midx_name
);
111 midx_map
= xmmap(NULL
, midx_size
, PROT_READ
, MAP_PRIVATE
, fd
, 0);
114 FLEX_ALLOC_STR(m
, object_dir
, object_dir
);
116 m
->data_len
= midx_size
;
119 m
->signature
= get_be32(m
->data
);
120 if (m
->signature
!= MIDX_SIGNATURE
)
121 die(_("multi-pack-index signature 0x%08x does not match signature 0x%08x"),
122 m
->signature
, MIDX_SIGNATURE
);
124 m
->version
= m
->data
[MIDX_BYTE_FILE_VERSION
];
125 if (m
->version
!= MIDX_VERSION
)
126 die(_("multi-pack-index version %d not recognized"),
129 hash_version
= m
->data
[MIDX_BYTE_HASH_VERSION
];
130 if (hash_version
!= oid_version()) {
131 error(_("multi-pack-index hash version %u does not match version %u"),
132 hash_version
, oid_version());
135 m
->hash_len
= the_hash_algo
->rawsz
;
137 m
->num_chunks
= m
->data
[MIDX_BYTE_NUM_CHUNKS
];
139 m
->num_packs
= get_be32(m
->data
+ MIDX_BYTE_NUM_PACKS
);
141 cf
= init_chunkfile(NULL
);
143 if (read_table_of_contents(cf
, m
->data
, midx_size
,
144 MIDX_HEADER_SIZE
, m
->num_chunks
))
147 if (pair_chunk(cf
, MIDX_CHUNKID_PACKNAMES
, &m
->chunk_pack_names
) == CHUNK_NOT_FOUND
)
148 die(_("multi-pack-index missing required pack-name chunk"));
149 if (read_chunk(cf
, MIDX_CHUNKID_OIDFANOUT
, midx_read_oid_fanout
, m
) == CHUNK_NOT_FOUND
)
150 die(_("multi-pack-index missing required OID fanout chunk"));
151 if (pair_chunk(cf
, MIDX_CHUNKID_OIDLOOKUP
, &m
->chunk_oid_lookup
) == CHUNK_NOT_FOUND
)
152 die(_("multi-pack-index missing required OID lookup chunk"));
153 if (pair_chunk(cf
, MIDX_CHUNKID_OBJECTOFFSETS
, &m
->chunk_object_offsets
) == CHUNK_NOT_FOUND
)
154 die(_("multi-pack-index missing required object offsets chunk"));
156 pair_chunk(cf
, MIDX_CHUNKID_LARGEOFFSETS
, &m
->chunk_large_offsets
);
158 m
->num_objects
= ntohl(m
->chunk_oid_fanout
[255]);
160 CALLOC_ARRAY(m
->pack_names
, m
->num_packs
);
161 CALLOC_ARRAY(m
->packs
, m
->num_packs
);
163 cur_pack_name
= (const char *)m
->chunk_pack_names
;
164 for (i
= 0; i
< m
->num_packs
; i
++) {
165 m
->pack_names
[i
] = cur_pack_name
;
167 cur_pack_name
+= strlen(cur_pack_name
) + 1;
169 if (i
&& strcmp(m
->pack_names
[i
], m
->pack_names
[i
- 1]) <= 0)
170 die(_("multi-pack-index pack names out of order: '%s' before '%s'"),
171 m
->pack_names
[i
- 1],
175 trace2_data_intmax("midx", the_repository
, "load/num_packs", m
->num_packs
);
176 trace2_data_intmax("midx", the_repository
, "load/num_objects", m
->num_objects
);
185 munmap(midx_map
, midx_size
);
191 void close_midx(struct multi_pack_index
*m
)
198 munmap((unsigned char *)m
->data
, m
->data_len
);
200 for (i
= 0; i
< m
->num_packs
; i
++) {
202 m
->packs
[i
]->multi_pack_index
= 0;
204 FREE_AND_NULL(m
->packs
);
205 FREE_AND_NULL(m
->pack_names
);
208 int prepare_midx_pack(struct repository
*r
, struct multi_pack_index
*m
, uint32_t pack_int_id
)
210 struct strbuf pack_name
= STRBUF_INIT
;
211 struct packed_git
*p
;
213 if (pack_int_id
>= m
->num_packs
)
214 die(_("bad pack-int-id: %u (%u total packs)"),
215 pack_int_id
, m
->num_packs
);
217 if (m
->packs
[pack_int_id
])
220 strbuf_addf(&pack_name
, "%s/pack/%s", m
->object_dir
,
221 m
->pack_names
[pack_int_id
]);
223 p
= add_packed_git(pack_name
.buf
, pack_name
.len
, m
->local
);
224 strbuf_release(&pack_name
);
229 p
->multi_pack_index
= 1;
230 m
->packs
[pack_int_id
] = p
;
231 install_packed_git(r
, p
);
232 list_add_tail(&p
->mru
, &r
->objects
->packed_git_mru
);
237 int bsearch_midx(const struct object_id
*oid
, struct multi_pack_index
*m
, uint32_t *result
)
239 return bsearch_hash(oid
->hash
, m
->chunk_oid_fanout
, m
->chunk_oid_lookup
,
240 the_hash_algo
->rawsz
, result
);
243 struct object_id
*nth_midxed_object_oid(struct object_id
*oid
,
244 struct multi_pack_index
*m
,
247 if (n
>= m
->num_objects
)
250 oidread(oid
, m
->chunk_oid_lookup
+ m
->hash_len
* n
);
254 off_t
nth_midxed_offset(struct multi_pack_index
*m
, uint32_t pos
)
256 const unsigned char *offset_data
;
259 offset_data
= m
->chunk_object_offsets
+ (off_t
)pos
* MIDX_CHUNK_OFFSET_WIDTH
;
260 offset32
= get_be32(offset_data
+ sizeof(uint32_t));
262 if (m
->chunk_large_offsets
&& offset32
& MIDX_LARGE_OFFSET_NEEDED
) {
263 if (sizeof(off_t
) < sizeof(uint64_t))
264 die(_("multi-pack-index stores a 64-bit offset, but off_t is too small"));
266 offset32
^= MIDX_LARGE_OFFSET_NEEDED
;
267 return get_be64(m
->chunk_large_offsets
+ sizeof(uint64_t) * offset32
);
273 uint32_t nth_midxed_pack_int_id(struct multi_pack_index
*m
, uint32_t pos
)
275 return get_be32(m
->chunk_object_offsets
+
276 (off_t
)pos
* MIDX_CHUNK_OFFSET_WIDTH
);
279 int fill_midx_entry(struct repository
* r
,
280 const struct object_id
*oid
,
281 struct pack_entry
*e
,
282 struct multi_pack_index
*m
)
285 uint32_t pack_int_id
;
286 struct packed_git
*p
;
288 if (!bsearch_midx(oid
, m
, &pos
))
291 if (pos
>= m
->num_objects
)
294 pack_int_id
= nth_midxed_pack_int_id(m
, pos
);
296 if (prepare_midx_pack(r
, m
, pack_int_id
))
298 p
= m
->packs
[pack_int_id
];
301 * We are about to tell the caller where they can locate the
302 * requested object. We better make sure the packfile is
303 * still here and can be accessed before supplying that
304 * answer, as it may have been deleted since the MIDX was
307 if (!is_pack_valid(p
))
310 if (oidset_size(&p
->bad_objects
) &&
311 oidset_contains(&p
->bad_objects
, oid
))
314 e
->offset
= nth_midxed_offset(m
, pos
);
320 /* Match "foo.idx" against either "foo.pack" _or_ "foo.idx". */
321 static int cmp_idx_or_pack_name(const char *idx_or_pack_name
,
322 const char *idx_name
)
324 /* Skip past any initial matching prefix. */
325 while (*idx_name
&& *idx_name
== *idx_or_pack_name
) {
331 * If we didn't match completely, we may have matched "pack-1234." and
332 * be left with "idx" and "pack" respectively, which is also OK. We do
333 * not have to check for "idx" and "idx", because that would have been
334 * a complete match (and in that case these strcmps will be false, but
335 * we'll correctly return 0 from the final strcmp() below.
337 * Technically this matches "fooidx" and "foopack", but we'd never have
338 * such names in the first place.
340 if (!strcmp(idx_name
, "idx") && !strcmp(idx_or_pack_name
, "pack"))
344 * This not only checks for a complete match, but also orders based on
345 * the first non-identical character, which means our ordering will
346 * match a raw strcmp(). That makes it OK to use this to binary search
347 * a naively-sorted list.
349 return strcmp(idx_or_pack_name
, idx_name
);
352 int midx_contains_pack(struct multi_pack_index
*m
, const char *idx_or_pack_name
)
354 uint32_t first
= 0, last
= m
->num_packs
;
356 while (first
< last
) {
357 uint32_t mid
= first
+ (last
- first
) / 2;
361 current
= m
->pack_names
[mid
];
362 cmp
= cmp_idx_or_pack_name(idx_or_pack_name
, current
);
375 int prepare_multi_pack_index_one(struct repository
*r
, const char *object_dir
, int local
)
377 struct multi_pack_index
*m
;
378 struct multi_pack_index
*m_search
;
380 prepare_repo_settings(r
);
381 if (!r
->settings
.core_multi_pack_index
)
384 for (m_search
= r
->objects
->multi_pack_index
; m_search
; m_search
= m_search
->next
)
385 if (!strcmp(object_dir
, m_search
->object_dir
))
388 m
= load_multi_pack_index(object_dir
, local
);
391 struct multi_pack_index
*mp
= r
->objects
->multi_pack_index
;
396 r
->objects
->multi_pack_index
= m
;
403 static size_t write_midx_header(struct hashfile
*f
,
404 unsigned char num_chunks
,
407 hashwrite_be32(f
, MIDX_SIGNATURE
);
408 hashwrite_u8(f
, MIDX_VERSION
);
409 hashwrite_u8(f
, oid_version());
410 hashwrite_u8(f
, num_chunks
);
411 hashwrite_u8(f
, 0); /* unused */
412 hashwrite_be32(f
, num_packs
);
414 return MIDX_HEADER_SIZE
;
418 uint32_t orig_pack_int_id
;
420 struct packed_git
*p
;
421 unsigned expired
: 1;
424 static int pack_info_compare(const void *_a
, const void *_b
)
426 struct pack_info
*a
= (struct pack_info
*)_a
;
427 struct pack_info
*b
= (struct pack_info
*)_b
;
428 return strcmp(a
->pack_name
, b
->pack_name
);
431 static int idx_or_pack_name_cmp(const void *_va
, const void *_vb
)
433 const char *pack_name
= _va
;
434 const struct pack_info
*compar
= _vb
;
436 return cmp_idx_or_pack_name(pack_name
, compar
->pack_name
);
439 struct write_midx_context
{
440 struct pack_info
*info
;
443 struct multi_pack_index
*m
;
444 struct progress
*progress
;
445 unsigned pack_paths_checked
;
447 struct pack_midx_entry
*entries
;
451 uint32_t *pack_order
;
452 unsigned large_offsets_needed
:1;
453 uint32_t num_large_offsets
;
455 int preferred_pack_idx
;
458 static void add_pack_to_midx(const char *full_path
, size_t full_path_len
,
459 const char *file_name
, void *data
)
461 struct write_midx_context
*ctx
= data
;
463 if (ends_with(file_name
, ".idx")) {
464 display_progress(ctx
->progress
, ++ctx
->pack_paths_checked
);
465 if (ctx
->m
&& midx_contains_pack(ctx
->m
, file_name
))
468 ALLOC_GROW(ctx
->info
, ctx
->nr
+ 1, ctx
->alloc
);
470 ctx
->info
[ctx
->nr
].p
= add_packed_git(full_path
,
474 if (!ctx
->info
[ctx
->nr
].p
) {
475 warning(_("failed to add packfile '%s'"),
480 if (open_pack_index(ctx
->info
[ctx
->nr
].p
)) {
481 warning(_("failed to open pack-index '%s'"),
483 close_pack(ctx
->info
[ctx
->nr
].p
);
484 FREE_AND_NULL(ctx
->info
[ctx
->nr
].p
);
488 ctx
->info
[ctx
->nr
].pack_name
= xstrdup(file_name
);
489 ctx
->info
[ctx
->nr
].orig_pack_int_id
= ctx
->nr
;
490 ctx
->info
[ctx
->nr
].expired
= 0;
495 struct pack_midx_entry
{
496 struct object_id oid
;
497 uint32_t pack_int_id
;
500 unsigned preferred
: 1;
503 static int midx_oid_compare(const void *_a
, const void *_b
)
505 const struct pack_midx_entry
*a
= (const struct pack_midx_entry
*)_a
;
506 const struct pack_midx_entry
*b
= (const struct pack_midx_entry
*)_b
;
507 int cmp
= oidcmp(&a
->oid
, &b
->oid
);
512 /* Sort objects in a preferred pack first when multiple copies exist. */
513 if (a
->preferred
> b
->preferred
)
515 if (a
->preferred
< b
->preferred
)
518 if (a
->pack_mtime
> b
->pack_mtime
)
520 else if (a
->pack_mtime
< b
->pack_mtime
)
523 return a
->pack_int_id
- b
->pack_int_id
;
526 static int nth_midxed_pack_midx_entry(struct multi_pack_index
*m
,
527 struct pack_midx_entry
*e
,
530 if (pos
>= m
->num_objects
)
533 nth_midxed_object_oid(&e
->oid
, m
, pos
);
534 e
->pack_int_id
= nth_midxed_pack_int_id(m
, pos
);
535 e
->offset
= nth_midxed_offset(m
, pos
);
537 /* consider objects in midx to be from "old" packs */
542 static void fill_pack_entry(uint32_t pack_int_id
,
543 struct packed_git
*p
,
545 struct pack_midx_entry
*entry
,
548 if (nth_packed_object_id(&entry
->oid
, p
, cur_object
) < 0)
549 die(_("failed to locate object %d in packfile"), cur_object
);
551 entry
->pack_int_id
= pack_int_id
;
552 entry
->pack_mtime
= p
->mtime
;
554 entry
->offset
= nth_packed_object_offset(p
, cur_object
);
555 entry
->preferred
= !!preferred
;
559 * It is possible to artificially get into a state where there are many
560 * duplicate copies of objects. That can create high memory pressure if
561 * we are to create a list of all objects before de-duplication. To reduce
562 * this memory pressure without a significant performance drop, automatically
563 * group objects by the first byte of their object id. Use the IDX fanout
564 * tables to group the data, copy to a local array, then sort.
566 * Copy only the de-duplicated entries (selected by most-recent modified time
567 * of a packfile containing the object).
569 static struct pack_midx_entry
*get_sorted_entries(struct multi_pack_index
*m
,
570 struct pack_info
*info
,
572 uint32_t *nr_objects
,
575 uint32_t cur_fanout
, cur_pack
, cur_object
;
576 uint32_t alloc_fanout
, alloc_objects
, total_objects
= 0;
577 struct pack_midx_entry
*entries_by_fanout
= NULL
;
578 struct pack_midx_entry
*deduplicated_entries
= NULL
;
579 uint32_t start_pack
= m
? m
->num_packs
: 0;
581 for (cur_pack
= start_pack
; cur_pack
< nr_packs
; cur_pack
++)
582 total_objects
+= info
[cur_pack
].p
->num_objects
;
585 * As we de-duplicate by fanout value, we expect the fanout
586 * slices to be evenly distributed, with some noise. Hence,
587 * allocate slightly more than one 256th.
589 alloc_objects
= alloc_fanout
= total_objects
> 3200 ? total_objects
/ 200 : 16;
591 ALLOC_ARRAY(entries_by_fanout
, alloc_fanout
);
592 ALLOC_ARRAY(deduplicated_entries
, alloc_objects
);
595 for (cur_fanout
= 0; cur_fanout
< 256; cur_fanout
++) {
596 uint32_t nr_fanout
= 0;
599 uint32_t start
= 0, end
;
602 start
= ntohl(m
->chunk_oid_fanout
[cur_fanout
- 1]);
603 end
= ntohl(m
->chunk_oid_fanout
[cur_fanout
]);
605 for (cur_object
= start
; cur_object
< end
; cur_object
++) {
606 ALLOC_GROW(entries_by_fanout
, nr_fanout
+ 1, alloc_fanout
);
607 nth_midxed_pack_midx_entry(m
,
608 &entries_by_fanout
[nr_fanout
],
610 if (nth_midxed_pack_int_id(m
, cur_object
) == preferred_pack
)
611 entries_by_fanout
[nr_fanout
].preferred
= 1;
613 entries_by_fanout
[nr_fanout
].preferred
= 0;
618 for (cur_pack
= start_pack
; cur_pack
< nr_packs
; cur_pack
++) {
619 uint32_t start
= 0, end
;
620 int preferred
= cur_pack
== preferred_pack
;
623 start
= get_pack_fanout(info
[cur_pack
].p
, cur_fanout
- 1);
624 end
= get_pack_fanout(info
[cur_pack
].p
, cur_fanout
);
626 for (cur_object
= start
; cur_object
< end
; cur_object
++) {
627 ALLOC_GROW(entries_by_fanout
, nr_fanout
+ 1, alloc_fanout
);
628 fill_pack_entry(cur_pack
,
631 &entries_by_fanout
[nr_fanout
],
637 QSORT(entries_by_fanout
, nr_fanout
, midx_oid_compare
);
640 * The batch is now sorted by OID and then mtime (descending).
641 * Take only the first duplicate.
643 for (cur_object
= 0; cur_object
< nr_fanout
; cur_object
++) {
644 if (cur_object
&& oideq(&entries_by_fanout
[cur_object
- 1].oid
,
645 &entries_by_fanout
[cur_object
].oid
))
648 ALLOC_GROW(deduplicated_entries
, *nr_objects
+ 1, alloc_objects
);
649 memcpy(&deduplicated_entries
[*nr_objects
],
650 &entries_by_fanout
[cur_object
],
651 sizeof(struct pack_midx_entry
));
656 free(entries_by_fanout
);
657 return deduplicated_entries
;
660 static int write_midx_pack_names(struct hashfile
*f
, void *data
)
662 struct write_midx_context
*ctx
= data
;
664 unsigned char padding
[MIDX_CHUNK_ALIGNMENT
];
667 for (i
= 0; i
< ctx
->nr
; i
++) {
670 if (ctx
->info
[i
].expired
)
673 if (i
&& strcmp(ctx
->info
[i
].pack_name
, ctx
->info
[i
- 1].pack_name
) <= 0)
674 BUG("incorrect pack-file order: %s before %s",
675 ctx
->info
[i
- 1].pack_name
,
676 ctx
->info
[i
].pack_name
);
678 writelen
= strlen(ctx
->info
[i
].pack_name
) + 1;
679 hashwrite(f
, ctx
->info
[i
].pack_name
, writelen
);
683 /* add padding to be aligned */
684 i
= MIDX_CHUNK_ALIGNMENT
- (written
% MIDX_CHUNK_ALIGNMENT
);
685 if (i
< MIDX_CHUNK_ALIGNMENT
) {
686 memset(padding
, 0, sizeof(padding
));
687 hashwrite(f
, padding
, i
);
693 static int write_midx_oid_fanout(struct hashfile
*f
,
696 struct write_midx_context
*ctx
= data
;
697 struct pack_midx_entry
*list
= ctx
->entries
;
698 struct pack_midx_entry
*last
= ctx
->entries
+ ctx
->entries_nr
;
703 * Write the first-level table (the list is sorted,
704 * but we use a 256-entry lookup to be able to avoid
705 * having to do eight extra binary search iterations).
707 for (i
= 0; i
< 256; i
++) {
708 struct pack_midx_entry
*next
= list
;
710 while (next
< last
&& next
->oid
.hash
[0] == i
) {
715 hashwrite_be32(f
, count
);
722 static int write_midx_oid_lookup(struct hashfile
*f
,
725 struct write_midx_context
*ctx
= data
;
726 unsigned char hash_len
= the_hash_algo
->rawsz
;
727 struct pack_midx_entry
*list
= ctx
->entries
;
730 for (i
= 0; i
< ctx
->entries_nr
; i
++) {
731 struct pack_midx_entry
*obj
= list
++;
733 if (i
< ctx
->entries_nr
- 1) {
734 struct pack_midx_entry
*next
= list
;
735 if (oidcmp(&obj
->oid
, &next
->oid
) >= 0)
736 BUG("OIDs not in order: %s >= %s",
737 oid_to_hex(&obj
->oid
),
738 oid_to_hex(&next
->oid
));
741 hashwrite(f
, obj
->oid
.hash
, (int)hash_len
);
747 static int write_midx_object_offsets(struct hashfile
*f
,
750 struct write_midx_context
*ctx
= data
;
751 struct pack_midx_entry
*list
= ctx
->entries
;
752 uint32_t i
, nr_large_offset
= 0;
754 for (i
= 0; i
< ctx
->entries_nr
; i
++) {
755 struct pack_midx_entry
*obj
= list
++;
757 if (ctx
->pack_perm
[obj
->pack_int_id
] == PACK_EXPIRED
)
758 BUG("object %s is in an expired pack with int-id %d",
759 oid_to_hex(&obj
->oid
),
762 hashwrite_be32(f
, ctx
->pack_perm
[obj
->pack_int_id
]);
764 if (ctx
->large_offsets_needed
&& obj
->offset
>> 31)
765 hashwrite_be32(f
, MIDX_LARGE_OFFSET_NEEDED
| nr_large_offset
++);
766 else if (!ctx
->large_offsets_needed
&& obj
->offset
>> 32)
767 BUG("object %s requires a large offset (%"PRIx64
") but the MIDX is not writing large offsets!",
768 oid_to_hex(&obj
->oid
),
771 hashwrite_be32(f
, (uint32_t)obj
->offset
);
777 static int write_midx_large_offsets(struct hashfile
*f
,
780 struct write_midx_context
*ctx
= data
;
781 struct pack_midx_entry
*list
= ctx
->entries
;
782 struct pack_midx_entry
*end
= ctx
->entries
+ ctx
->entries_nr
;
783 uint32_t nr_large_offset
= ctx
->num_large_offsets
;
785 while (nr_large_offset
) {
786 struct pack_midx_entry
*obj
;
790 BUG("too many large-offset objects");
793 offset
= obj
->offset
;
798 hashwrite_be64(f
, offset
);
806 struct midx_pack_order_data
{
812 static int midx_pack_order_cmp(const void *va
, const void *vb
)
814 const struct midx_pack_order_data
*a
= va
, *b
= vb
;
815 if (a
->pack
< b
->pack
)
817 else if (a
->pack
> b
->pack
)
819 else if (a
->offset
< b
->offset
)
821 else if (a
->offset
> b
->offset
)
827 static uint32_t *midx_pack_order(struct write_midx_context
*ctx
)
829 struct midx_pack_order_data
*data
;
830 uint32_t *pack_order
;
833 ALLOC_ARRAY(data
, ctx
->entries_nr
);
834 for (i
= 0; i
< ctx
->entries_nr
; i
++) {
835 struct pack_midx_entry
*e
= &ctx
->entries
[i
];
837 data
[i
].pack
= ctx
->pack_perm
[e
->pack_int_id
];
839 data
[i
].pack
|= (1U << 31);
840 data
[i
].offset
= e
->offset
;
843 QSORT(data
, ctx
->entries_nr
, midx_pack_order_cmp
);
845 ALLOC_ARRAY(pack_order
, ctx
->entries_nr
);
846 for (i
= 0; i
< ctx
->entries_nr
; i
++)
847 pack_order
[i
] = data
[i
].nr
;
853 static void write_midx_reverse_index(char *midx_name
, unsigned char *midx_hash
,
854 struct write_midx_context
*ctx
)
856 struct strbuf buf
= STRBUF_INIT
;
857 const char *tmp_file
;
859 strbuf_addf(&buf
, "%s-%s.rev", midx_name
, hash_to_hex(midx_hash
));
861 tmp_file
= write_rev_file_order(NULL
, ctx
->pack_order
, ctx
->entries_nr
,
862 midx_hash
, WRITE_REV
);
864 if (finalize_object_file(tmp_file
, buf
.buf
))
865 die(_("cannot store reverse index file"));
867 strbuf_release(&buf
);
870 static void clear_midx_files_ext(struct repository
*r
, const char *ext
,
871 unsigned char *keep_hash
);
873 static int midx_checksum_valid(struct multi_pack_index
*m
)
875 return hashfile_checksum_valid(m
->data
, m
->data_len
);
878 static int write_midx_internal(const char *object_dir
, struct multi_pack_index
*m
,
879 struct string_list
*packs_to_drop
,
880 const char *preferred_pack_name
,
884 unsigned char midx_hash
[GIT_MAX_RAWSZ
];
886 struct hashfile
*f
= NULL
;
888 struct write_midx_context ctx
= { 0 };
889 int pack_name_concat_len
= 0;
890 int dropped_packs
= 0;
892 struct chunkfile
*cf
;
894 midx_name
= get_midx_filename(object_dir
);
895 if (safe_create_leading_directories(midx_name
))
896 die_errno(_("unable to create leading directories of %s"),
902 ctx
.m
= load_multi_pack_index(object_dir
, 1);
904 if (ctx
.m
&& !midx_checksum_valid(ctx
.m
)) {
905 warning(_("ignoring existing multi-pack-index; checksum mismatch"));
910 ctx
.alloc
= ctx
.m
? ctx
.m
->num_packs
: 16;
912 ALLOC_ARRAY(ctx
.info
, ctx
.alloc
);
915 for (i
= 0; i
< ctx
.m
->num_packs
; i
++) {
916 ALLOC_GROW(ctx
.info
, ctx
.nr
+ 1, ctx
.alloc
);
918 ctx
.info
[ctx
.nr
].orig_pack_int_id
= i
;
919 ctx
.info
[ctx
.nr
].pack_name
= xstrdup(ctx
.m
->pack_names
[i
]);
920 ctx
.info
[ctx
.nr
].p
= NULL
;
921 ctx
.info
[ctx
.nr
].expired
= 0;
926 ctx
.pack_paths_checked
= 0;
927 if (flags
& MIDX_PROGRESS
)
928 ctx
.progress
= start_delayed_progress(_("Adding packfiles to multi-pack-index"), 0);
932 for_each_file_in_pack_dir(object_dir
, add_pack_to_midx
, &ctx
);
933 stop_progress(&ctx
.progress
);
935 if (ctx
.m
&& ctx
.nr
== ctx
.m
->num_packs
&& !packs_to_drop
)
938 ctx
.preferred_pack_idx
= -1;
939 if (preferred_pack_name
) {
940 for (i
= 0; i
< ctx
.nr
; i
++) {
941 if (!cmp_idx_or_pack_name(preferred_pack_name
,
942 ctx
.info
[i
].pack_name
)) {
943 ctx
.preferred_pack_idx
= i
;
949 ctx
.entries
= get_sorted_entries(ctx
.m
, ctx
.info
, ctx
.nr
, &ctx
.entries_nr
,
950 ctx
.preferred_pack_idx
);
952 ctx
.large_offsets_needed
= 0;
953 for (i
= 0; i
< ctx
.entries_nr
; i
++) {
954 if (ctx
.entries
[i
].offset
> 0x7fffffff)
955 ctx
.num_large_offsets
++;
956 if (ctx
.entries
[i
].offset
> 0xffffffff)
957 ctx
.large_offsets_needed
= 1;
960 QSORT(ctx
.info
, ctx
.nr
, pack_info_compare
);
962 if (packs_to_drop
&& packs_to_drop
->nr
) {
964 int missing_drops
= 0;
966 for (i
= 0; i
< ctx
.nr
&& drop_index
< packs_to_drop
->nr
; i
++) {
967 int cmp
= strcmp(ctx
.info
[i
].pack_name
,
968 packs_to_drop
->items
[drop_index
].string
);
972 ctx
.info
[i
].expired
= 1;
973 } else if (cmp
> 0) {
974 error(_("did not see pack-file %s to drop"),
975 packs_to_drop
->items
[drop_index
].string
);
980 ctx
.info
[i
].expired
= 0;
991 * pack_perm stores a permutation between pack-int-ids from the
992 * previous multi-pack-index to the new one we are writing:
994 * pack_perm[old_id] = new_id
996 ALLOC_ARRAY(ctx
.pack_perm
, ctx
.nr
);
997 for (i
= 0; i
< ctx
.nr
; i
++) {
998 if (ctx
.info
[i
].expired
) {
1000 ctx
.pack_perm
[ctx
.info
[i
].orig_pack_int_id
] = PACK_EXPIRED
;
1002 ctx
.pack_perm
[ctx
.info
[i
].orig_pack_int_id
] = i
- dropped_packs
;
1006 for (i
= 0; i
< ctx
.nr
; i
++) {
1007 if (!ctx
.info
[i
].expired
)
1008 pack_name_concat_len
+= strlen(ctx
.info
[i
].pack_name
) + 1;
1011 /* Check that the preferred pack wasn't expired (if given). */
1012 if (preferred_pack_name
) {
1013 struct pack_info
*preferred
= bsearch(preferred_pack_name
,
1016 idx_or_pack_name_cmp
);
1019 warning(_("unknown preferred pack: '%s'"),
1020 preferred_pack_name
);
1022 uint32_t perm
= ctx
.pack_perm
[preferred
->orig_pack_int_id
];
1023 if (perm
== PACK_EXPIRED
)
1024 warning(_("preferred pack '%s' is expired"),
1025 preferred_pack_name
);
1029 if (pack_name_concat_len
% MIDX_CHUNK_ALIGNMENT
)
1030 pack_name_concat_len
+= MIDX_CHUNK_ALIGNMENT
-
1031 (pack_name_concat_len
% MIDX_CHUNK_ALIGNMENT
);
1033 hold_lock_file_for_update(&lk
, midx_name
, LOCK_DIE_ON_ERROR
);
1034 f
= hashfd(get_lock_file_fd(&lk
), get_lock_file_path(&lk
));
1039 if (ctx
.nr
- dropped_packs
== 0) {
1040 error(_("no pack files to index."));
1045 cf
= init_chunkfile(f
);
1047 add_chunk(cf
, MIDX_CHUNKID_PACKNAMES
, pack_name_concat_len
,
1048 write_midx_pack_names
);
1049 add_chunk(cf
, MIDX_CHUNKID_OIDFANOUT
, MIDX_CHUNK_FANOUT_SIZE
,
1050 write_midx_oid_fanout
);
1051 add_chunk(cf
, MIDX_CHUNKID_OIDLOOKUP
,
1052 (size_t)ctx
.entries_nr
* the_hash_algo
->rawsz
,
1053 write_midx_oid_lookup
);
1054 add_chunk(cf
, MIDX_CHUNKID_OBJECTOFFSETS
,
1055 (size_t)ctx
.entries_nr
* MIDX_CHUNK_OFFSET_WIDTH
,
1056 write_midx_object_offsets
);
1058 if (ctx
.large_offsets_needed
)
1059 add_chunk(cf
, MIDX_CHUNKID_LARGEOFFSETS
,
1060 (size_t)ctx
.num_large_offsets
* MIDX_CHUNK_LARGE_OFFSET_WIDTH
,
1061 write_midx_large_offsets
);
1063 write_midx_header(f
, get_num_chunks(cf
), ctx
.nr
- dropped_packs
);
1064 write_chunkfile(cf
, &ctx
);
1066 finalize_hashfile(f
, midx_hash
, CSUM_FSYNC
| CSUM_HASH_IN_STREAM
);
1069 if (flags
& MIDX_WRITE_REV_INDEX
)
1070 ctx
.pack_order
= midx_pack_order(&ctx
);
1072 if (flags
& MIDX_WRITE_REV_INDEX
)
1073 write_midx_reverse_index(midx_name
, midx_hash
, &ctx
);
1074 clear_midx_files_ext(the_repository
, ".rev", midx_hash
);
1076 commit_lock_file(&lk
);
1079 for (i
= 0; i
< ctx
.nr
; i
++) {
1080 if (ctx
.info
[i
].p
) {
1081 close_pack(ctx
.info
[i
].p
);
1082 free(ctx
.info
[i
].p
);
1084 free(ctx
.info
[i
].pack_name
);
1089 free(ctx
.pack_perm
);
1090 free(ctx
.pack_order
);
1095 int write_midx_file(const char *object_dir
,
1096 const char *preferred_pack_name
,
1099 return write_midx_internal(object_dir
, NULL
, NULL
, preferred_pack_name
,
1103 struct clear_midx_data
{
1108 static void clear_midx_file_ext(const char *full_path
, size_t full_path_len
,
1109 const char *file_name
, void *_data
)
1111 struct clear_midx_data
*data
= _data
;
1113 if (!(starts_with(file_name
, "multi-pack-index-") &&
1114 ends_with(file_name
, data
->ext
)))
1116 if (data
->keep
&& !strcmp(data
->keep
, file_name
))
1119 if (unlink(full_path
))
1120 die_errno(_("failed to remove %s"), full_path
);
1123 static void clear_midx_files_ext(struct repository
*r
, const char *ext
,
1124 unsigned char *keep_hash
)
1126 struct clear_midx_data data
;
1127 memset(&data
, 0, sizeof(struct clear_midx_data
));
1130 data
.keep
= xstrfmt("multi-pack-index-%s%s",
1131 hash_to_hex(keep_hash
), ext
);
1134 for_each_file_in_pack_dir(r
->objects
->odb
->path
,
1135 clear_midx_file_ext
,
1141 void clear_midx_file(struct repository
*r
)
1143 char *midx
= get_midx_filename(r
->objects
->odb
->path
);
1145 if (r
->objects
&& r
->objects
->multi_pack_index
) {
1146 close_midx(r
->objects
->multi_pack_index
);
1147 r
->objects
->multi_pack_index
= NULL
;
1150 if (remove_path(midx
))
1151 die(_("failed to clear multi-pack-index at %s"), midx
);
1153 clear_midx_files_ext(r
, ".rev", NULL
);
1158 static int verify_midx_error
;
1160 __attribute__((format (printf
, 1, 2)))
1161 static void midx_report(const char *fmt
, ...)
1164 verify_midx_error
= 1;
1166 vfprintf(stderr
, fmt
, ap
);
1167 fprintf(stderr
, "\n");
1171 struct pair_pos_vs_id
1174 uint32_t pack_int_id
;
1177 static int compare_pair_pos_vs_id(const void *_a
, const void *_b
)
1179 struct pair_pos_vs_id
*a
= (struct pair_pos_vs_id
*)_a
;
1180 struct pair_pos_vs_id
*b
= (struct pair_pos_vs_id
*)_b
;
1182 return b
->pack_int_id
- a
->pack_int_id
;
1186 * Limit calls to display_progress() for performance reasons.
1187 * The interval here was arbitrarily chosen.
1189 #define SPARSE_PROGRESS_INTERVAL (1 << 12)
1190 #define midx_display_sparse_progress(progress, n) \
1192 uint64_t _n = (n); \
1193 if ((_n & (SPARSE_PROGRESS_INTERVAL - 1)) == 0) \
1194 display_progress(progress, _n); \
1197 int verify_midx_file(struct repository
*r
, const char *object_dir
, unsigned flags
)
1199 struct pair_pos_vs_id
*pairs
= NULL
;
1201 struct progress
*progress
= NULL
;
1202 struct multi_pack_index
*m
= load_multi_pack_index(object_dir
, 1);
1203 verify_midx_error
= 0;
1208 char *filename
= get_midx_filename(object_dir
);
1209 if (!stat(filename
, &sb
)) {
1210 error(_("multi-pack-index file exists, but failed to parse"));
1217 if (!midx_checksum_valid(m
))
1218 midx_report(_("incorrect checksum"));
1220 if (flags
& MIDX_PROGRESS
)
1221 progress
= start_delayed_progress(_("Looking for referenced packfiles"),
1223 for (i
= 0; i
< m
->num_packs
; i
++) {
1224 if (prepare_midx_pack(r
, m
, i
))
1225 midx_report("failed to load pack in position %d", i
);
1227 display_progress(progress
, i
+ 1);
1229 stop_progress(&progress
);
1231 for (i
= 0; i
< 255; i
++) {
1232 uint32_t oid_fanout1
= ntohl(m
->chunk_oid_fanout
[i
]);
1233 uint32_t oid_fanout2
= ntohl(m
->chunk_oid_fanout
[i
+ 1]);
1235 if (oid_fanout1
> oid_fanout2
)
1236 midx_report(_("oid fanout out of order: fanout[%d] = %"PRIx32
" > %"PRIx32
" = fanout[%d]"),
1237 i
, oid_fanout1
, oid_fanout2
, i
+ 1);
1240 if (m
->num_objects
== 0) {
1241 midx_report(_("the midx contains no oid"));
1243 * Remaining tests assume that we have objects, so we can
1246 return verify_midx_error
;
1249 if (flags
& MIDX_PROGRESS
)
1250 progress
= start_sparse_progress(_("Verifying OID order in multi-pack-index"),
1251 m
->num_objects
- 1);
1252 for (i
= 0; i
< m
->num_objects
- 1; i
++) {
1253 struct object_id oid1
, oid2
;
1255 nth_midxed_object_oid(&oid1
, m
, i
);
1256 nth_midxed_object_oid(&oid2
, m
, i
+ 1);
1258 if (oidcmp(&oid1
, &oid2
) >= 0)
1259 midx_report(_("oid lookup out of order: oid[%d] = %s >= %s = oid[%d]"),
1260 i
, oid_to_hex(&oid1
), oid_to_hex(&oid2
), i
+ 1);
1262 midx_display_sparse_progress(progress
, i
+ 1);
1264 stop_progress(&progress
);
1267 * Create an array mapping each object to its packfile id. Sort it
1268 * to group the objects by packfile. Use this permutation to visit
1269 * each of the objects and only require 1 packfile to be open at a
1272 ALLOC_ARRAY(pairs
, m
->num_objects
);
1273 for (i
= 0; i
< m
->num_objects
; i
++) {
1275 pairs
[i
].pack_int_id
= nth_midxed_pack_int_id(m
, i
);
1278 if (flags
& MIDX_PROGRESS
)
1279 progress
= start_sparse_progress(_("Sorting objects by packfile"),
1281 display_progress(progress
, 0); /* TODO: Measure QSORT() progress */
1282 QSORT(pairs
, m
->num_objects
, compare_pair_pos_vs_id
);
1283 stop_progress(&progress
);
1285 if (flags
& MIDX_PROGRESS
)
1286 progress
= start_sparse_progress(_("Verifying object offsets"), m
->num_objects
);
1287 for (i
= 0; i
< m
->num_objects
; i
++) {
1288 struct object_id oid
;
1289 struct pack_entry e
;
1290 off_t m_offset
, p_offset
;
1292 if (i
> 0 && pairs
[i
-1].pack_int_id
!= pairs
[i
].pack_int_id
&&
1293 m
->packs
[pairs
[i
-1].pack_int_id
])
1295 close_pack_fd(m
->packs
[pairs
[i
-1].pack_int_id
]);
1296 close_pack_index(m
->packs
[pairs
[i
-1].pack_int_id
]);
1299 nth_midxed_object_oid(&oid
, m
, pairs
[i
].pos
);
1301 if (!fill_midx_entry(r
, &oid
, &e
, m
)) {
1302 midx_report(_("failed to load pack entry for oid[%d] = %s"),
1303 pairs
[i
].pos
, oid_to_hex(&oid
));
1307 if (open_pack_index(e
.p
)) {
1308 midx_report(_("failed to load pack-index for packfile %s"),
1313 m_offset
= e
.offset
;
1314 p_offset
= find_pack_entry_one(oid
.hash
, e
.p
);
1316 if (m_offset
!= p_offset
)
1317 midx_report(_("incorrect object offset for oid[%d] = %s: %"PRIx64
" != %"PRIx64
),
1318 pairs
[i
].pos
, oid_to_hex(&oid
), m_offset
, p_offset
);
1320 midx_display_sparse_progress(progress
, i
+ 1);
1322 stop_progress(&progress
);
1326 return verify_midx_error
;
1329 int expire_midx_packs(struct repository
*r
, const char *object_dir
, unsigned flags
)
1331 uint32_t i
, *count
, result
= 0;
1332 struct string_list packs_to_drop
= STRING_LIST_INIT_DUP
;
1333 struct multi_pack_index
*m
= load_multi_pack_index(object_dir
, 1);
1334 struct progress
*progress
= NULL
;
1339 CALLOC_ARRAY(count
, m
->num_packs
);
1341 if (flags
& MIDX_PROGRESS
)
1342 progress
= start_delayed_progress(_("Counting referenced objects"),
1344 for (i
= 0; i
< m
->num_objects
; i
++) {
1345 int pack_int_id
= nth_midxed_pack_int_id(m
, i
);
1346 count
[pack_int_id
]++;
1347 display_progress(progress
, i
+ 1);
1349 stop_progress(&progress
);
1351 if (flags
& MIDX_PROGRESS
)
1352 progress
= start_delayed_progress(_("Finding and deleting unreferenced packfiles"),
1354 for (i
= 0; i
< m
->num_packs
; i
++) {
1356 display_progress(progress
, i
+ 1);
1361 if (prepare_midx_pack(r
, m
, i
))
1364 if (m
->packs
[i
]->pack_keep
)
1367 pack_name
= xstrdup(m
->packs
[i
]->pack_name
);
1368 close_pack(m
->packs
[i
]);
1370 string_list_insert(&packs_to_drop
, m
->pack_names
[i
]);
1371 unlink_pack_path(pack_name
, 0);
1374 stop_progress(&progress
);
1378 if (packs_to_drop
.nr
)
1379 result
= write_midx_internal(object_dir
, m
, &packs_to_drop
, NULL
, flags
);
1381 string_list_clear(&packs_to_drop
, 0);
1385 struct repack_info
{
1387 uint32_t referenced_objects
;
1388 uint32_t pack_int_id
;
1391 static int compare_by_mtime(const void *a_
, const void *b_
)
1393 const struct repack_info
*a
, *b
;
1395 a
= (const struct repack_info
*)a_
;
1396 b
= (const struct repack_info
*)b_
;
1398 if (a
->mtime
< b
->mtime
)
1400 if (a
->mtime
> b
->mtime
)
1405 static int fill_included_packs_all(struct repository
*r
,
1406 struct multi_pack_index
*m
,
1407 unsigned char *include_pack
)
1409 uint32_t i
, count
= 0;
1410 int pack_kept_objects
= 0;
1412 repo_config_get_bool(r
, "repack.packkeptobjects", &pack_kept_objects
);
1414 for (i
= 0; i
< m
->num_packs
; i
++) {
1415 if (prepare_midx_pack(r
, m
, i
))
1417 if (!pack_kept_objects
&& m
->packs
[i
]->pack_keep
)
1420 include_pack
[i
] = 1;
1427 static int fill_included_packs_batch(struct repository
*r
,
1428 struct multi_pack_index
*m
,
1429 unsigned char *include_pack
,
1432 uint32_t i
, packs_to_repack
;
1434 struct repack_info
*pack_info
= xcalloc(m
->num_packs
, sizeof(struct repack_info
));
1435 int pack_kept_objects
= 0;
1437 repo_config_get_bool(r
, "repack.packkeptobjects", &pack_kept_objects
);
1439 for (i
= 0; i
< m
->num_packs
; i
++) {
1440 pack_info
[i
].pack_int_id
= i
;
1442 if (prepare_midx_pack(r
, m
, i
))
1445 pack_info
[i
].mtime
= m
->packs
[i
]->mtime
;
1448 for (i
= 0; batch_size
&& i
< m
->num_objects
; i
++) {
1449 uint32_t pack_int_id
= nth_midxed_pack_int_id(m
, i
);
1450 pack_info
[pack_int_id
].referenced_objects
++;
1453 QSORT(pack_info
, m
->num_packs
, compare_by_mtime
);
1456 packs_to_repack
= 0;
1457 for (i
= 0; total_size
< batch_size
&& i
< m
->num_packs
; i
++) {
1458 int pack_int_id
= pack_info
[i
].pack_int_id
;
1459 struct packed_git
*p
= m
->packs
[pack_int_id
];
1460 size_t expected_size
;
1464 if (!pack_kept_objects
&& p
->pack_keep
)
1466 if (open_pack_index(p
) || !p
->num_objects
)
1469 expected_size
= (size_t)(p
->pack_size
1470 * pack_info
[i
].referenced_objects
);
1471 expected_size
/= p
->num_objects
;
1473 if (expected_size
>= batch_size
)
1477 total_size
+= expected_size
;
1478 include_pack
[pack_int_id
] = 1;
1483 if (packs_to_repack
< 2)
1489 int midx_repack(struct repository
*r
, const char *object_dir
, size_t batch_size
, unsigned flags
)
1493 unsigned char *include_pack
;
1494 struct child_process cmd
= CHILD_PROCESS_INIT
;
1496 struct strbuf base_name
= STRBUF_INIT
;
1497 struct multi_pack_index
*m
= load_multi_pack_index(object_dir
, 1);
1500 * When updating the default for these configuration
1501 * variables in builtin/repack.c, these must be adjusted
1504 int delta_base_offset
= 1;
1505 int use_delta_islands
= 0;
1510 CALLOC_ARRAY(include_pack
, m
->num_packs
);
1513 if (fill_included_packs_batch(r
, m
, include_pack
, batch_size
))
1515 } else if (fill_included_packs_all(r
, m
, include_pack
))
1518 repo_config_get_bool(r
, "repack.usedeltabaseoffset", &delta_base_offset
);
1519 repo_config_get_bool(r
, "repack.usedeltaislands", &use_delta_islands
);
1521 strvec_push(&cmd
.args
, "pack-objects");
1523 strbuf_addstr(&base_name
, object_dir
);
1524 strbuf_addstr(&base_name
, "/pack/pack");
1525 strvec_push(&cmd
.args
, base_name
.buf
);
1527 if (delta_base_offset
)
1528 strvec_push(&cmd
.args
, "--delta-base-offset");
1529 if (use_delta_islands
)
1530 strvec_push(&cmd
.args
, "--delta-islands");
1532 if (flags
& MIDX_PROGRESS
)
1533 strvec_push(&cmd
.args
, "--progress");
1535 strvec_push(&cmd
.args
, "-q");
1537 strbuf_release(&base_name
);
1540 cmd
.in
= cmd
.out
= -1;
1542 if (start_command(&cmd
)) {
1543 error(_("could not start pack-objects"));
1548 cmd_in
= xfdopen(cmd
.in
, "w");
1550 for (i
= 0; i
< m
->num_objects
; i
++) {
1551 struct object_id oid
;
1552 uint32_t pack_int_id
= nth_midxed_pack_int_id(m
, i
);
1554 if (!include_pack
[pack_int_id
])
1557 nth_midxed_object_oid(&oid
, m
, i
);
1558 fprintf(cmd_in
, "%s\n", oid_to_hex(&oid
));
1562 if (finish_command(&cmd
)) {
1563 error(_("could not finish pack-objects"));
1568 result
= write_midx_internal(object_dir
, m
, NULL
, NULL
, flags
);