| commit | ce8ebcdaf31dd56955635808bba1a6df50601563 | |
| author | Ramsay Jones <ramsay@ramsay1.demon.co.uk> | |
| Thu, 2 Feb 2012 09:57:23 +0000 (2 03:57 -0600) | ||
| committer | Jonathan Nieder <jrnieder@gmail.com> | |
| Thu, 2 Feb 2012 11:28:51 +0000 (2 05:28 -0600) | ||
| tree | 6d19cf6b6a6ff93c437b3a93de53433666169aa8 | treesnapshot (tar.gz zip) |
| parent | 58ebd9865d2bb9d42842fbac5a1c4eae49e92859 | commitdiff |
vcs-svn: rename check_overflow and its arguments for clarity
The canonical interpretation of a range a,b is as an interval [a,b),
not [a,a+b), so this function taking argument names a and b feels
unnatural. Use more explicit names "offset" and "len" to make the
arguments' type and function clearer.
While at it, rename the function to convey that we are making sure
the sum of this offset and length do not overflow an off_t, not a
size_t.
[jn: split out from a patch from Ramsay Jones, then improved with
advice from Thomas Rast, Dmitry Ivankov, and David Barr]
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Improved-by: Dmitry Ivankov <divanorama@gmail.com>
The canonical interpretation of a range a,b is as an interval [a,b),
not [a,a+b), so this function taking argument names a and b feels
unnatural. Use more explicit names "offset" and "len" to make the
arguments' type and function clearer.
While at it, rename the function to convey that we are making sure
the sum of this offset and length do not overflow an off_t, not a
size_t.
[jn: split out from a patch from Ramsay Jones, then improved with
advice from Thomas Rast, Dmitry Ivankov, and David Barr]
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Improved-by: Dmitry Ivankov <divanorama@gmail.com>
| vcs-svn/sliding_window.c | diffblobblamehistory |