| commit | 3783aad4c8e08ed7905bada47dc7b5df94bfa74a | |
| author | Stefan Beller <sbeller@google.com> | |
| Mon, 16 Jul 2018 23:05:37 +0000 (16 16:05 -0700) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Tue, 17 Jul 2018 18:25:31 +0000 (17 11:25 -0700) | ||
| tree | 74e16409879b531c6b20c50b496b362590a196a6 | treesnapshot (tar.gz zip) |
| parent | 74cfa7bed96ea003e0a3ea20455096187c517b19 | commitdiff |
diff.c: do not pass diff options as keydata to hashmap
When we initialize the hashmap, we give it a pointer to the
diff_options, which it then passes along to each call of the
hashmap_cmp_fn function. There's no need to pass it a second time as
the "keydata" parameter, and our comparison functions never look at
keydata.
This was a mistake left over from an earlier round of 2e2d5ac184
(diff.c: color moved lines differently, 2017-06-30), before hashmap
learned to pass the data pointer for us.
Explanation-by: Jeff King <peff@peff.net>
Signed-off-by: Stefan Beller <sbeller@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
When we initialize the hashmap, we give it a pointer to the
diff_options, which it then passes along to each call of the
hashmap_cmp_fn function. There's no need to pass it a second time as
the "keydata" parameter, and our comparison functions never look at
keydata.
This was a mistake left over from an earlier round of 2e2d5ac184
(diff.c: color moved lines differently, 2017-06-30), before hashmap
learned to pass the data pointer for us.
Explanation-by: Jeff King <peff@peff.net>
Signed-off-by: Stefan Beller <sbeller@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| diff.c | diffblobblamehistory |