4 #include "run-command.h"
7 #include "gpg-interface.h"
12 static char *configured_signing_key
;
13 static const char *ssh_default_key_command
, *ssh_allowed_signers
, *ssh_revocation_file
;
14 static enum signature_trust_level configured_min_trust_level
= TRUST_UNDEFINED
;
19 const char **verify_args
;
21 int (*verify_signed_buffer
)(struct signature_check
*sigc
,
22 struct gpg_format
*fmt
,
23 const char *signature
,
24 size_t signature_size
);
25 int (*sign_buffer
)(struct strbuf
*buffer
, struct strbuf
*signature
,
26 const char *signing_key
);
27 const char *(*get_default_key
)(void);
28 const char *(*get_key_id
)(void);
31 static const char *openpgp_verify_args
[] = {
32 "--keyid-format=long",
35 static const char *openpgp_sigs
[] = {
36 "-----BEGIN PGP SIGNATURE-----",
37 "-----BEGIN PGP MESSAGE-----",
41 static const char *x509_verify_args
[] = {
44 static const char *x509_sigs
[] = {
45 "-----BEGIN SIGNED MESSAGE-----",
49 static const char *ssh_verify_args
[] = { NULL
};
50 static const char *ssh_sigs
[] = {
51 "-----BEGIN SSH SIGNATURE-----",
55 static int verify_gpg_signed_buffer(struct signature_check
*sigc
,
56 struct gpg_format
*fmt
,
57 const char *signature
,
58 size_t signature_size
);
59 static int verify_ssh_signed_buffer(struct signature_check
*sigc
,
60 struct gpg_format
*fmt
,
61 const char *signature
,
62 size_t signature_size
);
63 static int sign_buffer_gpg(struct strbuf
*buffer
, struct strbuf
*signature
,
64 const char *signing_key
);
65 static int sign_buffer_ssh(struct strbuf
*buffer
, struct strbuf
*signature
,
66 const char *signing_key
);
68 static const char *get_default_ssh_signing_key(void);
70 static const char *get_ssh_key_id(void);
72 static struct gpg_format gpg_format
[] = {
76 .verify_args
= openpgp_verify_args
,
78 .verify_signed_buffer
= verify_gpg_signed_buffer
,
79 .sign_buffer
= sign_buffer_gpg
,
80 .get_default_key
= NULL
,
86 .verify_args
= x509_verify_args
,
88 .verify_signed_buffer
= verify_gpg_signed_buffer
,
89 .sign_buffer
= sign_buffer_gpg
,
90 .get_default_key
= NULL
,
95 .program
= "ssh-keygen",
96 .verify_args
= ssh_verify_args
,
98 .verify_signed_buffer
= verify_ssh_signed_buffer
,
99 .sign_buffer
= sign_buffer_ssh
,
100 .get_default_key
= get_default_ssh_signing_key
,
101 .get_key_id
= get_ssh_key_id
,
105 static struct gpg_format
*use_format
= &gpg_format
[0];
107 static struct gpg_format
*get_format_by_name(const char *str
)
111 for (i
= 0; i
< ARRAY_SIZE(gpg_format
); i
++)
112 if (!strcmp(gpg_format
[i
].name
, str
))
113 return gpg_format
+ i
;
117 static struct gpg_format
*get_format_by_sig(const char *sig
)
121 for (i
= 0; i
< ARRAY_SIZE(gpg_format
); i
++)
122 for (j
= 0; gpg_format
[i
].sigs
[j
]; j
++)
123 if (starts_with(sig
, gpg_format
[i
].sigs
[j
]))
124 return gpg_format
+ i
;
128 void signature_check_clear(struct signature_check
*sigc
)
130 FREE_AND_NULL(sigc
->payload
);
131 FREE_AND_NULL(sigc
->output
);
132 FREE_AND_NULL(sigc
->gpg_status
);
133 FREE_AND_NULL(sigc
->signer
);
134 FREE_AND_NULL(sigc
->key
);
135 FREE_AND_NULL(sigc
->fingerprint
);
136 FREE_AND_NULL(sigc
->primary_key_fingerprint
);
139 /* An exclusive status -- only one of them can appear in output */
140 #define GPG_STATUS_EXCLUSIVE (1<<0)
141 /* The status includes key identifier */
142 #define GPG_STATUS_KEYID (1<<1)
143 /* The status includes user identifier */
144 #define GPG_STATUS_UID (1<<2)
145 /* The status includes key fingerprints */
146 #define GPG_STATUS_FINGERPRINT (1<<3)
147 /* The status includes trust level */
148 #define GPG_STATUS_TRUST_LEVEL (1<<4)
150 /* Short-hand for standard exclusive *SIG status with keyid & UID */
151 #define GPG_STATUS_STDSIG (GPG_STATUS_EXCLUSIVE|GPG_STATUS_KEYID|GPG_STATUS_UID)
157 } sigcheck_gpg_status
[] = {
158 { 'G', "GOODSIG ", GPG_STATUS_STDSIG
},
159 { 'B', "BADSIG ", GPG_STATUS_STDSIG
},
160 { 'E', "ERRSIG ", GPG_STATUS_EXCLUSIVE
|GPG_STATUS_KEYID
},
161 { 'X', "EXPSIG ", GPG_STATUS_STDSIG
},
162 { 'Y', "EXPKEYSIG ", GPG_STATUS_STDSIG
},
163 { 'R', "REVKEYSIG ", GPG_STATUS_STDSIG
},
164 { 0, "VALIDSIG ", GPG_STATUS_FINGERPRINT
},
165 { 0, "TRUST_", GPG_STATUS_TRUST_LEVEL
},
168 /* Keep the order same as enum signature_trust_level */
169 static struct sigcheck_gpg_trust_level
{
171 const char *display_key
;
172 enum signature_trust_level value
;
173 } sigcheck_gpg_trust_level
[] = {
174 { "UNDEFINED", "undefined", TRUST_UNDEFINED
},
175 { "NEVER", "never", TRUST_NEVER
},
176 { "MARGINAL", "marginal", TRUST_MARGINAL
},
177 { "FULLY", "fully", TRUST_FULLY
},
178 { "ULTIMATE", "ultimate", TRUST_ULTIMATE
},
181 static void replace_cstring(char **field
, const char *line
, const char *next
)
186 *field
= xmemdupz(line
, next
- line
);
191 static int parse_gpg_trust_level(const char *level
,
192 enum signature_trust_level
*res
)
196 for (i
= 0; i
< ARRAY_SIZE(sigcheck_gpg_trust_level
); i
++) {
197 if (!strcmp(sigcheck_gpg_trust_level
[i
].key
, level
)) {
198 *res
= sigcheck_gpg_trust_level
[i
].value
;
205 static void parse_gpg_output(struct signature_check
*sigc
)
207 const char *buf
= sigc
->gpg_status
;
208 const char *line
, *next
;
210 int seen_exclusive_status
= 0;
212 /* Iterate over all lines */
213 for (line
= buf
; *line
; line
= strchrnul(line
+1, '\n')) {
214 while (*line
== '\n')
219 /* Skip lines that don't start with GNUPG status */
220 if (!skip_prefix(line
, "[GNUPG:] ", &line
))
223 /* Iterate over all search strings */
224 for (i
= 0; i
< ARRAY_SIZE(sigcheck_gpg_status
); i
++) {
225 if (skip_prefix(line
, sigcheck_gpg_status
[i
].check
, &line
)) {
227 * GOODSIG, BADSIG etc. can occur only once for
228 * each signature. Therefore, if we had more
229 * than one then we're dealing with multiple
230 * signatures. We don't support them
231 * currently, and they're rather hard to
232 * create, so something is likely fishy and we
233 * should reject them altogether.
235 if (sigcheck_gpg_status
[i
].flags
& GPG_STATUS_EXCLUSIVE
) {
236 if (seen_exclusive_status
++)
240 if (sigcheck_gpg_status
[i
].result
)
241 sigc
->result
= sigcheck_gpg_status
[i
].result
;
242 /* Do we have key information? */
243 if (sigcheck_gpg_status
[i
].flags
& GPG_STATUS_KEYID
) {
244 next
= strchrnul(line
, ' ');
245 replace_cstring(&sigc
->key
, line
, next
);
246 /* Do we have signer information? */
247 if (*next
&& (sigcheck_gpg_status
[i
].flags
& GPG_STATUS_UID
)) {
249 next
= strchrnul(line
, '\n');
250 replace_cstring(&sigc
->signer
, line
, next
);
254 /* Do we have trust level? */
255 if (sigcheck_gpg_status
[i
].flags
& GPG_STATUS_TRUST_LEVEL
) {
257 * GPG v1 and v2 differs in how the
258 * TRUST_ lines are written. Some
259 * trust lines contain no additional
260 * space-separated information for v1.
262 size_t trust_size
= strcspn(line
, " \n");
263 char *trust
= xmemdupz(line
, trust_size
);
265 if (parse_gpg_trust_level(trust
, &sigc
->trust_level
)) {
272 /* Do we have fingerprint? */
273 if (sigcheck_gpg_status
[i
].flags
& GPG_STATUS_FINGERPRINT
) {
277 next
= strchrnul(line
, ' ');
278 replace_cstring(&sigc
->fingerprint
, line
, next
);
281 * Skip interim fields. The search is
282 * limited to the same line since only
283 * OpenPGP signatures has a field with
284 * the primary fingerprint.
286 limit
= strchrnul(line
, '\n');
287 for (j
= 9; j
> 0; j
--) {
288 if (!*next
|| limit
<= next
)
291 next
= strchrnul(line
, ' ');
294 field
= &sigc
->primary_key_fingerprint
;
296 next
= strchrnul(line
, '\n');
297 replace_cstring(field
, line
, next
);
299 replace_cstring(field
, NULL
, NULL
);
311 /* Clear partial data to avoid confusion */
312 FREE_AND_NULL(sigc
->primary_key_fingerprint
);
313 FREE_AND_NULL(sigc
->fingerprint
);
314 FREE_AND_NULL(sigc
->signer
);
315 FREE_AND_NULL(sigc
->key
);
318 static int verify_gpg_signed_buffer(struct signature_check
*sigc
,
319 struct gpg_format
*fmt
,
320 const char *signature
,
321 size_t signature_size
)
323 struct child_process gpg
= CHILD_PROCESS_INIT
;
324 struct tempfile
*temp
;
326 struct strbuf gpg_stdout
= STRBUF_INIT
;
327 struct strbuf gpg_stderr
= STRBUF_INIT
;
329 temp
= mks_tempfile_t(".git_vtag_tmpXXXXXX");
331 return error_errno(_("could not create temporary file"));
332 if (write_in_full(temp
->fd
, signature
, signature_size
) < 0 ||
333 close_tempfile_gently(temp
) < 0) {
334 error_errno(_("failed writing detached signature to '%s'"),
336 delete_tempfile(&temp
);
340 strvec_push(&gpg
.args
, fmt
->program
);
341 strvec_pushv(&gpg
.args
, fmt
->verify_args
);
342 strvec_pushl(&gpg
.args
,
344 "--verify", temp
->filename
.buf
, "-",
347 sigchain_push(SIGPIPE
, SIG_IGN
);
348 ret
= pipe_command(&gpg
, sigc
->payload
, sigc
->payload_len
, &gpg_stdout
, 0,
350 sigchain_pop(SIGPIPE
);
352 delete_tempfile(&temp
);
354 ret
|= !strstr(gpg_stdout
.buf
, "\n[GNUPG:] GOODSIG ");
355 sigc
->output
= strbuf_detach(&gpg_stderr
, NULL
);
356 sigc
->gpg_status
= strbuf_detach(&gpg_stdout
, NULL
);
358 parse_gpg_output(sigc
);
360 strbuf_release(&gpg_stdout
);
361 strbuf_release(&gpg_stderr
);
366 static void parse_ssh_output(struct signature_check
*sigc
)
368 const char *line
, *principal
, *search
;
373 * ssh-keygen output should be:
374 * Good "git" signature for PRINCIPAL with RSA key SHA256:FINGERPRINT
376 * or for valid but unknown keys:
377 * Good "git" signature with RSA key SHA256:FINGERPRINT
379 * Note that "PRINCIPAL" can contain whitespace, "RSA" and
380 * "SHA256" part could be a different token that names of
381 * the algorithms used, and "FINGERPRINT" is a hexadecimal
382 * string. By finding the last occurence of " with ", we can
383 * reliably parse out the PRINCIPAL.
386 sigc
->trust_level
= TRUST_NEVER
;
388 line
= to_free
= xmemdupz(sigc
->output
, strcspn(sigc
->output
, "\n"));
390 if (skip_prefix(line
, "Good \"git\" signature for ", &line
)) {
391 /* Search for the last "with" to get the full principal */
394 search
= strstr(line
, " with ");
397 } while (search
!= NULL
);
398 if (line
== principal
)
401 /* Valid signature and known principal */
403 sigc
->trust_level
= TRUST_FULLY
;
404 sigc
->signer
= xmemdupz(principal
, line
- principal
- 1);
405 } else if (skip_prefix(line
, "Good \"git\" signature with ", &line
)) {
406 /* Valid signature, but key unknown */
408 sigc
->trust_level
= TRUST_UNDEFINED
;
413 key
= strstr(line
, "key ");
415 sigc
->fingerprint
= xstrdup(strstr(line
, "key ") + 4);
416 sigc
->key
= xstrdup(sigc
->fingerprint
);
419 * Output did not match what we expected
420 * Treat the signature as bad
429 static int verify_ssh_signed_buffer(struct signature_check
*sigc
,
430 struct gpg_format
*fmt
,
431 const char *signature
,
432 size_t signature_size
)
434 struct child_process ssh_keygen
= CHILD_PROCESS_INIT
;
435 struct tempfile
*buffer_file
;
439 struct strbuf ssh_principals_out
= STRBUF_INIT
;
440 struct strbuf ssh_principals_err
= STRBUF_INIT
;
441 struct strbuf ssh_keygen_out
= STRBUF_INIT
;
442 struct strbuf ssh_keygen_err
= STRBUF_INIT
;
443 struct strbuf verify_time
= STRBUF_INIT
;
444 const struct date_mode verify_date_mode
= {
445 .type
= DATE_STRFTIME
,
446 .strftime_fmt
= "%Y%m%d%H%M%S",
447 /* SSH signing key validity has no timezone information - Use the local timezone */
451 if (!ssh_allowed_signers
) {
452 error(_("gpg.ssh.allowedSignersFile needs to be configured and exist for ssh signature verification"));
456 buffer_file
= mks_tempfile_t(".git_vtag_tmpXXXXXX");
458 return error_errno(_("could not create temporary file"));
459 if (write_in_full(buffer_file
->fd
, signature
, signature_size
) < 0 ||
460 close_tempfile_gently(buffer_file
) < 0) {
461 error_errno(_("failed writing detached signature to '%s'"),
462 buffer_file
->filename
.buf
);
463 delete_tempfile(&buffer_file
);
467 if (sigc
->payload_timestamp
)
468 strbuf_addf(&verify_time
, "-Overify-time=%s",
469 show_date(sigc
->payload_timestamp
, 0, &verify_date_mode
));
471 /* Find the principal from the signers */
472 strvec_pushl(&ssh_keygen
.args
, fmt
->program
,
473 "-Y", "find-principals",
474 "-f", ssh_allowed_signers
,
475 "-s", buffer_file
->filename
.buf
,
478 ret
= pipe_command(&ssh_keygen
, NULL
, 0, &ssh_principals_out
, 0,
479 &ssh_principals_err
, 0);
480 if (ret
&& strstr(ssh_principals_err
.buf
, "usage:")) {
481 error(_("ssh-keygen -Y find-principals/verify is needed for ssh signature verification (available in openssh version 8.2p1+)"));
484 if (ret
|| !ssh_principals_out
.len
) {
486 * We did not find a matching principal in the allowedSigners
487 * Check without validation
489 child_process_init(&ssh_keygen
);
490 strvec_pushl(&ssh_keygen
.args
, fmt
->program
,
491 "-Y", "check-novalidate",
493 "-s", buffer_file
->filename
.buf
,
496 pipe_command(&ssh_keygen
, sigc
->payload
, sigc
->payload_len
,
497 &ssh_keygen_out
, 0, &ssh_keygen_err
, 0);
500 * Fail on unknown keys
501 * we still call check-novalidate to display the signature info
505 /* Check every principal we found (one per line) */
507 for (line
= ssh_principals_out
.buf
;
510 const char *end_of_text
;
512 next
= end_of_text
= strchrnul(line
, '\n');
514 /* Did we find a LF, and did we have CR before it? */
516 line
< end_of_text
&&
517 end_of_text
[-1] == '\r')
520 /* Unless we hit NUL, skip over the LF we found */
524 /* Not all lines are data. Skip empty ones */
525 if (line
== end_of_text
)
528 /* We now know we have an non-empty line. Process it */
529 principal
= xmemdupz(line
, end_of_text
- line
);
531 child_process_init(&ssh_keygen
);
532 strbuf_release(&ssh_keygen_out
);
533 strbuf_release(&ssh_keygen_err
);
534 strvec_push(&ssh_keygen
.args
, fmt
->program
);
536 * We found principals
537 * Try with each until we find a match
539 strvec_pushl(&ssh_keygen
.args
, "-Y", "verify",
541 "-f", ssh_allowed_signers
,
543 "-s", buffer_file
->filename
.buf
,
547 if (ssh_revocation_file
) {
548 if (file_exists(ssh_revocation_file
)) {
549 strvec_pushl(&ssh_keygen
.args
, "-r",
550 ssh_revocation_file
, NULL
);
552 warning(_("ssh signing revocation file configured but not found: %s"),
553 ssh_revocation_file
);
557 sigchain_push(SIGPIPE
, SIG_IGN
);
558 ret
= pipe_command(&ssh_keygen
, sigc
->payload
, sigc
->payload_len
,
559 &ssh_keygen_out
, 0, &ssh_keygen_err
, 0);
560 sigchain_pop(SIGPIPE
);
562 FREE_AND_NULL(principal
);
565 ret
= !starts_with(ssh_keygen_out
.buf
, "Good");
572 strbuf_stripspace(&ssh_keygen_out
, 0);
573 strbuf_stripspace(&ssh_keygen_err
, 0);
574 /* Add stderr outputs to show the user actual ssh-keygen errors */
575 strbuf_add(&ssh_keygen_out
, ssh_principals_err
.buf
, ssh_principals_err
.len
);
576 strbuf_add(&ssh_keygen_out
, ssh_keygen_err
.buf
, ssh_keygen_err
.len
);
577 sigc
->output
= strbuf_detach(&ssh_keygen_out
, NULL
);
578 sigc
->gpg_status
= xstrdup(sigc
->output
);
580 parse_ssh_output(sigc
);
584 delete_tempfile(&buffer_file
);
585 strbuf_release(&ssh_principals_out
);
586 strbuf_release(&ssh_principals_err
);
587 strbuf_release(&ssh_keygen_out
);
588 strbuf_release(&ssh_keygen_err
);
589 strbuf_release(&verify_time
);
594 static int parse_payload_metadata(struct signature_check
*sigc
)
596 const char *ident_line
= NULL
;
598 struct ident_split ident
;
599 const char *signer_header
;
601 switch (sigc
->payload_type
) {
602 case SIGNATURE_PAYLOAD_COMMIT
:
603 signer_header
= "committer";
605 case SIGNATURE_PAYLOAD_TAG
:
606 signer_header
= "tagger";
608 case SIGNATURE_PAYLOAD_UNDEFINED
:
609 case SIGNATURE_PAYLOAD_PUSH_CERT
:
610 /* Ignore payloads we don't want to parse */
613 BUG("invalid value for sigc->payload_type");
616 ident_line
= find_commit_header(sigc
->payload
, signer_header
, &ident_len
);
617 if (!ident_line
|| !ident_len
)
620 if (split_ident_line(&ident
, ident_line
, ident_len
))
623 if (!sigc
->payload_timestamp
&& ident
.date_begin
&& ident
.date_end
)
624 sigc
->payload_timestamp
= parse_timestamp(ident
.date_begin
, NULL
, 10);
629 int check_signature(struct signature_check
*sigc
,
630 const char *signature
, size_t slen
)
632 struct gpg_format
*fmt
;
636 sigc
->trust_level
= -1;
638 fmt
= get_format_by_sig(signature
);
640 die(_("bad/incompatible signature '%s'"), signature
);
642 if (parse_payload_metadata(sigc
))
645 status
= fmt
->verify_signed_buffer(sigc
, fmt
, signature
, slen
);
647 if (status
&& !sigc
->output
)
650 status
|= sigc
->result
!= 'G';
651 status
|= sigc
->trust_level
< configured_min_trust_level
;
656 void print_signature_buffer(const struct signature_check
*sigc
, unsigned flags
)
658 const char *output
= flags
& GPG_VERIFY_RAW
? sigc
->gpg_status
:
661 if (flags
& GPG_VERIFY_VERBOSE
&& sigc
->payload
)
662 fwrite(sigc
->payload
, 1, sigc
->payload_len
, stdout
);
665 fputs(output
, stderr
);
668 size_t parse_signed_buffer(const char *buf
, size_t size
)
675 if (get_format_by_sig(buf
+ len
))
678 eol
= memchr(buf
+ len
, '\n', size
- len
);
679 len
+= eol
? eol
- (buf
+ len
) + 1 : size
- len
;
684 int parse_signature(const char *buf
, size_t size
, struct strbuf
*payload
, struct strbuf
*signature
)
686 size_t match
= parse_signed_buffer(buf
, size
);
688 strbuf_add(payload
, buf
, match
);
689 remove_signature(payload
);
690 strbuf_add(signature
, buf
+ match
, size
- match
);
696 void set_signing_key(const char *key
)
698 free(configured_signing_key
);
699 configured_signing_key
= xstrdup(key
);
702 int git_gpg_config(const char *var
, const char *value
, void *cb UNUSED
)
704 struct gpg_format
*fmt
= NULL
;
705 char *fmtname
= NULL
;
709 if (!strcmp(var
, "user.signingkey")) {
711 return config_error_nonbool(var
);
712 set_signing_key(value
);
716 if (!strcmp(var
, "gpg.format")) {
718 return config_error_nonbool(var
);
719 fmt
= get_format_by_name(value
);
721 return error(_("invalid value for '%s': '%s'"),
727 if (!strcmp(var
, "gpg.mintrustlevel")) {
729 return config_error_nonbool(var
);
731 trust
= xstrdup_toupper(value
);
732 ret
= parse_gpg_trust_level(trust
, &configured_min_trust_level
);
736 return error(_("invalid value for '%s': '%s'"),
741 if (!strcmp(var
, "gpg.ssh.defaultkeycommand")) {
743 return config_error_nonbool(var
);
744 return git_config_string(&ssh_default_key_command
, var
, value
);
747 if (!strcmp(var
, "gpg.ssh.allowedsignersfile")) {
749 return config_error_nonbool(var
);
750 return git_config_pathname(&ssh_allowed_signers
, var
, value
);
753 if (!strcmp(var
, "gpg.ssh.revocationfile")) {
755 return config_error_nonbool(var
);
756 return git_config_pathname(&ssh_revocation_file
, var
, value
);
759 if (!strcmp(var
, "gpg.program") || !strcmp(var
, "gpg.openpgp.program"))
762 if (!strcmp(var
, "gpg.x509.program"))
765 if (!strcmp(var
, "gpg.ssh.program"))
769 fmt
= get_format_by_name(fmtname
);
770 return git_config_string(&fmt
->program
, var
, value
);
777 * Returns 1 if `string` contains a literal ssh key, 0 otherwise
778 * `key` will be set to the start of the actual key if a prefix is present.
780 static int is_literal_ssh_key(const char *string
, const char **key
)
782 if (skip_prefix(string
, "key::", key
))
784 if (starts_with(string
, "ssh-")) {
791 static char *get_ssh_key_fingerprint(const char *signing_key
)
793 struct child_process ssh_keygen
= CHILD_PROCESS_INIT
;
795 struct strbuf fingerprint_stdout
= STRBUF_INIT
;
796 struct strbuf
**fingerprint
;
797 char *fingerprint_ret
;
798 const char *literal_key
= NULL
;
801 * With SSH Signing this can contain a filename or a public key
802 * For textual representation we usually want a fingerprint
804 if (is_literal_ssh_key(signing_key
, &literal_key
)) {
805 strvec_pushl(&ssh_keygen
.args
, "ssh-keygen", "-lf", "-", NULL
);
806 ret
= pipe_command(&ssh_keygen
, literal_key
,
807 strlen(literal_key
), &fingerprint_stdout
, 0,
810 strvec_pushl(&ssh_keygen
.args
, "ssh-keygen", "-lf",
811 configured_signing_key
, NULL
);
812 ret
= pipe_command(&ssh_keygen
, NULL
, 0, &fingerprint_stdout
, 0,
817 die_errno(_("failed to get the ssh fingerprint for key '%s'"),
820 fingerprint
= strbuf_split_max(&fingerprint_stdout
, ' ', 3);
822 die_errno(_("failed to get the ssh fingerprint for key '%s'"),
825 fingerprint_ret
= strbuf_detach(fingerprint
[1], NULL
);
826 strbuf_list_free(fingerprint
);
827 strbuf_release(&fingerprint_stdout
);
828 return fingerprint_ret
;
831 /* Returns the first public key from an ssh-agent to use for signing */
832 static const char *get_default_ssh_signing_key(void)
834 struct child_process ssh_default_key
= CHILD_PROCESS_INIT
;
836 struct strbuf key_stdout
= STRBUF_INIT
, key_stderr
= STRBUF_INIT
;
837 struct strbuf
**keys
;
838 char *key_command
= NULL
;
841 char *default_key
= NULL
;
842 const char *literal_key
= NULL
;
844 if (!ssh_default_key_command
)
845 die(_("either user.signingkey or gpg.ssh.defaultKeyCommand needs to be configured"));
847 key_command
= xstrdup(ssh_default_key_command
);
848 n
= split_cmdline(key_command
, &argv
);
851 die("malformed build-time gpg.ssh.defaultKeyCommand: %s",
852 split_cmdline_strerror(n
));
854 strvec_pushv(&ssh_default_key
.args
, argv
);
855 ret
= pipe_command(&ssh_default_key
, NULL
, 0, &key_stdout
, 0,
859 keys
= strbuf_split_max(&key_stdout
, '\n', 2);
860 if (keys
[0] && is_literal_ssh_key(keys
[0]->buf
, &literal_key
)) {
862 * We only use `is_literal_ssh_key` here to check validity
863 * The prefix will be stripped when the key is used.
865 default_key
= strbuf_detach(keys
[0], NULL
);
867 warning(_("gpg.ssh.defaultKeyCommand succeeded but returned no keys: %s %s"),
868 key_stderr
.buf
, key_stdout
.buf
);
871 strbuf_list_free(keys
);
873 warning(_("gpg.ssh.defaultKeyCommand failed: %s %s"),
874 key_stderr
.buf
, key_stdout
.buf
);
879 strbuf_release(&key_stdout
);
884 static const char *get_ssh_key_id(void) {
885 return get_ssh_key_fingerprint(get_signing_key());
888 /* Returns a textual but unique representation of the signing key */
889 const char *get_signing_key_id(void)
891 if (use_format
->get_key_id
) {
892 return use_format
->get_key_id();
895 /* GPG/GPGSM only store a key id on this variable */
896 return get_signing_key();
899 const char *get_signing_key(void)
901 if (configured_signing_key
)
902 return configured_signing_key
;
903 if (use_format
->get_default_key
) {
904 return use_format
->get_default_key();
907 return git_committer_info(IDENT_STRICT
| IDENT_NO_DATE
);
910 const char *gpg_trust_level_to_str(enum signature_trust_level level
)
912 struct sigcheck_gpg_trust_level
*trust
;
914 if (level
< 0 || level
>= ARRAY_SIZE(sigcheck_gpg_trust_level
))
915 BUG("invalid trust level requested %d", level
);
917 trust
= &sigcheck_gpg_trust_level
[level
];
918 if (trust
->value
!= level
)
919 BUG("sigcheck_gpg_trust_level[] unsorted");
921 return sigcheck_gpg_trust_level
[level
].display_key
;
924 int sign_buffer(struct strbuf
*buffer
, struct strbuf
*signature
, const char *signing_key
)
926 return use_format
->sign_buffer(buffer
, signature
, signing_key
);
930 * Strip CR from the line endings, in case we are on Windows.
931 * NEEDSWORK: make it trim only CRs before LFs and rename
933 static void remove_cr_after(struct strbuf
*buffer
, size_t offset
)
937 for (i
= j
= offset
; i
< buffer
->len
; i
++) {
938 if (buffer
->buf
[i
] != '\r') {
940 buffer
->buf
[j
] = buffer
->buf
[i
];
944 strbuf_setlen(buffer
, j
);
947 static int sign_buffer_gpg(struct strbuf
*buffer
, struct strbuf
*signature
,
948 const char *signing_key
)
950 struct child_process gpg
= CHILD_PROCESS_INIT
;
954 struct strbuf gpg_status
= STRBUF_INIT
;
956 strvec_pushl(&gpg
.args
,
959 "-bsau", signing_key
,
962 bottom
= signature
->len
;
965 * When the username signingkey is bad, program could be terminated
966 * because gpg exits without reading and then write gets SIGPIPE.
968 sigchain_push(SIGPIPE
, SIG_IGN
);
969 ret
= pipe_command(&gpg
, buffer
->buf
, buffer
->len
,
970 signature
, 1024, &gpg_status
, 0);
971 sigchain_pop(SIGPIPE
);
973 for (cp
= gpg_status
.buf
;
974 cp
&& (cp
= strstr(cp
, "[GNUPG:] SIG_CREATED "));
976 if (cp
== gpg_status
.buf
|| cp
[-1] == '\n')
980 strbuf_release(&gpg_status
);
982 return error(_("gpg failed to sign the data"));
984 /* Strip CR from the line endings, in case we are on Windows. */
985 remove_cr_after(signature
, bottom
);
990 static int sign_buffer_ssh(struct strbuf
*buffer
, struct strbuf
*signature
,
991 const char *signing_key
)
993 struct child_process signer
= CHILD_PROCESS_INIT
;
995 size_t bottom
, keylen
;
996 struct strbuf signer_stderr
= STRBUF_INIT
;
997 struct tempfile
*key_file
= NULL
, *buffer_file
= NULL
;
998 char *ssh_signing_key_file
= NULL
;
999 struct strbuf ssh_signature_filename
= STRBUF_INIT
;
1000 const char *literal_key
= NULL
;
1001 int literal_ssh_key
= 0;
1003 if (!signing_key
|| signing_key
[0] == '\0')
1005 _("user.signingKey needs to be set for ssh signing"));
1007 if (is_literal_ssh_key(signing_key
, &literal_key
)) {
1008 /* A literal ssh key */
1009 literal_ssh_key
= 1;
1010 key_file
= mks_tempfile_t(".git_signing_key_tmpXXXXXX");
1013 _("could not create temporary file"));
1014 keylen
= strlen(literal_key
);
1015 if (write_in_full(key_file
->fd
, literal_key
, keylen
) < 0 ||
1016 close_tempfile_gently(key_file
) < 0) {
1017 error_errno(_("failed writing ssh signing key to '%s'"),
1018 key_file
->filename
.buf
);
1021 ssh_signing_key_file
= strbuf_detach(&key_file
->filename
, NULL
);
1023 /* We assume a file */
1024 ssh_signing_key_file
= expand_user_path(signing_key
, 1);
1027 buffer_file
= mks_tempfile_t(".git_signing_buffer_tmpXXXXXX");
1029 error_errno(_("could not create temporary file"));
1033 if (write_in_full(buffer_file
->fd
, buffer
->buf
, buffer
->len
) < 0 ||
1034 close_tempfile_gently(buffer_file
) < 0) {
1035 error_errno(_("failed writing ssh signing key buffer to '%s'"),
1036 buffer_file
->filename
.buf
);
1040 strvec_pushl(&signer
.args
, use_format
->program
,
1043 "-f", ssh_signing_key_file
,
1045 if (literal_ssh_key
)
1046 strvec_push(&signer
.args
, "-U");
1047 strvec_push(&signer
.args
, buffer_file
->filename
.buf
);
1049 sigchain_push(SIGPIPE
, SIG_IGN
);
1050 ret
= pipe_command(&signer
, NULL
, 0, NULL
, 0, &signer_stderr
, 0);
1051 sigchain_pop(SIGPIPE
);
1054 if (strstr(signer_stderr
.buf
, "usage:"))
1055 error(_("ssh-keygen -Y sign is needed for ssh signing (available in openssh version 8.2p1+)"));
1057 error("%s", signer_stderr
.buf
);
1061 bottom
= signature
->len
;
1063 strbuf_addbuf(&ssh_signature_filename
, &buffer_file
->filename
);
1064 strbuf_addstr(&ssh_signature_filename
, ".sig");
1065 if (strbuf_read_file(signature
, ssh_signature_filename
.buf
, 0) < 0) {
1067 _("failed reading ssh signing data buffer from '%s'"),
1068 ssh_signature_filename
.buf
);
1071 /* Strip CR from the line endings, in case we are on Windows. */
1072 remove_cr_after(signature
, bottom
);
1076 delete_tempfile(&key_file
);
1078 delete_tempfile(&buffer_file
);
1079 if (ssh_signature_filename
.len
)
1080 unlink_or_warn(ssh_signature_filename
.buf
);
1081 strbuf_release(&signer_stderr
);
1082 strbuf_release(&ssh_signature_filename
);
1083 FREE_AND_NULL(ssh_signing_key_file
);