Merge branch 'ab/remove-implicit-use-of-the-repository'
[git.git] / bisect.c
blobd55f2a4da5d2d8708a482a1f543eddb1cc47a115
1 #include "cache.h"
2 #include "config.h"
3 #include "commit.h"
4 #include "diff.h"
5 #include "hex.h"
6 #include "revision.h"
7 #include "refs.h"
8 #include "list-objects.h"
9 #include "quote.h"
10 #include "hash-lookup.h"
11 #include "run-command.h"
12 #include "log-tree.h"
13 #include "bisect.h"
14 #include "oid-array.h"
15 #include "strvec.h"
16 #include "commit-slab.h"
17 #include "commit-reach.h"
18 #include "object-store.h"
19 #include "dir.h"
21 static struct oid_array good_revs;
22 static struct oid_array skipped_revs;
24 static struct object_id *current_bad_oid;
26 static const char *term_bad;
27 static const char *term_good;
29 /* Remember to update object flag allocation in object.h */
30 #define COUNTED (1u<<16)
33 * This is a truly stupid algorithm, but it's only
34 * used for bisection, and we just don't care enough.
36 * We care just barely enough to avoid recursing for
37 * non-merge entries.
39 static int count_distance(struct commit_list *entry)
41 int nr = 0;
43 while (entry) {
44 struct commit *commit = entry->item;
45 struct commit_list *p;
47 if (commit->object.flags & (UNINTERESTING | COUNTED))
48 break;
49 if (!(commit->object.flags & TREESAME))
50 nr++;
51 commit->object.flags |= COUNTED;
52 p = commit->parents;
53 entry = p;
54 if (p) {
55 p = p->next;
56 while (p) {
57 nr += count_distance(p);
58 p = p->next;
63 return nr;
66 static void clear_distance(struct commit_list *list)
68 while (list) {
69 struct commit *commit = list->item;
70 commit->object.flags &= ~COUNTED;
71 list = list->next;
75 define_commit_slab(commit_weight, int *);
76 static struct commit_weight commit_weight;
78 #define DEBUG_BISECT 0
80 static inline int weight(struct commit_list *elem)
82 return **commit_weight_at(&commit_weight, elem->item);
85 static inline void weight_set(struct commit_list *elem, int weight)
87 **commit_weight_at(&commit_weight, elem->item) = weight;
90 static int count_interesting_parents(struct commit *commit, unsigned bisect_flags)
92 struct commit_list *p;
93 int count;
95 for (count = 0, p = commit->parents; p; p = p->next) {
96 if (!(p->item->object.flags & UNINTERESTING))
97 count++;
98 if (bisect_flags & FIND_BISECTION_FIRST_PARENT_ONLY)
99 break;
101 return count;
104 static inline int approx_halfway(struct commit_list *p, int nr)
106 int diff;
109 * Don't short-cut something we are not going to return!
111 if (p->item->object.flags & TREESAME)
112 return 0;
113 if (DEBUG_BISECT)
114 return 0;
116 * For small number of commits 2 and 3 are halfway of 5, and
117 * 3 is halfway of 6 but 2 and 4 are not.
119 diff = 2 * weight(p) - nr;
120 switch (diff) {
121 case -1: case 0: case 1:
122 return 1;
123 default:
125 * For large number of commits we are not so strict, it's
126 * good enough if it's within ~0.1% of the halfway point,
127 * e.g. 5000 is exactly halfway of 10000, but we consider
128 * the values [4996, 5004] as halfway as well.
130 if (abs(diff) < nr / 1024)
131 return 1;
132 return 0;
136 static void show_list(const char *debug, int counted, int nr,
137 struct commit_list *list)
139 struct commit_list *p;
141 if (!DEBUG_BISECT)
142 return;
144 fprintf(stderr, "%s (%d/%d)\n", debug, counted, nr);
146 for (p = list; p; p = p->next) {
147 struct commit_list *pp;
148 struct commit *commit = p->item;
149 unsigned commit_flags = commit->object.flags;
150 enum object_type type;
151 unsigned long size;
152 char *buf = repo_read_object_file(the_repository,
153 &commit->object.oid, &type,
154 &size);
155 const char *subject_start;
156 int subject_len;
158 fprintf(stderr, "%c%c%c ",
159 (commit_flags & TREESAME) ? ' ' : 'T',
160 (commit_flags & UNINTERESTING) ? 'U' : ' ',
161 (commit_flags & COUNTED) ? 'C' : ' ');
162 if (*commit_weight_at(&commit_weight, p->item))
163 fprintf(stderr, "%3d", weight(p));
164 else
165 fprintf(stderr, "---");
166 fprintf(stderr, " %.*s", 8, oid_to_hex(&commit->object.oid));
167 for (pp = commit->parents; pp; pp = pp->next)
168 fprintf(stderr, " %.*s", 8,
169 oid_to_hex(&pp->item->object.oid));
171 subject_len = find_commit_subject(buf, &subject_start);
172 if (subject_len)
173 fprintf(stderr, " %.*s", subject_len, subject_start);
174 fprintf(stderr, "\n");
178 static struct commit_list *best_bisection(struct commit_list *list, int nr)
180 struct commit_list *p, *best;
181 int best_distance = -1;
183 best = list;
184 for (p = list; p; p = p->next) {
185 int distance;
186 unsigned commit_flags = p->item->object.flags;
188 if (commit_flags & TREESAME)
189 continue;
190 distance = weight(p);
191 if (nr - distance < distance)
192 distance = nr - distance;
193 if (distance > best_distance) {
194 best = p;
195 best_distance = distance;
199 return best;
202 struct commit_dist {
203 struct commit *commit;
204 int distance;
207 static int compare_commit_dist(const void *a_, const void *b_)
209 struct commit_dist *a, *b;
211 a = (struct commit_dist *)a_;
212 b = (struct commit_dist *)b_;
213 if (a->distance != b->distance)
214 return b->distance - a->distance; /* desc sort */
215 return oidcmp(&a->commit->object.oid, &b->commit->object.oid);
218 static struct commit_list *best_bisection_sorted(struct commit_list *list, int nr)
220 struct commit_list *p;
221 struct commit_dist *array = xcalloc(nr, sizeof(*array));
222 struct strbuf buf = STRBUF_INIT;
223 int cnt, i;
225 for (p = list, cnt = 0; p; p = p->next) {
226 int distance;
227 unsigned commit_flags = p->item->object.flags;
229 if (commit_flags & TREESAME)
230 continue;
231 distance = weight(p);
232 if (nr - distance < distance)
233 distance = nr - distance;
234 array[cnt].commit = p->item;
235 array[cnt].distance = distance;
236 cnt++;
238 QSORT(array, cnt, compare_commit_dist);
239 for (p = list, i = 0; i < cnt; i++) {
240 struct object *obj = &(array[i].commit->object);
242 strbuf_reset(&buf);
243 strbuf_addf(&buf, "dist=%d", array[i].distance);
244 add_name_decoration(DECORATION_NONE, buf.buf, obj);
246 p->item = array[i].commit;
247 if (i < cnt - 1)
248 p = p->next;
250 if (p) {
251 free_commit_list(p->next);
252 p->next = NULL;
254 strbuf_release(&buf);
255 free(array);
256 return list;
260 * zero or positive weight is the number of interesting commits it can
261 * reach, including itself. Especially, weight = 0 means it does not
262 * reach any tree-changing commits (e.g. just above uninteresting one
263 * but traversal is with pathspec).
265 * weight = -1 means it has one parent and its distance is yet to
266 * be computed.
268 * weight = -2 means it has more than one parent and its distance is
269 * unknown. After running count_distance() first, they will get zero
270 * or positive distance.
272 static struct commit_list *do_find_bisection(struct commit_list *list,
273 int nr, int *weights,
274 unsigned bisect_flags)
276 int n, counted;
277 struct commit_list *p;
279 counted = 0;
281 for (n = 0, p = list; p; p = p->next) {
282 struct commit *commit = p->item;
283 unsigned commit_flags = commit->object.flags;
285 *commit_weight_at(&commit_weight, p->item) = &weights[n++];
286 switch (count_interesting_parents(commit, bisect_flags)) {
287 case 0:
288 if (!(commit_flags & TREESAME)) {
289 weight_set(p, 1);
290 counted++;
291 show_list("bisection 2 count one",
292 counted, nr, list);
295 * otherwise, it is known not to reach any
296 * tree-changing commit and gets weight 0.
298 break;
299 case 1:
300 weight_set(p, -1);
301 break;
302 default:
303 weight_set(p, -2);
304 break;
308 show_list("bisection 2 initialize", counted, nr, list);
311 * If you have only one parent in the resulting set
312 * then you can reach one commit more than that parent
313 * can reach. So we do not have to run the expensive
314 * count_distance() for single strand of pearls.
316 * However, if you have more than one parents, you cannot
317 * just add their distance and one for yourself, since
318 * they usually reach the same ancestor and you would
319 * end up counting them twice that way.
321 * So we will first count distance of merges the usual
322 * way, and then fill the blanks using cheaper algorithm.
324 for (p = list; p; p = p->next) {
325 if (p->item->object.flags & UNINTERESTING)
326 continue;
327 if (weight(p) != -2)
328 continue;
329 if (bisect_flags & FIND_BISECTION_FIRST_PARENT_ONLY)
330 BUG("shouldn't be calling count-distance in fp mode");
331 weight_set(p, count_distance(p));
332 clear_distance(list);
334 /* Does it happen to be at half-way? */
335 if (!(bisect_flags & FIND_BISECTION_ALL) &&
336 approx_halfway(p, nr))
337 return p;
338 counted++;
341 show_list("bisection 2 count_distance", counted, nr, list);
343 while (counted < nr) {
344 for (p = list; p; p = p->next) {
345 struct commit_list *q;
346 unsigned commit_flags = p->item->object.flags;
348 if (0 <= weight(p))
349 continue;
351 for (q = p->item->parents;
353 q = bisect_flags & FIND_BISECTION_FIRST_PARENT_ONLY ? NULL : q->next) {
354 if (q->item->object.flags & UNINTERESTING)
355 continue;
356 if (0 <= weight(q))
357 break;
359 if (!q)
360 continue;
363 * weight for p is unknown but q is known.
364 * add one for p itself if p is to be counted,
365 * otherwise inherit it from q directly.
367 if (!(commit_flags & TREESAME)) {
368 weight_set(p, weight(q)+1);
369 counted++;
370 show_list("bisection 2 count one",
371 counted, nr, list);
373 else
374 weight_set(p, weight(q));
376 /* Does it happen to be at half-way? */
377 if (!(bisect_flags & FIND_BISECTION_ALL) &&
378 approx_halfway(p, nr))
379 return p;
383 show_list("bisection 2 counted all", counted, nr, list);
385 if (!(bisect_flags & FIND_BISECTION_ALL))
386 return best_bisection(list, nr);
387 else
388 return best_bisection_sorted(list, nr);
391 void find_bisection(struct commit_list **commit_list, int *reaches,
392 int *all, unsigned bisect_flags)
394 int nr, on_list;
395 struct commit_list *list, *p, *best, *next, *last;
396 int *weights;
398 show_list("bisection 2 entry", 0, 0, *commit_list);
399 init_commit_weight(&commit_weight);
402 * Count the number of total and tree-changing items on the
403 * list, while reversing the list.
405 for (nr = on_list = 0, last = NULL, p = *commit_list;
407 p = next) {
408 unsigned commit_flags = p->item->object.flags;
410 next = p->next;
411 if (commit_flags & UNINTERESTING) {
412 free(p);
413 continue;
415 p->next = last;
416 last = p;
417 if (!(commit_flags & TREESAME))
418 nr++;
419 on_list++;
421 list = last;
422 show_list("bisection 2 sorted", 0, nr, list);
424 *all = nr;
425 CALLOC_ARRAY(weights, on_list);
427 /* Do the real work of finding bisection commit. */
428 best = do_find_bisection(list, nr, weights, bisect_flags);
429 if (best) {
430 if (!(bisect_flags & FIND_BISECTION_ALL)) {
431 list->item = best->item;
432 free_commit_list(list->next);
433 best = list;
434 best->next = NULL;
436 *reaches = weight(best);
438 free(weights);
439 *commit_list = best;
440 clear_commit_weight(&commit_weight);
443 static int register_ref(const char *refname, const struct object_id *oid,
444 int flags UNUSED, void *cb_data UNUSED)
446 struct strbuf good_prefix = STRBUF_INIT;
447 strbuf_addstr(&good_prefix, term_good);
448 strbuf_addstr(&good_prefix, "-");
450 if (!strcmp(refname, term_bad)) {
451 current_bad_oid = xmalloc(sizeof(*current_bad_oid));
452 oidcpy(current_bad_oid, oid);
453 } else if (starts_with(refname, good_prefix.buf)) {
454 oid_array_append(&good_revs, oid);
455 } else if (starts_with(refname, "skip-")) {
456 oid_array_append(&skipped_revs, oid);
459 strbuf_release(&good_prefix);
461 return 0;
464 static int read_bisect_refs(void)
466 return for_each_ref_in("refs/bisect/", register_ref, NULL);
469 static GIT_PATH_FUNC(git_path_bisect_names, "BISECT_NAMES")
470 static GIT_PATH_FUNC(git_path_bisect_expected_rev, "BISECT_EXPECTED_REV")
471 static GIT_PATH_FUNC(git_path_bisect_ancestors_ok, "BISECT_ANCESTORS_OK")
472 static GIT_PATH_FUNC(git_path_bisect_run, "BISECT_RUN")
473 static GIT_PATH_FUNC(git_path_bisect_start, "BISECT_START")
474 static GIT_PATH_FUNC(git_path_bisect_log, "BISECT_LOG")
475 static GIT_PATH_FUNC(git_path_bisect_terms, "BISECT_TERMS")
476 static GIT_PATH_FUNC(git_path_bisect_first_parent, "BISECT_FIRST_PARENT")
478 static void read_bisect_paths(struct strvec *array)
480 struct strbuf str = STRBUF_INIT;
481 const char *filename = git_path_bisect_names();
482 FILE *fp = xfopen(filename, "r");
484 while (strbuf_getline_lf(&str, fp) != EOF) {
485 strbuf_trim(&str);
486 if (sq_dequote_to_strvec(str.buf, array))
487 die(_("Badly quoted content in file '%s': %s"),
488 filename, str.buf);
491 strbuf_release(&str);
492 fclose(fp);
495 static char *join_oid_array_hex(struct oid_array *array, char delim)
497 struct strbuf joined_hexs = STRBUF_INIT;
498 int i;
500 for (i = 0; i < array->nr; i++) {
501 strbuf_addstr(&joined_hexs, oid_to_hex(array->oid + i));
502 if (i + 1 < array->nr)
503 strbuf_addch(&joined_hexs, delim);
506 return strbuf_detach(&joined_hexs, NULL);
510 * In this function, passing a not NULL skipped_first is very special.
511 * It means that we want to know if the first commit in the list is
512 * skipped because we will want to test a commit away from it if it is
513 * indeed skipped.
514 * So if the first commit is skipped, we cannot take the shortcut to
515 * just "return list" when we find the first non skipped commit, we
516 * have to return a fully filtered list.
518 * We use (*skipped_first == -1) to mean "it has been found that the
519 * first commit is not skipped". In this case *skipped_first is set back
520 * to 0 just before the function returns.
522 struct commit_list *filter_skipped(struct commit_list *list,
523 struct commit_list **tried,
524 int show_all,
525 int *count,
526 int *skipped_first)
528 struct commit_list *filtered = NULL, **f = &filtered;
530 *tried = NULL;
532 if (skipped_first)
533 *skipped_first = 0;
534 if (count)
535 *count = 0;
537 if (!skipped_revs.nr)
538 return list;
540 while (list) {
541 struct commit_list *next = list->next;
542 list->next = NULL;
543 if (0 <= oid_array_lookup(&skipped_revs, &list->item->object.oid)) {
544 if (skipped_first && !*skipped_first)
545 *skipped_first = 1;
546 /* Move current to tried list */
547 *tried = list;
548 tried = &list->next;
549 } else {
550 if (!show_all) {
551 if (!skipped_first || !*skipped_first)
552 return list;
553 } else if (skipped_first && !*skipped_first) {
554 /* This means we know it's not skipped */
555 *skipped_first = -1;
557 /* Move current to filtered list */
558 *f = list;
559 f = &list->next;
560 if (count)
561 (*count)++;
563 list = next;
566 if (skipped_first && *skipped_first == -1)
567 *skipped_first = 0;
569 return filtered;
572 #define PRN_MODULO 32768
575 * This is a pseudo random number generator based on "man 3 rand".
576 * It is not used properly because the seed is the argument and it
577 * is increased by one between each call, but that should not matter
578 * for this application.
580 static unsigned get_prn(unsigned count)
582 count = count * 1103515245 + 12345;
583 return (count/65536) % PRN_MODULO;
587 * Custom integer square root from
588 * https://en.wikipedia.org/wiki/Integer_square_root
590 static int sqrti(int val)
592 float d, x = val;
594 if (!val)
595 return 0;
597 do {
598 float y = (x + (float)val / x) / 2;
599 d = (y > x) ? y - x : x - y;
600 x = y;
601 } while (d >= 0.5);
603 return (int)x;
606 static struct commit_list *skip_away(struct commit_list *list, int count)
608 struct commit_list *cur, *previous;
609 int prn, index, i;
611 prn = get_prn(count);
612 index = (count * prn / PRN_MODULO) * sqrti(prn) / sqrti(PRN_MODULO);
614 cur = list;
615 previous = NULL;
617 for (i = 0; cur; cur = cur->next, i++) {
618 if (i == index) {
619 if (!oideq(&cur->item->object.oid, current_bad_oid))
620 return cur;
621 if (previous)
622 return previous;
623 return list;
625 previous = cur;
628 return list;
631 static struct commit_list *managed_skipped(struct commit_list *list,
632 struct commit_list **tried)
634 int count, skipped_first;
636 *tried = NULL;
638 if (!skipped_revs.nr)
639 return list;
641 list = filter_skipped(list, tried, 0, &count, &skipped_first);
643 if (!skipped_first)
644 return list;
646 return skip_away(list, count);
649 static void bisect_rev_setup(struct repository *r, struct rev_info *revs,
650 struct strvec *rev_argv,
651 const char *prefix,
652 const char *bad_format, const char *good_format,
653 int read_paths)
655 struct setup_revision_opt opt = {
656 .free_removed_argv_elements = 1,
658 int i;
660 repo_init_revisions(r, revs, prefix);
661 revs->abbrev = 0;
662 revs->commit_format = CMIT_FMT_UNSPECIFIED;
664 /* rev_argv.argv[0] will be ignored by setup_revisions */
665 strvec_push(rev_argv, "bisect_rev_setup");
666 strvec_pushf(rev_argv, bad_format, oid_to_hex(current_bad_oid));
667 for (i = 0; i < good_revs.nr; i++)
668 strvec_pushf(rev_argv, good_format,
669 oid_to_hex(good_revs.oid + i));
670 strvec_push(rev_argv, "--");
671 if (read_paths)
672 read_bisect_paths(rev_argv);
674 setup_revisions(rev_argv->nr, rev_argv->v, revs, &opt);
677 static void bisect_common(struct rev_info *revs)
679 if (prepare_revision_walk(revs))
680 die("revision walk setup failed");
681 if (revs->tree_objects)
682 mark_edges_uninteresting(revs, NULL, 0);
685 static enum bisect_error error_if_skipped_commits(struct commit_list *tried,
686 const struct object_id *bad)
688 if (!tried)
689 return BISECT_OK;
691 printf("There are only 'skip'ped commits left to test.\n"
692 "The first %s commit could be any of:\n", term_bad);
694 for ( ; tried; tried = tried->next)
695 printf("%s\n", oid_to_hex(&tried->item->object.oid));
697 if (bad)
698 printf("%s\n", oid_to_hex(bad));
699 printf(_("We cannot bisect more!\n"));
701 return BISECT_ONLY_SKIPPED_LEFT;
704 static int is_expected_rev(const struct object_id *oid)
706 const char *filename = git_path_bisect_expected_rev();
707 struct stat st;
708 struct strbuf str = STRBUF_INIT;
709 FILE *fp;
710 int res = 0;
712 if (stat(filename, &st) || !S_ISREG(st.st_mode))
713 return 0;
715 fp = fopen_or_warn(filename, "r");
716 if (!fp)
717 return 0;
719 if (strbuf_getline_lf(&str, fp) != EOF)
720 res = !strcmp(str.buf, oid_to_hex(oid));
722 strbuf_release(&str);
723 fclose(fp);
725 return res;
728 enum bisect_error bisect_checkout(const struct object_id *bisect_rev,
729 int no_checkout)
731 struct commit *commit;
732 struct pretty_print_context pp = {0};
733 struct strbuf commit_msg = STRBUF_INIT;
735 update_ref(NULL, "BISECT_EXPECTED_REV", bisect_rev, NULL, 0, UPDATE_REFS_DIE_ON_ERR);
737 if (no_checkout) {
738 update_ref(NULL, "BISECT_HEAD", bisect_rev, NULL, 0,
739 UPDATE_REFS_DIE_ON_ERR);
740 } else {
741 struct child_process cmd = CHILD_PROCESS_INIT;
743 cmd.git_cmd = 1;
744 strvec_pushl(&cmd.args, "checkout", "-q",
745 oid_to_hex(bisect_rev), "--", NULL);
746 if (run_command(&cmd))
748 * Errors in `run_command()` itself, signaled by res < 0,
749 * and errors in the child process, signaled by res > 0
750 * can both be treated as regular BISECT_FAILED (-1).
752 return BISECT_FAILED;
755 commit = lookup_commit_reference(the_repository, bisect_rev);
756 repo_format_commit_message(the_repository, commit, "[%H] %s%n",
757 &commit_msg, &pp);
758 fputs(commit_msg.buf, stdout);
759 strbuf_release(&commit_msg);
761 return BISECT_OK;
764 static struct commit *get_commit_reference(struct repository *r,
765 const struct object_id *oid)
767 struct commit *c = lookup_commit_reference(r, oid);
768 if (!c)
769 die(_("Not a valid commit name %s"), oid_to_hex(oid));
770 return c;
773 static struct commit **get_bad_and_good_commits(struct repository *r,
774 int *rev_nr)
776 struct commit **rev;
777 int i, n = 0;
779 ALLOC_ARRAY(rev, 1 + good_revs.nr);
780 rev[n++] = get_commit_reference(r, current_bad_oid);
781 for (i = 0; i < good_revs.nr; i++)
782 rev[n++] = get_commit_reference(r, good_revs.oid + i);
783 *rev_nr = n;
785 return rev;
788 static enum bisect_error handle_bad_merge_base(void)
790 if (is_expected_rev(current_bad_oid)) {
791 char *bad_hex = oid_to_hex(current_bad_oid);
792 char *good_hex = join_oid_array_hex(&good_revs, ' ');
793 if (!strcmp(term_bad, "bad") && !strcmp(term_good, "good")) {
794 fprintf(stderr, _("The merge base %s is bad.\n"
795 "This means the bug has been fixed "
796 "between %s and [%s].\n"),
797 bad_hex, bad_hex, good_hex);
798 } else if (!strcmp(term_bad, "new") && !strcmp(term_good, "old")) {
799 fprintf(stderr, _("The merge base %s is new.\n"
800 "The property has changed "
801 "between %s and [%s].\n"),
802 bad_hex, bad_hex, good_hex);
803 } else {
804 fprintf(stderr, _("The merge base %s is %s.\n"
805 "This means the first '%s' commit is "
806 "between %s and [%s].\n"),
807 bad_hex, term_bad, term_good, bad_hex, good_hex);
809 return BISECT_MERGE_BASE_CHECK;
812 fprintf(stderr, _("Some %s revs are not ancestors of the %s rev.\n"
813 "git bisect cannot work properly in this case.\n"
814 "Maybe you mistook %s and %s revs?\n"),
815 term_good, term_bad, term_good, term_bad);
816 return BISECT_FAILED;
819 static void handle_skipped_merge_base(const struct object_id *mb)
821 char *mb_hex = oid_to_hex(mb);
822 char *bad_hex = oid_to_hex(current_bad_oid);
823 char *good_hex = join_oid_array_hex(&good_revs, ' ');
825 warning(_("the merge base between %s and [%s] "
826 "must be skipped.\n"
827 "So we cannot be sure the first %s commit is "
828 "between %s and %s.\n"
829 "We continue anyway."),
830 bad_hex, good_hex, term_bad, mb_hex, bad_hex);
831 free(good_hex);
835 * "check_merge_bases" checks that merge bases are not "bad" (or "new").
837 * - If one is "bad" (or "new"), it means the user assumed something wrong
838 * and we must return error with a non 0 error code.
839 * - If one is "good" (or "old"), that's good, we have nothing to do.
840 * - If one is "skipped", we can't know but we should warn.
841 * - If we don't know, we should check it out and ask the user to test.
842 * - If a merge base must be tested, on success return
843 * BISECT_INTERNAL_SUCCESS_MERGE_BASE (-11) a special condition
844 * for early success, this will be converted back to 0 in
845 * check_good_are_ancestors_of_bad().
847 static enum bisect_error check_merge_bases(int rev_nr, struct commit **rev, int no_checkout)
849 enum bisect_error res = BISECT_OK;
850 struct commit_list *result;
852 result = repo_get_merge_bases_many(the_repository, rev[0], rev_nr - 1,
853 rev + 1);
855 for (; result; result = result->next) {
856 const struct object_id *mb = &result->item->object.oid;
857 if (oideq(mb, current_bad_oid)) {
858 res = handle_bad_merge_base();
859 break;
860 } else if (0 <= oid_array_lookup(&good_revs, mb)) {
861 continue;
862 } else if (0 <= oid_array_lookup(&skipped_revs, mb)) {
863 handle_skipped_merge_base(mb);
864 } else {
865 printf(_("Bisecting: a merge base must be tested\n"));
866 res = bisect_checkout(mb, no_checkout);
867 if (!res)
868 /* indicate early success */
869 res = BISECT_INTERNAL_SUCCESS_MERGE_BASE;
870 break;
874 free_commit_list(result);
875 return res;
878 static int check_ancestors(struct repository *r, int rev_nr,
879 struct commit **rev, const char *prefix)
881 struct strvec rev_argv = STRVEC_INIT;
882 struct rev_info revs;
883 int res;
885 bisect_rev_setup(r, &revs, &rev_argv, prefix, "^%s", "%s", 0);
887 bisect_common(&revs);
888 res = (revs.commits != NULL);
890 /* Clean up objects used, as they will be reused. */
891 clear_commit_marks_many(rev_nr, rev, ALL_REV_FLAGS);
893 release_revisions(&revs);
894 strvec_clear(&rev_argv);
895 return res;
899 * "check_good_are_ancestors_of_bad" checks that all "good" revs are
900 * ancestor of the "bad" rev.
902 * If that's not the case, we need to check the merge bases.
903 * If a merge base must be tested by the user, its source code will be
904 * checked out to be tested by the user and we will return.
907 static enum bisect_error check_good_are_ancestors_of_bad(struct repository *r,
908 const char *prefix,
909 int no_checkout)
911 char *filename;
912 struct stat st;
913 int fd, rev_nr;
914 enum bisect_error res = BISECT_OK;
915 struct commit **rev;
917 if (!current_bad_oid)
918 return error(_("a %s revision is needed"), term_bad);
920 filename = git_pathdup("BISECT_ANCESTORS_OK");
922 /* Check if file BISECT_ANCESTORS_OK exists. */
923 if (!stat(filename, &st) && S_ISREG(st.st_mode))
924 goto done;
926 /* Bisecting with no good rev is ok. */
927 if (!good_revs.nr)
928 goto done;
930 /* Check if all good revs are ancestor of the bad rev. */
932 rev = get_bad_and_good_commits(r, &rev_nr);
933 if (check_ancestors(r, rev_nr, rev, prefix))
934 res = check_merge_bases(rev_nr, rev, no_checkout);
935 free(rev);
937 if (!res) {
938 /* Create file BISECT_ANCESTORS_OK. */
939 fd = open(filename, O_CREAT | O_TRUNC | O_WRONLY, 0600);
940 if (fd < 0)
942 * BISECT_ANCESTORS_OK file is not absolutely necessary,
943 * the bisection process will continue at the next
944 * bisection step.
945 * So, just signal with a warning that something
946 * might be wrong.
948 warning_errno(_("could not create file '%s'"),
949 filename);
950 else
951 close(fd);
953 done:
954 free(filename);
955 return res;
959 * This does "git diff-tree --pretty COMMIT" without one fork+exec.
961 static void show_diff_tree(struct repository *r,
962 const char *prefix,
963 struct commit *commit)
965 const char *argv[] = {
966 "diff-tree", "--pretty", "--stat", "--summary", "--cc", NULL
968 struct rev_info opt;
970 git_config(git_diff_ui_config, NULL);
971 repo_init_revisions(r, &opt, prefix);
973 setup_revisions(ARRAY_SIZE(argv) - 1, argv, &opt, NULL);
974 log_tree_commit(&opt, commit);
975 release_revisions(&opt);
979 * The terms used for this bisect session are stored in BISECT_TERMS.
980 * We read them and store them to adapt the messages accordingly.
981 * Default is bad/good.
983 void read_bisect_terms(const char **read_bad, const char **read_good)
985 struct strbuf str = STRBUF_INIT;
986 const char *filename = git_path_bisect_terms();
987 FILE *fp = fopen(filename, "r");
989 if (!fp) {
990 if (errno == ENOENT) {
991 *read_bad = "bad";
992 *read_good = "good";
993 return;
994 } else {
995 die_errno(_("could not read file '%s'"), filename);
997 } else {
998 strbuf_getline_lf(&str, fp);
999 *read_bad = strbuf_detach(&str, NULL);
1000 strbuf_getline_lf(&str, fp);
1001 *read_good = strbuf_detach(&str, NULL);
1003 strbuf_release(&str);
1004 fclose(fp);
1008 * We use the convention that return BISECT_INTERNAL_SUCCESS_1ST_BAD_FOUND (-10) means
1009 * the bisection process finished successfully.
1010 * In this case the calling function or command should not turn a
1011 * BISECT_INTERNAL_SUCCESS_1ST_BAD_FOUND return code into an error or a non zero exit code.
1013 * Checking BISECT_INTERNAL_SUCCESS_1ST_BAD_FOUND
1014 * in bisect_helper::bisect_next() and only transforming it to 0 at
1015 * the end of bisect_helper::cmd_bisect__helper() helps bypassing
1016 * all the code related to finding a commit to test.
1018 enum bisect_error bisect_next_all(struct repository *r, const char *prefix)
1020 struct strvec rev_argv = STRVEC_INIT;
1021 struct rev_info revs = REV_INFO_INIT;
1022 struct commit_list *tried;
1023 int reaches = 0, all = 0, nr, steps;
1024 enum bisect_error res = BISECT_OK;
1025 struct object_id *bisect_rev;
1026 char *steps_msg;
1028 * If no_checkout is non-zero, the bisection process does not
1029 * checkout the trial commit but instead simply updates BISECT_HEAD.
1031 int no_checkout = ref_exists("BISECT_HEAD");
1032 unsigned bisect_flags = 0;
1034 read_bisect_terms(&term_bad, &term_good);
1035 if (read_bisect_refs())
1036 die(_("reading bisect refs failed"));
1038 if (file_exists(git_path_bisect_first_parent()))
1039 bisect_flags |= FIND_BISECTION_FIRST_PARENT_ONLY;
1041 if (skipped_revs.nr)
1042 bisect_flags |= FIND_BISECTION_ALL;
1044 res = check_good_are_ancestors_of_bad(r, prefix, no_checkout);
1045 if (res)
1046 goto cleanup;
1048 bisect_rev_setup(r, &revs, &rev_argv, prefix, "%s", "^%s", 1);
1050 revs.first_parent_only = !!(bisect_flags & FIND_BISECTION_FIRST_PARENT_ONLY);
1051 revs.limited = 1;
1053 bisect_common(&revs);
1055 find_bisection(&revs.commits, &reaches, &all, bisect_flags);
1056 revs.commits = managed_skipped(revs.commits, &tried);
1058 if (!revs.commits) {
1060 * We should return error here only if the "bad"
1061 * commit is also a "skip" commit.
1063 res = error_if_skipped_commits(tried, NULL);
1064 if (res < 0)
1065 goto cleanup;
1066 printf(_("%s was both %s and %s\n"),
1067 oid_to_hex(current_bad_oid),
1068 term_good,
1069 term_bad);
1071 res = BISECT_FAILED;
1072 goto cleanup;
1075 if (!all) {
1076 fprintf(stderr, _("No testable commit found.\n"
1077 "Maybe you started with bad path arguments?\n"));
1079 res = BISECT_NO_TESTABLE_COMMIT;
1080 goto cleanup;
1083 bisect_rev = &revs.commits->item->object.oid;
1085 if (oideq(bisect_rev, current_bad_oid)) {
1086 res = error_if_skipped_commits(tried, current_bad_oid);
1087 if (res)
1088 return res;
1089 printf("%s is the first %s commit\n", oid_to_hex(bisect_rev),
1090 term_bad);
1092 show_diff_tree(r, prefix, revs.commits->item);
1094 * This means the bisection process succeeded.
1095 * Using BISECT_INTERNAL_SUCCESS_1ST_BAD_FOUND (-10)
1096 * so that the call chain can simply check
1097 * for negative return values for early returns up
1098 * until the cmd_bisect__helper() caller.
1100 res = BISECT_INTERNAL_SUCCESS_1ST_BAD_FOUND;
1101 goto cleanup;
1104 nr = all - reaches - 1;
1105 steps = estimate_bisect_steps(all);
1107 steps_msg = xstrfmt(Q_("(roughly %d step)", "(roughly %d steps)",
1108 steps), steps);
1110 * TRANSLATORS: the last %s will be replaced with "(roughly %d
1111 * steps)" translation.
1113 printf(Q_("Bisecting: %d revision left to test after this %s\n",
1114 "Bisecting: %d revisions left to test after this %s\n",
1115 nr), nr, steps_msg);
1116 free(steps_msg);
1117 /* Clean up objects used, as they will be reused. */
1118 repo_clear_commit_marks(r, ALL_REV_FLAGS);
1120 res = bisect_checkout(bisect_rev, no_checkout);
1121 cleanup:
1122 release_revisions(&revs);
1123 strvec_clear(&rev_argv);
1124 return res;
1127 static inline int log2i(int n)
1129 int log2 = 0;
1131 for (; n > 1; n >>= 1)
1132 log2++;
1134 return log2;
1137 static inline int exp2i(int n)
1139 return 1 << n;
1143 * Estimate the number of bisect steps left (after the current step)
1145 * For any x between 0 included and 2^n excluded, the probability for
1146 * n - 1 steps left looks like:
1148 * P(2^n + x) == (2^n - x) / (2^n + x)
1150 * and P(2^n + x) < 0.5 means 2^n < 3x
1152 int estimate_bisect_steps(int all)
1154 int n, x, e;
1156 if (all < 3)
1157 return 0;
1159 n = log2i(all);
1160 e = exp2i(n);
1161 x = all - e;
1163 return (e < 3 * x) ? n : n - 1;
1166 static int mark_for_removal(const char *refname,
1167 const struct object_id *oid UNUSED,
1168 int flag UNUSED, void *cb_data)
1170 struct string_list *refs = cb_data;
1171 char *ref = xstrfmt("refs/bisect%s", refname);
1172 string_list_append(refs, ref);
1173 return 0;
1176 int bisect_clean_state(void)
1178 int result = 0;
1180 /* There may be some refs packed during bisection */
1181 struct string_list refs_for_removal = STRING_LIST_INIT_NODUP;
1182 for_each_ref_in("refs/bisect", mark_for_removal, (void *) &refs_for_removal);
1183 string_list_append(&refs_for_removal, xstrdup("BISECT_HEAD"));
1184 result = delete_refs("bisect: remove", &refs_for_removal, REF_NO_DEREF);
1185 refs_for_removal.strdup_strings = 1;
1186 string_list_clear(&refs_for_removal, 0);
1187 unlink_or_warn(git_path_bisect_expected_rev());
1188 unlink_or_warn(git_path_bisect_ancestors_ok());
1189 unlink_or_warn(git_path_bisect_log());
1190 unlink_or_warn(git_path_bisect_names());
1191 unlink_or_warn(git_path_bisect_run());
1192 unlink_or_warn(git_path_bisect_terms());
1193 unlink_or_warn(git_path_bisect_first_parent());
1195 * Cleanup BISECT_START last to support the --no-checkout option
1196 * introduced in the commit 4796e823a.
1198 unlink_or_warn(git_path_bisect_start());
1200 return result;