docs/contributing/reviews.rst

   1 Getting reviews
   2 ===============
   3
   4
   5 Thorough code reviews are one of Mozilla's ways of ensuring code quality.
   6 Every patch must be reviewed by the module owner of the code, or one of their designated peers.
   7
   8 To request a review, you will need to specify a review group (starts with #). If there is not, you should select one or more usernames either when you submit the patch, or afterward in the UI.
   9 If you have a mentor, the mentor can usually either also review or find a suitable reviewer on your behalf.
  10
  11 For example, the syntax to request review from a group should be:
  12
  13 .. code-block::
  14
  15      Bug xxxx - explain what you are doing and why r?#group-name
  16
  17      or
  18
  19      Bug xxxx - explain what you are doing and why r?developer-nickname
  20
  21 Getting attention: If a reviewer doesn't respond within a week, or so of the review request:
  22
  23   * Contact the reviewer directly (either via e-mail or on Matrix).
  24   * Join developers on `Mozilla's Matrix server <https://chat.mozilla.org>`_, and ask if anyone knows why a review may be delayed. Please link to the bug too.
  25   * If the review is still not addressed, mail the reviewer directly, asking if/when they'll have time to review the patch, or might otherwise be able to review it.
  26
  27 For simple documentation changes, reviews are not required.
  28
  29 For more information about the review process, see the :ref:`Code Review FAQ`.
  30
  31 Review groups
  32 -------------
  33
  34
  35 .. list-table::
  36    :header-rows: 1
  37
  38    * - Name
  39      - Owns
  40      - Members
  41    * - #anti-tracking
  42      - `Core: Anti-Tracking </mots/index.html#core-anti-tracking>`__
  43      - `Member list <https://phabricator.services.mozilla.com/project/members/157/>`__
  44    * - #build or #firefox-build-system-reviewers
  45      - The configure & build system
  46      - `Member list <https://phabricator.services.mozilla.com/project/members/20/>`__
  47    * - #cookies
  48      - `Core: Cookies </mots/index.html#core-cookies>`__
  49      - `Member list <https://phabricator.services.mozilla.com/project/members/177/>`__
  50    * - #desktop-theme-reviewers
  51      - User interface CSS
  52      - `Member list <https://phabricator.services.mozilla.com/project/members/141/>`__
  53    * - #devtools-reviewers
  54      - Firefox DevTools
  55      - `Member list <https://phabricator.services.mozilla.com/project/members/153/>`__
  56    * - #dom-workers-and-storage-reviewers
  57      - DOM Workers & Storage
  58      - `Member list <https://phabricator.services.mozilla.com/project/members/115/>`__
  59    * - #fluent-reviewers
  60      - Changes to Fluent (FTL) files (translation).
  61      - `Member list <https://phabricator.services.mozilla.com/project/members/105/>`__
  62    * - #firefox-source-docs-reviewers
  63      - Documentation files and its build
  64      - `Member list <https://phabricator.services.mozilla.com/project/members/118/>`__
  65    * - #firefox-ux-team
  66      - User experience (UX)
  67      - `Member list <https://phabricator.services.mozilla.com/project/members/91/>`__
  68    * - #firefox-svg-reviewers
  69      - SVG-related changes
  70      - `Member list <https://phabricator.services.mozilla.com/project/members/97/>`__
  71    * - #geckoview-reviewers
  72      - Changes to GeckoView
  73      - `Member list <https://phabricator.services.mozilla.com/project/members/92/>`__
  74    * - #gfx-reviewers
  75      - Changes to Graphics code
  76      - `Member list <https://phabricator.services.mozilla.com/project/members/122/>`__
  77    * - #webgpu-reviewers
  78      - Changes to WebGPU code
  79      - `Member list <https://phabricator.services.mozilla.com/project/members/170/>`__
  80    * - #intermittent-reviewers
  81      - Test manifest changes
  82      - `Member list <https://phabricator.services.mozilla.com/project/members/110/>`__
  83    * - #layout-reviewers
  84      - Layout changes.
  85      - `Member list <https://phabricator.services.mozilla.com/project/members/126/>`__
  86    * - #linter-reviewers
  87      - tools/lint/*
  88      - `Member list <https://phabricator.services.mozilla.com/project/members/119/>`__
  89    * - #mac-reviewers
  90      - Changes to Mac-specific code
  91      - `Member list <https://phabricator.services.mozilla.com/project/members/149/>`__
  92    * - #mozbase
  93      - Changes to Mozbase
  94      - `Member list <https://phabricator.services.mozilla.com/project/members/113/>`__
  95    * - #mozbase-rust
  96      - Changes to Mozbase in Rust
  97      - `Member list <https://phabricator.services.mozilla.com/project/members/114/>`__
  98    * - #necko-reviewers
  99      - Changes to network code (aka necko, aka netwerk)
 100      - `Member list <https://phabricator.services.mozilla.com/project/members/127/>`__
 101    * - #nss-reviewers
 102      - Changes to Network Security Services (NSS)
 103      - `Member list <https://phabricator.services.mozilla.com/project/members/156/>`__
 104    * - #perftest-reviewers
 105      - Perf Tests
 106      - `Member list <https://phabricator.services.mozilla.com/project/members/102/>`__
 107    * - #permissions or #permissions-reviewers
 108      - `Permissions </mots/index.html#core-permissions>`__
 109      - `Member list <https://phabricator.services.mozilla.com/project/members/158/>`__
 110    * - #places-reviewers
 111      - `Bookmarks & History (Places) </mots/index.html#bookmarks-history>`__
 112      - `Member list <https://phabricator.services.mozilla.com/project/members/186/>`__
 113    * - #platform-i18n-reviewers
 114      - Platform Internationalization
 115      - `Member list <https://phabricator.services.mozilla.com/project/members/150/>`__
 116    * - #preferences-reviewers
 117      - Firefox for Desktop Preferences (Options) user interface
 118      - `Member list <https://phabricator.services.mozilla.com/project/members/132/>`__
 119    * - #remote-debugging-reviewers
 120      - Remote Debugging UI & tools
 121      - `Member list <https://phabricator.services.mozilla.com/project/members/108/>`__
 122    * - #search-reviewers
 123      - Search Reviewers (search parts of `Search and Address Bar </mots/index.html#search-and-address-bar>`__)
 124      - `Member list <https://phabricator.services.mozilla.com/project/members/169/>`__
 125    * - #spidermonkey-reviewers
 126      - SpiderMonkey JS/Wasm Engine
 127      - `Member list <https://phabricator.services.mozilla.com/project/members/173/>`__
 128    * - #static-analysis-reviewers
 129      - Changes related to Static Analysis
 130      - `Member list <https://phabricator.services.mozilla.com/project/members/120/>`__
 131    * - #style or #firefox-style-system-reviewers
 132      - Firefox style system (servo, layout/style).
 133      - `Member list <https://phabricator.services.mozilla.com/project/members/90/>`__
 134    * - #webcompat-reviewers
 135      - System addons maintained by the Web Compatibility team
 136      - `Member list <https://phabricator.services.mozilla.com/project/members/124/>`__
 137    * - #webdriver-reviewers
 138      - Marionette and geckodriver (including MozBase Rust), and Remote Protocol with WebDriver BiDi, and CDP.
 139      - `Member list <https://phabricator.services.mozilla.com/project/members/103/>`__
 140    * - #webidl
 141      - Changes related to WebIDL
 142      - `Member list <https://phabricator.services.mozilla.com/project/members/112/>`__
 143    * - #xpcom-reviewers
 144      - Changes related to XPCOM
 145      - `Member list <https://phabricator.services.mozilla.com/project/members/125/>`__
 146    * - #media-playback-reviewers
 147      - `Media playback <https://wiki.mozilla.org/Modules/All#Media_Playback>`__
 148      - `Member list <https://phabricator.services.mozilla.com/project/profile/159/>`__
 149    * - #cubeb-reviewers
 150      - Changes related to cubeb, Gecko's audio input/output library and associated projects (audioipc, cubeb-rs, rust cubeb backends)
 151      - `Member list <https://phabricator.services.mozilla.com/project/profile/129/>`__
 152
 153 To create a new group, fill a `new bug in Conduit::Administration <https://bugzilla.mozilla.org/enter_bug.cgi?product=Conduit&component=Administration>`__.
 154 See `bug 1613306 <https://bugzilla.mozilla.org/show_bug.cgi?id=1613306>`__ as example.