1 When submitting a patch make sure the commits in your pull request:
3 * Have good commit messages
5 Please read Chris Beams' blog post [How to Write a Git Commit
6 Message](https://chris.beams.io/posts/git-commit/) on how to write a
7 good commit message. Although the article recommends at most 50
8 characters for the subject, up to 72 characters are frequently
9 accepted for fast-export.
11 * Adhere to good [commit
12 hygiene](http://www.ericbmerritt.com/2011/09/21/commit-hygiene-and-git.html)
14 When developing a pull request for hg-fast-export, base your work on
15 the current `master` branch and rebase your work if it no longer can
16 be merged into the current `master` without conflicts. Never merge
17 `master` into your development branch, rebase if your work needs
18 updates from `master`.
20 When a pull request is modified due to review feedback, please
21 incorporate the changes into the proper commit. A good reference on
22 how to modify history is in the [Pro Git book, Section
23 7.6](https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History).
25 Please do not submit a pull request if you are not willing to spend
26 the time required to address review comments or revise the patch until
27 it follows the guidelines above. A _take it or leave it_ approach to
28 contributing wastes both your and the maintainer's time.