remove-parameter-from-ext4_xattr_ibody_set

   1 ext4: remove parameter from ext4_xattr_ibody_set()
   2
   3 From: Eric Whitney <enwlinux@gmail.com>
   4
   5 The parameter "handle" isn't used.
   6
   7 Signed-off-by: Eric Whitney <enwlinux@gmail.com>
   8 Signed-off-by: Theodore Ts'o <tytso@mit.edu>
   9 ---
  10  fs/ext4/xattr.c | 11 +++++------
  11  1 file changed, 5 insertions(+), 6 deletions(-)
  12
  13 diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
  14 index d77be9e..2ee1378 100644
  15 --- a/fs/ext4/xattr.c
  16 +++ b/fs/ext4/xattr.c
  17 @@ -1109,7 +1109,7 @@ int ext4_xattr_ibody_inline_set(handle_t *handle, struct inode *inode,
  18         return 0;
  19  }
  20
  21 -static int ext4_xattr_ibody_set(handle_t *handle, struct inode *inode,
  22 +static int ext4_xattr_ibody_set(struct inode *inode,
  23                                 struct ext4_xattr_info *i,
  24                                 struct ext4_xattr_ibody_find *is)
  25  {
  26 @@ -1216,7 +1216,7 @@ ext4_xattr_set_handle(handle_t *handle, struct inode *inode, int name_index,
  27         }
  28         if (!value) {
  29                 if (!is.s.not_found)
  30 -                       error = ext4_xattr_ibody_set(handle, inode, &i, &is);
  31 +                       error = ext4_xattr_ibody_set(inode, &i, &is);
  32                 else if (!bs.s.not_found)
  33                         error = ext4_xattr_block_set(handle, inode, &i, &bs);
  34         } else {
  35 @@ -1227,7 +1227,7 @@ ext4_xattr_set_handle(handle_t *handle, struct inode *inode, int name_index,
  36                 if (!bs.s.not_found && ext4_xattr_value_same(&bs.s, &i))
  37                         goto cleanup;
  38
  39 -               error = ext4_xattr_ibody_set(handle, inode, &i, &is);
  40 +               error = ext4_xattr_ibody_set(inode, &i, &is);
  41                 if (!error && !bs.s.not_found) {
  42                         i.value = NULL;
  43                         error = ext4_xattr_block_set(handle, inode, &i, &bs);
  44 @@ -1242,8 +1242,7 @@ ext4_xattr_set_handle(handle_t *handle, struct inode *inode, int name_index,
  45                                 goto cleanup;
  46                         if (!is.s.not_found) {
  47                                 i.value = NULL;
  48 -                               error = ext4_xattr_ibody_set(handle, inode, &i,
  49 -                                                            &is);
  50 +                               error = ext4_xattr_ibody_set(inode, &i, &is);
  51                         }
  52                 }
  53         }
  54 @@ -1384,7 +1383,7 @@ static int ext4_xattr_move_to_block(handle_t *handle, struct inode *inode,
  55                 goto out;
  56
  57         /* Remove the chosen entry from the inode */
  58 -       error = ext4_xattr_ibody_set(handle, inode, &i, is);
  59 +       error = ext4_xattr_ibody_set(inode, &i, is);
  60         if (error)
  61                 goto out;
  62
  63 --
  64 2.1.4
  65
  66