remove-unused-mode-parameter

   1 ext4: remove unused mode parameter
   2
   3 From: Tahsin Erdogan <tahsin@google.com>
   4
   5 ext4_alloc_file_blocks() does not use its mode parameter. Remove it.
   6
   7 Signed-off-by: Tahsin Erdogan <tahsin@google.com>
   8 Signed-off-by: Theodore Ts'o <tytso@mit.edu>
   9 ---
  10  fs/ext4/extents.c | 9 ++++-----
  11  1 file changed, 4 insertions(+), 5 deletions(-)
  12
  13 diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
  14 index e0a8425ff74d..230ca74c4841 100644
  15 --- a/fs/ext4/extents.c
  16 +++ b/fs/ext4/extents.c
  17 @@ -4652,7 +4652,7 @@ int ext4_ext_truncate(handle_t *handle, struct inode *inode)
  18
  19  static int ext4_alloc_file_blocks(struct file *file, ext4_lblk_t offset,
  20                                   ext4_lblk_t len, loff_t new_size,
  21 -                                 int flags, int mode)
  22 +                                 int flags)
  23  {
  24         struct inode *inode = file_inode(file);
  25         handle_t *handle;
  26 @@ -4815,7 +4815,7 @@ static long ext4_zero_range(struct file *file, loff_t offset,
  27                                 round_down(offset, 1 << blkbits) >> blkbits,
  28                                 (round_up((offset + len), 1 << blkbits) -
  29                                  round_down(offset, 1 << blkbits)) >> blkbits,
  30 -                               new_size, flags, mode);
  31 +                               new_size, flags);
  32                 if (ret)
  33                         goto out_dio;
  34
  35 @@ -4841,7 +4841,7 @@ static long ext4_zero_range(struct file *file, loff_t offset,
  36                 inode->i_mtime = inode->i_ctime = current_time(inode);
  37
  38                 ret = ext4_alloc_file_blocks(file, lblk, max_blocks, new_size,
  39 -                                            flags, mode);
  40 +                                            flags);
  41                 up_write(&EXT4_I(inode)->i_mmap_sem);
  42                 if (ret)
  43                         goto out_dio;
  44 @@ -4976,8 +4976,7 @@ long ext4_fallocate(struct file *file, int mode, loff_t offset, loff_t len)
  45         ext4_inode_block_unlocked_dio(inode);
  46         inode_dio_wait(inode);
  47
  48 -       ret = ext4_alloc_file_blocks(file, lblk, max_blocks, new_size,
  49 -                                    flags, mode);
  50 +       ret = ext4_alloc_file_blocks(file, lblk, max_blocks, new_size, flags);
  51         ext4_inode_resume_unlocked_dio(inode);
  52         if (ret)
  53                 goto out;
  54 --
  55 2.14.0.rc0.284.gd933b75aa4-goog
  56
  57