remove-never-taken-branch-from-ext4_ext_shift_path_extents

   1 ext4: remove never taken branch from ext4_ext_shift_path_extents()
   2
   3 From: Jan Kara <jack@suse.cz>
   4
   5 path[depth].p_hdr can never be NULL for a path passed to us (and even if
   6 it could, EXT_LAST_EXTENT() would make something != NULL from it). So
   7 just remove the branch.
   8
   9 Coverity-id: 1196498
  10 Signed-off-by: Jan Kara <jack@suse.cz>
  11 Signed-off-by: Theodore Ts'o <tytso@mit.edu>
  12 ---
  13  fs/ext4/extents.c | 2 --
  14  1 file changed, 2 deletions(-)
  15
  16 diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
  17 index 0b16fb4c06d3..31cd9b5c6419 100644
  18 --- a/fs/ext4/extents.c
  19 +++ b/fs/ext4/extents.c
  20 @@ -5239,8 +5239,6 @@ ext4_ext_shift_path_extents(struct ext4_ext_path *path, ext4_lblk_t shift,
  21                                 return -EIO;
  22
  23                         ex_last = EXT_LAST_EXTENT(path[depth].p_hdr);
  24 -                       if (!ex_last)
  25 -                               return -EIO;
  26
  27                         err = ext4_access_path(handle, inode, path + depth);
  28                         if (err)
  29 --
  30 1.8.1.4
  31
  32