initialize-retries-variable-in-ext4_da_write_inline_begin

   1 ext4: initialize retries variable in ext4_da_write_inline_data_begin()
   2
   3 From: Lukas Czerner <lczerner@redhat.com>
   4
   5 Variable retries is not initialized in ext4_da_write_inline_data_begin()
   6 which can lead to nondeterministic number of retries in case we hit
   7 ENOSPC. Initialize retries to zero as we do everywhere else.
   8
   9 Signed-off-by: Lukas Czerner <lczerner@redhat.com>
  10 Signed-off-by: Theodore Ts'o <tytso@mit.edu>
  11 Fixes: bc0ca9df3b2a ("ext4: retry allocation when inline->extent conversion failed")
  12 Cc: stable@kernel.org
  13 ---
  14  fs/ext4/inline.c | 2 +-
  15  1 file changed, 1 insertion(+), 1 deletion(-)
  16
  17 diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c
  18 index 3543fe80a3c4..1b13fa5c9d6e 100644
  19 --- a/fs/ext4/inline.c
  20 +++ b/fs/ext4/inline.c
  21 @@ -863,7 +863,7 @@ int ext4_da_write_inline_data_begin(struct address_space *mapping,
  22         handle_t *handle;
  23         struct page *page;
  24         struct ext4_iloc iloc;
  25 -       int retries;
  26 +       int retries = 0;
  27
  28         ret = ext4_get_inode_loc(inode, &iloc);
  29         if (ret)
  30 --
  31 2.17.1
  32
  33