1 ext4: use swap macro in mext_page_double_lock
3 From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
5 Make use of the swap macro and remove unnecessary variable *tmp*.
6 This makes the code easier to read and maintain.
8 This code was detected with the help of Coccinelle.
10 Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
11 Signed-off-by: Theodore Ts'o <tytso@mit.edu>
14 - Update changelog. Remove the line claiming that this
15 patch reduces stack usage.
17 fs/ext4/move_extent.c | 4 +---
18 1 file changed, 1 insertion(+), 3 deletions(-)
20 diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c
21 index 8e17efd..a409ff7 100644
22 --- a/fs/ext4/move_extent.c
23 +++ b/fs/ext4/move_extent.c
24 @@ -134,9 +134,7 @@ mext_page_double_lock(struct inode *inode1, struct inode *inode2,
25 mapping[0] = inode1->i_mapping;
26 mapping[1] = inode2->i_mapping;
28 - pgoff_t tmp = index1;
31 + swap(index1, index2);
32 mapping[0] = inode2->i_mapping;
33 mapping[1] = inode1->i_mapping;