fix-uninit-variables-use-in-debugging-message

   1 ext4: fix use of potentially uninitialized variables in debugging code
   2
   3 From: Andi Shyti <andi@etezian.org>
   4
   5 If ext_debugging is enabled and path[depth].p_ext is NULL, len
   6 and lblock are printed non initialized
   7
   8 Signed-off-by: Andi Shyti <andi@etezian.org>
   9 Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
  10 ---
  11  fs/ext4/extents.c | 5 ++---
  12  1 file changed, 2 insertions(+), 3 deletions(-)
  13
  14 diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
  15 index a618738..acaf53c 100644
  16 --- a/fs/ext4/extents.c
  17 +++ b/fs/ext4/extents.c
  18 @@ -2195,8 +2195,8 @@ ext4_ext_put_gap_in_cache(struct inode *inode, struct ext4_ext_path *path,
  19                                 ext4_lblk_t block)
  20  {
  21         int depth = ext_depth(inode);
  22 -       unsigned long len;
  23 -       ext4_lblk_t lblock;
  24 +       unsigned long len = 0;
  25 +       ext4_lblk_t lblock = 0;
  26         struct ext4_extent *ex;
  27
  28         ex = path[depth].p_ext;
  29 @@ -2233,7 +2233,6 @@ ext4_ext_put_gap_in_cache(struct inode *inode, struct ext4_ext_path *path,
  30                         ext4_es_insert_extent(inode, lblock, len, ~0,
  31                                               EXTENT_STATUS_HOLE);
  32         } else {
  33 -               lblock = len = 0;
  34                 BUG();
  35         }
  36
  37 --
  38 1.8.3.2
  39
  40 --
  41 To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
  42 the body of a message to majordomo@vger.kernel.org
  43 More majordomo info at  http://vger.kernel.org/majordomo-info.html
  44 Please read the FAQ at  http://www.tux.org/lkml/
  45