1 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
3 Cleanup basic allocation variables and functions.
4 * alloc.c (ignore_warnings, init_intervals, init_float)
5 (init_cons, init_symbol, init_marker): Remove.
6 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
7 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
8 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
9 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
10 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
11 (staticidx, init_alloc_once, init_strings, free_ablock):
12 Remove redundant initialization.
13 * fns.c (init_weak_hash_tables): Remove.
14 * lisp.h (init_weak_hash_tables): Remove prototype.
16 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
18 Use zero_vector where appropriate.
19 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
21 * lisp.h (zero_vector): New declaration.
22 * font.c (null_vector): Remove.
23 (syms_of_font): Remove initialization and staticpro.
24 (font_list_entities, font_find_for_lface): Change to use zero_vector.
25 * keymap.c (Faccessible_keymaps): Likewise.
27 2012-07-15 Leo Liu <sdl.web@gmail.com>
29 * fringe.c: Fix typo in comments.
31 2012-07-14 Leo Liu <sdl.web@gmail.com>
33 * fringe.c: Add a new bitmap exclamation-mark.
35 2012-07-14 Eli Zaretskii <eliz@gnu.org>
37 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
39 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
40 (HAVE_MENUS): Don't define, defined by editing config.in with
42 (GMALLOC_INHIBIT_VALLOC): Don't define.
43 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
45 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
47 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
49 2012-07-14 Glenn Morris <rgm@gnu.org>
51 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
52 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
53 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
55 2012-07-13 Glenn Morris <rgm@gnu.org>
57 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
59 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
60 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
62 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
64 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
65 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
66 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
67 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
69 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
70 as boolean expression.
71 (x_set_window_size): Remove unused variable toolbar.
72 (ns_get_color_default, ns_mod_to_lisp): Remove.
73 (ns_mouse_position): Remove unused variables xchar and ychar.
74 (ns_compute_glyph_string_overhangs): Remove unused variable face.
75 (ns_set_vertical_scroll_bar): Remove unused variable count.
76 (ns_delete_terminal): Remove unused variable i.
77 (ns_term_init): Remove unused variables r, g and b.
78 (mouseDown): Remove unused variable window.
79 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
80 (initFrameFromEmacs): Remove unused variable vbextra.
81 (mouseEntered): Remove unused variables p and dpyinfo.
82 (mouseExited): Remove unused variables p and r.
83 (ns_define_frame_cursor, ns_clear_frame_area)
84 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
85 (menuDown): Assign [sender tag] to variable and cast the variable.
87 * nsterm.h (menuDown): Add id as type to argument sender.
88 (ns_display_info_for_name): Add Lisp_Object argument.
89 (ns_term_init): Add Lisp_Object argument.
90 (ns_map_event_to_object): Add void argument.
91 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
92 prototype with arguments and only declare if __OBJC__.
93 (nxatoms_of_nsselect): Add void argument.
94 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
95 (ns_alloc_autorelease_pool): Add void argument.
96 (ns_release_autorelease_pool): Add void* argument.
97 (ns_get_defaults_value): Add const char* argument.
99 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
100 (initFromContents): Use SSDATA where appropriate.
101 (ns_update_menubar): Add braces to ambigous if-else.
102 (initWithTitle): Put () around assignment in if statement.
103 (ns_menu_show): Remove unused variables window and keymap.
104 (update_frame_tool_bar): Remove unused variable selected_p.
105 (initWithContentRect): Remove unused variable this_cmd_name.
107 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
109 (setXBMColor): Remove unused variable len.
110 (setPixmapData): Put () around assignment in loop statement.
112 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
113 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
115 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
116 around assignment in loop statement.
117 (nsfont_open): Remove unused variable i.
118 (nsfont_open): Remove unused variable len.
119 (nsfont_draw): Remove unused variable cs.
121 * nsfns.m (x_set_icon_name, ns_set_name_internal)
122 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
123 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
124 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
125 (Fns_font_name, Fns_perform_service)
126 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
127 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
128 (ns_set_name): Remove unused variable view.
129 (x_set_menu_bar_lines): Remove unused variable olines.
130 (x_set_tool_bar_lines): Remove unused variable root_window.
131 (Fns_list_colors): Put () around assignment in while statement.
132 (Fns_perform_service): Remove unused variable len.
133 (Fns_display_usable_bounds): Remove unused variable top.
134 (syms_of_nsfns): Remove unused variable i.
136 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
139 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
141 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
142 and free it with DestroyExceptionInfo (Bug#11558).
144 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
146 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
147 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
148 Set here, not in nt/config.nt.
150 2012-07-13 Eli Zaretskii <eliz@gnu.org>
152 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
153 cursor overflow into the last glyph on display line when the right
154 fringe is off. (Bug#11832)
156 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
158 * xdisp.c (produce_special_glyphs): Now static.
159 * dispextern.h (produce_special_glyphs): Remove decl.
161 2012-07-13 Glenn Morris <rgm@gnu.org>
163 * s/bsd-common, s/cygwin.h: Remove empty files.
164 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
166 * s/usg5-4-common.h (USG, USG5):
167 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
168 * s/sol2-6.h (SOLARIS2):
169 * s/irix6-5.h (IRIX6_5):
170 * s/hpux10-20.h (USG, USG5, HPUX):
171 * s/gnu-linux.h (USG, GNU_LINUX):
172 * s/freebsd.h (BSD_SYSTEM):
173 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
174 * s/cygwin.h (CYGWIN):
175 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
176 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
178 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
180 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
182 2012-07-13 Glenn Morris <rgm@gnu.org>
184 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
186 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
188 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
189 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
191 2012-07-12 Glenn Morris <rgm@gnu.org>
193 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
195 * process.c (init_process_emacs): Rename from init_process.
196 The old name is also the name of a Mach system call.
197 * lisp.h, emacs.c: Update for this name change.
198 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
201 2012-07-12 Eli Zaretskii <eliz@gnu.org>
203 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
204 memmove call that removes glyphs covered by the left truncation
205 glyph. Improve commentary.
206 (display_line): Fix display of continuation glyphs on GUI frames
207 when the right fringe is turned off and variable-size fonts are
208 used in the window. Move the code that appends a stretch glyph to
209 produce_special_glyphs, so that it could be used for truncation
210 and continuation glyphs alike.
211 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
212 glyph of a suitably computed width, to align the special glyphs at
213 the window margin. Code moved from display_line. (Bug#11832)
215 2012-07-12 Glenn Morris <rgm@gnu.org>
217 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
219 * s/gnu-linux.h, s/hpux10-20.h:
220 Do not unconditionally define HAVE_XRMSETDATABASE.
222 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
224 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
226 Fix typos that broke OS X build.
227 Reported by Randal L. Schwartz in
228 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
229 * nsterm.m (ns_timeout): Add missing local decl.
230 (ns_get_color): snprintf -> sprintf, to fix typo.
232 2012-07-12 Glenn Morris <rgm@gnu.org>
234 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
235 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
236 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
237 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
239 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
240 Move PTY_OPEN to configure.
242 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
243 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
244 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
246 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
248 Use empty_unibyte_string where applicable.
249 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
250 * lread.c (read1): Likewise.
251 * xsettings.c (syms_of_xsettings): Likewise.
253 2012-07-12 Glenn Morris <rgm@gnu.org>
255 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
256 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
257 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
258 * s/hpux10-20.h (RUN_TIME_REMAP):
259 * s/bsd-common.h (TABDLY): Move to configure.
261 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
263 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
265 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
266 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
268 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
270 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
271 * s/template.h: Move NARROWPROTO to configure.
273 2012-07-11 Glenn Morris <rgm@gnu.org>
275 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
276 unused since 2011-01-17 change to systty.h.
278 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
279 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
280 Move HAVE_PTYS and HAVE_SOCKETS to configure.
282 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
284 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
286 2012-07-11 Glenn Morris <rgm@gnu.org>
288 * s/darwin.h, s/gnu-linux.h, s/template.h:
289 Move INTERRUPT_INPUT to configure.
291 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
293 Minor adjustments to interning code.
294 * lisp.h (intern, intern_c_string): Redefine as static inline
295 wrappers for intern_1 and intern_c_string_1, respectively.
296 (intern_1, intern_c_string_1): Rename prototypes.
297 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
299 * font.c (font_intern_prop): Likewise. Adjust comment.
300 * w32font.c (intern_font_name): Likewise.
302 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
304 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
306 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
307 of Fcar/Fcdr if possible.
308 * font.c (check_otf_features): Likewise.
309 * fontset.c (Fnew_fontset): Likewise.
310 * gnutls.c (Fgnutls_boot): Likewise.
311 * minibuf.c (read_minibuf): Likewise.
312 * msdos.c (IT_set_frame_parameters): Likewise.
313 * xmenu.c (Fx_popup_dialog): Likewise.
314 * w32menu.c (Fx_popup_dialog): Likewise.
316 2012-07-11 Glenn Morris <rgm@gnu.org>
318 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
319 since nothing has defined it on these platforms.
321 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
322 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
324 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
325 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
326 Move CLASH_DETECTION to configure.
328 * s/gnu.h: Remove file, which is now empty.
330 * s/gnu.h, s/gnu-linux.h:
331 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
333 2012-07-11 John Wiegley <johnw@newartisans.com>
335 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
336 function attribute, so we only use it if it exists in the
339 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
341 Avoid call to strlen in fast_c_string_match_ignore_case.
342 * search.c (fast_c_string_match_ignore_case): Change to use
343 length argument. Adjust users accordingly.
344 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
346 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
349 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
350 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
353 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
356 * s/hpux10-20.h (HAVE_PERROR): Remove.
357 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
358 Remove dummy definition, as this problem was obsolete long ago.
361 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
363 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
365 Avoid calls to strlen in font processing functions.
366 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
367 (font_open_by_name): Change to use length argument. Adjust
369 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
371 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
372 Change to return ptrdiff_t.
373 (xfont_list_pattern, xfont_match): Use length returned by
374 xfont_decode_coding_xlfd.
375 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
377 2012-07-11 Glenn Morris <rgm@gnu.org>
379 * s/darwin.h, s/freebsd.h, s/netbsd.h:
380 Move DONT_REOPEN_PTY to configure.
382 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
383 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
385 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
387 Remove "#define unix" that is no longer needed (Bug#11905).
388 * s/aix4-2.h (unix): Remove; no longer needed.
390 EMACS_TIME simplification (Bug#11875).
391 This replaces macros (which typically do not work in GDB)
392 with functions, typedefs and enums, making the code easier to debug.
393 The functional style also makes code easier to read and maintain.
394 * systime.h: Include <sys/time.h> on all hosts, not just if
395 WINDOWSNT, since 'struct timeval' is needed in general.
396 (EMACS_TIME): Now a typedef, not a macro.
397 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
399 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
400 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
401 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
402 (EMACS_TIME_LE): Now functions, not macros.
403 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
404 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
405 which are not functions. All uses rewritten to use:
406 (make_emacs_time): New function.
407 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
408 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
409 not functions. All uses rewritten to use the following, respectively:
410 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
411 (add_emacs_time, sub_emacs_time): New functions.
412 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
413 * fileio.c (Fcopy_file):
414 * xterm.c (XTflash): Get the current time closer to when it's used.
415 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
417 * bytecode.c (targets): Suppress -Woverride-init warnings.
419 Simplify by avoiding confusing use of strncpy etc.
420 * doc.c (Fsnarf_documentation):
421 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
422 * frame.c (Fmake_terminal_frame):
423 * gtkutil.c (get_utf8_string):
425 * nsmenu.m (ns_update_menubar):
426 * regex.c (regerror):
427 Prefer memcpy to strncpy and strncat when either will do.
428 * fileio.c (Fsubstitute_in_file_name):
429 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
430 (menu_separator_name_p):
431 * nsmenu.m (ns_update_menubar):
432 Prefer memcmp to strncmp when either will do.
433 * nsterm.m: Include <ftoastr.h>.
435 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
436 Prefer snprintf to strncpy.
437 * nsterm.m (ns_term_init):
438 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
439 * nsterm.m (ns_term_init):
440 Avoid the need for strncpy, by using build_string or
441 make_unibyte_string directly. Use dtoastr, not snprintf.
442 * process.c (Fmake_network_process): Diagnose service names that
443 are too long, rather than silently truncating them or creating
444 non-null-terminated names.
445 (Fnetwork_interface_info): Likewise, for interface names.
446 * sysdep.c (system_process_attributes) [GNU_LINUX]:
447 Prefer sprintf to strncat.
448 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
449 Prefer vsnprintf to vsprintf + strncpy.
451 2012-07-10 Glenn Morris <rgm@gnu.org>
453 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
454 Clarify fallback case.
456 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
458 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
459 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
460 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
461 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
462 where argument type is known to be a Lisp_Cons.
464 2012-07-10 Tom Tromey <tromey@redhat.com>
466 * bytecode.c (BYTE_CODE_THREADED): New macro.
467 (BYTE_CODES): New macro. Replaces all old byte-code defines.
468 (enum byte_code_op): New type.
469 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
470 (exec_byte_code): Use them. Use token threading when applicable.
472 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
474 Optimize pure C strings initialization.
475 * lisp.h (make_pure_string): Fix prototype.
476 (build_pure_c_string): New function, defined as static inline. This
477 provides a better opportunity to optimize away calls to strlen when
478 the function is called with compile-time constant argument.
479 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
480 argument, adjust users accordingly. Use build_pure_c_string where
482 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
483 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
484 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
486 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
488 Avoid calls to strlen in miscellaneous functions.
489 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
490 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
491 * lread.c (openp): Likewise.
493 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
495 Avoid calls to strlen in path processing functions.
496 * fileio.c (file_name_as_directory): Add comment. Change to add
497 srclen argument and return the length of result. Adjust users
499 (directory_file_name): Fix comment. Change to add srclen argument,
500 swap 1st and 2nd arguments to obey the common convention. Adjust
502 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
504 2012-07-10 Glenn Morris <rgm@gnu.org>
506 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
507 Move PENDING_OUTPUT_COUNT definition to configure.
509 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
510 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
511 * s/gnu.h (DATA_START): Move definitions to configure.
513 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
514 We include usg5-4-common.h, which defines them both.
516 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
517 O_RDONLY already includes it).
519 Stop ns builds setting the EMACSLOADPATH environment variable.
520 * nsterm.m (ns_load_path): Rename from ns_init_paths.
521 Now it does not set EMACSLOADPATH, just returns the load-path string.
522 * nsterm.h: Update accordingly.
523 * lread.c [HAVE_NS]: Include nsterm.h.
524 (init_lread) [HAVE_NS]: Use ns_load_path.
525 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
527 2012-07-09 Glenn Morris <rgm@gnu.org>
529 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
530 since the included bsd-common.h does so.
532 Stop ns builds setting the EMACSPATH environment variable.
533 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
534 (ns_init_paths): Do not set EMACSPATH.
535 * nsterm.h (ns_exec_path): Add it.
536 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
539 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
541 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
543 * process.c (wait_reading_process_output): 'waitchannels' was unset
544 when read_kbd || !NILP (wait_for_cell); fix this.
546 Add GCC-style 'const' attribute to functions that can use it.
547 * character.h (char_resolve_modifier_mask):
548 * keyboard.h (make_ctrl_char):
549 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
550 (init_character_once, next_almost_prime, init_fns, init_image)
551 (flush_pending_output, init_sound):
552 * mem-limits.h (start_of_data):
553 * menu.h (finish_menu_items):
555 * emacs.c (DEFINE_DUMMY_FUNCTION):
556 Declare the dummy function with ATTRIBUTE_CONST.
557 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
558 Add decls with ATTRIBUTE_CONST.
560 Minor improvements to make_formatted_string.
561 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
562 where int is good enough, as vsprintf returns an int.
563 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
565 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
567 Use make_formatted_string to avoid double length calculation.
568 * lisp.h (make_formatted_string): New prototype.
569 * alloc.c (make_formatted_string): New function.
570 * buffer.c (Fgenerate_new_buffer_name): Use it.
571 * dbus.c (syms_of_dbusbind): Likewise.
572 * editfns.c (Fcurrent_time_zone): Likewise.
573 * filelock.c (get_boot_time): Likewise.
574 * frame.c (make_terminal_frame, set_term_frame_name)
575 (x_report_frame_params): Likewise.
576 * image.c (gs_load): Likewise.
577 * minibuf.c (get_minibuffer): Likewise.
578 * msdos.c (dos_set_window_size): Likewise.
579 * process.c (make_process): Likewise.
580 * xdisp.c (ensure_echo_area_buffers): Likewise.
581 * xsettings.c (apply_xft_settings): Likewise.
583 2012-07-09 Glenn Morris <rgm@gnu.org>
585 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
586 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
587 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
588 * nsterm.h (ns_etc_directory): Add it.
589 * callproc.c [HAVE_NS]: Include nsterm.h.
590 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
592 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
594 Move marker debugging code under MARKER_DEBUG.
595 * marker.c (MARKER_DEBUG): Move marker debugging code under
596 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
597 for bootstrap with --enable-checking (~3x slowdown reported
598 by Juanma Barranquero <lekktu@gmail.com>).
599 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
601 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
603 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
604 See <http://bugs.gnu.org/11825#29>.
606 2012-07-08 Eli Zaretskii <eliz@gnu.org>
608 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
609 has no font, use the frame's font. (Bug#11813)
610 (display_line): Add commentary about displaying truncation glyphs
612 (produce_special_glyphs): Move here from term.c.
614 * term.c (produce_special_glyphs): Move to xdisp.c.
616 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
619 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
621 * xdisp.c (display_line): Avoid warning about implicit declaration
624 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
626 * lisp.h: Remove empty conditional.
628 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
630 * lread.c (load_path_check): Now static.
632 Fix some minor --with-ns problems found by static checking.
633 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
634 (x_set_font) [!HAVE_X_WINDOWS]:
635 * image.c (xpm_load_image) [HAVE_NS]:
636 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
637 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
639 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
640 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
641 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
642 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
643 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
644 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
645 Fix pointer signedness problem.
646 * xfaces.c (FRAME_X_FONT_TABLE):
647 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
649 2012-07-07 Glenn Morris <rgm@gnu.org>
651 * lread.c (load_path_check): New function, split from init_lread.
652 (init_lread): Reorganize. Motivation:
653 If EMACSLOADPATH is set, check/warn about that rather than the
654 defaults, which we are not going to use. Hence we can remove
655 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
656 Don't warn if site-lisp directories are missing.
657 If not installed, start from a blank load-path, since
658 PATH_LOADSEARCH refers to the eventual installation directories.
660 2012-07-07 Eli Zaretskii <eliz@gnu.org>
662 Support truncation and continuation glyphs on GUI frames, when
663 fringes are disabled. (Bug#11832)
664 * xdisp.c (init_iterator): Get dimensions of truncation and
665 continuation glyphs even if on GUI frames. Adjust
666 it->last_visible_x on GUI frames when the left or right fringes,
668 (start_display, move_it_in_display_line_to): Handle the case of a
669 GUI frame without a fringe to display continuation or truncation
671 (insert_left_trunc_glyphs): Support GUI frames: make sure
672 truncation glyphs overwrite enough glyphs from the current line to
673 have sufficient space in pixels.
674 (display_line): Support truncation and continuation glyphs on GUI
675 frames. If some spare pixels are left on the line after inserting
676 the truncation glyphs, fill that space with a stretch glyph of a
677 suitably computed width.
679 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
680 produce_glyphs, to support GUI sessions.
682 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
684 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
686 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
688 Do not require float-time's arg to fit in time_t (Bug#11825).
689 This works better on hosts where time_t is unsigned, and where
690 float-time is applied to the (negative) difference between two times.
691 * editfns.c (decode_time_components): Last arg is now double *,
692 not int *, and means to store all the result as a double, without
693 worrying about whether the seconds part fits in time_t.
695 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
697 (Ffloat_time): Do not fail merely because the specified time falls
698 outside of time_t range.
700 2012-07-07 Glenn Morris <rgm@gnu.org>
702 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
703 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
704 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
706 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
708 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
711 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
713 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
715 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
716 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
717 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
718 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
719 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
720 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
722 * xfont.c (compare_font_names): Redo to omit the need for casts.
724 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
726 * xfns.c (Fx_change_window_property): Doc fix.
727 * w32fns.c (Fx_change_window_property): Doc fix.
729 * w32fns.c (Fx_window_property): Accept the same arguments as the
730 X Windows version. Doc fix.
731 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
733 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
734 Eli Zaretskii <eliz@gnu.org>
736 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
737 Windows-specific code from nt/config.nt moved here.
738 Obsolete settings removed.
740 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
742 * process.c: Avoid unnecessary calls to gettime.
743 (wait_reading_process_output): Don't get the time of day
744 when gobbling data immediately and not waiting, as there's no need
745 for it in that case. This removes a FIXME.
747 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
749 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
750 is defined (Bug#11768).
752 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
754 Fix marker debugging code.
755 * marker.c (byte_char_debug_check): Do not perform the check
756 if buffer is not multibyte.
757 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
758 Call byte_char_debug_check with correct arguments.
760 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
762 Compile marker debugging code only if ENABLE_CHECKING is defined.
763 * marker.c (byte_char_debug_check, count_markers):
764 Use only if ENABLE_CHECKING is defined.
765 (byte_debug_flag): Remove.
766 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
767 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
769 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
771 Avoid code repetition in marker-related functions.
772 * marker.c (attach_marker): New function.
773 (Fset_marker, set_marker_restricted, set_marker_both)
774 (set_marker_restricted_both): Use it.
775 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
776 Consistently rename charno to charpos.
777 (marker_position): Add eassert.
778 (marker_byte_position): Convert to eassert.
780 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
782 Simplify list operations in unchain_overlay and unchain_marker.
783 * buffer.c (unchain_overlay): Simplify. Add comment.
784 * marker.c (unchain_marker): Simplify. Fix comments.
786 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
788 Introduce fast path for the widely used marker operation.
789 * alloc.c (build_marker): New function.
790 * lisp.h (build_marker): New prototype.
791 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
792 * composite.c (autocmp_chars): Likewise.
793 * editfns.c (buildmark): Remove.
794 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
795 (save_restriction_save): Use build_marker.
796 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
797 * window.c (save_window_save): Likewise.
799 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
801 Do not use Fdelete_overlay in delete_all_overlays
802 to avoid redundant calls to unchain_overlay.
803 * buffer.c (drop_overlay): New function.
804 (delete_all_overlays, Fdelete_overlay): Use it.
805 * minibuf.c (get_minibuffer): Fix comment.
807 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
809 Port to OpenBSD 5.1 amd64.
810 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
811 This is needed for OpenBSD, and should be harmless on all BSD systems.
812 Also, include <sys/sysctl.h>, as it should be available on all
813 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
814 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
815 use p_pid member, not kp_proc.pid.
817 2012-07-06 Glenn Morris <rgm@gnu.org>
819 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
821 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
823 More xmalloc and related cleanup.
824 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
825 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
826 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
827 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
828 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
829 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
830 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
831 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
832 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
834 Omit needless casts involving void * pointers and allocation.
835 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
836 as the former is more robust if P's type is changed.
837 Prefer xzalloc to xmalloc + memset 0.
838 Simplify malloc-or-realloc to realloc.
839 Don't worry about xmalloc returning a null pointer.
840 Prefer xstrdup to xmalloc + strcpy.
841 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
843 * keyboard.c (apply_modifiers_uncached): Prefer local array to
844 alloca of a constant.
846 2012-07-05 Eli Zaretskii <eliz@gnu.org>
848 * xdisp.c (display_line): Fix horizontal pixel coordinates when
849 hscroll is larger than the line width. Fixes long and futile
850 looping inside extend_face_to_end_of_line (on a TTY) producing
851 glyphs that are not needed and thrown away.
853 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
855 * marker.c (set_marker_restricted_both): Simplify by using
858 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
860 * editfns.c (region_limit): Simplify by using clip_to_bounds.
862 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
864 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
865 not defined (Bug#11768).
866 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
867 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
868 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
869 followed by gtk_box_set_homogeneous (Bug#11768).
870 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
871 (update_theme_scrollbar_width, xg_create_scroll_bar):
872 Use gtk_scrollbar_new (Bug#11768).
873 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
874 (is_box_type): New function (Bug#11768).
875 (xg_tool_item_stale_p): Call is_box_type.
876 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
877 with default display (Bug#11768).
879 2012-07-05 Eli Zaretskii <eliz@gnu.org>
881 * xdisp.c (window_hscroll_limited): New function.
882 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
883 coordinates when window's hscroll is set to insanely large
886 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
888 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
889 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
891 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
894 * lisp.h (xzalloc): New prototype. Omit needless casts.
895 * alloc.c (xzalloc): New function. Omit needless casts.
896 * charset.c: Omit needless casts. Convert all calls to
897 xmalloc with following memset to xzalloc.
898 * dispnew.c: Likewise.
899 * fringe.c: Likewise.
903 * w32fns.c: Likewise.
904 * w32font.c: Likewise.
905 * w32term.c: Likewise.
906 * xfaces.c: Likewise.
909 * atimer.c: Omit needless casts.
910 * buffer.c: Likewise.
911 * callproc.c: Likewise.
913 * coding.c: Likewise.
914 * composite.c: Likewise.
916 * doprnt.c: Likewise.
917 * editfns.c: Likewise.
920 * filelock.c: Likewise.
922 * gtkutil.c: Likewise.
923 * keyboard.c: Likewise.
926 * minibuf.c: Likewise.
929 * process.c: Likewise.
930 * region-cache.c: Likewise.
931 * search.c: Likewise.
932 * sysdep.c: Likewise.
933 * termcap.c: Likewise.
934 * terminal.c: Likewise.
935 * tparam.c: Likewise.
936 * w16select.c: Likewise.
938 * w32reg.c: Likewise.
939 * w32select.c: Likewise.
940 * w32uniscribe.c: Likewise.
941 * widget.c: Likewise.
945 * xselect.c: Likewise.
947 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
949 * fileio.c (time_error_value): Check the right error number.
950 Problem reported by Troels Nielsen in
951 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
953 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
955 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
956 This should be fixed in a better way; see Eli Zaretskii in
957 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
958 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
960 * fileio.c (time_error_value): Rename from special_mtime.
961 The old name's problems were noted by Eli Zaretskii in
962 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
964 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
965 This variable's comment says Emacs needs at least one GDB-visible
966 symbol of type enum pvec_type, to work around GDB problems.
967 The symbol's value doesn't matter.
969 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
970 that causes compilation to fail on pre-C99 compilers.
972 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
974 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
975 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
977 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
979 * buffer.c (init_buffer_once): Fix initialization of
980 headers for buffer_defaults and buffer_local_symbols.
981 Reported by Juanma Barranquero <lekktu@gmail.com>.
983 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
985 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
986 * lisp.h (enum pvec_type): Use fewer bits.
987 (PSEUDOVECTOR_SIZE_BITS): New constant.
988 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
989 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
991 (PSEUDOVECTOR_TYPEP): New macro.
992 (TYPED_PSEUDOVECTORP): Use it.
993 * fns.c (internal_equal): Adapt code to extract pvectype.
994 * emacs.c (gdb_pvec_type): Update type.
995 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
996 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
997 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
998 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
999 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1000 abusing vector->header.next.nbytes.
1001 (live_vector_p): Use PVEC_TYPE.
1002 (mark_object): Adapt code to extract pvectype. Use switch.
1004 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1006 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1007 Tighten new eassert a bit.
1009 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1011 Fix compilation with --enable-gcc-warnings and -O1
1013 * doprnt.c (doprnt): Change type of tem to int, initialize
1014 to avoid compiler warning. Add eassert.
1015 * search.c (simple_search): Initialize match_byte to avoid
1016 compiler warning. Add eassert.
1018 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1020 Avoid weird behavior with large horizontal scrolls.
1021 Without this change, for example, large hscroll values would
1022 mess up Emacs's display on Fedora 15 x86, presumably due to
1023 overflows in int calculations in the display code.
1024 Also, if buffers had long lines, Emacs would freeze.
1025 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1026 (set_window_hscroll): New function, containing the old guts of
1027 Fset_window_hscroll. Return the clipped value.
1028 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1029 This avoids the need to check against PTRDIFF_MAX.
1031 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1033 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1035 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1037 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1039 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1040 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1041 since GCC 4.4.6 issues a bogus warning for them.
1043 Fix bugs in file timestamp newness comparisons.
1044 * fileio.c (Ffile_newer_than_file_p):
1045 * lread.c (Fload): Use full timestamp resolution of files,
1046 not just the 1-second resolution, so that files that are only
1047 slightly newer still count as newer.
1048 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1049 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1051 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1053 * fileio.c: Improve handling of file time marker. (Bug#11852)
1054 (special_mtime): New function.
1055 (Finsert_file_contents, Fverify_visited_file_modtime):
1056 Use it to set special mtime values consistently.
1058 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1060 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1061 marker for non-existing file. (Bug#11852)
1063 2012-07-03 Glenn Morris <rgm@gnu.org>
1065 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1066 and did not make it into globals.h).
1068 2012-07-03 Tom Tromey <tromey@redhat.com>
1070 * window.c (Fset_window_margins, Fset_window_fringes)
1071 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1072 * textprop.c (Fprevious_property_change): No longer static.
1073 * syntax.c (Fsyntax_table_p): No longer static.
1074 * process.c (Fget_process, Fprocess_datagram_address): No longer
1076 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1077 * keyboard.c (Fcommand_execute): No longer static.
1079 * insdel.c (Fcombine_after_change_execute): No longer static.
1080 * image.c (Finit_image_library): No longer static.
1081 * fileio.c (Fmake_symbolic_link): No longer static.
1082 * eval.c (Ffetch_bytecode): No longer static.
1083 * editfns.c (Fuser_full_name): No longer static.
1084 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1086 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1088 * dired.c (Ffile_attributes): No longer static.
1089 * composite.c (Fcomposition_get_gstring): No longer static.
1090 * callproc.c (Fgetenv_internal): No longer static.
1092 * ccl.h: Remove EXFUNs.
1093 * buffer.h: Remove EXFUNs.
1094 * dispextern.h: Remove EXFUNs.
1095 * intervals.h: Remove EXFUNs.
1096 * fontset.h: Remove EXFUN.
1097 * font.h: Remove EXFUNs.
1098 * dosfns.c (system_process_attributes): Remove EXFUN.
1099 * keymap.h: Remove EXFUNs.
1100 * lisp.h: Remove EXFUNs.
1101 * w32term.h: Remove EXFUNs.
1102 * window.h: Remove EXFUNs.
1103 * xsettings.h: Remove EXFUN.
1104 * xterm.h: Remove EXFUN.
1106 2012-07-03 Glenn Morris <rgm@gnu.org>
1108 * lisp.h (Frandom): Make it visible to C.
1109 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1110 buffer for invisible buffers. (Bug#1229)
1112 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1114 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1115 values which aren't power of 2.
1116 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1117 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1120 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1122 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1124 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1126 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1128 * alloc.c (allocate_vector_block): Remove redundant
1129 calls to mallopt if DOUG_LEA_MALLOC is defined.
1130 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1131 avoid calls to mallopt if zero_vector is returned.
1133 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1135 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1136 is enabled, avoid dereferencing NULL current_sblock if
1139 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1141 Cleanup basic buffer management.
1142 * buffer.h (struct buffer): Change layout to use generic vector
1143 marking code. Fix some comments. Change type of 'clip_changed'
1144 to bitfield. Remove unused #ifndef old.
1145 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1146 (GET_OVERLAYS_AT): Fix indentation.
1147 (for_each_per_buffer_object_at): New macro.
1148 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1149 (Fbuffer_local_variables): Use it.
1150 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1151 * alloc.c (allocate_buffer): Adjust to match new layout of
1152 struct buffer. Fix comment.
1153 (mark_overlay): New function.
1154 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1155 Lisp area of struct buffer.
1156 (mark_object): Use it. Adjust marking of misc objects
1157 and related comments.
1159 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1161 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1162 wrapper that is not needed because the wrapped code is a no-op (zero
1163 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1164 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1166 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1168 * alloc.c (mark_buffer): Simplify. Remove prototype.
1169 (mark_object): Add comment. Reorganize marking of vector-like
1170 objects. Use CHECK_LIVE for all vector-like objects except buffers
1171 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1172 redundant calls to mark_vectorlike for bool vectors.
1174 2012-06-30 Glenn Morris <rgm@gnu.org>
1176 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1178 * epaths.in (PATH_SITELOADSEARCH): New.
1179 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1180 This is rather than relying on --enable-locallisppath elements
1181 having "site-lisp" in their names. (Bug#10208#25, 11658)
1183 2012-06-30 Eli Zaretskii <eliz@gnu.org>
1185 * w32proc.c (sys_select): Accept and ignore one more argument.
1187 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1189 * sysselect.h [DOS_NT]: Don't include sys/select.h.
1190 (pselect) [!MS_DOS]: Redirect to sys_select.
1192 * sysdep.c: Don't include dos.h and dosfns.h.
1194 * process.c (sys_select):
1195 * msdos.c (sys_select): Accept one more argument and ignore it.
1197 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1198 adapt data types and code to that.
1201 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1202 which clashes with the gnulib function of the same name.
1204 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1206 * font.c (font_style_to_value, font_style_symbolic)
1207 (font_prop_validate_style): Add type checks for values in
1210 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1212 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1215 2012-06-29 Eli Zaretskii <eliz@gnu.org>
1217 * xdisp.c (try_window_id): Undo last change.
1219 * w32.c (getwd): Adjust commentary about startup_dir.
1220 (init_environment): Always call sys_access, even in non-MSVC
1221 builds. Don't chdir to the directory of the Emacs executable.
1222 This undoes code from 1997 which was justified by the need to
1223 "avoid conflicts when removing and renaming directories". But its
1224 downside was that every relative file name was being interpreted
1225 relative to the directory of the Emacs executable, which can never
1226 be TRT. In particular, it broke sys_access when called with
1227 relative file names.
1228 (sys_access): Map GetLastError to errno.
1230 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1232 * window.h (struct window): Change type of 'fringes_outside_margins'
1233 to bitfield. Fix comment. Adjust users accordingly.
1234 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
1236 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1239 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
1241 * gnutls.c (emacs_gnutls_handshake):
1242 Add QUIT to make the loop interruptible.
1244 2012-06-29 Glenn Morris <rgm@gnu.org>
1246 * charset.c (init_charset): Make lack of etc/charsets fatal.
1248 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1250 * editfns.c (region_limit): Fix type mismatch.
1252 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1254 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1255 undefined. Convert from xassert to eassert.
1256 * nsmenu.m: Convert from xassert to eassert.
1257 * nsterm.m: Likewise.
1259 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1261 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1263 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1265 Avoid integer overflow on scroll-left and scroll-right.
1266 * window.c (HSCROLL_MAX): New macro.
1267 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1268 overflow when requested scroll falls outside ptrdiff_t range.
1270 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1272 * window.h (struct window): Change type of 'hscroll',
1273 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1274 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1275 Adjust users accordingly.
1276 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1277 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1278 from EMACS_INT to ptrdiff_t.
1279 (make_window): Omit redundant initialization.
1281 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
1283 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1285 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1287 * window.h (struct window): Change type of 'use_time' and
1288 'sequence_number' from Lisp_Object to int.
1289 * frame.c (make_frame): Adjust users accordingly.
1290 * print.c (print_object): Likewise.
1291 * window.c (select_window, Fwindow_use_time, make_parent_window)
1292 (make_window): Likewise.
1294 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1296 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1297 enabled with --enable-checking=[all,glyphs] configure option.
1298 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1299 adjust comments accordingly.
1300 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1301 undefined, adjust comments accordingly.
1302 * image.c: Likewise.
1303 * scroll.c: Likewise.
1304 * w32fns.c: Likewise.
1305 * w32term.c: Likewise.
1306 * xdisp.c: Likewise.
1307 * xfaces.c: Likewise.
1309 * xterm.c: Likewise.
1311 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1313 Generalize run-time debugging checks.
1314 * dispextern.h (XASSERTS): Remove.
1315 * fontset.c (xassert): Remove.
1316 Convert from xassert to eassert.
1317 * alloc.c: Convert from xassert to eassert.
1319 * dispnew.c: Likewise.
1321 * fringe.c: Likewise.
1322 * ftfont.c: Likewise.
1323 * gtkutil.c: Likewise.
1324 * image.c: Likewise.
1325 * keyboard.c: Likewise.
1327 * process.c: Likewise.
1328 * scroll.c: Likewise.
1329 * sound.c: Likewise.
1331 * w32console.c: Likewise.
1332 * w32fns.c: Likewise.
1333 * w32term.c: Likewise.
1334 * window.c: Likewise.
1335 * xdisp.c: Likewise.
1336 * xfaces.c: Likewise.
1338 * xselect.c: Likewise.
1339 * xterm.c: Likewise.
1341 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1343 * fns.c (maybe_resize_hash_table): Output message when growing the
1346 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1348 * alloc.c (allocate_string_data): Remove dead code.
1349 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1350 avoid GCC warning about unused macro.
1352 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1354 * alloc.c (allocate_string): Omit intervals initialization.
1355 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1356 as in make_pure_string and make_pure_c_string.
1358 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1360 * alloc.c (allocate_string): Fix last change.
1362 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1364 * alloc.c (allocate_string): Remove two redundant calls
1365 to memset, add explicit initialization where appropriate.
1367 2012-06-27 Glenn Morris <rgm@gnu.org>
1369 * lisp.mk (lisp): Remove paths.elc.
1371 2012-06-27 Chong Yidong <cyd@gnu.org>
1373 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1375 2012-06-26 John Wiegley <johnw@newartisans.com>
1377 * unexmacosx.c (copy_data_segment): Add two section names used
1378 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1380 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1381 when building with Clang.
1383 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1385 * eval.c (Fapply): Allow calling it with a single argument.
1387 2012-06-26 Eli Zaretskii <eliz@gnu.org>
1389 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1390 _stricmp and _strnicmp.
1391 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1393 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1395 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1397 (allocate_process): Likewise for new process.
1398 (allocate_terminal): Change to use offsetof.
1399 (allocate_frame): Likewise.
1400 * frame.c (make_frame): Omit redundant initialization.
1401 * window.c (make_parent_window): Use memset.
1402 (make_window): Omit redundant initialization.
1403 * process.c (make_process): Omit redundant initialization.
1404 * terminal.c (create_terminal): Likewise.
1406 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1408 * term.c (delete_tty): Remove redundant call to memset.
1410 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1412 * alloc.c: Remove build_string.
1413 * lisp.h: Define build_string as static inline. This provides
1414 a better opportunity to optimize away calls to strlen when the
1415 function is called with compile-time constant argument.
1416 * image.c (imagemagick_error): Convert to build_string.
1417 * w32proc.c (sys_spawnve): Likewise.
1418 * xterm.c (x_term_init): Likewise.
1420 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1422 Use sprintf return value instead of invoking strlen on result.
1423 In the old days this wasn't portable, since some sprintf
1424 implementations returned char *. But they died out years ago and
1425 Emacs already assumes sprintf returns int.
1426 Similarly for float_to_string.
1427 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1428 * ccl.c (ccl_driver):
1429 * character.c (string_escape_byte8):
1430 * data.c (Fnumber_to_string):
1431 * doprnt.c (doprnt):
1432 * print.c (print_object):
1433 * xdisp.c (message_dolog):
1434 * xfns.c (syms_of_xfns):
1435 Use sprintf or float_to_string result to avoid need to call strlen.
1436 * data.c (Fnumber_to_string):
1437 Use make_unibyte_string, since the string must be ASCII.
1438 * lisp.h, print.c (float_to_string): Now returns int length.
1439 * term.c (produce_glyphless_glyph):
1440 Use sprintf result rather than recomputing it.
1442 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1443 * Makefile.in (ALL_CFLAGS):
1444 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1445 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1447 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1449 * dispextern.h (xstrcasecmp): Define to library function
1450 strcasecmp if available.
1451 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1453 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1455 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1456 Avoid comma operator.
1457 * menu.c (push_submenu_start, push_submenu_end)
1458 (push_left_right_boundary, push_menu_pane): Likewise.
1459 * msdos.c (dos_rawgetc): Likewise.
1461 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1463 * xfns.c (xic_create_fontsetname): Remove redundant calls
1466 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1468 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1469 sprintf already null-terminates its output.
1471 * xfns.c (x_window): Remove redundant cast.
1473 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1475 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1476 `const char *' to `char *' to avoid compiler warning.
1478 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1480 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1481 instead of truncating it to 63 (admittedly a generous limit).
1483 * process.c: Fix spelling and caps in comments.
1485 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1487 * emacs.c (setpgrp): Remove definition, unused.
1488 * sysdep.c (setpgrp): Remove definition, not used in this file.
1490 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
1492 * makefile.w32-in: Update dependencies.
1494 2012-06-24 Eli Zaretskii <eliz@gnu.org>
1496 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1497 (SYSTIME_H): Add nt/inc/sys/time.h.
1499 * systime.h [WINDOWSNT]: Include sys/time.h.
1501 * s/ms-w32.h (struct timespec): Definition moved from
1502 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1504 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1506 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1507 * buffer.h (buffer_slot_type_mismatch):
1508 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1509 * eval.c (unwind_to_catch):
1510 * image.c (my_png_error, my_error_exit):
1511 * keyboard.c (quit_throw_to_read_char, user_error)
1512 (Fexit_recursive_edit, Fabort_recursive_edit):
1513 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1514 (wrong_type_argument, buffer_overflow, __executable_start)
1515 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1516 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1517 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1519 (child_setup) [!DOS_NT]:
1520 * lread.c (end_of_file_error, invalid_syntax):
1521 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1522 * puresize.h (pure_write_error):
1523 * search.c (matcher_overflow):
1524 * sound.c (sound_perror, alsa_sound_perror):
1525 * sysdep.c, syssignal.h (croak):
1526 * term.c (maybe_fatal, vfatal):
1527 * textprop.c (text_read_only):
1528 * undo.c (user_error):
1529 * unexmacosx.c (unexec_error):
1530 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1531 Use _Noreturn rather than NO_RETURN.
1532 No need for separate decl merely because of _Noreturn.
1533 * sound.c (sound_warning, parse_sound):
1534 Remove unnecessary forward decls.
1536 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1538 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1539 * lisp.h (WAIT_READING_MAX): New macro.
1540 * dispnew.c (Fsleep_for, sit_for):
1541 * keyboard.c (kbd_buffer_get_event):
1542 * process.c (Faccept_process_output):
1543 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1544 This improves on the previous patch, which introduced a bug
1545 when time_t is unsigned and as wide as intmax_t.
1546 See <http://bugs.gnu.org/9000#51>.
1548 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1550 * dispnew.c (sit_for, Fsleep_for):
1551 * keyboard.c (kbd_buffer_get_event):
1552 * process.c (Faccept_process_output): Avoid compiler warnings when
1553 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1555 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
1557 * makefile.w32-in: Update dependencies.
1559 * w32.c (ltime): Add return type and declare static.
1560 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1562 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1564 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1565 Privately reported by Herbert J. Skuhra.
1566 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1568 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1569 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1571 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1573 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1574 last argument of make_unibyte_string.
1576 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1577 language ID in the event parameters.
1579 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1580 event.code, not the obscure "character set ID".
1582 2012-06-23 Chong Yidong <cyd@gnu.org>
1584 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1586 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1588 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1589 * w32.c (fdutimens): New function.
1591 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1593 * s/ms-w32.h (pselect): Redirect to sys_select.
1595 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1597 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1598 in the logic of incrementing and decrementing the value of
1599 use_relocatable_buffers.
1601 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1603 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1604 Privately reported by Herbert J. Skuhra.
1605 [__FreeBSD__]: Remove "*/" typo after "#include".
1606 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1607 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1608 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1609 Don't assume EMACS_TIME and struct timeval are the same type.
1611 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1613 Support higher-resolution time stamps (Bug#9000).
1614 The time stamps are only nanosecond-resolution at the C level,
1615 since that's the best that any real-world system supports now.
1616 But they are picosecond-resolution at the Lisp level, as that's
1617 easy, and leaves room for future OS improvements.
1619 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1622 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1623 Don't get current time unless it's needed.
1625 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1626 now provides it if it's absent.
1627 (start_atimer): Port to higher-res time stamps.
1628 Check for time stamp overflow. Don't get current time more
1629 often than is needed.
1631 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1632 Include systime.h, not time.h.
1633 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1635 * dired.c: Include stat-time.h.
1636 (Ffile-attributes): File times now have higher resolution.
1638 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1639 (struct image): Timestamp now has higher resolution.
1641 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1642 has at least microseconds now. All uses removed.
1643 (update_frame, update_single_window, update_window, update_frame_1)
1644 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1646 * editfns.c (time_overflow): Now extern.
1647 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1648 (float-time, Fformat_time_string, Fcurrent_time_string)
1649 (Fcurrent_time_zone): Accept and generate higher-resolution
1651 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1652 (decode_time_components, lisp_seconds_argument): New functions.
1653 (make_time): Now static.
1654 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1655 Report an error if the time is invalid, rather than having the caller
1658 * fileio.c: Include <stat-time.h>
1659 (Fcopy_file): Copy higher-resolution time stamps.
1660 Prefer to set the time stamp via a file descriptor if that works.
1661 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1662 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1663 (Fvisited_file_modtime, Fset_visited_file_modtime):
1664 Support higher-resolution time stamps.
1666 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1668 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1670 * image.c (prepare_image_for_display, clear_image_cache)
1671 (lookup_image): Port to higer-resolution time stamps.
1673 * keyboard.c (start_polling, bind_polling_period):
1674 Check for time stamp overflow.
1675 (read_char, kbd_buffer_get_event, timer_start_idle)
1676 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1677 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1678 Port to higher-resolution time stamps. Do not assume time_t is signed.
1679 (decode_timer): New function. Timers are now vectors of length 9,
1680 not 8, to accommodate the picosecond component.
1681 (timer_check_2): Use it.
1683 * nsterm.m (select_timeout, timeval_subtract): Remove.
1684 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1685 as they're a bit more accurate and handle overflow better.
1686 (ns_select): Change prototype to be compatible with pselect.
1687 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1688 * nsterm.h (ns_select): Adjust prototype.
1690 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1691 us-resolution time stamps.
1692 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1694 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1696 * lisp.h (time_overflow): New decl.
1697 (wait_reading_process_output): First arg is now intmax_t, not int,
1698 to accommodate larger waits.
1700 * process.h (struct Lisp_Process.read_output_delay):
1701 Now counts nanoseconds, not microseconds.
1702 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1704 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1705 (wait_reading_process_output):
1706 Port to ns-resolution time stamps.
1707 (Faccept_process_output, wait_reading_process_output):
1708 Check for time stamp overflow. Do not assume time_t is signed.
1709 (select_wrapper): Remove; we now use pselect.
1710 (Fprocess_attributes): Now generates ns-resolution time stamps.
1712 * sysdep.c: Include utimens.h. Don't include utime.h
1713 or worry about struct utimbuf; gnulib does that for us now.
1714 (gettimeofday): Remove; gnulib provides a substitute.
1715 (make_timeval): New function.
1716 (set_file_times): Now sets ns-resolution time stamps.
1717 New arg FD; all uses changed.
1718 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1719 (system_process_attributes):
1720 Now returns ns-resolution time stamp. All uses changed.
1721 Check for time stamp overflow.
1723 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1724 provides a substitute now.
1726 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1727 since it guarantees struct timespec.
1728 (EMACS_TIME): Now struct timespec, so that we can support
1729 ns-resolution time stamps.
1730 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1731 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1732 (EMACS_USECS): Remove.
1733 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1734 so multiply the arg by 1000 before storing it.
1735 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1737 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1738 Port to ns-resolution time stamps.
1739 (EMACS_TIME_NEG_P): Remove; replaced by....
1740 (EMACS_TIME_SIGN): New macro.
1741 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1742 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1743 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1744 (make_timeval, make_lisp_time, decode_time_components): New decls.
1745 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1746 that it mishandled time_t overflow. You can't compare by subtracting!
1747 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1748 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1750 * term.c: Include <sys/time.h>.
1751 (timeval_to_Time): New function, for proper overflow wraparound.
1752 (term_mouse_position, term_mouse_click): Use it.
1754 * undo.c (record_first_change): Support higher-resolution time stamps
1756 (Fprimitive_undo): Use them when restoring time stamps.
1758 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1759 (w32_get_internal_run_time):
1760 Port to higher-resolution Emacs time stamps.
1761 (ltime): Now accepts single 64-bit integer, as that's more convenient
1764 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1766 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1767 for compatibility with pselect. Support ns-resolution time stamps.
1769 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1771 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1772 Check for time stamp overflow, and support ns-resolution time stamps.
1774 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1775 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1776 (timeval_subtract): Remove; no longer needed.
1777 (XTflash, XTring_bell, x_wait_for_event):
1778 Port to ns-resolution time stamps. Don't assume time_t is signed.
1780 2012-06-22 Chong Yidong <cyd@gnu.org>
1782 * xdisp.c (x_consider_frame_title): Revert last change.
1784 2012-06-22 Eli Zaretskii <eliz@gnu.org>
1786 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1787 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1788 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1789 staticidx goes up to 1597 out of 1600 = 0x640.)
1791 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1793 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1794 Otherwise, the umask might be mistakenly 0 while handling input signals.
1796 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1798 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1800 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1802 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1803 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1804 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1805 access to `contents' member of Lisp_Vector objects with AREF and ASET
1808 2012-06-19 Chong Yidong <cyd@gnu.org>
1810 * frame.c (delete_frame): When selecting a frame on a different
1811 text terminal, do not alter the terminal's top-frame.
1813 * xdisp.c (format_mode_line_unwind_data): Record the target
1814 frame's selected window and its terminal's top-frame.
1815 (unwind_format_mode_line): Restore them.
1816 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1818 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1819 since tty frames can be explicitly named.
1820 (prepare_menu_bars): Likewise.
1822 * term.c (Ftty_top_frame): New function.
1824 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1826 Port byte-code-meter to modern targets.
1827 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1828 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
1829 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
1830 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1831 (METER_1, METER_2): Simplify.
1833 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1835 * data.c (Fdefalias): Return `symbol' (bug#11686).
1837 2012-06-18 Martin Rudalics <rudalics@gmx.at>
1839 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1840 gets killed during executing of this function (Bug#11665).
1841 Try to always return Qt when the buffer has been actually killed.
1842 (Vkill_buffer_query_functions): In doc-string say that functions
1843 run by this hook should not change the current buffer.
1845 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1847 Fix recently-introduced process.c problems found by static checking.
1848 * process.c (write_queue_push, write_queue_pop, send_process):
1849 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1850 (write_queue_pop): Fix pointer signedness problem.
1851 (send_process): Remove unused local.
1853 2012-06-17 Chong Yidong <cyd@gnu.org>
1855 * xdisp.c (redisplay_internal): No need to redisplay terminal
1856 frames that are not on top.
1858 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
1860 * process.c (make_process): Initialize write_queue.
1861 (write_queue_push, write_queue_pop): New functions.
1862 (send_process): Use them to maintain correct ordering of process
1865 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1867 * lisp.h (eassert): Assume C89 or later.
1868 This removes the need for CHECK.
1869 (CHECK): Remove. Its comments about always evaluating its
1870 argument were confusing, as 'eassert' typically does not evaluate
1873 * coding.c (produce_chars): Use ptrdiff_t, not int.
1875 * xterm.c (x_draw_underwave): Check for integer overflow.
1876 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1878 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
1880 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1881 referenced (Bug#11583).
1883 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1885 Implement wave-style variant of underlining.
1886 * dispextern.h (face_underline_type): New enum.
1887 (face): Add field for underline type.
1888 * nsterm.m (ns_draw_underwave): New function.
1889 (ns_draw_text_decoration): Use it.
1890 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1892 (x_draw_glyph_string): Use them.
1893 * xfaces.c (Qline, Qwave): New Lisp objects.
1894 (check_lface_attrs, merge_face_ref)
1895 (Finternal_set_lisp_face_attribute, realize_x_face):
1896 Handle wave-style underline face attributes.
1897 * xterm.c (x_draw_underwave): New function.
1898 (x_draw_glyph_string): Use it.
1900 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
1902 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1903 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1904 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1905 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1906 ($(BLD)/w32select.$(O)): Update dependencies.
1908 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1910 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1911 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1912 * character.c (_fetch_multibyte_char_p): Remove.
1913 * alloc.c: Include "character.h" before "buffer.h".
1915 * buffer.c: Likewise.
1916 * bytecode.c: Likewise.
1917 * callint.c: Likewise.
1918 * callproc.c: Likewise.
1919 * casefiddle.c: Likewise.
1920 * casetab.c: Likewise.
1921 * category.c: Likewise.
1923 * coding.c: Likewise.
1924 * composite.c: Likewise.
1925 * dired.c: Likewise.
1926 * dispnew.c: Likewise.
1928 * dosfns.c: Likewise.
1929 * editfns.c: Likewise.
1930 * emacs.c: Likewise.
1931 * fileio.c: Likewise.
1932 * filelock.c: Likewise.
1934 * fontset.c: Likewise.
1935 * fringe.c: Likewise.
1936 * indent.c: Likewise.
1937 * insdel.c: Likewise.
1938 * intervals.c: Likewise.
1939 * keyboard.c: Likewise.
1940 * keymap.c: Likewise.
1941 * lread.c: Likewise.
1942 * macros.c: Likewise.
1943 * marker.c: Likewise.
1944 * minibuf.c: Likewise.
1945 * nsfns.m: Likewise.
1946 * nsmenu.m: Likewise.
1947 * print.c: Likewise.
1948 * process.c: Likewise.
1949 * regex.c: Likewise.
1950 * region-cache.c: Likewise.
1951 * search.c: Likewise.
1952 * syntax.c: Likewise.
1954 * textprop.c: Likewise.
1956 * unexsol.c: Likewise.
1957 * w16select.c: Likewise.
1958 * w32fns.c: Likewise.
1959 * w32menu.c: Likewise.
1960 * window.c: Likewise.
1961 * xdisp.c: Likewise.
1963 * xmenu.c: Likewise.
1965 * xselect.c: Likewise.
1967 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1969 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1970 If all the glyphs of the glyph row came from strings, and we have no
1971 cursor positioning clues, put the cursor on the first glyph of the
1973 (handle_face_prop): Use chunk-relative overlay string index when
1974 indexing into it->string_overlays array. (Bug#11653)
1975 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1976 the rightmost. (Bug#11720)
1978 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1980 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1981 (CATEGORY_MEMBER): Enforce 1/0 value.
1982 * category.c (_temp_category_set): Remove.
1984 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1986 * window.c (Fdelete_other_windows_internal)
1987 (Fdelete_window_internal): Don't access frame's mouse highlight
1988 info of the initial frame. (Bug#11677)
1990 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1992 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1993 Assume USE_2_TAGS_FOR_INTS.
1994 (xreload): Adjust $tagmask width to match recent lisp.h change.
1996 Simplify lisp.h in minor ways that should not affect code.
1997 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1998 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1999 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2000 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2001 (INTTYPEBITS): New macro, for clarity.
2002 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
2003 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2004 Simplify now that USE_LSB_TAG is always defined.
2005 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2006 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2008 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
2010 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2012 2012-06-13 Glenn Morris <rgm@gnu.org>
2014 * s/bsd-common.h (BSD4_3):
2015 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2017 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2019 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2022 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2024 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
2025 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
2026 * alloc.c (widen_to_Lisp_Object): Remove.
2027 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2028 * frame.c (delete_frame): Remove outdated comment.
2029 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2030 USE_LISP_UNION_TYPE.
2031 (Fw32_unregister_hot_key): Likewise.
2032 (Fw32_toggle_lock_key): Likewise.
2033 * w32menu.c (add_menu_item): Likewise.
2034 (w32_menu_display_help): Use XIL instead of checking
2035 USE_LISP_UNION_TYPE.
2036 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2037 (init_heap): Likewise.
2038 * w32term.c (w32_read_socket): Update comment.
2040 2012-06-13 Glenn Morris <rgm@gnu.org>
2042 * s/usg5-4-common.h, src/s/unixware.h:
2043 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2045 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2047 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2049 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2050 * alloc.c (make_number) [!defined make_number]:
2051 Remove, as lisp.h always defines this now.
2052 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2053 (roundup_size): Verify that it is a power of 2.
2054 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2055 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2056 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2057 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2058 USE_LSB_TAG now is always defined to be either 0 or 1.
2060 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2061 code works fine either way, and efficiency is not a concern here,
2062 as the union type is for debugging, not for production.
2063 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2064 Use an inline function on all platforms when using the union type,
2065 since this is simpler and 'static inline' can be used portably
2067 (LISP_INITIALLY_ZERO): New macro.
2068 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2069 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2071 2012-06-12 Glenn Morris <rgm@gnu.org>
2073 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2075 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
2077 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2078 Move BROKEN_SIGIO to configure.
2080 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2081 Move NO_TERMIO to configure.
2083 2012-06-12 Chong Yidong <cyd@gnu.org>
2085 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2086 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2087 MagickExportImagePixels is undefined.
2089 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2091 * image.c (imagemagick_load_image): Remove unused label.
2093 2012-06-11 Glenn Morris <rgm@gnu.org>
2095 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2096 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2097 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2098 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2100 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2102 * alloc.c (make_byte_code): New function.
2103 (Fmake_byte_code): Use it. Don't purify here.
2104 * lread.c (read1): Use it as well to avoid extra allocation.
2106 2012-06-11 Chong Yidong <cyd@gnu.org>
2108 * image.c (imagemagick_load_image): Implement transparency.
2110 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2112 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2113 account for preceding backslashes. (Bug#11663)
2115 2012-06-09 Chong Yidong <cyd@gnu.org>
2117 * term.c: Support italics in capable terminals (Bug#9652).
2118 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2119 (turn_on_face): Output using TS_enter_italic_mode if available.
2120 Don't handle unused blinking and alt-charset cases.
2121 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2122 and tty_alt_charset_p cases.
2123 (tty_capable_p, init_tty): Support italics.
2125 * termchar.h (struct tty_display_info): Add field for italics.
2126 Remove unused blink field.
2128 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2131 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2132 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2133 tty_alt_charset_p. Add tty_italic_p.
2135 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
2137 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2138 dbus_type_is_basic if available.
2139 (xd_extract_signed, xd_extract_unsigned): Rename from
2140 extract_signed and extract_unsigned, respectively. Adapt callers.
2142 2012-06-09 Chong Yidong <cyd@gnu.org>
2144 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2146 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2149 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2151 * xdisp.c (vmessage): Treat frame message as multibyte.
2152 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2153 would generate the diagnostic "Making \302\247 buffer-local while
2156 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2158 * dispnew.c (showing_window_margins_p): Undo last change, which
2159 was done due to an inadvertent commit.
2160 (adjust_frame_glyphs_for_frame_redisplay): Do call
2161 showing_window_margins_p.
2163 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2165 * eval.c (Fmake_var_non_special): New primitive.
2166 (syms_of_eval): Defsubr it.
2167 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2169 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
2171 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2172 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2174 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2176 * alloc.c (allocate_vectorlike): Fix last change.
2178 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2180 Block-based vector allocation of small vectors.
2181 * lisp.h (struct vectorlike_header): New field `nbytes',
2182 adjust comment accordingly.
2183 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2184 to denote vector blocks. Adjust users (live_vector_p,
2185 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2186 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2187 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2188 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2189 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2190 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2191 (roundup_size): New constant.
2192 (struct vector_block): New data type.
2193 (vector_blocks, vector_free_lists, zero_vector): New variables.
2194 (all_vectors): Rename to `large_vectors'.
2195 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2196 (sweep_vectors): New functions.
2197 (allocate_vectorlike): Return `zero_vector' as the only vector of
2198 0 items. Allocate new vector from block if vector size is less than
2199 or equal to VBLOCK_BYTES_MAX.
2200 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2201 (init_alloc_once): Add call to init_vectors.
2203 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2205 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2207 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2209 * doprnt.c (doprnt): Truncate multibyte char correctly.
2210 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2211 would mishandle a string argument "Xc" if X was a multibyte
2212 character of length 2: it would truncate after X's first byte
2213 rather than including all of X.
2215 2012-06-06 Chong Yidong <cyd@gnu.org>
2217 * buffer.c (word_wrap): Doc fix.
2219 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2221 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2223 2012-06-03 Glenn Morris <rgm@gnu.org>
2225 * xdisp.c (tool-bar-style): Doc fix.
2227 2012-06-03 Ulrich Müller <ulm@gentoo.org>
2229 * Makefile.in (PAXCTL): Define.
2230 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2231 binary via PaX flags if the paxctl utility is available.
2232 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2233 Restore PaX flags to their default. (Bug#11398)
2235 2012-06-03 Chong Yidong <cyd@gnu.org>
2237 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2240 2012-06-03 Chong Yidong <cyd@gnu.org>
2242 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2243 (note_mode_line_or_margin_highlight): If there is no help echo,
2244 use mode-line-default-help-echo. Handle the case where the mouse
2245 position is past the end of the mode line string.
2247 * buffer.c (buffer_local_value_1): New function, split from
2248 Fbuffer_local_value; can return Qunbound.
2249 (Fbuffer_local_value): Use it.
2250 (Vmode_line_format): Docstring tweaks.
2252 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2254 * sysdep.c (system_process_attributes): Improve comment.
2256 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2258 * keyboard.c: Export real-this-command to Elisp.
2259 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2260 and DEFVAR it. Update all users.
2262 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2264 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2266 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2267 Convert pctcpu and pctmem to Lisp float properly.
2268 Let the compiler fold better, as 100.0/0x8000 is exact.
2270 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2272 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2275 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2277 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2279 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2281 For a 'struct window', replace some Lisp_Object fields to
2282 bitfields where appropriate, remove unused fields.
2283 * window.h (struct window): Remove unused 'last_mark_x' and
2284 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2285 change it's type from Lisp_Object to bitfield.
2286 Change type of 'force_start', 'optional_new_start',
2287 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2288 fields from Lisp_Object to bitfield. Adjust users accordingly.
2290 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2292 Pacify gcc -Wdouble-precision when using Xaw.
2293 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2294 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2295 Use 'float' consistently, rather than 'float' in most places
2296 and 'double' in a couple of places.
2298 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2300 * xdisp.c (handle_stop): Detect whether we have overlay strings
2301 loaded by testing it->current.overlay_string_index to be
2302 non-negative, instead of checking whether n_overlay_strings is
2303 positive. (Bug#11587)
2305 2012-05-31 Chong Yidong <cyd@gnu.org>
2307 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2309 * doc.c (Fsubstitute_command_keys): Doc fix.
2311 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2313 * search.c (search_buffer): Remove calls to
2314 r_alloc_inhibit_buffer_relocation, as it is now called by
2315 maybe_unify_char, which was the cause of relocation of buffer text
2318 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2320 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2321 for the duration of call to load_charset, to avoid problems with
2322 callers of maybe_unify_char that access buffer text through C
2325 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2326 decrement the inhibition flag, instead of just setting or
2329 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2331 Remove obsolete '#define static' cruft.
2332 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2333 This #undef was "temporary" in 2000; it is no longer needed
2334 now that '#define static' has gone away.
2335 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2336 (gray_bitmap_bits): Remove; no longer needed.
2337 All uses replaced with definiens.
2338 * xterm.c: Include "bitmaps/gray.xbm".
2340 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2342 Clean up __executable_start, monstartup when --enable-profiling.
2343 The following changes affect the code only when profiling.
2344 * dispnew.c (__executable_start): Rename from safe_bcopy.
2345 Define only on platforms that need it.
2346 * emacs.c: Include <sys/gmon.h> when profiling.
2347 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2348 (__executable_start): Remove decl, since lisp.h does it now.
2349 (safe_bcopy): Remove decl; no longer has that name.
2350 (main): Coalesce #if into single bit of code, for simplicity.
2351 Cast pointers to uintptr_t, since standard libraries want integers
2353 * lisp.h (__executable_start): New decl.
2355 2012-05-31 Glenn Morris <rgm@gnu.org>
2357 * image.c (Fimagemagick_types): Doc fix.
2359 2012-05-30 Jim Meyering <meyering@redhat.com>
2361 * callproc.c (Fcall_process_region): Include directory component
2362 in mkstemp error message (Bug#11586).
2364 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2366 * alloc.c, lisp.h (make_pure_vector): Now static.
2368 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2370 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2371 Move to byte-run.el.
2372 (Fautoload): Do the hash-doc more carefully.
2373 * data.c (Fdefalias): Purify definition, except for keymaps.
2374 (Qdefun): Move from eval.c.
2375 * lisp.h (Qdefun): Remove.
2376 * lread.c (read1): Tiny simplification.
2378 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
2380 Do not create empty overlays with the evaporate property (Bug#9642).
2381 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2382 Bug#9642, but explicitly check that the buffer the overlay would
2383 be moved to is live and rearrange lines to make sure that errors
2384 will not put the overlay in an inconsistent state.
2385 (Fdelete_overlay): Cosmetics.
2387 2012-05-28 Eli Zaretskii <eliz@gnu.org>
2389 * w32term.c (my_bring_window_to_top): New function.
2390 (x_raise_frame): Use handle returned by DeferWindowPos, which
2391 could be different from the original one.
2392 Call my_bring_window_to_top instead of my_set_foreground_window.
2395 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2396 by calling BringWindowToTop.
2398 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2399 (WM_EMACS_END): Increase by one.
2401 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2403 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2404 This avoids undefined behavior that might cause the eassert
2405 to not catch an out-of-range value.
2407 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
2409 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2410 Update dependencies.
2412 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2414 * bidi.c (bidi_mirror_char): Fix last change.
2416 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2418 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2419 when referring to sectname field in printf format.
2421 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2423 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2424 Only r_alloc_inhibit_buffer_relocation needed to be added;
2425 the others were already declared.
2427 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2428 before checking whether it's out of range. Put the check inside
2430 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2432 2012-05-27 Ken Brown <kbrown@cornell.edu>
2434 * callproc.c (Fcall_process): Restore a line that was accidentally
2435 commented out in the 2011-02-13 change (bug#11547).
2437 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2439 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2440 defined on ralloc.c.
2442 * buffer.c [REL_ALLOC]: Remove prototypes of
2443 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2444 they are now on lisp.h.
2446 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2448 * search.c (search_buffer): Use it to inhibit relocation of buffer
2449 text while re_search_2 is doing its job, because re_search_2 is
2450 passed C pointers to buffer text. (Bug#11519)
2452 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2455 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2456 state after an additional call to move_it_in_display_line_to, keep
2457 the values of it->max_ascent and it->max_descent found for the
2459 (pos_visible_p): Revert the comparison against bottom_y to what it
2460 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2463 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2465 Fix coding-related core dumps with gcc -ftrapv.
2466 The code was computing A - B, where A and B are pointers, and B is
2467 random garbage. This can lead to core dumps on platforms that
2468 have special pointer registers, and it also leads to core dumps on
2469 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2470 A - B only when B is initialized properly.
2471 * coding.c (coding_set_source, coding_set_destination): Return void.
2472 (coding_change_source, coding_change_destinations): New functions,
2473 with the old behaviors of coding_set_source and coding_set_destination.
2474 All callers that need an offset changed to use these new functions.
2476 2012-05-26 Glenn Morris <rgm@gnu.org>
2478 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2480 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2482 Extend mouse support on W32 text-mode console.
2483 * xdisp.c (draw_row_with_mouse_face):
2484 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
2486 * w32console.c: Include window.h.
2487 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2489 (initialize_w32_display): Initialize mouse-highlight data.
2491 * w32inevt.c: Include termchar.h and window.h.
2492 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2493 moves, call note_mouse_highlight. If help_echo changed, call
2494 gen_help_event to produce help-echo message in the echo area.
2495 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2498 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2500 * lread.c (read1): Simplify slightly to avoid an overflow warning
2501 with GCC 4.7.0 on x86-64.
2503 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2505 * bidi.c (bidi_mirror_char): Revert last change: an int is
2506 definitely wide enough here.
2508 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
2510 Fix integer width and related bugs (Bug#9874).
2511 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
2512 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2513 (string_bytes, check_sblock, allocate_string_data):
2514 (compact_small_strings, Fmake_bool_vector, make_string)
2515 (make_unibyte_string, make_multibyte_string)
2516 (make_string_from_bytes, make_specified_string)
2517 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2518 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2520 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2521 (allocate_pseudovector):
2522 Use int, not EMACS_INT, where int is wide enough.
2523 (inhibit_garbage_collection, Fgarbage_collect):
2524 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2525 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2526 int might not be wide enough.
2527 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2528 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2529 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2530 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2531 (bidi_level_of_next_char, bidi_move_to_visually_next):
2532 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2533 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2534 (Fkill_buffer, Fset_buffer_major_mode)
2535 (advance_to_char_boundary, Fbuffer_swap_text)
2536 (Fset_buffer_multibyte, overlays_at, overlays_in)
2537 (overlay_touches_p, struct sortvec, record_overlay_string)
2538 (overlay_strings, recenter_overlay_lists)
2539 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2540 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2541 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2542 (Foverlay_recenter, last_overlay_modification_hooks_used)
2543 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2544 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2545 (validate_region): Omit unnecessary test for b <= e,
2546 since that's guaranteed by the previous test.
2547 (adjust_overlays_for_delete): Avoid pos + length overflow.
2548 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2549 (report_overlay_modification):
2550 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2551 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2552 Omit pointer cast, which isn't needed anyway, and doesn't work
2553 after the EMACS_INT -> ptrdiff_t change.
2554 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
2555 * buffer.h: Adjust decls to match defn changes elsewhere.
2556 (struct buffer_text, struct buffer):
2557 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2558 Use EMACS_INT, not int, where int might not be wide enough.
2559 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2560 not int, to avoid needless 32-bit limit on 64-bit hosts.
2561 (exec_byte_code): Use tighter memory-full test, one that checks
2562 for alloca overflow. Don't compute the address of the object just
2563 before an array, as that's not portable. Use EMACS_INT, not
2564 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
2565 * callint.c (Fcall_interactively):
2566 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2567 * callproc.c (call_process_kill, Fcall_process):
2568 Don't assume pid_t fits into an Emacs fixnum.
2569 (call_process_cleanup, Fcall_process, child_setup):
2570 Don't assume pid_t fits into int.
2571 (call_process_cleanup, Fcall_process, delete_temp_file)
2572 (Fcall_process_region):
2573 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2574 (Fcall_process): Simplify handling of volatile integers.
2575 Use int, not EMACS_INT, where int will do.
2576 * casefiddle.c (casify_object, casify_region, operate_on_word)
2577 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2578 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2579 (casify_object): Avoid integer overflow when overallocating buffer.
2580 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
2581 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
2582 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2583 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2584 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2585 integers are now checked earlier. All uses replaced with XINT.
2587 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2588 For CCL_MapSingle, check that content and value are in int range.
2589 (ccl_driver, Fregister_code_conversion_map):
2590 Check that Vcode_version_map_vector is a vector.
2591 (resolve_symbol_ccl_program): Check that vector header is in range.
2592 Always copy the vector, so that we can check its contents reliably
2593 now rather than having to recheck each instruction as it's being
2594 executed. Check that vector words fit in 'int'.
2595 (ccl_get_compiled_code, Fregister_ccl_program)
2596 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2597 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2598 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2599 contents are in range.
2600 (Fccl_execute_on_string): Check that status is in range.
2601 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2602 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2603 Accept and return EMACS_INT, not int, because callers can pass values
2605 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2606 (multibyte_chars_in_text, parse_str_as_multibyte)
2607 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2608 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2609 (string_escape_byte8, Fget_byte):
2610 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2611 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
2612 avoid mishandling large integers.
2613 * character.h: Adjust decls to match defn changes elsewhere.
2614 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2615 (Ffind_charset_region):
2616 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2617 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2618 (load_charset_map_from_vector, Fdefine_charset_internal):
2619 Don't assume fixnum fits in int.
2620 (load_charset_map_from_vector, Fmap_charset_chars):
2621 Remove now-unnecessary CHECK_NATNUMs.
2622 (Fdefine_charset_internal): Check ranges here, more carefully.
2623 Don't rely on undefined behavior with signed left shift overflow.
2624 Don't assume unsigned int fits into fixnum, or that fixnum fits
2625 into unsigned int. Don't require max_code to be a valid fixnum;
2626 that's not true for gb10830 4-byte on a 32-bit host. Allow
2627 invalid_code to be a cons, for the same reason. Require code_offset
2628 to be a character. Avoid int overflow if max_char is close
2630 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2631 this is intended anyway and avoids some undefined behavior.
2632 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2633 INDEX_TO_CODE_POINT, as that's what it expects.
2634 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
2635 * charset.h (DECODE_CHAR): Return int, not unsigned;
2636 this is what was intended anyway, and it avoids undefined behavior.
2637 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2638 integer-overflow issues.
2639 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2640 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2641 where the argument is EMACS_INT, and this behavior is not intended.
2642 * chartab.c (Fmake_char_table, Fset_char_table_range)
2643 (uniprop_get_decoder, uniprop_get_encoder):
2644 Don't assume fixnum fits in int.
2645 * cmds.c (move_point): New function, that does the gist of
2646 Fforward_char and Fbackward_char, but does so while checking
2647 for integer overflow more accurately.
2648 (Fforward_char, Fbackward_char): Use it.
2649 (Fforward_line, Fend_of_line, internal_self_insert)
2650 (internal_self_insert):
2651 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2652 Fix a FIXME, by checking for integer overflow when calculating
2653 target_clm and actual_clm.
2654 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
2655 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
2656 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2657 (coding_alloc_by_making_gap, alloc_destination)
2658 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2659 (encode_coding_utf_16, detect_coding_emacs_mule)
2660 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2661 (detect_coding_iso_2022, decode_coding_iso_2022)
2662 (encode_invocation_designation, encode_designation_at_bol)
2663 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2664 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2665 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2666 (encode_coding_ccl, encode_coding_raw_text)
2667 (detect_coding_charset, decode_coding_charset)
2668 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2669 (produce_composition, produce_charset, produce_annotation)
2670 (decode_coding, handle_composition_annotation)
2671 (handle_charset_annotation, consume_chars, decode_coding_gap)
2672 (decode_coding_object, encode_coding_object, detect_coding_system)
2673 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2674 (code_convert_region, code_convert_string)
2675 (Fdefine_coding_system_internal)
2676 (coding_set_source, coding_set_destination):
2677 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2678 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2679 (Fdefine_coding_system_internal):
2680 Don't assume fixnums fit in int.
2681 (decode_coding_gap, decode_coding_object, encode_coding_object)
2682 (Fread_coding_system, Fdetect_coding_region)
2683 (Funencodable_char_position, Fcheck_coding_systems_region)
2684 (get_translation, handle_composition_annotation, consume_chars):
2685 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2686 (consume_chars): Rewrite to not calculate an address outside buffer.
2687 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
2688 Don't access memory outside of the args array.
2689 (Fdefine_coding_system_internal): Check for charset-id overflow.
2690 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2691 result of ENCODE_CHAR.
2692 * coding.h: Adjust decls to match defn changes elsewhere.
2693 (struct coding_system):
2694 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2695 * composite.c (get_composition_id, find_composition)
2696 (run_composition_function, update_compositions)
2697 (compose_text, composition_gstring_put_cache)
2698 (composition_gstring_p, composition_gstring_width)
2699 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2700 (composition_compute_stop_pos, composition_reseat_it)
2701 (composition_update_it, struct position_record)
2702 (find_automatic_composition, composition_adjust_point)
2703 (Fcomposition_get_gstring, Ffind_composition_internal):
2704 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2705 (update_compositions):
2706 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2707 * composite.h: Adjust decls to match defn changes elsewhere.
2708 (struct composition):
2709 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2710 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2711 Do not attempt to compute the address of the object just before a
2712 buffer; this is not portable.
2714 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2715 (Faset): Use int, not EMACS_INT, where int is wide enough.
2716 (Fstring_to_number): Don't assume fixnums fit in int.
2717 (Frem): Don't assume arg is nonnegative.
2718 * dbusbind.c (xd_append_arg): Check for integers out of range.
2719 (Fdbus_call_method): Don't overflow the timeout int.
2720 (extract_signed, extract_unsigned): New functions.
2721 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2722 (xd_get_connection_references): Return ptrdiff_t, not int.
2724 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2725 (xd_read_message_1):
2726 Use int, not unsigned, where the dbus API uses int.
2727 (Fdbus_message_internal): Don't overflow mtype.
2728 (syms_of_dbusbind): Allocate right-sized buffer for integers.
2729 * dired.c (directory_files_internal, file_name_completion, scmp)
2730 (file_name_completion_stat):
2731 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2732 (file_name_completion): Don't overflow matchcount.
2733 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2734 * dispextern.h: Adjust decls to match defn changes elsewhere.
2735 (struct text_pos, struct glyph, struct bidi_saved_info)
2736 (struct bidi_string_data, struct bidi_it, struct composition_it)
2738 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2739 (struct display_pos, struct composition_it, struct it):
2740 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2741 * dispnew.c (increment_matrix_positions)
2742 (increment_row_positions, mode_line_string)
2743 (marginal_area_string):
2744 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2745 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
2746 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2747 (duration_to_sec_usec): New function, to check for overflow better.
2748 (Fsleep_for, sit_for): Use it.
2749 * doc.c (get_doc_string, store_function_docstring):
2750 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2751 (get_doc_string, Fsnarf_documentation):
2752 Use int, not EMACS_INT, where int is wide enough.
2754 Use SAFE_ALLOCA, not alloca.
2755 Check for overflow when converting EMACS_INT to off_t.
2756 * doprnt.c (doprnt):
2757 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2758 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2759 Don't assume uid_t fits into fixnum.
2760 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2761 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2762 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2763 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2764 (general_insert_function)
2765 (Finsert_char, make_buffer_string, make_buffer_string_both)
2766 (update_buffer_properties, Fbuffer_substring)
2767 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2768 (Fsubst_char_in_region, check_translation)
2769 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2770 (transpose_markers, Ftranspose_regions):
2771 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2772 (clip_to_bounds): Move to lisp.h as an inline function).
2773 (Fconstrain_to_field): Don't assume integers are nonnegative.
2774 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2775 (Fsubst_char_in_region, Fsave_restriction):
2776 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2777 (Femacs_pid): Don't assume pid_t fits into fixnum.
2778 (lo_time): Use int, not EMACS_INT, when int suffices.
2779 (lisp_time_argument): Check for usec out of range.
2780 (Fencode_time): Don't assume fixnum fits in int.
2781 (Fuser_login_name, Fuser_full_name): Signal an error
2782 if a uid argument is out of range, rather than relying on
2784 (Fformat_time_string): Remove now-unnecessary check.
2785 lisp_time_argument checks for out-of-range usec now.
2786 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
2787 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2788 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2789 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2790 (init_cmdargs, Fdump_emacs):
2791 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2792 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2793 the bottom (typically) 32 bits of the fixnum.
2794 * eval.c (specpdl_size, call_debugger):
2795 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2796 (when_entered_debugger, Fbacktrace_debug):
2797 Don't assume fixnum can fit in int.
2798 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2799 the object just before a buffer; this is not portable.
2800 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2801 (grow_specpdl, unbind_to):
2802 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2803 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2804 (grow_specpdl): Simplify allocation by using xpalloc.
2805 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
2806 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2807 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2808 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2809 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2811 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2812 (Fcopy_file, non_regular_nbytes, read_non_regular)
2813 (Finsert_file_contents):
2814 Use int, not EMACS_INT, where int is wide enough.
2815 (READ_BUF_SIZE): Verify that it fits in int.
2816 (Finsert_file_contents): Check that counts are in proper range,
2817 rather than assuming fixnums fit into ptrdiff_t etc.
2818 Don't assume fixnums fit into int.
2819 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
2820 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2821 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
2822 (string_char_to_byte, string_byte_to_char)
2823 (string_make_multibyte, string_to_multibyte)
2824 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2825 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2826 (substring_both, Fdelete, internal_equal, Ffillarray)
2827 (Fclear_string, mapcar1)
2828 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2829 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2830 (larger_vector, make_hash_table, maybe_resize_hash_table)
2831 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2832 (Fmaphash, secure_hash):
2833 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2834 (concat): Check for string index and length overflow.
2835 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2837 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2838 (larger_vector): New API (vec, incr_min, size_max) replaces old
2839 one (vec, new_size, init). This catches size overflow.
2840 INIT was removed because it was always Qnil.
2841 All callers changed.
2842 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2843 the upper bound on a hash table index size.
2844 (make_hash_table, maybe_resize_hash_table): Use it.
2845 (secure_hash): Computer start_byte and end_byte only after
2846 they're known to be in ptrdiff_t range.
2847 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2848 (Ffont_get_glyphs, Ffont_at):
2849 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2850 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2851 (Flist_fonts, Fopen_font):
2852 Don't assume fixnum can fit in int.
2853 (check_gstring): Don't assume index can fit in int.
2854 (font_match_p): Check that fixnum is a character, not a nonnegative
2855 fixnum, since the later code needs to stuff it into an int.
2856 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2857 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2858 conversion overflow issues.
2859 (Fopen_font): Check for integer out of range.
2860 (Ffont_get_glyphs): Don't assume index can fit in int.
2861 * font.h: Adjust decls to match defn changes elsewhere.
2862 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2864 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2865 printmax_t, where ptrdiff_t is wide enough.
2866 (Finternal_char_font):
2867 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2868 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2869 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2870 (Fset_frame_position, x_set_frame_parameters)
2871 (x_set_line_spacing, x_set_border_width)
2872 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2873 Check that fixnums are in proper range for system types.
2874 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2875 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2876 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2877 Use SAFE_ALLOCA_LISP, not alloca.
2878 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2879 intptr_t is wide enough.
2880 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2881 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2882 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2883 Check for fixnum out of range.
2884 * ftfont.c (ftfont_list): Don't assume index fits in int.
2885 Check that fixnums are in proper range for system types.
2886 (ftfont_shape_by_flt):
2887 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2888 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2889 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2890 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2891 Check that fixnums are in proper range for system types.
2892 * gnutls.h: Adjust decls to match defn changes elsewhere.
2893 * gtkutil.c (xg_dialog_run):
2894 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2895 (update_frame_tool_bar):
2896 Check that fixnums are in proper range for system types.
2897 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
2898 (lookup_image): Check that fixnums are in range for system types.
2899 * indent.c (last_known_column, last_known_column_point):
2900 (current_column_bol_cache):
2901 (skip_invisible, current_column, check_display_width):
2902 (check_display_width, scan_for_column, current_column_1)
2903 (Findent_to, Fcurrent_indentation, position_indentation)
2904 (indented_beyond_p, Fmove_to_column, compute_motion):
2905 (Fcompute_motion, Fvertical_motion):
2906 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2907 (last_known_column_modified): Use EMACS_INT, not int.
2908 (check_display_width):
2910 Check that fixnums and floats are in proper range for system types.
2911 (compute_motion): Don't assume index or fixnum fits in int.
2912 (compute_motion, Fcompute_motion):
2913 Use int, not EMACS_INT, when it is wide enough.
2914 (vmotion): Omit local var start_hpos that is always 0; that way
2915 we don't need to worry about overflow in expressions involving it.
2916 * indent.h: Adjust decls to match defn changes elsewhere.
2918 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2919 Use int, not EMACS_INT, where int is wide enough.
2920 Remove unused members ovstring_chars_done and tab_offset;
2922 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2923 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2924 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2925 (make_gap, copy_text, insert, insert_and_inherit)
2926 (insert_before_markers, insert_before_markers_and_inherit)
2927 (insert_1, count_combining_before, count_combining_after)
2928 (insert_1_both, insert_from_string)
2929 (insert_from_string_before_markers, insert_from_string_1)
2930 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2931 (adjust_after_replace, adjust_after_insert, replace_range)
2932 (replace_range_2, del_range, del_range_1, del_range_byte)
2933 (del_range_both, del_range_2, modify_region)
2934 (prepare_to_modify_buffer, signal_before_change)
2935 (signal_after_change, Fcombine_after_change_execute):
2936 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2937 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2938 (balance_an_interval, split_interval_right, split_interval_left)
2939 (find_interval, next_interval, update_interval)
2940 (adjust_intervals_for_insertion, delete_node, delete_interval)
2941 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2942 (static_offset_intervals, offset_intervals)
2943 (merge_interval_right, merge_interval_left, make_new_interval)
2944 (graft_intervals_into_buffer, temp_set_point_both)
2945 (temp_set_point, set_point, adjust_for_invis_intang)
2946 (set_point_both, move_if_not_intangible, get_property_and_range)
2947 (get_local_map, copy_intervals, copy_intervals_to_string)
2948 (compare_string_intervals, set_intervals_multibyte_1):
2949 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2950 * intervals.h: Adjust decls to match defn changes elsewhere.
2952 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2953 * keyboard.c (this_command_key_count, this_single_command_key_start)
2954 (before_command_key_count, before_command_echo_length, echo_now)
2955 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2956 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2957 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2958 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2959 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2960 (last_non_minibuf_size, last_point_position, echo_truncate)
2961 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2962 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2963 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2964 (stuff_buffered_input):
2965 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2966 (last_auto_save, command_loop_1, read_char):
2967 Use EMACS_INT, not int, to avoid integer overflow.
2968 (record_char): Avoid overflow in total_keys computation.
2969 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2970 * keyboard.h: Adjust decls to match defn changes elsewhere.
2971 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2972 (Fkey_description, Fdescribe_vector, Flookup_key):
2973 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2974 (click_position): New function, to check that positions are in range.
2975 (Fcurrent_active_maps):
2977 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2978 (Faccessible_keymaps, Fkey_description):
2979 (preferred_sequence_p):
2980 Don't assume fixnum can fit into int.
2981 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2982 Check for integer overflow in size calculations.
2983 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2984 avoid mishandling large integers.
2985 * lisp.h: Adjust decls to match defn changes elsewhere.
2986 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2987 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2988 (struct Lisp_Marker):
2989 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2990 (clip_to_bounds): Now an inline function, moved here from editfns.c.
2991 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2992 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2993 All callers changed.
2994 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2995 Assume the arg has valid form, since it always does.
2996 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2997 unsigned integer system type.
2998 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2999 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3000 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3001 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3002 (duration_to_sec_usec): New decl.
3003 * lread.c (read_from_string_index, read_from_string_index_byte)
3004 (read_from_string_limit, readchar, unreadchar, openp)
3005 (read_internal_start, read1, oblookup):
3006 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3007 (Fload, readevalloop, Feval_buffer, Feval_region):
3008 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3009 (openp): Check for out-of-range argument to 'access'.
3010 (read1): Use int, not EMACS_INT, where int is wide enough.
3011 Don't assume fixnum fits into int.
3012 Fix off-by-one error that can read outside a buffer.
3013 (read_filtered_event): Use duration_to_sec_usec
3014 to do proper overflow checking on durations.
3015 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3016 in size calculation.
3017 (Fexecute_kbd_macro):
3018 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3019 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3020 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3021 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3022 (set_marker_both, set_marker_restricted_both, marker_position)
3023 (marker_byte_position, Fbuffer_has_markers_at):
3024 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3025 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
3026 * menu.c (ensure_menu_items): Rename from grow_menu_items.
3027 It now merely ensures that the menu is large enough, without
3028 necessarily growing it, as this avoids some integer overflow issues.
3029 All callers changed.
3030 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3031 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3032 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3033 Use SAFE_ALLOCA_LISP, not alloca.
3034 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3035 to EMACS_INT. Check that fixnums are in proper range for system types.
3036 * minibuf.c (minibuf_prompt_width, string_to_object)
3037 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3038 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3039 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3040 (get_minibuffer, read_minibuf_unwind):
3041 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3042 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3043 this simplifies overflow checking. All callers changed.
3044 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3046 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3047 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3048 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3049 Check that fixnums are in proper range for system types.
3050 (Fx_create_frame, Fx_show_tip):
3051 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3052 * nsfont.m (ns_findfonts, nsfont_list_family):
3053 Don't assume fixnum fits in long.
3054 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3055 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3056 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3058 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
3059 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3060 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3061 (PRINTDECLARE, PRINTPREPARE):
3062 (strout, print_string):
3063 (print, print_preprocess, print_check_string_charset_prop)
3065 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3067 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3068 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3069 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
3070 (printchar, strout): Use xpalloc to catch size calculation overflow.
3071 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
3072 (print_error_message): Use SAFE_ALLOCA, not alloca.
3073 (print_object): Use int, not EMACS_INT, where int is wide enough.
3074 (print_depth, new_backquote_output, print_number_index):
3075 Use ptrdiff_t, not int, where int might not be wide enough.
3076 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3077 (Fset_process_window_size, Fformat_network_address)
3078 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
3080 Check that fixnums are in proper range for system types.
3081 (Fsignal_process): Simplify by avoiding a goto.
3082 Check for process-ids out of pid_t range rather than relying on
3084 (process_tick, update_tick): Use EMACS_INT, not int.
3085 (Fformat_network_address, read_process_output, send_process)
3086 (Fprocess_send_region, status_notify):
3087 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3088 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3089 (wait_reading_process_output, read_process_output, exec_sentinel):
3090 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3091 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3092 (Faccept_process_output): Use duration_to_sec_usec to do proper
3093 overflow checking on durations.
3094 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3095 Don't assume pid_t fits in int.
3096 * process.h (struct Lisp_Process): Members tick and update_tick
3097 are now of type EMACS_INT, not int.
3098 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3099 configured --with-wide-int.
3100 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3101 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3102 * search.c (looking_at_1, string_match_1):
3103 (fast_string_match, fast_c_string_match_ignore_case)
3104 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3105 (scan_newline, find_before_next_newline, search_command)
3106 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3107 (set_search_regs, wordify):
3110 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3111 (string_match_1, search_buffer, set_search_regs):
3113 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3114 (wordify): Check for overflow in size calculation.
3115 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3116 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3117 Check that fixnums are in proper range for system types.
3118 * sound.c (struct sound_device)
3119 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3120 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3121 (Fplay_sound_internal):
3122 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3123 * syntax.c (struct lisp_parse_state, find_start_modiff)
3124 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3125 (Fparse_partial_sexp):
3126 Don't assume fixnums can fit in int.
3127 (struct lisp_parse_state, find_start_pos, find_start_value)
3128 (find_start_value_byte, find_start_begv)
3129 (update_syntax_table, char_quoted, dec_bytepos)
3130 (find_defun_start, prev_char_comend_first, back_comment):
3131 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3132 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3133 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3134 (Finternal_describe_syntax_value): Check that match_lisp is a
3135 character, not an integer, since the code stuffs it into int.
3136 (scan_words, scan_sexps_forward):
3137 Check that fixnums are in proper range for system types.
3139 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3140 (scan_sexps_forward):
3141 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3142 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3143 * syntax.h: Adjust decls to match defn changes elsewhere.
3144 (struct gl_state_s):
3145 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3146 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3147 MOST_POSITIVE_FIXNUM.
3148 * sysdep.c (wait_for_termination_1, wait_for_termination)
3149 (interruptible_wait_for_termination, mkdir):
3150 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3151 (emacs_read, emacs_write):
3152 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3153 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3154 and double all fit in int.
3155 * term.c (set_tty_color_mode):
3156 Check that fixnums are in proper range for system types.
3157 * termhooks.h (struct input_event):
3158 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3159 * textprop.c (validate_interval_range, interval_of)
3160 (Fadd_text_properties, set_text_properties_1)
3161 (Fremove_text_properties, Fremove_list_of_text_properties)
3162 (Ftext_property_any, Ftext_property_not_all)
3163 (copy_text_properties, text_property_list, extend_property_ranges)
3164 (verify_interval_modification):
3165 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3166 (Fnext_single_char_property_change)
3167 (Fprevious_single_char_property_change):
3168 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3169 (copy_text_properties):
3170 Check for integer overflow in index calculation.
3171 * undo.c (last_boundary_position, record_point, record_insert)
3172 (record_delete, record_marker_adjustment, record_change)
3173 (record_property_change):
3174 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3175 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3176 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3177 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3178 (Fx_hide_tip, Fx_file_dialog):
3179 * w32menu.c (set_frame_menubar):
3180 Use ptrdiff_t, not int, for consistency with rest of code.
3181 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3182 (select_window, Fdelete_other_windows_internal)
3183 (window_scroll_pixel_based, window_scroll_line_based)
3184 (Frecenter, Fset_window_configuration):
3185 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3186 (Fset_window_hscroll, run_window_configuration_change_hook)
3187 (set_window_buffer, temp_output_buffer_show, scroll_command)
3188 (Fscroll_other_window, Frecenter):
3189 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3190 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3191 Don't assume fixnum fits in int.
3192 (Fset_window_scroll_bars):
3193 Check that fixnums are in proper range for system types.
3194 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3195 (string_pos, c_string_pos, number_of_chars, init_iterator)
3196 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3197 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3198 (compute_display_string_end, handle_face_prop)
3199 (face_before_or_after_it_pos, handle_invisible_prop)
3200 (handle_display_prop, handle_display_spec, handle_single_display_spec)
3201 (display_prop_intangible_p, string_buffer_position_lim)
3202 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3203 (get_overlay_strings_1, get_overlay_strings)
3204 (iterate_out_of_display_property, forward_to_next_line_start)
3205 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3206 (get_next_display_element, set_iterator_to_next)
3207 (get_visually_first_element, compute_stop_pos_backwards)
3208 (handle_stop_backwards, next_element_from_buffer)
3209 (move_it_in_display_line_to, move_it_in_display_line)
3210 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3211 (add_to_log, message_dolog, message_log_check_duplicate)
3212 (message2, message2_nolog, message3, message3_nolog
3213 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3214 (current_message_1, truncate_echo_area, truncate_message_1)
3215 (set_message, set_message_1, store_mode_line_noprop)
3216 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3217 (text_outside_line_unchanged_p, check_point_in_composition)
3218 (reconsider_clip_changes)
3219 (redisplay_internal, set_cursor_from_row, try_scrolling)
3220 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3221 (redisplay_window, find_last_unchanged_at_beg_row)
3222 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3223 (trailing_whitespace_p, find_row_edges, display_line)
3224 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3225 (display_mode_element, store_mode_line_string)
3226 (pint2str, pint2hrstr, decode_mode_spec)
3227 (display_count_lines, display_string, draw_glyphs)
3228 (x_produce_glyphs, x_insert_glyphs)
3229 (rows_from_pos_range, mouse_face_from_buffer_pos)
3230 (fast_find_string_pos, mouse_face_from_string_pos)
3231 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3232 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3233 (safe_call, init_from_display_pos, handle_fontified_prop)
3234 (handle_single_display_spec, load_overlay_strings)
3235 (with_echo_area_buffer, setup_echo_area_for_printing)
3236 (display_echo_area, echo_area_display)
3237 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3238 (update_tool_bar, hscroll_window_tree, redisplay_internal)
3239 (redisplay_window, dump_glyph_row, display_mode_line)
3240 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
3241 (handle_display_spec, display_prop_string_p):
3242 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3243 (handle_single_display_spec, build_desired_tool_bar_string)
3244 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3245 (get_specified_cursor_type):
3246 Check that fixnums are in proper range for system types.
3247 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3248 (Flookup_image_map):
3249 Don't assume fixnums fit in int.
3250 (compare_overlay_entries):
3251 Avoid mishandling comparisons due to subtraction overflow.
3252 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3253 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3254 (handle_tool_bar_click):
3255 Use int, not unsigned, since we prefer signed and the signedness
3256 doesn't matter here.
3257 (get_next_display_element, next_element_from_display_vector):
3258 Use int, not EMACS_INT, when int is wide enough.
3259 (start_hourglass): Use duration_to_sec_usec to do proper
3260 overflow checking on durations.
3261 * xfaces.c (Fbitmap_spec_p):
3262 Check that fixnums are in proper range for system types.
3263 (compare_fonts_by_sort_order):
3264 Avoid mishandling comparisons due to subtraction overflow.
3265 (Fx_family_fonts, realize_basic_faces):
3266 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3268 Don't assume fixnum fits in int.
3269 Use SAFE_ALLOCA_LISP, not alloca.
3270 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3271 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3272 (face_at_buffer_position, face_for_overlay_string)
3273 (face_at_string_position):
3274 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3275 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3276 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3278 Check that fixnums are in proper range for system types.
3279 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3280 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3281 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3282 (Fx_change_window_property): Don't assume fixnums fit in int.
3283 * xfont.c (xfont_chars_supported):
3284 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3285 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3286 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3287 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3288 * xml.c (parse_region):
3289 * xrdb.c (magic_file_p):
3290 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3291 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3292 (x_get_local_selection, x_reply_selection_request)
3293 (x_handle_selection_request, wait_for_property_change):
3294 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3295 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3296 short is wide enough.
3297 (x_send_client_event): Don't assume fixnum fits in int.
3298 * xterm.c (x_x_to_emacs_modifiers):
3299 Don't assume EMACS_INT overflows nicely into int.
3300 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3302 (handle_one_xevent): NATNUMP can eval its arg twice.
3303 (x_connection_closed):
3304 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3305 * xterm.h: Adjust decls to match defn changes elsewhere.
3306 (struct scroll_bar): Use struct vectorlike_header
3307 rather than rolling our own approximation.
3308 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3310 2012-05-25 Glenn Morris <rgm@gnu.org>
3312 * lisp.mk (lisp): Update for more files being compiled now.
3314 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3316 * lread.c: Remove `read_pure' which makes no difference.
3317 (read_pure): Remove var.
3318 (unreadpure): Remove function.
3319 (readevalloop): Don't call read_list with -1 flag.
3320 (read1, read_vector): Don't test read_pure any more.
3321 (read_list): Simplify.
3323 * fileio.c, character.h: Minor style tweaks.
3325 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3327 * window.h (clip_changed): Remove useless declaration.
3329 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
3331 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3332 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3334 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3337 This directory predates autoconf and is no longer needed nowadays.
3338 Move its few remaining bits of functionality to where they're needed.
3339 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3340 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3341 * m/template.h: Remove.
3342 * Makefile.in (M_FILE): Remove. All uses removed.
3343 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3344 * lisp.h (USE_LSB_TAG):
3345 * mem-limits.h (EXCEEDS_LISP_PTR):
3346 Use VAL_MAX, not VALBITS, in #if.
3347 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3348 (EMACS_UINT): Define unconditionally now.
3349 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3350 (BITS_PER_EMACS_INT): New constants, replacing
3351 what used to be in config.h, but not useful in #if.
3352 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3353 define them any more.
3354 (VAL_MAX): New macro.
3356 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3357 BITS_PER_EMACS_INT, in #if.
3358 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3359 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3360 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3361 * s/ms-w32.h (DATA_START):
3362 Move here from removed file m/intel386.h.
3363 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3364 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3366 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3368 Assume C89 or later.
3369 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3370 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3372 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3373 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3374 * textprop.c, tparam.c (NULL): Remove.
3375 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3376 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3377 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3378 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3379 * xterm.c (input_signal_count): Assume volatile works.
3381 2012-05-21 Ken Brown <kbrown@cornell.edu>
3383 * xgselect.c (xg_select): Fix first argument in call to 'select'
3386 2012-05-20 Ken Brown <kbrown@cornell.edu>
3388 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
3389 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
3391 2012-05-19 Ken Brown <kbrown@cornell.edu>
3393 * xfns.c (x_in_use): Remove `static' qualifier.
3394 * xterm.h (x_in_use): Declare.
3395 * xgselect.c: Include xterm.h.
3396 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3397 and `display_arg' (bug#9754).
3399 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3401 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3403 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3404 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3406 2012-05-18 Eli Zaretskii <eliz@gnu.org>
3408 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3410 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
3411 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
3413 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3414 reference to image_cache->refcount.
3415 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3417 2012-05-17 Juri Linkov <juri@jurta.org>
3419 * search.c (Fword_search_regexp, Fword_search_backward)
3420 (Fword_search_forward, Fword_search_backward_lax)
3421 (Fword_search_forward_lax): Move functions to isearch.el
3422 (bug#10145, bug#11381).
3424 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3426 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3428 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3430 * lread.c (init_obarray): Declare Qt and Qnil as special.
3432 2012-05-14 Glenn Morris <rgm@gnu.org>
3434 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
3435 Put "libexec" before "bin", for the sake of init_callproc_1.
3437 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3439 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3441 * unexaix.c: Port to more-recent AIX compilers.
3442 (report_error, report_error_1, make_hdr, copy_sym)
3443 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3444 Make arguments const char *, not char *, to avoid violations of C
3445 standard and to fix some AIX warnings reported by Gilles Pion.
3447 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3449 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3450 already have overlays loaded.
3451 (handle_single_display_spec): Before returning without displaying
3452 fringe bitmap, synchronize the bidi iterator with the main display
3453 iterator, by calling iterate_out_of_display_property.
3454 (iterate_out_of_display_property): Detect buffer iteration by
3455 testing that it->string is a Lisp string.
3456 (get_next_display_element): When the current object is exhausted,
3457 and there's something on it->stack, call set_iterator_to_next to
3458 proceed with what's on the stack, instead of returning zero.
3459 (set_iterator_to_next): If called at the end of a Lisp string,
3460 proceed to consider_string_end without incrementing string
3461 position. Don't increment display vector index past the end of
3462 the display vector. (Bug#11417)
3463 (pos_visible_p): Don't report a position visible when move_it_to
3464 stopped at the last line of window, which happens to be scanned
3465 backwards by the bidi iteration. (Bug#11464)
3467 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3469 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3470 and right-margin display specs even if the spec is invalid or we
3471 are on a TTY, and thus unable to display on the fringes.
3472 That's because the text with the property will not be displayed anyway,
3473 so we need to signal to the caller that this is a "replacing"
3474 display spec. This fixes display when the spec is invalid or we
3477 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3479 * unexaix.c (make_hdr): Fix typo in prototype.
3480 This bug broke the build on AIX. Problem reported by Gilles Pion.
3482 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
3484 * keyboard.c (kbd_buffer_get_event): Read special events also in
3485 batch mode. (Bug#11415)
3487 2012-05-12 Glenn Morris <rgm@gnu.org>
3489 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3491 2012-05-12 Eli Zaretskii <eliz@gnu.org>
3493 * lisp.mk (lisp): Add newcomment.elc.
3495 2012-05-12 Glenn Morris <rgm@gnu.org>
3497 * Makefile.in (MKDIR_P): New, set by configure.
3498 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3500 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3502 Remove unused function hourglass_started.
3503 * dispextern.h (hourglass_started):
3504 * w32fns.c (hourglass_started):
3505 * xdisp.c (hourglass_started): Remove.
3507 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
3509 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3510 Update dependencies.
3512 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3514 * xgselect.c (xg_select): Put maxfds+1 into a var.
3515 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3517 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3519 2012-05-10 Dave Abrahams <dave@boostpro.com>
3521 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3522 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3524 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
3526 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3527 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3528 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3529 Initialize xd_registered_buses.
3531 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3533 Untag more efficiently if USE_LSB_TAG.
3534 This is based on a proposal by YAMAMOTO Mitsuharu in
3535 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3536 For an admittedly artificial (nth 8000 longlist) benchmark on
3537 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3538 Emacs's overall text size by 1%.
3539 * lisp.h (XUNTAG): New macro.
3540 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3541 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3542 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3543 * eval.c (Fautoload):
3544 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3545 * frame.h (XFRAME): Use XUNTAG.
3547 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3548 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3549 Remove unportable assumptions about print widths of types like
3551 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3552 intptr_t when converting between pointer and integer, to avoid GCC
3553 warnings about wrong width.
3555 2012-05-09 Eli Zaretskii <eliz@gnu.org>
3557 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3558 stack for each reader_thread, instead of defaulting to 8MB
3559 determined by the linker. This avoids failures in creating
3560 subprocesses on Windows 7, see the discussion in this thread:
3561 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3563 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3565 Fix up display of the *Minibuf-0* buffer in the mini window.
3566 * keyboard.c (read_char): Don't clear the echo area if there's no
3568 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
3569 contents of *Minibuf-0*) if there's no message displayed in its stead.
3571 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
3573 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3576 2012-05-06 Chong Yidong <cyd@gnu.org>
3578 * lisp.mk (lisp): Update.
3580 2012-05-05 Jim Meyering <meyering@redhat.com>
3582 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3584 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3586 * data.c (PUT_ERROR): New macro.
3587 (syms_of_data): Use it. Add new error type `user-error'.
3588 * undo.c (user_error): New function.
3589 (Fprimitive_undo): Use it.
3590 * print.c (print_error_message): Adjust print style for `user-error'.
3591 * keyboard.c (user_error): New function.
3592 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3594 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3596 Do not limit current-time-string to years 1000..9999.
3597 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3598 (Fcurrent_time_string): Support any year that is supported by the
3599 underlying localtime representation. Don't use asctime, as it
3600 has undefined behavior for years outside the range -999..9999.
3602 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3604 Fix race conditions involving setenv, gmtime, localtime, asctime.
3605 Without this fix, interrupts could mess up code that uses these
3606 nonreentrant functions, since setting TZ invalidates existing
3607 tm_zone or tzname values, and since most of these functions return
3608 pointers to static storage.
3609 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3610 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3611 Grow the critical sections to include not just invoking
3612 localtime/gmtime, but also accessing these functions' results
3613 including their tm_zone values if any, and any related TZ setting.
3614 (format_time_string): Last arg is now struct tm *, not struct tm **,
3615 so that the struct tm is saved in the critical section.
3616 All callers changed. Simplify allocation of initial buffer, partly
3617 motivated by the fact that memory allocation needs to be outside
3618 the critical section.
3620 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3622 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3623 with RESET_INTERVAL.
3625 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3626 Remove duplicated buffer name initialization.
3628 2012-05-02 Jim Meyering <jim@meyering.net>
3630 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3632 * xfns.c (x_window): Use xstrdup (Bug#11375).
3634 2012-05-02 Eli Zaretskii <eliz@gnu.org>
3636 * xdisp.c (pos_visible_p): If already at a newline from the
3637 display string before the 'while' loop, don't walk back the glyphs
3638 from it3.glyph_row. Solves assertion violation when the display
3639 string begins with a newline (egg.el). (Bug#11367)
3641 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3643 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3646 2012-05-01 Glenn Morris <rgm@gnu.org>
3648 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3649 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3650 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3651 All were removed before 23.1.
3653 * dispnew.c: Remove HAVE_LIBNCURSES test;
3654 it is always true on relevant platforms.
3656 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3657 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3659 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3661 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3663 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3664 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3667 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3669 Do not avoid creating empty evaporating overlays (Bug#9642).
3670 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3671 That is, do not delete an evaporating overlay if it becomes
3672 empty after its bounds are adjusted to fit within its buffer.
3673 This fix caused other problems, and I'm reverting it until we get
3674 to the bottom of them.
3676 2012-04-27 Chong Yidong <cyd@gnu.org>
3678 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3680 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3682 * xdisp.c (pos_visible_p): If the window start position is beyond
3683 ZV, start the display from buffer beginning. Prevents assertion
3684 violation in init_iterator when the minibuffer window is scrolled
3687 * window.c (window_scroll_pixel_based): Likewise.
3689 2012-04-27 Chong Yidong <cyd@gnu.org>
3691 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3693 2012-04-27 Glenn Morris <rgm@gnu.org>
3695 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3696 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3698 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3700 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3701 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
3703 2012-04-26 Eli Zaretskii <eliz@gnu.org>
3705 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3706 display element, check also the underlying string or buffer
3707 character. (Bug#11341)
3709 * w32menu.c: Include w32heap.h.
3710 (add_menu_item): If the call to AppendMenuW (via
3711 unicode_append_menu) fails, disable Unicode menus only if we are
3712 running on Windows 9X/Me.
3714 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3716 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3717 (xgetint): Add missing shift for LSB tags.
3719 2012-04-24 Martin Rudalics <rudalics@gmx.at>
3721 * keyboard.c (read_char): Don't wipe echo area for select window
3722 events: These might get delayed via `mouse-autoselect-window'
3725 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
3727 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3728 manipulation of :loaded-from data.
3730 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
3732 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3733 now a cons (bug#11311).
3735 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3737 Do not create empty overlays with the evaporate property (Bug#9642).
3738 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3739 if it becomes empty after its bounds are adjusted to fit within
3740 its buffer. Without this fix, in a nonempty buffer (let ((o
3741 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3742 yields an empty overlay that has the evaporate property, which is
3743 not supposed to happen.
3745 Fix minor GTK3 problems found by static checking.
3746 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3747 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3748 (struct _EmacsFixedClass, emacs_fixed_get_type):
3749 Move decls here from emacsgtkfixed.h, since they needn't be public.
3750 (emacs_fixed_get_type): Now static.
3751 (emacs_fixed_class_init): Omit unused local.
3752 (emacs_fixed_child_type): Remove; unused.
3753 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3754 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3755 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3756 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3757 (EMACS_FIXED_GET_CLASS): Remove; unused.
3758 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3760 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3761 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3763 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3765 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
3766 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
3767 (__malloc_size_t, __malloc_ptrdiff_t):
3768 Remove. All uses removed, replaced by the definiens if needed,
3769 since we can assume C89 or better now.
3770 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3771 (protect_malloc_state, align, get_contiguous_space)
3772 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3773 (malloc_atfork_handler_child, malloc_enable_thread)
3774 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3775 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3776 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3777 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3778 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3779 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3780 Define using prototypes, not old style.
3781 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3782 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3783 (align): Don't assume that signed integer overflow wraps around.
3784 Omit unused local var.
3785 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3786 (_free_internal_nolock, memalign, mallochook, reallochook):
3787 Omit no-longer-needed casts.
3788 (valloc): Use getpagesize, not __getpagesize.
3789 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3790 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3792 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3794 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
3796 Move functions from C to Lisp. Make non-blocking method calls
3797 the default. Implement further D-Bus standard interfaces.
3799 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3800 (QCdbus_request_name_allow_replacement)
3801 (QCdbus_request_name_replace_existing)
3802 (QCdbus_request_name_do_not_queue)
3803 (QCdbus_request_name_reply_primary_owner)
3804 (QCdbus_request_name_reply_in_queue)
3805 (QCdbus_request_name_reply_exists)
3806 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3807 (QCdbus_registered_serial, QCdbus_registered_method)
3808 (QCdbus_registered_signal): New Lisp objects.
3809 (XD_DEBUG_MESSAGE): Use sizeof.
3810 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3811 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3812 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3813 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3814 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3815 (xd_signature, xd_append_arg): Allow float for integer types.
3816 (xd_get_connection_references): New function.
3817 (xd_get_connection_address): Rename from xd_initialize.
3818 Return cached address.
3819 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3820 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3822 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
3823 Return number of refcounts.
3824 (Fdbus_get_unique_name): Make stronger parameter check.
3825 (Fdbus_message_internal): New defun.
3826 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3827 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3828 (Fdbus_send_signal, Fdbus_register_service)
3829 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3830 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3831 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3832 (Vdbus_compiled_version, Vdbus_runtime_version)
3833 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3834 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3835 (Vdbus_message_type_signal): New defvars.
3836 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3839 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3841 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3842 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3843 Do not assume ptrdiff_t is the same width as 'int'.
3845 * alloc.c: Handle unusual debugging option combinations.
3846 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3847 since the two debugging options are incompatible.
3848 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3850 (mem_init, mem_insert, mem_insert_fixup):
3851 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3852 (NEED_MEM_INSERT): Remove; no longer needed.
3854 2012-04-22 Leo Liu <sdl.web@gmail.com>
3856 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3858 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3860 * sysdep.c [__FreeBSD__]: Minor cleanups.
3861 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3862 Use Emacs indenting style more consistently. Avoid some casts.
3863 Use 'double' consistently rather than mixing 'float' and 'double'.
3865 2012-04-21 Eduard Wiebe <usenet@pusto.de>
3867 * sysdep.c (list_system_processes, system_process_attributes):
3868 Add implementation for FreeBSD (Bug#5243).
3870 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3872 * lisp.mk (lisp): Update.
3874 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3876 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3877 It is never used otherwise.
3879 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3881 * print.c (print_preprocess): Only check print_depth if print-circle
3883 (print_object): Check for cycles even when print-circle is nil and
3884 print-gensym is t, but only check print_depth if print-circle is nil.
3886 2012-04-20 Chong Yidong <cyd@gnu.org>
3888 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3889 set the status to "failed" and ensure that sentinel is run.
3891 2012-04-20 Glenn Morris <rgm@gnu.org>
3893 * process.c (Fset_process_inherit_coding_system_flag)
3894 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
3895 (Fmake_network_process, Fmake_serial_process): Doc fix.
3897 2012-04-20 Eli Zaretskii <eliz@gnu.org>
3899 * xdisp.c (string_buffer_position_lim): Limit starting position to
3901 (set_cursor_from_row): If called for a mode-line or header-line
3902 row, return zero immediately.
3903 (try_cursor_movement): If inside continuation line, don't back up
3904 farther than the first row after the header line, if any.
3905 Don't consider the header-line row as "partially visible", even if
3906 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3908 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3910 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3913 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
3914 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
3916 configure: new option --enable-gcc-warnings (Bug#11207)
3917 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3918 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3919 (ALL_CFLAGS): Use new macros rather than old.
3920 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3921 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3922 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3923 -Wunused-result, -Wunused-variable. This should go away once
3924 the Emacs and Gnulib regex code is merged.
3925 (xmalloc, xrealloc): Now static.
3927 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3929 * dired.c (Fsystem_groups): Remove unused local.
3931 2012-04-17 Glenn Morris <rgm@gnu.org>
3933 * dired.c (Fsystem_users): Doc fix.
3935 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3937 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3938 (syms_of_dired): Add them.
3940 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3942 Fix minor alloc.c problems found by static checking.
3943 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3944 New extern decls, to avoid calling undeclared functions.
3945 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3946 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3947 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3948 (NEED_MEM_INSERT): New macro.
3949 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
3950 Remove one incorrect comment and fix another.
3952 Fix minor ralloc.c problems found by static checking.
3953 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3954 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3955 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3956 (r_alloc_sbrk): Now static.
3958 Improve ralloc.c interface checking.
3959 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3960 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3961 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3962 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3963 [REL_ALLOC]: ... to here, to check interface.
3964 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3965 Remove decls. This fixes an "It stinks!".
3967 * alloc.c (which_symbols): Fix alignment issue / type clash.
3969 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3971 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3972 (struct Lisp_Misc_Any): Likewise.
3973 (struct Lisp_Free): Likewise.
3974 * alloc.c (union aligned_Lisp_Symbol): Define.
3975 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3976 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3977 (union aligned_Lisp_Misc): Define.
3978 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3979 aligned_Lisp_Misc instead of union Lisp_Misc.
3980 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
3982 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3984 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3985 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3986 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3987 * s/netbsd.h, s/sol2-6.h:
3988 Remove definition of GC_MARK_STACK, since the default now works.
3989 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3990 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3991 no longer the default.
3992 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3994 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3996 * lread.c (lisp_file_lexically_bound_p):
3997 Fix hang at ";-*-\n" (bug#11238).
3999 2012-04-14 Eli Zaretskii <eliz@gnu.org>
4001 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4002 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4004 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4006 * nsterm.m (constrainFrameRect): Always constrain when there is only
4007 one screen (Bug#10962).
4009 2012-04-13 Ken Brown <kbrown@cornell.edu>
4011 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4013 2012-04-13 Reuben Thomas <rrt@sc3d.org>
4015 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4017 2012-04-11 Daniel Colascione <dancol@dancol.org>
4019 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4020 against is gone. It's better to use vfork now so that when Cygwin
4021 gains a new, working vfork, we use it automatically (bug#10398).
4023 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4025 * window.c (save_window_save): Obey window-point-insertion-type.
4027 2012-04-11 Glenn Morris <rgm@gnu.org>
4029 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4031 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4033 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4035 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
4037 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4038 (force_quit_count): New var.
4039 (handle_interrupt): Use it.
4041 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
4043 * w32.c (w32_delayed_load): Record the full path of the library
4044 being loaded (bug#10424).
4046 2012-04-09 Glenn Morris <rgm@gnu.org>
4048 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4049 not just in the obarray, before snarfing them. (Bug#11036)
4051 * Makefile.in ($(leimdir)/leim-list.el):
4052 Pass EMACS rather than BUILT_EMACS.
4054 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4056 * process.c (make_process):
4057 * process.h: Add integer `gnutls_handshakes_tried' member to
4060 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4061 Add convenience `GNUTLS_LOG2i' macro.
4063 * gnutls.c (gnutls_log_function2i): Convenience log function.
4064 (emacs_gnutls_read): Use new log functions,
4065 `gnutls_handshakes_tried' process member, and
4066 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4067 attempts per process (connection).
4069 2012-04-09 Chong Yidong <cyd@gnu.org>
4071 * eval.c (Fuser_variable_p, user_variable_p_eh)
4072 (lisp_indirect_variable): Functions deleted.
4073 (Fdefvar): Caller changed.
4075 * callint.c (Finteractive, Fcall_interactively):
4076 * minibuf.c (Fread_variable): Callers changed.
4078 2012-04-09 Eli Zaretskii <eliz@gnu.org>
4080 * xdisp.c (set_cursor_from_row): If the display string appears in
4081 the buffer at position that is closer to point than the position
4082 after the display string, display the cursor on the first glyph of
4083 the display string. Fixes cursor display when a 'display' text
4084 property immediately follows invisible text. (Bug#11094)
4086 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4088 composite.c: use 'double' consistently
4089 * composite.c (get_composition_id): Use 'double' consistently
4090 instead of converting 'float' to 'double' and vice versa; this is
4091 easier to understand and avoids a GCC warning.
4093 2012-04-09 Glenn Morris <rgm@gnu.org>
4095 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4096 preparation for dumping it with emacs. (Bug#4789)
4097 (leimdir): New variable.
4098 ($(leimdir)/leim-list.el): New rule.
4099 (emacs$(EXEEXT)): Depend on leim-list.el.
4101 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4102 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4103 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4105 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4107 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4110 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
4112 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4113 Remove unused local variable.
4115 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4117 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4118 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4119 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4120 objects, as mark_maybe_pointer will catch them otherwise.
4121 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4122 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4124 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4126 Fix typo that broke non-Windows builds.
4127 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4129 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4131 Support building on MS-Windows with libxml2.
4133 * makefile.w32-in (OBJ2): Add xml.$(O).
4134 (GLOBAL_SOURCES): Add xml.c.
4135 ($(BLD)/xml.$(O)): New dependency list.
4137 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4138 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4139 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4140 [!WINDOWSNT]: New macros.
4141 (init_libxml2_functions, libxml2_loaded_p): New functions.
4142 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4143 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4144 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4145 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4147 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4148 Call init_libxml2_functions before calling libxml2 functions.
4149 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4151 * emacs.c: Don't include libxml/parser.h.
4152 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4153 xmlCleanupParser directly.
4155 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4157 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4159 * indent.c (Fvertical_motion): If there is a display string at
4160 point, use it.vpos to compute how many lines to backtrack after
4161 move_it_to point. (Bug#11133)
4163 2012-04-06 Eli Zaretskii <eliz@gnu.org>
4165 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4166 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4167 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4168 macros related to unification of CJK characters. For the details,
4169 see the discussion following the message here:
4170 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4172 2012-04-04 Chong Yidong <cyd@gnu.org>
4174 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4176 2012-04-01 Eli Zaretskii <eliz@gnu.org>
4178 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4179 instead of alloca. (Bug#11138)
4181 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4183 * w32menu.c (is_simple_dialog): Properly check lisp types.
4186 2012-03-31 Eli Zaretskii <eliz@gnu.org>
4188 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4189 position we get to after a call to move_it_to fails the
4190 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4191 only if we wind up in a string from display property. (Bug#11063)
4193 * window.c (Fdelete_other_windows_internal): Invalidate the row
4194 and column information about mouse highlight, so that redisplay
4195 restores it after reallocating the glyph matrices. (Bug#7464)
4197 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4198 string comes from a `display' text property, use the buffer
4199 position of that property as if we actually saw that position in
4201 (move_it_by_lines): Remove the assertion that
4202 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4203 violated when there's a before-string at the beginning of a line.
4206 2012-03-30 Eli Zaretskii <eliz@gnu.org>
4208 * xdisp.c (append_space_for_newline): If the default face was
4209 remapped, use the remapped face for the appended newline.
4210 (extend_face_to_end_of_line): Use the remapped default face for
4211 extending the face to the end of the line.
4212 (display_line): Call extend_face_to_end_of_line when the default
4213 face was remapped. (Bug#11068)
4215 2012-03-29 Eli Zaretskii <eliz@gnu.org>
4217 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4219 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4221 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4223 2012-03-27 Glenn Morris <rgm@gnu.org>
4225 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4228 2012-03-26 Kenichi Handa <handa@m17n.org>
4230 * dispextern.h (struct glyph): Fix previous change. Change the
4231 bit length of glyphless.ch to 25 (Bug#11082).
4233 2012-03-26 Chong Yidong <cyd@gnu.org>
4235 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4236 (command_loop_1): Use it; inhibit selection update for
4237 handle-select-window too (Bug#8996).
4239 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4241 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
4243 2012-03-25 Kenichi Handa <handa@m17n.org>
4245 * dispextern.h (struct glyph): Change the bit length of
4246 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4248 2012-03-24 Eli Zaretskii <eliz@gnu.org>
4250 * s/ms-w32.h (tzname): Include time.h before redirecting to
4251 _tzname. Fixes the MSVC build. (Bug#9960)
4253 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4255 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4258 * xterm.c (XTread_socket): Only modify handling_signal if
4259 !SYNC_INPUT. (Bug#11080)
4261 2012-03-23 Eli Zaretskii <eliz@gnu.org>
4263 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4264 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4265 when fetching a multibyte character consumes more bytes than
4266 CHAR_BYTES returns, due to unification of CJK characters in
4267 string_char. (Bug#11073)
4269 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4271 * process.c (wait_reading_process_output): Handle pty disconnect
4272 by refraining from sending oneself a SIGCHLD (bug#10933).
4274 2012-03-22 Chong Yidong <cyd@gnu.org>
4276 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4278 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
4279 Mark string as coming from a prefix property.
4280 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4281 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4283 2012-03-21 Chong Yidong <cyd@gnu.org>
4285 * xfaces.c (Vface_remapping_alist): Doc fix.
4287 2012-03-20 Eli Zaretskii <eliz@gnu.org>
4289 * w32proc.c (Fw32_set_console_codepage)
4290 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4293 2012-03-20 Chong Yidong <cyd@gnu.org>
4295 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4296 to reflect default non-nil value of redisplay-dont-pause.
4298 2012-03-19 Kenichi Handa <handa@m17n.org>
4300 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4301 it fit in a valid range (Bug#11003).
4303 2012-03-18 Eli Zaretskii <eliz@gnu.org>
4305 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4306 that is not from display property, accept the row as a "cursor
4307 row" if one of the string's character has a non-nil `cursor'
4308 property. Fixes cursor positioning when there are newlines in
4309 overlay strings, e.g. in icomplete.el. (Bug#11035)
4311 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4313 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4315 2012-03-12 Chong Yidong <cyd@gnu.org>
4317 * eval.c (inhibit_lisp_code): Rename from
4318 inhibit_window_configuration_change_hook; move from window.c.
4320 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4321 * window.c (run_window_configuration_change_hook)
4322 (syms_of_window): Callers changed.
4324 2012-03-11 Chong Yidong <cyd@gnu.org>
4326 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4328 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4330 2012-03-10 Chong Yidong <cyd@gnu.org>
4332 * frame.c (other_visible_frames): Don't assume the selected frame
4333 is visible (Bug#10955).
4335 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4337 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4339 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4341 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4342 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4345 2012-03-03 Glenn Morris <rgm@gnu.org>
4347 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
4349 2012-03-02 Eli Zaretskii <eliz@gnu.org>
4351 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4352 position past the first glyph_row that ends at ZV. (Bug#10902)
4353 (redisplay_window, next_element_from_string): Fix typos in
4355 (redisplay_window): Pass to move_it_vertically the margin in
4356 pixels, not in screen lines.
4358 2012-03-02 Glenn Morris <rgm@gnu.org>
4360 * buffer.c (buffer-list-update-hook): Doc fix.
4362 2012-02-29 Eli Zaretskii <eliz@gnu.org>
4364 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4365 push_it before setting up the iterator for the first overlay
4366 string, even if we have an empty string loaded.
4367 (next_overlay_string): If there's an empty string on the iterator
4368 stack, pop the stack. (Bug#10903)
4370 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4372 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4373 Suggested by Stefan Monnier in
4374 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4375 * alloc.c (widen_to_Lisp_Object): New static function.
4376 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4377 and widening them to Lisp_Objects. This would work even if
4378 USE_LSB_TAG is defined and wide integers are used, which might
4379 happen in a future version of Emacs.
4381 2012-02-25 Chong Yidong <cyd@gnu.org>
4383 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4386 * xselect.c (Fx_selection_exists_p): Doc fix.
4387 (x_clipboard_manager_save_all): Print an informative message
4388 before saving to clipboard manager.
4390 2012-02-24 Chong Yidong <cyd@gnu.org>
4392 * keyboard.c (process_special_events): Handle all X selection
4393 requests in kbd_buffer, not just the next one (Bug#8869).
4395 2012-02-23 Chong Yidong <cyd@gnu.org>
4397 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4398 call when setting menu-bar-lines and tool-bar-lines parameters.
4399 (unwind_create_frame_1): New helper function.
4401 * window.c (inhibit_window_configuration_change_hook): New var.
4402 (run_window_configuration_change_hook): Obey it.
4403 (syms_of_window): Initialize it.
4405 2012-02-22 Chong Yidong <cyd@gnu.org>
4407 * xterm.c (x_draw_image_relief): Add missing type check for
4408 Vtool_bar_button_margin (Bug#10743).
4410 2012-02-21 Chong Yidong <cyd@gnu.org>
4412 * fileio.c (Vfile_name_handler_alist): Doc fix.
4414 * buffer.c (Fget_file_buffer): Protect against invalid file
4415 handler return value.
4417 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4419 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4420 when computing $valmask.
4422 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4423 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4424 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4425 It's useless in that case, and it can cause problems on hosts
4426 that allocate halves of EMACS_INT values separately.
4427 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4428 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4429 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4430 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4431 it avoids undefined behavior on hosts where shifting right by more
4432 than the word width has undefined behavior.
4434 2012-02-19 Chong Yidong <cyd@gnu.org>
4436 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4437 (Funhandled_file_name_directory, Ffile_name_as_directory)
4438 (Fdirectory_file_name, Fexpand_file_name)
4439 (Fsubstitute_in_file_name): Protect against invalid file handler
4440 return values (Bug#10845).
4442 2012-02-18 Eli Zaretskii <eliz@gnu.org>
4444 * .gdbinit (pitx): Fix incorrect references to fields of the
4447 2012-02-17 Chong Yidong <cyd@gnu.org>
4449 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4451 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4453 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4454 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4456 2012-02-15 Chong Yidong <cyd@gnu.org>
4458 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4459 marked as special. Also, starting docstrings with * is obsolete.
4461 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4463 * gnutls.c (emacs_gnutls_write): Fix last change.
4465 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4467 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4470 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4472 * keymap.c (Fsingle_key_description): Handle char ranges.
4474 2012-02-12 Chong Yidong <cyd@gnu.org>
4476 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4477 as that creates a dangerous corner case.
4479 * window.c (Fdelete_window_internal): Invalidate the mouse
4480 highlight (Bug#9904).
4482 2012-02-12 Glenn Morris <rgm@gnu.org>
4484 * xselect.c (Fx_own_selection_internal)
4485 (Fx_get_selection_internal, Fx_disown_selection_internal)
4486 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4487 * nsselect.m (Fx_own_selection_internal)
4488 (Fx_disown_selection_internal, Fx_selection_exists_p)
4489 (Fx_selection_owner_p, Fx_get_selection_internal):
4490 Sync docs and argument specs with the xselect.c versions.
4492 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4494 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4496 2012-02-11 Eli Zaretskii <eliz@gnu.org>
4498 * w32select.c (Fx_selection_exists_p): Sync doc string and
4499 argument list with xselect.c. (Bug#10783)
4501 * w16select.c (Fx_selection_exists_p): Sync doc string and
4502 argument list with xselect.c. (Bug#10783)
4504 2012-02-10 Glenn Morris <rgm@gnu.org>
4506 * fns.c (Fsecure_hash): Doc fix.
4508 2012-02-09 Kenichi Handa <handa@m17n.org>
4510 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4512 2012-02-07 Chong Yidong <cyd@gnu.org>
4514 * buffer.c (Fbuffer_local_variables)
4515 (buffer_lisp_local_variables): Handle unbound vars correctly;
4516 don't let Qunbound leak into Lisp.
4518 2012-02-07 Glenn Morris <rgm@gnu.org>
4520 * image.c (Fimagemagick_types): Doc fix.
4522 * image.c (imagemagick-render-type): Change it from a lisp object
4523 to an integer. Move the doc here from the lisp manual.
4524 Treat all values not equal to 0 the same.
4526 2012-02-06 Chong Yidong <cyd@gnu.org>
4528 * doc.c (store_function_docstring): Avoid applying docstring of
4529 alias to base function (Bug#2603).
4531 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4533 * .gdbinit (pp1, pv1): Remove redundant defines.
4536 2012-02-04 Chong Yidong <cyd@gnu.org>
4538 * nsterm.m: Declare a global (Bug#10694).
4540 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4542 * w32.c (get_emacs_configuration_options):
4543 Include --enable-checking, if specified, in the return value.
4545 2012-02-04 Martin Rudalics <rudalics@gmx.at>
4547 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4548 after rounding frame sizes. (Bug#9723)
4550 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4552 * keyboard.c (adjust_point_for_property): Don't position point
4553 before BEGV. (Bug#10696)
4555 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4557 Handle overflow when computing char display width (Bug#9496).
4558 * character.c (char_width): Return EMACS_INT, not int.
4559 (char_width, c_string_width): Check for overflow when
4560 computing the width; this is possible now that individual
4561 characters can have unbounded width. Problem introduced
4562 by merge from Emacs 23 on 2012-01-19.
4564 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
4566 * dbusbind.c (Fdbus_register_method): Mention the return value
4567 :ignore in the docstring.
4569 2012-02-02 Glenn Morris <rgm@gnu.org>
4571 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4573 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4574 Unconditionally set to t. (Bug#10673)
4575 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4576 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4577 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4579 2012-02-02 Kenichi Handa <handa@m17n.org>
4581 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4582 0, do not call append_composite_glyph.
4584 2012-02-02 Kenichi Handa <handa@m17n.org>
4586 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4588 (x_produce_glyphs): If the component of a composition is a null
4589 string, set it->pixel_width to 1 to avoid zero-width glyph.
4591 2012-02-01 Eli Zaretskii <eliz@gnu.org>
4593 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4594 first 2 arguments are identical. This makes inserting large
4595 output from a subprocess an order of magnitude faster on
4596 MS-Windows, where all sbrk'ed memory is always contiguous.
4598 2012-01-31 Glenn Morris <rgm@gnu.org>
4600 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4601 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4602 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4604 2012-01-29 Glenn Morris <rgm@gnu.org>
4606 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4608 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4610 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4612 2012-01-28 Chong Yidong <cyd@gnu.org>
4614 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4616 2012-01-26 Chong Yidong <cyd@gnu.org>
4618 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4620 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4621 repeat counts (Bug#10507).
4623 2012-01-26 Glenn Morris <rgm@gnu.org>
4625 * lread.c (syms_of_lread): Doc fix.
4627 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4629 * coding.c (encode_designation_at_bol): Change return value to
4632 2012-01-25 Chong Yidong <cyd@gnu.org>
4634 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4636 2012-01-21 Chong Yidong <cyd@gnu.org>
4638 * floatfns.c (Fcopysign): Make the second argument non-optional,
4639 since nil is not allowed anyway.
4641 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4643 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4644 (send_process): Likewise.
4646 2012-01-19 Martin Rudalics <rudalics@gmx.at>
4648 * window.c (save_window_save, Fcurrent_window_configuration)
4649 (Vwindow_persistent_parameters): Do not use Qstate.
4650 Rewrite doc-strings.
4652 2012-01-19 Kenichi Handa <handa@m17n.org>
4654 * character.c (char_width): New function.
4655 (Fchar_width, c_string_width, lisp_string_width):
4656 Use char_width (Bug#9496).
4658 2012-01-16 Martin Rudalics <rudalics@gmx.at>
4660 * window.c (Vwindow_persistent_parameters): New variable.
4661 (Fset_window_configuration, save_window_save): Handle persistent
4664 2012-01-14 Eli Zaretskii <eliz@gnu.org>
4666 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4667 thrashing the stack of the thread. (Bug#9087)
4669 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4671 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4673 2012-01-11 Eli Zaretskii <eliz@gnu.org>
4675 * xdisp.c (rows_from_pos_range): Handle the case where the
4676 highlight ends on a newline. (Bug#10464)
4677 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4678 he end column for display of highlight that ends on a newline
4681 2012-01-11 Glenn Morris <rgm@gnu.org>
4683 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4684 from load-path also when installation-directory is nil. (Bug#10208)
4686 2012-01-10 Glenn Morris <rgm@gnu.org>
4688 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4690 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4691 Update template values to be closer to their typical values these days.
4693 2012-01-09 Eli Zaretskii <eliz@gnu.org>
4695 * xdisp.c (rows_from_pos_range): Accept additional argument
4696 DISP_STRING, and accept any glyph in a row whose object is that
4697 string as eligible for mouse highlight. Fixes mouse highlight of
4698 display strings from overlays. (Bug#10464)
4700 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
4702 emacs: fix an auto-save permissions race condition (Bug#10400)
4703 * fileio.c (auto_saving_dir_umask): New static var.
4704 (Fmake_directory_internal): Use it.
4705 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4706 creating the directory. The old code temporarily assigns
4707 too-generous permissions to the directory.
4708 (do_auto_save_eh): Clear it.
4709 (Fdo_auto_save): Catch all errors, not just file errors, so
4710 that the var is always cleared.
4712 2012-01-07 Eli Zaretskii <eliz@gnu.org>
4714 * search.c (scan_buffer): Pass character positions to
4715 know_region_cache, not byte positions. (Bug#6540)
4717 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
4719 * w32.c (sys_rename): Report EXDEV when rename of a directory
4720 fails because the target is on another logical disk. (Bug#10284)
4722 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4724 * xterm.c (x_embed_request_focus): New function.
4726 * xterm.h: Add prototype.
4728 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4730 2012-01-05 Glenn Morris <rgm@gnu.org>
4732 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4734 2012-01-01 Eli Zaretskii <eliz@gnu.org>
4736 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4737 Load gnutls_transport_set_lowat only if GnuTLS version is below
4739 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4740 GnuTLS versions below 2.11.1.
4742 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4744 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4745 to the doc string advising against its use for altering the way
4746 windows are scrolled.
4748 2011-12-28 Kenichi Handa <handa@m17n.org>
4750 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4751 coding-system ASCII compatible only when it does not produce BOM
4752 on encoding (Bug#10383).
4754 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4756 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4758 (create_and_show_popup_menu): Always use menu_position_func for
4761 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4763 * callint.c (Fcall_interactively): Don't truncate prompt string.
4765 2011-12-23 Eli Zaretskii <eliz@gnu.org>
4767 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4768 property that ends at ZV, so that the bidi iteration could be
4769 resumed from there (after widening). (Bug#10360)
4771 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4773 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4775 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4777 * nsterm.m (x_free_frame_resources):
4778 Release f->output_data.ns->miniimage.
4779 (ns_index_color): Fix indentation. Do not retain
4780 color_table->colors[i].
4782 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4785 * nsfns.m (x_set_background_color): Assign return value from
4786 ns_index_color to face-background instead of NSColor*.
4787 (ns_implicitly_set_icon_type): Fix indentation.
4788 Change assignment in for loop to comparison.
4790 * emacs.c (ns_pool): New variable.
4791 (main): Assign ns_pool.
4792 (Fkill_emacs): Call ns_release_autorelease_pool.
4794 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4795 autorelease fdesc, release fdAttrs and tdict.
4796 (ns_get_covering_families): Release charset.
4797 (ns_findfonts): Release NSFontDescriptor created with new.
4798 (ns_uni_to_glyphs): Fix indentation.
4799 (setString): Release attrStr before assigning new value.
4801 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4803 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4805 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4806 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4808 2011-12-18 David Reitter <reitter@cmu.edu>
4810 * nsterm.m (ns_term_init): Subscribe for notifications
4811 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4812 to method trackingNotification in EmacsMenu.
4814 * nsmenu.m (trackingMenu): New variable.
4815 (trackingNotification): New method (from Aquamacs).
4816 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
4817 from Aquamacs (Bug#7030).
4819 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4821 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4822 (symbol_to_nsstring): Fix indentation.
4823 (ns_symbol_to_pb): New function.
4824 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4825 (Fns_rotate_cut_buffers_internal): Remove.
4826 (Fns_store_selection_internal): Rename from
4827 Fns_store_cut_buffer_internal.
4828 (ns_get_foreign_selection, Fx_own_selection_internal)
4829 (Fx_disown_selection_internal, Fx_selection_exists_p)
4830 (Fns_get_selection_internal, Fns_store_selection_internal):
4831 Use ns_symbol_to_pb and check if return value is nil.
4832 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4833 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
4834 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4835 renamed to Sns_store_selection_internal.
4836 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4837 and remove this function.
4838 (ns_handle_selection_clear): Remove, never used.
4839 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4842 2011-12-17 Ken Brown <kbrown@cornell.edu>
4844 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4845 GID is unknown (Bug#10257).
4847 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4849 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4850 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4851 which caused a build failure on GNU/Linux IA-64. This problem was
4852 introduced by my 2011-10-07 patch.
4854 2011-12-15 Juri Linkov <juri@jurta.org>
4856 * image.c (imagemagick_error): New function. (Bug#10112)
4857 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4858 Use `imagemagick_error' where ImageMagick functions return
4860 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4863 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4865 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4866 fill background (Bug#8992).
4868 2011-12-13 Martin Rudalics <rudalics@gmx.at>
4870 * window.c (Vwindow_combination_resize)
4871 (Vwindow_combination_limit): Use t instead of non-nil in
4873 (Vrecenter_redisplay): Add first sentence of doc-string on
4875 (Frecenter): Fix doc-string typo.
4877 2011-12-11 Kenichi Handa <handa@m17n.org>
4879 * coding.c (Funencodable_char_position): Pay attention to the
4880 buffer text relocation (Bug#9389).
4882 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4884 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4885 gtk_init (Bug#10100).
4887 2011-12-10 Eli Zaretskii <eliz@gnu.org>
4889 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4890 IT->string is nil. (Bug#10263)
4892 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4894 * nsterm.h (x_free_frame_resources): Declare.
4896 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4897 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4899 * nsterm.h (ns_get_defaults_value): Declare.
4901 * nsterm.m (ns_default): Call ns_get_defaults_value.
4903 2011-12-09 Eli Zaretskii <eliz@gnu.org>
4905 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4908 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4910 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4911 that where the value of an _OBJC_* symbol points to is in the .bss
4912 section (Bug#10240).
4914 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4916 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
4917 after the loop to call ccl_driver at least once (Bug#8619).
4919 2011-12-08 Kenichi Handa <handa@m17n.org>
4921 * ftfont.c (get_adstyle_property): Fix previous change
4924 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
4926 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4927 dirs from the default value of EMACSLOADPATH (bug#10208).
4929 2011-12-07 Glenn Morris <rgm@gnu.org>
4931 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4932 installation and source directories as well. (Bug#10208)
4934 2011-12-06 Chong Yidong <cyd@gnu.org>
4936 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4938 2011-12-06 Glenn Morris <rgm@gnu.org>
4940 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4941 as an error, not just -1. (Bug#10217)
4943 2011-12-05 Chong Yidong <cyd@gnu.org>
4945 * keyboard.c (process_special_events): New function.
4946 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4948 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4950 * coding.c (encode_designation_at_bol): Don't use uninitialized
4951 local variable (Bug#9318).
4953 2011-12-05 Kenichi Handa <handa@m17n.org>
4955 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4956 return Qnil (Bug#8046, Bug#10193).
4958 2011-12-05 Kenichi Handa <handa@m17n.org>
4960 * coding.c (encode_designation_at_bol): New args charbuf_end and
4961 dst. Return the number of produced bytes. Callers changed.
4962 (coding_set_source): Return how many bytes coding->source was
4964 (coding_set_destination): Return how many bytes
4965 coding->destination was relocated.
4966 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
4967 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
4969 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4971 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4972 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4975 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4977 The following changes are to fix Bug#9318.
4979 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
4980 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4981 (encode_coding_iso_2022, encode_coding_sjis)
4982 (encode_coding_big5, encode_coding_charset): Use the above macros.
4984 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
4986 * lisp.h (process_quit_flag): Fix external declaration.
4988 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4990 Don't macro-inline non-performance-critical code.
4991 * eval.c (process_quit_flag): New function.
4992 * lisp.h (QUIT): Use it.
4994 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4996 * nsfns.m (get_geometry_from_preferences): New function.
4997 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4999 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5001 * emacs.c (Qkill_emacs): Define.
5002 (syms_of_emacs): Initialize it.
5003 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5004 Qquit_flag to `kill-emacs' instead.
5005 (quit_throw_to_read_char): Add parameter `from_signal'.
5006 All callers changed. Call Fkill_emacs if requested and safe.
5007 * lisp.h (QUIT): Call Fkill_emacs if requested.
5009 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5011 * widget.c (update_wm_hints): Return if wmshell is null.
5012 (widget_update_wm_size_hints): New function.
5014 * widget.h (widget_update_wm_size_hints): Declare.
5016 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5017 widget_update_wm_size_hints (Bug#10104).
5019 2011-12-03 Eli Zaretskii <eliz@gnu.org>
5021 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5022 before a newline, prepare the bidi iterator for consuming the
5023 newline, and keep the current paragraph direction. (Bug#10183)
5024 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
5026 2011-12-02 Juri Linkov <juri@jurta.org>
5028 * search.c (Fword_search_regexp): New Lisp function created from
5029 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5030 (Fword_search_backward, Fword_search_forward)
5031 (Fword_search_backward_lax, Fword_search_forward_lax):
5032 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5033 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5035 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5037 * fileio.c (Finsert_file_contents): Move after-change-function call
5038 to before the "handled:" label, since all "goto handled" appear in
5039 cases where the *-change-functions have already been properly called
5042 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5044 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5045 waiting for input. (Bug#10169)
5047 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5049 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5050 verifies glyph row's hash code--we have just reallocated the
5051 glyphs, so their contents can be complete garbage. (Bug#10164)
5053 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
5055 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5057 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5059 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5060 attributes are tested _before_ calling verify_row_hash, to protect
5061 against GCC re-ordering of the tests. (Bug#10164)
5063 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5065 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5067 * xterm.c (handle_one_xevent): Only set async_visible and friends
5068 if net_wm_state_hidden_seen is non-zero (Bug#10002)
5069 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
5070 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5072 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5074 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5075 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5076 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5077 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5078 All uses changed to use GCPRO1 etc.
5079 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5080 Revert to old implementation (i.e., before 2011-03-11).
5082 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5084 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5085 of scroll runs so as to avoid assigning disabled bogus rows and
5086 unnecessary graphics copy operations.
5088 2011-11-27 Eli Zaretskii <eliz@gnu.org>
5090 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5091 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5092 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5093 (malloc, free, realloc, calloc): Redirect to e_* only when
5096 * lisp.h (GCTYPEBITS): Move before first use.
5097 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5098 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5099 this macro definition.
5101 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5104 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5106 * gtkutil.c (xg_create_frame_widgets):
5107 Call gtk_window_set_has_resize_grip (FALSE) if that function is
5108 present with Gtk+ 2.0.
5110 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5112 * fileio.c (Finsert_file_contents): Undo previous change; see
5113 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5115 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5117 Rename locals to avoid shadowing.
5118 * fileio.c (Finsert_file_contents):
5119 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5120 * process.c (wait_reading_process_output):
5121 Rename inner 'proc' to 'p' to avoid shadowing.
5122 Indent for consistency with usual Emacs style.
5124 2011-11-25 Eli Zaretskii <eliz@gnu.org>
5126 * xdisp.c (redisplay_window): If cursor row is not fully visible
5127 after recentering, and scroll-conservatively is set to a large
5128 number, scroll window by a few more lines to make the cursor fully
5129 visible and out of scroll-margin. (Bug#10105)
5130 (start_display): Don't move to the next line if the display should
5131 start at a newline that is part of a display vector or an overlay
5134 2011-11-24 Juri Linkov <juri@jurta.org>
5136 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5137 after the `MagickPingImage' call. (Bug#10112)
5139 2011-11-23 Chong Yidong <cyd@gnu.org>
5141 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5143 2011-11-23 Martin Rudalics <rudalics@gmx.at>
5145 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5146 making another buffer current. (Bug#10114)
5148 2011-11-23 Glenn Morris <rgm@gnu.org>
5150 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5152 2011-11-23 Chong Yidong <cyd@gnu.org>
5154 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5155 using it (Bug#5984).
5157 2011-11-22 Eli Zaretskii <eliz@gnu.org>
5159 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5160 and header-lines, as they don't have one computed for them.
5163 * .gdbinit (prow): Make displayed values more self-explaining.
5164 Add row's hash code.
5166 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5168 * process.c (wait_reading_process_output): Fix asynchrounous
5169 GnuTLS socket handling on some versions of the GnuTLS library.
5170 (wait_reading_process_output): Add comment and URL.
5172 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5174 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5176 2011-11-21 Chong Yidong <cyd@gnu.org>
5178 * window.c (Fnext_window, Fprevious_window): Doc fix.
5180 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5182 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5184 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5186 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5188 2011-11-20 Martin Rudalics <rudalics@gmx.at>
5190 * window.c (Fset_window_combination_limit): Rename argument
5192 (Vwindow_combination_limit): Remove "status" from doc-string.
5194 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5196 * m/ibms390.h: Remove.
5197 * m/ibms390x.h: Don't include "ibms390.h".
5199 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5201 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5202 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5204 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5206 * casetab.c (Fset_case_table):
5207 * charset.c (Fcharset_after): Fix typos.
5209 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
5211 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5212 Otherwise, valgrind does not work on some platforms.
5213 Problem reported by Andreas Schwab in
5214 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5215 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5216 is set, removing the need for VIRT_ADDRESS_VARIES.
5217 (PURE_P): Use a more-efficient implementation that needs just one
5218 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5219 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5220 to 4 (xorl, subq, cmpq, setbe).
5221 * alloc.c (pure): Always extern now, since that's the
5222 VIRT_ADDR_VARIES behavior.
5223 (PURE_POINTER_P): Use a single comparison, not two, for
5224 consistency with the new puresize.h.
5225 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5226 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5227 Remove VIRT_ADDR_VARIES no longer needed.
5229 2011-11-19 Eli Zaretskii <eliz@gnu.org>
5231 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5232 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5233 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5234 behave as if the cursor position were at the window margin.
5236 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5237 and the cursor position is out of bounds, behave as if the cursor
5238 position were at the window margin. (Bug#10075)
5240 2011-11-18 Chong Yidong <cyd@gnu.org>
5242 * window.c (Fwindow_combination_limit): Make first argument
5243 non-optional, since it is meaningless for live windows like the
5246 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5248 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5250 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5252 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5253 (graft_intervals_into_buffer): Simplify.
5255 2011-11-18 Eli Zaretskii <eliz@gnu.org>
5257 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5258 hash values of the two rows.
5259 (copy_row_except_pointers): Preserve the used[] arrays and the
5260 hash values of the two rows. (Bug#10035)
5261 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
5263 * xdisp.c (row_hash): New function, body extracted from
5264 compute_line_metrics.
5265 (compute_line_metrics): Call row_hash, instead of computing the
5268 * dispnew.c (verify_row_hash): Call row_hash for computing the
5269 hash code of a row, instead of duplicating code from xdisp.c.
5271 * dispextern.h (row_hash): Add prototype.
5273 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5275 * frame.c (delete_frame): Don't delete the terminal when the last
5276 X frame is closed if emacs is built with GTK toolkit.
5278 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
5280 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5282 2011-11-17 Martin Rudalics <rudalics@gmx.at>
5284 * window.c (Vwindow_splits): Rename to
5285 Vwindow_combination_resize. Suggested by Juri Linkov.
5286 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5289 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
5291 * nsfns.m (Fns_font_name):
5292 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
5294 2011-11-16 Martin Rudalics <rudalics@gmx.at>
5296 * window.h (window): Rename slot "nest" to "combination_limit".
5297 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5298 (Fset_window_nest): Rename to Fset_window_combination_limit.
5299 (Vwindow_nest): Rename to Vwindow_combination_limit.
5300 (recombine_windows, make_parent_window, make_window)
5301 (Fsplit_window_internal, saved_window)
5302 (Fset_window_configuration, save_window_save): Rename all
5303 occurrences of window_nest to window_combination_limit.
5305 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
5307 * image.c (imagemagick_load_image): Fix typo.
5309 2011-11-14 Eli Zaretskii <eliz@gnu.org>
5311 * xdisp.c (display_line): Move the call to
5312 highlight_trailing_whitespace before the call to
5313 compute_line_metrics, since the latter needs to see the final
5314 faces of all the glyphs to compute ROW's hash value.
5315 Fixes assertion violations in row_equal_p. (Bug#10035)
5317 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
5319 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5320 just return (bug#10044).
5322 2011-11-12 Eli Zaretskii <eliz@gnu.org>
5324 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5325 with user-defined heap size. Bump the default size of the temacs
5326 heap to 27MB, to avoid memory warning when running temacs.
5327 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5329 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5330 current_matrix and desired_matrix. (Bug#9990)
5331 (verify_row_hash) [XASSERTS]: New function.
5332 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5333 that the hash value of glyph rows is correct.
5335 2011-11-12 Martin Rudalics <rudalics@gmx.at>
5337 * window.h (window): Remove splits slot.
5338 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5339 (Fdelete_other_windows_internal, make_parent_window)
5340 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5341 (Fset_window_configuration, save_window_save): Don't deal with
5342 split status of windows.
5343 (saved_window): Remove splits slot.
5344 (Vwindow_splits): Rewrite doc-string.
5346 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5348 * xfns.c (unwind_create_frame):
5349 * nsfns.m (unwind_create_frame):
5350 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5351 Vframe_list (Bug#9999).
5353 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5355 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
5357 2011-11-11 Kenichi Handa <handa@m17n.org>
5359 * callproc.c (Fcall_process): Set the member dst_multibyte of
5362 2011-11-11 Johan Bockgård <bojohan@gnu.org>
5364 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5365 avoid a crash (bug#9496).
5367 2011-11-09 Chong Yidong <cyd@gnu.org>
5369 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5370 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5372 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5374 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5376 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5378 Avoid some portability problems by eschewing 'extern inline' functions.
5379 The trivial performance wins aren't worth the portability hassles; see
5380 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5382 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5383 (window_box_width, window_box_left, window_box_left_offset)
5384 (window_box_right, window_box_right_offset): Undo previous change,
5385 by removing the "extern"s.
5386 * intervals.c (adjust_intervals_for_insertion)
5387 (adjust_intervals_for_deletion): Undo previous change,
5388 making these static again.
5389 (offset_intervals, temp_set_point_both, temp_set_point)
5390 (copy_intervals_to_string): No longer inline.
5391 * xdisp.c (window_text_bottom_y, window_box_width)
5392 (window_box_height, window_box_left_offset)
5393 (window_box_right_offset, window_box_left, window_box_right)
5394 (window_box): No longer inline.
5396 2011-11-08 Chong Yidong <cyd@gnu.org>
5398 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
5399 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5400 Signal an error if not a live window.
5401 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5402 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5404 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
5406 * lisp.h (syms_of_abbrev): Remove declaration.
5407 Reported by CHENG Gao <chenggao@royau.me>.
5409 2011-11-07 Eli Zaretskii <eliz@gnu.org>
5411 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5412 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5413 of temacs in GUI mode.
5415 2011-11-07 Martin Rudalics <rudalics@gmx.at>
5417 * window.h: Declare delete_all_child_windows instead of
5418 delete_all_subwindows.
5419 * window.c (Fwindow_nest, Fset_window_nest)
5420 (Fset_window_new_total, Fset_window_new_normal)
5421 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5422 (delete_all_subwindows): Rename to delete_all_child_windows.
5423 (Fdelete_other_windows_internal, Fset_window_configuration):
5424 Call delete_all_child_windows instead of delete_all_subwindows.
5425 * frame.c (delete_frame): Call delete_all_child_windows instead
5426 of delete_all_subwindows.
5428 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5430 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5431 This is also needed for porting to any host where GC_MARK_STACK is
5432 not GC_MAKE_GCPROS_NOOPS.
5433 (which_symbols): Use it.
5435 2011-11-07 Kenichi Handa <handa@m17n.org>
5437 * coding.c (coding_set_destination): Check coding->src_pos only
5438 when coding->src_object is a buffer (bug#9910).
5440 * process.c (send_process): Set the member src_multibyte of coding
5441 to 0 (bug#9911) when sending a unibyte text.
5443 * callproc.c (Fcall_process): Set the member src_multibyte of
5444 process_coding to 0 (bug#9912).
5446 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5448 * xmenu.c (cleanup_widget_value_tree): New function.
5449 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5450 calling free_menubar_widget_value_tree directly (Bug#9830).
5452 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5454 Fix some portability problems with 'inline'.
5455 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5456 (window_box_width, window_box_left, window_box_left_offset)
5457 (window_box_right, window_box_right_offset): Declare extern.
5458 Otherwise, these inline functions do not conform to C99 and
5459 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5460 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5461 * intervals.c (adjust_intervals_for_insertion)
5462 (adjust_intervals_for_deletion): Now extern, because otherwise the
5463 extern inline functions 'offset_intervals' couldn't refer to it.
5464 (static_offset_intervals): Remove.
5465 (offset_intervals): Rewrite using the old contents of
5466 static_offset_intervals. The old version didn't conform to C99
5467 because an extern inline function contained a reference to an
5468 identifier with static linkage.
5470 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5472 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5475 2011-11-06 Eli Zaretskii <eliz@gnu.org>
5477 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5478 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5479 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5480 return Qleft_to_right.
5482 2011-11-06 Chong Yidong <cyd@gnu.org>
5484 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5485 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5486 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5487 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5488 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5489 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5490 (Fwindow_vscroll): Doc fix.
5491 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5492 argument, since it makes no sense to pass a live window and for
5493 consistency with window-child.
5495 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5497 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5500 2011-11-05 Jason Rumney <jasonr@gnu.org>
5502 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5503 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5505 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5506 bitwise arithmetic preventing use of unicode-sip and non-truetype
5509 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5511 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5514 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5515 initialization code to keep similarity to xfns.c after changes
5518 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5520 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5521 (unwind_create_frame): New function (Bug#9943).
5522 (Fx_create_frame): Restructure code to be more similar to the one in
5523 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5524 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5525 Move terminal->reference_count++ just before making the frame official
5528 * nsterm.m (x_free_frame_resources): New function.
5529 (x_destroy_window): Move code to x_free_frame_resources.
5531 * xfns.c (unwind_create_frame): Fix comment.
5532 (Fx_create_frame, x_create_tip_frame):
5533 Move terminal->reference_count++ just before making the frame
5534 official. Move initialization of image_cache_refcount and
5535 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5537 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5539 Support MSVC build with newer versions of Visual Studio.
5540 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5541 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5544 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5545 which are not supported by MSVC.
5546 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5547 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5549 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5551 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5553 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5555 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
5557 Support MSVC build with newer versions of Visual Studio.
5558 * w32.c: Don't include w32api.h for MSVC.
5559 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5561 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5562 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5563 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5564 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5566 (alloca) [_MSC_VER]: Define to _alloca.
5568 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5570 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5572 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5574 * xdisp.c (note_mouse_highlight): If either of
5575 previous/next-single-property-change returns nil, treat that as
5576 the beginning or the end of the buffer. (Bug#9955)
5578 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5580 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
5581 label is not null (Bug#9951).
5582 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5585 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5587 * window.c (Fwindow_body_size): Mention in the doc string that the
5588 return value is in frame's canonical units. (Bug#9949)
5590 2011-11-03 Eli Zaretskii <eliz@gnu.org>
5592 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5594 * w32fns.c (unwind_create_frame): If needed, free the glyph
5595 matrices of the partially constructed frame. (Bug#9943)
5596 * xfns.c (unwind_create_frame): Likewise.
5598 2011-11-01 Eli Zaretskii <eliz@gnu.org>
5600 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5601 Don't stop backward scan on the continuation glyph, even though
5602 its CHARPOS is positive.
5603 (mouse_face_from_buffer_pos, note_mouse_highlight):
5604 Rename cover_string to disp_string.
5606 2011-11-01 Martin Rudalics <rudalics@gmx.at>
5608 * window.c (temp_output_buffer_show): Don't use
5609 Vtemp_buffer_show_specifiers.
5610 (Vtemp_buffer_show_specifiers): Remove unused variable.
5612 2011-10-30 Eli Zaretskii <eliz@gnu.org>
5614 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5615 past the beginning of the current glyph matrix.
5617 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
5619 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5620 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5621 HAVE_GTK3 (Bug#9869).
5623 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5624 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5626 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5628 * xterm.c: Declare x_handle_net_wm_state to return int.
5629 (handle_one_xevent): Check if we are iconified but don't have
5630 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5631 (get_current_wm_state): Return non-zero if not hidden,
5632 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5633 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5634 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5635 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5637 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5639 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5640 so that this new function doesn't get optimized away by a
5641 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5643 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5645 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5647 2011-10-29 Eli Zaretskii <eliz@gnu.org>
5649 Fix the `xbytecode' command.
5650 * .gdbinit (xprintbytestr): New command.
5651 (xwhichsymbols): Rename from `which'; all callers changed.
5652 (xbytecode): Print the byte-code string as well.
5654 2011-10-29 Kim Storm <storm@cua.dk>
5656 * alloc.c (which_symbols): New function.
5658 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5660 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5663 2011-10-29 Glenn Morris <rgm@gnu.org>
5665 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5666 Not clear what it was for, and it causes various bugs. (Bug#9839)
5668 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5670 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5671 possible random value that matches one of those tested as
5672 condition to clear the mouse face.
5674 2011-10-28 Chong Yidong <cyd@gnu.org>
5676 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5678 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5680 * window.c (make_window): Initialize phys_cursor_on_p.
5682 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5684 * lisp.h (struct Lisp_Symbol): Update comments.
5686 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
5688 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5690 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5692 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5693 <oslsachem@gmail.com> for helping to debug this.
5695 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5696 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5697 (g_b_init_get_glyph_outline_w): New static variables.
5698 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5699 (GetGlyphOutlineW_Proc): New typedefs.
5700 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
5701 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5703 (w32font_open_internal, compute_metrics):
5704 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
5705 instead of calling the "wide" APIs directly.
5707 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5709 * w32.h (syms_of_w32font): Add prototype.
5711 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5713 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5714 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5715 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5716 (Fmove_to_window_line): Doc fix.
5718 2011-10-27 Chong Yidong <cyd@gnu.org>
5720 * process.c (make_process): Set gnutls_state to NULL.
5722 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5723 non-NULL, regardless of GNUTLS_INITSTAGE.
5724 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5725 an error. Set process slots as soon as we allocate them.
5727 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5729 2011-10-27 Chong Yidong <cyd@gnu.org>
5731 * gnutls.c (emacs_gnutls_deinit): New function.
5732 Deallocate credentials structures as well as calling gnutls_deinit.
5733 (Fgnutls_deinit, Fgnutls_boot): Use it.
5735 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5736 (deactivate_process): Call emacs_gnutls_deinit.
5738 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5740 * image.c (x_create_x_image_and_pixmap):
5741 * w32.c (sys_rename, w32_delayed_load):
5742 * w32font.c (fill_in_logfont):
5743 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5745 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
5747 * w32fns.c (w32_default_color_map): New function,
5748 extracted from Fw32_default_color_map.
5749 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5751 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5753 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5755 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5757 * keyboard.c (test_undefined): New function (bug#9751).
5758 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5760 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5762 * sysdep.c (init_sys_modes): Fix the check for the controlling
5763 terminal (Bug#6649).
5765 2011-10-20 Eli Zaretskii <eliz@gnu.org>
5767 * dispextern.h (struct bidi_it): New member next_en_type.
5769 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5770 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5771 current character, check also for next_en_type being WEAK_EN.
5772 (bidi_resolve_weak): Don't enter the expensive loop if the current
5773 position is before next_en_pos. Record the bidi type of the first
5774 non-ET, non-BN character we find, in addition to its position.
5775 (bidi_level_of_next_char): Invalidate next_en_type when
5776 next_en_pos is over-stepped.
5778 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5780 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5781 * editfns.c: Rewrite current-time-zone so that it invokes
5782 the equivalent of (format-time-string "%Z") to get the time zone name.
5783 This fixes a bug when the time zone name contains characters that
5784 need converting from the system time locale to Emacs internal format.
5785 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5786 that patch fixed format-time-string to do the conversion, but
5787 I forgot to fix current-time-zone.
5788 (format_time_string): New function, containing most of
5789 what Fformat_time_string used to contain.
5790 (Fformat_time_string): Rewrite in terms of format_time_string.
5791 This doesn't change this function's behavior.
5792 (current-time-zone): Rewrite to use format_time_string.
5793 This fixes the bug reported by Michael Schierl in
5794 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5795 Jason Rumney's 2007-06-07 change worked around this bug, but
5797 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5799 2011-10-19 Eli Zaretskii <eliz@gnu.org>
5801 * xdisp.c (start_display): If the character at POS is displayed
5802 via a display vector, reset IT->current.dpvec_index to zero.
5803 (try_window_reusing_current_matrix): If a line ends in a display
5804 vector or the next line starts in a display vector, continue
5805 redrawing the window even though the character position of
5806 start_row was reached.
5809 2011-10-18 Chong Yidong <cyd@gnu.org>
5811 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5812 with nobreak-char-display too.
5814 2011-10-18 Eli Zaretskii <eliz@gnu.org>
5816 Fix part 3 of bug#9771.
5817 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5818 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5819 non-neutral characters if the current character is a paragraph
5820 separator (a.k.a. Newline). This avoids running the same
5821 expensive loop twice, once when we consume the preceding newline
5822 and the other time when the line actually needs to be displayed.
5823 Avoid the loop when we see neutrals on the base embedding level
5824 following a character whose directionality is the same as the
5825 paragraph's. This avoids running the expensive loop when a line
5826 ends in a long sequence of neutrals, like control characters.
5827 Add assertion against STRONG_AL type. Slightly rearrange code
5828 that determines the type of a neutral given the first non-neutral
5830 (bidi_level_of_next_char): Set next_en_pos to zero when
5831 invalidating its info.
5833 2011-10-17 Eli Zaretskii <eliz@gnu.org>
5835 * xdisp.c (push_display_prop): Determine whether to record string
5836 or buffer position by IT->string, not by IT->method. Allow
5837 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
5838 (move_it_vertically_backward): Don't look for character position
5839 immediately after the newline when in a continuation line.
5842 2011-10-15 Martin Rudalics <rudalics@gmx.at>
5844 * window.c (coordinates_in_window): Rewrite and delabelize
5845 vertical border check. (Bug#5357) (Bug#9618)
5847 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5849 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5850 errors in XSetWindowBorder (bug#9310).
5852 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5854 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5855 avoid crash when xmalloc overrun checking is enabled.
5857 2011-10-13 Eli Zaretskii <eliz@gnu.org>
5859 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5860 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5861 cursor motion with <left> and <right> arrow keys.
5863 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5864 some callers set that themselves.
5866 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5868 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5869 display string and the previous row comes from the same string and
5870 is empty. (Bug#9739) (Bug#9738)
5872 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5874 * doc.c (get_doc_string): Encode file name (bug#9735).
5876 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5878 * bidi.c (bidi_level_of_next_char):
5879 * xdisp.c (get_visually_first_element): Remove old incorrect
5880 comments regarding the Unicode Line Separator character.
5882 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5884 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5886 * alloc.c (Fgc_status): Do not access beyond zombies array
5887 boundary if nzombies > MAX_ZOMBIES.
5888 * alloc.c (dump_zombies): Add missing format specifier.
5890 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5892 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5893 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5895 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5896 Some packages use them to denote characters with modifiers.
5898 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5900 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5901 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5902 matching a pp-number. Rename parameter var to var1.
5904 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5906 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5908 2011-10-08 Glenn Morris <rgm@gnu.org>
5910 * callint.c (Fcall_interactively): Give a more explicit error for the
5911 'c' case with a non-character input. (Bug#8479)
5913 2011-10-08 Eli Zaretskii <eliz@gnu.org>
5915 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5917 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5918 lines that are hscrolled on the left.
5920 * dispnew.c (buffer_posn_from_coords): Account for a possible
5921 presence of header-line. (Bug#4426)
5923 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5925 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5926 Don't advertise functionality which we discourage or doesn't work.
5928 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5930 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5931 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5932 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5933 this makes Emacs dump core during garbage collection on rare
5934 occasions. sizeof is obviously inferior to offsetof here, so
5935 stick with offsetof.
5936 (GC_POINTER_ALIGNMENT): New macro.
5937 (mark_memory): Omit 3rd (offset) arg; caller changed.
5938 Don't assume EMACS_INT alignment is the same as pointer alignment.
5940 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5942 * keyboard.c (read_key_sequence_remapped): New var.
5943 (read_key_sequence): Compute remapping in the right buffer.
5944 (command_loop_1): Use read_key_sequence's remapping directly.
5946 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5948 * dired.c (file_name_completion): Don't expand file name.
5949 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5950 before checking file name handler.
5952 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5953 they've been requested explicitly (bug#9591).
5955 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
5957 * keymap.c (Fsingle_key_description): Use make_specified_string
5958 instead of build_string to build string from push_key_description.
5961 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5963 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5964 This fixes a Y2038 bug on 64-bit hosts.
5965 * buffer.c (reset_buffer):
5966 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5967 (Fclear_buffer_auto_save_failure):
5968 Use 0, not -1, to represent an unset failure time, since time_t
5969 might not be signed.
5971 Remove dependency on glibc malloc internals.
5972 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5973 Move back here from lisp.h, but with their new implementations.
5974 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5975 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5976 * charset.c (charset_table_init): New static var.
5977 (syms_of_charset): Use it instead of xmalloc. This removes a
5978 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5979 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5980 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5981 Move back to alloc.c.
5982 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5983 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5985 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5987 * nsterm.m (windowDidResize): Call x_set_window_size only when
5988 ns_in_resize is true. Otherwise set pixelwidth/height and
5989 call change_frame_size (Bug#9628).
5991 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5993 Port --enable-checking=all to Fedora 14 x86-64.
5994 * charset.c (syms_of_charset): Also account for glibc malloc's
5995 internal overhead when calculating the initial malloc maximum.
5997 Port --enable-checking=all to Fedora 14 x86.
5998 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6000 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6001 (overrun_check_realloc, overrun_check_free):
6002 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6003 That way, xmalloc returns a properly-aligned pointer even if
6004 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6005 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6006 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6007 into account when calculating the initial malloc maximum.
6008 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6009 Move here from alloc.c, so that charset.c can use it too.
6010 Properly align; the old code wasn't right for common 32-bit hosts
6011 when configured with --enable-checking=all.
6012 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6013 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6015 2011-09-29 Eli Zaretskii <eliz@gnu.org>
6017 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
6020 2011-09-28 Eli Zaretskii <eliz@gnu.org>
6022 * xdisp.c (compute_display_string_end): If there's no display
6023 string at CHARPOS, return -1.
6025 * bidi.c (bidi_fetch_char): When compute_display_string_end
6026 returns a negative value, treat the character as a normal
6027 character not covered by a display string. (Bug#9624)
6029 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
6031 * lread.c (Fread_from_string): Fix typo in docstring.
6033 2011-09-27 Eli Zaretskii <eliz@gnu.org>
6035 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6036 newline, reseat the iterator instead of bidi-iterating there one
6037 character at a time. (Bug#9610)
6038 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6039 TO_CHARPOS if the bidi iterator is at base embedding level.
6041 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6043 * lread.c (readevalloop): Use correct code for NBSP.
6044 (read1): Likewise. (Bug#9608)
6046 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
6048 * dbusbind.c (Fdbus_register_signal): When service is not
6049 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6051 2011-09-25 Glenn Morris <rgm@gnu.org>
6053 * buffer.c (truncate-lines): Doc fix.
6055 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
6057 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6058 (Fset_window_next_buffers): Doc fix.
6060 2011-09-24 Glenn Morris <rgm@gnu.org>
6062 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6064 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6066 Fix minor problems found by static checking.
6067 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
6068 * indent.c (Fvertical_motion): Fix == vs = typo.
6070 2011-09-24 Eli Zaretskii <eliz@gnu.org>
6072 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6073 Default value is now t. Doc fix.
6075 * indent.c (Fvertical_motion): Compute and apply the overshoot
6076 logic when moving up, not only when moving down. Fix the
6077 confusing name and values of the it_overshoot_expected variable;
6078 logic changes accordingly. (Bug#9254) (Bug#9549)
6080 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6081 CHARPOS is covered by a display string which includes newlines.
6082 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6083 is covered by a display string with embedded newlines.
6085 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
6087 * dbusbind.c (Fdbus_register_signal): Add match rule to
6088 Vdbus_registered_objects_table. (Bug#9581)
6089 (Fdbus_register_method, Vdbus_registered_objects_table):
6092 2011-09-24 Jim Meyering <meyering@redhat.com>
6094 do not ignore write error for any output size
6095 The previous change was incomplete.
6096 While it makes emacs --batch detect the vast majority of stdout
6097 write failures, errors were still ignored whenever the output size is
6098 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6099 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6100 && echo FAIL: ignored write error
6101 FAIL: ignored write error
6102 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6103 && echo FAIL: ignored write error
6104 FAIL: ignored write error
6105 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6107 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6109 * emacs.c (Fkill_emacs): In noninteractive mode exit
6110 non-successfully if a write error occurred on stdout. (Bug#9574)
6112 2011-09-21 Eli Zaretskii <eliz@gnu.org>
6114 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6117 * dispextern.h (struct it): Update the comment documenting what
6120 2011-09-20 Eli Zaretskii <eliz@gnu.org>
6122 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6123 a display string, extend search for cursor position to end of row.
6124 (find_row_edges): If the row ends in a newline from a display
6125 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6126 Handle the case of a display string with multiple newlines.
6127 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6128 non-empty line. Fixes confusing cursor motion with arrow keys at
6129 the beginning of a line that starts with whitespace.
6131 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6133 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6136 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
6138 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6141 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6143 * xdisp.c (display_line): Record maximum and minimum buffer
6144 positions even if no glyphs were produced (e.g., by a zero-width
6145 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6146 buffer positions that will be removed from the glyph row because
6148 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6149 column is beyond frame width: don't subtract 1 "pixel" when
6150 computing width of the stretch.
6151 (reseat_at_next_visible_line_start): Undo the change made on
6152 2011-09-17 that saved paragraph information and restored it after
6153 the call to `reseat'. (Bug#9545)
6155 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6157 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6158 and turn window cursor on if cleared (Bug#9415).
6160 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
6162 * search.c (boyer_moore): Take unibyte characters from pattern
6163 literally. (Bug#9458)
6165 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6167 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6169 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6171 Fix minor problem found by static checking.
6172 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6173 initialized, to pacify gcc -Wuninitialized.
6175 * fileio.c: Report proper errno when syscall falls.
6176 (Finsert_file_contents): Save and restore errno,
6177 so that report_file_error outputs the correct diagnostic.
6178 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6180 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6182 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6184 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6186 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6187 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6189 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6191 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6192 about the current paragraph and restore it after the call to reseat.
6194 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6195 (bidi_find_paragraph_start): Search back for paragraph beginning
6196 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6197 (bidi_move_to_visually_next): Only trigger paragraph-related
6198 computations when the last character is a newline or at EOB, not
6199 just any NEUTRAL_B. (Bug#9470)
6201 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6202 truncated lines if point is covered by a display string. (Bug#9524)
6204 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6206 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6207 (cons_to_x_long): New function.
6208 (lisp_data_to_selection_data): Use it. Correct the test for
6209 short-versus-long data; it was negated. Break out of vector
6210 loop, for efficiency, when a long datum is discovered.
6212 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6214 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6216 2011-09-16 Eli Zaretskii <eliz@gnu.org>
6218 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6219 GCC PR/17406) by declaring this function with external scope.
6221 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6223 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6224 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6226 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6228 * editfns.c (Fformat): Correctly handle text properties on "%%".
6230 2011-09-15 Eli Zaretskii <eliz@gnu.org>
6232 * xterm.c (x_draw_composite_glyph_string_foreground):
6233 * w32term.c (x_draw_composite_glyph_string_foreground):
6234 * term.c (encode_terminal_code):
6235 * composite.c (composition_update_it, get_composition_id):
6236 * xdisp.c (get_next_display_element)
6237 (fill_composite_glyph_string): Add comments about special meaning
6238 of TAB characters in a composition.
6240 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6242 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
6243 This occurs when processing a multibyte format.
6244 Problem reported by Wolfgang Jenker.
6246 2011-09-15 Johan Bockgård <bojohan@gnu.org>
6248 * xdisp.c (try_cursor_movement): Only check for exact match if
6249 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6251 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6253 Remove unused external symbols.
6254 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6255 * xdisp.c (calc_pixel_width_or_height): Now static.
6256 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6257 * indent.c (check_display_width):
6258 * w32term.c: Fix comment to match code.
6259 * xterm.c, xterm.h (x_catching_errors): Remove.
6261 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6263 * xselect.c: Use signed conversions more consistently (Bug#9498).
6264 (selection_data_to_lisp_data): Assume incoming selection data are
6265 signed integers, not unsigned. This is to be consistent with
6266 outgoing selection data, which was modified to use signed integers
6267 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6268 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6269 expects long, not unsigned long.
6271 2011-09-14 Eli Zaretskii <eliz@gnu.org>
6273 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6274 computation of loop end. Reported by Johan Bockgård
6277 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
6279 * frame.c (Fother_visible_frames_p): Function deleted.
6281 2011-09-12 Eli Zaretskii <eliz@gnu.org>
6283 * indent.c (compute_motion): Process display vector front to back
6284 rather than the other way around. (Bug#2496)
6286 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6288 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6290 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
6292 * minibuf.c (Fread_from_minibuffer): Doc fix.
6294 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6296 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6297 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6299 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6301 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6302 value for non-existent files.
6304 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6306 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6307 set its "size" to -1. This will set the modtime_size field of
6308 the corresponding buffer to -1, which is what
6309 verify-visited-file-modtime expects for files that do not exist.
6312 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6314 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6316 * lisp.h: ... from here. push_key_description is no longer
6317 defined in keyboard.c, so its declaration should not be in
6318 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6319 logically belongs with push_key_description.
6321 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6323 * buffer.h: Include <sys/types.h> instead of <time.h>.
6324 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6325 Problem reported by Herbert J. Skuhra.
6327 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6329 * xml.c (parse_region): Make the parsing work for
6330 non-comment-starting XML files again (bug#9144).
6332 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6334 * image.c (gif_load): Fix calculation of bottom and right corner.
6337 2011-09-10 Eli Zaretskii <eliz@gnu.org>
6339 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6340 redisplay in small windows.
6342 2011-09-09 Eli Zaretskii <eliz@gnu.org>
6344 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6346 2011-09-08 Martin Rudalics <rudalics@gmx.at>
6348 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6349 Operate on live windows only.
6351 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
6353 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6355 2011-09-07 Eli Zaretskii <eliz@gnu.org>
6357 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6358 only under bidi iteration.
6360 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6362 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6364 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6366 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6367 Without this fix, the command to link temacs failed due to an
6368 undefined symbol __builtin_isnan. This is because
6369 /usr/include/iso/math_c99.h #defines isnan(x) to
6370 __builtin_isnan(x), but the bundled gcc, which identifies itself
6371 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6373 * floatfns.c (isnan): #undef, and then #define to a clone of
6375 (Fisnan): Always define, since it's always available now.
6376 (syms_of_floatfns): Always define isnan at the Lisp level.
6378 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6380 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6382 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6384 * fileio.c: Fix bugs with large file offsets (Bug#9428).
6385 The previous code assumed that file offsets (off_t values) fit in
6386 EMACS_INT variables, which is not true on typical 32-bit hosts.
6387 The code messed up by falsely reporting buffer overflow in cases
6388 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6389 when "big" contains more than 2**29 bytes, even though this
6390 inserts just one byte and does not overflow the buffer.
6391 (Finsert_file_contents): Store file offsets as off_t
6392 values, not as EMACS_INT values. Check for overflow when
6393 converting between EMACS_INT and off_t. When checking for
6394 buffer overflow or for overlap, take the offsets into account.
6395 Don't use EMACS_INT for small values where int suffices.
6396 When checking for overlap, fix a typo: ZV was used where
6397 ZV_BYTE was intended.
6398 (Fwrite_region): Don't assume off_t fits into 'long'.
6399 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6401 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
6403 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6405 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6407 sprintf-related integer and memory overflow issues (Bug#9412).
6409 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6410 (esprintf, exprintf, evxprintf): New functions.
6411 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6412 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
6413 (modify_event_symbol): Do not assume that the length of
6414 name_alist_or_stem is safe to alloca and fits in int.
6415 (Fexecute_extended_command): Likewise for function name and binding.
6416 (Frecursion_depth): Wrap around reliably on integer overflow.
6417 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6418 since some callers pass EMACS_INT values.
6419 (Fsingle_key_description): Don't crash if symbol name contains more
6420 than MAX_ALLOCA bytes.
6421 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6422 (get_minibuffer): Arg is now EMACS_INT, not int.
6423 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
6424 (esprintf, exprintf, evxprintf): New decls.
6425 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6427 * dbusbind.c (signature_cat): New function.
6428 (xd_signature, Fdbus_register_signal):
6429 Do not overrun buffer; instead, report string overflow.
6431 * dispnew.c (add_window_display_history): Don't overrun buffer.
6432 Truncate instead; this is OK since it's just a log.
6434 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6435 even if the time zone offset is outlandishly large.
6436 Don't mishandle offset == INT_MIN.
6438 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6439 when creating daemon; the previous buffer-overflow check was incorrect.
6441 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6442 which has the guts of the old verror function.
6444 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6445 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6447 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6448 (font_unparse_xlfd): Don't blindly alloca long strings.
6449 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
6450 fits in int, when using sprintf. Use single snprintf to count
6451 length of string rather than counting it via multiple sprintfs;
6452 that's simpler and more reliable.
6453 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6454 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6455 sprintf, in case result does not fit in int.
6457 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6458 (fontset_from_font): Print it.
6460 * frame.c (tty_frame_count): Now printmax_t, not int.
6461 (make_terminal_frame, set_term_frame_name): Print it.
6462 (x_report_frame_params): In X, window IDs are unsigned long,
6463 not signed long, so print them as unsigned.
6464 (validate_x_resource_name): Check for implausibly long names,
6465 and don't assume name length fits in 'int'.
6466 (x_get_resource_string): Don't blindly alloca invocation name;
6467 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6470 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6471 (xg_check_special_colors, xg_set_geometry):
6472 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6474 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6475 Use esprintf, not sprintf, in case result does not fit in int.
6477 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6478 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6479 it as a large positive number.
6480 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6481 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6483 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6484 in case result does not fit in int.
6486 * print.c (float_to_string): Detect width overflow more reliably.
6487 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6488 buffer overrun. Don't assume list length fits in 'int'. Treat
6489 print length of 0 as 0, not as infinity; to be consistent with other
6490 uses of print length in this function. Don't overflow print length
6491 index. Don't assume hash table size fits in 'long', or that
6492 vectorlike size fits in 'unsigned long'.
6494 * process.c (make_process): Use printmax_t, not int, to format
6495 process-name gensyms.
6497 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6499 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6500 to avoid potential buffer overrun.
6502 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6503 if X resource line is longer than 512 bytes.
6505 * xfns.c (x_window): Make sprintf buffer a bit bigger
6506 to avoid potential buffer overrun.
6508 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6510 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6512 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6514 Integer overflow fixes for scrolling, etc.
6515 Without these, Emacs silently mishandles large integers sometimes.
6516 For example, "C-u 4294967297 M-x recenter" was treated as if
6517 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6519 * xdisp.c (try_window_id): Check Emacs fixnum range before
6520 converting to 'int'.
6522 * window.c (window_scroll_line_based, Frecenter):
6523 Check that an Emacs fixnum is in range before assigning it to 'int'.
6524 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6525 values converted from Emacs fixnums.
6526 (Frecenter): Don't wrap around a line count if it is out of 'int'
6527 range; instead, treat it as an extreme value.
6528 (Fset_window_configuration, compare_window_configurations):
6529 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6531 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6532 that can exceed INT_MAX. Check that EMACS_INT value is in range
6533 before assigning it to the (possibly-narrower) index.
6534 (match_limit): Don't assume that a fixnum can fit in 'int'.
6536 * print.c (print_object): Use ptrdiff_t, not int, for index that can
6539 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
6540 (Fvertical_motion): Don't wrap around LINES values that don't fit
6541 in 'int'. Instead, treat them as extreme values. This is good
6542 enough for windows, which can't have more than INT_MAX lines anyway.
6544 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6546 * Require libxml/parser.h to avoid compilation warning.
6548 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6550 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6551 since this reportedly can destroy thread storage.
6553 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
6555 * syntax.c (find_defun_start): Update all cache variables if
6556 exiting early (Bug#9401).
6558 2011-08-30 Eli Zaretskii <eliz@gnu.org>
6560 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6562 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6563 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6564 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6566 * term.c (tty_append_glyph): New function.
6567 (produce_stretch_glyph): Static function and its prototype deleted.
6569 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6572 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6574 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6575 when checking :margin (Bug#9390).
6576 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
6577 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
6578 so that the name doesn't mislead. All uses changed.
6580 2011-08-28 Johan Bockgård <bojohan@gnu.org>
6582 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6585 2011-08-27 Eli Zaretskii <eliz@gnu.org>
6587 * xdisp.c (move_it_to): Don't bail out early when reaching
6588 position beyond to_charpos, if we are scanning backwards.
6589 (move_it_vertically_backward): When DY == 0, make sure we get to
6590 the first character in the line after the newline.
6592 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6594 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6595 (ccl_driver): Do not generate an out-of-range pointer.
6596 (Fccl_execute_on_string): Remove unnecessary check for
6597 integer overflow, noted by Stefan Monnier in
6598 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6599 Remove a FIXME that didn't need fixing.
6600 Simplify the newly-introduced buffer reallocation code.
6602 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
6604 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6606 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
6608 Integer and memory overflow issues (Bug#9196).
6610 * doc.c (get_doc_string): Rework so that
6611 get_doc_string_buffer_size is the actual buffer size, rather than
6612 being 1 less than the actual buffer size; this makes xpalloc more
6615 * image.c (x_allocate_bitmap_record, cache_image):
6616 * xselect.c (Fx_register_dnd_atom):
6617 Simplify previous changes by using xpalloc.
6619 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6620 since either will do and ptrdiff_t is convenient with xpalloc.
6622 * charset.c (charset_table_size)
6623 (struct charset_sort_data.priority): Now ptrdiff_t.
6624 (charset_compare): Don't overflow if priorities differ greatly.
6625 (Fsort_charsets): Don't assume list length fits in int.
6626 Check for size-calculation overflow when allocating sort data.
6627 (syms_of_charset): Allocate an initial charset table that is
6628 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6630 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6632 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6633 The actual value is always <= INT_MAX, and leaving it unsigned made
6634 overflow checking harder.
6636 * dispextern.h (struct glyph_matrix.rows_allocated)
6637 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6638 with xpalloc. The values are still always <= INT_MAX.
6640 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6642 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6643 (SAFE_NALLOCA): New macro.
6645 * region-cache.c (struct boundary.pos, find_cache_boundary)
6646 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6647 (set_cache_region, invalidate_region_cache)
6648 (revalidate_region_cache, know_region_cache, region_cache_forward)
6649 (region_cache_backward, pp_cache):
6650 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6651 so that ptrdiff_t * can be passed to xpalloc.
6652 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6653 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6654 (pp_cache): Don't assume cache_len fits in int.
6655 * region-cache.h: Adjust extern decls to match.
6657 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6658 EMACS_INT, since either will do, for xpalloc.
6660 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6661 (xnmalloc, xnrealloc, xpalloc): New functions.
6663 * bidi.c (bidi_shelve_header_size): New constant.
6664 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6665 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6667 * bidi.c (bidi_cache_shrink):
6668 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6670 Don't update size of array until after memory allocation succeeds,
6671 because xmalloc/xrealloc may not return.
6672 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6673 now that we have proper integer overflow checking.
6674 (record_overlay_string, overlay_strings): Catch overflows when
6675 calculating size of overlay_str_buf.
6677 * callproc.c (Fcall_process): Check for size overflow when
6678 calculating size of args2.
6679 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6680 Normally we prefer signed values, but sticking with ptrdiff_t would
6681 require adding more-complicated checks.
6683 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6684 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6685 Redo buffer-overflow calculations to avoid integer overflow.
6686 Add a FIXME comment where memory seems to be over-allocated.
6688 * character.c (Fstring): Check for size-calculation overflow.
6690 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6691 unnecessary integer overflow. Check for size overflow.
6692 (encode_coding_object): Don't update size until xmalloc succeeds.
6694 * composite.c (get_composition_id): Check for overflow in glyph
6695 length calculations.
6697 Integer and memory overflow fixes for display code.
6698 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6699 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6700 (scrolling_window): Check for overflow in size calculations.
6701 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6702 Don't assume glyph table len fits in int.
6703 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6704 (row_table_size): Now ptrdiff_t, not int.
6705 (scrolling_window): Avoid overflow in size calculations.
6706 Don't update size until allocation succeeds.
6707 * fns.c (concat): Check for overflow in size calculations.
6708 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6709 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6710 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6712 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6713 (get_doc_string): Check for size calculation overflow.
6714 Don't update size until allocation succeeds.
6715 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6716 EMACS_INT, where ptrdiff_t will do.
6717 (Fsubstitute_command_keys): Check for string overflow.
6719 * editfns.c (set_time_zone_rule): Don't assume environment length
6721 (message_length): Now ptrdiff_t, not int.
6722 (Fmessage_box): Don't update size until allocation succeeds.
6723 Don't assume message length fits in int.
6724 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6726 * emacs.c (main): Do not reallocate argv, since there is a null at
6727 the end that can be overwritten, and this way there's no need to
6728 worry about size-calculation overflow.
6729 (sort_args): Check for size-calculation overflow.
6731 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6733 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6735 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6736 (x_set_scroll_bar_width, x_figure_window_size):
6737 Check for integer overflow.
6738 (x_set_alpha): Do not assume XINT fits in int.
6740 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6741 This is for the members text_lines, text_cols, total_lines, total_cols,
6742 where the system imposes an 'int' limit.
6744 * fringe.c (Fdefine_fringe_bitmap):
6745 Don't update size until alloc works.
6747 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6748 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6750 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6751 Check for size-calculation overflow.
6752 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6753 do, as we prefer signed integers.
6754 (id_to_widget.max_size, id_to_widget.used)
6755 (xg_store_widget_in_map, xg_remove_widget_from_map)
6756 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6757 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6758 Use and return ptrdiff_t, not int.
6759 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6760 * gtkutil.h: Change prototypes to match the above.
6762 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6763 are duplicate now that they've been promoted to lisp.h.
6764 (x_allocate_bitmap_record, x_alloc_image_color)
6765 (make_image_cache, cache_image, xpm_load):
6766 Don't update size until alloc is done.
6767 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6769 Check for size calculation overflow.
6770 (ct_colors_allocated_max): New constant.
6771 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6774 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6775 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6776 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6777 Use ptrdiff_t, not int, to count maps.
6778 (read_char_minibuf_menu_prompt): Check for overflow in size
6779 calculations. Don't update size until allocation succeeds.
6780 Redo calculations to avoid overflow.
6781 * keyboard.h: Change prototypes to match the above.
6783 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6785 (current_minor_maps): Check for size calculation overflow.
6786 * keymap.h: Change prototypes to match the above.
6788 * lread.c (read1, init_obarray): Don't update size until alloc done.
6790 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6791 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6793 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6794 Now ptrdiff_t, not int.
6795 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6796 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6798 * process.c (Fnetwork_interface_list): Check for overflow
6799 in size calculation.
6801 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6803 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6804 overflow. Don't bother calling xmalloc when xrealloc will do.
6806 * search.c (Freplace_match): Check for size calculation overflow.
6807 (Fset_match_data): Don't assume list lengths fit in 'int'.
6809 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6810 for command line length. Do not attempt to address one before the
6811 beginning of an array, as that's not portable.
6813 * term.c (max_frame_lines): Remove; unused.
6814 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6816 (encode_terminal_code, calculate_costs): Check for size
6817 calculation overflow.
6818 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6819 table lengths and related sizes. Don't update size until alloc
6820 done. Redo calculations to avoid overflow.
6821 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6823 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6824 subtracting pointers.
6825 (gobble_line): Check for overflow more carefully. Don't update size
6828 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6829 Don't update size until alloc done.
6830 Redo size calculations to avoid overflow.
6831 Check for size calculation overflow.
6832 (main) [DEBUG]: Fix typo in invoking tparam1.
6834 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6835 Use ptrdiff_t, not int, for sizes.
6836 (store_mode_line_noprop_char): Don't update size until alloc done.
6838 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6839 Use ptrdiff_t, not int, for sizes.
6840 (Finternal_make_lisp_face, cache_face):
6841 Check for size calculation overflow.
6842 (cache_face): Treat size calculation overflows as if they were
6843 memory exhaustion (the usual treatment), rather than aborting.
6845 * xfns.c (x_encode_text, x_set_name_internal)
6846 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6847 sizes, since they can exceed INT_MAX in size. Check for size
6848 calculation overflow.
6850 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6851 (xg_select): Check for size calculation overflow.
6852 Don't update size until alloc done.
6854 * xrdb.c (get_environ_db): Don't assume path length fits in int,
6855 as sprintf is limited to int lengths.
6857 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6858 (X_LONG_MIN): New macros.
6859 Use them to make the following changes clearer.
6860 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6861 This change doesn't affect the value now, but it may help remind
6862 future maintainers not to raise the value too much later.
6863 (SELECTION_QUANTUM): Remove, replacing with ...
6864 (selection_quantum): ... new function, which avoids overflow.
6866 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6867 assumption that selection length fits in 'int'.
6868 (x_reply_selection_request, x_handle_selection_request)
6869 (x_get_window_property, receive_incremental_selection)
6870 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6871 (lisp_data_to_selection_data, clean_local_selection_data):
6872 Use ptrdiff_t, not int, to record length of selection.
6873 (x_reply_selection_request, x_get_window_property)
6874 (receive_incremental_selection, x_property_data_to_lisp):
6875 Redo calculations to avoid overflow.
6876 (x_reply_selection_request): When sending hint, ceiling it at
6877 X_LONG_MAX rather than relying on wraparound overflow to send
6879 (x_get_window_property, receive_incremental_selection)
6880 (lisp_data_to_selection_data, x_property_data_to_lisp):
6881 Check for size-calculation overflow.
6882 (x_get_window_property, receive_incremental_selection)
6883 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6884 Don't store size until memory allocation succeeds.
6885 (x_get_window_property): Plug memory leak on memory exhaustion.
6886 Don't double-block input; malloc is safe here. Don't assume 2**34
6887 - 4 fits in unsigned long. Add an xassert to check
6888 XGetWindowProperty overflow. Be more careful about overflow
6889 calculations, and distinguish size from memory overflow better.
6890 (receive_incremental_selection): When tracing, don't assume
6891 unsigned int is less than INT_MAX.
6892 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6893 harmful) conversions of unsigned short to int.
6894 (lisp_data_to_selection_data): Don't assume that integers
6895 in the range -65535 through -1 fit in an X unsigned short.
6896 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6897 result parameters unless successful. Rely on cons_to_unsigned
6898 to report problems with elements; the old code wasn't right anyway.
6899 (x_check_property_data): Check for int overflow; we cannot use
6900 a wider type due to X limits.
6901 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6903 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
6905 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6906 (x_term_init): Check for size calculation overflow.
6907 (x_color_cells): Don't store size until memory allocation succeeds.
6908 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
6909 Don't assume alloca size is less than MAX_ALLOCA.
6910 (x_term_init): Don't assume length fits in int (sprintf is limited
6913 Use ptrdiff_t for composition IDs.
6914 * character.c (lisp_string_width):
6915 * composite.c (composition_table_size, n_compositions)
6916 (get_composition_id, composition_gstring_from_id):
6917 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6918 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6919 * window.c (Frecenter):
6920 Use ptrdiff_t, not int, for composition IDs.
6921 * composite.c (get_composition_id): Check for integer overflow.
6922 * composite.h: Adjust prototypes to match the above changes.
6924 Use ptrdiff_t for hash table indexes.
6925 * category.c (hash_get_category_set):
6926 * ccl.c (ccl_driver):
6927 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6928 * coding.c (coding_system_charset_list, detect_coding_system):
6929 * coding.h (struct coding_system.id):
6930 * composite.c (get_composition_id, gstring_lookup_cache):
6931 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6932 * image.c (xpm_get_color_table_h):
6933 * lisp.h (hash_lookup, hash_put):
6934 * minibuf.c (Ftest_completion):
6935 Use ptrdiff_t for hash table indexes, not int (which is too
6936 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6937 32-bit --with-wide-int hosts).
6939 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6940 Add a FIXME comment about memory leaks.
6941 (syms_of_charset): Don't assume xmalloc returns.
6943 Don't assume that stated character widths fit in int.
6944 * character.c (Fchar_width, c_string_width, lisp_string_width):
6945 * character.h (CHAR_WIDTH):
6946 * indent.c (MULTIBYTE_BYTES_WIDTH):
6947 Use sanitize_char_width to avoid undefined and/or bad behavior
6948 with outlandish widths.
6949 * character.h (sanitize_tab_width): Rename from sanitize_width,
6950 now that we have two such functions. All uses changed.
6951 (sanitize_char_width): New inline function.
6953 Don't assume that tab-width fits in int.
6954 * character.h (sanitize_width): New inline function.
6955 (SANE_TAB_WIDTH): New macro.
6956 (ASCII_CHAR_WIDTH): Use it.
6957 * indent.c (sane_tab_width): Remove. All uses replaced by
6958 SANE_TAB_WIDTH (current_buffer).
6959 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6961 * fileio.c: Integer overflow issues with file modes.
6962 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6964 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6965 Remove unreachable code.
6966 (read_hex, load_charset_map_from_file): Check for integer overflow.
6968 * xterm.c: Don't go over XClientMessageEvent limit.
6969 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6970 (x_send_scroll_bar_event): Likewise. Check that the size does not
6971 exceed limits imposed by XClientMessageEvent, as well as the usual
6972 ptrdiff_t and size_t limits.
6974 * keyboard.c: Overflow, signedness and related fixes.
6975 (make_lispy_movement): Use same integer type in forward decl
6976 that is used in the definition.
6977 (read_key_sequence, keyremap_step):
6978 Change bufsize argument back to int, undoing my 2011-03-30 change.
6979 We prefer signed types, and int is wide enough here.
6980 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6981 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6982 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6983 length, not size_t. Use ptrdiff_t for index, not int.
6984 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6985 possibility of integer overflow.
6987 Overflow, signedness and related fixes for images.
6989 * dispextern.h (struct it.stack[0].u.image.image_id)
6990 (struct_it.image_id, struct image.id, struct image_cache.size)
6991 (struct image_cache.used, struct image_cache.ref_count):
6992 * gtkutil.c (update_frame_tool_bar):
6993 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6994 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6995 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6996 * nsmenu.m (update_frame_tool_bar):
6997 * xdisp.c (calc_pixel_width_or_height):
6998 * xfns.c (image_cache_refcount):
6999 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7000 on typical 64-bit hosts.
7002 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7003 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7004 Omit unnecessary casts to int.
7005 (parse_image_spec): Check that integers fall into 'int' range
7006 when the callers expect that.
7007 (image_ascent): Redo ascent calculation to avoid int overflow.
7008 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7009 (lookup_image): Remove unnecessary tests.
7010 (xbm_image_p): Locals are now of int, not EMACS_INT,
7011 since parse_image_check makes sure they fit into int.
7012 (png_load, gif_load, svg_load_image):
7013 Prefer int to unsigned where either will do.
7014 (tiff_handler): New function, combining the cores of the
7015 old tiff_error_handler and tiff_warning_handler.
7016 This function is rewritten to use vsnprintf and thereby avoid
7017 stack buffer overflows. It uses only the features of vsnprintf
7018 that are common to both POSIX and native Microsoft.
7019 (tiff_error_handler, tiff_warning_handler): Use it.
7020 (tiff_load, gif_load, imagemagick_load_image):
7021 Don't assume :index value fits in 'int'.
7022 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7023 (imagemagick_load_image): Check that crop parameters fit into
7024 the integer types that MagickCropImage accepts. Don't assume
7025 Vimagemagick_render_type has a nonnegative value. Don't assume
7026 size_t fits in 'long'.
7027 (gs_load): Use printmax_t to print the widest integers possible.
7028 Check for integer overflow when computing image height and width.
7030 2011-08-26 Eli Zaretskii <eliz@gnu.org>
7032 * xdisp.c (redisplay_window): Don't force window start if point
7033 will be invisible in the resulting window. (Bug#9324)
7035 2011-08-25 Eli Zaretskii <eliz@gnu.org>
7037 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7038 the display spec is of the form `(space ...)'.
7039 (handle_display_spec): Return the value returned by
7040 handle_single_display_spec, not just 1 or zero.
7041 (handle_single_display_spec): If the display spec is of the form
7042 `(space ...)', and specifies display in the text area, return 2
7044 (try_cursor_movement): Check for the need to scroll more
7045 accurately, and prefer exact match for point under bidi.
7046 Don't advance `row' beyond the last row of the window.
7048 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7049 into disp_prop; all users changed.
7051 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7052 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7053 for the text covered by the display property.
7055 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
7057 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7058 Change return value to nil.
7059 (Frecord_buffer): Delete unused function.
7061 2011-08-24 Eli Zaretskii <eliz@gnu.org>
7063 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7064 buffers, return left-to-right.
7065 (set_cursor_from_row): Consider candidate row a win if its glyph
7066 represents a newline and point is on that newline. Fixes cursor
7067 positioning on the newline at EOL of R2L text within L2R
7068 paragraph, and vice versa.
7069 (try_cursor_movement): Check continued rows, in addition to
7070 continuation rows. Fixes unwarranted scroll when point enters a
7071 continued line of R2L text within an L2R paragraph, or vice versa.
7072 (cursor_row_p): Consider the case of point being equal to
7073 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7074 from the end of a short line to the beginning of a continued line
7075 of R2L text within L2R paragraph.
7076 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7077 composed characters.
7079 * bidi.c (bidi_check_type): Use xassert.
7080 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7083 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7085 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7088 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
7090 * nsfont.m (ns_otf_to_script): Fix typo.
7092 2011-08-22 Kenichi Handa <handa@m17n.org>
7094 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7095 extra slot even if the purpose is char-code-property-table.
7097 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7099 * xdisp.c (redisplay_window): When computing centering_position,
7100 account for the height of the header line. (Bug#8874)
7102 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7103 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7104 candidate is selected by the mouse, and that candidate has a
7105 composed character under the mouse.
7107 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7108 coordinates reported by pos-visible-in-window-p for a composed
7109 character in column zero.
7111 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7113 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7115 2011-08-22 Eli Zaretskii <eliz@gnu.org>
7117 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7118 consider it a hit if to_charpos is anywhere in the range of the
7119 composed buffer positions.
7121 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
7123 * image.c (gif_load): Don't assume that each subimage has the same
7124 dimensions as the base image. Handle disposal method that is
7125 "undefined" by the gif spec (Bug#9335).
7127 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
7129 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
7130 (Fcondition_case): Document `debug' symbol in error handler.
7132 2011-08-19 Eli Zaretskii <eliz@gnu.org>
7134 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7135 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7136 from an Org mode buffer to a Speedbar frame.
7138 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7139 a composition, take its buffer position from IT->cmp_it.charpos.
7140 Fixes cursor positioning at the beginning of a line that begins
7141 with a composed character.
7143 2011-08-18 Eli Zaretskii <eliz@gnu.org>
7145 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7146 character bidirectional type, use STRONG_L instead. Fixes crashes
7147 in a buffer produced by `describe-categories'.
7149 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7150 members before the level stack, so they would be saved and
7151 restored when copying iterator state. Fixes incorrect reordering
7152 around TABs covered by display properties.
7154 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7156 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
7158 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
7160 * eval.c (internal_condition_case, internal_condition_case_1)
7161 (internal_condition_case_2, internal_condition_case_n):
7162 Remove unnecessary aborts (Bug#9081).
7164 2011-08-17 Eli Zaretskii <eliz@gnu.org>
7166 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7167 has no `load' handler, try opening the file locally. (Bug#9311)
7169 2011-08-16 Ken Brown <kbrown@cornell.edu>
7171 * gmalloc.c: Expand comment.
7173 2011-08-16 Eli Zaretskii <eliz@gnu.org>
7175 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7176 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7178 2011-08-16 Ken Brown <kbrown@cornell.edu>
7180 Fix memory allocation problems in Cygwin build (Bug#9273).
7182 * unexcw.c ( __malloc_initialized): Declare external variable.
7183 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7185 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7187 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7189 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7191 [CYGWIN] (special_realloc): New function.
7192 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7193 requests to realloc storage in the static heap.
7195 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7197 * bidi.c (bidi_initialize): Remove unused local.
7199 2011-08-15 Eli Zaretskii <eliz@gnu.org>
7202 * biditype.h: Remove file.
7203 * makefile.w32-in ($(BLD)/bidi.$(O)):
7204 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
7206 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7208 * chartab.c: Improve commentary for the uniprop_table API.
7210 * bidi.c (bidi_paragraph_init): Support zero value of
7211 bidi_ignore_explicit_marks_for_paragraph_level.
7212 (bidi_initialize): Use uniprop_table instead of including
7213 biditype.h and bidimirror.h.
7215 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7216 coordinates of the iterator when restoring from ppos_it.
7219 2011-08-14 Kenichi Handa <handa@m17n.org>
7221 * process.c (create_process): Call setup_process_coding_systems
7222 after the pid of the process is set to -1 (Bug#8162).
7224 2011-08-14 Eli Zaretskii <eliz@gnu.org>
7226 * xdisp.c (move_it_in_display_line_to): Don't invoke
7227 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7228 ppos_it. Fixes vertical cursor motion when line beginning is
7229 covered by an image. (Bug#9296)
7231 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7233 * nsterm.h (ns_run_ascript): Declare.
7234 (NSAPP_DATA2_RUNASSCRIPT): Define.
7236 * nsfns.m (as_script, as_result, as_status): New static variables.
7237 (ns_run_ascript): New function.
7238 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
7239 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7240 the event loop. Get status from as_status (Bug#7276).
7242 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7243 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7244 the event loop (Bug#7276).
7246 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7248 * gnutls.c (QCgnutls_bootprop_priority)
7249 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7250 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7251 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7252 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7253 (QCgnutls_bootprop_verify_hostname_error)
7254 (QCgnutls_bootprop_callbacks_verify): Rename from
7255 Qgnutls_bootprop_..., all uses changed.
7257 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7260 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7262 * xfaces.c (Qframe_set_background_mode): Now static.
7263 * dispextern.h (Qframe_set_background_mode): Remove decl.
7265 * process.c (Fnetwork_interface_info): Declare local only if needed.
7267 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7269 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7270 (Fnetwork_interface_list): Allocate in increments of bytes instead
7271 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7272 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7274 (struct ifflag_def): notrailers is smart on OSX.
7275 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7276 Get hardware address with getifaddrs if available.
7278 2011-08-12 Eli Zaretskii <eliz@gnu.org>
7280 * xdisp.c (iterate_out_of_display_property): xassert that
7281 IT->position is set to within IT->object's boundaries. Break from
7282 the loop as soon as EOB is reached; avoids infloops in redisplay
7283 when IT->position is set up wrongly due to some bug.
7284 Set IT->current to match the bidi iterator unconditionally.
7285 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7286 entry. Force push_it to save on the stack the current
7287 buffer/string position, to be restored by pop_it. Fix flags in
7288 the iterator structure wrt the object coming from a display
7289 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7290 properties. (Bug#9284)
7292 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
7294 * fontset.c (fontset_get_font_group): Add proper type checks.
7297 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7299 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7300 and LC_VERSION_MIN_MACOSX.
7301 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7302 (dump_it) [LC_FUNCTION_STARTS]: Use it.
7304 2011-08-08 Eli Zaretskii <eliz@gnu.org>
7306 * xdisp.c (forward_to_next_line_start): Allow to use the
7307 no-display-properties-and-no-overlays under bidi display.
7308 Set disp_pos in the bidi iterator to avoid searches for display
7309 properties and overlays.
7311 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
7313 * editfns.c (Fset_time_zone_rule): Document relationship with the
7316 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7317 the font entity extracted from the cache (Bug#8109).
7319 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
7321 * composite.c (autocmp_chars): Don't reset point. That is done by
7322 restore_point_unwind (Bug#5984).
7324 2011-08-07 Juri Linkov <juri@jurta.org>
7326 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7327 to show the arg `TIME' instead of `TIMEVAL'.
7329 2011-08-06 Eli Zaretskii <eliz@gnu.org>
7331 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7332 display property strides EOL and includes a newline, as in
7333 longlines-mode. (Bug#9254)
7334 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7335 word-wrap under bidirectional display. (Bug#9224)
7337 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7338 is non-zero, even if the data buffer is NULL. Fixes a crash in
7339 vertical-motion with longlines-mode. (Bug#9254)
7341 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7343 * bidi.c <bidi_cache_total_alloc>: Now static.
7344 (bidi_initialize): Initialize bidi_cache_total_alloc.
7346 * xdisp.c (display_line): Release buffer allocated for shelved bidi
7349 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7350 amount allocated this far in `bidi_cache_total_alloc'.
7351 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7352 non-zero, only free the data buffer without restoring the cache
7353 contents. All callers changed.
7355 * dispextern.h (bidi_unshelve_cache): Update prototype.
7357 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7358 (move_it_in_display_line, move_it_to)
7359 (move_it_vertically_backward, move_it_by_lines): Replace the call
7360 to xfree to an equivalent call to bidi_unshelve_cache.
7361 (move_it_in_display_line_to): Fix logic of returning
7362 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
7364 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7366 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7367 came from a string character with a `cursor' property. (Bug#9229)
7369 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7371 * Makefile.in (LIB_PTHREAD): New variable.
7372 (LIBES): Add LIB_PTHREAD (Bug#9216).
7374 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7375 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7377 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7379 * regex.c (re_iswctype): Remove some redundant boolean conversions.
7381 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7383 * xterm.c (x_find_topmost_parent): New function.
7384 (x_set_frame_alpha): Find topmost parent window with
7385 x_find_topmost_parent and set the property there also (bug#9181).
7386 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7388 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7390 * callproc.c (Fcall_process): Avoid vfork clobbering
7391 the local vars buffer, coding_systems, current_dir.
7393 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7395 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7397 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7399 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7400 so that it is not optimized away.
7402 * xdisp.c (compute_display_string_pos): Remove unused local.
7404 2011-08-02 Eli Zaretskii <eliz@gnu.org>
7406 Fix slow cursor motion and scrolling in large buffers with
7407 selective display, like Org Mode buffers. (Bug#9218)
7409 * dispextern.h (struct bidi_it): New member disp_prop_p.
7411 * xdisp.c: Remove one-slot cache of display string positions.
7412 (compute_display_string_pos): Accept an additional argument
7413 DISP_PROP_P; callers changed. Scan at most 5K characters forward
7414 for a display string or property. If found, set DISP_PROP_P
7417 * bidi.c (bidi_fetch_char): Accept an additional argument
7418 DISP_PROP_P, and pass it to compute_display_string_pos.
7419 Only handle text covered by a display string if DISP_PROP_P is returned
7420 non-zero. All callers of bidi_fetch_char changed.
7422 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7424 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7426 2010-12-03 Don March <don@ohspite.net>
7428 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7429 last character M-[char] is translated to ESC [char] (bug#7541).
7431 2011-08-02 Kenichi Handa <handa@m17n.org>
7433 * lisp.h (uniprop_table): Extern it.
7435 * chartab.c (uniprop_table): Make it non-static.
7437 2011-08-01 Eli Zaretskii <eliz@gnu.org>
7439 * xdisp.c (forward_to_next_line_start): Accept additional argument
7440 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7442 (reseat_at_next_visible_line_start): Use the bidi iterator state
7443 returned by forward_to_next_line_start to restore the state of
7444 it->bidi_it after backing up to previous newline. (Bug#9212)
7446 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7448 * regex.c (re_comp): Protoize.
7449 (re_exec): Fix return type.
7450 (regexec): Fix type of `ret'. (Bug#9203)
7452 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7454 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7455 This is needed if max-image-size is a floating-point number.
7457 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7459 * print.c (print_object): Print empty symbol as ##.
7461 * lread.c (read1): Read ## as empty symbol.
7463 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7465 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7466 setting frame foreground color (Bug#9175).
7467 (x_set_background_color): Likewise.
7469 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7470 contents (Bug#9176).
7471 (EmacsTooltip -init): Remove bezels and add shadows to
7474 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7475 or scroll bar (Bug#8470).
7477 * nsfont.m (nsfont_open): Remove assignment to voffset and
7478 unnecessary vars hshink, expand, hd, full_height, min_height.
7479 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7481 * nsterm.h (nsfont_info): Remove voffset field.
7483 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7485 Implement strike-through and overline on NextStep (Bug#8863).
7487 * nsfont.m (nsfont_open): Use underline position provided by font,
7488 instead of hard-coded value of 2.
7489 (nsfont_draw): Call ns_draw_text_decoration instead.
7491 * nsterm.h: Add declaration for ns_draw_text_decoration.
7493 * nsterm.m (ns_draw_text_decoration): New function for drawing
7494 underline, overline, and strike-through.
7495 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7496 ns_draw_text_decoration. Change treatment of cursor drawing to
7497 accommodate underlining, etc.
7499 2011-07-28 Eli Zaretskii <eliz@gnu.org>
7501 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7504 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7506 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7507 Without this fix, if a signal arrives just after memory fills up,
7508 'malloc' might be invoked reentrantly.
7510 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7511 In other words, assume that every image size is allowed, on non-X
7512 hosts. This assumption is probably wrong, but it lets Emacs compile.
7514 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7516 * regex.c (re_iswctype): Convert return values to boolean.
7518 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7520 * xdisp.c (compute_display_string_pos): Don't use cached display
7521 string position if the buffer had its restriction changed.
7524 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7526 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7528 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7530 Integer signedness and overflow and related fixes. (Bug#9079)
7532 * bidi.c: Integer size and overflow fixes.
7533 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7534 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7535 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7536 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7537 (bidi_find_other_level_edge):
7538 Use ptrdiff_t instead of EMACS_INT where either will do.
7539 This works better on 32-bit hosts configured --with-wide-int.
7540 (bidi_cache_ensure_space): Check for size-calculation overflow.
7541 Use % rather than repeated addition, for better worst-case speed.
7542 Don't set bidi_cache_size until after xrealloc returns, because it
7544 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
7545 (bidi_cache_ensure_space): Also check that the bidi cache size
7546 does not exceed that of the largest Lisp string or buffer. See Eli
7547 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
7549 * alloc.c (__malloc_size_t): Remove.
7550 All uses replaced by size_t. See Andreas Schwab's note
7551 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7553 * image.c: Improve checking for integer overflow.
7554 (check_image_size): Assume that f is nonnull, since
7555 it is always nonnull in practice. This is one less thing to
7556 worry about when checking for integer overflow later.
7557 (x_check_image_size): New function, which checks for integer
7558 overflow issues inside X.
7559 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7560 This removes the need for a memory_full check.
7561 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7562 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7563 (xbm_read_bitmap_data): Change locals back to 'int', since
7564 their values must fit in 'int'.
7565 (xpm_load_image, png_load, tiff_load):
7566 Invoke x_create_x_image_and_pixmap earlier,
7567 to avoid much needless work if the image is too large.
7568 (tiff_load): Treat overly large images as if
7569 x_create_x_image_and_pixmap failed, not as malloc failures.
7570 (gs_load): Use x_check_image_size.
7572 * gtkutil.c: Omit integer casts.
7573 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7574 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7576 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7578 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7579 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7580 would wrongly return t on a 64-bit host.
7582 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7583 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7584 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7585 and therefore cause GCC to emit a bogus diagnostic in some cases.
7587 * image.c: Integer signedness and overflow and related fixes.
7588 This is not an exhaustive set of fixes, but it's time to
7589 record what I've got.
7590 (lookup_pixel_color, check_image_size): Remove redundant decls.
7591 (check_image_size): Don't assume that arbitrary EMACS_INT values
7592 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7593 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7594 (tiff_load, imagemagick_load_image):
7595 Check for overflow in size calculations.
7596 (x_create_x_image_and_pixmap): Remove unnecessary test for
7597 xmalloc returning NULL; that can't happen.
7598 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7599 (xpm_color_bucket): Use better integer hashing function.
7600 (xpm_cache_color): Don't possibly over-allocate memory.
7601 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7602 (gif_memory_source):
7603 Use ptrdiff_t, not int or size_t, to record sizes.
7604 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7605 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7606 either works, as we prefer signed integers.
7607 (tiff_read_from_memory, tiff_write_from_memory):
7608 Return tsize_t, not size_t, since that's what the TIFF API wants.
7609 (tiff_read_from_memory): Don't fail simply because the read would
7610 go past EOF; instead, return a short read.
7611 (tiff_load): Omit no-longer-needed casts.
7612 (Fimagemagick_types): Don't assume size fits into 'int'.
7614 Improve hashing quality when configured --with-wide-int.
7615 * fns.c (hash_string): New function, taken from sxhash_string.
7616 Do not discard information about ASCII character case; this
7617 discarding is no longer needed.
7618 (sxhash-string): Use it. Change sig to match it. Caller changed.
7619 * lisp.h: Declare it.
7620 * lread.c (hash_string): Remove, since we now use fns.c's version.
7621 The fns.c version returns a wider integer if --with-wide-int is
7622 specified, so this should help the quality of the hashing a bit.
7624 * emacs.c: Integer overflow minor fix.
7625 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7626 Define only if GNU_LINUX.
7627 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7629 * dispnew.c: Integer signedness and overflow fixes.
7630 Remove unnecessary forward decls, that were a maintenance hassle.
7631 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7633 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7634 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7635 (prepare_desired_row, line_draw_cost):
7636 Use int, not unsigned, where either works.
7637 (save_current_matrix, restore_current_matrix):
7638 Use ptrdiff_t, not size_t, where either works.
7639 (init_display): Check for overflow more accurately, and without
7640 relying on undefined behavior.
7642 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7643 Remove, replacing with the new symbols in lisp.h. All uses changed.
7644 * fileio.c (make_temp_name):
7645 * filelock.c (lock_file_1, lock_file):
7646 * xdisp.c (message_dolog):
7647 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7648 Use pMd etc. instead.
7649 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7650 replacing the pWIDE etc. symbols removed from editfns.c.
7652 * keyboard.h (num_input_events): Now uintmax_t.
7653 This is (very slightly) less likely to mess up due to wraparound.
7656 * buffer.c: Integer signedness fixes.
7657 (alloc_buffer_text, enlarge_buffer_text):
7658 Use ptrdiff_t rather than size_t when either will do, as we prefer
7661 * alloc.c: Integer signedness and overflow fixes.
7662 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7663 (__malloc_size_t): Default to size_t, not to int.
7664 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7665 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7666 Prefer ptrdiff_t to size_t when either would do, as we prefer
7668 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7669 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7670 Now const. Initialize with values that are in range even if char
7672 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7673 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7674 These functions do the right thing with sizes > 2**32.
7675 (check_depth): Now ptrdiff_t, not int.
7676 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7677 Adjust to new way of storing sizes. Check for size overflow bugs
7679 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7680 slightly wrong anyway, as it missed one instance of
7681 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7682 (refill_memory_reserve): Omit needless cast to size_t.
7683 (mark_object_loop_halt): Mark as externally visible.
7685 * xselect.c: Integer signedness and overflow fixes.
7686 (Fx_register_dnd_atom, x_handle_dnd_message):
7687 Use ptrdiff_t, not size_t, since we prefer signed.
7688 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7689 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7690 x_dnd_atoms_size and x_dnd_atoms_length.
7692 * doprnt.c: Prefer signed to unsigned when either works.
7694 * doprnt.c (doprnt):
7696 * xdisp.c (vmessage):
7697 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7698 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7699 prefer signed arithmetic to avoid comparison confusion.
7700 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7701 but is a bit tricky.
7703 Assume freestanding C89 headers, string.h, stdlib.h.
7704 * data.c, doprnt.c, floatfns.c, print.c:
7705 Include float.h unconditionally.
7706 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7707 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7708 * regex.c: Likewise for stddef.h, string.h.
7709 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7710 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7711 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7712 (STDC_HEADERS): Remove obsolete defines.
7713 * sysdep.c: Include limits.h unconditionally.
7715 Assume support for memcmp, memcpy, memmove, memset.
7716 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7717 * regex.c (memcmp, memcpy):
7718 Remove; we assume C89 now.
7720 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7721 (__malloc_safe_bcopy): Remove; no longer needed.
7723 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
7724 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7725 well either way, and we prefer signed to unsigned.
7727 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7729 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7730 closes the connection while we're reading (bug#9182).
7732 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
7734 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7735 are specified (Bug#9168).
7737 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7739 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7740 Found by GCC static checking and --with-wide-int on a 32-bit host.
7742 2011-07-25 Eli Zaretskii <eliz@gnu.org>
7744 * xdisp.c (compute_display_string_pos): Fix logic of caching
7745 previous display string position. Initialize cached_prev_pos to
7746 -1. Fixes slow-down at the beginning of a buffer.
7748 2011-07-24 Eli Zaretskii <eliz@gnu.org>
7750 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7751 for attrs[LFACE_FONTSET_INDEX].
7753 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7755 * xml.c (parse_region): Remove unused local
7756 that was recently introduced.
7758 2011-07-23 Eli Zaretskii <eliz@gnu.org>
7760 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7761 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7763 * xdisp.c (move_it_in_display_line_to): Record the best matching
7764 position for TO_CHARPOS while scanning the line, and restore it on
7765 exit if none of the characters scanned was an exact match.
7766 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
7767 when exact match is impossible due to invisible text, and the
7768 lines are truncated.
7770 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7772 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7775 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7777 Fix a significant slow-down of cursor motion with C-n, C-p,
7778 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7779 auto-repeat under bidi redisplay in fontified buffers.
7780 * xdisp.c (compute_stop_pos_backwards): New function.
7781 (next_element_from_buffer): Call compute_stop_pos_backwards to
7782 find a suitable prev_stop when we find ourselves before
7784 (reseat): Don't look for prev_stop, as that could mean a very long
7786 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7787 <cached_disp_overlay_modiff>: Cache for last found display string
7789 (compute_display_string_pos): Return the cached position if asked
7790 about the same buffer in the same area of character positions, and
7791 the buffer wasn't changed since the time the display string
7792 position was cached.
7794 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7796 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7797 is an integer, which is important for empty lines. (Bug#9149)
7799 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
7801 * frame.c (Fmodify_frame_parameters): In tty case, update the
7802 default face if necessary (Bug#4238).
7804 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
7806 * editfns.c (Fstring_to_char): No need to explain what a character
7807 is in the docstring (Bug#6576).
7809 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7811 * xml.c (parse_region): Make sure we always return a tree.
7813 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7815 * xml.c (parse_region): If a document contains only comments,
7818 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7820 * xml.c (make_dom): Return comments, too.
7822 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7825 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7826 and the surrounding thread.
7827 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7828 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7829 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7831 * s/openbsd.h (BROKEN_SIGIO): Define.
7832 * unexelf.c (unexec) [__OpenBSD__]:
7833 Don't update the .mdebug section of the Alpha COFF symbol table.
7835 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7837 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7840 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7842 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7843 This fixes some race conditions on the permissions of any newly
7846 * alloc.c (valid_pointer_p): Use pipe, not open.
7847 This fixes some permissions issues when debugging.
7849 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7850 If fchown fails to set both uid and gid, try to set just gid,
7851 as that is sometimes allowed. Adjust the file's mode to eliminate
7852 setuid or setgid bits that are inappropriate if fchown fails.
7854 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7856 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7857 to compare Lisp_Objects.
7858 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7859 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7860 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7862 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7864 * lread.c (read_integer): Unread even EOF character.
7865 (read1): Likewise. Properly record start position of symbol.
7867 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7868 symbol character follows.
7870 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7872 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7873 This works around a problem with the previous change to Fcopy_file.
7874 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7875 and without this change, GCC might complain about discarding
7876 fchown's return value.
7878 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
7880 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7882 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7884 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7886 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7888 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7889 it's used from the C level.
7891 * process.c: Use the same condition for POLL_FOR_INPUT in both
7892 keyboard.c and process.c (bug#1858).
7894 2011-07-09 Lawrence Mitchell <wence@gmx.li>
7896 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7897 (Fgnutls_boot): Use it.
7899 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7901 * doc.c (Fsubstitute_command_keys): Revert last change.
7903 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7905 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7906 quotes the next character, and doesn't affect other longer
7907 sequences (bug#8935).
7909 * lread.c (syms_of_lread): Clarify that is isn't only
7910 `eval-buffer' and `eval-defun' that's affected by
7911 `lexical-binding' (bug#8460).
7913 2011-07-15 Eli Zaretskii <eliz@gnu.org>
7915 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
7916 bidi redisplay when a line includes both an image and is truncated.
7918 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7920 Fix minor problems found by static checking.
7921 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7922 (elsz): Now a signed constant, not a size_t var. We prefer signed
7923 types to unsigned, to avoid integer comparison confusion. Without
7924 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7925 "cannot optimize loop, the loop counter may overflow", a symptom
7927 * indent.c (Fvertical_motion): Mark locals as initialized.
7928 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7930 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7932 * search.c (Fre_search_backward): Mention `case-fold-search' in
7933 all the re_search_* functions (bug#8138).
7935 * keyboard.c (Fopen_dribble_file): Document when the file is
7938 2011-07-14 Eli Zaretskii <eliz@gnu.org>
7940 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7943 Support bidi reordering of display and overlay strings.
7944 * xdisp.c (compute_display_string_pos)
7945 (compute_display_string_end): Accept additional argument STRING.
7946 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7947 (reseat_to_string): Initialize bidi_it->string.s and
7948 bidi_it->string.schars.
7949 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
7950 NULL (avoids a crash in bidi_paragraph_init).
7951 Initialize itb.string.lstring.
7952 (init_iterator): Call bidi_init_it only of a valid
7953 buffer position was specified. Initialize paragraph_embedding to
7955 (reseat_to_string): Initialize the bidi iterator.
7956 (display_string): If we need to ignore text properties of
7957 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7958 original value of -1 will not work with bidi.)
7959 (compute_display_string_pos): First arg is now struct
7960 `text_pos *'; all callers changed. Support display properties on
7962 (compute_display_string_end): Support display properties on Lisp
7964 (init_iterator, reseat_1, reseat_to_string): Initialize the
7965 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7966 when iterating on a string not from display properties).
7967 (compute_display_string_pos, compute_display_string_end):
7968 Fix calculation of the object to scan. Fixes an error when using
7970 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
7971 base_level_stop; instead, set base_level_stop to BEGV.
7972 Fixes crashes in vertical-motion.
7973 (next_element_from_buffer): Improve commentary for when
7974 the iterator is before prev_stop.
7975 (init_iterator): Initialize bidi_p from the default value of
7976 bidi-display-reordering, not from buffer-local value. Use the
7977 buffer-local value only if initializing for buffer iteration.
7978 (handle_invisible_prop): Support invisible properties on strings
7979 that are being bidi-reordered.
7980 (set_iterator_to_next): Support bidi reordering of C strings and
7982 (next_element_from_string): Support bidi reordering of Lisp
7984 (handle_stop_backwards): Support Lisp strings as well.
7985 (display_string): Support display of R2L glyph rows.
7986 Use IT_STRING_CHARPOS when displaying from a Lisp string.
7987 (init_iterator): Don't initialize it->bidi_p for strings
7989 (reseat_to_string): Initialize it->bidi_p for strings here.
7990 (next_element_from_string, next_element_from_c_string)
7991 (next_element_from_buffer): Add xassert's for correspondence
7992 between IT's object being iterated and it->bidi_it.string
7994 (face_before_or_after_it_pos): Support bidi iteration.
7995 (next_element_from_c_string): Handle the case of the first string
7996 character that is not the first one in the visual order.
7997 (get_visually_first_element): New function, refactored from common
7998 parts of next_element_from_buffer, next_element_from_string, and
7999 next_element_from_c_string.
8000 (tool_bar_lines_needed, redisplay_tool_bar)
8001 (display_menu_bar): Force left-to-right direction. Add a FIXME
8002 comment for making that be controlled by a user option.
8003 (push_it, pop_it): Save and restore the state of the
8004 bidi iterator. Save and restore the bidi_p flag.
8005 (pop_it): Iterate out of display property for string iteration as
8007 (iterate_out_of_display_property): Support iteration over strings.
8008 (handle_single_display_spec): Set up it->bidi_it for iteration
8009 over a display string, and call bidi_init_it.
8010 (handle_single_display_spec, next_overlay_string)
8011 (get_overlay_strings_1, push_display_prop): Set up the bidi
8012 iterator for displaying display or overlay strings.
8013 (forward_to_next_line_start): Don't use the shortcut if
8015 (back_to_previous_visible_line_start): If handle_display_prop
8016 pushed the iterator stack, restore the internal state of the bidi
8017 iterator by calling bidi_pop_it same number of times.
8018 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8019 and we are bidi-iterating, don't decrement the iterator position;
8020 instead, set the first_elt flag in the bidi iterator, to produce
8022 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8023 (push_display_prop): xassert that we are iterating a buffer.
8024 (push_it, pop_it): Save and restore paragraph_embedding member.
8025 (handle_single_display_spec, next_overlay_string)
8026 (get_overlay_strings_1, reseat_1, reseat_to_string)
8027 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8028 correctly. Don't assume unibyte strings are not bidi-reordered.
8029 (compute_display_string_pos)
8030 (compute_display_string_end): Fix handling the case of C string.
8031 (push_it, pop_it): Save and restore from_disp_prop_p.
8032 (handle_single_display_spec, push_display_prop): Set the
8033 from_disp_prop_p flag.
8034 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8035 (pop_it): Call iterate_out_of_display_property only if we are
8036 popping after iteration over a string that came from a display
8037 property. Fix a typo in popping stretch info. Add an assertion
8038 for verifying that the iterator position is in sync with the bidi
8040 (handle_single_display_spec, get_overlay_strings_1)
8041 (push_display_prop): Fix initialization of paragraph direction for
8042 string when that of the parent object is not yet determined.
8043 (reseat_1): Call bidi_init_it to resync the bidi
8044 iterator with IT's position. (Bug#7616)
8045 (find_row_edges): If ROW->start.pos gives position
8046 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8047 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8048 Reset the from_disp_prop_p flag.
8049 (SAVE_IT, RESTORE_IT): New macros.
8050 (pos_visible_p, face_before_or_after_it_pos)
8051 (back_to_previous_visible_line_start)
8052 (move_it_in_display_line_to, move_it_in_display_line)
8053 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8054 (try_scrolling, redisplay_window, display_line): Use them when
8055 saving a temporary copy of the iterator and restoring it back.
8056 (back_to_previous_visible_line_start, reseat_1)
8057 (init_iterator): Empty the bidi cache "stack".
8058 (move_it_in_display_line_to): If iterator ended up at
8059 EOL, but we never saw any buffer positions smaller than
8060 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8061 motion in bidi-reordered lines.
8062 (move_it_in_display_line_to): Record prev_method and prev_pos
8063 immediately before the call to set_iterator_to_next. Fixes cursor
8064 motion in bidi-reordered lines with stretch glyphs and strings
8065 displayed in margins. (Bug#8133) (Bug#8867)
8066 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8068 (pos_visible_p): Support positions in bidi-reordered lines.
8069 Save and restore bidi cache.
8071 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8072 (bidi_paragraph_info): Delete unused struct.
8073 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8074 (bidi_cache_start): New variable.
8075 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8077 (bidi_cache_fetch_state, bidi_cache_search)
8078 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8079 (bidi_cache_find, bidi_peek_at_next_level)
8080 (bidi_level_of_next_char, bidi_find_other_level_edge)
8081 (bidi_move_to_visually_next): Compare cache index with
8082 bidi_cache_start rather than with zero.
8083 (bidi_fetch_char): Accept new argument STRING; all callers
8084 changed. Support iteration over a string. Support strings with
8085 display properties. Support unibyte strings. Fix the type of
8086 `len' according to what STRING_CHAR_AND_LENGTH expects.
8087 (bidi_paragraph_init, bidi_resolve_explicit_1)
8088 (bidi_resolve_explicit, bidi_resolve_weak)
8089 (bidi_level_of_next_char, bidi_move_to_visually_next):
8090 Support iteration over a string.
8091 (bidi_set_sor_type, bidi_resolve_explicit_1)
8092 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8093 can now be zero (for strings); special values 0 and -1 were
8094 changed to -1 and -2, respectively.
8095 (bidi_char_at_pos): New function.
8096 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8097 Call it instead of FETCH_MULTIBYTE_CHAR.
8098 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8099 initialized to valid values.
8100 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8102 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8103 the test for valid cached positions. Fix the logic for looking up
8104 the sentinel state in the cache. GCPRO the Lisp string we are
8106 (bidi_push_it, bidi_pop_it): New functions.
8107 (bidi_initialize): Initialize the bidi cache start stack pointer.
8108 (bidi_cache_ensure_space): New function, refactored from part of
8109 bidi_cache_iterator_state. Don't assume the required size is just
8110 one BIDI_CACHE_CHUNK away.
8111 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8112 (bidi_count_bytes, bidi_char_at_pos): New functions.
8113 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8114 always valid if bidi_cache_idx is valid.
8115 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8116 is valid if it's going to be used.
8117 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8118 (bidi_cache_fetch_state, bidi_cache_search)
8119 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8120 (bidi_cache_iterator_state, bidi_cache_find)
8121 (bidi_find_other_level_edge, bidi_cache_start_stack):
8122 All variables related to cache indices are now EMACS_INT.
8124 * dispextern.h (struct bidi_string_data): New structure.
8125 (struct bidi_it): New member `string'. Make flag members be 1-bit
8126 fields, and put them last in the struct.
8127 (compute_display_string_pos, compute_display_string_end):
8129 (bidi_push_it, bidi_pop_it): Add prototypes.
8130 (struct iterator_stack_entry): New members bidi_p,
8131 paragraph_embedding, and from_disp_prop_p.
8132 (struct it): Member bidi_p is now a bit field 1 bit wide.
8133 (bidi_shelve_cache, bidi_unshelve_cache):
8136 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8137 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8138 and vector-like objects.
8140 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8141 cache around display iteration.
8143 * window.c (Fwindow_end, window_scroll_pixel_based)
8144 (displayed_window_lines, Frecenter): Save and restore the bidi
8145 cache around display iteration.
8147 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8149 * editfns.c (Fdelete_region): Clarify the use of the named
8150 parameters (bug#6788).
8152 2011-07-14 Martin Rudalics <rudalics@gmx.at>
8154 * indent.c (Fvertical_motion): Set and restore w->pointm when
8155 saving and restoring the window's buffer (Bug#9006).
8157 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8159 * editfns.c (Fstring_to_char): Clarify just what is returned
8160 (bug#6576). Text by Eli Zaretskii.
8162 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
8164 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8166 2011-07-13 Eli Zaretskii <eliz@gnu.org>
8168 * buffer.c (mmap_find): Fix a typo.
8170 2011-07-13 Johan Bockgård <bojohan@gnu.org>
8172 Fix execution of x selection hooks.
8173 * xselect.c (Qx_lost_selection_functions)
8174 (Qx_sent_selection_functions): New vars.
8175 (syms_of_xselect): DEFSYM them.
8176 (x_handle_selection_request): Pass Qx_sent_selection_functions
8177 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8178 (x_handle_selection_clear,x_clear_frame_selections):
8179 Pass Qx_lost_selection_functions rather than
8180 Vx_lost_selection_functions to Frun_hook_with_args.
8182 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8184 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
8185 The old code sometimes used this field without initializing it.
8187 * alloc.c (gc_sweep): Don't read past end of array.
8188 In theory, the old code could also have corrupted Emacs internals,
8189 though it'd be very unlikely.
8191 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8193 * character.c (Fcharacterp): Don't advertise optional ignored
8194 argument. (Bug#4026)
8196 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8198 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8201 * window.c (Fset_window_start): Doc fix (bug#4199).
8202 (Fset_window_hscroll): Ditto.
8204 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8206 Fix minor new problems caught by GCC 4.6.1.
8207 * term.c (init_tty): Remove unused local.
8208 * xsettings.c (store_monospaced_changed): Define this function only
8209 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
8212 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
8214 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8216 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8218 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8219 are the mini-buffer and the echo area (bug#3320).
8221 * term.c (init_tty): Remove support for supdup, c10 and perq
8222 terminals, which are no longer supported (bug#1482).
8224 2011-07-10 Johan Bockgård <bojohan@gnu.org>
8226 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8228 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8230 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8231 for non-popups (Bug#3642).
8233 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8235 * alloc.c (reset_malloc_hooks): Protoize.
8236 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
8237 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8238 * cm.c (losecursor): Likewise.
8239 * data.c (fmod): Likewise.
8240 * dispnew.c (swap_glyphs_in_rows): Likewise.
8241 * emacs.c (memory_warning_signal): Likewise.
8242 * floatfns.c (float_error): Likewise.
8243 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8244 (otf_open, font_otf_capability, generate_otf_features)
8245 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8247 * image.c (pbm_read_file): Likewise.
8248 * indent.c (string_display_width): Likewise.
8249 * intervals.c (check_for_interval, search_for_interval)
8250 (inc_interval_count, count_intervals, root_interval)
8251 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8252 * lread.c (defalias): Likewise.
8253 * ralloc.c (r_alloc_check): Likewise.
8254 * regex.c (set_image_of_range_1, set_image_of_range)
8255 (regex_grow_registers): Likewise.
8256 * sysdep.c (strerror): Likewise.
8257 * termcap.c (valid_filename_p, tprint, main): Likewise.
8258 * tparam.c (main): Likewise.
8259 * unexhp9k800.c (run_time_remap, save_data_space)
8260 (update_file_ptrs, read_header, write_header, calculate_checksum)
8261 (copy_file, copy_rest, display_header): Likewise.
8262 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8264 * xdisp.c (check_it): Likewise.
8265 * xfaces.c (register_color, unregister_color, unregister_colors):
8267 * xfns.c (print_fontset_result): Likewise.
8268 * xrdb.c (member, fatal, main): Likewise.
8270 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8272 Fix minor problems found by static checking (Bug#9031).
8273 * chartab.c (char_table_set_range, map_sub_char_table):
8274 Remove unused locals.
8275 (uniprop_table): Now static.
8276 * composite.c (_work_char): Remove unused static var.
8278 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
8280 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8282 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8284 * gtkutil.c (qttip_cb): Remove code without function.
8286 2011-07-09 Eli Zaretskii <eliz@gnu.org>
8288 * w32.c (pthread_sigmask): New stub.
8290 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
8292 Use pthread_sigmask, not sigprocmask (Bug#9010).
8293 sigprocmask is portable only for single-threaded applications, and
8294 Emacs can be multi-threaded when it uses GTK.
8295 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8297 * callproc.c (Fcall_process):
8298 * process.c (create_process):
8299 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8300 Use pthread_sigmask, not sigprocmask.
8302 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8304 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8305 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8308 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8310 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8311 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8312 (xg_hide_tooltip): Fix comment.
8314 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8315 in registerServicesMenuSendTypes.
8316 (validRequestorForSendType): Don't check ns_return_types.
8318 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8321 2011-07-08 Jason Rumney <jasonr@gnu.org>
8323 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8324 SH_SHOW for hidden windows (Bug#5482).
8326 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8327 frame struct members of non-existent frames (Bug#6284).
8329 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8331 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8332 variable firstTime not needed on OSX >= 10.6.
8333 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8334 >= 10.5. Use setKnobProportion, setDoubleValue.
8336 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8337 (MAC_OS_X_VERSION_10_5): Define if not defined.
8338 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8339 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8340 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8342 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
8343 cString and lossyCString on OSX >= 10.4.
8345 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
8346 sizeToFit on OSX >= 10.2.
8348 * nsimage.m (allocInitFromFile): Don't use deprecated method
8349 bestRepresentationForDevice on OSX >= 10.6.
8351 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8354 * emacs.c: Declare unexec_init_emacs_zone.
8356 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8358 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8360 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8361 on svcsMenu (Bug#8842).
8363 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8365 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8367 * nsterm.m (QUTF8_STRING): Declare.
8368 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8369 (validRequestorForSendType): Return type is (id).
8370 Change indexOfObjectIdenticalTo to indexOfObject.
8371 Check if we have local selection before returning self (Bug#8842).
8372 (writeSelectionToPasteboard): Put local selection into paste board
8373 if we have a local selection (Bug#8842).
8374 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8376 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8377 (ns_get_local_selection): Declare.
8379 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8381 * keymap.c (describe_map_tree): Don't insert a double newline at
8382 the end of the buffer (bug#1169) and return whether we inserted
8385 * callint.c (Fcall_interactively): Change "reading args" to
8386 "providing args" to try to clarify what it does (bug#1010).
8388 2011-07-07 Kenichi Handa <handa@m17n.org>
8390 * composite.c (composition_compute_stop_pos): Ignore a static
8391 composition starting before CHARPOS (Bug#8915).
8393 * xdisp.c (handle_composition_prop): Likewise.
8395 2011-07-07 Eli Zaretskii <eliz@gnu.org>
8397 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8400 2011-07-07 Kenichi Handa <handa@m17n.org>
8402 * character.h (unicode_category_t): New enum type.
8404 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8405 (Qchar_code_property_table): New variable.
8406 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8407 (UNIPROP_COMPRESSED_FORM_P): New macros.
8408 (char_table_ascii): Uncompress the compressed values.
8409 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8410 Uncompress the compressed values.
8411 (sub_char_table_ref_and_range): Likewise.
8412 (char_table_ref_and_range): Uncompress the compressed values.
8413 (sub_char_table_set): New arg is_uniprop. Callers changed.
8414 Uncompress the compressed values.
8415 (sub_char_table_set_range): Args changed. Callers changed.
8416 (char_table_set_range): Adjuted for the above change.
8417 (map_sub_char_table): Delete args default_val and parent. Add arg
8418 top. Give decoded values to a Lisp function.
8419 (map_char_table): Adjust for the above change. Give decoded
8420 values to a Lisp function. Gcpro more variables.
8421 (uniprop_table_uncompress)
8422 (uniprop_decode_value_run_length): New functions.
8423 (uniprop_decoder, uniprop_decoder_count): New variables.
8424 (uniprop_get_decoder, uniprop_encode_value_character)
8425 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8427 (uniprop_encoder, uniprop_encoder_count): New variables.
8428 (uniprop_get_encoder, uniprop_table)
8429 (Funicode_property_table_internal, Fget_unicode_property_internal)
8430 (Fput_unicode_property_internal): New functions.
8431 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8432 Sunicode_property_table_internal, Sget_unicode_property_internal,
8433 and Sput_unicode_property_internal. Defvar_lisp
8434 char-code-property-alist.
8436 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
8437 Vunicode_category_table.
8439 * font.c (font_range): Adjust for the change of
8440 Vunicode_category_table.
8442 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8444 * m/iris4d.h: Remove file, move contents ...
8445 * s/irix6-5.h: ... here.
8447 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8449 Remove unportable assumption about struct layout (Bug#8884).
8450 * alloc.c (mark_buffer):
8451 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8452 (clone_per_buffer_values): Don't assume that
8453 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8454 This isn't true in general, and it's particularly not true
8455 if Emacs is configured with --with-wide-int.
8456 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8457 New macros, used in the buffer.c change.
8459 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8461 * xsettings.c: Use both GConf and GSettings if both are available.
8462 (store_config_changed_event): Add comment.
8463 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8464 (store_tool_bar_style_changed): New functions.
8465 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
8466 (struct xsettings): Move font inside HAVE_XFT.
8467 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
8468 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
8469 Move inside HAVE_XFT.
8470 (something_changed_gsettingsCB): Rename from something_changedCB.
8471 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8473 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
8474 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
8475 (something_changed_gconfCB): Rename from something_changedCB.
8476 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8477 (parse_settings): Move check for font inside HAVE_XFT.
8478 (read_settings, apply_xft_settings): Add comment.
8479 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8480 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8481 call store_font_name_changed.
8482 (xft_settings_event): Add comment.
8483 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8484 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8485 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8486 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8487 (xsettings_initialize): Call init_gsettings last.
8488 (xsettings_get_system_font, xsettings_get_system_normal_font):
8491 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8493 Random fixes. E.g., (random) never returned negative values.
8494 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8495 subseconds part to the entropy, as that's a bit more random.
8496 Prefer signed to unsigned, since the signedness doesn't matter and
8497 in general we prefer signed. When given a limit, use a
8498 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8499 latter isn't right if USE_2_TAGS_FOR_INTS.
8500 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8501 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8503 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8505 * textprop.c (text_property_stickiness):
8506 Obey Vtext_property_default_nonsticky.
8507 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8508 * w32fns.c (syms_of_w32fns):
8509 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8511 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8513 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8514 This is more efficient than Ffile_directory_p and avoids a minor race.
8516 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8518 * buffer.c (Foverlay_put): Say what the return value is
8521 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8522 is a directory before asking whether to use the file name
8524 (barf_or_query_if_file_exists): Make the "File is a directory"
8525 error be more correct.
8527 * fns.c (Frequire): Remove the mention of the .gz files, since
8528 that's installation-specific, but keep the mention of
8529 `get-load-suffixes'.
8531 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8533 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8534 Report string overflow if the output is too long.
8536 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
8538 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8539 (syms_of_gnutls): Remove duplicate DEFSYM for
8540 Qgnutls_bootprop_verify_hostname_error, an error for
8541 Qgnutls_bootprop_verify_error (which is no longer used).
8543 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8544 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8545 Also (re)move comments that are misplaced or no longer relevant.
8547 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8549 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8551 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
8553 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8554 and background color parameters if they have been changed.
8556 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8558 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8560 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8562 * xsettings.c (SYSTEM_FONT): Define only when used.
8563 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8565 * keymap.c (access_keymap_1): Now static.
8567 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
8569 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8570 leave any prefix arg for the up event (Bug#1586).
8572 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8574 * lread.c (syms_of_lread): Mention single symbols defined by
8575 `defvar' or `defconst' (bug#7154).
8577 * fns.c (Frequire): Mention .el.gz files (bug#7314).
8578 (Frequire): Mention get-load-suffixes.
8580 2011-07-02 Martin Rudalics <rudalics@gmx.at>
8582 * window.h (window): Remove clone_number slot.
8583 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8585 (make_parent_window, make_window, saved_window)
8586 (Fset_window_configuration, save_window_save): Don't deal with
8588 * buffer.c (Qclone_number): Remove declaration.
8589 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8591 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8593 Add multiple inheritance to keymaps.
8594 * keymap.c (Fmake_composed_keymap): New function.
8595 (Fset_keymap_parent): Simplify.
8596 (fix_submap_inheritance): Remove.
8597 (access_keymap_1): New function extracted from access_keymap to handle
8598 embedded parents and handle lists of maps.
8599 (access_keymap): Use it.
8600 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8601 (Fcopy_keymap): Handle embedded parents.
8602 (Fcommand_remapping, define_as_prefix): Simplify.
8603 (Fkey_binding): Simplify.
8604 (syms_of_keymap): Move minibuffer-local-completion-map,
8605 minibuffer-local-filename-completion-map,
8606 minibuffer-local-must-match-map, and
8607 minibuffer-local-filename-must-match-map to Elisp.
8608 (syms_of_keymap): Defsubr make-composed-keymap.
8609 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8610 (parse_menu_item): Trivial simplification.
8612 2011-07-01 Glenn Morris <rgm@gnu.org>
8614 * Makefile.in (SETTINGS_LIBS): Fix typo.
8616 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8618 * coding.c (Fencode_coding_string): Record the last coding system
8619 used, as the function doc string says (bug#8738).
8621 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8623 * xsettings.c (store_monospaced_changed): Take new font as arg and
8624 check for change against current_mono_font.
8625 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8626 (emacs_settings_constructor, emacs_settings_get_property)
8627 (emacs_settings_set_property, emacs_settings_class_init)
8628 (emacs_settings_init, gsettings_obj): Remove.
8629 (something_changedCB): New function for HAVE_GSETTINGS.
8630 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8631 with value as argument.
8632 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8633 g_settings_new (Bug#8967). Do not create gsettings_obj.
8634 Remove calls to g_settings_bind. Connect something_changedCB to
8637 * xgselect.c: Add defined (HAVE_GSETTINGS).
8638 (xgselect_initialize): Ditto.
8640 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8641 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8644 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8646 * eval.c (struct backtrace): Simplify and port the data structure.
8647 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8648 signed bit field, as this assumption is not portable and it makes
8649 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8650 "char debug_on_exit : 1" as this is not portable either; instead,
8651 use the portable "unsigned int debug_on_exit : 1". Remove unused
8652 member evalargs. Remove obsolete comments about cc bombing out.
8654 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8656 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
8657 Let HAVE_GSETTINGS override HAVE_GCONF.
8658 (store_monospaced_changed): New function.
8659 (EMACS_SETTINGS): A new type derived from GObject to handle
8660 GSettings notifications.
8661 (emacs_settings_constructor, emacs_settings_get_property)
8662 (emacs_settings_set_property, emacs_settings_class_init):
8664 (gsettings_client, gsettings_obj): New variables.
8665 (GSETTINGS_SCHEMA): New define.
8666 (something_changedCB): Call store_monospaced_changed.
8667 (init_gsettings): New function.
8668 (xsettings_initialize): Call init_gsettings.
8669 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8672 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
8675 2011-06-29 Martin Rudalics <rudalics@gmx.at>
8677 * window.c (resize_root_window, grow_mini_window)
8678 (shrink_mini_window): Rename Qresize_root_window to
8679 Qwindow_resize_root_window and Qresize_root_window_vertically to
8680 Qwindow_resize_root_window_vertically.
8682 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8684 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8686 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
8688 * makefile.w32-in: Redesign dependencies so they reflect more
8689 clearly which files are directly included by each source file,
8690 and not through other includes.
8692 2011-06-27 Martin Rudalics <rudalics@gmx.at>
8694 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8695 (sort_overlays, overlay_strings): When an overlay's clone number
8696 matches the window's clone number process the overlay even if
8697 the overlay's window property doesn't match the current window.
8699 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8700 (Fwindow_hchild): Rename to Fwindow_left_child.
8701 (Fwindow_next): Rename to Fwindow_next_sibling.
8702 (Fwindow_prev): Rename to Fwindow_prev_sibling.
8703 (resize_window_check): Rename to window_resize_check.
8704 (resize_window_apply): Rename to window_resize_apply.
8705 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8706 (Fdelete_other_windows_internal, resize_frame_windows)
8707 (Fsplit_window_internal, Fdelete_window_internal)
8708 (grow_mini_window, shrink_mini_window)
8709 (Fresize_mini_window_internal): Fix callers accordingly.
8711 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8713 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8714 (emacs_fixed_set_min_size): Remove.
8715 (emacs_fixed_new): Take frame as argument.
8717 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8718 (_EmacsFixedPrivate): Remove minwidth/height.
8719 Add struct frame *f.
8720 (emacs_fixed_init): Initialize priv->f.
8721 (get_parent_class, emacs_fixed_set_min_size): Remove.
8722 (emacs_fixed_new): Set priv->f to argument.
8723 (emacs_fixed_get_preferred_width)
8724 (emacs_fixed_get_preferred_height): Use min_width/height from
8725 frames size_hint to set minimum and natural (Bug#8919).
8726 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8727 and use min_width/height from frames size_hint to set
8728 min_width/height (Bug#8919).
8730 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
8731 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8734 2011-06-26 Eli Zaretskii <eliz@gnu.org>
8736 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8737 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8740 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
8742 * process.c (wait_reading_process_output): Bypass select if
8743 waiting for a cell while ignoring keyboard input, and input is
8744 pending. Suggested by Jan Djärv (Bug#8869).
8746 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8748 Use gnulib's dup2 module instead of rolling our own.
8749 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8751 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8753 * dispnew.c (scrolling_window): Before scrolling, turn off a
8754 mouse-highlight in the window being scrolled.
8756 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
8758 Move DEFSYM to lisp.h and use everywhere.
8760 * character.h (DEFSYM): Move declaration...
8761 * lisp.h (DEFSYM): ...here.
8767 * w32select.c: Don't include character.h.
8769 * alloc.c (syms_of_alloc):
8770 * buffer.c (syms_of_buffer):
8771 * bytecode.c (syms_of_bytecode):
8772 * callint.c (syms_of_callint):
8773 * casefiddle.c (syms_of_casefiddle):
8774 * casetab.c (init_casetab_once):
8775 * category.c (init_category_once, syms_of_category):
8776 * ccl.c (syms_of_ccl):
8777 * cmds.c (syms_of_cmds):
8778 * composite.c (syms_of_composite):
8779 * dbusbind.c (syms_of_dbusbind):
8780 * dired.c (syms_of_dired):
8781 * dispnew.c (syms_of_display):
8782 * doc.c (syms_of_doc):
8783 * editfns.c (syms_of_editfns):
8784 * emacs.c (syms_of_emacs):
8785 * eval.c (syms_of_eval):
8786 * fileio.c (syms_of_fileio):
8787 * fns.c (syms_of_fns):
8788 * frame.c (syms_of_frame):
8789 * fringe.c (syms_of_fringe):
8790 * insdel.c (syms_of_insdel):
8791 * keymap.c (syms_of_keymap):
8792 * lread.c (init_obarray, syms_of_lread):
8793 * macros.c (syms_of_macros):
8794 * msdos.c (syms_of_msdos):
8795 * print.c (syms_of_print):
8796 * process.c (syms_of_process):
8797 * search.c (syms_of_search):
8798 * sound.c (syms_of_sound):
8799 * syntax.c (init_syntax_once, syms_of_syntax):
8800 * terminal.c (syms_of_terminal):
8801 * textprop.c (syms_of_textprop):
8802 * undo.c (syms_of_undo):
8803 * w32.c (globals_of_w32):
8804 * window.c (syms_of_window):
8805 * xdisp.c (syms_of_xdisp):
8806 * xfaces.c (syms_of_xfaces):
8807 * xfns.c (syms_of_xfns):
8808 * xmenu.c (syms_of_xmenu):
8809 * xsettings.c (syms_of_xsettings):
8810 * xterm.c (syms_of_xterm): Use DEFSYM.
8812 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8814 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
8816 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8818 Integer and buffer overflow fixes (Bug#8873).
8820 * print.c (printchar, strout): Check for string overflow.
8821 (PRINTPREPARE, printchar, strout):
8822 Don't set size unless allocation succeeds.
8824 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8825 for sizes. Check for string overflow more accurately.
8826 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8828 * macros.c: Integer and buffer overflow fixes.
8829 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8830 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8831 Use ptrdiff_t, not int, for sizes.
8832 Don't increment bufsize until after realloc succeeds.
8833 Check for size-calculation overflow.
8834 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8836 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8838 * lread.c: Integer overflow fixes.
8839 (read_integer): Radix is now EMACS_INT, not int,
8840 to improve quality of diagnostics for out-of-range radices.
8841 Calculate buffer size correctly for out-of-range radices.
8842 (read1): Check for integer overflow in radices, and in
8843 read-circle numbers.
8844 (read_escape): Avoid int overflow.
8845 (Fload, openp, read_buffer_size, read1)
8846 (substitute_object_recurse, read_vector, read_list, map_obarray):
8847 Use ptrdiff_t, not int, for sizes.
8848 (read1): Use EMACS_INT, not int, for sizes.
8849 Check for size overflow.
8851 * image.c (cache_image): Check for size arithmetic overflow.
8853 * lread.c: Integer overflow issues.
8854 (saved_doc_string_size, saved_doc_string_length)
8855 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8856 Now ptrdiff_t, not int.
8857 (read1): Don't assume doc string length fits in int. Check for
8858 out-of-range doc string lengths.
8859 (read_list): Don't assume file position fits in int.
8860 (read_escape): Check for hex character overflow.
8862 2011-06-22 Leo Liu <sdl.web@gmail.com>
8864 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8865 Move to minibuffer.el.
8867 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8869 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
8870 The following patches are for when GLYPH_DEBUG && !XASSERT.
8871 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8872 * dispnew.c (flush_stdout):
8873 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8874 Mark as externally visible.
8875 * dispnew.c (check_window_matrix_pointers): Now static.
8876 * dispnew.c (window_to_frame_vpos):
8877 * xfns.c (unwind_create_frame):
8878 * xterm.c (x_check_font): Remove unused local.
8879 * scroll.c (CHECK_BOUNDS):
8880 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8881 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8882 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8883 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8884 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8886 (debug_method_add): Use va_list and vsprintf rather than relying
8887 on undefined behavior with wrong number of arguments.
8888 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8889 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8890 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8891 since we're not interested in debugging glyphs with old libraries.
8892 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8893 GCC 4.6.0's static checking.
8895 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8897 Integer overflow and signedness fixes (Bug#8873).
8898 A few related buffer overrun fixes, too.
8900 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8902 * dispextern.h (struct face.stipple):
8903 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8904 (x_bitmap_mask, x_allocate_bitmap_record)
8905 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8906 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8907 (x_create_bitmap_from_xpm_data):
8908 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8909 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8911 * xfaces.c (load_pixmap):
8912 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8913 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8914 (.bitmaps_last, struct x_output.icon_bitmap):
8915 Use ptrdiff_t, not int, for bitmap indexes.
8916 (x_allocate_bitmap_record): Check for size overflow.
8917 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8919 Use ptrdiff_t, not int, for overlay counts.
8920 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8921 * editfns.c (overlays_around, get_pos_property):
8922 * textprop.c (get_char_property_and_overlay):
8923 * xdisp.c (next_overlay_change, note_mouse_highlight):
8924 * xfaces.c (face_at_buffer_position):
8925 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8926 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8927 (Fnext_overlay_change, Fprevious_overlay_change)
8928 (mouse_face_overlay_overlaps, Foverlays_in):
8929 Use ptrdiff_t, not int, for sizes.
8930 (overlays_at, overlays_in): Check for size-calculation overflow.
8932 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8934 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8935 (x_session_initialize): Do not assume string length fits in int.
8937 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8938 This is unlikely, but can occur if DPI is outlandish.
8940 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
8941 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8943 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8944 * xrdb.c (magic_file_p, search_magic_path):
8945 Omit last arg SUFFIX; it was always 0. All callers changed.
8946 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8948 * xfont.c (xfont_match): Avoid need for strlen.
8950 * xfns.c: Don't assume strlen fits in int.
8951 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8953 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8954 not unsigned long, as we prefer signed integers. All callers changed.
8955 Detect integer overflow in repeat count.
8956 (message_dolog): Don't assume print length fits in 39 bytes.
8957 (display_mode_element): Don't assume strlen fits in int.
8959 * termcap.c: Don't assume sizes fit in int and never overflow.
8960 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8961 (gobble_line): Check for size-calculation overflow.
8963 * minibuf.c (Fread_buffer):
8964 * lread.c (intern, intern_c_string):
8965 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8966 Don't assume string length fits in int.
8968 * keyboard.c (parse_tool_bar_item):
8969 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8971 * font.c: Don't assume string length fits in int.
8972 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8973 Use ptrdiff_t, not int.
8974 (font_intern_prop): Don't assume string length fits in int.
8975 Don't assume integer property fits in fixnum.
8976 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
8978 * filelock.c: Fix some buffer overrun and integer overflow issues.
8979 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
8980 Reformulate so as not to need the command string.
8981 Invoke gzip -cd rather than gunzip, as it's more portable.
8982 (lock_info_type, lock_file_1, lock_file):
8983 Don't assume pid_t and time_t fit in unsigned long.
8984 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8985 (current_lock_owner): Prefer signed type for sizes.
8986 Use memcpy, not strncpy, where memcpy is what is really wanted.
8987 Don't assume (via atoi) that time_t and pid_t fit in int.
8988 Check for time_t and/or pid_t out of range, e.g., via a network share.
8989 Don't alloca where an auto var works fine.
8991 * fileio.c: Fix some integer overflow issues.
8992 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8993 Don't assume string length fits in int.
8994 (directory_file_name): Don't assume string length fits in long.
8995 (make_temp_name): Don't assume pid fits in int, or that its print
8996 length is less than 20.
8998 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9000 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9002 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9004 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9005 We prefer signed integers, even for size calculations.
9007 * emacs.c: Don't assume string length fits in 'int'.
9008 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9009 (main): Don't invoke strlen when not needed.
9011 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9012 (XD_DEBUG_MESSAGE): Don't waste a byte.
9014 * callproc.c (getenv_internal_1, getenv_internal)
9016 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9018 * lread.c (invalid_syntax): Omit length argument.
9019 All uses changed. This doesn't fix a bug, but it simplifies the
9020 code away from its former Hollerith-constant appearance, and it's
9021 one less 'int' to worry about when looking at integer-overflow issues.
9022 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
9024 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9025 This didn't break anything, but it didn't help either.
9026 It's confusing to put a bogus integer in a place where the actual
9027 value does not matter.
9028 (LIST_END_P): Remove unused macro and its bogus comment.
9029 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
9031 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9032 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9034 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9035 We prefer signed types, and the value cannot exceed the EMACS_INT
9036 range anyway (because otherwise the length would not be representable).
9037 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9038 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9039 This avoids a GCC warning when WIDE_EMACS_INT.
9041 * indent.c (sane_tab_width): New function.
9042 (current_column, scan_for_column, Findent_to, position_indentation)
9043 (compute_motion): Use it. This is just for clarity.
9044 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
9046 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
9048 * lisp.h (lint_assume): New macro.
9049 * composite.c (composition_gstring_put_cache):
9050 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9052 * editfns.c, insdel.c:
9053 Omit unnecessary forward decls, to simplify future changes.
9055 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9057 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9059 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
9060 Use much-faster test for byte-length change.
9061 Don't assume string byte-length fits in 'int'.
9062 Check that character arg fits in 'int'.
9063 (mapcar1): Declare byte as byte, for clarity.
9065 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9067 * fns.c (concat): Catch string overflow earlier.
9068 Do not rely on integer wraparound.
9070 * dispextern.h (struct it.overlay_strings_charpos)
9071 (struct it.selective): Now EMACS_INT, not int.
9072 * xdisp.c (forward_to_next_line_start)
9073 (back_to_previous_visible_line_start)
9074 (reseat_at_next_visible_line_start, next_element_from_buffer):
9075 Don't arbitrarily truncate the value of 'selective' to int.
9077 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9079 * composite.c: Don't truncate sizes to 'int'.
9080 (composition_gstring_p, composition_reseat_it)
9081 (composition_adjust_point): Use EMACS_INT, not int.
9082 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9083 not EMACS_UINT, for indexes.
9085 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9087 * buffer.c: Include <verify.h>.
9088 (struct sortvec.priority, struct sortstr.priority):
9089 Now EMACS_INT, not int.
9090 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
9091 (struct sortstr.size, record_overlay_string)
9092 (struct sortstrlist.size, struct sortlist.used):
9093 Don't truncate size to int.
9094 (record_overlay_string): Check for size-calculation overflow.
9095 (init_buffer_once): Check at compile-time, not run-time.
9097 2011-06-22 Jim Meyering <meyering@redhat.com>
9099 Don't leak an XBM-image-sized buffer
9100 * image.c (xbm_load): Free the image buffer after using it.
9102 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9105 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9106 that Sun C diagnosed.
9107 * fns.c (secure_hash): Fix pointer signedness issue.
9108 * intervals.c (static_offset_intervals): New function.
9109 (offset_intervals): Use it.
9111 2011-06-21 Leo Liu <sdl.web@gmail.com>
9114 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9117 * fns.c (secure_hash): Rename from crypto_hash_function and change
9118 the first arg to accept symbols.
9119 (Fsecure_hash): New primitive.
9120 (syms_of_fns): New symbols.
9122 2011-06-20 Deniz Dogan <deniz@dogan.se>
9124 * process.c (Fset_process_buffer): Clarify return value in
9127 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
9129 * dispnew.c (add_window_display_history): Use BVAR.
9131 * xdisp.c (debug_method_add): Use BVAR.
9132 (check_window_end, dump_glyph_matrix, dump_glyph)
9133 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9135 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9138 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9139 check till after the cache is created in init_frame_faces.
9141 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9143 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9145 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9147 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9148 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9149 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9151 Improve buffer-overflow checking (Bug#8873).
9152 * fileio.c (Finsert_file_contents):
9153 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9154 Remove the old (too-loose) buffer overflow checks.
9155 They weren't needed, since make_gap checks for buffer overflow.
9156 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9157 The old code merely checked for Emacs fixnum overflow, and relied
9158 on undefined (wraparound) behavior. The new code avoids undefined
9159 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9161 * editfns.c (Finsert_char): Don't dump core with very negative counts.
9162 Tune. Don't use wider integers than needed. Don't use alloca.
9163 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
9165 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9167 * insdel.c, lisp.h (buffer_overflow): New function.
9168 (insert_from_buffer_1, replace_range, replace_range_2):
9169 * insdel.c (make_gap_larger):
9170 * editfns.c (Finsert_char):
9171 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9173 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9175 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9177 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
9179 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9180 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9182 * fileio.c: Don't assume EMACS_INT fits in off_t.
9183 (emacs_lseek): New static function.
9184 (Finsert_file_contents, Fwrite_region): Use it.
9185 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9187 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9189 * fns.c: Don't overflow int when computing a list length.
9190 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9191 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9192 truncation on 64-bit hosts. Check for QUIT every
9193 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9194 faster and is responsive enough.
9195 (Flength): Report an error instead of overflowing an integer.
9196 (Fsafe_length): Return a float if the value is not representable
9197 as a fixnum. This shouldn't happen except in contrived situations.
9198 (Fnthcdr, Fsort): Don't assume list length fits in int.
9199 (Fcopy_sequence): Don't assume vector length fits in int.
9201 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9202 (header_size, word_size): New constants.
9203 (allocate_vectorlike): Don't check size overflow here.
9204 (allocate_vector): Check it here instead, since this is the only
9205 caller of allocate_vectorlike that could cause overflow.
9206 Check that the new vector's length is representable as a fixnum.
9208 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9209 The previous code was bogus. For example, next_almost_prime (32)
9210 returned 39, which is undesirable as it is a multiple of 3; and
9211 next_almost_prime (24) returned 25, which is a multiple of 5 so
9212 why was the code bothering to check for multiples of 7?
9214 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9216 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9218 Variadic C functions now count arguments with ptrdiff_t.
9219 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9220 Back then I didn't know that the Emacs coding style prefers signed int.
9221 Also, in the meantime I found a few more instances where arguments
9222 were being counted with int, which may truncate counts on 64-bit
9223 machines, or EMACS_INT, which may be unnecessarily wide.
9224 * lisp.h (struct Lisp_Subr.function.aMANY)
9225 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9226 Arg counts are now ptrdiff_t, not size_t.
9227 All variadic functions and their callers changed accordingly.
9228 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9229 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9230 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9231 * callint.c (Fcall_interactively): Check arg count for overflow,
9232 to avoid potential buffer overrun. Use signed char, not 'int',
9233 for 'varies' array, so that we needn't bother to check its size
9234 calculation for overflow.
9235 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9236 * eval.c (apply_lambda):
9237 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9238 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9239 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9241 * callint.c (Fcall_interactively): Don't use index var as event count.
9243 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9244 * mem-limits.h (SIZE): Remove; no longer used.
9246 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
9248 Remove unnecessary casts.
9249 * xterm.c (x_term_init):
9250 * xfns.c (x_set_border_pixel):
9251 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9252 These aren't needed now that we assume ANSI C.
9254 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9255 It's more likely to cause problems (due to unsigned overflow)
9258 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9260 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9262 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9264 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9266 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9268 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9270 GLYPH_CODE_FACE returns EMACS_INT, not int.
9271 * dispextern.h (merge_faces):
9272 * xfaces.c (merge_faces):
9273 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9274 Don't assume EMACS_INT fits in int.
9276 * character.h (CHAR_VALID_P): Remove unused parameter.
9277 * fontset.c, lisp.h, xdisp.c: All uses changed.
9279 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9281 * fns.c (concat): Minor tuning based on overflow analysis.
9282 This doesn't fix any bugs. Use int to hold character, instead
9283 of constantly refetching from Emacs object. Use XFASTINT, not
9284 XINT, for value known to be a character. Don't bother comparing
9285 a single byte to 0400, as it's always less.
9287 * floatfns.c (Fexpt):
9288 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9290 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9293 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9295 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9296 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9297 incorrectly succeed when S was a string, because 4294967386 was
9298 truncated before it was used.
9300 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9301 Otherwise, an out-of-range integer could cause undefined behavior
9304 * composite.c: Use int, not EMACS_INT, for characters.
9305 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9306 EMACS_INT, for values that are known to be in character range.
9307 This doesn't fix any bugs but is the usual style inside Emacs and
9308 may generate better code on 32-bit machines.
9310 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9311 This is for reasons similar to the recent CHAR_STRING fix.
9312 * charset.c (Fencode_char): Check that character arg is actually
9313 a character. Pass an int to ENCODE_CHAR.
9314 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9315 wider than 'int', as a compile-time check to prevent future regressions
9318 * character.c (char_string): Remove unnecessary casts.
9320 Make sure a 64-bit char is never passed to CHAR_STRING.
9321 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9322 by silently ignoring the top 32 bits, allowing some values
9323 that were far too large to be valid characters.
9324 * character.h: Include <verify.h>.
9325 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9326 arguments are no wider than unsigned, as a compile-time check
9327 to prevent future regressions in this area.
9329 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
9330 (Fsubst_char_in_region):
9332 * xdisp.c (decode_mode_spec_coding):
9333 Adjust to CHAR_STRING's new requirement.
9334 * editfns.c (Finsert_char, Fsubst_char_in_region):
9335 * fns.c (concat): Check that character args are actually
9336 characters. Without this test, these functions did the wrong
9337 thing with wildly out-of-range values on 64-bit hosts.
9339 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9340 These casts should not be needed on 32-bit hosts, either.
9341 * keyboard.c (read_char):
9342 * lread.c (Fload): Remove casts to unsigned.
9344 * lisp.h (UNSIGNED_CMP): New macro.
9345 This fixes comparison bugs on 64-bit hosts.
9346 (ASCII_CHAR_P): Use it.
9347 * casefiddle.c (casify_object):
9348 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
9349 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9350 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9351 * dispextern.h (FACE_FROM_ID):
9352 * keyboard.c (read_char): Use UNSIGNED_CMP.
9354 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9355 not to EMACS_INT, to avoid GCC warning.
9357 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9359 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9360 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9361 isn't needed on 32-bit machines.
9363 * buffer.c (Fgenerate_new_buffer_name):
9364 Use EMACS_INT for count, not int.
9365 (advance_to_char_boundary): Return EMACS_INT, not int.
9367 * data.c (Qcompiled_function): Now static.
9369 * window.c (window_body_lines): Now static.
9371 * image.c (gif_load): Rename local to avoid shadowing.
9373 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9374 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9375 * alloc.c (make_save_value): Integer argument is now of type
9377 (mark_object): Use ptrdiff_t, not int.
9378 * lisp.h (pD): New macro.
9379 * print.c (print_object): Use it.
9381 * alloc.c: Use EMACS_INT, not int, to count objects.
9382 (total_conses, total_markers, total_symbols, total_vector_size)
9383 (total_free_conses, total_free_markers, total_free_symbols)
9384 (total_free_floats, total_floats, total_free_intervals)
9385 (total_intervals, total_strings, total_free_strings):
9386 Now EMACS_INT, not int. All uses changed.
9387 (Fgarbage_collect): Compute overall total using a double, so that
9388 integer overflow is less likely to be a problem. Check for overflow
9389 when converting back to an integer.
9390 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9391 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9392 These were 'int' variables that could overflow on 64-bit hosts;
9393 they were never used, so remove them instead of repairing them.
9394 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
9395 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9396 Previously, this ceilinged at INT_MAX, but that doesn't work on
9398 (allocate_pseudovector): Don't use EMACS_INT when int would do.
9400 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
9401 (allocate_vectorlike): Check for ptrdiff_t overflow.
9402 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9403 when a (possibly-narrower) signed value would do just as well.
9404 We prefer using signed arithmetic, to avoid comparison confusion.
9406 * alloc.c: Catch some string size overflows that we were missing.
9407 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9408 for convenience in STRING_BYTES_MAX.
9409 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9410 The definition here is exact; the one in lisp.h was approximate.
9411 (allocate_string_data): Check for string overflow. This catches
9412 some instances we weren't catching before. Also, it catches
9413 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9414 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9415 and ptrdiff_t and EMACS_INT are both 64 bits.
9417 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9418 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
9419 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
9421 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9423 * alloc.c (Fmake_string): Check for out-of-range init.
9425 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9427 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9429 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9431 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9432 xg_get_default_scrollbar_width.
9434 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9435 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9436 (style_changed_cb): Call update_theme_scrollbar_width and call
9437 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9438 all frames (Bug#8505).
9439 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9440 Call gtk_window_set_resizable if HAVE_GTK3.
9441 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9442 and height if HAVE_GTK3 (Bug#8505).
9443 (scroll_bar_width_for_theme): New variable.
9444 (update_theme_scrollbar_width): New function.
9445 (xg_get_default_scrollbar_width): Move code to
9446 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9447 (xg_initialize): Call update_theme_scrollbar_width.
9449 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9451 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9453 2011-06-12 Martin Rudalics <rudalics@gmx.at>
9455 * frame.c (make_frame): Call other_buffer_safely instead of
9458 * window.c (temp_output_buffer_show): Call display_buffer with
9459 second argument Vtemp_buffer_show_specifiers and reset latter
9460 immediately after the call.
9461 (Vtemp_buffer_show_specifiers): New variable.
9462 (auto_window_vscroll_p, next_screen_context_lines)
9463 (Vscroll_preserve_screen_position): Remove leading asterisks from
9466 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
9468 Fix minor problems found by GCC 4.6.0 static checking.
9469 * buffer.c (Qclone_number): Remove for now, as it's unused.
9470 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9471 (record_buffer): Remove unused local.
9472 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9473 (set_frame_buffer_list): Remove; unused.
9474 * frame.h (other_visible_frames): Remove decl.
9475 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9476 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9477 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9479 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9480 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9481 Define only if HAVE_GPM.
9482 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9483 (update_hints_inhibit): Remove; never set. All uses removed.
9484 * widgetprv.h (emacsFrameClassRec): Remove decl.
9485 * window.c (delete_deletable_window): Now returns void, since it
9486 wasn't returning anything.
9487 (compare_window_configurations): Remove unused locals.
9488 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9489 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
9490 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9491 the same widths as pointers. This follows up on the 2011-05-06 patch.
9492 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9493 * xterm.h: Likewise.
9494 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9496 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
9498 * makefile.w32-in: Update dependencies.
9499 (LISP_H): Add lib/intprops.h.
9501 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9503 * image.c (gif_load): Add animation frame delay to the metadata.
9504 (syms_of_image): Use DEFSYM. New symbol `delay'.
9506 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9508 * window.c (delete_deletable_window): Re-add.
9509 (Fset_window_configuration): Rewrite to handle dead buffers and
9510 consequently deletable windows.
9511 (window_tree, Fwindow_tree): Remove. Supply functionality in
9513 (compare_window_configurations): Simplify code.
9515 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9517 * image.c (imagemagick_load_image): Fix type mismatch.
9518 (Fimagemagick_types): Likewise.
9520 * window.h (replace_buffer_in_windows): Declare.
9522 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9524 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9525 Qclone_number. Remove external declaration of Qdelete_window.
9526 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9528 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9529 Run Qbuffer_list_update_hook if allowed.
9530 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9531 buffer list implementation.
9532 (other_buffer_safely): New function.
9533 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9534 calls to replace_buffer_in_windows and
9535 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9537 (record_buffer): Inhibit quitting and rewrite using quittable
9538 functions. Run Qbuffer_list_update_hook if allowed.
9539 (Frecord_buffer, Funrecord_buffer): New functions.
9540 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9541 Move switch-to-buffer to window.el.
9542 (bury-buffer): Move to window.el.
9543 (Vbuffer_list_update_hook): New variable.
9545 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9548 * window.h (resize_frame_windows): Move up in code.
9549 (Fwindow_frame): Remove EXFUN.
9550 (replace_buffer_in_all_windows): Remove prototype.
9551 (replace_buffer_in_windows_safely): Add prototype.
9553 * window.c: Declare Qdelete_window static again. Move down
9554 declaration of select_count.
9555 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9556 (Fother_window): Move to window.el.
9557 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9558 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9559 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9561 (replace_buffer_in_windows): Implement by calling
9562 Qreplace_buffer_in_windows.
9563 (replace_buffer_in_all_windows): Remove with some functionality
9564 moved into replace_buffer_in_windows_safely.
9565 (replace_buffer_in_windows_safely): New function.
9566 (select_window_norecord, select_frame_norecord): Move in front
9567 of run_window_configuration_change_hook. Remove now obsolete
9569 (Fset_window_buffer): Rewrite doc-string.
9570 Call Qrecord_window_buffer.
9571 (keys_of_window): Move binding for other-window to window.el.
9573 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9575 * dispextern.h (struct image): Replace data member, whose int_val
9576 and ptr_val fields were not used by anything, with a single
9579 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9580 (gif_clear_image, gif_load, imagemagick_load_image)
9581 (gs_clear_image, gs_load): Callers changed.
9583 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9585 * buffer.h: Include <time.h>, for time_t.
9586 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9588 Fix minor problems found by static checking.
9590 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9592 Make identifiers static if they are not used in other modules.
9593 * data.c (Qcompiled_function, Qframe, Qvector):
9594 * image.c (QimageMagick, Qsvg):
9595 * minibuf.c (Qmetadata):
9596 * window.c (resize_window_check, resize_root_window): Now static.
9597 * window.h (resize_window_check, resize_root_window): Remove decls.
9599 * window.c (window_deletion_count, delete_deletable_window):
9601 (window_body_lines): Now static.
9602 (Fdelete_other_windows_internal): Mark vars as initialized.
9603 Make sure 'resize_failed' is initialized.
9604 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9605 (resize_window_apply): Remove unused local.
9606 * window.h (delete_deletable_window): Remove decl.
9608 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
9609 (imagemagick_load_image): Fix pointer signedness problem by changing
9610 last arg from unsigned char * to char *. All uses changed.
9611 Also, fix a local for similar reasons.
9612 Remove unused locals. Remove locals to avoid shadowing.
9613 (fn_rsvg_handle_free): Remove; unused.
9614 (svg_load, svg_load_image): Fix pointer signedness problem.
9615 (imagemagick_load_image): Don't use garbage pointer image_wand.
9617 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9619 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
9621 * image.c (gif_load): Fix omitted cast error introduced by
9624 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9626 * window.h (resize_proportionally, orig_total_lines)
9627 (orig_top_line): Remove from window structure.
9628 (set_window_height, set_window_width, change_window_heights)
9629 (Fdelete_window): Remove prototypes.
9630 (resize_frame_windows): Remove duplicate declaration.
9632 2011-06-10 Eli Zaretskii <eliz@gnu.org>
9634 * window.h (resize_frame_windows, resize_window_check)
9635 (delete_deletable_window, resize_root_window)
9636 (resize_frame_windows): Declare prototypes.
9638 * window.c (resize_window_apply): Make definition be "static" to
9639 match the prototype.
9641 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9643 * window.c: Remove declarations of Qwindow_size_fixed,
9644 window_min_size_1, window_min_size_2, window_min_size,
9645 size_window, window_fixed_size_p, enlarge_window, delete_window.
9646 Remove static from declaration of Qdelete_window, it's
9647 temporarily needed by Fbury_buffer.
9648 (replace_window): Don't assign orig_top_line and
9650 (Fdelete_window, delete_window): Remove. Window deletion is
9651 handled by window.el.
9652 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9653 Replace Fdelete_window calls with calls to Qdelete_window.
9654 (Fdelete_other_windows): Remove. Deleting other windows is
9655 handled by window.el.
9656 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9657 handled in window.el.
9658 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9659 Window minimum sizes are handled in window.el.
9660 (shrink_windows, size_window, set_window_height)
9661 (set_window_width, change_window_heights, window_height)
9662 (window_width, CURBEG, CURSIZE, enlarge_window)
9663 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9664 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9665 handled in window.el.
9666 (make_dummy_parent): Rename to make_parent_window and give it a
9667 second argument horflag.
9668 (make_window): Don't set resize_proportionally any more.
9669 (Fsplit_window): Remove. Windows are split in window.el.
9670 (save_restore_action, save_restore_orig_size)
9671 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9672 Resize mini windows in window.el.
9673 (grow_mini_window, shrink_mini_window): Implement by calling
9674 Qresize_root_window_vertically, resize_window_check and
9675 resize_window_apply.
9676 (saved_window, Fset_window_configuration, save_window_save):
9677 Do not handle orig_top_line, orig_total_lines, and
9678 resize_proportionally.
9679 (window_min_height, window_min_width): Move to window.el.
9680 (keys_of_window): Move bindings for delete-other-windows,
9681 split-window, delete-window and enlarge-window to window.el.
9683 * buffer.c: Temporarily extern Qdelete_window.
9684 (Fbury_buffer): Temporarily call Qdelete_window instead of
9685 Fdelete_window (Fbury_buffer will move to window.el soon).
9687 * frame.c (set_menu_bar_lines_1): Remove code handling
9688 orig_top_line and orig_total_lines.
9690 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9691 set_window_height but set heights directly.
9692 (change_frame_size_1): Use resize_frame_windows.
9694 * xdisp.c (init_xdisp): Don't use set_window_height but set
9697 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9698 Use resize_frame_windows instead of change_window_heights and run
9699 run_window_configuration_change_hook.
9701 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9702 instead of change_window_heights and run
9703 run_window_configuration_change_hook.
9705 2011-06-09 Martin Rudalics <rudalics@gmx.at>
9707 * window.c (replace_window): Rename second argument REPLACEMENT to
9708 NEW. New third argument SETFLAG. Rewrite.
9709 (delete_window, make_dummy_parent): Call replace_window with
9711 (window_list_1): Move down in code.
9712 (run_window_configuration_change_hook): Move set_buffer part
9713 before select_frame_norecord part in order to unwind correctly.
9714 Rename count1 to count.
9715 (recombine_windows, delete_deletable_window, resize_root_window)
9716 (Fdelete_other_windows_internal)
9717 (Frun_window_configuration_change_hook, make_parent_window)
9718 (resize_window_check, resize_window_apply, Fresize_window_apply)
9719 (resize_frame_windows, Fsplit_window_internal)
9720 (Fdelete_window_internal, Fresize_mini_window_internal):
9722 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9724 2011-06-08 Martin Rudalics <rudalics@gmx.at>
9726 * window.h (window): Add some new members to window structure -
9727 normal_lines, normal_cols, new_total, new_normal, clone_number,
9728 splits, nest, prev_buffers, next_buffers.
9729 (WINDOW_TOTAL_SIZE): Move here from window.c.
9730 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
9732 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9734 (make_dummy_parent): Set new members of windows structure.
9735 (make_window): Move down in code. Handle new members of window
9737 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9738 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9739 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9740 (Fset_window_prev_buffers, Fwindow_next_buffers)
9741 (Fset_window_next_buffers, Fset_window_clone_number):
9743 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9744 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9746 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9747 Argument WINDOW can be now internal window too.
9748 (Fwindow_use_time): Move up in code.
9749 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9751 (Fset_window_configuration, saved_window)
9752 (Fcurrent_window_configuration, save_window_save): Handle new
9753 members of window structure.
9754 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9755 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9756 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9757 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9758 Qget_mru_window, Qresize_root_window,
9759 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9760 Qauto_buffer_name; staticpro them.
9762 2011-06-07 Martin Rudalics <rudalics@gmx.at>
9764 * window.c (Fwindow_total_size, Fwindow_left_column)
9765 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9766 (Fwindow_list_1): New functions.
9767 (window_box_text_cols): Replace with window_body_cols.
9768 (Fwindow_width, Fscroll_left, Fscroll_right):
9769 Use window_body_cols instead of window_box_text_cols.
9770 (delete_window, Fset_window_configuration):
9771 Call delete_all_subwindows with window as argument.
9772 (delete_all_subwindows): Take a window as argument and not a
9774 (window_loop): Remove handling of GET_LRU_WINDOW and
9776 (Fget_lru_window, Fget_largest_window): Move to window.el.
9778 * window.h: Extern window_body_cols instead of
9779 window_box_text_cols. delete_all_subwindows now takes a
9780 Lisp_Object as argument.
9782 * indent.c (compute_motion, Fcompute_motion):
9783 Use window_body_cols instead of window_box_text_cols.
9785 * frame.c (delete_frame): Call delete_all_subwindows with root
9788 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9790 * fns.c (Fputhash): Document return value.
9792 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
9794 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9796 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9798 Cons<->int and similar integer overflow fixes (Bug#8794).
9800 Check for overflow when converting integer to cons and back.
9801 * charset.c (Fdefine_charset_internal, Fdecode_char):
9802 Use cons_to_unsigned to catch overflow.
9803 (Fencode_char): Use INTEGER_TO_CONS.
9804 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9805 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9806 * data.c (long_to_cons, cons_to_long): Remove.
9807 (cons_to_unsigned, cons_to_signed): New functions.
9808 These signal an error for invalid or out-of-range values.
9809 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9810 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9811 * font.c (Ffont_variation_glyphs):
9812 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9813 * lisp.h: Include <intprops.h>.
9814 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9815 (cons_to_signed, cons_to_unsigned): New decls.
9816 (long_to_cons, cons_to_long): Remove decls.
9817 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9818 (Fprimitive_undo): Use CONS_TO_INTEGER.
9819 * xfns.c (Fx_window_property): Likewise.
9820 * xselect.c: Include <limits.h>.
9821 (x_own_selection, selection_data_to_lisp_data):
9822 Use INTEGER_TO_CONS.
9823 (x_handle_selection_request, x_handle_selection_clear)
9824 (x_get_foreign_selection, Fx_disown_selection_internal)
9825 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9826 (lisp_data_to_selection_data): Use cons_to_unsigned.
9827 (x_fill_property_data): Use cons_to_signed.
9828 Report values out of range.
9830 Check for buffer and string overflow more precisely.
9831 * buffer.h (BUF_BYTES_MAX): New macro.
9832 * lisp.h (STRING_BYTES_MAX): New macro.
9833 * alloc.c (Fmake_string):
9834 * character.c (string_escape_byte8):
9835 * coding.c (coding_alloc_by_realloc):
9836 * doprnt.c (doprnt):
9837 * editfns.c (Fformat):
9839 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9840 since they may not be the same number.
9841 * editfns.c (Finsert_char):
9842 * fileio.c (Finsert_file_contents):
9843 Likewise for BUF_BYTES_MAX.
9845 * image.c: Use ptrdiff_t, not int, for sizes.
9846 (slurp_file): Switch from int to ptrdiff_t.
9848 (slurp_file): Check that file size fits in both size_t (for
9849 malloc) and ptrdiff_t (for sanity and safety).
9851 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9852 if b->modtime has its maximal value.
9854 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9856 Don't assume time_t can fit into int.
9857 * buffer.h (struct buffer.modtime): Now time_t, not int.
9858 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9859 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9861 Minor fixes for signed vs unsigned integers.
9862 * character.h (MAYBE_UNIFY_CHAR):
9863 * charset.c (maybe_unify_char):
9864 * keyboard.c (read_char, reorder_modifiers):
9865 XINT -> XFASTINT, since the integer must be nonnegative.
9866 * ftfont.c (ftfont_spec_pattern):
9867 * keymap.c (access_keymap, silly_event_symbol_error):
9868 XUINT -> XFASTINT, since the integer must be nonnegative.
9869 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9870 since it makes no difference and we prefer signed.
9871 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9872 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9875 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9877 * window.h (Fwindow_frame): Declare.
9879 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9881 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9882 (SPARE_MEMORY): Always define.
9883 (LARGE_REQUEST): Remove.
9884 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9886 2011-06-06 Martin Rudalics <rudalics@gmx.at>
9888 * lisp.h: Move EXFUNS for Fframe_root_window,
9889 Fframe_first_window and Fset_frame_selected_window to window.h.
9891 * window.h: Move EXFUNS for Fframe_root_window,
9892 Fframe_first_window and Fset_frame_selected_window here from
9895 * frame.c (Fwindow_frame, Fframe_first_window)
9896 (Fframe_root_window, Fframe_selected_window)
9897 (Fset_frame_selected_window): Move to window.c.
9898 (Factive_minibuffer_window): Move to minibuf.c.
9899 (Fother_visible_frames_p): New function.
9901 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9903 * window.c (decode_window, decode_any_window): Move up in code.
9904 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9905 (inhibit_frame_unsplittable): Remove unused variable.
9906 (Fwindow_buffer): Move up and rewrite doc-string.
9907 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9908 (Fwindow_prev): New functions.
9909 (Fwindow_frame): Move here from frame.c. Accept any window as
9911 (Fframe_root_window, Fframe_first_window)
9912 (Fframe_selected_window): Move here from frame.c. Accept frame
9913 or arbitrary window as argument. Update doc-strings.
9914 (Fminibuffer_window): Move up in code.
9915 (Fwindow_minibuffer_p): Move up in code and simplify.
9916 (Fset_frame_selected_window): Move here from frame.c.
9918 (Fselected_window, select_window, Fselect_window): Move up in
9919 code. Minor doc-string fixes.
9921 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9923 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9924 Do not assume that spare memory exists; that assumption is valid
9925 only if SYSTEM_MALLOC.
9926 (LARGE_REQUEST): New macro, so that the issue of large requests
9927 is separated from the issue of spare memory.
9929 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9931 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9934 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9936 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9939 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9941 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9943 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9945 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9946 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9948 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
9950 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9952 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
9954 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9955 (x_clipboard_manager_save): Add return value.
9956 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9958 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9959 Obey Vx_select_enable_clipboard_manager. Catch errors in
9960 x_clipboard_manager_save (Bug#8779).
9961 (Vx_select_enable_clipboard_manager): New variable.
9962 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
9964 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
9966 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9968 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9970 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9971 in the current matrix if keep_current_p is non-zero.
9973 2011-06-04 Eli Zaretskii <eliz@gnu.org>
9975 * bidi.c (bidi_level_of_next_char): Fix last change.
9977 2011-06-03 Eli Zaretskii <eliz@gnu.org>
9979 Support bidi reordering of text covered by display properties.
9981 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9982 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9983 (bidi_cache_search, bidi_cache_iterator_state)
9984 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
9985 (bidi_level_of_next_char, bidi_move_to_visually_next):
9986 Support character positions inside a run of characters covered by a
9988 (bidi_paragraph_init, bidi_resolve_explicit_1)
9989 (bidi_level_of_next_char): Call bidi_fetch_char and
9990 bidi_fetch_char_advance instead of FETCH_CHAR and
9992 (bidi_init_it): Initialize new members.
9993 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9995 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9996 instead of using explicit *_CHAR codes.
9997 (bidi_resolve_explicit, bidi_resolve_weak):
9998 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
9999 bidirectional text is supported only in multibyte buffers.
10000 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10001 it to initialize the frame_window_p member of struct bidi_it.
10002 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10003 (bidi_resolve_explicit, bidi_resolve_weak)
10004 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10005 bidi_it->nchars is non-positive.
10006 (bidi_level_of_next_char): Don't try to lookup the cache for the
10007 next/previous character if nothing is cached there yet, or if we
10008 were just reseat()'ed to a new position.
10010 * xdisp.c (set_cursor_from_row): Set start and stop points
10011 according to the row's direction when priming the loop that looks
10012 for the glyph on which to display cursor.
10013 (single_display_spec_intangible_p): Function deleted.
10014 (display_prop_intangible_p): Reimplement to call
10015 handle_display_spec instead of single_display_spec_intangible_p.
10016 Accept 3 additional arguments needed by handle_display_spec.
10017 This fixes incorrect cursor motion across display property with complex
10018 values: lists, `(when COND...)' forms, etc.
10019 (single_display_spec_string_p): Support property values that are
10020 lists with the argument STRING its top-level element.
10021 (display_prop_string_p): Fix the condition for processing a
10022 property that is a list to be consistent with handle_display_spec.
10023 (handle_display_spec): New function, refactored from the
10024 last portion of handle_display_prop.
10025 (compute_display_string_pos): Accept additional argument
10026 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10027 value of a `display' property is a "replacing spec".
10028 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10029 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10030 the display property, but just return a value indicating whether
10031 the display property will replace the characters it covers.
10032 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10033 frame_window_p members of struct bidi_it.
10034 (compute_display_string_pos, compute_display_string_end):
10036 (push_it): Accept second argument POSITION, where pop_it should
10037 jump to continue iteration.
10038 (reseat_1): Initialize bidi_it.disp_pos.
10040 * keyboard.c (adjust_point_for_property): Adjust the call to
10041 display_prop_intangible_p to its new signature.
10043 * dispextern.h (struct bidi_it): New member frame_window_p.
10044 (bidi_init_it): Update prototypes.
10045 (display_prop_intangible_p): Update prototype.
10046 (compute_display_string_pos, compute_display_string_end):
10047 Declare prototypes.
10048 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10051 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
10053 Malloc failure behavior now depends on size of allocation.
10054 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10055 * lisp.h: Change signatures accordingly.
10056 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10057 All callers changed. (Bug#8762)
10059 * gnutls.c: Use Emacs's memory allocators.
10060 Without this change, the gnutls library would invoke malloc etc.
10061 directly, which causes problems on non-SYNC_INPUT hosts, and which
10062 runs afoul of improving memory_full behavior. (Bug#8761)
10063 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10064 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10065 xfree instead of the default malloc, realloc, free.
10066 (Fgnutls_boot): No need to check for memory allocation failure,
10067 since xmalloc does that for us.
10069 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
10070 * category.c (hash_get_category_set):
10071 * ccl.c (ccl_driver):
10072 * charset.c (Fdefine_charset_internal):
10073 * charset.h (struct charset.hash_index):
10074 * composite.c (get_composition_id, gstring_lookup_cache)
10075 (composition_gstring_put_cache):
10076 * composite.h (struct composition.hash_index):
10077 * dispextern.h (struct image.hash):
10078 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10079 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10080 (hashfn_equal, hashfn_user_defined, make_hash_table)
10081 (maybe_resize_hash_table, hash_lookup, hash_put)
10082 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10083 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10084 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10085 * image.c (make_image, search_image_cache, lookup_image)
10086 (xpm_put_color_table_h):
10087 * lisp.h (struct Lisp_Hash_Table):
10088 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
10089 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
10090 for hashes and hash indexes, instead of 'unsigned' and 'int'.
10091 * alloc.c (allocate_vectorlike):
10092 Check for overflow in vector size calculations.
10093 * ccl.c (ccl_driver):
10094 Check for overflow when converting EMACS_INT to int.
10095 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10096 need to be updated by these changes.
10097 * fns.c (make_hash_table, maybe_resize_hash_table):
10098 Check for integer overflow with large hash tables.
10099 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10100 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10101 (SXHASH_REDUCE): New macro.
10102 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10103 Use it instead of discarding useful hash info with large hash values.
10104 (sxhash_float): New function.
10105 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10106 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
10107 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10108 Rewrite to use FIXNUM_BITS, as this simplifies things.
10109 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10110 Adjust signatures to match updated version of code.
10111 (consing_since_gc): Now EMACS_INT, since a single hash table can
10112 use more than INT_MAX bytes.
10114 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10116 Make it possible to build with GCC-4.6+ -O2 -flto.
10118 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10120 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10122 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10123 Call minibuffer-inactive-mode.
10125 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
10127 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10128 Update dependencies.
10130 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10132 * data.c (init_data): Remove code for UTS, this system is not
10135 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10137 Don't force ./temacs to start in terminal mode.
10139 * frame.c (make_initial_frame): Initialize faces in all cases, not
10140 only when CANNOT_DUMP is defined.
10141 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10143 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10145 * dispnew.c (add_window_display_history): Use const for the string
10146 pointer. Remove declaration, not needed.
10148 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10150 Use 'inline', not 'INLINE'.
10151 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
10152 * alloc.c, fontset.c (INLINE): Remove.
10153 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10154 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10155 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10156 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10157 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10159 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10161 Make it possible to run ./temacs.
10163 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10164 syms_of_callproc does the same thing. Remove test for
10165 "initialized", do it in the caller.
10166 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10168 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10170 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10171 (read_minibuf): Use get_minibuffer.
10172 (syms_of_minibuf): Use DEFSYM.
10173 (Qmetadata): New var.
10174 * data.c (Qbuffer): Don't make it static.
10175 (syms_of_data): Use DEFSYM.
10177 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10179 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10180 (CCL_CODE_MIN): New macro.
10182 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10184 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10186 * eval.c (Qdebug): Now static.
10187 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10188 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10189 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10191 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10193 * image.c: Various fixes to ImageMagick code comments.
10194 (Fimagemagick_types): Doc fix.
10196 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10198 Minor fixes prompted by GCC 4.6.0 warnings.
10200 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10202 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10203 (x_clipboard_manager_save_all): Move extern decl to ...
10204 * xterm.h: ... here, so that it can be checked for consistency.
10206 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10208 * xselect.c (x_clipboard_manager_save_frame)
10209 (x_clipboard_manager_save_all): New functions.
10210 (Fx_clipboard_manager_save): Lisp function deleted.
10212 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10213 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10215 * xterm.h: Update prototype.
10217 2011-05-28 William Xu <william.xwl@gmail.com>
10219 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10220 exiting (Bug#8239).
10222 2011-05-28 Jim Meyering <meyering@redhat.com>
10224 Avoid a sign-extension bug in crypto_hash_function.
10225 * fns.c (to_uchar): Define.
10226 (crypto_hash_function): Use it to convert some newly-signed
10227 variables to unsigned, to avoid sign-extension bugs. For example,
10228 without this change, (md5 "truc") would evaluate to
10229 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10230 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
10231 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
10233 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10235 Integer overflow fixes.
10237 * dbusbind.c: Serial number integer overflow fixes.
10238 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
10239 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10240 to hold a serial number that is too large for a fixnum.
10241 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10242 Check for serial numbers out of range. Decode any serial number
10243 that was so large that it became a float. (Bug#8722)
10245 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10246 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10247 Use XFASTINT rather than XUINT when numbers are nonnegative.
10248 (xd_append_arg, Fdbus_method_return_internal):
10249 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10250 arguments, check that Lisp number is nonnegative, rather than
10251 silently wrapping negative numbers around. (Bug#8722)
10252 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
10255 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10257 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10259 ccl: Add integer overflow checks.
10260 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10261 (IN_INT_RANGE): New macros.
10262 (ccl_driver): Use them to check for integer overflow when
10263 decoding a CCL program. Many of the new checks are whether XINT (x)
10264 fits in int; it doesn't always, on 64-bit hosts. The new version
10265 doesn't catch all possible integer overflows, but it's an
10266 improvement. (Bug#8719)
10268 * alloc.c (make_event_array): Use XINT, not XUINT.
10269 There's no need for unsigned here.
10271 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10272 This follows up to the 2011-05-06 change that substituted uintptr_t
10273 for EMACS_INT. This case wasn't caught back then.
10275 Rework Fformat to avoid integer overflow issues.
10276 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10277 now (part of C89). Include <verify.h>.
10278 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10279 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10280 (Fformat): Avoid the prepass trying to compute sizes; it was only
10281 approximate and thus did not catch overflow reliably. Instead, walk
10282 through the format just once, formatting and computing sizes as we go,
10283 checking for integer overflow at every step, and allocating a larger
10284 buffer as needed. Keep track separately whether the format is
10285 multibyte. Keep only the most-recently calculated precision, rather
10286 than them all. Record whether each argument has been converted to
10287 string. Use EMACS_INT, not int, for byte and char and arg counts.
10288 Support field widths and precisions larger than INT_MAX. Avoid
10289 sprintf's undefined behavior with conversion specifications such as %#d
10290 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10291 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10292 formatting out-of-range floating point numbers with int
10293 formats. (Bug#8668)
10295 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10297 * data.c: Avoid integer truncation in expressions involving floats.
10298 * data.c: Include <intprops.h>.
10299 (arith_driver): When there's an integer overflow in an expression
10300 involving floating point, convert the integers to floating point
10301 so that the resulting value does not suffer from catastrophic
10302 integer truncation. For example, on a 64-bit host (* 4
10303 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10304 Do not rely on undefined behavior after integer overflow.
10306 merge count_size_as_multibyte, parse_str_to_multibyte
10307 * character.c, character.h (count_size_as_multibyte):
10308 Rename from parse_str_to_multibyte; all uses changed.
10309 Check for integer overflow.
10310 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10311 since it's now a duplicate of the other. This is more of
10312 a character than a buffer op, so better that it's in character.c.
10313 * fns.c, print.c: Adjust to above changes.
10315 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10317 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10319 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10321 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10322 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10323 (x_clipboard_manager_save): Now static.
10324 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10326 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10327 (crypto_hash_function): Now static.
10328 Fix pointer signedness problems. Avoid unnecessary initializations.
10330 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
10332 * termhooks.h (Vselection_alist): Make it terminal-local.
10334 * terminal.c (create_terminal): Initialize it.
10336 * xselect.c: Support for clipboard managers.
10337 (Vselection_alist): Move to termhooks.h as terminal-local var.
10338 (LOCAL_SELECTION): New macro.
10339 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10340 (symbol_to_x_atom): Remove gratuitous arg.
10341 (x_handle_selection_request, lisp_data_to_selection_data)
10342 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
10343 (x_own_selection, x_get_local_selection, x_convert_selection):
10344 New arg, specifying work frame. Use terminal-local Vselection_alist.
10345 (some_frame_on_display): Delete unused function.
10346 (Fx_own_selection_internal, Fx_get_selection_internal)
10347 (Fx_disown_selection_internal, Fx_selection_owner_p)
10348 (Fx_selection_exists_p): New optional frame arg.
10349 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10350 (x_handle_selection_clear): Don't treat other terminals with the
10351 same keyboard specially. Use the terminal-local Vselection_alist.
10352 (x_clear_frame_selections): Use Frun_hook_with_args.
10354 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10356 * xterm.h: Add support for those atoms.
10358 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
10360 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10361 (converted_selections, conversion_fail_tag): New global variables.
10362 (x_selection_request_lisp_error): Free the above.
10363 (x_get_local_selection): Remove unnecessary code.
10364 (x_reply_selection_request): Args changed; handle arbitrary array
10365 of converted selections stored in converted_selections.
10366 Separate the XChangeProperty and SelectionNotify steps.
10367 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10368 (x_convert_selection): New function.
10369 (x_handle_selection_event): Simplify.
10370 (x_get_foreign_selection): Don't ignore incoming requests while
10371 waiting for an answer; this will fail when we implement
10372 SAVE_TARGETS, and seems unnecessary anyway.
10373 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10374 (Vx_sent_selection_functions): Doc fix.
10376 2011-05-26 Leo Liu <sdl.web@gmail.com>
10378 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10380 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10382 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10384 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10385 for fringe update if it has periodic bitmap.
10386 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
10387 and fringe_bitmap_periodic_p.
10389 * fringe.c (get_fringe_bitmap_data): New function.
10390 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10391 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10392 row. Mark glyph row for fringe update if periodicity changed.
10394 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10395 for fringe update unless it has periodic bitmap.
10397 2011-05-25 Kenichi Handa <handa@m17n.org>
10399 * xdisp.c (get_next_display_element): Set correct it->face_id for
10400 a static composition.
10402 2011-05-24 Leo Liu <sdl.web@gmail.com>
10405 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10407 * fns.c (crypto_hash_function, Fsha1): New function.
10408 (Fmd5): Use crypto_hash_function.
10409 (syms_of_fns): Add Ssha1.
10411 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10413 * gnutls.c: Remove unused macros.
10414 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10415 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10416 Remove macros that are defined and never used.
10417 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10419 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10421 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10422 (Fx_get_selection_internal): Minor cleanup.
10423 (Fx_own_selection_internal): Rename arguments for consistency with
10426 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10428 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10430 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10432 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10434 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10436 * dispnew.c (scrolling_window): Don't exclude the case that the
10437 last enabled row in the desired matrix touches the bottom boundary.
10439 2011-05-21 Glenn Morris <rgm@gnu.org>
10441 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
10442 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10443 and add some more files.
10445 2011-05-20 Eli Zaretskii <eliz@gnu.org>
10447 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10448 report_file_error introduced by the change from 2011-05-07.
10450 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10452 * systime.h (Time): Define only if emacs is defined.
10453 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10454 where the include path doesn't have X11/X.h by default. See
10455 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10457 2011-05-20 Kenichi Handa <handa@m17n.org>
10459 * composite.c (find_automatic_composition): Fix previous change.
10461 2011-05-20 Glenn Morris <rgm@gnu.org>
10463 * lisp.mk: New file, split from Makefile.in.
10464 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10465 (shortlisp): Remove.
10466 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10468 2011-05-19 Glenn Morris <rgm@gnu.org>
10470 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10471 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10472 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10473 (lisp): Set the order to that of loadup.el.
10474 (shortlisp): Make it a copy of $lisp.
10475 (SOME_MACHINE_LISP): Remove.
10476 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10477 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10479 2011-05-18 Kenichi Handa <handa@m17n.org>
10481 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10482 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10483 (find_automatic_composition): Mostly rewrite for efficiency.
10485 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
10487 * makefile.w32-in: Update dependencies.
10489 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10491 * menu.c: Include limits.h (fixes the MS-Windows build broken by
10492 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
10494 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
10496 Fix some integer overflow issues, such as string length overflow.
10498 * insdel.c (count_size_as_multibyte): Check for string overflow.
10500 * character.c (lisp_string_width): Check for string overflow.
10501 Use EMACS_INT, not int, for string indexes and lengths; in
10502 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10503 the resulting string length overflows an EMACS_INT; instead,
10504 report a string overflow if no precision given. When checking for
10505 precision exhaustion, use a check that cannot possibly have
10506 integer overflow. (Bug#8675)
10507 * character.h (lisp_string_width): Adjust to new signature.
10509 * alloc.c (string_overflow): New function.
10510 (Fmake_string): Use it. This doesn't change behavior, but saves
10511 a few bytes and will simplify future changes.
10512 * character.c (string_escape_byte8): Likewise.
10513 * lisp.h (string_overflow): New decl.
10515 Fixups, following up to the user-interface timestamp change.
10516 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10517 for UI timestamps, instead of unsigned long.
10518 * msdos.c (mouse_get_pos): Likewise.
10519 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
10520 * w32gui.h (Time): Define by including "systime.h" rather than by
10521 declaring it ourselves. (Bug#8664)
10523 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10524 * image.c (clear_image_cache): Likewise.
10526 * term.c (term_mouse_position): Don't assume time_t wraparound.
10528 Be more systematic about user-interface timestamps.
10529 Before, the code sometimes used 'Time', sometimes 'unsigned long',
10530 and sometimes 'EMACS_UINT', to represent these timestamps.
10531 This change causes it to use 'Time' uniformly, as that's what X uses.
10532 This makes the code easier to follow, and makes it easier to catch
10533 integer overflow bugs such as Bug#8664.
10534 * frame.c (Fmouse_position, Fmouse_pixel_position):
10535 Use Time, not unsigned long, for user-interface timestamps.
10536 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10537 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10538 * keyboard.h (last_event_timestamp): Likewise.
10539 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10540 * menu.h (xmenu_show): Likewise.
10541 * term.c (term_mouse_position): Likewise.
10542 * termhooks.h (struct input_event.timestamp): Likewise.
10543 (struct terminal.mouse_position_hook): Likewise.
10544 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10545 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10546 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10547 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10548 what it was before.
10549 * menu.h, termhooks.h: Include "systime.h", for Time.
10551 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10552 Don't assume that the difference between two unsigned long values
10553 can fit into an integer. At this point, we know button_down_time
10554 <= event->timestamp, so the difference must be nonnegative, so
10555 there's no need to cast the result if double-click-time is
10556 nonnegative, as it should be; check that it's nonnegative, just in
10557 case. This bug is triggered when events are more than 2**31 ms
10558 apart (about 25 days). (Bug#8664)
10560 * xselect.c (last_event_timestamp): Remove duplicate decl.
10561 (x_own_selection): Remove needless cast to unsigned long.
10563 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10564 that always fit in int. Use a sentinel instead of a counter, to
10565 avoid a temp and to allay GCC's concerns about possible int overflow.
10566 * frame.h (struct frame): Use int for menu_bar_items_used
10567 instead of EMACS_INT, since it always fits in int.
10569 * menu.c (grow_menu_items): Check for int overflow.
10571 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10573 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10574 Before, the code was not consistent. These values cannot exceed
10575 2**31 - 1 so there's no need to make them unsigned.
10576 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10577 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10578 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10580 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10582 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10583 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10584 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10585 presumably because the widths might not match.
10587 * window.c (size_window): Avoid needless test at loop start.
10589 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10591 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10593 2011-05-12 Drew Adams <drew.adams@oracle.com>
10595 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10597 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10599 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10600 `width' to `bar_area_x' and `bar_area_width', respectively.
10601 (x_scroll_run): Take account of fringe background extension.
10603 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10604 Rename local vars `left' and `width' to `bar_area_x' and
10605 `bar_area_width', respectively.
10606 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10607 background extension.
10609 2011-05-10 Jim Meyering <meyering@redhat.com>
10611 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10613 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
10615 * image.c (Finit_image_library): Return t for built-in image types,
10616 like pbm and xbm. (Bug#8640)
10618 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10620 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10622 2011-05-07 Eli Zaretskii <eliz@gnu.org>
10624 * w32console.c (Fset_screen_color): Doc fix.
10625 (Fget_screen_color): New function.
10626 (syms_of_ntterm): Defsubr it.
10628 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10629 unlink the temporary file if Fcall_process didn't create it in the
10631 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10632 child process will be redirected to a file specified with `:file'.
10633 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10634 cue to call_process_cleanup not to close that handle.
10636 2011-05-07 Ben Key <bkey76@gmail.com>
10638 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10639 one of two shell specific rules, either bootstrap-temacs-CMD or
10640 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10641 to the previous implementation of the bootstrap-temacs rule.
10642 The bootstrap-temacs-CMD rule is similar to the previous
10643 implementation of the bootstrap-temacs rule except that it
10644 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10647 These changes, along with some changes to nt/configure.bat,
10648 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10649 earlier fix to add support for --cflags and --ldflags options
10650 that include quotes so that it works whether make uses cmd or
10653 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
10655 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10656 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10658 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10659 a string. Handle both cases.
10660 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10661 (Fdbus_register_method): Use Qinvalid_function.
10663 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10665 * makefile.w32-in: Update dependencies.
10666 (LISP_H): Add inttypes.h and stdin.h.
10667 (PROCESS_H): Add unistd.h.
10669 2011-05-06 Eli Zaretskii <eliz@gnu.org>
10671 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10672 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10674 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
10676 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10678 * term.c (vfatal): Remove stray call to va_end.
10679 It's not needed and the C Standard doesn't allow it here anyway.
10681 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10682 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10684 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10687 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10689 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10691 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10693 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10695 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10697 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10698 * charset.c (Fdefine_charset_internal): Don't initialize
10699 charset.code_space[15]. The value was garbage, on hosts with
10700 32-bit int (Bug#8600).
10702 * lread.c (read_integer): Be more consistent with string-to-number.
10703 Use string_to_number to do the actual conversion; this avoids
10704 rounding errors and fixes some other screwups. Without this fix,
10705 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10706 (digit_to_number): Move earlier, for benefit of read_integer.
10707 Return -1 if the digit is out of range for the base, -2 if it is
10708 not a digit in any supported base. (Bug#8602)
10710 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10712 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10713 to match comment at start of function. This also removes a
10714 GCC warning about overflow in a 32+64-bit port.
10716 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10718 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10719 Reported by Stefan Monnier in
10720 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
10721 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10722 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
10724 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10725 (EMACS_UINTPTR): Likewise, with uintptr_t.
10727 * lisp.h: Prefer 64-bit EMACS_INT if available.
10728 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10729 on 32-bit hosts that have 64-bit int, so that they can access
10731 However, temporarily disable this change unless the temporary
10732 symbol WIDE_EMACS_INT is defined.
10734 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10736 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10737 This removes an assumption that EMACS_INT and long are the same
10738 width as pointers. The assumption is true for Emacs porting targets
10739 now, but we want to make other targets possible.
10740 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10741 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10742 In the rest of the code, change types of integers that hold casted
10743 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10744 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10745 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10746 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10747 No need to cast type when ORing.
10748 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10749 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10750 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10751 assume EMACS_INT is the same width as char *.
10752 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10753 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10754 Remove no-longer-needed casts.
10755 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10756 (xg_tool_bar_help_callback, xg_make_tool_item):
10757 Use EMACS_INTPTR to hold an integer
10758 that will be cast to void *; this can avoid a GCC warning
10759 if EMACS_INT is not the same width as void *.
10760 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10761 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10762 (current_message_1, set_message_1):
10763 Use a local to convert to proper width without a cast.
10764 * xmenu.c (dialog_selection_callback): Likewise.
10766 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10767 Also, don't assume VALBITS / RAND_BITS is less than 5,
10768 and don't rely on undefined behavior when shifting a 1 left into
10770 * lisp.h (get_random): Change signature to match.
10772 * lread.c (hash_string): Use size_t, not int, for hash computation.
10773 Normally we prefer signed values; but hashing is special, because
10774 it's better to use unsigned division on hash table sizes so that
10775 the remainder is nonnegative. Also, size_t is the natural width
10776 for hashing into memory. The previous code used 'int', which doesn't
10777 retain enough info to hash well into very large tables.
10778 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10780 * dbusbind.c: Don't possibly lose pointer info when converting.
10781 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10782 Use XPNTR rather than XHASH, so that the high-order bits of
10783 the pointer aren't lost when converting through void *.
10785 * eval.c (Fautoload): Don't double-shift a pointer.
10787 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10789 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10791 * gnutls.c (DEF_GNUTLS_FN):
10792 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10794 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10796 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10799 2011-05-05 Eli Zaretskii <eliz@gnu.org>
10801 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10802 New version that can reserve upto 2GB of heap space.
10804 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
10806 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10808 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10810 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10811 `gnutls_certificate_set_x509_key_file'.
10813 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
10815 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10816 Update dependencies.
10818 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10820 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10821 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10822 Remove unused parameter `fildes'.
10823 * process.c (read_process_output, send_process): Don't pass it.
10825 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10827 Fix previous change: the library cache is defined in w32.c.
10828 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10829 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10831 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10833 Implement dynamic loading of GnuTLS on Windows.
10835 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10836 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10837 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10840 * gnutls.c (Qgnutls_dll): Define.
10841 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10842 (gnutls_*): Declare function pointers.
10843 (init_gnutls_functions): New function to initialize function pointers.
10844 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10845 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10846 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10847 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10848 (emacs_gnutls_write, emacs_gnutls_read)
10849 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10850 (Fgnutls_available_p): New function.
10851 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10852 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10853 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10855 * image.c: Include w32.h.
10856 (Vimage_type_cache): Delete.
10857 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10858 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10859 (w32_delayed_load): Move to w32.c.
10861 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10863 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10864 (w32_delayed_load): Move from image.c. When loading a library, record
10865 its filename in the :loaded-from property of the library id.
10866 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10867 Initialize and staticpro them.
10868 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10870 * process.c: Include lisp.h before w32.h, not after.
10871 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10872 instead of gnutls_record_check_pending.
10874 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10876 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10878 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10879 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10882 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10884 * xterm.c (x_set_frame_alpha): Do not set property on anything
10885 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10887 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10889 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10891 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10893 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10894 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10895 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10896 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10897 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10898 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10899 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10900 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10901 (Qgnutls_bootprop_callbacks_verify): Make static.
10903 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10905 * callproc.c: Indentation fixup.
10907 * sysdep.c (wait_for_termination_1): Make static.
10908 (wait_for_termination, interruptible_wait_for_termination):
10909 Move after wait_for_termination_1.
10911 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10913 * sysdep.c (interruptible_wait_for_termination): New function
10914 which is like wait_for_termination, but allows keyboard
10917 * callproc.c (Fcall_process): Add (:file "file") as an option for
10919 (Fcall_process_region): Ditto.
10921 2011-04-30 Eli Zaretskii <eliz@gnu.org>
10923 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10924 rather than `XVECTOR (FOO)->size'.
10926 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10927 inttypes.h, as a gnulib replacement is used if it not available in
10930 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10932 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10933 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10934 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10936 * coding.c (coding_alloc_by_realloc): Error out if destination
10937 will grow beyond MOST_POSITIVE_FIXNUM.
10938 (decode_coding_emacs_mule): Abort if there isn't enough place in
10939 charbuf for the composition carryover bytes. Reserve an extra
10940 space for up to 2 characters produced in a loop.
10941 (decode_coding_iso_2022): Abort if there isn't enough place in
10942 charbuf for the composition carryover bytes.
10944 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10946 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10947 aborting when %lld or %lll format is passed.
10948 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10949 %llo or %llx format is passed. (Bug#8545)
10951 * window.c (window_scroll_line_based): Use a marker instead of
10952 simple variables to record original value of point. (Bug#7952)
10954 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10955 produced by %s or %c overflows available buffer space. (Bug#8545)
10957 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10959 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
10960 (SIZE_MAX): Move defn after all includes, as they might #define it.
10962 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10964 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10966 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10968 * keyboard.c (Qdelayed_warnings_hook): Define.
10969 (command_loop_1): Run `delayed-warnings-hook'
10970 if Vdelayed_warnings_list is non-nil.
10971 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10972 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10974 2011-04-28 Eli Zaretskii <eliz@gnu.org>
10976 * doprnt.c (doprnt): Don't return value smaller than the buffer
10977 size if the message was truncated. (Bug#8545).
10979 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10981 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10982 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10984 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10986 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10988 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
10990 * makefile.w32-in: Update dependencies.
10992 2011-04-27 Eli Zaretskii <eliz@gnu.org>
10994 Improve `doprnt' and its usage. (Bug#8545)
10995 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10996 `format_end'. Remove support for %l as a conversion specifier.
10997 Don't use xrealloc. Improve diagnostics when the %l size modifier
10998 is used. Update the commentary.
11000 * eval.c (verror): Simplify calculation of size_t.
11002 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11005 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11007 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11010 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11012 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11013 This makes this file independent of the recent pseudovector change.
11015 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
11017 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11019 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
11020 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
11021 Remove unused local.
11022 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
11024 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
11025 GCC 4.6.0 optimizes based on type-based alias analysis.
11026 For example, if b is of type struct buffer * and v of type struct
11027 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11028 != &v->size, and therefore "v->size = 1; b->size = 2; return
11029 v->size;" must therefore return 1. This assumption is incorrect
11030 for Emacs, since it type-puns struct Lisp_Vector * with many other
11031 types. To fix this problem, this patch adds a new type struct
11032 vectorlike_header that documents the constraints on layout of vectors
11033 and pseudovectors, and helps optimizing compilers not get fooled
11034 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11035 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
11036 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11038 (XSETPVECTYPE): Rewrite in terms of new macro.
11039 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11040 This is a bit clearer, and further avoids the possibility of
11041 undesirable aliasing.
11042 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
11043 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
11044 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11045 since Lisp_Subr is a special case (no "next" field).
11046 (ASIZE): Now uses header.size rather than size.
11047 All previous uses of XVECTOR (foo)->size replaced to use this macro,
11048 to avoid the hassle of writing XVECTOR (foo)->header.size.
11049 (struct vectorlike_header): New type.
11050 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11051 object, to help avoid aliasing.
11052 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11053 (SUBRP): Likewise, since Lisp_Subr is a special case.
11054 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11055 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11056 (struct Lisp_Hash_Table): Combine first two members into a single
11057 struct vectorlike_header member. All uses of "size" and "next" members
11058 changed to be "header.size" and "header.next".
11059 * buffer.h (struct buffer): Likewise.
11060 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11061 * frame.h (struct frame): Likewise.
11062 * process.h (struct Lisp_Process): Likewise.
11063 * termhooks.h (struct terminal): Likewise.
11064 * window.c (struct save_window_data, struct saved_window): Likewise.
11065 * window.h (struct window): Likewise.
11066 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11067 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11068 * buffer.c (init_buffer_once): Likewise.
11069 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11071 * process.c (Fformat_network_address): Use local var for size,
11074 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11076 Make the Lisp reader and string-to-float more consistent (Bug#8525)
11077 * data.c (atof): Remove decl; no longer used or needed.
11078 (digit_to_number): Move to lread.c.
11079 (Fstring_to_number): Use new string_to_number function, to be
11080 consistent with how the Lisp reader treats infinities and NaNs.
11081 Do not assume that floating-point numbers represent EMACS_INT
11082 without losing information; this is not true on most 64-bit hosts.
11083 Avoid double-rounding errors, by insisting on integers when
11084 parsing non-base-10 numbers, as the documentation specifies.
11085 * lisp.h (string_to_number): New decl, replacing ...
11086 (isfloat_string): Remove.
11087 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
11088 (read1): Do not accept +. and -. as integers; this
11089 appears to have been a coding error. Similarly, do not accept
11090 strings like +-1e0 as floating point numbers. Do not report
11091 overflow for integer overflows unless the base is not 10 which
11092 means we have no simple and reliable way to continue.
11093 Break out the floating-point parsing into a new
11094 function string_to_number, so that Fstring_to_number parses
11095 floating point numbers consistently with the Lisp reader.
11096 (digit_to_number): Move here from data.c. Make it static inline.
11097 (E_CHAR, EXP_INT): Remove, replacing with ...
11098 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11099 (string_to_number): New function, replacing isfloat_string.
11100 This function checks for valid syntax and produces the resulting
11101 Lisp float number too. Rework it so that string-to-number
11102 no longer mishandles examples like "1.0e+". Use strtoumax,
11103 so that overflow for non-base-10 numbers is reported only when
11104 there's no portable and simple way to convert to floating point.
11106 * textprop.c (set_text_properties_1): Rewrite for clarity,
11107 and to avoid GCC warning about integer overflow.
11109 * intervals.h (struct interval): Use EMACS_INT for members
11110 where EMACS_UINT might cause problems. See
11111 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11112 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11113 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11115 (offset_intervals): Tell GCC not to worry about length overflow
11116 when negating a negative length.
11118 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11119 (overrun_check_free): Likewise.
11121 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11122 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11125 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11126 (gnutls_make_error): Rename local to avoid shadowing.
11127 (gnutls_emacs_global_deinit): ifdef out; not used.
11128 (Fgnutls_boot): Use const for pointer to readonly storage.
11129 Comment out unused local. Fix pointer signedness problems.
11131 * lread.c (openp): Don't stuff size_t into an 'int'.
11132 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11133 about possible signed overflow.
11135 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11136 (GDK_KEY_g): Don't define if already defined.
11137 (xg_prepare_tooltip): Avoid pointer signedness problem.
11138 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11140 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11141 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11143 * xfns.c (Fx_window_property): Simplify a bit,
11144 to make a bit faster and to avoid GCC 4.6.0 warning.
11145 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11147 * fns.c (internal_equal): Don't assume size_t fits in int.
11149 * alloc.c (compact_small_strings): Tighten assertion a little.
11151 Replace pEd with more-general pI, and fix some printf arg casts.
11152 * lisp.h (pI): New macro, generalizing old pEd macro to other
11153 conversion specifiers. For example, use "...%"pI"d..." rather
11154 than "...%"pEd"...".
11155 (pEd): Remove. All uses replaced with similar uses of pI.
11156 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
11157 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11158 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11159 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11160 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11161 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11162 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11164 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11165 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11166 * print.c (safe_debug_print, print_object): Likewise.
11167 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11169 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11170 avoiding the 0 flag, which is not portable.
11171 * process.c (Fmake_network_process): Use pI to avoid cast.
11172 * region-cache.c (pp_cache): Likewise.
11173 * xdisp.c (decode_mode_spec): Likewise.
11174 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11175 behavior on 64-bit hosts with printf arg.
11176 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
11177 (x_stop_queuing_selection_requests): Likewise.
11178 (x_get_window_property): Don't truncate byte count to an 'int'
11181 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11182 here, since it parses constructs like leading '-' and spaces,
11183 which are not wanted; and it overflows with large numbers.
11184 Instead, simply match F[0-9]+, which is what is wanted anyway.
11186 * alloc.c: Remove unportable assumptions about struct layout.
11187 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11188 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11189 (allocate_vectorlike, make_pure_vector): Use the new macros,
11190 plus offsetof, to remove unportable assumptions about struct layout.
11191 These assumptions hold on all porting targets that I know of, but
11192 they are not guaranteed, they're easy to remove, and removing them
11193 makes further changes easier.
11195 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11196 This doesn't fix a bug but makes the code clearer.
11197 (string_overrun_cookie): Now const. Use initializers that
11198 don't formally overflow signed char, to avoid warnings.
11199 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11200 can cause Emacs to crash when string overrun checking is enabled.
11201 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11202 multiple of sizeof (EMACS_INT); it need not be, if
11203 alignof(EMACS_INT) < sizeof (EMACS_INT).
11204 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
11206 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
11208 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11210 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11212 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
11213 supposed to be handshaking. (Bug#8556)
11214 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11216 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
11218 * lisp.h (Qdebug): List symbol.
11219 * eval.c (Qdebug): Restore global linkage.
11220 * keyboard.c (debug-on-event): New variable.
11221 (handle_user_signal): Break into debugger when debug-on-event
11222 matches the current signal symbol.
11224 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11226 * alloc.c (check_sblock, check_string_bytes)
11227 (check_string_free_list): Convert to standard C.
11229 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11231 * w32.c (emacs_gnutls_push): Fix typo.
11233 2011-04-25 Eli Zaretskii <eliz@gnu.org>
11235 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11236 "cast to pointer from integer of different size".
11238 Improve doprnt and its use in verror. (Bug#8545)
11239 * doprnt.c (doprnt): Document the set of format control sequences
11240 supported by the function. Use SAFE_ALLOCA instead of always
11243 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11244 is one byte too soon. Don't use xrealloc; instead xfree and
11247 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11249 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11252 * gnutls.c: Renamed global_initialized to
11253 gnutls_global_initialized. Added internals for the
11254 :verify-hostname-error, :verify-error, and :verify-flags
11255 parameters of `gnutls-boot' and documented those parameters in the
11256 docstring. Start callback support.
11257 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11258 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11259 on error. Return error code.
11260 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11261 (emacs_gnutls_read): Likewise.
11262 (Fgnutls_boot): Return handshake error code.
11263 (emacs_gnutls_handle_error): New function.
11264 (wsaerror_to_errno): Likewise.
11266 * w32.h (emacs_gnutls_pull): Add prototype.
11267 (emacs_gnutls_push): Likewise.
11269 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11270 (emacs_gnutls_push): Likewise.
11272 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11274 * process.c (wait_reading_process_output): Check if GnuTLS
11275 buffered some data internally if no FDs are set for TLS
11278 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11279 (LIBS): Link to USER_LIBS.
11280 ($(BLD)/gnutls.$(0)): New target.
11282 2011-04-24 Eli Zaretskii <eliz@gnu.org>
11284 * xdisp.c (handle_single_display_spec): Rename the
11285 display_replaced_before_p argument into display_replaced_p, to
11286 make it consistent with the commentary. Fix typos in the
11289 * textprop.c (syms_of_textprop): Remove dead code.
11290 (copy_text_properties): Delete obsolete commentary about an
11291 interface that was deleted long ago. Fix typos in the description
11294 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11295 to changes in oldXMenu/XMenu.h from 2011-04-16.
11296 <menu_help_message, prev_menu_help_message>: Constify.
11297 (IT_menu_make_room): menu->help_text is now `const char **';
11300 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11301 to changes in oldXMenu/XMenu.h from 2011-04-16.
11302 (struct XMenu): Declare `help_text' `const char **'.
11304 * xfaces.c <Qunspecified>: Make extern again.
11306 * syntax.c: Include sys/types.h before including regex.h, as
11309 * doc.c (get_doc_string): Improve the format passed to `error'.
11311 * doprnt.c (doprnt): Improve commentary.
11313 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11315 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11318 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11319 changes in globals.h immediately force recompilation.
11320 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11321 $(CURDIR)/s/ms-w32.h.
11322 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
11324 * character.c (Fchar_direction): Function deleted.
11325 (syms_of_character): Don't defsubr it.
11326 <char-direction-table>: Deleted.
11328 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11330 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11331 * doprnt.c: Include limits.h.
11332 (SIZE_MAX): New macro.
11333 (doprnt): Return a size_t value. 2nd arg is now size_t.
11334 Many local variables are now size_t instead of int or unsigned.
11335 Improve overflow protection. Support `l' modifier for integer
11336 conversions. Support %l conversion. Don't assume an EMACS_INT
11337 argument for integer conversions and for %c.
11339 * lisp.h (doprnt): Restore prototype.
11341 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11342 $(SRC)/character.h.
11344 * Makefile.in (base_obj): Add back doprnt.o.
11346 * deps.mk (doprnt.o): Add back prerequisites.
11347 (callint.o): Depend on character.h.
11349 * eval.c (internal_lisp_condition_case): Include the handler
11350 representation in the error message.
11351 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11352 when breaking from the loop.
11354 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11356 * callint.c (Fcall_interactively): When displaying error message
11357 about invalid control letter, pass the character's codepoint, not
11358 a pointer to its multibyte form. Improve display of the character
11359 in octal and display also its hex code.
11361 * character.c (char_string): Use %x to display the (unsigned)
11362 codepoint of an invalid character, to avoid displaying a bogus
11365 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11366 `error', not SYMBOL_NAME itself.
11368 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11369 character arguments to `error'.
11371 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11372 to `error' in error message about FINAL_CHAR argument. Make sure
11373 FINAL_CHAR is a character, and use %c when it is passed as
11374 argument to `error'.
11376 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11378 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11380 * w32.c: Include <time.h>.
11381 (sys_localtime): New function.
11383 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
11385 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11387 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
11389 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
11391 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11392 zombies (Bug#8467).
11394 2011-04-19 Eli Zaretskii <eliz@gnu.org>
11396 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11397 gl_state.e_property when gl_state.object is Qt.
11399 * insdel.c (make_gap_larger): Remove limitation of buffer size
11402 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
11404 * xdisp.c (lookup_glyphless_char_display)
11405 (produce_glyphless_glyph): Handle cons cell entry in
11406 glyphless-char-display.
11407 (Vglyphless_char_display): Document it.
11409 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11410 glyphless-char-display.
11412 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
11414 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11416 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11418 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11419 definition for no-X builds.
11421 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
11423 Static checks with GCC 4.6.0 and non-default toolkits.
11425 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11427 * process.c (keyboard_bit_set): Define only if SIGIO.
11428 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11429 (send_process): Repair possible setjmp clobbering.
11431 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11433 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11435 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11437 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11438 Define only if needed.
11440 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11441 by pacifying GCC about it. Maybe it's time to retire it?
11442 * xfaces.c (USG, __TIMEVAL__): Likewise.
11444 * dispextern.h (struct redisplay_interface): Rename param
11445 to avoid shadowing.
11446 * termhooks.h (struct terminal): Likewise.
11447 * xterm.c (xembed_send_message): Likewise.
11449 * insdel.c (make_gap_smaller): Define only if
11450 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11452 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11455 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11456 so that we aren't warned about unused symbols.
11458 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11460 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
11462 * xfns.c (x_real_positions): Mark locals as initialized.
11464 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11466 * xterm.c: Fix problems found by static analysis with other toolkits.
11467 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
11468 (x_dispatch_event): Declare static if USE_GTK, and
11469 define if USE_GTK || USE_X_TOOLKIT.
11470 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
11471 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
11472 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11473 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
11475 * xmenu.c (menu_help_callback): Pointer type fixes.
11476 Use const pointers when pointing at readonly data. Avoid pointer
11477 signedness clashes.
11478 (FALSE): Remove unused macro.
11479 (update_frame_menubar): Remove unused decl.
11481 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11483 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11484 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11485 (single_menu_item): Rename local to avoid shadowing.
11487 * keyboard.c (make_lispy_event): Remove unused local var.
11489 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11490 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11492 * bitmaps: Change bitmaps from unsigned char back to the X11
11493 compatible char. Avoid the old compiler warnings about
11494 out-of-range initializers by using, for example, '\xab' rather
11497 * xgselect.c (xgselect_initialize): Check vs interface
11498 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11500 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11502 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11503 to read-only memory.
11505 * fns.c (vector): Remove; this old hack is no longer needed.
11507 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
11509 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
11511 * xrdb.c (x_load_resources): Omit unused local.
11513 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
11514 (x_window): Rename locals to avoid shadowing.
11515 (USG): Use the kludged USG macro, to pacify gcc.
11517 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
11518 (x_term_init): Remove local to avoid shadowing.
11520 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
11522 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11523 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11525 2011-04-16 Eli Zaretskii <eliz@gnu.org>
11527 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11529 Fix regex.c, syntax.c and friends for buffers > 2GB.
11530 * syntax.h (struct gl_state_s): Declare character position members
11533 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11535 * textprop.c (verify_interval_modification, interval_of):
11536 Declare arguments EMACS_INT.
11538 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11541 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11543 * indent.c (Fvertical_motion): Local variable it_start is now
11546 * regex.c (re_match, re_match_2, re_match_2_internal)
11547 (bcmp_translate, regcomp, regexec, print_double_string)
11548 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11549 (re_compile_pattern, re_exec): Declare arguments and local
11550 variables `size_t' and `ssize_t' and return values `regoff_t', as
11552 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11553 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11554 <compile_stack_type>: `size' and `avail' are now `size_t'.
11556 * regex.h <regoff_t>: Use ssize_t, not int.
11557 (re_search, re_search_2, re_match, re_match_2): Arguments that
11558 specify buffer/string position and length are now ssize_t and
11559 size_t. Return type is regoff_t.
11561 2011-04-16 Ben Key <bkey76@gmail.com>
11563 * nsfont.m: Fixed bugs in ns_get_family and
11564 ns_descriptor_to_entity that were caused by using free to
11565 deallocate memory blocks that were allocated by xmalloc (via
11566 xstrdup). This caused Emacs to crash when compiled with
11567 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11568 --enable-checking=xmallocoverrun). xfree is now used to
11569 deallocate these memory blocks.
11571 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
11573 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11575 emacs_write: Accept and return EMACS_INT for sizes.
11576 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11578 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11579 Accept and return EMACS_INT.
11580 (emacs_gnutls_write): Return the number of bytes written on
11582 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
11583 (emacs_read, emacs_write): Remove check for negative size, as the
11584 Emacs source code has been audited now.
11585 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11586 (emacs_read, emacs_write): Use it.
11587 * process.c (send_process): Adjust to the new signatures of
11588 emacs_write and emacs_gnutls_write. Do not attempt to store
11589 a byte offset into an 'int'; it might overflow.
11590 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
11592 * sound.c: Don't assume sizes fit in 'int'.
11593 (struct sound_device.period_size, alsa_period_size):
11594 Return EMACS_INT, not int.
11595 (struct sound_device.write, vox_write, alsa_write):
11596 Accept EMACS_INT, not int.
11597 (wav_play, au_play): Use EMACS_INT to store sizes and to
11598 record read return values.
11600 2011-04-15 Ben Key <bkey76@gmail.com>
11602 * keyboard.c (Qundefined): Don't declare static since it is used
11604 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11605 static since they are used in nsfont.m.
11607 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11609 * process.c (Qprocessp): Don't declare static.
11610 * lisp.h (Qprocessp): Declare again.
11612 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
11614 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11616 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11618 Improve C-level modularity by making more things 'static'.
11620 Don't publish debugger-only interfaces to other modules.
11621 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11622 (verify_bytepos, count_markers): Move decls to the only modules
11624 * region-cache.h (pp_cache): Likewise.
11625 * window.h (check_all_windows): Likewise.
11626 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11628 * sysdep.c (croak): Now static, if
11629 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11630 * syssignal.h (croak): Declare only if not static.
11632 * alloc.c (refill_memory_reserve): Now static if
11633 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11634 * lisp.h (refill_memory_reserve): Declare only if not static.
11636 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11637 Define only if USE_LUCID.
11639 * xrdb.c (x_customization_string, x_rm_string): Now static.
11641 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11642 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11644 * xdisp.c (draw_row_with_mouse_face): Now static.
11645 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11647 * window.h (check_all_windows): Mark externally visible.
11649 * window.c (window_deletion_count): Now static.
11651 * undo.c: Make symbols static if they're not exported.
11652 (last_undo_buffer, last_boundary_position, pending_boundary):
11655 * textprop.c (interval_insert_behind_hooks): Now static.
11656 (interval_insert_in_front_hooks): Likewise.
11658 * term.c: Make symbols static if they're not exported.
11659 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11660 (max_frame_lines, tty_set_terminal_modes):
11661 (tty_reset_terminal_modes, tty_turn_off_highlight):
11662 (get_tty_terminal): Now static.
11663 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11664 * termhooks.h (term_mouse_moveto): Do not declare if
11665 HAVE_WINDOW_SYSTEM.
11666 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11667 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11669 * sysdep.c: Make symbols static if they're not exported.
11670 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11672 (sigprocmask_set, full_mask): Remove; unused.
11673 (wait_debugging): Mark as visible.
11674 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11675 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11677 * syntax.c (syntax_temp): Define only if !__GNUC__.
11679 * sound.c (current_sound_device, current_sound): Now static.
11681 * search.c (searchbufs, searchbuf_head): Now static.
11683 * scroll.c (scroll_cost): Remove; unused.
11684 * dispextern.h (scroll_cost): Remove decl.
11686 * region-cache.h (pp_cache): Mark as externally visible.
11688 * process.c: Make symbols static if they're not exported.
11689 (process_tick, update_tick, create_process, chan_process):
11690 (Vprocess_alist, proc_buffered_char, datagram_access):
11691 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11692 (deactivate_process): Mark defn as static, as well as decl.
11693 * lisp.h (create_process): Remove decl.
11694 * process.h (chan_process, Vprocess_alist): Remove decls.
11696 * print.c: Make symbols static if they're not exported.
11697 (print_depth, new_backquote_output, being_printed, print_buffer):
11698 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11699 (print_interval, print_number_index, initial_stderr_stream):
11701 * lisp.h (Fprinc): Remove decl.
11702 (debug_output_compilation_hack): Mark as externally visible.
11704 * sysdep.c (croak): Move decl from here to syssignal.h.
11705 * syssignal.h (croak): Put it here, so the API can be checked when
11706 'croak' is called from dissociate_if_controlling_tty.
11708 * minibuf.c: Make symbols static if they're not exported.
11709 (minibuf_save_list, choose_minibuf_frame): Now static.
11710 * lisp.h (choose_minibuf_frame): Remove decl.
11712 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11714 * lread.c: Make symbols static if they're not exported.
11715 (read_objects, initial_obarray, oblookup_last_bucket_number):
11717 (make_symbol): Remove; unused.
11718 * lisp.h (initial_obarray, make_symbol): Remove decls.
11720 * keyboard.c: Make symbols static if they're not exported.
11721 (single_kboard, recent_keys_index, total_keys, recent_keys):
11722 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11723 (this_single_command_key_start, echoing, last_auto_save):
11724 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11725 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11726 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11727 (Vlispy_mouse_stem, double_click_count):
11729 (force_auto_save_soon): Define only if SIGDANGER.
11730 (ignore_mouse_drag_p): Now static if
11731 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11732 (print_help): Remove; unused.
11733 (stop_character, last_timer_event): Mark as externally visible.
11734 * keyboard.h (ignore_mouse_drag_p): Declare only if
11735 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11736 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11737 * lisp.h (echoing): Remove decl.
11738 (force_auto_save_soon): Declare only if SIGDANGER.
11739 * xdisp.c (redisplay_window): Simplify code, to make it more
11740 obvious that ignore_mouse_drag_p is not accessed if !defined
11741 USE_GTK && !defined HAVE_NS.
11743 * intervals.c: Make symbols static if they're not exported.
11744 (merge_properties_sticky, merge_interval_right, delete_interval):
11746 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11748 * insdel.c: Make symbols static if they're not exported.
11749 However, leave prepare_to_modify_buffer alone. It's never
11750 called from outside this function, but that appears to be a bug.
11751 (combine_after_change_list, combine_after_change_buffer):
11752 (adjust_after_replace, signal_before_change): Now static.
11753 (adjust_after_replace_noundo): Remove; unused.
11754 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
11755 (signal_before_change): Remove decls.
11757 * indent.c (val_compute_motion, val_vmotion): Now static.
11759 * image.c: Make symbols static if they're not exported.
11760 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11762 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11763 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11765 * fringe.c (standard_bitmaps): Now static.
11766 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11768 * frame.c: Make symbols static if they're not exported.
11769 (x_report_frame_params, make_terminal_frame): Now static.
11770 (get_frame_param): Now static, unless HAVE_NS.
11771 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11772 (x_get_resource_string): Remove; not used.
11773 * frame.h (make_terminal_frame, x_report_frame_params):
11774 (x_get_resource_string); Remove decls.
11775 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11776 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11778 * font.c, fontset.c: Make symbols static if they're not exported.
11779 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11780 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11781 * font.c (font_close_object): Now static.
11782 * font.h (font_close_object): Remove.
11783 * fontset.c (FONTSET_OBJLIST): Remove.
11784 (free_realized_fontset) #if-0 the body, which does nothing.
11785 (face_suitable_for_char_p): #if-0, as it's never called.
11786 * fontset.h (face_suitable_for_char_p): Remove decl.
11787 * xfaces.c (face_at_string_position):
11788 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
11789 since 0 is always ASCII.
11791 * fns.c (weak_hash_tables): Now static.
11793 * fileio.c: Make symbols static if they're not exported.
11794 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11795 (Vwrite_region_annotation_buffers): Now static.
11797 * eval.c: Make symbols static if they're not exported.
11798 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11799 * lisp.h (backtrace_list): Remove decl.
11801 * emacs.c: Make symbols static if they're not exported.
11802 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11803 (fatal_error_code, fatal_error_signal_hook, standard_args):
11805 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11806 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11807 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11808 * lisp.h (fatal_error_signal_hook): Remove decl.
11809 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11811 * editfns.c: Move a (normally-unused) function to its only use.
11812 * editfns.c, lisp.h (get_operating_system_release): Remove.
11813 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11814 worth the hassle of breaking this out.
11816 * xterm.c: Make symbols static if they're not exported.
11817 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11818 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11819 (x_destroy_window, x_delete_display):
11821 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11822 (x_mouse_leave): Remove; unused.
11823 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11824 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11825 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11827 (x_mouse_leave): Declare only if WINDOWSNT.
11828 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11829 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11832 * ftxfont.c: Make symbols static if they're not exported.
11833 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11835 * font.h (ftxfont_driver): Likewise.
11837 * xfns.c: Make symbols static if they're not exported.
11838 (x_last_font_name, x_display_info_for_name):
11839 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11840 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11841 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11842 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11843 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11844 (last_show_tip_args): Now static.
11845 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11846 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11847 (x_screen_planes): Remove; unused.
11848 * dispextern.h (x_screen_planes): Remove decl.
11850 * dispnew.c: Make symbols static if they're not exported.
11851 * dispextern.h (redraw_garbaged_frames, scrolling):
11852 (increment_row_positions): Remove.
11853 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11854 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11856 (redraw_garbaged_frames): Remove; unused.
11858 * xfaces.c: Make symbols static if they're not exported.
11859 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11861 * xterm.h (defined_color): Remove decls.
11862 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11863 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11864 (menu_face_changed_default, defined_color, free_realized_face):
11865 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11866 (ascii_face_of_lisp_face): Remove; unused.
11868 * xdisp.c: Make symbols static if they're not exported.
11869 * dispextern.h (scratch_glyph_row, window_box_edges):
11870 (glyph_to_pixel_coords, set_cursor_from_row):
11871 (get_next_display_element, set_iterator_to_next):
11872 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11873 (show_mouse_face): Remove decls
11874 * frame.h (message_buf_print): Likewise.
11875 * lisp.h (pop_message, set_message, check_point_in_composition):
11877 * xterm.h (set_vertical_scroll_bar): Likewise.
11878 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11879 (message_buf_print, scratch_glyph_row, displayed_buffer):
11880 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11881 (get_next_display_element, show_mouse_face, window_box_edges):
11882 (frame_to_window_pixel_xy, check_point_in_composition):
11883 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11884 (glyph_to_pixel_coords): Remove; unused.
11886 * dired.c (file_name_completion): Now static.
11888 * dbusbind.c (xd_in_read_queued_messages): Now static.
11890 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11891 * data.c (circular_list_error): Remove.
11893 * commands.h (last_point_position, last_point_position_buffer):
11894 (last_point_position_window): Remove decls.
11895 * keyboard.c: Make these variables static.
11897 * coding.h (coding, code_convert_region, encode_coding_gap):
11899 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11900 (iso_code_class, detect_coding, code_convert_region): Now static.
11901 (encode_coding_gap): Remove; unused.
11903 * chartab.c (chartab_chars, chartab_bits): Now static.
11905 * charset.h (charset_iso_8859_1): Remove decl.
11906 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11909 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11910 * ccl.c (Vccl_program_table): Now static.
11911 (check_ccl_update): Remove; unused.
11913 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11914 * category.h: ... from here.
11915 * category.c (check_category_table, set_category_set): Now static.
11917 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11918 * lisp.h: Remove these decls.
11920 * buffer.c (buffer_count): Remove unused var.
11922 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11923 so that it's not optimized away.
11924 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11925 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11926 exported only to the debugger.
11928 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
11929 * atimer.h (run_all_atimers): Remove; not exported.
11931 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11932 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11933 was inaccessible from Lisp.
11934 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11935 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11937 alloc.c: Import and export fewer symbols, and remove unused items.
11938 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11940 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11941 it's not optimized away by whole-program optimization.
11942 (message_enable_multibyte, free_misc): Remove.
11943 (catchlist, handlerlist, mark_backtrace):
11944 Declare only if BYTE_MARK_STACK.
11945 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11946 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11947 (message_enable_multibyte): Remove decl.
11948 (free_misc, interval_free_list, float_block, float_block_index):
11949 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11950 (cons_free_list, last_marked_index):
11952 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11953 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11954 (mark_backtrace): Define only if BYTE_MARK_STACK.
11955 * xdisp.c (message_enable_multibyte): Now static.
11957 Declare Lisp_Object Q* variables to be 'static' if not exported.
11958 This makes it easier for human readers (and static analyzers)
11959 to see whether these variables are used from other modules.
11960 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11961 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11962 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11963 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11964 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11965 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11966 * xmenu.c, xselect.c:
11967 Declare Q* vars static if they are not used in other modules.
11968 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11969 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11970 Remove decls of unexported vars.
11971 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11973 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11975 Make Emacs functions such as Fatom 'static' by default.
11976 This makes it easier for human readers (and static analyzers)
11977 to see whether these functions can be called from other modules.
11978 DEFUN now defines a static function. To make the function external
11979 so that it can be used in other C modules, use the new macro DEFUE.
11980 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11981 (Finit_image_library):
11982 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11983 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11984 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11985 Remove decls, since these functions are now static.
11986 (Funintern, Fget_internal_run_time): New decls, since these functions
11987 were already external.
11989 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11990 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11991 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11992 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11993 * keyboard.c, keymap.c, lread.c:
11994 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11995 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11996 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11997 Mark functions with DEFUE instead of DEFUN,
11998 if they are used in other modules.
11999 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12000 decls for now-static functions.
12001 * buffer.h (Fdelete_overlay): Remove decl.
12002 * callproc.c (Fgetenv_internal): Mark as internal.
12003 * composite.c (Fremove_list_of_text_properties): Remove decl.
12004 (Fcomposition_get_gstring): New forward static decl.
12005 * composite.h (Fcomposite_get_gstring): Remove decl.
12006 * dired.c (Ffile_attributes): New forward static decl.
12007 * doc.c (Fdocumntation_property): New forward static decl.
12008 * eval.c (Ffetch_bytecode): New forward static decl.
12009 (Funintern): Remove extern decl; now in .h file where it belongs.
12010 * fileio.c (Fmake_symbolic_link): New forward static decl.
12011 * image.c (Finit_image_library): New forward static decl.
12012 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12013 * intervals.h (Fprevious_property_change):
12014 (Fremove_list_of_text_properties): Remove decls.
12015 * keyboard.c (Fthis_command_keys): Remove decl.
12016 (Fcommand_execute): New forward static decl.
12017 * keymap.c (Flookup_key): New forward static decl.
12018 (Fcopy_keymap): Now static.
12019 * keymap.h (Flookup_key): Remove decl.
12020 * process.c (Fget_process): New forward static decl.
12021 (Fprocess_datagram_address): Mark as internal.
12022 * syntax.c (Fsyntax_table_p): New forward static decl.
12023 (skip_chars): Remove duplicate decl.
12024 * textprop.c (Fprevious_property_change): New forward static decl.
12025 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12027 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12028 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12030 * editfns.c (Fformat): Remove unreachable code.
12032 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12034 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12037 2011-04-13 Eli Zaretskii <eliz@gnu.org>
12039 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12040 when at ZV. (Bug#8487)
12042 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12044 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12046 * keyboard.c (parse_tool_bar_item): Likewise.
12047 * sound.c (sound_cleanup, alsa_close): Likewise.
12048 * termcap.c (tgetent): Likewise.
12049 * xfns.c (x_default_font_parameter): Likewise.
12050 * xsettings.c (read_and_apply_settings): Likewise.
12052 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12053 (overrun_check_free): Protoize.
12055 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12057 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12058 since callers should never pass a negative size.
12059 Change the signature to match that of plain 'read' and 'write'; see
12060 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12061 * lisp.h: Update prototypes of emacs_write and emacs_read.
12063 2011-04-11 Eli Zaretskii <eliz@gnu.org>
12065 * xdisp.c (redisplay_window): Don't try to determine the character
12066 position of the scroll margin if the window start point w->startp
12067 is outside the buffer's accessible region. (Bug#8468)
12069 2011-04-10 Eli Zaretskii <eliz@gnu.org>
12071 Fix write-region and its subroutines for buffers > 2GB.
12072 * fileio.c (a_write, e_write): Modify declaration of arguments and
12073 local variables to support buffers larger than 2GB.
12074 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12076 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12077 argument, local variables, and return value.
12079 * lisp.h: Update prototypes of emacs_write and emacs_read.
12081 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12083 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
12085 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12087 Fix more problems found by GCC 4.6.0's static checks.
12089 * xdisp.c (vmessage): Use a better test for character truncation.
12091 * charset.c (load_charset_map): <, not <=, for optimization,
12092 and to avoid potential problems with integer overflow.
12093 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
12094 * casetab.c (set_identity, shuffle): Likewise.
12095 * editfns.c (Fformat): Likewise.
12096 * syntax.c (skip_chars): Likewise.
12098 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12099 This also lets GCC 4.6.0 generate slightly better loop code.
12101 * callint.c (Fcall_interactively): <, not <=, for optimization.
12102 (Fcall_interactively): Count the number of arguments produced,
12103 not the number of arguments given. This is simpler and lets GCC
12104 4.6.0 generate slightly better code.
12106 * ftfont.c: Distingish more carefully between FcChar8 and char.
12107 The previous code passed unsigned char * to a functions like
12108 strlen and xstrcasecmp that expect char *, which does not
12109 conform to the C standard.
12110 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12111 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12112 char * when the C standard requires it.
12114 * keyboard.c (read_char): Remove unused var.
12116 * eval.c: Port to Windows vsnprintf (Bug#8435).
12117 Include <limits.h>.
12118 (SIZE_MAX): Define if the headers do not.
12119 (verror): Do not give up if vsnprintf returns a negative count.
12120 Instead, grow the buffer. This ports to Windows vsnprintf, which
12121 does not conform to C99. Problem reported by Eli Zaretskii.
12122 Also, simplify the allocation scheme, by avoiding the need for
12123 calling realloc, and removing the ALLOCATED variable.
12125 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12127 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12128 But keep the doprint source code for now, as we might revamp it
12129 and use it again (Bug#8435).
12130 * lisp.h (doprnt): Remove.
12131 * Makefile.in (base_obj): Remove doprnt.o.
12132 * deps.mk (doprnt.o): Remove.
12134 error: Print 32- and 64-bit integers portably (Bug#8435).
12135 Without this change, on typical 64-bit hosts error ("...%d...", N)
12136 was used to print both 32- and 64-bit integers N, which relied on
12137 undefined behavior.
12138 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
12139 * lisp.h (error, verror): Mark as printf-like functions.
12140 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12141 Report overflow in size calculations when allocating printf buffer.
12142 Do not truncate output string at its first null byte.
12143 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12144 Truncate the output at a character boundary, since vsnprintf does not
12146 * charset.c (check_iso_charset_parameter): Convert internal
12147 character to string before calling 'error', since %c now has the
12149 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12150 overflow when computing char to be passed to 'error'. Do not
12151 pass Lisp_Object to 'error'; pass the integer instead.
12152 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12153 formatted with plain %d.
12155 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12157 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12159 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12161 * xterm.c (x_catch_errors): Remove duplicate declaration.
12163 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12165 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12167 2011-04-10 Jim Meyering <meyering@redhat.com>
12169 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12170 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12171 return ssize_t not "int", and use size_t as the buffer length.
12172 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12173 * gnutls.h: Update declarations.
12174 * process.c (read_process_output): Use ssize_t, to match.
12175 (send_process): Likewise.
12177 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12179 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12181 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12183 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12184 Use unsigned char, to match FcChar8 type definition.
12186 * xterm.c (handle_one_xevent):
12187 * xmenu.c (create_and_show_popup_menu):
12188 * xselect.c (x_decline_selection_request)
12189 (x_reply_selection_request): Avoid type-punned deref of X events.
12191 2011-04-09 Eli Zaretskii <eliz@gnu.org>
12193 Fix some uses of `int' instead of EMACS_INT.
12194 * search.c (string_match_1, fast_string_match)
12195 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12196 (scan_buffer, find_next_newline_no_quit)
12197 (find_before_next_newline, search_command, Freplace_match)
12198 (Fmatch_data): Make some `int' variables be EMACS_INT.
12200 * xdisp.c (display_count_lines): 3rd argument and return value now
12201 EMACS_INT. All callers changed.
12202 (pint2hrstr): Last argument is now EMACS_INT.
12204 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12205 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12206 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12207 (decode_coding_utf_16, decode_coding_emacs_mule)
12208 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12209 (decode_coding_ccl, decode_coding_charset)
12210 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12211 (decode_coding_iso_2022, decode_coding_emacs_mule)
12212 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12213 <char_offset, last_offset>: Declare EMACS_INT.
12214 (encode_coding_utf_8, encode_coding_utf_16)
12215 (encode_coding_emacs_mule, encode_invocation_designation)
12216 (encode_designation_at_bol, encode_coding_iso_2022)
12217 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12218 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12220 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12221 (encode_invocation_designation): Last argument P_NCHARS is now
12223 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12224 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12226 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12229 * ccl.c (Fccl_execute_on_string): Declare some variables
12232 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
12234 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12236 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12238 * process.c (Fformat_network_address): Doc fix.
12240 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12242 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
12244 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
12246 * keyboard.c (read_char): Call Lisp function help-form-show,
12247 instead of using internal_with_output_to_temp_buffer.
12248 (Qhelp_form_show): New var.
12249 (syms_of_keyboard): Use DEFSYM macro.
12251 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12253 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12255 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
12257 * process.c (Flist_processes): Remove to Lisp.
12258 (list_processes_1): Delete.
12260 2011-04-06 Eli Zaretskii <eliz@gnu.org>
12262 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12264 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12266 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
12268 Fix more problems found by GCC 4.6.0's static checks.
12270 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12272 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12274 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
12276 * xdisp.c (vmessage): Mark as a printf-like function.
12278 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12280 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12282 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12283 printf-like functions.
12284 (tiff_load): Add casts to remove these marks before passing them
12285 to system-supplied API.
12287 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12289 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12290 This avoids several warnings with gcc -Wstrict-overflow.
12291 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12292 directly, rather than having caller test rule sign. This avoids
12293 some unnecessary tests.
12294 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12295 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12296 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
12298 * xfont.c (xfont_text_extents): Remove var that was set but not used.
12299 (xfont_open): Avoid unnecessary tests.
12301 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12303 * composite.h, composite.c (composition_gstring_put_cache):
12304 Use EMACS_INT, not int, for length.
12306 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12307 breaking out part of COMPOSITION_DECODE_RULE.
12308 (COMPOSITION_DECODE_RULE): Use it.
12309 * composite.c (get_composition_id): Remove unused local vars,
12310 by using the new macro.
12312 * textprop.c (set_text_properties_1): Change while to do-while,
12313 since the condition is always true at first.
12315 * intervals.c (graft_intervals_into_buffer): Mark var as used.
12316 (interval_deletion_adjustment): Return unsigned value.
12319 * process.c (list_processes_1, create_pty, read_process_output):
12320 (exec_sentinel): Remove vars that were set but not used.
12321 (create_pty): Remove unnecessary "volatile"s.
12322 (Fnetwork_interface_info): Avoid possibility of int overflow.
12323 (read_process_output): Do adaptive read buffering even if carryover.
12324 (read_process_output): Simplify nbytes computation if buffered.
12326 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12328 * syntax.c (scan_words): Remove var that was set but not used.
12329 (update_syntax_table): Use unsigned instead of int.
12331 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
12332 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
12333 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
12335 * print.c (print_error_message): Avoid int overflow.
12337 * font.c (font_list_entities): Redo for clarity,
12338 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12340 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
12341 (font_score): Avoid potential overflow in diff calculation.
12343 * fns.c (substring_both): Remove var that is set but not used.
12344 (sxhash): Redo loop for clarity and to avoid wraparound warning.
12346 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12348 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12349 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12350 can always succeed if overflow has undefined behavior.
12352 * search.c (boyer_moore, wordify): Remove vars set but not used.
12353 (wordify): Omit three unnecessary tests.
12355 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12356 All callers changed. This avoids the need for an unused var.
12358 * casefiddle.c (casify_region): Remove var that is set but not used.
12360 * dired.c (file_name_completion): Remove var that is set but not used.
12362 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12364 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
12365 (Finsert_file_contents): Remove unnecessary code checking fd.
12367 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12368 Check for integer overflow on size calculations.
12370 * buffer.c (Fprevious_overlay_change): Remove var that is set
12373 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12374 Remove vars that are set but not used.
12375 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
12376 (timer_check_2): Mark vars as initialized.
12378 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12380 * image.c (lookup_image): Remove var that is set but not used.
12381 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
12383 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12384 that are set but not used.
12386 * xfns.c (make_invisible_cursor): Don't return garbage
12387 if XCreateBitmapFromData fails (Bug#8410).
12389 * xselect.c (x_get_local_selection, x_handle_property_notify):
12390 Remove vars that are set but not used.
12392 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
12393 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
12395 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12396 Remove var that is set but not used.
12397 (scroll_bar_windows_size): Now size_t, not int.
12398 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12399 Check for overflow.
12401 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12402 (map_tty_color) [!defined MSDOS]: Likewise.
12404 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12406 * coding.c: Remove vars that are set but not used.
12407 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12408 All callers changed.
12409 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12410 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12411 (decode_coding_charset): Remove vars that are set but not used.
12413 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12414 that is set but not used.
12416 * print.c (print_object): Remove var that is set but not used.
12418 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
12419 The gnulib version avoids calling malloc in the usual case,
12420 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12421 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12422 * filelock.c (current_lock_owner): Likewise.
12423 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12424 * sysdep.c: Include allocator.h, careadlinkat.h.
12425 (emacs_no_realloc_allocator): New static constant.
12426 (emacs_readlink): New function.
12427 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12428 ../lib/careadlinkat.h.
12430 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12432 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12433 first non-nil return value).
12435 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12437 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12438 if not defined (Bug#8403).
12440 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12442 * xdisp.c (display_count_lines): Remove parameter `start',
12443 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12444 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12445 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12446 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12447 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12448 and thereabouts. All callers changed.
12449 (get_per_char_metric): Remove parameter `f', unused since
12450 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12452 2011-04-02 Jim Meyering <meyering@redhat.com>
12454 do not dereference NULL upon failed strdup
12455 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12456 (ns_get_family): Likewise.
12458 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12460 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12462 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12464 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12467 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12469 Add lexical binding.
12471 * window.c (Ftemp_output_buffer_show): New fun.
12472 (Fsave_window_excursion):
12473 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12475 * lread.c (lisp_file_lexically_bound_p): New function.
12476 (Fload): Bind Qlexical_binding.
12477 (readevalloop): Remove `evalfun' arg.
12478 Bind Qinternal_interpreter_environment.
12479 (Feval_buffer): Bind Qlexical_binding.
12480 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12482 (syms_of_lread): Declare `lexical-binding'.
12484 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12486 * keyboard.c (eval_dyn): New fun.
12487 (menu_item_eval_property): Use it.
12489 * image.c (parse_image_spec): Use Ffunctionp.
12491 * fns.c (concat, mapcar1): Accept byte-code-functions.
12493 * eval.c (Fsetq): Handle lexical vars.
12494 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12495 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12496 (FletX, Flet): Obey lexical binding.
12497 (Fcommandp): Handle closures.
12498 (Feval): New `lexical' arg.
12499 (eval_sub): New function extracted from Feval. Use it almost
12500 everywhere where Feval was used. Look up vars in lexical env.
12502 (Ffunctionp): Move from subr.el.
12503 (Ffuncall): Handle closures.
12504 (apply_lambda): Remove `eval_flags'.
12505 (funcall_lambda): Handle closures and new byte-code-functions.
12506 (Fspecial_variable_p): New function.
12507 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12508 but without exporting it to Lisp.
12510 * doc.c (Fdocumentation, store_function_docstring):
12511 * data.c (Finteractive_form): Handle closures.
12513 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12516 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12518 (exec_byte_code): New function extracted from Fbyte_code to handle new
12519 calling convention for byte-code-functions. Add new byte-codes.
12521 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
12523 * alloc.c (Fmake_symbol): Init new `declared_special' field.
12525 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12527 * xdisp.c (redisplay_internal): Fix prototype.
12529 2011-03-31 Eli Zaretskii <eliz@gnu.org>
12531 * xdisp.c (SCROLL_LIMIT): New macro.
12532 (try_scrolling): Use it when setting scroll_limit.
12533 Limit scrolling to 100 screen lines.
12534 (redisplay_window): Even when falling back on "recentering",
12535 position point in the window according to scroll-conservatively,
12536 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12538 (try_scrolling): When point is above the window, allow searching
12539 as far as scroll_max, or one screenful, to compute vertical
12540 distance from PT to the scroll margin position. This prevents
12541 try_scrolling from unnecessarily failing when
12542 scroll-conservatively is set to a value slightly larger than the
12543 window height. Clean up the case of PT below the margin at bottom
12544 of window: scroll_max can no longer be INT_MAX. When aggressive
12545 scrolling is in use, don't let point enter the opposite scroll
12546 margin as result of the scroll.
12547 (syms_of_xdisp) <scroll-conservatively>: Document the
12548 threshold of 100 lines for never-recentering scrolling.
12550 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12552 * dispextern.h (move_it_by_lines):
12553 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12554 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12555 (message_log_check_duplicate): Remove parameters `prev_bol' and
12556 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12557 (redisplay_internal): Remove parameter `preserve_echo_area',
12558 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12560 * indent.c (Fvertical_motion):
12561 * window.c (window_scroll_pixel_based, Frecenter):
12562 Don't pass `need_y_p' to `move_it_by_lines'.
12564 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12566 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12567 steal a few bits to be more compact.
12568 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12569 Remove unneeded casts.
12571 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12573 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12575 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12576 binding" message (bug#7967).
12578 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12580 Fix more problems found by GCC 4.6.0's static checks.
12582 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12583 Remove unused local var.
12585 * editfns.c (Fmessage_box): Remove unused local var.
12587 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12588 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12589 Omit unused local vars.
12590 * window.c (shrink_windows): Omit unused local var.
12591 * menu.c (digest_single_submenu): Omit unused local var.
12592 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12593 Omit unused local var.
12595 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12596 Don't assume string length fits in int.
12597 (keyremap_step, read_key_sequence): Use size_t for sizes.
12598 (read_key_sequence): Don't check last_real_key_start redundantly.
12600 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12601 instead of alloca (Bug#8344).
12603 * eval.c (Fbacktrace): Don't assume nargs fits in int.
12604 (Fbacktrace_frame): Don't assume nframes fits in int.
12606 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12608 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12611 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12613 * cm.c (calccost): Turn while-do into do-while, for clarity.
12615 * keyboard.c (syms_of_keyboard): Use the same style as later
12616 in this function when indexing through an array. This also
12617 works around GCC bug 48267.
12619 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12621 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12623 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12624 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12626 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12627 This avoids undefined behavior on integer overflow, and is a bit
12628 more convenient anyway since it is compared to a size_t variable.
12630 Variadic C functions now count arguments with size_t, not int.
12631 This avoids an unnecessary limitation on 64-bit machines, which
12632 caused (substring ...) to crash on large vectors (Bug#8344).
12633 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12634 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
12635 All variadic functions and their callers changed accordingly.
12636 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12637 * data.c (arith_driver, float_arith_driver): Likewise.
12638 * editfns.c (general_insert_function): Likewise.
12639 * eval.c (struct backtrace.nargs, interactive_p)
12640 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12641 (funcall_lambda, mark_backtrace): Likewise.
12642 * fns.c (concat): Likewise.
12643 * frame.c (x_set_frame_parameters): Likewise.
12644 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12645 0 if not found, not -1. All callers changed.
12647 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12648 (stack_copy_size): Now size_t, not int.
12649 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12651 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12653 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12654 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12655 All callers changed.
12657 * lisp.h (multibyte_char_to_unibyte):
12658 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12659 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12660 * character.h (CHAR_TO_BYTE8):
12661 * cmds.c (internal_self_insert):
12662 * editfns.c (general_insert_function):
12663 * keymap.c (push_key_description):
12664 * search.c (Freplace_match):
12665 * xdisp.c (message_dolog, set_message_1): All callers changed.
12667 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12669 * keyboard.c (safe_run_hook_funcall): New function.
12670 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12671 don't set the hook to nil, but remove the offending function instead.
12672 (Qcommand_hook_internal): Remove, unused.
12673 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12674 Vcommand_hook_internal.
12676 * eval.c (enum run_hooks_condition): Remove.
12677 (funcall_nil, funcall_not): New functions.
12678 (run_hook_with_args): Call each function through a `funcall' argument.
12679 Remove `cond' argument, now redundant.
12680 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12681 (Frun_hook_with_args_until_failure): Adjust accordingly.
12682 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12684 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12686 * dispextern.h (string_buffer_position): Remove declaration.
12688 * print.c (strout): Remove parameter `multibyte', unused since
12689 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12691 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12692 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12693 All callers changed.
12695 * w32.c (_wsa_errlist): Use braces for struct initializers.
12697 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12698 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12699 All callers changed.
12700 (string_buffer_position): Likewise. Also, make static (it's never
12701 used outside xdisp.c).
12702 (cursor_row_p): Remove parameter `w', unused since
12703 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12704 (decode_mode_spec): Remove parameter `precision', introduced during
12705 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12706 All callers changed.
12708 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12710 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12712 2011-03-27 Anders Lindgren <andlind@gmail.com>
12714 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12715 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12716 (ns_update_auto_hide_menu_bar): New functions.
12717 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12718 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12719 ns_constrain_all_frames.
12720 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12721 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12723 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12725 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12727 2011-03-27 Glenn Morris <rgm@gnu.org>
12729 * syssignal.h: Replace RETSIGTYPE with void.
12730 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12731 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12732 Replace SIGTYPE with void everywhere.
12733 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12734 * s/template.h (SIGTYPE): Remove commented out definition.
12736 2011-03-26 Eli Zaretskii <eliz@gnu.org>
12738 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12739 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12741 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
12743 * w32.c (read_unc_volume): Use parameter `henum', instead of
12744 global variable `wget_enum_handle'.
12746 * keymap.c (describe_vector): Remove parameters `indices' and
12747 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12748 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12750 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12752 * keyboard.c (timer_check): Remove parameter `do_it_now',
12753 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12754 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12755 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12757 * keyboard.c (read_char):
12758 * w32menu.c (w32_menu_display_help):
12759 * xmenu.c (show_help_event, menu_help_callback):
12760 Adjust calls to `show_help_echo'.
12762 * gtkutil.c (xg_maybe_add_timer):
12763 * keyboard.c (readable_events):
12764 * process.c (wait_reading_process_output):
12765 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12767 * insdel.c (adjust_markers_gap_motion):
12768 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12769 (gap_left, gap_right): Don't call it.
12771 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
12773 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12774 incurred during fontification.
12776 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12778 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12779 (DEFVAR_PER_BUFFER): Don't pass it.
12781 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12782 (scrolling_window): Don't pass it.
12784 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12786 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12788 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12790 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12791 of variables specific to SELinux and computation of `encoded_absname'.
12793 * image.c (XPutPixel): Remove unused variable `height'.
12795 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12797 * unexw32.c (get_section_info): Remove unused variable `section'.
12799 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12800 (system_process_attributes): Remove unused variable `sess'.
12801 (sys_read): Remove unused variable `err'.
12803 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12804 (w32_wnd_proc): Remove unused variable `isdead'.
12805 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12806 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12807 (x_create_tip_frame): Remove unused variable `tem'.
12809 * w32inevt.c (w32_console_read_socket):
12810 Remove unused variable `no_events'.
12812 * w32term.c (x_draw_composite_glyph_string_foreground):
12813 Remove unused variable `width'.
12815 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
12817 * w32term.c (x_set_glyph_string_clipping):
12818 Don't pass uninitialized region to CombineRgn.
12820 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
12822 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12823 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12824 (Fx_close_connection): Remove unused variable `i'.
12826 * w32font.c (w32font_draw): Return number of glyphs.
12827 (w32font_open_internal): Remove unused variable `i'.
12828 (w32font_driver): Add missing initializer.
12830 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12831 (fill_in_menu): Remove unused variable `items_added'.
12833 * w32term.c (last_mouse_press_frame): Remove static global variable.
12834 (w32_clip_to_row): Remove unused variable `f'.
12835 (x_delete_terminal): Remove unused variable `i'.
12837 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12838 (NOTHING): Remove unused static global variable.
12839 (uniscribe_check_otf): Remove unused variable `table'.
12840 (uniscribe_font_driver): Add missing initializers.
12842 2011-03-23 Julien Danjou <julien@danjou.info>
12844 * term.c (Fsuspend_tty, Fresume_tty):
12845 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12846 * window.c (temp_output_buffer_show):
12847 * insdel.c (signal_before_change):
12848 * frame.c (Fhandle_switch_frame):
12849 * fileio.c (Fdo_auto_save):
12850 * emacs.c (Fkill_emacs):
12851 * editfns.c (save_excursion_restore):
12852 * cmds.c (internal_self_insert):
12853 * callint.c (Fcall_interactively):
12854 * buffer.c (Fkill_all_local_variables):
12855 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12857 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
12858 unconditionally since it does the check itself.
12860 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
12862 Fix more problems found by GCC 4.5.2's static checks.
12864 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12865 the first time through the loop, since we know p0 < p1 then.
12866 This also avoids a gcc -Wstrict-overflow warning.
12868 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12869 leading to a memory leak, possible in functions like
12870 load_charset_map_from_file that can allocate an unbounded number
12871 of objects (Bug#8318).
12873 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12874 that could (at least in theory) be that large.
12876 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12877 This is less likely to overflow, and avoids undefined behavior if
12878 overflow does occur. All callers changed. Use strtoul to scan
12879 for the unsigned long integer.
12880 (pint2hrstr): Simplify and tune code slightly.
12881 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
12883 * scroll.c (do_scrolling): Work around GCC bug 48228.
12884 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12886 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12887 This also avoids a warning with gcc -Wstrict-overflow.
12888 (validate_x_resource_name): Simplify count usage.
12889 This also avoids a warning with gcc -Wstrict-overflow.
12891 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12894 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
12896 * process.c (Fmake_network_process): Use socklen_t, not int,
12897 where POSIX says socklen_t is required in portable programs.
12898 This fixes a porting bug on hosts like 64-bit HP-UX, where
12899 socklen_t is wider than int (Bug#8277).
12900 (Fmake_network_process, server_accept_connection):
12901 (wait_reading_process_output, read_process_output):
12904 * process.c: Rename or move locals to avoid shadowing.
12905 (list_processes_1, Fmake_network_process):
12906 (read_process_output_error_handler, exec_sentinel_error_handler):
12907 Rename or move locals.
12908 (Fmake_network_process): Define label "retry_connect" only if needed.
12909 (Fnetwork_interface_info): Fix pointer signedness.
12910 (process_send_signal): Add cast to avoid pointer signedness problem.
12911 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
12912 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
12914 Make tparam.h and terminfo.c consistent.
12915 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12916 Include tparam.h instead, since it declares them.
12917 * cm.h (PC): Remove extern decl; tparam.h now does this.
12918 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12919 * terminfo.c: Include tparam.h, to check interfaces.
12920 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12921 (tparam): Adjust signature to match interface in tparam.h;
12922 this removes some undefined behavior. Check that outstring and len
12923 are zero, which they always are with Emacs.
12924 * tparam.h (PC, BC, UP): New extern decls.
12926 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
12927 (xftfont_open): Rename locals to avoid shadowing.
12929 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
12930 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12931 (OTF_TAG_SYM): Omit macro if not needed.
12932 (ftfont_list): Remove unused local.
12933 (get_adstyle_property, ftfont_pattern_entity):
12934 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12935 Rename locals to avoid shadowing.
12937 * xfont.c (xfont_list_family): Mark var as initialized.
12939 * xml.c (make_dom): Now static.
12941 * composite.c (composition_compute_stop_pos): Rename local to
12943 (composition_reseat_it): Remove unused locals.
12944 (find_automatic_composition, composition_adjust_point): Likewise.
12945 (composition_update_it): Mark var as initialized.
12946 (find_automatic_composition): Mark vars as initialized,
12947 with a FIXME (Bug#8290).
12949 character.h: Rename locals to avoid shadowing.
12950 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12951 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12952 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12953 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12954 to avoid shadowing.
12956 * textprop.c (property_change_between_p): Remove; unused.
12958 * intervals.c (interval_start_pos): Now static.
12960 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12962 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12963 Rename locals to avoid shadowing.
12965 * sound.c (wav_play, au_play, Fplay_sound_internal):
12966 Fix pointer signedness.
12967 (alsa_choose_format): Remove unused local var.
12968 (wav_play): Initialize a variable to 0, to prevent undefined
12969 behavior (Bug#8278).
12971 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12973 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12975 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12976 clobbering (Bug#8298).
12977 * sysdep.c (sys_subshell): Likewise.
12978 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
12980 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12981 This should get cleaned up, so that child_setup has the
12982 same signature on all platforms.
12984 * callproc.c (call_process_cleanup): Now static.
12985 (relocate_fd): Rename locals to avoid shadowing.
12987 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
12989 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12990 not to be necessary, and produces flickering.
12992 2011-03-20 Glenn Morris <rgm@gnu.org>
12994 * config.in: Remove file.
12996 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
12998 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12999 are now in src/globals.h.
13000 (syms_of_minibuf): Remove spurious & from previous change.
13002 2011-03-20 Leo Liu <sdl.web@gmail.com>
13004 * minibuf.c (completing-read-function): New variable.
13005 (completing-read-default): Rename from completing-read.
13006 (completing-read): Call completing-read-function.
13008 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13010 * xfaces.c (Fx_load_color_file):
13011 Read color file from absolute filename (bug#8250).
13013 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13015 * makefile.w32-in: Update dependencies.
13017 2011-03-17 Eli Zaretskii <eliz@gnu.org>
13019 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13021 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13023 Fix more problems found by GCC 4.5.2's static checks.
13025 * process.c (make_serial_process_unwind, send_process_trap):
13026 (sigchld_handler): Now static.
13028 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13029 That way, the code declares only the vars that it needs.
13030 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13031 * s/cygwin.h (PTY_ITERATION): Likewise.
13032 * s/darwin.h (PTY_ITERATION): Likewise.
13033 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13035 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13036 * process.c (allocate_pty): Don't declare stb unless it's needed.
13038 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
13039 (CONSTANTLIM): Remove; unused.
13040 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13041 Define only if needed.
13043 * unexelf.c (unexec): Name an expression,
13044 to avoid gcc -Wbad-function-cast warning.
13045 Use a different way to cause a compilation error if anyone uses
13046 n rather than nn, a way that does not involve shadowing.
13047 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
13049 * deps.mk (unexalpha.o): Remove; unused.
13051 New file unexec.h, the (simple) interface for unexec (Bug#8267).
13052 * unexec.h: New file.
13053 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13054 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13055 Depend on unexec.h.
13056 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13057 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13058 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
13059 Change as necessary to match prototype in unexec.h.
13061 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13063 (back_comment, skip_chars): Mark vars as initialized.
13065 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13066 Rename locals to avoid shadowing.
13068 * lread.c (read1): Rewrite so as not to use empty "else".
13069 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
13071 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13073 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13074 warning when compiling print.c.
13076 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13077 instead of using an uninitialized var.
13078 (font_sort_entities): Mark var as initialized.
13080 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13082 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13083 pointers to constants.
13084 (font_parse_fcname): Remove unused vars.
13085 (font_delete_unmatched): Now static.
13086 (font_get_spec): Remove; unused.
13087 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13088 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13089 Rename or move locals to avoid shadowing.
13091 * fns.c (require_nesting_list, require_unwind): Now static.
13092 (Ffillarray): Rename locals to avoid shadowing.
13094 * floatfns.c (domain_error2): Define only if needed.
13095 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
13097 * alloc.c (mark_backtrace): Move decl from here ...
13098 * lisp.h: ... to here, so that it can be checked.
13100 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
13101 (Fdefvar): Rewrite so as not to use empty "else".
13102 (lisp_indirect_variable): Name an expression,
13103 to avoid gcc -Wbad-function-cast warning.
13104 (Fdefvar): Rename locals to avoid shadowing.
13106 * callint.c (quotify_arg, quotify_args): Now static.
13107 (Fcall_interactively): Rename locals to avoid shadowing.
13108 Use const pointer when appropriate.
13110 * lisp.h (get_system_name, get_operating_system_release):
13111 Move decls here, to check interfaces.
13112 * process.c (get_operating_system_release): Move decl to lisp.h.
13113 * xrdb.c (get_system_name): Likewise.
13114 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13115 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13116 some of which prompt warnings from gcc -Wbad-function-cast.
13117 (Fformat_time_string, Fencode_time, Finsert_char):
13118 (Ftranslate_region_internal, Fformat):
13119 Rename or remove local vars to avoid shadowing.
13120 (Ftranslate_region_internal): Mark var as initialized.
13122 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13125 * lisp.h (eassert): Check that the argument compiles, even if
13126 ENABLE_CHECKING is not defined.
13128 * data.c (Findirect_variable): Name an expression, to avoid
13129 gcc -Wbad-function-cast warning.
13130 (default_value, arithcompare, arith_driver, arith_error): Now static.
13131 (store_symval_forwarding): Rename local to avoid shadowing.
13132 (Fmake_variable_buffer_local, Fmake_local_variable):
13133 Mark variables as initialized.
13134 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
13136 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
13137 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13138 Rename locals to avoid shadowing.
13139 (mark_stack): Move local variables into the #ifdef region where
13141 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13142 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13144 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13145 (GC_STRING_CHARS): Remove; not used.
13146 (Fmemory_limit): Cast sbrk's returned value to char *.
13148 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13149 avoids undefined behavior in theory.
13151 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13153 Use functions, not macros, for up- and down-casing (Bug#8254).
13154 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13155 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13156 to use the following functions instead of these macros.
13157 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13158 EMACS_INT, since callers assume the returned value fits in int.
13159 (upcase1): Likewise, for UPCASE_TABLE.
13160 (uppercasep, lowercasep, upcase): New static inline functions.
13161 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
13162 the race-condition problem in the old DOWNCASE.
13164 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13165 Rename locals to avoid shadowing.
13166 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
13167 (regex_compile, re_search_2, re_match_2_internal):
13168 Remove unused local vars.
13169 (FREE_VAR): Rewrite so as not to use empty "else",
13170 which gcc can warn about.
13171 (regex_compile, re_match_2_internal): Mark locals as initialized.
13172 (RETALLOC_IF): Define only if needed.
13173 (WORDCHAR_P): Likewise. This one is never needed, but is used
13174 only in a comment talking about a compiler bug, so put inside
13175 the #if 0 of that comment.
13176 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13177 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13180 * search.c (boyer_moore): Rename locals to avoid shadowing.
13181 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13182 (PREV_CHAR_BOUNDARY): Likewise.
13184 * search.c (simple_search): Remove unused var.
13186 * dired.c (compile_pattern): Move decl from here ...
13187 * lisp.h: ... to here, so that it can be checked.
13188 (struct re_registers): New forward decl.
13190 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13192 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13194 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13195 Rename locals to avoid shadowing.
13196 (Fvertical_motion): Mark locals as initialized.
13198 * casefiddle.c (casify_object, casify_region): Now static.
13199 (casify_region): Mark local as initialized.
13201 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13203 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13204 New macros, so that the caller can use some names other than
13205 gcpro1, gcpro2, etc.
13206 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13208 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13209 argument, for consistency with GCPRO2_VAR, etc: it is now the
13210 prefix of the variable, not the variable itself. All uses
13212 * dired.c (directory_files_internal, file_name_completion):
13213 Rename locals to avoid shadowing.
13215 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13216 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13217 dired.c's scmp function, had undefined behavior.
13218 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13219 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13220 * buffer.h: ... to here, because these macros use current_buffer,
13221 and the new implementation with inline functions needs to have
13222 current_buffer in scope now, rather than later when the macros
13224 (downcase, upcase1): New static inline functions.
13225 (DOWNCASE, UPCASE1): Reimplement using these functions.
13226 This avoids undefined behavior in expressions like
13227 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13228 from race conditions in accessing the global variables
13229 case_temp1 and case_temp2.
13230 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13231 * lisp.h (case_temp1, case_temp2): Remove their decls.
13232 * character.h (ASCII_CHAR_P): Move from here ...
13233 * lisp.h: ... to here, so that the inline functions mentioned
13234 above can use them.
13236 * dired.c (directory_files_internal_unwind): Now static.
13238 * fileio.c (file_name_as_directory, directory_file_name):
13239 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13241 (file_name_as_directory): Use const pointers when appropriate.
13242 (Fexpand_file_name): Likewise. In particular, newdir might
13243 point at constant storage, so make it a const pointer.
13244 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
13245 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13247 (Fset_file_times, Finsert_file_contents, auto_save_error):
13248 Rename locals to avoid shadowing.
13250 * minibuf.c (choose_minibuf_frame_1): Now static.
13251 (Ftry_completion, Fall_completions): Rename or remove locals
13252 to avoid shadowing.
13254 * marker.c (bytepos_to_charpos): Remove; unused.
13256 * lisp.h (verify_bytepos, count_markers): New decls,
13257 so that gcc does not warn that these functions aren't declared.
13259 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13260 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
13261 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
13262 (copy_text): Remove unused local var.
13264 * filelock.c (within_one_second): Now static.
13265 (lock_file_1): Rename local to avoid shadowing.
13267 * buffer.c (fix_overlays_before): Mark locals as initialized.
13268 (fix_start_end_in_overlays): Likewise. This function should be
13269 simplified by using pointers-to-pointers, but that's a different
13271 (switch_to_buffer_1): Now static.
13272 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13273 (report_overlay_modification): Rename locals to avoid shadowing.
13275 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
13276 Fix pointer signedness issue.
13277 (sys_subshell): Mark local as volatile if checking for lint,
13278 to suppress a gcc -Wclobbered warning that does not seem to be right.
13279 (MAXPATHLEN): Define only if needed.
13281 * process.c (serial_open, serial_configure): Move decls from here ...
13282 * systty.h: ... to here, so that they can be checked.
13284 * fns.c (get_random, seed_random): Move extern decls from here ...
13285 * lisp.h: ... to here, so that they can be checked.
13287 * sysdep.c (reset_io): Now static.
13288 (wait_for_termination_signal): Remove; unused.
13290 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13291 (copy_keymap_item, append_key, push_text_char_description):
13293 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
13294 (DENSE_TABLE_SIZE): Remove; unused.
13295 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13296 (describe_map_tree):
13297 Rename locals to avoid shadowing.
13299 * keyboard.c: Declare functions static if they are not used elsewhere.
13300 (echo_char, echo_dash, cmd_error, top_level_2):
13301 (poll_for_input, handle_async_input): Now static.
13302 (read_char, kbd_buffer_get_event, make_lispy_position):
13303 (make_lispy_event, make_lispy_movement, apply_modifiers):
13304 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13305 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13306 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
13307 (read_key_sequence, read_char): Mark locals as initialized.
13308 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
13310 * keyboard.h (make_ctrl_char): New decl.
13311 (mark_kboards): Move decl here ...
13312 * alloc.c (mark_kboards): ... from here.
13314 * lisp.h (force_auto_save_soon): New decl.
13316 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
13317 (DEFINE_DUMMY_FUNCTION): New macro.
13318 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13320 (main): Add casts to avoid warnings
13321 if GCC considers string literals to be constants.
13323 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13325 * dbusbind.c: Pointer signedness fixes.
13326 (xd_signature, xd_append_arg, xd_initialize):
13327 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13328 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13329 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13330 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13332 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13333 if GCC considers string literals to be constants.
13334 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
13336 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13338 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13339 (print_preprocess, print_object): New macro to fix last change.
13341 * print.c (print_preprocess): Don't forget font objects.
13343 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
13345 * emacs.c (USAGE3): Doc fixes.
13347 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13349 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13352 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
13354 * lisp.h (VWindow_system, Qfile_name_history):
13355 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13356 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13357 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13359 * w32select.c: Don't #include "keyboard.h".
13360 (run_protected): Add extern declaration for waiting_for_input.
13362 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13363 * w32console.c (detect_input_pending, read_input_pending)
13364 (encode_terminal_code):
13365 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13366 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13367 (w32_system_caret_y, Qfile_name_history):
13368 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13369 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13370 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13371 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13372 * w32proc.c (Qlocal, report_file_error):
13373 * w32term.c (Vwindow_system, updating_frame):
13374 * w32uniscribe.c (initialized, uniscribe_font_driver):
13375 Remove unneeded extern declarations.
13377 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
13379 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
13381 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
13383 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13384 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13385 These macros can no longer be used for assignment.
13387 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13388 Assign struct members directly, instead of using BUF_BEGV etc.
13389 (record_buffer_markers, fetch_buffer_markers): New functions for
13390 recording and fetching special buffer markers.
13391 (set_buffer_internal_1, set_buffer_temp): Use them.
13393 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13395 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13397 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13398 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13400 * xdisp.c (hscroll_window_tree):
13401 (reconsider_clip_changes): Use PT instead of BUF_PT.
13403 2011-03-13 Eli Zaretskii <eliz@gnu.org>
13405 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13406 $(EMACS_ROOT)/lib/intprops.h.
13408 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13410 Fix more problems found by GCC 4.5.2's static checks.
13412 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13413 to unsigned char * to avoid compiler diagnostic.
13414 (xg_free_frame_widgets): Make it clear that a local variable is
13415 needed only if USE_GTK_TOOLTIP.
13416 (gdk_window_get_screen): Make it clear that this macro is needed
13417 only if USE_GTK_TOOLTIP.
13418 (int_gtk_range_get_value): New function, which avoids a diagnostic
13419 from gcc -Wbad-function-cast.
13420 (xg_set_toolkit_scroll_bar_thumb): Use it.
13421 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13422 diagnostic from gcc -Wbad-function-cast.
13423 (get_utf8_string, xg_get_file_with_chooser):
13424 Rename locals to avoid shadowing.
13425 (create_dialog): Move locals to avoid shadowing.
13427 * xgselect.c (xg_select): Remove unused var.
13429 * image.c (four_corners_best): Mark locals as initialized.
13430 (gif_load): Initialize transparent_p to zero (Bug#8238).
13431 Mark another local as initialized.
13432 (my_png_error, my_error_exit): Mark with NO_RETURN.
13434 * image.c (clear_image_cache): Now static.
13435 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
13436 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
13437 (x_edge_detection): Remove unnecessary cast that
13438 gcc -Wbad-function-cast diagnoses.
13439 (gif_load): Fix pointer signedness.
13440 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13441 (jpeg_load, gif_load): Rename locals to avoid shadowing.
13443 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
13445 Improve quality of tests for time stamp overflow.
13446 For example, without this patch (encode-time 0 0 0 1 1
13447 1152921504606846976) returns the obviously-bogus value (-948597
13448 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13449 reports time overflow. See
13450 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
13451 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13452 * editfns.c: Include limits.h and intprops.h.
13453 (TIME_T_MIN, TIME_T_MAX): New macros.
13454 (time_overflow): Move earlier, to before first use.
13455 (hi_time, lo_time): New functions, for an accurate test for
13456 out-of-range times.
13457 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13458 (Fget_internal_run_time): Don't assume time_t fits in int.
13459 (make_time): Use list2 instead of Fcons twice.
13460 (Fdecode_time): More accurate test for out-of-range times.
13461 (check_tm_member): New function.
13462 (Fencode_time): Use it, to test for out-of-range times.
13463 (lisp_time_argument): Don't rely on undefined left-shift and
13464 right-shift behavior when checking for time stamp overflow.
13466 * editfns.c (time_overflow): New function, refactoring common code.
13467 (Fformat_time_string, Fdecode_time, Fencode_time):
13468 (Fcurrent_time_string): Use it.
13470 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13471 * dired.c (make_time): Move to ...
13472 * editfns.c (make_time): ... here.
13473 * systime.h: Note the move.
13475 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13477 * fringe.c (update_window_fringes): Remove unused variables.
13479 * unexmacosx.c (copy_data_segment): Also copy __got section.
13482 2011-03-12 Eli Zaretskii <eliz@gnu.org>
13484 * termcap.c [MSDOS]: Include "msdos.h".
13485 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13486 Constify `char *' arguments and their references according to
13487 prototypes in tparam.h.
13489 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
13491 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13492 Adapt all references accordingly.
13494 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13496 2011-03-11 Tom Tromey <tromey@redhat.com>
13498 * buffer.c (syms_of_buffer): Remove obsolete comment.
13500 2011-03-11 Eli Zaretskii <eliz@gnu.org>
13502 * termhooks.h (encode_terminal_code): Declare prototype.
13504 * msdos.c (encode_terminal_code): Don't declare prototype.
13506 * term.c (encode_terminal_code): Now external again, used by
13507 w32console.c and msdos.c.
13509 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13510 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
13512 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
13514 Fix some minor problems found by GCC 4.5.2's static checks.
13516 * fringe.c (update_window_fringes): Mark locals as initialized
13518 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
13520 * alloc.c (mark_fringe_data): Move decl from here ...
13521 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13522 to check its interface.
13523 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13525 * fontset.c (free_realized_fontset): Now static.
13526 (Fset_fontset_font): Rename local to avoid shadowing.
13527 (fontset_font): Mark local as initialized.
13528 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
13530 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13532 * xselect.c (x_disown_buffer_selections): Remove; not used.
13533 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
13534 (x_own_selection, Fx_disown_selection_internal): Rename locals
13535 to avoid shadowing.
13536 (x_handle_dnd_message): Remove local to avoid shadowing.
13538 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13539 so that the caller can use some name other than gcpro1.
13540 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
13541 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13542 (Fx_backspace_delete_keys_p):
13543 Use them to avoid shadowing, and rename vars to avoid shadowing.
13544 (x_decode_color, x_set_name, x_window): Now static.
13545 (Fx_create_frame): Add braces to silence GCC warning.
13546 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
13547 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13548 Remove unused locals.
13549 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13550 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13551 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13554 * xterm.h (x_mouse_leave): New decl.
13556 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13557 Remove unused functions.
13558 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13559 (x_calc_absolute_position): Now static.
13560 (XTread_socket): Don't define label "out" unless it's used.
13561 Don't declare local "event" unless it's used.
13562 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13563 unless they are used.
13564 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13565 (x_fatal_error_signal): Remove; not used.
13566 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13567 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13568 (x_error_catcher, x_connection_closed, x_error_handler):
13569 (x_error_quitter, xembed_send_message, x_iconify_frame):
13570 (my_log_handler): Rename locals to avoid shadowing.
13571 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
13572 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
13574 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13575 Rename or move locals to avoid shadowing.
13576 (tty_defined_color, merge_face_heights): Now static.
13577 (free_realized_faces_for_fontset): Remove; not used.
13578 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13579 does not deduce is never used uninitialized.
13580 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13581 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
13583 * terminal.c (store_terminal_param): Now static.
13585 * xmenu.c (menu_highlight_callback): Now static.
13586 (set_frame_menubar): Remove unused local.
13587 (xmenu_show): Rename parameter to avoid shadowing.
13588 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13589 since they might point to immutable storage.
13590 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13591 since it's unused otherwise.
13593 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
13594 Add a FIXME, since the code still doesn't look right. (Bug#8215)
13595 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13596 avoids a gcc -Wuninitialized diagnostic.
13597 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
13598 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13599 does not deduce are never used uninitialized.
13601 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13603 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
13604 * window.c (window_loop, size_window):
13605 (run_window_configuration_change_hook, enlarge_window): Likewise.
13607 * window.c (display_buffer): Now static.
13608 (size_window): Mark variables that gcc -Wuninitialized
13609 does not deduce are never used uninitialized.
13610 * window.h (check_all_windows): New decl, to forestall
13611 gcc -Wmissing-prototypes diagnostic.
13612 * dispextern.h (bidi_dump_cached_states): Likewise.
13614 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13616 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
13617 Include <limits.h>.
13618 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13619 and to avoid gcc -Wuninitialized warning.
13620 (load_charset_map): Mark variables that gcc -Wuninitialized
13621 does not deduce are never used uninitialized.
13622 (load_charset): Abort instead of using uninitialized var (Bug#8229).
13624 * coding.c (coding_set_source, coding_set_destination):
13625 Use "else { /* comment */ }" rather than "else /* comment */;"
13626 for clarity, and to avoid gcc -Wempty-body warning.
13627 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13628 a block, when the outer 'i' will do.
13629 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13630 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13631 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13632 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13633 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13634 Rename locals to avoid shadowing.
13635 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
13636 * coding.c (emacs_mule_char, encode_invocation_designation):
13637 Now static, since they're not used elsewhere.
13638 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
13639 (decode_coding_object, encode_coding_object, detect_coding_system):
13640 (decode_coding_emacs_mule): Mark variables that gcc
13641 -Wuninitialized does not deduce are never used uninitialized.
13642 (detect_coding_iso_2022): Initialize a local variable that might
13643 be used uninitialized. Leave a FIXME because it's not clear that
13644 this initialization is needed. (Bug#8211)
13645 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13646 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13647 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13648 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13649 Remove unused macros.
13651 * category.c (hash_get_category_set): Remove unused local var.
13652 (copy_category_table): Now static, since it's not used elsewhere.
13653 * character.c (string_count_byte8): Likewise.
13655 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13656 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13658 * chartab.c (copy_sub_char_table): Now static, since it's not used
13660 (sub_char_table_ref_and_range, char_table_ref_and_range):
13661 Rename locals to avoid shadowing.
13662 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
13664 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
13665 (BIDI_BOB): Remove unused macro.
13667 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13668 deduce are never used uninitialized.
13669 * term.c (encode_terminal_code): Likewise.
13671 * term.c (encode_terminal_code): Now static. Remove unused local.
13673 * tparam.h: New file.
13674 * term.c, tparam.h: Include it.
13675 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13676 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13677 Move these decls to tparam.h, and make them agree with what
13678 is actually in tparam.c. The previous trick of using incompatible
13679 decls in different modules does not conform to the C standard.
13680 All callers of tparam changed to use tparam's actual API.
13681 * tparam.c (tparam1, tparam, tgoto):
13682 Use const pointers where appropriate.
13684 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13685 * cm.h (struct cm): Likewise.
13686 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13687 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13688 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13689 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13690 (turn_on_face, init_tty): Likewise.
13691 * termchar.h (struct tty_display_info): Likewise.
13693 * term.c (term_mouse_position): Rename local to avoid shadowing.
13695 * alloc.c (mark_ttys): Move decl from here ...
13696 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13698 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13700 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13702 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
13704 * search.c (compile_pattern_1): Remove argument regp, unused since
13705 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13706 (compile_pattern): Don't pass it.
13708 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13710 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13711 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13713 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13715 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13717 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13718 gdk_window_get_screen, gdk_window_get_geometry,
13719 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13720 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13721 (xg_get_pixbuf_from_pixmap): New function.
13722 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13723 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13724 Call xg_get_pixbuf_from_pixmap instead of
13725 gdk_pixbuf_get_from_drawable.
13726 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13727 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13728 (xg_check_special_colors): Use GtkStyleContext and its functions
13730 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13731 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13732 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
13733 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13734 Call gtk_widget_get_preferred_size.
13735 (xg_frame_resized): gdk_window_get_geometry only takes 5
13737 (xg_win_to_widget, xg_event_is_for_menubar):
13738 Call gdk_x11_window_lookup_for_display.
13739 (xg_set_widget_bg): New function.
13740 (delete_cb): New function.
13741 (xg_create_frame_widgets): Connect delete-event to delete_cb.
13742 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
13743 (xg_set_background_color): Call xg_set_widget_bg.
13744 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13745 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13746 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13747 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13749 (update_frame_tool_bar): Call gtk_widget_hide.
13750 (xg_initialize): Use GDK_KEY_g.
13752 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13754 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13756 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13757 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13758 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13760 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
13762 * w32xfns.c (select_palette): Check success of RealizePalette against
13763 GDI_ERROR, not zero.
13765 See ChangeLog.11 for earlier changes.
13767 ;; Local Variables:
13771 Copyright (C) 2011-2012 Free Software Foundation, Inc.
13773 This file is part of GNU Emacs.
13775 GNU Emacs is free software: you can redistribute it and/or modify
13776 it under the terms of the GNU General Public License as published by
13777 the Free Software Foundation, either version 3 of the License, or
13778 (at your option) any later version.
13780 GNU Emacs is distributed in the hope that it will be useful,
13781 but WITHOUT ANY WARRANTY; without even the implied warranty of
13782 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13783 GNU General Public License for more details.
13785 You should have received a copy of the GNU General Public License
13786 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.