1 ;;; nadvice.el --- Light-weight advice primitives for Elisp functions -*- lexical-binding: t -*-
3 ;; Copyright (C) 2012-2016 Free Software Foundation, Inc.
5 ;; Author: Stefan Monnier <monnier@iro.umontreal.ca>
6 ;; Keywords: extensions, lisp, tools
9 ;; This program is free software; you can redistribute it and/or modify
10 ;; it under the terms of the GNU General Public License as published by
11 ;; the Free Software Foundation, either version 3 of the License, or
12 ;; (at your option) any later version.
14 ;; This program is distributed in the hope that it will be useful,
15 ;; but WITHOUT ANY WARRANTY; without even the implied warranty of
16 ;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17 ;; GNU General Public License for more details.
19 ;; You should have received a copy of the GNU General Public License
20 ;; along with this program. If not, see <http://www.gnu.org/licenses/>.
24 ;; This package lets you add behavior (which we call "piece of advice") to
25 ;; existing functions, like the old `advice.el' package, but with much fewer
26 ;; bells and whistles. It comes in 2 parts:
28 ;; - The first part lets you add/remove functions, similarly to
29 ;; add/remove-hook, from any "place" (i.e. as accepted by `setf') that
31 ;; This part provides mainly 2 macros: `add-function' and `remove-function'.
33 ;; - The second part provides `advice-add' and `advice-remove' which are
34 ;; refined version of the previous macros specially tailored for the case
35 ;; where the place that we want to modify is a `symbol-function'.
39 ;;;; Lightweight advice/hook
40 (defvar advice--where-alist
41 '((:around
"\300\301\302\003#\207" 5)
42 (:before
"\300\301\002\"\210\300\302\002\"\207" 4)
43 (:after
"\300\302\002\"\300\301\003\"\210\207" 5)
44 (:override
"\300\301\x02\"\207" 4)
45 (:after-until
"\300\302\002\"\206\013\000\300\301\002\"\207" 4)
46 (:after-while
"\300\302\002\"\205\013\000\300\301\002\"\207" 4)
47 (:before-until
"\300\301\002\"\206\013\000\300\302\002\"\207" 4)
48 (:before-while
"\300\301\002\"\205\013\000\300\302\002\"\207" 4)
49 (:filter-args
"\300\302\301\x03!\"\207" 5)
50 (:filter-return
"\301\300\302\x03\"!\207" 5))
51 "List of descriptions of how to add a function.
52 Each element has the form (WHERE BYTECODE STACK) where:
53 WHERE is a keyword indicating where the function is added.
54 BYTECODE is the corresponding byte-code that will be used.
55 STACK is the amount of stack space needed by the byte-code.")
57 (defvar advice--bytecodes
(mapcar #'cadr advice--where-alist
))
59 (defun advice--p (object)
60 (and (byte-code-function-p object
)
61 (eq 128 (aref object
0))
62 (memq (length object
) '(5 6))
63 (memq (aref object
1) advice--bytecodes
)
64 (eq #'apply
(aref (aref object
2) 0))))
66 (defsubst advice--car
(f) (aref (aref f
2) 1))
67 (defsubst advice--cdr
(f) (aref (aref f
2) 2))
68 (defsubst advice--props
(f) (aref (aref f
2) 3))
70 (defun advice--cd*r
(f)
72 (setq f
(advice--cdr f
)))
75 (defun advice--make-docstring (function)
76 "Build the raw docstring for FUNCTION, presumably advised."
77 (let* ((flist (indirect-function function
))
80 (if (eq 'macro
(car-safe flist
)) (setq flist
(cdr flist
)))
81 (while (advice--p flist
)
82 (let ((bytecode (aref flist
1))
85 ;; Hack attack! For advices installed before calling
86 ;; Snarf-documentation, the integer offset into the DOC file will not
87 ;; be installed in the "core unadvised function" but in the advice
88 ;; object instead! So here we try to undo the damage.
89 (if (integerp doc
) (setq docfun flist
))
90 (dolist (elem advice--where-alist
)
91 (if (eq bytecode
(cadr elem
)) (setq where
(car elem
))))
95 (propertize (format "%s advice: " where
)
97 (let ((fun (advice--car flist
)))
98 (if (symbolp fun
) (format-message "`%S'" fun
)
99 (let* ((name (cdr (assq 'name
(advice--props flist
))))
100 (doc (documentation fun t
))
101 (usage (help-split-fundoc doc function
)))
102 (if usage
(setq doc
(cdr usage
)))
105 (format "%s\n%s" name doc
)
107 (or doc
"No documentation")))))
109 (setq flist
(advice--cdr flist
)))
110 (if docstring
(setq docstring
(concat docstring
"\n")))
111 (unless docfun
(setq docfun flist
))
112 (let* ((origdoc (unless (eq function docfun
) ;Avoid inf-loops.
113 (documentation docfun t
)))
114 (usage (help-split-fundoc origdoc function
)))
115 (setq usage
(if (null usage
)
116 (let ((arglist (help-function-arglist flist
)))
117 ;; "[Arg list not available until function
118 ;; definition is loaded]", bug#21299
119 (if (stringp arglist
) t
120 (help--make-usage-docstring function arglist
)))
121 (setq origdoc
(cdr usage
)) (car usage
)))
122 (help-add-fundoc-usage (concat docstring origdoc
) usage
))))
124 (defun advice-eval-interactive-spec (spec)
125 "Evaluate the interactive spec SPEC."
128 ;; There's no direct access to the C code (in call-interactively) that
129 ;; processes those specs, but that shouldn't stop us, should it?
130 ;; FIXME: Despite appearances, this is not faithful: SPEC and
131 ;; (advice-eval-interactive-spec SPEC) will behave subtly differently w.r.t
132 ;; command-history (and maybe a few other details).
133 (call-interactively `(lambda (&rest args
) (interactive ,spec
) args
)))
134 ;; ((functionp spec) (funcall spec))
137 (defun advice--interactive-form (function)
138 ;; Like `interactive-form' but tries to avoid autoloading functions.
139 (when (commandp function
)
140 (if (not (and (symbolp function
) (autoloadp (indirect-function function
))))
141 (interactive-form function
)
142 `(interactive (advice-eval-interactive-spec
143 (cadr (interactive-form ',function
)))))))
145 (defun advice--make-interactive-form (function main
)
146 ;; TODO: make it so that interactive spec can be a constant which
147 ;; dynamically checks the advice--car/cdr to do its job.
148 ;; For that, advice-eval-interactive-spec needs to be more faithful.
149 (let* ((iff (advice--interactive-form function
))
150 (ifm (advice--interactive-form main
))
152 (when (eq 'function
(car-safe fspec
)) ;; Macroexpanded lambda?
153 (setq fspec
(nth 1 fspec
)))
154 (if (functionp fspec
)
155 `(funcall ',fspec
',(cadr ifm
))
156 (cadr (or iff ifm
)))))
158 (defun advice--make-1 (byte-code stack-depth function main props
)
159 "Build a function value that adds FUNCTION to MAIN."
160 (let ((adv-sig (gethash main advertised-signature-table
))
162 (apply #'make-byte-code
128 byte-code
163 (vector #'apply function main props
) stack-depth nil
164 (and (or (commandp function
) (commandp main
))
165 (list (advice--make-interactive-form
167 (when adv-sig
(puthash advice adv-sig advertised-signature-table
))
170 (defun advice--make (where function main props
)
171 "Build a function value that adds FUNCTION to MAIN at WHERE.
172 WHERE is a symbol to select an entry in `advice--where-alist'."
173 (let ((fd (or (cdr (assq 'depth props
)) 0))
174 (md (if (advice--p main
)
175 (or (cdr (assq 'depth
(advice--props main
))) 0))))
176 (if (and md
(> fd md
))
177 ;; `function' should go deeper.
178 (let ((rest (advice--make where function
(advice--cdr main
) props
)))
179 (advice--make-1 (aref main
1) (aref main
3)
180 (advice--car main
) rest
(advice--props main
)))
181 (let ((desc (assq where advice--where-alist
)))
182 (unless desc
(error "Unknown add-function location `%S'" where
))
183 (advice--make-1 (nth 1 desc
) (nth 2 desc
)
184 function main props
)))))
186 (defun advice--member-p (function use-name definition
)
188 (while (and (not found
) (advice--p definition
))
189 (if (if (eq use-name
:use-both
)
191 (cdr (assq 'name
(advice--props definition
))))
192 (equal function
(advice--car definition
)))
193 (equal function
(if use-name
194 (cdr (assq 'name
(advice--props definition
)))
195 (advice--car definition
))))
196 (setq found definition
)
197 (setq definition
(advice--cdr definition
))))
200 (defun advice--tweak (flist tweaker
)
201 (if (not (advice--p flist
))
202 (funcall tweaker nil flist nil
)
203 (let ((first (advice--car flist
))
204 (rest (advice--cdr flist
))
205 (props (advice--props flist
)))
206 (let ((val (funcall tweaker first rest props
)))
208 (let ((nrest (advice--tweak rest tweaker
)))
209 (if (eq rest nrest
) flist
210 (advice--make-1 (aref flist
1) (aref flist
3)
211 first nrest props
))))))))
214 (defun advice--remove-function (flist function
)
216 (lambda (first rest props
)
217 (cond ((not first
) rest
)
218 ((or (equal function first
)
219 (equal function
(cdr (assq 'name props
))))
220 (list (advice--remove-function rest function
)))))))
222 (defvar advice--buffer-local-function-sample nil
223 "keeps an example of the special \"run the default value\" functions.
224 These functions play the same role as t in buffer-local hooks, and to recognize
225 them, we keep a sample here against which to compare. Each instance is
226 different, but `function-equal' will hopefully ignore those differences.")
228 (defun advice--set-buffer-local (var val
)
229 (if (function-equal val advice--buffer-local-function-sample
)
230 (kill-local-variable var
)
231 (set (make-local-variable var
) val
)))
234 (defun advice--buffer-local (var)
235 "Buffer-local value of VAR, presumed to contain a function."
236 (declare (gv-setter advice--set-buffer-local
))
237 (if (local-variable-p var
) (symbol-value var
)
238 (setq advice--buffer-local-function-sample
239 ;; This function acts like the t special value in buffer-local hooks.
240 (lambda (&rest args
) (apply (default-value var
) args
)))))
243 (defun advice--normalize-place (place)
244 (cond ((eq 'local
(car-safe place
)) `(advice--buffer-local ,@(cdr place
)))
245 ((eq 'var
(car-safe place
)) (nth 1 place
))
246 ((symbolp place
) `(default-value ',place
))
250 (defmacro add-function
(where place function
&optional props
)
252 ;; - maybe let `where' specify some kind of predicate and use it
253 ;; to implement things like mode-local or eieio-defmethod.
254 ;; Of course, that only makes sense if the predicates of all advices can
255 ;; be combined and made more efficient.
256 ;; :before is like a normal add-hook on a normal hook.
257 ;; :before-while is like add-hook on run-hook-with-args-until-failure.
258 ;; :before-until is like add-hook on run-hook-with-args-until-success.
259 ;; Same with :after-* but for (add-hook ... 'append).
260 "Add a piece of advice on the function stored at PLACE.
261 FUNCTION describes the code to add. WHERE describes where to add it.
262 WHERE can be explained by showing the resulting new function, as the
263 result of combining FUNCTION and the previous value of PLACE, which we
265 `:before' (lambda (&rest r) (apply FUNCTION r) (apply OLDFUN r))
266 `:after' (lambda (&rest r) (prog1 (apply OLDFUN r) (apply FUNCTION r)))
267 `:around' (lambda (&rest r) (apply FUNCTION OLDFUN r))
268 `:override' (lambda (&rest r) (apply FUNCTION r))
269 `:before-while' (lambda (&rest r) (and (apply FUNCTION r) (apply OLDFUN r)))
270 `:before-until' (lambda (&rest r) (or (apply FUNCTION r) (apply OLDFUN r)))
271 `:after-while' (lambda (&rest r) (and (apply OLDFUN r) (apply FUNCTION r)))
272 `:after-until' (lambda (&rest r) (or (apply OLDFUN r) (apply FUNCTION r)))
273 `:filter-args' (lambda (&rest r) (apply OLDFUN (funcall FUNCTION r)))
274 `:filter-return'(lambda (&rest r) (funcall FUNCTION (apply OLDFUN r)))
275 If FUNCTION was already added, do nothing.
276 PROPS is an alist of additional properties, among which the following have
278 - `name': a string or symbol. It can be used to refer to this piece of advice.
279 - `depth': a number indicating a preference w.r.t ordering.
280 The default depth is 0. By convention, a depth of 100 means that
281 the advice should be innermost (i.e. at the end of the list),
282 whereas a depth of -100 means that the advice should be outermost.
284 If PLACE is a symbol, its `default-value' will be affected.
285 Use (local \\='SYMBOL) if you want to apply FUNCTION to SYMBOL buffer-locally.
286 Use (var VAR) if you want to apply FUNCTION to the (lexical) VAR.
288 If one of FUNCTION or OLDFUN is interactive, then the resulting function
289 is also interactive. There are 3 cases:
290 - FUNCTION is not interactive: the interactive spec of OLDFUN is used.
291 - The interactive spec of FUNCTION is itself a function: it should take one
292 argument (the interactive spec of OLDFUN, which it can pass to
293 `advice-eval-interactive-spec') and return the list of arguments to use.
294 - Else, use the interactive spec of FUNCTION and ignore the one of OLDFUN."
297 (debug (form [&or symbolp
("local" form
) ("var" sexp
) gv-place
]
298 form
&optional form
)))
299 `(advice--add-function ,where
(gv-ref ,(advice--normalize-place place
))
303 (defun advice--add-function (where ref function props
)
304 (let* ((name (cdr (assq 'name props
)))
305 (a (advice--member-p (or name function
) (if name t
) (gv-deref ref
))))
307 ;; The advice is already present. Remove the old one, first.
309 (advice--remove-function (gv-deref ref
)
310 (or name
(advice--car a
)))))
312 (advice--make where function
(gv-deref ref
) props
))))
315 (defmacro remove-function
(place function
)
316 "Remove the FUNCTION piece of advice from PLACE.
317 If FUNCTION was not added to PLACE, do nothing.
318 Instead of FUNCTION being the actual function, it can also be the `name'
319 of the piece of advice."
320 (declare (debug ([&or symbolp
("local" form
) ("var" sexp
) gv-place
]
322 (gv-letplace (getter setter
) (advice--normalize-place place
)
323 (macroexp-let2 nil new
`(advice--remove-function ,getter
,function
)
324 `(unless (eq ,new
,getter
) ,(funcall setter new
)))))
326 (defun advice-function-mapc (f function-def
)
327 "Apply F to every advice function in FUNCTION-DEF.
328 F is called with two arguments: the function that was added, and the
329 properties alist that was specified when it was added."
330 (while (advice--p function-def
)
331 (funcall f
(advice--car function-def
) (advice--props function-def
))
332 (setq function-def
(advice--cdr function-def
))))
334 (defun advice-function-member-p (advice function-def
)
335 "Return non-nil if ADVICE is already in FUNCTION-DEF.
336 Instead of ADVICE being the actual function, it can also be the `name'
337 of the piece of advice."
338 (advice--member-p advice
:use-both function-def
))
340 ;;;; Specific application of add-function to `symbol-function' for advice.
342 (defun advice--subst-main (old new
)
344 (lambda (first _rest _props
) (if (not first
) new
))))
346 (defun advice--normalize (symbol def
)
348 ((special-form-p def
)
349 ;; Not worth the trouble trying to handle this, I think.
350 (error "Advice impossible: %S is a special form" symbol
))
351 ((and (symbolp def
) (macrop def
))
352 (let ((newval `(macro .
,(lambda (&rest r
) (macroexpand `(,def .
,r
))))))
353 (put symbol
'advice--saved-rewrite
(cons def
(cdr newval
)))
355 ;; `f' might be a pure (hence read-only) cons!
356 ((and (eq 'macro
(car-safe def
))
357 (not (ignore-errors (setcdr def
(cdr def
)) t
)))
358 (cons 'macro
(cdr def
)))
361 (defsubst advice--strip-macro
(x)
362 (if (eq 'macro
(car-safe x
)) (cdr x
) x
))
364 (defun advice--symbol-function (symbol)
365 ;; The value conceptually stored in `symbol-function' is split into two
367 ;; - the normal function definition.
368 ;; - the list of advice applied to it.
369 ;; `advice--symbol-function' is intended to return the second part (i.e. the
370 ;; list of advice, which includes a hole at the end which typically holds the
371 ;; first part, but this function doesn't care much which value is found
373 ;; In the "normal" state both parts are combined into a single value stored
374 ;; in the "function slot" of the symbol. But the way they are combined is
375 ;; different depending on whether the definition is a function or a macro.
376 ;; Also if the function definition is nil (i.e. unbound) or is an autoload,
377 ;; the second part is stashed away temporarily in the `advice--pending'
379 (or (get symbol
'advice--pending
)
380 (advice--strip-macro (symbol-function symbol
))))
382 (defun advice--defalias-fset (fsetfun symbol newdef
)
383 (unless fsetfun
(setq fsetfun
#'fset
))
384 (when (get symbol
'advice--saved-rewrite
)
385 (put symbol
'advice--saved-rewrite nil
))
386 (setq newdef
(advice--normalize symbol newdef
))
387 (let ((oldadv (advice--symbol-function symbol
)))
388 (if (and newdef
(not (autoloadp newdef
)))
389 (let* ((snewdef (advice--strip-macro newdef
))
390 (snewadv (advice--subst-main oldadv snewdef
)))
391 (put symbol
'advice--pending nil
)
392 (funcall fsetfun symbol
393 (if (eq snewdef newdef
) snewadv
(cons 'macro snewadv
))))
394 (unless (eq oldadv
(get symbol
'advice--pending
))
395 (put symbol
'advice--pending
(advice--subst-main oldadv nil
)))
396 (funcall fsetfun symbol newdef
))))
399 (defun advice-add (symbol where function
&optional props
)
400 "Like `add-function' but for the function named SYMBOL.
401 Contrary to `add-function', this will properly handle the cases where SYMBOL
402 is defined as a macro, alias, command, ..."
404 ;; - record the advice location, to display in describe-function.
405 ;; - change all defadvice in lisp/**/*.el.
406 ;; - obsolete advice.el.
407 (let* ((f (symbol-function symbol
))
408 (nf (advice--normalize symbol f
)))
409 (unless (eq f nf
) (fset symbol nf
))
410 (add-function where
(cond
411 ((eq (car-safe nf
) 'macro
) (cdr nf
))
412 ;; Reasons to delay installation of the advice:
413 ;; - If the function is not yet defined, installing
414 ;; the advice would affect `fboundp'ness.
415 ;; - the symbol-function slot of an autoloaded
416 ;; function is not itself a function value.
417 ;; - `autoload' does nothing if the function is
418 ;; not an autoload or undefined.
419 ((or (not nf
) (autoloadp nf
))
420 (get symbol
'advice--pending
))
421 (t (symbol-function symbol
)))
423 (put symbol
'function-documentation
`(advice--make-docstring ',symbol
))
424 (add-function :around
(get symbol
'defalias-fset-function
)
425 #'advice--defalias-fset
))
429 (defun advice-remove (symbol function
)
430 "Like `remove-function' but for the function named SYMBOL.
431 Contrary to `remove-function', this also works when SYMBOL is a macro
432 or an autoload and it preserves `fboundp'.
433 Instead of the actual function to remove, FUNCTION can also be the `name'
434 of the piece of advice."
435 (let ((f (symbol-function symbol
)))
436 (remove-function (cond ;This is `advice--symbol-function' but as a "place".
437 ((get symbol
'advice--pending
)
438 (get symbol
'advice--pending
))
439 ((eq (car-safe f
) 'macro
) (cdr f
))
440 (t (symbol-function symbol
)))
442 (unless (advice--p (advice--symbol-function symbol
))
443 (remove-function (get symbol
'defalias-fset-function
)
444 #'advice--defalias-fset
)
445 (let ((asr (get symbol
'advice--saved-rewrite
)))
446 (and asr
(eq (cdr-safe (symbol-function symbol
))
448 (fset symbol
(car (get symbol
'advice--saved-rewrite
)))))))
452 (defmacro define-advice
(symbol args
&rest body
)
453 "Define an advice and add it to function named SYMBOL.
454 See `advice-add' and `add-function' for explanation on the
455 arguments. Note if NAME is nil the advice is anonymous;
456 otherwise it is named `SYMBOL@NAME'.
458 \(fn SYMBOL (WHERE LAMBDA-LIST &optional NAME DEPTH) &rest BODY)"
459 (declare (indent 2) (doc-string 3) (debug (sexp sexp body
)))
460 (or (listp args
) (signal 'wrong-type-argument
(list 'listp args
)))
461 (or (<= 2 (length args
) 4)
462 (signal 'wrong-number-of-arguments
(list 2 4 (length args
))))
463 (let* ((where (nth 0 args
))
464 (lambda-list (nth 1 args
))
467 (props (and depth
`((depth .
,depth
))))
468 (advice (cond ((null name
) `(lambda ,lambda-list
,@body
))
469 ((or (stringp name
) (symbolp name
))
470 (intern (format "%s@%s" symbol name
)))
471 (t (error "Unrecognized name spec `%S'" name
)))))
472 `(prog1 ,@(and (symbolp advice
) `((defun ,advice
,lambda-list
,@body
)))
473 (advice-add ',symbol
,where
#',advice
,@(and props
`(',props
))))))
475 (defun advice-mapc (fun symbol
)
476 "Apply FUN to every advice function in SYMBOL.
477 FUN is called with a two arguments: the function that was added, and the
478 properties alist that was specified when it was added."
479 (advice-function-mapc fun
(advice--symbol-function symbol
)))
482 (defun advice-member-p (advice symbol
)
483 "Return non-nil if ADVICE has been added to SYMBOL.
484 Instead of ADVICE being the actual function, it can also be the `name'
485 of the piece of advice."
486 (advice-function-member-p advice
(advice--symbol-function symbol
)))
488 ;; When code is advised, called-interactively-p needs to be taught to skip
489 ;; the advising frames.
490 ;; FIXME: This Major Ugly Hack won't handle calls to called-interactively-p
491 ;; done from the advised function if the deepest advice is an around advice!
492 ;; In other cases (calls from an advice or calls from the advised function when
493 ;; the deepest advice is not an around advice), it should hopefully get
495 (add-hook 'called-interactively-p-functions
496 #'advice--called-interactively-skip
)
497 (defun advice--called-interactively-skip (origi frame1 frame2
)
502 (setq frame2
(backtrace-frame i
#'called-interactively-p
))
503 ;; (message "Advice Frame %d = %S" i frame2)
505 (when (and (eq (nth 1 frame2
) 'apply
)
507 (funcall get-next-frame
)
508 (advice--p (indirect-function (nth 1 frame2
)))))
509 (funcall get-next-frame
)
510 ;; If we now have the symbol, this was the head advice and
512 (while (advice--p (nth 1 frame1
))
513 ;; This was an inner advice called from some earlier advice.
514 ;; The stack frames look different depending on the particular
515 ;; kind of the earlier advice.
516 (let ((inneradvice (nth 1 frame1
)))
517 (if (and (eq (nth 1 frame2
) 'apply
)
519 (funcall get-next-frame
)
520 (advice--p (indirect-function
522 ;; The earlier advice was something like a before/after
523 ;; advice where the "next" code is called directly by the
525 (funcall get-next-frame
)
526 ;; It's apparently an around advice, where the "next" is
527 ;; called by the body of the advice in any way it sees fit,
528 ;; so we need to skip the frames of that body.
531 (funcall get-next-frame
)
533 (not (and (eq (nth 1 frame2
) 'apply
)
534 (eq (nth 3 frame2
) inneradvice
))))))
535 (funcall get-next-frame
)
536 (funcall get-next-frame
))))
541 ;;; nadvice.el ends here