1 2011-09-12 Eli Zaretskii <eliz@gnu.org>
3 * indent.c (compute_motion): Process display vector front to back
4 rather than the other way around. (Bug#2496)
6 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
8 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
10 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
12 * minibuf.c (Fread_from_minibuffer): Doc fix.
14 2011-09-11 Eli Zaretskii <eliz@gnu.org>
16 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
17 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
19 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
21 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
22 value for non-existent files.
24 2011-09-11 Eli Zaretskii <eliz@gnu.org>
26 * fileio.c (Finsert_file_contents): If the file cannot be opened,
27 set its "size" to -1. This will set the modtime_size field of
28 the corresponding buffer to -1, which is what
29 verify-visited-file-modtime expects for files that do not exist.
32 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
34 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
36 * lisp.h: ... from here. push_key_description is no longer
37 defined in keyboard.c, so its declaration should not be in
38 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
39 logically belongs with push_key_description.
41 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
43 * buffer.h: Include <sys/types.h> instead of <time.h>.
44 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
45 Problem reported by Herbert J. Skuhra.
47 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
49 * xml.c (parse_region): Make the parsing work for
50 non-comment-starting XML files again (bug#9144).
52 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
54 * image.c (gif_load): Fix calculation of bottom and right corner.
57 2011-09-10 Eli Zaretskii <eliz@gnu.org>
59 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
60 redisplay in small windows.
62 2011-09-09 Eli Zaretskii <eliz@gnu.org>
64 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
66 2011-09-08 Martin Rudalics <rudalics@gmx.at>
68 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
69 Operate on live windows only.
71 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
73 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
75 2011-09-07 Eli Zaretskii <eliz@gnu.org>
77 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
78 only under bidi iteration.
80 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
82 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
84 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
86 isnan: Fix porting problem to Solaris 10 with bundled gcc.
87 Without this fix, the command to link temacs failed due to an
88 undefined symbol __builtin_isnan. This is because
89 /usr/include/iso/math_c99.h #defines isnan(x) to
90 __builtin_isnan(x), but the bundled gcc, which identifies itself
91 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
93 * floatfns.c (isnan): #undef, and then #define to a clone of
95 (Fisnan): Always define, since it's always available now.
96 (syms_of_floatfns): Always define isnan at the Lisp level.
98 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
100 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
102 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
104 * fileio.c: Fix bugs with large file offsets (Bug#9428).
105 The previous code assumed that file offsets (off_t values) fit in
106 EMACS_INT variables, which is not true on typical 32-bit hosts.
107 The code messed up by falsely reporting buffer overflow in cases
108 such as (insert-file-contents "big" nil 1 2) into an empty buffer
109 when "big" contains more than 2**29 bytes, even though this
110 inserts just one byte and does not overflow the buffer.
111 (Finsert_file_contents): Store file offsets as off_t
112 values, not as EMACS_INT values. Check for overflow when
113 converting between EMACS_INT and off_t. When checking for
114 buffer overflow or for overlap, take the offsets into account.
115 Don't use EMACS_INT for small values where int suffices.
116 When checking for overlap, fix a typo: ZV was used where
117 ZV_BYTE was intended.
118 (Fwrite_region): Don't assume off_t fits into 'long'.
119 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
121 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
123 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
125 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
127 sprintf-related integer and memory overflow issues (Bug#9412).
129 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
130 (esprintf, exprintf, evxprintf): New functions.
131 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
132 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
133 (modify_event_symbol): Do not assume that the length of
134 name_alist_or_stem is safe to alloca and fits in int.
135 (Fexecute_extended_command): Likewise for function name and binding.
136 (Frecursion_depth): Wrap around reliably on integer overflow.
137 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
138 since some callers pass EMACS_INT values.
139 (Fsingle_key_description): Don't crash if symbol name contains more
140 than MAX_ALLOCA bytes.
141 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
142 (get_minibuffer): Arg is now EMACS_INT, not int.
143 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
144 (esprintf, exprintf, evxprintf): New decls.
145 * window.h (command_loop_level, minibuf_level): Reflect API changes.
147 * dbusbind.c (signature_cat): New function.
148 (xd_signature, Fdbus_register_signal):
149 Do not overrun buffer; instead, report string overflow.
151 * dispnew.c (add_window_display_history): Don't overrun buffer.
152 Truncate instead; this is OK since it's just a log.
154 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
155 even if the time zone offset is outlandishly large.
156 Don't mishandle offset == INT_MIN.
158 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
159 when creating daemon; the previous buffer-overflow check was incorrect.
161 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
162 which has the guts of the old verror function.
164 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
165 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
167 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
168 (font_unparse_xlfd): Don't blindly alloca long strings.
169 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
170 fits in int, when using sprintf. Use single snprintf to count
171 length of string rather than counting it via multiple sprintfs;
172 that's simpler and more reliable.
173 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
174 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
175 sprintf, in case result does not fit in int.
177 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
178 (fontset_from_font): Print it.
180 * frame.c (tty_frame_count): Now printmax_t, not int.
181 (make_terminal_frame, set_term_frame_name): Print it.
182 (x_report_frame_params): In X, window IDs are unsigned long,
183 not signed long, so print them as unsigned.
184 (validate_x_resource_name): Check for implausibly long names,
185 and don't assume name length fits in 'int'.
186 (x_get_resource_string): Don't blindly alloca invocation name;
187 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
190 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
191 (xg_check_special_colors, xg_set_geometry):
192 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
194 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
195 Use esprintf, not sprintf, in case result does not fit in int.
197 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
198 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
199 it as a large positive number.
200 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
201 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
203 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
204 in case result does not fit in int.
206 * print.c (float_to_string): Detect width overflow more reliably.
207 (print_object): Make sprintf buffer a bit bigger, to avoid potential
208 buffer overrun. Don't assume list length fits in 'int'. Treat
209 print length of 0 as 0, not as infinity; to be consistent with other
210 uses of print length in this function. Don't overflow print length
211 index. Don't assume hash table size fits in 'long', or that
212 vectorlike size fits in 'unsigned long'.
214 * process.c (make_process): Use printmax_t, not int, to format
215 process-name gensyms.
217 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
219 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
220 to avoid potential buffer overrun.
222 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
223 if X resource line is longer than 512 bytes.
225 * xfns.c (x_window): Make sprintf buffer a bit bigger
226 to avoid potential buffer overrun.
228 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
230 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
232 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
234 Integer overflow fixes for scrolling, etc.
235 Without these, Emacs silently mishandles large integers sometimes.
236 For example, "C-u 4294967297 M-x recenter" was treated as if
237 it were "C-u 1 M-x recenter" on a typical 64-bit host.
239 * xdisp.c (try_window_id): Check Emacs fixnum range before
242 * window.c (window_scroll_line_based, Frecenter):
243 Check that an Emacs fixnum is in range before assigning it to 'int'.
244 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
245 values converted from Emacs fixnums.
246 (Frecenter): Don't wrap around a line count if it is out of 'int'
247 range; instead, treat it as an extreme value.
248 (Fset_window_configuration, compare_window_configurations):
249 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
251 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
252 that can exceed INT_MAX. Check that EMACS_INT value is in range
253 before assigning it to the (possibly-narrower) index.
254 (match_limit): Don't assume that a fixnum can fit in 'int'.
256 * print.c (print_object): Use ptrdiff_t, not int, for index that can
259 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
260 (Fvertical_motion): Don't wrap around LINES values that don't fit
261 in 'int'. Instead, treat them as extreme values. This is good
262 enough for windows, which can't have more than INT_MAX lines anyway.
264 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
266 * Require libxml/parser.h to avoid compilation warning.
268 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
270 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
271 since this reportedly can destroy thread storage.
273 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
275 * syntax.c (find_defun_start): Update all cache variables if
276 exiting early (Bug#9401).
278 2011-08-30 Eli Zaretskii <eliz@gnu.org>
280 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
282 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
283 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
284 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
286 * term.c (tty_append_glyph): New function.
287 (produce_stretch_glyph): Static function and its prototype deleted.
289 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
292 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
294 * image.c (parse_image_spec): Check for nonnegative, not for positive,
295 when checking :margin (Bug#9390).
296 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
297 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
298 so that the name doesn't mislead. All uses changed.
300 2011-08-28 Johan Bockgård <bojohan@gnu.org>
302 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
305 2011-08-27 Eli Zaretskii <eliz@gnu.org>
307 * xdisp.c (move_it_to): Don't bail out early when reaching
308 position beyond to_charpos, if we are scanning backwards.
309 (move_it_vertically_backward): When DY == 0, make sure we get to
310 the first character in the line after the newline.
312 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
314 * ccl.c: Improve and simplify overflow checking (Bug#9196).
315 (ccl_driver): Do not generate an out-of-range pointer.
316 (Fccl_execute_on_string): Remove unnecessary check for
317 integer overflow, noted by Stefan Monnier in
318 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
319 Remove a FIXME that didn't need fixing.
320 Simplify the newly-introduced buffer reallocation code.
322 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
324 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
326 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
328 Integer and memory overflow issues (Bug#9196).
330 * doc.c (get_doc_string): Rework so that
331 get_doc_string_buffer_size is the actual buffer size, rather than
332 being 1 less than the actual buffer size; this makes xpalloc more
335 * image.c (x_allocate_bitmap_record, cache_image):
336 * xselect.c (Fx_register_dnd_atom):
337 Simplify previous changes by using xpalloc.
339 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
340 since either will do and ptrdiff_t is convenient with xpalloc.
342 * charset.c (charset_table_size)
343 (struct charset_sort_data.priority): Now ptrdiff_t.
344 (charset_compare): Don't overflow if priorities differ greatly.
345 (Fsort_charsets): Don't assume list length fits in int.
346 Check for size-calculation overflow when allocating sort data.
347 (syms_of_charset): Allocate an initial charset table that is
348 just under 64 KiB, to avoid problems with glibc malloc and mmap.
350 * cmds.c (internal_self_insert): Check for size-calculation overflow.
352 * composite.h (struct composition.glyph_len): Now int, not unsigned.
353 The actual value is always <= INT_MAX, and leaving it unsigned made
354 overflow checking harder.
356 * dispextern.h (struct glyph_matrix.rows_allocated)
357 (struct face_cache.size): Now ptrdiff_t, for convenience in use
358 with xpalloc. The values are still always <= INT_MAX.
360 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
362 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
363 (SAFE_NALLOCA): New macro.
365 * region-cache.c (struct boundary.pos, find_cache_boundary)
366 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
367 (set_cache_region, invalidate_region_cache)
368 (revalidate_region_cache, know_region_cache, region_cache_forward)
369 (region_cache_backward, pp_cache):
370 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
371 so that ptrdiff_t * can be passed to xpalloc.
372 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
373 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
374 (pp_cache): Don't assume cache_len fits in int.
375 * region-cache.h: Adjust extern decls to match.
377 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
378 EMACS_INT, since either will do, for xpalloc.
380 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
381 (xnmalloc, xnrealloc, xpalloc): New functions.
383 * bidi.c (bidi_shelve_header_size): New constant.
384 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
385 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
387 * bidi.c (bidi_cache_shrink):
388 * buffer.c (overlays_at, overlays_in, record_overlay_string)
390 Don't update size of array until after memory allocation succeeds,
391 because xmalloc/xrealloc may not return.
392 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
393 now that we have proper integer overflow checking.
394 (record_overlay_string, overlay_strings): Catch overflows when
395 calculating size of overlay_str_buf.
397 * callproc.c (Fcall_process): Check for size overflow when
398 calculating size of args2.
399 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
400 Normally we prefer signed values, but sticking with ptrdiff_t would
401 require adding more-complicated checks.
403 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
404 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
405 Redo buffer-overflow calculations to avoid integer overflow.
406 Add a FIXME comment where memory seems to be over-allocated.
408 * character.c (Fstring): Check for size-calculation overflow.
410 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
411 unnecessary integer overflow. Check for size overflow.
412 (encode_coding_object): Don't update size until xmalloc succeeds.
414 * composite.c (get_composition_id): Check for overflow in glyph
417 Integer and memory overflow fixes for display code.
418 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
419 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
420 (scrolling_window): Check for overflow in size calculations.
421 (line_draw_cost, realloc_glyph_pool, add_row_entry):
422 Don't assume glyph table len fits in int.
423 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
424 (row_table_size): Now ptrdiff_t, not int.
425 (scrolling_window): Avoid overflow in size calculations.
426 Don't update size until allocation succeeds.
427 * fns.c (concat): Check for overflow in size calculations.
428 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
429 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
430 (NEXT_ALMOST_PRIME_LIMIT): New constant.
432 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
433 (get_doc_string): Check for size calculation overflow.
434 Don't update size until allocation succeeds.
435 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
436 EMACS_INT, where ptrdiff_t will do.
437 (Fsubstitute_command_keys): Check for string overflow.
439 * editfns.c (set_time_zone_rule): Don't assume environment length
441 (message_length): Now ptrdiff_t, not int.
442 (Fmessage_box): Don't update size until allocation succeeds.
443 Don't assume message length fits in int.
444 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
446 * emacs.c (main): Do not reallocate argv, since there is a null at
447 the end that can be overwritten, and this way there's no need to
448 worry about size-calculation overflow.
449 (sort_args): Check for size-calculation overflow.
451 * eval.c (init_eval_once, grow_specpdl): Don't update size until
453 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
455 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
456 (x_set_scroll_bar_width, x_figure_window_size):
457 Check for integer overflow.
458 (x_set_alpha): Do not assume XINT fits in int.
460 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
461 This is for the members text_lines, text_cols, total_lines, total_cols,
462 where the system imposes an 'int' limit.
464 * fringe.c (Fdefine_fringe_bitmap):
465 Don't update size until alloc works.
467 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
468 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
470 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
471 Check for size-calculation overflow.
472 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
473 do, as we prefer signed integers.
474 (id_to_widget.max_size, id_to_widget.used)
475 (xg_store_widget_in_map, xg_remove_widget_from_map)
476 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
477 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
478 Use and return ptrdiff_t, not int.
479 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
480 * gtkutil.h: Change prototypes to match the above.
482 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
483 are duplicate now that they've been promoted to lisp.h.
484 (x_allocate_bitmap_record, x_alloc_image_color)
485 (make_image_cache, cache_image, xpm_load):
486 Don't update size until alloc is done.
487 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
489 Check for size calculation overflow.
490 (ct_colors_allocated_max): New constant.
491 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
494 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
495 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
496 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
497 Use ptrdiff_t, not int, to count maps.
498 (read_char_minibuf_menu_prompt): Check for overflow in size
499 calculations. Don't update size until allocation succeeds. Redo
500 calculations to avoid overflow.
501 * keyboard.h: Change prototypes to match the above.
503 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
505 (current_minor_maps): Check for size calculation overflow.
506 * keymap.h: Change prototypes to match the above.
508 * lread.c (read1, init_obarray): Don't update size until alloc done.
510 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
511 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
513 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
514 Now ptrdiff_t, not int.
515 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
516 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
518 * process.c (Fnetwork_interface_list): Check for overflow
521 * region-cache.c (move_cache_gap): Check for size calculation overflow.
523 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
524 overflow. Don't bother calling xmalloc when xrealloc will do.
526 * search.c (Freplace_match): Check for size calculation overflow.
527 (Fset_match_data): Don't assume list lengths fit in 'int'.
529 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
530 for command line length. Do not attempt to address one before the
531 beginning of an array, as that's not portable.
533 * term.c (max_frame_lines): Remove; unused.
534 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
536 (encode_terminal_code, calculate_costs): Check for size
537 calculation overflow.
538 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
539 table lengths and related sizes. Don't update size until alloc
540 done. Redo calculations to avoid overflow.
541 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
543 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
544 subtracting pointers.
545 (gobble_line): Check for overflow more carefully. Don't update size
548 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
549 Don't update size until alloc done.
550 Redo size calculations to avoid overflow.
551 Check for size calculation overflow.
552 (main) [DEBUG]: Fix typo in invoking tparam1.
554 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
555 Use ptrdiff_t, not int, for sizes.
556 (store_mode_line_noprop_char): Don't update size until alloc done.
558 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
559 Use ptrdiff_t, not int, for sizes.
560 (Finternal_make_lisp_face, cache_face):
561 Check for size calculation overflow.
562 (cache_face): Treat size calculation overflows as if they were
563 memory exhaustion (the usual treatment), rather than aborting.
565 * xfns.c (x_encode_text, x_set_name_internal)
566 (Fx_change_window_property): Use ptrdiff_t, not int, to count
567 sizes, since they can exceed INT_MAX in size. Check for size
568 calculation overflow.
570 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
571 (xg_select): Check for size calculation overflow.
572 Don't update size until alloc done.
574 * xrdb.c (get_environ_db): Don't assume path length fits in int,
575 as sprintf is limited to int lengths.
577 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
578 (X_LONG_MIN): New macros.
579 Use them to make the following changes clearer.
580 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
581 This change doesn't affect the value now, but it may help remind
582 future maintainers not to raise the value too much later.
583 (SELECTION_QUANTUM): Remove, replacing with ...
584 (selection_quantum): ... new function, which avoids overflow.
586 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
587 assumption that selection length fits in 'int'.
588 (x_reply_selection_request, x_handle_selection_request)
589 (x_get_window_property, receive_incremental_selection)
590 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
591 (lisp_data_to_selection_data, clean_local_selection_data):
592 Use ptrdiff_t, not int, to record length of selection.
593 (x_reply_selection_request, x_get_window_property)
594 (receive_incremental_selection, x_property_data_to_lisp):
595 Redo calculations to avoid overflow.
596 (x_reply_selection_request): When sending hint, ceiling it at
597 X_LONG_MAX rather than relying on wraparound overflow to send
599 (x_get_window_property, receive_incremental_selection)
600 (lisp_data_to_selection_data, x_property_data_to_lisp):
601 Check for size-calculation overflow.
602 (x_get_window_property, receive_incremental_selection)
603 (lisp_data_to_selection_data, Fx_register_dnd_atom):
604 Don't store size until memory allocation succeeds.
605 (x_get_window_property): Plug memory leak on memory exhaustion.
606 Don't double-block input; malloc is safe here. Don't assume 2**34
607 - 4 fits in unsigned long. Add an xassert to check
608 XGetWindowProperty overflow. Be more careful about overflow
609 calculations, and distinguish size from memory overflow better.
610 (receive_incremental_selection): When tracing, don't assume
611 unsigned int is less than INT_MAX.
612 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
613 harmful) conversions of unsigned short to int.
614 (lisp_data_to_selection_data): Don't assume that integers
615 in the range -65535 through -1 fit in an X unsigned short.
616 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
617 result parameters unless successful. Rely on cons_to_unsigned
618 to report problems with elements; the old code wasn't right anyway.
619 (x_check_property_data): Check for int overflow; we cannot use
620 a wider type due to X limits.
621 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
623 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
625 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
626 (x_term_init): Check for size calculation overflow.
627 (x_color_cells): Don't store size until memory allocation succeeds.
628 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
629 Don't assume alloca size is less than MAX_ALLOCA.
630 (x_term_init): Don't assume length fits in int (sprintf is limited
633 Use ptrdiff_t for composition IDs.
634 * character.c (lisp_string_width):
635 * composite.c (composition_table_size, n_compositions)
636 (get_composition_id, composition_gstring_from_id):
637 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
638 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
639 * window.c (Frecenter):
640 Use ptrdiff_t, not int, for composition IDs.
641 * composite.c (get_composition_id): Check for integer overflow.
642 * composite.h: Adjust prototypes to match the above changes.
644 Use ptrdiff_t for hash table indexes.
645 * category.c (hash_get_category_set):
646 * ccl.c (ccl_driver):
647 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
648 * coding.c (coding_system_charset_list, detect_coding_system):
649 * coding.h (struct coding_system.id):
650 * composite.c (get_composition_id, gstring_lookup_cache):
651 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
652 * image.c (xpm_get_color_table_h):
653 * lisp.h (hash_lookup, hash_put):
654 * minibuf.c (Ftest_completion):
655 Use ptrdiff_t for hash table indexes, not int (which is too
656 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
657 32-bit --with-wide-int hosts).
659 * charset.c (Fdefine_charset_internal): Check for integer overflow.
660 Add a FIXME comment about memory leaks.
661 (syms_of_charset): Don't assume xmalloc returns.
663 Don't assume that stated character widths fit in int.
664 * character.c (Fchar_width, c_string_width, lisp_string_width):
665 * character.h (CHAR_WIDTH):
666 * indent.c (MULTIBYTE_BYTES_WIDTH):
667 Use sanitize_char_width to avoid undefined and/or bad behavior
668 with outlandish widths.
669 * character.h (sanitize_tab_width): Renamed from sanitize_width,
670 now that we have two such functions. All uses changed.
671 (sanitize_char_width): New inline function.
673 Don't assume that tab-width fits in int.
674 * character.h (sanitize_width): New inline function.
675 (SANE_TAB_WIDTH): New macro.
676 (ASCII_CHAR_WIDTH): Use it.
677 * indent.c (sane_tab_width): Remove. All uses replaced by
678 SANE_TAB_WIDTH (current_buffer).
679 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
681 * fileio.c: Integer overflow issues with file modes.
682 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
684 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
685 Remove unreachable code.
686 (read_hex, load_charset_map_from_file): Check for integer overflow.
688 * xterm.c: don't go over XClientMessageEvent limit
689 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
690 (x_send_scroll_bar_event): Likewise. Check that the size does not
691 exceed limits imposed by XClientMessageEvent, as well as the usual
692 ptrdiff_t and size_t limits.
694 * keyboard.c: Overflow, signedness and related fixes.
695 (make_lispy_movement): Use same integer type in forward decl
696 that is used in the definition.
697 (read_key_sequence, keyremap_step):
698 Change bufsize argument back to int, undoing my 2011-03-30 change.
699 We prefer signed types, and int is wide enough here.
700 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
701 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
702 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
703 length, not size_t. Use ptrdiff_t for index, not int.
704 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
705 possibility of integer overflow.
707 Overflow, signedness and related fixes for images.
709 * dispextern.h (struct it.stack[0].u.image.image_id)
710 (struct_it.image_id, struct image.id, struct image_cache.size)
711 (struct image_cache.used, struct image_cache.ref_count):
712 * gtkutil.c (update_frame_tool_bar):
713 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
714 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
715 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
716 * nsmenu.m (update_frame_tool_bar):
717 * xdisp.c (calc_pixel_width_or_height):
718 * xfns.c (image_cache_refcount):
719 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
720 on typical 64-bit hosts.
722 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
723 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
724 Omit unnecessary casts to int.
725 (parse_image_spec): Check that integers fall into 'int' range
726 when the callers expect that.
727 (image_ascent): Redo ascent calculation to avoid int overflow.
728 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
729 (lookup_image): Remove unnecessary tests.
730 (xbm_image_p): Locals are now of int, not EMACS_INT,
731 since parse_image_check makes sure they fit into int.
732 (png_load, gif_load, svg_load_image):
733 Prefer int to unsigned where either will do.
734 (tiff_handler): New function, combining the cores of the
735 old tiff_error_handler and tiff_warning_handler. This
736 function is rewritten to use vsnprintf and thereby avoid
737 stack buffer overflows. It uses only the features of vsnprintf
738 that are common to both POSIX and native Microsoft.
739 (tiff_error_handler, tiff_warning_handler): Use it.
740 (tiff_load, gif_load, imagemagick_load_image):
741 Don't assume :index value fits in 'int'.
742 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
743 (imagemagick_load_image): Check that crop parameters fit into
744 the integer types that MagickCropImage accepts. Don't assume
745 Vimagemagick_render_type has a nonnegative value. Don't assume
746 size_t fits in 'long'.
747 (gs_load): Use printmax_t to print the widest integers possible.
748 Check for integer overflow when computing image height and width.
750 2011-08-26 Eli Zaretskii <eliz@gnu.org>
752 * xdisp.c (redisplay_window): Don't force window start if point
753 will be invisible in the resulting window. (Bug#9324)
755 2011-08-25 Eli Zaretskii <eliz@gnu.org>
757 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
758 the display spec is of the form `(space ...)'.
759 (handle_display_spec): Return the value returned by
760 handle_single_display_spec, not just 1 or zero.
761 (handle_single_display_spec): If the display spec is of the form
762 `(space ...)', and specifies display in the text area, return 2
764 (try_cursor_movement): Check for the need to scroll more
765 accurately, and prefer exact match for point under bidi. Don't
766 advance `row' beyond the last row of the window.
768 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
769 into disp_prop; all users changed.
771 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
772 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
773 for the text covered by the display property.
775 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
777 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
778 Change return value to nil.
779 (Frecord_buffer): Delete unused function.
781 2011-08-24 Eli Zaretskii <eliz@gnu.org>
783 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
784 buffers, return left-to-right.
785 (set_cursor_from_row): Consider candidate row a win if its glyph
786 represents a newline and point is on that newline. Fixes cursor
787 positioning on the newline at EOL of R2L text within L2R
788 paragraph, and vice versa.
789 (try_cursor_movement): Check continued rows, in addition to
790 continuation rows. Fixes unwarranted scroll when point enters a
791 continued line of R2L text within an L2R paragraph, or vice versa.
792 (cursor_row_p): Consider the case of point being equal to
793 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
794 from the end of a short line to the beginning of a continued line
795 of R2L text within L2R paragraph.
796 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
799 * bidi.c (bidi_check_type): Use xassert.
800 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
803 2011-08-23 Eli Zaretskii <eliz@gnu.org>
805 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
808 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
810 * nsfont.m (ns_otf_to_script): Fix typo.
812 2011-08-22 Kenichi Handa <handa@m17n.org>
814 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
815 extra slot even if the purpose is char-code-property-table.
817 2011-08-23 Eli Zaretskii <eliz@gnu.org>
819 * xdisp.c (redisplay_window): When computing centering_position,
820 account for the height of the header line. (Bug#8874)
822 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
823 instead of CHAR_TO_BYTE. Fixes a crash when a completion
824 candidate is selected by the mouse, and that candidate has a
825 composed character under the mouse.
827 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
828 coordinates reported by pos-visible-in-window-p for a composed
829 character in column zero.
831 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
833 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
835 2011-08-22 Eli Zaretskii <eliz@gnu.org>
837 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
838 consider it a hit if to_charpos is anywhere in the range of the
839 composed buffer positions.
841 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
843 * image.c (gif_load): Don't assume that each subimage has the same
844 dimensions as the base image. Handle disposal method that is
845 "undefined" by the gif spec (Bug#9335).
847 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
849 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
850 (Fcondition_case): Document `debug' symbol in error handler.
852 2011-08-19 Eli Zaretskii <eliz@gnu.org>
854 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
855 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
856 from an Org mode buffer to a Speedbar frame.
858 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
859 a composition, take its buffer position from IT->cmp_it.charpos.
860 Fixes cursor positioning at the beginning of a line that begins
861 with a composed character.
863 2011-08-18 Eli Zaretskii <eliz@gnu.org>
865 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
866 character bidirectional type, use STRONG_L instead. Fixes crashes
867 in a buffer produced by `describe-categories'.
869 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
870 members before the level stack, so they would be saved and
871 restored when copying iterator state. Fixes incorrect reordering
872 around TABs covered by display properties.
874 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
876 * process.c (Fnetwork_interface_list): Correctly determine buffer
879 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
881 * eval.c (internal_condition_case, internal_condition_case_1)
882 (internal_condition_case_2, internal_condition_case_n):
883 Remove unnecessary aborts (Bug#9081).
885 2011-08-17 Eli Zaretskii <eliz@gnu.org>
887 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
888 has no `load' handler, try opening the file locally. (Bug#9311)
890 2011-08-16 Ken Brown <kbrown@cornell.edu>
892 * gmalloc.c: Expand comment.
894 2011-08-16 Eli Zaretskii <eliz@gnu.org>
896 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
897 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
899 2011-08-16 Ken Brown <kbrown@cornell.edu>
901 Fix memory allocation problems in Cygwin build (Bug#9273).
903 * unexcw.c ( __malloc_initialized): Declare external variable.
904 (fixup_executable): Force the dumped emacs to reinitialize malloc.
906 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
908 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
910 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
912 [CYGWIN] (special_realloc): New function.
913 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
914 requests to realloc storage in the static heap.
916 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
918 * bidi.c (bidi_initialize): Remove unused local.
920 2011-08-15 Eli Zaretskii <eliz@gnu.org>
922 * biditype.h: File removed.
924 * bidimirror.h: File removed.
926 * deps.mk (bidi.o): Remove biditype.h and
929 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
932 * dispextern.h: Fix a typo in the comment to bidi_type_t.
934 * chartab.c: Improve commentary for the uniprop_table API.
936 * bidi.c (bidi_paragraph_init): Support zero value of
937 bidi_ignore_explicit_marks_for_paragraph_level.
938 (bidi_initialize): Use uniprop_table instead of including
939 biditype.h and bidimirror.h.
941 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
942 coordinates of the iterator when restoring from ppos_it.
945 2011-08-14 Kenichi Handa <handa@m17n.org>
947 * process.c (create_process): Call setup_process_coding_systems
948 after the pid of the process is set to -1 (Bug#8162).
950 2011-08-14 Eli Zaretskii <eliz@gnu.org>
952 * xdisp.c (move_it_in_display_line_to): Don't invoke
953 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
954 ppos_it. Fixes vertical cursor motion when line beginning is
955 covered by an image. (Bug#9296)
957 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
959 * nsterm.h (ns_run_ascript): Declare.
960 (NSAPP_DATA2_RUNASSCRIPT): Define.
962 * nsfns.m (as_script, as_result, as_status): New static variables.
963 (ns_run_ascript): New function.
964 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
965 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
966 the event loop. Get status from as_status (Bug#7276).
968 * nsterm.m (sendEvent): If event is NSApplicationDefined and
969 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
970 the event loop (Bug#7276).
972 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
974 * gnutls.c (QCgnutls_bootprop_priority)
975 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
976 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
977 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
978 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
979 (QCgnutls_bootprop_verify_hostname_error)
980 (QCgnutls_bootprop_callbacks_verify): Rename from
981 Qgnutls_bootprop_..., all uses changed.
983 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
986 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
988 * xfaces.c (Qframe_set_background_mode): Now static.
989 * dispextern.h (Qframe_set_background_mode): Remove decl.
991 * process.c (Fnetwork_interface_info): Declare local only if needed.
993 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
995 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
996 (Fnetwork_interface_list): Allocate in increments of bytes instead
997 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
998 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1000 (struct ifflag_def): notrailers is smart on OSX.
1001 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1002 Get hardware address with getifaddrs if available.
1004 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1006 * xdisp.c (iterate_out_of_display_property): xassert that
1007 IT->position is set to within IT->object's boundaries. Break from
1008 the loop as soon as EOB is reached; avoids infloops in redisplay
1009 when IT->position is set up wrongly due to some bug.
1010 Set IT->current to match the bidi iterator unconditionally.
1011 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1012 entry. Force push_it to save on the stack the current
1013 buffer/string position, to be restored by pop_it. Fix flags in
1014 the iterator structure wrt the object coming from a display
1015 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1016 properties. (Bug#9284)
1018 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1020 * fontset.c (fontset_get_font_group): Add proper type checks.
1023 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1025 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1026 and LC_VERSION_MIN_MACOSX.
1027 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1028 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1030 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1032 * xdisp.c (forward_to_next_line_start): Allow to use the
1033 no-display-properties-and-no-overlays under bidi display.
1034 Set disp_pos in the bidi iterator to avoid searches for display
1035 properties and overlays.
1037 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1039 * editfns.c (Fset_time_zone_rule): Document relationship with the
1042 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1043 the font entity extracted from the cache (Bug#8109).
1045 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1047 * composite.c (autocmp_chars): Don't reset point. That is done by
1048 restore_point_unwind (Bug#5984).
1050 2011-08-07 Juri Linkov <juri@jurta.org>
1052 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1053 to show the arg `TIME' instead of `TIMEVAL'.
1055 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1057 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1058 display property strides EOL and includes a newline, as in
1059 longlines-mode. (Bug#9254)
1060 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1061 word-wrap under bidirectional display. (Bug#9224)
1063 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1064 is non-zero, even if the data buffer is NULL. Fixes a crash in
1065 vertical-motion with longlines-mode. (Bug#9254)
1067 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1069 * bidi.c <bidi_cache_total_alloc>: Now static.
1070 (bidi_initialize): Initialize bidi_cache_total_alloc.
1072 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1075 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1076 amount allocated this far in `bidi_cache_total_alloc'.
1077 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1078 non-zero, only free the data buffer without restoring the cache
1079 contents. All callers changed.
1081 * dispextern.h (bidi_unshelve_cache): Update prototype.
1083 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1084 (move_it_in_display_line, move_it_to)
1085 (move_it_vertically_backward, move_it_by_lines): Replace the call
1086 to xfree to an equivalent call to bidi_unshelve_cache.
1087 (move_it_in_display_line_to): Fix logic of returning
1088 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1090 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1092 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1093 came from a string character with a `cursor' property. (Bug#9229)
1095 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1097 * Makefile.in (LIB_PTHREAD): New variable.
1098 (LIBES): Add LIB_PTHREAD (Bug#9216).
1100 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1101 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1103 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1105 * regex.c (re_iswctype): Remove some redundant boolean
1108 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1110 * xterm.c (x_find_topmost_parent): New function.
1111 (x_set_frame_alpha): Find topmost parent window with
1112 x_find_topmost_parent and set the property there also (bug#9181).
1113 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1115 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1117 * callproc.c (Fcall_process): Avoid vfork clobbering
1118 the local vars buffer, coding_systems, current_dir.
1120 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1122 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1124 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1126 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1127 so that it is not optimized away.
1129 * xdisp.c (compute_display_string_pos): Remove unused local.
1131 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1133 Fix slow cursor motion and scrolling in large buffers with
1134 selective display, like Org Mode buffers. (Bug#9218)
1136 * dispextern.h (struct bidi_it): New member disp_prop_p.
1138 * xdisp.c: Remove one-slot cache of display string positions.
1139 (compute_display_string_pos): Accept an additional argument
1140 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1141 for a display string or property. If found, set DISP_PROP_P
1144 * bidi.c (bidi_fetch_char): Accept an additional argument
1145 DISP_PROP_P, and pass it to compute_display_string_pos.
1146 Only handle text covered by a display string if DISP_PROP_P is returned
1147 non-zero. All callers of bidi_fetch_char changed.
1149 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1151 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1153 2010-12-03 Don March <don@ohspite.net>
1155 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1156 last character M-[char] is translated to ESC [char] (bug#7541).
1158 2011-08-02 Kenichi Handa <handa@m17n.org>
1160 * lisp.h (uniprop_table): Extern it.
1162 * chartab.c (uniprop_table): Make it non-static.
1164 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1166 * xdisp.c (forward_to_next_line_start): Accept additional argument
1167 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1169 (reseat_at_next_visible_line_start): Use the bidi iterator state
1170 returned by forward_to_next_line_start to restore the state of
1171 it->bidi_it after backing up to previous newline. (Bug#9212)
1173 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1175 * regex.c (re_comp): Protoize.
1176 (re_exec): Fix return type.
1177 (regexec): Fix type of `ret'. (Bug#9203)
1179 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1181 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1182 This is needed if max-image-size is a floating-point number.
1184 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1186 * print.c (print_object): Print empty symbol as ##.
1188 * lread.c (read1): Read ## as empty symbol.
1190 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1192 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1193 setting frame foreground color (Bug#9175).
1194 (x_set_background_color): Likewise.
1196 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1197 contents (Bug#9176).
1198 (EmacsTooltip -init): Remove bezels and add shadows to
1201 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1202 or scroll bar (Bug#8470).
1204 * nsfont.m (nsfont_open): Remove assignment to voffset and
1205 unnecessary vars hshink, expand, hd, full_height, min_height.
1206 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1208 * nsterm.h (nsfont_info): Remove voffset field.
1210 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1212 Implement strike-through and overline on NextStep (Bug#8863).
1214 * nsfont.m (nsfont_open): Use underline position provided by font,
1215 instead of hard-coded value of 2.
1216 (nsfont_draw): Call ns_draw_text_decoration instead.
1218 * nsterm.h: Add declaration for ns_draw_text_decoration.
1220 * nsterm.m (ns_draw_text_decoration): New function for drawing
1221 underline, overline, and strike-through.
1222 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1223 ns_draw_text_decoration. Change treatment of cursor drawing to
1224 accomodate underlining, etc.
1226 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1228 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1231 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1233 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1234 Without this fix, if a signal arrives just after memory fills up,
1235 'malloc' might be invoked reentrantly.
1237 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1238 In other words, assume that every image size is allowed, on non-X
1239 hosts. This assumption is probably wrong, but it lets Emacs compile.
1241 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1243 * regex.c (re_iswctype): Convert return values to boolean.
1245 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1247 * xdisp.c (compute_display_string_pos): Don't use cached display
1248 string position if the buffer had its restriction changed.
1251 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1253 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1255 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1257 Integer signedness and overflow and related fixes. (Bug#9079)
1259 * bidi.c: Integer size and overflow fixes.
1260 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1261 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1262 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1263 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1264 (bidi_find_other_level_edge):
1265 Use ptrdiff_t instead of EMACS_INT where either will do.
1266 This works better on 32-bit hosts configured --with-wide-int.
1267 (bidi_cache_ensure_space): Check for size-calculation overflow.
1268 Use % rather than repeated addition, for better worst-case speed.
1269 Don't set bidi_cache_size until after xrealloc returns, because it
1271 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1272 (bidi_cache_ensure_space): Also check that the bidi cache size
1273 does not exceed that of the largest Lisp string or buffer. See Eli
1274 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1276 * alloc.c (__malloc_size_t): Remove.
1277 All uses replaced by size_t. See Andreas Schwab's note
1278 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1280 * image.c: Improve checking for integer overflow.
1281 (check_image_size): Assume that f is nonnull, since
1282 it is always nonnull in practice. This is one less thing to
1283 worry about when checking for integer overflow later.
1284 (x_check_image_size): New function, which checks for integer
1285 overflow issues inside X.
1286 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1287 This removes the need for a memory_full check.
1288 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1289 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1290 (xbm_read_bitmap_data): Change locals back to 'int', since
1291 their values must fit in 'int'.
1292 (xpm_load_image, png_load, tiff_load):
1293 Invoke x_create_x_image_and_pixmap earlier,
1294 to avoid much needless work if the image is too large.
1295 (tiff_load): Treat overly large images as if
1296 x_create_x_image_and_pixmap failed, not as malloc failures.
1297 (gs_load): Use x_check_image_size.
1299 * gtkutil.c: Omit integer casts.
1300 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1301 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1303 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1305 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1306 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1307 would wrongly return t on a 64-bit host.
1309 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1310 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1311 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1312 and therefore cause GCC to emit a bogus diagnostic in some cases.
1314 * image.c: Integer signedness and overflow and related fixes.
1315 This is not an exhaustive set of fixes, but it's time to
1316 record what I've got.
1317 (lookup_pixel_color, check_image_size): Remove redundant decls.
1318 (check_image_size): Don't assume that arbitrary EMACS_INT values
1319 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1320 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1321 (tiff_load, imagemagick_load_image):
1322 Check for overflow in size calculations.
1323 (x_create_x_image_and_pixmap): Remove unnecessary test for
1324 xmalloc returning NULL; that can't happen.
1325 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1326 (xpm_color_bucket): Use better integer hashing function.
1327 (xpm_cache_color): Don't possibly over-allocate memory.
1328 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1329 (gif_memory_source):
1330 Use ptrdiff_t, not int or size_t, to record sizes.
1331 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1332 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1333 either works, as we prefer signed integers.
1334 (tiff_read_from_memory, tiff_write_from_memory):
1335 Return tsize_t, not size_t, since that's what the TIFF API wants.
1336 (tiff_read_from_memory): Don't fail simply because the read would
1337 go past EOF; instead, return a short read.
1338 (tiff_load): Omit no-longer-needed casts.
1339 (Fimagemagick_types): Don't assume size fits into 'int'.
1341 Improve hashing quality when configured --with-wide-int.
1342 * fns.c (hash_string): New function, taken from sxhash_string.
1343 Do not discard information about ASCII character case; this
1344 discarding is no longer needed.
1345 (sxhash-string): Use it. Change sig to match it. Caller changed.
1346 * lisp.h: Declare it.
1347 * lread.c (hash_string): Remove, since we now use fns.c's version.
1348 The fns.c version returns a wider integer if --with-wide-int is
1349 specified, so this should help the quality of the hashing a bit.
1351 * emacs.c: Integer overflow minor fix.
1352 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1353 Define only if GNU_LINUX.
1354 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1356 * dispnew.c: Integer signedness and overflow fixes.
1357 Remove unnecessary forward decls, that were a maintenance hassle.
1358 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1360 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1361 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1362 (prepare_desired_row, line_draw_cost):
1363 Use int, not unsigned, where either works.
1364 (save_current_matrix, restore_current_matrix):
1365 Use ptrdiff_t, not size_t, where either works.
1366 (init_display): Check for overflow more accurately, and without
1367 relying on undefined behavior.
1369 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1370 Remove, replacing with the new symbols in lisp.h. All uses changed.
1371 * fileio.c (make_temp_name):
1372 * filelock.c (lock_file_1, lock_file):
1373 * xdisp.c (message_dolog):
1374 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1375 Use pMd etc. instead.
1376 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1377 replacing the pWIDE etc. symbols removed from editfns.c.
1379 * keyboard.h (num_input_events): Now uintmax_t.
1380 This is (very slightly) less likely to mess up due to wraparound.
1383 * buffer.c: Integer signedness fixes.
1384 (alloc_buffer_text, enlarge_buffer_text):
1385 Use ptrdiff_t rather than size_t when either will do, as we prefer
1388 * alloc.c: Integer signedness and overflow fixes.
1389 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1390 (__malloc_size_t): Default to size_t, not to int.
1391 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1392 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1393 Prefer ptrdiff_t to size_t when either would do, as we prefer
1395 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1396 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1397 Now const. Initialize with values that are in range even if char
1399 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1400 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1401 These functions do the right thing with sizes > 2**32.
1402 (check_depth): Now ptrdiff_t, not int.
1403 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1404 Adjust to new way of storing sizes. Check for size overflow bugs
1406 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1407 slightly wrong anyway, as it missed one instance of
1408 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1409 (refill_memory_reserve): Omit needless cast to size_t.
1410 (mark_object_loop_halt): Mark as externally visible.
1412 * xselect.c: Integer signedness and overflow fixes.
1413 (Fx_register_dnd_atom, x_handle_dnd_message):
1414 Use ptrdiff_t, not size_t, since we prefer signed.
1415 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1416 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1417 x_dnd_atoms_size and x_dnd_atoms_length.
1419 * doprnt.c: Prefer signed to unsigned when either works.
1421 * doprnt.c (doprnt):
1423 * xdisp.c (vmessage):
1424 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1425 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1426 prefer signed arithmetic to avoid comparison confusion.
1427 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1428 but is a bit tricky.
1430 Assume freestanding C89 headers, string.h, stdlib.h.
1431 * data.c, doprnt.c, floatfns.c, print.c:
1432 Include float.h unconditionally.
1433 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1434 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1435 * regex.c: Likewise for stddef.h, string.h.
1436 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1437 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1438 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1439 (STDC_HEADERS): Remove obsolete defines.
1440 * sysdep.c: Include limits.h unconditionally.
1442 Assume support for memcmp, memcpy, memmove, memset.
1443 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1444 * regex.c (memcmp, memcpy):
1445 Remove; we assume C89 now.
1447 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1448 (__malloc_safe_bcopy): Remove; no longer needed.
1450 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1451 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1452 well either way, and we prefer signed to unsigned.
1454 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1456 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1457 closes the connection while we're reading (bug#9182).
1459 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1461 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1462 are specified (Bug#9168).
1464 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1466 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1467 Found by GCC static checking and --with-wide-int on a 32-bit host.
1469 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1471 * xdisp.c (compute_display_string_pos): Fix logic of caching
1472 previous display string position. Initialize cached_prev_pos to
1473 -1. Fixes slow-down at the beginning of a buffer.
1475 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1477 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1478 for attrs[LFACE_FONTSET_INDEX].
1480 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1482 * xml.c (parse_region): Remove unused local
1483 that was recently introduced.
1485 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1487 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1488 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1490 * xdisp.c (move_it_in_display_line_to): Record the best matching
1491 position for TO_CHARPOS while scanning the line, and restore it on
1492 exit if none of the characters scanned was an exact match.
1493 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1494 when exact match is impossible due to invisible text, and the
1495 lines are truncated.
1497 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1499 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1502 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1504 Fix a significant slow-down of cursor motion with C-n, C-p,
1505 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1506 auto-repeat under bidi redisplay in fontified buffers.
1507 * xdisp.c (compute_stop_pos_backwards): New function.
1508 (next_element_from_buffer): Call compute_stop_pos_backwards to
1509 find a suitable prev_stop when we find ourselves before
1511 (reseat): Don't look for prev_stop, as that could mean a very long
1513 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1514 <cached_disp_overlay_modiff>: Cache for last found display string
1516 (compute_display_string_pos): Return the cached position if asked
1517 about the same buffer in the same area of character positions, and
1518 the buffer wasn't changed since the time the display string
1519 position was cached.
1521 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1523 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1524 is an integer, which is important for empty lines. (Bug#9149)
1526 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1528 * frame.c (Fmodify_frame_parameters): In tty case, update the
1529 default face if necessary (Bug#4238).
1531 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1533 * editfns.c (Fstring_to_char): No need to explain what a character
1534 is in the docstring (Bug#6576).
1536 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1538 * xml.c (parse_region): Make sure we always return a tree.
1540 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1542 * xml.c (parse_region): If a document contains only comments,
1545 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1547 * xml.c (make_dom): Return comments, too.
1549 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1552 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1553 and the surrounding thread.
1554 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1555 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1556 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1558 * s/openbsd.h (BROKEN_SIGIO): Define.
1559 * unexelf.c (unexec) [__OpenBSD__]:
1560 Don't update the .mdebug section of the Alpha COFF symbol table.
1562 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1564 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1567 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1569 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1570 This fixes some race conditions on the permissions of any newly
1573 * alloc.c (valid_pointer_p): Use pipe, not open.
1574 This fixes some permissions issues when debugging.
1576 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1577 If fchown fails to set both uid and gid, try to set just gid,
1578 as that is sometimes allowed. Adjust the file's mode to eliminate
1579 setuid or setgid bits that are inappropriate if fchown fails.
1581 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1583 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1584 to compare Lisp_Objects.
1585 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1586 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1587 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1589 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1591 * lread.c (read_integer): Unread even EOF character.
1592 (read1): Likewise. Properly record start position of symbol.
1594 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1595 symbol character follows.
1597 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1599 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1600 This works around a problem with the previous change to Fcopy_file.
1601 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1602 and without this change, GCC might complain about discarding
1603 fchown's return value.
1605 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1607 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1609 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1611 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1613 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1615 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1616 it's used from the C level.
1618 * process.c: Use the same condition for POLL_FOR_INPUT in both
1619 keyboard.c and process.c (bug#1858).
1621 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1623 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1624 (Fgnutls_boot): Use it.
1626 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1628 * doc.c (Fsubstitute_command_keys): Revert last change.
1630 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1632 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1633 quotes the next character, and doesn't affect other longer
1634 sequences (bug#8935).
1636 * lread.c (syms_of_lread): Clarify that is isn't only
1637 `eval-buffer' and `eval-defun' that's affected by
1638 `lexical-binding' (bug#8460).
1640 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1642 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1643 bidi redisplay when a line includes both an image and is
1646 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1648 Fix minor problems found by static checking.
1649 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1650 (elsz): Now a signed constant, not a size_t var. We prefer signed
1651 types to unsigned, to avoid integer comparison confusion. Without
1652 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1653 "cannot optimize loop, the loop counter may overflow", a symptom
1655 * indent.c (Fvertical_motion): Mark locals as initialized.
1656 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1658 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1660 * search.c (Fre_search_backward): Mention `case-fold-search' in
1661 all the re_search_* functions (bug#8138).
1663 * keyboard.c (Fopen_dribble_file): Document when the file is
1666 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1668 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1671 Support bidi reordering of display and overlay strings.
1672 * xdisp.c (compute_display_string_pos)
1673 (compute_display_string_end): Accept additional argument STRING.
1674 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1675 (reseat_to_string): Initialize bidi_it->string.s and
1676 bidi_it->string.schars.
1677 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1678 NULL (avoids a crash in bidi_paragraph_init).
1679 Initialize itb.string.lstring.
1680 (init_iterator): Call bidi_init_it only of a valid
1681 buffer position was specified. Initialize paragraph_embedding to
1683 (reseat_to_string): Initialize the bidi iterator.
1684 (display_string): If we need to ignore text properties of
1685 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1686 original value of -1 will not work with bidi.)
1687 (compute_display_string_pos): First arg is now struct
1688 `text_pos *'; all callers changed. Support display properties on
1690 (compute_display_string_end): Support display properties on Lisp
1692 (init_iterator, reseat_1, reseat_to_string): Initialize the
1693 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1694 when iterating on a string not from display properties).
1695 (compute_display_string_pos, compute_display_string_end):
1696 Fix calculation of the object to scan. Fixes an error when using
1698 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1699 base_level_stop; instead, set base_level_stop to BEGV.
1700 Fixes crashes in vertical-motion.
1701 (next_element_from_buffer): Improve commentary for when
1702 the iterator is before prev_stop.
1703 (init_iterator): Initialize bidi_p from the default value of
1704 bidi-display-reordering, not from buffer-local value. Use the
1705 buffer-local value only if initializing for buffer iteration.
1706 (handle_invisible_prop): Support invisible properties on strings
1707 that are being bidi-reordered.
1708 (set_iterator_to_next): Support bidi reordering of C strings and
1710 (next_element_from_string): Support bidi reordering of Lisp
1712 (handle_stop_backwards): Support Lisp strings as well.
1713 (display_string): Support display of R2L glyph rows.
1714 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1715 (init_iterator): Don't initialize it->bidi_p for strings
1717 (reseat_to_string): Initialize it->bidi_p for strings here.
1718 (next_element_from_string, next_element_from_c_string)
1719 (next_element_from_buffer): Add xassert's for correspondence
1720 between IT's object being iterated and it->bidi_it.string
1722 (face_before_or_after_it_pos): Support bidi iteration.
1723 (next_element_from_c_string): Handle the case of the first string
1724 character that is not the first one in the visual order.
1725 (get_visually_first_element): New function, refactored from common
1726 parts of next_element_from_buffer, next_element_from_string, and
1727 next_element_from_c_string.
1728 (tool_bar_lines_needed, redisplay_tool_bar)
1729 (display_menu_bar): Force left-to-right direction. Add a FIXME
1730 comment for making that be controlled by a user option.
1731 (push_it, pop_it): Save and restore the state of the
1732 bidi iterator. Save and restore the bidi_p flag.
1733 (pop_it): Iterate out of display property for string iteration as
1735 (iterate_out_of_display_property): Support iteration over strings.
1736 (handle_single_display_spec): Set up it->bidi_it for iteration
1737 over a display string, and call bidi_init_it.
1738 (handle_single_display_spec, next_overlay_string)
1739 (get_overlay_strings_1, push_display_prop): Set up the bidi
1740 iterator for displaying display or overlay strings.
1741 (forward_to_next_line_start): Don't use the shortcut if
1743 (back_to_previous_visible_line_start): If handle_display_prop
1744 pushed the iterator stack, restore the internal state of the bidi
1745 iterator by calling bidi_pop_it same number of times.
1746 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1747 and we are bidi-iterating, don't decrement the iterator position;
1748 instead, set the first_elt flag in the bidi iterator, to produce
1750 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1751 (push_display_prop): xassert that we are iterating a buffer.
1752 (push_it, pop_it): Save and restore paragraph_embedding member.
1753 (handle_single_display_spec, next_overlay_string)
1754 (get_overlay_strings_1, reseat_1, reseat_to_string)
1755 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1756 correctly. Don't assume unibyte strings are not bidi-reordered.
1757 (compute_display_string_pos)
1758 (compute_display_string_end): Fix handling the case of C string.
1759 (push_it, pop_it): Save and restore from_disp_prop_p.
1760 (handle_single_display_spec, push_display_prop): Set the
1761 from_disp_prop_p flag.
1762 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1763 (pop_it): Call iterate_out_of_display_property only if we are
1764 popping after iteration over a string that came from a display
1765 property. Fix a typo in popping stretch info. Add an assertion
1766 for verifying that the iterator position is in sync with the bidi
1768 (handle_single_display_spec, get_overlay_strings_1)
1769 (push_display_prop): Fix initialization of paragraph direction for
1770 string when that of the parent object is not yet determined.
1771 (reseat_1): Call bidi_init_it to resync the bidi
1772 iterator with IT's position. (Bug#7616)
1773 (find_row_edges): If ROW->start.pos gives position
1774 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1775 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1776 Reset the from_disp_prop_p flag.
1777 (SAVE_IT, RESTORE_IT): New macros.
1778 (pos_visible_p, face_before_or_after_it_pos)
1779 (back_to_previous_visible_line_start)
1780 (move_it_in_display_line_to, move_it_in_display_line)
1781 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1782 (try_scrolling, redisplay_window, display_line): Use them when
1783 saving a temporary copy of the iterator and restoring it back.
1784 (back_to_previous_visible_line_start, reseat_1)
1785 (init_iterator): Empty the bidi cache "stack".
1786 (move_it_in_display_line_to): If iterator ended up at
1787 EOL, but we never saw any buffer positions smaller than
1788 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1789 motion in bidi-reordered lines.
1790 (move_it_in_display_line_to): Record prev_method and prev_pos
1791 immediately before the call to set_iterator_to_next. Fixes cursor
1792 motion in bidi-reordered lines with stretch glyphs and strings
1793 displayed in margins. (Bug#8133) (Bug#8867)
1794 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1796 (pos_visible_p): Support positions in bidi-reordered lines.
1797 Save and restore bidi cache.
1799 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1800 (bidi_paragraph_info): Delete unused struct.
1801 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1802 (bidi_cache_start): New variable.
1803 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1805 (bidi_cache_fetch_state, bidi_cache_search)
1806 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1807 (bidi_cache_find, bidi_peek_at_next_level)
1808 (bidi_level_of_next_char, bidi_find_other_level_edge)
1809 (bidi_move_to_visually_next): Compare cache index with
1810 bidi_cache_start rather than with zero.
1811 (bidi_fetch_char): Accept new argument STRING; all callers
1812 changed. Support iteration over a string. Support strings with
1813 display properties. Support unibyte strings. Fix the type of
1814 `len' according to what STRING_CHAR_AND_LENGTH expects.
1815 (bidi_paragraph_init, bidi_resolve_explicit_1)
1816 (bidi_resolve_explicit, bidi_resolve_weak)
1817 (bidi_level_of_next_char, bidi_move_to_visually_next):
1818 Support iteration over a string.
1819 (bidi_set_sor_type, bidi_resolve_explicit_1)
1820 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1821 can now be zero (for strings); special values 0 and -1 were
1822 changed to -1 and -2, respectively.
1823 (bidi_char_at_pos): New function.
1824 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1825 Call it instead of FETCH_MULTIBYTE_CHAR.
1826 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1827 initialized to valid values.
1828 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1830 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1831 the test for valid cached positions. Fix the logic for looking up
1832 the sentinel state in the cache. GCPRO the Lisp string we are
1834 (bidi_push_it, bidi_pop_it): New functions.
1835 (bidi_initialize): Initialize the bidi cache start stack pointer.
1836 (bidi_cache_ensure_space): New function, refactored from part of
1837 bidi_cache_iterator_state. Don't assume the required size is just
1838 one BIDI_CACHE_CHUNK away.
1839 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1840 (bidi_count_bytes, bidi_char_at_pos): New functions.
1841 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1842 always valid if bidi_cache_idx is valid.
1843 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1844 is valid if it's going to be used.
1845 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1846 (bidi_cache_fetch_state, bidi_cache_search)
1847 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1848 (bidi_cache_iterator_state, bidi_cache_find)
1849 (bidi_find_other_level_edge, bidi_cache_start_stack):
1850 All variables related to cache indices are now EMACS_INT.
1852 * dispextern.h (struct bidi_string_data): New structure.
1853 (struct bidi_it): New member `string'. Make flag members be 1-bit
1854 fields, and put them last in the struct.
1855 (compute_display_string_pos, compute_display_string_end):
1857 (bidi_push_it, bidi_pop_it): Add prototypes.
1858 (struct iterator_stack_entry): New members bidi_p,
1859 paragraph_embedding, and from_disp_prop_p.
1860 (struct it): Member bidi_p is now a bit field 1 bit wide.
1861 (bidi_shelve_cache, bidi_unshelve_cache):
1864 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1865 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1866 and vector-like objects.
1868 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1869 cache around display iteration.
1871 * window.c (Fwindow_end, window_scroll_pixel_based)
1872 (displayed_window_lines, Frecenter): Save and restore the bidi
1873 cache around display iteration.
1875 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1877 * editfns.c (Fdelete_region): Clarify the use of the named
1878 parameters (bug#6788).
1880 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1882 * indent.c (Fvertical_motion): Set and restore w->pointm when
1883 saving and restoring the window's buffer (Bug#9006).
1885 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1887 * editfns.c (Fstring_to_char): Clarify just what is returned
1888 (bug#6576). Text by Eli Zaretskii.
1890 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1892 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1894 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1896 * buffer.c (mmap_find): Fix a typo.
1898 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1900 Fix execution of x selection hooks.
1901 * xselect.c (Qx_lost_selection_functions)
1902 (Qx_sent_selection_functions): New vars.
1903 (syms_of_xselect): DEFSYM them.
1904 (x_handle_selection_request): Pass Qx_sent_selection_functions
1905 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1906 (x_handle_selection_clear,x_clear_frame_selections):
1907 Pass Qx_lost_selection_functions rather than
1908 Vx_lost_selection_functions to Frun_hook_with_args.
1910 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1912 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1913 The old code sometimes used this field without initializing it.
1915 * alloc.c (gc_sweep): Don't read past end of array.
1916 In theory, the old code could also have corrupted Emacs internals,
1917 though it'd be very unlikely.
1919 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1921 * character.c (Fcharacterp): Don't advertise optional ignored
1922 argument. (Bug#4026)
1924 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1926 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1929 * window.c (Fset_window_start): Doc fix (bug#4199).
1930 (Fset_window_hscroll): Ditto.
1932 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1934 Fix minor new problems caught by GCC 4.6.1.
1935 * term.c (init_tty): Remove unused local.
1936 * xsettings.c (store_monospaced_changed): Define this function only
1937 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1940 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1942 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1944 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1946 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1947 are the mini-buffer and the echo area (bug#3320).
1949 * term.c (init_tty): Remove support for supdup, c10 and perq
1950 terminals, which are no longer supported (bug#1482).
1952 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1954 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1956 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1958 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1959 for non-popups (Bug#3642).
1961 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1963 * alloc.c (reset_malloc_hooks): Protoize.
1964 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1965 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1966 * cm.c (losecursor): Likewise.
1967 * data.c (fmod): Likewise.
1968 * dispnew.c (swap_glyphs_in_rows): Likewise.
1969 * emacs.c (memory_warning_signal): Likewise.
1970 * floatfns.c (float_error): Likewise.
1971 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1972 (otf_open, font_otf_capability, generate_otf_features)
1973 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1975 * image.c (pbm_read_file): Likewise.
1976 * indent.c (string_display_width): Likewise.
1977 * intervals.c (check_for_interval, search_for_interval)
1978 (inc_interval_count, count_intervals, root_interval)
1979 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1980 * lread.c (defalias): Likewise.
1981 * ralloc.c (r_alloc_check): Likewise.
1982 * regex.c (set_image_of_range_1, set_image_of_range)
1983 (regex_grow_registers): Likewise.
1984 * sysdep.c (strerror): Likewise.
1985 * termcap.c (valid_filename_p, tprint, main): Likewise.
1986 * tparam.c (main): Likewise.
1987 * unexhp9k800.c (run_time_remap, save_data_space)
1988 (update_file_ptrs, read_header, write_header, calculate_checksum)
1989 (copy_file, copy_rest, display_header): Likewise.
1990 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1992 * xdisp.c (check_it): Likewise.
1993 * xfaces.c (register_color, unregister_color, unregister_colors):
1995 * xfns.c (print_fontset_result): Likewise.
1996 * xrdb.c (member, fatal, main): Likewise.
1998 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2000 Fix minor problems found by static checking (Bug#9031).
2001 * chartab.c (char_table_set_range, map_sub_char_table):
2002 Remove unused locals.
2003 (uniprop_table): Now static.
2004 * composite.c (_work_char): Remove unused static var.
2006 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2008 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2010 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2012 * gtkutil.c (qttip_cb): Remove code without function.
2014 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2016 * w32.c (pthread_sigmask): New stub.
2018 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2020 Use pthread_sigmask, not sigprocmask (Bug#9010).
2021 sigprocmask is portable only for single-threaded applications, and
2022 Emacs can be multi-threaded when it uses GTK.
2023 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2025 * callproc.c (Fcall_process):
2026 * process.c (create_process):
2027 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2028 Use pthread_sigmask, not sigprocmask.
2030 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2032 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2033 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2036 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2038 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2039 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2040 (xg_hide_tooltip): Fix comment.
2042 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2043 in registerServicesMenuSendTypes.
2044 (validRequestorForSendType): Don't check ns_return_types.
2046 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2049 2011-07-08 Jason Rumney <jasonr@gnu.org>
2051 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2052 frame struct members of non-existent frames (Bug#6284).
2054 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2056 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2057 variable firstTime not needed on OSX >= 10.6.
2058 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2059 >= 10.5. Use setKnobProportion, setDoubleValue.
2061 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2062 (MAC_OS_X_VERSION_10_5): Define if not defined.
2063 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2064 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2065 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2067 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2068 cString and lossyCString on OSX >= 10.4
2070 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2071 sizeToFit on OSX >= 10.2.
2073 * nsimage.m (allocInitFromFile): Don't use deprecated method
2074 bestRepresentationForDevice on OSX >= 10.6.
2076 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2079 * emacs.c: Declare unexec_init_emacs_zone.
2081 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2083 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2085 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2086 on svcsMenu (Bug#8842).
2088 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2090 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2092 * nsterm.m (QUTF8_STRING): Declare.
2093 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2094 (validRequestorForSendType): Return type is (id).
2095 Change indexOfObjectIdenticalTo to indexOfObject.
2096 Check if we have local selection before returning self (Bug#8842).
2097 (writeSelectionToPasteboard): Put local selection into paste board
2098 if we have a local selection (Bug#8842).
2099 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2101 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2102 (ns_get_local_selection): Declare.
2104 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2106 * keymap.c (describe_map_tree): Don't insert a double newline at
2107 the end of the buffer (bug#1169) and return whether we inserted
2110 * callint.c (Fcall_interactively): Change "reading args" to
2111 "providing args" to try to clarify what it does (bug#1010).
2113 2011-07-07 Kenichi Handa <handa@m17n.org>
2115 * composite.c (composition_compute_stop_pos): Ignore a static
2116 composition starting before CHARPOS (Bug#8915).
2118 * xdisp.c (handle_composition_prop): Likewise.
2120 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2122 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2125 2011-07-07 Kenichi Handa <handa@m17n.org>
2127 * character.h (unicode_category_t): New enum type.
2129 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2130 (Qchar_code_property_table): New variable.
2131 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2132 (UNIPROP_COMPRESSED_FORM_P): New macros.
2133 (char_table_ascii): Uncompress the compressed values.
2134 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2135 Uncompress the compressed values.
2136 (sub_char_table_ref_and_range): Likewise.
2137 (char_table_ref_and_range): Uncompress the compressed values.
2138 (sub_char_table_set): New arg is_uniprop. Callers changed.
2139 Uncompress the compressed values.
2140 (sub_char_table_set_range): Args changed. Callers changed.
2141 (char_table_set_range): Adjuted for the above change.
2142 (map_sub_char_table): Delete args default_val and parent. Add arg
2143 top. Give decoded values to a Lisp function.
2144 (map_char_table): Adjust for the above change. Give decoded
2145 values to a Lisp function. Gcpro more variables.
2146 (uniprop_table_uncompress)
2147 (uniprop_decode_value_run_length): New functions.
2148 (uniprop_decoder, uniprop_decoder_count): New variables.
2149 (uniprop_get_decoder, uniprop_encode_value_character)
2150 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2152 (uniprop_encoder, uniprop_encoder_count): New variables.
2153 (uniprop_get_encoder, uniprop_table)
2154 (Funicode_property_table_internal, Fget_unicode_property_internal)
2155 (Fput_unicode_property_internal): New functions.
2156 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2157 Sunicode_property_table_internal, Sget_unicode_property_internal,
2158 and Sput_unicode_property_internal. Defvar_lisp
2159 char-code-property-alist.
2161 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2162 Vunicode_category_table.
2164 * font.c (font_range): Adjust for the change of
2165 Vunicode_category_table.
2167 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2169 * m/iris4d.h: Remove file, move contents ...
2170 * s/irix6-5.h: ... here.
2172 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2174 Remove unportable assumption about struct layout (Bug#8884).
2175 * alloc.c (mark_buffer):
2176 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2177 (clone_per_buffer_values): Don't assume that
2178 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2179 This isn't true in general, and it's particularly not true
2180 if Emacs is configured with --with-wide-int.
2181 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2182 New macros, used in the buffer.c change.
2184 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2186 * xsettings.c: Use both GConf and GSettings if both are available.
2187 (store_config_changed_event): Add comment.
2188 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2189 (store_tool_bar_style_changed): New functions.
2190 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2191 (struct xsettings): Move font inside HAVE_XFT.
2192 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2193 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2194 Move inside HAVE_XFT.
2195 (something_changed_gsettingsCB): Rename from something_changedCB.
2196 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2198 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2199 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2200 (something_changed_gconfCB): Rename from something_changedCB.
2201 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2202 (parse_settings): Move check for font inside HAVE_XFT.
2203 (read_settings, apply_xft_settings): Add comment.
2204 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2205 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2206 call store_font_name_changed.
2207 (xft_settings_event): Add comment.
2208 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2209 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2210 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2211 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2212 (xsettings_initialize): Call init_gsettings last.
2213 (xsettings_get_system_font, xsettings_get_system_normal_font):
2216 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2218 Random fixes. E.g., (random) never returned negative values.
2219 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2220 subseconds part to the entropy, as that's a bit more random.
2221 Prefer signed to unsigned, since the signedness doesn't matter and
2222 in general we prefer signed. When given a limit, use a
2223 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2224 latter isn't right if USE_2_TAGS_FOR_INTS.
2225 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2226 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2228 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2230 * textprop.c (text_property_stickiness):
2231 Obey Vtext_property_default_nonsticky.
2232 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2233 * w32fns.c (syms_of_w32fns):
2234 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2236 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2238 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2239 This is more efficient than Ffile_directory_p and avoids a minor race.
2241 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2243 * buffer.c (Foverlay_put): Say what the return value is
2246 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2247 is a directory before asking whether to use the file name
2249 (barf_or_query_if_file_exists): Make the "File is a directory"
2250 error be more correct.
2252 * fns.c (Frequire): Remove the mention of the .gz files, since
2253 that's installation-specific, but keep the mention of
2254 `get-load-suffixes'.
2256 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2258 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2259 Report string overflow if the output is too long.
2261 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2263 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2264 (syms_of_gnutls): Remove duplicate DEFSYM for
2265 Qgnutls_bootprop_verify_hostname_error, an error for
2266 Qgnutls_bootprop_verify_error (which is no longer used).
2268 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2269 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2270 Also (re)move comments that are misplaced or no longer relevant.
2272 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2274 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2276 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2278 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2279 and background color parameters if they have been changed.
2281 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2283 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2285 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2287 * xsettings.c (SYSTEM_FONT): Define only when used.
2288 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2290 * keymap.c (access_keymap_1): Now static.
2292 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2294 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2295 leave any prefix arg for the up event (Bug#1586).
2297 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2299 * lread.c (syms_of_lread): Mention single symbols defined by
2300 `defvar' or `defconst' (bug#7154).
2302 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2303 (Frequire): Mention get-load-suffixes.
2305 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2307 * window.h (window): Remove clone_number slot.
2308 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2310 (make_parent_window, make_window, saved_window)
2311 (Fset_window_configuration, save_window_save): Don't deal with
2313 * buffer.c (Qclone_number): Remove declaration.
2314 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2316 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2318 Add multiple inheritance to keymaps.
2319 * keymap.c (Fmake_composed_keymap): New function.
2320 (Fset_keymap_parent): Simplify.
2321 (fix_submap_inheritance): Remove.
2322 (access_keymap_1): New function extracted from access_keymap to handle
2323 embedded parents and handle lists of maps.
2324 (access_keymap): Use it.
2325 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2326 (Fcopy_keymap): Handle embedded parents.
2327 (Fcommand_remapping, define_as_prefix): Simplify.
2328 (Fkey_binding): Simplify.
2329 (syms_of_keymap): Move minibuffer-local-completion-map,
2330 minibuffer-local-filename-completion-map,
2331 minibuffer-local-must-match-map, and
2332 minibuffer-local-filename-must-match-map to Elisp.
2333 (syms_of_keymap): Defsubr make-composed-keymap.
2334 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2335 (parse_menu_item): Trivial simplification.
2337 2011-07-01 Glenn Morris <rgm@gnu.org>
2339 * Makefile.in (SETTINGS_LIBS): Fix typo.
2341 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2343 * coding.c (Fencode_coding_string): Record the last coding system
2344 used, as the function doc string says (bug#8738).
2346 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2348 * xsettings.c (store_monospaced_changed): Take new font as arg and
2349 check for change against current_mono_font.
2350 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2351 (emacs_settings_constructor, emacs_settings_get_property)
2352 (emacs_settings_set_property, emacs_settings_class_init)
2353 (emacs_settings_init, gsettings_obj): Remove.
2354 (something_changedCB): New function for HAVE_GSETTINGS.
2355 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2356 with value as argument.
2357 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2358 g_settings_new (Bug#8967). Do not create gsettings_obj.
2359 Remove calls to g_settings_bind. Connect something_changedCB to
2362 * xgselect.c: Add defined (HAVE_GSETTINGS).
2363 (xgselect_initialize): Ditto.
2365 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2366 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2369 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2371 * eval.c (struct backtrace): Simplify and port the data structure.
2372 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2373 signed bit field, as this assumption is not portable and it makes
2374 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2375 "char debug_on_exit : 1" as this is not portable either; instead,
2376 use the portable "unsigned int debug_on_exit : 1". Remove unused
2377 member evalargs. Remove obsolete comments about cc bombing out.
2379 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2381 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2382 Let HAVE_GSETTINGS override HAVE_GCONF.
2383 (store_monospaced_changed): New function.
2384 (EMACS_SETTINGS): A new type derived from GObject to handle
2385 GSettings notifications.
2386 (emacs_settings_constructor, emacs_settings_get_property)
2387 (emacs_settings_set_property, emacs_settings_class_init):
2389 (gsettings_client, gsettings_obj): New variables.
2390 (GSETTINGS_SCHEMA): New define.
2391 (something_changedCB): Call store_monospaced_changed.
2392 (init_gsettings): New function.
2393 (xsettings_initialize): Call init_gsettings.
2394 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2397 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2400 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2402 * window.c (resize_root_window, grow_mini_window)
2403 (shrink_mini_window): Rename Qresize_root_window to
2404 Qwindow_resize_root_window and Qresize_root_window_vertically to
2405 Qwindow_resize_root_window_vertically.
2407 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2409 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2411 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2413 * makefile.w32-in: Redesign dependencies so they reflect more
2414 clearly which files are directly included by each source file,
2415 and not through other includes.
2417 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2419 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2420 (sort_overlays, overlay_strings): When an overlay's clone number
2421 matches the window's clone number process the overlay even if
2422 the overlay's window property doesn't match the current window.
2424 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2425 (Fwindow_hchild): Rename to Fwindow_left_child.
2426 (Fwindow_next): Rename to Fwindow_next_sibling.
2427 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2428 (resize_window_check): Rename to window_resize_check.
2429 (resize_window_apply): Rename to window_resize_apply.
2430 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2431 (Fdelete_other_windows_internal, resize_frame_windows)
2432 (Fsplit_window_internal, Fdelete_window_internal)
2433 (grow_mini_window, shrink_mini_window)
2434 (Fresize_mini_window_internal): Fix callers accordingly.
2436 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2438 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2439 (emacs_fixed_set_min_size): Remove.
2440 (emacs_fixed_new): Take frame as argument.
2442 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2443 (_EmacsFixedPrivate): Remove minwidth/height.
2444 Add struct frame *f.
2445 (emacs_fixed_init): Initialize priv->f.
2446 (get_parent_class, emacs_fixed_set_min_size): Remove.
2447 (emacs_fixed_new): Set priv->f to argument.
2448 (emacs_fixed_get_preferred_width)
2449 (emacs_fixed_get_preferred_height): Use min_width/height from
2450 frames size_hint to set minimum and natural (Bug#8919).
2451 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2452 and use min_width/height from frames size_hint to set
2453 min_width/height (Bug#8919).
2455 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2456 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2459 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2461 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2462 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2465 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2467 * process.c (wait_reading_process_output): Bypass select if
2468 waiting for a cell while ignoring keyboard input, and input is
2469 pending. Suggested by Jan Djärv (Bug#8869).
2471 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2473 Use gnulib's dup2 module instead of rolling our own.
2474 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2476 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2478 * dispnew.c (scrolling_window): Before scrolling, turn off a
2479 mouse-highlight in the window being scrolled.
2481 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2483 Move DEFSYM to lisp.h and use everywhere.
2485 * character.h (DEFSYM): Move declaration...
2486 * lisp.h (DEFSYM): ...here.
2492 * w32select.c: Don't include character.h.
2494 * alloc.c (syms_of_alloc):
2495 * buffer.c (syms_of_buffer):
2496 * bytecode.c (syms_of_bytecode):
2497 * callint.c (syms_of_callint):
2498 * casefiddle.c (syms_of_casefiddle):
2499 * casetab.c (init_casetab_once):
2500 * category.c (init_category_once, syms_of_category):
2501 * ccl.c (syms_of_ccl):
2502 * cmds.c (syms_of_cmds):
2503 * composite.c (syms_of_composite):
2504 * dbusbind.c (syms_of_dbusbind):
2505 * dired.c (syms_of_dired):
2506 * dispnew.c (syms_of_display):
2507 * doc.c (syms_of_doc):
2508 * editfns.c (syms_of_editfns):
2509 * emacs.c (syms_of_emacs):
2510 * eval.c (syms_of_eval):
2511 * fileio.c (syms_of_fileio):
2512 * fns.c (syms_of_fns):
2513 * frame.c (syms_of_frame):
2514 * fringe.c (syms_of_fringe):
2515 * insdel.c (syms_of_insdel):
2516 * keymap.c (syms_of_keymap):
2517 * lread.c (init_obarray, syms_of_lread):
2518 * macros.c (syms_of_macros):
2519 * msdos.c (syms_of_msdos):
2520 * print.c (syms_of_print):
2521 * process.c (syms_of_process):
2522 * search.c (syms_of_search):
2523 * sound.c (syms_of_sound):
2524 * syntax.c (init_syntax_once, syms_of_syntax):
2525 * terminal.c (syms_of_terminal):
2526 * textprop.c (syms_of_textprop):
2527 * undo.c (syms_of_undo):
2528 * w32.c (globals_of_w32):
2529 * window.c (syms_of_window):
2530 * xdisp.c (syms_of_xdisp):
2531 * xfaces.c (syms_of_xfaces):
2532 * xfns.c (syms_of_xfns):
2533 * xmenu.c (syms_of_xmenu):
2534 * xsettings.c (syms_of_xsettings):
2535 * xterm.c (syms_of_xterm): Use DEFSYM.
2537 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2539 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2541 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2543 Integer and buffer overflow fixes (Bug#8873).
2545 * print.c (printchar, strout): Check for string overflow.
2546 (PRINTPREPARE, printchar, strout):
2547 Don't set size unless allocation succeeds.
2549 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2550 for sizes. Check for string overflow more accurately.
2551 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2553 * macros.c: Integer and buffer overflow fixes.
2554 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2555 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2556 Use ptrdiff_t, not int, for sizes.
2557 Don't increment bufsize until after realloc succeeds.
2558 Check for size-calculation overflow.
2559 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2561 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2563 * lread.c: Integer overflow fixes.
2564 (read_integer): Radix is now EMACS_INT, not int,
2565 to improve quality of diagnostics for out-of-range radices.
2566 Calculate buffer size correctly for out-of-range radices.
2567 (read1): Check for integer overflow in radices, and in
2568 read-circle numbers.
2569 (read_escape): Avoid int overflow.
2570 (Fload, openp, read_buffer_size, read1)
2571 (substitute_object_recurse, read_vector, read_list, map_obarray):
2572 Use ptrdiff_t, not int, for sizes.
2573 (read1): Use EMACS_INT, not int, for sizes.
2574 Check for size overflow.
2576 * image.c (cache_image): Check for size arithmetic overflow.
2578 * lread.c: Integer overflow issues.
2579 (saved_doc_string_size, saved_doc_string_length)
2580 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2581 Now ptrdiff_t, not int.
2582 (read1): Don't assume doc string length fits in int. Check for
2583 out-of-range doc string lengths.
2584 (read_list): Don't assume file position fits in int.
2585 (read_escape): Check for hex character overflow.
2587 2011-06-22 Leo Liu <sdl.web@gmail.com>
2589 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2590 Move to minibuffer.el.
2592 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2594 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2595 The following patches are for when GLYPH_DEBUG && !XASSERT.
2596 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2597 * dispnew.c (flush_stdout):
2598 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2599 Mark as externally visible.
2600 * dispnew.c (check_window_matrix_pointers): Now static.
2601 * dispnew.c (window_to_frame_vpos):
2602 * xfns.c (unwind_create_frame):
2603 * xterm.c (x_check_font): Remove unused local.
2604 * scroll.c (CHECK_BOUNDS):
2605 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2606 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2607 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2608 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2609 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2611 (debug_method_add): Use va_list and vsprintf rather than relying
2612 on undefined behavior with wrong number of arguments.
2613 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2614 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2615 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2616 since we're not interested in debugging glyphs with old libraries.
2617 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2618 GCC 4.6.0's static checking.
2620 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2622 Integer overflow and signedness fixes (Bug#8873).
2623 A few related buffer overrun fixes, too.
2625 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2627 * dispextern.h (struct face.stipple):
2628 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2629 (x_bitmap_mask, x_allocate_bitmap_record)
2630 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2631 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2632 (x_create_bitmap_from_xpm_data):
2633 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2634 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2636 * xfaces.c (load_pixmap):
2637 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2638 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2639 (.bitmaps_last, struct x_output.icon_bitmap):
2640 Use ptrdiff_t, not int, for bitmap indexes.
2641 (x_allocate_bitmap_record): Check for size overflow.
2642 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2644 Use ptrdiff_t, not int, for overlay counts.
2645 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2646 * editfns.c (overlays_around, get_pos_property):
2647 * textprop.c (get_char_property_and_overlay):
2648 * xdisp.c (next_overlay_change, note_mouse_highlight):
2649 * xfaces.c (face_at_buffer_position):
2650 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2651 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2652 (Fnext_overlay_change, Fprevious_overlay_change)
2653 (mouse_face_overlay_overlaps, Foverlays_in):
2654 Use ptrdiff_t, not int, for sizes.
2655 (overlays_at, overlays_in): Check for size-calculation overflow.
2657 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2659 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2660 (x_session_initialize): Do not assume string length fits in int.
2662 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2663 This is unlikely, but can occur if DPI is outlandish.
2665 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2666 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2668 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2669 * xrdb.c (magic_file_p, search_magic_path):
2670 Omit last arg SUFFIX; it was always 0. All callers changed.
2671 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2673 * xfont.c (xfont_match): Avoid need for strlen.
2675 * xfns.c: Don't assume strlen fits in int.
2676 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2678 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2679 not unsigned long, as we prefer signed integers. All callers changed.
2680 Detect integer overflow in repeat count.
2681 (message_dolog): Don't assume print length fits in 39 bytes.
2682 (display_mode_element): Don't assume strlen fits in int.
2684 * termcap.c: Don't assume sizes fit in int and never overflow.
2685 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2686 (gobble_line): Check for size-calculation overflow.
2688 * minibuf.c (Fread_buffer):
2689 * lread.c (intern, intern_c_string):
2690 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2691 Don't assume string length fits in int.
2693 * keyboard.c (parse_tool_bar_item):
2694 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2696 * font.c: Don't assume string length fits in int.
2697 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2698 Use ptrdiff_t, not int.
2699 (font_intern_prop): Don't assume string length fits in int.
2700 Don't assume integer property fits in fixnum.
2701 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2703 * filelock.c: Fix some buffer overrun and integer overflow issues.
2704 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2705 Reformulate so as not to need the command string.
2706 Invoke gzip -cd rather than gunzip, as it's more portable.
2707 (lock_info_type, lock_file_1, lock_file):
2708 Don't assume pid_t and time_t fit in unsigned long.
2709 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2710 (current_lock_owner): Prefer signed type for sizes.
2711 Use memcpy, not strncpy, where memcpy is what is really wanted.
2712 Don't assume (via atoi) that time_t and pid_t fit in int.
2713 Check for time_t and/or pid_t out of range, e.g., via a network share.
2714 Don't alloca where an auto var works fine.
2716 * fileio.c: Fix some integer overflow issues.
2717 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2718 Don't assume string length fits in int.
2719 (directory_file_name): Don't assume string length fits in long.
2720 (make_temp_name): Don't assume pid fits in int, or that its print
2721 length is less than 20.
2723 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2725 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2727 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2729 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2730 We prefer signed integers, even for size calculations.
2732 * emacs.c: Don't assume string length fits in 'int'.
2733 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2734 (main): Don't invoke strlen when not needed.
2736 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2737 (XD_DEBUG_MESSAGE): Don't waste a byte.
2739 * callproc.c (getenv_internal_1, getenv_internal)
2741 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2743 * lread.c (invalid_syntax): Omit length argument.
2744 All uses changed. This doesn't fix a bug, but it simplifies the
2745 code away from its former Hollerith-constant appearance, and it's
2746 one less 'int' to worry about when looking at integer-overflow issues.
2747 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2749 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2750 This didn't break anything, but it didn't help either.
2751 It's confusing to put a bogus integer in a place where the actual
2752 value does not matter.
2753 (LIST_END_P): Remove unused macro and its bogus comment.
2754 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2756 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2757 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2759 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2760 We prefer signed types, and the value cannot exceed the EMACS_INT
2761 range anyway (because otherwise the length would not be representable).
2762 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2763 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2764 This avoids a GCC warning when WIDE_EMACS_INT.
2766 * indent.c (sane_tab_width): New function.
2767 (current_column, scan_for_column, Findent_to, position_indentation)
2768 (compute_motion): Use it. This is just for clarity.
2769 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2771 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2773 * lisp.h (lint_assume): New macro.
2774 * composite.c (composition_gstring_put_cache):
2775 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2777 * editfns.c, insdel.c:
2778 Omit unnecessary forward decls, to simplify future changes.
2780 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2782 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2784 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2785 Use much-faster test for byte-length change.
2786 Don't assume string byte-length fits in 'int'.
2787 Check that character arg fits in 'int'.
2788 (mapcar1): Declare byte as byte, for clarity.
2790 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2792 * fns.c (concat): Catch string overflow earlier.
2793 Do not rely on integer wraparound.
2795 * dispextern.h (struct it.overlay_strings_charpos)
2796 (struct it.selective): Now EMACS_INT, not int.
2797 * xdisp.c (forward_to_next_line_start)
2798 (back_to_previous_visible_line_start)
2799 (reseat_at_next_visible_line_start, next_element_from_buffer):
2800 Don't arbitrarily truncate the value of 'selective' to int.
2802 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2804 * composite.c: Don't truncate sizes to 'int'.
2805 (composition_gstring_p, composition_reseat_it)
2806 (composition_adjust_point): Use EMACS_INT, not int.
2807 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2808 not EMACS_UINT, for indexes.
2810 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2812 * buffer.c: Include <verify.h>.
2813 (struct sortvec.priority, struct sortstr.priority):
2814 Now EMACS_INT, not int.
2815 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2816 (struct sortstr.size, record_overlay_string)
2817 (struct sortstrlist.size, struct sortlist.used):
2818 Don't truncate size to int.
2819 (record_overlay_string): Check for size-calculation overflow.
2820 (init_buffer_once): Check at compile-time, not run-time.
2822 2011-06-22 Jim Meyering <meyering@redhat.com>
2824 Don't leak an XBM-image-sized buffer
2825 * image.c (xbm_load): Free the image buffer after using it.
2827 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2830 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2831 that Sun C diagnosed.
2832 * fns.c (secure_hash): Fix pointer signedness issue.
2833 * intervals.c (static_offset_intervals): New function.
2834 (offset_intervals): Use it.
2836 2011-06-21 Leo Liu <sdl.web@gmail.com>
2839 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2842 * fns.c (secure_hash): Rename from crypto_hash_function and change
2843 the first arg to accept symbols.
2844 (Fsecure_hash): New primitive.
2845 (syms_of_fns): New symbols.
2847 2011-06-20 Deniz Dogan <deniz@dogan.se>
2849 * process.c (Fset_process_buffer): Clarify return value in
2852 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2854 * dispnew.c (add_window_display_history): Use BVAR.
2856 * xdisp.c (debug_method_add): Use BVAR.
2857 (check_window_end, dump_glyph_matrix, dump_glyph)
2858 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2860 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2863 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2864 check till after the cache is created in init_frame_faces.
2866 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2868 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2870 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2872 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2873 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2874 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2876 Improve buffer-overflow checking (Bug#8873).
2877 * fileio.c (Finsert_file_contents):
2878 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2879 Remove the old (too-loose) buffer overflow checks.
2880 They weren't needed, since make_gap checks for buffer overflow.
2881 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2882 The old code merely checked for Emacs fixnum overflow, and relied
2883 on undefined (wraparound) behavior. The new code avoids undefined
2884 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2886 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2887 Tune. Don't use wider integers than needed. Don't use alloca.
2888 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2890 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2892 * insdel.c, lisp.h (buffer_overflow): New function.
2893 (insert_from_buffer_1, replace_range, replace_range_2):
2894 * insdel.c (make_gap_larger):
2895 * editfns.c (Finsert_char):
2896 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2898 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2900 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2902 Integer overflow and signedness fixes (Bug#8873).
2904 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2905 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2907 * fileio.c: Don't assume EMACS_INT fits in off_t.
2908 (emacs_lseek): New static function.
2909 (Finsert_file_contents, Fwrite_region): Use it.
2910 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2912 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2914 * fns.c: Don't overflow int when computing a list length.
2915 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2916 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2917 truncation on 64-bit hosts. Check for QUIT every
2918 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2919 faster and is responsive enough.
2920 (Flength): Report an error instead of overflowing an integer.
2921 (Fsafe_length): Return a float if the value is not representable
2922 as a fixnum. This shouldn't happen except in contrived situations.
2923 (Fnthcdr, Fsort): Don't assume list length fits in int.
2924 (Fcopy_sequence): Don't assume vector length fits in int.
2926 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2927 (header_size, word_size): New constants.
2928 (allocate_vectorlike): Don't check size overflow here.
2929 (allocate_vector): Check it here instead, since this is the only
2930 caller of allocate_vectorlike that could cause overflow.
2931 Check that the new vector's length is representable as a fixnum.
2933 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2934 The previous code was bogus. For example, next_almost_prime (32)
2935 returned 39, which is undesirable as it is a multiple of 3; and
2936 next_almost_prime (24) returned 25, which is a multiple of 5 so
2937 why was the code bothering to check for multiples of 7?
2939 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2941 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2943 Variadic C functions now count arguments with ptrdiff_t.
2944 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2945 Back then I didn't know that the Emacs coding style prefers signed int.
2946 Also, in the meantime I found a few more instances where arguments
2947 were being counted with int, which may truncate counts on 64-bit
2948 machines, or EMACS_INT, which may be unnecessarily wide.
2949 * lisp.h (struct Lisp_Subr.function.aMANY)
2950 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2951 Arg counts are now ptrdiff_t, not size_t.
2952 All variadic functions and their callers changed accordingly.
2953 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2954 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2955 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2956 * callint.c (Fcall_interactively): Check arg count for overflow,
2957 to avoid potential buffer overrun. Use signed char, not 'int',
2958 for 'varies' array, so that we needn't bother to check its size
2959 calculation for overflow.
2960 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2961 * eval.c (apply_lambda):
2962 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2963 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2964 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2966 * callint.c (Fcall_interactively): Don't use index var as event count.
2968 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2969 * mem-limits.h (SIZE): Remove; no longer used.
2971 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2973 Remove unnecessary casts.
2974 * xterm.c (x_term_init):
2975 * xfns.c (x_set_border_pixel):
2976 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2977 These aren't needed now that we assume ANSI C.
2979 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2980 It's more likely to cause problems (due to unsigned overflow)
2983 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2985 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2987 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2989 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2991 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2993 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2995 GLYPH_CODE_FACE returns EMACS_INT, not int.
2996 * dispextern.h (merge_faces):
2997 * xfaces.c (merge_faces):
2998 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2999 Don't assume EMACS_INT fits in int.
3001 * character.h (CHAR_VALID_P): Remove unused parameter.
3002 * fontset.c, lisp.h, xdisp.c: All uses changed.
3004 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3006 * fns.c (concat): Minor tuning based on overflow analysis.
3007 This doesn't fix any bugs. Use int to hold character, instead
3008 of constantly refetching from Emacs object. Use XFASTINT, not
3009 XINT, for value known to be a character. Don't bother comparing
3010 a single byte to 0400, as it's always less.
3012 * floatfns.c (Fexpt):
3013 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3015 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3018 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3020 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3021 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3022 incorrectly succeed when S was a string, because 4294967386 was
3023 truncated before it was used.
3025 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3026 Otherwise, an out-of-range integer could cause undefined behavior
3029 * composite.c: Use int, not EMACS_INT, for characters.
3030 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3031 EMACS_INT, for values that are known to be in character range.
3032 This doesn't fix any bugs but is the usual style inside Emacs and
3033 may generate better code on 32-bit machines.
3035 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3036 This is for reasons similar to the recent CHAR_STRING fix.
3037 * charset.c (Fencode_char): Check that character arg is actually
3038 a character. Pass an int to ENCODE_CHAR.
3039 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3040 wider than 'int', as a compile-time check to prevent future regressions
3043 * character.c (char_string): Remove unnecessary casts.
3045 Make sure a 64-bit char is never passed to CHAR_STRING.
3046 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3047 by silently ignoring the top 32 bits, allowing some values
3048 that were far too large to be valid characters.
3049 * character.h: Include <verify.h>.
3050 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3051 arguments are no wider than unsigned, as a compile-time check
3052 to prevent future regressions in this area.
3054 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3055 (Fsubst_char_in_region):
3057 * xdisp.c (decode_mode_spec_coding):
3058 Adjust to CHAR_STRING's new requirement.
3059 * editfns.c (Finsert_char, Fsubst_char_in_region):
3060 * fns.c (concat): Check that character args are actually
3061 characters. Without this test, these functions did the wrong
3062 thing with wildly out-of-range values on 64-bit hosts.
3064 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3065 These casts should not be needed on 32-bit hosts, either.
3066 * keyboard.c (read_char):
3067 * lread.c (Fload): Remove casts to unsigned.
3069 * lisp.h (UNSIGNED_CMP): New macro.
3070 This fixes comparison bugs on 64-bit hosts.
3071 (ASCII_CHAR_P): Use it.
3072 * casefiddle.c (casify_object):
3073 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3074 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3075 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3076 * dispextern.h (FACE_FROM_ID):
3077 * keyboard.c (read_char): Use UNSIGNED_CMP.
3079 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3080 not to EMACS_INT, to avoid GCC warning.
3082 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3084 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3085 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3086 isn't needed on 32-bit machines.
3088 * buffer.c (Fgenerate_new_buffer_name):
3089 Use EMACS_INT for count, not int.
3090 (advance_to_char_boundary): Return EMACS_INT, not int.
3092 * data.c (Qcompiled_function): Now static.
3094 * window.c (window_body_lines): Now static.
3096 * image.c (gif_load): Rename local to avoid shadowing.
3098 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3099 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3100 * alloc.c (make_save_value): Integer argument is now of type
3102 (mark_object): Use ptrdiff_t, not int.
3103 * lisp.h (pD): New macro.
3104 * print.c (print_object): Use it.
3106 * alloc.c: Use EMACS_INT, not int, to count objects.
3107 (total_conses, total_markers, total_symbols, total_vector_size)
3108 (total_free_conses, total_free_markers, total_free_symbols)
3109 (total_free_floats, total_floats, total_free_intervals)
3110 (total_intervals, total_strings, total_free_strings):
3111 Now EMACS_INT, not int. All uses changed.
3112 (Fgarbage_collect): Compute overall total using a double, so that
3113 integer overflow is less likely to be a problem. Check for overflow
3114 when converting back to an integer.
3115 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3116 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3117 These were 'int' variables that could overflow on 64-bit hosts;
3118 they were never used, so remove them instead of repairing them.
3119 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3120 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3121 Previously, this ceilinged at INT_MAX, but that doesn't work on
3123 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3125 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3126 (allocate_vectorlike): Check for ptrdiff_t overflow.
3127 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3128 when a (possibly-narrower) signed value would do just as well.
3129 We prefer using signed arithmetic, to avoid comparison confusion.
3131 * alloc.c: Catch some string size overflows that we were missing.
3132 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3133 for convenience in STRING_BYTES_MAX.
3134 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3135 The definition here is exact; the one in lisp.h was approximate.
3136 (allocate_string_data): Check for string overflow. This catches
3137 some instances we weren't catching before. Also, it catches
3138 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3139 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3140 and ptrdiff_t and EMACS_INT are both 64 bits.
3142 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3143 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3144 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3146 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3148 * alloc.c (Fmake_string): Check for out-of-range init.
3150 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3152 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3154 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3156 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3157 xg_get_default_scrollbar_width.
3159 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3160 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3161 (style_changed_cb): Call update_theme_scrollbar_width and call
3162 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3163 all frames (Bug#8505).
3164 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3165 Call gtk_window_set_resizable if HAVE_GTK3.
3166 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3167 and height if HAVE_GTK3 (Bug#8505).
3168 (scroll_bar_width_for_theme): New variable.
3169 (update_theme_scrollbar_width): New function.
3170 (xg_get_default_scrollbar_width): Move code to
3171 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3172 (xg_initialize): Call update_theme_scrollbar_width.
3174 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3176 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3178 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3180 * frame.c (make_frame): Call other_buffer_safely instead of
3183 * window.c (temp_output_buffer_show): Call display_buffer with
3184 second argument Vtemp_buffer_show_specifiers and reset latter
3185 immediately after the call.
3186 (Vtemp_buffer_show_specifiers): New variable.
3187 (auto_window_vscroll_p, next_screen_context_lines)
3188 (Vscroll_preserve_screen_position): Remove leading asterisks from
3191 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3193 Fix minor problems found by GCC 4.6.0 static checking.
3194 * buffer.c (Qclone_number): Remove for now, as it's unused.
3195 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3196 (record_buffer): Remove unused local.
3197 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3198 (set_frame_buffer_list): Remove; unused.
3199 * frame.h (other_visible_frames): Remove decl.
3200 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3201 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3202 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3204 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3205 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3206 Define only if HAVE_GPM.
3207 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3208 (update_hints_inhibit): Remove; never set. All uses removed.
3209 * widgetprv.h (emacsFrameClassRec): Remove decl.
3210 * window.c (delete_deletable_window): Now returns void, since it
3211 wasn't returning anything.
3212 (compare_window_configurations): Remove unused locals.
3213 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3214 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3215 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3216 the same widths as pointers. This follows up on the 2011-05-06 patch.
3217 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3218 * xterm.h: Likewise.
3219 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3221 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3223 * makefile.w32-in: Update dependencies.
3224 (LISP_H): Add lib/intprops.h.
3226 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3228 * image.c (gif_load): Add animation frame delay to the metadata.
3229 (syms_of_image): Use DEFSYM. New symbol `delay'.
3231 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3233 * window.c (delete_deletable_window): Re-add.
3234 (Fset_window_configuration): Rewrite to handle dead buffers and
3235 consequently deletable windows.
3236 (window_tree, Fwindow_tree): Remove. Supply functionality in
3238 (compare_window_configurations): Simplify code.
3240 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3242 * image.c (imagemagick_load_image): Fix type mismatch.
3243 (Fimagemagick_types): Likewise.
3245 * window.h (replace_buffer_in_windows): Declare.
3247 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3249 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3250 Qclone_number. Remove external declaration of Qdelete_window.
3251 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3253 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3254 Run Qbuffer_list_update_hook if allowed.
3255 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3256 buffer list implementation.
3257 (other_buffer_safely): New function.
3258 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3259 calls to replace_buffer_in_windows and
3260 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3262 (record_buffer): Inhibit quitting and rewrite using quittable
3263 functions. Run Qbuffer_list_update_hook if allowed.
3264 (Frecord_buffer, Funrecord_buffer): New functions.
3265 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3266 Move switch-to-buffer to window.el.
3267 (bury-buffer): Move to window.el.
3268 (Vbuffer_list_update_hook): New variable.
3270 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3273 * window.h (resize_frame_windows): Move up in code.
3274 (Fwindow_frame): Remove EXFUN.
3275 (replace_buffer_in_all_windows): Remove prototype.
3276 (replace_buffer_in_windows_safely): Add prototype.
3278 * window.c: Declare Qdelete_window static again. Move down
3279 declaration of select_count.
3280 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3281 (Fother_window): Move to window.el.
3282 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3283 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3284 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3286 (replace_buffer_in_windows): Implement by calling
3287 Qreplace_buffer_in_windows.
3288 (replace_buffer_in_all_windows): Remove with some functionality
3289 moved into replace_buffer_in_windows_safely.
3290 (replace_buffer_in_windows_safely): New function.
3291 (select_window_norecord, select_frame_norecord): Move in front
3292 of run_window_configuration_change_hook. Remove now obsolete
3294 (Fset_window_buffer): Rewrite doc-string.
3295 Call Qrecord_window_buffer.
3296 (keys_of_window): Move binding for other-window to window.el.
3298 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3300 * dispextern.h (struct image): Replace data member, whose int_val
3301 and ptr_val fields were not used by anything, with a single
3304 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3305 (gif_clear_image, gif_load, imagemagick_load_image)
3306 (gs_clear_image, gs_load): Callers changed.
3308 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3310 * buffer.h: Include <time.h>, for time_t.
3311 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3313 Fix minor problems found by static checking.
3315 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3317 Make identifiers static if they are not used in other modules.
3318 * data.c (Qcompiled_function, Qframe, Qvector):
3319 * image.c (QimageMagick, Qsvg):
3320 * minibuf.c (Qmetadata):
3321 * window.c (resize_window_check, resize_root_window): Now static.
3322 * window.h (resize_window_check, resize_root_window): Remove decls.
3324 * window.c (window_deletion_count, delete_deletable_window):
3326 (window_body_lines): Now static.
3327 (Fdelete_other_windows_internal): Mark vars as initialized.
3328 Make sure 'resize_failed' is initialized.
3329 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3330 (resize_window_apply): Remove unused local.
3331 * window.h (delete_deletable_window): Remove decl.
3333 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3334 (imagemagick_load_image): Fix pointer signedness problem by changing
3335 last arg from unsigned char * to char *. All uses changed.
3336 Also, fix a local for similar reasons.
3337 Remove unused locals. Remove locals to avoid shadowing.
3338 (fn_rsvg_handle_free): Remove; unused.
3339 (svg_load, svg_load_image): Fix pointer signedness problem.
3340 (imagemagick_load_image): Don't use garbage pointer image_wand.
3342 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3344 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3346 * image.c (gif_load): Fix omitted cast error introduced by
3349 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3351 * window.h (resize_proportionally, orig_total_lines)
3352 (orig_top_line): Remove from window structure.
3353 (set_window_height, set_window_width, change_window_heights)
3354 (Fdelete_window): Remove prototypes.
3355 (resize_frame_windows): Remove duplicate declaration.
3357 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3359 * window.h (resize_frame_windows, resize_window_check)
3360 (delete_deletable_window, resize_root_window)
3361 (resize_frame_windows): Declare prototypes.
3363 * window.c (resize_window_apply): Make definition be "static" to
3364 match the prototype.
3366 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3368 * window.c: Remove declarations of Qwindow_size_fixed,
3369 window_min_size_1, window_min_size_2, window_min_size,
3370 size_window, window_fixed_size_p, enlarge_window, delete_window.
3371 Remove static from declaration of Qdelete_window, it's
3372 temporarily needed by Fbury_buffer.
3373 (replace_window): Don't assign orig_top_line and
3375 (Fdelete_window, delete_window): Remove. Window deletion is
3376 handled by window.el.
3377 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3378 Replace Fdelete_window calls with calls to Qdelete_window.
3379 (Fdelete_other_windows): Remove. Deleting other windows is
3380 handled by window.el.
3381 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3382 handled in window.el.
3383 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3384 Window minimum sizes are handled in window.el.
3385 (shrink_windows, size_window, set_window_height)
3386 (set_window_width, change_window_heights, window_height)
3387 (window_width, CURBEG, CURSIZE, enlarge_window)
3388 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3389 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3390 handled in window.el.
3391 (make_dummy_parent): Rename to make_parent_window and give it a
3392 second argument horflag.
3393 (make_window): Don't set resize_proportionally any more.
3394 (Fsplit_window): Remove. Windows are split in window.el.
3395 (save_restore_action, save_restore_orig_size)
3396 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3397 Resize mini windows in window.el.
3398 (grow_mini_window, shrink_mini_window): Implement by calling
3399 Qresize_root_window_vertically, resize_window_check and
3400 resize_window_apply.
3401 (saved_window, Fset_window_configuration, save_window_save):
3402 Do not handle orig_top_line, orig_total_lines, and
3403 resize_proportionally.
3404 (window_min_height, window_min_width): Move to window.el.
3405 (keys_of_window): Move bindings for delete-other-windows,
3406 split-window, delete-window and enlarge-window to window.el.
3408 * buffer.c: Temporarily extern Qdelete_window.
3409 (Fbury_buffer): Temporarily call Qdelete_window instead of
3410 Fdelete_window (Fbury_buffer will move to window.el soon).
3412 * frame.c (set_menu_bar_lines_1): Remove code handling
3413 orig_top_line and orig_total_lines.
3415 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3416 set_window_height but set heights directly.
3417 (change_frame_size_1): Use resize_frame_windows.
3419 * xdisp.c (init_xdisp): Don't use set_window_height but set
3422 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3423 Use resize_frame_windows instead of change_window_heights and run
3424 run_window_configuration_change_hook.
3426 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3427 instead of change_window_heights and run
3428 run_window_configuration_change_hook.
3430 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3432 * window.c (replace_window): Rename second argument REPLACEMENT to
3433 NEW. New third argument SETFLAG. Rewrite.
3434 (delete_window, make_dummy_parent): Call replace_window with
3436 (window_list_1): Move down in code.
3437 (run_window_configuration_change_hook): Move set_buffer part
3438 before select_frame_norecord part in order to unwind correctly.
3439 Rename count1 to count.
3440 (recombine_windows, delete_deletable_window, resize_root_window)
3441 (Fdelete_other_windows_internal)
3442 (Frun_window_configuration_change_hook, make_parent_window)
3443 (resize_window_check, resize_window_apply, Fresize_window_apply)
3444 (resize_frame_windows, Fsplit_window_internal)
3445 (Fdelete_window_internal, Fresize_mini_window_internal):
3447 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3449 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3451 * window.h (window): Add some new members to window structure -
3452 normal_lines, normal_cols, new_total, new_normal, clone_number,
3453 splits, nest, prev_buffers, next_buffers.
3454 (WINDOW_TOTAL_SIZE): Move here from window.c.
3455 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3457 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3459 (make_dummy_parent): Set new members of windows structure.
3460 (make_window): Move down in code. Handle new members of window
3462 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3463 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3464 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3465 (Fset_window_prev_buffers, Fwindow_next_buffers)
3466 (Fset_window_next_buffers, Fset_window_clone_number):
3468 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3469 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3471 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3472 Argument WINDOW can be now internal window too.
3473 (Fwindow_use_time): Move up in code.
3474 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3476 (Fset_window_configuration, saved_window)
3477 (Fcurrent_window_configuration, save_window_save): Handle new
3478 members of window structure.
3479 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3480 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3481 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3482 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3483 Qget_mru_window, Qresize_root_window,
3484 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3485 Qauto_buffer_name; staticpro them.
3487 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3489 * window.c (Fwindow_total_size, Fwindow_left_column)
3490 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3491 (Fwindow_list_1): New functions.
3492 (window_box_text_cols): Replace with window_body_cols.
3493 (Fwindow_width, Fscroll_left, Fscroll_right):
3494 Use window_body_cols instead of window_box_text_cols.
3495 (delete_window, Fset_window_configuration):
3496 Call delete_all_subwindows with window as argument.
3497 (delete_all_subwindows): Take a window as argument and not a
3499 (window_loop): Remove handling of GET_LRU_WINDOW and
3501 (Fget_lru_window, Fget_largest_window): Move to window.el.
3503 * window.h: Extern window_body_cols instead of
3504 window_box_text_cols. delete_all_subwindows now takes a
3505 Lisp_Object as argument.
3507 * indent.c (compute_motion, Fcompute_motion):
3508 Use window_body_cols instead of window_box_text_cols.
3510 * frame.c (delete_frame): Call delete_all_subwindows with root
3513 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3515 * fns.c (Fputhash): Document return value.
3517 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3519 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3521 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3523 Cons<->int and similar integer overflow fixes (Bug#8794).
3525 Check for overflow when converting integer to cons and back.
3526 * charset.c (Fdefine_charset_internal, Fdecode_char):
3527 Use cons_to_unsigned to catch overflow.
3528 (Fencode_char): Use INTEGER_TO_CONS.
3529 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3530 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3531 * data.c (long_to_cons, cons_to_long): Remove.
3532 (cons_to_unsigned, cons_to_signed): New functions.
3533 These signal an error for invalid or out-of-range values.
3534 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3535 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3536 * font.c (Ffont_variation_glyphs):
3537 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3538 * lisp.h: Include <intprops.h>.
3539 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3540 (cons_to_signed, cons_to_unsigned): New decls.
3541 (long_to_cons, cons_to_long): Remove decls.
3542 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3543 (Fprimitive_undo): Use CONS_TO_INTEGER.
3544 * xfns.c (Fx_window_property): Likewise.
3545 * xselect.c: Include <limits.h>.
3546 (x_own_selection, selection_data_to_lisp_data):
3547 Use INTEGER_TO_CONS.
3548 (x_handle_selection_request, x_handle_selection_clear)
3549 (x_get_foreign_selection, Fx_disown_selection_internal)
3550 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3551 (lisp_data_to_selection_data): Use cons_to_unsigned.
3552 (x_fill_property_data): Use cons_to_signed.
3553 Report values out of range.
3555 Check for buffer and string overflow more precisely.
3556 * buffer.h (BUF_BYTES_MAX): New macro.
3557 * lisp.h (STRING_BYTES_MAX): New macro.
3558 * alloc.c (Fmake_string):
3559 * character.c (string_escape_byte8):
3560 * coding.c (coding_alloc_by_realloc):
3561 * doprnt.c (doprnt):
3562 * editfns.c (Fformat):
3564 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3565 since they may not be the same number.
3566 * editfns.c (Finsert_char):
3567 * fileio.c (Finsert_file_contents):
3568 Likewise for BUF_BYTES_MAX.
3570 * image.c: Use ptrdiff_t, not int, for sizes.
3571 (slurp_file): Switch from int to ptrdiff_t.
3573 (slurp_file): Check that file size fits in both size_t (for
3574 malloc) and ptrdiff_t (for sanity and safety).
3576 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3577 if b->modtime has its maximal value.
3579 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3581 Don't assume time_t can fit into int.
3582 * buffer.h (struct buffer.modtime): Now time_t, not int.
3583 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3584 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3586 Minor fixes for signed vs unsigned integers.
3587 * character.h (MAYBE_UNIFY_CHAR):
3588 * charset.c (maybe_unify_char):
3589 * keyboard.c (read_char, reorder_modifiers):
3590 XINT -> XFASTINT, since the integer must be nonnegative.
3591 * ftfont.c (ftfont_spec_pattern):
3592 * keymap.c (access_keymap, silly_event_symbol_error):
3593 XUINT -> XFASTINT, since the integer must be nonnegative.
3594 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3595 since it makes no difference and we prefer signed.
3596 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3597 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3600 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3602 * window.h (Fwindow_frame): Declare.
3604 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3606 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3607 (SPARE_MEMORY): Always define.
3608 (LARGE_REQUEST): Remove.
3609 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3611 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3613 * lisp.h: Move EXFUNS for Fframe_root_window,
3614 Fframe_first_window and Fset_frame_selected_window to window.h.
3616 * window.h: Move EXFUNS for Fframe_root_window,
3617 Fframe_first_window and Fset_frame_selected_window here from
3620 * frame.c (Fwindow_frame, Fframe_first_window)
3621 (Fframe_root_window, Fframe_selected_window)
3622 (Fset_frame_selected_window): Move to window.c.
3623 (Factive_minibuffer_window): Move to minibuf.c.
3624 (Fother_visible_frames_p): New function.
3626 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3628 * window.c (decode_window, decode_any_window): Move up in code.
3629 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3630 (inhibit_frame_unsplittable): Remove unused variable.
3631 (Fwindow_buffer): Move up and rewrite doc-string.
3632 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3633 (Fwindow_prev): New functions.
3634 (Fwindow_frame): Move here from frame.c. Accept any window as
3636 (Fframe_root_window, Fframe_first_window)
3637 (Fframe_selected_window): Move here from frame.c. Accept frame
3638 or arbitrary window as argument. Update doc-strings.
3639 (Fminibuffer_window): Move up in code.
3640 (Fwindow_minibuffer_p): Move up in code and simplify.
3641 (Fset_frame_selected_window): Move here from frame.c.
3643 (Fselected_window, select_window, Fselect_window): Move up in
3644 code. Minor doc-string fixes.
3646 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3648 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3649 Do not assume that spare memory exists; that assumption is valid
3650 only if SYSTEM_MALLOC.
3651 (LARGE_REQUEST): New macro, so that the issue of large requests
3652 is separated from the issue of spare memory.
3654 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3656 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3659 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3661 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3664 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3666 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3668 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3670 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3671 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3673 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3675 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3677 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3679 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3680 (x_clipboard_manager_save): Add return value.
3681 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3683 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3684 Obey Vx_select_enable_clipboard_manager. Catch errors in
3685 x_clipboard_manager_save (Bug#8779).
3686 (Vx_select_enable_clipboard_manager): New variable.
3687 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3689 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3691 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3693 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3695 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3696 in the current matrix if keep_current_p is non-zero.
3698 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3700 * bidi.c (bidi_level_of_next_char): Fix last change.
3702 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3704 Support bidi reordering of text covered by display properties.
3706 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3707 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3708 (bidi_cache_search, bidi_cache_iterator_state)
3709 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3710 (bidi_level_of_next_char, bidi_move_to_visually_next):
3711 Support character positions inside a run of characters covered by a
3713 (bidi_paragraph_init, bidi_resolve_explicit_1)
3714 (bidi_level_of_next_char): Call bidi_fetch_char and
3715 bidi_fetch_char_advance instead of FETCH_CHAR and
3717 (bidi_init_it): Initialize new members.
3718 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3720 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3721 instead of using explicit *_CHAR codes.
3722 (bidi_resolve_explicit, bidi_resolve_weak):
3723 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3724 bidirectional text is supported only in multibyte buffers.
3725 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3726 it to initialize the frame_window_p member of struct bidi_it.
3727 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3728 (bidi_resolve_explicit, bidi_resolve_weak)
3729 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3730 bidi_it->nchars is non-positive.
3731 (bidi_level_of_next_char): Don't try to lookup the cache for the
3732 next/previous character if nothing is cached there yet, or if we
3733 were just reseat()'ed to a new position.
3735 * xdisp.c (set_cursor_from_row): Set start and stop points
3736 according to the row's direction when priming the loop that looks
3737 for the glyph on which to display cursor.
3738 (single_display_spec_intangible_p): Function deleted.
3739 (display_prop_intangible_p): Reimplement to call
3740 handle_display_spec instead of single_display_spec_intangible_p.
3741 Accept 3 additional arguments needed by handle_display_spec.
3742 This fixes incorrect cursor motion across display property with complex
3743 values: lists, `(when COND...)' forms, etc.
3744 (single_display_spec_string_p): Support property values that are
3745 lists with the argument STRING its top-level element.
3746 (display_prop_string_p): Fix the condition for processing a
3747 property that is a list to be consistent with handle_display_spec.
3748 (handle_display_spec): New function, refactored from the
3749 last portion of handle_display_prop.
3750 (compute_display_string_pos): Accept additional argument
3751 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3752 value of a `display' property is a "replacing spec".
3753 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3754 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3755 the display property, but just return a value indicating whether
3756 the display property will replace the characters it covers.
3757 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3758 frame_window_p members of struct bidi_it.
3759 (compute_display_string_pos, compute_display_string_end):
3761 (push_it): Accept second argument POSITION, where pop_it should
3762 jump to continue iteration.
3763 (reseat_1): Initialize bidi_it.disp_pos.
3765 * keyboard.c (adjust_point_for_property): Adjust the call to
3766 display_prop_intangible_p to its new signature.
3768 * dispextern.h (struct bidi_it): New member frame_window_p.
3769 (bidi_init_it): Update prototypes.
3770 (display_prop_intangible_p): Update prototype.
3771 (compute_display_string_pos, compute_display_string_end):
3773 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3776 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3778 Malloc failure behavior now depends on size of allocation.
3779 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3780 * lisp.h: Change signatures accordingly.
3781 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3782 All callers changed. (Bug#8762)
3784 * gnutls.c: Use Emacs's memory allocators.
3785 Without this change, the gnutls library would invoke malloc etc.
3786 directly, which causes problems on non-SYNC_INPUT hosts, and which
3787 runs afoul of improving memory_full behavior. (Bug#8761)
3788 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3789 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3790 xfree instead of the default malloc, realloc, free.
3791 (Fgnutls_boot): No need to check for memory allocation failure,
3792 since xmalloc does that for us.
3794 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3795 * category.c (hash_get_category_set):
3796 * ccl.c (ccl_driver):
3797 * charset.c (Fdefine_charset_internal):
3798 * charset.h (struct charset.hash_index):
3799 * composite.c (get_composition_id, gstring_lookup_cache)
3800 (composition_gstring_put_cache):
3801 * composite.h (struct composition.hash_index):
3802 * dispextern.h (struct image.hash):
3803 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3804 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3805 (hashfn_equal, hashfn_user_defined, make_hash_table)
3806 (maybe_resize_hash_table, hash_lookup, hash_put)
3807 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3808 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3809 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3810 * image.c (make_image, search_image_cache, lookup_image)
3811 (xpm_put_color_table_h):
3812 * lisp.h (struct Lisp_Hash_Table):
3813 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3814 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3815 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3816 * alloc.c (allocate_vectorlike):
3817 Check for overflow in vector size calculations.
3818 * ccl.c (ccl_driver):
3819 Check for overflow when converting EMACS_INT to int.
3820 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3821 need to be updated by these changes.
3822 * fns.c (make_hash_table, maybe_resize_hash_table):
3823 Check for integer overflow with large hash tables.
3824 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3825 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3826 (SXHASH_REDUCE): New macro.
3827 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3828 Use it instead of discarding useful hash info with large hash values.
3829 (sxhash_float): New function.
3830 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3831 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3832 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3833 Rewrite to use FIXNUM_BITS, as this simplifies things.
3834 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3835 Adjust signatures to match updated version of code.
3836 (consing_since_gc): Now EMACS_INT, since a single hash table can
3837 use more than INT_MAX bytes.
3839 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3841 Make it possible to build with GCC-4.6+ -O2 -flto.
3843 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3845 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3847 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3848 Call minibuffer-inactive-mode.
3850 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3852 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3853 Update dependencies.
3855 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3857 * data.c (init_data): Remove code for UTS, this system is not
3860 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3862 Don't force ./temacs to start in terminal mode.
3864 * frame.c (make_initial_frame): Initialize faces in all cases, not
3865 only when CANNOT_DUMP is defined.
3866 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3868 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3870 * dispnew.c (add_window_display_history): Use const for the string
3871 pointer. Remove declaration, not needed.
3873 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3875 Use 'inline', not 'INLINE'.
3876 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3877 * alloc.c, fontset.c (INLINE): Remove.
3878 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3879 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3880 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3881 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3882 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3884 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3886 Make it possible to run ./temacs.
3888 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3889 syms_of_callproc does the same thing. Remove test for
3890 "initialized", do it in the caller.
3891 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3893 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3895 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3896 (read_minibuf): Use get_minibuffer.
3897 (syms_of_minibuf): Use DEFSYM.
3898 (Qmetadata): New var.
3899 * data.c (Qbuffer): Don't make it static.
3900 (syms_of_data): Use DEFSYM.
3902 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3904 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3905 (CCL_CODE_MIN): New macro.
3907 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3909 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3911 * eval.c (Qdebug): Now static.
3912 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3913 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3914 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3916 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3918 * image.c: Various fixes to ImageMagick code comments.
3919 (Fimagemagick_types): Doc fix.
3921 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3923 Minor fixes prompted by GCC 4.6.0 warnings.
3925 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3927 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3928 (x_clipboard_manager_save_all): Move extern decl to ...
3929 * xterm.h: ... here, so that it can be checked for consistency.
3931 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3933 * xselect.c (x_clipboard_manager_save_frame)
3934 (x_clipboard_manager_save_all): New functions.
3935 (Fx_clipboard_manager_save): Lisp function deleted.
3937 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3938 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3940 * xterm.h: Update prototype.
3942 2011-05-28 William Xu <william.xwl@gmail.com>
3944 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3947 2011-05-28 Jim Meyering <meyering@redhat.com>
3949 Avoid a sign-extension bug in crypto_hash_function.
3950 * fns.c (to_uchar): Define.
3951 (crypto_hash_function): Use it to convert some newly-signed
3952 variables to unsigned, to avoid sign-extension bugs. For example,
3953 without this change, (md5 "truc") would evaluate to
3954 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3955 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3956 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3958 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3960 Integer overflow fixes.
3962 * dbusbind.c: Serial number integer overflow fixes.
3963 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3964 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3965 to hold a serial number that is too large for a fixnum.
3966 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3967 Check for serial numbers out of range. Decode any serial number
3968 that was so large that it became a float. (Bug#8722)
3970 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3971 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3972 Use XFASTINT rather than XUINT when numbers are nonnegative.
3973 (xd_append_arg, Fdbus_method_return_internal):
3974 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3975 arguments, check that Lisp number is nonnegative, rather than
3976 silently wrapping negative numbers around. (Bug#8722)
3977 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3980 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3982 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3984 ccl: add integer overflow checks
3985 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3986 (IN_INT_RANGE): New macros.
3987 (ccl_driver): Use them to check for integer overflow when
3988 decoding a CCL program. Many of the new checks are whether XINT (x)
3989 fits in int; it doesn't always, on 64-bit hosts. The new version
3990 doesn't catch all possible integer overflows, but it's an
3991 improvement. (Bug#8719)
3993 * alloc.c (make_event_array): Use XINT, not XUINT.
3994 There's no need for unsigned here.
3996 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3997 This follows up to the 2011-05-06 change that substituted uintptr_t
3998 for EMACS_INT. This case wasn't caught back then.
4000 Rework Fformat to avoid integer overflow issues.
4001 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4002 now (part of C89). Include <verify.h>.
4003 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4004 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4005 (Fformat): Avoid the prepass trying to compute sizes; it was only
4006 approximate and thus did not catch overflow reliably. Instead, walk
4007 through the format just once, formatting and computing sizes as we go,
4008 checking for integer overflow at every step, and allocating a larger
4009 buffer as needed. Keep track separately whether the format is
4010 multibyte. Keep only the most-recently calculated precision, rather
4011 than them all. Record whether each argument has been converted to
4012 string. Use EMACS_INT, not int, for byte and char and arg counts.
4013 Support field widths and precisions larger than INT_MAX. Avoid
4014 sprintf's undefined behavior with conversion specifications such as %#d
4015 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4016 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4017 formatting out-of-range floating point numbers with int
4020 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4022 * data.c: Avoid integer truncation in expressions involving floats.
4023 * data.c: Include <intprops.h>.
4024 (arith_driver): When there's an integer overflow in an expression
4025 involving floating point, convert the integers to floating point
4026 so that the resulting value does not suffer from catastrophic
4027 integer truncation. For example, on a 64-bit host (* 4
4028 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4029 Do not rely on undefined behavior after integer overflow.
4031 merge count_size_as_multibyte, parse_str_to_multibyte
4032 * character.c, character.h (count_size_as_multibyte):
4033 Rename from parse_str_to_multibyte; all uses changed.
4034 Check for integer overflow.
4035 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4036 since it's now a duplicate of the other. This is more of
4037 a character than a buffer op, so better that it's in character.c.
4038 * fns.c, print.c: Adjust to above changes.
4040 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4042 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4044 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4046 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4047 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4048 (x_clipboard_manager_save): Now static.
4049 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4051 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4052 (crypto_hash_function): Now static.
4053 Fix pointer signedness problems. Avoid unnecessary initializations.
4055 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4057 * termhooks.h (Vselection_alist): Make it terminal-local.
4059 * terminal.c (create_terminal): Initialize it.
4061 * xselect.c: Support for clipboard managers.
4062 (Vselection_alist): Move to termhooks.h as terminal-local var.
4063 (LOCAL_SELECTION): New macro.
4064 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4065 (symbol_to_x_atom): Remove gratuitous arg.
4066 (x_handle_selection_request, lisp_data_to_selection_data)
4067 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4068 (x_own_selection, x_get_local_selection, x_convert_selection):
4069 New arg, specifying work frame. Use terminal-local Vselection_alist.
4070 (some_frame_on_display): Delete unused function.
4071 (Fx_own_selection_internal, Fx_get_selection_internal)
4072 (Fx_disown_selection_internal, Fx_selection_owner_p)
4073 (Fx_selection_exists_p): New optional frame arg.
4074 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4075 (x_handle_selection_clear): Don't treat other terminals with the
4076 same keyboard specially. Use the terminal-local Vselection_alist.
4077 (x_clear_frame_selections): Use Frun_hook_with_args.
4079 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4081 * xterm.h: Add support for those atoms.
4083 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4085 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4086 (converted_selections, conversion_fail_tag): New global variables.
4087 (x_selection_request_lisp_error): Free the above.
4088 (x_get_local_selection): Remove unnecessary code.
4089 (x_reply_selection_request): Args changed; handle arbitrary array
4090 of converted selections stored in converted_selections.
4091 Separate the XChangeProperty and SelectionNotify steps.
4092 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4093 (x_convert_selection): New function.
4094 (x_handle_selection_event): Simplify.
4095 (x_get_foreign_selection): Don't ignore incoming requests while
4096 waiting for an answer; this will fail when we implement
4097 SAVE_TARGETS, and seems unnecessary anyway.
4098 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4099 (Vx_sent_selection_functions): Doc fix.
4101 2011-05-26 Leo Liu <sdl.web@gmail.com>
4103 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4105 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4107 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4109 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4110 for fringe update if it has periodic bitmap.
4111 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4112 and fringe_bitmap_periodic_p.
4114 * fringe.c (get_fringe_bitmap_data): New function.
4115 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4116 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4117 row. Mark glyph row for fringe update if periodicity changed.
4119 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4120 for fringe update unless it has periodic bitmap.
4122 2011-05-25 Kenichi Handa <handa@m17n.org>
4124 * xdisp.c (get_next_display_element): Set correct it->face_id for
4125 a static composition.
4127 2011-05-24 Leo Liu <sdl.web@gmail.com>
4130 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4132 * fns.c (crypto_hash_function, Fsha1): New function.
4133 (Fmd5): Use crypto_hash_function.
4134 (syms_of_fns): Add Ssha1.
4136 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4138 * gnutls.c: Remove unused macros.
4139 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4140 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4141 Remove macros that are defined and never used.
4142 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4144 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4146 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4147 (Fx_get_selection_internal): Minor cleanup.
4148 (Fx_own_selection_internal): Rename arguments for consistency with
4151 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4153 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4155 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4157 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4159 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4161 * dispnew.c (scrolling_window): Don't exclude the case that the
4162 last enabled row in the desired matrix touches the bottom boundary.
4164 2011-05-21 Glenn Morris <rgm@gnu.org>
4166 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4167 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4168 and add some more files.
4170 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4172 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4173 report_file_error introduced by the change from 2011-05-07.
4175 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4177 * systime.h (Time): Define only if emacs is defined.
4178 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4179 where the include path doesn't have X11/X.h by default. See
4180 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4182 2011-05-20 Kenichi Handa <handa@m17n.org>
4184 * composite.c (find_automatic_composition): Fix previous change.
4186 2011-05-20 Glenn Morris <rgm@gnu.org>
4188 * lisp.mk: New file, split from Makefile.in.
4189 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4190 (shortlisp): Remove.
4191 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4193 2011-05-19 Glenn Morris <rgm@gnu.org>
4195 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4196 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4197 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4198 (lisp): Set the order to that of loadup.el.
4199 (shortlisp): Make it a copy of $lisp.
4200 (SOME_MACHINE_LISP): Remove.
4201 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4202 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4204 2011-05-18 Kenichi Handa <handa@m17n.org>
4206 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4207 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4208 (find_automatic_composition): Mostly rewrite for efficiency.
4210 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4212 * makefile.w32-in: Update dependencies.
4214 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4216 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4217 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4219 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4221 Fix some integer overflow issues, such as string length overflow.
4223 * insdel.c (count_size_as_multibyte): Check for string overflow.
4225 * character.c (lisp_string_width): Check for string overflow.
4226 Use EMACS_INT, not int, for string indexes and lengths; in
4227 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4228 the resulting string length overflows an EMACS_INT; instead,
4229 report a string overflow if no precision given. When checking for
4230 precision exhaustion, use a check that cannot possibly have
4231 integer overflow. (Bug#8675)
4232 * character.h (lisp_string_width): Adjust to new signature.
4234 * alloc.c (string_overflow): New function.
4235 (Fmake_string): Use it. This doesn't change behavior, but saves
4236 a few bytes and will simplify future changes.
4237 * character.c (string_escape_byte8): Likewise.
4238 * lisp.h (string_overflow): New decl.
4240 Fixups, following up to the user-interface timestamp change.
4241 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4242 for UI timestamps, instead of unsigned long.
4243 * msdos.c (mouse_get_pos): Likewise.
4244 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4245 * w32gui.h (Time): Define by including "systime.h" rather than by
4246 declaring it ourselves. (Bug#8664)
4248 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4249 * image.c (clear_image_cache): Likewise.
4251 * term.c (term_mouse_position): Don't assume time_t wraparound.
4253 Be more systematic about user-interface timestamps.
4254 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4255 and sometimes 'EMACS_UINT', to represent these timestamps.
4256 This change causes it to use 'Time' uniformly, as that's what X uses.
4257 This makes the code easier to follow, and makes it easier to catch
4258 integer overflow bugs such as Bug#8664.
4259 * frame.c (Fmouse_position, Fmouse_pixel_position):
4260 Use Time, not unsigned long, for user-interface timestamps.
4261 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4262 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4263 * keyboard.h (last_event_timestamp): Likewise.
4264 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4265 * menu.h (xmenu_show): Likewise.
4266 * term.c (term_mouse_position): Likewise.
4267 * termhooks.h (struct input_event.timestamp): Likewise.
4268 (struct terminal.mouse_position_hook): Likewise.
4269 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4270 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4271 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4272 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4274 * menu.h, termhooks.h: Include "systime.h", for Time.
4276 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4277 Don't assume that the difference between two unsigned long values
4278 can fit into an integer. At this point, we know button_down_time
4279 <= event->timestamp, so the difference must be nonnegative, so
4280 there's no need to cast the result if double-click-time is
4281 nonnegative, as it should be; check that it's nonnegative, just in
4282 case. This bug is triggered when events are more than 2**31 ms
4283 apart (about 25 days). (Bug#8664)
4285 * xselect.c (last_event_timestamp): Remove duplicate decl.
4286 (x_own_selection): Remove needless cast to unsigned long.
4288 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4289 that always fit in int. Use a sentinel instead of a counter, to
4290 avoid a temp and to allay GCC's concerns about possible int overflow.
4291 * frame.h (struct frame): Use int for menu_bar_items_used
4292 instead of EMACS_INT, since it always fits in int.
4294 * menu.c (grow_menu_items): Check for int overflow.
4296 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4298 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4299 Before, the code was not consistent. These values cannot exceed
4300 2**31 - 1 so there's no need to make them unsigned.
4301 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4302 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4303 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4305 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4307 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4308 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4309 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4310 presumably because the widths might not match.
4312 * window.c (size_window): Avoid needless test at loop start.
4314 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4316 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4318 2011-05-12 Drew Adams <drew.adams@oracle.com>
4320 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4322 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4324 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4325 `width' to `bar_area_x' and `bar_area_width', respectively.
4326 (x_scroll_run): Take account of fringe background extension.
4328 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4329 Rename local vars `left' and `width' to `bar_area_x' and
4330 `bar_area_width', respectively.
4331 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4332 background extension.
4334 2011-05-10 Jim Meyering <meyering@redhat.com>
4336 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4338 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4340 * image.c (Finit_image_library): Return t for built-in image types,
4341 like pbm and xbm. (Bug#8640)
4343 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4345 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4347 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4349 * w32console.c (Fset_screen_color): Doc fix.
4350 (Fget_screen_color): New function.
4351 (syms_of_ntterm): Defsubr it.
4353 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4354 unlink the temporary file if Fcall_process didn't create it in the
4356 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4357 child process will be redirected to a file specified with `:file'.
4358 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4359 cue to call_process_cleanup not to close that handle.
4361 2011-05-07 Ben Key <bkey76@gmail.com>
4363 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4364 one of two shell specific rules, either bootstrap-temacs-CMD or
4365 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4366 to the previous implementation of the bootstrap-temacs rule.
4367 The bootstrap-temacs-CMD rule is similar to the previous
4368 implementation of the bootstrap-temacs rule except that it
4369 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4372 These changes, along with some changes to nt/configure.bat,
4373 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4374 earlier fix to add support for --cflags and --ldflags options
4375 that include quotes so that it works whether make uses cmd or
4378 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4380 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4381 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4383 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4384 a string. Handle both cases.
4385 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4386 (Fdbus_register_method): Use Qinvalid_function.
4388 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4390 * makefile.w32-in: Update dependencies.
4391 (LISP_H): Add inttypes.h and stdin.h.
4392 (PROCESS_H): Add unistd.h.
4394 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4396 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4397 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4399 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4401 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4403 * term.c (vfatal): Remove stray call to va_end.
4404 It's not needed and the C Standard doesn't allow it here anyway.
4406 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4407 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4409 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4412 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4414 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4416 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4418 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4420 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4422 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4423 * charset.c (Fdefine_charset_internal): Don't initialize
4424 charset.code_space[15]. The value was garbage, on hosts with
4425 32-bit int (Bug#8600).
4427 * lread.c (read_integer): Be more consistent with string-to-number.
4428 Use string_to_number to do the actual conversion; this avoids
4429 rounding errors and fixes some other screwups. Without this fix,
4430 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4431 (digit_to_number): Move earlier, for benefit of read_integer.
4432 Return -1 if the digit is out of range for the base, -2 if it is
4433 not a digit in any supported base. (Bug#8602)
4435 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4437 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4438 to match comment at start of function. This also removes a
4439 GCC warning about overflow in a 32+64-bit port.
4441 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4443 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4444 Reported by Stefan Monnier in
4445 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4446 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4447 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4449 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4450 (EMACS_UINTPTR): Likewise, with uintptr_t.
4452 * lisp.h: Prefer 64-bit EMACS_INT if available.
4453 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4454 on 32-bit hosts that have 64-bit int, so that they can access
4456 However, temporarily disable this change unless the temporary
4457 symbol WIDE_EMACS_INT is defined.
4459 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4461 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4462 This removes an assumption that EMACS_INT and long are the same
4463 width as pointers. The assumption is true for Emacs porting targets
4464 now, but we want to make other targets possible.
4465 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4466 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4467 In the rest of the code, change types of integers that hold casted
4468 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4469 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4470 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4471 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4472 No need to cast type when ORing.
4473 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4474 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4475 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4476 assume EMACS_INT is the same width as char *.
4477 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4478 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4479 Remove no-longer-needed casts.
4480 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4481 (xg_tool_bar_help_callback, xg_make_tool_item):
4482 Use EMACS_INTPTR to hold an integer
4483 that will be cast to void *; this can avoid a GCC warning
4484 if EMACS_INT is not the same width as void *.
4485 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4486 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4487 (current_message_1, set_message_1):
4488 Use a local to convert to proper width without a cast.
4489 * xmenu.c (dialog_selection_callback): Likewise.
4491 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4492 Also, don't assume VALBITS / RAND_BITS is less than 5,
4493 and don't rely on undefined behavior when shifting a 1 left into
4495 * lisp.h (get_random): Change signature to match.
4497 * lread.c (hash_string): Use size_t, not int, for hash computation.
4498 Normally we prefer signed values; but hashing is special, because
4499 it's better to use unsigned division on hash table sizes so that
4500 the remainder is nonnegative. Also, size_t is the natural width
4501 for hashing into memory. The previous code used 'int', which doesn't
4502 retain enough info to hash well into very large tables.
4503 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4505 * dbusbind.c: Don't possibly lose pointer info when converting.
4506 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4507 Use XPNTR rather than XHASH, so that the high-order bits of
4508 the pointer aren't lost when converting through void *.
4510 * eval.c (Fautoload): Don't double-shift a pointer.
4512 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4514 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4516 * gnutls.c (DEF_GNUTLS_FN):
4517 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4519 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4521 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4524 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4526 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4527 New version that can reserve upto 2GB of heap space.
4529 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4531 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4533 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4535 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4536 `gnutls_certificate_set_x509_key_file'.
4538 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4540 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4541 Update dependencies.
4543 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4545 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4546 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4547 Remove unused parameter `fildes'.
4548 * process.c (read_process_output, send_process): Don't pass it.
4550 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4552 Fix previous change: the library cache is defined in w32.c.
4553 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4554 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4556 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4558 Implement dynamic loading of GnuTLS on Windows.
4560 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4561 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4562 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4565 * gnutls.c (Qgnutls_dll): Define.
4566 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4567 (gnutls_*): Declare function pointers.
4568 (init_gnutls_functions): New function to initialize function pointers.
4569 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4570 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4571 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4572 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4573 (emacs_gnutls_write, emacs_gnutls_read)
4574 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4575 (Fgnutls_available_p): New function.
4576 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4577 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4578 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4580 * image.c: Include w32.h.
4581 (Vimage_type_cache): Delete.
4582 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4583 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4584 (w32_delayed_load): Move to w32.c.
4586 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4588 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4589 (w32_delayed_load): Move from image.c. When loading a library, record
4590 its filename in the :loaded-from property of the library id.
4591 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4592 Initialize and staticpro them.
4593 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4595 * process.c: Include lisp.h before w32.h, not after.
4596 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4597 instead of gnutls_record_check_pending.
4599 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4601 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4603 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4604 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4607 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4609 * xterm.c (x_set_frame_alpha): Do not set property on anything
4610 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4612 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4614 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4616 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4618 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4619 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4620 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4621 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4622 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4623 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4624 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4625 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4626 (Qgnutls_bootprop_callbacks_verify): Make static.
4628 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4630 * callproc.c: Indentation fixup.
4632 * sysdep.c (wait_for_termination_1): Make static.
4633 (wait_for_termination, interruptible_wait_for_termination):
4634 Move after wait_for_termination_1.
4636 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4638 * sysdep.c (interruptible_wait_for_termination): New function
4639 which is like wait_for_termination, but allows keyboard
4642 * callproc.c (Fcall_process): Add (:file "file") as an option for
4644 (Fcall_process_region): Ditto.
4646 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4648 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4649 rather than `XVECTOR (FOO)->size'.
4651 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4652 inttypes.h, as a gnulib replacement is used if it not available in
4655 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4657 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4658 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4659 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4661 * coding.c (coding_alloc_by_realloc): Error out if destination
4662 will grow beyond MOST_POSITIVE_FIXNUM.
4663 (decode_coding_emacs_mule): Abort if there isn't enough place in
4664 charbuf for the composition carryover bytes. Reserve an extra
4665 space for up to 2 characters produced in a loop.
4666 (decode_coding_iso_2022): Abort if there isn't enough place in
4667 charbuf for the composition carryover bytes.
4669 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4671 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4672 aborting when %lld or %lll format is passed.
4673 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4674 %llo or %llx format is passed. (Bug#8545)
4676 * window.c (window_scroll_line_based): Use a marker instead of
4677 simple variables to record original value of point. (Bug#7952)
4679 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4680 produced by %s or %c overflows available buffer space. (Bug#8545)
4682 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4684 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4685 (SIZE_MAX): Move defn after all includes, as they might #define it.
4687 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4689 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4691 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4693 * keyboard.c (Qdelayed_warnings_hook): Define.
4694 (command_loop_1): Run `delayed-warnings-hook'
4695 if Vdelayed_warnings_list is non-nil.
4696 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4697 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4699 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4701 * doprnt.c (doprnt): Don't return value smaller than the buffer
4702 size if the message was truncated. (Bug#8545).
4704 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4706 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4707 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4709 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4711 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4713 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4715 * makefile.w32-in: Update dependencies.
4717 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4719 Improve `doprnt' and its usage. (Bug#8545)
4720 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4721 `format_end'. Remove support for %l as a conversion specifier.
4722 Don't use xrealloc. Improve diagnostics when the %l size modifier
4723 is used. Update the commentary.
4725 * eval.c (verror): Simplify calculation of size_t.
4727 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4730 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4732 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4735 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4737 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4738 This makes this file independent of the recent pseudovector change.
4740 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4742 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4744 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4745 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4746 Remove unused local.
4747 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4749 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4750 GCC 4.6.0 optimizes based on type-based alias analysis.
4751 For example, if b is of type struct buffer * and v of type struct
4752 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4753 != &v->size, and therefore "v->size = 1; b->size = 2; return
4754 v->size;" must therefore return 1. This assumption is incorrect
4755 for Emacs, since it type-puns struct Lisp_Vector * with many other
4756 types. To fix this problem, this patch adds a new type struct
4757 vectorlike_header that documents the constraints on layout of vectors
4758 and pseudovectors, and helps optimizing compilers not get fooled
4759 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4760 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4761 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4763 (XSETPVECTYPE): Rewrite in terms of new macro.
4764 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4765 This is a bit clearer, and further avoids the possibility of
4766 undesirable aliasing.
4767 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4768 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4769 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4770 since Lisp_Subr is a special case (no "next" field).
4771 (ASIZE): Now uses header.size rather than size.
4772 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4773 to avoid the hassle of writing XVECTOR (foo)->header.size.
4774 (struct vectorlike_header): New type.
4775 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4776 object, to help avoid aliasing.
4777 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4778 (SUBRP): Likewise, since Lisp_Subr is a special case.
4779 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4780 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4781 (struct Lisp_Hash_Table): Combine first two members into a single
4782 struct vectorlike_header member. All uses of "size" and "next" members
4783 changed to be "header.size" and "header.next".
4784 * buffer.h (struct buffer): Likewise.
4785 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4786 * frame.h (struct frame): Likewise.
4787 * process.h (struct Lisp_Process): Likewise.
4788 * termhooks.h (struct terminal): Likewise.
4789 * window.c (struct save_window_data, struct saved_window): Likewise.
4790 * window.h (struct window): Likewise.
4791 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4792 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4793 * buffer.c (init_buffer_once): Likewise.
4794 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4796 * process.c (Fformat_network_address): Use local var for size,
4799 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4801 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4802 * data.c (atof): Remove decl; no longer used or needed.
4803 (digit_to_number): Move to lread.c.
4804 (Fstring_to_number): Use new string_to_number function, to be
4805 consistent with how the Lisp reader treats infinities and NaNs.
4806 Do not assume that floating-point numbers represent EMACS_INT
4807 without losing information; this is not true on most 64-bit hosts.
4808 Avoid double-rounding errors, by insisting on integers when
4809 parsing non-base-10 numbers, as the documentation specifies.
4810 * lisp.h (string_to_number): New decl, replacing ...
4811 (isfloat_string): Remove.
4812 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4813 (read1): Do not accept +. and -. as integers; this
4814 appears to have been a coding error. Similarly, do not accept
4815 strings like +-1e0 as floating point numbers. Do not report
4816 overflow for integer overflows unless the base is not 10 which
4817 means we have no simple and reliable way to continue.
4818 Break out the floating-point parsing into a new
4819 function string_to_number, so that Fstring_to_number parses
4820 floating point numbers consistently with the Lisp reader.
4821 (digit_to_number): Move here from data.c. Make it static inline.
4822 (E_CHAR, EXP_INT): Remove, replacing with ...
4823 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4824 (string_to_number): New function, replacing isfloat_string.
4825 This function checks for valid syntax and produces the resulting
4826 Lisp float number too. Rework it so that string-to-number
4827 no longer mishandles examples like "1.0e+". Use strtoumax,
4828 so that overflow for non-base-10 numbers is reported only when
4829 there's no portable and simple way to convert to floating point.
4831 * textprop.c (set_text_properties_1): Rewrite for clarity,
4832 and to avoid GCC warning about integer overflow.
4834 * intervals.h (struct interval): Use EMACS_INT for members
4835 where EMACS_UINT might cause problems. See
4836 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4837 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4838 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4840 (offset_intervals): Tell GCC not to worry about length overflow
4841 when negating a negative length.
4843 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4844 (overrun_check_free): Likewise.
4846 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4847 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4850 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4851 (gnutls_make_error): Rename local to avoid shadowing.
4852 (gnutls_emacs_global_deinit): ifdef out; not used.
4853 (Fgnutls_boot): Use const for pointer to readonly storage.
4854 Comment out unused local. Fix pointer signedness problems.
4856 * lread.c (openp): Don't stuff size_t into an 'int'.
4857 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4858 about possible signed overflow.
4860 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4861 (GDK_KEY_g): Don't define if already defined.
4862 (xg_prepare_tooltip): Avoid pointer signedness problem.
4863 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4865 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4866 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4868 * xfns.c (Fx_window_property): Simplify a bit,
4869 to make a bit faster and to avoid GCC 4.6.0 warning.
4870 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4872 * fns.c (internal_equal): Don't assume size_t fits in int.
4874 * alloc.c (compact_small_strings): Tighten assertion a little.
4876 Replace pEd with more-general pI, and fix some printf arg casts.
4877 * lisp.h (pI): New macro, generalizing old pEd macro to other
4878 conversion specifiers. For example, use "...%"pI"d..." rather
4879 than "...%"pEd"...".
4880 (pEd): Remove. All uses replaced with similar uses of pI.
4881 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4882 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4883 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4884 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4885 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4886 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4887 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4889 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4890 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4891 * print.c (safe_debug_print, print_object): Likewise.
4892 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4894 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4895 avoiding the 0 flag, which is not portable.
4896 * process.c (Fmake_network_process): Use pI to avoid cast.
4897 * region-cache.c (pp_cache): Likewise.
4898 * xdisp.c (decode_mode_spec): Likewise.
4899 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4900 behavior on 64-bit hosts with printf arg.
4901 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4902 (x_stop_queuing_selection_requests): Likewise.
4903 (x_get_window_property): Don't truncate byte count to an 'int'
4906 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4907 here, since it parses constructs like leading '-' and spaces,
4908 which are not wanted; and it overflows with large numbers.
4909 Instead, simply match F[0-9]+, which is what is wanted anyway.
4911 * alloc.c: Remove unportable assumptions about struct layout.
4912 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4913 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4914 (allocate_vectorlike, make_pure_vector): Use the new macros,
4915 plus offsetof, to remove unportable assumptions about struct layout.
4916 These assumptions hold on all porting targets that I know of, but
4917 they are not guaranteed, they're easy to remove, and removing them
4918 makes further changes easier.
4920 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4921 This doesn't fix a bug but makes the code clearer.
4922 (string_overrun_cookie): Now const. Use initializers that
4923 don't formally overflow signed char, to avoid warnings.
4924 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4925 can cause Emacs to crash when string overrun checking is enabled.
4926 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4927 multiple of sizeof (EMACS_INT); it need not be, if
4928 alignof(EMACS_INT) < sizeof (EMACS_INT).
4929 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4931 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4933 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4935 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4937 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4938 supposed to be handshaking. (Bug#8556)
4939 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4941 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4943 * lisp.h (Qdebug): List symbol.
4944 * eval.c (Qdebug): Restore global linkage.
4945 * keyboard.c (debug-on-event): New variable.
4946 (handle_user_signal): Break into debugger when debug-on-event
4947 matches the current signal symbol.
4949 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4951 * alloc.c (check_sblock, check_string_bytes)
4952 (check_string_free_list): Convert to standard C.
4954 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4956 * w32.c (emacs_gnutls_push): Fix typo.
4958 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4960 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4961 "cast to pointer from integer of different size".
4963 Improve doprnt and its use in verror. (Bug#8545)
4964 * doprnt.c (doprnt): Document the set of format control sequences
4965 supported by the function. Use SAFE_ALLOCA instead of always
4968 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4969 is one byte too soon. Don't use xrealloc; instead xfree and
4972 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4974 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4977 * gnutls.c: Renamed global_initialized to
4978 gnutls_global_initialized. Added internals for the
4979 :verify-hostname-error, :verify-error, and :verify-flags
4980 parameters of `gnutls-boot' and documented those parameters in the
4981 docstring. Start callback support.
4982 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4983 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4984 on error. Return error code.
4985 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4986 (emacs_gnutls_read): Likewise.
4987 (Fgnutls_boot): Return handshake error code.
4988 (emacs_gnutls_handle_error): New function.
4989 (wsaerror_to_errno): Likewise.
4991 * w32.h (emacs_gnutls_pull): Add prototype.
4992 (emacs_gnutls_push): Likewise.
4994 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4995 (emacs_gnutls_push): Likewise.
4997 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4999 * process.c (wait_reading_process_output): Check if GnuTLS
5000 buffered some data internally if no FDs are set for TLS
5003 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5004 (LIBS): Link to USER_LIBS.
5005 ($(BLD)/gnutls.$(0)): New target.
5007 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5009 * xdisp.c (handle_single_display_spec): Rename the
5010 display_replaced_before_p argument into display_replaced_p, to
5011 make it consistent with the commentary. Fix typos in the
5014 * textprop.c (syms_of_textprop): Remove dead code.
5015 (copy_text_properties): Delete obsolete commentary about an
5016 interface that was deleted long ago. Fix typos in the description
5019 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5020 to changes in oldXMenu/XMenu.h from 2011-04-16.
5021 <menu_help_message, prev_menu_help_message>: Constify.
5022 (IT_menu_make_room): menu->help_text is now `const char **';
5025 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5026 to changes in oldXMenu/XMenu.h from 2011-04-16.
5027 (struct XMenu): Declare `help_text' `const char **'.
5029 * xfaces.c <Qunspecified>: Make extern again.
5031 * syntax.c: Include sys/types.h before including regex.h, as
5034 * doc.c (get_doc_string): Improve the format passed to `error'.
5036 * doprnt.c (doprnt): Improve commentary.
5038 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5040 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5043 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5044 changes in globals.h immediately force recompilation.
5045 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5046 $(CURDIR)/s/ms-w32.h.
5047 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5049 * character.c (Fchar_direction): Function deleted.
5050 (syms_of_character): Don't defsubr it.
5051 <char-direction-table>: Deleted.
5053 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5055 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5056 * doprnt.c: Include limits.h.
5057 (SIZE_MAX): New macro.
5058 (doprnt): Return a size_t value. 2nd arg is now size_t.
5059 Many local variables are now size_t instead of int or unsigned.
5060 Improve overflow protection. Support `l' modifier for integer
5061 conversions. Support %l conversion. Don't assume an EMACS_INT
5062 argument for integer conversions and for %c.
5064 * lisp.h (doprnt): Restore prototype.
5066 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5069 * Makefile.in (base_obj): Add back doprnt.o.
5071 * deps.mk (doprnt.o): Add back prerequisites.
5072 (callint.o): Depend on character.h.
5074 * eval.c (internal_lisp_condition_case): Include the handler
5075 representation in the error message.
5076 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5077 when breaking from the loop.
5079 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5081 * callint.c (Fcall_interactively): When displaying error message
5082 about invalid control letter, pass the character's codepoint, not
5083 a pointer to its multibyte form. Improve display of the character
5084 in octal and display also its hex code.
5086 * character.c (char_string): Use %x to display the (unsigned)
5087 codepoint of an invalid character, to avoid displaying a bogus
5090 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5091 `error', not SYMBOL_NAME itself.
5093 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5094 character arguments to `error'.
5096 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5097 to `error' in error message about FINAL_CHAR argument. Make sure
5098 FINAL_CHAR is a character, and use %c when it is passed as
5099 argument to `error'.
5101 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5103 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5105 * w32.c: Include <time.h>.
5106 (sys_localtime): New function.
5108 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5110 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5112 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5114 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5116 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5119 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5121 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5122 gl_state.e_property when gl_state.object is Qt.
5124 * insdel.c (make_gap_larger): Remove limitation of buffer size
5127 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5129 * xdisp.c (lookup_glyphless_char_display)
5130 (produce_glyphless_glyph): Handle cons cell entry in
5131 glyphless-char-display.
5132 (Vglyphless_char_display): Document it.
5134 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5135 glyphless-char-display.
5137 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5139 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5141 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5143 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5144 definition for no-X builds.
5146 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5148 Static checks with GCC 4.6.0 and non-default toolkits.
5150 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5152 * process.c (keyboard_bit_set): Define only if SIGIO.
5153 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5154 (send_process): Repair possible setjmp clobbering.
5156 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5158 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5160 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5162 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5163 Define only if needed.
5165 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5166 by pacifying GCC about it. Maybe it's time to retire it?
5167 * xfaces.c (USG, __TIMEVAL__): Likewise.
5169 * dispextern.h (struct redisplay_interface): Rename param
5171 * termhooks.h (struct terminal): Likewise.
5172 * xterm.c (xembed_send_message): Likewise.
5174 * insdel.c (make_gap_smaller): Define only if
5175 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5177 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5180 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5181 so that we aren't warned about unused symbols.
5183 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5185 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5187 * xfns.c (x_real_positions): Mark locals as initialized.
5189 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5191 * xterm.c: Fix problems found by static analysis with other toolkits.
5192 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5193 (x_dispatch_event): Declare static if USE_GTK, and
5194 define if USE_GTK || USE_X_TOOLKIT.
5195 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5196 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5197 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5198 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5200 * xmenu.c (menu_help_callback): Pointer type fixes.
5201 Use const pointers when pointing at readonly data. Avoid pointer
5203 (FALSE): Remove unused macro.
5204 (update_frame_menubar): Remove unused decl.
5206 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5208 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5209 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5210 (single_menu_item): Rename local to avoid shadowing.
5212 * keyboard.c (make_lispy_event): Remove unused local var.
5214 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5215 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5217 * bitmaps: Change bitmaps from unsigned char back to the X11
5218 compatible char. Avoid the old compiler warnings about
5219 out-of-range initializers by using, for example, '\xab' rather
5222 * xgselect.c (xgselect_initialize): Check vs interface
5223 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5225 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5227 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5228 to read-only memory.
5230 * fns.c (vector): Remove; this old hack is no longer needed.
5232 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5234 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5236 * xrdb.c (x_load_resources): Omit unused local.
5238 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5239 (x_window): Rename locals to avoid shadowing.
5240 (USG): Use the kludged USG macro, to pacify gcc.
5242 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5243 (x_term_init): Remove local to avoid shadowing.
5245 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5247 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5248 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5250 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5252 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5254 Fix regex.c, syntax.c and friends for buffers > 2GB.
5255 * syntax.h (struct gl_state_s): Declare character position members
5258 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5260 * textprop.c (verify_interval_modification, interval_of):
5261 Declare arguments EMACS_INT.
5263 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5266 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5268 * indent.c (Fvertical_motion): Local variable it_start is now
5271 * regex.c (re_match, re_match_2, re_match_2_internal)
5272 (bcmp_translate, regcomp, regexec, print_double_string)
5273 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5274 (re_compile_pattern, re_exec): Declare arguments and local
5275 variables `size_t' and `ssize_t' and return values `regoff_t', as
5277 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5278 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5279 <compile_stack_type>: `size' and `avail' are now `size_t'.
5281 * regex.h <regoff_t>: Use ssize_t, not int.
5282 (re_search, re_search_2, re_match, re_match_2): Arguments that
5283 specify buffer/string position and length are now ssize_t and
5284 size_t. Return type is regoff_t.
5286 2011-04-16 Ben Key <bkey76@gmail.com>
5288 * nsfont.m: Fixed bugs in ns_get_family and
5289 ns_descriptor_to_entity that were caused by using free to
5290 deallocate memory blocks that were allocated by xmalloc (via
5291 xstrdup). This caused Emacs to crash when compiled with
5292 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5293 --enable-checking=xmallocoverrun). xfree is now used to
5294 deallocate these memory blocks.
5296 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5298 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5300 emacs_write: Accept and return EMACS_INT for sizes.
5301 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5303 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5304 Accept and return EMACS_INT.
5305 (emacs_gnutls_write): Return the number of bytes written on
5307 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5308 (emacs_read, emacs_write): Remove check for negative size, as the
5309 Emacs source code has been audited now.
5310 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5311 (emacs_read, emacs_write): Use it.
5312 * process.c (send_process): Adjust to the new signatures of
5313 emacs_write and emacs_gnutls_write. Do not attempt to store
5314 a byte offset into an 'int'; it might overflow.
5315 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5317 * sound.c: Don't assume sizes fit in 'int'.
5318 (struct sound_device.period_size, alsa_period_size):
5319 Return EMACS_INT, not int.
5320 (struct sound_device.write, vox_write, alsa_write):
5321 Accept EMACS_INT, not int.
5322 (wav_play, au_play): Use EMACS_INT to store sizes and to
5323 record read return values.
5325 2011-04-15 Ben Key <bkey76@gmail.com>
5327 * keyboard.c (Qundefined): Don't declare static since it is used
5329 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5330 static since they are used in nsfont.m.
5332 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5334 * process.c (Qprocessp): Don't declare static.
5335 * lisp.h (Qprocessp): Declare again.
5337 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5339 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5341 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5343 Improve C-level modularity by making more things 'static'.
5345 Don't publish debugger-only interfaces to other modules.
5346 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5347 (verify_bytepos, count_markers): Move decls to the only modules
5349 * region-cache.h (pp_cache): Likewise.
5350 * window.h (check_all_windows): Likewise.
5351 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5353 * sysdep.c (croak): Now static, if
5354 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5355 * syssignal.h (croak): Declare only if not static.
5357 * alloc.c (refill_memory_reserve): Now static if
5358 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5359 * lisp.h (refill_memory_reserve): Declare only if not static.
5361 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5362 Define only if USE_LUCID.
5364 * xrdb.c (x_customization_string, x_rm_string): Now static.
5366 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5367 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5369 * xdisp.c (draw_row_with_mouse_face): Now static.
5370 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5372 * window.h (check_all_windows): Mark externally visible.
5374 * window.c (window_deletion_count): Now static.
5376 * undo.c: Make symbols static if they're not exported.
5377 (last_undo_buffer, last_boundary_position, pending_boundary):
5380 * textprop.c (interval_insert_behind_hooks): Now static.
5381 (interval_insert_in_front_hooks): Likewise.
5383 * term.c: Make symbols static if they're not exported.
5384 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5385 (max_frame_lines, tty_set_terminal_modes):
5386 (tty_reset_terminal_modes, tty_turn_off_highlight):
5387 (get_tty_terminal): Now static.
5388 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5389 * termhooks.h (term_mouse_moveto): Do not declare if
5391 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5392 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5394 * sysdep.c: Make symbols static if they're not exported.
5395 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5397 (sigprocmask_set, full_mask): Remove; unused.
5398 (wait_debugging): Mark as visible.
5399 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5400 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5402 * syntax.c (syntax_temp): Define only if !__GNUC__.
5404 * sound.c (current_sound_device, current_sound): Now static.
5406 * search.c (searchbufs, searchbuf_head): Now static.
5408 * scroll.c (scroll_cost): Remove; unused.
5409 * dispextern.h (scroll_cost): Remove decl.
5411 * region-cache.h (pp_cache): Mark as externally visible.
5413 * process.c: Make symbols static if they're not exported.
5414 (process_tick, update_tick, create_process, chan_process):
5415 (Vprocess_alist, proc_buffered_char, datagram_access):
5416 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5417 (deactivate_process): Mark defn as static, as well as decl.
5418 * lisp.h (create_process): Remove decl.
5419 * process.h (chan_process, Vprocess_alist): Remove decls.
5421 * print.c: Make symbols static if they're not exported.
5422 (print_depth, new_backquote_output, being_printed, print_buffer):
5423 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5424 (print_interval, print_number_index, initial_stderr_stream):
5426 * lisp.h (Fprinc): Remove decl.
5427 (debug_output_compilation_hack): Mark as externally visible.
5429 * sysdep.c (croak): Move decl from here to syssignal.h.
5430 * syssignal.h (croak): Put it here, so the API can be checked when
5431 'croak' is called from dissociate_if_controlling_tty.
5433 * minibuf.c: Make symbols static if they're not exported.
5434 (minibuf_save_list, choose_minibuf_frame): Now static.
5435 * lisp.h (choose_minibuf_frame): Remove decl.
5437 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5439 * lread.c: Make symbols static if they're not exported.
5440 (read_objects, initial_obarray, oblookup_last_bucket_number):
5442 (make_symbol): Remove; unused.
5443 * lisp.h (initial_obarray, make_symbol): Remove decls.
5445 * keyboard.c: Make symbols static if they're not exported.
5446 (single_kboard, recent_keys_index, total_keys, recent_keys):
5447 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5448 (this_single_command_key_start, echoing, last_auto_save):
5449 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5450 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5451 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5452 (Vlispy_mouse_stem, double_click_count):
5454 (force_auto_save_soon): Define only if SIGDANGER.
5455 (ignore_mouse_drag_p): Now static if
5456 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5457 (print_help): Remove; unused.
5458 (stop_character, last_timer_event): Mark as externally visible.
5459 * keyboard.h (ignore_mouse_drag_p): Declare only if
5460 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5461 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5462 * lisp.h (echoing): Remove decl.
5463 (force_auto_save_soon): Declare only if SIGDANGER.
5464 * xdisp.c (redisplay_window): Simplify code, to make it more
5465 obvious that ignore_mouse_drag_p is not accessed if !defined
5466 USE_GTK && !defined HAVE_NS.
5468 * intervals.c: Make symbols static if they're not exported.
5469 (merge_properties_sticky, merge_interval_right, delete_interval):
5471 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5473 * insdel.c: Make symbols static if they're not exported.
5474 However, leave prepare_to_modify_buffer alone. It's never
5475 called from outside this function, but that appears to be a bug.
5476 (combine_after_change_list, combine_after_change_buffer):
5477 (adjust_after_replace, signal_before_change): Now static.
5478 (adjust_after_replace_noundo): Remove; unused.
5479 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5480 (signal_before_change): Remove decls.
5482 * indent.c (val_compute_motion, val_vmotion): Now static.
5484 * image.c: Make symbols static if they're not exported.
5485 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5487 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5488 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5490 * fringe.c (standard_bitmaps): Now static.
5491 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5493 * frame.c: Make symbols static if they're not exported.
5494 (x_report_frame_params, make_terminal_frame): Now static.
5495 (get_frame_param): Now static, unless HAVE_NS.
5496 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5497 (x_get_resource_string): Remove; not used.
5498 * frame.h (make_terminal_frame, x_report_frame_params):
5499 (x_get_resource_string); Remove decls.
5500 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5501 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5503 * font.c, fontset.c: Make symbols static if they're not exported.
5504 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5505 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5506 * font.c (font_close_object): Now static.
5507 * font.h (font_close_object): Remove.
5508 * fontset.c (FONTSET_OBJLIST): Remove.
5509 (free_realized_fontset) #if-0 the body, which does nothing.
5510 (face_suitable_for_char_p): #if-0, as it's never called.
5511 * fontset.h (face_suitable_for_char_p): Remove decl.
5512 * xfaces.c (face_at_string_position):
5513 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5514 since 0 is always ASCII.
5516 * fns.c (weak_hash_tables): Now static.
5518 * fileio.c: Make symbols static if they're not exported.
5519 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5520 (Vwrite_region_annotation_buffers): Now static.
5522 * eval.c: Make symbols static if they're not exported.
5523 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5524 * lisp.h (backtrace_list): Remove decl.
5526 * emacs.c: Make symbols static if they're not exported.
5527 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5528 (fatal_error_code, fatal_error_signal_hook, standard_args):
5530 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5531 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5532 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5533 * lisp.h (fatal_error_signal_hook): Remove decl.
5534 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5536 * editfns.c: Move a (normally-unused) function to its only use.
5537 * editfns.c, lisp.h (get_operating_system_release): Remove.
5538 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5539 worth the hassle of breaking this out.
5541 * xterm.c: Make symbols static if they're not exported.
5542 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5543 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5544 (x_destroy_window, x_delete_display):
5546 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5547 (x_mouse_leave): Remove; unused.
5548 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5549 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5550 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5552 (x_mouse_leave): Declare only if WINDOWSNT.
5553 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5554 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5557 * ftxfont.c: Make symbols static if they're not exported.
5558 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5560 * font.h (ftxfont_driver): Likewise.
5562 * xfns.c: Make symbols static if they're not exported.
5563 (x_last_font_name, x_display_info_for_name):
5564 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5565 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5566 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5567 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5568 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5569 (last_show_tip_args): Now static.
5570 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5571 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5572 (x_screen_planes): Remove; unused.
5573 * dispextern.h (x_screen_planes): Remove decl.
5575 * dispnew.c: Make symbols static if they're not exported.
5576 * dispextern.h (redraw_garbaged_frames, scrolling):
5577 (increment_row_positions): Remove.
5578 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5579 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5581 (redraw_garbaged_frames): Remove; unused.
5583 * xfaces.c: Make symbols static if they're not exported.
5584 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5586 * xterm.h (defined_color): Remove decls.
5587 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5588 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5589 (menu_face_changed_default, defined_color, free_realized_face):
5590 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5591 (ascii_face_of_lisp_face): Remove; unused.
5593 * xdisp.c: Make symbols static if they're not exported.
5594 * dispextern.h (scratch_glyph_row, window_box_edges):
5595 (glyph_to_pixel_coords, set_cursor_from_row):
5596 (get_next_display_element, set_iterator_to_next):
5597 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5598 (show_mouse_face): Remove decls
5599 * frame.h (message_buf_print): Likewise.
5600 * lisp.h (pop_message, set_message, check_point_in_composition):
5602 * xterm.h (set_vertical_scroll_bar): Likewise.
5603 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5604 (message_buf_print, scratch_glyph_row, displayed_buffer):
5605 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5606 (get_next_display_element, show_mouse_face, window_box_edges):
5607 (frame_to_window_pixel_xy, check_point_in_composition):
5608 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5609 (glyph_to_pixel_coords): Remove; unused.
5611 * dired.c (file_name_completion): Now static.
5613 * dbusbind.c (xd_in_read_queued_messages): Now static.
5615 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5616 * data.c (circular_list_error): Remove.
5618 * commands.h (last_point_position, last_point_position_buffer):
5619 (last_point_position_window): Remove decls.
5620 * keyboard.c: Make these variables static.
5622 * coding.h (coding, code_convert_region, encode_coding_gap):
5624 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5625 (iso_code_class, detect_coding, code_convert_region): Now static.
5626 (encode_coding_gap): Remove; unused.
5628 * chartab.c (chartab_chars, chartab_bits): Now static.
5630 * charset.h (charset_iso_8859_1): Remove decl.
5631 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5634 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5635 * ccl.c (Vccl_program_table): Now static.
5636 (check_ccl_update): Remove; unused.
5638 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5639 * category.h: ... from here.
5640 * category.c (check_category_table, set_category_set): Now static.
5642 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5643 * lisp.h: Remove these decls.
5645 * buffer.c (buffer_count): Remove unused var.
5647 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5648 so that it's not optimized away.
5649 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5650 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5651 exported only to the debugger.
5653 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5654 * atimer.h (run_all_atimers): Remove; not exported.
5656 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5657 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5658 was inaccessible from Lisp.
5659 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5660 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5662 alloc.c: Import and export fewer symbols, and remove unused items.
5663 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5665 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5666 it's not optimized away by whole-program optimization.
5667 (message_enable_multibyte, free_misc): Remove.
5668 (catchlist, handlerlist, mark_backtrace):
5669 Declare only if BYTE_MARK_STACK.
5670 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5671 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5672 (message_enable_multibyte): Remove decl.
5673 (free_misc, interval_free_list, float_block, float_block_index):
5674 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5675 (cons_free_list, last_marked_index):
5677 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5678 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5679 (mark_backtrace): Define only if BYTE_MARK_STACK.
5680 * xdisp.c (message_enable_multibyte): Now static.
5682 Declare Lisp_Object Q* variables to be 'static' if not exported.
5683 This makes it easier for human readers (and static analyzers)
5684 to see whether these variables are used from other modules.
5685 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5686 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5687 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5688 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5689 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5690 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5691 * xmenu.c, xselect.c:
5692 Declare Q* vars static if they are not used in other modules.
5693 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5694 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5695 Remove decls of unexported vars.
5696 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5698 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5700 Make Emacs functions such as Fatom 'static' by default.
5701 This makes it easier for human readers (and static analyzers)
5702 to see whether these functions can be called from other modules.
5703 DEFUN now defines a static function. To make the function external
5704 so that it can be used in other C modules, use the new macro DEFUE.
5705 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5706 (Finit_image_library):
5707 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5708 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5709 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5710 Remove decls, since these functions are now static.
5711 (Funintern, Fget_internal_run_time): New decls, since these functions
5712 were already external.
5714 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5715 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5716 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5717 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5718 * keyboard.c, keymap.c, lread.c:
5719 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5720 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5721 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5722 Mark functions with DEFUE instead of DEFUN,
5723 if they are used in other modules.
5724 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5725 decls for now-static functions.
5726 * buffer.h (Fdelete_overlay): Remove decl.
5727 * callproc.c (Fgetenv_internal): Mark as internal.
5728 * composite.c (Fremove_list_of_text_properties): Remove decl.
5729 (Fcomposition_get_gstring): New forward static decl.
5730 * composite.h (Fcomposite_get_gstring): Remove decl.
5731 * dired.c (Ffile_attributes): New forward static decl.
5732 * doc.c (Fdocumntation_property): New forward static decl.
5733 * eval.c (Ffetch_bytecode): New forward static decl.
5734 (Funintern): Remove extern decl; now in .h file where it belongs.
5735 * fileio.c (Fmake_symbolic_link): New forward static decl.
5736 * image.c (Finit_image_library): New forward static decl.
5737 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5738 * intervals.h (Fprevious_property_change):
5739 (Fremove_list_of_text_properties): Remove decls.
5740 * keyboard.c (Fthis_command_keys): Remove decl.
5741 (Fcommand_execute): New forward static decl.
5742 * keymap.c (Flookup_key): New forward static decl.
5743 (Fcopy_keymap): Now static.
5744 * keymap.h (Flookup_key): Remove decl.
5745 * process.c (Fget_process): New forward static decl.
5746 (Fprocess_datagram_address): Mark as internal.
5747 * syntax.c (Fsyntax_table_p): New forward static decl.
5748 (skip_chars): Remove duplicate decl.
5749 * textprop.c (Fprevious_property_change): New forward static decl.
5750 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5752 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5753 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5755 * editfns.c (Fformat): Remove unreachable code.
5757 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5759 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5762 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5764 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5765 when at ZV. (Bug#8487)
5767 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5769 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5771 * keyboard.c (parse_tool_bar_item): Likewise.
5772 * sound.c (sound_cleanup, alsa_close): Likewise.
5773 * termcap.c (tgetent): Likewise.
5774 * xfns.c (x_default_font_parameter): Likewise.
5775 * xsettings.c (read_and_apply_settings): Likewise.
5777 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5778 (overrun_check_free): Protoize.
5780 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5782 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5783 since callers should never pass a negative size.
5784 Change the signature to match that of plain 'read' and 'write'; see
5785 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5786 * lisp.h: Update prototypes of emacs_write and emacs_read.
5788 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5790 * xdisp.c (redisplay_window): Don't try to determine the character
5791 position of the scroll margin if the window start point w->startp
5792 is outside the buffer's accessible region. (Bug#8468)
5794 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5796 Fix write-region and its subroutines for buffers > 2GB.
5797 * fileio.c (a_write, e_write): Modify declaration of arguments and
5798 local variables to support buffers larger than 2GB.
5799 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5801 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5802 argument, local variables, and return value.
5804 * lisp.h: Update prototypes of emacs_write and emacs_read.
5806 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5808 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5810 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5812 Fix more problems found by GCC 4.6.0's static checks.
5814 * xdisp.c (vmessage): Use a better test for character truncation.
5816 * charset.c (load_charset_map): <, not <=, for optimization,
5817 and to avoid potential problems with integer overflow.
5818 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5819 * casetab.c (set_identity, shuffle): Likewise.
5820 * editfns.c (Fformat): Likewise.
5821 * syntax.c (skip_chars): Likewise.
5823 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5824 This also lets GCC 4.6.0 generate slightly better loop code.
5826 * callint.c (Fcall_interactively): <, not <=, for optimization.
5827 (Fcall_interactively): Count the number of arguments produced,
5828 not the number of arguments given. This is simpler and lets GCC
5829 4.6.0 generate slightly better code.
5831 * ftfont.c: Distingish more carefully between FcChar8 and char.
5832 The previous code passed unsigned char * to a functions like
5833 strlen and xstrcasecmp that expect char *, which does not
5834 conform to the C standard.
5835 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5836 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5837 char * when the C standard requires it.
5839 * keyboard.c (read_char): Remove unused var.
5841 * eval.c: Port to Windows vsnprintf (Bug#8435).
5843 (SIZE_MAX): Define if the headers do not.
5844 (verror): Do not give up if vsnprintf returns a negative count.
5845 Instead, grow the buffer. This ports to Windows vsnprintf, which
5846 does not conform to C99. Problem reported by Eli Zaretskii.
5847 Also, simplify the allocation scheme, by avoiding the need for
5848 calling realloc, and removing the ALLOCATED variable.
5850 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5852 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5853 But keep the doprint source code for now, as we might revamp it
5854 and use it again (Bug#8435).
5855 * lisp.h (doprnt): Remove.
5856 * Makefile.in (base_obj): Remove doprnt.o.
5857 * deps.mk (doprnt.o): Remove.
5859 error: Print 32- and 64-bit integers portably (Bug#8435).
5860 Without this change, on typical 64-bit hosts error ("...%d...", N)
5861 was used to print both 32- and 64-bit integers N, which relied on
5863 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5865 * lisp.h (error, verror): Mark as printf-like functions.
5866 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5867 Report overflow in size calculations when allocating printf buffer.
5868 Do not truncate output string at its first null byte.
5869 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5870 Truncate the output at a character boundary, since vsnprintf does not
5872 * charset.c (check_iso_charset_parameter): Convert internal
5873 character to string before calling 'error', since %c now has the
5875 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5876 overflow when computing char to be passed to 'error'. Do not
5877 pass Lisp_Object to 'error'; pass the integer instead.
5878 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5879 formatted with plain %d.
5881 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5883 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5885 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5887 * xterm.c (x_catch_errors): Remove duplicate declaration.
5889 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5891 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5893 2011-04-10 Jim Meyering <meyering@redhat.com>
5895 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5896 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5897 return ssize_t not "int", and use size_t as the buffer length.
5898 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5899 * gnutls.h: Update declarations.
5900 * process.c (read_process_output): Use ssize_t, to match.
5901 (send_process): Likewise.
5903 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5905 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5907 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5909 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5910 Use unsigned char, to match FcChar8 type definition.
5912 * xterm.c (handle_one_xevent):
5913 * xmenu.c (create_and_show_popup_menu):
5914 * xselect.c (x_decline_selection_request)
5915 (x_reply_selection_request): Avoid type-punned deref of X events.
5917 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5919 Fix some uses of `int' instead of EMACS_INT.
5920 * search.c (string_match_1, fast_string_match)
5921 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5922 (scan_buffer, find_next_newline_no_quit)
5923 (find_before_next_newline, search_command, Freplace_match)
5924 (Fmatch_data): Make some `int' variables be EMACS_INT.
5926 * xdisp.c (display_count_lines): 3rd argument and return value now
5927 EMACS_INT. All callers changed.
5928 (pint2hrstr): Last argument is now EMACS_INT.
5930 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5931 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5932 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5933 (decode_coding_utf_16, decode_coding_emacs_mule)
5934 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5935 (decode_coding_ccl, decode_coding_charset)
5936 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5937 (decode_coding_iso_2022, decode_coding_emacs_mule)
5938 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5939 <char_offset, last_offset>: Declare EMACS_INT.
5940 (encode_coding_utf_8, encode_coding_utf_16)
5941 (encode_coding_emacs_mule, encode_invocation_designation)
5942 (encode_designation_at_bol, encode_coding_iso_2022)
5943 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5944 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5946 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5947 (encode_invocation_designation): Last argument P_NCHARS is now
5949 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5950 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5952 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5955 * ccl.c (Fccl_execute_on_string): Declare some variables
5958 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5960 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5962 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5964 * process.c (Fformat_network_address): Doc fix.
5966 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5968 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5970 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5972 * keyboard.c (read_char): Call Lisp function help-form-show,
5973 instead of using internal_with_output_to_temp_buffer.
5974 (Qhelp_form_show): New var.
5975 (syms_of_keyboard): Use DEFSYM macro.
5977 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5979 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5981 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5983 * process.c (Flist_processes): Remove to Lisp.
5984 (list_processes_1): Delete.
5986 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5988 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5990 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5992 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5994 Fix more problems found by GCC 4.6.0's static checks.
5996 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5998 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6000 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6002 * xdisp.c (vmessage): Mark as a printf-like function.
6004 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6006 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6008 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6009 printf-like functions.
6010 (tiff_load): Add casts to remove these marks before passing them
6011 to system-supplied API.
6013 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6015 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6016 This avoids several warnings with gcc -Wstrict-overflow.
6017 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6018 directly, rather than having caller test rule sign. This avoids
6019 some unnecessary tests.
6020 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6021 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6022 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6024 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6025 (xfont_open): Avoid unnecessary tests.
6027 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6029 * composite.h, composite.c (composition_gstring_put_cache):
6030 Use EMACS_INT, not int, for length.
6032 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6033 breaking out part of COMPOSITION_DECODE_RULE.
6034 (COMPOSITION_DECODE_RULE): Use it.
6035 * composite.c (get_composition_id): Remove unused local vars,
6036 by using the new macro.
6038 * textprop.c (set_text_properties_1): Change while to do-while,
6039 since the condition is always true at first.
6041 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6042 (interval_deletion_adjustment): Return unsigned value.
6045 * process.c (list_processes_1, create_pty, read_process_output):
6046 (exec_sentinel): Remove vars that were set but not used.
6047 (create_pty): Remove unnecessary "volatile"s.
6048 (Fnetwork_interface_info): Avoid possibility of int overflow.
6049 (read_process_output): Do adaptive read buffering even if carryover.
6050 (read_process_output): Simplify nbytes computation if buffered.
6052 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6054 * syntax.c (scan_words): Remove var that was set but not used.
6055 (update_syntax_table): Use unsigned instead of int.
6057 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6058 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6059 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6061 * print.c (print_error_message): Avoid int overflow.
6063 * font.c (font_list_entities): Redo for clarity,
6064 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6066 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6067 (font_score): Avoid potential overflow in diff calculation.
6069 * fns.c (substring_both): Remove var that is set but not used.
6070 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6072 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6074 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6075 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6076 can always succeed if overflow has undefined behavior.
6078 * search.c (boyer_moore, wordify): Remove vars set but not used.
6079 (wordify): Omit three unnecessary tests.
6081 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6082 All callers changed. This avoids the need for an unused var.
6084 * casefiddle.c (casify_region): Remove var that is set but not used.
6086 * dired.c (file_name_completion): Remove var that is set but not used.
6088 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6090 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6091 (Finsert_file_contents): Remove unnecessary code checking fd.
6093 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6094 Check for integer overflow on size calculations.
6096 * buffer.c (Fprevious_overlay_change): Remove var that is set
6099 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6100 Remove vars that are set but not used.
6101 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6102 (timer_check_2): Mark vars as initialized.
6104 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6106 * image.c (lookup_image): Remove var that is set but not used.
6107 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6109 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6110 that are set but not used.
6112 * xfns.c (make_invisible_cursor): Don't return garbage
6113 if XCreateBitmapFromData fails (Bug#8410).
6115 * xselect.c (x_get_local_selection, x_handle_property_notify):
6116 Remove vars that are set but not used.
6118 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6119 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6121 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6122 Remove var that is set but not used.
6123 (scroll_bar_windows_size): Now size_t, not int.
6124 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6127 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6128 (map_tty_color) [!defined MSDOS]: Likewise.
6130 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6132 * coding.c: Remove vars that are set but not used.
6133 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6134 All callers changed.
6135 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6136 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6137 (decode_coding_charset): Remove vars that are set but not used.
6139 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6140 that is set but not used.
6142 * print.c (print_object): Remove var that is set but not used.
6144 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6145 The gnulib version avoids calling malloc in the usual case,
6146 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6147 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6148 * filelock.c (current_lock_owner): Likewise.
6149 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6150 * sysdep.c: Include allocator.h, careadlinkat.h.
6151 (emacs_no_realloc_allocator): New static constant.
6152 (emacs_readlink): New function.
6153 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6154 ../lib/careadlinkat.h.
6156 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6158 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6159 first non-nil return value).
6161 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6163 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6164 if not defined (Bug#8403).
6166 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6168 * xdisp.c (display_count_lines): Remove parameter `start',
6169 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6170 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6171 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6172 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6173 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6174 and thereabouts. All callers changed.
6175 (get_per_char_metric): Remove parameter `f', unused since
6176 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6178 2011-04-02 Jim Meyering <meyering@redhat.com>
6180 do not dereference NULL upon failed strdup
6181 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6182 (ns_get_family): Likewise.
6184 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6186 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6188 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6190 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6193 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6195 Add lexical binding.
6197 * window.c (Ftemp_output_buffer_show): New fun.
6198 (Fsave_window_excursion):
6199 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6201 * lread.c (lisp_file_lexically_bound_p): New function.
6202 (Fload): Bind Qlexical_binding.
6203 (readevalloop): Remove `evalfun' arg.
6204 Bind Qinternal_interpreter_environment.
6205 (Feval_buffer): Bind Qlexical_binding.
6206 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6208 (syms_of_lread): Declare `lexical-binding'.
6210 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6212 * keyboard.c (eval_dyn): New fun.
6213 (menu_item_eval_property): Use it.
6215 * image.c (parse_image_spec): Use Ffunctionp.
6217 * fns.c (concat, mapcar1): Accept byte-code-functions.
6219 * eval.c (Fsetq): Handle lexical vars.
6220 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6221 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6222 (FletX, Flet): Obey lexical binding.
6223 (Fcommandp): Handle closures.
6224 (Feval): New `lexical' arg.
6225 (eval_sub): New function extracted from Feval. Use it almost
6226 everywhere where Feval was used. Look up vars in lexical env.
6228 (Ffunctionp): Move from subr.el.
6229 (Ffuncall): Handle closures.
6230 (apply_lambda): Remove `eval_flags'.
6231 (funcall_lambda): Handle closures and new byte-code-functions.
6232 (Fspecial_variable_p): New function.
6233 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6234 but without exporting it to Lisp.
6236 * doc.c (Fdocumentation, store_function_docstring):
6237 * data.c (Finteractive_form): Handle closures.
6239 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6242 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6244 (exec_byte_code): New function extracted from Fbyte_code to handle new
6245 calling convention for byte-code-functions. Add new byte-codes.
6247 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6249 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6251 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6253 * xdisp.c (redisplay_internal): Fix prototype.
6255 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6257 * xdisp.c (SCROLL_LIMIT): New macro.
6258 (try_scrolling): Use it when setting scroll_limit.
6259 Limit scrolling to 100 screen lines.
6260 (redisplay_window): Even when falling back on "recentering",
6261 position point in the window according to scroll-conservatively,
6262 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6264 (try_scrolling): When point is above the window, allow searching
6265 as far as scroll_max, or one screenful, to compute vertical
6266 distance from PT to the scroll margin position. This prevents
6267 try_scrolling from unnecessarily failing when
6268 scroll-conservatively is set to a value slightly larger than the
6269 window height. Clean up the case of PT below the margin at bottom
6270 of window: scroll_max can no longer be INT_MAX. When aggressive
6271 scrolling is in use, don't let point enter the opposite scroll
6272 margin as result of the scroll.
6273 (syms_of_xdisp) <scroll-conservatively>: Document the
6274 threshold of 100 lines for never-recentering scrolling.
6276 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6278 * dispextern.h (move_it_by_lines):
6279 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6280 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6281 (message_log_check_duplicate): Remove parameters `prev_bol' and
6282 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6283 (redisplay_internal): Remove parameter `preserve_echo_area',
6284 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6286 * indent.c (Fvertical_motion):
6287 * window.c (window_scroll_pixel_based, Frecenter):
6288 Don't pass `need_y_p' to `move_it_by_lines'.
6290 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6292 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6293 steal a few bits to be more compact.
6294 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6295 Remove unneeded casts.
6297 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6299 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6301 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6302 binding" message (bug#7967).
6304 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6306 Fix more problems found by GCC 4.6.0's static checks.
6308 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6309 Remove unused local var.
6311 * editfns.c (Fmessage_box): Remove unused local var.
6313 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6314 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6315 Omit unused local vars.
6316 * window.c (shrink_windows): Omit unused local var.
6317 * menu.c (digest_single_submenu): Omit unused local var.
6318 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6319 Omit unused local var.
6321 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6322 Don't assume string length fits in int.
6323 (keyremap_step, read_key_sequence): Use size_t for sizes.
6324 (read_key_sequence): Don't check last_real_key_start redundantly.
6326 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6327 instead of alloca (Bug#8344).
6329 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6330 (Fbacktrace_frame): Don't assume nframes fits in int.
6332 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6334 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6337 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6339 * cm.c (calccost): Turn while-do into do-while, for clarity.
6341 * keyboard.c (syms_of_keyboard): Use the same style as later
6342 in this function when indexing through an array. This also
6343 works around GCC bug 48267.
6345 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6347 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6349 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6350 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6352 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6353 This avoids undefined behavior on integer overflow, and is a bit
6354 more convenient anyway since it is compared to a size_t variable.
6356 Variadic C functions now count arguments with size_t, not int.
6357 This avoids an unnecessary limitation on 64-bit machines, which
6358 caused (substring ...) to crash on large vectors (Bug#8344).
6359 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6360 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6361 All variadic functions and their callers changed accordingly.
6362 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6363 * data.c (arith_driver, float_arith_driver): Likewise.
6364 * editfns.c (general_insert_function): Likewise.
6365 * eval.c (struct backtrace.nargs, interactive_p)
6366 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6367 (funcall_lambda, mark_backtrace): Likewise.
6368 * fns.c (concat): Likewise.
6369 * frame.c (x_set_frame_parameters): Likewise.
6370 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6371 0 if not found, not -1. All callers changed.
6373 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6374 (stack_copy_size): Now size_t, not int.
6375 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6377 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6379 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6380 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6381 All callers changed.
6383 * lisp.h (multibyte_char_to_unibyte):
6384 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6385 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6386 * character.h (CHAR_TO_BYTE8):
6387 * cmds.c (internal_self_insert):
6388 * editfns.c (general_insert_function):
6389 * keymap.c (push_key_description):
6390 * search.c (Freplace_match):
6391 * xdisp.c (message_dolog, set_message_1): All callers changed.
6393 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6395 * keyboard.c (safe_run_hook_funcall): New function.
6396 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6397 don't set the hook to nil, but remove the offending function instead.
6398 (Qcommand_hook_internal): Remove, unused.
6399 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6400 Vcommand_hook_internal.
6402 * eval.c (enum run_hooks_condition): Remove.
6403 (funcall_nil, funcall_not): New functions.
6404 (run_hook_with_args): Call each function through a `funcall' argument.
6405 Remove `cond' argument, now redundant.
6406 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6407 (Frun_hook_with_args_until_failure): Adjust accordingly.
6408 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6410 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6412 * dispextern.h (string_buffer_position): Remove declaration.
6414 * print.c (strout): Remove parameter `multibyte', unused since
6415 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6417 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6418 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6419 All callers changed.
6421 * w32.c (_wsa_errlist): Use braces for struct initializers.
6423 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6424 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6425 All callers changed.
6426 (string_buffer_position): Likewise. Also, make static (it's never
6427 used outside xdisp.c).
6428 (cursor_row_p): Remove parameter `w', unused since
6429 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6430 (decode_mode_spec): Remove parameter `precision', introduced during
6431 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6432 All callers changed.
6434 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6436 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6438 2011-03-27 Anders Lindgren <andlind@gmail.com>
6440 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6441 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6442 (ns_update_auto_hide_menu_bar): New functions.
6443 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6444 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6445 ns_constrain_all_frames.
6446 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6447 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6449 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6451 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6453 2011-03-27 Glenn Morris <rgm@gnu.org>
6455 * syssignal.h: Replace RETSIGTYPE with void.
6456 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6457 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6458 Replace SIGTYPE with void everywhere.
6459 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6460 * s/template.h (SIGTYPE): Remove commented out definition.
6462 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6464 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6465 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6467 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6469 * w32.c (read_unc_volume): Use parameter `henum', instead of
6470 global variable `wget_enum_handle'.
6472 * keymap.c (describe_vector): Remove parameters `indices' and
6473 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6474 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6476 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6478 * keyboard.c (timer_check): Remove parameter `do_it_now',
6479 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6480 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6481 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6483 * keyboard.c (read_char):
6484 * w32menu.c (w32_menu_display_help):
6485 * xmenu.c (show_help_event, menu_help_callback):
6486 Adjust calls to `show_help_echo'.
6488 * gtkutil.c (xg_maybe_add_timer):
6489 * keyboard.c (readable_events):
6490 * process.c (wait_reading_process_output):
6491 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6493 * insdel.c (adjust_markers_gap_motion):
6494 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6495 (gap_left, gap_right): Don't call it.
6497 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6499 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6500 incurred during fontification.
6502 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6504 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6505 (DEFVAR_PER_BUFFER): Don't pass it.
6507 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6508 (scrolling_window): Don't pass it.
6510 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6512 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6514 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6516 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6517 of variables specific to SELinux and computation of `encoded_absname'.
6519 * image.c (XPutPixel): Remove unused variable `height'.
6521 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6523 * unexw32.c (get_section_info): Remove unused variable `section'.
6525 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6526 (system_process_attributes): Remove unused variable `sess'.
6527 (sys_read): Remove unused variable `err'.
6529 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6530 (w32_wnd_proc): Remove unused variable `isdead'.
6531 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6532 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6533 (x_create_tip_frame): Remove unused variable `tem'.
6535 * w32inevt.c (w32_console_read_socket):
6536 Remove unused variable `no_events'.
6538 * w32term.c (x_draw_composite_glyph_string_foreground):
6539 Remove unused variable `width'.
6541 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6543 * w32term.c (x_set_glyph_string_clipping):
6544 Don't pass uninitialized region to CombineRgn.
6546 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6548 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6549 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6550 (Fx_close_connection): Remove unused variable `i'.
6552 * w32font.c (w32font_draw): Return number of glyphs.
6553 (w32font_open_internal): Remove unused variable `i'.
6554 (w32font_driver): Add missing initializer.
6556 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6557 (fill_in_menu): Remove unused variable `items_added'.
6559 * w32term.c (last_mouse_press_frame): Remove static global variable.
6560 (w32_clip_to_row): Remove unused variable `f'.
6561 (x_delete_terminal): Remove unused variable `i'.
6563 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6564 (NOTHING): Remove unused static global variable.
6565 (uniscribe_check_otf): Remove unused variable `table'.
6566 (uniscribe_font_driver): Add missing initializers.
6568 2011-03-23 Julien Danjou <julien@danjou.info>
6570 * term.c (Fsuspend_tty, Fresume_tty):
6571 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6572 * window.c (temp_output_buffer_show):
6573 * insdel.c (signal_before_change):
6574 * frame.c (Fhandle_switch_frame):
6575 * fileio.c (Fdo_auto_save):
6576 * emacs.c (Fkill_emacs):
6577 * editfns.c (save_excursion_restore):
6578 * cmds.c (internal_self_insert):
6579 * callint.c (Fcall_interactively):
6580 * buffer.c (Fkill_all_local_variables):
6581 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6583 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6584 unconditionnaly since it does the check itself.
6586 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6588 Fix more problems found by GCC 4.5.2's static checks.
6590 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6591 the first time through the loop, since we know p0 < p1 then.
6592 This also avoids a gcc -Wstrict-overflow warning.
6594 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6595 leading to a memory leak, possible in functions like
6596 load_charset_map_from_file that can allocate an unbounded number
6597 of objects (Bug#8318).
6599 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6600 that could (at least in theory) be that large.
6602 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6603 This is less likely to overflow, and avoids undefined behavior if
6604 overflow does occur. All callers changed. Use strtoul to scan
6605 for the unsigned long integer.
6606 (pint2hrstr): Simplify and tune code slightly.
6607 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6609 * scroll.c (do_scrolling): Work around GCC bug 48228.
6610 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6612 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6613 This also avoids a warning with gcc -Wstrict-overflow.
6614 (validate_x_resource_name): Simplify count usage.
6615 This also avoids a warning with gcc -Wstrict-overflow.
6617 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6620 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6622 * process.c (Fmake_network_process): Use socklen_t, not int,
6623 where POSIX says socklen_t is required in portable programs.
6624 This fixes a porting bug on hosts like 64-bit HP-UX, where
6625 socklen_t is wider than int (Bug#8277).
6626 (Fmake_network_process, server_accept_connection):
6627 (wait_reading_process_output, read_process_output):
6630 * process.c: Rename or move locals to avoid shadowing.
6631 (list_processes_1, Fmake_network_process):
6632 (read_process_output_error_handler, exec_sentinel_error_handler):
6633 Rename or move locals.
6634 (Fmake_network_process): Define label "retry_connect" only if needed.
6635 (Fnetwork_interface_info): Fix pointer signedness.
6636 (process_send_signal): Add cast to avoid pointer signedness problem.
6637 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6638 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6640 Make tparam.h and terminfo.c consistent.
6641 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6642 Include tparam.h instead, since it declares them.
6643 * cm.h (PC): Remove extern decl; tparam.h now does this.
6644 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6645 * terminfo.c: Include tparam.h, to check interfaces.
6646 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6647 (tparam): Adjust signature to match interface in tparam.h;
6648 this removes some undefined behavior. Check that outstring and len
6649 are zero, which they always are with Emacs.
6650 * tparam.h (PC, BC, UP): New extern decls.
6652 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6653 (xftfont_open): Rename locals to avoid shadowing.
6655 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6656 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6657 (OTF_TAG_SYM): Omit macro if not needed.
6658 (ftfont_list): Remove unused local.
6659 (get_adstyle_property, ftfont_pattern_entity):
6660 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6661 Rename locals to avoid shadowing.
6663 * xfont.c (xfont_list_family): Mark var as initialized.
6665 * xml.c (make_dom): Now static.
6667 * composite.c (composition_compute_stop_pos): Rename local to
6669 (composition_reseat_it): Remove unused locals.
6670 (find_automatic_composition, composition_adjust_point): Likewise.
6671 (composition_update_it): Mark var as initialized.
6672 (find_automatic_composition): Mark vars as initialized,
6673 with a FIXME (Bug#8290).
6675 character.h: Rename locals to avoid shadowing.
6676 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6677 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6678 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6679 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6682 * textprop.c (property_change_between_p): Remove; unused.
6684 * intervals.c (interval_start_pos): Now static.
6686 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6688 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6689 Rename locals to avoid shadowing.
6691 * sound.c (wav_play, au_play, Fplay_sound_internal):
6692 Fix pointer signedness.
6693 (alsa_choose_format): Remove unused local var.
6694 (wav_play): Initialize a variable to 0, to prevent undefined
6695 behavior (Bug#8278).
6697 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6699 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6701 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6702 clobbering (Bug#8298).
6703 * sysdep.c (sys_subshell): Likewise.
6704 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6706 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6707 This should get cleaned up, so that child_setup has the
6708 same signature on all platforms.
6710 * callproc.c (call_process_cleanup): Now static.
6711 (relocate_fd): Rename locals to avoid shadowing.
6713 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6715 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6716 not to be necessary, and produces flickering.
6718 2011-03-20 Glenn Morris <rgm@gnu.org>
6720 * config.in: Remove file.
6722 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6724 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6725 are now in src/globals.h.
6726 (syms_of_minibuf): Remove spurious & from previous change.
6728 2011-03-20 Leo <sdl.web@gmail.com>
6730 * minibuf.c (completing-read-function): New variable.
6731 (completing-read-default): Rename from completing-read.
6732 (completing-read): Call completing-read-function.
6734 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6736 * xfaces.c (Fx_load_color_file):
6737 Read color file from absolute filename (bug#8250).
6739 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6741 * makefile.w32-in: Update dependencies.
6743 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6745 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6747 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6749 Fix more problems found by GCC 4.5.2's static checks.
6751 * process.c (make_serial_process_unwind, send_process_trap):
6752 (sigchld_handler): Now static.
6754 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6755 That way, the code declares only the vars that it needs.
6756 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6757 * s/cygwin.h (PTY_ITERATION): Likewise.
6758 * s/darwin.h (PTY_ITERATION): Likewise.
6759 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6761 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6762 * process.c (allocate_pty): Don't declare stb unless it's needed.
6764 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6765 (CONSTANTLIM): Remove; unused.
6766 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6767 Define only if needed.
6769 * unexelf.c (unexec): Name an expression,
6770 to avoid gcc -Wbad-function-cast warning.
6771 Use a different way to cause a compilation error if anyone uses
6772 n rather than nn, a way that does not involve shadowing.
6773 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6775 * deps.mk (unexalpha.o): Remove; unused.
6777 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6778 * unexec.h: New file.
6779 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6780 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6782 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6783 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6784 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6785 Change as necessary to match prototype in unexec.h.
6787 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6789 (back_comment, skip_chars): Mark vars as initialized.
6791 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6792 Rename locals to avoid shadowing.
6794 * lread.c (read1): Rewrite so as not to use empty "else".
6795 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6797 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6799 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6800 warning when compiling print.c.
6802 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6803 instead of using an uninitialized var.
6804 (font_sort_entities): Mark var as initialized.
6806 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6808 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6809 pointers to constants.
6810 (font_parse_fcname): Remove unused vars.
6811 (font_delete_unmatched): Now static.
6812 (font_get_spec): Remove; unused.
6813 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6814 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6815 Rename or move locals to avoid shadowing.
6817 * fns.c (require_nesting_list, require_unwind): Now static.
6818 (Ffillarray): Rename locals to avoid shadowing.
6820 * floatfns.c (domain_error2): Define only if needed.
6821 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6823 * alloc.c (mark_backtrace): Move decl from here ...
6824 * lisp.h: ... to here, so that it can be checked.
6826 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6827 (Fdefvar): Rewrite so as not to use empty "else".
6828 (lisp_indirect_variable): Name an expression,
6829 to avoid gcc -Wbad-function-cast warning.
6830 (Fdefvar): Rename locals to avoid shadowing.
6832 * callint.c (quotify_arg, quotify_args): Now static.
6833 (Fcall_interactively): Rename locals to avoid shadowing.
6834 Use const pointer when appropriate.
6836 * lisp.h (get_system_name, get_operating_system_release):
6837 Move decls here, to check interfaces.
6838 * process.c (get_operating_system_release): Move decl to lisp.h.
6839 * xrdb.c (get_system_name): Likewise.
6840 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6841 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6842 some of which prompt warnings from gcc -Wbad-function-cast.
6843 (Fformat_time_string, Fencode_time, Finsert_char):
6844 (Ftranslate_region_internal, Fformat):
6845 Rename or remove local vars to avoid shadowing.
6846 (Ftranslate_region_internal): Mark var as initialized.
6848 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6851 * lisp.h (eassert): Check that the argument compiles, even if
6852 ENABLE_CHECKING is not defined.
6854 * data.c (Findirect_variable): Name an expression, to avoid
6855 gcc -Wbad-function-cast warning.
6856 (default_value, arithcompare, arith_driver, arith_error): Now static.
6857 (store_symval_forwarding): Rename local to avoid shadowing.
6858 (Fmake_variable_buffer_local, Fmake_local_variable):
6859 Mark variables as initialized.
6860 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6862 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6863 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6864 Rename locals to avoid shadowing.
6865 (mark_stack): Move local variables into the #ifdef region where
6867 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6868 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6870 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6871 (GC_STRING_CHARS): Remove; not used.
6872 (Fmemory_limit): Cast sbrk's returned value to char *.
6874 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6875 avoids undefined behavior in theory.
6877 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6879 Use functions, not macros, for up- and down-casing (Bug#8254).
6880 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6881 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6882 to use the following functions instead of these macros.
6883 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6884 EMACS_INT, since callers assume the returned value fits in int.
6885 (upcase1): Likewise, for UPCASE_TABLE.
6886 (uppercasep, lowercasep, upcase): New static inline functions.
6887 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6888 the race-condition problem in the old DOWNCASE.
6890 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6891 Rename locals to avoid shadowing.
6892 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6893 (regex_compile, re_search_2, re_match_2_internal):
6894 Remove unused local vars.
6895 (FREE_VAR): Rewrite so as not to use empty "else",
6896 which gcc can warn about.
6897 (regex_compile, re_match_2_internal): Mark locals as initialized.
6898 (RETALLOC_IF): Define only if needed.
6899 (WORDCHAR_P): Likewise. This one is never needed, but is used
6900 only in a comment talking about a compiler bug, so put inside
6901 the #if 0 of that comment.
6902 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6903 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6906 * search.c (boyer_moore): Rename locals to avoid shadowing.
6907 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6908 (PREV_CHAR_BOUNDARY): Likewise.
6910 * search.c (simple_search): Remove unused var.
6912 * dired.c (compile_pattern): Move decl from here ...
6913 * lisp.h: ... to here, so that it can be checked.
6914 (struct re_registers): New forward decl.
6916 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6918 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6920 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6921 Rename locals to avoid shadowing.
6922 (Fvertical_motion): Mark locals as initialized.
6924 * casefiddle.c (casify_object, casify_region): Now static.
6925 (casify_region): Mark local as initialized.
6927 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6929 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6930 New macros, so that the caller can use some names other than
6931 gcpro1, gcpro2, etc.
6932 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6934 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6935 argument, for consistency with GCPRO2_VAR, etc: it is now the
6936 prefix of the variable, not the variable itself. All uses
6938 * dired.c (directory_files_internal, file_name_completion):
6939 Rename locals to avoid shadowing.
6941 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6942 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6943 dired.c's scmp function, had undefined behavior.
6944 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6945 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6946 * buffer.h: ... to here, because these macros use current_buffer,
6947 and the new implementation with inline functions needs to have
6948 current_buffer in scope now, rather than later when the macros
6950 (downcase, upcase1): New static inline functions.
6951 (DOWNCASE, UPCASE1): Reimplement using these functions.
6952 This avoids undefined behavior in expressions like
6953 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6954 from race conditions in accessing the global variables
6955 case_temp1 and case_temp2.
6956 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6957 * lisp.h (case_temp1, case_temp2): Remove their decls.
6958 * character.h (ASCII_CHAR_P): Move from here ...
6959 * lisp.h: ... to here, so that the inline functions mentioned
6962 * dired.c (directory_files_internal_unwind): Now static.
6964 * fileio.c (file_name_as_directory, directory_file_name):
6965 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6967 (file_name_as_directory): Use const pointers when appropriate.
6968 (Fexpand_file_name): Likewise. In particular, newdir might
6969 point at constant storage, so make it a const pointer.
6970 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6971 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6973 (Fset_file_times, Finsert_file_contents, auto_save_error):
6974 Rename locals to avoid shadowing.
6976 * minibuf.c (choose_minibuf_frame_1): Now static.
6977 (Ftry_completion, Fall_completions): Rename or remove locals
6980 * marker.c (bytepos_to_charpos): Remove; unused.
6982 * lisp.h (verify_bytepos, count_markers): New decls,
6983 so that gcc does not warn that these functions aren't declared.
6985 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6986 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6987 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6988 (copy_text): Remove unused local var.
6990 * filelock.c (within_one_second): Now static.
6991 (lock_file_1): Rename local to avoid shadowing.
6993 * buffer.c (fix_overlays_before): Mark locals as initialized.
6994 (fix_start_end_in_overlays): Likewise. This function should be
6995 simplified by using pointers-to-pointers, but that's a different
6997 (switch_to_buffer_1): Now static.
6998 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6999 (report_overlay_modification): Rename locals to avoid shadowing.
7001 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7002 Fix pointer signedness issue.
7003 (sys_subshell): Mark local as volatile if checking for lint,
7004 to suppress a gcc -Wclobbered warning that does not seem to be right.
7005 (MAXPATHLEN): Define only if needed.
7007 * process.c (serial_open, serial_configure): Move decls from here ...
7008 * systty.h: ... to here, so that they can be checked.
7010 * fns.c (get_random, seed_random): Move extern decls from here ...
7011 * lisp.h: ... to here, so that they can be checked.
7013 * sysdep.c (reset_io): Now static.
7014 (wait_for_termination_signal): Remove; unused.
7016 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7017 (copy_keymap_item, append_key, push_text_char_description):
7019 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7020 (DENSE_TABLE_SIZE): Remove; unused.
7021 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7022 (describe_map_tree):
7023 Rename locals to avoid shadowing.
7025 * keyboard.c: Declare functions static if they are not used elsewhere.
7026 (echo_char, echo_dash, cmd_error, top_level_2):
7027 (poll_for_input, handle_async_input): Now static.
7028 (read_char, kbd_buffer_get_event, make_lispy_position):
7029 (make_lispy_event, make_lispy_movement, apply_modifiers):
7030 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7031 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7032 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7033 (read_key_sequence, read_char): Mark locals as initialized.
7034 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7036 * keyboard.h (make_ctrl_char): New decl.
7037 (mark_kboards): Move decl here ...
7038 * alloc.c (mark_kboards): ... from here.
7040 * lisp.h (force_auto_save_soon): New decl.
7042 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7043 (DEFINE_DUMMY_FUNCTION): New macro.
7044 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7046 (main): Add casts to avoid warnings
7047 if GCC considers string literals to be constants.
7049 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7051 * dbusbind.c: Pointer signedness fixes.
7052 (xd_signature, xd_append_arg, xd_initialize):
7053 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7054 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7055 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7056 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7058 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7059 if GCC considers string literals to be constants.
7060 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7062 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7064 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7065 (print_preprocess, print_object): New macro to fix last change.
7067 * print.c (print_preprocess): Don't forget font objects.
7069 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7071 * emacs.c (USAGE3): Doc fixes.
7073 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7075 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7078 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7080 * lisp.h (VWindow_system, Qfile_name_history):
7081 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7082 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7083 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7085 * w32select.c: Don't #include "keyboard.h".
7086 (run_protected): Add extern declaration for waiting_for_input.
7088 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7089 * w32console.c (detect_input_pending, read_input_pending)
7090 (encode_terminal_code):
7091 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7092 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7093 (w32_system_caret_y, Qfile_name_history):
7094 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7095 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7096 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7097 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7098 * w32proc.c (Qlocal, report_file_error):
7099 * w32term.c (Vwindow_system, updating_frame):
7100 * w32uniscribe.c (initialized, uniscribe_font_driver):
7101 Remove unneeded extern declarations.
7103 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7105 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7107 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7109 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7110 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7111 These macros can no longer be used for assignment.
7113 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7114 Assign struct members directly, instead of using BUF_BEGV etc.
7115 (record_buffer_markers, fetch_buffer_markers): New functions for
7116 recording and fetching special buffer markers.
7117 (set_buffer_internal_1, set_buffer_temp): Use them.
7119 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7121 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7123 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7124 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7126 * xdisp.c (hscroll_window_tree):
7127 (reconsider_clip_changes): Use PT instead of BUF_PT.
7129 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7131 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7132 $(EMACS_ROOT)/lib/intprops.h.
7134 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7136 Fix more problems found by GCC 4.5.2's static checks.
7138 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7139 to unsigned char * to avoid compiler diagnostic.
7140 (xg_free_frame_widgets): Make it clear that a local variable is
7141 needed only if USE_GTK_TOOLTIP.
7142 (gdk_window_get_screen): Make it clear that this macro is needed
7143 only if USE_GTK_TOOLTIP.
7144 (int_gtk_range_get_value): New function, which avoids a diagnostic
7145 from gcc -Wbad-function-cast.
7146 (xg_set_toolkit_scroll_bar_thumb): Use it.
7147 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7148 diagnostic from gcc -Wbad-function-cast.
7149 (get_utf8_string, xg_get_file_with_chooser):
7150 Rename locals to avoid shadowing.
7151 (create_dialog): Move locals to avoid shadowing.
7153 * xgselect.c (xg_select): Remove unused var.
7155 * image.c (four_corners_best): Mark locals as initialized.
7156 (gif_load): Initialize transparent_p to zero (Bug#8238).
7157 Mark another local as initialized.
7158 (my_png_error, my_error_exit): Mark with NO_RETURN.
7160 * image.c (clear_image_cache): Now static.
7161 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7162 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7163 (x_edge_detection): Remove unnecessary cast that
7164 gcc -Wbad-function-cast diagnoses.
7165 (gif_load): Fix pointer signedness.
7166 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7167 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7169 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7171 Improve quality of tests for time stamp overflow.
7172 For example, without this patch (encode-time 0 0 0 1 1
7173 1152921504606846976) returns the obviously-bogus value (-948597
7174 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7175 reports time overflow. See
7176 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7177 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7178 * editfns.c: Include limits.h and intprops.h.
7179 (TIME_T_MIN, TIME_T_MAX): New macros.
7180 (time_overflow): Move earlier, to before first use.
7181 (hi_time, lo_time): New functions, for an accurate test for
7183 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7184 (Fget_internal_run_time): Don't assume time_t fits in int.
7185 (make_time): Use list2 instead of Fcons twice.
7186 (Fdecode_time): More accurate test for out-of-range times.
7187 (check_tm_member): New function.
7188 (Fencode_time): Use it, to test for out-of-range times.
7189 (lisp_time_argument): Don't rely on undefined left-shift and
7190 right-shift behavior when checking for time stamp overflow.
7192 * editfns.c (time_overflow): New function, refactoring common code.
7193 (Fformat_time_string, Fdecode_time, Fencode_time):
7194 (Fcurrent_time_string): Use it.
7196 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7197 * dired.c (make_time): Move to ...
7198 * editfns.c (make_time): ... here.
7199 * systime.h: Note the move.
7201 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7203 * fringe.c (update_window_fringes): Remove unused variables.
7205 * unexmacosx.c (copy_data_segment): Also copy __got section.
7208 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7210 * termcap.c [MSDOS]: Include "msdos.h".
7211 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7212 Constify `char *' arguments and their references according to
7213 prototypes in tparam.h.
7215 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7217 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7218 Adapt all references accordingly.
7220 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7222 2011-03-11 Tom Tromey <tromey@redhat.com>
7224 * buffer.c (syms_of_buffer): Remove obsolete comment.
7226 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7228 * termhooks.h (encode_terminal_code): Declare prototype.
7230 * msdos.c (encode_terminal_code): Don't declare prototype.
7232 * term.c (encode_terminal_code): Now external again, used by
7233 w32console.c and msdos.c.
7235 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7236 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7238 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7240 Fix some minor problems found by GCC 4.5.2's static checks.
7242 * fringe.c (update_window_fringes): Mark locals as initialized
7244 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7246 * alloc.c (mark_fringe_data): Move decl from here ...
7247 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7248 to check its interface.
7249 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7251 * fontset.c (free_realized_fontset): Now static.
7252 (Fset_fontset_font): Rename local to avoid shadowing.
7253 (fontset_font): Mark local as initialized.
7254 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7256 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7258 * xselect.c (x_disown_buffer_selections): Remove; not used.
7259 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7260 (x_own_selection, Fx_disown_selection_internal): Rename locals
7262 (x_handle_dnd_message): Remove local to avoid shadowing.
7264 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7265 so that the caller can use some name other than gcpro1.
7266 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7267 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7268 (Fx_backspace_delete_keys_p):
7269 Use them to avoid shadowing, and rename vars to avoid shadowing.
7270 (x_decode_color, x_set_name, x_window): Now static.
7271 (Fx_create_frame): Add braces to silence GCC warning.
7272 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7273 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7274 Remove unused locals.
7275 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7276 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7277 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7280 * xterm.h (x_mouse_leave): New decl.
7282 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7283 Remove unused functions.
7284 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7285 (x_calc_absolute_position): Now static.
7286 (XTread_socket): Don't define label "out" unless it's used.
7287 Don't declare local "event" unless it's used.
7288 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7289 unless they are used.
7290 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7291 (x_fatal_error_signal): Remove; not used.
7292 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7293 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7294 (x_error_catcher, x_connection_closed, x_error_handler):
7295 (x_error_quitter, xembed_send_message, x_iconify_frame):
7296 (my_log_handler): Rename locals to avoid shadowing.
7297 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7298 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7300 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7301 Rename or move locals to avoid shadowing.
7302 (tty_defined_color, merge_face_heights): Now static.
7303 (free_realized_faces_for_fontset): Remove; not used.
7304 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7305 does not deduce is never used uninitialized.
7306 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7307 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7309 * terminal.c (store_terminal_param): Now static.
7311 * xmenu.c (menu_highlight_callback): Now static.
7312 (set_frame_menubar): Remove unused local.
7313 (xmenu_show): Rename parameter to avoid shadowing.
7314 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7315 since they might point to immutable storage.
7316 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7317 since it's unused otherwise.
7319 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7320 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7321 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7322 avoids a gcc -Wuninitialized diagnostic.
7323 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7324 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7325 does not deduce are never used uninitialized.
7327 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7329 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7330 * window.c (window_loop, size_window):
7331 (run_window_configuration_change_hook, enlarge_window): Likewise.
7333 * window.c (display_buffer): Now static.
7334 (size_window): Mark variables that gcc -Wuninitialized
7335 does not deduce are never used uninitialized.
7336 * window.h (check_all_windows): New decl, to forestall
7337 gcc -Wmissing-prototypes diagnostic.
7338 * dispextern.h (bidi_dump_cached_states): Likewise.
7340 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7342 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7344 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7345 and to avoid gcc -Wuninitialized warning.
7346 (load_charset_map): Mark variables that gcc -Wuninitialized
7347 does not deduce are never used uninitialized.
7348 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7350 * coding.c (coding_set_source, coding_set_destination):
7351 Use "else { /* comment */ }" rather than "else /* comment */;"
7352 for clarity, and to avoid gcc -Wempty-body warning.
7353 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7354 a block, when the outer 'i' will do.
7355 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7356 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7357 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7358 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7359 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7360 Rename locals to avoid shadowing.
7361 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7362 * coding.c (emacs_mule_char, encode_invocation_designation):
7363 Now static, since they're not used elsewhere.
7364 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7365 (decode_coding_object, encode_coding_object, detect_coding_system):
7366 (decode_coding_emacs_mule): Mark variables that gcc
7367 -Wuninitialized does not deduce are never used uninitialized.
7368 (detect_coding_iso_2022): Initialize a local variable that might
7369 be used uninitialized. Leave a FIXME because it's not clear that
7370 this initialization is needed. (Bug#8211)
7371 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7372 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7373 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7374 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7375 Remove unused macros.
7377 * category.c (hash_get_category_set): Remove unused local var.
7378 (copy_category_table): Now static, since it's not used elsewhere.
7379 * character.c (string_count_byte8): Likewise.
7381 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7382 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7384 * chartab.c (copy_sub_char_table): Now static, since it's not used
7386 (sub_char_table_ref_and_range, char_table_ref_and_range):
7387 Rename locals to avoid shadowing.
7388 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7390 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7391 (BIDI_BOB): Remove unused macro.
7393 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7394 deduce are never used uninitialized.
7395 * term.c (encode_terminal_code): Likewise.
7397 * term.c (encode_terminal_code): Now static. Remove unused local.
7399 * tparam.h: New file.
7400 * term.c, tparam.h: Include it.
7401 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7402 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7403 Move these decls to tparam.h, and make them agree with what
7404 is actually in tparam.c. The previous trick of using incompatible
7405 decls in different modules does not conform to the C standard.
7406 All callers of tparam changed to use tparam's actual API.
7407 * tparam.c (tparam1, tparam, tgoto):
7408 Use const pointers where appropriate.
7410 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7411 * cm.h (struct cm): Likewise.
7412 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7413 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7414 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7415 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7416 (turn_on_face, init_tty): Likewise.
7417 * termchar.h (struct tty_display_info): Likewise.
7419 * term.c (term_mouse_position): Rename local to avoid shadowing.
7421 * alloc.c (mark_ttys): Move decl from here ...
7422 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7424 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7426 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7428 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7430 * search.c (compile_pattern_1): Remove argument regp, unused since
7431 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7432 (compile_pattern): Don't pass it.
7434 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7436 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7437 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7439 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7441 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7443 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7444 gdk_window_get_screen, gdk_window_get_geometry,
7445 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7446 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7447 (xg_get_pixbuf_from_pixmap): New function.
7448 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7449 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7450 Call xg_get_pixbuf_from_pixmap instead of
7451 gdk_pixbuf_get_from_drawable.
7452 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7453 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7454 (xg_check_special_colors): Use GtkStyleContext and its functions
7456 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7457 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7458 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7459 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7460 Call gtk_widget_get_preferred_size.
7461 (xg_frame_resized): gdk_window_get_geometry only takes 5
7463 (xg_win_to_widget, xg_event_is_for_menubar):
7464 Call gdk_x11_window_lookup_for_display.
7465 (xg_set_widget_bg): New function.
7466 (delete_cb): New function.
7467 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7468 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7469 (xg_set_background_color): Call xg_set_widget_bg.
7470 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7471 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7472 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7473 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7475 (update_frame_tool_bar): Call gtk_widget_hide.
7476 (xg_initialize): Use GDK_KEY_g.
7478 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7480 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7482 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7483 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7484 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7486 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7488 * w32xfns.c (select_palette): Check success of RealizePalette against
7489 GDI_ERROR, not zero.
7491 See ChangeLog.11 for earlier changes.
7497 Copyright (C) 2011 Free Software Foundation, Inc.
7499 This file is part of GNU Emacs.
7501 GNU Emacs is free software: you can redistribute it and/or modify
7502 it under the terms of the GNU General Public License as published by
7503 the Free Software Foundation, either version 3 of the License, or
7504 (at your option) any later version.
7506 GNU Emacs is distributed in the hope that it will be useful,
7507 but WITHOUT ANY WARRANTY; without even the implied warranty of
7508 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7509 GNU General Public License for more details.
7511 You should have received a copy of the GNU General Public License
7512 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.