1 2012-02-25 Chong Yidong <cyd@gnu.org>
3 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
6 * xselect.c (Fx_selection_exists_p): Doc fix.
7 (x_clipboard_manager_save_all): Print an informative message
8 before saving to clipboard manager.
10 2012-02-24 Chong Yidong <cyd@gnu.org>
12 * keyboard.c (process_special_events): Handle all X selection
13 requests in kbd_buffer, not just the next one (Bug#8869).
15 2012-02-23 Chong Yidong <cyd@gnu.org>
17 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
18 call when setting menu-bar-lines and tool-bar-lines parameters.
19 (unwind_create_frame_1): New helper function.
21 * window.c (inhibit_window_configuration_change_hook): New var.
22 (run_window_configuration_change_hook): Obey it.
23 (syms_of_window): Initialize it.
25 2012-02-22 Chong Yidong <cyd@gnu.org>
27 * xterm.c (x_draw_image_relief): Add missing type check for
28 Vtool_bar_button_margin (Bug#10743).
30 2012-02-21 Chong Yidong <cyd@gnu.org>
32 * fileio.c (Vfile_name_handler_alist): Doc fix.
34 * buffer.c (Fget_file_buffer): Protect against invalid file
37 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
39 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
40 when computing $valmask.
42 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
43 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
44 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
45 It's useless in that case, and it can cause problems on hosts
46 that allocate halves of EMACS_INT values separately.
47 Reported by Dan Horák. Diagnosed by Andreas Schwab in
48 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
49 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
50 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
51 it avoids undefined behavior on hosts where shifting right by more
52 than the word width has undefined behavior.
54 2012-02-19 Chong Yidong <cyd@gnu.org>
56 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
57 (Funhandled_file_name_directory, Ffile_name_as_directory)
58 (Fdirectory_file_name, Fexpand_file_name)
59 (Fsubstitute_in_file_name): Protect against invalid file handler
60 return values (Bug#10845).
62 2012-02-18 Eli Zaretskii <eliz@gnu.org>
64 * .gdbinit (pitx): Fix incorrect references to fields of the
67 2012-02-17 Chong Yidong <cyd@gnu.org>
69 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
71 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
73 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
74 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
76 2012-02-15 Chong Yidong <cyd@gnu.org>
78 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
79 marked as special. Also, starting docstrings with * is obsolete.
81 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
83 * gnutls.c (emacs_gnutls_write): Fix last change.
85 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
87 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
90 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
92 * keymap.c (Fsingle_key_description): Handle char ranges.
94 2012-02-12 Chong Yidong <cyd@gnu.org>
96 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
97 as that creates a dangerous corner case.
99 * window.c (Fdelete_window_internal): Invalidate the mouse
100 highlight (Bug#9904).
102 2012-02-12 Glenn Morris <rgm@gnu.org>
104 * xselect.c (Fx_own_selection_internal)
105 (Fx_get_selection_internal, Fx_disown_selection_internal)
106 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
107 * nsselect.m (Fx_own_selection_internal)
108 (Fx_disown_selection_internal, Fx_selection_exists_p)
109 (Fx_selection_owner_p, Fx_get_selection_internal):
110 Sync docs and argument specs with the xselect.c versions.
112 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
114 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
116 2012-02-11 Eli Zaretskii <eliz@gnu.org>
118 * w32select.c (Fx_selection_exists_p): Sync doc string and
119 argument list with xselect.c. (Bug#10783)
121 * w16select.c (Fx_selection_exists_p): Sync doc string and
122 argument list with xselect.c. (Bug#10783)
124 2012-02-10 Glenn Morris <rgm@gnu.org>
126 * fns.c (Fsecure_hash): Doc fix.
128 2012-02-09 Kenichi Handa <handa@m17n.org>
130 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
132 2012-02-07 Chong Yidong <cyd@gnu.org>
134 * buffer.c (Fbuffer_local_variables)
135 (buffer_lisp_local_variables): Handle unbound vars correctly;
136 don't let Qunbound leak into Lisp.
138 2012-02-07 Glenn Morris <rgm@gnu.org>
140 * image.c (Fimagemagick_types): Doc fix.
142 * image.c (imagemagick-render-type): Change it from a lisp object
143 to an integer. Move the doc here from the lisp manual.
144 Treat all values not equal to 0 the same.
146 2012-02-06 Chong Yidong <cyd@gnu.org>
148 * doc.c (store_function_docstring): Avoid applying docstring of
149 alias to base function (Bug#2603).
151 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
153 * .gdbinit (pp1, pv1): Remove redundant defines.
156 2012-02-04 Chong Yidong <cyd@gnu.org>
158 * nsterm.m: Declare a global (Bug#10694).
160 2012-02-04 Eli Zaretskii <eliz@gnu.org>
162 * w32.c (get_emacs_configuration_options): Include
163 --enable-checking, if specified, in the return value.
165 2012-02-04 Martin Rudalics <rudalics@gmx.at>
167 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
168 after rounding frame sizes. (Bug#9723)
170 2012-02-04 Eli Zaretskii <eliz@gnu.org>
172 * keyboard.c (adjust_point_for_property): Don't position point
173 before BEGV. (Bug#10696)
175 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
177 Handle overflow when computing char display width (Bug#9496).
178 * character.c (char_width): Return EMACS_INT, not int.
179 (char_width, c_string_width): Check for overflow when
180 computing the width; this is possible now that individual
181 characters can have unbounded width. Problem introduced
182 by merge from Emacs 23 on 2012-01-19.
184 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
186 * dbusbind.c (Fdbus_register_method): Mention the return value
187 :ignore in the docstring.
189 2012-02-02 Glenn Morris <rgm@gnu.org>
191 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
193 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
194 Unconditionally set to t. (Bug#10673)
195 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
196 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
197 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
199 2012-02-02 Kenichi Handa <handa@m17n.org>
201 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
202 0, do not call append_composite_glyph.
204 2012-02-02 Kenichi Handa <handa@m17n.org>
206 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
208 (x_produce_glyphs): If the component of a composition is a null
209 string, set it->pixel_width to 1 to avoid zero-width glyph.
211 2012-02-01 Eli Zaretskii <eliz@gnu.org>
213 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
214 first 2 arguments are identical. This makes inserting large
215 output from a subprocess an order of magnitude faster on
216 MS-Windows, where all sbrk'ed memory is always contiguous.
218 2012-01-31 Glenn Morris <rgm@gnu.org>
220 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
221 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
222 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
224 2012-01-29 Glenn Morris <rgm@gnu.org>
226 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
228 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
230 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
232 2012-01-28 Chong Yidong <cyd@gnu.org>
234 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
236 2012-01-26 Chong Yidong <cyd@gnu.org>
238 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
240 * search.c (Fsearch_forward, Fsearch_backward): Document negative
241 repeat counts (Bug#10507).
243 2012-01-26 Glenn Morris <rgm@gnu.org>
245 * lread.c (syms_of_lread): Doc fix.
247 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
249 * coding.c (encode_designation_at_bol): Change return value to
252 2012-01-25 Chong Yidong <cyd@gnu.org>
254 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
256 2012-01-21 Chong Yidong <cyd@gnu.org>
258 * floatfns.c (Fcopysign): Make the second argument non-optional,
259 since nil is not allowed anyway.
261 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
263 * process.c (read_process_output): Use p instead of XPROCESS (proc).
264 (send_process): Likewise.
266 2012-01-19 Martin Rudalics <rudalics@gmx.at>
268 * window.c (save_window_save, Fcurrent_window_configuration)
269 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
272 2012-01-19 Kenichi Handa <handa@m17n.org>
274 * character.c (char_width): New function.
275 (Fchar_width, c_string_width, lisp_string_width):
276 Use char_width (Bug#9496).
278 2012-01-16 Martin Rudalics <rudalics@gmx.at>
280 * window.c (Vwindow_persistent_parameters): New variable.
281 (Fset_window_configuration, save_window_save): Handle persistent
284 2012-01-14 Eli Zaretskii <eliz@gnu.org>
286 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
287 thrashing the stack of the thread. (Bug#9087)
289 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
291 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
293 2012-01-11 Eli Zaretskii <eliz@gnu.org>
295 * xdisp.c (rows_from_pos_range): Handle the case where the
296 highlight ends on a newline. (Bug#10464)
297 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
298 he end column for display of highlight that ends on a newline
301 2012-01-11 Glenn Morris <rgm@gnu.org>
303 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
304 from load-path also when installation-directory is nil. (Bug#10208)
306 2012-01-10 Glenn Morris <rgm@gnu.org>
308 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
310 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
311 Update template values to be closer to their typical values these days.
313 2012-01-09 Eli Zaretskii <eliz@gnu.org>
315 * xdisp.c (rows_from_pos_range): Accept additional argument
316 DISP_STRING, and accept any glyph in a row whose object is that
317 string as eligible for mouse highlight. Fixes mouse highlight of
318 display strings from overlays. (Bug#10464)
320 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
322 emacs: fix an auto-save permissions race condition (Bug#10400)
323 * fileio.c (auto_saving_dir_umask): New static var.
324 (Fmake_directory_internal): Use it.
325 (do_auto_save_make_dir): Set it, instead of invoking chmod after
326 creating the directory. The old code temporarily assigns
327 too-generous permissions to the directory.
328 (do_auto_save_eh): Clear it.
329 (Fdo_auto_save): Catch all errors, not just file errors, so
330 that the var is always cleared.
332 2012-01-07 Eli Zaretskii <eliz@gnu.org>
334 * search.c (scan_buffer): Pass character positions to
335 know_region_cache, not byte positions. (Bug#6540)
337 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
339 * w32.c (sys_rename): Report EXDEV when rename of a directory
340 fails because the target is on another logical disk. (Bug#10284)
342 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
344 * xterm.c (x_embed_request_focus): New function.
346 * xterm.h: Add prototype.
348 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
350 2012-01-05 Glenn Morris <rgm@gnu.org>
352 * emacs.c (emacs_copyright): Update short copyright year to 2012.
354 2012-01-01 Eli Zaretskii <eliz@gnu.org>
356 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
357 Load gnutls_transport_set_lowat only if GnuTLS version is below
359 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
360 GnuTLS versions below 2.11.1.
362 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
364 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
365 to the doc string advising against its use for altering the way
366 windows are scrolled.
368 2011-12-28 Kenichi Handa <handa@m17n.org>
370 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
371 coding-system ASCII compatible only when it does not produce BOM
372 on encoding (Bug#10383).
374 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
376 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
378 (create_and_show_popup_menu): Always use menu_position_func for
381 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
383 * callint.c (Fcall_interactively): Don't truncate prompt string.
385 2011-12-23 Eli Zaretskii <eliz@gnu.org>
387 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
388 property that ends at ZV, so that the bidi iteration could be
389 resumed from there (after widening). (Bug#10360)
391 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
393 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
395 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
397 * nsterm.m (x_free_frame_resources):
398 Release f->output_data.ns->miniimage.
399 (ns_index_color): Fix indentation. Do not retain
400 color_table->colors[i].
402 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
405 * nsfns.m (x_set_background_color): Assign return value from
406 ns_index_color to face-background instead of NSColor*.
407 (ns_implicitly_set_icon_type): Fix indentation.
408 Change assignment in for loop to comparison.
410 * emacs.c (ns_pool): New variable.
411 (main): Assign ns_pool.
412 (Fkill_emacs): Call ns_release_autorelease_pool.
414 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
415 autorelease fdesc, release fdAttrs and tdict.
416 (ns_get_covering_families): Release charset.
417 (ns_findfonts): Release NSFontDescriptor created with new.
418 (ns_uni_to_glyphs): Fix indentation.
419 (setString): Release attrStr before assigning new value.
421 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
423 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
425 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
426 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
428 2011-12-18 David Reitter <reitter@cmu.edu>
430 * nsterm.m (ns_term_init): Subscribe for notifications
431 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
432 to method trackingNotification in EmacsMenu.
434 * nsmenu.m (trackingMenu): New variable.
435 (trackingNotification): New method (from Aquamacs).
436 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
437 from Aquamacs (Bug#7030).
439 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
441 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
442 (symbol_to_nsstring): Fix indentation.
443 (ns_symbol_to_pb): New function.
444 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
445 (Fns_rotate_cut_buffers_internal): Removed.
446 (Fns_store_selection_internal): Renamed from
447 Fns_store_cut_buffer_internal.
448 (ns_get_foreign_selection, Fx_own_selection_internal)
449 (Fx_disown_selection_internal, Fx_selection_exists_p)
450 (Fns_get_selection_internal, Fns_store_selection_internal):
451 Use ns_symbol_to_pb and check if return value is nil.
452 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
453 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
454 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
455 renamed to Sns_store_selection_internal.
456 (ns_handle_selection_request): Move code to Fx_own_selection_internal
457 and remove this function.
458 (ns_handle_selection_clear): Remove, never used.
459 (Fx_own_selection_internal): Move code from ns_handle_selection_request
462 2011-12-17 Ken Brown <kbrown@cornell.edu>
464 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
465 GID is unknown (Bug#10257).
467 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
469 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
470 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
471 which caused a build failure on GNU/Linux IA-64. This problem was
472 introduced by my 2011-10-07 patch.
474 2011-12-15 Juri Linkov <juri@jurta.org>
476 * image.c (imagemagick_error): New function. (Bug#10112)
477 (imagemagick_load_image): Comment out `MagickSetResolution' call.
478 Use `imagemagick_error' where ImageMagick functions return
480 (Fimagemagick_types): Add `Fnreverse' to return the list in the
483 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
485 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
486 fill background (Bug#8992).
488 2011-12-13 Martin Rudalics <rudalics@gmx.at>
490 * window.c (Vwindow_combination_resize)
491 (Vwindow_combination_limit): Use t instead of non-nil in
493 (Vrecenter_redisplay): Add first sentence of doc-string on
495 (Frecenter): Fix doc-string typo.
497 2011-12-11 Kenichi Handa <handa@m17n.org>
499 * coding.c (Funencodable_char_position): Pay attention to the
500 buffer text relocation (Bug#9389).
502 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
504 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
505 gtk_init (Bug#10100).
507 2011-12-10 Eli Zaretskii <eliz@gnu.org>
509 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
510 IT->string is nil. (Bug#10263)
512 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
514 * nsterm.h (x_free_frame_resources): Declare.
516 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
517 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
519 * nsterm.h (ns_get_defaults_value): Declare.
521 * nsterm.m (ns_default): Call ns_get_defaults_value.
523 2011-12-09 Eli Zaretskii <eliz@gnu.org>
525 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
528 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
530 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
531 that where the value of an _OBJC_* symbol points to is in the .bss
534 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
536 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
537 after the loop to call ccl_driver at least once (Bug#8619).
539 2011-12-08 Kenichi Handa <handa@m17n.org>
541 * ftfont.c (get_adstyle_property): Fix previous change
544 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
546 * w32.c (init_environment): If no_site_lisp, remove site-lisp
547 dirs from the default value of EMACSLOADPATH (bug#10208).
549 2011-12-07 Glenn Morris <rgm@gnu.org>
551 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
552 installation and source directories as well. (Bug#10208)
554 2011-12-06 Chong Yidong <cyd@gnu.org>
556 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
558 2011-12-06 Glenn Morris <rgm@gnu.org>
560 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
561 as an error, not just -1. (Bug#10217)
563 2011-12-05 Chong Yidong <cyd@gnu.org>
565 * keyboard.c (process_special_events): New function.
566 (swallow_events, Finput_pending_p): Use it (Bug#10195).
568 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
570 * coding.c (encode_designation_at_bol): Don't use uninitialized
571 local variable (Bug#9318).
573 2011-12-05 Kenichi Handa <handa@m17n.org>
575 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
576 return Qnil (Bug#8046, Bug#10193).
578 2011-12-05 Kenichi Handa <handa@m17n.org>
580 * coding.c (encode_designation_at_bol): New args charbuf_end and
581 dst. Return the number of produced bytes. Callers changed.
582 (coding_set_source): Return how many bytes coding->source was
584 (coding_set_destination): Return how many bytes
585 coding->destination was relocated.
586 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
587 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
589 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
591 * coding.c (CODING_CHAR_CHARSET_P): New macro.
592 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
595 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
597 The following changes are to fix Bug#9318.
599 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
600 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
601 (encode_coding_iso_2022, encode_coding_sjis)
602 (encode_coding_big5, encode_coding_charset): Use the above macros.
604 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
606 * lisp.h (process_quit_flag): Fix external declaration.
608 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
610 Don't macro-inline non-performance-critical code.
611 * eval.c (process_quit_flag): New function.
612 * lisp.h (QUIT): Use it.
614 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
616 * nsfns.m (get_geometry_from_preferences): New function.
617 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
619 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
621 * emacs.c (Qkill_emacs): Define.
622 (syms_of_emacs): Initialize it.
623 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
624 Qquit_flag to `kill-emacs' instead.
625 (quit_throw_to_read_char): Add parameter `from_signal'.
626 All callers changed. Call Fkill_emacs if requested and safe.
627 * lisp.h (QUIT): Call Fkill_emacs if requested.
629 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
631 * widget.c (update_wm_hints): Return if wmshell is null.
632 (widget_update_wm_size_hints): New function.
634 * widget.h (widget_update_wm_size_hints): Declare.
636 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
637 widget_update_wm_size_hints (Bug#10104).
639 2011-12-03 Eli Zaretskii <eliz@gnu.org>
641 * xdisp.c (handle_invisible_prop): If the invisible text ends just
642 before a newline, prepare the bidi iterator for consuming the
643 newline, and keep the current paragraph direction. (Bug#10183)
644 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
646 2011-12-02 Juri Linkov <juri@jurta.org>
648 * search.c (Fword_search_regexp): New Lisp function created from
649 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
650 (Fword_search_backward, Fword_search_forward)
651 (Fword_search_backward_lax, Fword_search_forward_lax):
652 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
653 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
655 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
657 * fileio.c (Finsert_file_contents): Move after-change-function call
658 to before the "handled:" label, since all "goto handled" appear in
659 cases where the *-change-functions have already been properly called
662 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
664 * keyboard.c (interrupt_signal): Don't call kill-emacs when
665 waiting for input. (Bug#10169)
667 2011-11-30 Eli Zaretskii <eliz@gnu.org>
669 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
670 verifies glyph row's hash code--we have just reallocated the
671 glyphs, so their contents can be complete garbage. (Bug#10164)
673 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
675 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
677 2011-11-30 Eli Zaretskii <eliz@gnu.org>
679 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
680 attributes are tested _before_ calling verify_row_hash, to protect
681 against GCC re-ordering of the tests. (Bug#10164)
683 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
685 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
687 * xterm.c (handle_one_xevent): Only set async_visible and friends
688 if net_wm_state_hidden_seen is non-zero (Bug#10002)
689 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
690 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
692 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
694 Remove GCPRO-related macros that exist only to avoid shadowing locals.
695 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
696 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
697 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
698 All uses changed to use GCPRO1 etc.
699 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
700 Revert to old implementation (i.e., before 2011-03-11).
702 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
704 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
705 of scroll runs so as to avoid assigning disabled bogus rows and
706 unnecessary graphics copy operations.
708 2011-11-27 Eli Zaretskii <eliz@gnu.org>
710 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
711 (snprintf) [_MSC_VER]: Redirect to _snprintf.
712 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
713 (malloc, free, realloc, calloc): Redirect to e_* only when
716 * lisp.h (GCTYPEBITS): Move before first use.
717 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
718 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
719 this macro definition.
721 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
724 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
726 * gtkutil.c (xg_create_frame_widgets):
727 Call gtk_window_set_has_resize_grip (FALSE) if that function is
728 present with Gtk+ 2.0.
730 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
732 * fileio.c (Finsert_file_contents): Undo previous change; see
733 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
735 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
737 Rename locals to avoid shadowing.
738 * fileio.c (Finsert_file_contents):
739 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
740 * process.c (wait_reading_process_output):
741 Rename inner 'proc' to 'p' to avoid shadowing.
742 Indent for consistency with usual Emacs style.
744 2011-11-25 Eli Zaretskii <eliz@gnu.org>
746 * xdisp.c (redisplay_window): If cursor row is not fully visible
747 after recentering, and scroll-conservatively is set to a large
748 number, scroll window by a few more lines to make the cursor fully
749 visible and out of scroll-margin. (Bug#10105)
750 (start_display): Don't move to the next line if the display should
751 start at a newline that is part of a display vector or an overlay
754 2011-11-24 Juri Linkov <juri@jurta.org>
756 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
757 after the `MagickPingImage' call. (Bug#10112)
759 2011-11-23 Chong Yidong <cyd@gnu.org>
761 * window.c (Fcoordinates_in_window_p): Accept only live windows.
763 2011-11-23 Martin Rudalics <rudalics@gmx.at>
765 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
766 making another buffer current. (Bug#10114)
768 2011-11-23 Glenn Morris <rgm@gnu.org>
770 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
772 2011-11-23 Chong Yidong <cyd@gnu.org>
774 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
777 2011-11-22 Eli Zaretskii <eliz@gnu.org>
779 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
780 and header-lines, as they don't have one computed for them.
783 * .gdbinit (prow): Make displayed values more self-explaining.
786 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
788 * process.c (wait_reading_process_output): Fix asynchrounous
789 GnuTLS socket handling on some versions of the GnuTLS library.
790 (wait_reading_process_output): Add comment and URL.
792 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
794 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
796 2011-11-21 Chong Yidong <cyd@gnu.org>
798 * window.c (Fnext_window, Fprevious_window): Doc fix.
800 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
802 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
804 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
806 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
808 2011-11-20 Martin Rudalics <rudalics@gmx.at>
810 * window.c (Fset_window_combination_limit): Rename argument
812 (Vwindow_combination_limit): Remove "status" from doc-string.
814 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
816 * m/ibms390.h: Remove.
817 * m/ibms390x.h: Don't include "ibms390.h".
819 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
821 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
822 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
824 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
826 * casetab.c (Fset_case_table):
827 * charset.c (Fcharset_after): Fix typos.
829 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
831 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
832 Otherwise, valgrind does not work on some platforms.
833 Problem reported by Andreas Schwab in
834 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
835 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
836 is set, removing the need for VIRT_ADDRESS_VARIES.
837 (PURE_P): Use a more-efficient implementation that needs just one
838 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
839 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
840 to 4 (xorl, subq, cmpq, setbe).
841 * alloc.c (pure): Always extern now, since that's the
842 VIRT_ADDR_VARIES behavior.
843 (PURE_POINTER_P): Use a single comparison, not two, for
844 consistency with the new puresize.h.
845 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
846 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
847 Remove VIRT_ADDR_VARIES no longer needed.
849 2011-11-19 Eli Zaretskii <eliz@gnu.org>
851 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
852 (erase_phys_cursor, update_window_cursor, show_mouse_face)
853 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
854 behave as if the cursor position were at the window margin.
856 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
857 and the cursor position is out of bounds, behave as if the cursor
858 position were at the window margin. (Bug#10075)
860 2011-11-18 Chong Yidong <cyd@gnu.org>
862 * window.c (Fwindow_combination_limit): Make first argument
863 non-optional, since it is meaningless for live windows like the
866 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
868 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
870 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
872 * intervals.c: Fix grafting over the whole buffer (bug#10071).
873 (graft_intervals_into_buffer): Simplify.
875 2011-11-18 Eli Zaretskii <eliz@gnu.org>
877 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
878 hash values of the two rows.
879 (copy_row_except_pointers): Preserve the used[] arrays and the
880 hash values of the two rows. (Bug#10035)
881 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
883 * xdisp.c (row_hash): New function, body extracted from
884 compute_line_metrics.
885 (compute_line_metrics): Call row_hash, instead of computing the
888 * dispnew.c (verify_row_hash): Call row_hash for computing the
889 hash code of a row, instead of duplicating code from xdisp.c.
891 * dispextern.h (row_hash): Add prototype.
893 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
895 * frame.c (delete_frame): Don't delete the terminal when the last
896 X frame is closed if emacs is built with GTK toolkit.
898 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
900 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
902 2011-11-17 Martin Rudalics <rudalics@gmx.at>
904 * window.c (Vwindow_splits): Rename to
905 Vwindow_combination_resize. Suggested by Juri Linkov.
906 (Fsplit_window_internal): Use Vwindow_combination_resize instead
909 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
911 * nsfns.m (Fns_font_name):
912 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
914 2011-11-16 Martin Rudalics <rudalics@gmx.at>
916 * window.h (window): Rename slot "nest" to "combination_limit".
917 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
918 (Fset_window_nest): Rename to Fset_window_combination_limit.
919 (Vwindow_nest): Rename to Vwindow_combination_limit.
920 (recombine_windows, make_parent_window, make_window)
921 (Fsplit_window_internal, saved_window)
922 (Fset_window_configuration, save_window_save): Rename all
923 occurrences of window_nest to window_combination_limit.
925 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
927 * image.c (imagemagick_load_image): Fix typo.
929 2011-11-14 Eli Zaretskii <eliz@gnu.org>
931 * xdisp.c (display_line): Move the call to
932 highlight_trailing_whitespace before the call to
933 compute_line_metrics, since the latter needs to see the final
934 faces of all the glyphs to compute ROW's hash value.
935 Fixes assertion violations in row_equal_p. (Bug#10035)
937 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
939 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
940 just return (bug#10044).
942 2011-11-12 Eli Zaretskii <eliz@gnu.org>
944 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
945 with user-defined heap size. Bump the default size of the temacs
946 heap to 27MB, to avoid memory warning when running temacs.
947 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
949 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
950 current_matrix and desired_matrix. (Bug#9990)
951 (verify_row_hash) [XASSERTS]: New function.
952 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
953 that the hash value of glyph rows is correct.
955 2011-11-12 Martin Rudalics <rudalics@gmx.at>
957 * window.h (window): Remove splits slot.
958 * window.c (Fwindow_splits, Fset_window_splits): Remove.
959 (Fdelete_other_windows_internal, make_parent_window)
960 (make_window, Fsplit_window_internal, Fdelete_window_internal)
961 (Fset_window_configuration, save_window_save): Don't deal with
962 split status of windows.
963 (saved_window): Remove splits slot.
964 (Vwindow_splits): Rewrite doc-string.
966 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
968 * xfns.c (unwind_create_frame):
969 * nsfns.m (unwind_create_frame):
970 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
971 Vframe_list (Bug#9999).
973 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
975 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
977 2011-11-11 Kenichi Handa <handa@m17n.org>
979 * callproc.c (Fcall_process): Set the member dst_multibyte of
982 2011-11-11 Johan Bockgård <bojohan@gnu.org>
984 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
985 avoid a crash (bug#9496).
987 2011-11-09 Chong Yidong <cyd@gnu.org>
989 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
990 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
992 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
994 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
996 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
998 Avoid some portability problems by eschewing 'extern inline' functions.
999 The trivial performance wins aren't worth the portability hassles; see
1000 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1002 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1003 (window_box_width, window_box_left, window_box_left_offset)
1004 (window_box_right, window_box_right_offset): Undo previous change,
1005 by removing the "extern"s.
1006 * intervals.c (adjust_intervals_for_insertion)
1007 (adjust_intervals_for_deletion): Undo previous change,
1008 making these static again.
1009 (offset_intervals, temp_set_point_both, temp_set_point)
1010 (copy_intervals_to_string): No longer inline.
1011 * xdisp.c (window_text_bottom_y, window_box_width)
1012 (window_box_height, window_box_left_offset)
1013 (window_box_right_offset, window_box_left, window_box_right)
1014 (window_box): No longer inline.
1016 2011-11-08 Chong Yidong <cyd@gnu.org>
1018 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1019 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1020 Signal an error if not a live window.
1021 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1022 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1024 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1026 * lisp.h (syms_of_abbrev): Remove declaration.
1027 Reported by CHENG Gao <chenggao@royau.me>.
1029 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1031 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1032 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1033 of temacs in GUI mode.
1035 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1037 * window.h: Declare delete_all_child_windows instead of
1038 delete_all_subwindows.
1039 * window.c (Fwindow_nest, Fset_window_nest)
1040 (Fset_window_new_total, Fset_window_new_normal)
1041 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1042 (delete_all_subwindows): Rename to delete_all_child_windows.
1043 (Fdelete_other_windows_internal, Fset_window_configuration):
1044 Call delete_all_child_windows instead of delete_all_subwindows.
1045 * frame.c (delete_frame): Call delete_all_child_windows instead
1046 of delete_all_subwindows.
1048 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1050 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1051 This is also needed for porting to any host where GC_MARK_STACK is
1052 not GC_MAKE_GCPROS_NOOPS.
1053 (which_symbols): Use it.
1055 2011-11-07 Kenichi Handa <handa@m17n.org>
1057 * coding.c (coding_set_destination): Check coding->src_pos only
1058 when coding->src_object is a buffer (bug#9910).
1060 * process.c (send_process): Set the member src_multibyte of coding
1061 to 0 (bug#9911) when sending a unibyte text.
1063 * callproc.c (Fcall_process): Set the member src_multibyte of
1064 process_coding to 0 (bug#9912).
1066 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1068 * xmenu.c (cleanup_widget_value_tree): New function.
1069 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1070 calling free_menubar_widget_value_tree directly (Bug#9830).
1072 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1074 Fix some portability problems with 'inline'.
1075 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1076 (window_box_width, window_box_left, window_box_left_offset)
1077 (window_box_right, window_box_right_offset): Declare extern.
1078 Otherwise, these inline functions do not conform to C99 and
1079 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1080 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1081 * intervals.c (adjust_intervals_for_insertion)
1082 (adjust_intervals_for_deletion): Now extern, because otherwise the
1083 extern inline functions 'offset_intervals' couldn't refer to it.
1084 (static_offset_intervals): Remove.
1085 (offset_intervals): Rewrite using the old contents of
1086 static_offset_intervals. The old version didn't conform to C99
1087 because an extern inline function contained a reference to an
1088 identifier with static linkage.
1090 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1092 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1095 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1097 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1098 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1099 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1100 return Qleft_to_right.
1102 2011-11-06 Chong Yidong <cyd@gnu.org>
1104 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1105 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1106 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1107 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1108 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1109 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1110 (Fwindow_vscroll): Doc fix.
1111 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1112 argument, since it makes no sense to pass a live window and for
1113 consistency with window-child.
1115 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1117 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1120 2011-11-05 Jason Rumney <jasonr@gnu.org>
1122 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1123 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1125 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1126 bitwise arithmetic preventing use of unicode-sip and non-truetype
1129 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1131 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1134 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1135 initialization code to keep similarity to xfns.c after changes
1138 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1140 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1141 (unwind_create_frame): New function (Bug#9943).
1142 (Fx_create_frame): Restructure code to be more similar to the one in
1143 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1144 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1145 Move terminal->reference_count++ just before making the frame official
1148 * nsterm.m (x_free_frame_resources): New function.
1149 (x_destroy_window): Move code to x_free_frame_resources.
1151 * xfns.c (unwind_create_frame): Fix comment.
1152 (Fx_create_frame, x_create_tip_frame):
1153 Move terminal->reference_count++ just before making the frame
1154 official. Move initialization of image_cache_refcount and
1155 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1157 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1159 Support MSVC build with newer versions of Visual Studio.
1160 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1161 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1164 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1165 which are not supported by MSVC.
1166 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1167 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1169 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1171 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1173 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1175 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1177 Support MSVC build with newer versions of Visual Studio.
1178 * w32.c: Don't include w32api.h for MSVC.
1179 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1181 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1182 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1183 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1184 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1186 (alloca) [_MSC_VER]: Define to _alloca.
1188 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1190 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1192 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1194 * xdisp.c (note_mouse_highlight): If either of
1195 previous/next-single-property-change returns nil, treat that as
1196 the beginning or the end of the buffer. (Bug#9955)
1198 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1200 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1201 label is not null (Bug#9951).
1202 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1205 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1207 * window.c (Fwindow_body_size): Mention in the doc string that the
1208 return value is in frame's canonical units. (Bug#9949)
1210 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1212 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1214 * w32fns.c (unwind_create_frame): If needed, free the glyph
1215 matrices of the partially constructed frame. (Bug#9943)
1216 * xfns.c (unwind_create_frame): Likewise.
1218 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1220 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1221 Don't stop backward scan on the continuation glyph, even though
1222 its CHARPOS is positive.
1223 (mouse_face_from_buffer_pos, note_mouse_highlight):
1224 Rename cover_string to disp_string.
1226 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1228 * window.c (temp_output_buffer_show): Don't use
1229 Vtemp_buffer_show_specifiers.
1230 (Vtemp_buffer_show_specifiers): Remove unused variable.
1232 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1234 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1235 past the beginning of the current glyph matrix.
1237 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1239 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1240 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1241 HAVE_GTK3 (Bug#9869).
1243 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1244 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1246 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1248 * xterm.c: Declare x_handle_net_wm_state to return int.
1249 (handle_one_xevent): Check if we are iconified but don't have
1250 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1251 (get_current_wm_state): Return non-zero if not hidden,
1252 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1253 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1254 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1255 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1257 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1259 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1260 so that this new function doesn't get optimized away by a
1261 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1263 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1265 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1267 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1269 Fix the `xbytecode' command.
1270 * .gdbinit (xprintbytestr): New command.
1271 (xwhichsymbols): Rename from `which'; all callers changed.
1272 (xbytecode): Print the byte-code string as well.
1274 2011-10-29 Kim Storm <storm@cua.dk>
1276 * alloc.c (which_symbols): New function.
1278 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1280 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1283 2011-10-29 Glenn Morris <rgm@gnu.org>
1285 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1286 Not clear what it was for, and it causes various bugs. (Bug#9839)
1288 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1290 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1291 possible random value that matches one of those tested as
1292 condition to clear the mouse face.
1294 2011-10-28 Chong Yidong <cyd@gnu.org>
1296 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1298 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1300 * window.c (make_window): Initialize phys_cursor_on_p.
1302 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1304 * lisp.h (struct Lisp_Symbol): Update comments.
1306 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1308 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1310 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1312 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1313 <oslsachem@gmail.com> for helping to debug this.
1315 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1316 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1317 (g_b_init_get_glyph_outline_w): New static variables.
1318 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1319 (GetGlyphOutlineW_Proc): New typedefs.
1320 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1321 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1323 (w32font_open_internal, compute_metrics):
1324 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1325 instead of calling the "wide" APIs directly.
1327 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1329 * w32.h (syms_of_w32font): Add prototype.
1331 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1333 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1334 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1335 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1336 (Fmove_to_window_line): Doc fix.
1338 2011-10-27 Chong Yidong <cyd@gnu.org>
1340 * process.c (make_process): Set gnutls_state to NULL.
1342 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1343 non-NULL, regardless of GNUTLS_INITSTAGE.
1344 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1345 an error. Set process slots as soon as we allocate them.
1347 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1349 2011-10-27 Chong Yidong <cyd@gnu.org>
1351 * gnutls.c (emacs_gnutls_deinit): New function.
1352 Deallocate credentials structures as well as calling gnutls_deinit.
1353 (Fgnutls_deinit, Fgnutls_boot): Use it.
1355 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1356 (deactivate_process): Call emacs_gnutls_deinit.
1358 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1360 * image.c (x_create_x_image_and_pixmap):
1361 * w32.c (sys_rename, w32_delayed_load):
1362 * w32font.c (fill_in_logfont):
1363 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1365 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1367 * w32fns.c (w32_default_color_map): New function,
1368 extracted from Fw32_default_color_map.
1369 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1371 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1373 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1375 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1377 * keyboard.c (test_undefined): New function (bug#9751).
1378 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1380 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1382 * sysdep.c (init_sys_modes): Fix the check for the controlling
1383 terminal (Bug#6649).
1385 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1387 * dispextern.h (struct bidi_it): New member next_en_type.
1389 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1390 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1391 current character, check also for next_en_type being WEAK_EN.
1392 (bidi_resolve_weak): Don't enter the expensive loop if the current
1393 position is before next_en_pos. Record the bidi type of the first
1394 non-ET, non-BN character we find, in addition to its position.
1395 (bidi_level_of_next_char): Invalidate next_en_type when
1396 next_en_pos is over-stepped.
1398 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1400 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1401 * editfns.c: Rewrite current-time-zone so that it invokes
1402 the equivalent of (format-time-string "%Z") to get the time zone name.
1403 This fixes a bug when the time zone name contains characters that
1404 need converting from the system time locale to Emacs internal format.
1405 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1406 that patch fixed format-time-string to do the conversion, but
1407 I forgot to fix current-time-zone.
1408 (format_time_string): New function, containing most of
1409 what Fformat_time_string used to contain.
1410 (Fformat_time_string): Rewrite in terms of format_time_string.
1411 This doesn't change this function's behavior.
1412 (current-time-zone): Rewrite to use format_time_string.
1413 This fixes the bug reported by Michael Schierl in
1414 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1415 Jason Rumney's 2007-06-07 change worked around this bug, but
1417 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1419 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1421 * xdisp.c (start_display): If the character at POS is displayed
1422 via a display vector, reset IT->current.dpvec_index to zero.
1423 (try_window_reusing_current_matrix): If a line ends in a display
1424 vector or the next line starts in a display vector, continue
1425 redrawing the window even though the character position of
1426 start_row was reached.
1429 2011-10-18 Chong Yidong <cyd@gnu.org>
1431 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1432 with nobreak-char-display too.
1434 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1436 Fix part 3 of bug#9771.
1437 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1438 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1439 non-neutral characters if the current character is a paragraph
1440 separator (a.k.a. Newline). This avoids running the same
1441 expensive loop twice, once when we consume the preceding newline
1442 and the other time when the line actually needs to be displayed.
1443 Avoid the loop when we see neutrals on the base embedding level
1444 following a character whose directionality is the same as the
1445 paragraph's. This avoids running the expensive loop when a line
1446 ends in a long sequence of neutrals, like control characters.
1447 Add assertion against STRONG_AL type. Slightly rearrange code
1448 that determines the type of a neutral given the first non-neutral
1450 (bidi_level_of_next_char): Set next_en_pos to zero when
1451 invalidating its info.
1453 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1455 * xdisp.c (push_display_prop): Determine whether to record string
1456 or buffer position by IT->string, not by IT->method. Allow
1457 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1458 (move_it_vertically_backward): Don't look for character position
1459 immediately after the newline when in a continuation line.
1462 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1464 * window.c (coordinates_in_window): Rewrite and delabelize
1465 vertical border check. (Bug#5357) (Bug#9618)
1467 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1469 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1470 errors in XSetWindowBorder (bug#9310).
1472 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1474 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1475 avoid crash when xmalloc overrun checking is enabled.
1477 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1479 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1480 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1481 cursor motion with <left> and <right> arrow keys.
1483 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1484 some callers set that themselves.
1486 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1488 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1489 display string and the previous row comes from the same string and
1490 is empty. (Bug#9739) (Bug#9738)
1492 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1494 * doc.c (get_doc_string): Encode file name (bug#9735).
1496 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1498 * bidi.c (bidi_level_of_next_char):
1499 * xdisp.c (get_visually_first_element): Remove old incorrect
1500 comments regarding the Unicode Line Separator character.
1502 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1504 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1506 * alloc.c (Fgc_status): Do not access beyond zombies array
1507 boundary if nzombies > MAX_ZOMBIES.
1508 * alloc.c (dump_zombies): Add missing format specifier.
1510 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1512 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1513 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1515 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1516 Some packages use them to denote characters with modifiers.
1518 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1520 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1521 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1522 matching a pp-number. Rename parameter var to var1.
1524 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1526 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1528 2011-10-08 Glenn Morris <rgm@gnu.org>
1530 * callint.c (Fcall_interactively): Give a more explicit error for the
1531 'c' case with a non-character input. (Bug#8479)
1533 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1535 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1537 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1538 lines that are hscrolled on the left.
1540 * dispnew.c (buffer_posn_from_coords): Account for a possible
1541 presence of header-line. (Bug#4426)
1543 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1545 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1546 Don't advertise functionality which we discourage or doesn't work.
1548 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1550 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1551 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1552 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1553 this makes Emacs dump core during garbage collection on rare
1554 occasions. sizeof is obviously inferior to offsetof here, so
1555 stick with offsetof.
1556 (GC_POINTER_ALIGNMENT): New macro.
1557 (mark_memory): Omit 3rd (offset) arg; caller changed.
1558 Don't assume EMACS_INT alignment is the same as pointer alignment.
1560 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1562 * keyboard.c (read_key_sequence_remapped): New var.
1563 (read_key_sequence): Compute remapping in the right buffer.
1564 (command_loop_1): Use read_key_sequence's remapping directly.
1566 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1568 * dired.c (file_name_completion): Don't expand file name.
1569 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1570 before checking file name handler.
1572 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1573 they've been requested explicitly (bug#9591).
1575 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1577 * keymap.c (Fsingle_key_description): Use make_specified_string
1578 instead of build_string to build string from push_key_description.
1581 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1583 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1584 This fixes a Y2038 bug on 64-bit hosts.
1585 * buffer.c (reset_buffer):
1586 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1587 (Fclear_buffer_auto_save_failure):
1588 Use 0, not -1, to represent an unset failure time, since time_t
1589 might not be signed.
1591 Remove dependency on glibc malloc internals.
1592 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1593 Move back here from lisp.h, but with their new implementations.
1594 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1595 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1596 * charset.c (charset_table_init): New static var.
1597 (syms_of_charset): Use it instead of xmalloc. This removes a
1598 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1599 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1600 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1601 Move back to alloc.c.
1602 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1603 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1605 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1607 * nsterm.m (windowDidResize): Call x_set_window_size only when
1608 ns_in_resize is true. Otherwise set pixelwidth/height and
1609 call change_frame_size (Bug#9628).
1611 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1613 Port --enable-checking=all to Fedora 14 x86-64.
1614 * charset.c (syms_of_charset): Also account for glibc malloc's
1615 internal overhead when calculating the initial malloc maximum.
1617 Port --enable-checking=all to Fedora 14 x86.
1618 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1620 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1621 (overrun_check_realloc, overrun_check_free):
1622 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1623 That way, xmalloc returns a properly-aligned pointer even if
1624 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1625 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1626 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1627 into account when calculating the initial malloc maximum.
1628 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1629 Move here from alloc.c, so that charset.c can use it too.
1630 Properly align; the old code wasn't right for common 32-bit hosts
1631 when configured with --enable-checking=all.
1632 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1633 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1635 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1637 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1640 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1642 * xdisp.c (compute_display_string_end): If there's no display
1643 string at CHARPOS, return -1.
1645 * bidi.c (bidi_fetch_char): When compute_display_string_end
1646 returns a negative value, treat the character as a normal
1647 character not covered by a display string. (Bug#9624)
1649 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1651 * lread.c (Fread_from_string): Fix typo in docstring.
1653 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1655 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1656 newline, reseat the iterator instead of bidi-iterating there one
1657 character at a time. (Bug#9610)
1658 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1659 TO_CHARPOS if the bidi iterator is at base embedding level.
1661 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1663 * lread.c (readevalloop): Use correct code for NBSP.
1664 (read1): Likewise. (Bug#9608)
1666 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1668 * dbusbind.c (Fdbus_register_signal): When service is not
1669 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1671 2011-09-25 Glenn Morris <rgm@gnu.org>
1673 * buffer.c (truncate-lines): Doc fix.
1675 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1677 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1678 (Fset_window_next_buffers): Doc fix.
1680 2011-09-24 Glenn Morris <rgm@gnu.org>
1682 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1684 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1686 Fix minor problems found by static checking.
1687 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1688 * indent.c (Fvertical_motion): Fix == vs = typo.
1690 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1692 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1693 Default value is now t. Doc fix.
1695 * indent.c (Fvertical_motion): Compute and apply the overshoot
1696 logic when moving up, not only when moving down. Fix the
1697 confusing name and values of the it_overshoot_expected variable;
1698 logic changes accordingly. (Bug#9254) (Bug#9549)
1700 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1701 CHARPOS is covered by a display string which includes newlines.
1702 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1703 is covered by a display string with embedded newlines.
1705 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1707 * dbusbind.c (Fdbus_register_signal): Add match rule to
1708 Vdbus_registered_objects_table. (Bug#9581)
1709 (Fdbus_register_method, Vdbus_registered_objects_table):
1712 2011-09-24 Jim Meyering <meyering@redhat.com>
1714 do not ignore write error for any output size
1715 The previous change was incomplete.
1716 While it makes emacs --batch detect the vast majority of stdout
1717 write failures, errors were still ignored whenever the output size is
1718 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1719 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1720 && echo FAIL: ignored write error
1721 FAIL: ignored write error
1722 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1723 && echo FAIL: ignored write error
1724 FAIL: ignored write error
1725 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1727 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1729 * emacs.c (Fkill_emacs): In noninteractive mode exit
1730 non-successfully if a write error occurred on stdout. (Bug#9574)
1732 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1734 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1737 * dispextern.h (struct it): Update the comment documenting what
1740 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1742 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1743 a display string, extend search for cursor position to end of row.
1744 (find_row_edges): If the row ends in a newline from a display
1745 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1746 Handle the case of a display string with multiple newlines.
1747 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1748 non-empty line. Fixes confusing cursor motion with arrow keys at
1749 the beginning of a line that starts with whitespace.
1751 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1753 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1756 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1758 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1761 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1763 * xdisp.c (display_line): Record maximum and minimum buffer
1764 positions even if no glyphs were produced (e.g., by a zero-width
1765 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1766 buffer positions that will be removed from the glyph row because
1768 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1769 column is beyond frame width: don't subtract 1 "pixel" when
1770 computing width of the stretch.
1771 (reseat_at_next_visible_line_start): Undo the change made on
1772 2011-09-17 that saved paragraph information and restored it after
1773 the call to `reseat'. (Bug#9545)
1775 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1777 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1778 and turn window cursor on if cleared (Bug#9415).
1780 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1782 * search.c (boyer_moore): Take unibyte characters from pattern
1783 literally. (Bug#9458)
1785 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1787 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1789 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1791 Fix minor problem found by static checking.
1792 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1793 initialized, to pacify gcc -Wuninitialized.
1795 * fileio.c: Report proper errno when syscall falls.
1796 (Finsert_file_contents): Save and restore errno,
1797 so that report_file_error outputs the correct diagnostic.
1798 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1800 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1802 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1804 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1806 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1807 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1809 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1811 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1812 about the current paragraph and restore it after the call to reseat.
1814 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1815 (bidi_find_paragraph_start): Search back for paragraph beginning
1816 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1817 (bidi_move_to_visually_next): Only trigger paragraph-related
1818 computations when the last character is a newline or at EOB, not
1819 just any NEUTRAL_B. (Bug#9470)
1821 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1822 truncated lines if point is covered by a display string. (Bug#9524)
1824 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1826 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1827 (cons_to_x_long): New function.
1828 (lisp_data_to_selection_data): Use it. Correct the test for
1829 short-versus-long data; it was negated. Break out of vector
1830 loop, for efficiency, when a long datum is discovered.
1832 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1834 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1836 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1838 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1839 GCC PR/17406) by declaring this function with external scope.
1841 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1843 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1844 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1846 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1848 * editfns.c (Fformat): Correctly handle text properties on "%%".
1850 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1852 * xterm.c (x_draw_composite_glyph_string_foreground):
1853 * w32term.c (x_draw_composite_glyph_string_foreground):
1854 * term.c (encode_terminal_code):
1855 * composite.c (composition_update_it, get_composition_id):
1856 * xdisp.c (get_next_display_element)
1857 (fill_composite_glyph_string): Add comments about special meaning
1858 of TAB characters in a composition.
1860 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1862 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1863 This occurs when processing a multibyte format.
1864 Problem reported by Wolfgang Jenker.
1866 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1868 * xdisp.c (try_cursor_movement): Only check for exact match if
1869 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1871 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1873 Remove unused external symbols.
1874 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1875 * xdisp.c (calc_pixel_width_or_height): Now static.
1876 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1877 * indent.c (check_display_width):
1878 * w32term.c: Fix comment to match code.
1879 * xterm.c, xterm.h (x_catching_errors): Remove.
1881 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1883 * xselect.c: Use signed conversions more consistently (Bug#9498).
1884 (selection_data_to_lisp_data): Assume incoming selection data are
1885 signed integers, not unsigned. This is to be consistent with
1886 outgoing selection data, which was modified to use signed integers
1887 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1888 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1889 expects long, not unsigned long.
1891 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1893 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1894 computation of loop end. Reported by Johan Bockgård
1897 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1899 * frame.c (Fother_visible_frames_p): Function deleted.
1901 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1903 * indent.c (compute_motion): Process display vector front to back
1904 rather than the other way around. (Bug#2496)
1906 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1908 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1910 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1912 * minibuf.c (Fread_from_minibuffer): Doc fix.
1914 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1916 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1917 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1919 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1921 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1922 value for non-existent files.
1924 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1926 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1927 set its "size" to -1. This will set the modtime_size field of
1928 the corresponding buffer to -1, which is what
1929 verify-visited-file-modtime expects for files that do not exist.
1932 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1934 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1936 * lisp.h: ... from here. push_key_description is no longer
1937 defined in keyboard.c, so its declaration should not be in
1938 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1939 logically belongs with push_key_description.
1941 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1943 * buffer.h: Include <sys/types.h> instead of <time.h>.
1944 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1945 Problem reported by Herbert J. Skuhra.
1947 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1949 * xml.c (parse_region): Make the parsing work for
1950 non-comment-starting XML files again (bug#9144).
1952 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1954 * image.c (gif_load): Fix calculation of bottom and right corner.
1957 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1959 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1960 redisplay in small windows.
1962 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1964 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1966 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1968 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1969 Operate on live windows only.
1971 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1973 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1975 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1977 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1978 only under bidi iteration.
1980 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1982 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1984 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1986 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1987 Without this fix, the command to link temacs failed due to an
1988 undefined symbol __builtin_isnan. This is because
1989 /usr/include/iso/math_c99.h #defines isnan(x) to
1990 __builtin_isnan(x), but the bundled gcc, which identifies itself
1991 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1993 * floatfns.c (isnan): #undef, and then #define to a clone of
1995 (Fisnan): Always define, since it's always available now.
1996 (syms_of_floatfns): Always define isnan at the Lisp level.
1998 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2000 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2002 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2004 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2005 The previous code assumed that file offsets (off_t values) fit in
2006 EMACS_INT variables, which is not true on typical 32-bit hosts.
2007 The code messed up by falsely reporting buffer overflow in cases
2008 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2009 when "big" contains more than 2**29 bytes, even though this
2010 inserts just one byte and does not overflow the buffer.
2011 (Finsert_file_contents): Store file offsets as off_t
2012 values, not as EMACS_INT values. Check for overflow when
2013 converting between EMACS_INT and off_t. When checking for
2014 buffer overflow or for overlap, take the offsets into account.
2015 Don't use EMACS_INT for small values where int suffices.
2016 When checking for overlap, fix a typo: ZV was used where
2017 ZV_BYTE was intended.
2018 (Fwrite_region): Don't assume off_t fits into 'long'.
2019 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2021 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2023 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2025 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2027 sprintf-related integer and memory overflow issues (Bug#9412).
2029 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2030 (esprintf, exprintf, evxprintf): New functions.
2031 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2032 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2033 (modify_event_symbol): Do not assume that the length of
2034 name_alist_or_stem is safe to alloca and fits in int.
2035 (Fexecute_extended_command): Likewise for function name and binding.
2036 (Frecursion_depth): Wrap around reliably on integer overflow.
2037 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2038 since some callers pass EMACS_INT values.
2039 (Fsingle_key_description): Don't crash if symbol name contains more
2040 than MAX_ALLOCA bytes.
2041 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2042 (get_minibuffer): Arg is now EMACS_INT, not int.
2043 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2044 (esprintf, exprintf, evxprintf): New decls.
2045 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2047 * dbusbind.c (signature_cat): New function.
2048 (xd_signature, Fdbus_register_signal):
2049 Do not overrun buffer; instead, report string overflow.
2051 * dispnew.c (add_window_display_history): Don't overrun buffer.
2052 Truncate instead; this is OK since it's just a log.
2054 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2055 even if the time zone offset is outlandishly large.
2056 Don't mishandle offset == INT_MIN.
2058 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2059 when creating daemon; the previous buffer-overflow check was incorrect.
2061 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2062 which has the guts of the old verror function.
2064 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2065 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2067 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2068 (font_unparse_xlfd): Don't blindly alloca long strings.
2069 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2070 fits in int, when using sprintf. Use single snprintf to count
2071 length of string rather than counting it via multiple sprintfs;
2072 that's simpler and more reliable.
2073 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2074 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2075 sprintf, in case result does not fit in int.
2077 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2078 (fontset_from_font): Print it.
2080 * frame.c (tty_frame_count): Now printmax_t, not int.
2081 (make_terminal_frame, set_term_frame_name): Print it.
2082 (x_report_frame_params): In X, window IDs are unsigned long,
2083 not signed long, so print them as unsigned.
2084 (validate_x_resource_name): Check for implausibly long names,
2085 and don't assume name length fits in 'int'.
2086 (x_get_resource_string): Don't blindly alloca invocation name;
2087 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2090 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2091 (xg_check_special_colors, xg_set_geometry):
2092 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2094 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2095 Use esprintf, not sprintf, in case result does not fit in int.
2097 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2098 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2099 it as a large positive number.
2100 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2101 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2103 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2104 in case result does not fit in int.
2106 * print.c (float_to_string): Detect width overflow more reliably.
2107 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2108 buffer overrun. Don't assume list length fits in 'int'. Treat
2109 print length of 0 as 0, not as infinity; to be consistent with other
2110 uses of print length in this function. Don't overflow print length
2111 index. Don't assume hash table size fits in 'long', or that
2112 vectorlike size fits in 'unsigned long'.
2114 * process.c (make_process): Use printmax_t, not int, to format
2115 process-name gensyms.
2117 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2119 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2120 to avoid potential buffer overrun.
2122 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2123 if X resource line is longer than 512 bytes.
2125 * xfns.c (x_window): Make sprintf buffer a bit bigger
2126 to avoid potential buffer overrun.
2128 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2130 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2132 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2134 Integer overflow fixes for scrolling, etc.
2135 Without these, Emacs silently mishandles large integers sometimes.
2136 For example, "C-u 4294967297 M-x recenter" was treated as if
2137 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2139 * xdisp.c (try_window_id): Check Emacs fixnum range before
2140 converting to 'int'.
2142 * window.c (window_scroll_line_based, Frecenter):
2143 Check that an Emacs fixnum is in range before assigning it to 'int'.
2144 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2145 values converted from Emacs fixnums.
2146 (Frecenter): Don't wrap around a line count if it is out of 'int'
2147 range; instead, treat it as an extreme value.
2148 (Fset_window_configuration, compare_window_configurations):
2149 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2151 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2152 that can exceed INT_MAX. Check that EMACS_INT value is in range
2153 before assigning it to the (possibly-narrower) index.
2154 (match_limit): Don't assume that a fixnum can fit in 'int'.
2156 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2159 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2160 (Fvertical_motion): Don't wrap around LINES values that don't fit
2161 in 'int'. Instead, treat them as extreme values. This is good
2162 enough for windows, which can't have more than INT_MAX lines anyway.
2164 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2166 * Require libxml/parser.h to avoid compilation warning.
2168 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2170 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2171 since this reportedly can destroy thread storage.
2173 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2175 * syntax.c (find_defun_start): Update all cache variables if
2176 exiting early (Bug#9401).
2178 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2180 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2182 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2183 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2184 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2186 * term.c (tty_append_glyph): New function.
2187 (produce_stretch_glyph): Static function and its prototype deleted.
2189 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2192 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2194 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2195 when checking :margin (Bug#9390).
2196 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2197 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2198 so that the name doesn't mislead. All uses changed.
2200 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2202 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2205 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2207 * xdisp.c (move_it_to): Don't bail out early when reaching
2208 position beyond to_charpos, if we are scanning backwards.
2209 (move_it_vertically_backward): When DY == 0, make sure we get to
2210 the first character in the line after the newline.
2212 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2214 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2215 (ccl_driver): Do not generate an out-of-range pointer.
2216 (Fccl_execute_on_string): Remove unnecessary check for
2217 integer overflow, noted by Stefan Monnier in
2218 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2219 Remove a FIXME that didn't need fixing.
2220 Simplify the newly-introduced buffer reallocation code.
2222 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2224 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2226 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2228 Integer and memory overflow issues (Bug#9196).
2230 * doc.c (get_doc_string): Rework so that
2231 get_doc_string_buffer_size is the actual buffer size, rather than
2232 being 1 less than the actual buffer size; this makes xpalloc more
2235 * image.c (x_allocate_bitmap_record, cache_image):
2236 * xselect.c (Fx_register_dnd_atom):
2237 Simplify previous changes by using xpalloc.
2239 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2240 since either will do and ptrdiff_t is convenient with xpalloc.
2242 * charset.c (charset_table_size)
2243 (struct charset_sort_data.priority): Now ptrdiff_t.
2244 (charset_compare): Don't overflow if priorities differ greatly.
2245 (Fsort_charsets): Don't assume list length fits in int.
2246 Check for size-calculation overflow when allocating sort data.
2247 (syms_of_charset): Allocate an initial charset table that is
2248 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2250 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2252 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2253 The actual value is always <= INT_MAX, and leaving it unsigned made
2254 overflow checking harder.
2256 * dispextern.h (struct glyph_matrix.rows_allocated)
2257 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2258 with xpalloc. The values are still always <= INT_MAX.
2260 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2262 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2263 (SAFE_NALLOCA): New macro.
2265 * region-cache.c (struct boundary.pos, find_cache_boundary)
2266 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2267 (set_cache_region, invalidate_region_cache)
2268 (revalidate_region_cache, know_region_cache, region_cache_forward)
2269 (region_cache_backward, pp_cache):
2270 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2271 so that ptrdiff_t * can be passed to xpalloc.
2272 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2273 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2274 (pp_cache): Don't assume cache_len fits in int.
2275 * region-cache.h: Adjust extern decls to match.
2277 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2278 EMACS_INT, since either will do, for xpalloc.
2280 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2281 (xnmalloc, xnrealloc, xpalloc): New functions.
2283 * bidi.c (bidi_shelve_header_size): New constant.
2284 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2285 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2287 * bidi.c (bidi_cache_shrink):
2288 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2290 Don't update size of array until after memory allocation succeeds,
2291 because xmalloc/xrealloc may not return.
2292 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2293 now that we have proper integer overflow checking.
2294 (record_overlay_string, overlay_strings): Catch overflows when
2295 calculating size of overlay_str_buf.
2297 * callproc.c (Fcall_process): Check for size overflow when
2298 calculating size of args2.
2299 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2300 Normally we prefer signed values, but sticking with ptrdiff_t would
2301 require adding more-complicated checks.
2303 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2304 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2305 Redo buffer-overflow calculations to avoid integer overflow.
2306 Add a FIXME comment where memory seems to be over-allocated.
2308 * character.c (Fstring): Check for size-calculation overflow.
2310 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2311 unnecessary integer overflow. Check for size overflow.
2312 (encode_coding_object): Don't update size until xmalloc succeeds.
2314 * composite.c (get_composition_id): Check for overflow in glyph
2315 length calculations.
2317 Integer and memory overflow fixes for display code.
2318 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2319 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2320 (scrolling_window): Check for overflow in size calculations.
2321 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2322 Don't assume glyph table len fits in int.
2323 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2324 (row_table_size): Now ptrdiff_t, not int.
2325 (scrolling_window): Avoid overflow in size calculations.
2326 Don't update size until allocation succeeds.
2327 * fns.c (concat): Check for overflow in size calculations.
2328 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2329 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2330 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2332 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2333 (get_doc_string): Check for size calculation overflow.
2334 Don't update size until allocation succeeds.
2335 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2336 EMACS_INT, where ptrdiff_t will do.
2337 (Fsubstitute_command_keys): Check for string overflow.
2339 * editfns.c (set_time_zone_rule): Don't assume environment length
2341 (message_length): Now ptrdiff_t, not int.
2342 (Fmessage_box): Don't update size until allocation succeeds.
2343 Don't assume message length fits in int.
2344 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2346 * emacs.c (main): Do not reallocate argv, since there is a null at
2347 the end that can be overwritten, and this way there's no need to
2348 worry about size-calculation overflow.
2349 (sort_args): Check for size-calculation overflow.
2351 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2353 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2355 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2356 (x_set_scroll_bar_width, x_figure_window_size):
2357 Check for integer overflow.
2358 (x_set_alpha): Do not assume XINT fits in int.
2360 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2361 This is for the members text_lines, text_cols, total_lines, total_cols,
2362 where the system imposes an 'int' limit.
2364 * fringe.c (Fdefine_fringe_bitmap):
2365 Don't update size until alloc works.
2367 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2368 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2370 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2371 Check for size-calculation overflow.
2372 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2373 do, as we prefer signed integers.
2374 (id_to_widget.max_size, id_to_widget.used)
2375 (xg_store_widget_in_map, xg_remove_widget_from_map)
2376 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2377 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2378 Use and return ptrdiff_t, not int.
2379 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2380 * gtkutil.h: Change prototypes to match the above.
2382 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2383 are duplicate now that they've been promoted to lisp.h.
2384 (x_allocate_bitmap_record, x_alloc_image_color)
2385 (make_image_cache, cache_image, xpm_load):
2386 Don't update size until alloc is done.
2387 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2389 Check for size calculation overflow.
2390 (ct_colors_allocated_max): New constant.
2391 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2394 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2395 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2396 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2397 Use ptrdiff_t, not int, to count maps.
2398 (read_char_minibuf_menu_prompt): Check for overflow in size
2399 calculations. Don't update size until allocation succeeds.
2400 Redo calculations to avoid overflow.
2401 * keyboard.h: Change prototypes to match the above.
2403 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2405 (current_minor_maps): Check for size calculation overflow.
2406 * keymap.h: Change prototypes to match the above.
2408 * lread.c (read1, init_obarray): Don't update size until alloc done.
2410 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2411 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2413 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2414 Now ptrdiff_t, not int.
2415 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2416 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2418 * process.c (Fnetwork_interface_list): Check for overflow
2419 in size calculation.
2421 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2423 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2424 overflow. Don't bother calling xmalloc when xrealloc will do.
2426 * search.c (Freplace_match): Check for size calculation overflow.
2427 (Fset_match_data): Don't assume list lengths fit in 'int'.
2429 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2430 for command line length. Do not attempt to address one before the
2431 beginning of an array, as that's not portable.
2433 * term.c (max_frame_lines): Remove; unused.
2434 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2436 (encode_terminal_code, calculate_costs): Check for size
2437 calculation overflow.
2438 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2439 table lengths and related sizes. Don't update size until alloc
2440 done. Redo calculations to avoid overflow.
2441 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2443 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2444 subtracting pointers.
2445 (gobble_line): Check for overflow more carefully. Don't update size
2448 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2449 Don't update size until alloc done.
2450 Redo size calculations to avoid overflow.
2451 Check for size calculation overflow.
2452 (main) [DEBUG]: Fix typo in invoking tparam1.
2454 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2455 Use ptrdiff_t, not int, for sizes.
2456 (store_mode_line_noprop_char): Don't update size until alloc done.
2458 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2459 Use ptrdiff_t, not int, for sizes.
2460 (Finternal_make_lisp_face, cache_face):
2461 Check for size calculation overflow.
2462 (cache_face): Treat size calculation overflows as if they were
2463 memory exhaustion (the usual treatment), rather than aborting.
2465 * xfns.c (x_encode_text, x_set_name_internal)
2466 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2467 sizes, since they can exceed INT_MAX in size. Check for size
2468 calculation overflow.
2470 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2471 (xg_select): Check for size calculation overflow.
2472 Don't update size until alloc done.
2474 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2475 as sprintf is limited to int lengths.
2477 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2478 (X_LONG_MIN): New macros.
2479 Use them to make the following changes clearer.
2480 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2481 This change doesn't affect the value now, but it may help remind
2482 future maintainers not to raise the value too much later.
2483 (SELECTION_QUANTUM): Remove, replacing with ...
2484 (selection_quantum): ... new function, which avoids overflow.
2486 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2487 assumption that selection length fits in 'int'.
2488 (x_reply_selection_request, x_handle_selection_request)
2489 (x_get_window_property, receive_incremental_selection)
2490 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2491 (lisp_data_to_selection_data, clean_local_selection_data):
2492 Use ptrdiff_t, not int, to record length of selection.
2493 (x_reply_selection_request, x_get_window_property)
2494 (receive_incremental_selection, x_property_data_to_lisp):
2495 Redo calculations to avoid overflow.
2496 (x_reply_selection_request): When sending hint, ceiling it at
2497 X_LONG_MAX rather than relying on wraparound overflow to send
2499 (x_get_window_property, receive_incremental_selection)
2500 (lisp_data_to_selection_data, x_property_data_to_lisp):
2501 Check for size-calculation overflow.
2502 (x_get_window_property, receive_incremental_selection)
2503 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2504 Don't store size until memory allocation succeeds.
2505 (x_get_window_property): Plug memory leak on memory exhaustion.
2506 Don't double-block input; malloc is safe here. Don't assume 2**34
2507 - 4 fits in unsigned long. Add an xassert to check
2508 XGetWindowProperty overflow. Be more careful about overflow
2509 calculations, and distinguish size from memory overflow better.
2510 (receive_incremental_selection): When tracing, don't assume
2511 unsigned int is less than INT_MAX.
2512 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2513 harmful) conversions of unsigned short to int.
2514 (lisp_data_to_selection_data): Don't assume that integers
2515 in the range -65535 through -1 fit in an X unsigned short.
2516 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2517 result parameters unless successful. Rely on cons_to_unsigned
2518 to report problems with elements; the old code wasn't right anyway.
2519 (x_check_property_data): Check for int overflow; we cannot use
2520 a wider type due to X limits.
2521 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2523 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2525 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2526 (x_term_init): Check for size calculation overflow.
2527 (x_color_cells): Don't store size until memory allocation succeeds.
2528 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2529 Don't assume alloca size is less than MAX_ALLOCA.
2530 (x_term_init): Don't assume length fits in int (sprintf is limited
2533 Use ptrdiff_t for composition IDs.
2534 * character.c (lisp_string_width):
2535 * composite.c (composition_table_size, n_compositions)
2536 (get_composition_id, composition_gstring_from_id):
2537 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2538 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2539 * window.c (Frecenter):
2540 Use ptrdiff_t, not int, for composition IDs.
2541 * composite.c (get_composition_id): Check for integer overflow.
2542 * composite.h: Adjust prototypes to match the above changes.
2544 Use ptrdiff_t for hash table indexes.
2545 * category.c (hash_get_category_set):
2546 * ccl.c (ccl_driver):
2547 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2548 * coding.c (coding_system_charset_list, detect_coding_system):
2549 * coding.h (struct coding_system.id):
2550 * composite.c (get_composition_id, gstring_lookup_cache):
2551 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2552 * image.c (xpm_get_color_table_h):
2553 * lisp.h (hash_lookup, hash_put):
2554 * minibuf.c (Ftest_completion):
2555 Use ptrdiff_t for hash table indexes, not int (which is too
2556 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2557 32-bit --with-wide-int hosts).
2559 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2560 Add a FIXME comment about memory leaks.
2561 (syms_of_charset): Don't assume xmalloc returns.
2563 Don't assume that stated character widths fit in int.
2564 * character.c (Fchar_width, c_string_width, lisp_string_width):
2565 * character.h (CHAR_WIDTH):
2566 * indent.c (MULTIBYTE_BYTES_WIDTH):
2567 Use sanitize_char_width to avoid undefined and/or bad behavior
2568 with outlandish widths.
2569 * character.h (sanitize_tab_width): Rename from sanitize_width,
2570 now that we have two such functions. All uses changed.
2571 (sanitize_char_width): New inline function.
2573 Don't assume that tab-width fits in int.
2574 * character.h (sanitize_width): New inline function.
2575 (SANE_TAB_WIDTH): New macro.
2576 (ASCII_CHAR_WIDTH): Use it.
2577 * indent.c (sane_tab_width): Remove. All uses replaced by
2578 SANE_TAB_WIDTH (current_buffer).
2579 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2581 * fileio.c: Integer overflow issues with file modes.
2582 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2584 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2585 Remove unreachable code.
2586 (read_hex, load_charset_map_from_file): Check for integer overflow.
2588 * xterm.c: Don't go over XClientMessageEvent limit.
2589 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2590 (x_send_scroll_bar_event): Likewise. Check that the size does not
2591 exceed limits imposed by XClientMessageEvent, as well as the usual
2592 ptrdiff_t and size_t limits.
2594 * keyboard.c: Overflow, signedness and related fixes.
2595 (make_lispy_movement): Use same integer type in forward decl
2596 that is used in the definition.
2597 (read_key_sequence, keyremap_step):
2598 Change bufsize argument back to int, undoing my 2011-03-30 change.
2599 We prefer signed types, and int is wide enough here.
2600 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2601 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2602 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2603 length, not size_t. Use ptrdiff_t for index, not int.
2604 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2605 possibility of integer overflow.
2607 Overflow, signedness and related fixes for images.
2609 * dispextern.h (struct it.stack[0].u.image.image_id)
2610 (struct_it.image_id, struct image.id, struct image_cache.size)
2611 (struct image_cache.used, struct image_cache.ref_count):
2612 * gtkutil.c (update_frame_tool_bar):
2613 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2614 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2615 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2616 * nsmenu.m (update_frame_tool_bar):
2617 * xdisp.c (calc_pixel_width_or_height):
2618 * xfns.c (image_cache_refcount):
2619 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2620 on typical 64-bit hosts.
2622 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2623 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2624 Omit unnecessary casts to int.
2625 (parse_image_spec): Check that integers fall into 'int' range
2626 when the callers expect that.
2627 (image_ascent): Redo ascent calculation to avoid int overflow.
2628 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2629 (lookup_image): Remove unnecessary tests.
2630 (xbm_image_p): Locals are now of int, not EMACS_INT,
2631 since parse_image_check makes sure they fit into int.
2632 (png_load, gif_load, svg_load_image):
2633 Prefer int to unsigned where either will do.
2634 (tiff_handler): New function, combining the cores of the
2635 old tiff_error_handler and tiff_warning_handler.
2636 This function is rewritten to use vsnprintf and thereby avoid
2637 stack buffer overflows. It uses only the features of vsnprintf
2638 that are common to both POSIX and native Microsoft.
2639 (tiff_error_handler, tiff_warning_handler): Use it.
2640 (tiff_load, gif_load, imagemagick_load_image):
2641 Don't assume :index value fits in 'int'.
2642 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2643 (imagemagick_load_image): Check that crop parameters fit into
2644 the integer types that MagickCropImage accepts. Don't assume
2645 Vimagemagick_render_type has a nonnegative value. Don't assume
2646 size_t fits in 'long'.
2647 (gs_load): Use printmax_t to print the widest integers possible.
2648 Check for integer overflow when computing image height and width.
2650 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2652 * xdisp.c (redisplay_window): Don't force window start if point
2653 will be invisible in the resulting window. (Bug#9324)
2655 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2657 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2658 the display spec is of the form `(space ...)'.
2659 (handle_display_spec): Return the value returned by
2660 handle_single_display_spec, not just 1 or zero.
2661 (handle_single_display_spec): If the display spec is of the form
2662 `(space ...)', and specifies display in the text area, return 2
2664 (try_cursor_movement): Check for the need to scroll more
2665 accurately, and prefer exact match for point under bidi.
2666 Don't advance `row' beyond the last row of the window.
2668 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2669 into disp_prop; all users changed.
2671 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2672 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2673 for the text covered by the display property.
2675 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2677 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2678 Change return value to nil.
2679 (Frecord_buffer): Delete unused function.
2681 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2683 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2684 buffers, return left-to-right.
2685 (set_cursor_from_row): Consider candidate row a win if its glyph
2686 represents a newline and point is on that newline. Fixes cursor
2687 positioning on the newline at EOL of R2L text within L2R
2688 paragraph, and vice versa.
2689 (try_cursor_movement): Check continued rows, in addition to
2690 continuation rows. Fixes unwarranted scroll when point enters a
2691 continued line of R2L text within an L2R paragraph, or vice versa.
2692 (cursor_row_p): Consider the case of point being equal to
2693 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2694 from the end of a short line to the beginning of a continued line
2695 of R2L text within L2R paragraph.
2696 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2697 composed characters.
2699 * bidi.c (bidi_check_type): Use xassert.
2700 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2703 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2705 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2708 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2710 * nsfont.m (ns_otf_to_script): Fix typo.
2712 2011-08-22 Kenichi Handa <handa@m17n.org>
2714 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2715 extra slot even if the purpose is char-code-property-table.
2717 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2719 * xdisp.c (redisplay_window): When computing centering_position,
2720 account for the height of the header line. (Bug#8874)
2722 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2723 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2724 candidate is selected by the mouse, and that candidate has a
2725 composed character under the mouse.
2727 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2728 coordinates reported by pos-visible-in-window-p for a composed
2729 character in column zero.
2731 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2733 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2735 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2737 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2738 consider it a hit if to_charpos is anywhere in the range of the
2739 composed buffer positions.
2741 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2743 * image.c (gif_load): Don't assume that each subimage has the same
2744 dimensions as the base image. Handle disposal method that is
2745 "undefined" by the gif spec (Bug#9335).
2747 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2749 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2750 (Fcondition_case): Document `debug' symbol in error handler.
2752 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2754 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2755 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2756 from an Org mode buffer to a Speedbar frame.
2758 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2759 a composition, take its buffer position from IT->cmp_it.charpos.
2760 Fixes cursor positioning at the beginning of a line that begins
2761 with a composed character.
2763 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2765 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2766 character bidirectional type, use STRONG_L instead. Fixes crashes
2767 in a buffer produced by `describe-categories'.
2769 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2770 members before the level stack, so they would be saved and
2771 restored when copying iterator state. Fixes incorrect reordering
2772 around TABs covered by display properties.
2774 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2776 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2778 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2780 * eval.c (internal_condition_case, internal_condition_case_1)
2781 (internal_condition_case_2, internal_condition_case_n):
2782 Remove unnecessary aborts (Bug#9081).
2784 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2786 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2787 has no `load' handler, try opening the file locally. (Bug#9311)
2789 2011-08-16 Ken Brown <kbrown@cornell.edu>
2791 * gmalloc.c: Expand comment.
2793 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2795 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2796 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2798 2011-08-16 Ken Brown <kbrown@cornell.edu>
2800 Fix memory allocation problems in Cygwin build (Bug#9273).
2802 * unexcw.c ( __malloc_initialized): Declare external variable.
2803 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2805 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2807 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2809 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2811 [CYGWIN] (special_realloc): New function.
2812 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2813 requests to realloc storage in the static heap.
2815 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2817 * bidi.c (bidi_initialize): Remove unused local.
2819 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2822 * biditype.h: Remove file.
2823 * makefile.w32-in ($(BLD)/bidi.$(O)):
2824 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2826 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2828 * chartab.c: Improve commentary for the uniprop_table API.
2830 * bidi.c (bidi_paragraph_init): Support zero value of
2831 bidi_ignore_explicit_marks_for_paragraph_level.
2832 (bidi_initialize): Use uniprop_table instead of including
2833 biditype.h and bidimirror.h.
2835 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2836 coordinates of the iterator when restoring from ppos_it.
2839 2011-08-14 Kenichi Handa <handa@m17n.org>
2841 * process.c (create_process): Call setup_process_coding_systems
2842 after the pid of the process is set to -1 (Bug#8162).
2844 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2846 * xdisp.c (move_it_in_display_line_to): Don't invoke
2847 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2848 ppos_it. Fixes vertical cursor motion when line beginning is
2849 covered by an image. (Bug#9296)
2851 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2853 * nsterm.h (ns_run_ascript): Declare.
2854 (NSAPP_DATA2_RUNASSCRIPT): Define.
2856 * nsfns.m (as_script, as_result, as_status): New static variables.
2857 (ns_run_ascript): New function.
2858 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2859 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2860 the event loop. Get status from as_status (Bug#7276).
2862 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2863 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2864 the event loop (Bug#7276).
2866 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2868 * gnutls.c (QCgnutls_bootprop_priority)
2869 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2870 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2871 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2872 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2873 (QCgnutls_bootprop_verify_hostname_error)
2874 (QCgnutls_bootprop_callbacks_verify): Rename from
2875 Qgnutls_bootprop_..., all uses changed.
2877 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2880 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2882 * xfaces.c (Qframe_set_background_mode): Now static.
2883 * dispextern.h (Qframe_set_background_mode): Remove decl.
2885 * process.c (Fnetwork_interface_info): Declare local only if needed.
2887 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2889 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2890 (Fnetwork_interface_list): Allocate in increments of bytes instead
2891 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2892 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2894 (struct ifflag_def): notrailers is smart on OSX.
2895 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2896 Get hardware address with getifaddrs if available.
2898 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2900 * xdisp.c (iterate_out_of_display_property): xassert that
2901 IT->position is set to within IT->object's boundaries. Break from
2902 the loop as soon as EOB is reached; avoids infloops in redisplay
2903 when IT->position is set up wrongly due to some bug.
2904 Set IT->current to match the bidi iterator unconditionally.
2905 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2906 entry. Force push_it to save on the stack the current
2907 buffer/string position, to be restored by pop_it. Fix flags in
2908 the iterator structure wrt the object coming from a display
2909 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2910 properties. (Bug#9284)
2912 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2914 * fontset.c (fontset_get_font_group): Add proper type checks.
2917 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2919 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2920 and LC_VERSION_MIN_MACOSX.
2921 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2922 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2924 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2926 * xdisp.c (forward_to_next_line_start): Allow to use the
2927 no-display-properties-and-no-overlays under bidi display.
2928 Set disp_pos in the bidi iterator to avoid searches for display
2929 properties and overlays.
2931 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2933 * editfns.c (Fset_time_zone_rule): Document relationship with the
2936 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2937 the font entity extracted from the cache (Bug#8109).
2939 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2941 * composite.c (autocmp_chars): Don't reset point. That is done by
2942 restore_point_unwind (Bug#5984).
2944 2011-08-07 Juri Linkov <juri@jurta.org>
2946 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2947 to show the arg `TIME' instead of `TIMEVAL'.
2949 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2951 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2952 display property strides EOL and includes a newline, as in
2953 longlines-mode. (Bug#9254)
2954 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2955 word-wrap under bidirectional display. (Bug#9224)
2957 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2958 is non-zero, even if the data buffer is NULL. Fixes a crash in
2959 vertical-motion with longlines-mode. (Bug#9254)
2961 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2963 * bidi.c <bidi_cache_total_alloc>: Now static.
2964 (bidi_initialize): Initialize bidi_cache_total_alloc.
2966 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2969 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2970 amount allocated this far in `bidi_cache_total_alloc'.
2971 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2972 non-zero, only free the data buffer without restoring the cache
2973 contents. All callers changed.
2975 * dispextern.h (bidi_unshelve_cache): Update prototype.
2977 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2978 (move_it_in_display_line, move_it_to)
2979 (move_it_vertically_backward, move_it_by_lines): Replace the call
2980 to xfree to an equivalent call to bidi_unshelve_cache.
2981 (move_it_in_display_line_to): Fix logic of returning
2982 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2984 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2986 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2987 came from a string character with a `cursor' property. (Bug#9229)
2989 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2991 * Makefile.in (LIB_PTHREAD): New variable.
2992 (LIBES): Add LIB_PTHREAD (Bug#9216).
2994 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2995 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2997 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2999 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3001 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3003 * xterm.c (x_find_topmost_parent): New function.
3004 (x_set_frame_alpha): Find topmost parent window with
3005 x_find_topmost_parent and set the property there also (bug#9181).
3006 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3008 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3010 * callproc.c (Fcall_process): Avoid vfork clobbering
3011 the local vars buffer, coding_systems, current_dir.
3013 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3015 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3017 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3019 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3020 so that it is not optimized away.
3022 * xdisp.c (compute_display_string_pos): Remove unused local.
3024 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3026 Fix slow cursor motion and scrolling in large buffers with
3027 selective display, like Org Mode buffers. (Bug#9218)
3029 * dispextern.h (struct bidi_it): New member disp_prop_p.
3031 * xdisp.c: Remove one-slot cache of display string positions.
3032 (compute_display_string_pos): Accept an additional argument
3033 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3034 for a display string or property. If found, set DISP_PROP_P
3037 * bidi.c (bidi_fetch_char): Accept an additional argument
3038 DISP_PROP_P, and pass it to compute_display_string_pos.
3039 Only handle text covered by a display string if DISP_PROP_P is returned
3040 non-zero. All callers of bidi_fetch_char changed.
3042 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3044 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3046 2010-12-03 Don March <don@ohspite.net>
3048 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3049 last character M-[char] is translated to ESC [char] (bug#7541).
3051 2011-08-02 Kenichi Handa <handa@m17n.org>
3053 * lisp.h (uniprop_table): Extern it.
3055 * chartab.c (uniprop_table): Make it non-static.
3057 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3059 * xdisp.c (forward_to_next_line_start): Accept additional argument
3060 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3062 (reseat_at_next_visible_line_start): Use the bidi iterator state
3063 returned by forward_to_next_line_start to restore the state of
3064 it->bidi_it after backing up to previous newline. (Bug#9212)
3066 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3068 * regex.c (re_comp): Protoize.
3069 (re_exec): Fix return type.
3070 (regexec): Fix type of `ret'. (Bug#9203)
3072 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3074 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3075 This is needed if max-image-size is a floating-point number.
3077 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3079 * print.c (print_object): Print empty symbol as ##.
3081 * lread.c (read1): Read ## as empty symbol.
3083 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3085 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3086 setting frame foreground color (Bug#9175).
3087 (x_set_background_color): Likewise.
3089 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3090 contents (Bug#9176).
3091 (EmacsTooltip -init): Remove bezels and add shadows to
3094 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3095 or scroll bar (Bug#8470).
3097 * nsfont.m (nsfont_open): Remove assignment to voffset and
3098 unnecessary vars hshink, expand, hd, full_height, min_height.
3099 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3101 * nsterm.h (nsfont_info): Remove voffset field.
3103 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3105 Implement strike-through and overline on NextStep (Bug#8863).
3107 * nsfont.m (nsfont_open): Use underline position provided by font,
3108 instead of hard-coded value of 2.
3109 (nsfont_draw): Call ns_draw_text_decoration instead.
3111 * nsterm.h: Add declaration for ns_draw_text_decoration.
3113 * nsterm.m (ns_draw_text_decoration): New function for drawing
3114 underline, overline, and strike-through.
3115 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3116 ns_draw_text_decoration. Change treatment of cursor drawing to
3117 accommodate underlining, etc.
3119 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3121 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3124 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3126 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3127 Without this fix, if a signal arrives just after memory fills up,
3128 'malloc' might be invoked reentrantly.
3130 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3131 In other words, assume that every image size is allowed, on non-X
3132 hosts. This assumption is probably wrong, but it lets Emacs compile.
3134 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3136 * regex.c (re_iswctype): Convert return values to boolean.
3138 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3140 * xdisp.c (compute_display_string_pos): Don't use cached display
3141 string position if the buffer had its restriction changed.
3144 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3146 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3148 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3150 Integer signedness and overflow and related fixes. (Bug#9079)
3152 * bidi.c: Integer size and overflow fixes.
3153 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3154 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3155 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3156 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3157 (bidi_find_other_level_edge):
3158 Use ptrdiff_t instead of EMACS_INT where either will do.
3159 This works better on 32-bit hosts configured --with-wide-int.
3160 (bidi_cache_ensure_space): Check for size-calculation overflow.
3161 Use % rather than repeated addition, for better worst-case speed.
3162 Don't set bidi_cache_size until after xrealloc returns, because it
3164 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3165 (bidi_cache_ensure_space): Also check that the bidi cache size
3166 does not exceed that of the largest Lisp string or buffer. See Eli
3167 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3169 * alloc.c (__malloc_size_t): Remove.
3170 All uses replaced by size_t. See Andreas Schwab's note
3171 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3173 * image.c: Improve checking for integer overflow.
3174 (check_image_size): Assume that f is nonnull, since
3175 it is always nonnull in practice. This is one less thing to
3176 worry about when checking for integer overflow later.
3177 (x_check_image_size): New function, which checks for integer
3178 overflow issues inside X.
3179 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3180 This removes the need for a memory_full check.
3181 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3182 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3183 (xbm_read_bitmap_data): Change locals back to 'int', since
3184 their values must fit in 'int'.
3185 (xpm_load_image, png_load, tiff_load):
3186 Invoke x_create_x_image_and_pixmap earlier,
3187 to avoid much needless work if the image is too large.
3188 (tiff_load): Treat overly large images as if
3189 x_create_x_image_and_pixmap failed, not as malloc failures.
3190 (gs_load): Use x_check_image_size.
3192 * gtkutil.c: Omit integer casts.
3193 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3194 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3196 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3198 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3199 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3200 would wrongly return t on a 64-bit host.
3202 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3203 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3204 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3205 and therefore cause GCC to emit a bogus diagnostic in some cases.
3207 * image.c: Integer signedness and overflow and related fixes.
3208 This is not an exhaustive set of fixes, but it's time to
3209 record what I've got.
3210 (lookup_pixel_color, check_image_size): Remove redundant decls.
3211 (check_image_size): Don't assume that arbitrary EMACS_INT values
3212 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3213 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3214 (tiff_load, imagemagick_load_image):
3215 Check for overflow in size calculations.
3216 (x_create_x_image_and_pixmap): Remove unnecessary test for
3217 xmalloc returning NULL; that can't happen.
3218 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3219 (xpm_color_bucket): Use better integer hashing function.
3220 (xpm_cache_color): Don't possibly over-allocate memory.
3221 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3222 (gif_memory_source):
3223 Use ptrdiff_t, not int or size_t, to record sizes.
3224 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3225 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3226 either works, as we prefer signed integers.
3227 (tiff_read_from_memory, tiff_write_from_memory):
3228 Return tsize_t, not size_t, since that's what the TIFF API wants.
3229 (tiff_read_from_memory): Don't fail simply because the read would
3230 go past EOF; instead, return a short read.
3231 (tiff_load): Omit no-longer-needed casts.
3232 (Fimagemagick_types): Don't assume size fits into 'int'.
3234 Improve hashing quality when configured --with-wide-int.
3235 * fns.c (hash_string): New function, taken from sxhash_string.
3236 Do not discard information about ASCII character case; this
3237 discarding is no longer needed.
3238 (sxhash-string): Use it. Change sig to match it. Caller changed.
3239 * lisp.h: Declare it.
3240 * lread.c (hash_string): Remove, since we now use fns.c's version.
3241 The fns.c version returns a wider integer if --with-wide-int is
3242 specified, so this should help the quality of the hashing a bit.
3244 * emacs.c: Integer overflow minor fix.
3245 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3246 Define only if GNU_LINUX.
3247 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3249 * dispnew.c: Integer signedness and overflow fixes.
3250 Remove unnecessary forward decls, that were a maintenance hassle.
3251 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3253 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3254 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3255 (prepare_desired_row, line_draw_cost):
3256 Use int, not unsigned, where either works.
3257 (save_current_matrix, restore_current_matrix):
3258 Use ptrdiff_t, not size_t, where either works.
3259 (init_display): Check for overflow more accurately, and without
3260 relying on undefined behavior.
3262 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3263 Remove, replacing with the new symbols in lisp.h. All uses changed.
3264 * fileio.c (make_temp_name):
3265 * filelock.c (lock_file_1, lock_file):
3266 * xdisp.c (message_dolog):
3267 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3268 Use pMd etc. instead.
3269 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3270 replacing the pWIDE etc. symbols removed from editfns.c.
3272 * keyboard.h (num_input_events): Now uintmax_t.
3273 This is (very slightly) less likely to mess up due to wraparound.
3276 * buffer.c: Integer signedness fixes.
3277 (alloc_buffer_text, enlarge_buffer_text):
3278 Use ptrdiff_t rather than size_t when either will do, as we prefer
3281 * alloc.c: Integer signedness and overflow fixes.
3282 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3283 (__malloc_size_t): Default to size_t, not to int.
3284 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3285 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3286 Prefer ptrdiff_t to size_t when either would do, as we prefer
3288 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3289 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3290 Now const. Initialize with values that are in range even if char
3292 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3293 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3294 These functions do the right thing with sizes > 2**32.
3295 (check_depth): Now ptrdiff_t, not int.
3296 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3297 Adjust to new way of storing sizes. Check for size overflow bugs
3299 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3300 slightly wrong anyway, as it missed one instance of
3301 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3302 (refill_memory_reserve): Omit needless cast to size_t.
3303 (mark_object_loop_halt): Mark as externally visible.
3305 * xselect.c: Integer signedness and overflow fixes.
3306 (Fx_register_dnd_atom, x_handle_dnd_message):
3307 Use ptrdiff_t, not size_t, since we prefer signed.
3308 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3309 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3310 x_dnd_atoms_size and x_dnd_atoms_length.
3312 * doprnt.c: Prefer signed to unsigned when either works.
3314 * doprnt.c (doprnt):
3316 * xdisp.c (vmessage):
3317 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3318 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3319 prefer signed arithmetic to avoid comparison confusion.
3320 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3321 but is a bit tricky.
3323 Assume freestanding C89 headers, string.h, stdlib.h.
3324 * data.c, doprnt.c, floatfns.c, print.c:
3325 Include float.h unconditionally.
3326 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3327 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3328 * regex.c: Likewise for stddef.h, string.h.
3329 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3330 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3331 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3332 (STDC_HEADERS): Remove obsolete defines.
3333 * sysdep.c: Include limits.h unconditionally.
3335 Assume support for memcmp, memcpy, memmove, memset.
3336 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3337 * regex.c (memcmp, memcpy):
3338 Remove; we assume C89 now.
3340 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3341 (__malloc_safe_bcopy): Remove; no longer needed.
3343 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3344 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3345 well either way, and we prefer signed to unsigned.
3347 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3349 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3350 closes the connection while we're reading (bug#9182).
3352 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3354 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3355 are specified (Bug#9168).
3357 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3359 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3360 Found by GCC static checking and --with-wide-int on a 32-bit host.
3362 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3364 * xdisp.c (compute_display_string_pos): Fix logic of caching
3365 previous display string position. Initialize cached_prev_pos to
3366 -1. Fixes slow-down at the beginning of a buffer.
3368 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3370 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3371 for attrs[LFACE_FONTSET_INDEX].
3373 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3375 * xml.c (parse_region): Remove unused local
3376 that was recently introduced.
3378 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3380 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3381 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3383 * xdisp.c (move_it_in_display_line_to): Record the best matching
3384 position for TO_CHARPOS while scanning the line, and restore it on
3385 exit if none of the characters scanned was an exact match.
3386 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3387 when exact match is impossible due to invisible text, and the
3388 lines are truncated.
3390 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3392 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3395 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3397 Fix a significant slow-down of cursor motion with C-n, C-p,
3398 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3399 auto-repeat under bidi redisplay in fontified buffers.
3400 * xdisp.c (compute_stop_pos_backwards): New function.
3401 (next_element_from_buffer): Call compute_stop_pos_backwards to
3402 find a suitable prev_stop when we find ourselves before
3404 (reseat): Don't look for prev_stop, as that could mean a very long
3406 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3407 <cached_disp_overlay_modiff>: Cache for last found display string
3409 (compute_display_string_pos): Return the cached position if asked
3410 about the same buffer in the same area of character positions, and
3411 the buffer wasn't changed since the time the display string
3412 position was cached.
3414 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3416 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3417 is an integer, which is important for empty lines. (Bug#9149)
3419 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3421 * frame.c (Fmodify_frame_parameters): In tty case, update the
3422 default face if necessary (Bug#4238).
3424 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3426 * editfns.c (Fstring_to_char): No need to explain what a character
3427 is in the docstring (Bug#6576).
3429 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3431 * xml.c (parse_region): Make sure we always return a tree.
3433 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3435 * xml.c (parse_region): If a document contains only comments,
3438 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3440 * xml.c (make_dom): Return comments, too.
3442 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3445 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3446 and the surrounding thread.
3447 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3448 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3449 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3451 * s/openbsd.h (BROKEN_SIGIO): Define.
3452 * unexelf.c (unexec) [__OpenBSD__]:
3453 Don't update the .mdebug section of the Alpha COFF symbol table.
3455 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3457 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3460 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3462 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3463 This fixes some race conditions on the permissions of any newly
3466 * alloc.c (valid_pointer_p): Use pipe, not open.
3467 This fixes some permissions issues when debugging.
3469 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3470 If fchown fails to set both uid and gid, try to set just gid,
3471 as that is sometimes allowed. Adjust the file's mode to eliminate
3472 setuid or setgid bits that are inappropriate if fchown fails.
3474 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3476 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3477 to compare Lisp_Objects.
3478 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3479 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3480 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3482 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3484 * lread.c (read_integer): Unread even EOF character.
3485 (read1): Likewise. Properly record start position of symbol.
3487 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3488 symbol character follows.
3490 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3492 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3493 This works around a problem with the previous change to Fcopy_file.
3494 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3495 and without this change, GCC might complain about discarding
3496 fchown's return value.
3498 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3500 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3502 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3504 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3506 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3508 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3509 it's used from the C level.
3511 * process.c: Use the same condition for POLL_FOR_INPUT in both
3512 keyboard.c and process.c (bug#1858).
3514 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3516 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3517 (Fgnutls_boot): Use it.
3519 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3521 * doc.c (Fsubstitute_command_keys): Revert last change.
3523 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3525 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3526 quotes the next character, and doesn't affect other longer
3527 sequences (bug#8935).
3529 * lread.c (syms_of_lread): Clarify that is isn't only
3530 `eval-buffer' and `eval-defun' that's affected by
3531 `lexical-binding' (bug#8460).
3533 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3535 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3536 bidi redisplay when a line includes both an image and is truncated.
3538 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3540 Fix minor problems found by static checking.
3541 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3542 (elsz): Now a signed constant, not a size_t var. We prefer signed
3543 types to unsigned, to avoid integer comparison confusion. Without
3544 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3545 "cannot optimize loop, the loop counter may overflow", a symptom
3547 * indent.c (Fvertical_motion): Mark locals as initialized.
3548 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3550 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3552 * search.c (Fre_search_backward): Mention `case-fold-search' in
3553 all the re_search_* functions (bug#8138).
3555 * keyboard.c (Fopen_dribble_file): Document when the file is
3558 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3560 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3563 Support bidi reordering of display and overlay strings.
3564 * xdisp.c (compute_display_string_pos)
3565 (compute_display_string_end): Accept additional argument STRING.
3566 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3567 (reseat_to_string): Initialize bidi_it->string.s and
3568 bidi_it->string.schars.
3569 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3570 NULL (avoids a crash in bidi_paragraph_init).
3571 Initialize itb.string.lstring.
3572 (init_iterator): Call bidi_init_it only of a valid
3573 buffer position was specified. Initialize paragraph_embedding to
3575 (reseat_to_string): Initialize the bidi iterator.
3576 (display_string): If we need to ignore text properties of
3577 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3578 original value of -1 will not work with bidi.)
3579 (compute_display_string_pos): First arg is now struct
3580 `text_pos *'; all callers changed. Support display properties on
3582 (compute_display_string_end): Support display properties on Lisp
3584 (init_iterator, reseat_1, reseat_to_string): Initialize the
3585 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3586 when iterating on a string not from display properties).
3587 (compute_display_string_pos, compute_display_string_end):
3588 Fix calculation of the object to scan. Fixes an error when using
3590 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3591 base_level_stop; instead, set base_level_stop to BEGV.
3592 Fixes crashes in vertical-motion.
3593 (next_element_from_buffer): Improve commentary for when
3594 the iterator is before prev_stop.
3595 (init_iterator): Initialize bidi_p from the default value of
3596 bidi-display-reordering, not from buffer-local value. Use the
3597 buffer-local value only if initializing for buffer iteration.
3598 (handle_invisible_prop): Support invisible properties on strings
3599 that are being bidi-reordered.
3600 (set_iterator_to_next): Support bidi reordering of C strings and
3602 (next_element_from_string): Support bidi reordering of Lisp
3604 (handle_stop_backwards): Support Lisp strings as well.
3605 (display_string): Support display of R2L glyph rows.
3606 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3607 (init_iterator): Don't initialize it->bidi_p for strings
3609 (reseat_to_string): Initialize it->bidi_p for strings here.
3610 (next_element_from_string, next_element_from_c_string)
3611 (next_element_from_buffer): Add xassert's for correspondence
3612 between IT's object being iterated and it->bidi_it.string
3614 (face_before_or_after_it_pos): Support bidi iteration.
3615 (next_element_from_c_string): Handle the case of the first string
3616 character that is not the first one in the visual order.
3617 (get_visually_first_element): New function, refactored from common
3618 parts of next_element_from_buffer, next_element_from_string, and
3619 next_element_from_c_string.
3620 (tool_bar_lines_needed, redisplay_tool_bar)
3621 (display_menu_bar): Force left-to-right direction. Add a FIXME
3622 comment for making that be controlled by a user option.
3623 (push_it, pop_it): Save and restore the state of the
3624 bidi iterator. Save and restore the bidi_p flag.
3625 (pop_it): Iterate out of display property for string iteration as
3627 (iterate_out_of_display_property): Support iteration over strings.
3628 (handle_single_display_spec): Set up it->bidi_it for iteration
3629 over a display string, and call bidi_init_it.
3630 (handle_single_display_spec, next_overlay_string)
3631 (get_overlay_strings_1, push_display_prop): Set up the bidi
3632 iterator for displaying display or overlay strings.
3633 (forward_to_next_line_start): Don't use the shortcut if
3635 (back_to_previous_visible_line_start): If handle_display_prop
3636 pushed the iterator stack, restore the internal state of the bidi
3637 iterator by calling bidi_pop_it same number of times.
3638 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3639 and we are bidi-iterating, don't decrement the iterator position;
3640 instead, set the first_elt flag in the bidi iterator, to produce
3642 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3643 (push_display_prop): xassert that we are iterating a buffer.
3644 (push_it, pop_it): Save and restore paragraph_embedding member.
3645 (handle_single_display_spec, next_overlay_string)
3646 (get_overlay_strings_1, reseat_1, reseat_to_string)
3647 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3648 correctly. Don't assume unibyte strings are not bidi-reordered.
3649 (compute_display_string_pos)
3650 (compute_display_string_end): Fix handling the case of C string.
3651 (push_it, pop_it): Save and restore from_disp_prop_p.
3652 (handle_single_display_spec, push_display_prop): Set the
3653 from_disp_prop_p flag.
3654 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3655 (pop_it): Call iterate_out_of_display_property only if we are
3656 popping after iteration over a string that came from a display
3657 property. Fix a typo in popping stretch info. Add an assertion
3658 for verifying that the iterator position is in sync with the bidi
3660 (handle_single_display_spec, get_overlay_strings_1)
3661 (push_display_prop): Fix initialization of paragraph direction for
3662 string when that of the parent object is not yet determined.
3663 (reseat_1): Call bidi_init_it to resync the bidi
3664 iterator with IT's position. (Bug#7616)
3665 (find_row_edges): If ROW->start.pos gives position
3666 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3667 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3668 Reset the from_disp_prop_p flag.
3669 (SAVE_IT, RESTORE_IT): New macros.
3670 (pos_visible_p, face_before_or_after_it_pos)
3671 (back_to_previous_visible_line_start)
3672 (move_it_in_display_line_to, move_it_in_display_line)
3673 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3674 (try_scrolling, redisplay_window, display_line): Use them when
3675 saving a temporary copy of the iterator and restoring it back.
3676 (back_to_previous_visible_line_start, reseat_1)
3677 (init_iterator): Empty the bidi cache "stack".
3678 (move_it_in_display_line_to): If iterator ended up at
3679 EOL, but we never saw any buffer positions smaller than
3680 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3681 motion in bidi-reordered lines.
3682 (move_it_in_display_line_to): Record prev_method and prev_pos
3683 immediately before the call to set_iterator_to_next. Fixes cursor
3684 motion in bidi-reordered lines with stretch glyphs and strings
3685 displayed in margins. (Bug#8133) (Bug#8867)
3686 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3688 (pos_visible_p): Support positions in bidi-reordered lines.
3689 Save and restore bidi cache.
3691 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3692 (bidi_paragraph_info): Delete unused struct.
3693 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3694 (bidi_cache_start): New variable.
3695 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3697 (bidi_cache_fetch_state, bidi_cache_search)
3698 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3699 (bidi_cache_find, bidi_peek_at_next_level)
3700 (bidi_level_of_next_char, bidi_find_other_level_edge)
3701 (bidi_move_to_visually_next): Compare cache index with
3702 bidi_cache_start rather than with zero.
3703 (bidi_fetch_char): Accept new argument STRING; all callers
3704 changed. Support iteration over a string. Support strings with
3705 display properties. Support unibyte strings. Fix the type of
3706 `len' according to what STRING_CHAR_AND_LENGTH expects.
3707 (bidi_paragraph_init, bidi_resolve_explicit_1)
3708 (bidi_resolve_explicit, bidi_resolve_weak)
3709 (bidi_level_of_next_char, bidi_move_to_visually_next):
3710 Support iteration over a string.
3711 (bidi_set_sor_type, bidi_resolve_explicit_1)
3712 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3713 can now be zero (for strings); special values 0 and -1 were
3714 changed to -1 and -2, respectively.
3715 (bidi_char_at_pos): New function.
3716 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3717 Call it instead of FETCH_MULTIBYTE_CHAR.
3718 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3719 initialized to valid values.
3720 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3722 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3723 the test for valid cached positions. Fix the logic for looking up
3724 the sentinel state in the cache. GCPRO the Lisp string we are
3726 (bidi_push_it, bidi_pop_it): New functions.
3727 (bidi_initialize): Initialize the bidi cache start stack pointer.
3728 (bidi_cache_ensure_space): New function, refactored from part of
3729 bidi_cache_iterator_state. Don't assume the required size is just
3730 one BIDI_CACHE_CHUNK away.
3731 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3732 (bidi_count_bytes, bidi_char_at_pos): New functions.
3733 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3734 always valid if bidi_cache_idx is valid.
3735 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3736 is valid if it's going to be used.
3737 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3738 (bidi_cache_fetch_state, bidi_cache_search)
3739 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3740 (bidi_cache_iterator_state, bidi_cache_find)
3741 (bidi_find_other_level_edge, bidi_cache_start_stack):
3742 All variables related to cache indices are now EMACS_INT.
3744 * dispextern.h (struct bidi_string_data): New structure.
3745 (struct bidi_it): New member `string'. Make flag members be 1-bit
3746 fields, and put them last in the struct.
3747 (compute_display_string_pos, compute_display_string_end):
3749 (bidi_push_it, bidi_pop_it): Add prototypes.
3750 (struct iterator_stack_entry): New members bidi_p,
3751 paragraph_embedding, and from_disp_prop_p.
3752 (struct it): Member bidi_p is now a bit field 1 bit wide.
3753 (bidi_shelve_cache, bidi_unshelve_cache):
3756 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3757 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3758 and vector-like objects.
3760 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3761 cache around display iteration.
3763 * window.c (Fwindow_end, window_scroll_pixel_based)
3764 (displayed_window_lines, Frecenter): Save and restore the bidi
3765 cache around display iteration.
3767 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3769 * editfns.c (Fdelete_region): Clarify the use of the named
3770 parameters (bug#6788).
3772 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3774 * indent.c (Fvertical_motion): Set and restore w->pointm when
3775 saving and restoring the window's buffer (Bug#9006).
3777 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3779 * editfns.c (Fstring_to_char): Clarify just what is returned
3780 (bug#6576). Text by Eli Zaretskii.
3782 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3784 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3786 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3788 * buffer.c (mmap_find): Fix a typo.
3790 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3792 Fix execution of x selection hooks.
3793 * xselect.c (Qx_lost_selection_functions)
3794 (Qx_sent_selection_functions): New vars.
3795 (syms_of_xselect): DEFSYM them.
3796 (x_handle_selection_request): Pass Qx_sent_selection_functions
3797 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3798 (x_handle_selection_clear,x_clear_frame_selections):
3799 Pass Qx_lost_selection_functions rather than
3800 Vx_lost_selection_functions to Frun_hook_with_args.
3802 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3804 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3805 The old code sometimes used this field without initializing it.
3807 * alloc.c (gc_sweep): Don't read past end of array.
3808 In theory, the old code could also have corrupted Emacs internals,
3809 though it'd be very unlikely.
3811 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3813 * character.c (Fcharacterp): Don't advertise optional ignored
3814 argument. (Bug#4026)
3816 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3818 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3821 * window.c (Fset_window_start): Doc fix (bug#4199).
3822 (Fset_window_hscroll): Ditto.
3824 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3826 Fix minor new problems caught by GCC 4.6.1.
3827 * term.c (init_tty): Remove unused local.
3828 * xsettings.c (store_monospaced_changed): Define this function only
3829 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3832 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3834 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3836 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3838 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3839 are the mini-buffer and the echo area (bug#3320).
3841 * term.c (init_tty): Remove support for supdup, c10 and perq
3842 terminals, which are no longer supported (bug#1482).
3844 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3846 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3848 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3850 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3851 for non-popups (Bug#3642).
3853 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3855 * alloc.c (reset_malloc_hooks): Protoize.
3856 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3857 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3858 * cm.c (losecursor): Likewise.
3859 * data.c (fmod): Likewise.
3860 * dispnew.c (swap_glyphs_in_rows): Likewise.
3861 * emacs.c (memory_warning_signal): Likewise.
3862 * floatfns.c (float_error): Likewise.
3863 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3864 (otf_open, font_otf_capability, generate_otf_features)
3865 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3867 * image.c (pbm_read_file): Likewise.
3868 * indent.c (string_display_width): Likewise.
3869 * intervals.c (check_for_interval, search_for_interval)
3870 (inc_interval_count, count_intervals, root_interval)
3871 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3872 * lread.c (defalias): Likewise.
3873 * ralloc.c (r_alloc_check): Likewise.
3874 * regex.c (set_image_of_range_1, set_image_of_range)
3875 (regex_grow_registers): Likewise.
3876 * sysdep.c (strerror): Likewise.
3877 * termcap.c (valid_filename_p, tprint, main): Likewise.
3878 * tparam.c (main): Likewise.
3879 * unexhp9k800.c (run_time_remap, save_data_space)
3880 (update_file_ptrs, read_header, write_header, calculate_checksum)
3881 (copy_file, copy_rest, display_header): Likewise.
3882 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3884 * xdisp.c (check_it): Likewise.
3885 * xfaces.c (register_color, unregister_color, unregister_colors):
3887 * xfns.c (print_fontset_result): Likewise.
3888 * xrdb.c (member, fatal, main): Likewise.
3890 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3892 Fix minor problems found by static checking (Bug#9031).
3893 * chartab.c (char_table_set_range, map_sub_char_table):
3894 Remove unused locals.
3895 (uniprop_table): Now static.
3896 * composite.c (_work_char): Remove unused static var.
3898 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3900 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3902 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3904 * gtkutil.c (qttip_cb): Remove code without function.
3906 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3908 * w32.c (pthread_sigmask): New stub.
3910 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3912 Use pthread_sigmask, not sigprocmask (Bug#9010).
3913 sigprocmask is portable only for single-threaded applications, and
3914 Emacs can be multi-threaded when it uses GTK.
3915 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3917 * callproc.c (Fcall_process):
3918 * process.c (create_process):
3919 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3920 Use pthread_sigmask, not sigprocmask.
3922 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3924 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3925 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3928 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3930 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3931 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3932 (xg_hide_tooltip): Fix comment.
3934 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3935 in registerServicesMenuSendTypes.
3936 (validRequestorForSendType): Don't check ns_return_types.
3938 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3941 2011-07-08 Jason Rumney <jasonr@gnu.org>
3943 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3944 SH_SHOW for hidden windows (Bug#5482).
3946 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3947 frame struct members of non-existent frames (Bug#6284).
3949 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3951 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3952 variable firstTime not needed on OSX >= 10.6.
3953 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3954 >= 10.5. Use setKnobProportion, setDoubleValue.
3956 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3957 (MAC_OS_X_VERSION_10_5): Define if not defined.
3958 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3959 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3960 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3962 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3963 cString and lossyCString on OSX >= 10.4
3965 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3966 sizeToFit on OSX >= 10.2.
3968 * nsimage.m (allocInitFromFile): Don't use deprecated method
3969 bestRepresentationForDevice on OSX >= 10.6.
3971 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3974 * emacs.c: Declare unexec_init_emacs_zone.
3976 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3978 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3980 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3981 on svcsMenu (Bug#8842).
3983 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3985 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3987 * nsterm.m (QUTF8_STRING): Declare.
3988 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3989 (validRequestorForSendType): Return type is (id).
3990 Change indexOfObjectIdenticalTo to indexOfObject.
3991 Check if we have local selection before returning self (Bug#8842).
3992 (writeSelectionToPasteboard): Put local selection into paste board
3993 if we have a local selection (Bug#8842).
3994 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3996 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3997 (ns_get_local_selection): Declare.
3999 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4001 * keymap.c (describe_map_tree): Don't insert a double newline at
4002 the end of the buffer (bug#1169) and return whether we inserted
4005 * callint.c (Fcall_interactively): Change "reading args" to
4006 "providing args" to try to clarify what it does (bug#1010).
4008 2011-07-07 Kenichi Handa <handa@m17n.org>
4010 * composite.c (composition_compute_stop_pos): Ignore a static
4011 composition starting before CHARPOS (Bug#8915).
4013 * xdisp.c (handle_composition_prop): Likewise.
4015 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4017 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4020 2011-07-07 Kenichi Handa <handa@m17n.org>
4022 * character.h (unicode_category_t): New enum type.
4024 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4025 (Qchar_code_property_table): New variable.
4026 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4027 (UNIPROP_COMPRESSED_FORM_P): New macros.
4028 (char_table_ascii): Uncompress the compressed values.
4029 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4030 Uncompress the compressed values.
4031 (sub_char_table_ref_and_range): Likewise.
4032 (char_table_ref_and_range): Uncompress the compressed values.
4033 (sub_char_table_set): New arg is_uniprop. Callers changed.
4034 Uncompress the compressed values.
4035 (sub_char_table_set_range): Args changed. Callers changed.
4036 (char_table_set_range): Adjuted for the above change.
4037 (map_sub_char_table): Delete args default_val and parent. Add arg
4038 top. Give decoded values to a Lisp function.
4039 (map_char_table): Adjust for the above change. Give decoded
4040 values to a Lisp function. Gcpro more variables.
4041 (uniprop_table_uncompress)
4042 (uniprop_decode_value_run_length): New functions.
4043 (uniprop_decoder, uniprop_decoder_count): New variables.
4044 (uniprop_get_decoder, uniprop_encode_value_character)
4045 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4047 (uniprop_encoder, uniprop_encoder_count): New variables.
4048 (uniprop_get_encoder, uniprop_table)
4049 (Funicode_property_table_internal, Fget_unicode_property_internal)
4050 (Fput_unicode_property_internal): New functions.
4051 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4052 Sunicode_property_table_internal, Sget_unicode_property_internal,
4053 and Sput_unicode_property_internal. Defvar_lisp
4054 char-code-property-alist.
4056 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4057 Vunicode_category_table.
4059 * font.c (font_range): Adjust for the change of
4060 Vunicode_category_table.
4062 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4064 * m/iris4d.h: Remove file, move contents ...
4065 * s/irix6-5.h: ... here.
4067 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4069 Remove unportable assumption about struct layout (Bug#8884).
4070 * alloc.c (mark_buffer):
4071 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4072 (clone_per_buffer_values): Don't assume that
4073 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4074 This isn't true in general, and it's particularly not true
4075 if Emacs is configured with --with-wide-int.
4076 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4077 New macros, used in the buffer.c change.
4079 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4081 * xsettings.c: Use both GConf and GSettings if both are available.
4082 (store_config_changed_event): Add comment.
4083 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4084 (store_tool_bar_style_changed): New functions.
4085 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4086 (struct xsettings): Move font inside HAVE_XFT.
4087 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4088 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4089 Move inside HAVE_XFT.
4090 (something_changed_gsettingsCB): Rename from something_changedCB.
4091 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4093 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4094 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4095 (something_changed_gconfCB): Rename from something_changedCB.
4096 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4097 (parse_settings): Move check for font inside HAVE_XFT.
4098 (read_settings, apply_xft_settings): Add comment.
4099 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4100 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4101 call store_font_name_changed.
4102 (xft_settings_event): Add comment.
4103 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4104 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4105 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4106 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4107 (xsettings_initialize): Call init_gsettings last.
4108 (xsettings_get_system_font, xsettings_get_system_normal_font):
4111 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4113 Random fixes. E.g., (random) never returned negative values.
4114 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4115 subseconds part to the entropy, as that's a bit more random.
4116 Prefer signed to unsigned, since the signedness doesn't matter and
4117 in general we prefer signed. When given a limit, use a
4118 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4119 latter isn't right if USE_2_TAGS_FOR_INTS.
4120 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4121 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4123 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4125 * textprop.c (text_property_stickiness):
4126 Obey Vtext_property_default_nonsticky.
4127 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4128 * w32fns.c (syms_of_w32fns):
4129 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4131 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4133 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4134 This is more efficient than Ffile_directory_p and avoids a minor race.
4136 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4138 * buffer.c (Foverlay_put): Say what the return value is
4141 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4142 is a directory before asking whether to use the file name
4144 (barf_or_query_if_file_exists): Make the "File is a directory"
4145 error be more correct.
4147 * fns.c (Frequire): Remove the mention of the .gz files, since
4148 that's installation-specific, but keep the mention of
4149 `get-load-suffixes'.
4151 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4153 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4154 Report string overflow if the output is too long.
4156 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4158 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4159 (syms_of_gnutls): Remove duplicate DEFSYM for
4160 Qgnutls_bootprop_verify_hostname_error, an error for
4161 Qgnutls_bootprop_verify_error (which is no longer used).
4163 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4164 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4165 Also (re)move comments that are misplaced or no longer relevant.
4167 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4169 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4171 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4173 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4174 and background color parameters if they have been changed.
4176 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4178 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4180 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4182 * xsettings.c (SYSTEM_FONT): Define only when used.
4183 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4185 * keymap.c (access_keymap_1): Now static.
4187 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4189 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4190 leave any prefix arg for the up event (Bug#1586).
4192 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4194 * lread.c (syms_of_lread): Mention single symbols defined by
4195 `defvar' or `defconst' (bug#7154).
4197 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4198 (Frequire): Mention get-load-suffixes.
4200 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4202 * window.h (window): Remove clone_number slot.
4203 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4205 (make_parent_window, make_window, saved_window)
4206 (Fset_window_configuration, save_window_save): Don't deal with
4208 * buffer.c (Qclone_number): Remove declaration.
4209 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4211 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4213 Add multiple inheritance to keymaps.
4214 * keymap.c (Fmake_composed_keymap): New function.
4215 (Fset_keymap_parent): Simplify.
4216 (fix_submap_inheritance): Remove.
4217 (access_keymap_1): New function extracted from access_keymap to handle
4218 embedded parents and handle lists of maps.
4219 (access_keymap): Use it.
4220 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4221 (Fcopy_keymap): Handle embedded parents.
4222 (Fcommand_remapping, define_as_prefix): Simplify.
4223 (Fkey_binding): Simplify.
4224 (syms_of_keymap): Move minibuffer-local-completion-map,
4225 minibuffer-local-filename-completion-map,
4226 minibuffer-local-must-match-map, and
4227 minibuffer-local-filename-must-match-map to Elisp.
4228 (syms_of_keymap): Defsubr make-composed-keymap.
4229 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4230 (parse_menu_item): Trivial simplification.
4232 2011-07-01 Glenn Morris <rgm@gnu.org>
4234 * Makefile.in (SETTINGS_LIBS): Fix typo.
4236 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4238 * coding.c (Fencode_coding_string): Record the last coding system
4239 used, as the function doc string says (bug#8738).
4241 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4243 * xsettings.c (store_monospaced_changed): Take new font as arg and
4244 check for change against current_mono_font.
4245 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4246 (emacs_settings_constructor, emacs_settings_get_property)
4247 (emacs_settings_set_property, emacs_settings_class_init)
4248 (emacs_settings_init, gsettings_obj): Remove.
4249 (something_changedCB): New function for HAVE_GSETTINGS.
4250 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4251 with value as argument.
4252 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4253 g_settings_new (Bug#8967). Do not create gsettings_obj.
4254 Remove calls to g_settings_bind. Connect something_changedCB to
4257 * xgselect.c: Add defined (HAVE_GSETTINGS).
4258 (xgselect_initialize): Ditto.
4260 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4261 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4264 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4266 * eval.c (struct backtrace): Simplify and port the data structure.
4267 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4268 signed bit field, as this assumption is not portable and it makes
4269 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4270 "char debug_on_exit : 1" as this is not portable either; instead,
4271 use the portable "unsigned int debug_on_exit : 1". Remove unused
4272 member evalargs. Remove obsolete comments about cc bombing out.
4274 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4276 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4277 Let HAVE_GSETTINGS override HAVE_GCONF.
4278 (store_monospaced_changed): New function.
4279 (EMACS_SETTINGS): A new type derived from GObject to handle
4280 GSettings notifications.
4281 (emacs_settings_constructor, emacs_settings_get_property)
4282 (emacs_settings_set_property, emacs_settings_class_init):
4284 (gsettings_client, gsettings_obj): New variables.
4285 (GSETTINGS_SCHEMA): New define.
4286 (something_changedCB): Call store_monospaced_changed.
4287 (init_gsettings): New function.
4288 (xsettings_initialize): Call init_gsettings.
4289 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4292 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4295 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4297 * window.c (resize_root_window, grow_mini_window)
4298 (shrink_mini_window): Rename Qresize_root_window to
4299 Qwindow_resize_root_window and Qresize_root_window_vertically to
4300 Qwindow_resize_root_window_vertically.
4302 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4304 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4306 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4308 * makefile.w32-in: Redesign dependencies so they reflect more
4309 clearly which files are directly included by each source file,
4310 and not through other includes.
4312 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4314 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4315 (sort_overlays, overlay_strings): When an overlay's clone number
4316 matches the window's clone number process the overlay even if
4317 the overlay's window property doesn't match the current window.
4319 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4320 (Fwindow_hchild): Rename to Fwindow_left_child.
4321 (Fwindow_next): Rename to Fwindow_next_sibling.
4322 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4323 (resize_window_check): Rename to window_resize_check.
4324 (resize_window_apply): Rename to window_resize_apply.
4325 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4326 (Fdelete_other_windows_internal, resize_frame_windows)
4327 (Fsplit_window_internal, Fdelete_window_internal)
4328 (grow_mini_window, shrink_mini_window)
4329 (Fresize_mini_window_internal): Fix callers accordingly.
4331 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4333 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4334 (emacs_fixed_set_min_size): Remove.
4335 (emacs_fixed_new): Take frame as argument.
4337 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4338 (_EmacsFixedPrivate): Remove minwidth/height.
4339 Add struct frame *f.
4340 (emacs_fixed_init): Initialize priv->f.
4341 (get_parent_class, emacs_fixed_set_min_size): Remove.
4342 (emacs_fixed_new): Set priv->f to argument.
4343 (emacs_fixed_get_preferred_width)
4344 (emacs_fixed_get_preferred_height): Use min_width/height from
4345 frames size_hint to set minimum and natural (Bug#8919).
4346 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4347 and use min_width/height from frames size_hint to set
4348 min_width/height (Bug#8919).
4350 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4351 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4354 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4356 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4357 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4360 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4362 * process.c (wait_reading_process_output): Bypass select if
4363 waiting for a cell while ignoring keyboard input, and input is
4364 pending. Suggested by Jan Djärv (Bug#8869).
4366 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4368 Use gnulib's dup2 module instead of rolling our own.
4369 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4371 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4373 * dispnew.c (scrolling_window): Before scrolling, turn off a
4374 mouse-highlight in the window being scrolled.
4376 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4378 Move DEFSYM to lisp.h and use everywhere.
4380 * character.h (DEFSYM): Move declaration...
4381 * lisp.h (DEFSYM): ...here.
4387 * w32select.c: Don't include character.h.
4389 * alloc.c (syms_of_alloc):
4390 * buffer.c (syms_of_buffer):
4391 * bytecode.c (syms_of_bytecode):
4392 * callint.c (syms_of_callint):
4393 * casefiddle.c (syms_of_casefiddle):
4394 * casetab.c (init_casetab_once):
4395 * category.c (init_category_once, syms_of_category):
4396 * ccl.c (syms_of_ccl):
4397 * cmds.c (syms_of_cmds):
4398 * composite.c (syms_of_composite):
4399 * dbusbind.c (syms_of_dbusbind):
4400 * dired.c (syms_of_dired):
4401 * dispnew.c (syms_of_display):
4402 * doc.c (syms_of_doc):
4403 * editfns.c (syms_of_editfns):
4404 * emacs.c (syms_of_emacs):
4405 * eval.c (syms_of_eval):
4406 * fileio.c (syms_of_fileio):
4407 * fns.c (syms_of_fns):
4408 * frame.c (syms_of_frame):
4409 * fringe.c (syms_of_fringe):
4410 * insdel.c (syms_of_insdel):
4411 * keymap.c (syms_of_keymap):
4412 * lread.c (init_obarray, syms_of_lread):
4413 * macros.c (syms_of_macros):
4414 * msdos.c (syms_of_msdos):
4415 * print.c (syms_of_print):
4416 * process.c (syms_of_process):
4417 * search.c (syms_of_search):
4418 * sound.c (syms_of_sound):
4419 * syntax.c (init_syntax_once, syms_of_syntax):
4420 * terminal.c (syms_of_terminal):
4421 * textprop.c (syms_of_textprop):
4422 * undo.c (syms_of_undo):
4423 * w32.c (globals_of_w32):
4424 * window.c (syms_of_window):
4425 * xdisp.c (syms_of_xdisp):
4426 * xfaces.c (syms_of_xfaces):
4427 * xfns.c (syms_of_xfns):
4428 * xmenu.c (syms_of_xmenu):
4429 * xsettings.c (syms_of_xsettings):
4430 * xterm.c (syms_of_xterm): Use DEFSYM.
4432 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4434 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4436 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4438 Integer and buffer overflow fixes (Bug#8873).
4440 * print.c (printchar, strout): Check for string overflow.
4441 (PRINTPREPARE, printchar, strout):
4442 Don't set size unless allocation succeeds.
4444 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4445 for sizes. Check for string overflow more accurately.
4446 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4448 * macros.c: Integer and buffer overflow fixes.
4449 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4450 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4451 Use ptrdiff_t, not int, for sizes.
4452 Don't increment bufsize until after realloc succeeds.
4453 Check for size-calculation overflow.
4454 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4456 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4458 * lread.c: Integer overflow fixes.
4459 (read_integer): Radix is now EMACS_INT, not int,
4460 to improve quality of diagnostics for out-of-range radices.
4461 Calculate buffer size correctly for out-of-range radices.
4462 (read1): Check for integer overflow in radices, and in
4463 read-circle numbers.
4464 (read_escape): Avoid int overflow.
4465 (Fload, openp, read_buffer_size, read1)
4466 (substitute_object_recurse, read_vector, read_list, map_obarray):
4467 Use ptrdiff_t, not int, for sizes.
4468 (read1): Use EMACS_INT, not int, for sizes.
4469 Check for size overflow.
4471 * image.c (cache_image): Check for size arithmetic overflow.
4473 * lread.c: Integer overflow issues.
4474 (saved_doc_string_size, saved_doc_string_length)
4475 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4476 Now ptrdiff_t, not int.
4477 (read1): Don't assume doc string length fits in int. Check for
4478 out-of-range doc string lengths.
4479 (read_list): Don't assume file position fits in int.
4480 (read_escape): Check for hex character overflow.
4482 2011-06-22 Leo Liu <sdl.web@gmail.com>
4484 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4485 Move to minibuffer.el.
4487 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4489 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4490 The following patches are for when GLYPH_DEBUG && !XASSERT.
4491 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4492 * dispnew.c (flush_stdout):
4493 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4494 Mark as externally visible.
4495 * dispnew.c (check_window_matrix_pointers): Now static.
4496 * dispnew.c (window_to_frame_vpos):
4497 * xfns.c (unwind_create_frame):
4498 * xterm.c (x_check_font): Remove unused local.
4499 * scroll.c (CHECK_BOUNDS):
4500 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4501 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4502 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4503 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4504 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4506 (debug_method_add): Use va_list and vsprintf rather than relying
4507 on undefined behavior with wrong number of arguments.
4508 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4509 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4510 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4511 since we're not interested in debugging glyphs with old libraries.
4512 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4513 GCC 4.6.0's static checking.
4515 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4517 Integer overflow and signedness fixes (Bug#8873).
4518 A few related buffer overrun fixes, too.
4520 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4522 * dispextern.h (struct face.stipple):
4523 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4524 (x_bitmap_mask, x_allocate_bitmap_record)
4525 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4526 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4527 (x_create_bitmap_from_xpm_data):
4528 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4529 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4531 * xfaces.c (load_pixmap):
4532 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4533 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4534 (.bitmaps_last, struct x_output.icon_bitmap):
4535 Use ptrdiff_t, not int, for bitmap indexes.
4536 (x_allocate_bitmap_record): Check for size overflow.
4537 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4539 Use ptrdiff_t, not int, for overlay counts.
4540 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4541 * editfns.c (overlays_around, get_pos_property):
4542 * textprop.c (get_char_property_and_overlay):
4543 * xdisp.c (next_overlay_change, note_mouse_highlight):
4544 * xfaces.c (face_at_buffer_position):
4545 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4546 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4547 (Fnext_overlay_change, Fprevious_overlay_change)
4548 (mouse_face_overlay_overlaps, Foverlays_in):
4549 Use ptrdiff_t, not int, for sizes.
4550 (overlays_at, overlays_in): Check for size-calculation overflow.
4552 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4554 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4555 (x_session_initialize): Do not assume string length fits in int.
4557 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4558 This is unlikely, but can occur if DPI is outlandish.
4560 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4561 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4563 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4564 * xrdb.c (magic_file_p, search_magic_path):
4565 Omit last arg SUFFIX; it was always 0. All callers changed.
4566 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4568 * xfont.c (xfont_match): Avoid need for strlen.
4570 * xfns.c: Don't assume strlen fits in int.
4571 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4573 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4574 not unsigned long, as we prefer signed integers. All callers changed.
4575 Detect integer overflow in repeat count.
4576 (message_dolog): Don't assume print length fits in 39 bytes.
4577 (display_mode_element): Don't assume strlen fits in int.
4579 * termcap.c: Don't assume sizes fit in int and never overflow.
4580 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4581 (gobble_line): Check for size-calculation overflow.
4583 * minibuf.c (Fread_buffer):
4584 * lread.c (intern, intern_c_string):
4585 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4586 Don't assume string length fits in int.
4588 * keyboard.c (parse_tool_bar_item):
4589 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4591 * font.c: Don't assume string length fits in int.
4592 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4593 Use ptrdiff_t, not int.
4594 (font_intern_prop): Don't assume string length fits in int.
4595 Don't assume integer property fits in fixnum.
4596 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4598 * filelock.c: Fix some buffer overrun and integer overflow issues.
4599 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4600 Reformulate so as not to need the command string.
4601 Invoke gzip -cd rather than gunzip, as it's more portable.
4602 (lock_info_type, lock_file_1, lock_file):
4603 Don't assume pid_t and time_t fit in unsigned long.
4604 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4605 (current_lock_owner): Prefer signed type for sizes.
4606 Use memcpy, not strncpy, where memcpy is what is really wanted.
4607 Don't assume (via atoi) that time_t and pid_t fit in int.
4608 Check for time_t and/or pid_t out of range, e.g., via a network share.
4609 Don't alloca where an auto var works fine.
4611 * fileio.c: Fix some integer overflow issues.
4612 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4613 Don't assume string length fits in int.
4614 (directory_file_name): Don't assume string length fits in long.
4615 (make_temp_name): Don't assume pid fits in int, or that its print
4616 length is less than 20.
4618 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4620 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4622 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4624 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4625 We prefer signed integers, even for size calculations.
4627 * emacs.c: Don't assume string length fits in 'int'.
4628 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4629 (main): Don't invoke strlen when not needed.
4631 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4632 (XD_DEBUG_MESSAGE): Don't waste a byte.
4634 * callproc.c (getenv_internal_1, getenv_internal)
4636 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4638 * lread.c (invalid_syntax): Omit length argument.
4639 All uses changed. This doesn't fix a bug, but it simplifies the
4640 code away from its former Hollerith-constant appearance, and it's
4641 one less 'int' to worry about when looking at integer-overflow issues.
4642 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4644 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4645 This didn't break anything, but it didn't help either.
4646 It's confusing to put a bogus integer in a place where the actual
4647 value does not matter.
4648 (LIST_END_P): Remove unused macro and its bogus comment.
4649 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4651 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4652 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4654 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4655 We prefer signed types, and the value cannot exceed the EMACS_INT
4656 range anyway (because otherwise the length would not be representable).
4657 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4658 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4659 This avoids a GCC warning when WIDE_EMACS_INT.
4661 * indent.c (sane_tab_width): New function.
4662 (current_column, scan_for_column, Findent_to, position_indentation)
4663 (compute_motion): Use it. This is just for clarity.
4664 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4666 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4668 * lisp.h (lint_assume): New macro.
4669 * composite.c (composition_gstring_put_cache):
4670 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4672 * editfns.c, insdel.c:
4673 Omit unnecessary forward decls, to simplify future changes.
4675 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4677 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4679 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4680 Use much-faster test for byte-length change.
4681 Don't assume string byte-length fits in 'int'.
4682 Check that character arg fits in 'int'.
4683 (mapcar1): Declare byte as byte, for clarity.
4685 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4687 * fns.c (concat): Catch string overflow earlier.
4688 Do not rely on integer wraparound.
4690 * dispextern.h (struct it.overlay_strings_charpos)
4691 (struct it.selective): Now EMACS_INT, not int.
4692 * xdisp.c (forward_to_next_line_start)
4693 (back_to_previous_visible_line_start)
4694 (reseat_at_next_visible_line_start, next_element_from_buffer):
4695 Don't arbitrarily truncate the value of 'selective' to int.
4697 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4699 * composite.c: Don't truncate sizes to 'int'.
4700 (composition_gstring_p, composition_reseat_it)
4701 (composition_adjust_point): Use EMACS_INT, not int.
4702 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4703 not EMACS_UINT, for indexes.
4705 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4707 * buffer.c: Include <verify.h>.
4708 (struct sortvec.priority, struct sortstr.priority):
4709 Now EMACS_INT, not int.
4710 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4711 (struct sortstr.size, record_overlay_string)
4712 (struct sortstrlist.size, struct sortlist.used):
4713 Don't truncate size to int.
4714 (record_overlay_string): Check for size-calculation overflow.
4715 (init_buffer_once): Check at compile-time, not run-time.
4717 2011-06-22 Jim Meyering <meyering@redhat.com>
4719 Don't leak an XBM-image-sized buffer
4720 * image.c (xbm_load): Free the image buffer after using it.
4722 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4725 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4726 that Sun C diagnosed.
4727 * fns.c (secure_hash): Fix pointer signedness issue.
4728 * intervals.c (static_offset_intervals): New function.
4729 (offset_intervals): Use it.
4731 2011-06-21 Leo Liu <sdl.web@gmail.com>
4734 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4737 * fns.c (secure_hash): Rename from crypto_hash_function and change
4738 the first arg to accept symbols.
4739 (Fsecure_hash): New primitive.
4740 (syms_of_fns): New symbols.
4742 2011-06-20 Deniz Dogan <deniz@dogan.se>
4744 * process.c (Fset_process_buffer): Clarify return value in
4747 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4749 * dispnew.c (add_window_display_history): Use BVAR.
4751 * xdisp.c (debug_method_add): Use BVAR.
4752 (check_window_end, dump_glyph_matrix, dump_glyph)
4753 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4755 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4758 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4759 check till after the cache is created in init_frame_faces.
4761 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4763 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4765 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4767 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4768 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4769 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4771 Improve buffer-overflow checking (Bug#8873).
4772 * fileio.c (Finsert_file_contents):
4773 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4774 Remove the old (too-loose) buffer overflow checks.
4775 They weren't needed, since make_gap checks for buffer overflow.
4776 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4777 The old code merely checked for Emacs fixnum overflow, and relied
4778 on undefined (wraparound) behavior. The new code avoids undefined
4779 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4781 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4782 Tune. Don't use wider integers than needed. Don't use alloca.
4783 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4785 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4787 * insdel.c, lisp.h (buffer_overflow): New function.
4788 (insert_from_buffer_1, replace_range, replace_range_2):
4789 * insdel.c (make_gap_larger):
4790 * editfns.c (Finsert_char):
4791 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4793 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4795 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4797 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
4799 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4800 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4802 * fileio.c: Don't assume EMACS_INT fits in off_t.
4803 (emacs_lseek): New static function.
4804 (Finsert_file_contents, Fwrite_region): Use it.
4805 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4807 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4809 * fns.c: Don't overflow int when computing a list length.
4810 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4811 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4812 truncation on 64-bit hosts. Check for QUIT every
4813 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4814 faster and is responsive enough.
4815 (Flength): Report an error instead of overflowing an integer.
4816 (Fsafe_length): Return a float if the value is not representable
4817 as a fixnum. This shouldn't happen except in contrived situations.
4818 (Fnthcdr, Fsort): Don't assume list length fits in int.
4819 (Fcopy_sequence): Don't assume vector length fits in int.
4821 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4822 (header_size, word_size): New constants.
4823 (allocate_vectorlike): Don't check size overflow here.
4824 (allocate_vector): Check it here instead, since this is the only
4825 caller of allocate_vectorlike that could cause overflow.
4826 Check that the new vector's length is representable as a fixnum.
4828 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4829 The previous code was bogus. For example, next_almost_prime (32)
4830 returned 39, which is undesirable as it is a multiple of 3; and
4831 next_almost_prime (24) returned 25, which is a multiple of 5 so
4832 why was the code bothering to check for multiples of 7?
4834 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4836 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4838 Variadic C functions now count arguments with ptrdiff_t.
4839 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4840 Back then I didn't know that the Emacs coding style prefers signed int.
4841 Also, in the meantime I found a few more instances where arguments
4842 were being counted with int, which may truncate counts on 64-bit
4843 machines, or EMACS_INT, which may be unnecessarily wide.
4844 * lisp.h (struct Lisp_Subr.function.aMANY)
4845 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4846 Arg counts are now ptrdiff_t, not size_t.
4847 All variadic functions and their callers changed accordingly.
4848 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4849 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4850 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4851 * callint.c (Fcall_interactively): Check arg count for overflow,
4852 to avoid potential buffer overrun. Use signed char, not 'int',
4853 for 'varies' array, so that we needn't bother to check its size
4854 calculation for overflow.
4855 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4856 * eval.c (apply_lambda):
4857 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4858 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4859 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4861 * callint.c (Fcall_interactively): Don't use index var as event count.
4863 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4864 * mem-limits.h (SIZE): Remove; no longer used.
4866 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4868 Remove unnecessary casts.
4869 * xterm.c (x_term_init):
4870 * xfns.c (x_set_border_pixel):
4871 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4872 These aren't needed now that we assume ANSI C.
4874 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4875 It's more likely to cause problems (due to unsigned overflow)
4878 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4880 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4882 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4884 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4886 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4888 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4890 GLYPH_CODE_FACE returns EMACS_INT, not int.
4891 * dispextern.h (merge_faces):
4892 * xfaces.c (merge_faces):
4893 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4894 Don't assume EMACS_INT fits in int.
4896 * character.h (CHAR_VALID_P): Remove unused parameter.
4897 * fontset.c, lisp.h, xdisp.c: All uses changed.
4899 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4901 * fns.c (concat): Minor tuning based on overflow analysis.
4902 This doesn't fix any bugs. Use int to hold character, instead
4903 of constantly refetching from Emacs object. Use XFASTINT, not
4904 XINT, for value known to be a character. Don't bother comparing
4905 a single byte to 0400, as it's always less.
4907 * floatfns.c (Fexpt):
4908 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4910 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4913 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4915 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4916 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4917 incorrectly succeed when S was a string, because 4294967386 was
4918 truncated before it was used.
4920 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4921 Otherwise, an out-of-range integer could cause undefined behavior
4924 * composite.c: Use int, not EMACS_INT, for characters.
4925 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4926 EMACS_INT, for values that are known to be in character range.
4927 This doesn't fix any bugs but is the usual style inside Emacs and
4928 may generate better code on 32-bit machines.
4930 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4931 This is for reasons similar to the recent CHAR_STRING fix.
4932 * charset.c (Fencode_char): Check that character arg is actually
4933 a character. Pass an int to ENCODE_CHAR.
4934 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4935 wider than 'int', as a compile-time check to prevent future regressions
4938 * character.c (char_string): Remove unnecessary casts.
4940 Make sure a 64-bit char is never passed to CHAR_STRING.
4941 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4942 by silently ignoring the top 32 bits, allowing some values
4943 that were far too large to be valid characters.
4944 * character.h: Include <verify.h>.
4945 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4946 arguments are no wider than unsigned, as a compile-time check
4947 to prevent future regressions in this area.
4949 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4950 (Fsubst_char_in_region):
4952 * xdisp.c (decode_mode_spec_coding):
4953 Adjust to CHAR_STRING's new requirement.
4954 * editfns.c (Finsert_char, Fsubst_char_in_region):
4955 * fns.c (concat): Check that character args are actually
4956 characters. Without this test, these functions did the wrong
4957 thing with wildly out-of-range values on 64-bit hosts.
4959 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4960 These casts should not be needed on 32-bit hosts, either.
4961 * keyboard.c (read_char):
4962 * lread.c (Fload): Remove casts to unsigned.
4964 * lisp.h (UNSIGNED_CMP): New macro.
4965 This fixes comparison bugs on 64-bit hosts.
4966 (ASCII_CHAR_P): Use it.
4967 * casefiddle.c (casify_object):
4968 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4969 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4970 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4971 * dispextern.h (FACE_FROM_ID):
4972 * keyboard.c (read_char): Use UNSIGNED_CMP.
4974 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4975 not to EMACS_INT, to avoid GCC warning.
4977 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4979 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4980 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4981 isn't needed on 32-bit machines.
4983 * buffer.c (Fgenerate_new_buffer_name):
4984 Use EMACS_INT for count, not int.
4985 (advance_to_char_boundary): Return EMACS_INT, not int.
4987 * data.c (Qcompiled_function): Now static.
4989 * window.c (window_body_lines): Now static.
4991 * image.c (gif_load): Rename local to avoid shadowing.
4993 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4994 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4995 * alloc.c (make_save_value): Integer argument is now of type
4997 (mark_object): Use ptrdiff_t, not int.
4998 * lisp.h (pD): New macro.
4999 * print.c (print_object): Use it.
5001 * alloc.c: Use EMACS_INT, not int, to count objects.
5002 (total_conses, total_markers, total_symbols, total_vector_size)
5003 (total_free_conses, total_free_markers, total_free_symbols)
5004 (total_free_floats, total_floats, total_free_intervals)
5005 (total_intervals, total_strings, total_free_strings):
5006 Now EMACS_INT, not int. All uses changed.
5007 (Fgarbage_collect): Compute overall total using a double, so that
5008 integer overflow is less likely to be a problem. Check for overflow
5009 when converting back to an integer.
5010 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5011 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5012 These were 'int' variables that could overflow on 64-bit hosts;
5013 they were never used, so remove them instead of repairing them.
5014 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5015 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5016 Previously, this ceilinged at INT_MAX, but that doesn't work on
5018 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5020 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5021 (allocate_vectorlike): Check for ptrdiff_t overflow.
5022 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5023 when a (possibly-narrower) signed value would do just as well.
5024 We prefer using signed arithmetic, to avoid comparison confusion.
5026 * alloc.c: Catch some string size overflows that we were missing.
5027 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5028 for convenience in STRING_BYTES_MAX.
5029 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5030 The definition here is exact; the one in lisp.h was approximate.
5031 (allocate_string_data): Check for string overflow. This catches
5032 some instances we weren't catching before. Also, it catches
5033 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5034 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5035 and ptrdiff_t and EMACS_INT are both 64 bits.
5037 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5038 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5039 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5041 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5043 * alloc.c (Fmake_string): Check for out-of-range init.
5045 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5047 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5049 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5051 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5052 xg_get_default_scrollbar_width.
5054 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5055 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5056 (style_changed_cb): Call update_theme_scrollbar_width and call
5057 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5058 all frames (Bug#8505).
5059 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5060 Call gtk_window_set_resizable if HAVE_GTK3.
5061 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5062 and height if HAVE_GTK3 (Bug#8505).
5063 (scroll_bar_width_for_theme): New variable.
5064 (update_theme_scrollbar_width): New function.
5065 (xg_get_default_scrollbar_width): Move code to
5066 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5067 (xg_initialize): Call update_theme_scrollbar_width.
5069 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5071 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5073 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5075 * frame.c (make_frame): Call other_buffer_safely instead of
5078 * window.c (temp_output_buffer_show): Call display_buffer with
5079 second argument Vtemp_buffer_show_specifiers and reset latter
5080 immediately after the call.
5081 (Vtemp_buffer_show_specifiers): New variable.
5082 (auto_window_vscroll_p, next_screen_context_lines)
5083 (Vscroll_preserve_screen_position): Remove leading asterisks from
5086 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5088 Fix minor problems found by GCC 4.6.0 static checking.
5089 * buffer.c (Qclone_number): Remove for now, as it's unused.
5090 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5091 (record_buffer): Remove unused local.
5092 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5093 (set_frame_buffer_list): Remove; unused.
5094 * frame.h (other_visible_frames): Remove decl.
5095 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5096 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5097 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5099 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5100 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5101 Define only if HAVE_GPM.
5102 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5103 (update_hints_inhibit): Remove; never set. All uses removed.
5104 * widgetprv.h (emacsFrameClassRec): Remove decl.
5105 * window.c (delete_deletable_window): Now returns void, since it
5106 wasn't returning anything.
5107 (compare_window_configurations): Remove unused locals.
5108 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5109 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5110 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5111 the same widths as pointers. This follows up on the 2011-05-06 patch.
5112 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5113 * xterm.h: Likewise.
5114 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5116 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5118 * makefile.w32-in: Update dependencies.
5119 (LISP_H): Add lib/intprops.h.
5121 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5123 * image.c (gif_load): Add animation frame delay to the metadata.
5124 (syms_of_image): Use DEFSYM. New symbol `delay'.
5126 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5128 * window.c (delete_deletable_window): Re-add.
5129 (Fset_window_configuration): Rewrite to handle dead buffers and
5130 consequently deletable windows.
5131 (window_tree, Fwindow_tree): Remove. Supply functionality in
5133 (compare_window_configurations): Simplify code.
5135 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5137 * image.c (imagemagick_load_image): Fix type mismatch.
5138 (Fimagemagick_types): Likewise.
5140 * window.h (replace_buffer_in_windows): Declare.
5142 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5144 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5145 Qclone_number. Remove external declaration of Qdelete_window.
5146 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5148 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5149 Run Qbuffer_list_update_hook if allowed.
5150 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5151 buffer list implementation.
5152 (other_buffer_safely): New function.
5153 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5154 calls to replace_buffer_in_windows and
5155 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5157 (record_buffer): Inhibit quitting and rewrite using quittable
5158 functions. Run Qbuffer_list_update_hook if allowed.
5159 (Frecord_buffer, Funrecord_buffer): New functions.
5160 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5161 Move switch-to-buffer to window.el.
5162 (bury-buffer): Move to window.el.
5163 (Vbuffer_list_update_hook): New variable.
5165 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5168 * window.h (resize_frame_windows): Move up in code.
5169 (Fwindow_frame): Remove EXFUN.
5170 (replace_buffer_in_all_windows): Remove prototype.
5171 (replace_buffer_in_windows_safely): Add prototype.
5173 * window.c: Declare Qdelete_window static again. Move down
5174 declaration of select_count.
5175 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5176 (Fother_window): Move to window.el.
5177 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5178 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5179 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5181 (replace_buffer_in_windows): Implement by calling
5182 Qreplace_buffer_in_windows.
5183 (replace_buffer_in_all_windows): Remove with some functionality
5184 moved into replace_buffer_in_windows_safely.
5185 (replace_buffer_in_windows_safely): New function.
5186 (select_window_norecord, select_frame_norecord): Move in front
5187 of run_window_configuration_change_hook. Remove now obsolete
5189 (Fset_window_buffer): Rewrite doc-string.
5190 Call Qrecord_window_buffer.
5191 (keys_of_window): Move binding for other-window to window.el.
5193 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5195 * dispextern.h (struct image): Replace data member, whose int_val
5196 and ptr_val fields were not used by anything, with a single
5199 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5200 (gif_clear_image, gif_load, imagemagick_load_image)
5201 (gs_clear_image, gs_load): Callers changed.
5203 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5205 * buffer.h: Include <time.h>, for time_t.
5206 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5208 Fix minor problems found by static checking.
5210 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5212 Make identifiers static if they are not used in other modules.
5213 * data.c (Qcompiled_function, Qframe, Qvector):
5214 * image.c (QimageMagick, Qsvg):
5215 * minibuf.c (Qmetadata):
5216 * window.c (resize_window_check, resize_root_window): Now static.
5217 * window.h (resize_window_check, resize_root_window): Remove decls.
5219 * window.c (window_deletion_count, delete_deletable_window):
5221 (window_body_lines): Now static.
5222 (Fdelete_other_windows_internal): Mark vars as initialized.
5223 Make sure 'resize_failed' is initialized.
5224 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5225 (resize_window_apply): Remove unused local.
5226 * window.h (delete_deletable_window): Remove decl.
5228 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5229 (imagemagick_load_image): Fix pointer signedness problem by changing
5230 last arg from unsigned char * to char *. All uses changed.
5231 Also, fix a local for similar reasons.
5232 Remove unused locals. Remove locals to avoid shadowing.
5233 (fn_rsvg_handle_free): Remove; unused.
5234 (svg_load, svg_load_image): Fix pointer signedness problem.
5235 (imagemagick_load_image): Don't use garbage pointer image_wand.
5237 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5239 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5241 * image.c (gif_load): Fix omitted cast error introduced by
5244 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5246 * window.h (resize_proportionally, orig_total_lines)
5247 (orig_top_line): Remove from window structure.
5248 (set_window_height, set_window_width, change_window_heights)
5249 (Fdelete_window): Remove prototypes.
5250 (resize_frame_windows): Remove duplicate declaration.
5252 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5254 * window.h (resize_frame_windows, resize_window_check)
5255 (delete_deletable_window, resize_root_window)
5256 (resize_frame_windows): Declare prototypes.
5258 * window.c (resize_window_apply): Make definition be "static" to
5259 match the prototype.
5261 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5263 * window.c: Remove declarations of Qwindow_size_fixed,
5264 window_min_size_1, window_min_size_2, window_min_size,
5265 size_window, window_fixed_size_p, enlarge_window, delete_window.
5266 Remove static from declaration of Qdelete_window, it's
5267 temporarily needed by Fbury_buffer.
5268 (replace_window): Don't assign orig_top_line and
5270 (Fdelete_window, delete_window): Remove. Window deletion is
5271 handled by window.el.
5272 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5273 Replace Fdelete_window calls with calls to Qdelete_window.
5274 (Fdelete_other_windows): Remove. Deleting other windows is
5275 handled by window.el.
5276 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5277 handled in window.el.
5278 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5279 Window minimum sizes are handled in window.el.
5280 (shrink_windows, size_window, set_window_height)
5281 (set_window_width, change_window_heights, window_height)
5282 (window_width, CURBEG, CURSIZE, enlarge_window)
5283 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5284 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5285 handled in window.el.
5286 (make_dummy_parent): Rename to make_parent_window and give it a
5287 second argument horflag.
5288 (make_window): Don't set resize_proportionally any more.
5289 (Fsplit_window): Remove. Windows are split in window.el.
5290 (save_restore_action, save_restore_orig_size)
5291 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5292 Resize mini windows in window.el.
5293 (grow_mini_window, shrink_mini_window): Implement by calling
5294 Qresize_root_window_vertically, resize_window_check and
5295 resize_window_apply.
5296 (saved_window, Fset_window_configuration, save_window_save):
5297 Do not handle orig_top_line, orig_total_lines, and
5298 resize_proportionally.
5299 (window_min_height, window_min_width): Move to window.el.
5300 (keys_of_window): Move bindings for delete-other-windows,
5301 split-window, delete-window and enlarge-window to window.el.
5303 * buffer.c: Temporarily extern Qdelete_window.
5304 (Fbury_buffer): Temporarily call Qdelete_window instead of
5305 Fdelete_window (Fbury_buffer will move to window.el soon).
5307 * frame.c (set_menu_bar_lines_1): Remove code handling
5308 orig_top_line and orig_total_lines.
5310 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5311 set_window_height but set heights directly.
5312 (change_frame_size_1): Use resize_frame_windows.
5314 * xdisp.c (init_xdisp): Don't use set_window_height but set
5317 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5318 Use resize_frame_windows instead of change_window_heights and run
5319 run_window_configuration_change_hook.
5321 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5322 instead of change_window_heights and run
5323 run_window_configuration_change_hook.
5325 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5327 * window.c (replace_window): Rename second argument REPLACEMENT to
5328 NEW. New third argument SETFLAG. Rewrite.
5329 (delete_window, make_dummy_parent): Call replace_window with
5331 (window_list_1): Move down in code.
5332 (run_window_configuration_change_hook): Move set_buffer part
5333 before select_frame_norecord part in order to unwind correctly.
5334 Rename count1 to count.
5335 (recombine_windows, delete_deletable_window, resize_root_window)
5336 (Fdelete_other_windows_internal)
5337 (Frun_window_configuration_change_hook, make_parent_window)
5338 (resize_window_check, resize_window_apply, Fresize_window_apply)
5339 (resize_frame_windows, Fsplit_window_internal)
5340 (Fdelete_window_internal, Fresize_mini_window_internal):
5342 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5344 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5346 * window.h (window): Add some new members to window structure -
5347 normal_lines, normal_cols, new_total, new_normal, clone_number,
5348 splits, nest, prev_buffers, next_buffers.
5349 (WINDOW_TOTAL_SIZE): Move here from window.c.
5350 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5352 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5354 (make_dummy_parent): Set new members of windows structure.
5355 (make_window): Move down in code. Handle new members of window
5357 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5358 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5359 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5360 (Fset_window_prev_buffers, Fwindow_next_buffers)
5361 (Fset_window_next_buffers, Fset_window_clone_number):
5363 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5364 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5366 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5367 Argument WINDOW can be now internal window too.
5368 (Fwindow_use_time): Move up in code.
5369 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5371 (Fset_window_configuration, saved_window)
5372 (Fcurrent_window_configuration, save_window_save): Handle new
5373 members of window structure.
5374 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5375 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5376 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5377 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5378 Qget_mru_window, Qresize_root_window,
5379 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5380 Qauto_buffer_name; staticpro them.
5382 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5384 * window.c (Fwindow_total_size, Fwindow_left_column)
5385 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5386 (Fwindow_list_1): New functions.
5387 (window_box_text_cols): Replace with window_body_cols.
5388 (Fwindow_width, Fscroll_left, Fscroll_right):
5389 Use window_body_cols instead of window_box_text_cols.
5390 (delete_window, Fset_window_configuration):
5391 Call delete_all_subwindows with window as argument.
5392 (delete_all_subwindows): Take a window as argument and not a
5394 (window_loop): Remove handling of GET_LRU_WINDOW and
5396 (Fget_lru_window, Fget_largest_window): Move to window.el.
5398 * window.h: Extern window_body_cols instead of
5399 window_box_text_cols. delete_all_subwindows now takes a
5400 Lisp_Object as argument.
5402 * indent.c (compute_motion, Fcompute_motion):
5403 Use window_body_cols instead of window_box_text_cols.
5405 * frame.c (delete_frame): Call delete_all_subwindows with root
5408 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5410 * fns.c (Fputhash): Document return value.
5412 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5414 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5416 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5418 Cons<->int and similar integer overflow fixes (Bug#8794).
5420 Check for overflow when converting integer to cons and back.
5421 * charset.c (Fdefine_charset_internal, Fdecode_char):
5422 Use cons_to_unsigned to catch overflow.
5423 (Fencode_char): Use INTEGER_TO_CONS.
5424 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5425 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5426 * data.c (long_to_cons, cons_to_long): Remove.
5427 (cons_to_unsigned, cons_to_signed): New functions.
5428 These signal an error for invalid or out-of-range values.
5429 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5430 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5431 * font.c (Ffont_variation_glyphs):
5432 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5433 * lisp.h: Include <intprops.h>.
5434 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5435 (cons_to_signed, cons_to_unsigned): New decls.
5436 (long_to_cons, cons_to_long): Remove decls.
5437 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5438 (Fprimitive_undo): Use CONS_TO_INTEGER.
5439 * xfns.c (Fx_window_property): Likewise.
5440 * xselect.c: Include <limits.h>.
5441 (x_own_selection, selection_data_to_lisp_data):
5442 Use INTEGER_TO_CONS.
5443 (x_handle_selection_request, x_handle_selection_clear)
5444 (x_get_foreign_selection, Fx_disown_selection_internal)
5445 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5446 (lisp_data_to_selection_data): Use cons_to_unsigned.
5447 (x_fill_property_data): Use cons_to_signed.
5448 Report values out of range.
5450 Check for buffer and string overflow more precisely.
5451 * buffer.h (BUF_BYTES_MAX): New macro.
5452 * lisp.h (STRING_BYTES_MAX): New macro.
5453 * alloc.c (Fmake_string):
5454 * character.c (string_escape_byte8):
5455 * coding.c (coding_alloc_by_realloc):
5456 * doprnt.c (doprnt):
5457 * editfns.c (Fformat):
5459 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5460 since they may not be the same number.
5461 * editfns.c (Finsert_char):
5462 * fileio.c (Finsert_file_contents):
5463 Likewise for BUF_BYTES_MAX.
5465 * image.c: Use ptrdiff_t, not int, for sizes.
5466 (slurp_file): Switch from int to ptrdiff_t.
5468 (slurp_file): Check that file size fits in both size_t (for
5469 malloc) and ptrdiff_t (for sanity and safety).
5471 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5472 if b->modtime has its maximal value.
5474 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5476 Don't assume time_t can fit into int.
5477 * buffer.h (struct buffer.modtime): Now time_t, not int.
5478 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5479 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5481 Minor fixes for signed vs unsigned integers.
5482 * character.h (MAYBE_UNIFY_CHAR):
5483 * charset.c (maybe_unify_char):
5484 * keyboard.c (read_char, reorder_modifiers):
5485 XINT -> XFASTINT, since the integer must be nonnegative.
5486 * ftfont.c (ftfont_spec_pattern):
5487 * keymap.c (access_keymap, silly_event_symbol_error):
5488 XUINT -> XFASTINT, since the integer must be nonnegative.
5489 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5490 since it makes no difference and we prefer signed.
5491 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5492 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5495 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5497 * window.h (Fwindow_frame): Declare.
5499 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5501 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5502 (SPARE_MEMORY): Always define.
5503 (LARGE_REQUEST): Remove.
5504 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5506 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5508 * lisp.h: Move EXFUNS for Fframe_root_window,
5509 Fframe_first_window and Fset_frame_selected_window to window.h.
5511 * window.h: Move EXFUNS for Fframe_root_window,
5512 Fframe_first_window and Fset_frame_selected_window here from
5515 * frame.c (Fwindow_frame, Fframe_first_window)
5516 (Fframe_root_window, Fframe_selected_window)
5517 (Fset_frame_selected_window): Move to window.c.
5518 (Factive_minibuffer_window): Move to minibuf.c.
5519 (Fother_visible_frames_p): New function.
5521 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5523 * window.c (decode_window, decode_any_window): Move up in code.
5524 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5525 (inhibit_frame_unsplittable): Remove unused variable.
5526 (Fwindow_buffer): Move up and rewrite doc-string.
5527 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5528 (Fwindow_prev): New functions.
5529 (Fwindow_frame): Move here from frame.c. Accept any window as
5531 (Fframe_root_window, Fframe_first_window)
5532 (Fframe_selected_window): Move here from frame.c. Accept frame
5533 or arbitrary window as argument. Update doc-strings.
5534 (Fminibuffer_window): Move up in code.
5535 (Fwindow_minibuffer_p): Move up in code and simplify.
5536 (Fset_frame_selected_window): Move here from frame.c.
5538 (Fselected_window, select_window, Fselect_window): Move up in
5539 code. Minor doc-string fixes.
5541 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5543 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5544 Do not assume that spare memory exists; that assumption is valid
5545 only if SYSTEM_MALLOC.
5546 (LARGE_REQUEST): New macro, so that the issue of large requests
5547 is separated from the issue of spare memory.
5549 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5551 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5554 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5556 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5559 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5561 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5563 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5565 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5566 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5568 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5570 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5572 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5574 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5575 (x_clipboard_manager_save): Add return value.
5576 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5578 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5579 Obey Vx_select_enable_clipboard_manager. Catch errors in
5580 x_clipboard_manager_save (Bug#8779).
5581 (Vx_select_enable_clipboard_manager): New variable.
5582 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5584 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5586 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5588 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5590 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5591 in the current matrix if keep_current_p is non-zero.
5593 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5595 * bidi.c (bidi_level_of_next_char): Fix last change.
5597 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5599 Support bidi reordering of text covered by display properties.
5601 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5602 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5603 (bidi_cache_search, bidi_cache_iterator_state)
5604 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5605 (bidi_level_of_next_char, bidi_move_to_visually_next):
5606 Support character positions inside a run of characters covered by a
5608 (bidi_paragraph_init, bidi_resolve_explicit_1)
5609 (bidi_level_of_next_char): Call bidi_fetch_char and
5610 bidi_fetch_char_advance instead of FETCH_CHAR and
5612 (bidi_init_it): Initialize new members.
5613 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5615 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5616 instead of using explicit *_CHAR codes.
5617 (bidi_resolve_explicit, bidi_resolve_weak):
5618 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5619 bidirectional text is supported only in multibyte buffers.
5620 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5621 it to initialize the frame_window_p member of struct bidi_it.
5622 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5623 (bidi_resolve_explicit, bidi_resolve_weak)
5624 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5625 bidi_it->nchars is non-positive.
5626 (bidi_level_of_next_char): Don't try to lookup the cache for the
5627 next/previous character if nothing is cached there yet, or if we
5628 were just reseat()'ed to a new position.
5630 * xdisp.c (set_cursor_from_row): Set start and stop points
5631 according to the row's direction when priming the loop that looks
5632 for the glyph on which to display cursor.
5633 (single_display_spec_intangible_p): Function deleted.
5634 (display_prop_intangible_p): Reimplement to call
5635 handle_display_spec instead of single_display_spec_intangible_p.
5636 Accept 3 additional arguments needed by handle_display_spec.
5637 This fixes incorrect cursor motion across display property with complex
5638 values: lists, `(when COND...)' forms, etc.
5639 (single_display_spec_string_p): Support property values that are
5640 lists with the argument STRING its top-level element.
5641 (display_prop_string_p): Fix the condition for processing a
5642 property that is a list to be consistent with handle_display_spec.
5643 (handle_display_spec): New function, refactored from the
5644 last portion of handle_display_prop.
5645 (compute_display_string_pos): Accept additional argument
5646 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5647 value of a `display' property is a "replacing spec".
5648 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5649 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5650 the display property, but just return a value indicating whether
5651 the display property will replace the characters it covers.
5652 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5653 frame_window_p members of struct bidi_it.
5654 (compute_display_string_pos, compute_display_string_end):
5656 (push_it): Accept second argument POSITION, where pop_it should
5657 jump to continue iteration.
5658 (reseat_1): Initialize bidi_it.disp_pos.
5660 * keyboard.c (adjust_point_for_property): Adjust the call to
5661 display_prop_intangible_p to its new signature.
5663 * dispextern.h (struct bidi_it): New member frame_window_p.
5664 (bidi_init_it): Update prototypes.
5665 (display_prop_intangible_p): Update prototype.
5666 (compute_display_string_pos, compute_display_string_end):
5668 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5671 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5673 Malloc failure behavior now depends on size of allocation.
5674 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5675 * lisp.h: Change signatures accordingly.
5676 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5677 All callers changed. (Bug#8762)
5679 * gnutls.c: Use Emacs's memory allocators.
5680 Without this change, the gnutls library would invoke malloc etc.
5681 directly, which causes problems on non-SYNC_INPUT hosts, and which
5682 runs afoul of improving memory_full behavior. (Bug#8761)
5683 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5684 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5685 xfree instead of the default malloc, realloc, free.
5686 (Fgnutls_boot): No need to check for memory allocation failure,
5687 since xmalloc does that for us.
5689 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5690 * category.c (hash_get_category_set):
5691 * ccl.c (ccl_driver):
5692 * charset.c (Fdefine_charset_internal):
5693 * charset.h (struct charset.hash_index):
5694 * composite.c (get_composition_id, gstring_lookup_cache)
5695 (composition_gstring_put_cache):
5696 * composite.h (struct composition.hash_index):
5697 * dispextern.h (struct image.hash):
5698 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5699 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5700 (hashfn_equal, hashfn_user_defined, make_hash_table)
5701 (maybe_resize_hash_table, hash_lookup, hash_put)
5702 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5703 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5704 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5705 * image.c (make_image, search_image_cache, lookup_image)
5706 (xpm_put_color_table_h):
5707 * lisp.h (struct Lisp_Hash_Table):
5708 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5709 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5710 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5711 * alloc.c (allocate_vectorlike):
5712 Check for overflow in vector size calculations.
5713 * ccl.c (ccl_driver):
5714 Check for overflow when converting EMACS_INT to int.
5715 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5716 need to be updated by these changes.
5717 * fns.c (make_hash_table, maybe_resize_hash_table):
5718 Check for integer overflow with large hash tables.
5719 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5720 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5721 (SXHASH_REDUCE): New macro.
5722 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5723 Use it instead of discarding useful hash info with large hash values.
5724 (sxhash_float): New function.
5725 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5726 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5727 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5728 Rewrite to use FIXNUM_BITS, as this simplifies things.
5729 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5730 Adjust signatures to match updated version of code.
5731 (consing_since_gc): Now EMACS_INT, since a single hash table can
5732 use more than INT_MAX bytes.
5734 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5736 Make it possible to build with GCC-4.6+ -O2 -flto.
5738 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5740 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5742 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5743 Call minibuffer-inactive-mode.
5745 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5747 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5748 Update dependencies.
5750 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5752 * data.c (init_data): Remove code for UTS, this system is not
5755 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5757 Don't force ./temacs to start in terminal mode.
5759 * frame.c (make_initial_frame): Initialize faces in all cases, not
5760 only when CANNOT_DUMP is defined.
5761 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5763 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5765 * dispnew.c (add_window_display_history): Use const for the string
5766 pointer. Remove declaration, not needed.
5768 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5770 Use 'inline', not 'INLINE'.
5771 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5772 * alloc.c, fontset.c (INLINE): Remove.
5773 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5774 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5775 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5776 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5777 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5779 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5781 Make it possible to run ./temacs.
5783 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5784 syms_of_callproc does the same thing. Remove test for
5785 "initialized", do it in the caller.
5786 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5788 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5790 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5791 (read_minibuf): Use get_minibuffer.
5792 (syms_of_minibuf): Use DEFSYM.
5793 (Qmetadata): New var.
5794 * data.c (Qbuffer): Don't make it static.
5795 (syms_of_data): Use DEFSYM.
5797 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5799 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5800 (CCL_CODE_MIN): New macro.
5802 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5804 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5806 * eval.c (Qdebug): Now static.
5807 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5808 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5809 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5811 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5813 * image.c: Various fixes to ImageMagick code comments.
5814 (Fimagemagick_types): Doc fix.
5816 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5818 Minor fixes prompted by GCC 4.6.0 warnings.
5820 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5822 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5823 (x_clipboard_manager_save_all): Move extern decl to ...
5824 * xterm.h: ... here, so that it can be checked for consistency.
5826 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5828 * xselect.c (x_clipboard_manager_save_frame)
5829 (x_clipboard_manager_save_all): New functions.
5830 (Fx_clipboard_manager_save): Lisp function deleted.
5832 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5833 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5835 * xterm.h: Update prototype.
5837 2011-05-28 William Xu <william.xwl@gmail.com>
5839 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5842 2011-05-28 Jim Meyering <meyering@redhat.com>
5844 Avoid a sign-extension bug in crypto_hash_function.
5845 * fns.c (to_uchar): Define.
5846 (crypto_hash_function): Use it to convert some newly-signed
5847 variables to unsigned, to avoid sign-extension bugs. For example,
5848 without this change, (md5 "truc") would evaluate to
5849 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5850 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5851 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5853 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5855 Integer overflow fixes.
5857 * dbusbind.c: Serial number integer overflow fixes.
5858 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5859 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5860 to hold a serial number that is too large for a fixnum.
5861 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5862 Check for serial numbers out of range. Decode any serial number
5863 that was so large that it became a float. (Bug#8722)
5865 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5866 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5867 Use XFASTINT rather than XUINT when numbers are nonnegative.
5868 (xd_append_arg, Fdbus_method_return_internal):
5869 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5870 arguments, check that Lisp number is nonnegative, rather than
5871 silently wrapping negative numbers around. (Bug#8722)
5872 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5875 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5877 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5879 ccl: Add integer overflow checks.
5880 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5881 (IN_INT_RANGE): New macros.
5882 (ccl_driver): Use them to check for integer overflow when
5883 decoding a CCL program. Many of the new checks are whether XINT (x)
5884 fits in int; it doesn't always, on 64-bit hosts. The new version
5885 doesn't catch all possible integer overflows, but it's an
5886 improvement. (Bug#8719)
5888 * alloc.c (make_event_array): Use XINT, not XUINT.
5889 There's no need for unsigned here.
5891 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5892 This follows up to the 2011-05-06 change that substituted uintptr_t
5893 for EMACS_INT. This case wasn't caught back then.
5895 Rework Fformat to avoid integer overflow issues.
5896 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5897 now (part of C89). Include <verify.h>.
5898 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5899 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5900 (Fformat): Avoid the prepass trying to compute sizes; it was only
5901 approximate and thus did not catch overflow reliably. Instead, walk
5902 through the format just once, formatting and computing sizes as we go,
5903 checking for integer overflow at every step, and allocating a larger
5904 buffer as needed. Keep track separately whether the format is
5905 multibyte. Keep only the most-recently calculated precision, rather
5906 than them all. Record whether each argument has been converted to
5907 string. Use EMACS_INT, not int, for byte and char and arg counts.
5908 Support field widths and precisions larger than INT_MAX. Avoid
5909 sprintf's undefined behavior with conversion specifications such as %#d
5910 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5911 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5912 formatting out-of-range floating point numbers with int
5915 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5917 * data.c: Avoid integer truncation in expressions involving floats.
5918 * data.c: Include <intprops.h>.
5919 (arith_driver): When there's an integer overflow in an expression
5920 involving floating point, convert the integers to floating point
5921 so that the resulting value does not suffer from catastrophic
5922 integer truncation. For example, on a 64-bit host (* 4
5923 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5924 Do not rely on undefined behavior after integer overflow.
5926 merge count_size_as_multibyte, parse_str_to_multibyte
5927 * character.c, character.h (count_size_as_multibyte):
5928 Rename from parse_str_to_multibyte; all uses changed.
5929 Check for integer overflow.
5930 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5931 since it's now a duplicate of the other. This is more of
5932 a character than a buffer op, so better that it's in character.c.
5933 * fns.c, print.c: Adjust to above changes.
5935 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5937 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5939 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5941 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5942 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5943 (x_clipboard_manager_save): Now static.
5944 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5946 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5947 (crypto_hash_function): Now static.
5948 Fix pointer signedness problems. Avoid unnecessary initializations.
5950 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5952 * termhooks.h (Vselection_alist): Make it terminal-local.
5954 * terminal.c (create_terminal): Initialize it.
5956 * xselect.c: Support for clipboard managers.
5957 (Vselection_alist): Move to termhooks.h as terminal-local var.
5958 (LOCAL_SELECTION): New macro.
5959 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5960 (symbol_to_x_atom): Remove gratuitous arg.
5961 (x_handle_selection_request, lisp_data_to_selection_data)
5962 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5963 (x_own_selection, x_get_local_selection, x_convert_selection):
5964 New arg, specifying work frame. Use terminal-local Vselection_alist.
5965 (some_frame_on_display): Delete unused function.
5966 (Fx_own_selection_internal, Fx_get_selection_internal)
5967 (Fx_disown_selection_internal, Fx_selection_owner_p)
5968 (Fx_selection_exists_p): New optional frame arg.
5969 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5970 (x_handle_selection_clear): Don't treat other terminals with the
5971 same keyboard specially. Use the terminal-local Vselection_alist.
5972 (x_clear_frame_selections): Use Frun_hook_with_args.
5974 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5976 * xterm.h: Add support for those atoms.
5978 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5980 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5981 (converted_selections, conversion_fail_tag): New global variables.
5982 (x_selection_request_lisp_error): Free the above.
5983 (x_get_local_selection): Remove unnecessary code.
5984 (x_reply_selection_request): Args changed; handle arbitrary array
5985 of converted selections stored in converted_selections.
5986 Separate the XChangeProperty and SelectionNotify steps.
5987 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5988 (x_convert_selection): New function.
5989 (x_handle_selection_event): Simplify.
5990 (x_get_foreign_selection): Don't ignore incoming requests while
5991 waiting for an answer; this will fail when we implement
5992 SAVE_TARGETS, and seems unnecessary anyway.
5993 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5994 (Vx_sent_selection_functions): Doc fix.
5996 2011-05-26 Leo Liu <sdl.web@gmail.com>
5998 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6000 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6002 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6004 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6005 for fringe update if it has periodic bitmap.
6006 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6007 and fringe_bitmap_periodic_p.
6009 * fringe.c (get_fringe_bitmap_data): New function.
6010 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6011 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6012 row. Mark glyph row for fringe update if periodicity changed.
6014 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6015 for fringe update unless it has periodic bitmap.
6017 2011-05-25 Kenichi Handa <handa@m17n.org>
6019 * xdisp.c (get_next_display_element): Set correct it->face_id for
6020 a static composition.
6022 2011-05-24 Leo Liu <sdl.web@gmail.com>
6025 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6027 * fns.c (crypto_hash_function, Fsha1): New function.
6028 (Fmd5): Use crypto_hash_function.
6029 (syms_of_fns): Add Ssha1.
6031 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6033 * gnutls.c: Remove unused macros.
6034 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6035 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6036 Remove macros that are defined and never used.
6037 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6039 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6041 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6042 (Fx_get_selection_internal): Minor cleanup.
6043 (Fx_own_selection_internal): Rename arguments for consistency with
6046 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6048 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6050 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6052 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6054 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6056 * dispnew.c (scrolling_window): Don't exclude the case that the
6057 last enabled row in the desired matrix touches the bottom boundary.
6059 2011-05-21 Glenn Morris <rgm@gnu.org>
6061 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6062 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6063 and add some more files.
6065 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6067 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6068 report_file_error introduced by the change from 2011-05-07.
6070 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6072 * systime.h (Time): Define only if emacs is defined.
6073 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6074 where the include path doesn't have X11/X.h by default. See
6075 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6077 2011-05-20 Kenichi Handa <handa@m17n.org>
6079 * composite.c (find_automatic_composition): Fix previous change.
6081 2011-05-20 Glenn Morris <rgm@gnu.org>
6083 * lisp.mk: New file, split from Makefile.in.
6084 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6085 (shortlisp): Remove.
6086 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6088 2011-05-19 Glenn Morris <rgm@gnu.org>
6090 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6091 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6092 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6093 (lisp): Set the order to that of loadup.el.
6094 (shortlisp): Make it a copy of $lisp.
6095 (SOME_MACHINE_LISP): Remove.
6096 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6097 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6099 2011-05-18 Kenichi Handa <handa@m17n.org>
6101 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6102 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6103 (find_automatic_composition): Mostly rewrite for efficiency.
6105 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6107 * makefile.w32-in: Update dependencies.
6109 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6111 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6112 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6114 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6116 Fix some integer overflow issues, such as string length overflow.
6118 * insdel.c (count_size_as_multibyte): Check for string overflow.
6120 * character.c (lisp_string_width): Check for string overflow.
6121 Use EMACS_INT, not int, for string indexes and lengths; in
6122 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6123 the resulting string length overflows an EMACS_INT; instead,
6124 report a string overflow if no precision given. When checking for
6125 precision exhaustion, use a check that cannot possibly have
6126 integer overflow. (Bug#8675)
6127 * character.h (lisp_string_width): Adjust to new signature.
6129 * alloc.c (string_overflow): New function.
6130 (Fmake_string): Use it. This doesn't change behavior, but saves
6131 a few bytes and will simplify future changes.
6132 * character.c (string_escape_byte8): Likewise.
6133 * lisp.h (string_overflow): New decl.
6135 Fixups, following up to the user-interface timestamp change.
6136 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6137 for UI timestamps, instead of unsigned long.
6138 * msdos.c (mouse_get_pos): Likewise.
6139 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6140 * w32gui.h (Time): Define by including "systime.h" rather than by
6141 declaring it ourselves. (Bug#8664)
6143 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6144 * image.c (clear_image_cache): Likewise.
6146 * term.c (term_mouse_position): Don't assume time_t wraparound.
6148 Be more systematic about user-interface timestamps.
6149 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6150 and sometimes 'EMACS_UINT', to represent these timestamps.
6151 This change causes it to use 'Time' uniformly, as that's what X uses.
6152 This makes the code easier to follow, and makes it easier to catch
6153 integer overflow bugs such as Bug#8664.
6154 * frame.c (Fmouse_position, Fmouse_pixel_position):
6155 Use Time, not unsigned long, for user-interface timestamps.
6156 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6157 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6158 * keyboard.h (last_event_timestamp): Likewise.
6159 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6160 * menu.h (xmenu_show): Likewise.
6161 * term.c (term_mouse_position): Likewise.
6162 * termhooks.h (struct input_event.timestamp): Likewise.
6163 (struct terminal.mouse_position_hook): Likewise.
6164 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6165 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6166 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6167 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6169 * menu.h, termhooks.h: Include "systime.h", for Time.
6171 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6172 Don't assume that the difference between two unsigned long values
6173 can fit into an integer. At this point, we know button_down_time
6174 <= event->timestamp, so the difference must be nonnegative, so
6175 there's no need to cast the result if double-click-time is
6176 nonnegative, as it should be; check that it's nonnegative, just in
6177 case. This bug is triggered when events are more than 2**31 ms
6178 apart (about 25 days). (Bug#8664)
6180 * xselect.c (last_event_timestamp): Remove duplicate decl.
6181 (x_own_selection): Remove needless cast to unsigned long.
6183 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6184 that always fit in int. Use a sentinel instead of a counter, to
6185 avoid a temp and to allay GCC's concerns about possible int overflow.
6186 * frame.h (struct frame): Use int for menu_bar_items_used
6187 instead of EMACS_INT, since it always fits in int.
6189 * menu.c (grow_menu_items): Check for int overflow.
6191 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6193 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6194 Before, the code was not consistent. These values cannot exceed
6195 2**31 - 1 so there's no need to make them unsigned.
6196 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6197 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6198 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6200 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6202 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6203 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6204 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6205 presumably because the widths might not match.
6207 * window.c (size_window): Avoid needless test at loop start.
6209 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6211 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6213 2011-05-12 Drew Adams <drew.adams@oracle.com>
6215 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6217 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6219 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6220 `width' to `bar_area_x' and `bar_area_width', respectively.
6221 (x_scroll_run): Take account of fringe background extension.
6223 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6224 Rename local vars `left' and `width' to `bar_area_x' and
6225 `bar_area_width', respectively.
6226 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6227 background extension.
6229 2011-05-10 Jim Meyering <meyering@redhat.com>
6231 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6233 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6235 * image.c (Finit_image_library): Return t for built-in image types,
6236 like pbm and xbm. (Bug#8640)
6238 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6240 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6242 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6244 * w32console.c (Fset_screen_color): Doc fix.
6245 (Fget_screen_color): New function.
6246 (syms_of_ntterm): Defsubr it.
6248 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6249 unlink the temporary file if Fcall_process didn't create it in the
6251 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6252 child process will be redirected to a file specified with `:file'.
6253 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6254 cue to call_process_cleanup not to close that handle.
6256 2011-05-07 Ben Key <bkey76@gmail.com>
6258 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6259 one of two shell specific rules, either bootstrap-temacs-CMD or
6260 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6261 to the previous implementation of the bootstrap-temacs rule.
6262 The bootstrap-temacs-CMD rule is similar to the previous
6263 implementation of the bootstrap-temacs rule except that it
6264 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6267 These changes, along with some changes to nt/configure.bat,
6268 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6269 earlier fix to add support for --cflags and --ldflags options
6270 that include quotes so that it works whether make uses cmd or
6273 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6275 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6276 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6278 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6279 a string. Handle both cases.
6280 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6281 (Fdbus_register_method): Use Qinvalid_function.
6283 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6285 * makefile.w32-in: Update dependencies.
6286 (LISP_H): Add inttypes.h and stdin.h.
6287 (PROCESS_H): Add unistd.h.
6289 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6291 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6292 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6294 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6296 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6298 * term.c (vfatal): Remove stray call to va_end.
6299 It's not needed and the C Standard doesn't allow it here anyway.
6301 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6302 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6304 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6307 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6309 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6311 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6313 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6315 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6317 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6318 * charset.c (Fdefine_charset_internal): Don't initialize
6319 charset.code_space[15]. The value was garbage, on hosts with
6320 32-bit int (Bug#8600).
6322 * lread.c (read_integer): Be more consistent with string-to-number.
6323 Use string_to_number to do the actual conversion; this avoids
6324 rounding errors and fixes some other screwups. Without this fix,
6325 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6326 (digit_to_number): Move earlier, for benefit of read_integer.
6327 Return -1 if the digit is out of range for the base, -2 if it is
6328 not a digit in any supported base. (Bug#8602)
6330 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6332 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6333 to match comment at start of function. This also removes a
6334 GCC warning about overflow in a 32+64-bit port.
6336 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6338 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6339 Reported by Stefan Monnier in
6340 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6341 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6342 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6344 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6345 (EMACS_UINTPTR): Likewise, with uintptr_t.
6347 * lisp.h: Prefer 64-bit EMACS_INT if available.
6348 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6349 on 32-bit hosts that have 64-bit int, so that they can access
6351 However, temporarily disable this change unless the temporary
6352 symbol WIDE_EMACS_INT is defined.
6354 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6356 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6357 This removes an assumption that EMACS_INT and long are the same
6358 width as pointers. The assumption is true for Emacs porting targets
6359 now, but we want to make other targets possible.
6360 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6361 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6362 In the rest of the code, change types of integers that hold casted
6363 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6364 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6365 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6366 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6367 No need to cast type when ORing.
6368 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6369 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6370 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6371 assume EMACS_INT is the same width as char *.
6372 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6373 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6374 Remove no-longer-needed casts.
6375 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6376 (xg_tool_bar_help_callback, xg_make_tool_item):
6377 Use EMACS_INTPTR to hold an integer
6378 that will be cast to void *; this can avoid a GCC warning
6379 if EMACS_INT is not the same width as void *.
6380 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6381 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6382 (current_message_1, set_message_1):
6383 Use a local to convert to proper width without a cast.
6384 * xmenu.c (dialog_selection_callback): Likewise.
6386 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6387 Also, don't assume VALBITS / RAND_BITS is less than 5,
6388 and don't rely on undefined behavior when shifting a 1 left into
6390 * lisp.h (get_random): Change signature to match.
6392 * lread.c (hash_string): Use size_t, not int, for hash computation.
6393 Normally we prefer signed values; but hashing is special, because
6394 it's better to use unsigned division on hash table sizes so that
6395 the remainder is nonnegative. Also, size_t is the natural width
6396 for hashing into memory. The previous code used 'int', which doesn't
6397 retain enough info to hash well into very large tables.
6398 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6400 * dbusbind.c: Don't possibly lose pointer info when converting.
6401 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6402 Use XPNTR rather than XHASH, so that the high-order bits of
6403 the pointer aren't lost when converting through void *.
6405 * eval.c (Fautoload): Don't double-shift a pointer.
6407 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6409 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6411 * gnutls.c (DEF_GNUTLS_FN):
6412 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6414 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6416 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6419 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6421 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6422 New version that can reserve upto 2GB of heap space.
6424 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6426 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6428 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6430 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6431 `gnutls_certificate_set_x509_key_file'.
6433 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6435 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6436 Update dependencies.
6438 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6440 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6441 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6442 Remove unused parameter `fildes'.
6443 * process.c (read_process_output, send_process): Don't pass it.
6445 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6447 Fix previous change: the library cache is defined in w32.c.
6448 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6449 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6451 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6453 Implement dynamic loading of GnuTLS on Windows.
6455 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6456 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6457 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6460 * gnutls.c (Qgnutls_dll): Define.
6461 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6462 (gnutls_*): Declare function pointers.
6463 (init_gnutls_functions): New function to initialize function pointers.
6464 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6465 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6466 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6467 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6468 (emacs_gnutls_write, emacs_gnutls_read)
6469 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6470 (Fgnutls_available_p): New function.
6471 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6472 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6473 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6475 * image.c: Include w32.h.
6476 (Vimage_type_cache): Delete.
6477 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6478 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6479 (w32_delayed_load): Move to w32.c.
6481 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6483 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6484 (w32_delayed_load): Move from image.c. When loading a library, record
6485 its filename in the :loaded-from property of the library id.
6486 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6487 Initialize and staticpro them.
6488 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6490 * process.c: Include lisp.h before w32.h, not after.
6491 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6492 instead of gnutls_record_check_pending.
6494 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6496 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6498 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6499 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6502 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6504 * xterm.c (x_set_frame_alpha): Do not set property on anything
6505 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6507 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6509 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6511 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6513 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6514 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6515 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6516 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6517 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6518 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6519 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6520 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6521 (Qgnutls_bootprop_callbacks_verify): Make static.
6523 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6525 * callproc.c: Indentation fixup.
6527 * sysdep.c (wait_for_termination_1): Make static.
6528 (wait_for_termination, interruptible_wait_for_termination):
6529 Move after wait_for_termination_1.
6531 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6533 * sysdep.c (interruptible_wait_for_termination): New function
6534 which is like wait_for_termination, but allows keyboard
6537 * callproc.c (Fcall_process): Add (:file "file") as an option for
6539 (Fcall_process_region): Ditto.
6541 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6543 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6544 rather than `XVECTOR (FOO)->size'.
6546 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6547 inttypes.h, as a gnulib replacement is used if it not available in
6550 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6552 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6553 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6554 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6556 * coding.c (coding_alloc_by_realloc): Error out if destination
6557 will grow beyond MOST_POSITIVE_FIXNUM.
6558 (decode_coding_emacs_mule): Abort if there isn't enough place in
6559 charbuf for the composition carryover bytes. Reserve an extra
6560 space for up to 2 characters produced in a loop.
6561 (decode_coding_iso_2022): Abort if there isn't enough place in
6562 charbuf for the composition carryover bytes.
6564 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6566 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6567 aborting when %lld or %lll format is passed.
6568 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6569 %llo or %llx format is passed. (Bug#8545)
6571 * window.c (window_scroll_line_based): Use a marker instead of
6572 simple variables to record original value of point. (Bug#7952)
6574 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6575 produced by %s or %c overflows available buffer space. (Bug#8545)
6577 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6579 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6580 (SIZE_MAX): Move defn after all includes, as they might #define it.
6582 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6584 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6586 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6588 * keyboard.c (Qdelayed_warnings_hook): Define.
6589 (command_loop_1): Run `delayed-warnings-hook'
6590 if Vdelayed_warnings_list is non-nil.
6591 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6592 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6594 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6596 * doprnt.c (doprnt): Don't return value smaller than the buffer
6597 size if the message was truncated. (Bug#8545).
6599 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6601 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6602 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6604 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6606 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6608 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6610 * makefile.w32-in: Update dependencies.
6612 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6614 Improve `doprnt' and its usage. (Bug#8545)
6615 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6616 `format_end'. Remove support for %l as a conversion specifier.
6617 Don't use xrealloc. Improve diagnostics when the %l size modifier
6618 is used. Update the commentary.
6620 * eval.c (verror): Simplify calculation of size_t.
6622 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6625 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6627 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6630 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6632 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6633 This makes this file independent of the recent pseudovector change.
6635 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6637 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6639 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6640 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6641 Remove unused local.
6642 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6644 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6645 GCC 4.6.0 optimizes based on type-based alias analysis.
6646 For example, if b is of type struct buffer * and v of type struct
6647 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6648 != &v->size, and therefore "v->size = 1; b->size = 2; return
6649 v->size;" must therefore return 1. This assumption is incorrect
6650 for Emacs, since it type-puns struct Lisp_Vector * with many other
6651 types. To fix this problem, this patch adds a new type struct
6652 vectorlike_header that documents the constraints on layout of vectors
6653 and pseudovectors, and helps optimizing compilers not get fooled
6654 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6655 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6656 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6658 (XSETPVECTYPE): Rewrite in terms of new macro.
6659 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6660 This is a bit clearer, and further avoids the possibility of
6661 undesirable aliasing.
6662 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6663 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6664 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6665 since Lisp_Subr is a special case (no "next" field).
6666 (ASIZE): Now uses header.size rather than size.
6667 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6668 to avoid the hassle of writing XVECTOR (foo)->header.size.
6669 (struct vectorlike_header): New type.
6670 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6671 object, to help avoid aliasing.
6672 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6673 (SUBRP): Likewise, since Lisp_Subr is a special case.
6674 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6675 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6676 (struct Lisp_Hash_Table): Combine first two members into a single
6677 struct vectorlike_header member. All uses of "size" and "next" members
6678 changed to be "header.size" and "header.next".
6679 * buffer.h (struct buffer): Likewise.
6680 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6681 * frame.h (struct frame): Likewise.
6682 * process.h (struct Lisp_Process): Likewise.
6683 * termhooks.h (struct terminal): Likewise.
6684 * window.c (struct save_window_data, struct saved_window): Likewise.
6685 * window.h (struct window): Likewise.
6686 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6687 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6688 * buffer.c (init_buffer_once): Likewise.
6689 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6691 * process.c (Fformat_network_address): Use local var for size,
6694 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6696 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6697 * data.c (atof): Remove decl; no longer used or needed.
6698 (digit_to_number): Move to lread.c.
6699 (Fstring_to_number): Use new string_to_number function, to be
6700 consistent with how the Lisp reader treats infinities and NaNs.
6701 Do not assume that floating-point numbers represent EMACS_INT
6702 without losing information; this is not true on most 64-bit hosts.
6703 Avoid double-rounding errors, by insisting on integers when
6704 parsing non-base-10 numbers, as the documentation specifies.
6705 * lisp.h (string_to_number): New decl, replacing ...
6706 (isfloat_string): Remove.
6707 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6708 (read1): Do not accept +. and -. as integers; this
6709 appears to have been a coding error. Similarly, do not accept
6710 strings like +-1e0 as floating point numbers. Do not report
6711 overflow for integer overflows unless the base is not 10 which
6712 means we have no simple and reliable way to continue.
6713 Break out the floating-point parsing into a new
6714 function string_to_number, so that Fstring_to_number parses
6715 floating point numbers consistently with the Lisp reader.
6716 (digit_to_number): Move here from data.c. Make it static inline.
6717 (E_CHAR, EXP_INT): Remove, replacing with ...
6718 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6719 (string_to_number): New function, replacing isfloat_string.
6720 This function checks for valid syntax and produces the resulting
6721 Lisp float number too. Rework it so that string-to-number
6722 no longer mishandles examples like "1.0e+". Use strtoumax,
6723 so that overflow for non-base-10 numbers is reported only when
6724 there's no portable and simple way to convert to floating point.
6726 * textprop.c (set_text_properties_1): Rewrite for clarity,
6727 and to avoid GCC warning about integer overflow.
6729 * intervals.h (struct interval): Use EMACS_INT for members
6730 where EMACS_UINT might cause problems. See
6731 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6732 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6733 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6735 (offset_intervals): Tell GCC not to worry about length overflow
6736 when negating a negative length.
6738 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6739 (overrun_check_free): Likewise.
6741 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6742 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6745 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6746 (gnutls_make_error): Rename local to avoid shadowing.
6747 (gnutls_emacs_global_deinit): ifdef out; not used.
6748 (Fgnutls_boot): Use const for pointer to readonly storage.
6749 Comment out unused local. Fix pointer signedness problems.
6751 * lread.c (openp): Don't stuff size_t into an 'int'.
6752 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6753 about possible signed overflow.
6755 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6756 (GDK_KEY_g): Don't define if already defined.
6757 (xg_prepare_tooltip): Avoid pointer signedness problem.
6758 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6760 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6761 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6763 * xfns.c (Fx_window_property): Simplify a bit,
6764 to make a bit faster and to avoid GCC 4.6.0 warning.
6765 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6767 * fns.c (internal_equal): Don't assume size_t fits in int.
6769 * alloc.c (compact_small_strings): Tighten assertion a little.
6771 Replace pEd with more-general pI, and fix some printf arg casts.
6772 * lisp.h (pI): New macro, generalizing old pEd macro to other
6773 conversion specifiers. For example, use "...%"pI"d..." rather
6774 than "...%"pEd"...".
6775 (pEd): Remove. All uses replaced with similar uses of pI.
6776 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
6777 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6778 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6779 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6780 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6781 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6782 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6784 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6785 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6786 * print.c (safe_debug_print, print_object): Likewise.
6787 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6789 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6790 avoiding the 0 flag, which is not portable.
6791 * process.c (Fmake_network_process): Use pI to avoid cast.
6792 * region-cache.c (pp_cache): Likewise.
6793 * xdisp.c (decode_mode_spec): Likewise.
6794 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6795 behavior on 64-bit hosts with printf arg.
6796 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6797 (x_stop_queuing_selection_requests): Likewise.
6798 (x_get_window_property): Don't truncate byte count to an 'int'
6801 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6802 here, since it parses constructs like leading '-' and spaces,
6803 which are not wanted; and it overflows with large numbers.
6804 Instead, simply match F[0-9]+, which is what is wanted anyway.
6806 * alloc.c: Remove unportable assumptions about struct layout.
6807 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6808 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6809 (allocate_vectorlike, make_pure_vector): Use the new macros,
6810 plus offsetof, to remove unportable assumptions about struct layout.
6811 These assumptions hold on all porting targets that I know of, but
6812 they are not guaranteed, they're easy to remove, and removing them
6813 makes further changes easier.
6815 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6816 This doesn't fix a bug but makes the code clearer.
6817 (string_overrun_cookie): Now const. Use initializers that
6818 don't formally overflow signed char, to avoid warnings.
6819 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6820 can cause Emacs to crash when string overrun checking is enabled.
6821 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6822 multiple of sizeof (EMACS_INT); it need not be, if
6823 alignof(EMACS_INT) < sizeof (EMACS_INT).
6824 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6826 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6828 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6830 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6832 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6833 supposed to be handshaking. (Bug#8556)
6834 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6836 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6838 * lisp.h (Qdebug): List symbol.
6839 * eval.c (Qdebug): Restore global linkage.
6840 * keyboard.c (debug-on-event): New variable.
6841 (handle_user_signal): Break into debugger when debug-on-event
6842 matches the current signal symbol.
6844 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6846 * alloc.c (check_sblock, check_string_bytes)
6847 (check_string_free_list): Convert to standard C.
6849 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6851 * w32.c (emacs_gnutls_push): Fix typo.
6853 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6855 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6856 "cast to pointer from integer of different size".
6858 Improve doprnt and its use in verror. (Bug#8545)
6859 * doprnt.c (doprnt): Document the set of format control sequences
6860 supported by the function. Use SAFE_ALLOCA instead of always
6863 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6864 is one byte too soon. Don't use xrealloc; instead xfree and
6867 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6869 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6872 * gnutls.c: Renamed global_initialized to
6873 gnutls_global_initialized. Added internals for the
6874 :verify-hostname-error, :verify-error, and :verify-flags
6875 parameters of `gnutls-boot' and documented those parameters in the
6876 docstring. Start callback support.
6877 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6878 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6879 on error. Return error code.
6880 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6881 (emacs_gnutls_read): Likewise.
6882 (Fgnutls_boot): Return handshake error code.
6883 (emacs_gnutls_handle_error): New function.
6884 (wsaerror_to_errno): Likewise.
6886 * w32.h (emacs_gnutls_pull): Add prototype.
6887 (emacs_gnutls_push): Likewise.
6889 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6890 (emacs_gnutls_push): Likewise.
6892 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6894 * process.c (wait_reading_process_output): Check if GnuTLS
6895 buffered some data internally if no FDs are set for TLS
6898 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6899 (LIBS): Link to USER_LIBS.
6900 ($(BLD)/gnutls.$(0)): New target.
6902 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6904 * xdisp.c (handle_single_display_spec): Rename the
6905 display_replaced_before_p argument into display_replaced_p, to
6906 make it consistent with the commentary. Fix typos in the
6909 * textprop.c (syms_of_textprop): Remove dead code.
6910 (copy_text_properties): Delete obsolete commentary about an
6911 interface that was deleted long ago. Fix typos in the description
6914 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6915 to changes in oldXMenu/XMenu.h from 2011-04-16.
6916 <menu_help_message, prev_menu_help_message>: Constify.
6917 (IT_menu_make_room): menu->help_text is now `const char **';
6920 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6921 to changes in oldXMenu/XMenu.h from 2011-04-16.
6922 (struct XMenu): Declare `help_text' `const char **'.
6924 * xfaces.c <Qunspecified>: Make extern again.
6926 * syntax.c: Include sys/types.h before including regex.h, as
6929 * doc.c (get_doc_string): Improve the format passed to `error'.
6931 * doprnt.c (doprnt): Improve commentary.
6933 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6935 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6938 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6939 changes in globals.h immediately force recompilation.
6940 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6941 $(CURDIR)/s/ms-w32.h.
6942 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6944 * character.c (Fchar_direction): Function deleted.
6945 (syms_of_character): Don't defsubr it.
6946 <char-direction-table>: Deleted.
6948 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6950 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6951 * doprnt.c: Include limits.h.
6952 (SIZE_MAX): New macro.
6953 (doprnt): Return a size_t value. 2nd arg is now size_t.
6954 Many local variables are now size_t instead of int or unsigned.
6955 Improve overflow protection. Support `l' modifier for integer
6956 conversions. Support %l conversion. Don't assume an EMACS_INT
6957 argument for integer conversions and for %c.
6959 * lisp.h (doprnt): Restore prototype.
6961 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6964 * Makefile.in (base_obj): Add back doprnt.o.
6966 * deps.mk (doprnt.o): Add back prerequisites.
6967 (callint.o): Depend on character.h.
6969 * eval.c (internal_lisp_condition_case): Include the handler
6970 representation in the error message.
6971 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6972 when breaking from the loop.
6974 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6976 * callint.c (Fcall_interactively): When displaying error message
6977 about invalid control letter, pass the character's codepoint, not
6978 a pointer to its multibyte form. Improve display of the character
6979 in octal and display also its hex code.
6981 * character.c (char_string): Use %x to display the (unsigned)
6982 codepoint of an invalid character, to avoid displaying a bogus
6985 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6986 `error', not SYMBOL_NAME itself.
6988 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6989 character arguments to `error'.
6991 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6992 to `error' in error message about FINAL_CHAR argument. Make sure
6993 FINAL_CHAR is a character, and use %c when it is passed as
6994 argument to `error'.
6996 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6998 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7000 * w32.c: Include <time.h>.
7001 (sys_localtime): New function.
7003 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7005 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7007 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7009 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7011 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7014 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7016 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7017 gl_state.e_property when gl_state.object is Qt.
7019 * insdel.c (make_gap_larger): Remove limitation of buffer size
7022 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7024 * xdisp.c (lookup_glyphless_char_display)
7025 (produce_glyphless_glyph): Handle cons cell entry in
7026 glyphless-char-display.
7027 (Vglyphless_char_display): Document it.
7029 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7030 glyphless-char-display.
7032 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7034 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7036 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7038 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7039 definition for no-X builds.
7041 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7043 Static checks with GCC 4.6.0 and non-default toolkits.
7045 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7047 * process.c (keyboard_bit_set): Define only if SIGIO.
7048 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7049 (send_process): Repair possible setjmp clobbering.
7051 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7053 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7055 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7057 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7058 Define only if needed.
7060 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7061 by pacifying GCC about it. Maybe it's time to retire it?
7062 * xfaces.c (USG, __TIMEVAL__): Likewise.
7064 * dispextern.h (struct redisplay_interface): Rename param
7066 * termhooks.h (struct terminal): Likewise.
7067 * xterm.c (xembed_send_message): Likewise.
7069 * insdel.c (make_gap_smaller): Define only if
7070 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7072 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7075 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7076 so that we aren't warned about unused symbols.
7078 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7080 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7082 * xfns.c (x_real_positions): Mark locals as initialized.
7084 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7086 * xterm.c: Fix problems found by static analysis with other toolkits.
7087 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7088 (x_dispatch_event): Declare static if USE_GTK, and
7089 define if USE_GTK || USE_X_TOOLKIT.
7090 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7091 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7092 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7093 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7095 * xmenu.c (menu_help_callback): Pointer type fixes.
7096 Use const pointers when pointing at readonly data. Avoid pointer
7098 (FALSE): Remove unused macro.
7099 (update_frame_menubar): Remove unused decl.
7101 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7103 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7104 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7105 (single_menu_item): Rename local to avoid shadowing.
7107 * keyboard.c (make_lispy_event): Remove unused local var.
7109 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7110 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7112 * bitmaps: Change bitmaps from unsigned char back to the X11
7113 compatible char. Avoid the old compiler warnings about
7114 out-of-range initializers by using, for example, '\xab' rather
7117 * xgselect.c (xgselect_initialize): Check vs interface
7118 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7120 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7122 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7123 to read-only memory.
7125 * fns.c (vector): Remove; this old hack is no longer needed.
7127 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7129 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7131 * xrdb.c (x_load_resources): Omit unused local.
7133 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7134 (x_window): Rename locals to avoid shadowing.
7135 (USG): Use the kludged USG macro, to pacify gcc.
7137 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7138 (x_term_init): Remove local to avoid shadowing.
7140 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7142 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7143 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7145 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7147 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7149 Fix regex.c, syntax.c and friends for buffers > 2GB.
7150 * syntax.h (struct gl_state_s): Declare character position members
7153 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7155 * textprop.c (verify_interval_modification, interval_of):
7156 Declare arguments EMACS_INT.
7158 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7161 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7163 * indent.c (Fvertical_motion): Local variable it_start is now
7166 * regex.c (re_match, re_match_2, re_match_2_internal)
7167 (bcmp_translate, regcomp, regexec, print_double_string)
7168 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7169 (re_compile_pattern, re_exec): Declare arguments and local
7170 variables `size_t' and `ssize_t' and return values `regoff_t', as
7172 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7173 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7174 <compile_stack_type>: `size' and `avail' are now `size_t'.
7176 * regex.h <regoff_t>: Use ssize_t, not int.
7177 (re_search, re_search_2, re_match, re_match_2): Arguments that
7178 specify buffer/string position and length are now ssize_t and
7179 size_t. Return type is regoff_t.
7181 2011-04-16 Ben Key <bkey76@gmail.com>
7183 * nsfont.m: Fixed bugs in ns_get_family and
7184 ns_descriptor_to_entity that were caused by using free to
7185 deallocate memory blocks that were allocated by xmalloc (via
7186 xstrdup). This caused Emacs to crash when compiled with
7187 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7188 --enable-checking=xmallocoverrun). xfree is now used to
7189 deallocate these memory blocks.
7191 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7193 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7195 emacs_write: Accept and return EMACS_INT for sizes.
7196 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7198 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7199 Accept and return EMACS_INT.
7200 (emacs_gnutls_write): Return the number of bytes written on
7202 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7203 (emacs_read, emacs_write): Remove check for negative size, as the
7204 Emacs source code has been audited now.
7205 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7206 (emacs_read, emacs_write): Use it.
7207 * process.c (send_process): Adjust to the new signatures of
7208 emacs_write and emacs_gnutls_write. Do not attempt to store
7209 a byte offset into an 'int'; it might overflow.
7210 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7212 * sound.c: Don't assume sizes fit in 'int'.
7213 (struct sound_device.period_size, alsa_period_size):
7214 Return EMACS_INT, not int.
7215 (struct sound_device.write, vox_write, alsa_write):
7216 Accept EMACS_INT, not int.
7217 (wav_play, au_play): Use EMACS_INT to store sizes and to
7218 record read return values.
7220 2011-04-15 Ben Key <bkey76@gmail.com>
7222 * keyboard.c (Qundefined): Don't declare static since it is used
7224 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7225 static since they are used in nsfont.m.
7227 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7229 * process.c (Qprocessp): Don't declare static.
7230 * lisp.h (Qprocessp): Declare again.
7232 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7234 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7236 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7238 Improve C-level modularity by making more things 'static'.
7240 Don't publish debugger-only interfaces to other modules.
7241 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7242 (verify_bytepos, count_markers): Move decls to the only modules
7244 * region-cache.h (pp_cache): Likewise.
7245 * window.h (check_all_windows): Likewise.
7246 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7248 * sysdep.c (croak): Now static, if
7249 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7250 * syssignal.h (croak): Declare only if not static.
7252 * alloc.c (refill_memory_reserve): Now static if
7253 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7254 * lisp.h (refill_memory_reserve): Declare only if not static.
7256 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7257 Define only if USE_LUCID.
7259 * xrdb.c (x_customization_string, x_rm_string): Now static.
7261 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7262 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7264 * xdisp.c (draw_row_with_mouse_face): Now static.
7265 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7267 * window.h (check_all_windows): Mark externally visible.
7269 * window.c (window_deletion_count): Now static.
7271 * undo.c: Make symbols static if they're not exported.
7272 (last_undo_buffer, last_boundary_position, pending_boundary):
7275 * textprop.c (interval_insert_behind_hooks): Now static.
7276 (interval_insert_in_front_hooks): Likewise.
7278 * term.c: Make symbols static if they're not exported.
7279 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7280 (max_frame_lines, tty_set_terminal_modes):
7281 (tty_reset_terminal_modes, tty_turn_off_highlight):
7282 (get_tty_terminal): Now static.
7283 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7284 * termhooks.h (term_mouse_moveto): Do not declare if
7286 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7287 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7289 * sysdep.c: Make symbols static if they're not exported.
7290 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7292 (sigprocmask_set, full_mask): Remove; unused.
7293 (wait_debugging): Mark as visible.
7294 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7295 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7297 * syntax.c (syntax_temp): Define only if !__GNUC__.
7299 * sound.c (current_sound_device, current_sound): Now static.
7301 * search.c (searchbufs, searchbuf_head): Now static.
7303 * scroll.c (scroll_cost): Remove; unused.
7304 * dispextern.h (scroll_cost): Remove decl.
7306 * region-cache.h (pp_cache): Mark as externally visible.
7308 * process.c: Make symbols static if they're not exported.
7309 (process_tick, update_tick, create_process, chan_process):
7310 (Vprocess_alist, proc_buffered_char, datagram_access):
7311 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7312 (deactivate_process): Mark defn as static, as well as decl.
7313 * lisp.h (create_process): Remove decl.
7314 * process.h (chan_process, Vprocess_alist): Remove decls.
7316 * print.c: Make symbols static if they're not exported.
7317 (print_depth, new_backquote_output, being_printed, print_buffer):
7318 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7319 (print_interval, print_number_index, initial_stderr_stream):
7321 * lisp.h (Fprinc): Remove decl.
7322 (debug_output_compilation_hack): Mark as externally visible.
7324 * sysdep.c (croak): Move decl from here to syssignal.h.
7325 * syssignal.h (croak): Put it here, so the API can be checked when
7326 'croak' is called from dissociate_if_controlling_tty.
7328 * minibuf.c: Make symbols static if they're not exported.
7329 (minibuf_save_list, choose_minibuf_frame): Now static.
7330 * lisp.h (choose_minibuf_frame): Remove decl.
7332 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7334 * lread.c: Make symbols static if they're not exported.
7335 (read_objects, initial_obarray, oblookup_last_bucket_number):
7337 (make_symbol): Remove; unused.
7338 * lisp.h (initial_obarray, make_symbol): Remove decls.
7340 * keyboard.c: Make symbols static if they're not exported.
7341 (single_kboard, recent_keys_index, total_keys, recent_keys):
7342 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7343 (this_single_command_key_start, echoing, last_auto_save):
7344 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7345 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7346 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7347 (Vlispy_mouse_stem, double_click_count):
7349 (force_auto_save_soon): Define only if SIGDANGER.
7350 (ignore_mouse_drag_p): Now static if
7351 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7352 (print_help): Remove; unused.
7353 (stop_character, last_timer_event): Mark as externally visible.
7354 * keyboard.h (ignore_mouse_drag_p): Declare only if
7355 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7356 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7357 * lisp.h (echoing): Remove decl.
7358 (force_auto_save_soon): Declare only if SIGDANGER.
7359 * xdisp.c (redisplay_window): Simplify code, to make it more
7360 obvious that ignore_mouse_drag_p is not accessed if !defined
7361 USE_GTK && !defined HAVE_NS.
7363 * intervals.c: Make symbols static if they're not exported.
7364 (merge_properties_sticky, merge_interval_right, delete_interval):
7366 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7368 * insdel.c: Make symbols static if they're not exported.
7369 However, leave prepare_to_modify_buffer alone. It's never
7370 called from outside this function, but that appears to be a bug.
7371 (combine_after_change_list, combine_after_change_buffer):
7372 (adjust_after_replace, signal_before_change): Now static.
7373 (adjust_after_replace_noundo): Remove; unused.
7374 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7375 (signal_before_change): Remove decls.
7377 * indent.c (val_compute_motion, val_vmotion): Now static.
7379 * image.c: Make symbols static if they're not exported.
7380 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7382 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7383 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7385 * fringe.c (standard_bitmaps): Now static.
7386 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7388 * frame.c: Make symbols static if they're not exported.
7389 (x_report_frame_params, make_terminal_frame): Now static.
7390 (get_frame_param): Now static, unless HAVE_NS.
7391 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7392 (x_get_resource_string): Remove; not used.
7393 * frame.h (make_terminal_frame, x_report_frame_params):
7394 (x_get_resource_string); Remove decls.
7395 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7396 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7398 * font.c, fontset.c: Make symbols static if they're not exported.
7399 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7400 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7401 * font.c (font_close_object): Now static.
7402 * font.h (font_close_object): Remove.
7403 * fontset.c (FONTSET_OBJLIST): Remove.
7404 (free_realized_fontset) #if-0 the body, which does nothing.
7405 (face_suitable_for_char_p): #if-0, as it's never called.
7406 * fontset.h (face_suitable_for_char_p): Remove decl.
7407 * xfaces.c (face_at_string_position):
7408 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7409 since 0 is always ASCII.
7411 * fns.c (weak_hash_tables): Now static.
7413 * fileio.c: Make symbols static if they're not exported.
7414 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7415 (Vwrite_region_annotation_buffers): Now static.
7417 * eval.c: Make symbols static if they're not exported.
7418 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7419 * lisp.h (backtrace_list): Remove decl.
7421 * emacs.c: Make symbols static if they're not exported.
7422 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7423 (fatal_error_code, fatal_error_signal_hook, standard_args):
7425 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7426 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7427 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7428 * lisp.h (fatal_error_signal_hook): Remove decl.
7429 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7431 * editfns.c: Move a (normally-unused) function to its only use.
7432 * editfns.c, lisp.h (get_operating_system_release): Remove.
7433 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7434 worth the hassle of breaking this out.
7436 * xterm.c: Make symbols static if they're not exported.
7437 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7438 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7439 (x_destroy_window, x_delete_display):
7441 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7442 (x_mouse_leave): Remove; unused.
7443 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7444 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7445 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7447 (x_mouse_leave): Declare only if WINDOWSNT.
7448 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7449 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7452 * ftxfont.c: Make symbols static if they're not exported.
7453 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7455 * font.h (ftxfont_driver): Likewise.
7457 * xfns.c: Make symbols static if they're not exported.
7458 (x_last_font_name, x_display_info_for_name):
7459 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7460 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7461 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7462 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7463 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7464 (last_show_tip_args): Now static.
7465 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7466 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7467 (x_screen_planes): Remove; unused.
7468 * dispextern.h (x_screen_planes): Remove decl.
7470 * dispnew.c: Make symbols static if they're not exported.
7471 * dispextern.h (redraw_garbaged_frames, scrolling):
7472 (increment_row_positions): Remove.
7473 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7474 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7476 (redraw_garbaged_frames): Remove; unused.
7478 * xfaces.c: Make symbols static if they're not exported.
7479 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7481 * xterm.h (defined_color): Remove decls.
7482 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7483 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7484 (menu_face_changed_default, defined_color, free_realized_face):
7485 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7486 (ascii_face_of_lisp_face): Remove; unused.
7488 * xdisp.c: Make symbols static if they're not exported.
7489 * dispextern.h (scratch_glyph_row, window_box_edges):
7490 (glyph_to_pixel_coords, set_cursor_from_row):
7491 (get_next_display_element, set_iterator_to_next):
7492 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7493 (show_mouse_face): Remove decls
7494 * frame.h (message_buf_print): Likewise.
7495 * lisp.h (pop_message, set_message, check_point_in_composition):
7497 * xterm.h (set_vertical_scroll_bar): Likewise.
7498 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7499 (message_buf_print, scratch_glyph_row, displayed_buffer):
7500 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7501 (get_next_display_element, show_mouse_face, window_box_edges):
7502 (frame_to_window_pixel_xy, check_point_in_composition):
7503 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7504 (glyph_to_pixel_coords): Remove; unused.
7506 * dired.c (file_name_completion): Now static.
7508 * dbusbind.c (xd_in_read_queued_messages): Now static.
7510 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7511 * data.c (circular_list_error): Remove.
7513 * commands.h (last_point_position, last_point_position_buffer):
7514 (last_point_position_window): Remove decls.
7515 * keyboard.c: Make these variables static.
7517 * coding.h (coding, code_convert_region, encode_coding_gap):
7519 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7520 (iso_code_class, detect_coding, code_convert_region): Now static.
7521 (encode_coding_gap): Remove; unused.
7523 * chartab.c (chartab_chars, chartab_bits): Now static.
7525 * charset.h (charset_iso_8859_1): Remove decl.
7526 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7529 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7530 * ccl.c (Vccl_program_table): Now static.
7531 (check_ccl_update): Remove; unused.
7533 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7534 * category.h: ... from here.
7535 * category.c (check_category_table, set_category_set): Now static.
7537 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7538 * lisp.h: Remove these decls.
7540 * buffer.c (buffer_count): Remove unused var.
7542 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7543 so that it's not optimized away.
7544 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7545 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7546 exported only to the debugger.
7548 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7549 * atimer.h (run_all_atimers): Remove; not exported.
7551 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7552 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7553 was inaccessible from Lisp.
7554 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7555 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7557 alloc.c: Import and export fewer symbols, and remove unused items.
7558 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7560 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7561 it's not optimized away by whole-program optimization.
7562 (message_enable_multibyte, free_misc): Remove.
7563 (catchlist, handlerlist, mark_backtrace):
7564 Declare only if BYTE_MARK_STACK.
7565 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7566 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7567 (message_enable_multibyte): Remove decl.
7568 (free_misc, interval_free_list, float_block, float_block_index):
7569 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7570 (cons_free_list, last_marked_index):
7572 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7573 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7574 (mark_backtrace): Define only if BYTE_MARK_STACK.
7575 * xdisp.c (message_enable_multibyte): Now static.
7577 Declare Lisp_Object Q* variables to be 'static' if not exported.
7578 This makes it easier for human readers (and static analyzers)
7579 to see whether these variables are used from other modules.
7580 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7581 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7582 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7583 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7584 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7585 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7586 * xmenu.c, xselect.c:
7587 Declare Q* vars static if they are not used in other modules.
7588 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7589 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7590 Remove decls of unexported vars.
7591 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7593 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7595 Make Emacs functions such as Fatom 'static' by default.
7596 This makes it easier for human readers (and static analyzers)
7597 to see whether these functions can be called from other modules.
7598 DEFUN now defines a static function. To make the function external
7599 so that it can be used in other C modules, use the new macro DEFUE.
7600 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7601 (Finit_image_library):
7602 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7603 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7604 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7605 Remove decls, since these functions are now static.
7606 (Funintern, Fget_internal_run_time): New decls, since these functions
7607 were already external.
7609 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7610 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7611 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7612 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7613 * keyboard.c, keymap.c, lread.c:
7614 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7615 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7616 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7617 Mark functions with DEFUE instead of DEFUN,
7618 if they are used in other modules.
7619 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7620 decls for now-static functions.
7621 * buffer.h (Fdelete_overlay): Remove decl.
7622 * callproc.c (Fgetenv_internal): Mark as internal.
7623 * composite.c (Fremove_list_of_text_properties): Remove decl.
7624 (Fcomposition_get_gstring): New forward static decl.
7625 * composite.h (Fcomposite_get_gstring): Remove decl.
7626 * dired.c (Ffile_attributes): New forward static decl.
7627 * doc.c (Fdocumntation_property): New forward static decl.
7628 * eval.c (Ffetch_bytecode): New forward static decl.
7629 (Funintern): Remove extern decl; now in .h file where it belongs.
7630 * fileio.c (Fmake_symbolic_link): New forward static decl.
7631 * image.c (Finit_image_library): New forward static decl.
7632 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7633 * intervals.h (Fprevious_property_change):
7634 (Fremove_list_of_text_properties): Remove decls.
7635 * keyboard.c (Fthis_command_keys): Remove decl.
7636 (Fcommand_execute): New forward static decl.
7637 * keymap.c (Flookup_key): New forward static decl.
7638 (Fcopy_keymap): Now static.
7639 * keymap.h (Flookup_key): Remove decl.
7640 * process.c (Fget_process): New forward static decl.
7641 (Fprocess_datagram_address): Mark as internal.
7642 * syntax.c (Fsyntax_table_p): New forward static decl.
7643 (skip_chars): Remove duplicate decl.
7644 * textprop.c (Fprevious_property_change): New forward static decl.
7645 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7647 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7648 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7650 * editfns.c (Fformat): Remove unreachable code.
7652 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7654 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7657 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7659 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7660 when at ZV. (Bug#8487)
7662 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7664 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7666 * keyboard.c (parse_tool_bar_item): Likewise.
7667 * sound.c (sound_cleanup, alsa_close): Likewise.
7668 * termcap.c (tgetent): Likewise.
7669 * xfns.c (x_default_font_parameter): Likewise.
7670 * xsettings.c (read_and_apply_settings): Likewise.
7672 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7673 (overrun_check_free): Protoize.
7675 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7677 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7678 since callers should never pass a negative size.
7679 Change the signature to match that of plain 'read' and 'write'; see
7680 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7681 * lisp.h: Update prototypes of emacs_write and emacs_read.
7683 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7685 * xdisp.c (redisplay_window): Don't try to determine the character
7686 position of the scroll margin if the window start point w->startp
7687 is outside the buffer's accessible region. (Bug#8468)
7689 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7691 Fix write-region and its subroutines for buffers > 2GB.
7692 * fileio.c (a_write, e_write): Modify declaration of arguments and
7693 local variables to support buffers larger than 2GB.
7694 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7696 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7697 argument, local variables, and return value.
7699 * lisp.h: Update prototypes of emacs_write and emacs_read.
7701 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7703 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7705 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7707 Fix more problems found by GCC 4.6.0's static checks.
7709 * xdisp.c (vmessage): Use a better test for character truncation.
7711 * charset.c (load_charset_map): <, not <=, for optimization,
7712 and to avoid potential problems with integer overflow.
7713 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7714 * casetab.c (set_identity, shuffle): Likewise.
7715 * editfns.c (Fformat): Likewise.
7716 * syntax.c (skip_chars): Likewise.
7718 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7719 This also lets GCC 4.6.0 generate slightly better loop code.
7721 * callint.c (Fcall_interactively): <, not <=, for optimization.
7722 (Fcall_interactively): Count the number of arguments produced,
7723 not the number of arguments given. This is simpler and lets GCC
7724 4.6.0 generate slightly better code.
7726 * ftfont.c: Distingish more carefully between FcChar8 and char.
7727 The previous code passed unsigned char * to a functions like
7728 strlen and xstrcasecmp that expect char *, which does not
7729 conform to the C standard.
7730 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7731 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7732 char * when the C standard requires it.
7734 * keyboard.c (read_char): Remove unused var.
7736 * eval.c: Port to Windows vsnprintf (Bug#8435).
7738 (SIZE_MAX): Define if the headers do not.
7739 (verror): Do not give up if vsnprintf returns a negative count.
7740 Instead, grow the buffer. This ports to Windows vsnprintf, which
7741 does not conform to C99. Problem reported by Eli Zaretskii.
7742 Also, simplify the allocation scheme, by avoiding the need for
7743 calling realloc, and removing the ALLOCATED variable.
7745 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7747 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7748 But keep the doprint source code for now, as we might revamp it
7749 and use it again (Bug#8435).
7750 * lisp.h (doprnt): Remove.
7751 * Makefile.in (base_obj): Remove doprnt.o.
7752 * deps.mk (doprnt.o): Remove.
7754 error: Print 32- and 64-bit integers portably (Bug#8435).
7755 Without this change, on typical 64-bit hosts error ("...%d...", N)
7756 was used to print both 32- and 64-bit integers N, which relied on
7758 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
7759 * lisp.h (error, verror): Mark as printf-like functions.
7760 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7761 Report overflow in size calculations when allocating printf buffer.
7762 Do not truncate output string at its first null byte.
7763 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7764 Truncate the output at a character boundary, since vsnprintf does not
7766 * charset.c (check_iso_charset_parameter): Convert internal
7767 character to string before calling 'error', since %c now has the
7769 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7770 overflow when computing char to be passed to 'error'. Do not
7771 pass Lisp_Object to 'error'; pass the integer instead.
7772 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7773 formatted with plain %d.
7775 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7777 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7779 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7781 * xterm.c (x_catch_errors): Remove duplicate declaration.
7783 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7785 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7787 2011-04-10 Jim Meyering <meyering@redhat.com>
7789 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7790 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7791 return ssize_t not "int", and use size_t as the buffer length.
7792 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7793 * gnutls.h: Update declarations.
7794 * process.c (read_process_output): Use ssize_t, to match.
7795 (send_process): Likewise.
7797 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7799 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7801 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7803 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7804 Use unsigned char, to match FcChar8 type definition.
7806 * xterm.c (handle_one_xevent):
7807 * xmenu.c (create_and_show_popup_menu):
7808 * xselect.c (x_decline_selection_request)
7809 (x_reply_selection_request): Avoid type-punned deref of X events.
7811 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7813 Fix some uses of `int' instead of EMACS_INT.
7814 * search.c (string_match_1, fast_string_match)
7815 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7816 (scan_buffer, find_next_newline_no_quit)
7817 (find_before_next_newline, search_command, Freplace_match)
7818 (Fmatch_data): Make some `int' variables be EMACS_INT.
7820 * xdisp.c (display_count_lines): 3rd argument and return value now
7821 EMACS_INT. All callers changed.
7822 (pint2hrstr): Last argument is now EMACS_INT.
7824 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7825 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7826 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7827 (decode_coding_utf_16, decode_coding_emacs_mule)
7828 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7829 (decode_coding_ccl, decode_coding_charset)
7830 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7831 (decode_coding_iso_2022, decode_coding_emacs_mule)
7832 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7833 <char_offset, last_offset>: Declare EMACS_INT.
7834 (encode_coding_utf_8, encode_coding_utf_16)
7835 (encode_coding_emacs_mule, encode_invocation_designation)
7836 (encode_designation_at_bol, encode_coding_iso_2022)
7837 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7838 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7840 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7841 (encode_invocation_designation): Last argument P_NCHARS is now
7843 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7844 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7846 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7849 * ccl.c (Fccl_execute_on_string): Declare some variables
7852 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7854 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7856 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7858 * process.c (Fformat_network_address): Doc fix.
7860 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7862 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7864 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7866 * keyboard.c (read_char): Call Lisp function help-form-show,
7867 instead of using internal_with_output_to_temp_buffer.
7868 (Qhelp_form_show): New var.
7869 (syms_of_keyboard): Use DEFSYM macro.
7871 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7873 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7875 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7877 * process.c (Flist_processes): Remove to Lisp.
7878 (list_processes_1): Delete.
7880 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7882 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7884 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7886 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7888 Fix more problems found by GCC 4.6.0's static checks.
7890 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7892 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7894 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7896 * xdisp.c (vmessage): Mark as a printf-like function.
7898 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7900 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7902 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7903 printf-like functions.
7904 (tiff_load): Add casts to remove these marks before passing them
7905 to system-supplied API.
7907 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7909 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7910 This avoids several warnings with gcc -Wstrict-overflow.
7911 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7912 directly, rather than having caller test rule sign. This avoids
7913 some unnecessary tests.
7914 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7915 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7916 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7918 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7919 (xfont_open): Avoid unnecessary tests.
7921 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7923 * composite.h, composite.c (composition_gstring_put_cache):
7924 Use EMACS_INT, not int, for length.
7926 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7927 breaking out part of COMPOSITION_DECODE_RULE.
7928 (COMPOSITION_DECODE_RULE): Use it.
7929 * composite.c (get_composition_id): Remove unused local vars,
7930 by using the new macro.
7932 * textprop.c (set_text_properties_1): Change while to do-while,
7933 since the condition is always true at first.
7935 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7936 (interval_deletion_adjustment): Return unsigned value.
7939 * process.c (list_processes_1, create_pty, read_process_output):
7940 (exec_sentinel): Remove vars that were set but not used.
7941 (create_pty): Remove unnecessary "volatile"s.
7942 (Fnetwork_interface_info): Avoid possibility of int overflow.
7943 (read_process_output): Do adaptive read buffering even if carryover.
7944 (read_process_output): Simplify nbytes computation if buffered.
7946 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7948 * syntax.c (scan_words): Remove var that was set but not used.
7949 (update_syntax_table): Use unsigned instead of int.
7951 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7952 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7953 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7955 * print.c (print_error_message): Avoid int overflow.
7957 * font.c (font_list_entities): Redo for clarity,
7958 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7960 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7961 (font_score): Avoid potential overflow in diff calculation.
7963 * fns.c (substring_both): Remove var that is set but not used.
7964 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7966 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7968 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7969 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7970 can always succeed if overflow has undefined behavior.
7972 * search.c (boyer_moore, wordify): Remove vars set but not used.
7973 (wordify): Omit three unnecessary tests.
7975 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7976 All callers changed. This avoids the need for an unused var.
7978 * casefiddle.c (casify_region): Remove var that is set but not used.
7980 * dired.c (file_name_completion): Remove var that is set but not used.
7982 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7984 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7985 (Finsert_file_contents): Remove unnecessary code checking fd.
7987 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7988 Check for integer overflow on size calculations.
7990 * buffer.c (Fprevious_overlay_change): Remove var that is set
7993 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7994 Remove vars that are set but not used.
7995 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7996 (timer_check_2): Mark vars as initialized.
7998 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8000 * image.c (lookup_image): Remove var that is set but not used.
8001 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8003 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8004 that are set but not used.
8006 * xfns.c (make_invisible_cursor): Don't return garbage
8007 if XCreateBitmapFromData fails (Bug#8410).
8009 * xselect.c (x_get_local_selection, x_handle_property_notify):
8010 Remove vars that are set but not used.
8012 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8013 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8015 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8016 Remove var that is set but not used.
8017 (scroll_bar_windows_size): Now size_t, not int.
8018 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8021 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8022 (map_tty_color) [!defined MSDOS]: Likewise.
8024 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8026 * coding.c: Remove vars that are set but not used.
8027 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8028 All callers changed.
8029 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8030 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8031 (decode_coding_charset): Remove vars that are set but not used.
8033 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8034 that is set but not used.
8036 * print.c (print_object): Remove var that is set but not used.
8038 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8039 The gnulib version avoids calling malloc in the usual case,
8040 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8041 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8042 * filelock.c (current_lock_owner): Likewise.
8043 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8044 * sysdep.c: Include allocator.h, careadlinkat.h.
8045 (emacs_no_realloc_allocator): New static constant.
8046 (emacs_readlink): New function.
8047 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8048 ../lib/careadlinkat.h.
8050 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8052 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8053 first non-nil return value).
8055 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8057 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8058 if not defined (Bug#8403).
8060 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8062 * xdisp.c (display_count_lines): Remove parameter `start',
8063 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8064 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8065 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8066 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8067 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8068 and thereabouts. All callers changed.
8069 (get_per_char_metric): Remove parameter `f', unused since
8070 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8072 2011-04-02 Jim Meyering <meyering@redhat.com>
8074 do not dereference NULL upon failed strdup
8075 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8076 (ns_get_family): Likewise.
8078 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8080 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8082 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8084 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8087 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8089 Add lexical binding.
8091 * window.c (Ftemp_output_buffer_show): New fun.
8092 (Fsave_window_excursion):
8093 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8095 * lread.c (lisp_file_lexically_bound_p): New function.
8096 (Fload): Bind Qlexical_binding.
8097 (readevalloop): Remove `evalfun' arg.
8098 Bind Qinternal_interpreter_environment.
8099 (Feval_buffer): Bind Qlexical_binding.
8100 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8102 (syms_of_lread): Declare `lexical-binding'.
8104 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8106 * keyboard.c (eval_dyn): New fun.
8107 (menu_item_eval_property): Use it.
8109 * image.c (parse_image_spec): Use Ffunctionp.
8111 * fns.c (concat, mapcar1): Accept byte-code-functions.
8113 * eval.c (Fsetq): Handle lexical vars.
8114 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8115 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8116 (FletX, Flet): Obey lexical binding.
8117 (Fcommandp): Handle closures.
8118 (Feval): New `lexical' arg.
8119 (eval_sub): New function extracted from Feval. Use it almost
8120 everywhere where Feval was used. Look up vars in lexical env.
8122 (Ffunctionp): Move from subr.el.
8123 (Ffuncall): Handle closures.
8124 (apply_lambda): Remove `eval_flags'.
8125 (funcall_lambda): Handle closures and new byte-code-functions.
8126 (Fspecial_variable_p): New function.
8127 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8128 but without exporting it to Lisp.
8130 * doc.c (Fdocumentation, store_function_docstring):
8131 * data.c (Finteractive_form): Handle closures.
8133 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8136 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8138 (exec_byte_code): New function extracted from Fbyte_code to handle new
8139 calling convention for byte-code-functions. Add new byte-codes.
8141 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8143 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8145 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8147 * xdisp.c (redisplay_internal): Fix prototype.
8149 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8151 * xdisp.c (SCROLL_LIMIT): New macro.
8152 (try_scrolling): Use it when setting scroll_limit.
8153 Limit scrolling to 100 screen lines.
8154 (redisplay_window): Even when falling back on "recentering",
8155 position point in the window according to scroll-conservatively,
8156 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8158 (try_scrolling): When point is above the window, allow searching
8159 as far as scroll_max, or one screenful, to compute vertical
8160 distance from PT to the scroll margin position. This prevents
8161 try_scrolling from unnecessarily failing when
8162 scroll-conservatively is set to a value slightly larger than the
8163 window height. Clean up the case of PT below the margin at bottom
8164 of window: scroll_max can no longer be INT_MAX. When aggressive
8165 scrolling is in use, don't let point enter the opposite scroll
8166 margin as result of the scroll.
8167 (syms_of_xdisp) <scroll-conservatively>: Document the
8168 threshold of 100 lines for never-recentering scrolling.
8170 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8172 * dispextern.h (move_it_by_lines):
8173 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8174 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8175 (message_log_check_duplicate): Remove parameters `prev_bol' and
8176 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8177 (redisplay_internal): Remove parameter `preserve_echo_area',
8178 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8180 * indent.c (Fvertical_motion):
8181 * window.c (window_scroll_pixel_based, Frecenter):
8182 Don't pass `need_y_p' to `move_it_by_lines'.
8184 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8186 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8187 steal a few bits to be more compact.
8188 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8189 Remove unneeded casts.
8191 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8193 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8195 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8196 binding" message (bug#7967).
8198 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8200 Fix more problems found by GCC 4.6.0's static checks.
8202 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8203 Remove unused local var.
8205 * editfns.c (Fmessage_box): Remove unused local var.
8207 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8208 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8209 Omit unused local vars.
8210 * window.c (shrink_windows): Omit unused local var.
8211 * menu.c (digest_single_submenu): Omit unused local var.
8212 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8213 Omit unused local var.
8215 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8216 Don't assume string length fits in int.
8217 (keyremap_step, read_key_sequence): Use size_t for sizes.
8218 (read_key_sequence): Don't check last_real_key_start redundantly.
8220 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8221 instead of alloca (Bug#8344).
8223 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8224 (Fbacktrace_frame): Don't assume nframes fits in int.
8226 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8228 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8231 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8233 * cm.c (calccost): Turn while-do into do-while, for clarity.
8235 * keyboard.c (syms_of_keyboard): Use the same style as later
8236 in this function when indexing through an array. This also
8237 works around GCC bug 48267.
8239 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8241 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8243 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8244 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8246 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8247 This avoids undefined behavior on integer overflow, and is a bit
8248 more convenient anyway since it is compared to a size_t variable.
8250 Variadic C functions now count arguments with size_t, not int.
8251 This avoids an unnecessary limitation on 64-bit machines, which
8252 caused (substring ...) to crash on large vectors (Bug#8344).
8253 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8254 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8255 All variadic functions and their callers changed accordingly.
8256 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8257 * data.c (arith_driver, float_arith_driver): Likewise.
8258 * editfns.c (general_insert_function): Likewise.
8259 * eval.c (struct backtrace.nargs, interactive_p)
8260 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8261 (funcall_lambda, mark_backtrace): Likewise.
8262 * fns.c (concat): Likewise.
8263 * frame.c (x_set_frame_parameters): Likewise.
8264 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8265 0 if not found, not -1. All callers changed.
8267 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8268 (stack_copy_size): Now size_t, not int.
8269 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8271 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8273 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8274 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8275 All callers changed.
8277 * lisp.h (multibyte_char_to_unibyte):
8278 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8279 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8280 * character.h (CHAR_TO_BYTE8):
8281 * cmds.c (internal_self_insert):
8282 * editfns.c (general_insert_function):
8283 * keymap.c (push_key_description):
8284 * search.c (Freplace_match):
8285 * xdisp.c (message_dolog, set_message_1): All callers changed.
8287 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8289 * keyboard.c (safe_run_hook_funcall): New function.
8290 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8291 don't set the hook to nil, but remove the offending function instead.
8292 (Qcommand_hook_internal): Remove, unused.
8293 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8294 Vcommand_hook_internal.
8296 * eval.c (enum run_hooks_condition): Remove.
8297 (funcall_nil, funcall_not): New functions.
8298 (run_hook_with_args): Call each function through a `funcall' argument.
8299 Remove `cond' argument, now redundant.
8300 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8301 (Frun_hook_with_args_until_failure): Adjust accordingly.
8302 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8304 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8306 * dispextern.h (string_buffer_position): Remove declaration.
8308 * print.c (strout): Remove parameter `multibyte', unused since
8309 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8311 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8312 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8313 All callers changed.
8315 * w32.c (_wsa_errlist): Use braces for struct initializers.
8317 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8318 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8319 All callers changed.
8320 (string_buffer_position): Likewise. Also, make static (it's never
8321 used outside xdisp.c).
8322 (cursor_row_p): Remove parameter `w', unused since
8323 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8324 (decode_mode_spec): Remove parameter `precision', introduced during
8325 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8326 All callers changed.
8328 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8330 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8332 2011-03-27 Anders Lindgren <andlind@gmail.com>
8334 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8335 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8336 (ns_update_auto_hide_menu_bar): New functions.
8337 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8338 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8339 ns_constrain_all_frames.
8340 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8341 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8343 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8345 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8347 2011-03-27 Glenn Morris <rgm@gnu.org>
8349 * syssignal.h: Replace RETSIGTYPE with void.
8350 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8351 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8352 Replace SIGTYPE with void everywhere.
8353 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8354 * s/template.h (SIGTYPE): Remove commented out definition.
8356 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8358 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8359 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8361 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8363 * w32.c (read_unc_volume): Use parameter `henum', instead of
8364 global variable `wget_enum_handle'.
8366 * keymap.c (describe_vector): Remove parameters `indices' and
8367 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8368 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8370 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8372 * keyboard.c (timer_check): Remove parameter `do_it_now',
8373 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8374 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8375 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8377 * keyboard.c (read_char):
8378 * w32menu.c (w32_menu_display_help):
8379 * xmenu.c (show_help_event, menu_help_callback):
8380 Adjust calls to `show_help_echo'.
8382 * gtkutil.c (xg_maybe_add_timer):
8383 * keyboard.c (readable_events):
8384 * process.c (wait_reading_process_output):
8385 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8387 * insdel.c (adjust_markers_gap_motion):
8388 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8389 (gap_left, gap_right): Don't call it.
8391 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8393 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8394 incurred during fontification.
8396 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8398 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8399 (DEFVAR_PER_BUFFER): Don't pass it.
8401 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8402 (scrolling_window): Don't pass it.
8404 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8406 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8408 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8410 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8411 of variables specific to SELinux and computation of `encoded_absname'.
8413 * image.c (XPutPixel): Remove unused variable `height'.
8415 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8417 * unexw32.c (get_section_info): Remove unused variable `section'.
8419 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8420 (system_process_attributes): Remove unused variable `sess'.
8421 (sys_read): Remove unused variable `err'.
8423 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8424 (w32_wnd_proc): Remove unused variable `isdead'.
8425 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8426 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8427 (x_create_tip_frame): Remove unused variable `tem'.
8429 * w32inevt.c (w32_console_read_socket):
8430 Remove unused variable `no_events'.
8432 * w32term.c (x_draw_composite_glyph_string_foreground):
8433 Remove unused variable `width'.
8435 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8437 * w32term.c (x_set_glyph_string_clipping):
8438 Don't pass uninitialized region to CombineRgn.
8440 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8442 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8443 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8444 (Fx_close_connection): Remove unused variable `i'.
8446 * w32font.c (w32font_draw): Return number of glyphs.
8447 (w32font_open_internal): Remove unused variable `i'.
8448 (w32font_driver): Add missing initializer.
8450 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8451 (fill_in_menu): Remove unused variable `items_added'.
8453 * w32term.c (last_mouse_press_frame): Remove static global variable.
8454 (w32_clip_to_row): Remove unused variable `f'.
8455 (x_delete_terminal): Remove unused variable `i'.
8457 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8458 (NOTHING): Remove unused static global variable.
8459 (uniscribe_check_otf): Remove unused variable `table'.
8460 (uniscribe_font_driver): Add missing initializers.
8462 2011-03-23 Julien Danjou <julien@danjou.info>
8464 * term.c (Fsuspend_tty, Fresume_tty):
8465 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8466 * window.c (temp_output_buffer_show):
8467 * insdel.c (signal_before_change):
8468 * frame.c (Fhandle_switch_frame):
8469 * fileio.c (Fdo_auto_save):
8470 * emacs.c (Fkill_emacs):
8471 * editfns.c (save_excursion_restore):
8472 * cmds.c (internal_self_insert):
8473 * callint.c (Fcall_interactively):
8474 * buffer.c (Fkill_all_local_variables):
8475 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8477 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8478 unconditionally since it does the check itself.
8480 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8482 Fix more problems found by GCC 4.5.2's static checks.
8484 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8485 the first time through the loop, since we know p0 < p1 then.
8486 This also avoids a gcc -Wstrict-overflow warning.
8488 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8489 leading to a memory leak, possible in functions like
8490 load_charset_map_from_file that can allocate an unbounded number
8491 of objects (Bug#8318).
8493 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8494 that could (at least in theory) be that large.
8496 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8497 This is less likely to overflow, and avoids undefined behavior if
8498 overflow does occur. All callers changed. Use strtoul to scan
8499 for the unsigned long integer.
8500 (pint2hrstr): Simplify and tune code slightly.
8501 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8503 * scroll.c (do_scrolling): Work around GCC bug 48228.
8504 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8506 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8507 This also avoids a warning with gcc -Wstrict-overflow.
8508 (validate_x_resource_name): Simplify count usage.
8509 This also avoids a warning with gcc -Wstrict-overflow.
8511 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8514 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8516 * process.c (Fmake_network_process): Use socklen_t, not int,
8517 where POSIX says socklen_t is required in portable programs.
8518 This fixes a porting bug on hosts like 64-bit HP-UX, where
8519 socklen_t is wider than int (Bug#8277).
8520 (Fmake_network_process, server_accept_connection):
8521 (wait_reading_process_output, read_process_output):
8524 * process.c: Rename or move locals to avoid shadowing.
8525 (list_processes_1, Fmake_network_process):
8526 (read_process_output_error_handler, exec_sentinel_error_handler):
8527 Rename or move locals.
8528 (Fmake_network_process): Define label "retry_connect" only if needed.
8529 (Fnetwork_interface_info): Fix pointer signedness.
8530 (process_send_signal): Add cast to avoid pointer signedness problem.
8531 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8532 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8534 Make tparam.h and terminfo.c consistent.
8535 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8536 Include tparam.h instead, since it declares them.
8537 * cm.h (PC): Remove extern decl; tparam.h now does this.
8538 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8539 * terminfo.c: Include tparam.h, to check interfaces.
8540 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8541 (tparam): Adjust signature to match interface in tparam.h;
8542 this removes some undefined behavior. Check that outstring and len
8543 are zero, which they always are with Emacs.
8544 * tparam.h (PC, BC, UP): New extern decls.
8546 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8547 (xftfont_open): Rename locals to avoid shadowing.
8549 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8550 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8551 (OTF_TAG_SYM): Omit macro if not needed.
8552 (ftfont_list): Remove unused local.
8553 (get_adstyle_property, ftfont_pattern_entity):
8554 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8555 Rename locals to avoid shadowing.
8557 * xfont.c (xfont_list_family): Mark var as initialized.
8559 * xml.c (make_dom): Now static.
8561 * composite.c (composition_compute_stop_pos): Rename local to
8563 (composition_reseat_it): Remove unused locals.
8564 (find_automatic_composition, composition_adjust_point): Likewise.
8565 (composition_update_it): Mark var as initialized.
8566 (find_automatic_composition): Mark vars as initialized,
8567 with a FIXME (Bug#8290).
8569 character.h: Rename locals to avoid shadowing.
8570 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8571 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8572 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8573 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8576 * textprop.c (property_change_between_p): Remove; unused.
8578 * intervals.c (interval_start_pos): Now static.
8580 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8582 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8583 Rename locals to avoid shadowing.
8585 * sound.c (wav_play, au_play, Fplay_sound_internal):
8586 Fix pointer signedness.
8587 (alsa_choose_format): Remove unused local var.
8588 (wav_play): Initialize a variable to 0, to prevent undefined
8589 behavior (Bug#8278).
8591 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8593 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8595 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8596 clobbering (Bug#8298).
8597 * sysdep.c (sys_subshell): Likewise.
8598 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8600 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8601 This should get cleaned up, so that child_setup has the
8602 same signature on all platforms.
8604 * callproc.c (call_process_cleanup): Now static.
8605 (relocate_fd): Rename locals to avoid shadowing.
8607 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8609 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8610 not to be necessary, and produces flickering.
8612 2011-03-20 Glenn Morris <rgm@gnu.org>
8614 * config.in: Remove file.
8616 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8618 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8619 are now in src/globals.h.
8620 (syms_of_minibuf): Remove spurious & from previous change.
8622 2011-03-20 Leo Liu <sdl.web@gmail.com>
8624 * minibuf.c (completing-read-function): New variable.
8625 (completing-read-default): Rename from completing-read.
8626 (completing-read): Call completing-read-function.
8628 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8630 * xfaces.c (Fx_load_color_file):
8631 Read color file from absolute filename (bug#8250).
8633 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8635 * makefile.w32-in: Update dependencies.
8637 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8639 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8641 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8643 Fix more problems found by GCC 4.5.2's static checks.
8645 * process.c (make_serial_process_unwind, send_process_trap):
8646 (sigchld_handler): Now static.
8648 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8649 That way, the code declares only the vars that it needs.
8650 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8651 * s/cygwin.h (PTY_ITERATION): Likewise.
8652 * s/darwin.h (PTY_ITERATION): Likewise.
8653 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8655 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8656 * process.c (allocate_pty): Don't declare stb unless it's needed.
8658 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8659 (CONSTANTLIM): Remove; unused.
8660 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8661 Define only if needed.
8663 * unexelf.c (unexec): Name an expression,
8664 to avoid gcc -Wbad-function-cast warning.
8665 Use a different way to cause a compilation error if anyone uses
8666 n rather than nn, a way that does not involve shadowing.
8667 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8669 * deps.mk (unexalpha.o): Remove; unused.
8671 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8672 * unexec.h: New file.
8673 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8674 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8676 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8677 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8678 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8679 Change as necessary to match prototype in unexec.h.
8681 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8683 (back_comment, skip_chars): Mark vars as initialized.
8685 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8686 Rename locals to avoid shadowing.
8688 * lread.c (read1): Rewrite so as not to use empty "else".
8689 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8691 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8693 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8694 warning when compiling print.c.
8696 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8697 instead of using an uninitialized var.
8698 (font_sort_entities): Mark var as initialized.
8700 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8702 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8703 pointers to constants.
8704 (font_parse_fcname): Remove unused vars.
8705 (font_delete_unmatched): Now static.
8706 (font_get_spec): Remove; unused.
8707 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8708 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8709 Rename or move locals to avoid shadowing.
8711 * fns.c (require_nesting_list, require_unwind): Now static.
8712 (Ffillarray): Rename locals to avoid shadowing.
8714 * floatfns.c (domain_error2): Define only if needed.
8715 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8717 * alloc.c (mark_backtrace): Move decl from here ...
8718 * lisp.h: ... to here, so that it can be checked.
8720 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8721 (Fdefvar): Rewrite so as not to use empty "else".
8722 (lisp_indirect_variable): Name an expression,
8723 to avoid gcc -Wbad-function-cast warning.
8724 (Fdefvar): Rename locals to avoid shadowing.
8726 * callint.c (quotify_arg, quotify_args): Now static.
8727 (Fcall_interactively): Rename locals to avoid shadowing.
8728 Use const pointer when appropriate.
8730 * lisp.h (get_system_name, get_operating_system_release):
8731 Move decls here, to check interfaces.
8732 * process.c (get_operating_system_release): Move decl to lisp.h.
8733 * xrdb.c (get_system_name): Likewise.
8734 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8735 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8736 some of which prompt warnings from gcc -Wbad-function-cast.
8737 (Fformat_time_string, Fencode_time, Finsert_char):
8738 (Ftranslate_region_internal, Fformat):
8739 Rename or remove local vars to avoid shadowing.
8740 (Ftranslate_region_internal): Mark var as initialized.
8742 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8745 * lisp.h (eassert): Check that the argument compiles, even if
8746 ENABLE_CHECKING is not defined.
8748 * data.c (Findirect_variable): Name an expression, to avoid
8749 gcc -Wbad-function-cast warning.
8750 (default_value, arithcompare, arith_driver, arith_error): Now static.
8751 (store_symval_forwarding): Rename local to avoid shadowing.
8752 (Fmake_variable_buffer_local, Fmake_local_variable):
8753 Mark variables as initialized.
8754 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8756 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8757 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8758 Rename locals to avoid shadowing.
8759 (mark_stack): Move local variables into the #ifdef region where
8761 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8762 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8764 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8765 (GC_STRING_CHARS): Remove; not used.
8766 (Fmemory_limit): Cast sbrk's returned value to char *.
8768 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8769 avoids undefined behavior in theory.
8771 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8773 Use functions, not macros, for up- and down-casing (Bug#8254).
8774 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8775 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8776 to use the following functions instead of these macros.
8777 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8778 EMACS_INT, since callers assume the returned value fits in int.
8779 (upcase1): Likewise, for UPCASE_TABLE.
8780 (uppercasep, lowercasep, upcase): New static inline functions.
8781 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8782 the race-condition problem in the old DOWNCASE.
8784 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8785 Rename locals to avoid shadowing.
8786 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8787 (regex_compile, re_search_2, re_match_2_internal):
8788 Remove unused local vars.
8789 (FREE_VAR): Rewrite so as not to use empty "else",
8790 which gcc can warn about.
8791 (regex_compile, re_match_2_internal): Mark locals as initialized.
8792 (RETALLOC_IF): Define only if needed.
8793 (WORDCHAR_P): Likewise. This one is never needed, but is used
8794 only in a comment talking about a compiler bug, so put inside
8795 the #if 0 of that comment.
8796 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8797 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8800 * search.c (boyer_moore): Rename locals to avoid shadowing.
8801 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8802 (PREV_CHAR_BOUNDARY): Likewise.
8804 * search.c (simple_search): Remove unused var.
8806 * dired.c (compile_pattern): Move decl from here ...
8807 * lisp.h: ... to here, so that it can be checked.
8808 (struct re_registers): New forward decl.
8810 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8812 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8814 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8815 Rename locals to avoid shadowing.
8816 (Fvertical_motion): Mark locals as initialized.
8818 * casefiddle.c (casify_object, casify_region): Now static.
8819 (casify_region): Mark local as initialized.
8821 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8823 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8824 New macros, so that the caller can use some names other than
8825 gcpro1, gcpro2, etc.
8826 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8828 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8829 argument, for consistency with GCPRO2_VAR, etc: it is now the
8830 prefix of the variable, not the variable itself. All uses
8832 * dired.c (directory_files_internal, file_name_completion):
8833 Rename locals to avoid shadowing.
8835 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8836 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8837 dired.c's scmp function, had undefined behavior.
8838 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8839 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8840 * buffer.h: ... to here, because these macros use current_buffer,
8841 and the new implementation with inline functions needs to have
8842 current_buffer in scope now, rather than later when the macros
8844 (downcase, upcase1): New static inline functions.
8845 (DOWNCASE, UPCASE1): Reimplement using these functions.
8846 This avoids undefined behavior in expressions like
8847 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8848 from race conditions in accessing the global variables
8849 case_temp1 and case_temp2.
8850 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8851 * lisp.h (case_temp1, case_temp2): Remove their decls.
8852 * character.h (ASCII_CHAR_P): Move from here ...
8853 * lisp.h: ... to here, so that the inline functions mentioned
8856 * dired.c (directory_files_internal_unwind): Now static.
8858 * fileio.c (file_name_as_directory, directory_file_name):
8859 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8861 (file_name_as_directory): Use const pointers when appropriate.
8862 (Fexpand_file_name): Likewise. In particular, newdir might
8863 point at constant storage, so make it a const pointer.
8864 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8865 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8867 (Fset_file_times, Finsert_file_contents, auto_save_error):
8868 Rename locals to avoid shadowing.
8870 * minibuf.c (choose_minibuf_frame_1): Now static.
8871 (Ftry_completion, Fall_completions): Rename or remove locals
8874 * marker.c (bytepos_to_charpos): Remove; unused.
8876 * lisp.h (verify_bytepos, count_markers): New decls,
8877 so that gcc does not warn that these functions aren't declared.
8879 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8880 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8881 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8882 (copy_text): Remove unused local var.
8884 * filelock.c (within_one_second): Now static.
8885 (lock_file_1): Rename local to avoid shadowing.
8887 * buffer.c (fix_overlays_before): Mark locals as initialized.
8888 (fix_start_end_in_overlays): Likewise. This function should be
8889 simplified by using pointers-to-pointers, but that's a different
8891 (switch_to_buffer_1): Now static.
8892 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8893 (report_overlay_modification): Rename locals to avoid shadowing.
8895 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8896 Fix pointer signedness issue.
8897 (sys_subshell): Mark local as volatile if checking for lint,
8898 to suppress a gcc -Wclobbered warning that does not seem to be right.
8899 (MAXPATHLEN): Define only if needed.
8901 * process.c (serial_open, serial_configure): Move decls from here ...
8902 * systty.h: ... to here, so that they can be checked.
8904 * fns.c (get_random, seed_random): Move extern decls from here ...
8905 * lisp.h: ... to here, so that they can be checked.
8907 * sysdep.c (reset_io): Now static.
8908 (wait_for_termination_signal): Remove; unused.
8910 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8911 (copy_keymap_item, append_key, push_text_char_description):
8913 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8914 (DENSE_TABLE_SIZE): Remove; unused.
8915 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8916 (describe_map_tree):
8917 Rename locals to avoid shadowing.
8919 * keyboard.c: Declare functions static if they are not used elsewhere.
8920 (echo_char, echo_dash, cmd_error, top_level_2):
8921 (poll_for_input, handle_async_input): Now static.
8922 (read_char, kbd_buffer_get_event, make_lispy_position):
8923 (make_lispy_event, make_lispy_movement, apply_modifiers):
8924 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8925 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8926 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8927 (read_key_sequence, read_char): Mark locals as initialized.
8928 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8930 * keyboard.h (make_ctrl_char): New decl.
8931 (mark_kboards): Move decl here ...
8932 * alloc.c (mark_kboards): ... from here.
8934 * lisp.h (force_auto_save_soon): New decl.
8936 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8937 (DEFINE_DUMMY_FUNCTION): New macro.
8938 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8940 (main): Add casts to avoid warnings
8941 if GCC considers string literals to be constants.
8943 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8945 * dbusbind.c: Pointer signedness fixes.
8946 (xd_signature, xd_append_arg, xd_initialize):
8947 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8948 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8949 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8950 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8952 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8953 if GCC considers string literals to be constants.
8954 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8956 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8958 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8959 (print_preprocess, print_object): New macro to fix last change.
8961 * print.c (print_preprocess): Don't forget font objects.
8963 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8965 * emacs.c (USAGE3): Doc fixes.
8967 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8969 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8972 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8974 * lisp.h (VWindow_system, Qfile_name_history):
8975 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8976 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8977 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8979 * w32select.c: Don't #include "keyboard.h".
8980 (run_protected): Add extern declaration for waiting_for_input.
8982 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8983 * w32console.c (detect_input_pending, read_input_pending)
8984 (encode_terminal_code):
8985 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8986 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8987 (w32_system_caret_y, Qfile_name_history):
8988 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8989 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8990 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8991 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8992 * w32proc.c (Qlocal, report_file_error):
8993 * w32term.c (Vwindow_system, updating_frame):
8994 * w32uniscribe.c (initialized, uniscribe_font_driver):
8995 Remove unneeded extern declarations.
8997 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8999 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9001 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9003 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9004 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9005 These macros can no longer be used for assignment.
9007 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9008 Assign struct members directly, instead of using BUF_BEGV etc.
9009 (record_buffer_markers, fetch_buffer_markers): New functions for
9010 recording and fetching special buffer markers.
9011 (set_buffer_internal_1, set_buffer_temp): Use them.
9013 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9015 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9017 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9018 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9020 * xdisp.c (hscroll_window_tree):
9021 (reconsider_clip_changes): Use PT instead of BUF_PT.
9023 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9025 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9026 $(EMACS_ROOT)/lib/intprops.h.
9028 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9030 Fix more problems found by GCC 4.5.2's static checks.
9032 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9033 to unsigned char * to avoid compiler diagnostic.
9034 (xg_free_frame_widgets): Make it clear that a local variable is
9035 needed only if USE_GTK_TOOLTIP.
9036 (gdk_window_get_screen): Make it clear that this macro is needed
9037 only if USE_GTK_TOOLTIP.
9038 (int_gtk_range_get_value): New function, which avoids a diagnostic
9039 from gcc -Wbad-function-cast.
9040 (xg_set_toolkit_scroll_bar_thumb): Use it.
9041 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9042 diagnostic from gcc -Wbad-function-cast.
9043 (get_utf8_string, xg_get_file_with_chooser):
9044 Rename locals to avoid shadowing.
9045 (create_dialog): Move locals to avoid shadowing.
9047 * xgselect.c (xg_select): Remove unused var.
9049 * image.c (four_corners_best): Mark locals as initialized.
9050 (gif_load): Initialize transparent_p to zero (Bug#8238).
9051 Mark another local as initialized.
9052 (my_png_error, my_error_exit): Mark with NO_RETURN.
9054 * image.c (clear_image_cache): Now static.
9055 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9056 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9057 (x_edge_detection): Remove unnecessary cast that
9058 gcc -Wbad-function-cast diagnoses.
9059 (gif_load): Fix pointer signedness.
9060 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9061 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9063 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9065 Improve quality of tests for time stamp overflow.
9066 For example, without this patch (encode-time 0 0 0 1 1
9067 1152921504606846976) returns the obviously-bogus value (-948597
9068 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9069 reports time overflow. See
9070 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9071 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9072 * editfns.c: Include limits.h and intprops.h.
9073 (TIME_T_MIN, TIME_T_MAX): New macros.
9074 (time_overflow): Move earlier, to before first use.
9075 (hi_time, lo_time): New functions, for an accurate test for
9077 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9078 (Fget_internal_run_time): Don't assume time_t fits in int.
9079 (make_time): Use list2 instead of Fcons twice.
9080 (Fdecode_time): More accurate test for out-of-range times.
9081 (check_tm_member): New function.
9082 (Fencode_time): Use it, to test for out-of-range times.
9083 (lisp_time_argument): Don't rely on undefined left-shift and
9084 right-shift behavior when checking for time stamp overflow.
9086 * editfns.c (time_overflow): New function, refactoring common code.
9087 (Fformat_time_string, Fdecode_time, Fencode_time):
9088 (Fcurrent_time_string): Use it.
9090 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9091 * dired.c (make_time): Move to ...
9092 * editfns.c (make_time): ... here.
9093 * systime.h: Note the move.
9095 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9097 * fringe.c (update_window_fringes): Remove unused variables.
9099 * unexmacosx.c (copy_data_segment): Also copy __got section.
9102 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9104 * termcap.c [MSDOS]: Include "msdos.h".
9105 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9106 Constify `char *' arguments and their references according to
9107 prototypes in tparam.h.
9109 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9111 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9112 Adapt all references accordingly.
9114 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9116 2011-03-11 Tom Tromey <tromey@redhat.com>
9118 * buffer.c (syms_of_buffer): Remove obsolete comment.
9120 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9122 * termhooks.h (encode_terminal_code): Declare prototype.
9124 * msdos.c (encode_terminal_code): Don't declare prototype.
9126 * term.c (encode_terminal_code): Now external again, used by
9127 w32console.c and msdos.c.
9129 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9130 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9132 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9134 Fix some minor problems found by GCC 4.5.2's static checks.
9136 * fringe.c (update_window_fringes): Mark locals as initialized
9138 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9140 * alloc.c (mark_fringe_data): Move decl from here ...
9141 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9142 to check its interface.
9143 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9145 * fontset.c (free_realized_fontset): Now static.
9146 (Fset_fontset_font): Rename local to avoid shadowing.
9147 (fontset_font): Mark local as initialized.
9148 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9150 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9152 * xselect.c (x_disown_buffer_selections): Remove; not used.
9153 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9154 (x_own_selection, Fx_disown_selection_internal): Rename locals
9156 (x_handle_dnd_message): Remove local to avoid shadowing.
9158 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9159 so that the caller can use some name other than gcpro1.
9160 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9161 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9162 (Fx_backspace_delete_keys_p):
9163 Use them to avoid shadowing, and rename vars to avoid shadowing.
9164 (x_decode_color, x_set_name, x_window): Now static.
9165 (Fx_create_frame): Add braces to silence GCC warning.
9166 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9167 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9168 Remove unused locals.
9169 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9170 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9171 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9174 * xterm.h (x_mouse_leave): New decl.
9176 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9177 Remove unused functions.
9178 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9179 (x_calc_absolute_position): Now static.
9180 (XTread_socket): Don't define label "out" unless it's used.
9181 Don't declare local "event" unless it's used.
9182 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9183 unless they are used.
9184 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9185 (x_fatal_error_signal): Remove; not used.
9186 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9187 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9188 (x_error_catcher, x_connection_closed, x_error_handler):
9189 (x_error_quitter, xembed_send_message, x_iconify_frame):
9190 (my_log_handler): Rename locals to avoid shadowing.
9191 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9192 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9194 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9195 Rename or move locals to avoid shadowing.
9196 (tty_defined_color, merge_face_heights): Now static.
9197 (free_realized_faces_for_fontset): Remove; not used.
9198 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9199 does not deduce is never used uninitialized.
9200 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9201 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9203 * terminal.c (store_terminal_param): Now static.
9205 * xmenu.c (menu_highlight_callback): Now static.
9206 (set_frame_menubar): Remove unused local.
9207 (xmenu_show): Rename parameter to avoid shadowing.
9208 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9209 since they might point to immutable storage.
9210 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9211 since it's unused otherwise.
9213 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9214 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9215 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9216 avoids a gcc -Wuninitialized diagnostic.
9217 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9218 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9219 does not deduce are never used uninitialized.
9221 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9223 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9224 * window.c (window_loop, size_window):
9225 (run_window_configuration_change_hook, enlarge_window): Likewise.
9227 * window.c (display_buffer): Now static.
9228 (size_window): Mark variables that gcc -Wuninitialized
9229 does not deduce are never used uninitialized.
9230 * window.h (check_all_windows): New decl, to forestall
9231 gcc -Wmissing-prototypes diagnostic.
9232 * dispextern.h (bidi_dump_cached_states): Likewise.
9234 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9236 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9238 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9239 and to avoid gcc -Wuninitialized warning.
9240 (load_charset_map): Mark variables that gcc -Wuninitialized
9241 does not deduce are never used uninitialized.
9242 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9244 * coding.c (coding_set_source, coding_set_destination):
9245 Use "else { /* comment */ }" rather than "else /* comment */;"
9246 for clarity, and to avoid gcc -Wempty-body warning.
9247 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9248 a block, when the outer 'i' will do.
9249 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9250 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9251 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9252 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9253 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9254 Rename locals to avoid shadowing.
9255 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9256 * coding.c (emacs_mule_char, encode_invocation_designation):
9257 Now static, since they're not used elsewhere.
9258 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9259 (decode_coding_object, encode_coding_object, detect_coding_system):
9260 (decode_coding_emacs_mule): Mark variables that gcc
9261 -Wuninitialized does not deduce are never used uninitialized.
9262 (detect_coding_iso_2022): Initialize a local variable that might
9263 be used uninitialized. Leave a FIXME because it's not clear that
9264 this initialization is needed. (Bug#8211)
9265 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9266 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9267 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9268 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9269 Remove unused macros.
9271 * category.c (hash_get_category_set): Remove unused local var.
9272 (copy_category_table): Now static, since it's not used elsewhere.
9273 * character.c (string_count_byte8): Likewise.
9275 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9276 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9278 * chartab.c (copy_sub_char_table): Now static, since it's not used
9280 (sub_char_table_ref_and_range, char_table_ref_and_range):
9281 Rename locals to avoid shadowing.
9282 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9284 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9285 (BIDI_BOB): Remove unused macro.
9287 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9288 deduce are never used uninitialized.
9289 * term.c (encode_terminal_code): Likewise.
9291 * term.c (encode_terminal_code): Now static. Remove unused local.
9293 * tparam.h: New file.
9294 * term.c, tparam.h: Include it.
9295 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9296 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9297 Move these decls to tparam.h, and make them agree with what
9298 is actually in tparam.c. The previous trick of using incompatible
9299 decls in different modules does not conform to the C standard.
9300 All callers of tparam changed to use tparam's actual API.
9301 * tparam.c (tparam1, tparam, tgoto):
9302 Use const pointers where appropriate.
9304 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9305 * cm.h (struct cm): Likewise.
9306 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9307 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9308 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9309 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9310 (turn_on_face, init_tty): Likewise.
9311 * termchar.h (struct tty_display_info): Likewise.
9313 * term.c (term_mouse_position): Rename local to avoid shadowing.
9315 * alloc.c (mark_ttys): Move decl from here ...
9316 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9318 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9320 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9322 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9324 * search.c (compile_pattern_1): Remove argument regp, unused since
9325 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9326 (compile_pattern): Don't pass it.
9328 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9330 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9331 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9333 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9335 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9337 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9338 gdk_window_get_screen, gdk_window_get_geometry,
9339 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9340 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9341 (xg_get_pixbuf_from_pixmap): New function.
9342 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9343 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9344 Call xg_get_pixbuf_from_pixmap instead of
9345 gdk_pixbuf_get_from_drawable.
9346 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9347 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9348 (xg_check_special_colors): Use GtkStyleContext and its functions
9350 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9351 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9352 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9353 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9354 Call gtk_widget_get_preferred_size.
9355 (xg_frame_resized): gdk_window_get_geometry only takes 5
9357 (xg_win_to_widget, xg_event_is_for_menubar):
9358 Call gdk_x11_window_lookup_for_display.
9359 (xg_set_widget_bg): New function.
9360 (delete_cb): New function.
9361 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9362 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9363 (xg_set_background_color): Call xg_set_widget_bg.
9364 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9365 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9366 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9367 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9369 (update_frame_tool_bar): Call gtk_widget_hide.
9370 (xg_initialize): Use GDK_KEY_g.
9372 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9374 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9376 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9377 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9378 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9380 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9382 * w32xfns.c (select_palette): Check success of RealizePalette against
9383 GDI_ERROR, not zero.
9385 See ChangeLog.11 for earlier changes.
9391 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9393 This file is part of GNU Emacs.
9395 GNU Emacs is free software: you can redistribute it and/or modify
9396 it under the terms of the GNU General Public License as published by
9397 the Free Software Foundation, either version 3 of the License, or
9398 (at your option) any later version.
9400 GNU Emacs is distributed in the hope that it will be useful,
9401 but WITHOUT ANY WARRANTY; without even the implied warranty of
9402 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9403 GNU General Public License for more details.
9405 You should have received a copy of the GNU General Public License
9406 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.