1 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6 behave as if the cursor position were at the window margin.
8 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
9 and the cursor position is out of bounds, behave as if the cursor
10 position were at the window margin. (Bug#10075)
12 2011-11-18 Chong Yidong <cyd@gnu.org>
14 * window.c (Fwindow_combination_limit): Make first argument
15 non-optional, since it is meaningless for live windows like the
18 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
20 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
22 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
24 * intervals.c: Fix grafting over the whole buffer (bug#10071).
25 (graft_intervals_into_buffer): Simplify.
27 2011-11-18 Eli Zaretskii <eliz@gnu.org>
29 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
30 hash values of the two rows.
31 (copy_row_except_pointers): Preserve the used[] arrays and the
32 hash values of the two rows. (Bug#10035)
33 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
35 * xdisp.c (row_hash): New function, body extracted from
37 (compute_line_metrics): Call row_hash, instead of computing the
40 * dispnew.c (verify_row_hash): Call row_hash for computing the
41 hash code of a row, instead of duplicating code from xdisp.c.
43 * dispextern.h (row_hash): Add prototype.
45 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
47 * frame.c (delete_frame): Don't delete the terminal when the last
48 X frame is closed if emacs is built with GTK toolkit.
50 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
52 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
54 2011-11-17 Martin Rudalics <rudalics@gmx.at>
56 * window.c (Vwindow_splits): Rename to
57 Vwindow_combination_resize. Suggested by Juri Linkov.
58 (Fsplit_window_internal): Use Vwindow_combination_resize instead
61 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
63 * nsfns.m (Fns_font_name):
64 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
66 2011-11-16 Martin Rudalics <rudalics@gmx.at>
68 * window.h (window): Rename slot "nest" to "combination_limit".
69 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
70 (Fset_window_nest): Rename to Fset_window_combination_limit.
71 (Vwindow_nest): Rename to Vwindow_combination_limit.
72 (recombine_windows, make_parent_window, make_window)
73 (Fsplit_window_internal, saved_window)
74 (Fset_window_configuration, save_window_save): Rename all
75 occurrences of window_nest to window_combination_limit.
77 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
79 * image.c (imagemagick_load_image): Fix typo.
81 2011-11-14 Eli Zaretskii <eliz@gnu.org>
83 * xdisp.c (display_line): Move the call to
84 highlight_trailing_whitespace before the call to
85 compute_line_metrics, since the latter needs to see the final
86 faces of all the glyphs to compute ROW's hash value. Fixes
87 assertion violations in row_equal_p. (Bug#10035)
89 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
91 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
92 just return (bug#10044).
94 2011-11-12 Eli Zaretskii <eliz@gnu.org>
96 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
97 with user-defined heap size. Bump the default size of the temacs
98 heap to 27MB, to avoid memory warning when running temacs.
99 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
101 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
102 current_matrix and desired_matrix. (Bug#9990)
103 (verify_row_hash) [XASSERTS]: New function.
104 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
105 that the hash value of glyph rows is correct.
107 2011-11-12 Martin Rudalics <rudalics@gmx.at>
109 * window.h (window): Remove splits slot.
110 * window.c (Fwindow_splits, Fset_window_splits): Remove.
111 (Fdelete_other_windows_internal, make_parent_window)
112 (make_window, Fsplit_window_internal, Fdelete_window_internal)
113 (Fset_window_configuration, save_window_save): Don't deal with
114 split status of windows.
115 (saved_window): Remove splits slot.
116 (Vwindow_splits): Rewrite doc-string.
118 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
120 * xfns.c (unwind_create_frame):
121 * nsfns.m (unwind_create_frame):
122 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
123 Vframe_list (Bug#9999).
125 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
127 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
129 2011-11-11 Kenichi Handa <handa@m17n.org>
131 * callproc.c (Fcall_process): Set the member dst_multibyte of
134 2011-11-11 Johan Bockgård <bojohan@gnu.org>
136 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
137 avoid a crash (bug#9496).
139 2011-11-09 Chong Yidong <cyd@gnu.org>
141 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
142 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
144 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
146 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
148 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
150 Avoid some portability problems by eschewing 'extern inline' functions.
151 The trivial performance wins aren't worth the portability hassles; see
152 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
154 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
155 (window_box_width, window_box_left, window_box_left_offset)
156 (window_box_right, window_box_right_offset): Undo previous change,
157 by removing the "extern"s.
158 * intervals.c (adjust_intervals_for_insertion)
159 (adjust_intervals_for_deletion): Undo previous change,
160 making these static again.
161 (offset_intervals, temp_set_point_both, temp_set_point)
162 (copy_intervals_to_string): No longer inline.
163 * xdisp.c (window_text_bottom_y, window_box_width)
164 (window_box_height, window_box_left_offset)
165 (window_box_right_offset, window_box_left, window_box_right)
166 (window_box): No longer inline.
168 2011-11-08 Chong Yidong <cyd@gnu.org>
170 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
171 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
172 an error if not a live window.
173 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
174 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
176 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
178 * lisp.h (syms_of_abbrev): Remove declaration.
179 Reported by CHENG Gao <chenggao@royau.me>.
181 2011-11-07 Eli Zaretskii <eliz@gnu.org>
183 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
184 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
185 of temacs in GUI mode.
187 2011-11-07 Martin Rudalics <rudalics@gmx.at>
189 * window.h: Declare delete_all_child_windows instead of
190 delete_all_subwindows.
191 * window.c (Fwindow_nest, Fset_window_nest)
192 (Fset_window_new_total, Fset_window_new_normal)
193 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
194 (delete_all_subwindows): Rename to delete_all_child_windows.
195 (Fdelete_other_windows_internal, Fset_window_configuration):
196 Call delete_all_child_windows instead of delete_all_subwindows.
197 * frame.c (delete_frame): Call delete_all_child_windows instead
198 of delete_all_subwindows.
200 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
202 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
203 This is also needed for porting to any host where GC_MARK_STACK is
204 not GC_MAKE_GCPROS_NOOPS.
205 (which_symbols): Use it.
207 2011-11-07 Kenichi Handa <handa@m17n.org>
209 * coding.c (coding_set_destination): Check coding->src_pos only
210 when coding->src_object is a buffer (bug#9910).
212 * process.c (send_process): Set the member src_multibyte of coding
213 to 0 (bug#9911) when sending a unibyte text.
215 * callproc.c (Fcall_process): Set the member src_multibyte of
216 process_coding to 0 (bug#9912).
218 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
220 * xmenu.c (cleanup_widget_value_tree): New function.
221 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
222 calling free_menubar_widget_value_tree directly (Bug#9830).
224 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
226 Fix some portability problems with 'inline'.
227 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
228 (window_box_width, window_box_left, window_box_left_offset)
229 (window_box_right, window_box_right_offset): Declare extern.
230 Otherwise, these inline functions do not conform to C99 and
231 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
232 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
233 * intervals.c (adjust_intervals_for_insertion)
234 (adjust_intervals_for_deletion): Now extern, because otherwise the
235 extern inline functions 'offset_intervals' couldn't refer to it.
236 (static_offset_intervals): Remove.
237 (offset_intervals): Rewrite using the old contents of
238 static_offset_intervals. The old version didn't conform to C99
239 because an extern inline function contained a reference to an
240 identifier with static linkage.
242 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
244 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
247 2011-11-06 Eli Zaretskii <eliz@gnu.org>
249 * xdisp.c (init_iterator, reseat_to_string): Don't set the
250 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
251 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
252 return Qleft_to_right.
254 2011-11-06 Chong Yidong <cyd@gnu.org>
256 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
257 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
258 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
259 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
260 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
261 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
262 (Fwindow_vscroll): Doc fix.
263 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
264 argument, since it makes no sense to pass a live window and for
265 consistency with window-child.
267 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
269 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
272 2011-11-05 Jason Rumney <jasonr@gnu.org>
274 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
275 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
277 (add_font_entity_to_list): Fix logic errors in mixed boolean and
278 bitwise arithmetic preventing use of unicode-sip and non-truetype
281 2011-11-05 Eli Zaretskii <eliz@gnu.org>
283 * s/ms-w32.h (fstat, stat, utime): Move redirections to
286 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
287 initialization code to keep similarity to xfns.c after changes
290 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
292 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
293 (unwind_create_frame): New function (Bug#9943).
294 (Fx_create_frame): Restructure code to be more similar to the one in
295 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
296 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
297 Move terminal->reference_count++ just before making the frame official
300 * nsterm.m (x_free_frame_resources): New function.
301 (x_destroy_window): Move code to x_free_frame_resources.
303 * xfns.c (unwind_create_frame): Fix comment.
304 (Fx_create_frame, x_create_tip_frame): Move
305 terminal->reference_count++ just before making the frame
306 official. Move initialization of image_cache_refcount and
307 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
309 2011-11-05 Eli Zaretskii <eliz@gnu.org>
311 Support MSVC build with newer versions of Visual Studio.
312 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
313 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
316 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
317 which are not supported by MSVC.
318 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
319 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
321 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
323 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
325 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
327 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
329 Support MSVC build with newer versions of Visual Studio.
330 * w32.c: Don't include w32api.h for MSVC.
331 (init_environment) [_MSC_VER]: Call sys_access, not _access.
333 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
334 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
335 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
336 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
338 (alloca) [_MSC_VER]: Define to _alloca.
340 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
342 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
344 2011-11-04 Eli Zaretskii <eliz@gnu.org>
346 * xdisp.c (note_mouse_highlight): If either of
347 previous/next-single-property-change returns nil, treat that as
348 the beginning or the end of the buffer. (Bug#9955)
350 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
352 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
353 label is not null (Bug#9951).
354 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
357 2011-11-04 Eli Zaretskii <eliz@gnu.org>
359 * window.c (Fwindow_body_size): Mention in the doc string that the
360 return value is in frame's canonical units. (Bug#9949)
362 2011-11-03 Eli Zaretskii <eliz@gnu.org>
364 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
366 * w32fns.c (unwind_create_frame): If needed, free the glyph
367 matrices of the partially constructed frame. (Bug#9943)
368 * xfns.c (unwind_create_frame): Likewise.
370 2011-11-01 Eli Zaretskii <eliz@gnu.org>
372 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
373 Don't stop backward scan on the continuation glyph, even though
374 its CHARPOS is positive.
375 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
376 cover_string to disp_string.
378 2011-11-01 Martin Rudalics <rudalics@gmx.at>
380 * window.c (temp_output_buffer_show): Don't use
381 Vtemp_buffer_show_specifiers.
382 (Vtemp_buffer_show_specifiers): Remove unused variable.
384 2011-10-30 Eli Zaretskii <eliz@gnu.org>
386 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
387 past the beginning of the current glyph matrix.
389 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
391 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
392 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
393 HAVE_GTK3 (Bug#9869).
395 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
396 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
398 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
400 * xterm.c: Declare x_handle_net_wm_state to return int.
401 (handle_one_xevent): Check if we are iconified but don't have
402 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
403 (get_current_wm_state): Return non-zero if not hidden,
404 check for _NET_WM_STATE_HIDDEN (Bug#9893).
405 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
406 (x_handle_net_wm_state): Return what get_current_wm_state returns.
407 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
409 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
411 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
412 so that this new function doesn't get optimized away by a
413 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
415 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
417 * frame.h (MOUSE_HL_INFO): Remove excess parens.
419 2011-10-29 Eli Zaretskii <eliz@gnu.org>
421 Fix the `xbytecode' command.
422 * .gdbinit (xprintbytestr): New command.
423 (xwhichsymbols): Rename from `which'; all callers changed.
424 (xbytecode): Print the byte-code string as well.
426 2011-10-29 Kim Storm <storm@cua.dk>
428 * alloc.c (which_symbols): New function.
430 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
432 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
435 2011-10-29 Glenn Morris <rgm@gnu.org>
437 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
438 Not clear what it was for, and it causes various bugs. (Bug#9839)
440 2011-10-28 Eli Zaretskii <eliz@gnu.org>
442 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
443 possible random value that matches one of those tested as
444 condition to clear the mouse face.
446 2011-10-28 Chong Yidong <cyd@gnu.org>
448 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
450 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
452 * window.c (make_window): Initialize phys_cursor_on_p.
454 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
456 * lisp.h (struct Lisp_Symbol): Update comments.
458 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
460 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
462 2011-10-28 Eli Zaretskii <eliz@gnu.org>
464 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
465 <oslsachem@gmail.com> for helping to debug this.
467 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
468 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
469 (g_b_init_get_glyph_outline_w): New static variables.
470 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
471 (GetGlyphOutlineW_Proc): New typedefs.
472 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
473 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
475 (w32font_open_internal, compute_metrics):
476 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
477 instead of calling the "wide" APIs directly.
479 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
481 * w32.h (syms_of_w32font): Add prototype.
483 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
485 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
486 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
487 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
488 (Fmove_to_window_line): Doc fix.
490 2011-10-27 Chong Yidong <cyd@gnu.org>
492 * process.c (make_process): Set gnutls_state to NULL.
494 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
495 non-NULL, regardless of GNUTLS_INITSTAGE.
496 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
497 an error. Set process slots as soon as we allocate them.
499 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
501 2011-10-27 Chong Yidong <cyd@gnu.org>
503 * gnutls.c (emacs_gnutls_deinit): New function.
504 Deallocate credentials structures as well as calling gnutls_deinit.
505 (Fgnutls_deinit, Fgnutls_boot): Use it.
507 * process.c (make_process): Initialize GnuTLS credentials to NULL.
508 (deactivate_process): Call emacs_gnutls_deinit.
510 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
512 * image.c (x_create_x_image_and_pixmap):
513 * w32.c (sys_rename, w32_delayed_load):
514 * w32font.c (fill_in_logfont):
515 * w32reg.c (x_get_string_resource): Silence compiler warnings.
517 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
519 * w32fns.c (w32_default_color_map): New function,
520 extracted from Fw32_default_color_map.
521 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
523 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
525 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
527 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
529 * keyboard.c (test_undefined): New function (bug#9751).
530 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
532 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
534 * sysdep.c (init_sys_modes): Fix the check for the controlling
537 2011-10-20 Eli Zaretskii <eliz@gnu.org>
539 * dispextern.h (struct bidi_it): New member next_en_type.
541 * bidi.c (bidi_line_init): Initialize the next_en_type member.
542 (bidi_resolve_explicit_1): When next_en_pos is valid for the
543 current character, check also for next_en_type being WEAK_EN.
544 (bidi_resolve_weak): Don't enter the expensive loop if the current
545 position is before next_en_pos. Record the bidi type of the first
546 non-ET, non-BN character we find, in addition to its position.
547 (bidi_level_of_next_char): Invalidate next_en_type when
548 next_en_pos is over-stepped.
550 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
552 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
553 * editfns.c: Rewrite current-time-zone so that it invokes
554 the equivalent of (format-time-string "%Z") to get the time zone name.
555 This fixes a bug when the time zone name contains characters that
556 need converting from the system time locale to Emacs internal format.
557 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
558 that patch fixed format-time-string to do the conversion, but
559 I forgot to fix current-time-zone.
560 (format_time_string): New function, containing most of
561 what Fformat_time_string used to contain.
562 (Fformat_time_string): Rewrite in terms of format_time_string.
563 This doesn't change this function's behavior.
564 (current-time-zone): Rewrite to use format_time_string.
565 This fixes the bug reported by Michael Schierl in
566 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
567 Jason Rumney's 2007-06-07 change worked around this bug, but
569 * systime.h (tzname, timezone): Remove no-longer-used declarations.
571 2011-10-19 Eli Zaretskii <eliz@gnu.org>
573 * xdisp.c (start_display): If the character at POS is displayed
574 via a display vector, reset IT->current.dpvec_index to zero.
575 (try_window_reusing_current_matrix): If a line ends in a display
576 vector or the next line starts in a display vector, continue
577 redrawing the window even though the character position of
578 start_row was reached.
581 2011-10-18 Chong Yidong <cyd@gnu.org>
583 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
584 with nobreak-char-display too.
586 2011-10-18 Eli Zaretskii <eliz@gnu.org>
588 Fix part 3 of bug#9771.
589 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
590 (bidi_resolve_neutral): Don't enter the expensive loop looking for
591 non-neutral characters if the current character is a paragraph
592 separator (a.k.a. Newline). This avoids running the same
593 expensive loop twice, once when we consume the preceding newline
594 and the other time when the line actually needs to be displayed.
595 Avoid the loop when we see neutrals on the base embedding level
596 following a character whose directionality is the same as the
597 paragraph's. This avoids running the expensive loop when a line
598 ends in a long sequence of neutrals, like control characters.
599 Add assertion against STRONG_AL type. Slightly rearrange code
600 that determines the type of a neutral given the first non-neutral
602 (bidi_level_of_next_char): Set next_en_pos to zero when
603 invalidating its info.
605 2011-10-17 Eli Zaretskii <eliz@gnu.org>
607 * xdisp.c (push_display_prop): Determine whether to record string
608 or buffer position by IT->string, not by IT->method. Allow
609 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
610 (move_it_vertically_backward): Don't look for character position
611 immediately after the newline when in a continuation line.
614 2011-10-15 Martin Rudalics <rudalics@gmx.at>
616 * window.c (coordinates_in_window): Rewrite and delabelize
617 vertical border check. (Bug#5357) (Bug#9618)
619 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
621 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
622 errors in XSetWindowBorder (bug#9310).
624 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
626 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
627 avoid crash when xmalloc overrun checking is enabled.
629 2011-10-13 Eli Zaretskii <eliz@gnu.org>
631 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
632 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
633 cursor motion with <left> and <right> arrow keys.
635 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
636 some callers set that themselves.
638 2011-10-12 Eli Zaretskii <eliz@gnu.org>
640 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
641 display string and the previous row comes from the same string and
642 is empty. (Bug#9739) (Bug#9738)
644 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
646 * doc.c (get_doc_string): Encode file name (bug#9735).
648 2011-10-12 Eli Zaretskii <eliz@gnu.org>
650 * bidi.c (bidi_level_of_next_char):
651 * xdisp.c (get_visually_first_element): Remove old incorrect
652 comments regarding the Unicode Line Separator character.
654 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
656 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
658 * alloc.c (Fgc_status): Do not access beyond zombies array
659 boundary if nzombies > MAX_ZOMBIES.
660 * alloc.c (dump_zombies): Add missing format specifier.
662 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
664 * xdisp.c (set_cursor_from_row): Simplify conditionals,
665 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
667 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
668 Some packages use them to denote characters with modifiers.
670 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
672 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
673 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
674 matching a pp-number. Rename parameter var to var1.
676 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
678 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
680 2011-10-08 Glenn Morris <rgm@gnu.org>
682 * callint.c (Fcall_interactively): Give a more explicit error for the
683 'c' case with a non-character input. (Bug#8479)
685 2011-10-08 Eli Zaretskii <eliz@gnu.org>
687 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
689 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
690 lines that are hscrolled on the left.
692 * dispnew.c (buffer_posn_from_coords): Account for a possible
693 presence of header-line. (Bug#4426)
695 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
697 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
698 Don't advertise functionality which we discourage or doesn't work.
700 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
702 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
703 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
704 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
705 this makes Emacs dump core during garbage collection on rare
706 occasions. sizeof is obviously inferior to offsetof here, so
708 (GC_POINTER_ALIGNMENT): New macro.
709 (mark_memory): Omit 3rd (offset) arg; caller changed.
710 Don't assume EMACS_INT alignment is the same as pointer alignment.
712 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
714 * keyboard.c (read_key_sequence_remapped): New var.
715 (read_key_sequence): Compute remapping in the right buffer.
716 (command_loop_1): Use read_key_sequence's remapping directly.
718 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
720 * dired.c (file_name_completion): Don't expand file name.
721 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
722 before checking file name handler.
724 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
725 they've been requested explicitly (bug#9591).
727 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
729 * keymap.c (Fsingle_key_description): Use make_specified_string
730 instead of build_string to build string from push_key_description.
733 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
735 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
736 This fixes a Y2038 bug on 64-bit hosts.
737 * buffer.c (reset_buffer):
738 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
739 (Fclear_buffer_auto_save_failure):
740 Use 0, not -1, to represent an unset failure time, since time_t
743 Remove dependency on glibc malloc internals.
744 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
745 Move back here from lisp.h, but with their new implementations.
746 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
747 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
748 * charset.c (charset_table_init): New static var.
749 (syms_of_charset): Use it instead of xmalloc. This removes a
750 dependency on glibc malloc internals. See Eli Zaretskii's comment in
751 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
752 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
753 Move back to alloc.c.
754 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
755 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
757 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
759 * nsterm.m (windowDidResize): Call x_set_window_size only when
760 ns_in_resize is true. Otherwise set pixelwidth/height and
761 call change_frame_size (Bug#9628).
763 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
765 Port --enable-checking=all to Fedora 14 x86-64.
766 * charset.c (syms_of_charset): Also account for glibc malloc's
767 internal overhead when calculating the initial malloc maximum.
769 Port --enable-checking=all to Fedora 14 x86.
770 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
772 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
773 (overrun_check_realloc, overrun_check_free):
774 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
775 That way, xmalloc returns a properly-aligned pointer even if
776 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
777 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
778 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
779 into account when calculating the initial malloc maximum.
780 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
781 Move here from alloc.c, so that charset.c can use it too.
782 Properly align; the old code wasn't right for common 32-bit hosts
783 when configured with --enable-checking=all.
784 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
785 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
787 2011-09-29 Eli Zaretskii <eliz@gnu.org>
789 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
792 2011-09-28 Eli Zaretskii <eliz@gnu.org>
794 * xdisp.c (compute_display_string_end): If there's no display
795 string at CHARPOS, return -1.
797 * bidi.c (bidi_fetch_char): When compute_display_string_end
798 returns a negative value, treat the character as a normal
799 character not covered by a display string. (Bug#9624)
801 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
803 * lread.c (Fread_from_string): Fix typo in docstring.
805 2011-09-27 Eli Zaretskii <eliz@gnu.org>
807 * xdisp.c (handle_invisible_prop): If invisible text ends on a
808 newline, reseat the iterator instead of bidi-iterating there one
809 character at a time. (Bug#9610)
810 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
811 TO_CHARPOS if the bidi iterator is at base embedding level.
813 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
815 * lread.c (readevalloop): Use correct code for NBSP.
816 (read1): Likewise. (Bug#9608)
818 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
820 * dbusbind.c (Fdbus_register_signal): When service is not
821 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
823 2011-09-25 Glenn Morris <rgm@gnu.org>
825 * buffer.c (truncate-lines): Doc fix.
827 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
829 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
830 (Fset_window_next_buffers): Doc fix.
832 2011-09-24 Glenn Morris <rgm@gnu.org>
834 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
836 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
838 Fix minor problems found by static checking.
839 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
840 * indent.c (Fvertical_motion): Fix == vs = typo.
842 2011-09-24 Eli Zaretskii <eliz@gnu.org>
844 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
845 Default value is now t. Doc fix.
847 * indent.c (Fvertical_motion): Compute and apply the overshoot
848 logic when moving up, not only when moving down. Fix the
849 confusing name and values of the it_overshoot_expected variable;
850 logic changes accordingly. (Bug#9254) (Bug#9549)
852 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
853 CHARPOS is covered by a display string which includes newlines.
854 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
855 is covered by a display string with embedded newlines.
857 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
859 * dbusbind.c (Fdbus_register_signal): Add match rule to
860 Vdbus_registered_objects_table. (Bug#9581)
861 (Fdbus_register_method, Vdbus_registered_objects_table):
864 2011-09-24 Jim Meyering <meyering@redhat.com>
866 do not ignore write error for any output size
867 The previous change was incomplete.
868 While it makes emacs --batch detect the vast majority of stdout
869 write failures, errors were still ignored whenever the output size is
870 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
871 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
872 && echo FAIL: ignored write error
873 FAIL: ignored write error
874 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
875 && echo FAIL: ignored write error
876 FAIL: ignored write error
877 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
879 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
881 * emacs.c (Fkill_emacs): In noninteractive mode exit
882 non-successfully if a write error occurred on stdout. (Bug#9574)
884 2011-09-21 Eli Zaretskii <eliz@gnu.org>
886 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
889 * dispextern.h (struct it): Update the comment documenting what
892 2011-09-20 Eli Zaretskii <eliz@gnu.org>
894 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
895 a display string, extend search for cursor position to end of row.
896 (find_row_edges): If the row ends in a newline from a display
897 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
898 Handle the case of a display string with multiple newlines.
899 (Fcurrent_bidi_paragraph_direction): Fix search for previous
900 non-empty line. Fixes confusing cursor motion with arrow keys at
901 the beginning of a line that starts with whitespace.
903 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
905 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
908 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
910 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
913 2011-09-18 Eli Zaretskii <eliz@gnu.org>
915 * xdisp.c (display_line): Record maximum and minimum buffer
916 positions even if no glyphs were produced (e.g., by a zero-width
917 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
918 buffer positions that will be removed from the glyph row because
920 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
921 column is beyond frame width: don't subtract 1 "pixel" when
922 computing width of the stretch.
923 (reseat_at_next_visible_line_start): Undo the change made on
924 2011-09-17 that saved paragraph information and restored it after
925 the call to `reseat'. (Bug#9545)
927 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
929 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
930 and turn window cursor on if cleared (Bug#9415).
932 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
934 * search.c (boyer_moore): Take unibyte characters from pattern
935 literally. (Bug#9458)
937 2011-09-18 Eli Zaretskii <eliz@gnu.org>
939 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
941 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
943 Fix minor problem found by static checking.
944 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
945 initialized, to pacify gcc -Wuninitialized.
947 * fileio.c: Report proper errno when syscall falls.
948 (Finsert_file_contents): Save and restore errno,
949 so that report_file_error outputs the correct diagnostic.
950 (Fwrite_region) [CLASH_DETECTION]: Likewise.
952 2011-09-18 Eli Zaretskii <eliz@gnu.org>
954 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
956 2011-09-17 Eli Zaretskii <eliz@gnu.org>
958 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
959 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
961 2011-09-17 Eli Zaretskii <eliz@gnu.org>
963 * xdisp.c (reseat_at_next_visible_line_start): Keep information
964 about the current paragraph and restore it after the call to reseat.
966 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
967 (bidi_find_paragraph_start): Search back for paragraph beginning
968 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
969 (bidi_move_to_visually_next): Only trigger paragraph-related
970 computations when the last character is a newline or at EOB, not
971 just any NEUTRAL_B. (Bug#9470)
973 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
974 truncated lines if point is covered by a display string. (Bug#9524)
976 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
978 * xselect.c: Relax test for outgoing X longs (Bug#9498).
979 (cons_to_x_long): New function.
980 (lisp_data_to_selection_data): Use it. Correct the test for
981 short-versus-long data; it was negated. Break out of vector
982 loop, for efficiency, when a long datum is discovered.
984 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
986 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
988 2011-09-16 Eli Zaretskii <eliz@gnu.org>
990 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
991 GCC PR/17406) by declaring this function with external scope.
993 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
995 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
996 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
998 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1000 * editfns.c (Fformat): Correctly handle text properties on "%%".
1002 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1004 * xterm.c (x_draw_composite_glyph_string_foreground):
1005 * w32term.c (x_draw_composite_glyph_string_foreground):
1006 * term.c (encode_terminal_code):
1007 * composite.c (composition_update_it, get_composition_id):
1008 * xdisp.c (get_next_display_element)
1009 (fill_composite_glyph_string): Add comments about special meaning
1010 of TAB characters in a composition.
1012 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1014 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1015 This occurs when processing a multibyte format.
1016 Problem reported by Wolfgang Jenker.
1018 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1020 * xdisp.c (try_cursor_movement): Only check for exact match if
1021 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1023 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1025 Remove unused external symbols.
1026 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1027 * xdisp.c (calc_pixel_width_or_height): Now static.
1028 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1029 * indent.c (check_display_width):
1030 * w32term.c: Fix comment to match code.
1031 * xterm.c, xterm.h (x_catching_errors): Remove.
1033 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1035 * xselect.c: Use signed conversions more consistently (Bug#9498).
1036 (selection_data_to_lisp_data): Assume incoming selection data are
1037 signed integers, not unsigned. This is to be consistent with
1038 outgoing selection data, which was modified to use signed integers
1039 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1040 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1041 expects long, not unsigned long.
1043 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1045 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1046 computation of loop end. Reported by Johan Bockgård
1049 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1051 * frame.c (Fother_visible_frames_p): Function deleted.
1053 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1055 * indent.c (compute_motion): Process display vector front to back
1056 rather than the other way around. (Bug#2496)
1058 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1060 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1062 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1064 * minibuf.c (Fread_from_minibuffer): Doc fix.
1066 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1068 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1069 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1071 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1073 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1074 value for non-existent files.
1076 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1078 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1079 set its "size" to -1. This will set the modtime_size field of
1080 the corresponding buffer to -1, which is what
1081 verify-visited-file-modtime expects for files that do not exist.
1084 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1086 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1088 * lisp.h: ... from here. push_key_description is no longer
1089 defined in keyboard.c, so its declaration should not be in
1090 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1091 logically belongs with push_key_description.
1093 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1095 * buffer.h: Include <sys/types.h> instead of <time.h>.
1096 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1097 Problem reported by Herbert J. Skuhra.
1099 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1101 * xml.c (parse_region): Make the parsing work for
1102 non-comment-starting XML files again (bug#9144).
1104 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1106 * image.c (gif_load): Fix calculation of bottom and right corner.
1109 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1111 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1112 redisplay in small windows.
1114 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1116 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1118 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1120 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1121 Operate on live windows only.
1123 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1125 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1127 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1129 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1130 only under bidi iteration.
1132 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1134 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1136 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1138 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1139 Without this fix, the command to link temacs failed due to an
1140 undefined symbol __builtin_isnan. This is because
1141 /usr/include/iso/math_c99.h #defines isnan(x) to
1142 __builtin_isnan(x), but the bundled gcc, which identifies itself
1143 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1145 * floatfns.c (isnan): #undef, and then #define to a clone of
1147 (Fisnan): Always define, since it's always available now.
1148 (syms_of_floatfns): Always define isnan at the Lisp level.
1150 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1152 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1154 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1156 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1157 The previous code assumed that file offsets (off_t values) fit in
1158 EMACS_INT variables, which is not true on typical 32-bit hosts.
1159 The code messed up by falsely reporting buffer overflow in cases
1160 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1161 when "big" contains more than 2**29 bytes, even though this
1162 inserts just one byte and does not overflow the buffer.
1163 (Finsert_file_contents): Store file offsets as off_t
1164 values, not as EMACS_INT values. Check for overflow when
1165 converting between EMACS_INT and off_t. When checking for
1166 buffer overflow or for overlap, take the offsets into account.
1167 Don't use EMACS_INT for small values where int suffices.
1168 When checking for overlap, fix a typo: ZV was used where
1169 ZV_BYTE was intended.
1170 (Fwrite_region): Don't assume off_t fits into 'long'.
1171 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1173 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1175 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1177 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1179 sprintf-related integer and memory overflow issues (Bug#9412).
1181 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1182 (esprintf, exprintf, evxprintf): New functions.
1183 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1184 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1185 (modify_event_symbol): Do not assume that the length of
1186 name_alist_or_stem is safe to alloca and fits in int.
1187 (Fexecute_extended_command): Likewise for function name and binding.
1188 (Frecursion_depth): Wrap around reliably on integer overflow.
1189 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1190 since some callers pass EMACS_INT values.
1191 (Fsingle_key_description): Don't crash if symbol name contains more
1192 than MAX_ALLOCA bytes.
1193 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1194 (get_minibuffer): Arg is now EMACS_INT, not int.
1195 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1196 (esprintf, exprintf, evxprintf): New decls.
1197 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1199 * dbusbind.c (signature_cat): New function.
1200 (xd_signature, Fdbus_register_signal):
1201 Do not overrun buffer; instead, report string overflow.
1203 * dispnew.c (add_window_display_history): Don't overrun buffer.
1204 Truncate instead; this is OK since it's just a log.
1206 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1207 even if the time zone offset is outlandishly large.
1208 Don't mishandle offset == INT_MIN.
1210 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1211 when creating daemon; the previous buffer-overflow check was incorrect.
1213 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1214 which has the guts of the old verror function.
1216 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1217 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1219 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1220 (font_unparse_xlfd): Don't blindly alloca long strings.
1221 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1222 fits in int, when using sprintf. Use single snprintf to count
1223 length of string rather than counting it via multiple sprintfs;
1224 that's simpler and more reliable.
1225 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1226 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1227 sprintf, in case result does not fit in int.
1229 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1230 (fontset_from_font): Print it.
1232 * frame.c (tty_frame_count): Now printmax_t, not int.
1233 (make_terminal_frame, set_term_frame_name): Print it.
1234 (x_report_frame_params): In X, window IDs are unsigned long,
1235 not signed long, so print them as unsigned.
1236 (validate_x_resource_name): Check for implausibly long names,
1237 and don't assume name length fits in 'int'.
1238 (x_get_resource_string): Don't blindly alloca invocation name;
1239 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1242 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1243 (xg_check_special_colors, xg_set_geometry):
1244 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1246 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1247 Use esprintf, not sprintf, in case result does not fit in int.
1249 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1250 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1251 it as a large positive number.
1252 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1253 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1255 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1256 in case result does not fit in int.
1258 * print.c (float_to_string): Detect width overflow more reliably.
1259 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1260 buffer overrun. Don't assume list length fits in 'int'. Treat
1261 print length of 0 as 0, not as infinity; to be consistent with other
1262 uses of print length in this function. Don't overflow print length
1263 index. Don't assume hash table size fits in 'long', or that
1264 vectorlike size fits in 'unsigned long'.
1266 * process.c (make_process): Use printmax_t, not int, to format
1267 process-name gensyms.
1269 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1271 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1272 to avoid potential buffer overrun.
1274 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1275 if X resource line is longer than 512 bytes.
1277 * xfns.c (x_window): Make sprintf buffer a bit bigger
1278 to avoid potential buffer overrun.
1280 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1282 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1284 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1286 Integer overflow fixes for scrolling, etc.
1287 Without these, Emacs silently mishandles large integers sometimes.
1288 For example, "C-u 4294967297 M-x recenter" was treated as if
1289 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1291 * xdisp.c (try_window_id): Check Emacs fixnum range before
1292 converting to 'int'.
1294 * window.c (window_scroll_line_based, Frecenter):
1295 Check that an Emacs fixnum is in range before assigning it to 'int'.
1296 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1297 values converted from Emacs fixnums.
1298 (Frecenter): Don't wrap around a line count if it is out of 'int'
1299 range; instead, treat it as an extreme value.
1300 (Fset_window_configuration, compare_window_configurations):
1301 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1303 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1304 that can exceed INT_MAX. Check that EMACS_INT value is in range
1305 before assigning it to the (possibly-narrower) index.
1306 (match_limit): Don't assume that a fixnum can fit in 'int'.
1308 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1311 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1312 (Fvertical_motion): Don't wrap around LINES values that don't fit
1313 in 'int'. Instead, treat them as extreme values. This is good
1314 enough for windows, which can't have more than INT_MAX lines anyway.
1316 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1318 * Require libxml/parser.h to avoid compilation warning.
1320 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1322 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1323 since this reportedly can destroy thread storage.
1325 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1327 * syntax.c (find_defun_start): Update all cache variables if
1328 exiting early (Bug#9401).
1330 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1332 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1334 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1335 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1336 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1338 * term.c (tty_append_glyph): New function.
1339 (produce_stretch_glyph): Static function and its prototype deleted.
1341 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1344 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1346 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1347 when checking :margin (Bug#9390).
1348 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1349 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1350 so that the name doesn't mislead. All uses changed.
1352 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1354 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1357 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1359 * xdisp.c (move_it_to): Don't bail out early when reaching
1360 position beyond to_charpos, if we are scanning backwards.
1361 (move_it_vertically_backward): When DY == 0, make sure we get to
1362 the first character in the line after the newline.
1364 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1366 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1367 (ccl_driver): Do not generate an out-of-range pointer.
1368 (Fccl_execute_on_string): Remove unnecessary check for
1369 integer overflow, noted by Stefan Monnier in
1370 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1371 Remove a FIXME that didn't need fixing.
1372 Simplify the newly-introduced buffer reallocation code.
1374 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1376 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1378 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1380 Integer and memory overflow issues (Bug#9196).
1382 * doc.c (get_doc_string): Rework so that
1383 get_doc_string_buffer_size is the actual buffer size, rather than
1384 being 1 less than the actual buffer size; this makes xpalloc more
1387 * image.c (x_allocate_bitmap_record, cache_image):
1388 * xselect.c (Fx_register_dnd_atom):
1389 Simplify previous changes by using xpalloc.
1391 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1392 since either will do and ptrdiff_t is convenient with xpalloc.
1394 * charset.c (charset_table_size)
1395 (struct charset_sort_data.priority): Now ptrdiff_t.
1396 (charset_compare): Don't overflow if priorities differ greatly.
1397 (Fsort_charsets): Don't assume list length fits in int.
1398 Check for size-calculation overflow when allocating sort data.
1399 (syms_of_charset): Allocate an initial charset table that is
1400 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1402 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1404 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1405 The actual value is always <= INT_MAX, and leaving it unsigned made
1406 overflow checking harder.
1408 * dispextern.h (struct glyph_matrix.rows_allocated)
1409 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1410 with xpalloc. The values are still always <= INT_MAX.
1412 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1414 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1415 (SAFE_NALLOCA): New macro.
1417 * region-cache.c (struct boundary.pos, find_cache_boundary)
1418 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1419 (set_cache_region, invalidate_region_cache)
1420 (revalidate_region_cache, know_region_cache, region_cache_forward)
1421 (region_cache_backward, pp_cache):
1422 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1423 so that ptrdiff_t * can be passed to xpalloc.
1424 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1425 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1426 (pp_cache): Don't assume cache_len fits in int.
1427 * region-cache.h: Adjust extern decls to match.
1429 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1430 EMACS_INT, since either will do, for xpalloc.
1432 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1433 (xnmalloc, xnrealloc, xpalloc): New functions.
1435 * bidi.c (bidi_shelve_header_size): New constant.
1436 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1437 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1439 * bidi.c (bidi_cache_shrink):
1440 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1442 Don't update size of array until after memory allocation succeeds,
1443 because xmalloc/xrealloc may not return.
1444 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1445 now that we have proper integer overflow checking.
1446 (record_overlay_string, overlay_strings): Catch overflows when
1447 calculating size of overlay_str_buf.
1449 * callproc.c (Fcall_process): Check for size overflow when
1450 calculating size of args2.
1451 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1452 Normally we prefer signed values, but sticking with ptrdiff_t would
1453 require adding more-complicated checks.
1455 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1456 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1457 Redo buffer-overflow calculations to avoid integer overflow.
1458 Add a FIXME comment where memory seems to be over-allocated.
1460 * character.c (Fstring): Check for size-calculation overflow.
1462 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1463 unnecessary integer overflow. Check for size overflow.
1464 (encode_coding_object): Don't update size until xmalloc succeeds.
1466 * composite.c (get_composition_id): Check for overflow in glyph
1467 length calculations.
1469 Integer and memory overflow fixes for display code.
1470 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1471 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1472 (scrolling_window): Check for overflow in size calculations.
1473 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1474 Don't assume glyph table len fits in int.
1475 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1476 (row_table_size): Now ptrdiff_t, not int.
1477 (scrolling_window): Avoid overflow in size calculations.
1478 Don't update size until allocation succeeds.
1479 * fns.c (concat): Check for overflow in size calculations.
1480 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1481 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1482 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1484 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1485 (get_doc_string): Check for size calculation overflow.
1486 Don't update size until allocation succeeds.
1487 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1488 EMACS_INT, where ptrdiff_t will do.
1489 (Fsubstitute_command_keys): Check for string overflow.
1491 * editfns.c (set_time_zone_rule): Don't assume environment length
1493 (message_length): Now ptrdiff_t, not int.
1494 (Fmessage_box): Don't update size until allocation succeeds.
1495 Don't assume message length fits in int.
1496 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1498 * emacs.c (main): Do not reallocate argv, since there is a null at
1499 the end that can be overwritten, and this way there's no need to
1500 worry about size-calculation overflow.
1501 (sort_args): Check for size-calculation overflow.
1503 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1505 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1507 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1508 (x_set_scroll_bar_width, x_figure_window_size):
1509 Check for integer overflow.
1510 (x_set_alpha): Do not assume XINT fits in int.
1512 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1513 This is for the members text_lines, text_cols, total_lines, total_cols,
1514 where the system imposes an 'int' limit.
1516 * fringe.c (Fdefine_fringe_bitmap):
1517 Don't update size until alloc works.
1519 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1520 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1522 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1523 Check for size-calculation overflow.
1524 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1525 do, as we prefer signed integers.
1526 (id_to_widget.max_size, id_to_widget.used)
1527 (xg_store_widget_in_map, xg_remove_widget_from_map)
1528 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1529 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1530 Use and return ptrdiff_t, not int.
1531 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1532 * gtkutil.h: Change prototypes to match the above.
1534 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1535 are duplicate now that they've been promoted to lisp.h.
1536 (x_allocate_bitmap_record, x_alloc_image_color)
1537 (make_image_cache, cache_image, xpm_load):
1538 Don't update size until alloc is done.
1539 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1541 Check for size calculation overflow.
1542 (ct_colors_allocated_max): New constant.
1543 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1546 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1547 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1548 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1549 Use ptrdiff_t, not int, to count maps.
1550 (read_char_minibuf_menu_prompt): Check for overflow in size
1551 calculations. Don't update size until allocation succeeds.
1552 Redo calculations to avoid overflow.
1553 * keyboard.h: Change prototypes to match the above.
1555 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1557 (current_minor_maps): Check for size calculation overflow.
1558 * keymap.h: Change prototypes to match the above.
1560 * lread.c (read1, init_obarray): Don't update size until alloc done.
1562 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1563 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1565 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1566 Now ptrdiff_t, not int.
1567 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1568 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1570 * process.c (Fnetwork_interface_list): Check for overflow
1571 in size calculation.
1573 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1575 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1576 overflow. Don't bother calling xmalloc when xrealloc will do.
1578 * search.c (Freplace_match): Check for size calculation overflow.
1579 (Fset_match_data): Don't assume list lengths fit in 'int'.
1581 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1582 for command line length. Do not attempt to address one before the
1583 beginning of an array, as that's not portable.
1585 * term.c (max_frame_lines): Remove; unused.
1586 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1588 (encode_terminal_code, calculate_costs): Check for size
1589 calculation overflow.
1590 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1591 table lengths and related sizes. Don't update size until alloc
1592 done. Redo calculations to avoid overflow.
1593 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1595 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1596 subtracting pointers.
1597 (gobble_line): Check for overflow more carefully. Don't update size
1600 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1601 Don't update size until alloc done.
1602 Redo size calculations to avoid overflow.
1603 Check for size calculation overflow.
1604 (main) [DEBUG]: Fix typo in invoking tparam1.
1606 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1607 Use ptrdiff_t, not int, for sizes.
1608 (store_mode_line_noprop_char): Don't update size until alloc done.
1610 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1611 Use ptrdiff_t, not int, for sizes.
1612 (Finternal_make_lisp_face, cache_face):
1613 Check for size calculation overflow.
1614 (cache_face): Treat size calculation overflows as if they were
1615 memory exhaustion (the usual treatment), rather than aborting.
1617 * xfns.c (x_encode_text, x_set_name_internal)
1618 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1619 sizes, since they can exceed INT_MAX in size. Check for size
1620 calculation overflow.
1622 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1623 (xg_select): Check for size calculation overflow.
1624 Don't update size until alloc done.
1626 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1627 as sprintf is limited to int lengths.
1629 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1630 (X_LONG_MIN): New macros.
1631 Use them to make the following changes clearer.
1632 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1633 This change doesn't affect the value now, but it may help remind
1634 future maintainers not to raise the value too much later.
1635 (SELECTION_QUANTUM): Remove, replacing with ...
1636 (selection_quantum): ... new function, which avoids overflow.
1638 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1639 assumption that selection length fits in 'int'.
1640 (x_reply_selection_request, x_handle_selection_request)
1641 (x_get_window_property, receive_incremental_selection)
1642 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1643 (lisp_data_to_selection_data, clean_local_selection_data):
1644 Use ptrdiff_t, not int, to record length of selection.
1645 (x_reply_selection_request, x_get_window_property)
1646 (receive_incremental_selection, x_property_data_to_lisp):
1647 Redo calculations to avoid overflow.
1648 (x_reply_selection_request): When sending hint, ceiling it at
1649 X_LONG_MAX rather than relying on wraparound overflow to send
1651 (x_get_window_property, receive_incremental_selection)
1652 (lisp_data_to_selection_data, x_property_data_to_lisp):
1653 Check for size-calculation overflow.
1654 (x_get_window_property, receive_incremental_selection)
1655 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1656 Don't store size until memory allocation succeeds.
1657 (x_get_window_property): Plug memory leak on memory exhaustion.
1658 Don't double-block input; malloc is safe here. Don't assume 2**34
1659 - 4 fits in unsigned long. Add an xassert to check
1660 XGetWindowProperty overflow. Be more careful about overflow
1661 calculations, and distinguish size from memory overflow better.
1662 (receive_incremental_selection): When tracing, don't assume
1663 unsigned int is less than INT_MAX.
1664 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1665 harmful) conversions of unsigned short to int.
1666 (lisp_data_to_selection_data): Don't assume that integers
1667 in the range -65535 through -1 fit in an X unsigned short.
1668 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1669 result parameters unless successful. Rely on cons_to_unsigned
1670 to report problems with elements; the old code wasn't right anyway.
1671 (x_check_property_data): Check for int overflow; we cannot use
1672 a wider type due to X limits.
1673 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1675 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1677 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1678 (x_term_init): Check for size calculation overflow.
1679 (x_color_cells): Don't store size until memory allocation succeeds.
1680 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1681 Don't assume alloca size is less than MAX_ALLOCA.
1682 (x_term_init): Don't assume length fits in int (sprintf is limited
1685 Use ptrdiff_t for composition IDs.
1686 * character.c (lisp_string_width):
1687 * composite.c (composition_table_size, n_compositions)
1688 (get_composition_id, composition_gstring_from_id):
1689 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1690 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1691 * window.c (Frecenter):
1692 Use ptrdiff_t, not int, for composition IDs.
1693 * composite.c (get_composition_id): Check for integer overflow.
1694 * composite.h: Adjust prototypes to match the above changes.
1696 Use ptrdiff_t for hash table indexes.
1697 * category.c (hash_get_category_set):
1698 * ccl.c (ccl_driver):
1699 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1700 * coding.c (coding_system_charset_list, detect_coding_system):
1701 * coding.h (struct coding_system.id):
1702 * composite.c (get_composition_id, gstring_lookup_cache):
1703 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1704 * image.c (xpm_get_color_table_h):
1705 * lisp.h (hash_lookup, hash_put):
1706 * minibuf.c (Ftest_completion):
1707 Use ptrdiff_t for hash table indexes, not int (which is too
1708 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1709 32-bit --with-wide-int hosts).
1711 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1712 Add a FIXME comment about memory leaks.
1713 (syms_of_charset): Don't assume xmalloc returns.
1715 Don't assume that stated character widths fit in int.
1716 * character.c (Fchar_width, c_string_width, lisp_string_width):
1717 * character.h (CHAR_WIDTH):
1718 * indent.c (MULTIBYTE_BYTES_WIDTH):
1719 Use sanitize_char_width to avoid undefined and/or bad behavior
1720 with outlandish widths.
1721 * character.h (sanitize_tab_width): Rename from sanitize_width,
1722 now that we have two such functions. All uses changed.
1723 (sanitize_char_width): New inline function.
1725 Don't assume that tab-width fits in int.
1726 * character.h (sanitize_width): New inline function.
1727 (SANE_TAB_WIDTH): New macro.
1728 (ASCII_CHAR_WIDTH): Use it.
1729 * indent.c (sane_tab_width): Remove. All uses replaced by
1730 SANE_TAB_WIDTH (current_buffer).
1731 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1733 * fileio.c: Integer overflow issues with file modes.
1734 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1736 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1737 Remove unreachable code.
1738 (read_hex, load_charset_map_from_file): Check for integer overflow.
1740 * xterm.c: don't go over XClientMessageEvent limit
1741 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1742 (x_send_scroll_bar_event): Likewise. Check that the size does not
1743 exceed limits imposed by XClientMessageEvent, as well as the usual
1744 ptrdiff_t and size_t limits.
1746 * keyboard.c: Overflow, signedness and related fixes.
1747 (make_lispy_movement): Use same integer type in forward decl
1748 that is used in the definition.
1749 (read_key_sequence, keyremap_step):
1750 Change bufsize argument back to int, undoing my 2011-03-30 change.
1751 We prefer signed types, and int is wide enough here.
1752 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1753 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1754 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1755 length, not size_t. Use ptrdiff_t for index, not int.
1756 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1757 possibility of integer overflow.
1759 Overflow, signedness and related fixes for images.
1761 * dispextern.h (struct it.stack[0].u.image.image_id)
1762 (struct_it.image_id, struct image.id, struct image_cache.size)
1763 (struct image_cache.used, struct image_cache.ref_count):
1764 * gtkutil.c (update_frame_tool_bar):
1765 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1766 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1767 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1768 * nsmenu.m (update_frame_tool_bar):
1769 * xdisp.c (calc_pixel_width_or_height):
1770 * xfns.c (image_cache_refcount):
1771 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1772 on typical 64-bit hosts.
1774 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1775 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1776 Omit unnecessary casts to int.
1777 (parse_image_spec): Check that integers fall into 'int' range
1778 when the callers expect that.
1779 (image_ascent): Redo ascent calculation to avoid int overflow.
1780 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1781 (lookup_image): Remove unnecessary tests.
1782 (xbm_image_p): Locals are now of int, not EMACS_INT,
1783 since parse_image_check makes sure they fit into int.
1784 (png_load, gif_load, svg_load_image):
1785 Prefer int to unsigned where either will do.
1786 (tiff_handler): New function, combining the cores of the
1787 old tiff_error_handler and tiff_warning_handler.
1788 This function is rewritten to use vsnprintf and thereby avoid
1789 stack buffer overflows. It uses only the features of vsnprintf
1790 that are common to both POSIX and native Microsoft.
1791 (tiff_error_handler, tiff_warning_handler): Use it.
1792 (tiff_load, gif_load, imagemagick_load_image):
1793 Don't assume :index value fits in 'int'.
1794 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1795 (imagemagick_load_image): Check that crop parameters fit into
1796 the integer types that MagickCropImage accepts. Don't assume
1797 Vimagemagick_render_type has a nonnegative value. Don't assume
1798 size_t fits in 'long'.
1799 (gs_load): Use printmax_t to print the widest integers possible.
1800 Check for integer overflow when computing image height and width.
1802 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1804 * xdisp.c (redisplay_window): Don't force window start if point
1805 will be invisible in the resulting window. (Bug#9324)
1807 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1809 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1810 the display spec is of the form `(space ...)'.
1811 (handle_display_spec): Return the value returned by
1812 handle_single_display_spec, not just 1 or zero.
1813 (handle_single_display_spec): If the display spec is of the form
1814 `(space ...)', and specifies display in the text area, return 2
1816 (try_cursor_movement): Check for the need to scroll more
1817 accurately, and prefer exact match for point under bidi.
1818 Don't advance `row' beyond the last row of the window.
1820 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1821 into disp_prop; all users changed.
1823 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1824 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1825 for the text covered by the display property.
1827 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1829 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1830 Change return value to nil.
1831 (Frecord_buffer): Delete unused function.
1833 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1835 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1836 buffers, return left-to-right.
1837 (set_cursor_from_row): Consider candidate row a win if its glyph
1838 represents a newline and point is on that newline. Fixes cursor
1839 positioning on the newline at EOL of R2L text within L2R
1840 paragraph, and vice versa.
1841 (try_cursor_movement): Check continued rows, in addition to
1842 continuation rows. Fixes unwarranted scroll when point enters a
1843 continued line of R2L text within an L2R paragraph, or vice versa.
1844 (cursor_row_p): Consider the case of point being equal to
1845 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1846 from the end of a short line to the beginning of a continued line
1847 of R2L text within L2R paragraph.
1848 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1849 composed characters.
1851 * bidi.c (bidi_check_type): Use xassert.
1852 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1855 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1857 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1860 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1862 * nsfont.m (ns_otf_to_script): Fix typo.
1864 2011-08-22 Kenichi Handa <handa@m17n.org>
1866 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1867 extra slot even if the purpose is char-code-property-table.
1869 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1871 * xdisp.c (redisplay_window): When computing centering_position,
1872 account for the height of the header line. (Bug#8874)
1874 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1875 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1876 candidate is selected by the mouse, and that candidate has a
1877 composed character under the mouse.
1879 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1880 coordinates reported by pos-visible-in-window-p for a composed
1881 character in column zero.
1883 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1885 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1887 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1889 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1890 consider it a hit if to_charpos is anywhere in the range of the
1891 composed buffer positions.
1893 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1895 * image.c (gif_load): Don't assume that each subimage has the same
1896 dimensions as the base image. Handle disposal method that is
1897 "undefined" by the gif spec (Bug#9335).
1899 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1901 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1902 (Fcondition_case): Document `debug' symbol in error handler.
1904 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1906 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1907 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1908 from an Org mode buffer to a Speedbar frame.
1910 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1911 a composition, take its buffer position from IT->cmp_it.charpos.
1912 Fixes cursor positioning at the beginning of a line that begins
1913 with a composed character.
1915 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1917 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1918 character bidirectional type, use STRONG_L instead. Fixes crashes
1919 in a buffer produced by `describe-categories'.
1921 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1922 members before the level stack, so they would be saved and
1923 restored when copying iterator state. Fixes incorrect reordering
1924 around TABs covered by display properties.
1926 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1928 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
1930 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1932 * eval.c (internal_condition_case, internal_condition_case_1)
1933 (internal_condition_case_2, internal_condition_case_n):
1934 Remove unnecessary aborts (Bug#9081).
1936 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1938 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1939 has no `load' handler, try opening the file locally. (Bug#9311)
1941 2011-08-16 Ken Brown <kbrown@cornell.edu>
1943 * gmalloc.c: Expand comment.
1945 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1947 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1948 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1950 2011-08-16 Ken Brown <kbrown@cornell.edu>
1952 Fix memory allocation problems in Cygwin build (Bug#9273).
1954 * unexcw.c ( __malloc_initialized): Declare external variable.
1955 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1957 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1959 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1961 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1963 [CYGWIN] (special_realloc): New function.
1964 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1965 requests to realloc storage in the static heap.
1967 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1969 * bidi.c (bidi_initialize): Remove unused local.
1971 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1974 * biditype.h: Remove file.
1975 * makefile.w32-in ($(BLD)/bidi.$(O)):
1976 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
1978 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1980 * chartab.c: Improve commentary for the uniprop_table API.
1982 * bidi.c (bidi_paragraph_init): Support zero value of
1983 bidi_ignore_explicit_marks_for_paragraph_level.
1984 (bidi_initialize): Use uniprop_table instead of including
1985 biditype.h and bidimirror.h.
1987 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1988 coordinates of the iterator when restoring from ppos_it.
1991 2011-08-14 Kenichi Handa <handa@m17n.org>
1993 * process.c (create_process): Call setup_process_coding_systems
1994 after the pid of the process is set to -1 (Bug#8162).
1996 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1998 * xdisp.c (move_it_in_display_line_to): Don't invoke
1999 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2000 ppos_it. Fixes vertical cursor motion when line beginning is
2001 covered by an image. (Bug#9296)
2003 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2005 * nsterm.h (ns_run_ascript): Declare.
2006 (NSAPP_DATA2_RUNASSCRIPT): Define.
2008 * nsfns.m (as_script, as_result, as_status): New static variables.
2009 (ns_run_ascript): New function.
2010 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2011 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2012 the event loop. Get status from as_status (Bug#7276).
2014 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2015 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2016 the event loop (Bug#7276).
2018 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2020 * gnutls.c (QCgnutls_bootprop_priority)
2021 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2022 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2023 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2024 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2025 (QCgnutls_bootprop_verify_hostname_error)
2026 (QCgnutls_bootprop_callbacks_verify): Rename from
2027 Qgnutls_bootprop_..., all uses changed.
2029 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2032 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2034 * xfaces.c (Qframe_set_background_mode): Now static.
2035 * dispextern.h (Qframe_set_background_mode): Remove decl.
2037 * process.c (Fnetwork_interface_info): Declare local only if needed.
2039 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2041 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2042 (Fnetwork_interface_list): Allocate in increments of bytes instead
2043 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2044 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2046 (struct ifflag_def): notrailers is smart on OSX.
2047 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2048 Get hardware address with getifaddrs if available.
2050 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2052 * xdisp.c (iterate_out_of_display_property): xassert that
2053 IT->position is set to within IT->object's boundaries. Break from
2054 the loop as soon as EOB is reached; avoids infloops in redisplay
2055 when IT->position is set up wrongly due to some bug.
2056 Set IT->current to match the bidi iterator unconditionally.
2057 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2058 entry. Force push_it to save on the stack the current
2059 buffer/string position, to be restored by pop_it. Fix flags in
2060 the iterator structure wrt the object coming from a display
2061 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2062 properties. (Bug#9284)
2064 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2066 * fontset.c (fontset_get_font_group): Add proper type checks.
2069 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2071 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2072 and LC_VERSION_MIN_MACOSX.
2073 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2074 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2076 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2078 * xdisp.c (forward_to_next_line_start): Allow to use the
2079 no-display-properties-and-no-overlays under bidi display.
2080 Set disp_pos in the bidi iterator to avoid searches for display
2081 properties and overlays.
2083 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2085 * editfns.c (Fset_time_zone_rule): Document relationship with the
2088 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2089 the font entity extracted from the cache (Bug#8109).
2091 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2093 * composite.c (autocmp_chars): Don't reset point. That is done by
2094 restore_point_unwind (Bug#5984).
2096 2011-08-07 Juri Linkov <juri@jurta.org>
2098 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2099 to show the arg `TIME' instead of `TIMEVAL'.
2101 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2103 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2104 display property strides EOL and includes a newline, as in
2105 longlines-mode. (Bug#9254)
2106 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2107 word-wrap under bidirectional display. (Bug#9224)
2109 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2110 is non-zero, even if the data buffer is NULL. Fixes a crash in
2111 vertical-motion with longlines-mode. (Bug#9254)
2113 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2115 * bidi.c <bidi_cache_total_alloc>: Now static.
2116 (bidi_initialize): Initialize bidi_cache_total_alloc.
2118 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2121 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2122 amount allocated this far in `bidi_cache_total_alloc'.
2123 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2124 non-zero, only free the data buffer without restoring the cache
2125 contents. All callers changed.
2127 * dispextern.h (bidi_unshelve_cache): Update prototype.
2129 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2130 (move_it_in_display_line, move_it_to)
2131 (move_it_vertically_backward, move_it_by_lines): Replace the call
2132 to xfree to an equivalent call to bidi_unshelve_cache.
2133 (move_it_in_display_line_to): Fix logic of returning
2134 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2136 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2138 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2139 came from a string character with a `cursor' property. (Bug#9229)
2141 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2143 * Makefile.in (LIB_PTHREAD): New variable.
2144 (LIBES): Add LIB_PTHREAD (Bug#9216).
2146 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2147 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2149 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2151 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2153 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2155 * xterm.c (x_find_topmost_parent): New function.
2156 (x_set_frame_alpha): Find topmost parent window with
2157 x_find_topmost_parent and set the property there also (bug#9181).
2158 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2160 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2162 * callproc.c (Fcall_process): Avoid vfork clobbering
2163 the local vars buffer, coding_systems, current_dir.
2165 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2167 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2169 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2171 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2172 so that it is not optimized away.
2174 * xdisp.c (compute_display_string_pos): Remove unused local.
2176 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2178 Fix slow cursor motion and scrolling in large buffers with
2179 selective display, like Org Mode buffers. (Bug#9218)
2181 * dispextern.h (struct bidi_it): New member disp_prop_p.
2183 * xdisp.c: Remove one-slot cache of display string positions.
2184 (compute_display_string_pos): Accept an additional argument
2185 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2186 for a display string or property. If found, set DISP_PROP_P
2189 * bidi.c (bidi_fetch_char): Accept an additional argument
2190 DISP_PROP_P, and pass it to compute_display_string_pos.
2191 Only handle text covered by a display string if DISP_PROP_P is returned
2192 non-zero. All callers of bidi_fetch_char changed.
2194 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2196 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2198 2010-12-03 Don March <don@ohspite.net>
2200 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2201 last character M-[char] is translated to ESC [char] (bug#7541).
2203 2011-08-02 Kenichi Handa <handa@m17n.org>
2205 * lisp.h (uniprop_table): Extern it.
2207 * chartab.c (uniprop_table): Make it non-static.
2209 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2211 * xdisp.c (forward_to_next_line_start): Accept additional argument
2212 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2214 (reseat_at_next_visible_line_start): Use the bidi iterator state
2215 returned by forward_to_next_line_start to restore the state of
2216 it->bidi_it after backing up to previous newline. (Bug#9212)
2218 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2220 * regex.c (re_comp): Protoize.
2221 (re_exec): Fix return type.
2222 (regexec): Fix type of `ret'. (Bug#9203)
2224 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2226 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2227 This is needed if max-image-size is a floating-point number.
2229 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2231 * print.c (print_object): Print empty symbol as ##.
2233 * lread.c (read1): Read ## as empty symbol.
2235 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2237 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2238 setting frame foreground color (Bug#9175).
2239 (x_set_background_color): Likewise.
2241 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2242 contents (Bug#9176).
2243 (EmacsTooltip -init): Remove bezels and add shadows to
2246 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2247 or scroll bar (Bug#8470).
2249 * nsfont.m (nsfont_open): Remove assignment to voffset and
2250 unnecessary vars hshink, expand, hd, full_height, min_height.
2251 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2253 * nsterm.h (nsfont_info): Remove voffset field.
2255 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2257 Implement strike-through and overline on NextStep (Bug#8863).
2259 * nsfont.m (nsfont_open): Use underline position provided by font,
2260 instead of hard-coded value of 2.
2261 (nsfont_draw): Call ns_draw_text_decoration instead.
2263 * nsterm.h: Add declaration for ns_draw_text_decoration.
2265 * nsterm.m (ns_draw_text_decoration): New function for drawing
2266 underline, overline, and strike-through.
2267 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2268 ns_draw_text_decoration. Change treatment of cursor drawing to
2269 accommodate underlining, etc.
2271 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2273 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2276 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2278 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2279 Without this fix, if a signal arrives just after memory fills up,
2280 'malloc' might be invoked reentrantly.
2282 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2283 In other words, assume that every image size is allowed, on non-X
2284 hosts. This assumption is probably wrong, but it lets Emacs compile.
2286 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2288 * regex.c (re_iswctype): Convert return values to boolean.
2290 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2292 * xdisp.c (compute_display_string_pos): Don't use cached display
2293 string position if the buffer had its restriction changed.
2296 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2298 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2300 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2302 Integer signedness and overflow and related fixes. (Bug#9079)
2304 * bidi.c: Integer size and overflow fixes.
2305 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2306 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2307 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2308 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2309 (bidi_find_other_level_edge):
2310 Use ptrdiff_t instead of EMACS_INT where either will do.
2311 This works better on 32-bit hosts configured --with-wide-int.
2312 (bidi_cache_ensure_space): Check for size-calculation overflow.
2313 Use % rather than repeated addition, for better worst-case speed.
2314 Don't set bidi_cache_size until after xrealloc returns, because it
2316 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2317 (bidi_cache_ensure_space): Also check that the bidi cache size
2318 does not exceed that of the largest Lisp string or buffer. See Eli
2319 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2321 * alloc.c (__malloc_size_t): Remove.
2322 All uses replaced by size_t. See Andreas Schwab's note
2323 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2325 * image.c: Improve checking for integer overflow.
2326 (check_image_size): Assume that f is nonnull, since
2327 it is always nonnull in practice. This is one less thing to
2328 worry about when checking for integer overflow later.
2329 (x_check_image_size): New function, which checks for integer
2330 overflow issues inside X.
2331 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2332 This removes the need for a memory_full check.
2333 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2334 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2335 (xbm_read_bitmap_data): Change locals back to 'int', since
2336 their values must fit in 'int'.
2337 (xpm_load_image, png_load, tiff_load):
2338 Invoke x_create_x_image_and_pixmap earlier,
2339 to avoid much needless work if the image is too large.
2340 (tiff_load): Treat overly large images as if
2341 x_create_x_image_and_pixmap failed, not as malloc failures.
2342 (gs_load): Use x_check_image_size.
2344 * gtkutil.c: Omit integer casts.
2345 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2346 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2348 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2350 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2351 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2352 would wrongly return t on a 64-bit host.
2354 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2355 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2356 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2357 and therefore cause GCC to emit a bogus diagnostic in some cases.
2359 * image.c: Integer signedness and overflow and related fixes.
2360 This is not an exhaustive set of fixes, but it's time to
2361 record what I've got.
2362 (lookup_pixel_color, check_image_size): Remove redundant decls.
2363 (check_image_size): Don't assume that arbitrary EMACS_INT values
2364 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2365 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2366 (tiff_load, imagemagick_load_image):
2367 Check for overflow in size calculations.
2368 (x_create_x_image_and_pixmap): Remove unnecessary test for
2369 xmalloc returning NULL; that can't happen.
2370 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2371 (xpm_color_bucket): Use better integer hashing function.
2372 (xpm_cache_color): Don't possibly over-allocate memory.
2373 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2374 (gif_memory_source):
2375 Use ptrdiff_t, not int or size_t, to record sizes.
2376 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2377 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2378 either works, as we prefer signed integers.
2379 (tiff_read_from_memory, tiff_write_from_memory):
2380 Return tsize_t, not size_t, since that's what the TIFF API wants.
2381 (tiff_read_from_memory): Don't fail simply because the read would
2382 go past EOF; instead, return a short read.
2383 (tiff_load): Omit no-longer-needed casts.
2384 (Fimagemagick_types): Don't assume size fits into 'int'.
2386 Improve hashing quality when configured --with-wide-int.
2387 * fns.c (hash_string): New function, taken from sxhash_string.
2388 Do not discard information about ASCII character case; this
2389 discarding is no longer needed.
2390 (sxhash-string): Use it. Change sig to match it. Caller changed.
2391 * lisp.h: Declare it.
2392 * lread.c (hash_string): Remove, since we now use fns.c's version.
2393 The fns.c version returns a wider integer if --with-wide-int is
2394 specified, so this should help the quality of the hashing a bit.
2396 * emacs.c: Integer overflow minor fix.
2397 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2398 Define only if GNU_LINUX.
2399 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2401 * dispnew.c: Integer signedness and overflow fixes.
2402 Remove unnecessary forward decls, that were a maintenance hassle.
2403 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2405 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2406 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2407 (prepare_desired_row, line_draw_cost):
2408 Use int, not unsigned, where either works.
2409 (save_current_matrix, restore_current_matrix):
2410 Use ptrdiff_t, not size_t, where either works.
2411 (init_display): Check for overflow more accurately, and without
2412 relying on undefined behavior.
2414 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2415 Remove, replacing with the new symbols in lisp.h. All uses changed.
2416 * fileio.c (make_temp_name):
2417 * filelock.c (lock_file_1, lock_file):
2418 * xdisp.c (message_dolog):
2419 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2420 Use pMd etc. instead.
2421 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2422 replacing the pWIDE etc. symbols removed from editfns.c.
2424 * keyboard.h (num_input_events): Now uintmax_t.
2425 This is (very slightly) less likely to mess up due to wraparound.
2428 * buffer.c: Integer signedness fixes.
2429 (alloc_buffer_text, enlarge_buffer_text):
2430 Use ptrdiff_t rather than size_t when either will do, as we prefer
2433 * alloc.c: Integer signedness and overflow fixes.
2434 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2435 (__malloc_size_t): Default to size_t, not to int.
2436 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2437 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2438 Prefer ptrdiff_t to size_t when either would do, as we prefer
2440 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2441 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2442 Now const. Initialize with values that are in range even if char
2444 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2445 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2446 These functions do the right thing with sizes > 2**32.
2447 (check_depth): Now ptrdiff_t, not int.
2448 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2449 Adjust to new way of storing sizes. Check for size overflow bugs
2451 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2452 slightly wrong anyway, as it missed one instance of
2453 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2454 (refill_memory_reserve): Omit needless cast to size_t.
2455 (mark_object_loop_halt): Mark as externally visible.
2457 * xselect.c: Integer signedness and overflow fixes.
2458 (Fx_register_dnd_atom, x_handle_dnd_message):
2459 Use ptrdiff_t, not size_t, since we prefer signed.
2460 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2461 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2462 x_dnd_atoms_size and x_dnd_atoms_length.
2464 * doprnt.c: Prefer signed to unsigned when either works.
2466 * doprnt.c (doprnt):
2468 * xdisp.c (vmessage):
2469 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2470 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2471 prefer signed arithmetic to avoid comparison confusion.
2472 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2473 but is a bit tricky.
2475 Assume freestanding C89 headers, string.h, stdlib.h.
2476 * data.c, doprnt.c, floatfns.c, print.c:
2477 Include float.h unconditionally.
2478 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2479 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2480 * regex.c: Likewise for stddef.h, string.h.
2481 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2482 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2483 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2484 (STDC_HEADERS): Remove obsolete defines.
2485 * sysdep.c: Include limits.h unconditionally.
2487 Assume support for memcmp, memcpy, memmove, memset.
2488 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2489 * regex.c (memcmp, memcpy):
2490 Remove; we assume C89 now.
2492 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2493 (__malloc_safe_bcopy): Remove; no longer needed.
2495 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2496 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2497 well either way, and we prefer signed to unsigned.
2499 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2501 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2502 closes the connection while we're reading (bug#9182).
2504 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2506 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2507 are specified (Bug#9168).
2509 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2511 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2512 Found by GCC static checking and --with-wide-int on a 32-bit host.
2514 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2516 * xdisp.c (compute_display_string_pos): Fix logic of caching
2517 previous display string position. Initialize cached_prev_pos to
2518 -1. Fixes slow-down at the beginning of a buffer.
2520 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2522 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2523 for attrs[LFACE_FONTSET_INDEX].
2525 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2527 * xml.c (parse_region): Remove unused local
2528 that was recently introduced.
2530 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2532 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2533 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2535 * xdisp.c (move_it_in_display_line_to): Record the best matching
2536 position for TO_CHARPOS while scanning the line, and restore it on
2537 exit if none of the characters scanned was an exact match.
2538 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2539 when exact match is impossible due to invisible text, and the
2540 lines are truncated.
2542 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2544 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2547 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2549 Fix a significant slow-down of cursor motion with C-n, C-p,
2550 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2551 auto-repeat under bidi redisplay in fontified buffers.
2552 * xdisp.c (compute_stop_pos_backwards): New function.
2553 (next_element_from_buffer): Call compute_stop_pos_backwards to
2554 find a suitable prev_stop when we find ourselves before
2556 (reseat): Don't look for prev_stop, as that could mean a very long
2558 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2559 <cached_disp_overlay_modiff>: Cache for last found display string
2561 (compute_display_string_pos): Return the cached position if asked
2562 about the same buffer in the same area of character positions, and
2563 the buffer wasn't changed since the time the display string
2564 position was cached.
2566 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2568 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2569 is an integer, which is important for empty lines. (Bug#9149)
2571 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2573 * frame.c (Fmodify_frame_parameters): In tty case, update the
2574 default face if necessary (Bug#4238).
2576 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2578 * editfns.c (Fstring_to_char): No need to explain what a character
2579 is in the docstring (Bug#6576).
2581 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2583 * xml.c (parse_region): Make sure we always return a tree.
2585 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2587 * xml.c (parse_region): If a document contains only comments,
2590 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2592 * xml.c (make_dom): Return comments, too.
2594 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2597 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2598 and the surrounding thread.
2599 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2600 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2601 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2603 * s/openbsd.h (BROKEN_SIGIO): Define.
2604 * unexelf.c (unexec) [__OpenBSD__]:
2605 Don't update the .mdebug section of the Alpha COFF symbol table.
2607 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2609 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2612 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2614 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2615 This fixes some race conditions on the permissions of any newly
2618 * alloc.c (valid_pointer_p): Use pipe, not open.
2619 This fixes some permissions issues when debugging.
2621 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2622 If fchown fails to set both uid and gid, try to set just gid,
2623 as that is sometimes allowed. Adjust the file's mode to eliminate
2624 setuid or setgid bits that are inappropriate if fchown fails.
2626 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2628 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2629 to compare Lisp_Objects.
2630 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2631 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2632 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2634 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2636 * lread.c (read_integer): Unread even EOF character.
2637 (read1): Likewise. Properly record start position of symbol.
2639 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2640 symbol character follows.
2642 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2644 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2645 This works around a problem with the previous change to Fcopy_file.
2646 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2647 and without this change, GCC might complain about discarding
2648 fchown's return value.
2650 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2652 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2654 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2656 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2658 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2660 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2661 it's used from the C level.
2663 * process.c: Use the same condition for POLL_FOR_INPUT in both
2664 keyboard.c and process.c (bug#1858).
2666 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2668 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2669 (Fgnutls_boot): Use it.
2671 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2673 * doc.c (Fsubstitute_command_keys): Revert last change.
2675 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2677 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2678 quotes the next character, and doesn't affect other longer
2679 sequences (bug#8935).
2681 * lread.c (syms_of_lread): Clarify that is isn't only
2682 `eval-buffer' and `eval-defun' that's affected by
2683 `lexical-binding' (bug#8460).
2685 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2687 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2688 bidi redisplay when a line includes both an image and is truncated.
2690 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2692 Fix minor problems found by static checking.
2693 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2694 (elsz): Now a signed constant, not a size_t var. We prefer signed
2695 types to unsigned, to avoid integer comparison confusion. Without
2696 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2697 "cannot optimize loop, the loop counter may overflow", a symptom
2699 * indent.c (Fvertical_motion): Mark locals as initialized.
2700 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2702 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2704 * search.c (Fre_search_backward): Mention `case-fold-search' in
2705 all the re_search_* functions (bug#8138).
2707 * keyboard.c (Fopen_dribble_file): Document when the file is
2710 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2712 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2715 Support bidi reordering of display and overlay strings.
2716 * xdisp.c (compute_display_string_pos)
2717 (compute_display_string_end): Accept additional argument STRING.
2718 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2719 (reseat_to_string): Initialize bidi_it->string.s and
2720 bidi_it->string.schars.
2721 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2722 NULL (avoids a crash in bidi_paragraph_init).
2723 Initialize itb.string.lstring.
2724 (init_iterator): Call bidi_init_it only of a valid
2725 buffer position was specified. Initialize paragraph_embedding to
2727 (reseat_to_string): Initialize the bidi iterator.
2728 (display_string): If we need to ignore text properties of
2729 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2730 original value of -1 will not work with bidi.)
2731 (compute_display_string_pos): First arg is now struct
2732 `text_pos *'; all callers changed. Support display properties on
2734 (compute_display_string_end): Support display properties on Lisp
2736 (init_iterator, reseat_1, reseat_to_string): Initialize the
2737 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2738 when iterating on a string not from display properties).
2739 (compute_display_string_pos, compute_display_string_end):
2740 Fix calculation of the object to scan. Fixes an error when using
2742 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2743 base_level_stop; instead, set base_level_stop to BEGV.
2744 Fixes crashes in vertical-motion.
2745 (next_element_from_buffer): Improve commentary for when
2746 the iterator is before prev_stop.
2747 (init_iterator): Initialize bidi_p from the default value of
2748 bidi-display-reordering, not from buffer-local value. Use the
2749 buffer-local value only if initializing for buffer iteration.
2750 (handle_invisible_prop): Support invisible properties on strings
2751 that are being bidi-reordered.
2752 (set_iterator_to_next): Support bidi reordering of C strings and
2754 (next_element_from_string): Support bidi reordering of Lisp
2756 (handle_stop_backwards): Support Lisp strings as well.
2757 (display_string): Support display of R2L glyph rows.
2758 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2759 (init_iterator): Don't initialize it->bidi_p for strings
2761 (reseat_to_string): Initialize it->bidi_p for strings here.
2762 (next_element_from_string, next_element_from_c_string)
2763 (next_element_from_buffer): Add xassert's for correspondence
2764 between IT's object being iterated and it->bidi_it.string
2766 (face_before_or_after_it_pos): Support bidi iteration.
2767 (next_element_from_c_string): Handle the case of the first string
2768 character that is not the first one in the visual order.
2769 (get_visually_first_element): New function, refactored from common
2770 parts of next_element_from_buffer, next_element_from_string, and
2771 next_element_from_c_string.
2772 (tool_bar_lines_needed, redisplay_tool_bar)
2773 (display_menu_bar): Force left-to-right direction. Add a FIXME
2774 comment for making that be controlled by a user option.
2775 (push_it, pop_it): Save and restore the state of the
2776 bidi iterator. Save and restore the bidi_p flag.
2777 (pop_it): Iterate out of display property for string iteration as
2779 (iterate_out_of_display_property): Support iteration over strings.
2780 (handle_single_display_spec): Set up it->bidi_it for iteration
2781 over a display string, and call bidi_init_it.
2782 (handle_single_display_spec, next_overlay_string)
2783 (get_overlay_strings_1, push_display_prop): Set up the bidi
2784 iterator for displaying display or overlay strings.
2785 (forward_to_next_line_start): Don't use the shortcut if
2787 (back_to_previous_visible_line_start): If handle_display_prop
2788 pushed the iterator stack, restore the internal state of the bidi
2789 iterator by calling bidi_pop_it same number of times.
2790 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2791 and we are bidi-iterating, don't decrement the iterator position;
2792 instead, set the first_elt flag in the bidi iterator, to produce
2794 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2795 (push_display_prop): xassert that we are iterating a buffer.
2796 (push_it, pop_it): Save and restore paragraph_embedding member.
2797 (handle_single_display_spec, next_overlay_string)
2798 (get_overlay_strings_1, reseat_1, reseat_to_string)
2799 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2800 correctly. Don't assume unibyte strings are not bidi-reordered.
2801 (compute_display_string_pos)
2802 (compute_display_string_end): Fix handling the case of C string.
2803 (push_it, pop_it): Save and restore from_disp_prop_p.
2804 (handle_single_display_spec, push_display_prop): Set the
2805 from_disp_prop_p flag.
2806 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2807 (pop_it): Call iterate_out_of_display_property only if we are
2808 popping after iteration over a string that came from a display
2809 property. Fix a typo in popping stretch info. Add an assertion
2810 for verifying that the iterator position is in sync with the bidi
2812 (handle_single_display_spec, get_overlay_strings_1)
2813 (push_display_prop): Fix initialization of paragraph direction for
2814 string when that of the parent object is not yet determined.
2815 (reseat_1): Call bidi_init_it to resync the bidi
2816 iterator with IT's position. (Bug#7616)
2817 (find_row_edges): If ROW->start.pos gives position
2818 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2819 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2820 Reset the from_disp_prop_p flag.
2821 (SAVE_IT, RESTORE_IT): New macros.
2822 (pos_visible_p, face_before_or_after_it_pos)
2823 (back_to_previous_visible_line_start)
2824 (move_it_in_display_line_to, move_it_in_display_line)
2825 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2826 (try_scrolling, redisplay_window, display_line): Use them when
2827 saving a temporary copy of the iterator and restoring it back.
2828 (back_to_previous_visible_line_start, reseat_1)
2829 (init_iterator): Empty the bidi cache "stack".
2830 (move_it_in_display_line_to): If iterator ended up at
2831 EOL, but we never saw any buffer positions smaller than
2832 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2833 motion in bidi-reordered lines.
2834 (move_it_in_display_line_to): Record prev_method and prev_pos
2835 immediately before the call to set_iterator_to_next. Fixes cursor
2836 motion in bidi-reordered lines with stretch glyphs and strings
2837 displayed in margins. (Bug#8133) (Bug#8867)
2838 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2840 (pos_visible_p): Support positions in bidi-reordered lines.
2841 Save and restore bidi cache.
2843 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2844 (bidi_paragraph_info): Delete unused struct.
2845 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2846 (bidi_cache_start): New variable.
2847 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2849 (bidi_cache_fetch_state, bidi_cache_search)
2850 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2851 (bidi_cache_find, bidi_peek_at_next_level)
2852 (bidi_level_of_next_char, bidi_find_other_level_edge)
2853 (bidi_move_to_visually_next): Compare cache index with
2854 bidi_cache_start rather than with zero.
2855 (bidi_fetch_char): Accept new argument STRING; all callers
2856 changed. Support iteration over a string. Support strings with
2857 display properties. Support unibyte strings. Fix the type of
2858 `len' according to what STRING_CHAR_AND_LENGTH expects.
2859 (bidi_paragraph_init, bidi_resolve_explicit_1)
2860 (bidi_resolve_explicit, bidi_resolve_weak)
2861 (bidi_level_of_next_char, bidi_move_to_visually_next):
2862 Support iteration over a string.
2863 (bidi_set_sor_type, bidi_resolve_explicit_1)
2864 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2865 can now be zero (for strings); special values 0 and -1 were
2866 changed to -1 and -2, respectively.
2867 (bidi_char_at_pos): New function.
2868 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2869 Call it instead of FETCH_MULTIBYTE_CHAR.
2870 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2871 initialized to valid values.
2872 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2874 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2875 the test for valid cached positions. Fix the logic for looking up
2876 the sentinel state in the cache. GCPRO the Lisp string we are
2878 (bidi_push_it, bidi_pop_it): New functions.
2879 (bidi_initialize): Initialize the bidi cache start stack pointer.
2880 (bidi_cache_ensure_space): New function, refactored from part of
2881 bidi_cache_iterator_state. Don't assume the required size is just
2882 one BIDI_CACHE_CHUNK away.
2883 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2884 (bidi_count_bytes, bidi_char_at_pos): New functions.
2885 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2886 always valid if bidi_cache_idx is valid.
2887 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2888 is valid if it's going to be used.
2889 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2890 (bidi_cache_fetch_state, bidi_cache_search)
2891 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2892 (bidi_cache_iterator_state, bidi_cache_find)
2893 (bidi_find_other_level_edge, bidi_cache_start_stack):
2894 All variables related to cache indices are now EMACS_INT.
2896 * dispextern.h (struct bidi_string_data): New structure.
2897 (struct bidi_it): New member `string'. Make flag members be 1-bit
2898 fields, and put them last in the struct.
2899 (compute_display_string_pos, compute_display_string_end):
2901 (bidi_push_it, bidi_pop_it): Add prototypes.
2902 (struct iterator_stack_entry): New members bidi_p,
2903 paragraph_embedding, and from_disp_prop_p.
2904 (struct it): Member bidi_p is now a bit field 1 bit wide.
2905 (bidi_shelve_cache, bidi_unshelve_cache):
2908 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2909 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2910 and vector-like objects.
2912 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2913 cache around display iteration.
2915 * window.c (Fwindow_end, window_scroll_pixel_based)
2916 (displayed_window_lines, Frecenter): Save and restore the bidi
2917 cache around display iteration.
2919 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2921 * editfns.c (Fdelete_region): Clarify the use of the named
2922 parameters (bug#6788).
2924 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2926 * indent.c (Fvertical_motion): Set and restore w->pointm when
2927 saving and restoring the window's buffer (Bug#9006).
2929 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2931 * editfns.c (Fstring_to_char): Clarify just what is returned
2932 (bug#6576). Text by Eli Zaretskii.
2934 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2936 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2938 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2940 * buffer.c (mmap_find): Fix a typo.
2942 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2944 Fix execution of x selection hooks.
2945 * xselect.c (Qx_lost_selection_functions)
2946 (Qx_sent_selection_functions): New vars.
2947 (syms_of_xselect): DEFSYM them.
2948 (x_handle_selection_request): Pass Qx_sent_selection_functions
2949 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2950 (x_handle_selection_clear,x_clear_frame_selections):
2951 Pass Qx_lost_selection_functions rather than
2952 Vx_lost_selection_functions to Frun_hook_with_args.
2954 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2956 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2957 The old code sometimes used this field without initializing it.
2959 * alloc.c (gc_sweep): Don't read past end of array.
2960 In theory, the old code could also have corrupted Emacs internals,
2961 though it'd be very unlikely.
2963 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2965 * character.c (Fcharacterp): Don't advertise optional ignored
2966 argument. (Bug#4026)
2968 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2970 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2973 * window.c (Fset_window_start): Doc fix (bug#4199).
2974 (Fset_window_hscroll): Ditto.
2976 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2978 Fix minor new problems caught by GCC 4.6.1.
2979 * term.c (init_tty): Remove unused local.
2980 * xsettings.c (store_monospaced_changed): Define this function only
2981 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2984 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2986 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2988 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2990 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2991 are the mini-buffer and the echo area (bug#3320).
2993 * term.c (init_tty): Remove support for supdup, c10 and perq
2994 terminals, which are no longer supported (bug#1482).
2996 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2998 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3000 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3002 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3003 for non-popups (Bug#3642).
3005 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3007 * alloc.c (reset_malloc_hooks): Protoize.
3008 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3009 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3010 * cm.c (losecursor): Likewise.
3011 * data.c (fmod): Likewise.
3012 * dispnew.c (swap_glyphs_in_rows): Likewise.
3013 * emacs.c (memory_warning_signal): Likewise.
3014 * floatfns.c (float_error): Likewise.
3015 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3016 (otf_open, font_otf_capability, generate_otf_features)
3017 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3019 * image.c (pbm_read_file): Likewise.
3020 * indent.c (string_display_width): Likewise.
3021 * intervals.c (check_for_interval, search_for_interval)
3022 (inc_interval_count, count_intervals, root_interval)
3023 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3024 * lread.c (defalias): Likewise.
3025 * ralloc.c (r_alloc_check): Likewise.
3026 * regex.c (set_image_of_range_1, set_image_of_range)
3027 (regex_grow_registers): Likewise.
3028 * sysdep.c (strerror): Likewise.
3029 * termcap.c (valid_filename_p, tprint, main): Likewise.
3030 * tparam.c (main): Likewise.
3031 * unexhp9k800.c (run_time_remap, save_data_space)
3032 (update_file_ptrs, read_header, write_header, calculate_checksum)
3033 (copy_file, copy_rest, display_header): Likewise.
3034 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3036 * xdisp.c (check_it): Likewise.
3037 * xfaces.c (register_color, unregister_color, unregister_colors):
3039 * xfns.c (print_fontset_result): Likewise.
3040 * xrdb.c (member, fatal, main): Likewise.
3042 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3044 Fix minor problems found by static checking (Bug#9031).
3045 * chartab.c (char_table_set_range, map_sub_char_table):
3046 Remove unused locals.
3047 (uniprop_table): Now static.
3048 * composite.c (_work_char): Remove unused static var.
3050 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3052 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3054 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3056 * gtkutil.c (qttip_cb): Remove code without function.
3058 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3060 * w32.c (pthread_sigmask): New stub.
3062 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3064 Use pthread_sigmask, not sigprocmask (Bug#9010).
3065 sigprocmask is portable only for single-threaded applications, and
3066 Emacs can be multi-threaded when it uses GTK.
3067 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3069 * callproc.c (Fcall_process):
3070 * process.c (create_process):
3071 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3072 Use pthread_sigmask, not sigprocmask.
3074 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3076 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3077 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3080 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3082 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3083 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3084 (xg_hide_tooltip): Fix comment.
3086 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3087 in registerServicesMenuSendTypes.
3088 (validRequestorForSendType): Don't check ns_return_types.
3090 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3093 2011-07-08 Jason Rumney <jasonr@gnu.org>
3095 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3096 SH_SHOW for hidden windows (Bug#5482).
3098 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3099 frame struct members of non-existent frames (Bug#6284).
3101 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3103 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3104 variable firstTime not needed on OSX >= 10.6.
3105 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3106 >= 10.5. Use setKnobProportion, setDoubleValue.
3108 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3109 (MAC_OS_X_VERSION_10_5): Define if not defined.
3110 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3111 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3112 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3114 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3115 cString and lossyCString on OSX >= 10.4
3117 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3118 sizeToFit on OSX >= 10.2.
3120 * nsimage.m (allocInitFromFile): Don't use deprecated method
3121 bestRepresentationForDevice on OSX >= 10.6.
3123 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3126 * emacs.c: Declare unexec_init_emacs_zone.
3128 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3130 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3132 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3133 on svcsMenu (Bug#8842).
3135 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3137 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3139 * nsterm.m (QUTF8_STRING): Declare.
3140 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3141 (validRequestorForSendType): Return type is (id).
3142 Change indexOfObjectIdenticalTo to indexOfObject.
3143 Check if we have local selection before returning self (Bug#8842).
3144 (writeSelectionToPasteboard): Put local selection into paste board
3145 if we have a local selection (Bug#8842).
3146 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3148 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3149 (ns_get_local_selection): Declare.
3151 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3153 * keymap.c (describe_map_tree): Don't insert a double newline at
3154 the end of the buffer (bug#1169) and return whether we inserted
3157 * callint.c (Fcall_interactively): Change "reading args" to
3158 "providing args" to try to clarify what it does (bug#1010).
3160 2011-07-07 Kenichi Handa <handa@m17n.org>
3162 * composite.c (composition_compute_stop_pos): Ignore a static
3163 composition starting before CHARPOS (Bug#8915).
3165 * xdisp.c (handle_composition_prop): Likewise.
3167 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3169 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3172 2011-07-07 Kenichi Handa <handa@m17n.org>
3174 * character.h (unicode_category_t): New enum type.
3176 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3177 (Qchar_code_property_table): New variable.
3178 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3179 (UNIPROP_COMPRESSED_FORM_P): New macros.
3180 (char_table_ascii): Uncompress the compressed values.
3181 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3182 Uncompress the compressed values.
3183 (sub_char_table_ref_and_range): Likewise.
3184 (char_table_ref_and_range): Uncompress the compressed values.
3185 (sub_char_table_set): New arg is_uniprop. Callers changed.
3186 Uncompress the compressed values.
3187 (sub_char_table_set_range): Args changed. Callers changed.
3188 (char_table_set_range): Adjuted for the above change.
3189 (map_sub_char_table): Delete args default_val and parent. Add arg
3190 top. Give decoded values to a Lisp function.
3191 (map_char_table): Adjust for the above change. Give decoded
3192 values to a Lisp function. Gcpro more variables.
3193 (uniprop_table_uncompress)
3194 (uniprop_decode_value_run_length): New functions.
3195 (uniprop_decoder, uniprop_decoder_count): New variables.
3196 (uniprop_get_decoder, uniprop_encode_value_character)
3197 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3199 (uniprop_encoder, uniprop_encoder_count): New variables.
3200 (uniprop_get_encoder, uniprop_table)
3201 (Funicode_property_table_internal, Fget_unicode_property_internal)
3202 (Fput_unicode_property_internal): New functions.
3203 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3204 Sunicode_property_table_internal, Sget_unicode_property_internal,
3205 and Sput_unicode_property_internal. Defvar_lisp
3206 char-code-property-alist.
3208 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3209 Vunicode_category_table.
3211 * font.c (font_range): Adjust for the change of
3212 Vunicode_category_table.
3214 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3216 * m/iris4d.h: Remove file, move contents ...
3217 * s/irix6-5.h: ... here.
3219 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3221 Remove unportable assumption about struct layout (Bug#8884).
3222 * alloc.c (mark_buffer):
3223 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3224 (clone_per_buffer_values): Don't assume that
3225 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3226 This isn't true in general, and it's particularly not true
3227 if Emacs is configured with --with-wide-int.
3228 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3229 New macros, used in the buffer.c change.
3231 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3233 * xsettings.c: Use both GConf and GSettings if both are available.
3234 (store_config_changed_event): Add comment.
3235 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3236 (store_tool_bar_style_changed): New functions.
3237 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3238 (struct xsettings): Move font inside HAVE_XFT.
3239 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3240 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3241 Move inside HAVE_XFT.
3242 (something_changed_gsettingsCB): Rename from something_changedCB.
3243 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3245 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3246 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3247 (something_changed_gconfCB): Rename from something_changedCB.
3248 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3249 (parse_settings): Move check for font inside HAVE_XFT.
3250 (read_settings, apply_xft_settings): Add comment.
3251 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3252 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3253 call store_font_name_changed.
3254 (xft_settings_event): Add comment.
3255 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3256 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3257 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3258 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3259 (xsettings_initialize): Call init_gsettings last.
3260 (xsettings_get_system_font, xsettings_get_system_normal_font):
3263 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3265 Random fixes. E.g., (random) never returned negative values.
3266 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3267 subseconds part to the entropy, as that's a bit more random.
3268 Prefer signed to unsigned, since the signedness doesn't matter and
3269 in general we prefer signed. When given a limit, use a
3270 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3271 latter isn't right if USE_2_TAGS_FOR_INTS.
3272 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3273 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3275 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3277 * textprop.c (text_property_stickiness):
3278 Obey Vtext_property_default_nonsticky.
3279 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3280 * w32fns.c (syms_of_w32fns):
3281 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3283 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3285 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3286 This is more efficient than Ffile_directory_p and avoids a minor race.
3288 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3290 * buffer.c (Foverlay_put): Say what the return value is
3293 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3294 is a directory before asking whether to use the file name
3296 (barf_or_query_if_file_exists): Make the "File is a directory"
3297 error be more correct.
3299 * fns.c (Frequire): Remove the mention of the .gz files, since
3300 that's installation-specific, but keep the mention of
3301 `get-load-suffixes'.
3303 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3305 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3306 Report string overflow if the output is too long.
3308 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3310 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3311 (syms_of_gnutls): Remove duplicate DEFSYM for
3312 Qgnutls_bootprop_verify_hostname_error, an error for
3313 Qgnutls_bootprop_verify_error (which is no longer used).
3315 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3316 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3317 Also (re)move comments that are misplaced or no longer relevant.
3319 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3321 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3323 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3325 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3326 and background color parameters if they have been changed.
3328 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3330 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3332 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3334 * xsettings.c (SYSTEM_FONT): Define only when used.
3335 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3337 * keymap.c (access_keymap_1): Now static.
3339 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3341 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3342 leave any prefix arg for the up event (Bug#1586).
3344 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3346 * lread.c (syms_of_lread): Mention single symbols defined by
3347 `defvar' or `defconst' (bug#7154).
3349 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3350 (Frequire): Mention get-load-suffixes.
3352 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3354 * window.h (window): Remove clone_number slot.
3355 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3357 (make_parent_window, make_window, saved_window)
3358 (Fset_window_configuration, save_window_save): Don't deal with
3360 * buffer.c (Qclone_number): Remove declaration.
3361 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3363 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3365 Add multiple inheritance to keymaps.
3366 * keymap.c (Fmake_composed_keymap): New function.
3367 (Fset_keymap_parent): Simplify.
3368 (fix_submap_inheritance): Remove.
3369 (access_keymap_1): New function extracted from access_keymap to handle
3370 embedded parents and handle lists of maps.
3371 (access_keymap): Use it.
3372 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3373 (Fcopy_keymap): Handle embedded parents.
3374 (Fcommand_remapping, define_as_prefix): Simplify.
3375 (Fkey_binding): Simplify.
3376 (syms_of_keymap): Move minibuffer-local-completion-map,
3377 minibuffer-local-filename-completion-map,
3378 minibuffer-local-must-match-map, and
3379 minibuffer-local-filename-must-match-map to Elisp.
3380 (syms_of_keymap): Defsubr make-composed-keymap.
3381 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3382 (parse_menu_item): Trivial simplification.
3384 2011-07-01 Glenn Morris <rgm@gnu.org>
3386 * Makefile.in (SETTINGS_LIBS): Fix typo.
3388 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3390 * coding.c (Fencode_coding_string): Record the last coding system
3391 used, as the function doc string says (bug#8738).
3393 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3395 * xsettings.c (store_monospaced_changed): Take new font as arg and
3396 check for change against current_mono_font.
3397 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3398 (emacs_settings_constructor, emacs_settings_get_property)
3399 (emacs_settings_set_property, emacs_settings_class_init)
3400 (emacs_settings_init, gsettings_obj): Remove.
3401 (something_changedCB): New function for HAVE_GSETTINGS.
3402 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3403 with value as argument.
3404 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3405 g_settings_new (Bug#8967). Do not create gsettings_obj.
3406 Remove calls to g_settings_bind. Connect something_changedCB to
3409 * xgselect.c: Add defined (HAVE_GSETTINGS).
3410 (xgselect_initialize): Ditto.
3412 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3413 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3416 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3418 * eval.c (struct backtrace): Simplify and port the data structure.
3419 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3420 signed bit field, as this assumption is not portable and it makes
3421 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3422 "char debug_on_exit : 1" as this is not portable either; instead,
3423 use the portable "unsigned int debug_on_exit : 1". Remove unused
3424 member evalargs. Remove obsolete comments about cc bombing out.
3426 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3428 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3429 Let HAVE_GSETTINGS override HAVE_GCONF.
3430 (store_monospaced_changed): New function.
3431 (EMACS_SETTINGS): A new type derived from GObject to handle
3432 GSettings notifications.
3433 (emacs_settings_constructor, emacs_settings_get_property)
3434 (emacs_settings_set_property, emacs_settings_class_init):
3436 (gsettings_client, gsettings_obj): New variables.
3437 (GSETTINGS_SCHEMA): New define.
3438 (something_changedCB): Call store_monospaced_changed.
3439 (init_gsettings): New function.
3440 (xsettings_initialize): Call init_gsettings.
3441 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3444 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3447 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3449 * window.c (resize_root_window, grow_mini_window)
3450 (shrink_mini_window): Rename Qresize_root_window to
3451 Qwindow_resize_root_window and Qresize_root_window_vertically to
3452 Qwindow_resize_root_window_vertically.
3454 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3456 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3458 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3460 * makefile.w32-in: Redesign dependencies so they reflect more
3461 clearly which files are directly included by each source file,
3462 and not through other includes.
3464 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3466 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3467 (sort_overlays, overlay_strings): When an overlay's clone number
3468 matches the window's clone number process the overlay even if
3469 the overlay's window property doesn't match the current window.
3471 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3472 (Fwindow_hchild): Rename to Fwindow_left_child.
3473 (Fwindow_next): Rename to Fwindow_next_sibling.
3474 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3475 (resize_window_check): Rename to window_resize_check.
3476 (resize_window_apply): Rename to window_resize_apply.
3477 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3478 (Fdelete_other_windows_internal, resize_frame_windows)
3479 (Fsplit_window_internal, Fdelete_window_internal)
3480 (grow_mini_window, shrink_mini_window)
3481 (Fresize_mini_window_internal): Fix callers accordingly.
3483 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3485 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3486 (emacs_fixed_set_min_size): Remove.
3487 (emacs_fixed_new): Take frame as argument.
3489 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3490 (_EmacsFixedPrivate): Remove minwidth/height.
3491 Add struct frame *f.
3492 (emacs_fixed_init): Initialize priv->f.
3493 (get_parent_class, emacs_fixed_set_min_size): Remove.
3494 (emacs_fixed_new): Set priv->f to argument.
3495 (emacs_fixed_get_preferred_width)
3496 (emacs_fixed_get_preferred_height): Use min_width/height from
3497 frames size_hint to set minimum and natural (Bug#8919).
3498 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3499 and use min_width/height from frames size_hint to set
3500 min_width/height (Bug#8919).
3502 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3503 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3506 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3508 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3509 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3512 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3514 * process.c (wait_reading_process_output): Bypass select if
3515 waiting for a cell while ignoring keyboard input, and input is
3516 pending. Suggested by Jan Djärv (Bug#8869).
3518 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3520 Use gnulib's dup2 module instead of rolling our own.
3521 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3523 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3525 * dispnew.c (scrolling_window): Before scrolling, turn off a
3526 mouse-highlight in the window being scrolled.
3528 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3530 Move DEFSYM to lisp.h and use everywhere.
3532 * character.h (DEFSYM): Move declaration...
3533 * lisp.h (DEFSYM): ...here.
3539 * w32select.c: Don't include character.h.
3541 * alloc.c (syms_of_alloc):
3542 * buffer.c (syms_of_buffer):
3543 * bytecode.c (syms_of_bytecode):
3544 * callint.c (syms_of_callint):
3545 * casefiddle.c (syms_of_casefiddle):
3546 * casetab.c (init_casetab_once):
3547 * category.c (init_category_once, syms_of_category):
3548 * ccl.c (syms_of_ccl):
3549 * cmds.c (syms_of_cmds):
3550 * composite.c (syms_of_composite):
3551 * dbusbind.c (syms_of_dbusbind):
3552 * dired.c (syms_of_dired):
3553 * dispnew.c (syms_of_display):
3554 * doc.c (syms_of_doc):
3555 * editfns.c (syms_of_editfns):
3556 * emacs.c (syms_of_emacs):
3557 * eval.c (syms_of_eval):
3558 * fileio.c (syms_of_fileio):
3559 * fns.c (syms_of_fns):
3560 * frame.c (syms_of_frame):
3561 * fringe.c (syms_of_fringe):
3562 * insdel.c (syms_of_insdel):
3563 * keymap.c (syms_of_keymap):
3564 * lread.c (init_obarray, syms_of_lread):
3565 * macros.c (syms_of_macros):
3566 * msdos.c (syms_of_msdos):
3567 * print.c (syms_of_print):
3568 * process.c (syms_of_process):
3569 * search.c (syms_of_search):
3570 * sound.c (syms_of_sound):
3571 * syntax.c (init_syntax_once, syms_of_syntax):
3572 * terminal.c (syms_of_terminal):
3573 * textprop.c (syms_of_textprop):
3574 * undo.c (syms_of_undo):
3575 * w32.c (globals_of_w32):
3576 * window.c (syms_of_window):
3577 * xdisp.c (syms_of_xdisp):
3578 * xfaces.c (syms_of_xfaces):
3579 * xfns.c (syms_of_xfns):
3580 * xmenu.c (syms_of_xmenu):
3581 * xsettings.c (syms_of_xsettings):
3582 * xterm.c (syms_of_xterm): Use DEFSYM.
3584 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3586 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3588 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3590 Integer and buffer overflow fixes (Bug#8873).
3592 * print.c (printchar, strout): Check for string overflow.
3593 (PRINTPREPARE, printchar, strout):
3594 Don't set size unless allocation succeeds.
3596 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3597 for sizes. Check for string overflow more accurately.
3598 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3600 * macros.c: Integer and buffer overflow fixes.
3601 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3602 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3603 Use ptrdiff_t, not int, for sizes.
3604 Don't increment bufsize until after realloc succeeds.
3605 Check for size-calculation overflow.
3606 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3608 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3610 * lread.c: Integer overflow fixes.
3611 (read_integer): Radix is now EMACS_INT, not int,
3612 to improve quality of diagnostics for out-of-range radices.
3613 Calculate buffer size correctly for out-of-range radices.
3614 (read1): Check for integer overflow in radices, and in
3615 read-circle numbers.
3616 (read_escape): Avoid int overflow.
3617 (Fload, openp, read_buffer_size, read1)
3618 (substitute_object_recurse, read_vector, read_list, map_obarray):
3619 Use ptrdiff_t, not int, for sizes.
3620 (read1): Use EMACS_INT, not int, for sizes.
3621 Check for size overflow.
3623 * image.c (cache_image): Check for size arithmetic overflow.
3625 * lread.c: Integer overflow issues.
3626 (saved_doc_string_size, saved_doc_string_length)
3627 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3628 Now ptrdiff_t, not int.
3629 (read1): Don't assume doc string length fits in int. Check for
3630 out-of-range doc string lengths.
3631 (read_list): Don't assume file position fits in int.
3632 (read_escape): Check for hex character overflow.
3634 2011-06-22 Leo Liu <sdl.web@gmail.com>
3636 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3637 Move to minibuffer.el.
3639 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3641 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3642 The following patches are for when GLYPH_DEBUG && !XASSERT.
3643 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3644 * dispnew.c (flush_stdout):
3645 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3646 Mark as externally visible.
3647 * dispnew.c (check_window_matrix_pointers): Now static.
3648 * dispnew.c (window_to_frame_vpos):
3649 * xfns.c (unwind_create_frame):
3650 * xterm.c (x_check_font): Remove unused local.
3651 * scroll.c (CHECK_BOUNDS):
3652 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3653 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3654 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3655 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3656 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3658 (debug_method_add): Use va_list and vsprintf rather than relying
3659 on undefined behavior with wrong number of arguments.
3660 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3661 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3662 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3663 since we're not interested in debugging glyphs with old libraries.
3664 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3665 GCC 4.6.0's static checking.
3667 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3669 Integer overflow and signedness fixes (Bug#8873).
3670 A few related buffer overrun fixes, too.
3672 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3674 * dispextern.h (struct face.stipple):
3675 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3676 (x_bitmap_mask, x_allocate_bitmap_record)
3677 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3678 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3679 (x_create_bitmap_from_xpm_data):
3680 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3681 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3683 * xfaces.c (load_pixmap):
3684 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3685 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3686 (.bitmaps_last, struct x_output.icon_bitmap):
3687 Use ptrdiff_t, not int, for bitmap indexes.
3688 (x_allocate_bitmap_record): Check for size overflow.
3689 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3691 Use ptrdiff_t, not int, for overlay counts.
3692 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3693 * editfns.c (overlays_around, get_pos_property):
3694 * textprop.c (get_char_property_and_overlay):
3695 * xdisp.c (next_overlay_change, note_mouse_highlight):
3696 * xfaces.c (face_at_buffer_position):
3697 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3698 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3699 (Fnext_overlay_change, Fprevious_overlay_change)
3700 (mouse_face_overlay_overlaps, Foverlays_in):
3701 Use ptrdiff_t, not int, for sizes.
3702 (overlays_at, overlays_in): Check for size-calculation overflow.
3704 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3706 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3707 (x_session_initialize): Do not assume string length fits in int.
3709 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3710 This is unlikely, but can occur if DPI is outlandish.
3712 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3713 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3715 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3716 * xrdb.c (magic_file_p, search_magic_path):
3717 Omit last arg SUFFIX; it was always 0. All callers changed.
3718 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3720 * xfont.c (xfont_match): Avoid need for strlen.
3722 * xfns.c: Don't assume strlen fits in int.
3723 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3725 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3726 not unsigned long, as we prefer signed integers. All callers changed.
3727 Detect integer overflow in repeat count.
3728 (message_dolog): Don't assume print length fits in 39 bytes.
3729 (display_mode_element): Don't assume strlen fits in int.
3731 * termcap.c: Don't assume sizes fit in int and never overflow.
3732 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3733 (gobble_line): Check for size-calculation overflow.
3735 * minibuf.c (Fread_buffer):
3736 * lread.c (intern, intern_c_string):
3737 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3738 Don't assume string length fits in int.
3740 * keyboard.c (parse_tool_bar_item):
3741 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3743 * font.c: Don't assume string length fits in int.
3744 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3745 Use ptrdiff_t, not int.
3746 (font_intern_prop): Don't assume string length fits in int.
3747 Don't assume integer property fits in fixnum.
3748 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3750 * filelock.c: Fix some buffer overrun and integer overflow issues.
3751 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3752 Reformulate so as not to need the command string.
3753 Invoke gzip -cd rather than gunzip, as it's more portable.
3754 (lock_info_type, lock_file_1, lock_file):
3755 Don't assume pid_t and time_t fit in unsigned long.
3756 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3757 (current_lock_owner): Prefer signed type for sizes.
3758 Use memcpy, not strncpy, where memcpy is what is really wanted.
3759 Don't assume (via atoi) that time_t and pid_t fit in int.
3760 Check for time_t and/or pid_t out of range, e.g., via a network share.
3761 Don't alloca where an auto var works fine.
3763 * fileio.c: Fix some integer overflow issues.
3764 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3765 Don't assume string length fits in int.
3766 (directory_file_name): Don't assume string length fits in long.
3767 (make_temp_name): Don't assume pid fits in int, or that its print
3768 length is less than 20.
3770 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3772 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3774 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3776 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3777 We prefer signed integers, even for size calculations.
3779 * emacs.c: Don't assume string length fits in 'int'.
3780 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3781 (main): Don't invoke strlen when not needed.
3783 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3784 (XD_DEBUG_MESSAGE): Don't waste a byte.
3786 * callproc.c (getenv_internal_1, getenv_internal)
3788 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3790 * lread.c (invalid_syntax): Omit length argument.
3791 All uses changed. This doesn't fix a bug, but it simplifies the
3792 code away from its former Hollerith-constant appearance, and it's
3793 one less 'int' to worry about when looking at integer-overflow issues.
3794 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3796 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3797 This didn't break anything, but it didn't help either.
3798 It's confusing to put a bogus integer in a place where the actual
3799 value does not matter.
3800 (LIST_END_P): Remove unused macro and its bogus comment.
3801 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3803 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3804 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3806 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3807 We prefer signed types, and the value cannot exceed the EMACS_INT
3808 range anyway (because otherwise the length would not be representable).
3809 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3810 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3811 This avoids a GCC warning when WIDE_EMACS_INT.
3813 * indent.c (sane_tab_width): New function.
3814 (current_column, scan_for_column, Findent_to, position_indentation)
3815 (compute_motion): Use it. This is just for clarity.
3816 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3818 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3820 * lisp.h (lint_assume): New macro.
3821 * composite.c (composition_gstring_put_cache):
3822 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3824 * editfns.c, insdel.c:
3825 Omit unnecessary forward decls, to simplify future changes.
3827 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3829 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3831 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3832 Use much-faster test for byte-length change.
3833 Don't assume string byte-length fits in 'int'.
3834 Check that character arg fits in 'int'.
3835 (mapcar1): Declare byte as byte, for clarity.
3837 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3839 * fns.c (concat): Catch string overflow earlier.
3840 Do not rely on integer wraparound.
3842 * dispextern.h (struct it.overlay_strings_charpos)
3843 (struct it.selective): Now EMACS_INT, not int.
3844 * xdisp.c (forward_to_next_line_start)
3845 (back_to_previous_visible_line_start)
3846 (reseat_at_next_visible_line_start, next_element_from_buffer):
3847 Don't arbitrarily truncate the value of 'selective' to int.
3849 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3851 * composite.c: Don't truncate sizes to 'int'.
3852 (composition_gstring_p, composition_reseat_it)
3853 (composition_adjust_point): Use EMACS_INT, not int.
3854 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3855 not EMACS_UINT, for indexes.
3857 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3859 * buffer.c: Include <verify.h>.
3860 (struct sortvec.priority, struct sortstr.priority):
3861 Now EMACS_INT, not int.
3862 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3863 (struct sortstr.size, record_overlay_string)
3864 (struct sortstrlist.size, struct sortlist.used):
3865 Don't truncate size to int.
3866 (record_overlay_string): Check for size-calculation overflow.
3867 (init_buffer_once): Check at compile-time, not run-time.
3869 2011-06-22 Jim Meyering <meyering@redhat.com>
3871 Don't leak an XBM-image-sized buffer
3872 * image.c (xbm_load): Free the image buffer after using it.
3874 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3877 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3878 that Sun C diagnosed.
3879 * fns.c (secure_hash): Fix pointer signedness issue.
3880 * intervals.c (static_offset_intervals): New function.
3881 (offset_intervals): Use it.
3883 2011-06-21 Leo Liu <sdl.web@gmail.com>
3886 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3889 * fns.c (secure_hash): Rename from crypto_hash_function and change
3890 the first arg to accept symbols.
3891 (Fsecure_hash): New primitive.
3892 (syms_of_fns): New symbols.
3894 2011-06-20 Deniz Dogan <deniz@dogan.se>
3896 * process.c (Fset_process_buffer): Clarify return value in
3899 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3901 * dispnew.c (add_window_display_history): Use BVAR.
3903 * xdisp.c (debug_method_add): Use BVAR.
3904 (check_window_end, dump_glyph_matrix, dump_glyph)
3905 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3907 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3910 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3911 check till after the cache is created in init_frame_faces.
3913 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3915 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3917 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3919 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3920 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3921 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3923 Improve buffer-overflow checking (Bug#8873).
3924 * fileio.c (Finsert_file_contents):
3925 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3926 Remove the old (too-loose) buffer overflow checks.
3927 They weren't needed, since make_gap checks for buffer overflow.
3928 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3929 The old code merely checked for Emacs fixnum overflow, and relied
3930 on undefined (wraparound) behavior. The new code avoids undefined
3931 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3933 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3934 Tune. Don't use wider integers than needed. Don't use alloca.
3935 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3937 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3939 * insdel.c, lisp.h (buffer_overflow): New function.
3940 (insert_from_buffer_1, replace_range, replace_range_2):
3941 * insdel.c (make_gap_larger):
3942 * editfns.c (Finsert_char):
3943 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3945 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3947 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3949 Integer overflow and signedness fixes (Bug#8873).
3951 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3952 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3954 * fileio.c: Don't assume EMACS_INT fits in off_t.
3955 (emacs_lseek): New static function.
3956 (Finsert_file_contents, Fwrite_region): Use it.
3957 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3959 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3961 * fns.c: Don't overflow int when computing a list length.
3962 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3963 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3964 truncation on 64-bit hosts. Check for QUIT every
3965 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3966 faster and is responsive enough.
3967 (Flength): Report an error instead of overflowing an integer.
3968 (Fsafe_length): Return a float if the value is not representable
3969 as a fixnum. This shouldn't happen except in contrived situations.
3970 (Fnthcdr, Fsort): Don't assume list length fits in int.
3971 (Fcopy_sequence): Don't assume vector length fits in int.
3973 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3974 (header_size, word_size): New constants.
3975 (allocate_vectorlike): Don't check size overflow here.
3976 (allocate_vector): Check it here instead, since this is the only
3977 caller of allocate_vectorlike that could cause overflow.
3978 Check that the new vector's length is representable as a fixnum.
3980 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3981 The previous code was bogus. For example, next_almost_prime (32)
3982 returned 39, which is undesirable as it is a multiple of 3; and
3983 next_almost_prime (24) returned 25, which is a multiple of 5 so
3984 why was the code bothering to check for multiples of 7?
3986 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3988 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3990 Variadic C functions now count arguments with ptrdiff_t.
3991 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3992 Back then I didn't know that the Emacs coding style prefers signed int.
3993 Also, in the meantime I found a few more instances where arguments
3994 were being counted with int, which may truncate counts on 64-bit
3995 machines, or EMACS_INT, which may be unnecessarily wide.
3996 * lisp.h (struct Lisp_Subr.function.aMANY)
3997 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3998 Arg counts are now ptrdiff_t, not size_t.
3999 All variadic functions and their callers changed accordingly.
4000 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4001 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4002 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4003 * callint.c (Fcall_interactively): Check arg count for overflow,
4004 to avoid potential buffer overrun. Use signed char, not 'int',
4005 for 'varies' array, so that we needn't bother to check its size
4006 calculation for overflow.
4007 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4008 * eval.c (apply_lambda):
4009 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4010 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4011 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4013 * callint.c (Fcall_interactively): Don't use index var as event count.
4015 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4016 * mem-limits.h (SIZE): Remove; no longer used.
4018 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4020 Remove unnecessary casts.
4021 * xterm.c (x_term_init):
4022 * xfns.c (x_set_border_pixel):
4023 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4024 These aren't needed now that we assume ANSI C.
4026 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4027 It's more likely to cause problems (due to unsigned overflow)
4030 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4032 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4034 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4036 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4038 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4040 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4042 GLYPH_CODE_FACE returns EMACS_INT, not int.
4043 * dispextern.h (merge_faces):
4044 * xfaces.c (merge_faces):
4045 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4046 Don't assume EMACS_INT fits in int.
4048 * character.h (CHAR_VALID_P): Remove unused parameter.
4049 * fontset.c, lisp.h, xdisp.c: All uses changed.
4051 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4053 * fns.c (concat): Minor tuning based on overflow analysis.
4054 This doesn't fix any bugs. Use int to hold character, instead
4055 of constantly refetching from Emacs object. Use XFASTINT, not
4056 XINT, for value known to be a character. Don't bother comparing
4057 a single byte to 0400, as it's always less.
4059 * floatfns.c (Fexpt):
4060 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4062 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4065 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4067 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4068 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4069 incorrectly succeed when S was a string, because 4294967386 was
4070 truncated before it was used.
4072 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4073 Otherwise, an out-of-range integer could cause undefined behavior
4076 * composite.c: Use int, not EMACS_INT, for characters.
4077 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4078 EMACS_INT, for values that are known to be in character range.
4079 This doesn't fix any bugs but is the usual style inside Emacs and
4080 may generate better code on 32-bit machines.
4082 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4083 This is for reasons similar to the recent CHAR_STRING fix.
4084 * charset.c (Fencode_char): Check that character arg is actually
4085 a character. Pass an int to ENCODE_CHAR.
4086 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4087 wider than 'int', as a compile-time check to prevent future regressions
4090 * character.c (char_string): Remove unnecessary casts.
4092 Make sure a 64-bit char is never passed to CHAR_STRING.
4093 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4094 by silently ignoring the top 32 bits, allowing some values
4095 that were far too large to be valid characters.
4096 * character.h: Include <verify.h>.
4097 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4098 arguments are no wider than unsigned, as a compile-time check
4099 to prevent future regressions in this area.
4101 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4102 (Fsubst_char_in_region):
4104 * xdisp.c (decode_mode_spec_coding):
4105 Adjust to CHAR_STRING's new requirement.
4106 * editfns.c (Finsert_char, Fsubst_char_in_region):
4107 * fns.c (concat): Check that character args are actually
4108 characters. Without this test, these functions did the wrong
4109 thing with wildly out-of-range values on 64-bit hosts.
4111 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4112 These casts should not be needed on 32-bit hosts, either.
4113 * keyboard.c (read_char):
4114 * lread.c (Fload): Remove casts to unsigned.
4116 * lisp.h (UNSIGNED_CMP): New macro.
4117 This fixes comparison bugs on 64-bit hosts.
4118 (ASCII_CHAR_P): Use it.
4119 * casefiddle.c (casify_object):
4120 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4121 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4122 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4123 * dispextern.h (FACE_FROM_ID):
4124 * keyboard.c (read_char): Use UNSIGNED_CMP.
4126 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4127 not to EMACS_INT, to avoid GCC warning.
4129 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4131 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4132 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4133 isn't needed on 32-bit machines.
4135 * buffer.c (Fgenerate_new_buffer_name):
4136 Use EMACS_INT for count, not int.
4137 (advance_to_char_boundary): Return EMACS_INT, not int.
4139 * data.c (Qcompiled_function): Now static.
4141 * window.c (window_body_lines): Now static.
4143 * image.c (gif_load): Rename local to avoid shadowing.
4145 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4146 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4147 * alloc.c (make_save_value): Integer argument is now of type
4149 (mark_object): Use ptrdiff_t, not int.
4150 * lisp.h (pD): New macro.
4151 * print.c (print_object): Use it.
4153 * alloc.c: Use EMACS_INT, not int, to count objects.
4154 (total_conses, total_markers, total_symbols, total_vector_size)
4155 (total_free_conses, total_free_markers, total_free_symbols)
4156 (total_free_floats, total_floats, total_free_intervals)
4157 (total_intervals, total_strings, total_free_strings):
4158 Now EMACS_INT, not int. All uses changed.
4159 (Fgarbage_collect): Compute overall total using a double, so that
4160 integer overflow is less likely to be a problem. Check for overflow
4161 when converting back to an integer.
4162 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4163 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4164 These were 'int' variables that could overflow on 64-bit hosts;
4165 they were never used, so remove them instead of repairing them.
4166 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4167 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4168 Previously, this ceilinged at INT_MAX, but that doesn't work on
4170 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4172 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4173 (allocate_vectorlike): Check for ptrdiff_t overflow.
4174 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4175 when a (possibly-narrower) signed value would do just as well.
4176 We prefer using signed arithmetic, to avoid comparison confusion.
4178 * alloc.c: Catch some string size overflows that we were missing.
4179 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4180 for convenience in STRING_BYTES_MAX.
4181 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4182 The definition here is exact; the one in lisp.h was approximate.
4183 (allocate_string_data): Check for string overflow. This catches
4184 some instances we weren't catching before. Also, it catches
4185 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4186 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4187 and ptrdiff_t and EMACS_INT are both 64 bits.
4189 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4190 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4191 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4193 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4195 * alloc.c (Fmake_string): Check for out-of-range init.
4197 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4199 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4201 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4203 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4204 xg_get_default_scrollbar_width.
4206 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4207 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4208 (style_changed_cb): Call update_theme_scrollbar_width and call
4209 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4210 all frames (Bug#8505).
4211 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4212 Call gtk_window_set_resizable if HAVE_GTK3.
4213 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4214 and height if HAVE_GTK3 (Bug#8505).
4215 (scroll_bar_width_for_theme): New variable.
4216 (update_theme_scrollbar_width): New function.
4217 (xg_get_default_scrollbar_width): Move code to
4218 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4219 (xg_initialize): Call update_theme_scrollbar_width.
4221 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4223 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4225 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4227 * frame.c (make_frame): Call other_buffer_safely instead of
4230 * window.c (temp_output_buffer_show): Call display_buffer with
4231 second argument Vtemp_buffer_show_specifiers and reset latter
4232 immediately after the call.
4233 (Vtemp_buffer_show_specifiers): New variable.
4234 (auto_window_vscroll_p, next_screen_context_lines)
4235 (Vscroll_preserve_screen_position): Remove leading asterisks from
4238 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4240 Fix minor problems found by GCC 4.6.0 static checking.
4241 * buffer.c (Qclone_number): Remove for now, as it's unused.
4242 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4243 (record_buffer): Remove unused local.
4244 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4245 (set_frame_buffer_list): Remove; unused.
4246 * frame.h (other_visible_frames): Remove decl.
4247 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4248 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4249 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4251 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4252 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4253 Define only if HAVE_GPM.
4254 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4255 (update_hints_inhibit): Remove; never set. All uses removed.
4256 * widgetprv.h (emacsFrameClassRec): Remove decl.
4257 * window.c (delete_deletable_window): Now returns void, since it
4258 wasn't returning anything.
4259 (compare_window_configurations): Remove unused locals.
4260 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4261 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4262 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4263 the same widths as pointers. This follows up on the 2011-05-06 patch.
4264 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4265 * xterm.h: Likewise.
4266 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4268 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4270 * makefile.w32-in: Update dependencies.
4271 (LISP_H): Add lib/intprops.h.
4273 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4275 * image.c (gif_load): Add animation frame delay to the metadata.
4276 (syms_of_image): Use DEFSYM. New symbol `delay'.
4278 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4280 * window.c (delete_deletable_window): Re-add.
4281 (Fset_window_configuration): Rewrite to handle dead buffers and
4282 consequently deletable windows.
4283 (window_tree, Fwindow_tree): Remove. Supply functionality in
4285 (compare_window_configurations): Simplify code.
4287 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4289 * image.c (imagemagick_load_image): Fix type mismatch.
4290 (Fimagemagick_types): Likewise.
4292 * window.h (replace_buffer_in_windows): Declare.
4294 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4296 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4297 Qclone_number. Remove external declaration of Qdelete_window.
4298 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4300 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4301 Run Qbuffer_list_update_hook if allowed.
4302 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4303 buffer list implementation.
4304 (other_buffer_safely): New function.
4305 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4306 calls to replace_buffer_in_windows and
4307 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4309 (record_buffer): Inhibit quitting and rewrite using quittable
4310 functions. Run Qbuffer_list_update_hook if allowed.
4311 (Frecord_buffer, Funrecord_buffer): New functions.
4312 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4313 Move switch-to-buffer to window.el.
4314 (bury-buffer): Move to window.el.
4315 (Vbuffer_list_update_hook): New variable.
4317 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4320 * window.h (resize_frame_windows): Move up in code.
4321 (Fwindow_frame): Remove EXFUN.
4322 (replace_buffer_in_all_windows): Remove prototype.
4323 (replace_buffer_in_windows_safely): Add prototype.
4325 * window.c: Declare Qdelete_window static again. Move down
4326 declaration of select_count.
4327 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4328 (Fother_window): Move to window.el.
4329 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4330 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4331 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4333 (replace_buffer_in_windows): Implement by calling
4334 Qreplace_buffer_in_windows.
4335 (replace_buffer_in_all_windows): Remove with some functionality
4336 moved into replace_buffer_in_windows_safely.
4337 (replace_buffer_in_windows_safely): New function.
4338 (select_window_norecord, select_frame_norecord): Move in front
4339 of run_window_configuration_change_hook. Remove now obsolete
4341 (Fset_window_buffer): Rewrite doc-string.
4342 Call Qrecord_window_buffer.
4343 (keys_of_window): Move binding for other-window to window.el.
4345 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4347 * dispextern.h (struct image): Replace data member, whose int_val
4348 and ptr_val fields were not used by anything, with a single
4351 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4352 (gif_clear_image, gif_load, imagemagick_load_image)
4353 (gs_clear_image, gs_load): Callers changed.
4355 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4357 * buffer.h: Include <time.h>, for time_t.
4358 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4360 Fix minor problems found by static checking.
4362 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4364 Make identifiers static if they are not used in other modules.
4365 * data.c (Qcompiled_function, Qframe, Qvector):
4366 * image.c (QimageMagick, Qsvg):
4367 * minibuf.c (Qmetadata):
4368 * window.c (resize_window_check, resize_root_window): Now static.
4369 * window.h (resize_window_check, resize_root_window): Remove decls.
4371 * window.c (window_deletion_count, delete_deletable_window):
4373 (window_body_lines): Now static.
4374 (Fdelete_other_windows_internal): Mark vars as initialized.
4375 Make sure 'resize_failed' is initialized.
4376 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4377 (resize_window_apply): Remove unused local.
4378 * window.h (delete_deletable_window): Remove decl.
4380 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4381 (imagemagick_load_image): Fix pointer signedness problem by changing
4382 last arg from unsigned char * to char *. All uses changed.
4383 Also, fix a local for similar reasons.
4384 Remove unused locals. Remove locals to avoid shadowing.
4385 (fn_rsvg_handle_free): Remove; unused.
4386 (svg_load, svg_load_image): Fix pointer signedness problem.
4387 (imagemagick_load_image): Don't use garbage pointer image_wand.
4389 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4391 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4393 * image.c (gif_load): Fix omitted cast error introduced by
4396 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4398 * window.h (resize_proportionally, orig_total_lines)
4399 (orig_top_line): Remove from window structure.
4400 (set_window_height, set_window_width, change_window_heights)
4401 (Fdelete_window): Remove prototypes.
4402 (resize_frame_windows): Remove duplicate declaration.
4404 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4406 * window.h (resize_frame_windows, resize_window_check)
4407 (delete_deletable_window, resize_root_window)
4408 (resize_frame_windows): Declare prototypes.
4410 * window.c (resize_window_apply): Make definition be "static" to
4411 match the prototype.
4413 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4415 * window.c: Remove declarations of Qwindow_size_fixed,
4416 window_min_size_1, window_min_size_2, window_min_size,
4417 size_window, window_fixed_size_p, enlarge_window, delete_window.
4418 Remove static from declaration of Qdelete_window, it's
4419 temporarily needed by Fbury_buffer.
4420 (replace_window): Don't assign orig_top_line and
4422 (Fdelete_window, delete_window): Remove. Window deletion is
4423 handled by window.el.
4424 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4425 Replace Fdelete_window calls with calls to Qdelete_window.
4426 (Fdelete_other_windows): Remove. Deleting other windows is
4427 handled by window.el.
4428 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4429 handled in window.el.
4430 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4431 Window minimum sizes are handled in window.el.
4432 (shrink_windows, size_window, set_window_height)
4433 (set_window_width, change_window_heights, window_height)
4434 (window_width, CURBEG, CURSIZE, enlarge_window)
4435 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4436 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4437 handled in window.el.
4438 (make_dummy_parent): Rename to make_parent_window and give it a
4439 second argument horflag.
4440 (make_window): Don't set resize_proportionally any more.
4441 (Fsplit_window): Remove. Windows are split in window.el.
4442 (save_restore_action, save_restore_orig_size)
4443 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4444 Resize mini windows in window.el.
4445 (grow_mini_window, shrink_mini_window): Implement by calling
4446 Qresize_root_window_vertically, resize_window_check and
4447 resize_window_apply.
4448 (saved_window, Fset_window_configuration, save_window_save):
4449 Do not handle orig_top_line, orig_total_lines, and
4450 resize_proportionally.
4451 (window_min_height, window_min_width): Move to window.el.
4452 (keys_of_window): Move bindings for delete-other-windows,
4453 split-window, delete-window and enlarge-window to window.el.
4455 * buffer.c: Temporarily extern Qdelete_window.
4456 (Fbury_buffer): Temporarily call Qdelete_window instead of
4457 Fdelete_window (Fbury_buffer will move to window.el soon).
4459 * frame.c (set_menu_bar_lines_1): Remove code handling
4460 orig_top_line and orig_total_lines.
4462 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4463 set_window_height but set heights directly.
4464 (change_frame_size_1): Use resize_frame_windows.
4466 * xdisp.c (init_xdisp): Don't use set_window_height but set
4469 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4470 Use resize_frame_windows instead of change_window_heights and run
4471 run_window_configuration_change_hook.
4473 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4474 instead of change_window_heights and run
4475 run_window_configuration_change_hook.
4477 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4479 * window.c (replace_window): Rename second argument REPLACEMENT to
4480 NEW. New third argument SETFLAG. Rewrite.
4481 (delete_window, make_dummy_parent): Call replace_window with
4483 (window_list_1): Move down in code.
4484 (run_window_configuration_change_hook): Move set_buffer part
4485 before select_frame_norecord part in order to unwind correctly.
4486 Rename count1 to count.
4487 (recombine_windows, delete_deletable_window, resize_root_window)
4488 (Fdelete_other_windows_internal)
4489 (Frun_window_configuration_change_hook, make_parent_window)
4490 (resize_window_check, resize_window_apply, Fresize_window_apply)
4491 (resize_frame_windows, Fsplit_window_internal)
4492 (Fdelete_window_internal, Fresize_mini_window_internal):
4494 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4496 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4498 * window.h (window): Add some new members to window structure -
4499 normal_lines, normal_cols, new_total, new_normal, clone_number,
4500 splits, nest, prev_buffers, next_buffers.
4501 (WINDOW_TOTAL_SIZE): Move here from window.c.
4502 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4504 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4506 (make_dummy_parent): Set new members of windows structure.
4507 (make_window): Move down in code. Handle new members of window
4509 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4510 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4511 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4512 (Fset_window_prev_buffers, Fwindow_next_buffers)
4513 (Fset_window_next_buffers, Fset_window_clone_number):
4515 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4516 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4518 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4519 Argument WINDOW can be now internal window too.
4520 (Fwindow_use_time): Move up in code.
4521 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4523 (Fset_window_configuration, saved_window)
4524 (Fcurrent_window_configuration, save_window_save): Handle new
4525 members of window structure.
4526 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4527 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4528 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4529 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4530 Qget_mru_window, Qresize_root_window,
4531 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4532 Qauto_buffer_name; staticpro them.
4534 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4536 * window.c (Fwindow_total_size, Fwindow_left_column)
4537 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4538 (Fwindow_list_1): New functions.
4539 (window_box_text_cols): Replace with window_body_cols.
4540 (Fwindow_width, Fscroll_left, Fscroll_right):
4541 Use window_body_cols instead of window_box_text_cols.
4542 (delete_window, Fset_window_configuration):
4543 Call delete_all_subwindows with window as argument.
4544 (delete_all_subwindows): Take a window as argument and not a
4546 (window_loop): Remove handling of GET_LRU_WINDOW and
4548 (Fget_lru_window, Fget_largest_window): Move to window.el.
4550 * window.h: Extern window_body_cols instead of
4551 window_box_text_cols. delete_all_subwindows now takes a
4552 Lisp_Object as argument.
4554 * indent.c (compute_motion, Fcompute_motion):
4555 Use window_body_cols instead of window_box_text_cols.
4557 * frame.c (delete_frame): Call delete_all_subwindows with root
4560 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4562 * fns.c (Fputhash): Document return value.
4564 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4566 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4568 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4570 Cons<->int and similar integer overflow fixes (Bug#8794).
4572 Check for overflow when converting integer to cons and back.
4573 * charset.c (Fdefine_charset_internal, Fdecode_char):
4574 Use cons_to_unsigned to catch overflow.
4575 (Fencode_char): Use INTEGER_TO_CONS.
4576 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4577 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4578 * data.c (long_to_cons, cons_to_long): Remove.
4579 (cons_to_unsigned, cons_to_signed): New functions.
4580 These signal an error for invalid or out-of-range values.
4581 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4582 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4583 * font.c (Ffont_variation_glyphs):
4584 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4585 * lisp.h: Include <intprops.h>.
4586 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4587 (cons_to_signed, cons_to_unsigned): New decls.
4588 (long_to_cons, cons_to_long): Remove decls.
4589 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4590 (Fprimitive_undo): Use CONS_TO_INTEGER.
4591 * xfns.c (Fx_window_property): Likewise.
4592 * xselect.c: Include <limits.h>.
4593 (x_own_selection, selection_data_to_lisp_data):
4594 Use INTEGER_TO_CONS.
4595 (x_handle_selection_request, x_handle_selection_clear)
4596 (x_get_foreign_selection, Fx_disown_selection_internal)
4597 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4598 (lisp_data_to_selection_data): Use cons_to_unsigned.
4599 (x_fill_property_data): Use cons_to_signed.
4600 Report values out of range.
4602 Check for buffer and string overflow more precisely.
4603 * buffer.h (BUF_BYTES_MAX): New macro.
4604 * lisp.h (STRING_BYTES_MAX): New macro.
4605 * alloc.c (Fmake_string):
4606 * character.c (string_escape_byte8):
4607 * coding.c (coding_alloc_by_realloc):
4608 * doprnt.c (doprnt):
4609 * editfns.c (Fformat):
4611 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4612 since they may not be the same number.
4613 * editfns.c (Finsert_char):
4614 * fileio.c (Finsert_file_contents):
4615 Likewise for BUF_BYTES_MAX.
4617 * image.c: Use ptrdiff_t, not int, for sizes.
4618 (slurp_file): Switch from int to ptrdiff_t.
4620 (slurp_file): Check that file size fits in both size_t (for
4621 malloc) and ptrdiff_t (for sanity and safety).
4623 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4624 if b->modtime has its maximal value.
4626 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4628 Don't assume time_t can fit into int.
4629 * buffer.h (struct buffer.modtime): Now time_t, not int.
4630 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4631 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4633 Minor fixes for signed vs unsigned integers.
4634 * character.h (MAYBE_UNIFY_CHAR):
4635 * charset.c (maybe_unify_char):
4636 * keyboard.c (read_char, reorder_modifiers):
4637 XINT -> XFASTINT, since the integer must be nonnegative.
4638 * ftfont.c (ftfont_spec_pattern):
4639 * keymap.c (access_keymap, silly_event_symbol_error):
4640 XUINT -> XFASTINT, since the integer must be nonnegative.
4641 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4642 since it makes no difference and we prefer signed.
4643 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4644 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4647 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4649 * window.h (Fwindow_frame): Declare.
4651 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4653 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4654 (SPARE_MEMORY): Always define.
4655 (LARGE_REQUEST): Remove.
4656 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4658 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4660 * lisp.h: Move EXFUNS for Fframe_root_window,
4661 Fframe_first_window and Fset_frame_selected_window to window.h.
4663 * window.h: Move EXFUNS for Fframe_root_window,
4664 Fframe_first_window and Fset_frame_selected_window here from
4667 * frame.c (Fwindow_frame, Fframe_first_window)
4668 (Fframe_root_window, Fframe_selected_window)
4669 (Fset_frame_selected_window): Move to window.c.
4670 (Factive_minibuffer_window): Move to minibuf.c.
4671 (Fother_visible_frames_p): New function.
4673 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4675 * window.c (decode_window, decode_any_window): Move up in code.
4676 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4677 (inhibit_frame_unsplittable): Remove unused variable.
4678 (Fwindow_buffer): Move up and rewrite doc-string.
4679 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4680 (Fwindow_prev): New functions.
4681 (Fwindow_frame): Move here from frame.c. Accept any window as
4683 (Fframe_root_window, Fframe_first_window)
4684 (Fframe_selected_window): Move here from frame.c. Accept frame
4685 or arbitrary window as argument. Update doc-strings.
4686 (Fminibuffer_window): Move up in code.
4687 (Fwindow_minibuffer_p): Move up in code and simplify.
4688 (Fset_frame_selected_window): Move here from frame.c.
4690 (Fselected_window, select_window, Fselect_window): Move up in
4691 code. Minor doc-string fixes.
4693 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4695 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4696 Do not assume that spare memory exists; that assumption is valid
4697 only if SYSTEM_MALLOC.
4698 (LARGE_REQUEST): New macro, so that the issue of large requests
4699 is separated from the issue of spare memory.
4701 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4703 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4706 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4708 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4711 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4713 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4715 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4717 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4718 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4720 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4722 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4724 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4726 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4727 (x_clipboard_manager_save): Add return value.
4728 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4730 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4731 Obey Vx_select_enable_clipboard_manager. Catch errors in
4732 x_clipboard_manager_save (Bug#8779).
4733 (Vx_select_enable_clipboard_manager): New variable.
4734 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4736 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4738 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4740 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4742 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4743 in the current matrix if keep_current_p is non-zero.
4745 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4747 * bidi.c (bidi_level_of_next_char): Fix last change.
4749 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4751 Support bidi reordering of text covered by display properties.
4753 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4754 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4755 (bidi_cache_search, bidi_cache_iterator_state)
4756 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4757 (bidi_level_of_next_char, bidi_move_to_visually_next):
4758 Support character positions inside a run of characters covered by a
4760 (bidi_paragraph_init, bidi_resolve_explicit_1)
4761 (bidi_level_of_next_char): Call bidi_fetch_char and
4762 bidi_fetch_char_advance instead of FETCH_CHAR and
4764 (bidi_init_it): Initialize new members.
4765 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4767 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4768 instead of using explicit *_CHAR codes.
4769 (bidi_resolve_explicit, bidi_resolve_weak):
4770 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4771 bidirectional text is supported only in multibyte buffers.
4772 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4773 it to initialize the frame_window_p member of struct bidi_it.
4774 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4775 (bidi_resolve_explicit, bidi_resolve_weak)
4776 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4777 bidi_it->nchars is non-positive.
4778 (bidi_level_of_next_char): Don't try to lookup the cache for the
4779 next/previous character if nothing is cached there yet, or if we
4780 were just reseat()'ed to a new position.
4782 * xdisp.c (set_cursor_from_row): Set start and stop points
4783 according to the row's direction when priming the loop that looks
4784 for the glyph on which to display cursor.
4785 (single_display_spec_intangible_p): Function deleted.
4786 (display_prop_intangible_p): Reimplement to call
4787 handle_display_spec instead of single_display_spec_intangible_p.
4788 Accept 3 additional arguments needed by handle_display_spec.
4789 This fixes incorrect cursor motion across display property with complex
4790 values: lists, `(when COND...)' forms, etc.
4791 (single_display_spec_string_p): Support property values that are
4792 lists with the argument STRING its top-level element.
4793 (display_prop_string_p): Fix the condition for processing a
4794 property that is a list to be consistent with handle_display_spec.
4795 (handle_display_spec): New function, refactored from the
4796 last portion of handle_display_prop.
4797 (compute_display_string_pos): Accept additional argument
4798 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4799 value of a `display' property is a "replacing spec".
4800 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4801 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4802 the display property, but just return a value indicating whether
4803 the display property will replace the characters it covers.
4804 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4805 frame_window_p members of struct bidi_it.
4806 (compute_display_string_pos, compute_display_string_end):
4808 (push_it): Accept second argument POSITION, where pop_it should
4809 jump to continue iteration.
4810 (reseat_1): Initialize bidi_it.disp_pos.
4812 * keyboard.c (adjust_point_for_property): Adjust the call to
4813 display_prop_intangible_p to its new signature.
4815 * dispextern.h (struct bidi_it): New member frame_window_p.
4816 (bidi_init_it): Update prototypes.
4817 (display_prop_intangible_p): Update prototype.
4818 (compute_display_string_pos, compute_display_string_end):
4820 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4823 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4825 Malloc failure behavior now depends on size of allocation.
4826 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4827 * lisp.h: Change signatures accordingly.
4828 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4829 All callers changed. (Bug#8762)
4831 * gnutls.c: Use Emacs's memory allocators.
4832 Without this change, the gnutls library would invoke malloc etc.
4833 directly, which causes problems on non-SYNC_INPUT hosts, and which
4834 runs afoul of improving memory_full behavior. (Bug#8761)
4835 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4836 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4837 xfree instead of the default malloc, realloc, free.
4838 (Fgnutls_boot): No need to check for memory allocation failure,
4839 since xmalloc does that for us.
4841 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4842 * category.c (hash_get_category_set):
4843 * ccl.c (ccl_driver):
4844 * charset.c (Fdefine_charset_internal):
4845 * charset.h (struct charset.hash_index):
4846 * composite.c (get_composition_id, gstring_lookup_cache)
4847 (composition_gstring_put_cache):
4848 * composite.h (struct composition.hash_index):
4849 * dispextern.h (struct image.hash):
4850 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4851 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4852 (hashfn_equal, hashfn_user_defined, make_hash_table)
4853 (maybe_resize_hash_table, hash_lookup, hash_put)
4854 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4855 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4856 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4857 * image.c (make_image, search_image_cache, lookup_image)
4858 (xpm_put_color_table_h):
4859 * lisp.h (struct Lisp_Hash_Table):
4860 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4861 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4862 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4863 * alloc.c (allocate_vectorlike):
4864 Check for overflow in vector size calculations.
4865 * ccl.c (ccl_driver):
4866 Check for overflow when converting EMACS_INT to int.
4867 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4868 need to be updated by these changes.
4869 * fns.c (make_hash_table, maybe_resize_hash_table):
4870 Check for integer overflow with large hash tables.
4871 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4872 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4873 (SXHASH_REDUCE): New macro.
4874 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4875 Use it instead of discarding useful hash info with large hash values.
4876 (sxhash_float): New function.
4877 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4878 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4879 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4880 Rewrite to use FIXNUM_BITS, as this simplifies things.
4881 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4882 Adjust signatures to match updated version of code.
4883 (consing_since_gc): Now EMACS_INT, since a single hash table can
4884 use more than INT_MAX bytes.
4886 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4888 Make it possible to build with GCC-4.6+ -O2 -flto.
4890 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4892 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4894 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4895 Call minibuffer-inactive-mode.
4897 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4899 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4900 Update dependencies.
4902 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4904 * data.c (init_data): Remove code for UTS, this system is not
4907 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4909 Don't force ./temacs to start in terminal mode.
4911 * frame.c (make_initial_frame): Initialize faces in all cases, not
4912 only when CANNOT_DUMP is defined.
4913 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4915 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4917 * dispnew.c (add_window_display_history): Use const for the string
4918 pointer. Remove declaration, not needed.
4920 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4922 Use 'inline', not 'INLINE'.
4923 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4924 * alloc.c, fontset.c (INLINE): Remove.
4925 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4926 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4927 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4928 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4929 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4931 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4933 Make it possible to run ./temacs.
4935 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4936 syms_of_callproc does the same thing. Remove test for
4937 "initialized", do it in the caller.
4938 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4940 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4942 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4943 (read_minibuf): Use get_minibuffer.
4944 (syms_of_minibuf): Use DEFSYM.
4945 (Qmetadata): New var.
4946 * data.c (Qbuffer): Don't make it static.
4947 (syms_of_data): Use DEFSYM.
4949 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4951 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4952 (CCL_CODE_MIN): New macro.
4954 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4956 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4958 * eval.c (Qdebug): Now static.
4959 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4960 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4961 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4963 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4965 * image.c: Various fixes to ImageMagick code comments.
4966 (Fimagemagick_types): Doc fix.
4968 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4970 Minor fixes prompted by GCC 4.6.0 warnings.
4972 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4974 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4975 (x_clipboard_manager_save_all): Move extern decl to ...
4976 * xterm.h: ... here, so that it can be checked for consistency.
4978 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4980 * xselect.c (x_clipboard_manager_save_frame)
4981 (x_clipboard_manager_save_all): New functions.
4982 (Fx_clipboard_manager_save): Lisp function deleted.
4984 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4985 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4987 * xterm.h: Update prototype.
4989 2011-05-28 William Xu <william.xwl@gmail.com>
4991 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4994 2011-05-28 Jim Meyering <meyering@redhat.com>
4996 Avoid a sign-extension bug in crypto_hash_function.
4997 * fns.c (to_uchar): Define.
4998 (crypto_hash_function): Use it to convert some newly-signed
4999 variables to unsigned, to avoid sign-extension bugs. For example,
5000 without this change, (md5 "truc") would evaluate to
5001 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5002 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5003 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5005 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5007 Integer overflow fixes.
5009 * dbusbind.c: Serial number integer overflow fixes.
5010 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5011 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5012 to hold a serial number that is too large for a fixnum.
5013 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5014 Check for serial numbers out of range. Decode any serial number
5015 that was so large that it became a float. (Bug#8722)
5017 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5018 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5019 Use XFASTINT rather than XUINT when numbers are nonnegative.
5020 (xd_append_arg, Fdbus_method_return_internal):
5021 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5022 arguments, check that Lisp number is nonnegative, rather than
5023 silently wrapping negative numbers around. (Bug#8722)
5024 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5027 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5029 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5031 ccl: add integer overflow checks
5032 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5033 (IN_INT_RANGE): New macros.
5034 (ccl_driver): Use them to check for integer overflow when
5035 decoding a CCL program. Many of the new checks are whether XINT (x)
5036 fits in int; it doesn't always, on 64-bit hosts. The new version
5037 doesn't catch all possible integer overflows, but it's an
5038 improvement. (Bug#8719)
5040 * alloc.c (make_event_array): Use XINT, not XUINT.
5041 There's no need for unsigned here.
5043 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5044 This follows up to the 2011-05-06 change that substituted uintptr_t
5045 for EMACS_INT. This case wasn't caught back then.
5047 Rework Fformat to avoid integer overflow issues.
5048 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5049 now (part of C89). Include <verify.h>.
5050 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5051 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5052 (Fformat): Avoid the prepass trying to compute sizes; it was only
5053 approximate and thus did not catch overflow reliably. Instead, walk
5054 through the format just once, formatting and computing sizes as we go,
5055 checking for integer overflow at every step, and allocating a larger
5056 buffer as needed. Keep track separately whether the format is
5057 multibyte. Keep only the most-recently calculated precision, rather
5058 than them all. Record whether each argument has been converted to
5059 string. Use EMACS_INT, not int, for byte and char and arg counts.
5060 Support field widths and precisions larger than INT_MAX. Avoid
5061 sprintf's undefined behavior with conversion specifications such as %#d
5062 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5063 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5064 formatting out-of-range floating point numbers with int
5067 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5069 * data.c: Avoid integer truncation in expressions involving floats.
5070 * data.c: Include <intprops.h>.
5071 (arith_driver): When there's an integer overflow in an expression
5072 involving floating point, convert the integers to floating point
5073 so that the resulting value does not suffer from catastrophic
5074 integer truncation. For example, on a 64-bit host (* 4
5075 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5076 Do not rely on undefined behavior after integer overflow.
5078 merge count_size_as_multibyte, parse_str_to_multibyte
5079 * character.c, character.h (count_size_as_multibyte):
5080 Rename from parse_str_to_multibyte; all uses changed.
5081 Check for integer overflow.
5082 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5083 since it's now a duplicate of the other. This is more of
5084 a character than a buffer op, so better that it's in character.c.
5085 * fns.c, print.c: Adjust to above changes.
5087 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5089 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5091 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5093 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5094 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5095 (x_clipboard_manager_save): Now static.
5096 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5098 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5099 (crypto_hash_function): Now static.
5100 Fix pointer signedness problems. Avoid unnecessary initializations.
5102 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5104 * termhooks.h (Vselection_alist): Make it terminal-local.
5106 * terminal.c (create_terminal): Initialize it.
5108 * xselect.c: Support for clipboard managers.
5109 (Vselection_alist): Move to termhooks.h as terminal-local var.
5110 (LOCAL_SELECTION): New macro.
5111 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5112 (symbol_to_x_atom): Remove gratuitous arg.
5113 (x_handle_selection_request, lisp_data_to_selection_data)
5114 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5115 (x_own_selection, x_get_local_selection, x_convert_selection):
5116 New arg, specifying work frame. Use terminal-local Vselection_alist.
5117 (some_frame_on_display): Delete unused function.
5118 (Fx_own_selection_internal, Fx_get_selection_internal)
5119 (Fx_disown_selection_internal, Fx_selection_owner_p)
5120 (Fx_selection_exists_p): New optional frame arg.
5121 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5122 (x_handle_selection_clear): Don't treat other terminals with the
5123 same keyboard specially. Use the terminal-local Vselection_alist.
5124 (x_clear_frame_selections): Use Frun_hook_with_args.
5126 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5128 * xterm.h: Add support for those atoms.
5130 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5132 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5133 (converted_selections, conversion_fail_tag): New global variables.
5134 (x_selection_request_lisp_error): Free the above.
5135 (x_get_local_selection): Remove unnecessary code.
5136 (x_reply_selection_request): Args changed; handle arbitrary array
5137 of converted selections stored in converted_selections.
5138 Separate the XChangeProperty and SelectionNotify steps.
5139 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5140 (x_convert_selection): New function.
5141 (x_handle_selection_event): Simplify.
5142 (x_get_foreign_selection): Don't ignore incoming requests while
5143 waiting for an answer; this will fail when we implement
5144 SAVE_TARGETS, and seems unnecessary anyway.
5145 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5146 (Vx_sent_selection_functions): Doc fix.
5148 2011-05-26 Leo Liu <sdl.web@gmail.com>
5150 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5152 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5154 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5156 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5157 for fringe update if it has periodic bitmap.
5158 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5159 and fringe_bitmap_periodic_p.
5161 * fringe.c (get_fringe_bitmap_data): New function.
5162 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5163 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5164 row. Mark glyph row for fringe update if periodicity changed.
5166 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5167 for fringe update unless it has periodic bitmap.
5169 2011-05-25 Kenichi Handa <handa@m17n.org>
5171 * xdisp.c (get_next_display_element): Set correct it->face_id for
5172 a static composition.
5174 2011-05-24 Leo Liu <sdl.web@gmail.com>
5177 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5179 * fns.c (crypto_hash_function, Fsha1): New function.
5180 (Fmd5): Use crypto_hash_function.
5181 (syms_of_fns): Add Ssha1.
5183 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5185 * gnutls.c: Remove unused macros.
5186 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5187 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5188 Remove macros that are defined and never used.
5189 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5191 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5193 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5194 (Fx_get_selection_internal): Minor cleanup.
5195 (Fx_own_selection_internal): Rename arguments for consistency with
5198 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5200 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5202 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5204 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5206 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5208 * dispnew.c (scrolling_window): Don't exclude the case that the
5209 last enabled row in the desired matrix touches the bottom boundary.
5211 2011-05-21 Glenn Morris <rgm@gnu.org>
5213 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5214 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5215 and add some more files.
5217 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5219 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5220 report_file_error introduced by the change from 2011-05-07.
5222 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5224 * systime.h (Time): Define only if emacs is defined.
5225 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5226 where the include path doesn't have X11/X.h by default. See
5227 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5229 2011-05-20 Kenichi Handa <handa@m17n.org>
5231 * composite.c (find_automatic_composition): Fix previous change.
5233 2011-05-20 Glenn Morris <rgm@gnu.org>
5235 * lisp.mk: New file, split from Makefile.in.
5236 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5237 (shortlisp): Remove.
5238 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5240 2011-05-19 Glenn Morris <rgm@gnu.org>
5242 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5243 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5244 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5245 (lisp): Set the order to that of loadup.el.
5246 (shortlisp): Make it a copy of $lisp.
5247 (SOME_MACHINE_LISP): Remove.
5248 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5249 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5251 2011-05-18 Kenichi Handa <handa@m17n.org>
5253 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5254 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5255 (find_automatic_composition): Mostly rewrite for efficiency.
5257 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5259 * makefile.w32-in: Update dependencies.
5261 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5263 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5264 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5266 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5268 Fix some integer overflow issues, such as string length overflow.
5270 * insdel.c (count_size_as_multibyte): Check for string overflow.
5272 * character.c (lisp_string_width): Check for string overflow.
5273 Use EMACS_INT, not int, for string indexes and lengths; in
5274 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5275 the resulting string length overflows an EMACS_INT; instead,
5276 report a string overflow if no precision given. When checking for
5277 precision exhaustion, use a check that cannot possibly have
5278 integer overflow. (Bug#8675)
5279 * character.h (lisp_string_width): Adjust to new signature.
5281 * alloc.c (string_overflow): New function.
5282 (Fmake_string): Use it. This doesn't change behavior, but saves
5283 a few bytes and will simplify future changes.
5284 * character.c (string_escape_byte8): Likewise.
5285 * lisp.h (string_overflow): New decl.
5287 Fixups, following up to the user-interface timestamp change.
5288 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5289 for UI timestamps, instead of unsigned long.
5290 * msdos.c (mouse_get_pos): Likewise.
5291 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5292 * w32gui.h (Time): Define by including "systime.h" rather than by
5293 declaring it ourselves. (Bug#8664)
5295 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5296 * image.c (clear_image_cache): Likewise.
5298 * term.c (term_mouse_position): Don't assume time_t wraparound.
5300 Be more systematic about user-interface timestamps.
5301 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5302 and sometimes 'EMACS_UINT', to represent these timestamps.
5303 This change causes it to use 'Time' uniformly, as that's what X uses.
5304 This makes the code easier to follow, and makes it easier to catch
5305 integer overflow bugs such as Bug#8664.
5306 * frame.c (Fmouse_position, Fmouse_pixel_position):
5307 Use Time, not unsigned long, for user-interface timestamps.
5308 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5309 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5310 * keyboard.h (last_event_timestamp): Likewise.
5311 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5312 * menu.h (xmenu_show): Likewise.
5313 * term.c (term_mouse_position): Likewise.
5314 * termhooks.h (struct input_event.timestamp): Likewise.
5315 (struct terminal.mouse_position_hook): Likewise.
5316 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5317 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5318 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5319 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5321 * menu.h, termhooks.h: Include "systime.h", for Time.
5323 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5324 Don't assume that the difference between two unsigned long values
5325 can fit into an integer. At this point, we know button_down_time
5326 <= event->timestamp, so the difference must be nonnegative, so
5327 there's no need to cast the result if double-click-time is
5328 nonnegative, as it should be; check that it's nonnegative, just in
5329 case. This bug is triggered when events are more than 2**31 ms
5330 apart (about 25 days). (Bug#8664)
5332 * xselect.c (last_event_timestamp): Remove duplicate decl.
5333 (x_own_selection): Remove needless cast to unsigned long.
5335 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5336 that always fit in int. Use a sentinel instead of a counter, to
5337 avoid a temp and to allay GCC's concerns about possible int overflow.
5338 * frame.h (struct frame): Use int for menu_bar_items_used
5339 instead of EMACS_INT, since it always fits in int.
5341 * menu.c (grow_menu_items): Check for int overflow.
5343 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5345 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5346 Before, the code was not consistent. These values cannot exceed
5347 2**31 - 1 so there's no need to make them unsigned.
5348 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5349 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5350 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5352 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5354 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5355 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5356 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5357 presumably because the widths might not match.
5359 * window.c (size_window): Avoid needless test at loop start.
5361 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5363 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5365 2011-05-12 Drew Adams <drew.adams@oracle.com>
5367 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5369 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5371 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5372 `width' to `bar_area_x' and `bar_area_width', respectively.
5373 (x_scroll_run): Take account of fringe background extension.
5375 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5376 Rename local vars `left' and `width' to `bar_area_x' and
5377 `bar_area_width', respectively.
5378 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5379 background extension.
5381 2011-05-10 Jim Meyering <meyering@redhat.com>
5383 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5385 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5387 * image.c (Finit_image_library): Return t for built-in image types,
5388 like pbm and xbm. (Bug#8640)
5390 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5392 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5394 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5396 * w32console.c (Fset_screen_color): Doc fix.
5397 (Fget_screen_color): New function.
5398 (syms_of_ntterm): Defsubr it.
5400 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5401 unlink the temporary file if Fcall_process didn't create it in the
5403 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5404 child process will be redirected to a file specified with `:file'.
5405 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5406 cue to call_process_cleanup not to close that handle.
5408 2011-05-07 Ben Key <bkey76@gmail.com>
5410 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5411 one of two shell specific rules, either bootstrap-temacs-CMD or
5412 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5413 to the previous implementation of the bootstrap-temacs rule.
5414 The bootstrap-temacs-CMD rule is similar to the previous
5415 implementation of the bootstrap-temacs rule except that it
5416 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5419 These changes, along with some changes to nt/configure.bat,
5420 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5421 earlier fix to add support for --cflags and --ldflags options
5422 that include quotes so that it works whether make uses cmd or
5425 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5427 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5428 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5430 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5431 a string. Handle both cases.
5432 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5433 (Fdbus_register_method): Use Qinvalid_function.
5435 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5437 * makefile.w32-in: Update dependencies.
5438 (LISP_H): Add inttypes.h and stdin.h.
5439 (PROCESS_H): Add unistd.h.
5441 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5443 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5444 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5446 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5448 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5450 * term.c (vfatal): Remove stray call to va_end.
5451 It's not needed and the C Standard doesn't allow it here anyway.
5453 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5454 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5456 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5459 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5461 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5463 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5465 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5467 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5469 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5470 * charset.c (Fdefine_charset_internal): Don't initialize
5471 charset.code_space[15]. The value was garbage, on hosts with
5472 32-bit int (Bug#8600).
5474 * lread.c (read_integer): Be more consistent with string-to-number.
5475 Use string_to_number to do the actual conversion; this avoids
5476 rounding errors and fixes some other screwups. Without this fix,
5477 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5478 (digit_to_number): Move earlier, for benefit of read_integer.
5479 Return -1 if the digit is out of range for the base, -2 if it is
5480 not a digit in any supported base. (Bug#8602)
5482 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5484 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5485 to match comment at start of function. This also removes a
5486 GCC warning about overflow in a 32+64-bit port.
5488 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5490 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5491 Reported by Stefan Monnier in
5492 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5493 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5494 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5496 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5497 (EMACS_UINTPTR): Likewise, with uintptr_t.
5499 * lisp.h: Prefer 64-bit EMACS_INT if available.
5500 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5501 on 32-bit hosts that have 64-bit int, so that they can access
5503 However, temporarily disable this change unless the temporary
5504 symbol WIDE_EMACS_INT is defined.
5506 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5508 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5509 This removes an assumption that EMACS_INT and long are the same
5510 width as pointers. The assumption is true for Emacs porting targets
5511 now, but we want to make other targets possible.
5512 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5513 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5514 In the rest of the code, change types of integers that hold casted
5515 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5516 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5517 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5518 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5519 No need to cast type when ORing.
5520 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5521 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5522 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5523 assume EMACS_INT is the same width as char *.
5524 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5525 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5526 Remove no-longer-needed casts.
5527 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5528 (xg_tool_bar_help_callback, xg_make_tool_item):
5529 Use EMACS_INTPTR to hold an integer
5530 that will be cast to void *; this can avoid a GCC warning
5531 if EMACS_INT is not the same width as void *.
5532 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5533 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5534 (current_message_1, set_message_1):
5535 Use a local to convert to proper width without a cast.
5536 * xmenu.c (dialog_selection_callback): Likewise.
5538 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5539 Also, don't assume VALBITS / RAND_BITS is less than 5,
5540 and don't rely on undefined behavior when shifting a 1 left into
5542 * lisp.h (get_random): Change signature to match.
5544 * lread.c (hash_string): Use size_t, not int, for hash computation.
5545 Normally we prefer signed values; but hashing is special, because
5546 it's better to use unsigned division on hash table sizes so that
5547 the remainder is nonnegative. Also, size_t is the natural width
5548 for hashing into memory. The previous code used 'int', which doesn't
5549 retain enough info to hash well into very large tables.
5550 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5552 * dbusbind.c: Don't possibly lose pointer info when converting.
5553 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5554 Use XPNTR rather than XHASH, so that the high-order bits of
5555 the pointer aren't lost when converting through void *.
5557 * eval.c (Fautoload): Don't double-shift a pointer.
5559 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5561 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5563 * gnutls.c (DEF_GNUTLS_FN):
5564 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5566 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5568 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5571 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5573 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5574 New version that can reserve upto 2GB of heap space.
5576 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5578 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5580 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5582 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5583 `gnutls_certificate_set_x509_key_file'.
5585 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5587 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5588 Update dependencies.
5590 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5592 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5593 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5594 Remove unused parameter `fildes'.
5595 * process.c (read_process_output, send_process): Don't pass it.
5597 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5599 Fix previous change: the library cache is defined in w32.c.
5600 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5601 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5603 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5605 Implement dynamic loading of GnuTLS on Windows.
5607 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5608 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5609 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5612 * gnutls.c (Qgnutls_dll): Define.
5613 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5614 (gnutls_*): Declare function pointers.
5615 (init_gnutls_functions): New function to initialize function pointers.
5616 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5617 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5618 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5619 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5620 (emacs_gnutls_write, emacs_gnutls_read)
5621 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5622 (Fgnutls_available_p): New function.
5623 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5624 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5625 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5627 * image.c: Include w32.h.
5628 (Vimage_type_cache): Delete.
5629 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5630 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5631 (w32_delayed_load): Move to w32.c.
5633 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5635 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5636 (w32_delayed_load): Move from image.c. When loading a library, record
5637 its filename in the :loaded-from property of the library id.
5638 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5639 Initialize and staticpro them.
5640 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5642 * process.c: Include lisp.h before w32.h, not after.
5643 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5644 instead of gnutls_record_check_pending.
5646 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5648 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5650 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5651 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5654 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5656 * xterm.c (x_set_frame_alpha): Do not set property on anything
5657 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5659 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5661 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5663 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5665 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5666 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5667 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5668 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5669 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5670 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5671 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5672 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5673 (Qgnutls_bootprop_callbacks_verify): Make static.
5675 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5677 * callproc.c: Indentation fixup.
5679 * sysdep.c (wait_for_termination_1): Make static.
5680 (wait_for_termination, interruptible_wait_for_termination):
5681 Move after wait_for_termination_1.
5683 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5685 * sysdep.c (interruptible_wait_for_termination): New function
5686 which is like wait_for_termination, but allows keyboard
5689 * callproc.c (Fcall_process): Add (:file "file") as an option for
5691 (Fcall_process_region): Ditto.
5693 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5695 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5696 rather than `XVECTOR (FOO)->size'.
5698 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5699 inttypes.h, as a gnulib replacement is used if it not available in
5702 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5704 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5705 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5706 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5708 * coding.c (coding_alloc_by_realloc): Error out if destination
5709 will grow beyond MOST_POSITIVE_FIXNUM.
5710 (decode_coding_emacs_mule): Abort if there isn't enough place in
5711 charbuf for the composition carryover bytes. Reserve an extra
5712 space for up to 2 characters produced in a loop.
5713 (decode_coding_iso_2022): Abort if there isn't enough place in
5714 charbuf for the composition carryover bytes.
5716 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5718 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5719 aborting when %lld or %lll format is passed.
5720 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5721 %llo or %llx format is passed. (Bug#8545)
5723 * window.c (window_scroll_line_based): Use a marker instead of
5724 simple variables to record original value of point. (Bug#7952)
5726 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5727 produced by %s or %c overflows available buffer space. (Bug#8545)
5729 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5731 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5732 (SIZE_MAX): Move defn after all includes, as they might #define it.
5734 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5736 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5738 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5740 * keyboard.c (Qdelayed_warnings_hook): Define.
5741 (command_loop_1): Run `delayed-warnings-hook'
5742 if Vdelayed_warnings_list is non-nil.
5743 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5744 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5746 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5748 * doprnt.c (doprnt): Don't return value smaller than the buffer
5749 size if the message was truncated. (Bug#8545).
5751 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5753 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5754 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5756 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5758 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5760 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5762 * makefile.w32-in: Update dependencies.
5764 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5766 Improve `doprnt' and its usage. (Bug#8545)
5767 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5768 `format_end'. Remove support for %l as a conversion specifier.
5769 Don't use xrealloc. Improve diagnostics when the %l size modifier
5770 is used. Update the commentary.
5772 * eval.c (verror): Simplify calculation of size_t.
5774 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5777 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5779 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5782 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5784 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5785 This makes this file independent of the recent pseudovector change.
5787 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5789 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5791 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5792 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5793 Remove unused local.
5794 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5796 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5797 GCC 4.6.0 optimizes based on type-based alias analysis.
5798 For example, if b is of type struct buffer * and v of type struct
5799 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5800 != &v->size, and therefore "v->size = 1; b->size = 2; return
5801 v->size;" must therefore return 1. This assumption is incorrect
5802 for Emacs, since it type-puns struct Lisp_Vector * with many other
5803 types. To fix this problem, this patch adds a new type struct
5804 vectorlike_header that documents the constraints on layout of vectors
5805 and pseudovectors, and helps optimizing compilers not get fooled
5806 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5807 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5808 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5810 (XSETPVECTYPE): Rewrite in terms of new macro.
5811 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5812 This is a bit clearer, and further avoids the possibility of
5813 undesirable aliasing.
5814 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5815 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5816 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5817 since Lisp_Subr is a special case (no "next" field).
5818 (ASIZE): Now uses header.size rather than size.
5819 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5820 to avoid the hassle of writing XVECTOR (foo)->header.size.
5821 (struct vectorlike_header): New type.
5822 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5823 object, to help avoid aliasing.
5824 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5825 (SUBRP): Likewise, since Lisp_Subr is a special case.
5826 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5827 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5828 (struct Lisp_Hash_Table): Combine first two members into a single
5829 struct vectorlike_header member. All uses of "size" and "next" members
5830 changed to be "header.size" and "header.next".
5831 * buffer.h (struct buffer): Likewise.
5832 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5833 * frame.h (struct frame): Likewise.
5834 * process.h (struct Lisp_Process): Likewise.
5835 * termhooks.h (struct terminal): Likewise.
5836 * window.c (struct save_window_data, struct saved_window): Likewise.
5837 * window.h (struct window): Likewise.
5838 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5839 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5840 * buffer.c (init_buffer_once): Likewise.
5841 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5843 * process.c (Fformat_network_address): Use local var for size,
5846 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5848 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5849 * data.c (atof): Remove decl; no longer used or needed.
5850 (digit_to_number): Move to lread.c.
5851 (Fstring_to_number): Use new string_to_number function, to be
5852 consistent with how the Lisp reader treats infinities and NaNs.
5853 Do not assume that floating-point numbers represent EMACS_INT
5854 without losing information; this is not true on most 64-bit hosts.
5855 Avoid double-rounding errors, by insisting on integers when
5856 parsing non-base-10 numbers, as the documentation specifies.
5857 * lisp.h (string_to_number): New decl, replacing ...
5858 (isfloat_string): Remove.
5859 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5860 (read1): Do not accept +. and -. as integers; this
5861 appears to have been a coding error. Similarly, do not accept
5862 strings like +-1e0 as floating point numbers. Do not report
5863 overflow for integer overflows unless the base is not 10 which
5864 means we have no simple and reliable way to continue.
5865 Break out the floating-point parsing into a new
5866 function string_to_number, so that Fstring_to_number parses
5867 floating point numbers consistently with the Lisp reader.
5868 (digit_to_number): Move here from data.c. Make it static inline.
5869 (E_CHAR, EXP_INT): Remove, replacing with ...
5870 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5871 (string_to_number): New function, replacing isfloat_string.
5872 This function checks for valid syntax and produces the resulting
5873 Lisp float number too. Rework it so that string-to-number
5874 no longer mishandles examples like "1.0e+". Use strtoumax,
5875 so that overflow for non-base-10 numbers is reported only when
5876 there's no portable and simple way to convert to floating point.
5878 * textprop.c (set_text_properties_1): Rewrite for clarity,
5879 and to avoid GCC warning about integer overflow.
5881 * intervals.h (struct interval): Use EMACS_INT for members
5882 where EMACS_UINT might cause problems. See
5883 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5884 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5885 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5887 (offset_intervals): Tell GCC not to worry about length overflow
5888 when negating a negative length.
5890 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5891 (overrun_check_free): Likewise.
5893 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5894 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5897 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5898 (gnutls_make_error): Rename local to avoid shadowing.
5899 (gnutls_emacs_global_deinit): ifdef out; not used.
5900 (Fgnutls_boot): Use const for pointer to readonly storage.
5901 Comment out unused local. Fix pointer signedness problems.
5903 * lread.c (openp): Don't stuff size_t into an 'int'.
5904 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5905 about possible signed overflow.
5907 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5908 (GDK_KEY_g): Don't define if already defined.
5909 (xg_prepare_tooltip): Avoid pointer signedness problem.
5910 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5912 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5913 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5915 * xfns.c (Fx_window_property): Simplify a bit,
5916 to make a bit faster and to avoid GCC 4.6.0 warning.
5917 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5919 * fns.c (internal_equal): Don't assume size_t fits in int.
5921 * alloc.c (compact_small_strings): Tighten assertion a little.
5923 Replace pEd with more-general pI, and fix some printf arg casts.
5924 * lisp.h (pI): New macro, generalizing old pEd macro to other
5925 conversion specifiers. For example, use "...%"pI"d..." rather
5926 than "...%"pEd"...".
5927 (pEd): Remove. All uses replaced with similar uses of pI.
5928 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5929 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5930 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5931 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5932 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5933 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5934 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5936 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5937 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5938 * print.c (safe_debug_print, print_object): Likewise.
5939 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5941 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5942 avoiding the 0 flag, which is not portable.
5943 * process.c (Fmake_network_process): Use pI to avoid cast.
5944 * region-cache.c (pp_cache): Likewise.
5945 * xdisp.c (decode_mode_spec): Likewise.
5946 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5947 behavior on 64-bit hosts with printf arg.
5948 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5949 (x_stop_queuing_selection_requests): Likewise.
5950 (x_get_window_property): Don't truncate byte count to an 'int'
5953 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5954 here, since it parses constructs like leading '-' and spaces,
5955 which are not wanted; and it overflows with large numbers.
5956 Instead, simply match F[0-9]+, which is what is wanted anyway.
5958 * alloc.c: Remove unportable assumptions about struct layout.
5959 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5960 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5961 (allocate_vectorlike, make_pure_vector): Use the new macros,
5962 plus offsetof, to remove unportable assumptions about struct layout.
5963 These assumptions hold on all porting targets that I know of, but
5964 they are not guaranteed, they're easy to remove, and removing them
5965 makes further changes easier.
5967 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5968 This doesn't fix a bug but makes the code clearer.
5969 (string_overrun_cookie): Now const. Use initializers that
5970 don't formally overflow signed char, to avoid warnings.
5971 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5972 can cause Emacs to crash when string overrun checking is enabled.
5973 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5974 multiple of sizeof (EMACS_INT); it need not be, if
5975 alignof(EMACS_INT) < sizeof (EMACS_INT).
5976 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5978 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5980 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5982 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5984 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5985 supposed to be handshaking. (Bug#8556)
5986 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5988 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5990 * lisp.h (Qdebug): List symbol.
5991 * eval.c (Qdebug): Restore global linkage.
5992 * keyboard.c (debug-on-event): New variable.
5993 (handle_user_signal): Break into debugger when debug-on-event
5994 matches the current signal symbol.
5996 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5998 * alloc.c (check_sblock, check_string_bytes)
5999 (check_string_free_list): Convert to standard C.
6001 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6003 * w32.c (emacs_gnutls_push): Fix typo.
6005 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6007 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6008 "cast to pointer from integer of different size".
6010 Improve doprnt and its use in verror. (Bug#8545)
6011 * doprnt.c (doprnt): Document the set of format control sequences
6012 supported by the function. Use SAFE_ALLOCA instead of always
6015 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6016 is one byte too soon. Don't use xrealloc; instead xfree and
6019 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6021 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6024 * gnutls.c: Renamed global_initialized to
6025 gnutls_global_initialized. Added internals for the
6026 :verify-hostname-error, :verify-error, and :verify-flags
6027 parameters of `gnutls-boot' and documented those parameters in the
6028 docstring. Start callback support.
6029 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6030 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6031 on error. Return error code.
6032 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6033 (emacs_gnutls_read): Likewise.
6034 (Fgnutls_boot): Return handshake error code.
6035 (emacs_gnutls_handle_error): New function.
6036 (wsaerror_to_errno): Likewise.
6038 * w32.h (emacs_gnutls_pull): Add prototype.
6039 (emacs_gnutls_push): Likewise.
6041 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6042 (emacs_gnutls_push): Likewise.
6044 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6046 * process.c (wait_reading_process_output): Check if GnuTLS
6047 buffered some data internally if no FDs are set for TLS
6050 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6051 (LIBS): Link to USER_LIBS.
6052 ($(BLD)/gnutls.$(0)): New target.
6054 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6056 * xdisp.c (handle_single_display_spec): Rename the
6057 display_replaced_before_p argument into display_replaced_p, to
6058 make it consistent with the commentary. Fix typos in the
6061 * textprop.c (syms_of_textprop): Remove dead code.
6062 (copy_text_properties): Delete obsolete commentary about an
6063 interface that was deleted long ago. Fix typos in the description
6066 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6067 to changes in oldXMenu/XMenu.h from 2011-04-16.
6068 <menu_help_message, prev_menu_help_message>: Constify.
6069 (IT_menu_make_room): menu->help_text is now `const char **';
6072 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6073 to changes in oldXMenu/XMenu.h from 2011-04-16.
6074 (struct XMenu): Declare `help_text' `const char **'.
6076 * xfaces.c <Qunspecified>: Make extern again.
6078 * syntax.c: Include sys/types.h before including regex.h, as
6081 * doc.c (get_doc_string): Improve the format passed to `error'.
6083 * doprnt.c (doprnt): Improve commentary.
6085 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6087 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6090 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6091 changes in globals.h immediately force recompilation.
6092 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6093 $(CURDIR)/s/ms-w32.h.
6094 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6096 * character.c (Fchar_direction): Function deleted.
6097 (syms_of_character): Don't defsubr it.
6098 <char-direction-table>: Deleted.
6100 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6102 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6103 * doprnt.c: Include limits.h.
6104 (SIZE_MAX): New macro.
6105 (doprnt): Return a size_t value. 2nd arg is now size_t.
6106 Many local variables are now size_t instead of int or unsigned.
6107 Improve overflow protection. Support `l' modifier for integer
6108 conversions. Support %l conversion. Don't assume an EMACS_INT
6109 argument for integer conversions and for %c.
6111 * lisp.h (doprnt): Restore prototype.
6113 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6116 * Makefile.in (base_obj): Add back doprnt.o.
6118 * deps.mk (doprnt.o): Add back prerequisites.
6119 (callint.o): Depend on character.h.
6121 * eval.c (internal_lisp_condition_case): Include the handler
6122 representation in the error message.
6123 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6124 when breaking from the loop.
6126 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6128 * callint.c (Fcall_interactively): When displaying error message
6129 about invalid control letter, pass the character's codepoint, not
6130 a pointer to its multibyte form. Improve display of the character
6131 in octal and display also its hex code.
6133 * character.c (char_string): Use %x to display the (unsigned)
6134 codepoint of an invalid character, to avoid displaying a bogus
6137 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6138 `error', not SYMBOL_NAME itself.
6140 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6141 character arguments to `error'.
6143 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6144 to `error' in error message about FINAL_CHAR argument. Make sure
6145 FINAL_CHAR is a character, and use %c when it is passed as
6146 argument to `error'.
6148 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6150 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6152 * w32.c: Include <time.h>.
6153 (sys_localtime): New function.
6155 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6157 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6159 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6161 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6163 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6166 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6168 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6169 gl_state.e_property when gl_state.object is Qt.
6171 * insdel.c (make_gap_larger): Remove limitation of buffer size
6174 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6176 * xdisp.c (lookup_glyphless_char_display)
6177 (produce_glyphless_glyph): Handle cons cell entry in
6178 glyphless-char-display.
6179 (Vglyphless_char_display): Document it.
6181 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6182 glyphless-char-display.
6184 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6186 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6188 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6190 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6191 definition for no-X builds.
6193 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6195 Static checks with GCC 4.6.0 and non-default toolkits.
6197 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6199 * process.c (keyboard_bit_set): Define only if SIGIO.
6200 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6201 (send_process): Repair possible setjmp clobbering.
6203 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6205 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6207 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6209 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6210 Define only if needed.
6212 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6213 by pacifying GCC about it. Maybe it's time to retire it?
6214 * xfaces.c (USG, __TIMEVAL__): Likewise.
6216 * dispextern.h (struct redisplay_interface): Rename param
6218 * termhooks.h (struct terminal): Likewise.
6219 * xterm.c (xembed_send_message): Likewise.
6221 * insdel.c (make_gap_smaller): Define only if
6222 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6224 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6227 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6228 so that we aren't warned about unused symbols.
6230 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6232 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6234 * xfns.c (x_real_positions): Mark locals as initialized.
6236 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6238 * xterm.c: Fix problems found by static analysis with other toolkits.
6239 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6240 (x_dispatch_event): Declare static if USE_GTK, and
6241 define if USE_GTK || USE_X_TOOLKIT.
6242 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6243 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6244 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6245 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6247 * xmenu.c (menu_help_callback): Pointer type fixes.
6248 Use const pointers when pointing at readonly data. Avoid pointer
6250 (FALSE): Remove unused macro.
6251 (update_frame_menubar): Remove unused decl.
6253 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6255 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6256 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6257 (single_menu_item): Rename local to avoid shadowing.
6259 * keyboard.c (make_lispy_event): Remove unused local var.
6261 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6262 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6264 * bitmaps: Change bitmaps from unsigned char back to the X11
6265 compatible char. Avoid the old compiler warnings about
6266 out-of-range initializers by using, for example, '\xab' rather
6269 * xgselect.c (xgselect_initialize): Check vs interface
6270 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6272 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6274 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6275 to read-only memory.
6277 * fns.c (vector): Remove; this old hack is no longer needed.
6279 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6281 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6283 * xrdb.c (x_load_resources): Omit unused local.
6285 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6286 (x_window): Rename locals to avoid shadowing.
6287 (USG): Use the kludged USG macro, to pacify gcc.
6289 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6290 (x_term_init): Remove local to avoid shadowing.
6292 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6294 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6295 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6297 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6299 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6301 Fix regex.c, syntax.c and friends for buffers > 2GB.
6302 * syntax.h (struct gl_state_s): Declare character position members
6305 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6307 * textprop.c (verify_interval_modification, interval_of):
6308 Declare arguments EMACS_INT.
6310 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6313 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6315 * indent.c (Fvertical_motion): Local variable it_start is now
6318 * regex.c (re_match, re_match_2, re_match_2_internal)
6319 (bcmp_translate, regcomp, regexec, print_double_string)
6320 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6321 (re_compile_pattern, re_exec): Declare arguments and local
6322 variables `size_t' and `ssize_t' and return values `regoff_t', as
6324 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6325 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6326 <compile_stack_type>: `size' and `avail' are now `size_t'.
6328 * regex.h <regoff_t>: Use ssize_t, not int.
6329 (re_search, re_search_2, re_match, re_match_2): Arguments that
6330 specify buffer/string position and length are now ssize_t and
6331 size_t. Return type is regoff_t.
6333 2011-04-16 Ben Key <bkey76@gmail.com>
6335 * nsfont.m: Fixed bugs in ns_get_family and
6336 ns_descriptor_to_entity that were caused by using free to
6337 deallocate memory blocks that were allocated by xmalloc (via
6338 xstrdup). This caused Emacs to crash when compiled with
6339 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6340 --enable-checking=xmallocoverrun). xfree is now used to
6341 deallocate these memory blocks.
6343 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6345 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6347 emacs_write: Accept and return EMACS_INT for sizes.
6348 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6350 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6351 Accept and return EMACS_INT.
6352 (emacs_gnutls_write): Return the number of bytes written on
6354 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6355 (emacs_read, emacs_write): Remove check for negative size, as the
6356 Emacs source code has been audited now.
6357 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6358 (emacs_read, emacs_write): Use it.
6359 * process.c (send_process): Adjust to the new signatures of
6360 emacs_write and emacs_gnutls_write. Do not attempt to store
6361 a byte offset into an 'int'; it might overflow.
6362 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6364 * sound.c: Don't assume sizes fit in 'int'.
6365 (struct sound_device.period_size, alsa_period_size):
6366 Return EMACS_INT, not int.
6367 (struct sound_device.write, vox_write, alsa_write):
6368 Accept EMACS_INT, not int.
6369 (wav_play, au_play): Use EMACS_INT to store sizes and to
6370 record read return values.
6372 2011-04-15 Ben Key <bkey76@gmail.com>
6374 * keyboard.c (Qundefined): Don't declare static since it is used
6376 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6377 static since they are used in nsfont.m.
6379 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6381 * process.c (Qprocessp): Don't declare static.
6382 * lisp.h (Qprocessp): Declare again.
6384 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6386 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6388 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6390 Improve C-level modularity by making more things 'static'.
6392 Don't publish debugger-only interfaces to other modules.
6393 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6394 (verify_bytepos, count_markers): Move decls to the only modules
6396 * region-cache.h (pp_cache): Likewise.
6397 * window.h (check_all_windows): Likewise.
6398 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6400 * sysdep.c (croak): Now static, if
6401 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6402 * syssignal.h (croak): Declare only if not static.
6404 * alloc.c (refill_memory_reserve): Now static if
6405 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6406 * lisp.h (refill_memory_reserve): Declare only if not static.
6408 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6409 Define only if USE_LUCID.
6411 * xrdb.c (x_customization_string, x_rm_string): Now static.
6413 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6414 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6416 * xdisp.c (draw_row_with_mouse_face): Now static.
6417 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6419 * window.h (check_all_windows): Mark externally visible.
6421 * window.c (window_deletion_count): Now static.
6423 * undo.c: Make symbols static if they're not exported.
6424 (last_undo_buffer, last_boundary_position, pending_boundary):
6427 * textprop.c (interval_insert_behind_hooks): Now static.
6428 (interval_insert_in_front_hooks): Likewise.
6430 * term.c: Make symbols static if they're not exported.
6431 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6432 (max_frame_lines, tty_set_terminal_modes):
6433 (tty_reset_terminal_modes, tty_turn_off_highlight):
6434 (get_tty_terminal): Now static.
6435 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6436 * termhooks.h (term_mouse_moveto): Do not declare if
6438 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6439 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6441 * sysdep.c: Make symbols static if they're not exported.
6442 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6444 (sigprocmask_set, full_mask): Remove; unused.
6445 (wait_debugging): Mark as visible.
6446 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6447 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6449 * syntax.c (syntax_temp): Define only if !__GNUC__.
6451 * sound.c (current_sound_device, current_sound): Now static.
6453 * search.c (searchbufs, searchbuf_head): Now static.
6455 * scroll.c (scroll_cost): Remove; unused.
6456 * dispextern.h (scroll_cost): Remove decl.
6458 * region-cache.h (pp_cache): Mark as externally visible.
6460 * process.c: Make symbols static if they're not exported.
6461 (process_tick, update_tick, create_process, chan_process):
6462 (Vprocess_alist, proc_buffered_char, datagram_access):
6463 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6464 (deactivate_process): Mark defn as static, as well as decl.
6465 * lisp.h (create_process): Remove decl.
6466 * process.h (chan_process, Vprocess_alist): Remove decls.
6468 * print.c: Make symbols static if they're not exported.
6469 (print_depth, new_backquote_output, being_printed, print_buffer):
6470 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6471 (print_interval, print_number_index, initial_stderr_stream):
6473 * lisp.h (Fprinc): Remove decl.
6474 (debug_output_compilation_hack): Mark as externally visible.
6476 * sysdep.c (croak): Move decl from here to syssignal.h.
6477 * syssignal.h (croak): Put it here, so the API can be checked when
6478 'croak' is called from dissociate_if_controlling_tty.
6480 * minibuf.c: Make symbols static if they're not exported.
6481 (minibuf_save_list, choose_minibuf_frame): Now static.
6482 * lisp.h (choose_minibuf_frame): Remove decl.
6484 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6486 * lread.c: Make symbols static if they're not exported.
6487 (read_objects, initial_obarray, oblookup_last_bucket_number):
6489 (make_symbol): Remove; unused.
6490 * lisp.h (initial_obarray, make_symbol): Remove decls.
6492 * keyboard.c: Make symbols static if they're not exported.
6493 (single_kboard, recent_keys_index, total_keys, recent_keys):
6494 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6495 (this_single_command_key_start, echoing, last_auto_save):
6496 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6497 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6498 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6499 (Vlispy_mouse_stem, double_click_count):
6501 (force_auto_save_soon): Define only if SIGDANGER.
6502 (ignore_mouse_drag_p): Now static if
6503 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6504 (print_help): Remove; unused.
6505 (stop_character, last_timer_event): Mark as externally visible.
6506 * keyboard.h (ignore_mouse_drag_p): Declare only if
6507 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6508 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6509 * lisp.h (echoing): Remove decl.
6510 (force_auto_save_soon): Declare only if SIGDANGER.
6511 * xdisp.c (redisplay_window): Simplify code, to make it more
6512 obvious that ignore_mouse_drag_p is not accessed if !defined
6513 USE_GTK && !defined HAVE_NS.
6515 * intervals.c: Make symbols static if they're not exported.
6516 (merge_properties_sticky, merge_interval_right, delete_interval):
6518 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6520 * insdel.c: Make symbols static if they're not exported.
6521 However, leave prepare_to_modify_buffer alone. It's never
6522 called from outside this function, but that appears to be a bug.
6523 (combine_after_change_list, combine_after_change_buffer):
6524 (adjust_after_replace, signal_before_change): Now static.
6525 (adjust_after_replace_noundo): Remove; unused.
6526 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6527 (signal_before_change): Remove decls.
6529 * indent.c (val_compute_motion, val_vmotion): Now static.
6531 * image.c: Make symbols static if they're not exported.
6532 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6534 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6535 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6537 * fringe.c (standard_bitmaps): Now static.
6538 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6540 * frame.c: Make symbols static if they're not exported.
6541 (x_report_frame_params, make_terminal_frame): Now static.
6542 (get_frame_param): Now static, unless HAVE_NS.
6543 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6544 (x_get_resource_string): Remove; not used.
6545 * frame.h (make_terminal_frame, x_report_frame_params):
6546 (x_get_resource_string); Remove decls.
6547 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6548 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6550 * font.c, fontset.c: Make symbols static if they're not exported.
6551 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6552 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6553 * font.c (font_close_object): Now static.
6554 * font.h (font_close_object): Remove.
6555 * fontset.c (FONTSET_OBJLIST): Remove.
6556 (free_realized_fontset) #if-0 the body, which does nothing.
6557 (face_suitable_for_char_p): #if-0, as it's never called.
6558 * fontset.h (face_suitable_for_char_p): Remove decl.
6559 * xfaces.c (face_at_string_position):
6560 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6561 since 0 is always ASCII.
6563 * fns.c (weak_hash_tables): Now static.
6565 * fileio.c: Make symbols static if they're not exported.
6566 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6567 (Vwrite_region_annotation_buffers): Now static.
6569 * eval.c: Make symbols static if they're not exported.
6570 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6571 * lisp.h (backtrace_list): Remove decl.
6573 * emacs.c: Make symbols static if they're not exported.
6574 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6575 (fatal_error_code, fatal_error_signal_hook, standard_args):
6577 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6578 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6579 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6580 * lisp.h (fatal_error_signal_hook): Remove decl.
6581 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6583 * editfns.c: Move a (normally-unused) function to its only use.
6584 * editfns.c, lisp.h (get_operating_system_release): Remove.
6585 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6586 worth the hassle of breaking this out.
6588 * xterm.c: Make symbols static if they're not exported.
6589 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6590 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6591 (x_destroy_window, x_delete_display):
6593 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6594 (x_mouse_leave): Remove; unused.
6595 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6596 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6597 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6599 (x_mouse_leave): Declare only if WINDOWSNT.
6600 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6601 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6604 * ftxfont.c: Make symbols static if they're not exported.
6605 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6607 * font.h (ftxfont_driver): Likewise.
6609 * xfns.c: Make symbols static if they're not exported.
6610 (x_last_font_name, x_display_info_for_name):
6611 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6612 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6613 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6614 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6615 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6616 (last_show_tip_args): Now static.
6617 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6618 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6619 (x_screen_planes): Remove; unused.
6620 * dispextern.h (x_screen_planes): Remove decl.
6622 * dispnew.c: Make symbols static if they're not exported.
6623 * dispextern.h (redraw_garbaged_frames, scrolling):
6624 (increment_row_positions): Remove.
6625 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6626 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6628 (redraw_garbaged_frames): Remove; unused.
6630 * xfaces.c: Make symbols static if they're not exported.
6631 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6633 * xterm.h (defined_color): Remove decls.
6634 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6635 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6636 (menu_face_changed_default, defined_color, free_realized_face):
6637 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6638 (ascii_face_of_lisp_face): Remove; unused.
6640 * xdisp.c: Make symbols static if they're not exported.
6641 * dispextern.h (scratch_glyph_row, window_box_edges):
6642 (glyph_to_pixel_coords, set_cursor_from_row):
6643 (get_next_display_element, set_iterator_to_next):
6644 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6645 (show_mouse_face): Remove decls
6646 * frame.h (message_buf_print): Likewise.
6647 * lisp.h (pop_message, set_message, check_point_in_composition):
6649 * xterm.h (set_vertical_scroll_bar): Likewise.
6650 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6651 (message_buf_print, scratch_glyph_row, displayed_buffer):
6652 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6653 (get_next_display_element, show_mouse_face, window_box_edges):
6654 (frame_to_window_pixel_xy, check_point_in_composition):
6655 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6656 (glyph_to_pixel_coords): Remove; unused.
6658 * dired.c (file_name_completion): Now static.
6660 * dbusbind.c (xd_in_read_queued_messages): Now static.
6662 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6663 * data.c (circular_list_error): Remove.
6665 * commands.h (last_point_position, last_point_position_buffer):
6666 (last_point_position_window): Remove decls.
6667 * keyboard.c: Make these variables static.
6669 * coding.h (coding, code_convert_region, encode_coding_gap):
6671 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6672 (iso_code_class, detect_coding, code_convert_region): Now static.
6673 (encode_coding_gap): Remove; unused.
6675 * chartab.c (chartab_chars, chartab_bits): Now static.
6677 * charset.h (charset_iso_8859_1): Remove decl.
6678 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6681 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6682 * ccl.c (Vccl_program_table): Now static.
6683 (check_ccl_update): Remove; unused.
6685 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6686 * category.h: ... from here.
6687 * category.c (check_category_table, set_category_set): Now static.
6689 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6690 * lisp.h: Remove these decls.
6692 * buffer.c (buffer_count): Remove unused var.
6694 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6695 so that it's not optimized away.
6696 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6697 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6698 exported only to the debugger.
6700 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6701 * atimer.h (run_all_atimers): Remove; not exported.
6703 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6704 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6705 was inaccessible from Lisp.
6706 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6707 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6709 alloc.c: Import and export fewer symbols, and remove unused items.
6710 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6712 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6713 it's not optimized away by whole-program optimization.
6714 (message_enable_multibyte, free_misc): Remove.
6715 (catchlist, handlerlist, mark_backtrace):
6716 Declare only if BYTE_MARK_STACK.
6717 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6718 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6719 (message_enable_multibyte): Remove decl.
6720 (free_misc, interval_free_list, float_block, float_block_index):
6721 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6722 (cons_free_list, last_marked_index):
6724 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6725 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6726 (mark_backtrace): Define only if BYTE_MARK_STACK.
6727 * xdisp.c (message_enable_multibyte): Now static.
6729 Declare Lisp_Object Q* variables to be 'static' if not exported.
6730 This makes it easier for human readers (and static analyzers)
6731 to see whether these variables are used from other modules.
6732 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6733 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6734 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6735 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6736 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6737 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6738 * xmenu.c, xselect.c:
6739 Declare Q* vars static if they are not used in other modules.
6740 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6741 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6742 Remove decls of unexported vars.
6743 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6745 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6747 Make Emacs functions such as Fatom 'static' by default.
6748 This makes it easier for human readers (and static analyzers)
6749 to see whether these functions can be called from other modules.
6750 DEFUN now defines a static function. To make the function external
6751 so that it can be used in other C modules, use the new macro DEFUE.
6752 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6753 (Finit_image_library):
6754 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6755 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6756 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6757 Remove decls, since these functions are now static.
6758 (Funintern, Fget_internal_run_time): New decls, since these functions
6759 were already external.
6761 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6762 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6763 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6764 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6765 * keyboard.c, keymap.c, lread.c:
6766 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6767 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6768 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6769 Mark functions with DEFUE instead of DEFUN,
6770 if they are used in other modules.
6771 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6772 decls for now-static functions.
6773 * buffer.h (Fdelete_overlay): Remove decl.
6774 * callproc.c (Fgetenv_internal): Mark as internal.
6775 * composite.c (Fremove_list_of_text_properties): Remove decl.
6776 (Fcomposition_get_gstring): New forward static decl.
6777 * composite.h (Fcomposite_get_gstring): Remove decl.
6778 * dired.c (Ffile_attributes): New forward static decl.
6779 * doc.c (Fdocumntation_property): New forward static decl.
6780 * eval.c (Ffetch_bytecode): New forward static decl.
6781 (Funintern): Remove extern decl; now in .h file where it belongs.
6782 * fileio.c (Fmake_symbolic_link): New forward static decl.
6783 * image.c (Finit_image_library): New forward static decl.
6784 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6785 * intervals.h (Fprevious_property_change):
6786 (Fremove_list_of_text_properties): Remove decls.
6787 * keyboard.c (Fthis_command_keys): Remove decl.
6788 (Fcommand_execute): New forward static decl.
6789 * keymap.c (Flookup_key): New forward static decl.
6790 (Fcopy_keymap): Now static.
6791 * keymap.h (Flookup_key): Remove decl.
6792 * process.c (Fget_process): New forward static decl.
6793 (Fprocess_datagram_address): Mark as internal.
6794 * syntax.c (Fsyntax_table_p): New forward static decl.
6795 (skip_chars): Remove duplicate decl.
6796 * textprop.c (Fprevious_property_change): New forward static decl.
6797 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6799 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6800 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6802 * editfns.c (Fformat): Remove unreachable code.
6804 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6806 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6809 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6811 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6812 when at ZV. (Bug#8487)
6814 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6816 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6818 * keyboard.c (parse_tool_bar_item): Likewise.
6819 * sound.c (sound_cleanup, alsa_close): Likewise.
6820 * termcap.c (tgetent): Likewise.
6821 * xfns.c (x_default_font_parameter): Likewise.
6822 * xsettings.c (read_and_apply_settings): Likewise.
6824 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6825 (overrun_check_free): Protoize.
6827 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6829 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6830 since callers should never pass a negative size.
6831 Change the signature to match that of plain 'read' and 'write'; see
6832 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6833 * lisp.h: Update prototypes of emacs_write and emacs_read.
6835 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6837 * xdisp.c (redisplay_window): Don't try to determine the character
6838 position of the scroll margin if the window start point w->startp
6839 is outside the buffer's accessible region. (Bug#8468)
6841 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6843 Fix write-region and its subroutines for buffers > 2GB.
6844 * fileio.c (a_write, e_write): Modify declaration of arguments and
6845 local variables to support buffers larger than 2GB.
6846 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6848 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6849 argument, local variables, and return value.
6851 * lisp.h: Update prototypes of emacs_write and emacs_read.
6853 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6855 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6857 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6859 Fix more problems found by GCC 4.6.0's static checks.
6861 * xdisp.c (vmessage): Use a better test for character truncation.
6863 * charset.c (load_charset_map): <, not <=, for optimization,
6864 and to avoid potential problems with integer overflow.
6865 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6866 * casetab.c (set_identity, shuffle): Likewise.
6867 * editfns.c (Fformat): Likewise.
6868 * syntax.c (skip_chars): Likewise.
6870 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6871 This also lets GCC 4.6.0 generate slightly better loop code.
6873 * callint.c (Fcall_interactively): <, not <=, for optimization.
6874 (Fcall_interactively): Count the number of arguments produced,
6875 not the number of arguments given. This is simpler and lets GCC
6876 4.6.0 generate slightly better code.
6878 * ftfont.c: Distingish more carefully between FcChar8 and char.
6879 The previous code passed unsigned char * to a functions like
6880 strlen and xstrcasecmp that expect char *, which does not
6881 conform to the C standard.
6882 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6883 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6884 char * when the C standard requires it.
6886 * keyboard.c (read_char): Remove unused var.
6888 * eval.c: Port to Windows vsnprintf (Bug#8435).
6890 (SIZE_MAX): Define if the headers do not.
6891 (verror): Do not give up if vsnprintf returns a negative count.
6892 Instead, grow the buffer. This ports to Windows vsnprintf, which
6893 does not conform to C99. Problem reported by Eli Zaretskii.
6894 Also, simplify the allocation scheme, by avoiding the need for
6895 calling realloc, and removing the ALLOCATED variable.
6897 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6899 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6900 But keep the doprint source code for now, as we might revamp it
6901 and use it again (Bug#8435).
6902 * lisp.h (doprnt): Remove.
6903 * Makefile.in (base_obj): Remove doprnt.o.
6904 * deps.mk (doprnt.o): Remove.
6906 error: Print 32- and 64-bit integers portably (Bug#8435).
6907 Without this change, on typical 64-bit hosts error ("...%d...", N)
6908 was used to print both 32- and 64-bit integers N, which relied on
6910 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6912 * lisp.h (error, verror): Mark as printf-like functions.
6913 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6914 Report overflow in size calculations when allocating printf buffer.
6915 Do not truncate output string at its first null byte.
6916 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6917 Truncate the output at a character boundary, since vsnprintf does not
6919 * charset.c (check_iso_charset_parameter): Convert internal
6920 character to string before calling 'error', since %c now has the
6922 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6923 overflow when computing char to be passed to 'error'. Do not
6924 pass Lisp_Object to 'error'; pass the integer instead.
6925 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6926 formatted with plain %d.
6928 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6930 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6932 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6934 * xterm.c (x_catch_errors): Remove duplicate declaration.
6936 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6938 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6940 2011-04-10 Jim Meyering <meyering@redhat.com>
6942 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6943 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6944 return ssize_t not "int", and use size_t as the buffer length.
6945 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6946 * gnutls.h: Update declarations.
6947 * process.c (read_process_output): Use ssize_t, to match.
6948 (send_process): Likewise.
6950 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6952 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6954 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6956 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6957 Use unsigned char, to match FcChar8 type definition.
6959 * xterm.c (handle_one_xevent):
6960 * xmenu.c (create_and_show_popup_menu):
6961 * xselect.c (x_decline_selection_request)
6962 (x_reply_selection_request): Avoid type-punned deref of X events.
6964 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6966 Fix some uses of `int' instead of EMACS_INT.
6967 * search.c (string_match_1, fast_string_match)
6968 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6969 (scan_buffer, find_next_newline_no_quit)
6970 (find_before_next_newline, search_command, Freplace_match)
6971 (Fmatch_data): Make some `int' variables be EMACS_INT.
6973 * xdisp.c (display_count_lines): 3rd argument and return value now
6974 EMACS_INT. All callers changed.
6975 (pint2hrstr): Last argument is now EMACS_INT.
6977 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6978 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6979 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6980 (decode_coding_utf_16, decode_coding_emacs_mule)
6981 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6982 (decode_coding_ccl, decode_coding_charset)
6983 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6984 (decode_coding_iso_2022, decode_coding_emacs_mule)
6985 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6986 <char_offset, last_offset>: Declare EMACS_INT.
6987 (encode_coding_utf_8, encode_coding_utf_16)
6988 (encode_coding_emacs_mule, encode_invocation_designation)
6989 (encode_designation_at_bol, encode_coding_iso_2022)
6990 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6991 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6993 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6994 (encode_invocation_designation): Last argument P_NCHARS is now
6996 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6997 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6999 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7002 * ccl.c (Fccl_execute_on_string): Declare some variables
7005 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7007 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7009 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7011 * process.c (Fformat_network_address): Doc fix.
7013 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7015 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
7017 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7019 * keyboard.c (read_char): Call Lisp function help-form-show,
7020 instead of using internal_with_output_to_temp_buffer.
7021 (Qhelp_form_show): New var.
7022 (syms_of_keyboard): Use DEFSYM macro.
7024 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7026 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7028 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7030 * process.c (Flist_processes): Remove to Lisp.
7031 (list_processes_1): Delete.
7033 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7035 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7037 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7039 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7041 Fix more problems found by GCC 4.6.0's static checks.
7043 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7045 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7047 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7049 * xdisp.c (vmessage): Mark as a printf-like function.
7051 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7053 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7055 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7056 printf-like functions.
7057 (tiff_load): Add casts to remove these marks before passing them
7058 to system-supplied API.
7060 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7062 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7063 This avoids several warnings with gcc -Wstrict-overflow.
7064 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7065 directly, rather than having caller test rule sign. This avoids
7066 some unnecessary tests.
7067 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7068 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7069 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7071 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7072 (xfont_open): Avoid unnecessary tests.
7074 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7076 * composite.h, composite.c (composition_gstring_put_cache):
7077 Use EMACS_INT, not int, for length.
7079 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7080 breaking out part of COMPOSITION_DECODE_RULE.
7081 (COMPOSITION_DECODE_RULE): Use it.
7082 * composite.c (get_composition_id): Remove unused local vars,
7083 by using the new macro.
7085 * textprop.c (set_text_properties_1): Change while to do-while,
7086 since the condition is always true at first.
7088 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7089 (interval_deletion_adjustment): Return unsigned value.
7092 * process.c (list_processes_1, create_pty, read_process_output):
7093 (exec_sentinel): Remove vars that were set but not used.
7094 (create_pty): Remove unnecessary "volatile"s.
7095 (Fnetwork_interface_info): Avoid possibility of int overflow.
7096 (read_process_output): Do adaptive read buffering even if carryover.
7097 (read_process_output): Simplify nbytes computation if buffered.
7099 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7101 * syntax.c (scan_words): Remove var that was set but not used.
7102 (update_syntax_table): Use unsigned instead of int.
7104 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7105 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7106 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7108 * print.c (print_error_message): Avoid int overflow.
7110 * font.c (font_list_entities): Redo for clarity,
7111 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7113 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7114 (font_score): Avoid potential overflow in diff calculation.
7116 * fns.c (substring_both): Remove var that is set but not used.
7117 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7119 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7121 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7122 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7123 can always succeed if overflow has undefined behavior.
7125 * search.c (boyer_moore, wordify): Remove vars set but not used.
7126 (wordify): Omit three unnecessary tests.
7128 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7129 All callers changed. This avoids the need for an unused var.
7131 * casefiddle.c (casify_region): Remove var that is set but not used.
7133 * dired.c (file_name_completion): Remove var that is set but not used.
7135 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7137 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7138 (Finsert_file_contents): Remove unnecessary code checking fd.
7140 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7141 Check for integer overflow on size calculations.
7143 * buffer.c (Fprevious_overlay_change): Remove var that is set
7146 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7147 Remove vars that are set but not used.
7148 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7149 (timer_check_2): Mark vars as initialized.
7151 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7153 * image.c (lookup_image): Remove var that is set but not used.
7154 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7156 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7157 that are set but not used.
7159 * xfns.c (make_invisible_cursor): Don't return garbage
7160 if XCreateBitmapFromData fails (Bug#8410).
7162 * xselect.c (x_get_local_selection, x_handle_property_notify):
7163 Remove vars that are set but not used.
7165 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7166 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7168 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7169 Remove var that is set but not used.
7170 (scroll_bar_windows_size): Now size_t, not int.
7171 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7174 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7175 (map_tty_color) [!defined MSDOS]: Likewise.
7177 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7179 * coding.c: Remove vars that are set but not used.
7180 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7181 All callers changed.
7182 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7183 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7184 (decode_coding_charset): Remove vars that are set but not used.
7186 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7187 that is set but not used.
7189 * print.c (print_object): Remove var that is set but not used.
7191 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7192 The gnulib version avoids calling malloc in the usual case,
7193 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7194 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7195 * filelock.c (current_lock_owner): Likewise.
7196 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7197 * sysdep.c: Include allocator.h, careadlinkat.h.
7198 (emacs_no_realloc_allocator): New static constant.
7199 (emacs_readlink): New function.
7200 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7201 ../lib/careadlinkat.h.
7203 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7205 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7206 first non-nil return value).
7208 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7210 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7211 if not defined (Bug#8403).
7213 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7215 * xdisp.c (display_count_lines): Remove parameter `start',
7216 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7217 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7218 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7219 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7220 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7221 and thereabouts. All callers changed.
7222 (get_per_char_metric): Remove parameter `f', unused since
7223 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7225 2011-04-02 Jim Meyering <meyering@redhat.com>
7227 do not dereference NULL upon failed strdup
7228 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7229 (ns_get_family): Likewise.
7231 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7233 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7235 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7237 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7240 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7242 Add lexical binding.
7244 * window.c (Ftemp_output_buffer_show): New fun.
7245 (Fsave_window_excursion):
7246 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7248 * lread.c (lisp_file_lexically_bound_p): New function.
7249 (Fload): Bind Qlexical_binding.
7250 (readevalloop): Remove `evalfun' arg.
7251 Bind Qinternal_interpreter_environment.
7252 (Feval_buffer): Bind Qlexical_binding.
7253 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7255 (syms_of_lread): Declare `lexical-binding'.
7257 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7259 * keyboard.c (eval_dyn): New fun.
7260 (menu_item_eval_property): Use it.
7262 * image.c (parse_image_spec): Use Ffunctionp.
7264 * fns.c (concat, mapcar1): Accept byte-code-functions.
7266 * eval.c (Fsetq): Handle lexical vars.
7267 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7268 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7269 (FletX, Flet): Obey lexical binding.
7270 (Fcommandp): Handle closures.
7271 (Feval): New `lexical' arg.
7272 (eval_sub): New function extracted from Feval. Use it almost
7273 everywhere where Feval was used. Look up vars in lexical env.
7275 (Ffunctionp): Move from subr.el.
7276 (Ffuncall): Handle closures.
7277 (apply_lambda): Remove `eval_flags'.
7278 (funcall_lambda): Handle closures and new byte-code-functions.
7279 (Fspecial_variable_p): New function.
7280 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7281 but without exporting it to Lisp.
7283 * doc.c (Fdocumentation, store_function_docstring):
7284 * data.c (Finteractive_form): Handle closures.
7286 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7289 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7291 (exec_byte_code): New function extracted from Fbyte_code to handle new
7292 calling convention for byte-code-functions. Add new byte-codes.
7294 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7296 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7298 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7300 * xdisp.c (redisplay_internal): Fix prototype.
7302 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7304 * xdisp.c (SCROLL_LIMIT): New macro.
7305 (try_scrolling): Use it when setting scroll_limit.
7306 Limit scrolling to 100 screen lines.
7307 (redisplay_window): Even when falling back on "recentering",
7308 position point in the window according to scroll-conservatively,
7309 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7311 (try_scrolling): When point is above the window, allow searching
7312 as far as scroll_max, or one screenful, to compute vertical
7313 distance from PT to the scroll margin position. This prevents
7314 try_scrolling from unnecessarily failing when
7315 scroll-conservatively is set to a value slightly larger than the
7316 window height. Clean up the case of PT below the margin at bottom
7317 of window: scroll_max can no longer be INT_MAX. When aggressive
7318 scrolling is in use, don't let point enter the opposite scroll
7319 margin as result of the scroll.
7320 (syms_of_xdisp) <scroll-conservatively>: Document the
7321 threshold of 100 lines for never-recentering scrolling.
7323 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7325 * dispextern.h (move_it_by_lines):
7326 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7327 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7328 (message_log_check_duplicate): Remove parameters `prev_bol' and
7329 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7330 (redisplay_internal): Remove parameter `preserve_echo_area',
7331 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7333 * indent.c (Fvertical_motion):
7334 * window.c (window_scroll_pixel_based, Frecenter):
7335 Don't pass `need_y_p' to `move_it_by_lines'.
7337 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7339 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7340 steal a few bits to be more compact.
7341 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7342 Remove unneeded casts.
7344 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7346 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7348 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7349 binding" message (bug#7967).
7351 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7353 Fix more problems found by GCC 4.6.0's static checks.
7355 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7356 Remove unused local var.
7358 * editfns.c (Fmessage_box): Remove unused local var.
7360 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7361 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7362 Omit unused local vars.
7363 * window.c (shrink_windows): Omit unused local var.
7364 * menu.c (digest_single_submenu): Omit unused local var.
7365 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7366 Omit unused local var.
7368 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7369 Don't assume string length fits in int.
7370 (keyremap_step, read_key_sequence): Use size_t for sizes.
7371 (read_key_sequence): Don't check last_real_key_start redundantly.
7373 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7374 instead of alloca (Bug#8344).
7376 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7377 (Fbacktrace_frame): Don't assume nframes fits in int.
7379 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7381 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7384 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7386 * cm.c (calccost): Turn while-do into do-while, for clarity.
7388 * keyboard.c (syms_of_keyboard): Use the same style as later
7389 in this function when indexing through an array. This also
7390 works around GCC bug 48267.
7392 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7394 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7396 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7397 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7399 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7400 This avoids undefined behavior on integer overflow, and is a bit
7401 more convenient anyway since it is compared to a size_t variable.
7403 Variadic C functions now count arguments with size_t, not int.
7404 This avoids an unnecessary limitation on 64-bit machines, which
7405 caused (substring ...) to crash on large vectors (Bug#8344).
7406 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7407 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7408 All variadic functions and their callers changed accordingly.
7409 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7410 * data.c (arith_driver, float_arith_driver): Likewise.
7411 * editfns.c (general_insert_function): Likewise.
7412 * eval.c (struct backtrace.nargs, interactive_p)
7413 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7414 (funcall_lambda, mark_backtrace): Likewise.
7415 * fns.c (concat): Likewise.
7416 * frame.c (x_set_frame_parameters): Likewise.
7417 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7418 0 if not found, not -1. All callers changed.
7420 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7421 (stack_copy_size): Now size_t, not int.
7422 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7424 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7426 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7427 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7428 All callers changed.
7430 * lisp.h (multibyte_char_to_unibyte):
7431 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7432 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7433 * character.h (CHAR_TO_BYTE8):
7434 * cmds.c (internal_self_insert):
7435 * editfns.c (general_insert_function):
7436 * keymap.c (push_key_description):
7437 * search.c (Freplace_match):
7438 * xdisp.c (message_dolog, set_message_1): All callers changed.
7440 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7442 * keyboard.c (safe_run_hook_funcall): New function.
7443 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7444 don't set the hook to nil, but remove the offending function instead.
7445 (Qcommand_hook_internal): Remove, unused.
7446 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7447 Vcommand_hook_internal.
7449 * eval.c (enum run_hooks_condition): Remove.
7450 (funcall_nil, funcall_not): New functions.
7451 (run_hook_with_args): Call each function through a `funcall' argument.
7452 Remove `cond' argument, now redundant.
7453 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7454 (Frun_hook_with_args_until_failure): Adjust accordingly.
7455 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7457 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7459 * dispextern.h (string_buffer_position): Remove declaration.
7461 * print.c (strout): Remove parameter `multibyte', unused since
7462 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7464 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7465 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7466 All callers changed.
7468 * w32.c (_wsa_errlist): Use braces for struct initializers.
7470 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7471 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7472 All callers changed.
7473 (string_buffer_position): Likewise. Also, make static (it's never
7474 used outside xdisp.c).
7475 (cursor_row_p): Remove parameter `w', unused since
7476 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7477 (decode_mode_spec): Remove parameter `precision', introduced during
7478 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7479 All callers changed.
7481 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7483 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7485 2011-03-27 Anders Lindgren <andlind@gmail.com>
7487 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7488 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7489 (ns_update_auto_hide_menu_bar): New functions.
7490 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7491 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7492 ns_constrain_all_frames.
7493 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7494 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7496 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7498 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7500 2011-03-27 Glenn Morris <rgm@gnu.org>
7502 * syssignal.h: Replace RETSIGTYPE with void.
7503 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7504 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7505 Replace SIGTYPE with void everywhere.
7506 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7507 * s/template.h (SIGTYPE): Remove commented out definition.
7509 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7511 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7512 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7514 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7516 * w32.c (read_unc_volume): Use parameter `henum', instead of
7517 global variable `wget_enum_handle'.
7519 * keymap.c (describe_vector): Remove parameters `indices' and
7520 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7521 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7523 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7525 * keyboard.c (timer_check): Remove parameter `do_it_now',
7526 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7527 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7528 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7530 * keyboard.c (read_char):
7531 * w32menu.c (w32_menu_display_help):
7532 * xmenu.c (show_help_event, menu_help_callback):
7533 Adjust calls to `show_help_echo'.
7535 * gtkutil.c (xg_maybe_add_timer):
7536 * keyboard.c (readable_events):
7537 * process.c (wait_reading_process_output):
7538 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7540 * insdel.c (adjust_markers_gap_motion):
7541 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7542 (gap_left, gap_right): Don't call it.
7544 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7546 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7547 incurred during fontification.
7549 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7551 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7552 (DEFVAR_PER_BUFFER): Don't pass it.
7554 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7555 (scrolling_window): Don't pass it.
7557 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7559 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7561 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7563 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7564 of variables specific to SELinux and computation of `encoded_absname'.
7566 * image.c (XPutPixel): Remove unused variable `height'.
7568 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7570 * unexw32.c (get_section_info): Remove unused variable `section'.
7572 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7573 (system_process_attributes): Remove unused variable `sess'.
7574 (sys_read): Remove unused variable `err'.
7576 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7577 (w32_wnd_proc): Remove unused variable `isdead'.
7578 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7579 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7580 (x_create_tip_frame): Remove unused variable `tem'.
7582 * w32inevt.c (w32_console_read_socket):
7583 Remove unused variable `no_events'.
7585 * w32term.c (x_draw_composite_glyph_string_foreground):
7586 Remove unused variable `width'.
7588 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7590 * w32term.c (x_set_glyph_string_clipping):
7591 Don't pass uninitialized region to CombineRgn.
7593 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7595 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7596 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7597 (Fx_close_connection): Remove unused variable `i'.
7599 * w32font.c (w32font_draw): Return number of glyphs.
7600 (w32font_open_internal): Remove unused variable `i'.
7601 (w32font_driver): Add missing initializer.
7603 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7604 (fill_in_menu): Remove unused variable `items_added'.
7606 * w32term.c (last_mouse_press_frame): Remove static global variable.
7607 (w32_clip_to_row): Remove unused variable `f'.
7608 (x_delete_terminal): Remove unused variable `i'.
7610 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7611 (NOTHING): Remove unused static global variable.
7612 (uniscribe_check_otf): Remove unused variable `table'.
7613 (uniscribe_font_driver): Add missing initializers.
7615 2011-03-23 Julien Danjou <julien@danjou.info>
7617 * term.c (Fsuspend_tty, Fresume_tty):
7618 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7619 * window.c (temp_output_buffer_show):
7620 * insdel.c (signal_before_change):
7621 * frame.c (Fhandle_switch_frame):
7622 * fileio.c (Fdo_auto_save):
7623 * emacs.c (Fkill_emacs):
7624 * editfns.c (save_excursion_restore):
7625 * cmds.c (internal_self_insert):
7626 * callint.c (Fcall_interactively):
7627 * buffer.c (Fkill_all_local_variables):
7628 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7630 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7631 unconditionnaly since it does the check itself.
7633 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7635 Fix more problems found by GCC 4.5.2's static checks.
7637 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7638 the first time through the loop, since we know p0 < p1 then.
7639 This also avoids a gcc -Wstrict-overflow warning.
7641 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7642 leading to a memory leak, possible in functions like
7643 load_charset_map_from_file that can allocate an unbounded number
7644 of objects (Bug#8318).
7646 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7647 that could (at least in theory) be that large.
7649 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7650 This is less likely to overflow, and avoids undefined behavior if
7651 overflow does occur. All callers changed. Use strtoul to scan
7652 for the unsigned long integer.
7653 (pint2hrstr): Simplify and tune code slightly.
7654 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7656 * scroll.c (do_scrolling): Work around GCC bug 48228.
7657 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7659 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7660 This also avoids a warning with gcc -Wstrict-overflow.
7661 (validate_x_resource_name): Simplify count usage.
7662 This also avoids a warning with gcc -Wstrict-overflow.
7664 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7667 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7669 * process.c (Fmake_network_process): Use socklen_t, not int,
7670 where POSIX says socklen_t is required in portable programs.
7671 This fixes a porting bug on hosts like 64-bit HP-UX, where
7672 socklen_t is wider than int (Bug#8277).
7673 (Fmake_network_process, server_accept_connection):
7674 (wait_reading_process_output, read_process_output):
7677 * process.c: Rename or move locals to avoid shadowing.
7678 (list_processes_1, Fmake_network_process):
7679 (read_process_output_error_handler, exec_sentinel_error_handler):
7680 Rename or move locals.
7681 (Fmake_network_process): Define label "retry_connect" only if needed.
7682 (Fnetwork_interface_info): Fix pointer signedness.
7683 (process_send_signal): Add cast to avoid pointer signedness problem.
7684 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7685 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7687 Make tparam.h and terminfo.c consistent.
7688 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7689 Include tparam.h instead, since it declares them.
7690 * cm.h (PC): Remove extern decl; tparam.h now does this.
7691 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7692 * terminfo.c: Include tparam.h, to check interfaces.
7693 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7694 (tparam): Adjust signature to match interface in tparam.h;
7695 this removes some undefined behavior. Check that outstring and len
7696 are zero, which they always are with Emacs.
7697 * tparam.h (PC, BC, UP): New extern decls.
7699 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7700 (xftfont_open): Rename locals to avoid shadowing.
7702 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7703 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7704 (OTF_TAG_SYM): Omit macro if not needed.
7705 (ftfont_list): Remove unused local.
7706 (get_adstyle_property, ftfont_pattern_entity):
7707 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7708 Rename locals to avoid shadowing.
7710 * xfont.c (xfont_list_family): Mark var as initialized.
7712 * xml.c (make_dom): Now static.
7714 * composite.c (composition_compute_stop_pos): Rename local to
7716 (composition_reseat_it): Remove unused locals.
7717 (find_automatic_composition, composition_adjust_point): Likewise.
7718 (composition_update_it): Mark var as initialized.
7719 (find_automatic_composition): Mark vars as initialized,
7720 with a FIXME (Bug#8290).
7722 character.h: Rename locals to avoid shadowing.
7723 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7724 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7725 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7726 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7729 * textprop.c (property_change_between_p): Remove; unused.
7731 * intervals.c (interval_start_pos): Now static.
7733 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7735 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7736 Rename locals to avoid shadowing.
7738 * sound.c (wav_play, au_play, Fplay_sound_internal):
7739 Fix pointer signedness.
7740 (alsa_choose_format): Remove unused local var.
7741 (wav_play): Initialize a variable to 0, to prevent undefined
7742 behavior (Bug#8278).
7744 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7746 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7748 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7749 clobbering (Bug#8298).
7750 * sysdep.c (sys_subshell): Likewise.
7751 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7753 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7754 This should get cleaned up, so that child_setup has the
7755 same signature on all platforms.
7757 * callproc.c (call_process_cleanup): Now static.
7758 (relocate_fd): Rename locals to avoid shadowing.
7760 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7762 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7763 not to be necessary, and produces flickering.
7765 2011-03-20 Glenn Morris <rgm@gnu.org>
7767 * config.in: Remove file.
7769 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7771 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7772 are now in src/globals.h.
7773 (syms_of_minibuf): Remove spurious & from previous change.
7775 2011-03-20 Leo <sdl.web@gmail.com>
7777 * minibuf.c (completing-read-function): New variable.
7778 (completing-read-default): Rename from completing-read.
7779 (completing-read): Call completing-read-function.
7781 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7783 * xfaces.c (Fx_load_color_file):
7784 Read color file from absolute filename (bug#8250).
7786 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7788 * makefile.w32-in: Update dependencies.
7790 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7792 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7794 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7796 Fix more problems found by GCC 4.5.2's static checks.
7798 * process.c (make_serial_process_unwind, send_process_trap):
7799 (sigchld_handler): Now static.
7801 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7802 That way, the code declares only the vars that it needs.
7803 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7804 * s/cygwin.h (PTY_ITERATION): Likewise.
7805 * s/darwin.h (PTY_ITERATION): Likewise.
7806 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7808 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7809 * process.c (allocate_pty): Don't declare stb unless it's needed.
7811 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7812 (CONSTANTLIM): Remove; unused.
7813 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7814 Define only if needed.
7816 * unexelf.c (unexec): Name an expression,
7817 to avoid gcc -Wbad-function-cast warning.
7818 Use a different way to cause a compilation error if anyone uses
7819 n rather than nn, a way that does not involve shadowing.
7820 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7822 * deps.mk (unexalpha.o): Remove; unused.
7824 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7825 * unexec.h: New file.
7826 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7827 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7829 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7830 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7831 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7832 Change as necessary to match prototype in unexec.h.
7834 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7836 (back_comment, skip_chars): Mark vars as initialized.
7838 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7839 Rename locals to avoid shadowing.
7841 * lread.c (read1): Rewrite so as not to use empty "else".
7842 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7844 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7846 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7847 warning when compiling print.c.
7849 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7850 instead of using an uninitialized var.
7851 (font_sort_entities): Mark var as initialized.
7853 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7855 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7856 pointers to constants.
7857 (font_parse_fcname): Remove unused vars.
7858 (font_delete_unmatched): Now static.
7859 (font_get_spec): Remove; unused.
7860 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7861 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7862 Rename or move locals to avoid shadowing.
7864 * fns.c (require_nesting_list, require_unwind): Now static.
7865 (Ffillarray): Rename locals to avoid shadowing.
7867 * floatfns.c (domain_error2): Define only if needed.
7868 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7870 * alloc.c (mark_backtrace): Move decl from here ...
7871 * lisp.h: ... to here, so that it can be checked.
7873 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7874 (Fdefvar): Rewrite so as not to use empty "else".
7875 (lisp_indirect_variable): Name an expression,
7876 to avoid gcc -Wbad-function-cast warning.
7877 (Fdefvar): Rename locals to avoid shadowing.
7879 * callint.c (quotify_arg, quotify_args): Now static.
7880 (Fcall_interactively): Rename locals to avoid shadowing.
7881 Use const pointer when appropriate.
7883 * lisp.h (get_system_name, get_operating_system_release):
7884 Move decls here, to check interfaces.
7885 * process.c (get_operating_system_release): Move decl to lisp.h.
7886 * xrdb.c (get_system_name): Likewise.
7887 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7888 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7889 some of which prompt warnings from gcc -Wbad-function-cast.
7890 (Fformat_time_string, Fencode_time, Finsert_char):
7891 (Ftranslate_region_internal, Fformat):
7892 Rename or remove local vars to avoid shadowing.
7893 (Ftranslate_region_internal): Mark var as initialized.
7895 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7898 * lisp.h (eassert): Check that the argument compiles, even if
7899 ENABLE_CHECKING is not defined.
7901 * data.c (Findirect_variable): Name an expression, to avoid
7902 gcc -Wbad-function-cast warning.
7903 (default_value, arithcompare, arith_driver, arith_error): Now static.
7904 (store_symval_forwarding): Rename local to avoid shadowing.
7905 (Fmake_variable_buffer_local, Fmake_local_variable):
7906 Mark variables as initialized.
7907 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7909 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7910 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7911 Rename locals to avoid shadowing.
7912 (mark_stack): Move local variables into the #ifdef region where
7914 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7915 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7917 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7918 (GC_STRING_CHARS): Remove; not used.
7919 (Fmemory_limit): Cast sbrk's returned value to char *.
7921 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7922 avoids undefined behavior in theory.
7924 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7926 Use functions, not macros, for up- and down-casing (Bug#8254).
7927 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7928 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7929 to use the following functions instead of these macros.
7930 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7931 EMACS_INT, since callers assume the returned value fits in int.
7932 (upcase1): Likewise, for UPCASE_TABLE.
7933 (uppercasep, lowercasep, upcase): New static inline functions.
7934 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7935 the race-condition problem in the old DOWNCASE.
7937 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7938 Rename locals to avoid shadowing.
7939 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7940 (regex_compile, re_search_2, re_match_2_internal):
7941 Remove unused local vars.
7942 (FREE_VAR): Rewrite so as not to use empty "else",
7943 which gcc can warn about.
7944 (regex_compile, re_match_2_internal): Mark locals as initialized.
7945 (RETALLOC_IF): Define only if needed.
7946 (WORDCHAR_P): Likewise. This one is never needed, but is used
7947 only in a comment talking about a compiler bug, so put inside
7948 the #if 0 of that comment.
7949 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7950 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7953 * search.c (boyer_moore): Rename locals to avoid shadowing.
7954 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7955 (PREV_CHAR_BOUNDARY): Likewise.
7957 * search.c (simple_search): Remove unused var.
7959 * dired.c (compile_pattern): Move decl from here ...
7960 * lisp.h: ... to here, so that it can be checked.
7961 (struct re_registers): New forward decl.
7963 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7965 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7967 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7968 Rename locals to avoid shadowing.
7969 (Fvertical_motion): Mark locals as initialized.
7971 * casefiddle.c (casify_object, casify_region): Now static.
7972 (casify_region): Mark local as initialized.
7974 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7976 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7977 New macros, so that the caller can use some names other than
7978 gcpro1, gcpro2, etc.
7979 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7981 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7982 argument, for consistency with GCPRO2_VAR, etc: it is now the
7983 prefix of the variable, not the variable itself. All uses
7985 * dired.c (directory_files_internal, file_name_completion):
7986 Rename locals to avoid shadowing.
7988 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7989 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7990 dired.c's scmp function, had undefined behavior.
7991 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7992 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7993 * buffer.h: ... to here, because these macros use current_buffer,
7994 and the new implementation with inline functions needs to have
7995 current_buffer in scope now, rather than later when the macros
7997 (downcase, upcase1): New static inline functions.
7998 (DOWNCASE, UPCASE1): Reimplement using these functions.
7999 This avoids undefined behavior in expressions like
8000 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8001 from race conditions in accessing the global variables
8002 case_temp1 and case_temp2.
8003 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8004 * lisp.h (case_temp1, case_temp2): Remove their decls.
8005 * character.h (ASCII_CHAR_P): Move from here ...
8006 * lisp.h: ... to here, so that the inline functions mentioned
8009 * dired.c (directory_files_internal_unwind): Now static.
8011 * fileio.c (file_name_as_directory, directory_file_name):
8012 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8014 (file_name_as_directory): Use const pointers when appropriate.
8015 (Fexpand_file_name): Likewise. In particular, newdir might
8016 point at constant storage, so make it a const pointer.
8017 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8018 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8020 (Fset_file_times, Finsert_file_contents, auto_save_error):
8021 Rename locals to avoid shadowing.
8023 * minibuf.c (choose_minibuf_frame_1): Now static.
8024 (Ftry_completion, Fall_completions): Rename or remove locals
8027 * marker.c (bytepos_to_charpos): Remove; unused.
8029 * lisp.h (verify_bytepos, count_markers): New decls,
8030 so that gcc does not warn that these functions aren't declared.
8032 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8033 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8034 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8035 (copy_text): Remove unused local var.
8037 * filelock.c (within_one_second): Now static.
8038 (lock_file_1): Rename local to avoid shadowing.
8040 * buffer.c (fix_overlays_before): Mark locals as initialized.
8041 (fix_start_end_in_overlays): Likewise. This function should be
8042 simplified by using pointers-to-pointers, but that's a different
8044 (switch_to_buffer_1): Now static.
8045 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8046 (report_overlay_modification): Rename locals to avoid shadowing.
8048 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8049 Fix pointer signedness issue.
8050 (sys_subshell): Mark local as volatile if checking for lint,
8051 to suppress a gcc -Wclobbered warning that does not seem to be right.
8052 (MAXPATHLEN): Define only if needed.
8054 * process.c (serial_open, serial_configure): Move decls from here ...
8055 * systty.h: ... to here, so that they can be checked.
8057 * fns.c (get_random, seed_random): Move extern decls from here ...
8058 * lisp.h: ... to here, so that they can be checked.
8060 * sysdep.c (reset_io): Now static.
8061 (wait_for_termination_signal): Remove; unused.
8063 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8064 (copy_keymap_item, append_key, push_text_char_description):
8066 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8067 (DENSE_TABLE_SIZE): Remove; unused.
8068 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8069 (describe_map_tree):
8070 Rename locals to avoid shadowing.
8072 * keyboard.c: Declare functions static if they are not used elsewhere.
8073 (echo_char, echo_dash, cmd_error, top_level_2):
8074 (poll_for_input, handle_async_input): Now static.
8075 (read_char, kbd_buffer_get_event, make_lispy_position):
8076 (make_lispy_event, make_lispy_movement, apply_modifiers):
8077 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8078 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8079 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8080 (read_key_sequence, read_char): Mark locals as initialized.
8081 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8083 * keyboard.h (make_ctrl_char): New decl.
8084 (mark_kboards): Move decl here ...
8085 * alloc.c (mark_kboards): ... from here.
8087 * lisp.h (force_auto_save_soon): New decl.
8089 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8090 (DEFINE_DUMMY_FUNCTION): New macro.
8091 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8093 (main): Add casts to avoid warnings
8094 if GCC considers string literals to be constants.
8096 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8098 * dbusbind.c: Pointer signedness fixes.
8099 (xd_signature, xd_append_arg, xd_initialize):
8100 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8101 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8102 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8103 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8105 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8106 if GCC considers string literals to be constants.
8107 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8109 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8111 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8112 (print_preprocess, print_object): New macro to fix last change.
8114 * print.c (print_preprocess): Don't forget font objects.
8116 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8118 * emacs.c (USAGE3): Doc fixes.
8120 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8122 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8125 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8127 * lisp.h (VWindow_system, Qfile_name_history):
8128 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8129 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8130 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8132 * w32select.c: Don't #include "keyboard.h".
8133 (run_protected): Add extern declaration for waiting_for_input.
8135 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8136 * w32console.c (detect_input_pending, read_input_pending)
8137 (encode_terminal_code):
8138 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8139 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8140 (w32_system_caret_y, Qfile_name_history):
8141 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8142 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8143 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8144 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8145 * w32proc.c (Qlocal, report_file_error):
8146 * w32term.c (Vwindow_system, updating_frame):
8147 * w32uniscribe.c (initialized, uniscribe_font_driver):
8148 Remove unneeded extern declarations.
8150 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8152 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8154 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8156 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8157 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8158 These macros can no longer be used for assignment.
8160 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8161 Assign struct members directly, instead of using BUF_BEGV etc.
8162 (record_buffer_markers, fetch_buffer_markers): New functions for
8163 recording and fetching special buffer markers.
8164 (set_buffer_internal_1, set_buffer_temp): Use them.
8166 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8168 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8170 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8171 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8173 * xdisp.c (hscroll_window_tree):
8174 (reconsider_clip_changes): Use PT instead of BUF_PT.
8176 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8178 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8179 $(EMACS_ROOT)/lib/intprops.h.
8181 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8183 Fix more problems found by GCC 4.5.2's static checks.
8185 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8186 to unsigned char * to avoid compiler diagnostic.
8187 (xg_free_frame_widgets): Make it clear that a local variable is
8188 needed only if USE_GTK_TOOLTIP.
8189 (gdk_window_get_screen): Make it clear that this macro is needed
8190 only if USE_GTK_TOOLTIP.
8191 (int_gtk_range_get_value): New function, which avoids a diagnostic
8192 from gcc -Wbad-function-cast.
8193 (xg_set_toolkit_scroll_bar_thumb): Use it.
8194 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8195 diagnostic from gcc -Wbad-function-cast.
8196 (get_utf8_string, xg_get_file_with_chooser):
8197 Rename locals to avoid shadowing.
8198 (create_dialog): Move locals to avoid shadowing.
8200 * xgselect.c (xg_select): Remove unused var.
8202 * image.c (four_corners_best): Mark locals as initialized.
8203 (gif_load): Initialize transparent_p to zero (Bug#8238).
8204 Mark another local as initialized.
8205 (my_png_error, my_error_exit): Mark with NO_RETURN.
8207 * image.c (clear_image_cache): Now static.
8208 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8209 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8210 (x_edge_detection): Remove unnecessary cast that
8211 gcc -Wbad-function-cast diagnoses.
8212 (gif_load): Fix pointer signedness.
8213 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8214 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8216 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8218 Improve quality of tests for time stamp overflow.
8219 For example, without this patch (encode-time 0 0 0 1 1
8220 1152921504606846976) returns the obviously-bogus value (-948597
8221 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8222 reports time overflow. See
8223 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8224 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8225 * editfns.c: Include limits.h and intprops.h.
8226 (TIME_T_MIN, TIME_T_MAX): New macros.
8227 (time_overflow): Move earlier, to before first use.
8228 (hi_time, lo_time): New functions, for an accurate test for
8230 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8231 (Fget_internal_run_time): Don't assume time_t fits in int.
8232 (make_time): Use list2 instead of Fcons twice.
8233 (Fdecode_time): More accurate test for out-of-range times.
8234 (check_tm_member): New function.
8235 (Fencode_time): Use it, to test for out-of-range times.
8236 (lisp_time_argument): Don't rely on undefined left-shift and
8237 right-shift behavior when checking for time stamp overflow.
8239 * editfns.c (time_overflow): New function, refactoring common code.
8240 (Fformat_time_string, Fdecode_time, Fencode_time):
8241 (Fcurrent_time_string): Use it.
8243 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8244 * dired.c (make_time): Move to ...
8245 * editfns.c (make_time): ... here.
8246 * systime.h: Note the move.
8248 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8250 * fringe.c (update_window_fringes): Remove unused variables.
8252 * unexmacosx.c (copy_data_segment): Also copy __got section.
8255 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8257 * termcap.c [MSDOS]: Include "msdos.h".
8258 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8259 Constify `char *' arguments and their references according to
8260 prototypes in tparam.h.
8262 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8264 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8265 Adapt all references accordingly.
8267 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8269 2011-03-11 Tom Tromey <tromey@redhat.com>
8271 * buffer.c (syms_of_buffer): Remove obsolete comment.
8273 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8275 * termhooks.h (encode_terminal_code): Declare prototype.
8277 * msdos.c (encode_terminal_code): Don't declare prototype.
8279 * term.c (encode_terminal_code): Now external again, used by
8280 w32console.c and msdos.c.
8282 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8283 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8285 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8287 Fix some minor problems found by GCC 4.5.2's static checks.
8289 * fringe.c (update_window_fringes): Mark locals as initialized
8291 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8293 * alloc.c (mark_fringe_data): Move decl from here ...
8294 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8295 to check its interface.
8296 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8298 * fontset.c (free_realized_fontset): Now static.
8299 (Fset_fontset_font): Rename local to avoid shadowing.
8300 (fontset_font): Mark local as initialized.
8301 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8303 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8305 * xselect.c (x_disown_buffer_selections): Remove; not used.
8306 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8307 (x_own_selection, Fx_disown_selection_internal): Rename locals
8309 (x_handle_dnd_message): Remove local to avoid shadowing.
8311 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8312 so that the caller can use some name other than gcpro1.
8313 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8314 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8315 (Fx_backspace_delete_keys_p):
8316 Use them to avoid shadowing, and rename vars to avoid shadowing.
8317 (x_decode_color, x_set_name, x_window): Now static.
8318 (Fx_create_frame): Add braces to silence GCC warning.
8319 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8320 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8321 Remove unused locals.
8322 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8323 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8324 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8327 * xterm.h (x_mouse_leave): New decl.
8329 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8330 Remove unused functions.
8331 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8332 (x_calc_absolute_position): Now static.
8333 (XTread_socket): Don't define label "out" unless it's used.
8334 Don't declare local "event" unless it's used.
8335 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8336 unless they are used.
8337 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8338 (x_fatal_error_signal): Remove; not used.
8339 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8340 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8341 (x_error_catcher, x_connection_closed, x_error_handler):
8342 (x_error_quitter, xembed_send_message, x_iconify_frame):
8343 (my_log_handler): Rename locals to avoid shadowing.
8344 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8345 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8347 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8348 Rename or move locals to avoid shadowing.
8349 (tty_defined_color, merge_face_heights): Now static.
8350 (free_realized_faces_for_fontset): Remove; not used.
8351 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8352 does not deduce is never used uninitialized.
8353 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8354 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8356 * terminal.c (store_terminal_param): Now static.
8358 * xmenu.c (menu_highlight_callback): Now static.
8359 (set_frame_menubar): Remove unused local.
8360 (xmenu_show): Rename parameter to avoid shadowing.
8361 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8362 since they might point to immutable storage.
8363 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8364 since it's unused otherwise.
8366 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8367 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8368 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8369 avoids a gcc -Wuninitialized diagnostic.
8370 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8371 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8372 does not deduce are never used uninitialized.
8374 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8376 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8377 * window.c (window_loop, size_window):
8378 (run_window_configuration_change_hook, enlarge_window): Likewise.
8380 * window.c (display_buffer): Now static.
8381 (size_window): Mark variables that gcc -Wuninitialized
8382 does not deduce are never used uninitialized.
8383 * window.h (check_all_windows): New decl, to forestall
8384 gcc -Wmissing-prototypes diagnostic.
8385 * dispextern.h (bidi_dump_cached_states): Likewise.
8387 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8389 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8391 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8392 and to avoid gcc -Wuninitialized warning.
8393 (load_charset_map): Mark variables that gcc -Wuninitialized
8394 does not deduce are never used uninitialized.
8395 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8397 * coding.c (coding_set_source, coding_set_destination):
8398 Use "else { /* comment */ }" rather than "else /* comment */;"
8399 for clarity, and to avoid gcc -Wempty-body warning.
8400 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8401 a block, when the outer 'i' will do.
8402 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8403 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8404 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8405 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8406 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8407 Rename locals to avoid shadowing.
8408 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8409 * coding.c (emacs_mule_char, encode_invocation_designation):
8410 Now static, since they're not used elsewhere.
8411 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8412 (decode_coding_object, encode_coding_object, detect_coding_system):
8413 (decode_coding_emacs_mule): Mark variables that gcc
8414 -Wuninitialized does not deduce are never used uninitialized.
8415 (detect_coding_iso_2022): Initialize a local variable that might
8416 be used uninitialized. Leave a FIXME because it's not clear that
8417 this initialization is needed. (Bug#8211)
8418 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8419 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8420 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8421 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8422 Remove unused macros.
8424 * category.c (hash_get_category_set): Remove unused local var.
8425 (copy_category_table): Now static, since it's not used elsewhere.
8426 * character.c (string_count_byte8): Likewise.
8428 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8429 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8431 * chartab.c (copy_sub_char_table): Now static, since it's not used
8433 (sub_char_table_ref_and_range, char_table_ref_and_range):
8434 Rename locals to avoid shadowing.
8435 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8437 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8438 (BIDI_BOB): Remove unused macro.
8440 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8441 deduce are never used uninitialized.
8442 * term.c (encode_terminal_code): Likewise.
8444 * term.c (encode_terminal_code): Now static. Remove unused local.
8446 * tparam.h: New file.
8447 * term.c, tparam.h: Include it.
8448 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8449 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8450 Move these decls to tparam.h, and make them agree with what
8451 is actually in tparam.c. The previous trick of using incompatible
8452 decls in different modules does not conform to the C standard.
8453 All callers of tparam changed to use tparam's actual API.
8454 * tparam.c (tparam1, tparam, tgoto):
8455 Use const pointers where appropriate.
8457 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8458 * cm.h (struct cm): Likewise.
8459 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8460 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8461 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8462 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8463 (turn_on_face, init_tty): Likewise.
8464 * termchar.h (struct tty_display_info): Likewise.
8466 * term.c (term_mouse_position): Rename local to avoid shadowing.
8468 * alloc.c (mark_ttys): Move decl from here ...
8469 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8471 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8473 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8475 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8477 * search.c (compile_pattern_1): Remove argument regp, unused since
8478 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8479 (compile_pattern): Don't pass it.
8481 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8483 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8484 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8486 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8488 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8490 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8491 gdk_window_get_screen, gdk_window_get_geometry,
8492 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8493 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8494 (xg_get_pixbuf_from_pixmap): New function.
8495 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8496 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8497 Call xg_get_pixbuf_from_pixmap instead of
8498 gdk_pixbuf_get_from_drawable.
8499 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8500 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8501 (xg_check_special_colors): Use GtkStyleContext and its functions
8503 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8504 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8505 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8506 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8507 Call gtk_widget_get_preferred_size.
8508 (xg_frame_resized): gdk_window_get_geometry only takes 5
8510 (xg_win_to_widget, xg_event_is_for_menubar):
8511 Call gdk_x11_window_lookup_for_display.
8512 (xg_set_widget_bg): New function.
8513 (delete_cb): New function.
8514 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8515 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8516 (xg_set_background_color): Call xg_set_widget_bg.
8517 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8518 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8519 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8520 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8522 (update_frame_tool_bar): Call gtk_widget_hide.
8523 (xg_initialize): Use GDK_KEY_g.
8525 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8527 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8529 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8530 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8531 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8533 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8535 * w32xfns.c (select_palette): Check success of RealizePalette against
8536 GDI_ERROR, not zero.
8538 See ChangeLog.11 for earlier changes.
8544 Copyright (C) 2011 Free Software Foundation, Inc.
8546 This file is part of GNU Emacs.
8548 GNU Emacs is free software: you can redistribute it and/or modify
8549 it under the terms of the GNU General Public License as published by
8550 the Free Software Foundation, either version 3 of the License, or
8551 (at your option) any later version.
8553 GNU Emacs is distributed in the hope that it will be useful,
8554 but WITHOUT ANY WARRANTY; without even the implied warranty of
8555 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8556 GNU General Public License for more details.
8558 You should have received a copy of the GNU General Public License
8559 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.