1 2012-07-26 Juanma Barranquero <lekktu@gmail.com>
3 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
5 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
7 Simplify export of symbols to GDB (Bug#12036).
8 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
9 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
10 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
11 Adjust to changes in lisp.h and emacs.c, by using
12 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
13 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
14 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
15 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
16 instead of gdb_valbits.
17 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
18 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
19 instead of gdb_array_mark_flag.
20 (xboolvector): Get size from $->size, not $->header.size.
21 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
22 (xreload, hook-run, hookpost-run): Remove.
23 * emacs.c: Include <verify.h>.
24 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
25 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
27 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
28 (gdb_USE_LSB_TAG): New enum constants.
29 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
30 Also define these as enum constants, so they're visible to GDB.
31 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
32 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
33 as constants, so they're visible to GDB.
34 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
35 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
36 Now enum constants, not macros, so they're visible to GDB.
37 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
38 more convenient now. All uses changed.
39 (VALMASK) [USE_LSB_TAG]: Also define in this case.
40 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
42 2012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
44 Explicitly free restriction data that are not needed anymore.
45 * editfns.c (save_restriction_restore): Free restriction data.
47 2012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
49 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
50 add argument, tune behavior, and adjust all callers.
52 2012-07-25 Paul Eggert <eggert@cs.ucla.edu>
54 Use typedef for EMACS_INT, EMACS_UINT.
55 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
56 than macros. This simplifies debugging in the usual case, since
57 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
58 and it allows expressions involving EMACS_INT casts.
59 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
61 2012-07-25 Jan Djärv <jan.h.d@swipnet.se>
63 * nsterm.m (ns_read_socket): Return early if there is a modal
66 2012-07-25 Martin Rudalics <rudalics@gmx.at>
68 * frame.c (Fredirect_frame_focus): In doc-string don't mention
69 that FOCUS-FRAME can be omitted.
71 2012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
73 Adjust buffer text indirection counters at the end of Fkill_buffer.
74 * buffer.c (Fkill_buffer): Adjust indirection counters when the
75 buffer is definitely dead. This should really fix an issue reported
76 by Christoph Scholtes again. (Bug#12007).
77 (init_buffer_once): Initialize indirection counters of
78 buffer_defaults and buffer_local_symbols (for sanity and safety).
80 2012-07-24 Eli Zaretskii <eliz@gnu.org>
82 * xdisp.c (init_iterator): Don't compute dimensions of truncation
83 and continuation glyphs on tooltip frames, leave them at zero.
84 Avoids continued lines in tooltips. (Bug#11832)
86 2012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
88 Simplify copy_overlay.
89 * buffer.c (copy_overlay): Simplify. Use build_marker.
90 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
92 2012-07-23 Eli Zaretskii <eliz@gnu.org>
94 * print.c (print_object): Don't crash when a frame's name is nil
95 or invalid. (Bug#12025)
97 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
98 it signals an error when a tooltip frame is being created.
100 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
102 Cleanup miscellaneous objects allocation and initialization.
103 * alloc.c (allocate_misc): Change to static. Add argument to
104 specify the subtype. Adjust comment and users.
105 (build_overlay): New function.
106 * buffer.c (copy_overlays, Fmake_overlay): Use it.
107 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
108 (allocate_misc): Remove prototype.
109 (build_overlay): Add prototype.
111 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
113 Swap buffer text indirection counters in Fbuffer_swap_text.
114 * buffer.c (Fbuffer_swap_text): Swap indirections too.
115 This avoids crash reported by Christoph Scholtes at
116 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
118 2012-07-22 Jan Djärv <jan.h.d@swipnet.se>
120 * nsmenu.m (Popdown_data): New struct.
121 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
123 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
124 (initWithContentRect): Make imgView and contentView non-static
125 and autorelease them. Also autorelease img and matrix (Bug#12005).
126 (dealloc): Remove (Bug#12005).
128 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
130 Adjust consing_since_gc when objects are explicitly freed.
131 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
132 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
133 (free_cons, free_misc): Subtract object size from consing_since_gc.
135 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
137 Simplify and cleanup markers positioning code.
138 * marker.c (attach_marker): More useful eassert.
139 (live_buffer, set_marker_internal): New function.
140 (Fset_marker, set_marker_restricted): Use set_marker_internal.
141 (set_marker_both, set_marker_restricted_both): Use live_buffer.
143 2012-07-22 Paul Eggert <eggert@cs.ucla.edu>
145 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
146 as it's limited by the amount of memory, not by INT_MAX.
148 2012-07-21 Eli Zaretskii <eliz@gnu.org>
150 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
151 in special-event-map. See the discussion at
152 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
155 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
156 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
157 Fabrice Popineau <fabrice.popineau@supelec.fr>.
159 2012-07-21 Jan Djärv <jan.h.d@swipnet.se>
161 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
162 (conversationIdentifier): Return value is NSInteger.
163 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
165 2012-07-21 Chong Yidong <cyd@gnu.org>
167 * window.c (decode_any_window): Signal an error if the window is
168 on a dead frame (Bug#11984).
170 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
172 Add indirection counting to speed up Fkill_buffer.
173 * buffer.h (struct buffer): New member.
174 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
175 (Fmake_indirect_buffer): Set indirection counter to -1, increment
176 base buffer indirection counter.
177 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
178 (Fkill_buffer): Adjust indirection counters as needed, don't walk
179 through buffer list if indirection counter is 0.
181 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
183 Extend the value returned by Fgarbage_collect with heap statistics.
184 * alloc.c (Qheap): New symbol.
185 (syms_of_alloc): DEFSYM it.
186 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
187 (Fmemory_free): Remove.
188 (syms_of_alloc): Don't defsubr it.
189 * buffer.c (Fcompact_buffer): Remove.
190 (syms_of_buffer): Don't defsubr it.
192 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
194 Make maybe_gc inline.
195 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
196 * lisp.h (consing_since_gc, gc_relative_threshold)
197 (memory_full_cons_threshold): Revert declaration.
198 (maybe_gc): Remove prototype, define as inline.
199 * alloc.c: Remove old commented-out code.
200 (consing_since_gc, gc_relative_threshold)
201 (memory_full_cons_threshold): Revert to global.
204 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
206 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
207 * lisp.h (build_unibyte_string): New function.
208 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
209 * sysdep.c, w32fns.c, xfns.c: Use it.
210 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
211 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
212 Adjust users accordingly.
213 * font.h (font_open_by_name): Adjust prototype.
215 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
217 Cleanup calls to Fgarbage_collect.
218 * lisp.h (maybe_gc): New prototype.
219 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
221 * alloc.c (maybe_gc): New function.
222 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
224 * bytecode.c (MAYBE_GC): Use maybe_gc.
225 * eval.c (eval_sub, Ffuncall): Likewise.
226 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
227 to avoid dependency from auto-save feature.
229 2012-07-19 Paul Eggert <eggert@cs.ucla.edu>
231 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
232 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
233 'for_each_per_buffer_object_at'.
234 All uses changed. It's better to use upper-case for macros that
235 cannot be implemented as functions, to give the reader a clue
236 that they're special.
238 2012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
240 * alloc.c (Fgarbage_collect): Tweak docstring.
242 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
244 Tweak the value returned from Fgarbage_collect again.
245 * alloc.c (Fgarbage_collect): New return value, as confirmed in
246 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
247 Adjust documentation.
248 (total_vector_bytes): Rename to total_vector_slots, adjust
250 (total_free_vector_bytes): Rename to total_free_vector_slots,
252 (Qstring_bytes, Qvector_slots): New symbols.
253 (syms_of_alloc): DEFSYM them.
255 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
257 Buffer compaction primitive which may be used from Lisp.
258 * buffer.c (compact_buffer, Fcompact_buffer): New function.
259 (syms_of_buffer): Register Fcompact_buffer.
260 * alloc.c (Fgarbage_collect): Use compact_buffer.
261 * buffer.h (compact_buffer): New prototype.
262 (struct buffer_text): New member.
264 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
266 New macro to iterate over all buffers, miscellaneous cleanups.
267 * lisp.h (all_buffers): Remove declaration.
268 * buffer.h (all_buffers): Add declaration, with comment.
269 (for_each_buffer): New macro.
270 * alloc.c (Fgarbage_collect, mark_object): Use it.
271 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
272 (init_buffer): Likewise.
273 * data.c (Fset_default): Likewise.
274 * coding.c (code_conversion_restore): Remove redundant check
276 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
278 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
280 Fix bug that created negative-length intervals.
281 * intervals.c (merge_interval_right, merge_interval_left):
282 Do not zero out this interval if it is absorbed by its children,
283 as this interval's total length doesn't change in that case. See
284 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
286 2012-07-18 Paul Eggert <eggert@cs.ucla.edu>
288 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
289 when invoking (make-bool-vector N t) and N is a positive
290 multiple of 8 -- the last 8 bits were mistakenly cleared.
292 Remove some struct layout assumptions in bool vectors.
293 * alloc.c (bool_header_size): New constant.
294 (header_size, word_size): Move earlier, as they're now used earlier.
295 Use 'word_size' in a few more places, where it's appropriate.
296 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
297 padding before the data member of a bool vector.
298 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
299 than doing the check by hand with an abort ().
301 2012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
303 * eval.c (Fdefvar): Don't check constants since we only set the var if
304 it's not yet defined anyway (bug#11904).
306 * lisp.h (last_undo_boundary): Declare new var.
307 * keyboard.c (command_loop_1): Set it.
308 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
309 were auto-added by the command loop (bug#11774).
311 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
313 * w32font.c (Qsymbol): Remove local definition.
314 (syms_of_w32font): Don't DEFSYM it.
316 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
318 Fix sweep_vectors to handle large bool vectors correctly.
319 * alloc.c (sweep_vectors): Account total_vector_bytes for
320 bool vectors larger than VBLOCK_BYTES_MAX.
322 2012-07-18 Chong Yidong <cyd@gnu.org>
324 * frame.c (x_set_frame_parameters): Revert bogus change introduced
325 in 2012-05-25 commit by Paul Eggert (Bug#11738).
327 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
329 Return more descriptive data from Fgarbage_collect.
330 Suggested by Stefan Monnier in
331 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
332 * alloc.c (bounded_number): New function.
333 (total_buffers, total_vectors): New variable.
334 (total_string_size): Rename to total_string_bytes, adjust users.
335 (total_vector_size): Rename to total_vector_bytes, adjust users.
336 (sweep_vectors): Account total_vectors and total_vector_bytes.
337 (Fgarbage_collect): New return value. Adjust documentation.
338 (gc_sweep): Account total_buffers.
339 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
340 (VECTOR_SIZE): Remove.
341 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
342 (Qinterval, Qmisc): New symbols.
343 (syms_of_data): Initialize them.
344 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
345 (Qcons, Qbuffer): New declarations.
347 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
349 * alloc.c (Fmemory_free): Account for memory-free's own storage.
350 Round up, not down. Improve doc.
352 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
354 Restore old code in allocate_string_data to avoid Faset breakage.
355 Reported by Julien Danjou <julien@danjou.info> in
356 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
357 * alloc.c (allocate_string_data): Restore old code with minor
358 adjustments, fix comment to explain this subtle issue.
360 2012-07-17 Eli Zaretskii <eliz@gnu.org>
362 Remove FILE_SYSTEM_CASE.
363 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
365 * fileio.c (FILE_SYSTEM_CASE): Don't define.
366 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
367 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
368 call-process-region passes it through expand-file-name.
370 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
372 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
374 Fix crash when creating indirect buffer (Bug#11917)
375 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
376 Don't handle unbound variables specially if non-zero.
377 (Fbuffer_local_variables): Pass zero.
378 (clone_per_buffer_values): Pass non-zero.
380 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
382 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
383 to make the loop interruptible.
385 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
387 * gnutls.c (emacs_gnutls_handshake): Only retry if
388 GNUTLS_E_INTERRUPTED.
390 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
392 Cleanup and convert miscellaneous checks to eassert.
393 * alloc.c (mark_interval): Fix comment, partially rephrase
394 old comment from intervals.h (see below).
395 * intervals.c (find_interval, adjust_intervals_for_insertion)
396 (delete_interval, adjust_intervals_for_deletion)
397 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
399 (adjust_intervals_for_insertion, make_new_interval):
400 Remove obsolete and unused code.
401 * intervals.h (struct interval): Remove obsolete comment.
402 * textprotp.c (erase_properties): Remove unused code.
403 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
404 (Fremove_list_of_text_properties): Convert to eassert.
406 2012-07-17 Chong Yidong <cyd@gnu.org>
408 * editfns.c (Finsert_char): Doc fix.
410 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
412 Fix previous change to make Fmemory_free always accurate.
413 * alloc.c (make_interval): Update total_free_intervals.
414 (make_float): Likewise for total_free_floats.
415 (free_cons, Fcons): Likewise for total_free_conses.
416 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
417 Likewise for total_free_vector_bytes.
418 (Fmake_symbol): Likewise for total_free_symbols.
419 (bytes_free): Remove.
421 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
423 Simple free memory accounting feature.
424 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
425 (sweep_vectors): Accumulate size of free vectors.
426 (Fgarbage_collect): Setup bytes_free.
427 (Fmemory_free): New function.
428 (syms_of_alloc): Register it.
430 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
432 Cleanup overlays checking.
433 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
434 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
435 eassert and OVERLAYP.
436 (sort_overlays): Change to use OVERLAYP.
438 2012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
440 * editfns.c (Finsert_char): Make it interactive, and make the
441 second arg optional. Copy interactive spec and docstring from
444 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
446 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
447 Unlike the other wrapped functions, fabs has an unspecified
450 2012-07-16 Jan Djärv <jan.h.d@swipnet.se>
452 * nsterm.m (keyDown): Interpret flags without left/right bits
453 as the left key (Bug#11670).
455 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
457 Remove empty and useless init functions.
458 * lisp.h (init_character_once, init_fns, init_image)
459 (init_filelock, init_sound): Remove prototype.
460 * character.c (init_character_once): Remove.
461 * filelock.c (init_filelock): Likewise.
462 * fns.c (init_fns): Likewise.
463 * image.c (init_image): Likewise.
464 * sound.c (init_sound): Likewise.
465 * emacs.c (main): Adjust accordingly.
467 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
469 * gtkutil.h: Tiny cleanups.
470 (use_old_gtk_file_dialog): Remove useless declaration.
471 (xg_uses_old_file_dialog): Add suggested const attribute.
473 2012-07-15 Eli Zaretskii <eliz@gnu.org>
475 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
476 (bidi_paragraph_init): Use it to limit search forward for a strong
477 directional character in abnormally large paragraphs full of
478 neutral or weak characters. (Bug#11943)
480 2012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
482 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
483 the toolbar (Bug#9451).
484 (xg_make_tool_item): Give the widget event box a transparent
487 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
489 Cleanup basic allocation variables and functions.
490 * alloc.c (ignore_warnings, init_intervals, init_float)
491 (init_cons, init_symbol, init_marker): Remove.
492 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
493 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
494 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
495 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
496 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
497 (staticidx, init_alloc_once, init_strings, free_ablock):
498 Remove redundant initialization.
499 * fns.c (init_weak_hash_tables): Remove.
500 * lisp.h (init_weak_hash_tables): Remove prototype.
502 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
504 Use zero_vector where appropriate.
505 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
507 * lisp.h (zero_vector): New declaration.
508 * font.c (null_vector): Remove.
509 (syms_of_font): Remove initialization and staticpro.
510 (font_list_entities, font_find_for_lface): Change to use zero_vector.
511 * keymap.c (Faccessible_keymaps): Likewise.
513 2012-07-15 Leo Liu <sdl.web@gmail.com>
515 * fringe.c: Fix typo in comments.
517 2012-07-14 Leo Liu <sdl.web@gmail.com>
519 * fringe.c: Add a new bitmap exclamation-mark.
521 2012-07-14 Eli Zaretskii <eliz@gnu.org>
523 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
525 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
526 (HAVE_MENUS): Don't define, defined by editing config.in with
528 (GMALLOC_INHIBIT_VALLOC): Don't define.
529 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
531 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
533 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
535 2012-07-14 Glenn Morris <rgm@gnu.org>
537 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
538 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
539 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
541 2012-07-13 Glenn Morris <rgm@gnu.org>
543 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
545 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
546 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
548 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
550 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
551 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
552 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
553 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
555 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
556 as boolean expression.
557 (x_set_window_size): Remove unused variable toolbar.
558 (ns_get_color_default, ns_mod_to_lisp): Remove.
559 (ns_mouse_position): Remove unused variables xchar and ychar.
560 (ns_compute_glyph_string_overhangs): Remove unused variable face.
561 (ns_set_vertical_scroll_bar): Remove unused variable count.
562 (ns_delete_terminal): Remove unused variable i.
563 (ns_term_init): Remove unused variables r, g and b.
564 (mouseDown): Remove unused variable window.
565 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
566 (initFrameFromEmacs): Remove unused variable vbextra.
567 (mouseEntered): Remove unused variables p and dpyinfo.
568 (mouseExited): Remove unused variables p and r.
569 (ns_define_frame_cursor, ns_clear_frame_area)
570 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
571 (menuDown): Assign [sender tag] to variable and cast the variable.
573 * nsterm.h (menuDown): Add id as type to argument sender.
574 (ns_display_info_for_name): Add Lisp_Object argument.
575 (ns_term_init): Add Lisp_Object argument.
576 (ns_map_event_to_object): Add void argument.
577 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
578 prototype with arguments and only declare if __OBJC__.
579 (nxatoms_of_nsselect): Add void argument.
580 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
581 (ns_alloc_autorelease_pool): Add void argument.
582 (ns_release_autorelease_pool): Add void* argument.
583 (ns_get_defaults_value): Add const char* argument.
585 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
586 (initFromContents): Use SSDATA where appropriate.
587 (ns_update_menubar): Add braces to ambigous if-else.
588 (initWithTitle): Put () around assignment in if statement.
589 (ns_menu_show): Remove unused variables window and keymap.
590 (update_frame_tool_bar): Remove unused variable selected_p.
591 (initWithContentRect): Remove unused variable this_cmd_name.
593 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
595 (setXBMColor): Remove unused variable len.
596 (setPixmapData): Put () around assignment in loop statement.
598 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
599 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
601 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
602 around assignment in loop statement.
603 (nsfont_open): Remove unused variable i.
604 (nsfont_open): Remove unused variable len.
605 (nsfont_draw): Remove unused variable cs.
607 * nsfns.m (x_set_icon_name, ns_set_name_internal)
608 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
609 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
610 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
611 (Fns_font_name, Fns_perform_service)
612 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
613 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
614 (ns_set_name): Remove unused variable view.
615 (x_set_menu_bar_lines): Remove unused variable olines.
616 (x_set_tool_bar_lines): Remove unused variable root_window.
617 (Fns_list_colors): Put () around assignment in while statement.
618 (Fns_perform_service): Remove unused variable len.
619 (Fns_display_usable_bounds): Remove unused variable top.
620 (syms_of_nsfns): Remove unused variable i.
622 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
625 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
627 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
628 and free it with DestroyExceptionInfo (Bug#11558).
630 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
632 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
633 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
634 Set here, not in nt/config.nt.
636 2012-07-13 Eli Zaretskii <eliz@gnu.org>
638 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
639 cursor overflow into the last glyph on display line when the right
640 fringe is off. (Bug#11832)
642 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
644 * xdisp.c (produce_special_glyphs): Now static.
645 * dispextern.h (produce_special_glyphs): Remove decl.
647 2012-07-13 Glenn Morris <rgm@gnu.org>
649 * s/bsd-common, s/cygwin.h: Remove empty files.
650 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
652 * s/usg5-4-common.h (USG, USG5):
653 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
654 * s/sol2-6.h (SOLARIS2):
655 * s/irix6-5.h (IRIX6_5):
656 * s/hpux10-20.h (USG, USG5, HPUX):
657 * s/gnu-linux.h (USG, GNU_LINUX):
658 * s/freebsd.h (BSD_SYSTEM):
659 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
660 * s/cygwin.h (CYGWIN):
661 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
662 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
664 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
666 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
668 2012-07-13 Glenn Morris <rgm@gnu.org>
670 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
672 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
674 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
675 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
677 2012-07-12 Glenn Morris <rgm@gnu.org>
679 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
681 * process.c (init_process_emacs): Rename from init_process.
682 The old name is also the name of a Mach system call.
683 * lisp.h, emacs.c: Update for this name change.
684 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
687 2012-07-12 Eli Zaretskii <eliz@gnu.org>
689 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
690 memmove call that removes glyphs covered by the left truncation
691 glyph. Improve commentary.
692 (display_line): Fix display of continuation glyphs on GUI frames
693 when the right fringe is turned off and variable-size fonts are
694 used in the window. Move the code that appends a stretch glyph to
695 produce_special_glyphs, so that it could be used for truncation
696 and continuation glyphs alike.
697 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
698 glyph of a suitably computed width, to align the special glyphs at
699 the window margin. Code moved from display_line. (Bug#11832)
701 2012-07-12 Glenn Morris <rgm@gnu.org>
703 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
705 * s/gnu-linux.h, s/hpux10-20.h:
706 Do not unconditionally define HAVE_XRMSETDATABASE.
708 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
710 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
712 Fix typos that broke OS X build.
713 Reported by Randal L. Schwartz in
714 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
715 * nsterm.m (ns_timeout): Add missing local decl.
716 (ns_get_color): snprintf -> sprintf, to fix typo.
718 2012-07-12 Glenn Morris <rgm@gnu.org>
720 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
721 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
722 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
723 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
725 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
726 Move PTY_OPEN to configure.
728 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
729 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
730 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
732 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
734 Use empty_unibyte_string where applicable.
735 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
736 * lread.c (read1): Likewise.
737 * xsettings.c (syms_of_xsettings): Likewise.
739 2012-07-12 Glenn Morris <rgm@gnu.org>
741 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
742 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
743 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
744 * s/hpux10-20.h (RUN_TIME_REMAP):
745 * s/bsd-common.h (TABDLY): Move to configure.
747 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
749 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
751 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
752 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
754 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
756 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
757 * s/template.h: Move NARROWPROTO to configure.
759 2012-07-11 Glenn Morris <rgm@gnu.org>
761 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
762 unused since 2011-01-17 change to systty.h.
764 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
765 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
766 Move HAVE_PTYS and HAVE_SOCKETS to configure.
768 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
770 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
772 2012-07-11 Glenn Morris <rgm@gnu.org>
774 * s/darwin.h, s/gnu-linux.h, s/template.h:
775 Move INTERRUPT_INPUT to configure.
777 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
779 Minor adjustments to interning code.
780 * lisp.h (intern, intern_c_string): Redefine as static inline
781 wrappers for intern_1 and intern_c_string_1, respectively.
782 (intern_1, intern_c_string_1): Rename prototypes.
783 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
785 * font.c (font_intern_prop): Likewise. Adjust comment.
786 * w32font.c (intern_font_name): Likewise.
788 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
790 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
792 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
793 of Fcar/Fcdr if possible.
794 * font.c (check_otf_features): Likewise.
795 * fontset.c (Fnew_fontset): Likewise.
796 * gnutls.c (Fgnutls_boot): Likewise.
797 * minibuf.c (read_minibuf): Likewise.
798 * msdos.c (IT_set_frame_parameters): Likewise.
799 * xmenu.c (Fx_popup_dialog): Likewise.
800 * w32menu.c (Fx_popup_dialog): Likewise.
802 2012-07-11 Glenn Morris <rgm@gnu.org>
804 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
805 since nothing has defined it on these platforms.
807 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
808 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
810 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
811 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
812 Move CLASH_DETECTION to configure.
814 * s/gnu.h: Remove file, which is now empty.
816 * s/gnu.h, s/gnu-linux.h:
817 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
819 2012-07-11 John Wiegley <johnw@newartisans.com>
821 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
822 function attribute, so we only use it if it exists in the
825 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
827 Avoid call to strlen in fast_c_string_match_ignore_case.
828 * search.c (fast_c_string_match_ignore_case): Change to use
829 length argument. Adjust users accordingly.
830 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
832 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
835 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
836 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
839 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
842 * s/hpux10-20.h (HAVE_PERROR): Remove.
843 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
844 Remove dummy definition, as this problem was obsolete long ago.
847 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
849 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
851 Avoid calls to strlen in font processing functions.
852 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
853 (font_open_by_name): Change to use length argument. Adjust
855 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
857 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
858 Change to return ptrdiff_t.
859 (xfont_list_pattern, xfont_match): Use length returned by
860 xfont_decode_coding_xlfd.
861 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
863 2012-07-11 Glenn Morris <rgm@gnu.org>
865 * s/darwin.h, s/freebsd.h, s/netbsd.h:
866 Move DONT_REOPEN_PTY to configure.
868 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
869 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
871 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
873 Remove "#define unix" that is no longer needed (Bug#11905).
874 * s/aix4-2.h (unix): Remove; no longer needed.
876 EMACS_TIME simplification (Bug#11875).
877 This replaces macros (which typically do not work in GDB)
878 with functions, typedefs and enums, making the code easier to debug.
879 The functional style also makes code easier to read and maintain.
880 * systime.h: Include <sys/time.h> on all hosts, not just if
881 WINDOWSNT, since 'struct timeval' is needed in general.
882 (EMACS_TIME): Now a typedef, not a macro.
883 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
885 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
886 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
887 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
888 (EMACS_TIME_LE): Now functions, not macros.
889 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
890 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
891 which are not functions. All uses rewritten to use:
892 (make_emacs_time): New function.
893 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
894 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
895 not functions. All uses rewritten to use the following, respectively:
896 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
897 (add_emacs_time, sub_emacs_time): New functions.
898 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
899 * fileio.c (Fcopy_file):
900 * xterm.c (XTflash): Get the current time closer to when it's used.
901 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
903 * bytecode.c (targets): Suppress -Woverride-init warnings.
905 Simplify by avoiding confusing use of strncpy etc.
906 * doc.c (Fsnarf_documentation):
907 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
908 * frame.c (Fmake_terminal_frame):
909 * gtkutil.c (get_utf8_string):
911 * nsmenu.m (ns_update_menubar):
912 * regex.c (regerror):
913 Prefer memcpy to strncpy and strncat when either will do.
914 * fileio.c (Fsubstitute_in_file_name):
915 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
916 (menu_separator_name_p):
917 * nsmenu.m (ns_update_menubar):
918 Prefer memcmp to strncmp when either will do.
919 * nsterm.m: Include <ftoastr.h>.
921 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
922 Prefer snprintf to strncpy.
923 * nsterm.m (ns_term_init):
924 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
925 * nsterm.m (ns_term_init):
926 Avoid the need for strncpy, by using build_string or
927 make_unibyte_string directly. Use dtoastr, not snprintf.
928 * process.c (Fmake_network_process): Diagnose service names that
929 are too long, rather than silently truncating them or creating
930 non-null-terminated names.
931 (Fnetwork_interface_info): Likewise, for interface names.
932 * sysdep.c (system_process_attributes) [GNU_LINUX]:
933 Prefer sprintf to strncat.
934 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
935 Prefer vsnprintf to vsprintf + strncpy.
937 2012-07-10 Glenn Morris <rgm@gnu.org>
939 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
940 Clarify fallback case.
942 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
944 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
945 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
946 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
947 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
948 where argument type is known to be a Lisp_Cons.
950 2012-07-10 Tom Tromey <tromey@redhat.com>
952 * bytecode.c (BYTE_CODE_THREADED): New macro.
953 (BYTE_CODES): New macro. Replaces all old byte-code defines.
954 (enum byte_code_op): New type.
955 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
956 (exec_byte_code): Use them. Use token threading when applicable.
958 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
960 Optimize pure C strings initialization.
961 * lisp.h (make_pure_string): Fix prototype.
962 (build_pure_c_string): New function, defined as static inline. This
963 provides a better opportunity to optimize away calls to strlen when
964 the function is called with compile-time constant argument.
965 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
966 argument, adjust users accordingly. Use build_pure_c_string where
968 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
969 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
970 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
972 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
974 Avoid calls to strlen in miscellaneous functions.
975 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
976 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
977 * lread.c (openp): Likewise.
979 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
981 Avoid calls to strlen in path processing functions.
982 * fileio.c (file_name_as_directory): Add comment. Change to add
983 srclen argument and return the length of result. Adjust users
985 (directory_file_name): Fix comment. Change to add srclen argument,
986 swap 1st and 2nd arguments to obey the common convention. Adjust
988 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
990 2012-07-10 Glenn Morris <rgm@gnu.org>
992 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
993 Move PENDING_OUTPUT_COUNT definition to configure.
995 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
996 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
997 * s/gnu.h (DATA_START): Move definitions to configure.
999 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1000 We include usg5-4-common.h, which defines them both.
1002 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1003 O_RDONLY already includes it).
1005 Stop ns builds setting the EMACSLOADPATH environment variable.
1006 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1007 Now it does not set EMACSLOADPATH, just returns the load-path string.
1008 * nsterm.h: Update accordingly.
1009 * lread.c [HAVE_NS]: Include nsterm.h.
1010 (init_lread) [HAVE_NS]: Use ns_load_path.
1011 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1013 2012-07-09 Glenn Morris <rgm@gnu.org>
1015 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1016 since the included bsd-common.h does so.
1018 Stop ns builds setting the EMACSPATH environment variable.
1019 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1020 (ns_init_paths): Do not set EMACSPATH.
1021 * nsterm.h (ns_exec_path): Add it.
1022 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1025 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1027 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1029 * process.c (wait_reading_process_output): 'waitchannels' was unset
1030 when read_kbd || !NILP (wait_for_cell); fix this.
1032 Add GCC-style 'const' attribute to functions that can use it.
1033 * character.h (char_resolve_modifier_mask):
1034 * keyboard.h (make_ctrl_char):
1035 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1036 (init_character_once, next_almost_prime, init_fns, init_image)
1037 (flush_pending_output, init_sound):
1038 * mem-limits.h (start_of_data):
1039 * menu.h (finish_menu_items):
1040 Add ATTRIBUTE_CONST.
1041 * emacs.c (DEFINE_DUMMY_FUNCTION):
1042 Declare the dummy function with ATTRIBUTE_CONST.
1043 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1044 Add decls with ATTRIBUTE_CONST.
1046 Minor improvements to make_formatted_string.
1047 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1048 where int is good enough, as vsprintf returns an int.
1049 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1051 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1053 Use make_formatted_string to avoid double length calculation.
1054 * lisp.h (make_formatted_string): New prototype.
1055 * alloc.c (make_formatted_string): New function.
1056 * buffer.c (Fgenerate_new_buffer_name): Use it.
1057 * dbus.c (syms_of_dbusbind): Likewise.
1058 * editfns.c (Fcurrent_time_zone): Likewise.
1059 * filelock.c (get_boot_time): Likewise.
1060 * frame.c (make_terminal_frame, set_term_frame_name)
1061 (x_report_frame_params): Likewise.
1062 * image.c (gs_load): Likewise.
1063 * minibuf.c (get_minibuffer): Likewise.
1064 * msdos.c (dos_set_window_size): Likewise.
1065 * process.c (make_process): Likewise.
1066 * xdisp.c (ensure_echo_area_buffers): Likewise.
1067 * xsettings.c (apply_xft_settings): Likewise.
1069 2012-07-09 Glenn Morris <rgm@gnu.org>
1071 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1072 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1073 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1074 * nsterm.h (ns_etc_directory): Add it.
1075 * callproc.c [HAVE_NS]: Include nsterm.h.
1076 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1078 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1080 Move marker debugging code under MARKER_DEBUG.
1081 * marker.c (MARKER_DEBUG): Move marker debugging code under
1082 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1083 for bootstrap with --enable-checking (~3x slowdown reported
1084 by Juanma Barranquero <lekktu@gmail.com>).
1085 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1087 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1089 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1090 See <http://bugs.gnu.org/11825#29>.
1092 2012-07-08 Eli Zaretskii <eliz@gnu.org>
1094 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1095 has no font, use the frame's font. (Bug#11813)
1096 (display_line): Add commentary about displaying truncation glyphs
1098 (produce_special_glyphs): Move here from term.c.
1100 * term.c (produce_special_glyphs): Move to xdisp.c.
1102 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1105 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1107 * xdisp.c (display_line): Avoid warning about implicit declaration
1110 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1112 * lisp.h: Remove empty conditional.
1114 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1116 * lread.c (load_path_check): Now static.
1118 Fix some minor --with-ns problems found by static checking.
1119 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1120 (x_set_font) [!HAVE_X_WINDOWS]:
1121 * image.c (xpm_load_image) [HAVE_NS]:
1122 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1123 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1124 Remove unused local.
1125 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1126 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1127 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1128 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1129 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1130 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1131 Fix pointer signedness problem.
1132 * xfaces.c (FRAME_X_FONT_TABLE):
1133 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1135 2012-07-07 Glenn Morris <rgm@gnu.org>
1137 * lread.c (load_path_check): New function, split from init_lread.
1138 (init_lread): Reorganize. Motivation:
1139 If EMACSLOADPATH is set, check/warn about that rather than the
1140 defaults, which we are not going to use. Hence we can remove
1141 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1142 Don't warn if site-lisp directories are missing.
1143 If not installed, start from a blank load-path, since
1144 PATH_LOADSEARCH refers to the eventual installation directories.
1146 2012-07-07 Eli Zaretskii <eliz@gnu.org>
1148 Support truncation and continuation glyphs on GUI frames, when
1149 fringes are disabled. (Bug#11832)
1150 * xdisp.c (init_iterator): Get dimensions of truncation and
1151 continuation glyphs even if on GUI frames. Adjust
1152 it->last_visible_x on GUI frames when the left or right fringes,
1153 or both, are absent.
1154 (start_display, move_it_in_display_line_to): Handle the case of a
1155 GUI frame without a fringe to display continuation or truncation
1157 (insert_left_trunc_glyphs): Support GUI frames: make sure
1158 truncation glyphs overwrite enough glyphs from the current line to
1159 have sufficient space in pixels.
1160 (display_line): Support truncation and continuation glyphs on GUI
1161 frames. If some spare pixels are left on the line after inserting
1162 the truncation glyphs, fill that space with a stretch glyph of a
1163 suitably computed width.
1165 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1166 produce_glyphs, to support GUI sessions.
1168 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1170 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1172 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1174 Do not require float-time's arg to fit in time_t (Bug#11825).
1175 This works better on hosts where time_t is unsigned, and where
1176 float-time is applied to the (negative) difference between two times.
1177 * editfns.c (decode_time_components): Last arg is now double *,
1178 not int *, and means to store all the result as a double, without
1179 worrying about whether the seconds part fits in time_t.
1180 All callers changed.
1181 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1182 All callers changed.
1183 (Ffloat_time): Do not fail merely because the specified time falls
1184 outside of time_t range.
1186 2012-07-07 Glenn Morris <rgm@gnu.org>
1188 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1189 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1190 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1192 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
1194 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1195 Update dependencies.
1197 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1199 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1201 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1202 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1203 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1204 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1205 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1206 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1208 * xfont.c (compare_font_names): Redo to omit the need for casts.
1210 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1212 * xfns.c (Fx_change_window_property): Doc fix.
1213 * w32fns.c (Fx_change_window_property): Doc fix.
1215 * w32fns.c (Fx_window_property): Accept the same arguments as the
1216 X Windows version. Doc fix.
1217 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1219 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
1220 Eli Zaretskii <eliz@gnu.org>
1222 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1223 Windows-specific code from nt/config.nt moved here.
1224 Obsolete settings removed.
1226 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1228 * process.c: Avoid unnecessary calls to gettime.
1229 (wait_reading_process_output): Don't get the time of day
1230 when gobbling data immediately and not waiting, as there's no need
1231 for it in that case. This removes a FIXME.
1233 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1235 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1236 is defined (Bug#11768).
1238 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1240 Fix marker debugging code.
1241 * marker.c (byte_char_debug_check): Do not perform the check
1242 if buffer is not multibyte.
1243 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1244 Call byte_char_debug_check with correct arguments.
1246 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1248 Compile marker debugging code only if ENABLE_CHECKING is defined.
1249 * marker.c (byte_char_debug_check, count_markers):
1250 Use only if ENABLE_CHECKING is defined.
1251 (byte_debug_flag): Remove.
1252 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1253 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1255 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1257 Avoid code repetition in marker-related functions.
1258 * marker.c (attach_marker): New function.
1259 (Fset_marker, set_marker_restricted, set_marker_both)
1260 (set_marker_restricted_both): Use it.
1261 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1262 Consistently rename charno to charpos.
1263 (marker_position): Add eassert.
1264 (marker_byte_position): Convert to eassert.
1266 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1268 Simplify list operations in unchain_overlay and unchain_marker.
1269 * buffer.c (unchain_overlay): Simplify. Add comment.
1270 * marker.c (unchain_marker): Simplify. Fix comments.
1272 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1274 Introduce fast path for the widely used marker operation.
1275 * alloc.c (build_marker): New function.
1276 * lisp.h (build_marker): New prototype.
1277 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1278 * composite.c (autocmp_chars): Likewise.
1279 * editfns.c (buildmark): Remove.
1280 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1281 (save_restriction_save): Use build_marker.
1282 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1283 * window.c (save_window_save): Likewise.
1285 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1287 Do not use Fdelete_overlay in delete_all_overlays
1288 to avoid redundant calls to unchain_overlay.
1289 * buffer.c (drop_overlay): New function.
1290 (delete_all_overlays, Fdelete_overlay): Use it.
1291 * minibuf.c (get_minibuffer): Fix comment.
1293 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1295 Port to OpenBSD 5.1 amd64.
1296 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1297 This is needed for OpenBSD, and should be harmless on all BSD systems.
1298 Also, include <sys/sysctl.h>, as it should be available on all
1299 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1300 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1301 use p_pid member, not kp_proc.pid.
1303 2012-07-06 Glenn Morris <rgm@gnu.org>
1305 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1307 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1309 More xmalloc and related cleanup.
1310 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1311 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1312 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1313 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1314 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1315 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1316 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1317 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1318 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1320 Omit needless casts involving void * pointers and allocation.
1321 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1322 as the former is more robust if P's type is changed.
1323 Prefer xzalloc to xmalloc + memset 0.
1324 Simplify malloc-or-realloc to realloc.
1325 Don't worry about xmalloc returning a null pointer.
1326 Prefer xstrdup to xmalloc + strcpy.
1327 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1329 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1330 alloca of a constant.
1332 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1334 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1335 hscroll is larger than the line width. Fixes long and futile
1336 looping inside extend_face_to_end_of_line (on a TTY) producing
1337 glyphs that are not needed and thrown away.
1339 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1341 * marker.c (set_marker_restricted_both): Simplify by using
1344 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1346 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1348 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1350 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1351 not defined (Bug#11768).
1352 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1353 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1354 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1355 followed by gtk_box_set_homogeneous (Bug#11768).
1356 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
1357 (update_theme_scrollbar_width, xg_create_scroll_bar):
1358 Use gtk_scrollbar_new (Bug#11768).
1359 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1360 (is_box_type): New function (Bug#11768).
1361 (xg_tool_item_stale_p): Call is_box_type.
1362 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
1363 with default display (Bug#11768).
1365 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1367 * xdisp.c (window_hscroll_limited): New function.
1368 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1369 coordinates when window's hscroll is set to insanely large
1372 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
1374 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1375 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1377 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1380 * lisp.h (xzalloc): New prototype. Omit needless casts.
1381 * alloc.c (xzalloc): New function. Omit needless casts.
1382 * charset.c: Omit needless casts. Convert all calls to
1383 xmalloc with following memset to xzalloc.
1384 * dispnew.c: Likewise.
1385 * fringe.c: Likewise.
1386 * image.c: Likewise.
1387 * sound.c: Likewise.
1389 * w32fns.c: Likewise.
1390 * w32font.c: Likewise.
1391 * w32term.c: Likewise.
1392 * xfaces.c: Likewise.
1394 * xterm.c: Likewise.
1395 * atimer.c: Omit needless casts.
1396 * buffer.c: Likewise.
1397 * callproc.c: Likewise.
1399 * coding.c: Likewise.
1400 * composite.c: Likewise.
1402 * doprnt.c: Likewise.
1403 * editfns.c: Likewise.
1404 * emacs.c: Likewise.
1406 * filelock.c: Likewise.
1408 * gtkutil.c: Likewise.
1409 * keyboard.c: Likewise.
1411 * lread.c: Likewise.
1412 * minibuf.c: Likewise.
1413 * msdos.c: Likewise.
1414 * print.c: Likewise.
1415 * process.c: Likewise.
1416 * region-cache.c: Likewise.
1417 * search.c: Likewise.
1418 * sysdep.c: Likewise.
1419 * termcap.c: Likewise.
1420 * terminal.c: Likewise.
1421 * tparam.c: Likewise.
1422 * w16select.c: Likewise.
1424 * w32reg.c: Likewise.
1425 * w32select.c: Likewise.
1426 * w32uniscribe.c: Likewise.
1427 * widget.c: Likewise.
1428 * xdisp.c: Likewise.
1429 * xmenu.c: Likewise.
1431 * xselect.c: Likewise.
1433 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1435 * fileio.c (time_error_value): Check the right error number.
1436 Problem reported by Troels Nielsen in
1437 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1439 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1441 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1442 This should be fixed in a better way; see Eli Zaretskii in
1443 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1444 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1446 * fileio.c (time_error_value): Rename from special_mtime.
1447 The old name's problems were noted by Eli Zaretskii in
1448 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1450 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1451 This variable's comment says Emacs needs at least one GDB-visible
1452 symbol of type enum pvec_type, to work around GDB problems.
1453 The symbol's value doesn't matter.
1455 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1456 that causes compilation to fail on pre-C99 compilers.
1458 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
1460 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1461 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1463 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1465 * buffer.c (init_buffer_once): Fix initialization of
1466 headers for buffer_defaults and buffer_local_symbols.
1467 Reported by Juanma Barranquero <lekktu@gmail.com>.
1469 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1471 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1472 * lisp.h (enum pvec_type): Use fewer bits.
1473 (PSEUDOVECTOR_SIZE_BITS): New constant.
1474 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1475 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1476 change in pvec_type.
1477 (PSEUDOVECTOR_TYPEP): New macro.
1478 (TYPED_PSEUDOVECTORP): Use it.
1479 * fns.c (internal_equal): Adapt code to extract pvectype.
1480 * emacs.c (gdb_pvec_type): Update type.
1481 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1482 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1483 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1484 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1485 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1486 abusing vector->header.next.nbytes.
1487 (live_vector_p): Use PVEC_TYPE.
1488 (mark_object): Adapt code to extract pvectype. Use switch.
1490 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1492 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1493 Tighten new eassert a bit.
1495 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1497 Fix compilation with --enable-gcc-warnings and -O1
1499 * doprnt.c (doprnt): Change type of tem to int, initialize
1500 to avoid compiler warning. Add eassert.
1501 * search.c (simple_search): Initialize match_byte to avoid
1502 compiler warning. Add eassert.
1504 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1506 Avoid weird behavior with large horizontal scrolls.
1507 Without this change, for example, large hscroll values would
1508 mess up Emacs's display on Fedora 15 x86, presumably due to
1509 overflows in int calculations in the display code.
1510 Also, if buffers had long lines, Emacs would freeze.
1511 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1512 (set_window_hscroll): New function, containing the old guts of
1513 Fset_window_hscroll. Return the clipped value.
1514 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1515 This avoids the need to check against PTRDIFF_MAX.
1517 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1519 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1521 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1523 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1525 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1526 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1527 since GCC 4.4.6 issues a bogus warning for them.
1529 Fix bugs in file timestamp newness comparisons.
1530 * fileio.c (Ffile_newer_than_file_p):
1531 * lread.c (Fload): Use full timestamp resolution of files,
1532 not just the 1-second resolution, so that files that are only
1533 slightly newer still count as newer.
1534 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1535 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1537 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1539 * fileio.c: Improve handling of file time marker. (Bug#11852)
1540 (special_mtime): New function.
1541 (Finsert_file_contents, Fverify_visited_file_modtime):
1542 Use it to set special mtime values consistently.
1544 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1546 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1547 marker for non-existing file. (Bug#11852)
1549 2012-07-03 Glenn Morris <rgm@gnu.org>
1551 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1552 and did not make it into globals.h).
1554 2012-07-03 Tom Tromey <tromey@redhat.com>
1556 * window.c (Fset_window_margins, Fset_window_fringes)
1557 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1558 * textprop.c (Fprevious_property_change): No longer static.
1559 * syntax.c (Fsyntax_table_p): No longer static.
1560 * process.c (Fget_process, Fprocess_datagram_address): No longer
1562 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1563 * keyboard.c (Fcommand_execute): No longer static.
1565 * insdel.c (Fcombine_after_change_execute): No longer static.
1566 * image.c (Finit_image_library): No longer static.
1567 * fileio.c (Fmake_symbolic_link): No longer static.
1568 * eval.c (Ffetch_bytecode): No longer static.
1569 * editfns.c (Fuser_full_name): No longer static.
1570 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1572 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1574 * dired.c (Ffile_attributes): No longer static.
1575 * composite.c (Fcomposition_get_gstring): No longer static.
1576 * callproc.c (Fgetenv_internal): No longer static.
1578 * ccl.h: Remove EXFUNs.
1579 * buffer.h: Remove EXFUNs.
1580 * dispextern.h: Remove EXFUNs.
1581 * intervals.h: Remove EXFUNs.
1582 * fontset.h: Remove EXFUN.
1583 * font.h: Remove EXFUNs.
1584 * dosfns.c (system_process_attributes): Remove EXFUN.
1585 * keymap.h: Remove EXFUNs.
1586 * lisp.h: Remove EXFUNs.
1587 * w32term.h: Remove EXFUNs.
1588 * window.h: Remove EXFUNs.
1589 * xsettings.h: Remove EXFUN.
1590 * xterm.h: Remove EXFUN.
1592 2012-07-03 Glenn Morris <rgm@gnu.org>
1594 * lisp.h (Frandom): Make it visible to C.
1595 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1596 buffer for invisible buffers. (Bug#1229)
1598 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1600 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1601 values which aren't power of 2.
1602 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1603 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1606 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1608 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1610 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1612 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1614 * alloc.c (allocate_vector_block): Remove redundant
1615 calls to mallopt if DOUG_LEA_MALLOC is defined.
1616 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1617 avoid calls to mallopt if zero_vector is returned.
1619 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1621 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1622 is enabled, avoid dereferencing NULL current_sblock if
1625 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1627 Cleanup basic buffer management.
1628 * buffer.h (struct buffer): Change layout to use generic vector
1629 marking code. Fix some comments. Change type of 'clip_changed'
1630 to bitfield. Remove unused #ifndef old.
1631 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1632 (GET_OVERLAYS_AT): Fix indentation.
1633 (for_each_per_buffer_object_at): New macro.
1634 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1635 (Fbuffer_local_variables): Use it.
1636 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1637 * alloc.c (allocate_buffer): Adjust to match new layout of
1638 struct buffer. Fix comment.
1639 (mark_overlay): New function.
1640 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1641 Lisp area of struct buffer.
1642 (mark_object): Use it. Adjust marking of misc objects
1643 and related comments.
1645 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1647 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1648 wrapper that is not needed because the wrapped code is a no-op (zero
1649 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1650 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1652 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1654 * alloc.c (mark_buffer): Simplify. Remove prototype.
1655 (mark_object): Add comment. Reorganize marking of vector-like
1656 objects. Use CHECK_LIVE for all vector-like objects except buffers
1657 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1658 redundant calls to mark_vectorlike for bool vectors.
1660 2012-06-30 Glenn Morris <rgm@gnu.org>
1662 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1664 * epaths.in (PATH_SITELOADSEARCH): New.
1665 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1666 This is rather than relying on --enable-locallisppath elements
1667 having "site-lisp" in their names. (Bug#10208#25, 11658)
1669 2012-06-30 Eli Zaretskii <eliz@gnu.org>
1671 * w32proc.c (sys_select): Accept and ignore one more argument.
1673 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1675 * sysselect.h [DOS_NT]: Don't include sys/select.h.
1676 (pselect) [!MS_DOS]: Redirect to sys_select.
1678 * sysdep.c: Don't include dos.h and dosfns.h.
1680 * process.c (sys_select):
1681 * msdos.c (sys_select): Accept one more argument and ignore it.
1683 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1684 adapt data types and code to that.
1687 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1688 which clashes with the gnulib function of the same name.
1690 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1692 * font.c (font_style_to_value, font_style_symbolic)
1693 (font_prop_validate_style): Add type checks for values in
1696 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1698 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1701 2012-06-29 Eli Zaretskii <eliz@gnu.org>
1703 * xdisp.c (try_window_id): Undo last change.
1705 * w32.c (getwd): Adjust commentary about startup_dir.
1706 (init_environment): Always call sys_access, even in non-MSVC
1707 builds. Don't chdir to the directory of the Emacs executable.
1708 This undoes code from 1997 which was justified by the need to
1709 "avoid conflicts when removing and renaming directories". But its
1710 downside was that every relative file name was being interpreted
1711 relative to the directory of the Emacs executable, which can never
1712 be TRT. In particular, it broke sys_access when called with
1713 relative file names.
1714 (sys_access): Map GetLastError to errno.
1716 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1718 * window.h (struct window): Change type of 'fringes_outside_margins'
1719 to bitfield. Fix comment. Adjust users accordingly.
1720 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
1722 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1725 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
1727 * gnutls.c (emacs_gnutls_handshake):
1728 Add QUIT to make the loop interruptible.
1730 2012-06-29 Glenn Morris <rgm@gnu.org>
1732 * charset.c (init_charset): Make lack of etc/charsets fatal.
1734 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1736 * editfns.c (region_limit): Fix type mismatch.
1738 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1740 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1741 undefined. Convert from xassert to eassert.
1742 * nsmenu.m: Convert from xassert to eassert.
1743 * nsterm.m: Likewise.
1745 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1747 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1749 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1751 Avoid integer overflow on scroll-left and scroll-right.
1752 * window.c (HSCROLL_MAX): New macro.
1753 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1754 overflow when requested scroll falls outside ptrdiff_t range.
1756 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1758 * window.h (struct window): Change type of 'hscroll',
1759 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1760 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1761 Adjust users accordingly.
1762 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1763 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1764 from EMACS_INT to ptrdiff_t.
1765 (make_window): Omit redundant initialization.
1767 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
1769 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1771 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1773 * window.h (struct window): Change type of 'use_time' and
1774 'sequence_number' from Lisp_Object to int.
1775 * frame.c (make_frame): Adjust users accordingly.
1776 * print.c (print_object): Likewise.
1777 * window.c (select_window, Fwindow_use_time, make_parent_window)
1778 (make_window): Likewise.
1780 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1782 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1783 enabled with --enable-checking=[all,glyphs] configure option.
1784 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1785 adjust comments accordingly.
1786 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1787 undefined, adjust comments accordingly.
1788 * image.c: Likewise.
1789 * scroll.c: Likewise.
1790 * w32fns.c: Likewise.
1791 * w32term.c: Likewise.
1792 * xdisp.c: Likewise.
1793 * xfaces.c: Likewise.
1795 * xterm.c: Likewise.
1797 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1799 Generalize run-time debugging checks.
1800 * dispextern.h (XASSERTS): Remove.
1801 * fontset.c (xassert): Remove.
1802 Convert from xassert to eassert.
1803 * alloc.c: Convert from xassert to eassert.
1805 * dispnew.c: Likewise.
1807 * fringe.c: Likewise.
1808 * ftfont.c: Likewise.
1809 * gtkutil.c: Likewise.
1810 * image.c: Likewise.
1811 * keyboard.c: Likewise.
1813 * process.c: Likewise.
1814 * scroll.c: Likewise.
1815 * sound.c: Likewise.
1817 * w32console.c: Likewise.
1818 * w32fns.c: Likewise.
1819 * w32term.c: Likewise.
1820 * window.c: Likewise.
1821 * xdisp.c: Likewise.
1822 * xfaces.c: Likewise.
1824 * xselect.c: Likewise.
1825 * xterm.c: Likewise.
1827 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1829 * fns.c (maybe_resize_hash_table): Output message when growing the
1832 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1834 * alloc.c (allocate_string_data): Remove dead code.
1835 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1836 avoid GCC warning about unused macro.
1838 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1840 * alloc.c (allocate_string): Omit intervals initialization.
1841 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1842 as in make_pure_string and make_pure_c_string.
1844 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1846 * alloc.c (allocate_string): Fix last change.
1848 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1850 * alloc.c (allocate_string): Remove two redundant calls
1851 to memset, add explicit initialization where appropriate.
1853 2012-06-27 Glenn Morris <rgm@gnu.org>
1855 * lisp.mk (lisp): Remove paths.elc.
1857 2012-06-27 Chong Yidong <cyd@gnu.org>
1859 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1861 2012-06-26 John Wiegley <johnw@newartisans.com>
1863 * unexmacosx.c (copy_data_segment): Add two section names used
1864 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1866 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1867 when building with Clang.
1869 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1871 * eval.c (Fapply): Allow calling it with a single argument.
1873 2012-06-26 Eli Zaretskii <eliz@gnu.org>
1875 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1876 _stricmp and _strnicmp.
1877 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1879 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1881 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1883 (allocate_process): Likewise for new process.
1884 (allocate_terminal): Change to use offsetof.
1885 (allocate_frame): Likewise.
1886 * frame.c (make_frame): Omit redundant initialization.
1887 * window.c (make_parent_window): Use memset.
1888 (make_window): Omit redundant initialization.
1889 * process.c (make_process): Omit redundant initialization.
1890 * terminal.c (create_terminal): Likewise.
1892 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1894 * term.c (delete_tty): Remove redundant call to memset.
1896 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1898 * alloc.c: Remove build_string.
1899 * lisp.h: Define build_string as static inline. This provides
1900 a better opportunity to optimize away calls to strlen when the
1901 function is called with compile-time constant argument.
1902 * image.c (imagemagick_error): Convert to build_string.
1903 * w32proc.c (sys_spawnve): Likewise.
1904 * xterm.c (x_term_init): Likewise.
1906 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1908 Use sprintf return value instead of invoking strlen on result.
1909 In the old days this wasn't portable, since some sprintf
1910 implementations returned char *. But they died out years ago and
1911 Emacs already assumes sprintf returns int.
1912 Similarly for float_to_string.
1913 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1914 * ccl.c (ccl_driver):
1915 * character.c (string_escape_byte8):
1916 * data.c (Fnumber_to_string):
1917 * doprnt.c (doprnt):
1918 * print.c (print_object):
1919 * xdisp.c (message_dolog):
1920 * xfns.c (syms_of_xfns):
1921 Use sprintf or float_to_string result to avoid need to call strlen.
1922 * data.c (Fnumber_to_string):
1923 Use make_unibyte_string, since the string must be ASCII.
1924 * lisp.h, print.c (float_to_string): Now returns int length.
1925 * term.c (produce_glyphless_glyph):
1926 Use sprintf result rather than recomputing it.
1928 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1929 * Makefile.in (ALL_CFLAGS):
1930 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1931 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1933 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1935 * dispextern.h (xstrcasecmp): Define to library function
1936 strcasecmp if available.
1937 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1939 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1941 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1942 Avoid comma operator.
1943 * menu.c (push_submenu_start, push_submenu_end)
1944 (push_left_right_boundary, push_menu_pane): Likewise.
1945 * msdos.c (dos_rawgetc): Likewise.
1947 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1949 * xfns.c (xic_create_fontsetname): Remove redundant calls
1952 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1954 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1955 sprintf already null-terminates its output.
1957 * xfns.c (x_window): Remove redundant cast.
1959 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1961 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1962 `const char *' to `char *' to avoid compiler warning.
1964 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1966 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1967 instead of truncating it to 63 (admittedly a generous limit).
1969 * process.c: Fix spelling and caps in comments.
1971 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1973 * emacs.c (setpgrp): Remove definition, unused.
1974 * sysdep.c (setpgrp): Remove definition, not used in this file.
1976 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
1978 * makefile.w32-in: Update dependencies.
1980 2012-06-24 Eli Zaretskii <eliz@gnu.org>
1982 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1983 (SYSTIME_H): Add nt/inc/sys/time.h.
1985 * systime.h [WINDOWSNT]: Include sys/time.h.
1987 * s/ms-w32.h (struct timespec): Definition moved from
1988 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1990 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1992 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1993 * buffer.h (buffer_slot_type_mismatch):
1994 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1995 * eval.c (unwind_to_catch):
1996 * image.c (my_png_error, my_error_exit):
1997 * keyboard.c (quit_throw_to_read_char, user_error)
1998 (Fexit_recursive_edit, Fabort_recursive_edit):
1999 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2000 (wrong_type_argument, buffer_overflow, __executable_start)
2001 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2002 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2003 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2005 (child_setup) [!DOS_NT]:
2006 * lread.c (end_of_file_error, invalid_syntax):
2007 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2008 * puresize.h (pure_write_error):
2009 * search.c (matcher_overflow):
2010 * sound.c (sound_perror, alsa_sound_perror):
2011 * sysdep.c, syssignal.h (croak):
2012 * term.c (maybe_fatal, vfatal):
2013 * textprop.c (text_read_only):
2014 * undo.c (user_error):
2015 * unexmacosx.c (unexec_error):
2016 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2017 Use _Noreturn rather than NO_RETURN.
2018 No need for separate decl merely because of _Noreturn.
2019 * sound.c (sound_warning, parse_sound):
2020 Remove unnecessary forward decls.
2022 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2024 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2025 * lisp.h (WAIT_READING_MAX): New macro.
2026 * dispnew.c (Fsleep_for, sit_for):
2027 * keyboard.c (kbd_buffer_get_event):
2028 * process.c (Faccept_process_output):
2029 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2030 This improves on the previous patch, which introduced a bug
2031 when time_t is unsigned and as wide as intmax_t.
2032 See <http://bugs.gnu.org/9000#51>.
2034 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2036 * dispnew.c (sit_for, Fsleep_for):
2037 * keyboard.c (kbd_buffer_get_event):
2038 * process.c (Faccept_process_output): Avoid compiler warnings when
2039 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2041 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
2043 * makefile.w32-in: Update dependencies.
2045 * w32.c (ltime): Add return type and declare static.
2046 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2048 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2050 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2051 Privately reported by Herbert J. Skuhra.
2052 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2054 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2055 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2057 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2059 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2060 last argument of make_unibyte_string.
2062 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2063 language ID in the event parameters.
2065 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2066 event.code, not the obscure "character set ID".
2068 2012-06-23 Chong Yidong <cyd@gnu.org>
2070 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2072 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2074 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2075 * w32.c (fdutimens): New function.
2077 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2079 * s/ms-w32.h (pselect): Redirect to sys_select.
2081 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2083 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2084 in the logic of incrementing and decrementing the value of
2085 use_relocatable_buffers.
2087 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2089 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2090 Privately reported by Herbert J. Skuhra.
2091 [__FreeBSD__]: Remove "*/" typo after "#include".
2092 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2093 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2094 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2095 Don't assume EMACS_TIME and struct timeval are the same type.
2097 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2099 Support higher-resolution time stamps (Bug#9000).
2100 The time stamps are only nanosecond-resolution at the C level,
2101 since that's the best that any real-world system supports now.
2102 But they are picosecond-resolution at the Lisp level, as that's
2103 easy, and leaves room for future OS improvements.
2105 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2108 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2109 Don't get current time unless it's needed.
2111 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2112 now provides it if it's absent.
2113 (start_atimer): Port to higher-res time stamps.
2114 Check for time stamp overflow. Don't get current time more
2115 often than is needed.
2117 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2118 Include systime.h, not time.h.
2119 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2121 * dired.c: Include stat-time.h.
2122 (Ffile-attributes): File times now have higher resolution.
2124 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2125 (struct image): Timestamp now has higher resolution.
2127 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2128 has at least microseconds now. All uses removed.
2129 (update_frame, update_single_window, update_window, update_frame_1)
2130 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2132 * editfns.c (time_overflow): Now extern.
2133 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2134 (float-time, Fformat_time_string, Fcurrent_time_string)
2135 (Fcurrent_time_zone): Accept and generate higher-resolution
2137 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2138 (decode_time_components, lisp_seconds_argument): New functions.
2139 (make_time): Now static.
2140 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2141 Report an error if the time is invalid, rather than having the caller
2144 * fileio.c: Include <stat-time.h>
2145 (Fcopy_file): Copy higher-resolution time stamps.
2146 Prefer to set the time stamp via a file descriptor if that works.
2147 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2148 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2149 (Fvisited_file_modtime, Fset_visited_file_modtime):
2150 Support higher-resolution time stamps.
2152 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2154 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2156 * image.c (prepare_image_for_display, clear_image_cache)
2157 (lookup_image): Port to higer-resolution time stamps.
2159 * keyboard.c (start_polling, bind_polling_period):
2160 Check for time stamp overflow.
2161 (read_char, kbd_buffer_get_event, timer_start_idle)
2162 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2163 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2164 Port to higher-resolution time stamps. Do not assume time_t is signed.
2165 (decode_timer): New function. Timers are now vectors of length 9,
2166 not 8, to accommodate the picosecond component.
2167 (timer_check_2): Use it.
2169 * nsterm.m (select_timeout, timeval_subtract): Remove.
2170 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2171 as they're a bit more accurate and handle overflow better.
2172 (ns_select): Change prototype to be compatible with pselect.
2173 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2174 * nsterm.h (ns_select): Adjust prototype.
2176 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2177 us-resolution time stamps.
2178 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2180 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2182 * lisp.h (time_overflow): New decl.
2183 (wait_reading_process_output): First arg is now intmax_t, not int,
2184 to accommodate larger waits.
2186 * process.h (struct Lisp_Process.read_output_delay):
2187 Now counts nanoseconds, not microseconds.
2188 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2190 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2191 (wait_reading_process_output):
2192 Port to ns-resolution time stamps.
2193 (Faccept_process_output, wait_reading_process_output):
2194 Check for time stamp overflow. Do not assume time_t is signed.
2195 (select_wrapper): Remove; we now use pselect.
2196 (Fprocess_attributes): Now generates ns-resolution time stamps.
2198 * sysdep.c: Include utimens.h. Don't include utime.h
2199 or worry about struct utimbuf; gnulib does that for us now.
2200 (gettimeofday): Remove; gnulib provides a substitute.
2201 (make_timeval): New function.
2202 (set_file_times): Now sets ns-resolution time stamps.
2203 New arg FD; all uses changed.
2204 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2205 (system_process_attributes):
2206 Now returns ns-resolution time stamp. All uses changed.
2207 Check for time stamp overflow.
2209 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2210 provides a substitute now.
2212 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2213 since it guarantees struct timespec.
2214 (EMACS_TIME): Now struct timespec, so that we can support
2215 ns-resolution time stamps.
2216 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2217 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2218 (EMACS_USECS): Remove.
2219 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2220 so multiply the arg by 1000 before storing it.
2221 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2223 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2224 Port to ns-resolution time stamps.
2225 (EMACS_TIME_NEG_P): Remove; replaced by....
2226 (EMACS_TIME_SIGN): New macro.
2227 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2228 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2229 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2230 (make_timeval, make_lisp_time, decode_time_components): New decls.
2231 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2232 that it mishandled time_t overflow. You can't compare by subtracting!
2233 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2234 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2236 * term.c: Include <sys/time.h>.
2237 (timeval_to_Time): New function, for proper overflow wraparound.
2238 (term_mouse_position, term_mouse_click): Use it.
2240 * undo.c (record_first_change): Support higher-resolution time stamps
2242 (Fprimitive_undo): Use them when restoring time stamps.
2244 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2245 (w32_get_internal_run_time):
2246 Port to higher-resolution Emacs time stamps.
2247 (ltime): Now accepts single 64-bit integer, as that's more convenient
2250 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2252 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2253 for compatibility with pselect. Support ns-resolution time stamps.
2255 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2257 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2258 Check for time stamp overflow, and support ns-resolution time stamps.
2260 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2261 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2262 (timeval_subtract): Remove; no longer needed.
2263 (XTflash, XTring_bell, x_wait_for_event):
2264 Port to ns-resolution time stamps. Don't assume time_t is signed.
2266 2012-06-22 Chong Yidong <cyd@gnu.org>
2268 * xdisp.c (x_consider_frame_title): Revert last change.
2270 2012-06-22 Eli Zaretskii <eliz@gnu.org>
2272 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2273 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2274 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2275 staticidx goes up to 1597 out of 1600 = 0x640.)
2277 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2279 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2280 Otherwise, the umask might be mistakenly 0 while handling input signals.
2282 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2284 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2286 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2288 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2289 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2290 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2291 access to `contents' member of Lisp_Vector objects with AREF and ASET
2294 2012-06-19 Chong Yidong <cyd@gnu.org>
2296 * frame.c (delete_frame): When selecting a frame on a different
2297 text terminal, do not alter the terminal's top-frame.
2299 * xdisp.c (format_mode_line_unwind_data): Record the target
2300 frame's selected window and its terminal's top-frame.
2301 (unwind_format_mode_line): Restore them.
2302 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2304 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2305 since tty frames can be explicitly named.
2306 (prepare_menu_bars): Likewise.
2308 * term.c (Ftty_top_frame): New function.
2310 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2312 Port byte-code-meter to modern targets.
2313 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2314 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
2315 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
2316 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2317 (METER_1, METER_2): Simplify.
2319 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2321 * data.c (Fdefalias): Return `symbol' (bug#11686).
2323 2012-06-18 Martin Rudalics <rudalics@gmx.at>
2325 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
2326 gets killed during executing of this function (Bug#11665).
2327 Try to always return Qt when the buffer has been actually killed.
2328 (Vkill_buffer_query_functions): In doc-string say that functions
2329 run by this hook should not change the current buffer.
2331 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2333 Fix recently-introduced process.c problems found by static checking.
2334 * process.c (write_queue_push, write_queue_pop, send_process):
2335 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2336 (write_queue_pop): Fix pointer signedness problem.
2337 (send_process): Remove unused local.
2339 2012-06-17 Chong Yidong <cyd@gnu.org>
2341 * xdisp.c (redisplay_internal): No need to redisplay terminal
2342 frames that are not on top.
2344 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
2346 * process.c (make_process): Initialize write_queue.
2347 (write_queue_push, write_queue_pop): New functions.
2348 (send_process): Use them to maintain correct ordering of process
2351 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2353 * lisp.h (eassert): Assume C89 or later.
2354 This removes the need for CHECK.
2355 (CHECK): Remove. Its comments about always evaluating its
2356 argument were confusing, as 'eassert' typically does not evaluate
2359 * coding.c (produce_chars): Use ptrdiff_t, not int.
2361 * xterm.c (x_draw_underwave): Check for integer overflow.
2362 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2364 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
2366 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2367 referenced (Bug#11583).
2369 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2371 Implement wave-style variant of underlining.
2372 * dispextern.h (face_underline_type): New enum.
2373 (face): Add field for underline type.
2374 * nsterm.m (ns_draw_underwave): New function.
2375 (ns_draw_text_decoration): Use it.
2376 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2378 (x_draw_glyph_string): Use them.
2379 * xfaces.c (Qline, Qwave): New Lisp objects.
2380 (check_lface_attrs, merge_face_ref)
2381 (Finternal_set_lisp_face_attribute, realize_x_face):
2382 Handle wave-style underline face attributes.
2383 * xterm.c (x_draw_underwave): New function.
2384 (x_draw_glyph_string): Use it.
2386 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
2388 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2389 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2390 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2391 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2392 ($(BLD)/w32select.$(O)): Update dependencies.
2394 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2396 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2397 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2398 * character.c (_fetch_multibyte_char_p): Remove.
2399 * alloc.c: Include "character.h" before "buffer.h".
2401 * buffer.c: Likewise.
2402 * bytecode.c: Likewise.
2403 * callint.c: Likewise.
2404 * callproc.c: Likewise.
2405 * casefiddle.c: Likewise.
2406 * casetab.c: Likewise.
2407 * category.c: Likewise.
2409 * coding.c: Likewise.
2410 * composite.c: Likewise.
2411 * dired.c: Likewise.
2412 * dispnew.c: Likewise.
2414 * dosfns.c: Likewise.
2415 * editfns.c: Likewise.
2416 * emacs.c: Likewise.
2417 * fileio.c: Likewise.
2418 * filelock.c: Likewise.
2420 * fontset.c: Likewise.
2421 * fringe.c: Likewise.
2422 * indent.c: Likewise.
2423 * insdel.c: Likewise.
2424 * intervals.c: Likewise.
2425 * keyboard.c: Likewise.
2426 * keymap.c: Likewise.
2427 * lread.c: Likewise.
2428 * macros.c: Likewise.
2429 * marker.c: Likewise.
2430 * minibuf.c: Likewise.
2431 * nsfns.m: Likewise.
2432 * nsmenu.m: Likewise.
2433 * print.c: Likewise.
2434 * process.c: Likewise.
2435 * regex.c: Likewise.
2436 * region-cache.c: Likewise.
2437 * search.c: Likewise.
2438 * syntax.c: Likewise.
2440 * textprop.c: Likewise.
2442 * unexsol.c: Likewise.
2443 * w16select.c: Likewise.
2444 * w32fns.c: Likewise.
2445 * w32menu.c: Likewise.
2446 * window.c: Likewise.
2447 * xdisp.c: Likewise.
2449 * xmenu.c: Likewise.
2451 * xselect.c: Likewise.
2453 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2455 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2456 If all the glyphs of the glyph row came from strings, and we have no
2457 cursor positioning clues, put the cursor on the first glyph of the
2459 (handle_face_prop): Use chunk-relative overlay string index when
2460 indexing into it->string_overlays array. (Bug#11653)
2461 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2462 the rightmost. (Bug#11720)
2464 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2466 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2467 (CATEGORY_MEMBER): Enforce 1/0 value.
2468 * category.c (_temp_category_set): Remove.
2470 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2472 * window.c (Fdelete_other_windows_internal)
2473 (Fdelete_window_internal): Don't access frame's mouse highlight
2474 info of the initial frame. (Bug#11677)
2476 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2478 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2479 Assume USE_2_TAGS_FOR_INTS.
2480 (xreload): Adjust $tagmask width to match recent lisp.h change.
2482 Simplify lisp.h in minor ways that should not affect code.
2483 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2484 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2485 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2486 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2487 (INTTYPEBITS): New macro, for clarity.
2488 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
2489 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2490 Simplify now that USE_LSB_TAG is always defined.
2491 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2492 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2494 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
2496 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2498 2012-06-13 Glenn Morris <rgm@gnu.org>
2500 * s/bsd-common.h (BSD4_3):
2501 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2503 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2505 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2508 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2510 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
2511 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
2512 * alloc.c (widen_to_Lisp_Object): Remove.
2513 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2514 * frame.c (delete_frame): Remove outdated comment.
2515 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2516 USE_LISP_UNION_TYPE.
2517 (Fw32_unregister_hot_key): Likewise.
2518 (Fw32_toggle_lock_key): Likewise.
2519 * w32menu.c (add_menu_item): Likewise.
2520 (w32_menu_display_help): Use XIL instead of checking
2521 USE_LISP_UNION_TYPE.
2522 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2523 (init_heap): Likewise.
2524 * w32term.c (w32_read_socket): Update comment.
2526 2012-06-13 Glenn Morris <rgm@gnu.org>
2528 * s/usg5-4-common.h, src/s/unixware.h:
2529 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2531 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2533 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2535 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2536 * alloc.c (make_number) [!defined make_number]:
2537 Remove, as lisp.h always defines this now.
2538 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2539 (roundup_size): Verify that it is a power of 2.
2540 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2541 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2542 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2543 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2544 USE_LSB_TAG now is always defined to be either 0 or 1.
2546 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2547 code works fine either way, and efficiency is not a concern here,
2548 as the union type is for debugging, not for production.
2549 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2550 Use an inline function on all platforms when using the union type,
2551 since this is simpler and 'static inline' can be used portably
2553 (LISP_INITIALLY_ZERO): New macro.
2554 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2555 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2557 2012-06-12 Glenn Morris <rgm@gnu.org>
2559 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2561 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
2563 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2564 Move BROKEN_SIGIO to configure.
2566 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2567 Move NO_TERMIO to configure.
2569 2012-06-12 Chong Yidong <cyd@gnu.org>
2571 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2572 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2573 MagickExportImagePixels is undefined.
2575 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2577 * image.c (imagemagick_load_image): Remove unused label.
2579 2012-06-11 Glenn Morris <rgm@gnu.org>
2581 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2582 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2583 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2584 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2586 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2588 * alloc.c (make_byte_code): New function.
2589 (Fmake_byte_code): Use it. Don't purify here.
2590 * lread.c (read1): Use it as well to avoid extra allocation.
2592 2012-06-11 Chong Yidong <cyd@gnu.org>
2594 * image.c (imagemagick_load_image): Implement transparency.
2596 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2598 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2599 account for preceding backslashes. (Bug#11663)
2601 2012-06-09 Chong Yidong <cyd@gnu.org>
2603 * term.c: Support italics in capable terminals (Bug#9652).
2604 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2605 (turn_on_face): Output using TS_enter_italic_mode if available.
2606 Don't handle unused blinking and alt-charset cases.
2607 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2608 and tty_alt_charset_p cases.
2609 (tty_capable_p, init_tty): Support italics.
2611 * termchar.h (struct tty_display_info): Add field for italics.
2612 Remove unused blink field.
2614 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2617 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2618 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2619 tty_alt_charset_p. Add tty_italic_p.
2621 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
2623 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2624 dbus_type_is_basic if available.
2625 (xd_extract_signed, xd_extract_unsigned): Rename from
2626 extract_signed and extract_unsigned, respectively. Adapt callers.
2628 2012-06-09 Chong Yidong <cyd@gnu.org>
2630 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2632 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2635 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2637 * xdisp.c (vmessage): Treat frame message as multibyte.
2638 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2639 would generate the diagnostic "Making \302\247 buffer-local while
2642 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2644 * dispnew.c (showing_window_margins_p): Undo last change, which
2645 was done due to an inadvertent commit.
2646 (adjust_frame_glyphs_for_frame_redisplay): Do call
2647 showing_window_margins_p.
2649 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2651 * eval.c (Fmake_var_non_special): New primitive.
2652 (syms_of_eval): Defsubr it.
2653 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2655 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
2657 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2658 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2660 2012-06-08 Eli Zaretskii <eliz@gnu.org>
2662 * alloc.c (allocate_vectorlike): Fix last change.
2664 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2666 Block-based vector allocation of small vectors.
2667 * lisp.h (struct vectorlike_header): New field `nbytes',
2668 adjust comment accordingly.
2669 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2670 to denote vector blocks. Adjust users (live_vector_p,
2671 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2672 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2673 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2674 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2675 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2676 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2677 (roundup_size): New constant.
2678 (struct vector_block): New data type.
2679 (vector_blocks, vector_free_lists, zero_vector): New variables.
2680 (all_vectors): Rename to `large_vectors'.
2681 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2682 (sweep_vectors): New functions.
2683 (allocate_vectorlike): Return `zero_vector' as the only vector of
2684 0 items. Allocate new vector from block if vector size is less than
2685 or equal to VBLOCK_BYTES_MAX.
2686 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2687 (init_alloc_once): Add call to init_vectors.
2689 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2691 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2693 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2695 * doprnt.c (doprnt): Truncate multibyte char correctly.
2696 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2697 would mishandle a string argument "Xc" if X was a multibyte
2698 character of length 2: it would truncate after X's first byte
2699 rather than including all of X.
2701 2012-06-06 Chong Yidong <cyd@gnu.org>
2703 * buffer.c (word_wrap): Doc fix.
2705 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2707 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2709 2012-06-03 Glenn Morris <rgm@gnu.org>
2711 * xdisp.c (tool-bar-style): Doc fix.
2713 2012-06-03 Ulrich Müller <ulm@gentoo.org>
2715 * Makefile.in (PAXCTL): Define.
2716 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2717 binary via PaX flags if the paxctl utility is available.
2718 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2719 Restore PaX flags to their default. (Bug#11398)
2721 2012-06-03 Chong Yidong <cyd@gnu.org>
2723 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2726 2012-06-03 Chong Yidong <cyd@gnu.org>
2728 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2729 (note_mode_line_or_margin_highlight): If there is no help echo,
2730 use mode-line-default-help-echo. Handle the case where the mouse
2731 position is past the end of the mode line string.
2733 * buffer.c (buffer_local_value_1): New function, split from
2734 Fbuffer_local_value; can return Qunbound.
2735 (Fbuffer_local_value): Use it.
2736 (Vmode_line_format): Docstring tweaks.
2738 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2740 * sysdep.c (system_process_attributes): Improve comment.
2742 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2744 * keyboard.c: Export real-this-command to Elisp.
2745 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2746 and DEFVAR it. Update all users.
2748 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2750 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2752 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2753 Convert pctcpu and pctmem to Lisp float properly.
2754 Let the compiler fold better, as 100.0/0x8000 is exact.
2756 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2758 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2761 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2763 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2765 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2767 For a 'struct window', replace some Lisp_Object fields to
2768 bitfields where appropriate, remove unused fields.
2769 * window.h (struct window): Remove unused 'last_mark_x' and
2770 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2771 change it's type from Lisp_Object to bitfield.
2772 Change type of 'force_start', 'optional_new_start',
2773 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2774 fields from Lisp_Object to bitfield. Adjust users accordingly.
2776 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2778 Pacify gcc -Wdouble-precision when using Xaw.
2779 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2780 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2781 Use 'float' consistently, rather than 'float' in most places
2782 and 'double' in a couple of places.
2784 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2786 * xdisp.c (handle_stop): Detect whether we have overlay strings
2787 loaded by testing it->current.overlay_string_index to be
2788 non-negative, instead of checking whether n_overlay_strings is
2789 positive. (Bug#11587)
2791 2012-05-31 Chong Yidong <cyd@gnu.org>
2793 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2795 * doc.c (Fsubstitute_command_keys): Doc fix.
2797 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2799 * search.c (search_buffer): Remove calls to
2800 r_alloc_inhibit_buffer_relocation, as it is now called by
2801 maybe_unify_char, which was the cause of relocation of buffer text
2804 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2806 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2807 for the duration of call to load_charset, to avoid problems with
2808 callers of maybe_unify_char that access buffer text through C
2811 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2812 decrement the inhibition flag, instead of just setting or
2815 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2817 Remove obsolete '#define static' cruft.
2818 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2819 This #undef was "temporary" in 2000; it is no longer needed
2820 now that '#define static' has gone away.
2821 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2822 (gray_bitmap_bits): Remove; no longer needed.
2823 All uses replaced with definiens.
2824 * xterm.c: Include "bitmaps/gray.xbm".
2826 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2828 Clean up __executable_start, monstartup when --enable-profiling.
2829 The following changes affect the code only when profiling.
2830 * dispnew.c (__executable_start): Rename from safe_bcopy.
2831 Define only on platforms that need it.
2832 * emacs.c: Include <sys/gmon.h> when profiling.
2833 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2834 (__executable_start): Remove decl, since lisp.h does it now.
2835 (safe_bcopy): Remove decl; no longer has that name.
2836 (main): Coalesce #if into single bit of code, for simplicity.
2837 Cast pointers to uintptr_t, since standard libraries want integers
2839 * lisp.h (__executable_start): New decl.
2841 2012-05-31 Glenn Morris <rgm@gnu.org>
2843 * image.c (Fimagemagick_types): Doc fix.
2845 2012-05-30 Jim Meyering <meyering@redhat.com>
2847 * callproc.c (Fcall_process_region): Include directory component
2848 in mkstemp error message (Bug#11586).
2850 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2852 * alloc.c, lisp.h (make_pure_vector): Now static.
2854 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2856 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2857 Move to byte-run.el.
2858 (Fautoload): Do the hash-doc more carefully.
2859 * data.c (Fdefalias): Purify definition, except for keymaps.
2860 (Qdefun): Move from eval.c.
2861 * lisp.h (Qdefun): Remove.
2862 * lread.c (read1): Tiny simplification.
2864 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
2866 Do not create empty overlays with the evaporate property (Bug#9642).
2867 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2868 Bug#9642, but explicitly check that the buffer the overlay would
2869 be moved to is live and rearrange lines to make sure that errors
2870 will not put the overlay in an inconsistent state.
2871 (Fdelete_overlay): Cosmetics.
2873 2012-05-28 Eli Zaretskii <eliz@gnu.org>
2875 * w32term.c (my_bring_window_to_top): New function.
2876 (x_raise_frame): Use handle returned by DeferWindowPos, which
2877 could be different from the original one.
2878 Call my_bring_window_to_top instead of my_set_foreground_window.
2881 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2882 by calling BringWindowToTop.
2884 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2885 (WM_EMACS_END): Increase by one.
2887 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2889 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2890 This avoids undefined behavior that might cause the eassert
2891 to not catch an out-of-range value.
2893 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
2895 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2896 Update dependencies.
2898 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2900 * bidi.c (bidi_mirror_char): Fix last change.
2902 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2904 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2905 when referring to sectname field in printf format.
2907 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2909 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2910 Only r_alloc_inhibit_buffer_relocation needed to be added;
2911 the others were already declared.
2913 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2914 before checking whether it's out of range. Put the check inside
2916 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2918 2012-05-27 Ken Brown <kbrown@cornell.edu>
2920 * callproc.c (Fcall_process): Restore a line that was accidentally
2921 commented out in the 2011-02-13 change (bug#11547).
2923 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2925 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2926 defined on ralloc.c.
2928 * buffer.c [REL_ALLOC]: Remove prototypes of
2929 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2930 they are now on lisp.h.
2932 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2934 * search.c (search_buffer): Use it to inhibit relocation of buffer
2935 text while re_search_2 is doing its job, because re_search_2 is
2936 passed C pointers to buffer text. (Bug#11519)
2938 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2941 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2942 state after an additional call to move_it_in_display_line_to, keep
2943 the values of it->max_ascent and it->max_descent found for the
2945 (pos_visible_p): Revert the comparison against bottom_y to what it
2946 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2949 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2951 Fix coding-related core dumps with gcc -ftrapv.
2952 The code was computing A - B, where A and B are pointers, and B is
2953 random garbage. This can lead to core dumps on platforms that
2954 have special pointer registers, and it also leads to core dumps on
2955 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2956 A - B only when B is initialized properly.
2957 * coding.c (coding_set_source, coding_set_destination): Return void.
2958 (coding_change_source, coding_change_destinations): New functions,
2959 with the old behaviors of coding_set_source and coding_set_destination.
2960 All callers that need an offset changed to use these new functions.
2962 2012-05-26 Glenn Morris <rgm@gnu.org>
2964 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2966 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2968 Extend mouse support on W32 text-mode console.
2969 * xdisp.c (draw_row_with_mouse_face):
2970 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
2972 * w32console.c: Include window.h.
2973 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2975 (initialize_w32_display): Initialize mouse-highlight data.
2977 * w32inevt.c: Include termchar.h and window.h.
2978 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2979 moves, call note_mouse_highlight. If help_echo changed, call
2980 gen_help_event to produce help-echo message in the echo area.
2981 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2984 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2986 * lread.c (read1): Simplify slightly to avoid an overflow warning
2987 with GCC 4.7.0 on x86-64.
2989 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2991 * bidi.c (bidi_mirror_char): Revert last change: an int is
2992 definitely wide enough here.
2994 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
2996 Fix integer width and related bugs (Bug#9874).
2997 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
2998 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2999 (string_bytes, check_sblock, allocate_string_data):
3000 (compact_small_strings, Fmake_bool_vector, make_string)
3001 (make_unibyte_string, make_multibyte_string)
3002 (make_string_from_bytes, make_specified_string)
3003 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3004 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3006 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3007 (allocate_pseudovector):
3008 Use int, not EMACS_INT, where int is wide enough.
3009 (inhibit_garbage_collection, Fgarbage_collect):
3010 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3011 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3012 int might not be wide enough.
3013 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3014 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3015 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3016 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3017 (bidi_level_of_next_char, bidi_move_to_visually_next):
3018 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3019 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3020 (Fkill_buffer, Fset_buffer_major_mode)
3021 (advance_to_char_boundary, Fbuffer_swap_text)
3022 (Fset_buffer_multibyte, overlays_at, overlays_in)
3023 (overlay_touches_p, struct sortvec, record_overlay_string)
3024 (overlay_strings, recenter_overlay_lists)
3025 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3026 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3027 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3028 (Foverlay_recenter, last_overlay_modification_hooks_used)
3029 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3030 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3031 (validate_region): Omit unnecessary test for b <= e,
3032 since that's guaranteed by the previous test.
3033 (adjust_overlays_for_delete): Avoid pos + length overflow.
3034 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3035 (report_overlay_modification):
3036 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3037 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3038 Omit pointer cast, which isn't needed anyway, and doesn't work
3039 after the EMACS_INT -> ptrdiff_t change.
3040 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
3041 * buffer.h: Adjust decls to match defn changes elsewhere.
3042 (struct buffer_text, struct buffer):
3043 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3044 Use EMACS_INT, not int, where int might not be wide enough.
3045 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3046 not int, to avoid needless 32-bit limit on 64-bit hosts.
3047 (exec_byte_code): Use tighter memory-full test, one that checks
3048 for alloca overflow. Don't compute the address of the object just
3049 before an array, as that's not portable. Use EMACS_INT, not
3050 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
3051 * callint.c (Fcall_interactively):
3052 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3053 * callproc.c (call_process_kill, Fcall_process):
3054 Don't assume pid_t fits into an Emacs fixnum.
3055 (call_process_cleanup, Fcall_process, child_setup):
3056 Don't assume pid_t fits into int.
3057 (call_process_cleanup, Fcall_process, delete_temp_file)
3058 (Fcall_process_region):
3059 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3060 (Fcall_process): Simplify handling of volatile integers.
3061 Use int, not EMACS_INT, where int will do.
3062 * casefiddle.c (casify_object, casify_region, operate_on_word)
3063 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3064 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3065 (casify_object): Avoid integer overflow when overallocating buffer.
3066 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
3067 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
3068 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3069 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3070 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3071 integers are now checked earlier. All uses replaced with XINT.
3073 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3074 For CCL_MapSingle, check that content and value are in int range.
3075 (ccl_driver, Fregister_code_conversion_map):
3076 Check that Vcode_version_map_vector is a vector.
3077 (resolve_symbol_ccl_program): Check that vector header is in range.
3078 Always copy the vector, so that we can check its contents reliably
3079 now rather than having to recheck each instruction as it's being
3080 executed. Check that vector words fit in 'int'.
3081 (ccl_get_compiled_code, Fregister_ccl_program)
3082 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3083 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3084 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3085 contents are in range.
3086 (Fccl_execute_on_string): Check that status is in range.
3087 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3088 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3089 Accept and return EMACS_INT, not int, because callers can pass values
3091 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3092 (multibyte_chars_in_text, parse_str_as_multibyte)
3093 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3094 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3095 (string_escape_byte8, Fget_byte):
3096 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3097 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
3098 avoid mishandling large integers.
3099 * character.h: Adjust decls to match defn changes elsewhere.
3100 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3101 (Ffind_charset_region):
3102 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3103 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3104 (load_charset_map_from_vector, Fdefine_charset_internal):
3105 Don't assume fixnum fits in int.
3106 (load_charset_map_from_vector, Fmap_charset_chars):
3107 Remove now-unnecessary CHECK_NATNUMs.
3108 (Fdefine_charset_internal): Check ranges here, more carefully.
3109 Don't rely on undefined behavior with signed left shift overflow.
3110 Don't assume unsigned int fits into fixnum, or that fixnum fits
3111 into unsigned int. Don't require max_code to be a valid fixnum;
3112 that's not true for gb10830 4-byte on a 32-bit host. Allow
3113 invalid_code to be a cons, for the same reason. Require code_offset
3114 to be a character. Avoid int overflow if max_char is close
3116 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3117 this is intended anyway and avoids some undefined behavior.
3118 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3119 INDEX_TO_CODE_POINT, as that's what it expects.
3120 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
3121 * charset.h (DECODE_CHAR): Return int, not unsigned;
3122 this is what was intended anyway, and it avoids undefined behavior.
3123 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3124 integer-overflow issues.
3125 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3126 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3127 where the argument is EMACS_INT, and this behavior is not intended.
3128 * chartab.c (Fmake_char_table, Fset_char_table_range)
3129 (uniprop_get_decoder, uniprop_get_encoder):
3130 Don't assume fixnum fits in int.
3131 * cmds.c (move_point): New function, that does the gist of
3132 Fforward_char and Fbackward_char, but does so while checking
3133 for integer overflow more accurately.
3134 (Fforward_char, Fbackward_char): Use it.
3135 (Fforward_line, Fend_of_line, internal_self_insert)
3136 (internal_self_insert):
3137 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3138 Fix a FIXME, by checking for integer overflow when calculating
3139 target_clm and actual_clm.
3140 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
3141 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
3142 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3143 (coding_alloc_by_making_gap, alloc_destination)
3144 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3145 (encode_coding_utf_16, detect_coding_emacs_mule)
3146 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3147 (detect_coding_iso_2022, decode_coding_iso_2022)
3148 (encode_invocation_designation, encode_designation_at_bol)
3149 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3150 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3151 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3152 (encode_coding_ccl, encode_coding_raw_text)
3153 (detect_coding_charset, decode_coding_charset)
3154 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3155 (produce_composition, produce_charset, produce_annotation)
3156 (decode_coding, handle_composition_annotation)
3157 (handle_charset_annotation, consume_chars, decode_coding_gap)
3158 (decode_coding_object, encode_coding_object, detect_coding_system)
3159 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3160 (code_convert_region, code_convert_string)
3161 (Fdefine_coding_system_internal)
3162 (coding_set_source, coding_set_destination):
3163 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3164 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3165 (Fdefine_coding_system_internal):
3166 Don't assume fixnums fit in int.
3167 (decode_coding_gap, decode_coding_object, encode_coding_object)
3168 (Fread_coding_system, Fdetect_coding_region)
3169 (Funencodable_char_position, Fcheck_coding_systems_region)
3170 (get_translation, handle_composition_annotation, consume_chars):
3171 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3172 (consume_chars): Rewrite to not calculate an address outside buffer.
3173 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
3174 Don't access memory outside of the args array.
3175 (Fdefine_coding_system_internal): Check for charset-id overflow.
3176 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3177 result of ENCODE_CHAR.
3178 * coding.h: Adjust decls to match defn changes elsewhere.
3179 (struct coding_system):
3180 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3181 * composite.c (get_composition_id, find_composition)
3182 (run_composition_function, update_compositions)
3183 (compose_text, composition_gstring_put_cache)
3184 (composition_gstring_p, composition_gstring_width)
3185 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3186 (composition_compute_stop_pos, composition_reseat_it)
3187 (composition_update_it, struct position_record)
3188 (find_automatic_composition, composition_adjust_point)
3189 (Fcomposition_get_gstring, Ffind_composition_internal):
3190 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3191 (update_compositions):
3192 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3193 * composite.h: Adjust decls to match defn changes elsewhere.
3194 (struct composition):
3195 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3196 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3197 Do not attempt to compute the address of the object just before a
3198 buffer; this is not portable.
3200 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3201 (Faset): Use int, not EMACS_INT, where int is wide enough.
3202 (Fstring_to_number): Don't assume fixnums fit in int.
3203 (Frem): Don't assume arg is nonnegative.
3204 * dbusbind.c (xd_append_arg): Check for integers out of range.
3205 (Fdbus_call_method): Don't overflow the timeout int.
3206 (extract_signed, extract_unsigned): New functions.
3207 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3208 (xd_get_connection_references): Return ptrdiff_t, not int.
3210 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3211 (xd_read_message_1):
3212 Use int, not unsigned, where the dbus API uses int.
3213 (Fdbus_message_internal): Don't overflow mtype.
3214 (syms_of_dbusbind): Allocate right-sized buffer for integers.
3215 * dired.c (directory_files_internal, file_name_completion, scmp)
3216 (file_name_completion_stat):
3217 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3218 (file_name_completion): Don't overflow matchcount.
3219 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3220 * dispextern.h: Adjust decls to match defn changes elsewhere.
3221 (struct text_pos, struct glyph, struct bidi_saved_info)
3222 (struct bidi_string_data, struct bidi_it, struct composition_it)
3224 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3225 (struct display_pos, struct composition_it, struct it):
3226 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3227 * dispnew.c (increment_matrix_positions)
3228 (increment_row_positions, mode_line_string)
3229 (marginal_area_string):
3230 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3231 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
3232 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3233 (duration_to_sec_usec): New function, to check for overflow better.
3234 (Fsleep_for, sit_for): Use it.
3235 * doc.c (get_doc_string, store_function_docstring):
3236 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3237 (get_doc_string, Fsnarf_documentation):
3238 Use int, not EMACS_INT, where int is wide enough.
3240 Use SAFE_ALLOCA, not alloca.
3241 Check for overflow when converting EMACS_INT to off_t.
3242 * doprnt.c (doprnt):
3243 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3244 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3245 Don't assume uid_t fits into fixnum.
3246 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3247 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3248 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3249 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3250 (general_insert_function)
3251 (Finsert_char, make_buffer_string, make_buffer_string_both)
3252 (update_buffer_properties, Fbuffer_substring)
3253 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3254 (Fsubst_char_in_region, check_translation)
3255 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3256 (transpose_markers, Ftranspose_regions):
3257 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3258 (clip_to_bounds): Move to lisp.h as an inline function).
3259 (Fconstrain_to_field): Don't assume integers are nonnegative.
3260 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3261 (Fsubst_char_in_region, Fsave_restriction):
3262 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3263 (Femacs_pid): Don't assume pid_t fits into fixnum.
3264 (lo_time): Use int, not EMACS_INT, when int suffices.
3265 (lisp_time_argument): Check for usec out of range.
3266 (Fencode_time): Don't assume fixnum fits in int.
3267 (Fuser_login_name, Fuser_full_name): Signal an error
3268 if a uid argument is out of range, rather than relying on
3270 (Fformat_time_string): Remove now-unnecessary check.
3271 lisp_time_argument checks for out-of-range usec now.
3272 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
3273 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3274 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3275 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3276 (init_cmdargs, Fdump_emacs):
3277 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3278 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3279 the bottom (typically) 32 bits of the fixnum.
3280 * eval.c (specpdl_size, call_debugger):
3281 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3282 (when_entered_debugger, Fbacktrace_debug):
3283 Don't assume fixnum can fit in int.
3284 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3285 the object just before a buffer; this is not portable.
3286 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3287 (grow_specpdl, unbind_to):
3288 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3289 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3290 (grow_specpdl): Simplify allocation by using xpalloc.
3291 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
3292 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3293 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3294 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3295 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3297 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3298 (Fcopy_file, non_regular_nbytes, read_non_regular)
3299 (Finsert_file_contents):
3300 Use int, not EMACS_INT, where int is wide enough.
3301 (READ_BUF_SIZE): Verify that it fits in int.
3302 (Finsert_file_contents): Check that counts are in proper range,
3303 rather than assuming fixnums fit into ptrdiff_t etc.
3304 Don't assume fixnums fit into int.
3305 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
3306 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3307 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
3308 (string_char_to_byte, string_byte_to_char)
3309 (string_make_multibyte, string_to_multibyte)
3310 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3311 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3312 (substring_both, Fdelete, internal_equal, Ffillarray)
3313 (Fclear_string, mapcar1)
3314 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3315 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3316 (larger_vector, make_hash_table, maybe_resize_hash_table)
3317 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3318 (Fmaphash, secure_hash):
3319 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3320 (concat): Check for string index and length overflow.
3321 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3323 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3324 (larger_vector): New API (vec, incr_min, size_max) replaces old
3325 one (vec, new_size, init). This catches size overflow.
3326 INIT was removed because it was always Qnil.
3327 All callers changed.
3328 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3329 the upper bound on a hash table index size.
3330 (make_hash_table, maybe_resize_hash_table): Use it.
3331 (secure_hash): Computer start_byte and end_byte only after
3332 they're known to be in ptrdiff_t range.
3333 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3334 (Ffont_get_glyphs, Ffont_at):
3335 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3336 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3337 (Flist_fonts, Fopen_font):
3338 Don't assume fixnum can fit in int.
3339 (check_gstring): Don't assume index can fit in int.
3340 (font_match_p): Check that fixnum is a character, not a nonnegative
3341 fixnum, since the later code needs to stuff it into an int.
3342 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3343 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3344 conversion overflow issues.
3345 (Fopen_font): Check for integer out of range.
3346 (Ffont_get_glyphs): Don't assume index can fit in int.
3347 * font.h: Adjust decls to match defn changes elsewhere.
3348 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3350 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3351 printmax_t, where ptrdiff_t is wide enough.
3352 (Finternal_char_font):
3353 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3354 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3355 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3356 (Fset_frame_position, x_set_frame_parameters)
3357 (x_set_line_spacing, x_set_border_width)
3358 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3359 Check that fixnums are in proper range for system types.
3360 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3361 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3362 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3363 Use SAFE_ALLOCA_LISP, not alloca.
3364 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3365 intptr_t is wide enough.
3366 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3367 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3368 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3369 Check for fixnum out of range.
3370 * ftfont.c (ftfont_list): Don't assume index fits in int.
3371 Check that fixnums are in proper range for system types.
3372 (ftfont_shape_by_flt):
3373 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3374 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3375 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3376 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3377 Check that fixnums are in proper range for system types.
3378 * gnutls.h: Adjust decls to match defn changes elsewhere.
3379 * gtkutil.c (xg_dialog_run):
3380 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3381 (update_frame_tool_bar):
3382 Check that fixnums are in proper range for system types.
3383 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
3384 (lookup_image): Check that fixnums are in range for system types.
3385 * indent.c (last_known_column, last_known_column_point):
3386 (current_column_bol_cache):
3387 (skip_invisible, current_column, check_display_width):
3388 (check_display_width, scan_for_column, current_column_1)
3389 (Findent_to, Fcurrent_indentation, position_indentation)
3390 (indented_beyond_p, Fmove_to_column, compute_motion):
3391 (Fcompute_motion, Fvertical_motion):
3392 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3393 (last_known_column_modified): Use EMACS_INT, not int.
3394 (check_display_width):
3396 Check that fixnums and floats are in proper range for system types.
3397 (compute_motion): Don't assume index or fixnum fits in int.
3398 (compute_motion, Fcompute_motion):
3399 Use int, not EMACS_INT, when it is wide enough.
3400 (vmotion): Omit local var start_hpos that is always 0; that way
3401 we don't need to worry about overflow in expressions involving it.
3402 * indent.h: Adjust decls to match defn changes elsewhere.
3404 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3405 Use int, not EMACS_INT, where int is wide enough.
3406 Remove unused members ovstring_chars_done and tab_offset;
3408 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3409 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3410 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3411 (make_gap, copy_text, insert, insert_and_inherit)
3412 (insert_before_markers, insert_before_markers_and_inherit)
3413 (insert_1, count_combining_before, count_combining_after)
3414 (insert_1_both, insert_from_string)
3415 (insert_from_string_before_markers, insert_from_string_1)
3416 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3417 (adjust_after_replace, adjust_after_insert, replace_range)
3418 (replace_range_2, del_range, del_range_1, del_range_byte)
3419 (del_range_both, del_range_2, modify_region)
3420 (prepare_to_modify_buffer, signal_before_change)
3421 (signal_after_change, Fcombine_after_change_execute):
3422 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3423 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3424 (balance_an_interval, split_interval_right, split_interval_left)
3425 (find_interval, next_interval, update_interval)
3426 (adjust_intervals_for_insertion, delete_node, delete_interval)
3427 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3428 (static_offset_intervals, offset_intervals)
3429 (merge_interval_right, merge_interval_left, make_new_interval)
3430 (graft_intervals_into_buffer, temp_set_point_both)
3431 (temp_set_point, set_point, adjust_for_invis_intang)
3432 (set_point_both, move_if_not_intangible, get_property_and_range)
3433 (get_local_map, copy_intervals, copy_intervals_to_string)
3434 (compare_string_intervals, set_intervals_multibyte_1):
3435 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3436 * intervals.h: Adjust decls to match defn changes elsewhere.
3438 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3439 * keyboard.c (this_command_key_count, this_single_command_key_start)
3440 (before_command_key_count, before_command_echo_length, echo_now)
3441 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3442 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3443 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3444 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3445 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3446 (last_non_minibuf_size, last_point_position, echo_truncate)
3447 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3448 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3449 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3450 (stuff_buffered_input):
3451 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3452 (last_auto_save, command_loop_1, read_char):
3453 Use EMACS_INT, not int, to avoid integer overflow.
3454 (record_char): Avoid overflow in total_keys computation.
3455 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3456 * keyboard.h: Adjust decls to match defn changes elsewhere.
3457 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3458 (Fkey_description, Fdescribe_vector, Flookup_key):
3459 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3460 (click_position): New function, to check that positions are in range.
3461 (Fcurrent_active_maps):
3463 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3464 (Faccessible_keymaps, Fkey_description):
3465 (preferred_sequence_p):
3466 Don't assume fixnum can fit into int.
3467 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3468 Check for integer overflow in size calculations.
3469 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3470 avoid mishandling large integers.
3471 * lisp.h: Adjust decls to match defn changes elsewhere.
3472 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3473 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3474 (struct Lisp_Marker):
3475 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3476 (clip_to_bounds): Now an inline function, moved here from editfns.c.
3477 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3478 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3479 All callers changed.
3480 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3481 Assume the arg has valid form, since it always does.
3482 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3483 unsigned integer system type.
3484 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3485 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3486 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3487 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3488 (duration_to_sec_usec): New decl.
3489 * lread.c (read_from_string_index, read_from_string_index_byte)
3490 (read_from_string_limit, readchar, unreadchar, openp)
3491 (read_internal_start, read1, oblookup):
3492 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3493 (Fload, readevalloop, Feval_buffer, Feval_region):
3494 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3495 (openp): Check for out-of-range argument to 'access'.
3496 (read1): Use int, not EMACS_INT, where int is wide enough.
3497 Don't assume fixnum fits into int.
3498 Fix off-by-one error that can read outside a buffer.
3499 (read_filtered_event): Use duration_to_sec_usec
3500 to do proper overflow checking on durations.
3501 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3502 in size calculation.
3503 (Fexecute_kbd_macro):
3504 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3505 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3506 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3507 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3508 (set_marker_both, set_marker_restricted_both, marker_position)
3509 (marker_byte_position, Fbuffer_has_markers_at):
3510 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3511 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
3512 * menu.c (ensure_menu_items): Rename from grow_menu_items.
3513 It now merely ensures that the menu is large enough, without
3514 necessarily growing it, as this avoids some integer overflow issues.
3515 All callers changed.
3516 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3517 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3518 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3519 Use SAFE_ALLOCA_LISP, not alloca.
3520 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3521 to EMACS_INT. Check that fixnums are in proper range for system types.
3522 * minibuf.c (minibuf_prompt_width, string_to_object)
3523 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3524 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3525 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3526 (get_minibuffer, read_minibuf_unwind):
3527 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3528 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3529 this simplifies overflow checking. All callers changed.
3530 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3532 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3533 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3534 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3535 Check that fixnums are in proper range for system types.
3536 (Fx_create_frame, Fx_show_tip):
3537 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3538 * nsfont.m (ns_findfonts, nsfont_list_family):
3539 Don't assume fixnum fits in long.
3540 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3541 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3542 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3544 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
3545 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3546 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3547 (PRINTDECLARE, PRINTPREPARE):
3548 (strout, print_string):
3549 (print, print_preprocess, print_check_string_charset_prop)
3551 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3553 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3554 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3555 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
3556 (printchar, strout): Use xpalloc to catch size calculation overflow.
3557 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
3558 (print_error_message): Use SAFE_ALLOCA, not alloca.
3559 (print_object): Use int, not EMACS_INT, where int is wide enough.
3560 (print_depth, new_backquote_output, print_number_index):
3561 Use ptrdiff_t, not int, where int might not be wide enough.
3562 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3563 (Fset_process_window_size, Fformat_network_address)
3564 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
3566 Check that fixnums are in proper range for system types.
3567 (Fsignal_process): Simplify by avoiding a goto.
3568 Check for process-ids out of pid_t range rather than relying on
3570 (process_tick, update_tick): Use EMACS_INT, not int.
3571 (Fformat_network_address, read_process_output, send_process)
3572 (Fprocess_send_region, status_notify):
3573 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3574 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3575 (wait_reading_process_output, read_process_output, exec_sentinel):
3576 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3577 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3578 (Faccept_process_output): Use duration_to_sec_usec to do proper
3579 overflow checking on durations.
3580 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3581 Don't assume pid_t fits in int.
3582 * process.h (struct Lisp_Process): Members tick and update_tick
3583 are now of type EMACS_INT, not int.
3584 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3585 configured --with-wide-int.
3586 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3587 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3588 * search.c (looking_at_1, string_match_1):
3589 (fast_string_match, fast_c_string_match_ignore_case)
3590 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3591 (scan_newline, find_before_next_newline, search_command)
3592 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3593 (set_search_regs, wordify):
3596 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3597 (string_match_1, search_buffer, set_search_regs):
3599 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3600 (wordify): Check for overflow in size calculation.
3601 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3602 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3603 Check that fixnums are in proper range for system types.
3604 * sound.c (struct sound_device)
3605 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3606 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3607 (Fplay_sound_internal):
3608 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3609 * syntax.c (struct lisp_parse_state, find_start_modiff)
3610 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3611 (Fparse_partial_sexp):
3612 Don't assume fixnums can fit in int.
3613 (struct lisp_parse_state, find_start_pos, find_start_value)
3614 (find_start_value_byte, find_start_begv)
3615 (update_syntax_table, char_quoted, dec_bytepos)
3616 (find_defun_start, prev_char_comend_first, back_comment):
3617 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3618 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3619 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3620 (Finternal_describe_syntax_value): Check that match_lisp is a
3621 character, not an integer, since the code stuffs it into int.
3622 (scan_words, scan_sexps_forward):
3623 Check that fixnums are in proper range for system types.
3625 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3626 (scan_sexps_forward):
3627 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3628 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3629 * syntax.h: Adjust decls to match defn changes elsewhere.
3630 (struct gl_state_s):
3631 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3632 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3633 MOST_POSITIVE_FIXNUM.
3634 * sysdep.c (wait_for_termination_1, wait_for_termination)
3635 (interruptible_wait_for_termination, mkdir):
3636 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3637 (emacs_read, emacs_write):
3638 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3639 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3640 and double all fit in int.
3641 * term.c (set_tty_color_mode):
3642 Check that fixnums are in proper range for system types.
3643 * termhooks.h (struct input_event):
3644 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3645 * textprop.c (validate_interval_range, interval_of)
3646 (Fadd_text_properties, set_text_properties_1)
3647 (Fremove_text_properties, Fremove_list_of_text_properties)
3648 (Ftext_property_any, Ftext_property_not_all)
3649 (copy_text_properties, text_property_list, extend_property_ranges)
3650 (verify_interval_modification):
3651 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3652 (Fnext_single_char_property_change)
3653 (Fprevious_single_char_property_change):
3654 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3655 (copy_text_properties):
3656 Check for integer overflow in index calculation.
3657 * undo.c (last_boundary_position, record_point, record_insert)
3658 (record_delete, record_marker_adjustment, record_change)
3659 (record_property_change):
3660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3661 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3662 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3663 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3664 (Fx_hide_tip, Fx_file_dialog):
3665 * w32menu.c (set_frame_menubar):
3666 Use ptrdiff_t, not int, for consistency with rest of code.
3667 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3668 (select_window, Fdelete_other_windows_internal)
3669 (window_scroll_pixel_based, window_scroll_line_based)
3670 (Frecenter, Fset_window_configuration):
3671 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3672 (Fset_window_hscroll, run_window_configuration_change_hook)
3673 (set_window_buffer, temp_output_buffer_show, scroll_command)
3674 (Fscroll_other_window, Frecenter):
3675 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3676 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3677 Don't assume fixnum fits in int.
3678 (Fset_window_scroll_bars):
3679 Check that fixnums are in proper range for system types.
3680 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3681 (string_pos, c_string_pos, number_of_chars, init_iterator)
3682 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3683 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3684 (compute_display_string_end, handle_face_prop)
3685 (face_before_or_after_it_pos, handle_invisible_prop)
3686 (handle_display_prop, handle_display_spec, handle_single_display_spec)
3687 (display_prop_intangible_p, string_buffer_position_lim)
3688 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3689 (get_overlay_strings_1, get_overlay_strings)
3690 (iterate_out_of_display_property, forward_to_next_line_start)
3691 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3692 (get_next_display_element, set_iterator_to_next)
3693 (get_visually_first_element, compute_stop_pos_backwards)
3694 (handle_stop_backwards, next_element_from_buffer)
3695 (move_it_in_display_line_to, move_it_in_display_line)
3696 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3697 (add_to_log, message_dolog, message_log_check_duplicate)
3698 (message2, message2_nolog, message3, message3_nolog
3699 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3700 (current_message_1, truncate_echo_area, truncate_message_1)
3701 (set_message, set_message_1, store_mode_line_noprop)
3702 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3703 (text_outside_line_unchanged_p, check_point_in_composition)
3704 (reconsider_clip_changes)
3705 (redisplay_internal, set_cursor_from_row, try_scrolling)
3706 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3707 (redisplay_window, find_last_unchanged_at_beg_row)
3708 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3709 (trailing_whitespace_p, find_row_edges, display_line)
3710 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3711 (display_mode_element, store_mode_line_string)
3712 (pint2str, pint2hrstr, decode_mode_spec)
3713 (display_count_lines, display_string, draw_glyphs)
3714 (x_produce_glyphs, x_insert_glyphs)
3715 (rows_from_pos_range, mouse_face_from_buffer_pos)
3716 (fast_find_string_pos, mouse_face_from_string_pos)
3717 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3718 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3719 (safe_call, init_from_display_pos, handle_fontified_prop)
3720 (handle_single_display_spec, load_overlay_strings)
3721 (with_echo_area_buffer, setup_echo_area_for_printing)
3722 (display_echo_area, echo_area_display)
3723 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3724 (update_tool_bar, hscroll_window_tree, redisplay_internal)
3725 (redisplay_window, dump_glyph_row, display_mode_line)
3726 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
3727 (handle_display_spec, display_prop_string_p):
3728 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3729 (handle_single_display_spec, build_desired_tool_bar_string)
3730 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3731 (get_specified_cursor_type):
3732 Check that fixnums are in proper range for system types.
3733 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3734 (Flookup_image_map):
3735 Don't assume fixnums fit in int.
3736 (compare_overlay_entries):
3737 Avoid mishandling comparisons due to subtraction overflow.
3738 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3739 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3740 (handle_tool_bar_click):
3741 Use int, not unsigned, since we prefer signed and the signedness
3742 doesn't matter here.
3743 (get_next_display_element, next_element_from_display_vector):
3744 Use int, not EMACS_INT, when int is wide enough.
3745 (start_hourglass): Use duration_to_sec_usec to do proper
3746 overflow checking on durations.
3747 * xfaces.c (Fbitmap_spec_p):
3748 Check that fixnums are in proper range for system types.
3749 (compare_fonts_by_sort_order):
3750 Avoid mishandling comparisons due to subtraction overflow.
3751 (Fx_family_fonts, realize_basic_faces):
3752 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3754 Don't assume fixnum fits in int.
3755 Use SAFE_ALLOCA_LISP, not alloca.
3756 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3757 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3758 (face_at_buffer_position, face_for_overlay_string)
3759 (face_at_string_position):
3760 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3761 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3762 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3764 Check that fixnums are in proper range for system types.
3765 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3766 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3767 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3768 (Fx_change_window_property): Don't assume fixnums fit in int.
3769 * xfont.c (xfont_chars_supported):
3770 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3771 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3772 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3773 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3774 * xml.c (parse_region):
3775 * xrdb.c (magic_file_p):
3776 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3777 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3778 (x_get_local_selection, x_reply_selection_request)
3779 (x_handle_selection_request, wait_for_property_change):
3780 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3781 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3782 short is wide enough.
3783 (x_send_client_event): Don't assume fixnum fits in int.
3784 * xterm.c (x_x_to_emacs_modifiers):
3785 Don't assume EMACS_INT overflows nicely into int.
3786 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3788 (handle_one_xevent): NATNUMP can eval its arg twice.
3789 (x_connection_closed):
3790 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3791 * xterm.h: Adjust decls to match defn changes elsewhere.
3792 (struct scroll_bar): Use struct vectorlike_header
3793 rather than rolling our own approximation.
3794 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3796 2012-05-25 Glenn Morris <rgm@gnu.org>
3798 * lisp.mk (lisp): Update for more files being compiled now.
3800 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3802 * lread.c: Remove `read_pure' which makes no difference.
3803 (read_pure): Remove var.
3804 (unreadpure): Remove function.
3805 (readevalloop): Don't call read_list with -1 flag.
3806 (read1, read_vector): Don't test read_pure any more.
3807 (read_list): Simplify.
3809 * fileio.c, character.h: Minor style tweaks.
3811 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3813 * window.h (clip_changed): Remove useless declaration.
3815 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
3817 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3818 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3820 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3823 This directory predates autoconf and is no longer needed nowadays.
3824 Move its few remaining bits of functionality to where they're needed.
3825 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3826 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3827 * m/template.h: Remove.
3828 * Makefile.in (M_FILE): Remove. All uses removed.
3829 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3830 * lisp.h (USE_LSB_TAG):
3831 * mem-limits.h (EXCEEDS_LISP_PTR):
3832 Use VAL_MAX, not VALBITS, in #if.
3833 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3834 (EMACS_UINT): Define unconditionally now.
3835 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3836 (BITS_PER_EMACS_INT): New constants, replacing
3837 what used to be in config.h, but not useful in #if.
3838 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3839 define them any more.
3840 (VAL_MAX): New macro.
3842 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3843 BITS_PER_EMACS_INT, in #if.
3844 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3845 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3846 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3847 * s/ms-w32.h (DATA_START):
3848 Move here from removed file m/intel386.h.
3849 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3850 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3852 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3854 Assume C89 or later.
3855 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3856 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3858 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3859 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3860 * textprop.c, tparam.c (NULL): Remove.
3861 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3862 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3863 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3864 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3865 * xterm.c (input_signal_count): Assume volatile works.
3867 2012-05-21 Ken Brown <kbrown@cornell.edu>
3869 * xgselect.c (xg_select): Fix first argument in call to 'select'
3872 2012-05-20 Ken Brown <kbrown@cornell.edu>
3874 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
3875 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
3877 2012-05-19 Ken Brown <kbrown@cornell.edu>
3879 * xfns.c (x_in_use): Remove `static' qualifier.
3880 * xterm.h (x_in_use): Declare.
3881 * xgselect.c: Include xterm.h.
3882 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3883 and `display_arg' (bug#9754).
3885 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3887 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3889 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3890 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3892 2012-05-18 Eli Zaretskii <eliz@gnu.org>
3894 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3896 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
3897 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
3899 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3900 reference to image_cache->refcount.
3901 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3903 2012-05-17 Juri Linkov <juri@jurta.org>
3905 * search.c (Fword_search_regexp, Fword_search_backward)
3906 (Fword_search_forward, Fword_search_backward_lax)
3907 (Fword_search_forward_lax): Move functions to isearch.el
3908 (bug#10145, bug#11381).
3910 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3912 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3914 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3916 * lread.c (init_obarray): Declare Qt and Qnil as special.
3918 2012-05-14 Glenn Morris <rgm@gnu.org>
3920 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
3921 Put "libexec" before "bin", for the sake of init_callproc_1.
3923 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3925 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3927 * unexaix.c: Port to more-recent AIX compilers.
3928 (report_error, report_error_1, make_hdr, copy_sym)
3929 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3930 Make arguments const char *, not char *, to avoid violations of C
3931 standard and to fix some AIX warnings reported by Gilles Pion.
3933 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3935 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3936 already have overlays loaded.
3937 (handle_single_display_spec): Before returning without displaying
3938 fringe bitmap, synchronize the bidi iterator with the main display
3939 iterator, by calling iterate_out_of_display_property.
3940 (iterate_out_of_display_property): Detect buffer iteration by
3941 testing that it->string is a Lisp string.
3942 (get_next_display_element): When the current object is exhausted,
3943 and there's something on it->stack, call set_iterator_to_next to
3944 proceed with what's on the stack, instead of returning zero.
3945 (set_iterator_to_next): If called at the end of a Lisp string,
3946 proceed to consider_string_end without incrementing string
3947 position. Don't increment display vector index past the end of
3948 the display vector. (Bug#11417)
3949 (pos_visible_p): Don't report a position visible when move_it_to
3950 stopped at the last line of window, which happens to be scanned
3951 backwards by the bidi iteration. (Bug#11464)
3953 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3955 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3956 and right-margin display specs even if the spec is invalid or we
3957 are on a TTY, and thus unable to display on the fringes.
3958 That's because the text with the property will not be displayed anyway,
3959 so we need to signal to the caller that this is a "replacing"
3960 display spec. This fixes display when the spec is invalid or we
3963 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3965 * unexaix.c (make_hdr): Fix typo in prototype.
3966 This bug broke the build on AIX. Problem reported by Gilles Pion.
3968 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
3970 * keyboard.c (kbd_buffer_get_event): Read special events also in
3971 batch mode. (Bug#11415)
3973 2012-05-12 Glenn Morris <rgm@gnu.org>
3975 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3977 2012-05-12 Eli Zaretskii <eliz@gnu.org>
3979 * lisp.mk (lisp): Add newcomment.elc.
3981 2012-05-12 Glenn Morris <rgm@gnu.org>
3983 * Makefile.in (MKDIR_P): New, set by configure.
3984 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3986 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3988 Remove unused function hourglass_started.
3989 * dispextern.h (hourglass_started):
3990 * w32fns.c (hourglass_started):
3991 * xdisp.c (hourglass_started): Remove.
3993 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
3995 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3996 Update dependencies.
3998 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4000 * xgselect.c (xg_select): Put maxfds+1 into a var.
4001 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4003 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4005 2012-05-10 Dave Abrahams <dave@boostpro.com>
4007 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4008 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4010 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
4012 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4013 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4014 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4015 Initialize xd_registered_buses.
4017 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4019 Untag more efficiently if USE_LSB_TAG.
4020 This is based on a proposal by YAMAMOTO Mitsuharu in
4021 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4022 For an admittedly artificial (nth 8000 longlist) benchmark on
4023 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4024 Emacs's overall text size by 1%.
4025 * lisp.h (XUNTAG): New macro.
4026 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4027 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4028 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4029 * eval.c (Fautoload):
4030 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4031 * frame.h (XFRAME): Use XUNTAG.
4033 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4034 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4035 Remove unportable assumptions about print widths of types like
4037 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4038 intptr_t when converting between pointer and integer, to avoid GCC
4039 warnings about wrong width.
4041 2012-05-09 Eli Zaretskii <eliz@gnu.org>
4043 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4044 stack for each reader_thread, instead of defaulting to 8MB
4045 determined by the linker. This avoids failures in creating
4046 subprocesses on Windows 7, see the discussion in this thread:
4047 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4049 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4051 Fix up display of the *Minibuf-0* buffer in the mini window.
4052 * keyboard.c (read_char): Don't clear the echo area if there's no
4054 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
4055 contents of *Minibuf-0*) if there's no message displayed in its stead.
4057 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
4059 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4062 2012-05-06 Chong Yidong <cyd@gnu.org>
4064 * lisp.mk (lisp): Update.
4066 2012-05-05 Jim Meyering <meyering@redhat.com>
4068 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4070 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4072 * data.c (PUT_ERROR): New macro.
4073 (syms_of_data): Use it. Add new error type `user-error'.
4074 * undo.c (user_error): New function.
4075 (Fprimitive_undo): Use it.
4076 * print.c (print_error_message): Adjust print style for `user-error'.
4077 * keyboard.c (user_error): New function.
4078 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4080 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4082 Do not limit current-time-string to years 1000..9999.
4083 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4084 (Fcurrent_time_string): Support any year that is supported by the
4085 underlying localtime representation. Don't use asctime, as it
4086 has undefined behavior for years outside the range -999..9999.
4088 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4090 Fix race conditions involving setenv, gmtime, localtime, asctime.
4091 Without this fix, interrupts could mess up code that uses these
4092 nonreentrant functions, since setting TZ invalidates existing
4093 tm_zone or tzname values, and since most of these functions return
4094 pointers to static storage.
4095 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4096 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4097 Grow the critical sections to include not just invoking
4098 localtime/gmtime, but also accessing these functions' results
4099 including their tm_zone values if any, and any related TZ setting.
4100 (format_time_string): Last arg is now struct tm *, not struct tm **,
4101 so that the struct tm is saved in the critical section.
4102 All callers changed. Simplify allocation of initial buffer, partly
4103 motivated by the fact that memory allocation needs to be outside
4104 the critical section.
4106 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4108 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4109 with RESET_INTERVAL.
4111 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4112 Remove duplicated buffer name initialization.
4114 2012-05-02 Jim Meyering <jim@meyering.net>
4116 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4118 * xfns.c (x_window): Use xstrdup (Bug#11375).
4120 2012-05-02 Eli Zaretskii <eliz@gnu.org>
4122 * xdisp.c (pos_visible_p): If already at a newline from the
4123 display string before the 'while' loop, don't walk back the glyphs
4124 from it3.glyph_row. Solves assertion violation when the display
4125 string begins with a newline (egg.el). (Bug#11367)
4127 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4129 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4132 2012-05-01 Glenn Morris <rgm@gnu.org>
4134 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4135 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4136 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4137 All were removed before 23.1.
4139 * dispnew.c: Remove HAVE_LIBNCURSES test;
4140 it is always true on relevant platforms.
4142 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4143 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4145 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4147 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4149 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4150 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4153 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4155 Do not avoid creating empty evaporating overlays (Bug#9642).
4156 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4157 That is, do not delete an evaporating overlay if it becomes
4158 empty after its bounds are adjusted to fit within its buffer.
4159 This fix caused other problems, and I'm reverting it until we get
4160 to the bottom of them.
4162 2012-04-27 Chong Yidong <cyd@gnu.org>
4164 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4166 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4168 * xdisp.c (pos_visible_p): If the window start position is beyond
4169 ZV, start the display from buffer beginning. Prevents assertion
4170 violation in init_iterator when the minibuffer window is scrolled
4173 * window.c (window_scroll_pixel_based): Likewise.
4175 2012-04-27 Chong Yidong <cyd@gnu.org>
4177 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4179 2012-04-27 Glenn Morris <rgm@gnu.org>
4181 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4182 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4184 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4186 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4187 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
4189 2012-04-26 Eli Zaretskii <eliz@gnu.org>
4191 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4192 display element, check also the underlying string or buffer
4193 character. (Bug#11341)
4195 * w32menu.c: Include w32heap.h.
4196 (add_menu_item): If the call to AppendMenuW (via
4197 unicode_append_menu) fails, disable Unicode menus only if we are
4198 running on Windows 9X/Me.
4200 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4202 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4203 (xgetint): Add missing shift for LSB tags.
4205 2012-04-24 Martin Rudalics <rudalics@gmx.at>
4207 * keyboard.c (read_char): Don't wipe echo area for select window
4208 events: These might get delayed via `mouse-autoselect-window'
4211 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
4213 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4214 manipulation of :loaded-from data.
4216 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
4218 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4219 now a cons (bug#11311).
4221 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4223 Do not create empty overlays with the evaporate property (Bug#9642).
4224 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4225 if it becomes empty after its bounds are adjusted to fit within
4226 its buffer. Without this fix, in a nonempty buffer (let ((o
4227 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4228 yields an empty overlay that has the evaporate property, which is
4229 not supposed to happen.
4231 Fix minor GTK3 problems found by static checking.
4232 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4233 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4234 (struct _EmacsFixedClass, emacs_fixed_get_type):
4235 Move decls here from emacsgtkfixed.h, since they needn't be public.
4236 (emacs_fixed_get_type): Now static.
4237 (emacs_fixed_class_init): Omit unused local.
4238 (emacs_fixed_child_type): Remove; unused.
4239 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4240 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4241 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4242 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4243 (EMACS_FIXED_GET_CLASS): Remove; unused.
4244 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4246 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4247 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4249 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4251 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
4252 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
4253 (__malloc_size_t, __malloc_ptrdiff_t):
4254 Remove. All uses removed, replaced by the definiens if needed,
4255 since we can assume C89 or better now.
4256 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4257 (protect_malloc_state, align, get_contiguous_space)
4258 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4259 (malloc_atfork_handler_child, malloc_enable_thread)
4260 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4261 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4262 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4263 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4264 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4265 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4266 Define using prototypes, not old style.
4267 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4268 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4269 (align): Don't assume that signed integer overflow wraps around.
4270 Omit unused local var.
4271 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4272 (_free_internal_nolock, memalign, mallochook, reallochook):
4273 Omit no-longer-needed casts.
4274 (valloc): Use getpagesize, not __getpagesize.
4275 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4276 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4278 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4280 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
4282 Move functions from C to Lisp. Make non-blocking method calls
4283 the default. Implement further D-Bus standard interfaces.
4285 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4286 (QCdbus_request_name_allow_replacement)
4287 (QCdbus_request_name_replace_existing)
4288 (QCdbus_request_name_do_not_queue)
4289 (QCdbus_request_name_reply_primary_owner)
4290 (QCdbus_request_name_reply_in_queue)
4291 (QCdbus_request_name_reply_exists)
4292 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4293 (QCdbus_registered_serial, QCdbus_registered_method)
4294 (QCdbus_registered_signal): New Lisp objects.
4295 (XD_DEBUG_MESSAGE): Use sizeof.
4296 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4297 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4298 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4299 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4300 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4301 (xd_signature, xd_append_arg): Allow float for integer types.
4302 (xd_get_connection_references): New function.
4303 (xd_get_connection_address): Rename from xd_initialize.
4304 Return cached address.
4305 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4306 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4308 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
4309 Return number of refcounts.
4310 (Fdbus_get_unique_name): Make stronger parameter check.
4311 (Fdbus_message_internal): New defun.
4312 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4313 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4314 (Fdbus_send_signal, Fdbus_register_service)
4315 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4316 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4317 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4318 (Vdbus_compiled_version, Vdbus_runtime_version)
4319 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4320 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4321 (Vdbus_message_type_signal): New defvars.
4322 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4325 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4327 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4328 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4329 Do not assume ptrdiff_t is the same width as 'int'.
4331 * alloc.c: Handle unusual debugging option combinations.
4332 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4333 since the two debugging options are incompatible.
4334 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4336 (mem_init, mem_insert, mem_insert_fixup):
4337 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4338 (NEED_MEM_INSERT): Remove; no longer needed.
4340 2012-04-22 Leo Liu <sdl.web@gmail.com>
4342 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4344 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4346 * sysdep.c [__FreeBSD__]: Minor cleanups.
4347 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4348 Use Emacs indenting style more consistently. Avoid some casts.
4349 Use 'double' consistently rather than mixing 'float' and 'double'.
4351 2012-04-21 Eduard Wiebe <usenet@pusto.de>
4353 * sysdep.c (list_system_processes, system_process_attributes):
4354 Add implementation for FreeBSD (Bug#5243).
4356 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4358 * lisp.mk (lisp): Update.
4360 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4362 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4363 It is never used otherwise.
4365 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4367 * print.c (print_preprocess): Only check print_depth if print-circle
4369 (print_object): Check for cycles even when print-circle is nil and
4370 print-gensym is t, but only check print_depth if print-circle is nil.
4372 2012-04-20 Chong Yidong <cyd@gnu.org>
4374 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4375 set the status to "failed" and ensure that sentinel is run.
4377 2012-04-20 Glenn Morris <rgm@gnu.org>
4379 * process.c (Fset_process_inherit_coding_system_flag)
4380 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4381 (Fmake_network_process, Fmake_serial_process): Doc fix.
4383 2012-04-20 Eli Zaretskii <eliz@gnu.org>
4385 * xdisp.c (string_buffer_position_lim): Limit starting position to
4387 (set_cursor_from_row): If called for a mode-line or header-line
4388 row, return zero immediately.
4389 (try_cursor_movement): If inside continuation line, don't back up
4390 farther than the first row after the header line, if any.
4391 Don't consider the header-line row as "partially visible", even if
4392 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4394 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4396 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4399 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
4400 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
4402 configure: new option --enable-gcc-warnings (Bug#11207)
4403 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4404 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4405 (ALL_CFLAGS): Use new macros rather than old.
4406 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4407 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4408 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4409 -Wunused-result, -Wunused-variable. This should go away once
4410 the Emacs and Gnulib regex code is merged.
4411 (xmalloc, xrealloc): Now static.
4413 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4415 * dired.c (Fsystem_groups): Remove unused local.
4417 2012-04-17 Glenn Morris <rgm@gnu.org>
4419 * dired.c (Fsystem_users): Doc fix.
4421 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4423 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4424 (syms_of_dired): Add them.
4426 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4428 Fix minor alloc.c problems found by static checking.
4429 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4430 New extern decls, to avoid calling undeclared functions.
4431 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4432 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4433 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4434 (NEED_MEM_INSERT): New macro.
4435 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4436 Remove one incorrect comment and fix another.
4438 Fix minor ralloc.c problems found by static checking.
4439 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4440 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4441 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4442 (r_alloc_sbrk): Now static.
4444 Improve ralloc.c interface checking.
4445 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4446 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4447 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4448 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4449 [REL_ALLOC]: ... to here, to check interface.
4450 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4451 Remove decls. This fixes an "It stinks!".
4453 * alloc.c (which_symbols): Fix alignment issue / type clash.
4455 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4457 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4458 (struct Lisp_Misc_Any): Likewise.
4459 (struct Lisp_Free): Likewise.
4460 * alloc.c (union aligned_Lisp_Symbol): Define.
4461 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4462 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4463 (union aligned_Lisp_Misc): Define.
4464 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4465 aligned_Lisp_Misc instead of union Lisp_Misc.
4466 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
4468 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4470 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4471 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4472 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4473 * s/netbsd.h, s/sol2-6.h:
4474 Remove definition of GC_MARK_STACK, since the default now works.
4475 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4476 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4477 no longer the default.
4478 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4480 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4482 * lread.c (lisp_file_lexically_bound_p):
4483 Fix hang at ";-*-\n" (bug#11238).
4485 2012-04-14 Eli Zaretskii <eliz@gnu.org>
4487 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4488 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4490 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4492 * nsterm.m (constrainFrameRect): Always constrain when there is only
4493 one screen (Bug#10962).
4495 2012-04-13 Ken Brown <kbrown@cornell.edu>
4497 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4499 2012-04-13 Reuben Thomas <rrt@sc3d.org>
4501 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4503 2012-04-11 Daniel Colascione <dancol@dancol.org>
4505 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4506 against is gone. It's better to use vfork now so that when Cygwin
4507 gains a new, working vfork, we use it automatically (bug#10398).
4509 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4511 * window.c (save_window_save): Obey window-point-insertion-type.
4513 2012-04-11 Glenn Morris <rgm@gnu.org>
4515 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4517 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4519 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4521 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
4523 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4524 (force_quit_count): New var.
4525 (handle_interrupt): Use it.
4527 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
4529 * w32.c (w32_delayed_load): Record the full path of the library
4530 being loaded (bug#10424).
4532 2012-04-09 Glenn Morris <rgm@gnu.org>
4534 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4535 not just in the obarray, before snarfing them. (Bug#11036)
4537 * Makefile.in ($(leimdir)/leim-list.el):
4538 Pass EMACS rather than BUILT_EMACS.
4540 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4542 * process.c (make_process):
4543 * process.h: Add integer `gnutls_handshakes_tried' member to
4546 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4547 Add convenience `GNUTLS_LOG2i' macro.
4549 * gnutls.c (gnutls_log_function2i): Convenience log function.
4550 (emacs_gnutls_read): Use new log functions,
4551 `gnutls_handshakes_tried' process member, and
4552 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4553 attempts per process (connection).
4555 2012-04-09 Chong Yidong <cyd@gnu.org>
4557 * eval.c (Fuser_variable_p, user_variable_p_eh)
4558 (lisp_indirect_variable): Functions deleted.
4559 (Fdefvar): Caller changed.
4561 * callint.c (Finteractive, Fcall_interactively):
4562 * minibuf.c (Fread_variable): Callers changed.
4564 2012-04-09 Eli Zaretskii <eliz@gnu.org>
4566 * xdisp.c (set_cursor_from_row): If the display string appears in
4567 the buffer at position that is closer to point than the position
4568 after the display string, display the cursor on the first glyph of
4569 the display string. Fixes cursor display when a 'display' text
4570 property immediately follows invisible text. (Bug#11094)
4572 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4574 composite.c: use 'double' consistently
4575 * composite.c (get_composition_id): Use 'double' consistently
4576 instead of converting 'float' to 'double' and vice versa; this is
4577 easier to understand and avoids a GCC warning.
4579 2012-04-09 Glenn Morris <rgm@gnu.org>
4581 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4582 preparation for dumping it with emacs. (Bug#4789)
4583 (leimdir): New variable.
4584 ($(leimdir)/leim-list.el): New rule.
4585 (emacs$(EXEEXT)): Depend on leim-list.el.
4587 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4588 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4589 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4591 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4593 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4596 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
4598 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4599 Remove unused local variable.
4601 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4603 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4604 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4605 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4606 objects, as mark_maybe_pointer will catch them otherwise.
4607 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4608 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4610 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4612 Fix typo that broke non-Windows builds.
4613 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4615 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4617 Support building on MS-Windows with libxml2.
4619 * makefile.w32-in (OBJ2): Add xml.$(O).
4620 (GLOBAL_SOURCES): Add xml.c.
4621 ($(BLD)/xml.$(O)): New dependency list.
4623 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4624 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4625 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4626 [!WINDOWSNT]: New macros.
4627 (init_libxml2_functions, libxml2_loaded_p): New functions.
4628 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4629 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4630 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4631 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4633 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4634 Call init_libxml2_functions before calling libxml2 functions.
4635 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4637 * emacs.c: Don't include libxml/parser.h.
4638 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4639 xmlCleanupParser directly.
4641 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4643 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4645 * indent.c (Fvertical_motion): If there is a display string at
4646 point, use it.vpos to compute how many lines to backtrack after
4647 move_it_to point. (Bug#11133)
4649 2012-04-06 Eli Zaretskii <eliz@gnu.org>
4651 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4652 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4653 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4654 macros related to unification of CJK characters. For the details,
4655 see the discussion following the message here:
4656 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4658 2012-04-04 Chong Yidong <cyd@gnu.org>
4660 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4662 2012-04-01 Eli Zaretskii <eliz@gnu.org>
4664 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4665 instead of alloca. (Bug#11138)
4667 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4669 * w32menu.c (is_simple_dialog): Properly check lisp types.
4672 2012-03-31 Eli Zaretskii <eliz@gnu.org>
4674 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4675 position we get to after a call to move_it_to fails the
4676 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4677 only if we wind up in a string from display property. (Bug#11063)
4679 * window.c (Fdelete_other_windows_internal): Invalidate the row
4680 and column information about mouse highlight, so that redisplay
4681 restores it after reallocating the glyph matrices. (Bug#7464)
4683 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4684 string comes from a `display' text property, use the buffer
4685 position of that property as if we actually saw that position in
4687 (move_it_by_lines): Remove the assertion that
4688 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4689 violated when there's a before-string at the beginning of a line.
4692 2012-03-30 Eli Zaretskii <eliz@gnu.org>
4694 * xdisp.c (append_space_for_newline): If the default face was
4695 remapped, use the remapped face for the appended newline.
4696 (extend_face_to_end_of_line): Use the remapped default face for
4697 extending the face to the end of the line.
4698 (display_line): Call extend_face_to_end_of_line when the default
4699 face was remapped. (Bug#11068)
4701 2012-03-29 Eli Zaretskii <eliz@gnu.org>
4703 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4705 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4707 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4709 2012-03-27 Glenn Morris <rgm@gnu.org>
4711 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4714 2012-03-26 Kenichi Handa <handa@m17n.org>
4716 * dispextern.h (struct glyph): Fix previous change. Change the
4717 bit length of glyphless.ch to 25 (Bug#11082).
4719 2012-03-26 Chong Yidong <cyd@gnu.org>
4721 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4722 (command_loop_1): Use it; inhibit selection update for
4723 handle-select-window too (Bug#8996).
4725 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4727 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
4729 2012-03-25 Kenichi Handa <handa@m17n.org>
4731 * dispextern.h (struct glyph): Change the bit length of
4732 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4734 2012-03-24 Eli Zaretskii <eliz@gnu.org>
4736 * s/ms-w32.h (tzname): Include time.h before redirecting to
4737 _tzname. Fixes the MSVC build. (Bug#9960)
4739 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4741 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4744 * xterm.c (XTread_socket): Only modify handling_signal if
4745 !SYNC_INPUT. (Bug#11080)
4747 2012-03-23 Eli Zaretskii <eliz@gnu.org>
4749 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4750 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4751 when fetching a multibyte character consumes more bytes than
4752 CHAR_BYTES returns, due to unification of CJK characters in
4753 string_char. (Bug#11073)
4755 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4757 * process.c (wait_reading_process_output): Handle pty disconnect
4758 by refraining from sending oneself a SIGCHLD (bug#10933).
4760 2012-03-22 Chong Yidong <cyd@gnu.org>
4762 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4764 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
4765 Mark string as coming from a prefix property.
4766 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4767 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4769 2012-03-21 Chong Yidong <cyd@gnu.org>
4771 * xfaces.c (Vface_remapping_alist): Doc fix.
4773 2012-03-20 Eli Zaretskii <eliz@gnu.org>
4775 * w32proc.c (Fw32_set_console_codepage)
4776 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4779 2012-03-20 Chong Yidong <cyd@gnu.org>
4781 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4782 to reflect default non-nil value of redisplay-dont-pause.
4784 2012-03-19 Kenichi Handa <handa@m17n.org>
4786 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4787 it fit in a valid range (Bug#11003).
4789 2012-03-18 Eli Zaretskii <eliz@gnu.org>
4791 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4792 that is not from display property, accept the row as a "cursor
4793 row" if one of the string's character has a non-nil `cursor'
4794 property. Fixes cursor positioning when there are newlines in
4795 overlay strings, e.g. in icomplete.el. (Bug#11035)
4797 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4799 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4801 2012-03-12 Chong Yidong <cyd@gnu.org>
4803 * eval.c (inhibit_lisp_code): Rename from
4804 inhibit_window_configuration_change_hook; move from window.c.
4806 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4807 * window.c (run_window_configuration_change_hook)
4808 (syms_of_window): Callers changed.
4810 2012-03-11 Chong Yidong <cyd@gnu.org>
4812 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4814 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4816 2012-03-10 Chong Yidong <cyd@gnu.org>
4818 * frame.c (other_visible_frames): Don't assume the selected frame
4819 is visible (Bug#10955).
4821 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4823 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4825 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4827 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4828 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4831 2012-03-03 Glenn Morris <rgm@gnu.org>
4833 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
4835 2012-03-02 Eli Zaretskii <eliz@gnu.org>
4837 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4838 position past the first glyph_row that ends at ZV. (Bug#10902)
4839 (redisplay_window, next_element_from_string): Fix typos in
4841 (redisplay_window): Pass to move_it_vertically the margin in
4842 pixels, not in screen lines.
4844 2012-03-02 Glenn Morris <rgm@gnu.org>
4846 * buffer.c (buffer-list-update-hook): Doc fix.
4848 2012-02-29 Eli Zaretskii <eliz@gnu.org>
4850 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4851 push_it before setting up the iterator for the first overlay
4852 string, even if we have an empty string loaded.
4853 (next_overlay_string): If there's an empty string on the iterator
4854 stack, pop the stack. (Bug#10903)
4856 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4858 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4859 Suggested by Stefan Monnier in
4860 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4861 * alloc.c (widen_to_Lisp_Object): New static function.
4862 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4863 and widening them to Lisp_Objects. This would work even if
4864 USE_LSB_TAG is defined and wide integers are used, which might
4865 happen in a future version of Emacs.
4867 2012-02-25 Chong Yidong <cyd@gnu.org>
4869 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4872 * xselect.c (Fx_selection_exists_p): Doc fix.
4873 (x_clipboard_manager_save_all): Print an informative message
4874 before saving to clipboard manager.
4876 2012-02-24 Chong Yidong <cyd@gnu.org>
4878 * keyboard.c (process_special_events): Handle all X selection
4879 requests in kbd_buffer, not just the next one (Bug#8869).
4881 2012-02-23 Chong Yidong <cyd@gnu.org>
4883 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4884 call when setting menu-bar-lines and tool-bar-lines parameters.
4885 (unwind_create_frame_1): New helper function.
4887 * window.c (inhibit_window_configuration_change_hook): New var.
4888 (run_window_configuration_change_hook): Obey it.
4889 (syms_of_window): Initialize it.
4891 2012-02-22 Chong Yidong <cyd@gnu.org>
4893 * xterm.c (x_draw_image_relief): Add missing type check for
4894 Vtool_bar_button_margin (Bug#10743).
4896 2012-02-21 Chong Yidong <cyd@gnu.org>
4898 * fileio.c (Vfile_name_handler_alist): Doc fix.
4900 * buffer.c (Fget_file_buffer): Protect against invalid file
4901 handler return value.
4903 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4905 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4906 when computing $valmask.
4908 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4909 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4910 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4911 It's useless in that case, and it can cause problems on hosts
4912 that allocate halves of EMACS_INT values separately.
4913 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4914 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4915 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4916 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4917 it avoids undefined behavior on hosts where shifting right by more
4918 than the word width has undefined behavior.
4920 2012-02-19 Chong Yidong <cyd@gnu.org>
4922 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4923 (Funhandled_file_name_directory, Ffile_name_as_directory)
4924 (Fdirectory_file_name, Fexpand_file_name)
4925 (Fsubstitute_in_file_name): Protect against invalid file handler
4926 return values (Bug#10845).
4928 2012-02-18 Eli Zaretskii <eliz@gnu.org>
4930 * .gdbinit (pitx): Fix incorrect references to fields of the
4933 2012-02-17 Chong Yidong <cyd@gnu.org>
4935 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4937 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4939 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4940 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4942 2012-02-15 Chong Yidong <cyd@gnu.org>
4944 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4945 marked as special. Also, starting docstrings with * is obsolete.
4947 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4949 * gnutls.c (emacs_gnutls_write): Fix last change.
4951 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4953 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4956 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4958 * keymap.c (Fsingle_key_description): Handle char ranges.
4960 2012-02-12 Chong Yidong <cyd@gnu.org>
4962 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4963 as that creates a dangerous corner case.
4965 * window.c (Fdelete_window_internal): Invalidate the mouse
4966 highlight (Bug#9904).
4968 2012-02-12 Glenn Morris <rgm@gnu.org>
4970 * xselect.c (Fx_own_selection_internal)
4971 (Fx_get_selection_internal, Fx_disown_selection_internal)
4972 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4973 * nsselect.m (Fx_own_selection_internal)
4974 (Fx_disown_selection_internal, Fx_selection_exists_p)
4975 (Fx_selection_owner_p, Fx_get_selection_internal):
4976 Sync docs and argument specs with the xselect.c versions.
4978 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4980 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4982 2012-02-11 Eli Zaretskii <eliz@gnu.org>
4984 * w32select.c (Fx_selection_exists_p): Sync doc string and
4985 argument list with xselect.c. (Bug#10783)
4987 * w16select.c (Fx_selection_exists_p): Sync doc string and
4988 argument list with xselect.c. (Bug#10783)
4990 2012-02-10 Glenn Morris <rgm@gnu.org>
4992 * fns.c (Fsecure_hash): Doc fix.
4994 2012-02-09 Kenichi Handa <handa@m17n.org>
4996 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4998 2012-02-07 Chong Yidong <cyd@gnu.org>
5000 * buffer.c (Fbuffer_local_variables)
5001 (buffer_lisp_local_variables): Handle unbound vars correctly;
5002 don't let Qunbound leak into Lisp.
5004 2012-02-07 Glenn Morris <rgm@gnu.org>
5006 * image.c (Fimagemagick_types): Doc fix.
5008 * image.c (imagemagick-render-type): Change it from a lisp object
5009 to an integer. Move the doc here from the lisp manual.
5010 Treat all values not equal to 0 the same.
5012 2012-02-06 Chong Yidong <cyd@gnu.org>
5014 * doc.c (store_function_docstring): Avoid applying docstring of
5015 alias to base function (Bug#2603).
5017 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5019 * .gdbinit (pp1, pv1): Remove redundant defines.
5022 2012-02-04 Chong Yidong <cyd@gnu.org>
5024 * nsterm.m: Declare a global (Bug#10694).
5026 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5028 * w32.c (get_emacs_configuration_options):
5029 Include --enable-checking, if specified, in the return value.
5031 2012-02-04 Martin Rudalics <rudalics@gmx.at>
5033 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5034 after rounding frame sizes. (Bug#9723)
5036 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5038 * keyboard.c (adjust_point_for_property): Don't position point
5039 before BEGV. (Bug#10696)
5041 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5043 Handle overflow when computing char display width (Bug#9496).
5044 * character.c (char_width): Return EMACS_INT, not int.
5045 (char_width, c_string_width): Check for overflow when
5046 computing the width; this is possible now that individual
5047 characters can have unbounded width. Problem introduced
5048 by merge from Emacs 23 on 2012-01-19.
5050 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
5052 * dbusbind.c (Fdbus_register_method): Mention the return value
5053 :ignore in the docstring.
5055 2012-02-02 Glenn Morris <rgm@gnu.org>
5057 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5059 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5060 Unconditionally set to t. (Bug#10673)
5061 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5062 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5063 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5065 2012-02-02 Kenichi Handa <handa@m17n.org>
5067 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5068 0, do not call append_composite_glyph.
5070 2012-02-02 Kenichi Handa <handa@m17n.org>
5072 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5074 (x_produce_glyphs): If the component of a composition is a null
5075 string, set it->pixel_width to 1 to avoid zero-width glyph.
5077 2012-02-01 Eli Zaretskii <eliz@gnu.org>
5079 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5080 first 2 arguments are identical. This makes inserting large
5081 output from a subprocess an order of magnitude faster on
5082 MS-Windows, where all sbrk'ed memory is always contiguous.
5084 2012-01-31 Glenn Morris <rgm@gnu.org>
5086 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5087 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5088 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5090 2012-01-29 Glenn Morris <rgm@gnu.org>
5092 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5094 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5096 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5098 2012-01-28 Chong Yidong <cyd@gnu.org>
5100 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5102 2012-01-26 Chong Yidong <cyd@gnu.org>
5104 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5106 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5107 repeat counts (Bug#10507).
5109 2012-01-26 Glenn Morris <rgm@gnu.org>
5111 * lread.c (syms_of_lread): Doc fix.
5113 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5115 * coding.c (encode_designation_at_bol): Change return value to
5118 2012-01-25 Chong Yidong <cyd@gnu.org>
5120 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5122 2012-01-21 Chong Yidong <cyd@gnu.org>
5124 * floatfns.c (Fcopysign): Make the second argument non-optional,
5125 since nil is not allowed anyway.
5127 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5129 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5130 (send_process): Likewise.
5132 2012-01-19 Martin Rudalics <rudalics@gmx.at>
5134 * window.c (save_window_save, Fcurrent_window_configuration)
5135 (Vwindow_persistent_parameters): Do not use Qstate.
5136 Rewrite doc-strings.
5138 2012-01-19 Kenichi Handa <handa@m17n.org>
5140 * character.c (char_width): New function.
5141 (Fchar_width, c_string_width, lisp_string_width):
5142 Use char_width (Bug#9496).
5144 2012-01-16 Martin Rudalics <rudalics@gmx.at>
5146 * window.c (Vwindow_persistent_parameters): New variable.
5147 (Fset_window_configuration, save_window_save): Handle persistent
5150 2012-01-14 Eli Zaretskii <eliz@gnu.org>
5152 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5153 thrashing the stack of the thread. (Bug#9087)
5155 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5157 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5159 2012-01-11 Eli Zaretskii <eliz@gnu.org>
5161 * xdisp.c (rows_from_pos_range): Handle the case where the
5162 highlight ends on a newline. (Bug#10464)
5163 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5164 he end column for display of highlight that ends on a newline
5167 2012-01-11 Glenn Morris <rgm@gnu.org>
5169 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5170 from load-path also when installation-directory is nil. (Bug#10208)
5172 2012-01-10 Glenn Morris <rgm@gnu.org>
5174 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5176 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5177 Update template values to be closer to their typical values these days.
5179 2012-01-09 Eli Zaretskii <eliz@gnu.org>
5181 * xdisp.c (rows_from_pos_range): Accept additional argument
5182 DISP_STRING, and accept any glyph in a row whose object is that
5183 string as eligible for mouse highlight. Fixes mouse highlight of
5184 display strings from overlays. (Bug#10464)
5186 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
5188 emacs: fix an auto-save permissions race condition (Bug#10400)
5189 * fileio.c (auto_saving_dir_umask): New static var.
5190 (Fmake_directory_internal): Use it.
5191 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5192 creating the directory. The old code temporarily assigns
5193 too-generous permissions to the directory.
5194 (do_auto_save_eh): Clear it.
5195 (Fdo_auto_save): Catch all errors, not just file errors, so
5196 that the var is always cleared.
5198 2012-01-07 Eli Zaretskii <eliz@gnu.org>
5200 * search.c (scan_buffer): Pass character positions to
5201 know_region_cache, not byte positions. (Bug#6540)
5203 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
5205 * w32.c (sys_rename): Report EXDEV when rename of a directory
5206 fails because the target is on another logical disk. (Bug#10284)
5208 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5210 * xterm.c (x_embed_request_focus): New function.
5212 * xterm.h: Add prototype.
5214 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5216 2012-01-05 Glenn Morris <rgm@gnu.org>
5218 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5220 2012-01-01 Eli Zaretskii <eliz@gnu.org>
5222 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5223 Load gnutls_transport_set_lowat only if GnuTLS version is below
5225 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5226 GnuTLS versions below 2.11.1.
5228 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5230 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5231 to the doc string advising against its use for altering the way
5232 windows are scrolled.
5234 2011-12-28 Kenichi Handa <handa@m17n.org>
5236 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5237 coding-system ASCII compatible only when it does not produce BOM
5238 on encoding (Bug#10383).
5240 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5242 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5244 (create_and_show_popup_menu): Always use menu_position_func for
5247 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5249 * callint.c (Fcall_interactively): Don't truncate prompt string.
5251 2011-12-23 Eli Zaretskii <eliz@gnu.org>
5253 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5254 property that ends at ZV, so that the bidi iteration could be
5255 resumed from there (after widening). (Bug#10360)
5257 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5259 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5261 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5263 * nsterm.m (x_free_frame_resources):
5264 Release f->output_data.ns->miniimage.
5265 (ns_index_color): Fix indentation. Do not retain
5266 color_table->colors[i].
5268 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5271 * nsfns.m (x_set_background_color): Assign return value from
5272 ns_index_color to face-background instead of NSColor*.
5273 (ns_implicitly_set_icon_type): Fix indentation.
5274 Change assignment in for loop to comparison.
5276 * emacs.c (ns_pool): New variable.
5277 (main): Assign ns_pool.
5278 (Fkill_emacs): Call ns_release_autorelease_pool.
5280 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5281 autorelease fdesc, release fdAttrs and tdict.
5282 (ns_get_covering_families): Release charset.
5283 (ns_findfonts): Release NSFontDescriptor created with new.
5284 (ns_uni_to_glyphs): Fix indentation.
5285 (setString): Release attrStr before assigning new value.
5287 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5289 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5291 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5292 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5294 2011-12-18 David Reitter <reitter@cmu.edu>
5296 * nsterm.m (ns_term_init): Subscribe for notifications
5297 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5298 to method trackingNotification in EmacsMenu.
5300 * nsmenu.m (trackingMenu): New variable.
5301 (trackingNotification): New method (from Aquamacs).
5302 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
5303 from Aquamacs (Bug#7030).
5305 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5307 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5308 (symbol_to_nsstring): Fix indentation.
5309 (ns_symbol_to_pb): New function.
5310 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5311 (Fns_rotate_cut_buffers_internal): Remove.
5312 (Fns_store_selection_internal): Rename from
5313 Fns_store_cut_buffer_internal.
5314 (ns_get_foreign_selection, Fx_own_selection_internal)
5315 (Fx_disown_selection_internal, Fx_selection_exists_p)
5316 (Fns_get_selection_internal, Fns_store_selection_internal):
5317 Use ns_symbol_to_pb and check if return value is nil.
5318 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5319 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
5320 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5321 renamed to Sns_store_selection_internal.
5322 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5323 and remove this function.
5324 (ns_handle_selection_clear): Remove, never used.
5325 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5328 2011-12-17 Ken Brown <kbrown@cornell.edu>
5330 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5331 GID is unknown (Bug#10257).
5333 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5335 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5336 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5337 which caused a build failure on GNU/Linux IA-64. This problem was
5338 introduced by my 2011-10-07 patch.
5340 2011-12-15 Juri Linkov <juri@jurta.org>
5342 * image.c (imagemagick_error): New function. (Bug#10112)
5343 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5344 Use `imagemagick_error' where ImageMagick functions return
5346 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5349 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5351 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5352 fill background (Bug#8992).
5354 2011-12-13 Martin Rudalics <rudalics@gmx.at>
5356 * window.c (Vwindow_combination_resize)
5357 (Vwindow_combination_limit): Use t instead of non-nil in
5359 (Vrecenter_redisplay): Add first sentence of doc-string on
5361 (Frecenter): Fix doc-string typo.
5363 2011-12-11 Kenichi Handa <handa@m17n.org>
5365 * coding.c (Funencodable_char_position): Pay attention to the
5366 buffer text relocation (Bug#9389).
5368 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5370 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5371 gtk_init (Bug#10100).
5373 2011-12-10 Eli Zaretskii <eliz@gnu.org>
5375 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5376 IT->string is nil. (Bug#10263)
5378 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5380 * nsterm.h (x_free_frame_resources): Declare.
5382 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5383 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5385 * nsterm.h (ns_get_defaults_value): Declare.
5387 * nsterm.m (ns_default): Call ns_get_defaults_value.
5389 2011-12-09 Eli Zaretskii <eliz@gnu.org>
5391 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5394 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5396 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5397 that where the value of an _OBJC_* symbol points to is in the .bss
5398 section (Bug#10240).
5400 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5402 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
5403 after the loop to call ccl_driver at least once (Bug#8619).
5405 2011-12-08 Kenichi Handa <handa@m17n.org>
5407 * ftfont.c (get_adstyle_property): Fix previous change
5410 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
5412 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5413 dirs from the default value of EMACSLOADPATH (bug#10208).
5415 2011-12-07 Glenn Morris <rgm@gnu.org>
5417 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5418 installation and source directories as well. (Bug#10208)
5420 2011-12-06 Chong Yidong <cyd@gnu.org>
5422 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5424 2011-12-06 Glenn Morris <rgm@gnu.org>
5426 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5427 as an error, not just -1. (Bug#10217)
5429 2011-12-05 Chong Yidong <cyd@gnu.org>
5431 * keyboard.c (process_special_events): New function.
5432 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5434 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5436 * coding.c (encode_designation_at_bol): Don't use uninitialized
5437 local variable (Bug#9318).
5439 2011-12-05 Kenichi Handa <handa@m17n.org>
5441 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5442 return Qnil (Bug#8046, Bug#10193).
5444 2011-12-05 Kenichi Handa <handa@m17n.org>
5446 * coding.c (encode_designation_at_bol): New args charbuf_end and
5447 dst. Return the number of produced bytes. Callers changed.
5448 (coding_set_source): Return how many bytes coding->source was
5450 (coding_set_destination): Return how many bytes
5451 coding->destination was relocated.
5452 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
5453 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5455 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5457 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5458 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5461 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5463 The following changes are to fix Bug#9318.
5465 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5466 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5467 (encode_coding_iso_2022, encode_coding_sjis)
5468 (encode_coding_big5, encode_coding_charset): Use the above macros.
5470 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
5472 * lisp.h (process_quit_flag): Fix external declaration.
5474 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5476 Don't macro-inline non-performance-critical code.
5477 * eval.c (process_quit_flag): New function.
5478 * lisp.h (QUIT): Use it.
5480 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5482 * nsfns.m (get_geometry_from_preferences): New function.
5483 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5485 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5487 * emacs.c (Qkill_emacs): Define.
5488 (syms_of_emacs): Initialize it.
5489 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5490 Qquit_flag to `kill-emacs' instead.
5491 (quit_throw_to_read_char): Add parameter `from_signal'.
5492 All callers changed. Call Fkill_emacs if requested and safe.
5493 * lisp.h (QUIT): Call Fkill_emacs if requested.
5495 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5497 * widget.c (update_wm_hints): Return if wmshell is null.
5498 (widget_update_wm_size_hints): New function.
5500 * widget.h (widget_update_wm_size_hints): Declare.
5502 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5503 widget_update_wm_size_hints (Bug#10104).
5505 2011-12-03 Eli Zaretskii <eliz@gnu.org>
5507 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5508 before a newline, prepare the bidi iterator for consuming the
5509 newline, and keep the current paragraph direction. (Bug#10183)
5510 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
5512 2011-12-02 Juri Linkov <juri@jurta.org>
5514 * search.c (Fword_search_regexp): New Lisp function created from
5515 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5516 (Fword_search_backward, Fword_search_forward)
5517 (Fword_search_backward_lax, Fword_search_forward_lax):
5518 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5519 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5521 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5523 * fileio.c (Finsert_file_contents): Move after-change-function call
5524 to before the "handled:" label, since all "goto handled" appear in
5525 cases where the *-change-functions have already been properly called
5528 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5530 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5531 waiting for input. (Bug#10169)
5533 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5535 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5536 verifies glyph row's hash code--we have just reallocated the
5537 glyphs, so their contents can be complete garbage. (Bug#10164)
5539 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
5541 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5543 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5545 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5546 attributes are tested _before_ calling verify_row_hash, to protect
5547 against GCC re-ordering of the tests. (Bug#10164)
5549 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5551 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5553 * xterm.c (handle_one_xevent): Only set async_visible and friends
5554 if net_wm_state_hidden_seen is non-zero (Bug#10002)
5555 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
5556 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5558 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5560 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5561 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5562 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5563 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5564 All uses changed to use GCPRO1 etc.
5565 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5566 Revert to old implementation (i.e., before 2011-03-11).
5568 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5570 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5571 of scroll runs so as to avoid assigning disabled bogus rows and
5572 unnecessary graphics copy operations.
5574 2011-11-27 Eli Zaretskii <eliz@gnu.org>
5576 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5577 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5578 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5579 (malloc, free, realloc, calloc): Redirect to e_* only when
5582 * lisp.h (GCTYPEBITS): Move before first use.
5583 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5584 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5585 this macro definition.
5587 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5590 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5592 * gtkutil.c (xg_create_frame_widgets):
5593 Call gtk_window_set_has_resize_grip (FALSE) if that function is
5594 present with Gtk+ 2.0.
5596 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5598 * fileio.c (Finsert_file_contents): Undo previous change; see
5599 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5601 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5603 Rename locals to avoid shadowing.
5604 * fileio.c (Finsert_file_contents):
5605 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5606 * process.c (wait_reading_process_output):
5607 Rename inner 'proc' to 'p' to avoid shadowing.
5608 Indent for consistency with usual Emacs style.
5610 2011-11-25 Eli Zaretskii <eliz@gnu.org>
5612 * xdisp.c (redisplay_window): If cursor row is not fully visible
5613 after recentering, and scroll-conservatively is set to a large
5614 number, scroll window by a few more lines to make the cursor fully
5615 visible and out of scroll-margin. (Bug#10105)
5616 (start_display): Don't move to the next line if the display should
5617 start at a newline that is part of a display vector or an overlay
5620 2011-11-24 Juri Linkov <juri@jurta.org>
5622 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5623 after the `MagickPingImage' call. (Bug#10112)
5625 2011-11-23 Chong Yidong <cyd@gnu.org>
5627 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5629 2011-11-23 Martin Rudalics <rudalics@gmx.at>
5631 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5632 making another buffer current. (Bug#10114)
5634 2011-11-23 Glenn Morris <rgm@gnu.org>
5636 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5638 2011-11-23 Chong Yidong <cyd@gnu.org>
5640 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5641 using it (Bug#5984).
5643 2011-11-22 Eli Zaretskii <eliz@gnu.org>
5645 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5646 and header-lines, as they don't have one computed for them.
5649 * .gdbinit (prow): Make displayed values more self-explaining.
5650 Add row's hash code.
5652 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5654 * process.c (wait_reading_process_output): Fix asynchrounous
5655 GnuTLS socket handling on some versions of the GnuTLS library.
5656 (wait_reading_process_output): Add comment and URL.
5658 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5660 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5662 2011-11-21 Chong Yidong <cyd@gnu.org>
5664 * window.c (Fnext_window, Fprevious_window): Doc fix.
5666 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5668 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5670 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5672 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5674 2011-11-20 Martin Rudalics <rudalics@gmx.at>
5676 * window.c (Fset_window_combination_limit): Rename argument
5678 (Vwindow_combination_limit): Remove "status" from doc-string.
5680 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5682 * m/ibms390.h: Remove.
5683 * m/ibms390x.h: Don't include "ibms390.h".
5685 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5687 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5688 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5690 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5692 * casetab.c (Fset_case_table):
5693 * charset.c (Fcharset_after): Fix typos.
5695 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
5697 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5698 Otherwise, valgrind does not work on some platforms.
5699 Problem reported by Andreas Schwab in
5700 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5701 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5702 is set, removing the need for VIRT_ADDRESS_VARIES.
5703 (PURE_P): Use a more-efficient implementation that needs just one
5704 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5705 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5706 to 4 (xorl, subq, cmpq, setbe).
5707 * alloc.c (pure): Always extern now, since that's the
5708 VIRT_ADDR_VARIES behavior.
5709 (PURE_POINTER_P): Use a single comparison, not two, for
5710 consistency with the new puresize.h.
5711 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5712 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5713 Remove VIRT_ADDR_VARIES no longer needed.
5715 2011-11-19 Eli Zaretskii <eliz@gnu.org>
5717 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5718 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5719 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5720 behave as if the cursor position were at the window margin.
5722 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5723 and the cursor position is out of bounds, behave as if the cursor
5724 position were at the window margin. (Bug#10075)
5726 2011-11-18 Chong Yidong <cyd@gnu.org>
5728 * window.c (Fwindow_combination_limit): Make first argument
5729 non-optional, since it is meaningless for live windows like the
5732 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5734 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5736 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5738 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5739 (graft_intervals_into_buffer): Simplify.
5741 2011-11-18 Eli Zaretskii <eliz@gnu.org>
5743 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5744 hash values of the two rows.
5745 (copy_row_except_pointers): Preserve the used[] arrays and the
5746 hash values of the two rows. (Bug#10035)
5747 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
5749 * xdisp.c (row_hash): New function, body extracted from
5750 compute_line_metrics.
5751 (compute_line_metrics): Call row_hash, instead of computing the
5754 * dispnew.c (verify_row_hash): Call row_hash for computing the
5755 hash code of a row, instead of duplicating code from xdisp.c.
5757 * dispextern.h (row_hash): Add prototype.
5759 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5761 * frame.c (delete_frame): Don't delete the terminal when the last
5762 X frame is closed if emacs is built with GTK toolkit.
5764 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
5766 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5768 2011-11-17 Martin Rudalics <rudalics@gmx.at>
5770 * window.c (Vwindow_splits): Rename to
5771 Vwindow_combination_resize. Suggested by Juri Linkov.
5772 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5775 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
5777 * nsfns.m (Fns_font_name):
5778 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
5780 2011-11-16 Martin Rudalics <rudalics@gmx.at>
5782 * window.h (window): Rename slot "nest" to "combination_limit".
5783 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5784 (Fset_window_nest): Rename to Fset_window_combination_limit.
5785 (Vwindow_nest): Rename to Vwindow_combination_limit.
5786 (recombine_windows, make_parent_window, make_window)
5787 (Fsplit_window_internal, saved_window)
5788 (Fset_window_configuration, save_window_save): Rename all
5789 occurrences of window_nest to window_combination_limit.
5791 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
5793 * image.c (imagemagick_load_image): Fix typo.
5795 2011-11-14 Eli Zaretskii <eliz@gnu.org>
5797 * xdisp.c (display_line): Move the call to
5798 highlight_trailing_whitespace before the call to
5799 compute_line_metrics, since the latter needs to see the final
5800 faces of all the glyphs to compute ROW's hash value.
5801 Fixes assertion violations in row_equal_p. (Bug#10035)
5803 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
5805 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5806 just return (bug#10044).
5808 2011-11-12 Eli Zaretskii <eliz@gnu.org>
5810 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5811 with user-defined heap size. Bump the default size of the temacs
5812 heap to 27MB, to avoid memory warning when running temacs.
5813 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5815 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5816 current_matrix and desired_matrix. (Bug#9990)
5817 (verify_row_hash) [XASSERTS]: New function.
5818 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5819 that the hash value of glyph rows is correct.
5821 2011-11-12 Martin Rudalics <rudalics@gmx.at>
5823 * window.h (window): Remove splits slot.
5824 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5825 (Fdelete_other_windows_internal, make_parent_window)
5826 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5827 (Fset_window_configuration, save_window_save): Don't deal with
5828 split status of windows.
5829 (saved_window): Remove splits slot.
5830 (Vwindow_splits): Rewrite doc-string.
5832 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5834 * xfns.c (unwind_create_frame):
5835 * nsfns.m (unwind_create_frame):
5836 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5837 Vframe_list (Bug#9999).
5839 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5841 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
5843 2011-11-11 Kenichi Handa <handa@m17n.org>
5845 * callproc.c (Fcall_process): Set the member dst_multibyte of
5848 2011-11-11 Johan Bockgård <bojohan@gnu.org>
5850 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5851 avoid a crash (bug#9496).
5853 2011-11-09 Chong Yidong <cyd@gnu.org>
5855 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5856 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5858 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5860 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5862 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5864 Avoid some portability problems by eschewing 'extern inline' functions.
5865 The trivial performance wins aren't worth the portability hassles; see
5866 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5868 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5869 (window_box_width, window_box_left, window_box_left_offset)
5870 (window_box_right, window_box_right_offset): Undo previous change,
5871 by removing the "extern"s.
5872 * intervals.c (adjust_intervals_for_insertion)
5873 (adjust_intervals_for_deletion): Undo previous change,
5874 making these static again.
5875 (offset_intervals, temp_set_point_both, temp_set_point)
5876 (copy_intervals_to_string): No longer inline.
5877 * xdisp.c (window_text_bottom_y, window_box_width)
5878 (window_box_height, window_box_left_offset)
5879 (window_box_right_offset, window_box_left, window_box_right)
5880 (window_box): No longer inline.
5882 2011-11-08 Chong Yidong <cyd@gnu.org>
5884 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
5885 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5886 Signal an error if not a live window.
5887 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5888 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5890 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
5892 * lisp.h (syms_of_abbrev): Remove declaration.
5893 Reported by CHENG Gao <chenggao@royau.me>.
5895 2011-11-07 Eli Zaretskii <eliz@gnu.org>
5897 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5898 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5899 of temacs in GUI mode.
5901 2011-11-07 Martin Rudalics <rudalics@gmx.at>
5903 * window.h: Declare delete_all_child_windows instead of
5904 delete_all_subwindows.
5905 * window.c (Fwindow_nest, Fset_window_nest)
5906 (Fset_window_new_total, Fset_window_new_normal)
5907 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5908 (delete_all_subwindows): Rename to delete_all_child_windows.
5909 (Fdelete_other_windows_internal, Fset_window_configuration):
5910 Call delete_all_child_windows instead of delete_all_subwindows.
5911 * frame.c (delete_frame): Call delete_all_child_windows instead
5912 of delete_all_subwindows.
5914 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5916 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5917 This is also needed for porting to any host where GC_MARK_STACK is
5918 not GC_MAKE_GCPROS_NOOPS.
5919 (which_symbols): Use it.
5921 2011-11-07 Kenichi Handa <handa@m17n.org>
5923 * coding.c (coding_set_destination): Check coding->src_pos only
5924 when coding->src_object is a buffer (bug#9910).
5926 * process.c (send_process): Set the member src_multibyte of coding
5927 to 0 (bug#9911) when sending a unibyte text.
5929 * callproc.c (Fcall_process): Set the member src_multibyte of
5930 process_coding to 0 (bug#9912).
5932 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5934 * xmenu.c (cleanup_widget_value_tree): New function.
5935 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5936 calling free_menubar_widget_value_tree directly (Bug#9830).
5938 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5940 Fix some portability problems with 'inline'.
5941 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5942 (window_box_width, window_box_left, window_box_left_offset)
5943 (window_box_right, window_box_right_offset): Declare extern.
5944 Otherwise, these inline functions do not conform to C99 and
5945 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5946 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5947 * intervals.c (adjust_intervals_for_insertion)
5948 (adjust_intervals_for_deletion): Now extern, because otherwise the
5949 extern inline functions 'offset_intervals' couldn't refer to it.
5950 (static_offset_intervals): Remove.
5951 (offset_intervals): Rewrite using the old contents of
5952 static_offset_intervals. The old version didn't conform to C99
5953 because an extern inline function contained a reference to an
5954 identifier with static linkage.
5956 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5958 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5961 2011-11-06 Eli Zaretskii <eliz@gnu.org>
5963 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5964 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5965 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5966 return Qleft_to_right.
5968 2011-11-06 Chong Yidong <cyd@gnu.org>
5970 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5971 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5972 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5973 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5974 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5975 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5976 (Fwindow_vscroll): Doc fix.
5977 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5978 argument, since it makes no sense to pass a live window and for
5979 consistency with window-child.
5981 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5983 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5986 2011-11-05 Jason Rumney <jasonr@gnu.org>
5988 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5989 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5991 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5992 bitwise arithmetic preventing use of unicode-sip and non-truetype
5995 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5997 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6000 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6001 initialization code to keep similarity to xfns.c after changes
6004 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6006 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6007 (unwind_create_frame): New function (Bug#9943).
6008 (Fx_create_frame): Restructure code to be more similar to the one in
6009 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6010 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6011 Move terminal->reference_count++ just before making the frame official
6014 * nsterm.m (x_free_frame_resources): New function.
6015 (x_destroy_window): Move code to x_free_frame_resources.
6017 * xfns.c (unwind_create_frame): Fix comment.
6018 (Fx_create_frame, x_create_tip_frame):
6019 Move terminal->reference_count++ just before making the frame
6020 official. Move initialization of image_cache_refcount and
6021 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6023 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6025 Support MSVC build with newer versions of Visual Studio.
6026 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6027 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6030 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6031 which are not supported by MSVC.
6032 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6033 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6035 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6037 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6039 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6041 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
6043 Support MSVC build with newer versions of Visual Studio.
6044 * w32.c: Don't include w32api.h for MSVC.
6045 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6047 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6048 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6049 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6050 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6052 (alloca) [_MSC_VER]: Define to _alloca.
6054 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6056 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6058 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6060 * xdisp.c (note_mouse_highlight): If either of
6061 previous/next-single-property-change returns nil, treat that as
6062 the beginning or the end of the buffer. (Bug#9955)
6064 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6066 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
6067 label is not null (Bug#9951).
6068 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6071 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6073 * window.c (Fwindow_body_size): Mention in the doc string that the
6074 return value is in frame's canonical units. (Bug#9949)
6076 2011-11-03 Eli Zaretskii <eliz@gnu.org>
6078 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6080 * w32fns.c (unwind_create_frame): If needed, free the glyph
6081 matrices of the partially constructed frame. (Bug#9943)
6082 * xfns.c (unwind_create_frame): Likewise.
6084 2011-11-01 Eli Zaretskii <eliz@gnu.org>
6086 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6087 Don't stop backward scan on the continuation glyph, even though
6088 its CHARPOS is positive.
6089 (mouse_face_from_buffer_pos, note_mouse_highlight):
6090 Rename cover_string to disp_string.
6092 2011-11-01 Martin Rudalics <rudalics@gmx.at>
6094 * window.c (temp_output_buffer_show): Don't use
6095 Vtemp_buffer_show_specifiers.
6096 (Vtemp_buffer_show_specifiers): Remove unused variable.
6098 2011-10-30 Eli Zaretskii <eliz@gnu.org>
6100 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6101 past the beginning of the current glyph matrix.
6103 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6105 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6106 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6107 HAVE_GTK3 (Bug#9869).
6109 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6110 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6112 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6114 * xterm.c: Declare x_handle_net_wm_state to return int.
6115 (handle_one_xevent): Check if we are iconified but don't have
6116 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6117 (get_current_wm_state): Return non-zero if not hidden,
6118 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6119 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6120 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6121 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6123 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6125 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6126 so that this new function doesn't get optimized away by a
6127 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6129 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6131 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6133 2011-10-29 Eli Zaretskii <eliz@gnu.org>
6135 Fix the `xbytecode' command.
6136 * .gdbinit (xprintbytestr): New command.
6137 (xwhichsymbols): Rename from `which'; all callers changed.
6138 (xbytecode): Print the byte-code string as well.
6140 2011-10-29 Kim Storm <storm@cua.dk>
6142 * alloc.c (which_symbols): New function.
6144 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6146 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6149 2011-10-29 Glenn Morris <rgm@gnu.org>
6151 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6152 Not clear what it was for, and it causes various bugs. (Bug#9839)
6154 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6156 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6157 possible random value that matches one of those tested as
6158 condition to clear the mouse face.
6160 2011-10-28 Chong Yidong <cyd@gnu.org>
6162 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6164 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6166 * window.c (make_window): Initialize phys_cursor_on_p.
6168 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6170 * lisp.h (struct Lisp_Symbol): Update comments.
6172 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
6174 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6176 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6178 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6179 <oslsachem@gmail.com> for helping to debug this.
6181 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6182 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6183 (g_b_init_get_glyph_outline_w): New static variables.
6184 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6185 (GetGlyphOutlineW_Proc): New typedefs.
6186 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
6187 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6189 (w32font_open_internal, compute_metrics):
6190 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
6191 instead of calling the "wide" APIs directly.
6193 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6195 * w32.h (syms_of_w32font): Add prototype.
6197 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6199 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6200 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6201 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6202 (Fmove_to_window_line): Doc fix.
6204 2011-10-27 Chong Yidong <cyd@gnu.org>
6206 * process.c (make_process): Set gnutls_state to NULL.
6208 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6209 non-NULL, regardless of GNUTLS_INITSTAGE.
6210 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6211 an error. Set process slots as soon as we allocate them.
6213 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6215 2011-10-27 Chong Yidong <cyd@gnu.org>
6217 * gnutls.c (emacs_gnutls_deinit): New function.
6218 Deallocate credentials structures as well as calling gnutls_deinit.
6219 (Fgnutls_deinit, Fgnutls_boot): Use it.
6221 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6222 (deactivate_process): Call emacs_gnutls_deinit.
6224 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6226 * image.c (x_create_x_image_and_pixmap):
6227 * w32.c (sys_rename, w32_delayed_load):
6228 * w32font.c (fill_in_logfont):
6229 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6231 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
6233 * w32fns.c (w32_default_color_map): New function,
6234 extracted from Fw32_default_color_map.
6235 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
6237 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6239 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6241 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6243 * keyboard.c (test_undefined): New function (bug#9751).
6244 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6246 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6248 * sysdep.c (init_sys_modes): Fix the check for the controlling
6249 terminal (Bug#6649).
6251 2011-10-20 Eli Zaretskii <eliz@gnu.org>
6253 * dispextern.h (struct bidi_it): New member next_en_type.
6255 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6256 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6257 current character, check also for next_en_type being WEAK_EN.
6258 (bidi_resolve_weak): Don't enter the expensive loop if the current
6259 position is before next_en_pos. Record the bidi type of the first
6260 non-ET, non-BN character we find, in addition to its position.
6261 (bidi_level_of_next_char): Invalidate next_en_type when
6262 next_en_pos is over-stepped.
6264 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6266 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6267 * editfns.c: Rewrite current-time-zone so that it invokes
6268 the equivalent of (format-time-string "%Z") to get the time zone name.
6269 This fixes a bug when the time zone name contains characters that
6270 need converting from the system time locale to Emacs internal format.
6271 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6272 that patch fixed format-time-string to do the conversion, but
6273 I forgot to fix current-time-zone.
6274 (format_time_string): New function, containing most of
6275 what Fformat_time_string used to contain.
6276 (Fformat_time_string): Rewrite in terms of format_time_string.
6277 This doesn't change this function's behavior.
6278 (current-time-zone): Rewrite to use format_time_string.
6279 This fixes the bug reported by Michael Schierl in
6280 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6281 Jason Rumney's 2007-06-07 change worked around this bug, but
6283 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6285 2011-10-19 Eli Zaretskii <eliz@gnu.org>
6287 * xdisp.c (start_display): If the character at POS is displayed
6288 via a display vector, reset IT->current.dpvec_index to zero.
6289 (try_window_reusing_current_matrix): If a line ends in a display
6290 vector or the next line starts in a display vector, continue
6291 redrawing the window even though the character position of
6292 start_row was reached.
6295 2011-10-18 Chong Yidong <cyd@gnu.org>
6297 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6298 with nobreak-char-display too.
6300 2011-10-18 Eli Zaretskii <eliz@gnu.org>
6302 Fix part 3 of bug#9771.
6303 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6304 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6305 non-neutral characters if the current character is a paragraph
6306 separator (a.k.a. Newline). This avoids running the same
6307 expensive loop twice, once when we consume the preceding newline
6308 and the other time when the line actually needs to be displayed.
6309 Avoid the loop when we see neutrals on the base embedding level
6310 following a character whose directionality is the same as the
6311 paragraph's. This avoids running the expensive loop when a line
6312 ends in a long sequence of neutrals, like control characters.
6313 Add assertion against STRONG_AL type. Slightly rearrange code
6314 that determines the type of a neutral given the first non-neutral
6316 (bidi_level_of_next_char): Set next_en_pos to zero when
6317 invalidating its info.
6319 2011-10-17 Eli Zaretskii <eliz@gnu.org>
6321 * xdisp.c (push_display_prop): Determine whether to record string
6322 or buffer position by IT->string, not by IT->method. Allow
6323 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
6324 (move_it_vertically_backward): Don't look for character position
6325 immediately after the newline when in a continuation line.
6328 2011-10-15 Martin Rudalics <rudalics@gmx.at>
6330 * window.c (coordinates_in_window): Rewrite and delabelize
6331 vertical border check. (Bug#5357) (Bug#9618)
6333 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6335 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6336 errors in XSetWindowBorder (bug#9310).
6338 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6340 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6341 avoid crash when xmalloc overrun checking is enabled.
6343 2011-10-13 Eli Zaretskii <eliz@gnu.org>
6345 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6346 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6347 cursor motion with <left> and <right> arrow keys.
6349 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6350 some callers set that themselves.
6352 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6354 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6355 display string and the previous row comes from the same string and
6356 is empty. (Bug#9739) (Bug#9738)
6358 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6360 * doc.c (get_doc_string): Encode file name (bug#9735).
6362 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6364 * bidi.c (bidi_level_of_next_char):
6365 * xdisp.c (get_visually_first_element): Remove old incorrect
6366 comments regarding the Unicode Line Separator character.
6368 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6370 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6372 * alloc.c (Fgc_status): Do not access beyond zombies array
6373 boundary if nzombies > MAX_ZOMBIES.
6374 * alloc.c (dump_zombies): Add missing format specifier.
6376 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6378 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6379 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6381 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6382 Some packages use them to denote characters with modifiers.
6384 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6386 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6387 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6388 matching a pp-number. Rename parameter var to var1.
6390 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6392 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6394 2011-10-08 Glenn Morris <rgm@gnu.org>
6396 * callint.c (Fcall_interactively): Give a more explicit error for the
6397 'c' case with a non-character input. (Bug#8479)
6399 2011-10-08 Eli Zaretskii <eliz@gnu.org>
6401 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6403 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6404 lines that are hscrolled on the left.
6406 * dispnew.c (buffer_posn_from_coords): Account for a possible
6407 presence of header-line. (Bug#4426)
6409 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6411 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6412 Don't advertise functionality which we discourage or doesn't work.
6414 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6416 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6417 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6418 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6419 this makes Emacs dump core during garbage collection on rare
6420 occasions. sizeof is obviously inferior to offsetof here, so
6421 stick with offsetof.
6422 (GC_POINTER_ALIGNMENT): New macro.
6423 (mark_memory): Omit 3rd (offset) arg; caller changed.
6424 Don't assume EMACS_INT alignment is the same as pointer alignment.
6426 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6428 * keyboard.c (read_key_sequence_remapped): New var.
6429 (read_key_sequence): Compute remapping in the right buffer.
6430 (command_loop_1): Use read_key_sequence's remapping directly.
6432 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6434 * dired.c (file_name_completion): Don't expand file name.
6435 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6436 before checking file name handler.
6438 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6439 they've been requested explicitly (bug#9591).
6441 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
6443 * keymap.c (Fsingle_key_description): Use make_specified_string
6444 instead of build_string to build string from push_key_description.
6447 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6449 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6450 This fixes a Y2038 bug on 64-bit hosts.
6451 * buffer.c (reset_buffer):
6452 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6453 (Fclear_buffer_auto_save_failure):
6454 Use 0, not -1, to represent an unset failure time, since time_t
6455 might not be signed.
6457 Remove dependency on glibc malloc internals.
6458 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6459 Move back here from lisp.h, but with their new implementations.
6460 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6461 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6462 * charset.c (charset_table_init): New static var.
6463 (syms_of_charset): Use it instead of xmalloc. This removes a
6464 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6465 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6466 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6467 Move back to alloc.c.
6468 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6469 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6471 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6473 * nsterm.m (windowDidResize): Call x_set_window_size only when
6474 ns_in_resize is true. Otherwise set pixelwidth/height and
6475 call change_frame_size (Bug#9628).
6477 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6479 Port --enable-checking=all to Fedora 14 x86-64.
6480 * charset.c (syms_of_charset): Also account for glibc malloc's
6481 internal overhead when calculating the initial malloc maximum.
6483 Port --enable-checking=all to Fedora 14 x86.
6484 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6486 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6487 (overrun_check_realloc, overrun_check_free):
6488 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6489 That way, xmalloc returns a properly-aligned pointer even if
6490 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6491 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6492 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6493 into account when calculating the initial malloc maximum.
6494 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6495 Move here from alloc.c, so that charset.c can use it too.
6496 Properly align; the old code wasn't right for common 32-bit hosts
6497 when configured with --enable-checking=all.
6498 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6499 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6501 2011-09-29 Eli Zaretskii <eliz@gnu.org>
6503 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
6506 2011-09-28 Eli Zaretskii <eliz@gnu.org>
6508 * xdisp.c (compute_display_string_end): If there's no display
6509 string at CHARPOS, return -1.
6511 * bidi.c (bidi_fetch_char): When compute_display_string_end
6512 returns a negative value, treat the character as a normal
6513 character not covered by a display string. (Bug#9624)
6515 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
6517 * lread.c (Fread_from_string): Fix typo in docstring.
6519 2011-09-27 Eli Zaretskii <eliz@gnu.org>
6521 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6522 newline, reseat the iterator instead of bidi-iterating there one
6523 character at a time. (Bug#9610)
6524 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6525 TO_CHARPOS if the bidi iterator is at base embedding level.
6527 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6529 * lread.c (readevalloop): Use correct code for NBSP.
6530 (read1): Likewise. (Bug#9608)
6532 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
6534 * dbusbind.c (Fdbus_register_signal): When service is not
6535 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6537 2011-09-25 Glenn Morris <rgm@gnu.org>
6539 * buffer.c (truncate-lines): Doc fix.
6541 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
6543 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6544 (Fset_window_next_buffers): Doc fix.
6546 2011-09-24 Glenn Morris <rgm@gnu.org>
6548 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6550 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6552 Fix minor problems found by static checking.
6553 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
6554 * indent.c (Fvertical_motion): Fix == vs = typo.
6556 2011-09-24 Eli Zaretskii <eliz@gnu.org>
6558 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6559 Default value is now t. Doc fix.
6561 * indent.c (Fvertical_motion): Compute and apply the overshoot
6562 logic when moving up, not only when moving down. Fix the
6563 confusing name and values of the it_overshoot_expected variable;
6564 logic changes accordingly. (Bug#9254) (Bug#9549)
6566 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6567 CHARPOS is covered by a display string which includes newlines.
6568 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6569 is covered by a display string with embedded newlines.
6571 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
6573 * dbusbind.c (Fdbus_register_signal): Add match rule to
6574 Vdbus_registered_objects_table. (Bug#9581)
6575 (Fdbus_register_method, Vdbus_registered_objects_table):
6578 2011-09-24 Jim Meyering <meyering@redhat.com>
6580 do not ignore write error for any output size
6581 The previous change was incomplete.
6582 While it makes emacs --batch detect the vast majority of stdout
6583 write failures, errors were still ignored whenever the output size is
6584 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6585 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6586 && echo FAIL: ignored write error
6587 FAIL: ignored write error
6588 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6589 && echo FAIL: ignored write error
6590 FAIL: ignored write error
6591 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6593 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6595 * emacs.c (Fkill_emacs): In noninteractive mode exit
6596 non-successfully if a write error occurred on stdout. (Bug#9574)
6598 2011-09-21 Eli Zaretskii <eliz@gnu.org>
6600 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6603 * dispextern.h (struct it): Update the comment documenting what
6606 2011-09-20 Eli Zaretskii <eliz@gnu.org>
6608 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6609 a display string, extend search for cursor position to end of row.
6610 (find_row_edges): If the row ends in a newline from a display
6611 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6612 Handle the case of a display string with multiple newlines.
6613 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6614 non-empty line. Fixes confusing cursor motion with arrow keys at
6615 the beginning of a line that starts with whitespace.
6617 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6619 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6622 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
6624 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6627 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6629 * xdisp.c (display_line): Record maximum and minimum buffer
6630 positions even if no glyphs were produced (e.g., by a zero-width
6631 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6632 buffer positions that will be removed from the glyph row because
6634 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6635 column is beyond frame width: don't subtract 1 "pixel" when
6636 computing width of the stretch.
6637 (reseat_at_next_visible_line_start): Undo the change made on
6638 2011-09-17 that saved paragraph information and restored it after
6639 the call to `reseat'. (Bug#9545)
6641 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6643 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6644 and turn window cursor on if cleared (Bug#9415).
6646 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
6648 * search.c (boyer_moore): Take unibyte characters from pattern
6649 literally. (Bug#9458)
6651 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6653 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6655 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6657 Fix minor problem found by static checking.
6658 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6659 initialized, to pacify gcc -Wuninitialized.
6661 * fileio.c: Report proper errno when syscall falls.
6662 (Finsert_file_contents): Save and restore errno,
6663 so that report_file_error outputs the correct diagnostic.
6664 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6666 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6668 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6670 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6672 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6673 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6675 2011-09-17 Eli Zaretskii <eliz@gnu.org>
6677 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6678 about the current paragraph and restore it after the call to reseat.
6680 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6681 (bidi_find_paragraph_start): Search back for paragraph beginning
6682 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6683 (bidi_move_to_visually_next): Only trigger paragraph-related
6684 computations when the last character is a newline or at EOB, not
6685 just any NEUTRAL_B. (Bug#9470)
6687 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6688 truncated lines if point is covered by a display string. (Bug#9524)
6690 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6692 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6693 (cons_to_x_long): New function.
6694 (lisp_data_to_selection_data): Use it. Correct the test for
6695 short-versus-long data; it was negated. Break out of vector
6696 loop, for efficiency, when a long datum is discovered.
6698 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6700 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6702 2011-09-16 Eli Zaretskii <eliz@gnu.org>
6704 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6705 GCC PR/17406) by declaring this function with external scope.
6707 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6709 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6710 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6712 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6714 * editfns.c (Fformat): Correctly handle text properties on "%%".
6716 2011-09-15 Eli Zaretskii <eliz@gnu.org>
6718 * xterm.c (x_draw_composite_glyph_string_foreground):
6719 * w32term.c (x_draw_composite_glyph_string_foreground):
6720 * term.c (encode_terminal_code):
6721 * composite.c (composition_update_it, get_composition_id):
6722 * xdisp.c (get_next_display_element)
6723 (fill_composite_glyph_string): Add comments about special meaning
6724 of TAB characters in a composition.
6726 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6728 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
6729 This occurs when processing a multibyte format.
6730 Problem reported by Wolfgang Jenker.
6732 2011-09-15 Johan Bockgård <bojohan@gnu.org>
6734 * xdisp.c (try_cursor_movement): Only check for exact match if
6735 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6737 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6739 Remove unused external symbols.
6740 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6741 * xdisp.c (calc_pixel_width_or_height): Now static.
6742 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6743 * indent.c (check_display_width):
6744 * w32term.c: Fix comment to match code.
6745 * xterm.c, xterm.h (x_catching_errors): Remove.
6747 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6749 * xselect.c: Use signed conversions more consistently (Bug#9498).
6750 (selection_data_to_lisp_data): Assume incoming selection data are
6751 signed integers, not unsigned. This is to be consistent with
6752 outgoing selection data, which was modified to use signed integers
6753 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6754 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6755 expects long, not unsigned long.
6757 2011-09-14 Eli Zaretskii <eliz@gnu.org>
6759 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6760 computation of loop end. Reported by Johan Bockgård
6763 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
6765 * frame.c (Fother_visible_frames_p): Function deleted.
6767 2011-09-12 Eli Zaretskii <eliz@gnu.org>
6769 * indent.c (compute_motion): Process display vector front to back
6770 rather than the other way around. (Bug#2496)
6772 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6774 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6776 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
6778 * minibuf.c (Fread_from_minibuffer): Doc fix.
6780 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6782 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6783 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6785 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6787 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6788 value for non-existent files.
6790 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6792 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6793 set its "size" to -1. This will set the modtime_size field of
6794 the corresponding buffer to -1, which is what
6795 verify-visited-file-modtime expects for files that do not exist.
6798 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6800 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6802 * lisp.h: ... from here. push_key_description is no longer
6803 defined in keyboard.c, so its declaration should not be in
6804 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6805 logically belongs with push_key_description.
6807 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6809 * buffer.h: Include <sys/types.h> instead of <time.h>.
6810 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6811 Problem reported by Herbert J. Skuhra.
6813 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6815 * xml.c (parse_region): Make the parsing work for
6816 non-comment-starting XML files again (bug#9144).
6818 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6820 * image.c (gif_load): Fix calculation of bottom and right corner.
6823 2011-09-10 Eli Zaretskii <eliz@gnu.org>
6825 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6826 redisplay in small windows.
6828 2011-09-09 Eli Zaretskii <eliz@gnu.org>
6830 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6832 2011-09-08 Martin Rudalics <rudalics@gmx.at>
6834 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6835 Operate on live windows only.
6837 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
6839 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6841 2011-09-07 Eli Zaretskii <eliz@gnu.org>
6843 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6844 only under bidi iteration.
6846 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6848 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6850 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6852 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6853 Without this fix, the command to link temacs failed due to an
6854 undefined symbol __builtin_isnan. This is because
6855 /usr/include/iso/math_c99.h #defines isnan(x) to
6856 __builtin_isnan(x), but the bundled gcc, which identifies itself
6857 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6859 * floatfns.c (isnan): #undef, and then #define to a clone of
6861 (Fisnan): Always define, since it's always available now.
6862 (syms_of_floatfns): Always define isnan at the Lisp level.
6864 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6866 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6868 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6870 * fileio.c: Fix bugs with large file offsets (Bug#9428).
6871 The previous code assumed that file offsets (off_t values) fit in
6872 EMACS_INT variables, which is not true on typical 32-bit hosts.
6873 The code messed up by falsely reporting buffer overflow in cases
6874 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6875 when "big" contains more than 2**29 bytes, even though this
6876 inserts just one byte and does not overflow the buffer.
6877 (Finsert_file_contents): Store file offsets as off_t
6878 values, not as EMACS_INT values. Check for overflow when
6879 converting between EMACS_INT and off_t. When checking for
6880 buffer overflow or for overlap, take the offsets into account.
6881 Don't use EMACS_INT for small values where int suffices.
6882 When checking for overlap, fix a typo: ZV was used where
6883 ZV_BYTE was intended.
6884 (Fwrite_region): Don't assume off_t fits into 'long'.
6885 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6887 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
6889 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6891 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6893 sprintf-related integer and memory overflow issues (Bug#9412).
6895 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6896 (esprintf, exprintf, evxprintf): New functions.
6897 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6898 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
6899 (modify_event_symbol): Do not assume that the length of
6900 name_alist_or_stem is safe to alloca and fits in int.
6901 (Fexecute_extended_command): Likewise for function name and binding.
6902 (Frecursion_depth): Wrap around reliably on integer overflow.
6903 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6904 since some callers pass EMACS_INT values.
6905 (Fsingle_key_description): Don't crash if symbol name contains more
6906 than MAX_ALLOCA bytes.
6907 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6908 (get_minibuffer): Arg is now EMACS_INT, not int.
6909 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
6910 (esprintf, exprintf, evxprintf): New decls.
6911 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6913 * dbusbind.c (signature_cat): New function.
6914 (xd_signature, Fdbus_register_signal):
6915 Do not overrun buffer; instead, report string overflow.
6917 * dispnew.c (add_window_display_history): Don't overrun buffer.
6918 Truncate instead; this is OK since it's just a log.
6920 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6921 even if the time zone offset is outlandishly large.
6922 Don't mishandle offset == INT_MIN.
6924 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6925 when creating daemon; the previous buffer-overflow check was incorrect.
6927 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6928 which has the guts of the old verror function.
6930 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6931 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6933 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6934 (font_unparse_xlfd): Don't blindly alloca long strings.
6935 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
6936 fits in int, when using sprintf. Use single snprintf to count
6937 length of string rather than counting it via multiple sprintfs;
6938 that's simpler and more reliable.
6939 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6940 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6941 sprintf, in case result does not fit in int.
6943 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6944 (fontset_from_font): Print it.
6946 * frame.c (tty_frame_count): Now printmax_t, not int.
6947 (make_terminal_frame, set_term_frame_name): Print it.
6948 (x_report_frame_params): In X, window IDs are unsigned long,
6949 not signed long, so print them as unsigned.
6950 (validate_x_resource_name): Check for implausibly long names,
6951 and don't assume name length fits in 'int'.
6952 (x_get_resource_string): Don't blindly alloca invocation name;
6953 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6956 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6957 (xg_check_special_colors, xg_set_geometry):
6958 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6960 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6961 Use esprintf, not sprintf, in case result does not fit in int.
6963 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6964 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6965 it as a large positive number.
6966 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6967 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6969 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6970 in case result does not fit in int.
6972 * print.c (float_to_string): Detect width overflow more reliably.
6973 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6974 buffer overrun. Don't assume list length fits in 'int'. Treat
6975 print length of 0 as 0, not as infinity; to be consistent with other
6976 uses of print length in this function. Don't overflow print length
6977 index. Don't assume hash table size fits in 'long', or that
6978 vectorlike size fits in 'unsigned long'.
6980 * process.c (make_process): Use printmax_t, not int, to format
6981 process-name gensyms.
6983 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6985 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6986 to avoid potential buffer overrun.
6988 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6989 if X resource line is longer than 512 bytes.
6991 * xfns.c (x_window): Make sprintf buffer a bit bigger
6992 to avoid potential buffer overrun.
6994 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6996 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6998 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7000 Integer overflow fixes for scrolling, etc.
7001 Without these, Emacs silently mishandles large integers sometimes.
7002 For example, "C-u 4294967297 M-x recenter" was treated as if
7003 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7005 * xdisp.c (try_window_id): Check Emacs fixnum range before
7006 converting to 'int'.
7008 * window.c (window_scroll_line_based, Frecenter):
7009 Check that an Emacs fixnum is in range before assigning it to 'int'.
7010 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7011 values converted from Emacs fixnums.
7012 (Frecenter): Don't wrap around a line count if it is out of 'int'
7013 range; instead, treat it as an extreme value.
7014 (Fset_window_configuration, compare_window_configurations):
7015 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7017 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7018 that can exceed INT_MAX. Check that EMACS_INT value is in range
7019 before assigning it to the (possibly-narrower) index.
7020 (match_limit): Don't assume that a fixnum can fit in 'int'.
7022 * print.c (print_object): Use ptrdiff_t, not int, for index that can
7025 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
7026 (Fvertical_motion): Don't wrap around LINES values that don't fit
7027 in 'int'. Instead, treat them as extreme values. This is good
7028 enough for windows, which can't have more than INT_MAX lines anyway.
7030 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7032 * Require libxml/parser.h to avoid compilation warning.
7034 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7036 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7037 since this reportedly can destroy thread storage.
7039 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
7041 * syntax.c (find_defun_start): Update all cache variables if
7042 exiting early (Bug#9401).
7044 2011-08-30 Eli Zaretskii <eliz@gnu.org>
7046 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7048 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7049 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7050 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7052 * term.c (tty_append_glyph): New function.
7053 (produce_stretch_glyph): Static function and its prototype deleted.
7055 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7058 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7060 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7061 when checking :margin (Bug#9390).
7062 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
7063 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
7064 so that the name doesn't mislead. All uses changed.
7066 2011-08-28 Johan Bockgård <bojohan@gnu.org>
7068 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7071 2011-08-27 Eli Zaretskii <eliz@gnu.org>
7073 * xdisp.c (move_it_to): Don't bail out early when reaching
7074 position beyond to_charpos, if we are scanning backwards.
7075 (move_it_vertically_backward): When DY == 0, make sure we get to
7076 the first character in the line after the newline.
7078 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7080 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7081 (ccl_driver): Do not generate an out-of-range pointer.
7082 (Fccl_execute_on_string): Remove unnecessary check for
7083 integer overflow, noted by Stefan Monnier in
7084 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7085 Remove a FIXME that didn't need fixing.
7086 Simplify the newly-introduced buffer reallocation code.
7088 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
7090 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7092 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
7094 Integer and memory overflow issues (Bug#9196).
7096 * doc.c (get_doc_string): Rework so that
7097 get_doc_string_buffer_size is the actual buffer size, rather than
7098 being 1 less than the actual buffer size; this makes xpalloc more
7101 * image.c (x_allocate_bitmap_record, cache_image):
7102 * xselect.c (Fx_register_dnd_atom):
7103 Simplify previous changes by using xpalloc.
7105 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7106 since either will do and ptrdiff_t is convenient with xpalloc.
7108 * charset.c (charset_table_size)
7109 (struct charset_sort_data.priority): Now ptrdiff_t.
7110 (charset_compare): Don't overflow if priorities differ greatly.
7111 (Fsort_charsets): Don't assume list length fits in int.
7112 Check for size-calculation overflow when allocating sort data.
7113 (syms_of_charset): Allocate an initial charset table that is
7114 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7116 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7118 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7119 The actual value is always <= INT_MAX, and leaving it unsigned made
7120 overflow checking harder.
7122 * dispextern.h (struct glyph_matrix.rows_allocated)
7123 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7124 with xpalloc. The values are still always <= INT_MAX.
7126 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7128 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7129 (SAFE_NALLOCA): New macro.
7131 * region-cache.c (struct boundary.pos, find_cache_boundary)
7132 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7133 (set_cache_region, invalidate_region_cache)
7134 (revalidate_region_cache, know_region_cache, region_cache_forward)
7135 (region_cache_backward, pp_cache):
7136 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7137 so that ptrdiff_t * can be passed to xpalloc.
7138 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7139 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7140 (pp_cache): Don't assume cache_len fits in int.
7141 * region-cache.h: Adjust extern decls to match.
7143 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7144 EMACS_INT, since either will do, for xpalloc.
7146 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7147 (xnmalloc, xnrealloc, xpalloc): New functions.
7149 * bidi.c (bidi_shelve_header_size): New constant.
7150 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7151 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7153 * bidi.c (bidi_cache_shrink):
7154 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7156 Don't update size of array until after memory allocation succeeds,
7157 because xmalloc/xrealloc may not return.
7158 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7159 now that we have proper integer overflow checking.
7160 (record_overlay_string, overlay_strings): Catch overflows when
7161 calculating size of overlay_str_buf.
7163 * callproc.c (Fcall_process): Check for size overflow when
7164 calculating size of args2.
7165 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7166 Normally we prefer signed values, but sticking with ptrdiff_t would
7167 require adding more-complicated checks.
7169 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7170 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7171 Redo buffer-overflow calculations to avoid integer overflow.
7172 Add a FIXME comment where memory seems to be over-allocated.
7174 * character.c (Fstring): Check for size-calculation overflow.
7176 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7177 unnecessary integer overflow. Check for size overflow.
7178 (encode_coding_object): Don't update size until xmalloc succeeds.
7180 * composite.c (get_composition_id): Check for overflow in glyph
7181 length calculations.
7183 Integer and memory overflow fixes for display code.
7184 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7185 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7186 (scrolling_window): Check for overflow in size calculations.
7187 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7188 Don't assume glyph table len fits in int.
7189 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7190 (row_table_size): Now ptrdiff_t, not int.
7191 (scrolling_window): Avoid overflow in size calculations.
7192 Don't update size until allocation succeeds.
7193 * fns.c (concat): Check for overflow in size calculations.
7194 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7195 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7196 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7198 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7199 (get_doc_string): Check for size calculation overflow.
7200 Don't update size until allocation succeeds.
7201 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7202 EMACS_INT, where ptrdiff_t will do.
7203 (Fsubstitute_command_keys): Check for string overflow.
7205 * editfns.c (set_time_zone_rule): Don't assume environment length
7207 (message_length): Now ptrdiff_t, not int.
7208 (Fmessage_box): Don't update size until allocation succeeds.
7209 Don't assume message length fits in int.
7210 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7212 * emacs.c (main): Do not reallocate argv, since there is a null at
7213 the end that can be overwritten, and this way there's no need to
7214 worry about size-calculation overflow.
7215 (sort_args): Check for size-calculation overflow.
7217 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7219 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7221 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7222 (x_set_scroll_bar_width, x_figure_window_size):
7223 Check for integer overflow.
7224 (x_set_alpha): Do not assume XINT fits in int.
7226 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7227 This is for the members text_lines, text_cols, total_lines, total_cols,
7228 where the system imposes an 'int' limit.
7230 * fringe.c (Fdefine_fringe_bitmap):
7231 Don't update size until alloc works.
7233 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7234 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7236 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7237 Check for size-calculation overflow.
7238 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7239 do, as we prefer signed integers.
7240 (id_to_widget.max_size, id_to_widget.used)
7241 (xg_store_widget_in_map, xg_remove_widget_from_map)
7242 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7243 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7244 Use and return ptrdiff_t, not int.
7245 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7246 * gtkutil.h: Change prototypes to match the above.
7248 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7249 are duplicate now that they've been promoted to lisp.h.
7250 (x_allocate_bitmap_record, x_alloc_image_color)
7251 (make_image_cache, cache_image, xpm_load):
7252 Don't update size until alloc is done.
7253 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7255 Check for size calculation overflow.
7256 (ct_colors_allocated_max): New constant.
7257 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7260 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7261 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7262 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7263 Use ptrdiff_t, not int, to count maps.
7264 (read_char_minibuf_menu_prompt): Check for overflow in size
7265 calculations. Don't update size until allocation succeeds.
7266 Redo calculations to avoid overflow.
7267 * keyboard.h: Change prototypes to match the above.
7269 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7271 (current_minor_maps): Check for size calculation overflow.
7272 * keymap.h: Change prototypes to match the above.
7274 * lread.c (read1, init_obarray): Don't update size until alloc done.
7276 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7277 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7279 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7280 Now ptrdiff_t, not int.
7281 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7282 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7284 * process.c (Fnetwork_interface_list): Check for overflow
7285 in size calculation.
7287 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7289 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7290 overflow. Don't bother calling xmalloc when xrealloc will do.
7292 * search.c (Freplace_match): Check for size calculation overflow.
7293 (Fset_match_data): Don't assume list lengths fit in 'int'.
7295 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7296 for command line length. Do not attempt to address one before the
7297 beginning of an array, as that's not portable.
7299 * term.c (max_frame_lines): Remove; unused.
7300 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7302 (encode_terminal_code, calculate_costs): Check for size
7303 calculation overflow.
7304 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7305 table lengths and related sizes. Don't update size until alloc
7306 done. Redo calculations to avoid overflow.
7307 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7309 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7310 subtracting pointers.
7311 (gobble_line): Check for overflow more carefully. Don't update size
7314 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7315 Don't update size until alloc done.
7316 Redo size calculations to avoid overflow.
7317 Check for size calculation overflow.
7318 (main) [DEBUG]: Fix typo in invoking tparam1.
7320 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7321 Use ptrdiff_t, not int, for sizes.
7322 (store_mode_line_noprop_char): Don't update size until alloc done.
7324 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7325 Use ptrdiff_t, not int, for sizes.
7326 (Finternal_make_lisp_face, cache_face):
7327 Check for size calculation overflow.
7328 (cache_face): Treat size calculation overflows as if they were
7329 memory exhaustion (the usual treatment), rather than aborting.
7331 * xfns.c (x_encode_text, x_set_name_internal)
7332 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7333 sizes, since they can exceed INT_MAX in size. Check for size
7334 calculation overflow.
7336 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7337 (xg_select): Check for size calculation overflow.
7338 Don't update size until alloc done.
7340 * xrdb.c (get_environ_db): Don't assume path length fits in int,
7341 as sprintf is limited to int lengths.
7343 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7344 (X_LONG_MIN): New macros.
7345 Use them to make the following changes clearer.
7346 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7347 This change doesn't affect the value now, but it may help remind
7348 future maintainers not to raise the value too much later.
7349 (SELECTION_QUANTUM): Remove, replacing with ...
7350 (selection_quantum): ... new function, which avoids overflow.
7352 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7353 assumption that selection length fits in 'int'.
7354 (x_reply_selection_request, x_handle_selection_request)
7355 (x_get_window_property, receive_incremental_selection)
7356 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7357 (lisp_data_to_selection_data, clean_local_selection_data):
7358 Use ptrdiff_t, not int, to record length of selection.
7359 (x_reply_selection_request, x_get_window_property)
7360 (receive_incremental_selection, x_property_data_to_lisp):
7361 Redo calculations to avoid overflow.
7362 (x_reply_selection_request): When sending hint, ceiling it at
7363 X_LONG_MAX rather than relying on wraparound overflow to send
7365 (x_get_window_property, receive_incremental_selection)
7366 (lisp_data_to_selection_data, x_property_data_to_lisp):
7367 Check for size-calculation overflow.
7368 (x_get_window_property, receive_incremental_selection)
7369 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7370 Don't store size until memory allocation succeeds.
7371 (x_get_window_property): Plug memory leak on memory exhaustion.
7372 Don't double-block input; malloc is safe here. Don't assume 2**34
7373 - 4 fits in unsigned long. Add an xassert to check
7374 XGetWindowProperty overflow. Be more careful about overflow
7375 calculations, and distinguish size from memory overflow better.
7376 (receive_incremental_selection): When tracing, don't assume
7377 unsigned int is less than INT_MAX.
7378 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7379 harmful) conversions of unsigned short to int.
7380 (lisp_data_to_selection_data): Don't assume that integers
7381 in the range -65535 through -1 fit in an X unsigned short.
7382 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7383 result parameters unless successful. Rely on cons_to_unsigned
7384 to report problems with elements; the old code wasn't right anyway.
7385 (x_check_property_data): Check for int overflow; we cannot use
7386 a wider type due to X limits.
7387 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7389 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
7391 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7392 (x_term_init): Check for size calculation overflow.
7393 (x_color_cells): Don't store size until memory allocation succeeds.
7394 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
7395 Don't assume alloca size is less than MAX_ALLOCA.
7396 (x_term_init): Don't assume length fits in int (sprintf is limited
7399 Use ptrdiff_t for composition IDs.
7400 * character.c (lisp_string_width):
7401 * composite.c (composition_table_size, n_compositions)
7402 (get_composition_id, composition_gstring_from_id):
7403 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7404 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7405 * window.c (Frecenter):
7406 Use ptrdiff_t, not int, for composition IDs.
7407 * composite.c (get_composition_id): Check for integer overflow.
7408 * composite.h: Adjust prototypes to match the above changes.
7410 Use ptrdiff_t for hash table indexes.
7411 * category.c (hash_get_category_set):
7412 * ccl.c (ccl_driver):
7413 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7414 * coding.c (coding_system_charset_list, detect_coding_system):
7415 * coding.h (struct coding_system.id):
7416 * composite.c (get_composition_id, gstring_lookup_cache):
7417 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7418 * image.c (xpm_get_color_table_h):
7419 * lisp.h (hash_lookup, hash_put):
7420 * minibuf.c (Ftest_completion):
7421 Use ptrdiff_t for hash table indexes, not int (which is too
7422 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7423 32-bit --with-wide-int hosts).
7425 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7426 Add a FIXME comment about memory leaks.
7427 (syms_of_charset): Don't assume xmalloc returns.
7429 Don't assume that stated character widths fit in int.
7430 * character.c (Fchar_width, c_string_width, lisp_string_width):
7431 * character.h (CHAR_WIDTH):
7432 * indent.c (MULTIBYTE_BYTES_WIDTH):
7433 Use sanitize_char_width to avoid undefined and/or bad behavior
7434 with outlandish widths.
7435 * character.h (sanitize_tab_width): Rename from sanitize_width,
7436 now that we have two such functions. All uses changed.
7437 (sanitize_char_width): New inline function.
7439 Don't assume that tab-width fits in int.
7440 * character.h (sanitize_width): New inline function.
7441 (SANE_TAB_WIDTH): New macro.
7442 (ASCII_CHAR_WIDTH): Use it.
7443 * indent.c (sane_tab_width): Remove. All uses replaced by
7444 SANE_TAB_WIDTH (current_buffer).
7445 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7447 * fileio.c: Integer overflow issues with file modes.
7448 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7450 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7451 Remove unreachable code.
7452 (read_hex, load_charset_map_from_file): Check for integer overflow.
7454 * xterm.c: Don't go over XClientMessageEvent limit.
7455 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7456 (x_send_scroll_bar_event): Likewise. Check that the size does not
7457 exceed limits imposed by XClientMessageEvent, as well as the usual
7458 ptrdiff_t and size_t limits.
7460 * keyboard.c: Overflow, signedness and related fixes.
7461 (make_lispy_movement): Use same integer type in forward decl
7462 that is used in the definition.
7463 (read_key_sequence, keyremap_step):
7464 Change bufsize argument back to int, undoing my 2011-03-30 change.
7465 We prefer signed types, and int is wide enough here.
7466 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7467 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7468 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7469 length, not size_t. Use ptrdiff_t for index, not int.
7470 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7471 possibility of integer overflow.
7473 Overflow, signedness and related fixes for images.
7475 * dispextern.h (struct it.stack[0].u.image.image_id)
7476 (struct_it.image_id, struct image.id, struct image_cache.size)
7477 (struct image_cache.used, struct image_cache.ref_count):
7478 * gtkutil.c (update_frame_tool_bar):
7479 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7480 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7481 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7482 * nsmenu.m (update_frame_tool_bar):
7483 * xdisp.c (calc_pixel_width_or_height):
7484 * xfns.c (image_cache_refcount):
7485 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7486 on typical 64-bit hosts.
7488 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7489 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7490 Omit unnecessary casts to int.
7491 (parse_image_spec): Check that integers fall into 'int' range
7492 when the callers expect that.
7493 (image_ascent): Redo ascent calculation to avoid int overflow.
7494 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7495 (lookup_image): Remove unnecessary tests.
7496 (xbm_image_p): Locals are now of int, not EMACS_INT,
7497 since parse_image_check makes sure they fit into int.
7498 (png_load, gif_load, svg_load_image):
7499 Prefer int to unsigned where either will do.
7500 (tiff_handler): New function, combining the cores of the
7501 old tiff_error_handler and tiff_warning_handler.
7502 This function is rewritten to use vsnprintf and thereby avoid
7503 stack buffer overflows. It uses only the features of vsnprintf
7504 that are common to both POSIX and native Microsoft.
7505 (tiff_error_handler, tiff_warning_handler): Use it.
7506 (tiff_load, gif_load, imagemagick_load_image):
7507 Don't assume :index value fits in 'int'.
7508 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7509 (imagemagick_load_image): Check that crop parameters fit into
7510 the integer types that MagickCropImage accepts. Don't assume
7511 Vimagemagick_render_type has a nonnegative value. Don't assume
7512 size_t fits in 'long'.
7513 (gs_load): Use printmax_t to print the widest integers possible.
7514 Check for integer overflow when computing image height and width.
7516 2011-08-26 Eli Zaretskii <eliz@gnu.org>
7518 * xdisp.c (redisplay_window): Don't force window start if point
7519 will be invisible in the resulting window. (Bug#9324)
7521 2011-08-25 Eli Zaretskii <eliz@gnu.org>
7523 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7524 the display spec is of the form `(space ...)'.
7525 (handle_display_spec): Return the value returned by
7526 handle_single_display_spec, not just 1 or zero.
7527 (handle_single_display_spec): If the display spec is of the form
7528 `(space ...)', and specifies display in the text area, return 2
7530 (try_cursor_movement): Check for the need to scroll more
7531 accurately, and prefer exact match for point under bidi.
7532 Don't advance `row' beyond the last row of the window.
7534 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7535 into disp_prop; all users changed.
7537 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7538 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7539 for the text covered by the display property.
7541 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
7543 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7544 Change return value to nil.
7545 (Frecord_buffer): Delete unused function.
7547 2011-08-24 Eli Zaretskii <eliz@gnu.org>
7549 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7550 buffers, return left-to-right.
7551 (set_cursor_from_row): Consider candidate row a win if its glyph
7552 represents a newline and point is on that newline. Fixes cursor
7553 positioning on the newline at EOL of R2L text within L2R
7554 paragraph, and vice versa.
7555 (try_cursor_movement): Check continued rows, in addition to
7556 continuation rows. Fixes unwarranted scroll when point enters a
7557 continued line of R2L text within an L2R paragraph, or vice versa.
7558 (cursor_row_p): Consider the case of point being equal to
7559 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7560 from the end of a short line to the beginning of a continued line
7561 of R2L text within L2R paragraph.
7562 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7563 composed characters.
7565 * bidi.c (bidi_check_type): Use xassert.
7566 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7569 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7571 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7574 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
7576 * nsfont.m (ns_otf_to_script): Fix typo.
7578 2011-08-22 Kenichi Handa <handa@m17n.org>
7580 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7581 extra slot even if the purpose is char-code-property-table.
7583 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7585 * xdisp.c (redisplay_window): When computing centering_position,
7586 account for the height of the header line. (Bug#8874)
7588 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7589 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7590 candidate is selected by the mouse, and that candidate has a
7591 composed character under the mouse.
7593 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7594 coordinates reported by pos-visible-in-window-p for a composed
7595 character in column zero.
7597 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7599 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7601 2011-08-22 Eli Zaretskii <eliz@gnu.org>
7603 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7604 consider it a hit if to_charpos is anywhere in the range of the
7605 composed buffer positions.
7607 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
7609 * image.c (gif_load): Don't assume that each subimage has the same
7610 dimensions as the base image. Handle disposal method that is
7611 "undefined" by the gif spec (Bug#9335).
7613 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
7615 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
7616 (Fcondition_case): Document `debug' symbol in error handler.
7618 2011-08-19 Eli Zaretskii <eliz@gnu.org>
7620 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7621 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7622 from an Org mode buffer to a Speedbar frame.
7624 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7625 a composition, take its buffer position from IT->cmp_it.charpos.
7626 Fixes cursor positioning at the beginning of a line that begins
7627 with a composed character.
7629 2011-08-18 Eli Zaretskii <eliz@gnu.org>
7631 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7632 character bidirectional type, use STRONG_L instead. Fixes crashes
7633 in a buffer produced by `describe-categories'.
7635 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7636 members before the level stack, so they would be saved and
7637 restored when copying iterator state. Fixes incorrect reordering
7638 around TABs covered by display properties.
7640 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7642 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
7644 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
7646 * eval.c (internal_condition_case, internal_condition_case_1)
7647 (internal_condition_case_2, internal_condition_case_n):
7648 Remove unnecessary aborts (Bug#9081).
7650 2011-08-17 Eli Zaretskii <eliz@gnu.org>
7652 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7653 has no `load' handler, try opening the file locally. (Bug#9311)
7655 2011-08-16 Ken Brown <kbrown@cornell.edu>
7657 * gmalloc.c: Expand comment.
7659 2011-08-16 Eli Zaretskii <eliz@gnu.org>
7661 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7662 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7664 2011-08-16 Ken Brown <kbrown@cornell.edu>
7666 Fix memory allocation problems in Cygwin build (Bug#9273).
7668 * unexcw.c ( __malloc_initialized): Declare external variable.
7669 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7671 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7673 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7675 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7677 [CYGWIN] (special_realloc): New function.
7678 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7679 requests to realloc storage in the static heap.
7681 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7683 * bidi.c (bidi_initialize): Remove unused local.
7685 2011-08-15 Eli Zaretskii <eliz@gnu.org>
7688 * biditype.h: Remove file.
7689 * makefile.w32-in ($(BLD)/bidi.$(O)):
7690 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
7692 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7694 * chartab.c: Improve commentary for the uniprop_table API.
7696 * bidi.c (bidi_paragraph_init): Support zero value of
7697 bidi_ignore_explicit_marks_for_paragraph_level.
7698 (bidi_initialize): Use uniprop_table instead of including
7699 biditype.h and bidimirror.h.
7701 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7702 coordinates of the iterator when restoring from ppos_it.
7705 2011-08-14 Kenichi Handa <handa@m17n.org>
7707 * process.c (create_process): Call setup_process_coding_systems
7708 after the pid of the process is set to -1 (Bug#8162).
7710 2011-08-14 Eli Zaretskii <eliz@gnu.org>
7712 * xdisp.c (move_it_in_display_line_to): Don't invoke
7713 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7714 ppos_it. Fixes vertical cursor motion when line beginning is
7715 covered by an image. (Bug#9296)
7717 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7719 * nsterm.h (ns_run_ascript): Declare.
7720 (NSAPP_DATA2_RUNASSCRIPT): Define.
7722 * nsfns.m (as_script, as_result, as_status): New static variables.
7723 (ns_run_ascript): New function.
7724 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
7725 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7726 the event loop. Get status from as_status (Bug#7276).
7728 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7729 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7730 the event loop (Bug#7276).
7732 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7734 * gnutls.c (QCgnutls_bootprop_priority)
7735 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7736 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7737 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7738 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7739 (QCgnutls_bootprop_verify_hostname_error)
7740 (QCgnutls_bootprop_callbacks_verify): Rename from
7741 Qgnutls_bootprop_..., all uses changed.
7743 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7746 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7748 * xfaces.c (Qframe_set_background_mode): Now static.
7749 * dispextern.h (Qframe_set_background_mode): Remove decl.
7751 * process.c (Fnetwork_interface_info): Declare local only if needed.
7753 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7755 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7756 (Fnetwork_interface_list): Allocate in increments of bytes instead
7757 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7758 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7760 (struct ifflag_def): notrailers is smart on OSX.
7761 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7762 Get hardware address with getifaddrs if available.
7764 2011-08-12 Eli Zaretskii <eliz@gnu.org>
7766 * xdisp.c (iterate_out_of_display_property): xassert that
7767 IT->position is set to within IT->object's boundaries. Break from
7768 the loop as soon as EOB is reached; avoids infloops in redisplay
7769 when IT->position is set up wrongly due to some bug.
7770 Set IT->current to match the bidi iterator unconditionally.
7771 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7772 entry. Force push_it to save on the stack the current
7773 buffer/string position, to be restored by pop_it. Fix flags in
7774 the iterator structure wrt the object coming from a display
7775 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7776 properties. (Bug#9284)
7778 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
7780 * fontset.c (fontset_get_font_group): Add proper type checks.
7783 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7785 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7786 and LC_VERSION_MIN_MACOSX.
7787 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7788 (dump_it) [LC_FUNCTION_STARTS]: Use it.
7790 2011-08-08 Eli Zaretskii <eliz@gnu.org>
7792 * xdisp.c (forward_to_next_line_start): Allow to use the
7793 no-display-properties-and-no-overlays under bidi display.
7794 Set disp_pos in the bidi iterator to avoid searches for display
7795 properties and overlays.
7797 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
7799 * editfns.c (Fset_time_zone_rule): Document relationship with the
7802 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7803 the font entity extracted from the cache (Bug#8109).
7805 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
7807 * composite.c (autocmp_chars): Don't reset point. That is done by
7808 restore_point_unwind (Bug#5984).
7810 2011-08-07 Juri Linkov <juri@jurta.org>
7812 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7813 to show the arg `TIME' instead of `TIMEVAL'.
7815 2011-08-06 Eli Zaretskii <eliz@gnu.org>
7817 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7818 display property strides EOL and includes a newline, as in
7819 longlines-mode. (Bug#9254)
7820 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7821 word-wrap under bidirectional display. (Bug#9224)
7823 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7824 is non-zero, even if the data buffer is NULL. Fixes a crash in
7825 vertical-motion with longlines-mode. (Bug#9254)
7827 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7829 * bidi.c <bidi_cache_total_alloc>: Now static.
7830 (bidi_initialize): Initialize bidi_cache_total_alloc.
7832 * xdisp.c (display_line): Release buffer allocated for shelved bidi
7835 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7836 amount allocated this far in `bidi_cache_total_alloc'.
7837 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7838 non-zero, only free the data buffer without restoring the cache
7839 contents. All callers changed.
7841 * dispextern.h (bidi_unshelve_cache): Update prototype.
7843 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7844 (move_it_in_display_line, move_it_to)
7845 (move_it_vertically_backward, move_it_by_lines): Replace the call
7846 to xfree to an equivalent call to bidi_unshelve_cache.
7847 (move_it_in_display_line_to): Fix logic of returning
7848 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
7850 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7852 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7853 came from a string character with a `cursor' property. (Bug#9229)
7855 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7857 * Makefile.in (LIB_PTHREAD): New variable.
7858 (LIBES): Add LIB_PTHREAD (Bug#9216).
7860 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7861 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7863 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7865 * regex.c (re_iswctype): Remove some redundant boolean conversions.
7867 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7869 * xterm.c (x_find_topmost_parent): New function.
7870 (x_set_frame_alpha): Find topmost parent window with
7871 x_find_topmost_parent and set the property there also (bug#9181).
7872 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7874 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7876 * callproc.c (Fcall_process): Avoid vfork clobbering
7877 the local vars buffer, coding_systems, current_dir.
7879 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7881 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7883 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7885 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7886 so that it is not optimized away.
7888 * xdisp.c (compute_display_string_pos): Remove unused local.
7890 2011-08-02 Eli Zaretskii <eliz@gnu.org>
7892 Fix slow cursor motion and scrolling in large buffers with
7893 selective display, like Org Mode buffers. (Bug#9218)
7895 * dispextern.h (struct bidi_it): New member disp_prop_p.
7897 * xdisp.c: Remove one-slot cache of display string positions.
7898 (compute_display_string_pos): Accept an additional argument
7899 DISP_PROP_P; callers changed. Scan at most 5K characters forward
7900 for a display string or property. If found, set DISP_PROP_P
7903 * bidi.c (bidi_fetch_char): Accept an additional argument
7904 DISP_PROP_P, and pass it to compute_display_string_pos.
7905 Only handle text covered by a display string if DISP_PROP_P is returned
7906 non-zero. All callers of bidi_fetch_char changed.
7908 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7910 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7912 2010-12-03 Don March <don@ohspite.net>
7914 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7915 last character M-[char] is translated to ESC [char] (bug#7541).
7917 2011-08-02 Kenichi Handa <handa@m17n.org>
7919 * lisp.h (uniprop_table): Extern it.
7921 * chartab.c (uniprop_table): Make it non-static.
7923 2011-08-01 Eli Zaretskii <eliz@gnu.org>
7925 * xdisp.c (forward_to_next_line_start): Accept additional argument
7926 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7928 (reseat_at_next_visible_line_start): Use the bidi iterator state
7929 returned by forward_to_next_line_start to restore the state of
7930 it->bidi_it after backing up to previous newline. (Bug#9212)
7932 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7934 * regex.c (re_comp): Protoize.
7935 (re_exec): Fix return type.
7936 (regexec): Fix type of `ret'. (Bug#9203)
7938 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7940 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7941 This is needed if max-image-size is a floating-point number.
7943 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7945 * print.c (print_object): Print empty symbol as ##.
7947 * lread.c (read1): Read ## as empty symbol.
7949 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7951 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7952 setting frame foreground color (Bug#9175).
7953 (x_set_background_color): Likewise.
7955 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7956 contents (Bug#9176).
7957 (EmacsTooltip -init): Remove bezels and add shadows to
7960 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7961 or scroll bar (Bug#8470).
7963 * nsfont.m (nsfont_open): Remove assignment to voffset and
7964 unnecessary vars hshink, expand, hd, full_height, min_height.
7965 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7967 * nsterm.h (nsfont_info): Remove voffset field.
7969 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7971 Implement strike-through and overline on NextStep (Bug#8863).
7973 * nsfont.m (nsfont_open): Use underline position provided by font,
7974 instead of hard-coded value of 2.
7975 (nsfont_draw): Call ns_draw_text_decoration instead.
7977 * nsterm.h: Add declaration for ns_draw_text_decoration.
7979 * nsterm.m (ns_draw_text_decoration): New function for drawing
7980 underline, overline, and strike-through.
7981 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7982 ns_draw_text_decoration. Change treatment of cursor drawing to
7983 accommodate underlining, etc.
7985 2011-07-28 Eli Zaretskii <eliz@gnu.org>
7987 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7990 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7992 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7993 Without this fix, if a signal arrives just after memory fills up,
7994 'malloc' might be invoked reentrantly.
7996 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7997 In other words, assume that every image size is allowed, on non-X
7998 hosts. This assumption is probably wrong, but it lets Emacs compile.
8000 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8002 * regex.c (re_iswctype): Convert return values to boolean.
8004 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8006 * xdisp.c (compute_display_string_pos): Don't use cached display
8007 string position if the buffer had its restriction changed.
8010 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8012 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8014 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8016 Integer signedness and overflow and related fixes. (Bug#9079)
8018 * bidi.c: Integer size and overflow fixes.
8019 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8020 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8021 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8022 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8023 (bidi_find_other_level_edge):
8024 Use ptrdiff_t instead of EMACS_INT where either will do.
8025 This works better on 32-bit hosts configured --with-wide-int.
8026 (bidi_cache_ensure_space): Check for size-calculation overflow.
8027 Use % rather than repeated addition, for better worst-case speed.
8028 Don't set bidi_cache_size until after xrealloc returns, because it
8030 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
8031 (bidi_cache_ensure_space): Also check that the bidi cache size
8032 does not exceed that of the largest Lisp string or buffer. See Eli
8033 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
8035 * alloc.c (__malloc_size_t): Remove.
8036 All uses replaced by size_t. See Andreas Schwab's note
8037 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8039 * image.c: Improve checking for integer overflow.
8040 (check_image_size): Assume that f is nonnull, since
8041 it is always nonnull in practice. This is one less thing to
8042 worry about when checking for integer overflow later.
8043 (x_check_image_size): New function, which checks for integer
8044 overflow issues inside X.
8045 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8046 This removes the need for a memory_full check.
8047 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8048 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8049 (xbm_read_bitmap_data): Change locals back to 'int', since
8050 their values must fit in 'int'.
8051 (xpm_load_image, png_load, tiff_load):
8052 Invoke x_create_x_image_and_pixmap earlier,
8053 to avoid much needless work if the image is too large.
8054 (tiff_load): Treat overly large images as if
8055 x_create_x_image_and_pixmap failed, not as malloc failures.
8056 (gs_load): Use x_check_image_size.
8058 * gtkutil.c: Omit integer casts.
8059 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8060 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8062 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8064 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8065 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8066 would wrongly return t on a 64-bit host.
8068 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8069 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8070 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8071 and therefore cause GCC to emit a bogus diagnostic in some cases.
8073 * image.c: Integer signedness and overflow and related fixes.
8074 This is not an exhaustive set of fixes, but it's time to
8075 record what I've got.
8076 (lookup_pixel_color, check_image_size): Remove redundant decls.
8077 (check_image_size): Don't assume that arbitrary EMACS_INT values
8078 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8079 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8080 (tiff_load, imagemagick_load_image):
8081 Check for overflow in size calculations.
8082 (x_create_x_image_and_pixmap): Remove unnecessary test for
8083 xmalloc returning NULL; that can't happen.
8084 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8085 (xpm_color_bucket): Use better integer hashing function.
8086 (xpm_cache_color): Don't possibly over-allocate memory.
8087 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8088 (gif_memory_source):
8089 Use ptrdiff_t, not int or size_t, to record sizes.
8090 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8091 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8092 either works, as we prefer signed integers.
8093 (tiff_read_from_memory, tiff_write_from_memory):
8094 Return tsize_t, not size_t, since that's what the TIFF API wants.
8095 (tiff_read_from_memory): Don't fail simply because the read would
8096 go past EOF; instead, return a short read.
8097 (tiff_load): Omit no-longer-needed casts.
8098 (Fimagemagick_types): Don't assume size fits into 'int'.
8100 Improve hashing quality when configured --with-wide-int.
8101 * fns.c (hash_string): New function, taken from sxhash_string.
8102 Do not discard information about ASCII character case; this
8103 discarding is no longer needed.
8104 (sxhash-string): Use it. Change sig to match it. Caller changed.
8105 * lisp.h: Declare it.
8106 * lread.c (hash_string): Remove, since we now use fns.c's version.
8107 The fns.c version returns a wider integer if --with-wide-int is
8108 specified, so this should help the quality of the hashing a bit.
8110 * emacs.c: Integer overflow minor fix.
8111 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8112 Define only if GNU_LINUX.
8113 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8115 * dispnew.c: Integer signedness and overflow fixes.
8116 Remove unnecessary forward decls, that were a maintenance hassle.
8117 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8119 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8120 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8121 (prepare_desired_row, line_draw_cost):
8122 Use int, not unsigned, where either works.
8123 (save_current_matrix, restore_current_matrix):
8124 Use ptrdiff_t, not size_t, where either works.
8125 (init_display): Check for overflow more accurately, and without
8126 relying on undefined behavior.
8128 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8129 Remove, replacing with the new symbols in lisp.h. All uses changed.
8130 * fileio.c (make_temp_name):
8131 * filelock.c (lock_file_1, lock_file):
8132 * xdisp.c (message_dolog):
8133 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8134 Use pMd etc. instead.
8135 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8136 replacing the pWIDE etc. symbols removed from editfns.c.
8138 * keyboard.h (num_input_events): Now uintmax_t.
8139 This is (very slightly) less likely to mess up due to wraparound.
8142 * buffer.c: Integer signedness fixes.
8143 (alloc_buffer_text, enlarge_buffer_text):
8144 Use ptrdiff_t rather than size_t when either will do, as we prefer
8147 * alloc.c: Integer signedness and overflow fixes.
8148 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8149 (__malloc_size_t): Default to size_t, not to int.
8150 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8151 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8152 Prefer ptrdiff_t to size_t when either would do, as we prefer
8154 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8155 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8156 Now const. Initialize with values that are in range even if char
8158 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8159 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8160 These functions do the right thing with sizes > 2**32.
8161 (check_depth): Now ptrdiff_t, not int.
8162 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8163 Adjust to new way of storing sizes. Check for size overflow bugs
8165 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8166 slightly wrong anyway, as it missed one instance of
8167 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8168 (refill_memory_reserve): Omit needless cast to size_t.
8169 (mark_object_loop_halt): Mark as externally visible.
8171 * xselect.c: Integer signedness and overflow fixes.
8172 (Fx_register_dnd_atom, x_handle_dnd_message):
8173 Use ptrdiff_t, not size_t, since we prefer signed.
8174 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8175 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8176 x_dnd_atoms_size and x_dnd_atoms_length.
8178 * doprnt.c: Prefer signed to unsigned when either works.
8180 * doprnt.c (doprnt):
8182 * xdisp.c (vmessage):
8183 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8184 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8185 prefer signed arithmetic to avoid comparison confusion.
8186 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8187 but is a bit tricky.
8189 Assume freestanding C89 headers, string.h, stdlib.h.
8190 * data.c, doprnt.c, floatfns.c, print.c:
8191 Include float.h unconditionally.
8192 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8193 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8194 * regex.c: Likewise for stddef.h, string.h.
8195 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8196 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8197 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8198 (STDC_HEADERS): Remove obsolete defines.
8199 * sysdep.c: Include limits.h unconditionally.
8201 Assume support for memcmp, memcpy, memmove, memset.
8202 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8203 * regex.c (memcmp, memcpy):
8204 Remove; we assume C89 now.
8206 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8207 (__malloc_safe_bcopy): Remove; no longer needed.
8209 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
8210 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8211 well either way, and we prefer signed to unsigned.
8213 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8215 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8216 closes the connection while we're reading (bug#9182).
8218 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
8220 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8221 are specified (Bug#9168).
8223 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8225 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8226 Found by GCC static checking and --with-wide-int on a 32-bit host.
8228 2011-07-25 Eli Zaretskii <eliz@gnu.org>
8230 * xdisp.c (compute_display_string_pos): Fix logic of caching
8231 previous display string position. Initialize cached_prev_pos to
8232 -1. Fixes slow-down at the beginning of a buffer.
8234 2011-07-24 Eli Zaretskii <eliz@gnu.org>
8236 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8237 for attrs[LFACE_FONTSET_INDEX].
8239 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8241 * xml.c (parse_region): Remove unused local
8242 that was recently introduced.
8244 2011-07-23 Eli Zaretskii <eliz@gnu.org>
8246 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8247 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8249 * xdisp.c (move_it_in_display_line_to): Record the best matching
8250 position for TO_CHARPOS while scanning the line, and restore it on
8251 exit if none of the characters scanned was an exact match.
8252 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
8253 when exact match is impossible due to invisible text, and the
8254 lines are truncated.
8256 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8258 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8261 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8263 Fix a significant slow-down of cursor motion with C-n, C-p,
8264 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8265 auto-repeat under bidi redisplay in fontified buffers.
8266 * xdisp.c (compute_stop_pos_backwards): New function.
8267 (next_element_from_buffer): Call compute_stop_pos_backwards to
8268 find a suitable prev_stop when we find ourselves before
8270 (reseat): Don't look for prev_stop, as that could mean a very long
8272 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8273 <cached_disp_overlay_modiff>: Cache for last found display string
8275 (compute_display_string_pos): Return the cached position if asked
8276 about the same buffer in the same area of character positions, and
8277 the buffer wasn't changed since the time the display string
8278 position was cached.
8280 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8282 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8283 is an integer, which is important for empty lines. (Bug#9149)
8285 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
8287 * frame.c (Fmodify_frame_parameters): In tty case, update the
8288 default face if necessary (Bug#4238).
8290 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
8292 * editfns.c (Fstring_to_char): No need to explain what a character
8293 is in the docstring (Bug#6576).
8295 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8297 * xml.c (parse_region): Make sure we always return a tree.
8299 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8301 * xml.c (parse_region): If a document contains only comments,
8304 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8306 * xml.c (make_dom): Return comments, too.
8308 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8311 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8312 and the surrounding thread.
8313 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8314 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8315 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8317 * s/openbsd.h (BROKEN_SIGIO): Define.
8318 * unexelf.c (unexec) [__OpenBSD__]:
8319 Don't update the .mdebug section of the Alpha COFF symbol table.
8321 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8323 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8326 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8328 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8329 This fixes some race conditions on the permissions of any newly
8332 * alloc.c (valid_pointer_p): Use pipe, not open.
8333 This fixes some permissions issues when debugging.
8335 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8336 If fchown fails to set both uid and gid, try to set just gid,
8337 as that is sometimes allowed. Adjust the file's mode to eliminate
8338 setuid or setgid bits that are inappropriate if fchown fails.
8340 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8342 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8343 to compare Lisp_Objects.
8344 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8345 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8346 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8348 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8350 * lread.c (read_integer): Unread even EOF character.
8351 (read1): Likewise. Properly record start position of symbol.
8353 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8354 symbol character follows.
8356 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8358 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8359 This works around a problem with the previous change to Fcopy_file.
8360 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8361 and without this change, GCC might complain about discarding
8362 fchown's return value.
8364 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
8366 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8368 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8370 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8372 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8374 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8375 it's used from the C level.
8377 * process.c: Use the same condition for POLL_FOR_INPUT in both
8378 keyboard.c and process.c (bug#1858).
8380 2011-07-09 Lawrence Mitchell <wence@gmx.li>
8382 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8383 (Fgnutls_boot): Use it.
8385 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8387 * doc.c (Fsubstitute_command_keys): Revert last change.
8389 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8391 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8392 quotes the next character, and doesn't affect other longer
8393 sequences (bug#8935).
8395 * lread.c (syms_of_lread): Clarify that is isn't only
8396 `eval-buffer' and `eval-defun' that's affected by
8397 `lexical-binding' (bug#8460).
8399 2011-07-15 Eli Zaretskii <eliz@gnu.org>
8401 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
8402 bidi redisplay when a line includes both an image and is truncated.
8404 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8406 Fix minor problems found by static checking.
8407 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8408 (elsz): Now a signed constant, not a size_t var. We prefer signed
8409 types to unsigned, to avoid integer comparison confusion. Without
8410 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8411 "cannot optimize loop, the loop counter may overflow", a symptom
8413 * indent.c (Fvertical_motion): Mark locals as initialized.
8414 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8416 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8418 * search.c (Fre_search_backward): Mention `case-fold-search' in
8419 all the re_search_* functions (bug#8138).
8421 * keyboard.c (Fopen_dribble_file): Document when the file is
8424 2011-07-14 Eli Zaretskii <eliz@gnu.org>
8426 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8429 Support bidi reordering of display and overlay strings.
8430 * xdisp.c (compute_display_string_pos)
8431 (compute_display_string_end): Accept additional argument STRING.
8432 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8433 (reseat_to_string): Initialize bidi_it->string.s and
8434 bidi_it->string.schars.
8435 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
8436 NULL (avoids a crash in bidi_paragraph_init).
8437 Initialize itb.string.lstring.
8438 (init_iterator): Call bidi_init_it only of a valid
8439 buffer position was specified. Initialize paragraph_embedding to
8441 (reseat_to_string): Initialize the bidi iterator.
8442 (display_string): If we need to ignore text properties of
8443 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8444 original value of -1 will not work with bidi.)
8445 (compute_display_string_pos): First arg is now struct
8446 `text_pos *'; all callers changed. Support display properties on
8448 (compute_display_string_end): Support display properties on Lisp
8450 (init_iterator, reseat_1, reseat_to_string): Initialize the
8451 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8452 when iterating on a string not from display properties).
8453 (compute_display_string_pos, compute_display_string_end):
8454 Fix calculation of the object to scan. Fixes an error when using
8456 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
8457 base_level_stop; instead, set base_level_stop to BEGV.
8458 Fixes crashes in vertical-motion.
8459 (next_element_from_buffer): Improve commentary for when
8460 the iterator is before prev_stop.
8461 (init_iterator): Initialize bidi_p from the default value of
8462 bidi-display-reordering, not from buffer-local value. Use the
8463 buffer-local value only if initializing for buffer iteration.
8464 (handle_invisible_prop): Support invisible properties on strings
8465 that are being bidi-reordered.
8466 (set_iterator_to_next): Support bidi reordering of C strings and
8468 (next_element_from_string): Support bidi reordering of Lisp
8470 (handle_stop_backwards): Support Lisp strings as well.
8471 (display_string): Support display of R2L glyph rows.
8472 Use IT_STRING_CHARPOS when displaying from a Lisp string.
8473 (init_iterator): Don't initialize it->bidi_p for strings
8475 (reseat_to_string): Initialize it->bidi_p for strings here.
8476 (next_element_from_string, next_element_from_c_string)
8477 (next_element_from_buffer): Add xassert's for correspondence
8478 between IT's object being iterated and it->bidi_it.string
8480 (face_before_or_after_it_pos): Support bidi iteration.
8481 (next_element_from_c_string): Handle the case of the first string
8482 character that is not the first one in the visual order.
8483 (get_visually_first_element): New function, refactored from common
8484 parts of next_element_from_buffer, next_element_from_string, and
8485 next_element_from_c_string.
8486 (tool_bar_lines_needed, redisplay_tool_bar)
8487 (display_menu_bar): Force left-to-right direction. Add a FIXME
8488 comment for making that be controlled by a user option.
8489 (push_it, pop_it): Save and restore the state of the
8490 bidi iterator. Save and restore the bidi_p flag.
8491 (pop_it): Iterate out of display property for string iteration as
8493 (iterate_out_of_display_property): Support iteration over strings.
8494 (handle_single_display_spec): Set up it->bidi_it for iteration
8495 over a display string, and call bidi_init_it.
8496 (handle_single_display_spec, next_overlay_string)
8497 (get_overlay_strings_1, push_display_prop): Set up the bidi
8498 iterator for displaying display or overlay strings.
8499 (forward_to_next_line_start): Don't use the shortcut if
8501 (back_to_previous_visible_line_start): If handle_display_prop
8502 pushed the iterator stack, restore the internal state of the bidi
8503 iterator by calling bidi_pop_it same number of times.
8504 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8505 and we are bidi-iterating, don't decrement the iterator position;
8506 instead, set the first_elt flag in the bidi iterator, to produce
8508 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8509 (push_display_prop): xassert that we are iterating a buffer.
8510 (push_it, pop_it): Save and restore paragraph_embedding member.
8511 (handle_single_display_spec, next_overlay_string)
8512 (get_overlay_strings_1, reseat_1, reseat_to_string)
8513 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8514 correctly. Don't assume unibyte strings are not bidi-reordered.
8515 (compute_display_string_pos)
8516 (compute_display_string_end): Fix handling the case of C string.
8517 (push_it, pop_it): Save and restore from_disp_prop_p.
8518 (handle_single_display_spec, push_display_prop): Set the
8519 from_disp_prop_p flag.
8520 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8521 (pop_it): Call iterate_out_of_display_property only if we are
8522 popping after iteration over a string that came from a display
8523 property. Fix a typo in popping stretch info. Add an assertion
8524 for verifying that the iterator position is in sync with the bidi
8526 (handle_single_display_spec, get_overlay_strings_1)
8527 (push_display_prop): Fix initialization of paragraph direction for
8528 string when that of the parent object is not yet determined.
8529 (reseat_1): Call bidi_init_it to resync the bidi
8530 iterator with IT's position. (Bug#7616)
8531 (find_row_edges): If ROW->start.pos gives position
8532 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8533 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8534 Reset the from_disp_prop_p flag.
8535 (SAVE_IT, RESTORE_IT): New macros.
8536 (pos_visible_p, face_before_or_after_it_pos)
8537 (back_to_previous_visible_line_start)
8538 (move_it_in_display_line_to, move_it_in_display_line)
8539 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8540 (try_scrolling, redisplay_window, display_line): Use them when
8541 saving a temporary copy of the iterator and restoring it back.
8542 (back_to_previous_visible_line_start, reseat_1)
8543 (init_iterator): Empty the bidi cache "stack".
8544 (move_it_in_display_line_to): If iterator ended up at
8545 EOL, but we never saw any buffer positions smaller than
8546 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8547 motion in bidi-reordered lines.
8548 (move_it_in_display_line_to): Record prev_method and prev_pos
8549 immediately before the call to set_iterator_to_next. Fixes cursor
8550 motion in bidi-reordered lines with stretch glyphs and strings
8551 displayed in margins. (Bug#8133) (Bug#8867)
8552 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8554 (pos_visible_p): Support positions in bidi-reordered lines.
8555 Save and restore bidi cache.
8557 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8558 (bidi_paragraph_info): Delete unused struct.
8559 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8560 (bidi_cache_start): New variable.
8561 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8563 (bidi_cache_fetch_state, bidi_cache_search)
8564 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8565 (bidi_cache_find, bidi_peek_at_next_level)
8566 (bidi_level_of_next_char, bidi_find_other_level_edge)
8567 (bidi_move_to_visually_next): Compare cache index with
8568 bidi_cache_start rather than with zero.
8569 (bidi_fetch_char): Accept new argument STRING; all callers
8570 changed. Support iteration over a string. Support strings with
8571 display properties. Support unibyte strings. Fix the type of
8572 `len' according to what STRING_CHAR_AND_LENGTH expects.
8573 (bidi_paragraph_init, bidi_resolve_explicit_1)
8574 (bidi_resolve_explicit, bidi_resolve_weak)
8575 (bidi_level_of_next_char, bidi_move_to_visually_next):
8576 Support iteration over a string.
8577 (bidi_set_sor_type, bidi_resolve_explicit_1)
8578 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8579 can now be zero (for strings); special values 0 and -1 were
8580 changed to -1 and -2, respectively.
8581 (bidi_char_at_pos): New function.
8582 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8583 Call it instead of FETCH_MULTIBYTE_CHAR.
8584 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8585 initialized to valid values.
8586 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8588 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8589 the test for valid cached positions. Fix the logic for looking up
8590 the sentinel state in the cache. GCPRO the Lisp string we are
8592 (bidi_push_it, bidi_pop_it): New functions.
8593 (bidi_initialize): Initialize the bidi cache start stack pointer.
8594 (bidi_cache_ensure_space): New function, refactored from part of
8595 bidi_cache_iterator_state. Don't assume the required size is just
8596 one BIDI_CACHE_CHUNK away.
8597 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8598 (bidi_count_bytes, bidi_char_at_pos): New functions.
8599 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8600 always valid if bidi_cache_idx is valid.
8601 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8602 is valid if it's going to be used.
8603 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8604 (bidi_cache_fetch_state, bidi_cache_search)
8605 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8606 (bidi_cache_iterator_state, bidi_cache_find)
8607 (bidi_find_other_level_edge, bidi_cache_start_stack):
8608 All variables related to cache indices are now EMACS_INT.
8610 * dispextern.h (struct bidi_string_data): New structure.
8611 (struct bidi_it): New member `string'. Make flag members be 1-bit
8612 fields, and put them last in the struct.
8613 (compute_display_string_pos, compute_display_string_end):
8615 (bidi_push_it, bidi_pop_it): Add prototypes.
8616 (struct iterator_stack_entry): New members bidi_p,
8617 paragraph_embedding, and from_disp_prop_p.
8618 (struct it): Member bidi_p is now a bit field 1 bit wide.
8619 (bidi_shelve_cache, bidi_unshelve_cache):
8622 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8623 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8624 and vector-like objects.
8626 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8627 cache around display iteration.
8629 * window.c (Fwindow_end, window_scroll_pixel_based)
8630 (displayed_window_lines, Frecenter): Save and restore the bidi
8631 cache around display iteration.
8633 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8635 * editfns.c (Fdelete_region): Clarify the use of the named
8636 parameters (bug#6788).
8638 2011-07-14 Martin Rudalics <rudalics@gmx.at>
8640 * indent.c (Fvertical_motion): Set and restore w->pointm when
8641 saving and restoring the window's buffer (Bug#9006).
8643 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8645 * editfns.c (Fstring_to_char): Clarify just what is returned
8646 (bug#6576). Text by Eli Zaretskii.
8648 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
8650 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8652 2011-07-13 Eli Zaretskii <eliz@gnu.org>
8654 * buffer.c (mmap_find): Fix a typo.
8656 2011-07-13 Johan Bockgård <bojohan@gnu.org>
8658 Fix execution of x selection hooks.
8659 * xselect.c (Qx_lost_selection_functions)
8660 (Qx_sent_selection_functions): New vars.
8661 (syms_of_xselect): DEFSYM them.
8662 (x_handle_selection_request): Pass Qx_sent_selection_functions
8663 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8664 (x_handle_selection_clear,x_clear_frame_selections):
8665 Pass Qx_lost_selection_functions rather than
8666 Vx_lost_selection_functions to Frun_hook_with_args.
8668 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8670 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
8671 The old code sometimes used this field without initializing it.
8673 * alloc.c (gc_sweep): Don't read past end of array.
8674 In theory, the old code could also have corrupted Emacs internals,
8675 though it'd be very unlikely.
8677 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8679 * character.c (Fcharacterp): Don't advertise optional ignored
8680 argument. (Bug#4026)
8682 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8684 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8687 * window.c (Fset_window_start): Doc fix (bug#4199).
8688 (Fset_window_hscroll): Ditto.
8690 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8692 Fix minor new problems caught by GCC 4.6.1.
8693 * term.c (init_tty): Remove unused local.
8694 * xsettings.c (store_monospaced_changed): Define this function only
8695 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
8698 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
8700 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8702 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8704 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8705 are the mini-buffer and the echo area (bug#3320).
8707 * term.c (init_tty): Remove support for supdup, c10 and perq
8708 terminals, which are no longer supported (bug#1482).
8710 2011-07-10 Johan Bockgård <bojohan@gnu.org>
8712 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8714 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8716 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8717 for non-popups (Bug#3642).
8719 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8721 * alloc.c (reset_malloc_hooks): Protoize.
8722 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
8723 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8724 * cm.c (losecursor): Likewise.
8725 * data.c (fmod): Likewise.
8726 * dispnew.c (swap_glyphs_in_rows): Likewise.
8727 * emacs.c (memory_warning_signal): Likewise.
8728 * floatfns.c (float_error): Likewise.
8729 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8730 (otf_open, font_otf_capability, generate_otf_features)
8731 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8733 * image.c (pbm_read_file): Likewise.
8734 * indent.c (string_display_width): Likewise.
8735 * intervals.c (check_for_interval, search_for_interval)
8736 (inc_interval_count, count_intervals, root_interval)
8737 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8738 * lread.c (defalias): Likewise.
8739 * ralloc.c (r_alloc_check): Likewise.
8740 * regex.c (set_image_of_range_1, set_image_of_range)
8741 (regex_grow_registers): Likewise.
8742 * sysdep.c (strerror): Likewise.
8743 * termcap.c (valid_filename_p, tprint, main): Likewise.
8744 * tparam.c (main): Likewise.
8745 * unexhp9k800.c (run_time_remap, save_data_space)
8746 (update_file_ptrs, read_header, write_header, calculate_checksum)
8747 (copy_file, copy_rest, display_header): Likewise.
8748 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8750 * xdisp.c (check_it): Likewise.
8751 * xfaces.c (register_color, unregister_color, unregister_colors):
8753 * xfns.c (print_fontset_result): Likewise.
8754 * xrdb.c (member, fatal, main): Likewise.
8756 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8758 Fix minor problems found by static checking (Bug#9031).
8759 * chartab.c (char_table_set_range, map_sub_char_table):
8760 Remove unused locals.
8761 (uniprop_table): Now static.
8762 * composite.c (_work_char): Remove unused static var.
8764 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
8766 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8768 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8770 * gtkutil.c (qttip_cb): Remove code without function.
8772 2011-07-09 Eli Zaretskii <eliz@gnu.org>
8774 * w32.c (pthread_sigmask): New stub.
8776 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
8778 Use pthread_sigmask, not sigprocmask (Bug#9010).
8779 sigprocmask is portable only for single-threaded applications, and
8780 Emacs can be multi-threaded when it uses GTK.
8781 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8783 * callproc.c (Fcall_process):
8784 * process.c (create_process):
8785 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8786 Use pthread_sigmask, not sigprocmask.
8788 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8790 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8791 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8794 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8796 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8797 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8798 (xg_hide_tooltip): Fix comment.
8800 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8801 in registerServicesMenuSendTypes.
8802 (validRequestorForSendType): Don't check ns_return_types.
8804 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8807 2011-07-08 Jason Rumney <jasonr@gnu.org>
8809 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8810 SH_SHOW for hidden windows (Bug#5482).
8812 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8813 frame struct members of non-existent frames (Bug#6284).
8815 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8817 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8818 variable firstTime not needed on OSX >= 10.6.
8819 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8820 >= 10.5. Use setKnobProportion, setDoubleValue.
8822 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8823 (MAC_OS_X_VERSION_10_5): Define if not defined.
8824 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8825 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8826 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8828 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
8829 cString and lossyCString on OSX >= 10.4.
8831 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
8832 sizeToFit on OSX >= 10.2.
8834 * nsimage.m (allocInitFromFile): Don't use deprecated method
8835 bestRepresentationForDevice on OSX >= 10.6.
8837 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8840 * emacs.c: Declare unexec_init_emacs_zone.
8842 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8844 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8846 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8847 on svcsMenu (Bug#8842).
8849 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8851 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8853 * nsterm.m (QUTF8_STRING): Declare.
8854 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8855 (validRequestorForSendType): Return type is (id).
8856 Change indexOfObjectIdenticalTo to indexOfObject.
8857 Check if we have local selection before returning self (Bug#8842).
8858 (writeSelectionToPasteboard): Put local selection into paste board
8859 if we have a local selection (Bug#8842).
8860 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8862 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8863 (ns_get_local_selection): Declare.
8865 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8867 * keymap.c (describe_map_tree): Don't insert a double newline at
8868 the end of the buffer (bug#1169) and return whether we inserted
8871 * callint.c (Fcall_interactively): Change "reading args" to
8872 "providing args" to try to clarify what it does (bug#1010).
8874 2011-07-07 Kenichi Handa <handa@m17n.org>
8876 * composite.c (composition_compute_stop_pos): Ignore a static
8877 composition starting before CHARPOS (Bug#8915).
8879 * xdisp.c (handle_composition_prop): Likewise.
8881 2011-07-07 Eli Zaretskii <eliz@gnu.org>
8883 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8886 2011-07-07 Kenichi Handa <handa@m17n.org>
8888 * character.h (unicode_category_t): New enum type.
8890 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8891 (Qchar_code_property_table): New variable.
8892 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8893 (UNIPROP_COMPRESSED_FORM_P): New macros.
8894 (char_table_ascii): Uncompress the compressed values.
8895 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8896 Uncompress the compressed values.
8897 (sub_char_table_ref_and_range): Likewise.
8898 (char_table_ref_and_range): Uncompress the compressed values.
8899 (sub_char_table_set): New arg is_uniprop. Callers changed.
8900 Uncompress the compressed values.
8901 (sub_char_table_set_range): Args changed. Callers changed.
8902 (char_table_set_range): Adjuted for the above change.
8903 (map_sub_char_table): Delete args default_val and parent. Add arg
8904 top. Give decoded values to a Lisp function.
8905 (map_char_table): Adjust for the above change. Give decoded
8906 values to a Lisp function. Gcpro more variables.
8907 (uniprop_table_uncompress)
8908 (uniprop_decode_value_run_length): New functions.
8909 (uniprop_decoder, uniprop_decoder_count): New variables.
8910 (uniprop_get_decoder, uniprop_encode_value_character)
8911 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8913 (uniprop_encoder, uniprop_encoder_count): New variables.
8914 (uniprop_get_encoder, uniprop_table)
8915 (Funicode_property_table_internal, Fget_unicode_property_internal)
8916 (Fput_unicode_property_internal): New functions.
8917 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8918 Sunicode_property_table_internal, Sget_unicode_property_internal,
8919 and Sput_unicode_property_internal. Defvar_lisp
8920 char-code-property-alist.
8922 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
8923 Vunicode_category_table.
8925 * font.c (font_range): Adjust for the change of
8926 Vunicode_category_table.
8928 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8930 * m/iris4d.h: Remove file, move contents ...
8931 * s/irix6-5.h: ... here.
8933 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8935 Remove unportable assumption about struct layout (Bug#8884).
8936 * alloc.c (mark_buffer):
8937 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8938 (clone_per_buffer_values): Don't assume that
8939 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8940 This isn't true in general, and it's particularly not true
8941 if Emacs is configured with --with-wide-int.
8942 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8943 New macros, used in the buffer.c change.
8945 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8947 * xsettings.c: Use both GConf and GSettings if both are available.
8948 (store_config_changed_event): Add comment.
8949 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8950 (store_tool_bar_style_changed): New functions.
8951 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
8952 (struct xsettings): Move font inside HAVE_XFT.
8953 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
8954 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
8955 Move inside HAVE_XFT.
8956 (something_changed_gsettingsCB): Rename from something_changedCB.
8957 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8959 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
8960 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
8961 (something_changed_gconfCB): Rename from something_changedCB.
8962 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8963 (parse_settings): Move check for font inside HAVE_XFT.
8964 (read_settings, apply_xft_settings): Add comment.
8965 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8966 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8967 call store_font_name_changed.
8968 (xft_settings_event): Add comment.
8969 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8970 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8971 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8972 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8973 (xsettings_initialize): Call init_gsettings last.
8974 (xsettings_get_system_font, xsettings_get_system_normal_font):
8977 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8979 Random fixes. E.g., (random) never returned negative values.
8980 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8981 subseconds part to the entropy, as that's a bit more random.
8982 Prefer signed to unsigned, since the signedness doesn't matter and
8983 in general we prefer signed. When given a limit, use a
8984 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8985 latter isn't right if USE_2_TAGS_FOR_INTS.
8986 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8987 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8989 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8991 * textprop.c (text_property_stickiness):
8992 Obey Vtext_property_default_nonsticky.
8993 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8994 * w32fns.c (syms_of_w32fns):
8995 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8997 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8999 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9000 This is more efficient than Ffile_directory_p and avoids a minor race.
9002 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9004 * buffer.c (Foverlay_put): Say what the return value is
9007 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9008 is a directory before asking whether to use the file name
9010 (barf_or_query_if_file_exists): Make the "File is a directory"
9011 error be more correct.
9013 * fns.c (Frequire): Remove the mention of the .gz files, since
9014 that's installation-specific, but keep the mention of
9015 `get-load-suffixes'.
9017 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9019 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9020 Report string overflow if the output is too long.
9022 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
9024 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9025 (syms_of_gnutls): Remove duplicate DEFSYM for
9026 Qgnutls_bootprop_verify_hostname_error, an error for
9027 Qgnutls_bootprop_verify_error (which is no longer used).
9029 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9030 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9031 Also (re)move comments that are misplaced or no longer relevant.
9033 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9035 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9037 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
9039 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9040 and background color parameters if they have been changed.
9042 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9044 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9046 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9048 * xsettings.c (SYSTEM_FONT): Define only when used.
9049 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9051 * keymap.c (access_keymap_1): Now static.
9053 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
9055 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9056 leave any prefix arg for the up event (Bug#1586).
9058 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9060 * lread.c (syms_of_lread): Mention single symbols defined by
9061 `defvar' or `defconst' (bug#7154).
9063 * fns.c (Frequire): Mention .el.gz files (bug#7314).
9064 (Frequire): Mention get-load-suffixes.
9066 2011-07-02 Martin Rudalics <rudalics@gmx.at>
9068 * window.h (window): Remove clone_number slot.
9069 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9071 (make_parent_window, make_window, saved_window)
9072 (Fset_window_configuration, save_window_save): Don't deal with
9074 * buffer.c (Qclone_number): Remove declaration.
9075 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9077 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9079 Add multiple inheritance to keymaps.
9080 * keymap.c (Fmake_composed_keymap): New function.
9081 (Fset_keymap_parent): Simplify.
9082 (fix_submap_inheritance): Remove.
9083 (access_keymap_1): New function extracted from access_keymap to handle
9084 embedded parents and handle lists of maps.
9085 (access_keymap): Use it.
9086 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9087 (Fcopy_keymap): Handle embedded parents.
9088 (Fcommand_remapping, define_as_prefix): Simplify.
9089 (Fkey_binding): Simplify.
9090 (syms_of_keymap): Move minibuffer-local-completion-map,
9091 minibuffer-local-filename-completion-map,
9092 minibuffer-local-must-match-map, and
9093 minibuffer-local-filename-must-match-map to Elisp.
9094 (syms_of_keymap): Defsubr make-composed-keymap.
9095 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9096 (parse_menu_item): Trivial simplification.
9098 2011-07-01 Glenn Morris <rgm@gnu.org>
9100 * Makefile.in (SETTINGS_LIBS): Fix typo.
9102 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9104 * coding.c (Fencode_coding_string): Record the last coding system
9105 used, as the function doc string says (bug#8738).
9107 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9109 * xsettings.c (store_monospaced_changed): Take new font as arg and
9110 check for change against current_mono_font.
9111 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9112 (emacs_settings_constructor, emacs_settings_get_property)
9113 (emacs_settings_set_property, emacs_settings_class_init)
9114 (emacs_settings_init, gsettings_obj): Remove.
9115 (something_changedCB): New function for HAVE_GSETTINGS.
9116 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9117 with value as argument.
9118 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9119 g_settings_new (Bug#8967). Do not create gsettings_obj.
9120 Remove calls to g_settings_bind. Connect something_changedCB to
9123 * xgselect.c: Add defined (HAVE_GSETTINGS).
9124 (xgselect_initialize): Ditto.
9126 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9127 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9130 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9132 * eval.c (struct backtrace): Simplify and port the data structure.
9133 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9134 signed bit field, as this assumption is not portable and it makes
9135 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9136 "char debug_on_exit : 1" as this is not portable either; instead,
9137 use the portable "unsigned int debug_on_exit : 1". Remove unused
9138 member evalargs. Remove obsolete comments about cc bombing out.
9140 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9142 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9143 Let HAVE_GSETTINGS override HAVE_GCONF.
9144 (store_monospaced_changed): New function.
9145 (EMACS_SETTINGS): A new type derived from GObject to handle
9146 GSettings notifications.
9147 (emacs_settings_constructor, emacs_settings_get_property)
9148 (emacs_settings_set_property, emacs_settings_class_init):
9150 (gsettings_client, gsettings_obj): New variables.
9151 (GSETTINGS_SCHEMA): New define.
9152 (something_changedCB): Call store_monospaced_changed.
9153 (init_gsettings): New function.
9154 (xsettings_initialize): Call init_gsettings.
9155 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9158 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9161 2011-06-29 Martin Rudalics <rudalics@gmx.at>
9163 * window.c (resize_root_window, grow_mini_window)
9164 (shrink_mini_window): Rename Qresize_root_window to
9165 Qwindow_resize_root_window and Qresize_root_window_vertically to
9166 Qwindow_resize_root_window_vertically.
9168 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9170 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9172 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
9174 * makefile.w32-in: Redesign dependencies so they reflect more
9175 clearly which files are directly included by each source file,
9176 and not through other includes.
9178 2011-06-27 Martin Rudalics <rudalics@gmx.at>
9180 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9181 (sort_overlays, overlay_strings): When an overlay's clone number
9182 matches the window's clone number process the overlay even if
9183 the overlay's window property doesn't match the current window.
9185 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9186 (Fwindow_hchild): Rename to Fwindow_left_child.
9187 (Fwindow_next): Rename to Fwindow_next_sibling.
9188 (Fwindow_prev): Rename to Fwindow_prev_sibling.
9189 (resize_window_check): Rename to window_resize_check.
9190 (resize_window_apply): Rename to window_resize_apply.
9191 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9192 (Fdelete_other_windows_internal, resize_frame_windows)
9193 (Fsplit_window_internal, Fdelete_window_internal)
9194 (grow_mini_window, shrink_mini_window)
9195 (Fresize_mini_window_internal): Fix callers accordingly.
9197 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9199 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9200 (emacs_fixed_set_min_size): Remove.
9201 (emacs_fixed_new): Take frame as argument.
9203 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9204 (_EmacsFixedPrivate): Remove minwidth/height.
9205 Add struct frame *f.
9206 (emacs_fixed_init): Initialize priv->f.
9207 (get_parent_class, emacs_fixed_set_min_size): Remove.
9208 (emacs_fixed_new): Set priv->f to argument.
9209 (emacs_fixed_get_preferred_width)
9210 (emacs_fixed_get_preferred_height): Use min_width/height from
9211 frames size_hint to set minimum and natural (Bug#8919).
9212 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9213 and use min_width/height from frames size_hint to set
9214 min_width/height (Bug#8919).
9216 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9217 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9220 2011-06-26 Eli Zaretskii <eliz@gnu.org>
9222 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9223 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9226 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
9228 * process.c (wait_reading_process_output): Bypass select if
9229 waiting for a cell while ignoring keyboard input, and input is
9230 pending. Suggested by Jan Djärv (Bug#8869).
9232 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9234 Use gnulib's dup2 module instead of rolling our own.
9235 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9237 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9239 * dispnew.c (scrolling_window): Before scrolling, turn off a
9240 mouse-highlight in the window being scrolled.
9242 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
9244 Move DEFSYM to lisp.h and use everywhere.
9246 * character.h (DEFSYM): Move declaration...
9247 * lisp.h (DEFSYM): ...here.
9253 * w32select.c: Don't include character.h.
9255 * alloc.c (syms_of_alloc):
9256 * buffer.c (syms_of_buffer):
9257 * bytecode.c (syms_of_bytecode):
9258 * callint.c (syms_of_callint):
9259 * casefiddle.c (syms_of_casefiddle):
9260 * casetab.c (init_casetab_once):
9261 * category.c (init_category_once, syms_of_category):
9262 * ccl.c (syms_of_ccl):
9263 * cmds.c (syms_of_cmds):
9264 * composite.c (syms_of_composite):
9265 * dbusbind.c (syms_of_dbusbind):
9266 * dired.c (syms_of_dired):
9267 * dispnew.c (syms_of_display):
9268 * doc.c (syms_of_doc):
9269 * editfns.c (syms_of_editfns):
9270 * emacs.c (syms_of_emacs):
9271 * eval.c (syms_of_eval):
9272 * fileio.c (syms_of_fileio):
9273 * fns.c (syms_of_fns):
9274 * frame.c (syms_of_frame):
9275 * fringe.c (syms_of_fringe):
9276 * insdel.c (syms_of_insdel):
9277 * keymap.c (syms_of_keymap):
9278 * lread.c (init_obarray, syms_of_lread):
9279 * macros.c (syms_of_macros):
9280 * msdos.c (syms_of_msdos):
9281 * print.c (syms_of_print):
9282 * process.c (syms_of_process):
9283 * search.c (syms_of_search):
9284 * sound.c (syms_of_sound):
9285 * syntax.c (init_syntax_once, syms_of_syntax):
9286 * terminal.c (syms_of_terminal):
9287 * textprop.c (syms_of_textprop):
9288 * undo.c (syms_of_undo):
9289 * w32.c (globals_of_w32):
9290 * window.c (syms_of_window):
9291 * xdisp.c (syms_of_xdisp):
9292 * xfaces.c (syms_of_xfaces):
9293 * xfns.c (syms_of_xfns):
9294 * xmenu.c (syms_of_xmenu):
9295 * xsettings.c (syms_of_xsettings):
9296 * xterm.c (syms_of_xterm): Use DEFSYM.
9298 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9300 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
9302 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9304 Integer and buffer overflow fixes (Bug#8873).
9306 * print.c (printchar, strout): Check for string overflow.
9307 (PRINTPREPARE, printchar, strout):
9308 Don't set size unless allocation succeeds.
9310 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9311 for sizes. Check for string overflow more accurately.
9312 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9314 * macros.c: Integer and buffer overflow fixes.
9315 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9316 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9317 Use ptrdiff_t, not int, for sizes.
9318 Don't increment bufsize until after realloc succeeds.
9319 Check for size-calculation overflow.
9320 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9322 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9324 * lread.c: Integer overflow fixes.
9325 (read_integer): Radix is now EMACS_INT, not int,
9326 to improve quality of diagnostics for out-of-range radices.
9327 Calculate buffer size correctly for out-of-range radices.
9328 (read1): Check for integer overflow in radices, and in
9329 read-circle numbers.
9330 (read_escape): Avoid int overflow.
9331 (Fload, openp, read_buffer_size, read1)
9332 (substitute_object_recurse, read_vector, read_list, map_obarray):
9333 Use ptrdiff_t, not int, for sizes.
9334 (read1): Use EMACS_INT, not int, for sizes.
9335 Check for size overflow.
9337 * image.c (cache_image): Check for size arithmetic overflow.
9339 * lread.c: Integer overflow issues.
9340 (saved_doc_string_size, saved_doc_string_length)
9341 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9342 Now ptrdiff_t, not int.
9343 (read1): Don't assume doc string length fits in int. Check for
9344 out-of-range doc string lengths.
9345 (read_list): Don't assume file position fits in int.
9346 (read_escape): Check for hex character overflow.
9348 2011-06-22 Leo Liu <sdl.web@gmail.com>
9350 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9351 Move to minibuffer.el.
9353 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9355 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
9356 The following patches are for when GLYPH_DEBUG && !XASSERT.
9357 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9358 * dispnew.c (flush_stdout):
9359 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9360 Mark as externally visible.
9361 * dispnew.c (check_window_matrix_pointers): Now static.
9362 * dispnew.c (window_to_frame_vpos):
9363 * xfns.c (unwind_create_frame):
9364 * xterm.c (x_check_font): Remove unused local.
9365 * scroll.c (CHECK_BOUNDS):
9366 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9367 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9368 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9369 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9370 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9372 (debug_method_add): Use va_list and vsprintf rather than relying
9373 on undefined behavior with wrong number of arguments.
9374 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9375 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9376 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9377 since we're not interested in debugging glyphs with old libraries.
9378 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9379 GCC 4.6.0's static checking.
9381 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9383 Integer overflow and signedness fixes (Bug#8873).
9384 A few related buffer overrun fixes, too.
9386 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9388 * dispextern.h (struct face.stipple):
9389 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9390 (x_bitmap_mask, x_allocate_bitmap_record)
9391 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9392 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9393 (x_create_bitmap_from_xpm_data):
9394 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9395 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9397 * xfaces.c (load_pixmap):
9398 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9399 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9400 (.bitmaps_last, struct x_output.icon_bitmap):
9401 Use ptrdiff_t, not int, for bitmap indexes.
9402 (x_allocate_bitmap_record): Check for size overflow.
9403 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9405 Use ptrdiff_t, not int, for overlay counts.
9406 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9407 * editfns.c (overlays_around, get_pos_property):
9408 * textprop.c (get_char_property_and_overlay):
9409 * xdisp.c (next_overlay_change, note_mouse_highlight):
9410 * xfaces.c (face_at_buffer_position):
9411 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9412 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9413 (Fnext_overlay_change, Fprevious_overlay_change)
9414 (mouse_face_overlay_overlaps, Foverlays_in):
9415 Use ptrdiff_t, not int, for sizes.
9416 (overlays_at, overlays_in): Check for size-calculation overflow.
9418 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9420 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9421 (x_session_initialize): Do not assume string length fits in int.
9423 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9424 This is unlikely, but can occur if DPI is outlandish.
9426 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
9427 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9429 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9430 * xrdb.c (magic_file_p, search_magic_path):
9431 Omit last arg SUFFIX; it was always 0. All callers changed.
9432 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9434 * xfont.c (xfont_match): Avoid need for strlen.
9436 * xfns.c: Don't assume strlen fits in int.
9437 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9439 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9440 not unsigned long, as we prefer signed integers. All callers changed.
9441 Detect integer overflow in repeat count.
9442 (message_dolog): Don't assume print length fits in 39 bytes.
9443 (display_mode_element): Don't assume strlen fits in int.
9445 * termcap.c: Don't assume sizes fit in int and never overflow.
9446 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9447 (gobble_line): Check for size-calculation overflow.
9449 * minibuf.c (Fread_buffer):
9450 * lread.c (intern, intern_c_string):
9451 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9452 Don't assume string length fits in int.
9454 * keyboard.c (parse_tool_bar_item):
9455 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9457 * font.c: Don't assume string length fits in int.
9458 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9459 Use ptrdiff_t, not int.
9460 (font_intern_prop): Don't assume string length fits in int.
9461 Don't assume integer property fits in fixnum.
9462 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
9464 * filelock.c: Fix some buffer overrun and integer overflow issues.
9465 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
9466 Reformulate so as not to need the command string.
9467 Invoke gzip -cd rather than gunzip, as it's more portable.
9468 (lock_info_type, lock_file_1, lock_file):
9469 Don't assume pid_t and time_t fit in unsigned long.
9470 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9471 (current_lock_owner): Prefer signed type for sizes.
9472 Use memcpy, not strncpy, where memcpy is what is really wanted.
9473 Don't assume (via atoi) that time_t and pid_t fit in int.
9474 Check for time_t and/or pid_t out of range, e.g., via a network share.
9475 Don't alloca where an auto var works fine.
9477 * fileio.c: Fix some integer overflow issues.
9478 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9479 Don't assume string length fits in int.
9480 (directory_file_name): Don't assume string length fits in long.
9481 (make_temp_name): Don't assume pid fits in int, or that its print
9482 length is less than 20.
9484 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9486 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9488 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9490 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9491 We prefer signed integers, even for size calculations.
9493 * emacs.c: Don't assume string length fits in 'int'.
9494 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9495 (main): Don't invoke strlen when not needed.
9497 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9498 (XD_DEBUG_MESSAGE): Don't waste a byte.
9500 * callproc.c (getenv_internal_1, getenv_internal)
9502 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9504 * lread.c (invalid_syntax): Omit length argument.
9505 All uses changed. This doesn't fix a bug, but it simplifies the
9506 code away from its former Hollerith-constant appearance, and it's
9507 one less 'int' to worry about when looking at integer-overflow issues.
9508 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
9510 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9511 This didn't break anything, but it didn't help either.
9512 It's confusing to put a bogus integer in a place where the actual
9513 value does not matter.
9514 (LIST_END_P): Remove unused macro and its bogus comment.
9515 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
9517 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9518 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9520 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9521 We prefer signed types, and the value cannot exceed the EMACS_INT
9522 range anyway (because otherwise the length would not be representable).
9523 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9524 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9525 This avoids a GCC warning when WIDE_EMACS_INT.
9527 * indent.c (sane_tab_width): New function.
9528 (current_column, scan_for_column, Findent_to, position_indentation)
9529 (compute_motion): Use it. This is just for clarity.
9530 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
9532 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
9534 * lisp.h (lint_assume): New macro.
9535 * composite.c (composition_gstring_put_cache):
9536 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9538 * editfns.c, insdel.c:
9539 Omit unnecessary forward decls, to simplify future changes.
9541 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9543 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9545 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
9546 Use much-faster test for byte-length change.
9547 Don't assume string byte-length fits in 'int'.
9548 Check that character arg fits in 'int'.
9549 (mapcar1): Declare byte as byte, for clarity.
9551 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9553 * fns.c (concat): Catch string overflow earlier.
9554 Do not rely on integer wraparound.
9556 * dispextern.h (struct it.overlay_strings_charpos)
9557 (struct it.selective): Now EMACS_INT, not int.
9558 * xdisp.c (forward_to_next_line_start)
9559 (back_to_previous_visible_line_start)
9560 (reseat_at_next_visible_line_start, next_element_from_buffer):
9561 Don't arbitrarily truncate the value of 'selective' to int.
9563 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9565 * composite.c: Don't truncate sizes to 'int'.
9566 (composition_gstring_p, composition_reseat_it)
9567 (composition_adjust_point): Use EMACS_INT, not int.
9568 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9569 not EMACS_UINT, for indexes.
9571 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9573 * buffer.c: Include <verify.h>.
9574 (struct sortvec.priority, struct sortstr.priority):
9575 Now EMACS_INT, not int.
9576 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
9577 (struct sortstr.size, record_overlay_string)
9578 (struct sortstrlist.size, struct sortlist.used):
9579 Don't truncate size to int.
9580 (record_overlay_string): Check for size-calculation overflow.
9581 (init_buffer_once): Check at compile-time, not run-time.
9583 2011-06-22 Jim Meyering <meyering@redhat.com>
9585 Don't leak an XBM-image-sized buffer
9586 * image.c (xbm_load): Free the image buffer after using it.
9588 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9591 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9592 that Sun C diagnosed.
9593 * fns.c (secure_hash): Fix pointer signedness issue.
9594 * intervals.c (static_offset_intervals): New function.
9595 (offset_intervals): Use it.
9597 2011-06-21 Leo Liu <sdl.web@gmail.com>
9600 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9603 * fns.c (secure_hash): Rename from crypto_hash_function and change
9604 the first arg to accept symbols.
9605 (Fsecure_hash): New primitive.
9606 (syms_of_fns): New symbols.
9608 2011-06-20 Deniz Dogan <deniz@dogan.se>
9610 * process.c (Fset_process_buffer): Clarify return value in
9613 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
9615 * dispnew.c (add_window_display_history): Use BVAR.
9617 * xdisp.c (debug_method_add): Use BVAR.
9618 (check_window_end, dump_glyph_matrix, dump_glyph)
9619 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9621 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9624 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9625 check till after the cache is created in init_frame_faces.
9627 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9629 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9631 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9633 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9634 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9635 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9637 Improve buffer-overflow checking (Bug#8873).
9638 * fileio.c (Finsert_file_contents):
9639 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9640 Remove the old (too-loose) buffer overflow checks.
9641 They weren't needed, since make_gap checks for buffer overflow.
9642 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9643 The old code merely checked for Emacs fixnum overflow, and relied
9644 on undefined (wraparound) behavior. The new code avoids undefined
9645 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9647 * editfns.c (Finsert_char): Don't dump core with very negative counts.
9648 Tune. Don't use wider integers than needed. Don't use alloca.
9649 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
9651 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9653 * insdel.c, lisp.h (buffer_overflow): New function.
9654 (insert_from_buffer_1, replace_range, replace_range_2):
9655 * insdel.c (make_gap_larger):
9656 * editfns.c (Finsert_char):
9657 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9659 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9661 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9663 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
9665 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9666 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9668 * fileio.c: Don't assume EMACS_INT fits in off_t.
9669 (emacs_lseek): New static function.
9670 (Finsert_file_contents, Fwrite_region): Use it.
9671 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9673 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9675 * fns.c: Don't overflow int when computing a list length.
9676 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9677 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9678 truncation on 64-bit hosts. Check for QUIT every
9679 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9680 faster and is responsive enough.
9681 (Flength): Report an error instead of overflowing an integer.
9682 (Fsafe_length): Return a float if the value is not representable
9683 as a fixnum. This shouldn't happen except in contrived situations.
9684 (Fnthcdr, Fsort): Don't assume list length fits in int.
9685 (Fcopy_sequence): Don't assume vector length fits in int.
9687 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9688 (header_size, word_size): New constants.
9689 (allocate_vectorlike): Don't check size overflow here.
9690 (allocate_vector): Check it here instead, since this is the only
9691 caller of allocate_vectorlike that could cause overflow.
9692 Check that the new vector's length is representable as a fixnum.
9694 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9695 The previous code was bogus. For example, next_almost_prime (32)
9696 returned 39, which is undesirable as it is a multiple of 3; and
9697 next_almost_prime (24) returned 25, which is a multiple of 5 so
9698 why was the code bothering to check for multiples of 7?
9700 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9702 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9704 Variadic C functions now count arguments with ptrdiff_t.
9705 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9706 Back then I didn't know that the Emacs coding style prefers signed int.
9707 Also, in the meantime I found a few more instances where arguments
9708 were being counted with int, which may truncate counts on 64-bit
9709 machines, or EMACS_INT, which may be unnecessarily wide.
9710 * lisp.h (struct Lisp_Subr.function.aMANY)
9711 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9712 Arg counts are now ptrdiff_t, not size_t.
9713 All variadic functions and their callers changed accordingly.
9714 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9715 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9716 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9717 * callint.c (Fcall_interactively): Check arg count for overflow,
9718 to avoid potential buffer overrun. Use signed char, not 'int',
9719 for 'varies' array, so that we needn't bother to check its size
9720 calculation for overflow.
9721 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9722 * eval.c (apply_lambda):
9723 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9724 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9725 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9727 * callint.c (Fcall_interactively): Don't use index var as event count.
9729 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9730 * mem-limits.h (SIZE): Remove; no longer used.
9732 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
9734 Remove unnecessary casts.
9735 * xterm.c (x_term_init):
9736 * xfns.c (x_set_border_pixel):
9737 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9738 These aren't needed now that we assume ANSI C.
9740 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9741 It's more likely to cause problems (due to unsigned overflow)
9744 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9746 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9748 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9750 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9752 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9754 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9756 GLYPH_CODE_FACE returns EMACS_INT, not int.
9757 * dispextern.h (merge_faces):
9758 * xfaces.c (merge_faces):
9759 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9760 Don't assume EMACS_INT fits in int.
9762 * character.h (CHAR_VALID_P): Remove unused parameter.
9763 * fontset.c, lisp.h, xdisp.c: All uses changed.
9765 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9767 * fns.c (concat): Minor tuning based on overflow analysis.
9768 This doesn't fix any bugs. Use int to hold character, instead
9769 of constantly refetching from Emacs object. Use XFASTINT, not
9770 XINT, for value known to be a character. Don't bother comparing
9771 a single byte to 0400, as it's always less.
9773 * floatfns.c (Fexpt):
9774 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9776 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9779 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9781 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9782 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9783 incorrectly succeed when S was a string, because 4294967386 was
9784 truncated before it was used.
9786 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9787 Otherwise, an out-of-range integer could cause undefined behavior
9790 * composite.c: Use int, not EMACS_INT, for characters.
9791 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9792 EMACS_INT, for values that are known to be in character range.
9793 This doesn't fix any bugs but is the usual style inside Emacs and
9794 may generate better code on 32-bit machines.
9796 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9797 This is for reasons similar to the recent CHAR_STRING fix.
9798 * charset.c (Fencode_char): Check that character arg is actually
9799 a character. Pass an int to ENCODE_CHAR.
9800 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9801 wider than 'int', as a compile-time check to prevent future regressions
9804 * character.c (char_string): Remove unnecessary casts.
9806 Make sure a 64-bit char is never passed to CHAR_STRING.
9807 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9808 by silently ignoring the top 32 bits, allowing some values
9809 that were far too large to be valid characters.
9810 * character.h: Include <verify.h>.
9811 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9812 arguments are no wider than unsigned, as a compile-time check
9813 to prevent future regressions in this area.
9815 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
9816 (Fsubst_char_in_region):
9818 * xdisp.c (decode_mode_spec_coding):
9819 Adjust to CHAR_STRING's new requirement.
9820 * editfns.c (Finsert_char, Fsubst_char_in_region):
9821 * fns.c (concat): Check that character args are actually
9822 characters. Without this test, these functions did the wrong
9823 thing with wildly out-of-range values on 64-bit hosts.
9825 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9826 These casts should not be needed on 32-bit hosts, either.
9827 * keyboard.c (read_char):
9828 * lread.c (Fload): Remove casts to unsigned.
9830 * lisp.h (UNSIGNED_CMP): New macro.
9831 This fixes comparison bugs on 64-bit hosts.
9832 (ASCII_CHAR_P): Use it.
9833 * casefiddle.c (casify_object):
9834 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
9835 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9836 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9837 * dispextern.h (FACE_FROM_ID):
9838 * keyboard.c (read_char): Use UNSIGNED_CMP.
9840 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9841 not to EMACS_INT, to avoid GCC warning.
9843 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9845 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9846 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9847 isn't needed on 32-bit machines.
9849 * buffer.c (Fgenerate_new_buffer_name):
9850 Use EMACS_INT for count, not int.
9851 (advance_to_char_boundary): Return EMACS_INT, not int.
9853 * data.c (Qcompiled_function): Now static.
9855 * window.c (window_body_lines): Now static.
9857 * image.c (gif_load): Rename local to avoid shadowing.
9859 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9860 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9861 * alloc.c (make_save_value): Integer argument is now of type
9863 (mark_object): Use ptrdiff_t, not int.
9864 * lisp.h (pD): New macro.
9865 * print.c (print_object): Use it.
9867 * alloc.c: Use EMACS_INT, not int, to count objects.
9868 (total_conses, total_markers, total_symbols, total_vector_size)
9869 (total_free_conses, total_free_markers, total_free_symbols)
9870 (total_free_floats, total_floats, total_free_intervals)
9871 (total_intervals, total_strings, total_free_strings):
9872 Now EMACS_INT, not int. All uses changed.
9873 (Fgarbage_collect): Compute overall total using a double, so that
9874 integer overflow is less likely to be a problem. Check for overflow
9875 when converting back to an integer.
9876 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9877 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9878 These were 'int' variables that could overflow on 64-bit hosts;
9879 they were never used, so remove them instead of repairing them.
9880 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
9881 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9882 Previously, this ceilinged at INT_MAX, but that doesn't work on
9884 (allocate_pseudovector): Don't use EMACS_INT when int would do.
9886 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
9887 (allocate_vectorlike): Check for ptrdiff_t overflow.
9888 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9889 when a (possibly-narrower) signed value would do just as well.
9890 We prefer using signed arithmetic, to avoid comparison confusion.
9892 * alloc.c: Catch some string size overflows that we were missing.
9893 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9894 for convenience in STRING_BYTES_MAX.
9895 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9896 The definition here is exact; the one in lisp.h was approximate.
9897 (allocate_string_data): Check for string overflow. This catches
9898 some instances we weren't catching before. Also, it catches
9899 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9900 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9901 and ptrdiff_t and EMACS_INT are both 64 bits.
9903 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9904 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
9905 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
9907 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9909 * alloc.c (Fmake_string): Check for out-of-range init.
9911 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9913 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9915 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9917 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9918 xg_get_default_scrollbar_width.
9920 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9921 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9922 (style_changed_cb): Call update_theme_scrollbar_width and call
9923 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9924 all frames (Bug#8505).
9925 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9926 Call gtk_window_set_resizable if HAVE_GTK3.
9927 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9928 and height if HAVE_GTK3 (Bug#8505).
9929 (scroll_bar_width_for_theme): New variable.
9930 (update_theme_scrollbar_width): New function.
9931 (xg_get_default_scrollbar_width): Move code to
9932 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9933 (xg_initialize): Call update_theme_scrollbar_width.
9935 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9937 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9939 2011-06-12 Martin Rudalics <rudalics@gmx.at>
9941 * frame.c (make_frame): Call other_buffer_safely instead of
9944 * window.c (temp_output_buffer_show): Call display_buffer with
9945 second argument Vtemp_buffer_show_specifiers and reset latter
9946 immediately after the call.
9947 (Vtemp_buffer_show_specifiers): New variable.
9948 (auto_window_vscroll_p, next_screen_context_lines)
9949 (Vscroll_preserve_screen_position): Remove leading asterisks from
9952 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
9954 Fix minor problems found by GCC 4.6.0 static checking.
9955 * buffer.c (Qclone_number): Remove for now, as it's unused.
9956 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9957 (record_buffer): Remove unused local.
9958 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9959 (set_frame_buffer_list): Remove; unused.
9960 * frame.h (other_visible_frames): Remove decl.
9961 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9962 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9963 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9965 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9966 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9967 Define only if HAVE_GPM.
9968 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9969 (update_hints_inhibit): Remove; never set. All uses removed.
9970 * widgetprv.h (emacsFrameClassRec): Remove decl.
9971 * window.c (delete_deletable_window): Now returns void, since it
9972 wasn't returning anything.
9973 (compare_window_configurations): Remove unused locals.
9974 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9975 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
9976 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9977 the same widths as pointers. This follows up on the 2011-05-06 patch.
9978 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9979 * xterm.h: Likewise.
9980 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9982 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
9984 * makefile.w32-in: Update dependencies.
9985 (LISP_H): Add lib/intprops.h.
9987 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9989 * image.c (gif_load): Add animation frame delay to the metadata.
9990 (syms_of_image): Use DEFSYM. New symbol `delay'.
9992 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9994 * window.c (delete_deletable_window): Re-add.
9995 (Fset_window_configuration): Rewrite to handle dead buffers and
9996 consequently deletable windows.
9997 (window_tree, Fwindow_tree): Remove. Supply functionality in
9999 (compare_window_configurations): Simplify code.
10001 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10003 * image.c (imagemagick_load_image): Fix type mismatch.
10004 (Fimagemagick_types): Likewise.
10006 * window.h (replace_buffer_in_windows): Declare.
10008 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10010 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10011 Qclone_number. Remove external declaration of Qdelete_window.
10012 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10014 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10015 Run Qbuffer_list_update_hook if allowed.
10016 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10017 buffer list implementation.
10018 (other_buffer_safely): New function.
10019 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10020 calls to replace_buffer_in_windows and
10021 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10023 (record_buffer): Inhibit quitting and rewrite using quittable
10024 functions. Run Qbuffer_list_update_hook if allowed.
10025 (Frecord_buffer, Funrecord_buffer): New functions.
10026 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10027 Move switch-to-buffer to window.el.
10028 (bury-buffer): Move to window.el.
10029 (Vbuffer_list_update_hook): New variable.
10031 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10034 * window.h (resize_frame_windows): Move up in code.
10035 (Fwindow_frame): Remove EXFUN.
10036 (replace_buffer_in_all_windows): Remove prototype.
10037 (replace_buffer_in_windows_safely): Add prototype.
10039 * window.c: Declare Qdelete_window static again. Move down
10040 declaration of select_count.
10041 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10042 (Fother_window): Move to window.el.
10043 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10044 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10045 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10047 (replace_buffer_in_windows): Implement by calling
10048 Qreplace_buffer_in_windows.
10049 (replace_buffer_in_all_windows): Remove with some functionality
10050 moved into replace_buffer_in_windows_safely.
10051 (replace_buffer_in_windows_safely): New function.
10052 (select_window_norecord, select_frame_norecord): Move in front
10053 of run_window_configuration_change_hook. Remove now obsolete
10055 (Fset_window_buffer): Rewrite doc-string.
10056 Call Qrecord_window_buffer.
10057 (keys_of_window): Move binding for other-window to window.el.
10059 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10061 * dispextern.h (struct image): Replace data member, whose int_val
10062 and ptr_val fields were not used by anything, with a single
10065 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10066 (gif_clear_image, gif_load, imagemagick_load_image)
10067 (gs_clear_image, gs_load): Callers changed.
10069 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10071 * buffer.h: Include <time.h>, for time_t.
10072 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10074 Fix minor problems found by static checking.
10076 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10078 Make identifiers static if they are not used in other modules.
10079 * data.c (Qcompiled_function, Qframe, Qvector):
10080 * image.c (QimageMagick, Qsvg):
10081 * minibuf.c (Qmetadata):
10082 * window.c (resize_window_check, resize_root_window): Now static.
10083 * window.h (resize_window_check, resize_root_window): Remove decls.
10085 * window.c (window_deletion_count, delete_deletable_window):
10087 (window_body_lines): Now static.
10088 (Fdelete_other_windows_internal): Mark vars as initialized.
10089 Make sure 'resize_failed' is initialized.
10090 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10091 (resize_window_apply): Remove unused local.
10092 * window.h (delete_deletable_window): Remove decl.
10094 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
10095 (imagemagick_load_image): Fix pointer signedness problem by changing
10096 last arg from unsigned char * to char *. All uses changed.
10097 Also, fix a local for similar reasons.
10098 Remove unused locals. Remove locals to avoid shadowing.
10099 (fn_rsvg_handle_free): Remove; unused.
10100 (svg_load, svg_load_image): Fix pointer signedness problem.
10101 (imagemagick_load_image): Don't use garbage pointer image_wand.
10103 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10105 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
10107 * image.c (gif_load): Fix omitted cast error introduced by
10110 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10112 * window.h (resize_proportionally, orig_total_lines)
10113 (orig_top_line): Remove from window structure.
10114 (set_window_height, set_window_width, change_window_heights)
10115 (Fdelete_window): Remove prototypes.
10116 (resize_frame_windows): Remove duplicate declaration.
10118 2011-06-10 Eli Zaretskii <eliz@gnu.org>
10120 * window.h (resize_frame_windows, resize_window_check)
10121 (delete_deletable_window, resize_root_window)
10122 (resize_frame_windows): Declare prototypes.
10124 * window.c (resize_window_apply): Make definition be "static" to
10125 match the prototype.
10127 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10129 * window.c: Remove declarations of Qwindow_size_fixed,
10130 window_min_size_1, window_min_size_2, window_min_size,
10131 size_window, window_fixed_size_p, enlarge_window, delete_window.
10132 Remove static from declaration of Qdelete_window, it's
10133 temporarily needed by Fbury_buffer.
10134 (replace_window): Don't assign orig_top_line and
10136 (Fdelete_window, delete_window): Remove. Window deletion is
10137 handled by window.el.
10138 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10139 Replace Fdelete_window calls with calls to Qdelete_window.
10140 (Fdelete_other_windows): Remove. Deleting other windows is
10141 handled by window.el.
10142 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10143 handled in window.el.
10144 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10145 Window minimum sizes are handled in window.el.
10146 (shrink_windows, size_window, set_window_height)
10147 (set_window_width, change_window_heights, window_height)
10148 (window_width, CURBEG, CURSIZE, enlarge_window)
10149 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10150 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10151 handled in window.el.
10152 (make_dummy_parent): Rename to make_parent_window and give it a
10153 second argument horflag.
10154 (make_window): Don't set resize_proportionally any more.
10155 (Fsplit_window): Remove. Windows are split in window.el.
10156 (save_restore_action, save_restore_orig_size)
10157 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10158 Resize mini windows in window.el.
10159 (grow_mini_window, shrink_mini_window): Implement by calling
10160 Qresize_root_window_vertically, resize_window_check and
10161 resize_window_apply.
10162 (saved_window, Fset_window_configuration, save_window_save):
10163 Do not handle orig_top_line, orig_total_lines, and
10164 resize_proportionally.
10165 (window_min_height, window_min_width): Move to window.el.
10166 (keys_of_window): Move bindings for delete-other-windows,
10167 split-window, delete-window and enlarge-window to window.el.
10169 * buffer.c: Temporarily extern Qdelete_window.
10170 (Fbury_buffer): Temporarily call Qdelete_window instead of
10171 Fdelete_window (Fbury_buffer will move to window.el soon).
10173 * frame.c (set_menu_bar_lines_1): Remove code handling
10174 orig_top_line and orig_total_lines.
10176 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10177 set_window_height but set heights directly.
10178 (change_frame_size_1): Use resize_frame_windows.
10180 * xdisp.c (init_xdisp): Don't use set_window_height but set
10183 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10184 Use resize_frame_windows instead of change_window_heights and run
10185 run_window_configuration_change_hook.
10187 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10188 instead of change_window_heights and run
10189 run_window_configuration_change_hook.
10191 2011-06-09 Martin Rudalics <rudalics@gmx.at>
10193 * window.c (replace_window): Rename second argument REPLACEMENT to
10194 NEW. New third argument SETFLAG. Rewrite.
10195 (delete_window, make_dummy_parent): Call replace_window with
10197 (window_list_1): Move down in code.
10198 (run_window_configuration_change_hook): Move set_buffer part
10199 before select_frame_norecord part in order to unwind correctly.
10200 Rename count1 to count.
10201 (recombine_windows, delete_deletable_window, resize_root_window)
10202 (Fdelete_other_windows_internal)
10203 (Frun_window_configuration_change_hook, make_parent_window)
10204 (resize_window_check, resize_window_apply, Fresize_window_apply)
10205 (resize_frame_windows, Fsplit_window_internal)
10206 (Fdelete_window_internal, Fresize_mini_window_internal):
10208 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10210 2011-06-08 Martin Rudalics <rudalics@gmx.at>
10212 * window.h (window): Add some new members to window structure -
10213 normal_lines, normal_cols, new_total, new_normal, clone_number,
10214 splits, nest, prev_buffers, next_buffers.
10215 (WINDOW_TOTAL_SIZE): Move here from window.c.
10216 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
10218 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10220 (make_dummy_parent): Set new members of windows structure.
10221 (make_window): Move down in code. Handle new members of window
10223 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10224 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10225 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10226 (Fset_window_prev_buffers, Fwindow_next_buffers)
10227 (Fset_window_next_buffers, Fset_window_clone_number):
10229 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10230 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10232 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10233 Argument WINDOW can be now internal window too.
10234 (Fwindow_use_time): Move up in code.
10235 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10236 Rewrite doc-string.
10237 (Fset_window_configuration, saved_window)
10238 (Fcurrent_window_configuration, save_window_save): Handle new
10239 members of window structure.
10240 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10241 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10242 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10243 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10244 Qget_mru_window, Qresize_root_window,
10245 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10246 Qauto_buffer_name; staticpro them.
10248 2011-06-07 Martin Rudalics <rudalics@gmx.at>
10250 * window.c (Fwindow_total_size, Fwindow_left_column)
10251 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10252 (Fwindow_list_1): New functions.
10253 (window_box_text_cols): Replace with window_body_cols.
10254 (Fwindow_width, Fscroll_left, Fscroll_right):
10255 Use window_body_cols instead of window_box_text_cols.
10256 (delete_window, Fset_window_configuration):
10257 Call delete_all_subwindows with window as argument.
10258 (delete_all_subwindows): Take a window as argument and not a
10259 structure. Rewrite.
10260 (window_loop): Remove handling of GET_LRU_WINDOW and
10261 GET_LARGEST_WINDOW.
10262 (Fget_lru_window, Fget_largest_window): Move to window.el.
10264 * window.h: Extern window_body_cols instead of
10265 window_box_text_cols. delete_all_subwindows now takes a
10266 Lisp_Object as argument.
10268 * indent.c (compute_motion, Fcompute_motion):
10269 Use window_body_cols instead of window_box_text_cols.
10271 * frame.c (delete_frame): Call delete_all_subwindows with root
10272 window as argument.
10274 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10276 * fns.c (Fputhash): Document return value.
10278 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
10280 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10282 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10284 Cons<->int and similar integer overflow fixes (Bug#8794).
10286 Check for overflow when converting integer to cons and back.
10287 * charset.c (Fdefine_charset_internal, Fdecode_char):
10288 Use cons_to_unsigned to catch overflow.
10289 (Fencode_char): Use INTEGER_TO_CONS.
10290 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10291 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10292 * data.c (long_to_cons, cons_to_long): Remove.
10293 (cons_to_unsigned, cons_to_signed): New functions.
10294 These signal an error for invalid or out-of-range values.
10295 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10296 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10297 * font.c (Ffont_variation_glyphs):
10298 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10299 * lisp.h: Include <intprops.h>.
10300 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10301 (cons_to_signed, cons_to_unsigned): New decls.
10302 (long_to_cons, cons_to_long): Remove decls.
10303 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10304 (Fprimitive_undo): Use CONS_TO_INTEGER.
10305 * xfns.c (Fx_window_property): Likewise.
10306 * xselect.c: Include <limits.h>.
10307 (x_own_selection, selection_data_to_lisp_data):
10308 Use INTEGER_TO_CONS.
10309 (x_handle_selection_request, x_handle_selection_clear)
10310 (x_get_foreign_selection, Fx_disown_selection_internal)
10311 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10312 (lisp_data_to_selection_data): Use cons_to_unsigned.
10313 (x_fill_property_data): Use cons_to_signed.
10314 Report values out of range.
10316 Check for buffer and string overflow more precisely.
10317 * buffer.h (BUF_BYTES_MAX): New macro.
10318 * lisp.h (STRING_BYTES_MAX): New macro.
10319 * alloc.c (Fmake_string):
10320 * character.c (string_escape_byte8):
10321 * coding.c (coding_alloc_by_realloc):
10322 * doprnt.c (doprnt):
10323 * editfns.c (Fformat):
10325 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10326 since they may not be the same number.
10327 * editfns.c (Finsert_char):
10328 * fileio.c (Finsert_file_contents):
10329 Likewise for BUF_BYTES_MAX.
10331 * image.c: Use ptrdiff_t, not int, for sizes.
10332 (slurp_file): Switch from int to ptrdiff_t.
10334 (slurp_file): Check that file size fits in both size_t (for
10335 malloc) and ptrdiff_t (for sanity and safety).
10337 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10338 if b->modtime has its maximal value.
10340 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10342 Don't assume time_t can fit into int.
10343 * buffer.h (struct buffer.modtime): Now time_t, not int.
10344 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10345 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10347 Minor fixes for signed vs unsigned integers.
10348 * character.h (MAYBE_UNIFY_CHAR):
10349 * charset.c (maybe_unify_char):
10350 * keyboard.c (read_char, reorder_modifiers):
10351 XINT -> XFASTINT, since the integer must be nonnegative.
10352 * ftfont.c (ftfont_spec_pattern):
10353 * keymap.c (access_keymap, silly_event_symbol_error):
10354 XUINT -> XFASTINT, since the integer must be nonnegative.
10355 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10356 since it makes no difference and we prefer signed.
10357 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10358 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10361 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10363 * window.h (Fwindow_frame): Declare.
10365 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10367 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10368 (SPARE_MEMORY): Always define.
10369 (LARGE_REQUEST): Remove.
10370 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10372 2011-06-06 Martin Rudalics <rudalics@gmx.at>
10374 * lisp.h: Move EXFUNS for Fframe_root_window,
10375 Fframe_first_window and Fset_frame_selected_window to window.h.
10377 * window.h: Move EXFUNS for Fframe_root_window,
10378 Fframe_first_window and Fset_frame_selected_window here from
10381 * frame.c (Fwindow_frame, Fframe_first_window)
10382 (Fframe_root_window, Fframe_selected_window)
10383 (Fset_frame_selected_window): Move to window.c.
10384 (Factive_minibuffer_window): Move to minibuf.c.
10385 (Fother_visible_frames_p): New function.
10387 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10389 * window.c (decode_window, decode_any_window): Move up in code.
10390 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10391 (inhibit_frame_unsplittable): Remove unused variable.
10392 (Fwindow_buffer): Move up and rewrite doc-string.
10393 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10394 (Fwindow_prev): New functions.
10395 (Fwindow_frame): Move here from frame.c. Accept any window as
10397 (Fframe_root_window, Fframe_first_window)
10398 (Fframe_selected_window): Move here from frame.c. Accept frame
10399 or arbitrary window as argument. Update doc-strings.
10400 (Fminibuffer_window): Move up in code.
10401 (Fwindow_minibuffer_p): Move up in code and simplify.
10402 (Fset_frame_selected_window): Move here from frame.c.
10404 (Fselected_window, select_window, Fselect_window): Move up in
10405 code. Minor doc-string fixes.
10407 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10409 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10410 Do not assume that spare memory exists; that assumption is valid
10411 only if SYSTEM_MALLOC.
10412 (LARGE_REQUEST): New macro, so that the issue of large requests
10413 is separated from the issue of spare memory.
10415 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10417 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10420 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10422 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10425 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10427 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10429 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10431 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10432 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10434 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
10436 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10438 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
10440 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10441 (x_clipboard_manager_save): Add return value.
10442 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10443 New error handlers.
10444 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10445 Obey Vx_select_enable_clipboard_manager. Catch errors in
10446 x_clipboard_manager_save (Bug#8779).
10447 (Vx_select_enable_clipboard_manager): New variable.
10448 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
10450 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
10452 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10454 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10456 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10457 in the current matrix if keep_current_p is non-zero.
10459 2011-06-04 Eli Zaretskii <eliz@gnu.org>
10461 * bidi.c (bidi_level_of_next_char): Fix last change.
10463 2011-06-03 Eli Zaretskii <eliz@gnu.org>
10465 Support bidi reordering of text covered by display properties.
10467 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10468 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10469 (bidi_cache_search, bidi_cache_iterator_state)
10470 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
10471 (bidi_level_of_next_char, bidi_move_to_visually_next):
10472 Support character positions inside a run of characters covered by a
10474 (bidi_paragraph_init, bidi_resolve_explicit_1)
10475 (bidi_level_of_next_char): Call bidi_fetch_char and
10476 bidi_fetch_char_advance instead of FETCH_CHAR and
10477 FETCH_CHAR_ADVANCE.
10478 (bidi_init_it): Initialize new members.
10479 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10481 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10482 instead of using explicit *_CHAR codes.
10483 (bidi_resolve_explicit, bidi_resolve_weak):
10484 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
10485 bidirectional text is supported only in multibyte buffers.
10486 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10487 it to initialize the frame_window_p member of struct bidi_it.
10488 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10489 (bidi_resolve_explicit, bidi_resolve_weak)
10490 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10491 bidi_it->nchars is non-positive.
10492 (bidi_level_of_next_char): Don't try to lookup the cache for the
10493 next/previous character if nothing is cached there yet, or if we
10494 were just reseat()'ed to a new position.
10496 * xdisp.c (set_cursor_from_row): Set start and stop points
10497 according to the row's direction when priming the loop that looks
10498 for the glyph on which to display cursor.
10499 (single_display_spec_intangible_p): Function deleted.
10500 (display_prop_intangible_p): Reimplement to call
10501 handle_display_spec instead of single_display_spec_intangible_p.
10502 Accept 3 additional arguments needed by handle_display_spec.
10503 This fixes incorrect cursor motion across display property with complex
10504 values: lists, `(when COND...)' forms, etc.
10505 (single_display_spec_string_p): Support property values that are
10506 lists with the argument STRING its top-level element.
10507 (display_prop_string_p): Fix the condition for processing a
10508 property that is a list to be consistent with handle_display_spec.
10509 (handle_display_spec): New function, refactored from the
10510 last portion of handle_display_prop.
10511 (compute_display_string_pos): Accept additional argument
10512 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10513 value of a `display' property is a "replacing spec".
10514 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10515 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10516 the display property, but just return a value indicating whether
10517 the display property will replace the characters it covers.
10518 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10519 frame_window_p members of struct bidi_it.
10520 (compute_display_string_pos, compute_display_string_end):
10522 (push_it): Accept second argument POSITION, where pop_it should
10523 jump to continue iteration.
10524 (reseat_1): Initialize bidi_it.disp_pos.
10526 * keyboard.c (adjust_point_for_property): Adjust the call to
10527 display_prop_intangible_p to its new signature.
10529 * dispextern.h (struct bidi_it): New member frame_window_p.
10530 (bidi_init_it): Update prototypes.
10531 (display_prop_intangible_p): Update prototype.
10532 (compute_display_string_pos, compute_display_string_end):
10533 Declare prototypes.
10534 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10537 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
10539 Malloc failure behavior now depends on size of allocation.
10540 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10541 * lisp.h: Change signatures accordingly.
10542 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10543 All callers changed. (Bug#8762)
10545 * gnutls.c: Use Emacs's memory allocators.
10546 Without this change, the gnutls library would invoke malloc etc.
10547 directly, which causes problems on non-SYNC_INPUT hosts, and which
10548 runs afoul of improving memory_full behavior. (Bug#8761)
10549 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10550 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10551 xfree instead of the default malloc, realloc, free.
10552 (Fgnutls_boot): No need to check for memory allocation failure,
10553 since xmalloc does that for us.
10555 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
10556 * category.c (hash_get_category_set):
10557 * ccl.c (ccl_driver):
10558 * charset.c (Fdefine_charset_internal):
10559 * charset.h (struct charset.hash_index):
10560 * composite.c (get_composition_id, gstring_lookup_cache)
10561 (composition_gstring_put_cache):
10562 * composite.h (struct composition.hash_index):
10563 * dispextern.h (struct image.hash):
10564 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10565 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10566 (hashfn_equal, hashfn_user_defined, make_hash_table)
10567 (maybe_resize_hash_table, hash_lookup, hash_put)
10568 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10569 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10570 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10571 * image.c (make_image, search_image_cache, lookup_image)
10572 (xpm_put_color_table_h):
10573 * lisp.h (struct Lisp_Hash_Table):
10574 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
10575 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
10576 for hashes and hash indexes, instead of 'unsigned' and 'int'.
10577 * alloc.c (allocate_vectorlike):
10578 Check for overflow in vector size calculations.
10579 * ccl.c (ccl_driver):
10580 Check for overflow when converting EMACS_INT to int.
10581 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10582 need to be updated by these changes.
10583 * fns.c (make_hash_table, maybe_resize_hash_table):
10584 Check for integer overflow with large hash tables.
10585 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10586 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10587 (SXHASH_REDUCE): New macro.
10588 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10589 Use it instead of discarding useful hash info with large hash values.
10590 (sxhash_float): New function.
10591 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10592 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
10593 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10594 Rewrite to use FIXNUM_BITS, as this simplifies things.
10595 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10596 Adjust signatures to match updated version of code.
10597 (consing_since_gc): Now EMACS_INT, since a single hash table can
10598 use more than INT_MAX bytes.
10600 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10602 Make it possible to build with GCC-4.6+ -O2 -flto.
10604 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10606 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10608 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10609 Call minibuffer-inactive-mode.
10611 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
10613 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10614 Update dependencies.
10616 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10618 * data.c (init_data): Remove code for UTS, this system is not
10621 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10623 Don't force ./temacs to start in terminal mode.
10625 * frame.c (make_initial_frame): Initialize faces in all cases, not
10626 only when CANNOT_DUMP is defined.
10627 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10629 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10631 * dispnew.c (add_window_display_history): Use const for the string
10632 pointer. Remove declaration, not needed.
10634 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10636 Use 'inline', not 'INLINE'.
10637 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
10638 * alloc.c, fontset.c (INLINE): Remove.
10639 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10640 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10641 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10642 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10643 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10645 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10647 Make it possible to run ./temacs.
10649 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10650 syms_of_callproc does the same thing. Remove test for
10651 "initialized", do it in the caller.
10652 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10654 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10656 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10657 (read_minibuf): Use get_minibuffer.
10658 (syms_of_minibuf): Use DEFSYM.
10659 (Qmetadata): New var.
10660 * data.c (Qbuffer): Don't make it static.
10661 (syms_of_data): Use DEFSYM.
10663 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10665 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10666 (CCL_CODE_MIN): New macro.
10668 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10670 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10672 * eval.c (Qdebug): Now static.
10673 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10674 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10675 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10677 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10679 * image.c: Various fixes to ImageMagick code comments.
10680 (Fimagemagick_types): Doc fix.
10682 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10684 Minor fixes prompted by GCC 4.6.0 warnings.
10686 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10688 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10689 (x_clipboard_manager_save_all): Move extern decl to ...
10690 * xterm.h: ... here, so that it can be checked for consistency.
10692 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10694 * xselect.c (x_clipboard_manager_save_frame)
10695 (x_clipboard_manager_save_all): New functions.
10696 (Fx_clipboard_manager_save): Lisp function deleted.
10698 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10699 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10701 * xterm.h: Update prototype.
10703 2011-05-28 William Xu <william.xwl@gmail.com>
10705 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10706 exiting (Bug#8239).
10708 2011-05-28 Jim Meyering <meyering@redhat.com>
10710 Avoid a sign-extension bug in crypto_hash_function.
10711 * fns.c (to_uchar): Define.
10712 (crypto_hash_function): Use it to convert some newly-signed
10713 variables to unsigned, to avoid sign-extension bugs. For example,
10714 without this change, (md5 "truc") would evaluate to
10715 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10716 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
10717 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
10719 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10721 Integer overflow fixes.
10723 * dbusbind.c: Serial number integer overflow fixes.
10724 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
10725 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10726 to hold a serial number that is too large for a fixnum.
10727 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10728 Check for serial numbers out of range. Decode any serial number
10729 that was so large that it became a float. (Bug#8722)
10731 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10732 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10733 Use XFASTINT rather than XUINT when numbers are nonnegative.
10734 (xd_append_arg, Fdbus_method_return_internal):
10735 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10736 arguments, check that Lisp number is nonnegative, rather than
10737 silently wrapping negative numbers around. (Bug#8722)
10738 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
10741 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10743 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10745 ccl: Add integer overflow checks.
10746 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10747 (IN_INT_RANGE): New macros.
10748 (ccl_driver): Use them to check for integer overflow when
10749 decoding a CCL program. Many of the new checks are whether XINT (x)
10750 fits in int; it doesn't always, on 64-bit hosts. The new version
10751 doesn't catch all possible integer overflows, but it's an
10752 improvement. (Bug#8719)
10754 * alloc.c (make_event_array): Use XINT, not XUINT.
10755 There's no need for unsigned here.
10757 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10758 This follows up to the 2011-05-06 change that substituted uintptr_t
10759 for EMACS_INT. This case wasn't caught back then.
10761 Rework Fformat to avoid integer overflow issues.
10762 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10763 now (part of C89). Include <verify.h>.
10764 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10765 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10766 (Fformat): Avoid the prepass trying to compute sizes; it was only
10767 approximate and thus did not catch overflow reliably. Instead, walk
10768 through the format just once, formatting and computing sizes as we go,
10769 checking for integer overflow at every step, and allocating a larger
10770 buffer as needed. Keep track separately whether the format is
10771 multibyte. Keep only the most-recently calculated precision, rather
10772 than them all. Record whether each argument has been converted to
10773 string. Use EMACS_INT, not int, for byte and char and arg counts.
10774 Support field widths and precisions larger than INT_MAX. Avoid
10775 sprintf's undefined behavior with conversion specifications such as %#d
10776 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10777 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10778 formatting out-of-range floating point numbers with int
10779 formats. (Bug#8668)
10781 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10783 * data.c: Avoid integer truncation in expressions involving floats.
10784 * data.c: Include <intprops.h>.
10785 (arith_driver): When there's an integer overflow in an expression
10786 involving floating point, convert the integers to floating point
10787 so that the resulting value does not suffer from catastrophic
10788 integer truncation. For example, on a 64-bit host (* 4
10789 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10790 Do not rely on undefined behavior after integer overflow.
10792 merge count_size_as_multibyte, parse_str_to_multibyte
10793 * character.c, character.h (count_size_as_multibyte):
10794 Rename from parse_str_to_multibyte; all uses changed.
10795 Check for integer overflow.
10796 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10797 since it's now a duplicate of the other. This is more of
10798 a character than a buffer op, so better that it's in character.c.
10799 * fns.c, print.c: Adjust to above changes.
10801 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10803 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10805 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10807 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10808 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10809 (x_clipboard_manager_save): Now static.
10810 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10812 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10813 (crypto_hash_function): Now static.
10814 Fix pointer signedness problems. Avoid unnecessary initializations.
10816 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
10818 * termhooks.h (Vselection_alist): Make it terminal-local.
10820 * terminal.c (create_terminal): Initialize it.
10822 * xselect.c: Support for clipboard managers.
10823 (Vselection_alist): Move to termhooks.h as terminal-local var.
10824 (LOCAL_SELECTION): New macro.
10825 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10826 (symbol_to_x_atom): Remove gratuitous arg.
10827 (x_handle_selection_request, lisp_data_to_selection_data)
10828 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
10829 (x_own_selection, x_get_local_selection, x_convert_selection):
10830 New arg, specifying work frame. Use terminal-local Vselection_alist.
10831 (some_frame_on_display): Delete unused function.
10832 (Fx_own_selection_internal, Fx_get_selection_internal)
10833 (Fx_disown_selection_internal, Fx_selection_owner_p)
10834 (Fx_selection_exists_p): New optional frame arg.
10835 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10836 (x_handle_selection_clear): Don't treat other terminals with the
10837 same keyboard specially. Use the terminal-local Vselection_alist.
10838 (x_clear_frame_selections): Use Frun_hook_with_args.
10840 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10842 * xterm.h: Add support for those atoms.
10844 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
10846 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10847 (converted_selections, conversion_fail_tag): New global variables.
10848 (x_selection_request_lisp_error): Free the above.
10849 (x_get_local_selection): Remove unnecessary code.
10850 (x_reply_selection_request): Args changed; handle arbitrary array
10851 of converted selections stored in converted_selections.
10852 Separate the XChangeProperty and SelectionNotify steps.
10853 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10854 (x_convert_selection): New function.
10855 (x_handle_selection_event): Simplify.
10856 (x_get_foreign_selection): Don't ignore incoming requests while
10857 waiting for an answer; this will fail when we implement
10858 SAVE_TARGETS, and seems unnecessary anyway.
10859 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10860 (Vx_sent_selection_functions): Doc fix.
10862 2011-05-26 Leo Liu <sdl.web@gmail.com>
10864 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10866 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10868 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10870 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10871 for fringe update if it has periodic bitmap.
10872 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
10873 and fringe_bitmap_periodic_p.
10875 * fringe.c (get_fringe_bitmap_data): New function.
10876 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10877 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10878 row. Mark glyph row for fringe update if periodicity changed.
10880 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10881 for fringe update unless it has periodic bitmap.
10883 2011-05-25 Kenichi Handa <handa@m17n.org>
10885 * xdisp.c (get_next_display_element): Set correct it->face_id for
10886 a static composition.
10888 2011-05-24 Leo Liu <sdl.web@gmail.com>
10891 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10893 * fns.c (crypto_hash_function, Fsha1): New function.
10894 (Fmd5): Use crypto_hash_function.
10895 (syms_of_fns): Add Ssha1.
10897 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10899 * gnutls.c: Remove unused macros.
10900 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10901 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10902 Remove macros that are defined and never used.
10903 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10905 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10907 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10908 (Fx_get_selection_internal): Minor cleanup.
10909 (Fx_own_selection_internal): Rename arguments for consistency with
10912 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10914 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10916 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10918 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10920 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10922 * dispnew.c (scrolling_window): Don't exclude the case that the
10923 last enabled row in the desired matrix touches the bottom boundary.
10925 2011-05-21 Glenn Morris <rgm@gnu.org>
10927 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
10928 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10929 and add some more files.
10931 2011-05-20 Eli Zaretskii <eliz@gnu.org>
10933 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10934 report_file_error introduced by the change from 2011-05-07.
10936 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10938 * systime.h (Time): Define only if emacs is defined.
10939 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10940 where the include path doesn't have X11/X.h by default. See
10941 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10943 2011-05-20 Kenichi Handa <handa@m17n.org>
10945 * composite.c (find_automatic_composition): Fix previous change.
10947 2011-05-20 Glenn Morris <rgm@gnu.org>
10949 * lisp.mk: New file, split from Makefile.in.
10950 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10951 (shortlisp): Remove.
10952 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10954 2011-05-19 Glenn Morris <rgm@gnu.org>
10956 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10957 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10958 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10959 (lisp): Set the order to that of loadup.el.
10960 (shortlisp): Make it a copy of $lisp.
10961 (SOME_MACHINE_LISP): Remove.
10962 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10963 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10965 2011-05-18 Kenichi Handa <handa@m17n.org>
10967 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10968 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10969 (find_automatic_composition): Mostly rewrite for efficiency.
10971 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
10973 * makefile.w32-in: Update dependencies.
10975 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10977 * menu.c: Include limits.h (fixes the MS-Windows build broken by
10978 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
10980 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
10982 Fix some integer overflow issues, such as string length overflow.
10984 * insdel.c (count_size_as_multibyte): Check for string overflow.
10986 * character.c (lisp_string_width): Check for string overflow.
10987 Use EMACS_INT, not int, for string indexes and lengths; in
10988 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10989 the resulting string length overflows an EMACS_INT; instead,
10990 report a string overflow if no precision given. When checking for
10991 precision exhaustion, use a check that cannot possibly have
10992 integer overflow. (Bug#8675)
10993 * character.h (lisp_string_width): Adjust to new signature.
10995 * alloc.c (string_overflow): New function.
10996 (Fmake_string): Use it. This doesn't change behavior, but saves
10997 a few bytes and will simplify future changes.
10998 * character.c (string_escape_byte8): Likewise.
10999 * lisp.h (string_overflow): New decl.
11001 Fixups, following up to the user-interface timestamp change.
11002 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11003 for UI timestamps, instead of unsigned long.
11004 * msdos.c (mouse_get_pos): Likewise.
11005 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
11006 * w32gui.h (Time): Define by including "systime.h" rather than by
11007 declaring it ourselves. (Bug#8664)
11009 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11010 * image.c (clear_image_cache): Likewise.
11012 * term.c (term_mouse_position): Don't assume time_t wraparound.
11014 Be more systematic about user-interface timestamps.
11015 Before, the code sometimes used 'Time', sometimes 'unsigned long',
11016 and sometimes 'EMACS_UINT', to represent these timestamps.
11017 This change causes it to use 'Time' uniformly, as that's what X uses.
11018 This makes the code easier to follow, and makes it easier to catch
11019 integer overflow bugs such as Bug#8664.
11020 * frame.c (Fmouse_position, Fmouse_pixel_position):
11021 Use Time, not unsigned long, for user-interface timestamps.
11022 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11023 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11024 * keyboard.h (last_event_timestamp): Likewise.
11025 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11026 * menu.h (xmenu_show): Likewise.
11027 * term.c (term_mouse_position): Likewise.
11028 * termhooks.h (struct input_event.timestamp): Likewise.
11029 (struct terminal.mouse_position_hook): Likewise.
11030 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11031 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11032 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11033 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11034 what it was before.
11035 * menu.h, termhooks.h: Include "systime.h", for Time.
11037 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11038 Don't assume that the difference between two unsigned long values
11039 can fit into an integer. At this point, we know button_down_time
11040 <= event->timestamp, so the difference must be nonnegative, so
11041 there's no need to cast the result if double-click-time is
11042 nonnegative, as it should be; check that it's nonnegative, just in
11043 case. This bug is triggered when events are more than 2**31 ms
11044 apart (about 25 days). (Bug#8664)
11046 * xselect.c (last_event_timestamp): Remove duplicate decl.
11047 (x_own_selection): Remove needless cast to unsigned long.
11049 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11050 that always fit in int. Use a sentinel instead of a counter, to
11051 avoid a temp and to allay GCC's concerns about possible int overflow.
11052 * frame.h (struct frame): Use int for menu_bar_items_used
11053 instead of EMACS_INT, since it always fits in int.
11055 * menu.c (grow_menu_items): Check for int overflow.
11057 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11059 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11060 Before, the code was not consistent. These values cannot exceed
11061 2**31 - 1 so there's no need to make them unsigned.
11062 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11063 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11064 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11066 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11068 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11069 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11070 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11071 presumably because the widths might not match.
11073 * window.c (size_window): Avoid needless test at loop start.
11075 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11077 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11079 2011-05-12 Drew Adams <drew.adams@oracle.com>
11081 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11083 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11085 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11086 `width' to `bar_area_x' and `bar_area_width', respectively.
11087 (x_scroll_run): Take account of fringe background extension.
11089 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11090 Rename local vars `left' and `width' to `bar_area_x' and
11091 `bar_area_width', respectively.
11092 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11093 background extension.
11095 2011-05-10 Jim Meyering <meyering@redhat.com>
11097 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11099 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
11101 * image.c (Finit_image_library): Return t for built-in image types,
11102 like pbm and xbm. (Bug#8640)
11104 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11106 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11108 2011-05-07 Eli Zaretskii <eliz@gnu.org>
11110 * w32console.c (Fset_screen_color): Doc fix.
11111 (Fget_screen_color): New function.
11112 (syms_of_ntterm): Defsubr it.
11114 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11115 unlink the temporary file if Fcall_process didn't create it in the
11117 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11118 child process will be redirected to a file specified with `:file'.
11119 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11120 cue to call_process_cleanup not to close that handle.
11122 2011-05-07 Ben Key <bkey76@gmail.com>
11124 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11125 one of two shell specific rules, either bootstrap-temacs-CMD or
11126 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11127 to the previous implementation of the bootstrap-temacs rule.
11128 The bootstrap-temacs-CMD rule is similar to the previous
11129 implementation of the bootstrap-temacs rule except that it
11130 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11133 These changes, along with some changes to nt/configure.bat,
11134 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11135 earlier fix to add support for --cflags and --ldflags options
11136 that include quotes so that it works whether make uses cmd or
11139 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
11141 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11142 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11144 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11145 a string. Handle both cases.
11146 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11147 (Fdbus_register_method): Use Qinvalid_function.
11149 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11151 * makefile.w32-in: Update dependencies.
11152 (LISP_H): Add inttypes.h and stdin.h.
11153 (PROCESS_H): Add unistd.h.
11155 2011-05-06 Eli Zaretskii <eliz@gnu.org>
11157 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11158 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11160 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
11162 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11164 * term.c (vfatal): Remove stray call to va_end.
11165 It's not needed and the C Standard doesn't allow it here anyway.
11167 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11168 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11170 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11173 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11175 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11177 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11179 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11181 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11183 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11184 * charset.c (Fdefine_charset_internal): Don't initialize
11185 charset.code_space[15]. The value was garbage, on hosts with
11186 32-bit int (Bug#8600).
11188 * lread.c (read_integer): Be more consistent with string-to-number.
11189 Use string_to_number to do the actual conversion; this avoids
11190 rounding errors and fixes some other screwups. Without this fix,
11191 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11192 (digit_to_number): Move earlier, for benefit of read_integer.
11193 Return -1 if the digit is out of range for the base, -2 if it is
11194 not a digit in any supported base. (Bug#8602)
11196 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11198 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11199 to match comment at start of function. This also removes a
11200 GCC warning about overflow in a 32+64-bit port.
11202 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11204 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11205 Reported by Stefan Monnier in
11206 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
11207 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11208 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
11210 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11211 (EMACS_UINTPTR): Likewise, with uintptr_t.
11213 * lisp.h: Prefer 64-bit EMACS_INT if available.
11214 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11215 on 32-bit hosts that have 64-bit int, so that they can access
11217 However, temporarily disable this change unless the temporary
11218 symbol WIDE_EMACS_INT is defined.
11220 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11222 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11223 This removes an assumption that EMACS_INT and long are the same
11224 width as pointers. The assumption is true for Emacs porting targets
11225 now, but we want to make other targets possible.
11226 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11227 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11228 In the rest of the code, change types of integers that hold casted
11229 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11230 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11231 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11232 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11233 No need to cast type when ORing.
11234 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11235 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11236 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11237 assume EMACS_INT is the same width as char *.
11238 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11239 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11240 Remove no-longer-needed casts.
11241 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11242 (xg_tool_bar_help_callback, xg_make_tool_item):
11243 Use EMACS_INTPTR to hold an integer
11244 that will be cast to void *; this can avoid a GCC warning
11245 if EMACS_INT is not the same width as void *.
11246 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11247 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11248 (current_message_1, set_message_1):
11249 Use a local to convert to proper width without a cast.
11250 * xmenu.c (dialog_selection_callback): Likewise.
11252 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11253 Also, don't assume VALBITS / RAND_BITS is less than 5,
11254 and don't rely on undefined behavior when shifting a 1 left into
11256 * lisp.h (get_random): Change signature to match.
11258 * lread.c (hash_string): Use size_t, not int, for hash computation.
11259 Normally we prefer signed values; but hashing is special, because
11260 it's better to use unsigned division on hash table sizes so that
11261 the remainder is nonnegative. Also, size_t is the natural width
11262 for hashing into memory. The previous code used 'int', which doesn't
11263 retain enough info to hash well into very large tables.
11264 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11266 * dbusbind.c: Don't possibly lose pointer info when converting.
11267 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11268 Use XPNTR rather than XHASH, so that the high-order bits of
11269 the pointer aren't lost when converting through void *.
11271 * eval.c (Fautoload): Don't double-shift a pointer.
11273 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11275 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11277 * gnutls.c (DEF_GNUTLS_FN):
11278 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11280 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11282 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11285 2011-05-05 Eli Zaretskii <eliz@gnu.org>
11287 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11288 New version that can reserve upto 2GB of heap space.
11290 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
11292 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11294 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11296 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11297 `gnutls_certificate_set_x509_key_file'.
11299 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
11301 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11302 Update dependencies.
11304 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11306 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11307 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11308 Remove unused parameter `fildes'.
11309 * process.c (read_process_output, send_process): Don't pass it.
11311 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11313 Fix previous change: the library cache is defined in w32.c.
11314 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11315 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11317 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11319 Implement dynamic loading of GnuTLS on Windows.
11321 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11322 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11323 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11326 * gnutls.c (Qgnutls_dll): Define.
11327 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11328 (gnutls_*): Declare function pointers.
11329 (init_gnutls_functions): New function to initialize function pointers.
11330 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11331 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11332 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11333 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11334 (emacs_gnutls_write, emacs_gnutls_read)
11335 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11336 (Fgnutls_available_p): New function.
11337 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11338 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11339 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11341 * image.c: Include w32.h.
11342 (Vimage_type_cache): Delete.
11343 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11344 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11345 (w32_delayed_load): Move to w32.c.
11347 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11349 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11350 (w32_delayed_load): Move from image.c. When loading a library, record
11351 its filename in the :loaded-from property of the library id.
11352 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11353 Initialize and staticpro them.
11354 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11356 * process.c: Include lisp.h before w32.h, not after.
11357 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11358 instead of gnutls_record_check_pending.
11360 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11362 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11364 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11365 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11368 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11370 * xterm.c (x_set_frame_alpha): Do not set property on anything
11371 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11373 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11375 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11377 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11379 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11380 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11381 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11382 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11383 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11384 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11385 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11386 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11387 (Qgnutls_bootprop_callbacks_verify): Make static.
11389 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11391 * callproc.c: Indentation fixup.
11393 * sysdep.c (wait_for_termination_1): Make static.
11394 (wait_for_termination, interruptible_wait_for_termination):
11395 Move after wait_for_termination_1.
11397 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11399 * sysdep.c (interruptible_wait_for_termination): New function
11400 which is like wait_for_termination, but allows keyboard
11403 * callproc.c (Fcall_process): Add (:file "file") as an option for
11405 (Fcall_process_region): Ditto.
11407 2011-04-30 Eli Zaretskii <eliz@gnu.org>
11409 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11410 rather than `XVECTOR (FOO)->size'.
11412 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11413 inttypes.h, as a gnulib replacement is used if it not available in
11416 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11418 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11419 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11420 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11422 * coding.c (coding_alloc_by_realloc): Error out if destination
11423 will grow beyond MOST_POSITIVE_FIXNUM.
11424 (decode_coding_emacs_mule): Abort if there isn't enough place in
11425 charbuf for the composition carryover bytes. Reserve an extra
11426 space for up to 2 characters produced in a loop.
11427 (decode_coding_iso_2022): Abort if there isn't enough place in
11428 charbuf for the composition carryover bytes.
11430 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11432 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11433 aborting when %lld or %lll format is passed.
11434 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11435 %llo or %llx format is passed. (Bug#8545)
11437 * window.c (window_scroll_line_based): Use a marker instead of
11438 simple variables to record original value of point. (Bug#7952)
11440 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11441 produced by %s or %c overflows available buffer space. (Bug#8545)
11443 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11445 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
11446 (SIZE_MAX): Move defn after all includes, as they might #define it.
11448 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11450 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11452 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11454 * keyboard.c (Qdelayed_warnings_hook): Define.
11455 (command_loop_1): Run `delayed-warnings-hook'
11456 if Vdelayed_warnings_list is non-nil.
11457 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11458 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11460 2011-04-28 Eli Zaretskii <eliz@gnu.org>
11462 * doprnt.c (doprnt): Don't return value smaller than the buffer
11463 size if the message was truncated. (Bug#8545).
11465 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11467 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11468 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11470 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11472 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11474 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
11476 * makefile.w32-in: Update dependencies.
11478 2011-04-27 Eli Zaretskii <eliz@gnu.org>
11480 Improve `doprnt' and its usage. (Bug#8545)
11481 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11482 `format_end'. Remove support for %l as a conversion specifier.
11483 Don't use xrealloc. Improve diagnostics when the %l size modifier
11484 is used. Update the commentary.
11486 * eval.c (verror): Simplify calculation of size_t.
11488 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11491 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11493 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11496 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11498 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11499 This makes this file independent of the recent pseudovector change.
11501 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
11503 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11505 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
11506 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
11507 Remove unused local.
11508 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
11510 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
11511 GCC 4.6.0 optimizes based on type-based alias analysis.
11512 For example, if b is of type struct buffer * and v of type struct
11513 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11514 != &v->size, and therefore "v->size = 1; b->size = 2; return
11515 v->size;" must therefore return 1. This assumption is incorrect
11516 for Emacs, since it type-puns struct Lisp_Vector * with many other
11517 types. To fix this problem, this patch adds a new type struct
11518 vectorlike_header that documents the constraints on layout of vectors
11519 and pseudovectors, and helps optimizing compilers not get fooled
11520 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11521 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
11522 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11524 (XSETPVECTYPE): Rewrite in terms of new macro.
11525 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11526 This is a bit clearer, and further avoids the possibility of
11527 undesirable aliasing.
11528 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
11529 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
11530 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11531 since Lisp_Subr is a special case (no "next" field).
11532 (ASIZE): Now uses header.size rather than size.
11533 All previous uses of XVECTOR (foo)->size replaced to use this macro,
11534 to avoid the hassle of writing XVECTOR (foo)->header.size.
11535 (struct vectorlike_header): New type.
11536 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11537 object, to help avoid aliasing.
11538 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11539 (SUBRP): Likewise, since Lisp_Subr is a special case.
11540 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11541 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11542 (struct Lisp_Hash_Table): Combine first two members into a single
11543 struct vectorlike_header member. All uses of "size" and "next" members
11544 changed to be "header.size" and "header.next".
11545 * buffer.h (struct buffer): Likewise.
11546 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11547 * frame.h (struct frame): Likewise.
11548 * process.h (struct Lisp_Process): Likewise.
11549 * termhooks.h (struct terminal): Likewise.
11550 * window.c (struct save_window_data, struct saved_window): Likewise.
11551 * window.h (struct window): Likewise.
11552 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11553 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11554 * buffer.c (init_buffer_once): Likewise.
11555 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11557 * process.c (Fformat_network_address): Use local var for size,
11560 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11562 Make the Lisp reader and string-to-float more consistent (Bug#8525)
11563 * data.c (atof): Remove decl; no longer used or needed.
11564 (digit_to_number): Move to lread.c.
11565 (Fstring_to_number): Use new string_to_number function, to be
11566 consistent with how the Lisp reader treats infinities and NaNs.
11567 Do not assume that floating-point numbers represent EMACS_INT
11568 without losing information; this is not true on most 64-bit hosts.
11569 Avoid double-rounding errors, by insisting on integers when
11570 parsing non-base-10 numbers, as the documentation specifies.
11571 * lisp.h (string_to_number): New decl, replacing ...
11572 (isfloat_string): Remove.
11573 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
11574 (read1): Do not accept +. and -. as integers; this
11575 appears to have been a coding error. Similarly, do not accept
11576 strings like +-1e0 as floating point numbers. Do not report
11577 overflow for integer overflows unless the base is not 10 which
11578 means we have no simple and reliable way to continue.
11579 Break out the floating-point parsing into a new
11580 function string_to_number, so that Fstring_to_number parses
11581 floating point numbers consistently with the Lisp reader.
11582 (digit_to_number): Move here from data.c. Make it static inline.
11583 (E_CHAR, EXP_INT): Remove, replacing with ...
11584 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11585 (string_to_number): New function, replacing isfloat_string.
11586 This function checks for valid syntax and produces the resulting
11587 Lisp float number too. Rework it so that string-to-number
11588 no longer mishandles examples like "1.0e+". Use strtoumax,
11589 so that overflow for non-base-10 numbers is reported only when
11590 there's no portable and simple way to convert to floating point.
11592 * textprop.c (set_text_properties_1): Rewrite for clarity,
11593 and to avoid GCC warning about integer overflow.
11595 * intervals.h (struct interval): Use EMACS_INT for members
11596 where EMACS_UINT might cause problems. See
11597 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11598 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11599 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11601 (offset_intervals): Tell GCC not to worry about length overflow
11602 when negating a negative length.
11604 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11605 (overrun_check_free): Likewise.
11607 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11608 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11611 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11612 (gnutls_make_error): Rename local to avoid shadowing.
11613 (gnutls_emacs_global_deinit): ifdef out; not used.
11614 (Fgnutls_boot): Use const for pointer to readonly storage.
11615 Comment out unused local. Fix pointer signedness problems.
11617 * lread.c (openp): Don't stuff size_t into an 'int'.
11618 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11619 about possible signed overflow.
11621 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11622 (GDK_KEY_g): Don't define if already defined.
11623 (xg_prepare_tooltip): Avoid pointer signedness problem.
11624 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11626 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11627 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11629 * xfns.c (Fx_window_property): Simplify a bit,
11630 to make a bit faster and to avoid GCC 4.6.0 warning.
11631 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11633 * fns.c (internal_equal): Don't assume size_t fits in int.
11635 * alloc.c (compact_small_strings): Tighten assertion a little.
11637 Replace pEd with more-general pI, and fix some printf arg casts.
11638 * lisp.h (pI): New macro, generalizing old pEd macro to other
11639 conversion specifiers. For example, use "...%"pI"d..." rather
11640 than "...%"pEd"...".
11641 (pEd): Remove. All uses replaced with similar uses of pI.
11642 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
11643 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11644 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11645 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11646 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11647 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11648 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11650 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11651 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11652 * print.c (safe_debug_print, print_object): Likewise.
11653 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11655 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11656 avoiding the 0 flag, which is not portable.
11657 * process.c (Fmake_network_process): Use pI to avoid cast.
11658 * region-cache.c (pp_cache): Likewise.
11659 * xdisp.c (decode_mode_spec): Likewise.
11660 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11661 behavior on 64-bit hosts with printf arg.
11662 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
11663 (x_stop_queuing_selection_requests): Likewise.
11664 (x_get_window_property): Don't truncate byte count to an 'int'
11667 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11668 here, since it parses constructs like leading '-' and spaces,
11669 which are not wanted; and it overflows with large numbers.
11670 Instead, simply match F[0-9]+, which is what is wanted anyway.
11672 * alloc.c: Remove unportable assumptions about struct layout.
11673 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11674 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11675 (allocate_vectorlike, make_pure_vector): Use the new macros,
11676 plus offsetof, to remove unportable assumptions about struct layout.
11677 These assumptions hold on all porting targets that I know of, but
11678 they are not guaranteed, they're easy to remove, and removing them
11679 makes further changes easier.
11681 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11682 This doesn't fix a bug but makes the code clearer.
11683 (string_overrun_cookie): Now const. Use initializers that
11684 don't formally overflow signed char, to avoid warnings.
11685 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11686 can cause Emacs to crash when string overrun checking is enabled.
11687 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11688 multiple of sizeof (EMACS_INT); it need not be, if
11689 alignof(EMACS_INT) < sizeof (EMACS_INT).
11690 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
11692 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
11694 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11696 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11698 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
11699 supposed to be handshaking. (Bug#8556)
11700 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11702 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
11704 * lisp.h (Qdebug): List symbol.
11705 * eval.c (Qdebug): Restore global linkage.
11706 * keyboard.c (debug-on-event): New variable.
11707 (handle_user_signal): Break into debugger when debug-on-event
11708 matches the current signal symbol.
11710 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11712 * alloc.c (check_sblock, check_string_bytes)
11713 (check_string_free_list): Convert to standard C.
11715 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11717 * w32.c (emacs_gnutls_push): Fix typo.
11719 2011-04-25 Eli Zaretskii <eliz@gnu.org>
11721 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11722 "cast to pointer from integer of different size".
11724 Improve doprnt and its use in verror. (Bug#8545)
11725 * doprnt.c (doprnt): Document the set of format control sequences
11726 supported by the function. Use SAFE_ALLOCA instead of always
11729 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11730 is one byte too soon. Don't use xrealloc; instead xfree and
11733 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11735 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11738 * gnutls.c: Renamed global_initialized to
11739 gnutls_global_initialized. Added internals for the
11740 :verify-hostname-error, :verify-error, and :verify-flags
11741 parameters of `gnutls-boot' and documented those parameters in the
11742 docstring. Start callback support.
11743 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11744 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11745 on error. Return error code.
11746 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11747 (emacs_gnutls_read): Likewise.
11748 (Fgnutls_boot): Return handshake error code.
11749 (emacs_gnutls_handle_error): New function.
11750 (wsaerror_to_errno): Likewise.
11752 * w32.h (emacs_gnutls_pull): Add prototype.
11753 (emacs_gnutls_push): Likewise.
11755 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11756 (emacs_gnutls_push): Likewise.
11758 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11760 * process.c (wait_reading_process_output): Check if GnuTLS
11761 buffered some data internally if no FDs are set for TLS
11764 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11765 (LIBS): Link to USER_LIBS.
11766 ($(BLD)/gnutls.$(0)): New target.
11768 2011-04-24 Eli Zaretskii <eliz@gnu.org>
11770 * xdisp.c (handle_single_display_spec): Rename the
11771 display_replaced_before_p argument into display_replaced_p, to
11772 make it consistent with the commentary. Fix typos in the
11775 * textprop.c (syms_of_textprop): Remove dead code.
11776 (copy_text_properties): Delete obsolete commentary about an
11777 interface that was deleted long ago. Fix typos in the description
11780 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11781 to changes in oldXMenu/XMenu.h from 2011-04-16.
11782 <menu_help_message, prev_menu_help_message>: Constify.
11783 (IT_menu_make_room): menu->help_text is now `const char **';
11786 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11787 to changes in oldXMenu/XMenu.h from 2011-04-16.
11788 (struct XMenu): Declare `help_text' `const char **'.
11790 * xfaces.c <Qunspecified>: Make extern again.
11792 * syntax.c: Include sys/types.h before including regex.h, as
11795 * doc.c (get_doc_string): Improve the format passed to `error'.
11797 * doprnt.c (doprnt): Improve commentary.
11799 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11801 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11804 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11805 changes in globals.h immediately force recompilation.
11806 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11807 $(CURDIR)/s/ms-w32.h.
11808 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
11810 * character.c (Fchar_direction): Function deleted.
11811 (syms_of_character): Don't defsubr it.
11812 <char-direction-table>: Deleted.
11814 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11816 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11817 * doprnt.c: Include limits.h.
11818 (SIZE_MAX): New macro.
11819 (doprnt): Return a size_t value. 2nd arg is now size_t.
11820 Many local variables are now size_t instead of int or unsigned.
11821 Improve overflow protection. Support `l' modifier for integer
11822 conversions. Support %l conversion. Don't assume an EMACS_INT
11823 argument for integer conversions and for %c.
11825 * lisp.h (doprnt): Restore prototype.
11827 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11828 $(SRC)/character.h.
11830 * Makefile.in (base_obj): Add back doprnt.o.
11832 * deps.mk (doprnt.o): Add back prerequisites.
11833 (callint.o): Depend on character.h.
11835 * eval.c (internal_lisp_condition_case): Include the handler
11836 representation in the error message.
11837 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11838 when breaking from the loop.
11840 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11842 * callint.c (Fcall_interactively): When displaying error message
11843 about invalid control letter, pass the character's codepoint, not
11844 a pointer to its multibyte form. Improve display of the character
11845 in octal and display also its hex code.
11847 * character.c (char_string): Use %x to display the (unsigned)
11848 codepoint of an invalid character, to avoid displaying a bogus
11851 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11852 `error', not SYMBOL_NAME itself.
11854 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11855 character arguments to `error'.
11857 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11858 to `error' in error message about FINAL_CHAR argument. Make sure
11859 FINAL_CHAR is a character, and use %c when it is passed as
11860 argument to `error'.
11862 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11864 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11866 * w32.c: Include <time.h>.
11867 (sys_localtime): New function.
11869 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
11871 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11873 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
11875 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
11877 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11878 zombies (Bug#8467).
11880 2011-04-19 Eli Zaretskii <eliz@gnu.org>
11882 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11883 gl_state.e_property when gl_state.object is Qt.
11885 * insdel.c (make_gap_larger): Remove limitation of buffer size
11888 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
11890 * xdisp.c (lookup_glyphless_char_display)
11891 (produce_glyphless_glyph): Handle cons cell entry in
11892 glyphless-char-display.
11893 (Vglyphless_char_display): Document it.
11895 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11896 glyphless-char-display.
11898 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
11900 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11902 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11904 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11905 definition for no-X builds.
11907 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
11909 Static checks with GCC 4.6.0 and non-default toolkits.
11911 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11913 * process.c (keyboard_bit_set): Define only if SIGIO.
11914 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11915 (send_process): Repair possible setjmp clobbering.
11917 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11919 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11921 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11923 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11924 Define only if needed.
11926 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11927 by pacifying GCC about it. Maybe it's time to retire it?
11928 * xfaces.c (USG, __TIMEVAL__): Likewise.
11930 * dispextern.h (struct redisplay_interface): Rename param
11931 to avoid shadowing.
11932 * termhooks.h (struct terminal): Likewise.
11933 * xterm.c (xembed_send_message): Likewise.
11935 * insdel.c (make_gap_smaller): Define only if
11936 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11938 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11941 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11942 so that we aren't warned about unused symbols.
11944 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11946 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
11948 * xfns.c (x_real_positions): Mark locals as initialized.
11950 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11952 * xterm.c: Fix problems found by static analysis with other toolkits.
11953 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
11954 (x_dispatch_event): Declare static if USE_GTK, and
11955 define if USE_GTK || USE_X_TOOLKIT.
11956 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
11957 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
11958 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11959 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
11961 * xmenu.c (menu_help_callback): Pointer type fixes.
11962 Use const pointers when pointing at readonly data. Avoid pointer
11963 signedness clashes.
11964 (FALSE): Remove unused macro.
11965 (update_frame_menubar): Remove unused decl.
11967 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11969 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11970 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11971 (single_menu_item): Rename local to avoid shadowing.
11973 * keyboard.c (make_lispy_event): Remove unused local var.
11975 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11976 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11978 * bitmaps: Change bitmaps from unsigned char back to the X11
11979 compatible char. Avoid the old compiler warnings about
11980 out-of-range initializers by using, for example, '\xab' rather
11983 * xgselect.c (xgselect_initialize): Check vs interface
11984 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11986 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11988 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11989 to read-only memory.
11991 * fns.c (vector): Remove; this old hack is no longer needed.
11993 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
11995 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
11997 * xrdb.c (x_load_resources): Omit unused local.
11999 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
12000 (x_window): Rename locals to avoid shadowing.
12001 (USG): Use the kludged USG macro, to pacify gcc.
12003 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
12004 (x_term_init): Remove local to avoid shadowing.
12006 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
12008 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12009 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12011 2011-04-16 Eli Zaretskii <eliz@gnu.org>
12013 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12015 Fix regex.c, syntax.c and friends for buffers > 2GB.
12016 * syntax.h (struct gl_state_s): Declare character position members
12019 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12021 * textprop.c (verify_interval_modification, interval_of):
12022 Declare arguments EMACS_INT.
12024 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12027 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12029 * indent.c (Fvertical_motion): Local variable it_start is now
12032 * regex.c (re_match, re_match_2, re_match_2_internal)
12033 (bcmp_translate, regcomp, regexec, print_double_string)
12034 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12035 (re_compile_pattern, re_exec): Declare arguments and local
12036 variables `size_t' and `ssize_t' and return values `regoff_t', as
12038 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12039 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12040 <compile_stack_type>: `size' and `avail' are now `size_t'.
12042 * regex.h <regoff_t>: Use ssize_t, not int.
12043 (re_search, re_search_2, re_match, re_match_2): Arguments that
12044 specify buffer/string position and length are now ssize_t and
12045 size_t. Return type is regoff_t.
12047 2011-04-16 Ben Key <bkey76@gmail.com>
12049 * nsfont.m: Fixed bugs in ns_get_family and
12050 ns_descriptor_to_entity that were caused by using free to
12051 deallocate memory blocks that were allocated by xmalloc (via
12052 xstrdup). This caused Emacs to crash when compiled with
12053 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12054 --enable-checking=xmallocoverrun). xfree is now used to
12055 deallocate these memory blocks.
12057 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
12059 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12061 emacs_write: Accept and return EMACS_INT for sizes.
12062 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12064 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12065 Accept and return EMACS_INT.
12066 (emacs_gnutls_write): Return the number of bytes written on
12068 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
12069 (emacs_read, emacs_write): Remove check for negative size, as the
12070 Emacs source code has been audited now.
12071 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12072 (emacs_read, emacs_write): Use it.
12073 * process.c (send_process): Adjust to the new signatures of
12074 emacs_write and emacs_gnutls_write. Do not attempt to store
12075 a byte offset into an 'int'; it might overflow.
12076 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
12078 * sound.c: Don't assume sizes fit in 'int'.
12079 (struct sound_device.period_size, alsa_period_size):
12080 Return EMACS_INT, not int.
12081 (struct sound_device.write, vox_write, alsa_write):
12082 Accept EMACS_INT, not int.
12083 (wav_play, au_play): Use EMACS_INT to store sizes and to
12084 record read return values.
12086 2011-04-15 Ben Key <bkey76@gmail.com>
12088 * keyboard.c (Qundefined): Don't declare static since it is used
12090 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12091 static since they are used in nsfont.m.
12093 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12095 * process.c (Qprocessp): Don't declare static.
12096 * lisp.h (Qprocessp): Declare again.
12098 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
12100 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12102 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12104 Improve C-level modularity by making more things 'static'.
12106 Don't publish debugger-only interfaces to other modules.
12107 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12108 (verify_bytepos, count_markers): Move decls to the only modules
12110 * region-cache.h (pp_cache): Likewise.
12111 * window.h (check_all_windows): Likewise.
12112 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12114 * sysdep.c (croak): Now static, if
12115 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12116 * syssignal.h (croak): Declare only if not static.
12118 * alloc.c (refill_memory_reserve): Now static if
12119 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12120 * lisp.h (refill_memory_reserve): Declare only if not static.
12122 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12123 Define only if USE_LUCID.
12125 * xrdb.c (x_customization_string, x_rm_string): Now static.
12127 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12128 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12130 * xdisp.c (draw_row_with_mouse_face): Now static.
12131 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12133 * window.h (check_all_windows): Mark externally visible.
12135 * window.c (window_deletion_count): Now static.
12137 * undo.c: Make symbols static if they're not exported.
12138 (last_undo_buffer, last_boundary_position, pending_boundary):
12141 * textprop.c (interval_insert_behind_hooks): Now static.
12142 (interval_insert_in_front_hooks): Likewise.
12144 * term.c: Make symbols static if they're not exported.
12145 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12146 (max_frame_lines, tty_set_terminal_modes):
12147 (tty_reset_terminal_modes, tty_turn_off_highlight):
12148 (get_tty_terminal): Now static.
12149 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12150 * termhooks.h (term_mouse_moveto): Do not declare if
12151 HAVE_WINDOW_SYSTEM.
12152 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12153 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12155 * sysdep.c: Make symbols static if they're not exported.
12156 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12158 (sigprocmask_set, full_mask): Remove; unused.
12159 (wait_debugging): Mark as visible.
12160 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12161 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12163 * syntax.c (syntax_temp): Define only if !__GNUC__.
12165 * sound.c (current_sound_device, current_sound): Now static.
12167 * search.c (searchbufs, searchbuf_head): Now static.
12169 * scroll.c (scroll_cost): Remove; unused.
12170 * dispextern.h (scroll_cost): Remove decl.
12172 * region-cache.h (pp_cache): Mark as externally visible.
12174 * process.c: Make symbols static if they're not exported.
12175 (process_tick, update_tick, create_process, chan_process):
12176 (Vprocess_alist, proc_buffered_char, datagram_access):
12177 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12178 (deactivate_process): Mark defn as static, as well as decl.
12179 * lisp.h (create_process): Remove decl.
12180 * process.h (chan_process, Vprocess_alist): Remove decls.
12182 * print.c: Make symbols static if they're not exported.
12183 (print_depth, new_backquote_output, being_printed, print_buffer):
12184 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12185 (print_interval, print_number_index, initial_stderr_stream):
12187 * lisp.h (Fprinc): Remove decl.
12188 (debug_output_compilation_hack): Mark as externally visible.
12190 * sysdep.c (croak): Move decl from here to syssignal.h.
12191 * syssignal.h (croak): Put it here, so the API can be checked when
12192 'croak' is called from dissociate_if_controlling_tty.
12194 * minibuf.c: Make symbols static if they're not exported.
12195 (minibuf_save_list, choose_minibuf_frame): Now static.
12196 * lisp.h (choose_minibuf_frame): Remove decl.
12198 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12200 * lread.c: Make symbols static if they're not exported.
12201 (read_objects, initial_obarray, oblookup_last_bucket_number):
12203 (make_symbol): Remove; unused.
12204 * lisp.h (initial_obarray, make_symbol): Remove decls.
12206 * keyboard.c: Make symbols static if they're not exported.
12207 (single_kboard, recent_keys_index, total_keys, recent_keys):
12208 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12209 (this_single_command_key_start, echoing, last_auto_save):
12210 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12211 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12212 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12213 (Vlispy_mouse_stem, double_click_count):
12215 (force_auto_save_soon): Define only if SIGDANGER.
12216 (ignore_mouse_drag_p): Now static if
12217 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12218 (print_help): Remove; unused.
12219 (stop_character, last_timer_event): Mark as externally visible.
12220 * keyboard.h (ignore_mouse_drag_p): Declare only if
12221 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12222 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12223 * lisp.h (echoing): Remove decl.
12224 (force_auto_save_soon): Declare only if SIGDANGER.
12225 * xdisp.c (redisplay_window): Simplify code, to make it more
12226 obvious that ignore_mouse_drag_p is not accessed if !defined
12227 USE_GTK && !defined HAVE_NS.
12229 * intervals.c: Make symbols static if they're not exported.
12230 (merge_properties_sticky, merge_interval_right, delete_interval):
12232 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12234 * insdel.c: Make symbols static if they're not exported.
12235 However, leave prepare_to_modify_buffer alone. It's never
12236 called from outside this function, but that appears to be a bug.
12237 (combine_after_change_list, combine_after_change_buffer):
12238 (adjust_after_replace, signal_before_change): Now static.
12239 (adjust_after_replace_noundo): Remove; unused.
12240 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
12241 (signal_before_change): Remove decls.
12243 * indent.c (val_compute_motion, val_vmotion): Now static.
12245 * image.c: Make symbols static if they're not exported.
12246 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12248 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12249 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12251 * fringe.c (standard_bitmaps): Now static.
12252 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12254 * frame.c: Make symbols static if they're not exported.
12255 (x_report_frame_params, make_terminal_frame): Now static.
12256 (get_frame_param): Now static, unless HAVE_NS.
12257 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12258 (x_get_resource_string): Remove; not used.
12259 * frame.h (make_terminal_frame, x_report_frame_params):
12260 (x_get_resource_string); Remove decls.
12261 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12262 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12264 * font.c, fontset.c: Make symbols static if they're not exported.
12265 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12266 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12267 * font.c (font_close_object): Now static.
12268 * font.h (font_close_object): Remove.
12269 * fontset.c (FONTSET_OBJLIST): Remove.
12270 (free_realized_fontset) #if-0 the body, which does nothing.
12271 (face_suitable_for_char_p): #if-0, as it's never called.
12272 * fontset.h (face_suitable_for_char_p): Remove decl.
12273 * xfaces.c (face_at_string_position):
12274 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
12275 since 0 is always ASCII.
12277 * fns.c (weak_hash_tables): Now static.
12279 * fileio.c: Make symbols static if they're not exported.
12280 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12281 (Vwrite_region_annotation_buffers): Now static.
12283 * eval.c: Make symbols static if they're not exported.
12284 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12285 * lisp.h (backtrace_list): Remove decl.
12287 * emacs.c: Make symbols static if they're not exported.
12288 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12289 (fatal_error_code, fatal_error_signal_hook, standard_args):
12291 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12292 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12293 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12294 * lisp.h (fatal_error_signal_hook): Remove decl.
12295 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12297 * editfns.c: Move a (normally-unused) function to its only use.
12298 * editfns.c, lisp.h (get_operating_system_release): Remove.
12299 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12300 worth the hassle of breaking this out.
12302 * xterm.c: Make symbols static if they're not exported.
12303 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12304 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12305 (x_destroy_window, x_delete_display):
12307 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12308 (x_mouse_leave): Remove; unused.
12309 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12310 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12311 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12313 (x_mouse_leave): Declare only if WINDOWSNT.
12314 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12315 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12318 * ftxfont.c: Make symbols static if they're not exported.
12319 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12321 * font.h (ftxfont_driver): Likewise.
12323 * xfns.c: Make symbols static if they're not exported.
12324 (x_last_font_name, x_display_info_for_name):
12325 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12326 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12327 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12328 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12329 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12330 (last_show_tip_args): Now static.
12331 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12332 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12333 (x_screen_planes): Remove; unused.
12334 * dispextern.h (x_screen_planes): Remove decl.
12336 * dispnew.c: Make symbols static if they're not exported.
12337 * dispextern.h (redraw_garbaged_frames, scrolling):
12338 (increment_row_positions): Remove.
12339 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12340 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12342 (redraw_garbaged_frames): Remove; unused.
12344 * xfaces.c: Make symbols static if they're not exported.
12345 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12347 * xterm.h (defined_color): Remove decls.
12348 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12349 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12350 (menu_face_changed_default, defined_color, free_realized_face):
12351 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12352 (ascii_face_of_lisp_face): Remove; unused.
12354 * xdisp.c: Make symbols static if they're not exported.
12355 * dispextern.h (scratch_glyph_row, window_box_edges):
12356 (glyph_to_pixel_coords, set_cursor_from_row):
12357 (get_next_display_element, set_iterator_to_next):
12358 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12359 (show_mouse_face): Remove decls
12360 * frame.h (message_buf_print): Likewise.
12361 * lisp.h (pop_message, set_message, check_point_in_composition):
12363 * xterm.h (set_vertical_scroll_bar): Likewise.
12364 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12365 (message_buf_print, scratch_glyph_row, displayed_buffer):
12366 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12367 (get_next_display_element, show_mouse_face, window_box_edges):
12368 (frame_to_window_pixel_xy, check_point_in_composition):
12369 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12370 (glyph_to_pixel_coords): Remove; unused.
12372 * dired.c (file_name_completion): Now static.
12374 * dbusbind.c (xd_in_read_queued_messages): Now static.
12376 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12377 * data.c (circular_list_error): Remove.
12379 * commands.h (last_point_position, last_point_position_buffer):
12380 (last_point_position_window): Remove decls.
12381 * keyboard.c: Make these variables static.
12383 * coding.h (coding, code_convert_region, encode_coding_gap):
12385 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12386 (iso_code_class, detect_coding, code_convert_region): Now static.
12387 (encode_coding_gap): Remove; unused.
12389 * chartab.c (chartab_chars, chartab_bits): Now static.
12391 * charset.h (charset_iso_8859_1): Remove decl.
12392 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12395 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12396 * ccl.c (Vccl_program_table): Now static.
12397 (check_ccl_update): Remove; unused.
12399 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12400 * category.h: ... from here.
12401 * category.c (check_category_table, set_category_set): Now static.
12403 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12404 * lisp.h: Remove these decls.
12406 * buffer.c (buffer_count): Remove unused var.
12408 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12409 so that it's not optimized away.
12410 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12411 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12412 exported only to the debugger.
12414 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
12415 * atimer.h (run_all_atimers): Remove; not exported.
12417 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12418 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12419 was inaccessible from Lisp.
12420 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12421 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12423 alloc.c: Import and export fewer symbols, and remove unused items.
12424 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12426 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12427 it's not optimized away by whole-program optimization.
12428 (message_enable_multibyte, free_misc): Remove.
12429 (catchlist, handlerlist, mark_backtrace):
12430 Declare only if BYTE_MARK_STACK.
12431 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12432 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12433 (message_enable_multibyte): Remove decl.
12434 (free_misc, interval_free_list, float_block, float_block_index):
12435 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12436 (cons_free_list, last_marked_index):
12438 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12439 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12440 (mark_backtrace): Define only if BYTE_MARK_STACK.
12441 * xdisp.c (message_enable_multibyte): Now static.
12443 Declare Lisp_Object Q* variables to be 'static' if not exported.
12444 This makes it easier for human readers (and static analyzers)
12445 to see whether these variables are used from other modules.
12446 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12447 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12448 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12449 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12450 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12451 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12452 * xmenu.c, xselect.c:
12453 Declare Q* vars static if they are not used in other modules.
12454 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12455 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12456 Remove decls of unexported vars.
12457 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12459 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12461 Make Emacs functions such as Fatom 'static' by default.
12462 This makes it easier for human readers (and static analyzers)
12463 to see whether these functions can be called from other modules.
12464 DEFUN now defines a static function. To make the function external
12465 so that it can be used in other C modules, use the new macro DEFUE.
12466 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12467 (Finit_image_library):
12468 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12469 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12470 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12471 Remove decls, since these functions are now static.
12472 (Funintern, Fget_internal_run_time): New decls, since these functions
12473 were already external.
12475 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12476 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12477 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12478 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12479 * keyboard.c, keymap.c, lread.c:
12480 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12481 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12482 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12483 Mark functions with DEFUE instead of DEFUN,
12484 if they are used in other modules.
12485 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12486 decls for now-static functions.
12487 * buffer.h (Fdelete_overlay): Remove decl.
12488 * callproc.c (Fgetenv_internal): Mark as internal.
12489 * composite.c (Fremove_list_of_text_properties): Remove decl.
12490 (Fcomposition_get_gstring): New forward static decl.
12491 * composite.h (Fcomposite_get_gstring): Remove decl.
12492 * dired.c (Ffile_attributes): New forward static decl.
12493 * doc.c (Fdocumntation_property): New forward static decl.
12494 * eval.c (Ffetch_bytecode): New forward static decl.
12495 (Funintern): Remove extern decl; now in .h file where it belongs.
12496 * fileio.c (Fmake_symbolic_link): New forward static decl.
12497 * image.c (Finit_image_library): New forward static decl.
12498 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12499 * intervals.h (Fprevious_property_change):
12500 (Fremove_list_of_text_properties): Remove decls.
12501 * keyboard.c (Fthis_command_keys): Remove decl.
12502 (Fcommand_execute): New forward static decl.
12503 * keymap.c (Flookup_key): New forward static decl.
12504 (Fcopy_keymap): Now static.
12505 * keymap.h (Flookup_key): Remove decl.
12506 * process.c (Fget_process): New forward static decl.
12507 (Fprocess_datagram_address): Mark as internal.
12508 * syntax.c (Fsyntax_table_p): New forward static decl.
12509 (skip_chars): Remove duplicate decl.
12510 * textprop.c (Fprevious_property_change): New forward static decl.
12511 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12513 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12514 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12516 * editfns.c (Fformat): Remove unreachable code.
12518 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12520 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12523 2011-04-13 Eli Zaretskii <eliz@gnu.org>
12525 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12526 when at ZV. (Bug#8487)
12528 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12530 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12532 * keyboard.c (parse_tool_bar_item): Likewise.
12533 * sound.c (sound_cleanup, alsa_close): Likewise.
12534 * termcap.c (tgetent): Likewise.
12535 * xfns.c (x_default_font_parameter): Likewise.
12536 * xsettings.c (read_and_apply_settings): Likewise.
12538 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12539 (overrun_check_free): Protoize.
12541 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12543 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12544 since callers should never pass a negative size.
12545 Change the signature to match that of plain 'read' and 'write'; see
12546 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12547 * lisp.h: Update prototypes of emacs_write and emacs_read.
12549 2011-04-11 Eli Zaretskii <eliz@gnu.org>
12551 * xdisp.c (redisplay_window): Don't try to determine the character
12552 position of the scroll margin if the window start point w->startp
12553 is outside the buffer's accessible region. (Bug#8468)
12555 2011-04-10 Eli Zaretskii <eliz@gnu.org>
12557 Fix write-region and its subroutines for buffers > 2GB.
12558 * fileio.c (a_write, e_write): Modify declaration of arguments and
12559 local variables to support buffers larger than 2GB.
12560 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12562 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12563 argument, local variables, and return value.
12565 * lisp.h: Update prototypes of emacs_write and emacs_read.
12567 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12569 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
12571 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12573 Fix more problems found by GCC 4.6.0's static checks.
12575 * xdisp.c (vmessage): Use a better test for character truncation.
12577 * charset.c (load_charset_map): <, not <=, for optimization,
12578 and to avoid potential problems with integer overflow.
12579 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
12580 * casetab.c (set_identity, shuffle): Likewise.
12581 * editfns.c (Fformat): Likewise.
12582 * syntax.c (skip_chars): Likewise.
12584 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12585 This also lets GCC 4.6.0 generate slightly better loop code.
12587 * callint.c (Fcall_interactively): <, not <=, for optimization.
12588 (Fcall_interactively): Count the number of arguments produced,
12589 not the number of arguments given. This is simpler and lets GCC
12590 4.6.0 generate slightly better code.
12592 * ftfont.c: Distingish more carefully between FcChar8 and char.
12593 The previous code passed unsigned char * to a functions like
12594 strlen and xstrcasecmp that expect char *, which does not
12595 conform to the C standard.
12596 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12597 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12598 char * when the C standard requires it.
12600 * keyboard.c (read_char): Remove unused var.
12602 * eval.c: Port to Windows vsnprintf (Bug#8435).
12603 Include <limits.h>.
12604 (SIZE_MAX): Define if the headers do not.
12605 (verror): Do not give up if vsnprintf returns a negative count.
12606 Instead, grow the buffer. This ports to Windows vsnprintf, which
12607 does not conform to C99. Problem reported by Eli Zaretskii.
12608 Also, simplify the allocation scheme, by avoiding the need for
12609 calling realloc, and removing the ALLOCATED variable.
12611 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12613 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12614 But keep the doprint source code for now, as we might revamp it
12615 and use it again (Bug#8435).
12616 * lisp.h (doprnt): Remove.
12617 * Makefile.in (base_obj): Remove doprnt.o.
12618 * deps.mk (doprnt.o): Remove.
12620 error: Print 32- and 64-bit integers portably (Bug#8435).
12621 Without this change, on typical 64-bit hosts error ("...%d...", N)
12622 was used to print both 32- and 64-bit integers N, which relied on
12623 undefined behavior.
12624 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
12625 * lisp.h (error, verror): Mark as printf-like functions.
12626 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12627 Report overflow in size calculations when allocating printf buffer.
12628 Do not truncate output string at its first null byte.
12629 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12630 Truncate the output at a character boundary, since vsnprintf does not
12632 * charset.c (check_iso_charset_parameter): Convert internal
12633 character to string before calling 'error', since %c now has the
12635 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12636 overflow when computing char to be passed to 'error'. Do not
12637 pass Lisp_Object to 'error'; pass the integer instead.
12638 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12639 formatted with plain %d.
12641 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12643 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12645 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12647 * xterm.c (x_catch_errors): Remove duplicate declaration.
12649 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12651 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12653 2011-04-10 Jim Meyering <meyering@redhat.com>
12655 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12656 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12657 return ssize_t not "int", and use size_t as the buffer length.
12658 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12659 * gnutls.h: Update declarations.
12660 * process.c (read_process_output): Use ssize_t, to match.
12661 (send_process): Likewise.
12663 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12665 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12667 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
12669 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12670 Use unsigned char, to match FcChar8 type definition.
12672 * xterm.c (handle_one_xevent):
12673 * xmenu.c (create_and_show_popup_menu):
12674 * xselect.c (x_decline_selection_request)
12675 (x_reply_selection_request): Avoid type-punned deref of X events.
12677 2011-04-09 Eli Zaretskii <eliz@gnu.org>
12679 Fix some uses of `int' instead of EMACS_INT.
12680 * search.c (string_match_1, fast_string_match)
12681 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12682 (scan_buffer, find_next_newline_no_quit)
12683 (find_before_next_newline, search_command, Freplace_match)
12684 (Fmatch_data): Make some `int' variables be EMACS_INT.
12686 * xdisp.c (display_count_lines): 3rd argument and return value now
12687 EMACS_INT. All callers changed.
12688 (pint2hrstr): Last argument is now EMACS_INT.
12690 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12691 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12692 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12693 (decode_coding_utf_16, decode_coding_emacs_mule)
12694 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12695 (decode_coding_ccl, decode_coding_charset)
12696 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12697 (decode_coding_iso_2022, decode_coding_emacs_mule)
12698 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12699 <char_offset, last_offset>: Declare EMACS_INT.
12700 (encode_coding_utf_8, encode_coding_utf_16)
12701 (encode_coding_emacs_mule, encode_invocation_designation)
12702 (encode_designation_at_bol, encode_coding_iso_2022)
12703 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12704 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12706 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12707 (encode_invocation_designation): Last argument P_NCHARS is now
12709 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12710 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12712 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12715 * ccl.c (Fccl_execute_on_string): Declare some variables
12718 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
12720 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12722 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12724 * process.c (Fformat_network_address): Doc fix.
12726 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12728 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
12730 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
12732 * keyboard.c (read_char): Call Lisp function help-form-show,
12733 instead of using internal_with_output_to_temp_buffer.
12734 (Qhelp_form_show): New var.
12735 (syms_of_keyboard): Use DEFSYM macro.
12737 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12739 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12741 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
12743 * process.c (Flist_processes): Remove to Lisp.
12744 (list_processes_1): Delete.
12746 2011-04-06 Eli Zaretskii <eliz@gnu.org>
12748 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12750 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12752 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
12754 Fix more problems found by GCC 4.6.0's static checks.
12756 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12758 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12760 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
12762 * xdisp.c (vmessage): Mark as a printf-like function.
12764 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12766 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12768 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12769 printf-like functions.
12770 (tiff_load): Add casts to remove these marks before passing them
12771 to system-supplied API.
12773 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12775 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12776 This avoids several warnings with gcc -Wstrict-overflow.
12777 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12778 directly, rather than having caller test rule sign. This avoids
12779 some unnecessary tests.
12780 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12781 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12782 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
12784 * xfont.c (xfont_text_extents): Remove var that was set but not used.
12785 (xfont_open): Avoid unnecessary tests.
12787 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12789 * composite.h, composite.c (composition_gstring_put_cache):
12790 Use EMACS_INT, not int, for length.
12792 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12793 breaking out part of COMPOSITION_DECODE_RULE.
12794 (COMPOSITION_DECODE_RULE): Use it.
12795 * composite.c (get_composition_id): Remove unused local vars,
12796 by using the new macro.
12798 * textprop.c (set_text_properties_1): Change while to do-while,
12799 since the condition is always true at first.
12801 * intervals.c (graft_intervals_into_buffer): Mark var as used.
12802 (interval_deletion_adjustment): Return unsigned value.
12805 * process.c (list_processes_1, create_pty, read_process_output):
12806 (exec_sentinel): Remove vars that were set but not used.
12807 (create_pty): Remove unnecessary "volatile"s.
12808 (Fnetwork_interface_info): Avoid possibility of int overflow.
12809 (read_process_output): Do adaptive read buffering even if carryover.
12810 (read_process_output): Simplify nbytes computation if buffered.
12812 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12814 * syntax.c (scan_words): Remove var that was set but not used.
12815 (update_syntax_table): Use unsigned instead of int.
12817 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
12818 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
12819 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
12821 * print.c (print_error_message): Avoid int overflow.
12823 * font.c (font_list_entities): Redo for clarity,
12824 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12826 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
12827 (font_score): Avoid potential overflow in diff calculation.
12829 * fns.c (substring_both): Remove var that is set but not used.
12830 (sxhash): Redo loop for clarity and to avoid wraparound warning.
12832 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12834 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12835 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12836 can always succeed if overflow has undefined behavior.
12838 * search.c (boyer_moore, wordify): Remove vars set but not used.
12839 (wordify): Omit three unnecessary tests.
12841 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12842 All callers changed. This avoids the need for an unused var.
12844 * casefiddle.c (casify_region): Remove var that is set but not used.
12846 * dired.c (file_name_completion): Remove var that is set but not used.
12848 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12850 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
12851 (Finsert_file_contents): Remove unnecessary code checking fd.
12853 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12854 Check for integer overflow on size calculations.
12856 * buffer.c (Fprevious_overlay_change): Remove var that is set
12859 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12860 Remove vars that are set but not used.
12861 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
12862 (timer_check_2): Mark vars as initialized.
12864 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12866 * image.c (lookup_image): Remove var that is set but not used.
12867 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
12869 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12870 that are set but not used.
12872 * xfns.c (make_invisible_cursor): Don't return garbage
12873 if XCreateBitmapFromData fails (Bug#8410).
12875 * xselect.c (x_get_local_selection, x_handle_property_notify):
12876 Remove vars that are set but not used.
12878 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
12879 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
12881 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12882 Remove var that is set but not used.
12883 (scroll_bar_windows_size): Now size_t, not int.
12884 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12885 Check for overflow.
12887 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12888 (map_tty_color) [!defined MSDOS]: Likewise.
12890 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12892 * coding.c: Remove vars that are set but not used.
12893 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12894 All callers changed.
12895 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12896 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12897 (decode_coding_charset): Remove vars that are set but not used.
12899 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12900 that is set but not used.
12902 * print.c (print_object): Remove var that is set but not used.
12904 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
12905 The gnulib version avoids calling malloc in the usual case,
12906 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12907 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12908 * filelock.c (current_lock_owner): Likewise.
12909 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12910 * sysdep.c: Include allocator.h, careadlinkat.h.
12911 (emacs_no_realloc_allocator): New static constant.
12912 (emacs_readlink): New function.
12913 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12914 ../lib/careadlinkat.h.
12916 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12918 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12919 first non-nil return value).
12921 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12923 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12924 if not defined (Bug#8403).
12926 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12928 * xdisp.c (display_count_lines): Remove parameter `start',
12929 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12930 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12931 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12932 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12933 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12934 and thereabouts. All callers changed.
12935 (get_per_char_metric): Remove parameter `f', unused since
12936 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12938 2011-04-02 Jim Meyering <meyering@redhat.com>
12940 do not dereference NULL upon failed strdup
12941 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12942 (ns_get_family): Likewise.
12944 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12946 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12948 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12950 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12953 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12955 Add lexical binding.
12957 * window.c (Ftemp_output_buffer_show): New fun.
12958 (Fsave_window_excursion):
12959 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12961 * lread.c (lisp_file_lexically_bound_p): New function.
12962 (Fload): Bind Qlexical_binding.
12963 (readevalloop): Remove `evalfun' arg.
12964 Bind Qinternal_interpreter_environment.
12965 (Feval_buffer): Bind Qlexical_binding.
12966 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12968 (syms_of_lread): Declare `lexical-binding'.
12970 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12972 * keyboard.c (eval_dyn): New fun.
12973 (menu_item_eval_property): Use it.
12975 * image.c (parse_image_spec): Use Ffunctionp.
12977 * fns.c (concat, mapcar1): Accept byte-code-functions.
12979 * eval.c (Fsetq): Handle lexical vars.
12980 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12981 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12982 (FletX, Flet): Obey lexical binding.
12983 (Fcommandp): Handle closures.
12984 (Feval): New `lexical' arg.
12985 (eval_sub): New function extracted from Feval. Use it almost
12986 everywhere where Feval was used. Look up vars in lexical env.
12988 (Ffunctionp): Move from subr.el.
12989 (Ffuncall): Handle closures.
12990 (apply_lambda): Remove `eval_flags'.
12991 (funcall_lambda): Handle closures and new byte-code-functions.
12992 (Fspecial_variable_p): New function.
12993 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12994 but without exporting it to Lisp.
12996 * doc.c (Fdocumentation, store_function_docstring):
12997 * data.c (Finteractive_form): Handle closures.
12999 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13002 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13004 (exec_byte_code): New function extracted from Fbyte_code to handle new
13005 calling convention for byte-code-functions. Add new byte-codes.
13007 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
13009 * alloc.c (Fmake_symbol): Init new `declared_special' field.
13011 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13013 * xdisp.c (redisplay_internal): Fix prototype.
13015 2011-03-31 Eli Zaretskii <eliz@gnu.org>
13017 * xdisp.c (SCROLL_LIMIT): New macro.
13018 (try_scrolling): Use it when setting scroll_limit.
13019 Limit scrolling to 100 screen lines.
13020 (redisplay_window): Even when falling back on "recentering",
13021 position point in the window according to scroll-conservatively,
13022 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13024 (try_scrolling): When point is above the window, allow searching
13025 as far as scroll_max, or one screenful, to compute vertical
13026 distance from PT to the scroll margin position. This prevents
13027 try_scrolling from unnecessarily failing when
13028 scroll-conservatively is set to a value slightly larger than the
13029 window height. Clean up the case of PT below the margin at bottom
13030 of window: scroll_max can no longer be INT_MAX. When aggressive
13031 scrolling is in use, don't let point enter the opposite scroll
13032 margin as result of the scroll.
13033 (syms_of_xdisp) <scroll-conservatively>: Document the
13034 threshold of 100 lines for never-recentering scrolling.
13036 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13038 * dispextern.h (move_it_by_lines):
13039 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13040 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13041 (message_log_check_duplicate): Remove parameters `prev_bol' and
13042 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13043 (redisplay_internal): Remove parameter `preserve_echo_area',
13044 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13046 * indent.c (Fvertical_motion):
13047 * window.c (window_scroll_pixel_based, Frecenter):
13048 Don't pass `need_y_p' to `move_it_by_lines'.
13050 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13052 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13053 steal a few bits to be more compact.
13054 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13055 Remove unneeded casts.
13057 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13059 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13061 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13062 binding" message (bug#7967).
13064 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13066 Fix more problems found by GCC 4.6.0's static checks.
13068 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13069 Remove unused local var.
13071 * editfns.c (Fmessage_box): Remove unused local var.
13073 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13074 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13075 Omit unused local vars.
13076 * window.c (shrink_windows): Omit unused local var.
13077 * menu.c (digest_single_submenu): Omit unused local var.
13078 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13079 Omit unused local var.
13081 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13082 Don't assume string length fits in int.
13083 (keyremap_step, read_key_sequence): Use size_t for sizes.
13084 (read_key_sequence): Don't check last_real_key_start redundantly.
13086 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13087 instead of alloca (Bug#8344).
13089 * eval.c (Fbacktrace): Don't assume nargs fits in int.
13090 (Fbacktrace_frame): Don't assume nframes fits in int.
13092 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13094 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13097 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13099 * cm.c (calccost): Turn while-do into do-while, for clarity.
13101 * keyboard.c (syms_of_keyboard): Use the same style as later
13102 in this function when indexing through an array. This also
13103 works around GCC bug 48267.
13105 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13107 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13109 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13110 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13112 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13113 This avoids undefined behavior on integer overflow, and is a bit
13114 more convenient anyway since it is compared to a size_t variable.
13116 Variadic C functions now count arguments with size_t, not int.
13117 This avoids an unnecessary limitation on 64-bit machines, which
13118 caused (substring ...) to crash on large vectors (Bug#8344).
13119 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13120 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
13121 All variadic functions and their callers changed accordingly.
13122 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13123 * data.c (arith_driver, float_arith_driver): Likewise.
13124 * editfns.c (general_insert_function): Likewise.
13125 * eval.c (struct backtrace.nargs, interactive_p)
13126 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13127 (funcall_lambda, mark_backtrace): Likewise.
13128 * fns.c (concat): Likewise.
13129 * frame.c (x_set_frame_parameters): Likewise.
13130 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13131 0 if not found, not -1. All callers changed.
13133 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13134 (stack_copy_size): Now size_t, not int.
13135 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13137 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13139 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13140 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13141 All callers changed.
13143 * lisp.h (multibyte_char_to_unibyte):
13144 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13145 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13146 * character.h (CHAR_TO_BYTE8):
13147 * cmds.c (internal_self_insert):
13148 * editfns.c (general_insert_function):
13149 * keymap.c (push_key_description):
13150 * search.c (Freplace_match):
13151 * xdisp.c (message_dolog, set_message_1): All callers changed.
13153 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13155 * keyboard.c (safe_run_hook_funcall): New function.
13156 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13157 don't set the hook to nil, but remove the offending function instead.
13158 (Qcommand_hook_internal): Remove, unused.
13159 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13160 Vcommand_hook_internal.
13162 * eval.c (enum run_hooks_condition): Remove.
13163 (funcall_nil, funcall_not): New functions.
13164 (run_hook_with_args): Call each function through a `funcall' argument.
13165 Remove `cond' argument, now redundant.
13166 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13167 (Frun_hook_with_args_until_failure): Adjust accordingly.
13168 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13170 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13172 * dispextern.h (string_buffer_position): Remove declaration.
13174 * print.c (strout): Remove parameter `multibyte', unused since
13175 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13177 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13178 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13179 All callers changed.
13181 * w32.c (_wsa_errlist): Use braces for struct initializers.
13183 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13184 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13185 All callers changed.
13186 (string_buffer_position): Likewise. Also, make static (it's never
13187 used outside xdisp.c).
13188 (cursor_row_p): Remove parameter `w', unused since
13189 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13190 (decode_mode_spec): Remove parameter `precision', introduced during
13191 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13192 All callers changed.
13194 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13196 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13198 2011-03-27 Anders Lindgren <andlind@gmail.com>
13200 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13201 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13202 (ns_update_auto_hide_menu_bar): New functions.
13203 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13204 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13205 ns_constrain_all_frames.
13206 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13207 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13209 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13211 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13213 2011-03-27 Glenn Morris <rgm@gnu.org>
13215 * syssignal.h: Replace RETSIGTYPE with void.
13216 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13217 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13218 Replace SIGTYPE with void everywhere.
13219 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13220 * s/template.h (SIGTYPE): Remove commented out definition.
13222 2011-03-26 Eli Zaretskii <eliz@gnu.org>
13224 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13225 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13227 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
13229 * w32.c (read_unc_volume): Use parameter `henum', instead of
13230 global variable `wget_enum_handle'.
13232 * keymap.c (describe_vector): Remove parameters `indices' and
13233 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13234 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13236 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13238 * keyboard.c (timer_check): Remove parameter `do_it_now',
13239 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13240 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13241 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13243 * keyboard.c (read_char):
13244 * w32menu.c (w32_menu_display_help):
13245 * xmenu.c (show_help_event, menu_help_callback):
13246 Adjust calls to `show_help_echo'.
13248 * gtkutil.c (xg_maybe_add_timer):
13249 * keyboard.c (readable_events):
13250 * process.c (wait_reading_process_output):
13251 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13253 * insdel.c (adjust_markers_gap_motion):
13254 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13255 (gap_left, gap_right): Don't call it.
13257 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
13259 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13260 incurred during fontification.
13262 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13264 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13265 (DEFVAR_PER_BUFFER): Don't pass it.
13267 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13268 (scrolling_window): Don't pass it.
13270 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13272 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13274 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13276 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13277 of variables specific to SELinux and computation of `encoded_absname'.
13279 * image.c (XPutPixel): Remove unused variable `height'.
13281 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13283 * unexw32.c (get_section_info): Remove unused variable `section'.
13285 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13286 (system_process_attributes): Remove unused variable `sess'.
13287 (sys_read): Remove unused variable `err'.
13289 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13290 (w32_wnd_proc): Remove unused variable `isdead'.
13291 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13292 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13293 (x_create_tip_frame): Remove unused variable `tem'.
13295 * w32inevt.c (w32_console_read_socket):
13296 Remove unused variable `no_events'.
13298 * w32term.c (x_draw_composite_glyph_string_foreground):
13299 Remove unused variable `width'.
13301 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
13303 * w32term.c (x_set_glyph_string_clipping):
13304 Don't pass uninitialized region to CombineRgn.
13306 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
13308 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13309 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13310 (Fx_close_connection): Remove unused variable `i'.
13312 * w32font.c (w32font_draw): Return number of glyphs.
13313 (w32font_open_internal): Remove unused variable `i'.
13314 (w32font_driver): Add missing initializer.
13316 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13317 (fill_in_menu): Remove unused variable `items_added'.
13319 * w32term.c (last_mouse_press_frame): Remove static global variable.
13320 (w32_clip_to_row): Remove unused variable `f'.
13321 (x_delete_terminal): Remove unused variable `i'.
13323 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13324 (NOTHING): Remove unused static global variable.
13325 (uniscribe_check_otf): Remove unused variable `table'.
13326 (uniscribe_font_driver): Add missing initializers.
13328 2011-03-23 Julien Danjou <julien@danjou.info>
13330 * term.c (Fsuspend_tty, Fresume_tty):
13331 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13332 * window.c (temp_output_buffer_show):
13333 * insdel.c (signal_before_change):
13334 * frame.c (Fhandle_switch_frame):
13335 * fileio.c (Fdo_auto_save):
13336 * emacs.c (Fkill_emacs):
13337 * editfns.c (save_excursion_restore):
13338 * cmds.c (internal_self_insert):
13339 * callint.c (Fcall_interactively):
13340 * buffer.c (Fkill_all_local_variables):
13341 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13343 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
13344 unconditionally since it does the check itself.
13346 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
13348 Fix more problems found by GCC 4.5.2's static checks.
13350 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13351 the first time through the loop, since we know p0 < p1 then.
13352 This also avoids a gcc -Wstrict-overflow warning.
13354 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13355 leading to a memory leak, possible in functions like
13356 load_charset_map_from_file that can allocate an unbounded number
13357 of objects (Bug#8318).
13359 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13360 that could (at least in theory) be that large.
13362 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13363 This is less likely to overflow, and avoids undefined behavior if
13364 overflow does occur. All callers changed. Use strtoul to scan
13365 for the unsigned long integer.
13366 (pint2hrstr): Simplify and tune code slightly.
13367 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
13369 * scroll.c (do_scrolling): Work around GCC bug 48228.
13370 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13372 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13373 This also avoids a warning with gcc -Wstrict-overflow.
13374 (validate_x_resource_name): Simplify count usage.
13375 This also avoids a warning with gcc -Wstrict-overflow.
13377 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13380 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
13382 * process.c (Fmake_network_process): Use socklen_t, not int,
13383 where POSIX says socklen_t is required in portable programs.
13384 This fixes a porting bug on hosts like 64-bit HP-UX, where
13385 socklen_t is wider than int (Bug#8277).
13386 (Fmake_network_process, server_accept_connection):
13387 (wait_reading_process_output, read_process_output):
13390 * process.c: Rename or move locals to avoid shadowing.
13391 (list_processes_1, Fmake_network_process):
13392 (read_process_output_error_handler, exec_sentinel_error_handler):
13393 Rename or move locals.
13394 (Fmake_network_process): Define label "retry_connect" only if needed.
13395 (Fnetwork_interface_info): Fix pointer signedness.
13396 (process_send_signal): Add cast to avoid pointer signedness problem.
13397 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
13398 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
13400 Make tparam.h and terminfo.c consistent.
13401 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13402 Include tparam.h instead, since it declares them.
13403 * cm.h (PC): Remove extern decl; tparam.h now does this.
13404 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13405 * terminfo.c: Include tparam.h, to check interfaces.
13406 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13407 (tparam): Adjust signature to match interface in tparam.h;
13408 this removes some undefined behavior. Check that outstring and len
13409 are zero, which they always are with Emacs.
13410 * tparam.h (PC, BC, UP): New extern decls.
13412 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
13413 (xftfont_open): Rename locals to avoid shadowing.
13415 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
13416 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13417 (OTF_TAG_SYM): Omit macro if not needed.
13418 (ftfont_list): Remove unused local.
13419 (get_adstyle_property, ftfont_pattern_entity):
13420 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13421 Rename locals to avoid shadowing.
13423 * xfont.c (xfont_list_family): Mark var as initialized.
13425 * xml.c (make_dom): Now static.
13427 * composite.c (composition_compute_stop_pos): Rename local to
13429 (composition_reseat_it): Remove unused locals.
13430 (find_automatic_composition, composition_adjust_point): Likewise.
13431 (composition_update_it): Mark var as initialized.
13432 (find_automatic_composition): Mark vars as initialized,
13433 with a FIXME (Bug#8290).
13435 character.h: Rename locals to avoid shadowing.
13436 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13437 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13438 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13439 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13440 to avoid shadowing.
13442 * textprop.c (property_change_between_p): Remove; unused.
13444 * intervals.c (interval_start_pos): Now static.
13446 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13448 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13449 Rename locals to avoid shadowing.
13451 * sound.c (wav_play, au_play, Fplay_sound_internal):
13452 Fix pointer signedness.
13453 (alsa_choose_format): Remove unused local var.
13454 (wav_play): Initialize a variable to 0, to prevent undefined
13455 behavior (Bug#8278).
13457 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13459 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13461 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13462 clobbering (Bug#8298).
13463 * sysdep.c (sys_subshell): Likewise.
13464 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
13466 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13467 This should get cleaned up, so that child_setup has the
13468 same signature on all platforms.
13470 * callproc.c (call_process_cleanup): Now static.
13471 (relocate_fd): Rename locals to avoid shadowing.
13473 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
13475 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13476 not to be necessary, and produces flickering.
13478 2011-03-20 Glenn Morris <rgm@gnu.org>
13480 * config.in: Remove file.
13482 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
13484 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13485 are now in src/globals.h.
13486 (syms_of_minibuf): Remove spurious & from previous change.
13488 2011-03-20 Leo Liu <sdl.web@gmail.com>
13490 * minibuf.c (completing-read-function): New variable.
13491 (completing-read-default): Rename from completing-read.
13492 (completing-read): Call completing-read-function.
13494 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13496 * xfaces.c (Fx_load_color_file):
13497 Read color file from absolute filename (bug#8250).
13499 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13501 * makefile.w32-in: Update dependencies.
13503 2011-03-17 Eli Zaretskii <eliz@gnu.org>
13505 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13507 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13509 Fix more problems found by GCC 4.5.2's static checks.
13511 * process.c (make_serial_process_unwind, send_process_trap):
13512 (sigchld_handler): Now static.
13514 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13515 That way, the code declares only the vars that it needs.
13516 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13517 * s/cygwin.h (PTY_ITERATION): Likewise.
13518 * s/darwin.h (PTY_ITERATION): Likewise.
13519 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13521 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13522 * process.c (allocate_pty): Don't declare stb unless it's needed.
13524 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
13525 (CONSTANTLIM): Remove; unused.
13526 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13527 Define only if needed.
13529 * unexelf.c (unexec): Name an expression,
13530 to avoid gcc -Wbad-function-cast warning.
13531 Use a different way to cause a compilation error if anyone uses
13532 n rather than nn, a way that does not involve shadowing.
13533 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
13535 * deps.mk (unexalpha.o): Remove; unused.
13537 New file unexec.h, the (simple) interface for unexec (Bug#8267).
13538 * unexec.h: New file.
13539 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13540 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13541 Depend on unexec.h.
13542 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13543 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13544 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
13545 Change as necessary to match prototype in unexec.h.
13547 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13549 (back_comment, skip_chars): Mark vars as initialized.
13551 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13552 Rename locals to avoid shadowing.
13554 * lread.c (read1): Rewrite so as not to use empty "else".
13555 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
13557 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13559 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13560 warning when compiling print.c.
13562 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13563 instead of using an uninitialized var.
13564 (font_sort_entities): Mark var as initialized.
13566 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13568 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13569 pointers to constants.
13570 (font_parse_fcname): Remove unused vars.
13571 (font_delete_unmatched): Now static.
13572 (font_get_spec): Remove; unused.
13573 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13574 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13575 Rename or move locals to avoid shadowing.
13577 * fns.c (require_nesting_list, require_unwind): Now static.
13578 (Ffillarray): Rename locals to avoid shadowing.
13580 * floatfns.c (domain_error2): Define only if needed.
13581 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
13583 * alloc.c (mark_backtrace): Move decl from here ...
13584 * lisp.h: ... to here, so that it can be checked.
13586 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
13587 (Fdefvar): Rewrite so as not to use empty "else".
13588 (lisp_indirect_variable): Name an expression,
13589 to avoid gcc -Wbad-function-cast warning.
13590 (Fdefvar): Rename locals to avoid shadowing.
13592 * callint.c (quotify_arg, quotify_args): Now static.
13593 (Fcall_interactively): Rename locals to avoid shadowing.
13594 Use const pointer when appropriate.
13596 * lisp.h (get_system_name, get_operating_system_release):
13597 Move decls here, to check interfaces.
13598 * process.c (get_operating_system_release): Move decl to lisp.h.
13599 * xrdb.c (get_system_name): Likewise.
13600 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13601 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13602 some of which prompt warnings from gcc -Wbad-function-cast.
13603 (Fformat_time_string, Fencode_time, Finsert_char):
13604 (Ftranslate_region_internal, Fformat):
13605 Rename or remove local vars to avoid shadowing.
13606 (Ftranslate_region_internal): Mark var as initialized.
13608 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13611 * lisp.h (eassert): Check that the argument compiles, even if
13612 ENABLE_CHECKING is not defined.
13614 * data.c (Findirect_variable): Name an expression, to avoid
13615 gcc -Wbad-function-cast warning.
13616 (default_value, arithcompare, arith_driver, arith_error): Now static.
13617 (store_symval_forwarding): Rename local to avoid shadowing.
13618 (Fmake_variable_buffer_local, Fmake_local_variable):
13619 Mark variables as initialized.
13620 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
13622 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
13623 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13624 Rename locals to avoid shadowing.
13625 (mark_stack): Move local variables into the #ifdef region where
13627 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13628 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13630 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13631 (GC_STRING_CHARS): Remove; not used.
13632 (Fmemory_limit): Cast sbrk's returned value to char *.
13634 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13635 avoids undefined behavior in theory.
13637 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13639 Use functions, not macros, for up- and down-casing (Bug#8254).
13640 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13641 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13642 to use the following functions instead of these macros.
13643 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13644 EMACS_INT, since callers assume the returned value fits in int.
13645 (upcase1): Likewise, for UPCASE_TABLE.
13646 (uppercasep, lowercasep, upcase): New static inline functions.
13647 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
13648 the race-condition problem in the old DOWNCASE.
13650 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13651 Rename locals to avoid shadowing.
13652 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
13653 (regex_compile, re_search_2, re_match_2_internal):
13654 Remove unused local vars.
13655 (FREE_VAR): Rewrite so as not to use empty "else",
13656 which gcc can warn about.
13657 (regex_compile, re_match_2_internal): Mark locals as initialized.
13658 (RETALLOC_IF): Define only if needed.
13659 (WORDCHAR_P): Likewise. This one is never needed, but is used
13660 only in a comment talking about a compiler bug, so put inside
13661 the #if 0 of that comment.
13662 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13663 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13666 * search.c (boyer_moore): Rename locals to avoid shadowing.
13667 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13668 (PREV_CHAR_BOUNDARY): Likewise.
13670 * search.c (simple_search): Remove unused var.
13672 * dired.c (compile_pattern): Move decl from here ...
13673 * lisp.h: ... to here, so that it can be checked.
13674 (struct re_registers): New forward decl.
13676 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13678 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13680 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13681 Rename locals to avoid shadowing.
13682 (Fvertical_motion): Mark locals as initialized.
13684 * casefiddle.c (casify_object, casify_region): Now static.
13685 (casify_region): Mark local as initialized.
13687 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13689 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13690 New macros, so that the caller can use some names other than
13691 gcpro1, gcpro2, etc.
13692 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13694 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13695 argument, for consistency with GCPRO2_VAR, etc: it is now the
13696 prefix of the variable, not the variable itself. All uses
13698 * dired.c (directory_files_internal, file_name_completion):
13699 Rename locals to avoid shadowing.
13701 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13702 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13703 dired.c's scmp function, had undefined behavior.
13704 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13705 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13706 * buffer.h: ... to here, because these macros use current_buffer,
13707 and the new implementation with inline functions needs to have
13708 current_buffer in scope now, rather than later when the macros
13710 (downcase, upcase1): New static inline functions.
13711 (DOWNCASE, UPCASE1): Reimplement using these functions.
13712 This avoids undefined behavior in expressions like
13713 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13714 from race conditions in accessing the global variables
13715 case_temp1 and case_temp2.
13716 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13717 * lisp.h (case_temp1, case_temp2): Remove their decls.
13718 * character.h (ASCII_CHAR_P): Move from here ...
13719 * lisp.h: ... to here, so that the inline functions mentioned
13720 above can use them.
13722 * dired.c (directory_files_internal_unwind): Now static.
13724 * fileio.c (file_name_as_directory, directory_file_name):
13725 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13727 (file_name_as_directory): Use const pointers when appropriate.
13728 (Fexpand_file_name): Likewise. In particular, newdir might
13729 point at constant storage, so make it a const pointer.
13730 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
13731 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13733 (Fset_file_times, Finsert_file_contents, auto_save_error):
13734 Rename locals to avoid shadowing.
13736 * minibuf.c (choose_minibuf_frame_1): Now static.
13737 (Ftry_completion, Fall_completions): Rename or remove locals
13738 to avoid shadowing.
13740 * marker.c (bytepos_to_charpos): Remove; unused.
13742 * lisp.h (verify_bytepos, count_markers): New decls,
13743 so that gcc does not warn that these functions aren't declared.
13745 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13746 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
13747 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
13748 (copy_text): Remove unused local var.
13750 * filelock.c (within_one_second): Now static.
13751 (lock_file_1): Rename local to avoid shadowing.
13753 * buffer.c (fix_overlays_before): Mark locals as initialized.
13754 (fix_start_end_in_overlays): Likewise. This function should be
13755 simplified by using pointers-to-pointers, but that's a different
13757 (switch_to_buffer_1): Now static.
13758 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13759 (report_overlay_modification): Rename locals to avoid shadowing.
13761 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
13762 Fix pointer signedness issue.
13763 (sys_subshell): Mark local as volatile if checking for lint,
13764 to suppress a gcc -Wclobbered warning that does not seem to be right.
13765 (MAXPATHLEN): Define only if needed.
13767 * process.c (serial_open, serial_configure): Move decls from here ...
13768 * systty.h: ... to here, so that they can be checked.
13770 * fns.c (get_random, seed_random): Move extern decls from here ...
13771 * lisp.h: ... to here, so that they can be checked.
13773 * sysdep.c (reset_io): Now static.
13774 (wait_for_termination_signal): Remove; unused.
13776 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13777 (copy_keymap_item, append_key, push_text_char_description):
13779 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
13780 (DENSE_TABLE_SIZE): Remove; unused.
13781 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13782 (describe_map_tree):
13783 Rename locals to avoid shadowing.
13785 * keyboard.c: Declare functions static if they are not used elsewhere.
13786 (echo_char, echo_dash, cmd_error, top_level_2):
13787 (poll_for_input, handle_async_input): Now static.
13788 (read_char, kbd_buffer_get_event, make_lispy_position):
13789 (make_lispy_event, make_lispy_movement, apply_modifiers):
13790 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13791 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13792 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
13793 (read_key_sequence, read_char): Mark locals as initialized.
13794 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
13796 * keyboard.h (make_ctrl_char): New decl.
13797 (mark_kboards): Move decl here ...
13798 * alloc.c (mark_kboards): ... from here.
13800 * lisp.h (force_auto_save_soon): New decl.
13802 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
13803 (DEFINE_DUMMY_FUNCTION): New macro.
13804 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13806 (main): Add casts to avoid warnings
13807 if GCC considers string literals to be constants.
13809 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13811 * dbusbind.c: Pointer signedness fixes.
13812 (xd_signature, xd_append_arg, xd_initialize):
13813 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13814 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13815 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13816 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13818 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13819 if GCC considers string literals to be constants.
13820 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
13822 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13824 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13825 (print_preprocess, print_object): New macro to fix last change.
13827 * print.c (print_preprocess): Don't forget font objects.
13829 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
13831 * emacs.c (USAGE3): Doc fixes.
13833 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13835 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13838 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
13840 * lisp.h (VWindow_system, Qfile_name_history):
13841 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13842 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13843 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13845 * w32select.c: Don't #include "keyboard.h".
13846 (run_protected): Add extern declaration for waiting_for_input.
13848 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13849 * w32console.c (detect_input_pending, read_input_pending)
13850 (encode_terminal_code):
13851 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13852 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13853 (w32_system_caret_y, Qfile_name_history):
13854 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13855 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13856 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13857 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13858 * w32proc.c (Qlocal, report_file_error):
13859 * w32term.c (Vwindow_system, updating_frame):
13860 * w32uniscribe.c (initialized, uniscribe_font_driver):
13861 Remove unneeded extern declarations.
13863 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
13865 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
13867 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
13869 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13870 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13871 These macros can no longer be used for assignment.
13873 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13874 Assign struct members directly, instead of using BUF_BEGV etc.
13875 (record_buffer_markers, fetch_buffer_markers): New functions for
13876 recording and fetching special buffer markers.
13877 (set_buffer_internal_1, set_buffer_temp): Use them.
13879 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13881 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13883 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13884 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13886 * xdisp.c (hscroll_window_tree):
13887 (reconsider_clip_changes): Use PT instead of BUF_PT.
13889 2011-03-13 Eli Zaretskii <eliz@gnu.org>
13891 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13892 $(EMACS_ROOT)/lib/intprops.h.
13894 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13896 Fix more problems found by GCC 4.5.2's static checks.
13898 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13899 to unsigned char * to avoid compiler diagnostic.
13900 (xg_free_frame_widgets): Make it clear that a local variable is
13901 needed only if USE_GTK_TOOLTIP.
13902 (gdk_window_get_screen): Make it clear that this macro is needed
13903 only if USE_GTK_TOOLTIP.
13904 (int_gtk_range_get_value): New function, which avoids a diagnostic
13905 from gcc -Wbad-function-cast.
13906 (xg_set_toolkit_scroll_bar_thumb): Use it.
13907 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13908 diagnostic from gcc -Wbad-function-cast.
13909 (get_utf8_string, xg_get_file_with_chooser):
13910 Rename locals to avoid shadowing.
13911 (create_dialog): Move locals to avoid shadowing.
13913 * xgselect.c (xg_select): Remove unused var.
13915 * image.c (four_corners_best): Mark locals as initialized.
13916 (gif_load): Initialize transparent_p to zero (Bug#8238).
13917 Mark another local as initialized.
13918 (my_png_error, my_error_exit): Mark with NO_RETURN.
13920 * image.c (clear_image_cache): Now static.
13921 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
13922 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
13923 (x_edge_detection): Remove unnecessary cast that
13924 gcc -Wbad-function-cast diagnoses.
13925 (gif_load): Fix pointer signedness.
13926 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13927 (jpeg_load, gif_load): Rename locals to avoid shadowing.
13929 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
13931 Improve quality of tests for time stamp overflow.
13932 For example, without this patch (encode-time 0 0 0 1 1
13933 1152921504606846976) returns the obviously-bogus value (-948597
13934 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13935 reports time overflow. See
13936 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
13937 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13938 * editfns.c: Include limits.h and intprops.h.
13939 (TIME_T_MIN, TIME_T_MAX): New macros.
13940 (time_overflow): Move earlier, to before first use.
13941 (hi_time, lo_time): New functions, for an accurate test for
13942 out-of-range times.
13943 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13944 (Fget_internal_run_time): Don't assume time_t fits in int.
13945 (make_time): Use list2 instead of Fcons twice.
13946 (Fdecode_time): More accurate test for out-of-range times.
13947 (check_tm_member): New function.
13948 (Fencode_time): Use it, to test for out-of-range times.
13949 (lisp_time_argument): Don't rely on undefined left-shift and
13950 right-shift behavior when checking for time stamp overflow.
13952 * editfns.c (time_overflow): New function, refactoring common code.
13953 (Fformat_time_string, Fdecode_time, Fencode_time):
13954 (Fcurrent_time_string): Use it.
13956 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13957 * dired.c (make_time): Move to ...
13958 * editfns.c (make_time): ... here.
13959 * systime.h: Note the move.
13961 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13963 * fringe.c (update_window_fringes): Remove unused variables.
13965 * unexmacosx.c (copy_data_segment): Also copy __got section.
13968 2011-03-12 Eli Zaretskii <eliz@gnu.org>
13970 * termcap.c [MSDOS]: Include "msdos.h".
13971 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13972 Constify `char *' arguments and their references according to
13973 prototypes in tparam.h.
13975 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
13977 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13978 Adapt all references accordingly.
13980 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13982 2011-03-11 Tom Tromey <tromey@redhat.com>
13984 * buffer.c (syms_of_buffer): Remove obsolete comment.
13986 2011-03-11 Eli Zaretskii <eliz@gnu.org>
13988 * termhooks.h (encode_terminal_code): Declare prototype.
13990 * msdos.c (encode_terminal_code): Don't declare prototype.
13992 * term.c (encode_terminal_code): Now external again, used by
13993 w32console.c and msdos.c.
13995 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13996 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
13998 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
14000 Fix some minor problems found by GCC 4.5.2's static checks.
14002 * fringe.c (update_window_fringes): Mark locals as initialized
14004 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
14006 * alloc.c (mark_fringe_data): Move decl from here ...
14007 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14008 to check its interface.
14009 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14011 * fontset.c (free_realized_fontset): Now static.
14012 (Fset_fontset_font): Rename local to avoid shadowing.
14013 (fontset_font): Mark local as initialized.
14014 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
14016 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14018 * xselect.c (x_disown_buffer_selections): Remove; not used.
14019 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
14020 (x_own_selection, Fx_disown_selection_internal): Rename locals
14021 to avoid shadowing.
14022 (x_handle_dnd_message): Remove local to avoid shadowing.
14024 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14025 so that the caller can use some name other than gcpro1.
14026 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
14027 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14028 (Fx_backspace_delete_keys_p):
14029 Use them to avoid shadowing, and rename vars to avoid shadowing.
14030 (x_decode_color, x_set_name, x_window): Now static.
14031 (Fx_create_frame): Add braces to silence GCC warning.
14032 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
14033 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14034 Remove unused locals.
14035 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14036 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14037 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14040 * xterm.h (x_mouse_leave): New decl.
14042 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14043 Remove unused functions.
14044 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14045 (x_calc_absolute_position): Now static.
14046 (XTread_socket): Don't define label "out" unless it's used.
14047 Don't declare local "event" unless it's used.
14048 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14049 unless they are used.
14050 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14051 (x_fatal_error_signal): Remove; not used.
14052 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14053 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14054 (x_error_catcher, x_connection_closed, x_error_handler):
14055 (x_error_quitter, xembed_send_message, x_iconify_frame):
14056 (my_log_handler): Rename locals to avoid shadowing.
14057 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
14058 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
14060 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14061 Rename or move locals to avoid shadowing.
14062 (tty_defined_color, merge_face_heights): Now static.
14063 (free_realized_faces_for_fontset): Remove; not used.
14064 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14065 does not deduce is never used uninitialized.
14066 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14067 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
14069 * terminal.c (store_terminal_param): Now static.
14071 * xmenu.c (menu_highlight_callback): Now static.
14072 (set_frame_menubar): Remove unused local.
14073 (xmenu_show): Rename parameter to avoid shadowing.
14074 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14075 since they might point to immutable storage.
14076 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14077 since it's unused otherwise.
14079 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
14080 Add a FIXME, since the code still doesn't look right. (Bug#8215)
14081 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14082 avoids a gcc -Wuninitialized diagnostic.
14083 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
14084 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14085 does not deduce are never used uninitialized.
14087 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14089 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
14090 * window.c (window_loop, size_window):
14091 (run_window_configuration_change_hook, enlarge_window): Likewise.
14093 * window.c (display_buffer): Now static.
14094 (size_window): Mark variables that gcc -Wuninitialized
14095 does not deduce are never used uninitialized.
14096 * window.h (check_all_windows): New decl, to forestall
14097 gcc -Wmissing-prototypes diagnostic.
14098 * dispextern.h (bidi_dump_cached_states): Likewise.
14100 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14102 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
14103 Include <limits.h>.
14104 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14105 and to avoid gcc -Wuninitialized warning.
14106 (load_charset_map): Mark variables that gcc -Wuninitialized
14107 does not deduce are never used uninitialized.
14108 (load_charset): Abort instead of using uninitialized var (Bug#8229).
14110 * coding.c (coding_set_source, coding_set_destination):
14111 Use "else { /* comment */ }" rather than "else /* comment */;"
14112 for clarity, and to avoid gcc -Wempty-body warning.
14113 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14114 a block, when the outer 'i' will do.
14115 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14116 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14117 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14118 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14119 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14120 Rename locals to avoid shadowing.
14121 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
14122 * coding.c (emacs_mule_char, encode_invocation_designation):
14123 Now static, since they're not used elsewhere.
14124 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
14125 (decode_coding_object, encode_coding_object, detect_coding_system):
14126 (decode_coding_emacs_mule): Mark variables that gcc
14127 -Wuninitialized does not deduce are never used uninitialized.
14128 (detect_coding_iso_2022): Initialize a local variable that might
14129 be used uninitialized. Leave a FIXME because it's not clear that
14130 this initialization is needed. (Bug#8211)
14131 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14132 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14133 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14134 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14135 Remove unused macros.
14137 * category.c (hash_get_category_set): Remove unused local var.
14138 (copy_category_table): Now static, since it's not used elsewhere.
14139 * character.c (string_count_byte8): Likewise.
14141 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14142 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14144 * chartab.c (copy_sub_char_table): Now static, since it's not used
14146 (sub_char_table_ref_and_range, char_table_ref_and_range):
14147 Rename locals to avoid shadowing.
14148 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
14150 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
14151 (BIDI_BOB): Remove unused macro.
14153 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14154 deduce are never used uninitialized.
14155 * term.c (encode_terminal_code): Likewise.
14157 * term.c (encode_terminal_code): Now static. Remove unused local.
14159 * tparam.h: New file.
14160 * term.c, tparam.h: Include it.
14161 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14162 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14163 Move these decls to tparam.h, and make them agree with what
14164 is actually in tparam.c. The previous trick of using incompatible
14165 decls in different modules does not conform to the C standard.
14166 All callers of tparam changed to use tparam's actual API.
14167 * tparam.c (tparam1, tparam, tgoto):
14168 Use const pointers where appropriate.
14170 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14171 * cm.h (struct cm): Likewise.
14172 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14173 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14174 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14175 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14176 (turn_on_face, init_tty): Likewise.
14177 * termchar.h (struct tty_display_info): Likewise.
14179 * term.c (term_mouse_position): Rename local to avoid shadowing.
14181 * alloc.c (mark_ttys): Move decl from here ...
14182 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14184 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14186 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14188 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
14190 * search.c (compile_pattern_1): Remove argument regp, unused since
14191 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14192 (compile_pattern): Don't pass it.
14194 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14196 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14197 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14199 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14201 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14203 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14204 gdk_window_get_screen, gdk_window_get_geometry,
14205 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14206 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14207 (xg_get_pixbuf_from_pixmap): New function.
14208 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14209 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14210 Call xg_get_pixbuf_from_pixmap instead of
14211 gdk_pixbuf_get_from_drawable.
14212 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14213 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14214 (xg_check_special_colors): Use GtkStyleContext and its functions
14216 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14217 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14218 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
14219 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14220 Call gtk_widget_get_preferred_size.
14221 (xg_frame_resized): gdk_window_get_geometry only takes 5
14223 (xg_win_to_widget, xg_event_is_for_menubar):
14224 Call gdk_x11_window_lookup_for_display.
14225 (xg_set_widget_bg): New function.
14226 (delete_cb): New function.
14227 (xg_create_frame_widgets): Connect delete-event to delete_cb.
14228 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
14229 (xg_set_background_color): Call xg_set_widget_bg.
14230 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14231 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14232 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14233 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14235 (update_frame_tool_bar): Call gtk_widget_hide.
14236 (xg_initialize): Use GDK_KEY_g.
14238 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14240 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14242 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14243 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14244 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14246 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
14248 * w32xfns.c (select_palette): Check success of RealizePalette against
14249 GDI_ERROR, not zero.
14251 See ChangeLog.11 for earlier changes.
14253 ;; Local Variables:
14257 Copyright (C) 2011-2012 Free Software Foundation, Inc.
14259 This file is part of GNU Emacs.
14261 GNU Emacs is free software: you can redistribute it and/or modify
14262 it under the terms of the GNU General Public License as published by
14263 the Free Software Foundation, either version 3 of the License, or
14264 (at your option) any later version.
14266 GNU Emacs is distributed in the hope that it will be useful,
14267 but WITHOUT ANY WARRANTY; without even the implied warranty of
14268 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14269 GNU General Public License for more details.
14271 You should have received a copy of the GNU General Public License
14272 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.