1 2013-08-26 Paul Eggert <eggert@cs.ucla.edu>
3 * frame.c (check_minibuf_window): Initialize 'window' properly,
4 so that Emacs reliably aborts later if 'window' is not initialized.
6 2013-08-26 Jan Djärv <jan.h.d@swipnet.se>
8 * gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
9 of VoidSymbol (Bug#15154).
11 2013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
13 * lisp.h (Mouse_HLInfo): Drop set-but-unused members
14 mouse_face_beg_y and mouse_face_end_y.
15 * xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
16 (mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
17 Adjust users and update comment where appropriate.
19 2013-08-26 Martin Rudalics <rudalics@gmx.at>
21 * frame.c (check_minibuf_window): New function.
22 (delete_frame, Fmake_frame_invisible, Ficonify_frame): Call
23 check_minibuf_window (Bug#15183).
25 2013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
27 * window.h (struct window): Replace last_cursor with last_cursor_vpos
28 because this is the only last cursor data we need to keep and consult.
29 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
30 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
33 2013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
35 Fix recovering from possible decompression error. Since
36 insert_from_gap doesn't always move point, we can't use PT as
37 the position where the partially decompressed data ends, and
38 should count how many bytes was produced so far.
39 * decompress.c (struct decompress_unwind_data): Add nbytes member.
40 (unwind_decompress): Really delete partially uncompressed data.
41 (Fzlib_decompress_region): Take decompressed data size into account.
43 2013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
45 * syntax.c (init_syntax_once): Adjust comment and do an early
46 initialization of Qchar_table_extra_slots just once...
47 * casetab.c (init_casetab_once):
48 * category.c (init_category_once):
49 * character.c (syms_of_character):
50 * coding.c (syms_of_coding):
51 * xdisp.c (syms_of_xdisp): ...and omit it here.
53 2013-08-24 Eli Zaretskii <eliz@gnu.org>
55 * xdisp.c (get_next_display_element): Don't apply to characters
56 from a display vector the logic of setting it->end_of_box_run_p
57 suitable for characters from a buffer. (Bug#15175)
59 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
60 to handle directories, rather than '_utime' which doesn't.
63 2013-08-24 Jan Djärv <jan.h.d@swipnet.se>
65 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
66 or fullscreen (Bug#14627).
68 2013-08-24 Paul Eggert <eggert@cs.ucla.edu>
70 System-dependent integer overflow fixes.
71 * process.c (Fset_process_window_size): Signal an error if
72 the window size is outside the range supported by the lower level.
73 * sysdep.c (set_window_size): Return negative on error,
74 nonnegative on success, rather than -1, 0, 1 on not in system,
75 failure, success. This is simpler. Caller changed.
76 (serial_configure): Remove unnecessary initialization of local.
77 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
78 size fits in unsigned long; this isn't true on some 32-bit hosts.
79 Avoid buffer overrun if some future version of /proc/meminfo has a
80 variable name longer than 20 bytes.
81 (system_process_attributes) [__FreeBSD__]:
82 Don't assume hw.availpages fits in 'int'.
84 2013-08-23 Paul Eggert <eggert@cs.ucla.edu>
86 Don't let very long directory names overrun the stack.
87 Fix some related minor problems involving "//", vfork.
88 * callproc.c (encode_current_directory): New function.
89 (call_process): Don't append "/"; not needed.
90 * fileio.c (file_name_as_directory_slop): New constant.
91 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
92 this can save the caller having to alloca.
93 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
94 Use SAFE_ALLOCA, not alloca.
95 (directory_file_name, Fexpand_file_name): Leave leading "//"
96 alone, since it can be special even on POSIX platforms.
97 * callproc.c (call_process):
98 * process.c (Fformat_network_address):
99 * sysdep.c (sys_subshell):
100 Use encode_current_directory rather than rolling our own.
101 (create_process): No need to encode directory; caller does that now.
102 * process.h (encode_current_directory): New decl.
103 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
104 Rework to avoid 'goto xyzzy;'.
106 2013-08-23 Eli Zaretskii <eliz@gnu.org>
108 * xdisp.c (handle_face_prop): If the default face was remapped use
109 the remapped face for strings from prefix properties. (Bug#15155)
111 2013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
113 Minor cleanup for redisplay interface and few related functions.
114 * frame.h (enum text_cursor_kinds): Move from here...
115 * dispextern.h (enum text_cursor_kinds): ...to here.
116 (toplevel): Drop unnecessary declarations.
117 (struct redisplay_interface): Use bool and enum text_cursor_kinds
118 in update_window_end_hook and draw_window_cursor functions.
119 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
120 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
121 * w32term.c (x_update_window_end,w32_draw_window_cursor):
122 * xterm.c (x_update_window_end, x_draw_window_cursor):
123 * xdisp.c (display_and_set_cursor, update_window_cursor)
124 (update_cursor_in_window_tree, x_update_cursor): Use bool and
125 enum text_cursor_kinds where appropriate.
127 2013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
129 Redesign redisplay interface to drop updated_row and updated_area.
130 * dispextern.h (updated_row, updated_area): Remove declaration.
131 (struct redisplay_interface): Pass glyph row and row area parameters
132 to write_glyphs, insert_glyphs and clear_end_of_line functions.
133 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
135 * dispnew.c (updated_row, updated_area): Remove.
136 (redraw_overlapped_rows, update_window_line): Adjust user.
137 (update_marginal_area, update_text_area): Likewise. Pass updated row
138 as a parameter. Prefer enum glyph_row_area to int where appropriate.
139 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
142 2013-08-22 Paul Eggert <eggert@cs.ucla.edu>
144 * process.c (flush_pending_output): Remove stub.
147 2013-08-21 Paul Eggert <eggert@cs.ucla.edu>
149 * callproc.c: Fix race that killed background processes (Bug#15144).
150 (call_process): New arg TEMPFILE_INDEX. Callers changed.
151 Record deleted process-id in critical section, not afterwards.
152 Don't mistakenly kill process created by a call-process invocation
153 that discards output and does not wait.
155 2013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
157 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
158 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
159 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
160 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
161 to shut up compiler in mark_object.
162 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
164 2013-08-21 Paul Eggert <eggert@cs.ucla.edu>
166 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
167 We can't portably rely on PTY_OPEN doing that, even if
168 it calls posix_openpt with O_CLOEXEC.
170 2013-08-20 Kenichi Handa <handa@gnu.org>
172 * character.c (string_char): Improve commentary.
174 2013-08-20 Paul Eggert <eggert@cs.ucla.edu>
176 * image.c (SIGNATURE_DIGESTSIZE): Remove.
177 (struct animation_cache): Make signature a flexible array member.
178 All uses changed. This is a tad slower but may insulate us better
179 from future changes to ImageMagick.
181 2013-08-19 Paul Eggert <eggert@cs.ucla.edu>
183 * image.c: Shrink memory needed for animation cache.
184 (SIGNATURE_DIGESTSIZE): New constant.
185 (struct animation_cache): Make 'signature' a fixed size array of bytes.
186 (imagemagick_create_cache): Copy the signature. This saves
187 several KB of memory that ImageMagick wastes per signature.
188 Don't bother updating the update_time, as the caller does that now.
189 (imagemagick_prune_animation_cache): Don't destroy the signature, as
190 it's a fixed size struct member now.
191 (imagemagick_get_animation_cache): Always destroy the signature,
192 as it's now imagemagick_create_cache's responsibility to copy it.
193 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
194 and use memcmp rather than strcmp.
195 eassert that ImageMagick returns a signature of the specified length.
197 2013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
199 * image.c (imagemagick_get_animation_cache): Don't segfault on
201 (imagemagick_get_animation_cache): Revert to previous definition
202 so that it actually works. But keep the memory leak fix.
203 (imagemagick_get_animation_cache): Fix memory leak.
205 2013-08-19 Paul Eggert <eggert@cs.ucla.edu>
207 * image.c: Fix animation cache signature memory leak.
208 Fix some other minor performance problems while we're at it.
209 (imagemagick_create_cache): Clear just the members that
210 need clearing. Don't set update_time, as caller does that now.
211 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
212 Simplify by using pointer-to-pointer instead of a prev pointer.
213 (imagemagick_prune_animation_cache): Use make_emacs_time rather
214 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
215 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
216 it's already a copy. Free the signature probe unless it's cached.
218 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
219 This was introduced by my 2013-08-12 fix for Bug#15035.
221 2013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
223 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
224 (imagemagick_prune_animation_cache): Now static.
226 2013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
228 * image.c (imagemagick_get_animation_cache): Don't segfault when
231 2013-08-18 Ken Brown <kbrown@cornell.edu>
233 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
234 static heap if ENABLE_CHECKING is defined.
235 (max_bss_sbrk_ptr): New variable.
237 (report_sheap_usage): Report maximum static heap usage instead of
238 ending static heap usage.
240 2013-08-17 Eli Zaretskii <eliz@gnu.org>
242 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
243 of zlib_initialized according to the results of calling
246 2013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
248 * image.c: Implement an ImageMagick per-image cache.
249 (imagemagick_get_animation_cache): Fix a double-free error.
250 (imagemagick_load_image): Remove the ping_wand code, which only
251 apparently saved time on invalid animated images, and slowed down
252 everything else. Optimise for the common case.
254 2013-08-16 Xue Fuqiao <xfq.free@gmail.com>
256 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
258 * editfns.c (insert_before_markers): Mention overlay in the doc string.
260 * marker.c (set_marker): Remove documentation of undefined behavior.
262 2013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
264 * image.c (imagemagick_compute_animated_image): Animate correctly
265 when sub-images are smaller than the main image.
266 (imagemagick_compute_animated_image): Setting the iterator row to
267 zero is apparently not allowed.
268 (imagemagick_compute_animated_image): Allow images that say they
269 have sub-images that are bigger than the main image, but just crop
272 2013-08-15 Jan Djärv <jan.h.d@swipnet.se>
274 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
276 2013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
278 * image.c (imagemagick_compute_animated_image): Respect the GIF
281 2013-08-15 Ken Brown <kbrown@cornell.edu>
283 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
284 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
287 2013-08-15 Paul Eggert <eggert@cs.ucla.edu>
289 Fix minor problems found by static checking.
290 * frame.c (delete_frame):
291 * xdisp.c (next_element_from_display_vector):
292 Avoid uninitialized local.
293 * image.c (imagemagick_compute_animated_image): Port to C89.
294 Prefer usual GNU indentation style for loops.
295 Be more careful about bizarrely large sizes, by using ptrdiff_t
298 2013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
300 Fix infinite frame selection loop (Bug#15025).
301 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
303 2013-08-15 Eli Zaretskii <eliz@gnu.org>
305 * xdisp.c (compute_window_start_on_continuation_line): When
306 WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
307 to make sure we end up setting the window start at the leftmost
308 visible character of the display line. This avoids funky
309 horizontal shifting because the window start is not kept on the
310 same position. (Bug#15090)
311 (next_element_from_display_vector): Support 'box' face attribute
312 in the face definitions of a display vector. (Bug#15099)
314 2013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
316 * image.c (imagemagick_compute_animated_image): Implement animated
318 (imagemagick_compute_animated_image): Fix some compilation
319 warnings. Implement a very simple cache to make the animation
320 usable at all, but it should be replaced with a per-image cache.
322 2013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
324 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
325 to do `for' loops over alist values.
326 * buffer.h (FOR_EACH_BUFFER):
327 * process.c (FOR_EACH_PROCESS): Use it.
328 (handle_child_signal, status_notify, Fget_buffer_process)
329 (kill_buffer_processes): Use FOR_EACH_PROCESS.
331 2013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
333 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
334 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
335 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
336 to xzalloc and so avoid redundant call to memset.
337 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
338 members because it is allocated with xzalloc and so already zeroed.
340 2013-08-14 Ken Brown <kbrown@cornell.edu>
342 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
345 2013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
347 Utility function and macro to copy Lisp string to C string.
348 * lisp.h (xlispstrdupa): New macro.
349 (xlispstrdup): New prototype.
350 * alloc.c (xlispstrdup): New function.
351 * callint.c (Fcall_interactively):
352 * fileio.c (Ffile_name_directory, Fexpand_file_name)
353 (Fsubstitute_in_file_name):
354 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
355 * image.c (x_create_bitmap_from_file):
356 * w32term.c (w32_term_init):
357 * xterm.c (x_term_init): Use xlispstrdup.
359 2013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
361 * image.c (imagemagick_load_image): Make animated pictures work.
362 There's still some problems with background color settings, though
365 * decompress.c (unwind_decompress): Always restore point.
367 2013-08-14 Xue Fuqiao <xfq.free@gmail.com>
369 * marker.c (set_marker): Reformat documentation.
371 2013-08-14 Paul Eggert <eggert@cs.ucla.edu>
373 * xdisp.c (cursor_type_changed): Now static.
375 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
376 Use changed. This avoids the need to call xmalloc and for the
377 caller to call xfree, and avoids memory leaks in some situations.
379 2013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
381 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
382 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
383 (redisplay_window): If window_end_valid is cleared due to non-zero
384 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
385 so do not call to try_cursor_movement for that window.
387 2013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
389 * window.h (struct window): Convert window_end_pos and
390 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
391 (wset_window_end_pos, wset_window_end_vpos): Remove.
392 * dispnew.c (adjust_glyph_matrix):
393 * window.c (Fwindow_end, replace_window, set_window_buffer)
395 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
396 (set_vertical_scroll_bar, redisplay_window, try_window)
397 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
398 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
399 (note_mouse_highlight): Adjust users.
400 (try_cursor_movement): Likewise. Convert old precondition to eassert.
403 2013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
405 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
406 * image.c (imagemagick_filename_hint): Use `const char *' and
407 prefer SSDATA to SDATA to avoid warnings.
409 2013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
411 Cleanup window fringes, margins and scroll bars adjustments.
412 * window.c (set_window_fringes, set_window_margins)
413 (set_window_scroll_bars, apply_window_adjustment): New functions.
414 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
415 (Fset_window_scroll_bars): Use them.
417 2013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
419 * window.h (struct window): Convert scroll_bar_width
420 from Lisp_Object to integer. Adjust comment.
421 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
423 * window.c (wset_scroll_bar_width): Remove.
424 (make_window): Initialize scroll_bar_width.
425 (Fsplit_window_internal): Use direct assignment.
426 (Fset_window_configuration, save_window_save):
427 Convert Lisp_Object to integer and back where appropriate.
428 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
429 bar was actually changed, and mention this in docstring.
431 2013-08-13 Paul Eggert <eggert@cs.ucla.edu>
433 * decompress.c: Minor simplifications.
434 (Fzlib_decompress_region): Don't bother verifying
435 that avail_out <= UINT_MAX, as that was confusing.
436 Mention the restriction in a comment instead.
437 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
439 2013-08-13 Jan Djärv <jan.h.d@swipnet.se>
441 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
442 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
444 2013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
446 * image.c (imagemagick_filename_hint): Check for errors in the
449 2013-08-13 Eli Zaretskii <eliz@gnu.org>
451 * window.c (Fwindow_margins): Return nil when there's no marginal
452 area, as per the documented API.
454 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
455 Fmake_vector, as scroll bar's struct members are not all Lisp
456 objects now. This avoids crashes in GC.
458 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
459 bool, so its address could be taken.
461 2013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
463 * image.c (imagemagick_filename_hint): New function to possibly
464 apply `image-content-type-suffixes'.
465 (imagemagick_load_image): Use it.
467 2013-08-13 Eli Zaretskii <eliz@gnu.org>
469 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
470 if loading zlib failed.
472 2013-08-13 Jan Djärv <jan.h.d@swipnet.se>
474 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
475 2013-08-13 checkin below. Change bool to BOOL, rule is:
476 All Obj-C code uses BOOL, except for interfaces callable from C.
478 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
480 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
482 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
483 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
484 bool instead of BOOL.
485 * w32term.h (struct scroll_bar): Convert fringe_extended_p
486 from Lisp_Object to bitfield. Adjust comment.
487 * w32term.c (x_scroll_bar_create): Adjust user.
488 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
489 * xterm.c (XTset_vertical_scroll_bar): Likewise.
490 Use bool for boolean.
491 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
492 to `unsigned int' when defining a bitfield.
494 2013-08-13 Paul Eggert <eggert@cs.ucla.edu>
496 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
498 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
500 * window.h (struct window): Convert left_margin_cols and
501 right_margin_cols from Lisp_Objects to integers. Adjust comment.
502 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
503 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
505 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
507 (showing_window_margins_p, update_window_line, update_frame_1):
508 * fringe.c (draw_fringe_bitmap_1):
509 * xdisp.c (window_box_width): Adjust users.
510 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
511 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
512 Use direct assignment.
513 (Fset_window_configuration, save_window_save, Fwindow_margins):
514 Convert Lisp_Object to integer and back where appropriate.
515 (Fset_window_margins): Adjust user. Return t if any margin
516 was actually changed, and mention this in docstring.
518 2013-08-13 Xue Fuqiao <xfq.free@gmail.com>
520 * syntax.c (forward_word):
521 * cmds.c (forward_char, backward_char): Mention the optional argument.
523 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
525 * window.h (struct window): Convert left_fringe_width
526 and right_fringe_width from Lisp_Objects to integers.
528 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
529 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
530 * window.c (wset_left_fringe_width, wset_right_fringe_width):
532 (make_window): Initialize new integer fields to -1.
533 (Fsplit_window_internal): Use direct assignment.
534 (Fset_window_configuration, save_window_save): Convert
535 Lisp_Object to integer and back where appropriate.
536 (Fset_window_fringes): Adjust user. Return t if any fringe
537 was actually changed, and mention this in docstring.
539 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
541 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
542 * nsfns.m (x_set_cursor_type):
543 * w32fns.c (x_set_cursor_type):
544 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
545 * xdisp.c (set_frame_cursor_types): ...but in common code.
547 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
549 * font.c (clear_font_cache): New function, stripped from...
550 (Fclear_font_cache): ...here, which now uses the function
551 above. Adjust comment.
552 * font.h (clear_font_cache): Add prototype.
553 * xfaces.c (clear_face_cache): Use clear_font_cache.
555 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
557 * window.c (Fset_window_start): Compare `w', not `window' because
558 `w' might not be equal to `window' after call to decode_live_window.
560 2013-08-12 Paul Eggert <eggert@cs.ucla.edu>
562 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
563 This fixes a problem introduced by the Bug#15035 patch
564 when using GPG. Reported by Herbert J. Skuhra.
566 2013-08-12 Eli Zaretskii <eliz@gnu.org>
568 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
569 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
572 2013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
574 * decompress.c (Fzlib_decompress_region): Support zlib
575 decompression, too, and rename.
577 2013-08-12 Paul Eggert <eggert@cs.ucla.edu>
579 Minor zlib configuration tweaks.
580 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
581 Don't assume presence of fn_inflateInit2_ zlib internal function.
583 2013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
585 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
586 include the zlib prefix.
588 2013-08-12 Eli Zaretskii <eliz@gnu.org>
590 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
591 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
592 define static variables that are pointers to zlib functions to be
594 (init_zlib_functions) [WINDOWSNT]: New function.
595 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
597 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
598 macros instead of invoking the zlib functions directly.
599 (syms_of_decompress): DEFSYM Qzlib_dll. Staticpro
602 2013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
604 Avoid looping over all frame windows to freeze and unfreeze.
605 * window.h (struct window): Drop frozen_window_start_p.
606 (freeze_window_starts): Drop prototype.
607 * frame.h (struct frame): New frozen_window_starts flag.
608 (FRAME_WINDOWS_FROZEN): New macro.
609 * window.c (freeze_window_start, freeze_window_starts):
611 (select_window, replace_window): Adjust users.
612 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
613 (window_frozen_p): New function.
614 (redisplay_window): Use it.
616 2013-08-12 Paul Eggert <eggert@cs.ucla.edu>
618 Fix some fd issues when running subprocesses (Bug#15035).
619 Fix bugs that can leak files or file descriptors on errors.
620 Don't unlink open temp files, as that's hard for users to diagnose
621 when things go awry (e.g., temp disk exhausted).
622 Don't bother to lock temp files. Check for invalid recursion.
623 * callproc.c (synch_process_fd): Remove. All uses removed.
624 (synch_process_tempfile): New var or macro.
625 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
627 (record_kill_process): New arg, the temp name. All callers changed.
628 (delete_temp_file): Now just a simple wrapper around unlink.
629 (call_process_kill): New arg, the call_process_fd array.
630 Close them all. Clear synch_process_pid. Remove the temp file,
631 or arrange for it to be removed.
632 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
633 that's been moved to synch_process_tempfile. Caller changed.
634 Do not remove the tempfile; that's now call_process_kill's
636 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
637 call_process_kill; the caller now does that.
638 (call_process_cleanup): Do not close the process fd; that's now
639 call_process_kill's responsibility.
640 (Fcall_process): Implement via new function call_process, which
641 has most of the old body of Fcall_process, but with a different API.
642 (call_process): New function that does not open or close filefd if
643 it is nonnegative. Record which fds need to be closed, and let
644 call_process_kill close (and remove the tempfile, on MSDOS) on error.
645 Signal an error if invoked recursively (could be done via a hook).
646 Simplify creation of the tempfile in the MSDOS case.
647 Don't create the output file until after checking for the executable.
648 Report any failure to open /dev/null.
649 Don't open /dev/null for writing twice; once is enough.
650 Don't create pipe if all output is being discarded or sent to file.
651 Don't worry about setting up the coding system or reading from the
652 pipe if all output is being discarded.
653 Hoist fd_error local into top level, to lessen block nesting.
654 Don't record deleted pid here; now done by Fcall_process_region.
655 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
656 and note its success in synch_process_tempfile.
657 Do not leak resources when child_setup fails.
658 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
659 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
660 (create_temp_file): Now returns open fd, with an additional
661 Lisp_Object * argument to return the name. All callers changed.
662 Do not close the file; rewind it instead, and leave it open for
663 the caller. Do not lock the temp file. Unwind-protect the file
664 and the file-descriptor.
665 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
666 If an asynchrounous process, record it here, not in call_process.
667 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
668 * eval.c (set_unwind_protect): New function.
669 * fileio.c (write_region): New function, generalized from the
670 old Fwrite_region. Do not lock temp files.
671 (Fwrite_region): Use it.
672 * lisp.h (set_unwind_protect, write_region): New decls.
673 * process.c: Include <verify.h>.
674 (make_process): Mark fds as initially closed.
675 (deleted_pid_list): Now a list of pid-filename pairs.
677 (close_process_fd): New function.
678 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
679 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
680 New constants. Verify that their number matches PROCESS_OPEN_FDS.
681 (create_process, create_pty, Fmake_serial_process)
682 (server_accept_connection): Record which fds need to be closed,
683 and let deactivate_process close them.
684 (Fmake_network_process): Do not discard the unwind-protect
685 until it's safe to do so.
686 (deactivate_process): Close the fds opened by create_process etc.
687 (Fprocess_send_eof): Adjust to new way of recording open fds.
688 Report an error if /dev/null can't be opened, instead of aborting.
689 * process.h (PROCESS_OPEN_FDS): New constant.
690 (struct Lisp_Process): New member open_fds.
691 (record_kill_process, record_deleted_pid): Adjust signatures.
692 (record_deleted_pid): Move decl here ...
693 * syswait.h (record_deleted_pid): ... from here.
695 2013-08-11 Paul Eggert <eggert@cs.ucla.edu>
697 * decompress.c: Fix bugs with large buffers and weird inputs.
698 Tune a bit. Reindent as per usual Emacs style.
699 (BUFFER_SIZE): Remove.
700 (Fdecompress_gzipped_region): Do not mishandle input buffers with
701 more than UINT_MAX bytes. Decompress into the gap instead of into
702 an auto buffer, as this should avoid copying. Return nil if
703 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
704 set immediate_quit; we shouldn't trust zlib code that much.
706 2013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
708 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
709 errors, and really move the gap to where we want it.
711 * lisp.h: Include decompress.c support.
713 * emacs.c (main): Include decompress.c support.
715 * Makefile.in: Include -lz if present.
717 2013-08-11 Jan Djärv <jan.h.d@swipnet.se>
719 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
720 (initWithTitle:): Initialize frame to 0.
721 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
722 (fillWithWidgetValue:frame:): Renamed from
723 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
725 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
726 fillWithWidgetValue:frame:
728 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
729 remove memory leak warnings.
731 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
732 (ns_check_menu_open): Handle menu == nil. Remove assignment to
735 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
736 (x_activate_menubar): Update the whole menu.
737 (trackingNotification:): Call ns_check_menu_open if tracking ends.
738 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
739 current event is not NSSystemDefined (Bug#15001).
740 Call ns_check_menu_open only if trackingMenu is 2.
741 (menuDidClose:): New method, decrease trackingMenu.
742 (fillWithWidgetValue:setDelegate:): New method.
743 (fillWithWidgetValue:): Call the above.
745 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
747 2013-08-11 Paul Eggert <eggert@cs.ucla.edu>
749 Omit some unnecessary casts.
750 Many of these go back to the old pre-C89 days, when they may have
751 been needed, but we've been assuming C89 or later for a while now.
752 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
753 (live_float_p, live_misc_p, live_vector_p):
754 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
755 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
757 * callint.c (Fcall_interactively):
758 * doc.c (Fsubstitute_command_keys):
759 * filelock.c (get_boot_time):
760 * frame.c (xrdb_get_resource):
761 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
762 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
763 (xg_get_file_name_from_selector, menuitem_destroy_callback)
764 (menuitem_highlight_callback, menu_destroy_callback)
765 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
766 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
767 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
768 (xg_tool_bar_help_callback, tb_size_cb):
769 * image.c (xpm_alloc_color, png_read_from_memory)
770 (png_read_from_file, png_load_body, our_memory_skip_input_data)
771 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
773 * keymap.c (describe_map):
774 * nsfns.m (Fns_display_monitor_attributes_list):
775 * nsmenu.m (process_dialog:):
776 * nsterm.m (hold_event):
777 * process.c (wait_reading_process_output):
778 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
779 * scroll.c (do_direct_scrolling, scrolling_1):
780 * termcap.c (tgetent):
781 * window.c (check_window_containing, add_window_to_list)
782 (freeze_window_starts):
783 * xdisp.c (compare_overlay_entries, vmessage):
784 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
785 (x_get_monitor_attributes_xrandr)
786 (Fx_display_monitor_attributes_list, x_display_info_for_name)
787 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
788 * xfont.c (xfont_match, xfont_open):
789 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
790 (menubar_selection_callback, menu_position_func)
791 (popup_selection_callback, create_and_show_popup_menu)
792 (dialog_selection_callback, create_and_show_dialog):
793 * xrdb.c (x_get_string_resource):
795 * xsmfns.c (x_session_check_input):
796 * xterm.c (x_draw_glyphless_glyph_string_foreground)
797 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
798 (xaw_jump_callback, xaw_scroll_callback):
799 Omit unnecessary casts.
801 2013-08-10 Paul Eggert <eggert@cs.ucla.edu>
803 Minor string-length refactoring.
804 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
805 * frame.c (make_monitor_attribute_list):
806 Prefer build_string to strlen + make_string.
808 2013-08-10 Jan Djärv <jan.h.d@swipnet.se>
810 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
811 don't check minor_code (Bug#14417).
813 2013-08-09 Eli Zaretskii <eliz@gnu.org>
815 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
816 vertical positions instead. This avoids calling MATRIX_ROW with
817 row numbers that are possibly beyond valid limits. (Bug#15064)
819 2013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
821 Use xstrdup and build_unibyte_string where applicable.
822 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
824 * xrdb.c (x_get_customization_string):
825 * xterm.c (xim_initialize):
826 * w32fns.c (w32_window): Use xstrdup.
827 (w32_display_monitor_attributes_list):
828 * emacs.c (init_cmdargs):
829 * keyboard.c (PUSH_C_STR):
830 * nsfont.m (nsfont_open):
831 * sysdep.c (system_process_attributes):
832 * w32.c (system_process_attributes):
833 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
835 2013-08-09 Eli Zaretskii <eliz@gnu.org>
837 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
838 variables of these types so that GDB would know about them, as aid
839 for debugging fatal exceptions. (Bug#15024) See also
840 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
843 2013-08-08 Jan Djärv <jan.h.d@swipnet.se>
845 * nsterm.m (ns_update_begin): Don't change clip path if it would be
846 larger than the NSWindow (Bug#14934).
848 2013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
850 Redesign redisplay interface to drop global variable updated_window.
851 Always pass currently updated window as a parameter to update routines.
852 * dispextern.h (updated_window): Remove declaration.
853 (struct redisplay_interface): Pass window parameter to
854 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
855 and after_update_window_hook.
856 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
858 * dispnew.c (updated_window): Remove.
859 (redraw_overlapped_rows, update_marginal_area, update_text_area)
860 (update_window_line): Adjust to match redisplay interface changes.
861 * nsterm.m (ns_update_window_begin, ns_update_window_end)
862 (ns_scroll_run, ns_after_update_window_line):
863 * w32term.c (x_update_window_begin, x_update_window_end)
864 (x_after_update_window_line, x_scroll_run):
865 * xterm.c (x_update_window_begin, x_update_window_end)
866 (x_after_update_window_line, x_scroll_run):
867 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
868 Likewise. Adjust comments where appropriate.
869 (x_cursor_to): Simplify because this is always called during window
870 update (but install debugging check anyway).
871 (expose_window): Check must_be_updated_p flag to see whether this
872 function is called during window update.
874 2013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
876 Do not reset window modification event counters excessively.
877 These leftovers and poor man's tricky methods to catch extra
878 redisplay's attention are no longer needed.
879 * frame.c (set_menu_bar_lines_1):
880 * minibuf.c (read_minibuf_unwind):
881 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
882 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
883 (window_scroll_line_based, Fset_window_configuration):
884 * xdisp.c (redisplay_window): Do not reset last_modified and
885 last_overlay_modified counters.
887 2013-08-07 Jan Djärv <jan.h.d@swipnet.se>
889 * xselect.c (x_send_client_event): Set send_event and serial, memset
890 data.l as it might be bigger than data.b. Use 24 bit mask to
891 XSendEvent (Bug#15034).
893 2013-08-07 Eli Zaretskii <eliz@gnu.org>
895 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
896 for TTY frames that are not the top frame on their console.
899 2013-08-07 Martin Rudalics <rudalics@gmx.at>
901 * w32term.c (w32fullscreen_hook): Really maximize frame when
902 asked for (Bug#14841).
904 2013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
906 Prefer selected_window to Fselected_window, likewise for frames.
907 * buffer.c (Fbuffer_swap_text):
908 * data.c (Fvariable_binding_locus):
909 * window.c (run_window_configuration_change_hook): Adjust users.
910 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
911 Use decode_live_frame.
913 2013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
915 Be more careful if selected window shows the buffer other than current,
916 use window_outdated only if this is not so. This change should also
917 address some weird issues discussed in Bug#13012.
918 * window.h (window_outdated): New prototype.
919 * window.c (window_outdated): Now here. Convert from static and
920 always assume window's buffer.
921 (Fwindow_end, Fwindow_line_height): Use it.
922 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
923 and always assume window's buffer.
924 (redisplay_window): Adjust user.
925 (redisplay_internal): Call to reconsider_clip_changes once and
926 check whether mode line should be updated only if selected window
927 shows current buffer.
928 (run_window_scroll_functions): Use eassert for debugging check.
929 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
931 2013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
933 * window.c (window_scroll, window_scroll_pixel_based)
934 (window_scroll_line_based): Use bool for booleans.
936 2013-08-06 Paul Eggert <eggert@cs.ucla.edu>
938 * process.c: Fix minor off-by-one issues in descriptor counts.
939 This shouldn't fix any real bugs, but it cleans up the code a bit.
940 (max_process_desc, max_input_desc): -1, not 0, means none.
942 (delete_input_desc): New function.
943 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
944 (deactivate_process): Scan backwards when recomuting max_process_desc;
945 that should be faster.
946 (init_process_emacs): Initialize max_input_desc.
948 2013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
950 Use region cache to speedup bidi_find_paragraph_start.
951 * buffer.h (struct buffer): New member bidi_paragraph_cache.
952 Rename cache_long_line_scans to cache_long_scans.
953 * buffer.c (bset_cache_long_line_scans): Rename to
954 bset_cache_long_scans.
955 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
956 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
958 (syms_of_buffer): Rename cache-long-line-scans to
959 cache-long-scans. Adjust docstring.
960 * search.c (newline_cache_on_off):
961 * indent.c (width_run_cache_on_off): Adjust users.
962 * bidi.c (bidi_paragraph_cache_on_off): New function.
963 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
964 * insdel.c (prepare_to_modify_buffer): Invalidate
965 bidi_paragraph_cache if enabled.
967 2013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
969 Invalidate region caches only if buffer text is going to be changed.
970 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
971 (modify_text): ...new prototype.
972 (prepare_to_modify_buffer_1): New prototype.
973 * textprop.c (modify_region): Rename to...
974 (modify_text_properties): ...new function.
975 (add_text_properties_1, set_text_properties, Fremove_text_properties)
976 (Fremove_list_of_text_properties): Adjust users.
977 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
978 (modify_text): ...new function.
979 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
980 (prepare_to_modify_buffer_1): ...new function.
981 * casefiddle.c (casify_region):
982 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
983 (Ftranspose_regions): Use modify_text.
985 2013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
987 * lisp.mk (lisp): Add nadvice.elc.
989 2013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
991 New macro to iterate over live buffers similar to frames.
992 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
993 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
994 Declare buffer-related variables here to offload lisp.h.
995 * buffer.c (Vbuffer_alist): Adjust comment.
996 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
997 (other_buffer_safely):
998 * data.c (store_symval_forwarding):
999 * dispnew.c (Fframe_or_buffer_changed_p):
1000 * fileio.c (Fdo_auto_save):
1001 * filelock.c (unlock_all_files):
1002 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
1004 2013-08-04 Paul Eggert <eggert@cs.ucla.edu>
1006 Fix some minor races in hosts lacking mkostemp (Bug#15015).
1007 * callproc.c (create_temp_file):
1008 * filelock.c (create_lock_file):
1009 Assume mkostemp, since it's now provided by Gnulib.
1011 2013-08-04 Eli Zaretskii <eliz@gnu.org>
1013 * w32.c (mkostemp): New function.
1014 (mktemp): Remove, no longer used. Most of the code reused in
1015 mkostemp. (Bug#15015)
1016 (mktemp): Don't undef.
1018 2013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
1020 * dispnew.c (glyph_matrix_count, glyph_pool_count):
1021 Move under GLYPH_DEBUG and ENABLE_CHECKING.
1022 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
1023 (free_glyph_pool, check_glyph_memory): Likewise for
1024 all users. Adjust comments where appropriate.
1026 2013-08-03 Paul Eggert <eggert@cs.ucla.edu>
1028 * composite.h: Minor fixups.
1029 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
1030 to fix a misspelling, and change it to an inline function while
1031 we're at it (it need not be a macro). All uses changed.
1032 (composition_method, composition_valid_p):
1033 Rewrite to avoid assignments in if-conditions.
1035 2013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1037 Do not use global Lisp_Object in composition macros.
1038 * composite.h (composition_temp): Remove declaration.
1039 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
1040 (composition_method, composition_valid_p): ...inline functions.
1041 (compose_region): Remove the leftover.
1042 * composite.c (composition_temp): Remove.
1043 (run_composition_function, update_compositions)
1044 (composition_compute_stop_pos, composition_adjust_point)
1045 (Ffind_composition_internal):
1046 * coding.c (handle_composition_annotation):
1047 * xdisp.c (handle_composition_prop, check_point_in_composition):
1048 Related users changed.
1050 2013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1052 Drop FRAME_PTR typedef.
1053 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
1054 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
1055 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
1056 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
1057 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
1058 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
1059 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
1060 All related users changed.
1062 2013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1064 * eval.c (default_toplevel_binding): New function.
1066 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
1067 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
1068 (syms_of_eval): Export them.
1069 * data.c (Fdefault_value): Micro cleanup.
1070 * term.c (init_tty): Use "false".
1072 2013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1074 Fix X GC leak in GTK and raw (no toolkit) X ports.
1075 * xterm.c (x_free_frame_resources): If white and black relief
1076 GCs are allocated, always free them here.
1077 * xfns.c (x_make_gc): Omit redundant initialization.
1078 * widget.c (create_frame_gcs): Remove the leftover.
1079 (EmacsFrameDestroy): Do nothing because all GCs are now freed
1080 in x_free_frame_resources.
1082 2013-08-02 Jan Djärv <jan.h.d@swipnet.se>
1084 * nsterm.m (windowWillResize:toSize:): Only change title if
1085 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
1087 (viewDidEndLiveResize): New method.
1089 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
1090 inside NS_IMPL_COCOA.
1092 2013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1094 * insdel.c (adjust_after_replace, replace_range, del_range_2):
1095 Do not check whether undo is enabled because record_insert and
1096 record_delete does that themselves.
1098 2013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1100 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
1101 member which is not really used any more.
1102 (FRAME_XIC_BASE_FONTNAME): Remove.
1103 * xfns.c (xic_free_fontset): Adjust user.
1104 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
1105 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
1106 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
1107 (xdialog_show): Use eassert for debugging check.
1108 * w32term.c (x_unfocus_frame): Remove unused dummy function.
1110 2013-08-01 Paul Eggert <eggert@cs.ucla.edu>
1112 * fileio.c, fns.c (merge): Move extern decl from here ...
1113 * lisp.h (merge): ... to here.
1115 2013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1117 Fix last font-related change.
1118 * w32font.h (w32font_list_internal, w32font_match_internal):
1120 * w32uniscribe.c (uniscribe_list, uniscribe_match):
1121 (uniscribe_list_family): Adjust to match font API change.
1122 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
1123 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
1125 2013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1127 * frame.h (FRAME_MOUSE_UPDATE):
1128 * nsterm.m (ns_frame_up_to_date): Omit redundant check
1129 whether hlinfo->mouse_face_mouse_frame is non-NULL.
1131 2013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1133 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
1134 * font.h (struct font_driver): Change list, match, and list_family
1135 functions to accept struct frame * as first arg.
1136 * font.c (font_score, font_compare, font_sort_entities): Remove
1138 (font_sort_entities, font_list_entities, font_select_entity):
1139 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
1140 match font API change.
1141 * xfont.c (xfont_list, xfont_match, xfont_list_family):
1142 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
1143 * ftxfont.c (ftxfont_list, ftxfont_match):
1144 * xftfont.c (xftfont_list, xftfont_match):
1145 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
1146 * w32font.c (w32font_list, w32font_match, w32font_list):
1147 (w32font_list_internal, w32_font_match_internal): Likewise.
1148 * xfaces.c (Fx_family_fonts): Adjust user.
1150 2013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1152 Do not use pure Xism x_wm_set_icon_position in non-X ports.
1153 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
1154 only if HAVE_X_WINDOWS is in use.
1155 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
1156 * nsterm.m (x_wm_set_icon_position): Remove no-op.
1157 * w32term.c (x_wm_set_icon_position): Likewise.
1158 * w32fns.c (x_icon): Adjust user.
1160 2013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1162 * xterm.c (last_mouse_press_frame): Remove the
1163 leftover which is not really used any more.
1164 (handle_one_xevent, syms_of_xterm): Adjust users.
1165 (x_flush): Call XFlush once per each X display, not frame.
1166 This is better because this code always unconditionally skips
1167 non-X frames in Vframe_list and issues the only XFlush if we
1168 have more than one X frame on the same X display.
1169 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
1170 Use bool for booleans.
1171 (x_draw_glyph_string_background, cvt_string_to_pixel):
1172 (cvt_pixel_dtor): Drop unnecessary prototypes.
1173 * xterm.h (x_display_ok): Adjust prototype.
1175 2013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1177 Drop unnecessary functions that deals with frame pixel size.
1178 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
1179 (x_pixel_height): Drop prototypes.
1180 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
1181 (x_pixel_height): Drop implementations.
1182 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
1183 which should be always valid for window frame.
1184 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
1185 * w32menu.c (Fx_popup_dialog):
1186 * xmenu.c (Fx_popup_dialog): Likewise for both.
1188 2013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1190 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
1191 frame parameters and call to Fmodify_frame_parameters just once.
1192 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
1193 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
1194 and mention nil frame in docstring.
1196 2013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1198 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
1199 (x_figure_window_size): Likewise. Adjust to return long.
1200 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
1201 (toplevel): Move Qterminal_live_p to...
1202 * terminal.c (toplevel): ...here, make it static, and...
1203 (syms_of_terminal): ...DEFSYM here.
1204 * frame.h (Qterminal_live_p): Remove declaration.
1205 (make_frame, x_figure_window_size): Adjust prototype.
1206 * nsfns.m (Fx_create_frame): Use long for window flags.
1208 2013-07-30 Paul Eggert <eggert@cs.ucla.edu>
1210 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
1211 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
1212 Do not assume that emacs_close (INT_MAX) is a no-op.
1214 2013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1216 * xfaces.c (make_face_cache): For struct face_cache, prefer
1217 xmalloc to xzalloc and so avoid redundant call to memset.
1218 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
1220 2013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1222 * fringe.c (draw_window_fringes, update_window_fringes)
1223 (compute_fringe_widths):
1224 * w32term.c (x_draw_glyph_string):
1225 * window.c (candidate_window_p, Frecenter):
1226 * xfaces.c (realize_basic_faces, realize_default_face)
1227 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
1228 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
1229 * xfns.c (x_set_cursor_color, xic_free_xfontset):
1230 * xmenu.c (Fx_menu_bar_open_internal):
1231 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
1232 * xsettings.c (xft_settings_event):
1233 * xterm.c (x_draw_glyph_string, x_had_errors_p):
1234 Use bool for booleans. Adjust style and comments where
1236 * dispextern.h (draw_window_fringes, update_window_fringes)
1237 (compute_fringe_widths):
1238 * xterm.h (x_had_errors_p): Adjust prototype.
1240 2013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1242 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
1243 CHECK_LIST. Rewrite the loop to avoid useless local variable.
1245 2013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1247 * fns.c (toplevel): Remove comment before Fsafe_length because
1250 2013-07-28 Paul Eggert <eggert@cs.ucla.edu>
1252 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
1254 2013-07-28 Eli Zaretskii <eliz@gnu.org>
1256 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
1257 frame which got the message is still alive, before dereferencing
1258 its pointer. (Bug#14970)
1260 * frame.c (delete_frame): Test "this" frame's minibuffer window to
1261 be a live window, before using it as such. (Bug#14970)
1263 2013-07-27 Eli Zaretskii <eliz@gnu.org>
1265 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
1266 w32_detect_focus_change instead of doing part of its job by hand.
1267 This fixes the problem whereby FOCUS_OUT events were not sent to
1270 2013-07-26 Eli Zaretskii <eliz@gnu.org>
1272 * process.c (Fprocess_list): Doc fix.
1274 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
1275 being re-exposed only if it didn't ask to become visible.
1276 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
1277 was previously iconified. (Bug#14841)
1278 (x_iconify_frame): Mark the frame iconified.
1280 2013-07-26 Paul Eggert <eggert@cs.ucla.edu>
1282 Fix minor problems found by static checking.
1283 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
1284 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
1286 2013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1288 * eval.c (set_specpdl_old_value): New function.
1289 (unbind_to): Minor simplification.
1290 (get_backtrace_frame): New function.
1291 (Fbacktrace_frame): Use it. Add `base' argument.
1292 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
1293 (syms_of_eval): Export backtrace-eval.
1294 * xterm.c (x_focus_changed): Simplify.
1296 2013-07-25 Paul Eggert <eggert@cs.ucla.edu>
1298 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
1300 2013-07-24 Eli Zaretskii <eliz@gnu.org>
1302 * xdisp.c (redisplay_window): Instead of moving point out of
1303 scroll margin, reject the force_start method, and try scrolling
1304 instead. (Bug#14780)
1306 2013-07-24 Ken Brown <kbrown@cornell.edu>
1308 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
1311 2013-07-24 Paul Eggert <eggert@cs.ucla.edu>
1313 * eval.c (Fprogn): Do not check that BODY is a proper list.
1314 This undoes the previous change. The check slows down the
1315 interpreter, and is not needed to prevent a crash. See
1316 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
1318 2013-07-23 Glenn Morris <rgm@gnu.org>
1320 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
1322 2013-07-23 Paul Eggert <eggert@cs.ucla.edu>
1324 Port to GNU/Linux systems with tinfo but not ncurses.
1325 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
1326 to decide whether ncurses is being used. Without this change,
1327 GCC complains about tgetent not being declared, on a system
1328 that has tinfo installed but ncurses not installed.
1330 * eval.c (Fprogn): Check that BODY is a proper list.
1332 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
1333 * data.c (Fsetq_default):
1334 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
1335 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
1337 Tune by taking advantage of the fact that ARGS is always a list
1338 when a function is declared to have UNEVALLED args.
1340 * emacsgtkfixed.c: Port to GCC 4.6.
1341 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
1343 2013-07-23 Juanma Barranquero <lekktu@gmail.com>
1345 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
1346 here to silence compiler warnings.
1348 2013-07-22 Paul Eggert <eggert@cs.ucla.edu>
1350 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
1351 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
1352 from messing up Emacs's 'struct frame' (Bug#14923).
1354 2013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1356 * alloc.c (make_save_ptr_ptr): Define this function.
1357 It was inadvertently omitted. It's needed only if
1358 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
1360 2013-07-21 Jan Djärv <jan.h.d@swipnet.se>
1362 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
1363 frame have focus (Bug#14895).
1365 2013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1367 Avoid vfork-related deadlock more cleanly.
1368 * callproc.c (child_setup): When the child's exec fails, output
1369 the program name, as that's more useful. Use O_NONBLOCK to avoid
1371 * process.c (create_process_1): Remove; no longer needed.
1372 (create_process): Remove timer hack; no longer needed, now that
1373 the child avoids deadlock.
1375 2013-07-20 Glenn Morris <rgm@gnu.org>
1377 * image.c (Fimage_flush): Fix doc typo.
1379 2013-07-20 Paul Eggert <eggert@cs.ucla.edu>
1381 Fix array bounds violation when pty allocation fails.
1382 * process.c (PTY_NAME_SIZE): New constant.
1383 (pty_name): Remove static variable; it's now auto.
1384 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1385 Take pty_name as an arg rather than using a static variable.
1386 All callers changed.
1387 (create_process): Recover pty_flag from process, not from volatile local.
1388 (create_pty): Stay inside array even when pty allocation fails.
1389 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1391 * lread.c (Fload): Avoid initialization only when lint checking.
1392 Mention that it's needed only for older GCCs.
1394 2013-07-20 Kenichi Handa <handa@gnu.org>
1396 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1397 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1399 2013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1401 * lread.c (Fload): Avoid uninitialized warning.
1403 2013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1405 Fix some minor file descriptor leaks and related glitches.
1406 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1407 (create_lock_file): Use write, not emacs_write.
1408 * image.c (slurp_file, png_load_body):
1409 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1410 (server_accept_connection):
1411 Don't leak an fd on memory allocation failure.
1412 * image.c (slurp_file): Add a cheap heuristic for growing files.
1413 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1414 as that's what the other routines do. Maybe input need not be
1415 blocked at all, but it's better to be consistent.
1416 Avoid undefined behavior when strlen is zero.
1418 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1419 (NSTATICS): Now a constant; doesn't need to be a macro.
1421 2013-07-19 Richard Stallman <rms@gnu.org>
1423 * coding.c (decode_coding_utf_8): Add simple loop for fast
1424 processing of ASCII characters.
1426 2013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1428 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1430 2013-07-19 Eli Zaretskii <eliz@gnu.org>
1432 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1433 unportable 'struct x_display_info'.
1434 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1437 2013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1439 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1440 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1442 (system_process_attributes): Prefer plain char to unsigned char
1443 when either will do. Clean up properly if interrupted or if
1444 memory allocations fail. Don't assume sscanf succeeds. Remove
1445 no-longer-needed workaround to stop GCC from whining. Read
1446 command-line once, instead of multiple times. Check read status a
1449 Fix obscure porting bug with varargs functions.
1450 The code assumed that int is treated like ptrdiff_t in a vararg
1451 function, which is not a portable assumption. There was a similar
1452 -- though these days less likely -- porting problem with various
1453 assumptions that pointers of different types all smell the same as
1454 far as vararg functions is conserved. To make this problem less
1455 likely in the future, redo the API to use varargs functions.
1456 * alloc.c (make_save_value): Remove this vararg function.
1457 All uses changed to ...
1458 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1459 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1461 (make_save_ptr): Rename from make_save_pointer, for consistency with
1462 the above. Define only on platforms that need it. All uses changed.
1464 2013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1466 * keyboard.c: Try to fix typos in previous change.
1467 (DISPLAY_LIST_INFO): New macro.
1468 (kbd_buffer_get_event): Do not access members that are not present
1469 in X11. Revert inadvertent change of "!=" to "=".
1471 2013-07-18 Juanma Barranquero <lekktu@gmail.com>
1473 * keyboard.c (kbd_buffer_get_event):
1474 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1475 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1477 2013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1479 * filelock.c: Fix unlikely file descriptor leaks.
1480 (get_boot_time_1): Rework to avoid using emacs_open.
1481 This doesn't actually fix a leak, but is better anyway.
1482 (read_lock_data): Use read, not emacs_read.
1484 * doc.c: Fix minor memory and file descriptor leaks.
1485 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1486 (get_doc_string, Fsnarf_documentation):
1487 Fix file descriptor leak on error.
1489 * term.c: Fix minor fdopen-related file descriptor leaks.
1490 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1491 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1493 * charset.c: Fix file descriptor leaks and errno issues.
1495 (load_charset_map_from_file): Don't leak file descriptor on error.
1496 Use plain record_xmalloc since the allocation is larger than
1497 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1499 * eval.c (record_unwind_protect_nothing):
1500 * fileio.c (fclose_unwind):
1502 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1503 The replacement doesn't block input, but that no longer seems
1506 2013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1508 * lread.c: Fix file descriptor leaks and errno issues.
1509 (Fload): Close some races that leaked fds or streams when 'load'
1511 (Fload, openp): Report error number of last nontrivial failure to open.
1512 ENOENT counts as trivial.
1513 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1515 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1516 now that the function is always called with a nonnegative arg.
1517 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1518 All uses replaced with ...
1519 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1521 A few more minor file errno-reporting bugs.
1522 * callproc.c (Fcall_process):
1523 * doc.c (Fsnarf_documentation):
1524 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1525 * process.c (set_socket_option):
1526 Don't let a constructor trash errno.
1527 * doc.c: Include <errno.h>.
1529 2013-07-16 Juanma Barranquero <lekktu@gmail.com>
1531 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1533 2013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1535 Fix w32 bug with call-process-region (Bug#14885).
1536 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1537 to Fcall_process when the input is empty. This simplifies the
1538 code a bit. It makes no difference on POSIXish platforms but
1539 apparently it fixes a bug on w32.
1541 Fix bug where insert-file-contents closes a file twice (Bug#14839).
1542 * fileio.c (close_file_unwind): Don't close if FD is negative;
1543 this can happen when unwinding a zapped file descriptor.
1544 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1545 in case Emacs runs out of memory between the two unwind-protects.
1546 Don't trash errno when closing FD.
1547 Zap the FD in the specpdl when closing it, instead of deferring
1548 the removal of the unwind-protect; this fixes a bug where a child
1549 function unwinds the stack past us.
1551 New unwind-protect flavors to better type-check C callbacks.
1552 This also lessens the need to write wrappers for callbacks,
1553 and the need for make_save_pointer.
1554 * alloca.c (free_save_value):
1555 * atimer.c (run_all_atimers):
1557 * alloc.c (safe_alloca_unwind):
1558 * atimer.c (unwind_stop_other_atimers):
1559 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1560 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1561 * minibuf.c (choose_minibuf_frame_1):
1562 * process.c (make_serial_process_unwind):
1563 * xdisp.h (pop_message_unwind):
1564 * xselect.c (queue_selection_requests_unwind):
1565 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1566 * alloca.c (record_xmalloc):
1567 Prefer record_unwind_protect_ptr to record_unwind_protect with
1569 * alloca.c (Fgarbage_collect):
1570 Prefer record_unwind_protect_void to passing a dummy.
1571 * buffer.c (restore_buffer):
1572 * window.c (restore_window_configuration):
1573 * xfns.c, w32fns.c (do_unwind_create_frame)
1574 New wrapper. All record-unwind uses of wrappee changed.
1575 * buffer.c (set_buffer_if_live):
1576 * callproc.c (call_process_cleanup, delete_temp_file):
1577 * coding.c (code_conversion_restore):
1578 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1579 * editfns.c (save_excursion_restore)
1580 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1581 (save_restriction_restore):
1582 * eval.c (restore_stack_limits, un_autoload):
1583 * fns.c (require_unwind):
1584 * keyboard.c (recursive_edit_unwind, tracking_off):
1585 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1586 * macros.c (pop_kbd_macro, restore_menu_items):
1587 * nsfns.m (unwind_create_frame):
1588 * print.c (print_unwind):
1589 * process.c (start_process_unwind):
1590 * search.c (unwind_set_match_data):
1591 * window.c (select_window_norecord, select_frame_norecord):
1592 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1593 (fast_set_selected_frame):
1594 * xfns.c, w32fns.c (unwind_create_tip_frame):
1595 Return void, not a dummy Lisp_Object. All uses changed.
1596 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1597 * callproc.c (call_process_kill):
1598 * fileio.c (restore_point_unwind, decide_coding_unwind)
1599 (build_annotations_unwind):
1600 * insdel.c (Fcombine_after_change_execute_1):
1601 * keyboard.c (read_char_help_form_unwind):
1602 * menu.c (unuse_menu_items):
1603 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1604 * sound.c (sound_cleanup):
1605 * xdisp.c (unwind_redisplay):
1606 * xfns.c (clean_up_dialog):
1607 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1608 Accept no args and return void, instead of accepting and returning
1609 a dummy Lisp_Object. All uses changed.
1610 * cygw32.c (fchdir_unwind):
1611 * fileio.c (close_file_unwind):
1612 * keyboard.c (restore_kboard_configuration):
1613 * lread.c (readevalllop_1):
1614 * process.c (wait_reading_process_output_unwind):
1615 Accept int and return void, rather than accepting an Emacs integer
1616 and returning a dummy object. In some cases this fixes an
1617 unlikely bug when the corresponding int is outside Emacs integer
1618 range. All uses changed.
1619 * dired.c (directory_files_internal_unwind):
1620 * fileio.c (do_auto_save_unwind):
1621 * gtkutil.c (pop_down_dialog):
1622 * insdel.c (reset_var_on_error):
1623 * lread.c (load_unwind):
1624 * xfns.c (clean_up_file_dialog):
1625 * xmenu.c, nsmenu.m (pop_down_menu):
1626 * xmenu.c (cleanup_widget_value_tree):
1627 * xselect.c (wait_for_property_change_unwind):
1628 Accept pointer and return void, rather than accepting an Emacs
1629 save value encapsulating the pointer and returning a dummy object.
1631 * editfns.c (Fformat): Update the saved pointer directly via
1632 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1633 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1634 (unwind_body): New function.
1635 (record_unwind_protect): First arg is now a function returning void,
1636 not a dummy Lisp_Object.
1637 (record_unwind_protect_ptr, record_unwind_protect_int)
1638 (record_unwind_protect_void): New functions.
1639 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1640 * fileio.c (struct auto_save_unwind): New type.
1641 (do_auto_save_unwind): Use it.
1642 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1643 * insdel.c (struct rvoe_arg): New type.
1644 (reset_var_on_error): Use it.
1645 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1647 (specbinding_func): Remove; there are now several such functions.
1648 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1649 (set_unwind_protect_ptr): New function.
1650 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1652 Be simpler and more consistent about reporting I/O errors.
1653 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1654 Say "Read error" and "Write error", rather than "I/O error", or
1655 "IO error reading", or "IO error writing", when a read or write
1657 * process.c (Fmake_network_process, wait_reading_process_output)
1658 (send_process, Fprocess_send_eof, wait_reading_process_output):
1659 Capitalize diagnostics consistently. Put "failed foo" at the
1660 start of the diagnostic, so that we don't capitalize the
1661 function name "foo". Consistently say "failed" for such
1663 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
1664 All callers changed. This is so it can use report_file_error.
1665 * sysdep.c (serial_open, serial_configure): Capitalize I/O
1666 diagnostics consistently as above.
1668 * fileio.c (report_file_errno): Fix errno reporting bug.
1669 If the file name is neither null nor a pair, package it up as a
1670 singleton list. All callers changed, both to this function and to
1671 report_file_error. This fixes a bug where the memory allocator
1672 invoked by list1 set errno so that the immediately following
1673 report_file_error reported the wrong errno value.
1675 Fix minor problems found by --enable-gcc-warnings.
1676 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
1677 * keyboard.c (kbd_buffer_get_event): Remove unused local.
1679 2013-07-16 Jan Djärv <jan.h.d@swipnet.se>
1681 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
1682 Set event->arg to Qt if switch-event shall be generated.
1683 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
1685 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
1687 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
1690 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
1691 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
1692 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
1693 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
1694 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
1695 and there is a focused frame.
1696 (head_table): Add focus-in and focus-out.
1697 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
1698 bind to handle-focus-in/out.
1700 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
1701 (Fhandle_switch_frame): Call Fhandle_focus_in.
1702 (syms_of_frame): defsubr handle-focus-in/out.
1704 2013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1706 Fix porting bug to older POSIXish platforms (Bug#14862).
1707 * sysdep.c (emacs_pipe): New function, that implements
1708 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
1709 This should port better to CentOS 5 and to Mac OS X 10.6.
1710 All calls to pipe2 changed.
1712 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
1713 This makes the code easier to read and the executable a bit smaller.
1714 Do not replace all calls to Fcons that happen to create lists,
1715 just calls that are intended to create lists. For example, when
1716 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1717 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1718 Similarly for list2 through list5.
1719 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1720 * bytecode.c (exec_byte_code):
1721 * callint.c (quotify_arg, Fcall_interactively):
1722 * callproc.c (Fcall_process, create_temp_file):
1723 * charset.c (load_charset_map_from_file)
1724 (Fdefine_charset_internal, init_charset):
1725 * coding.c (get_translation_table, detect_coding_system)
1726 (Fcheck_coding_systems_region)
1727 (Fset_terminal_coding_system_internal)
1728 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1729 * composite.c (update_compositions, Ffind_composition_internal):
1730 * dired.c (directory_files_internal, file_name_completion)
1732 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1733 * doc.c (Fsnarf_documentation):
1734 * editfns.c (Fmessage_box):
1736 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1737 (Feval, eval_sub, Ffuncall, apply_lambda):
1738 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1739 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1740 (Fset_file_times, Finsert_file_contents)
1741 (Fchoose_write_coding_system, Fwrite_region):
1742 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1743 * font.c (font_registry_charsets, font_parse_fcname)
1744 (font_prepare_cache, font_update_drivers, Flist_fonts):
1745 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1746 * frame.c (make_frame, Fmake_terminal_frame)
1747 (x_set_frame_parameters, x_report_frame_params)
1748 (x_default_parameter, Fx_parse_geometry):
1749 * ftfont.c (syms_of_ftfont):
1750 * image.c (gif_load):
1751 * keyboard.c (command_loop_1):
1752 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1753 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1754 (Fminor_mode_key_binding, accessible_keymaps_1)
1755 (Faccessible_keymaps, Fwhere_is_internal):
1756 * lread.c (read_emacs_mule_char):
1757 * menu.c (find_and_return_menu_selection):
1758 * minibuf.c (get_minibuffer):
1759 * nsfns.m (Fns_perform_service):
1760 * nsfont.m (ns_script_to_charset):
1761 * nsmenu.m (ns_popup_dialog):
1762 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
1763 (Fx_own_selection_internal):
1764 * nsterm.m (append2):
1765 * print.c (Fredirect_debugging_output)
1766 (print_prune_string_charset):
1767 * process.c (Fdelete_process, Fprocess_contact)
1768 (Fformat_network_address, set_socket_option)
1769 (read_and_dispose_of_process_output, write_queue_push)
1770 (send_process, exec_sentinel):
1771 * sound.c (Fplay_sound_internal):
1772 * textprop.c (validate_plist, add_properties)
1773 (Fput_text_property, Fadd_face_text_property)
1774 (copy_text_properties, text_property_list, syms_of_textprop):
1775 * unexaix.c (report_error):
1776 * unexcoff.c (report_error):
1777 * unexsol.c (unexec):
1778 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
1779 (Fformat_mode_line, syms_of_xdisp):
1780 * xfaces.c (set_font_frame_param)
1781 (Finternal_lisp_face_attribute_values)
1782 (Finternal_merge_in_global_face, syms_of_xfaces):
1783 * xfns.c (x_default_scroll_bar_color_parameter)
1784 (x_default_font_parameter, x_create_tip_frame):
1785 * xfont.c (xfont_supported_scripts):
1786 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
1787 (menu_help_callback, xmenu_show):
1789 * xterm.c (set_wm_state):
1790 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
1791 and similarly for list2 through list5.
1793 2013-07-15 Paul Eggert <eggert@cs.ucla.edu>
1795 * callproc.c (Fcall_process_region): Fix minor race and tune.
1796 (create_temp_file): New function, with the temp-file-creation part
1797 of the old Fcall_process_region. Use Fcopy_sequence to create the
1798 temp file name, rather than alloca + build_string, for simplicity.
1799 Don't bother to block input around the temp file creation;
1800 shouldn't be needed. Simplify use of mktemp. Use
1801 record_unwind_protect immediately after creating the temp file;
1802 this closes an unlikely race where the temp file was not removed.
1803 Use memcpy rather than an open-coded loop.
1804 (Fcall_process_region): Use the new function. If the input is
1805 empty, redirect from /dev/null rather than from a newly created
1806 empty temp file; this avoids unnecessary file system traffic.
1808 2013-07-14 Paul Eggert <eggert@cs.ucla.edu>
1810 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
1811 Simplify by making this case like the other two. This is a bit
1812 slower on obsolete hosts, but the extra complexity isn't worth it.
1814 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
1815 * process.c (create_process) [!DOS_NT]:
1816 Remove now-unnecessary calls to emacs_close.
1818 2013-07-13 Eli Zaretskii <eliz@gnu.org>
1820 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
1821 returning early. (Bug#14850)
1823 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
1824 and inhibit-iso-escape-detection attributes of 'undecided'.
1827 2013-07-13 Paul Eggert <eggert@cs.ucla.edu>
1829 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
1830 Reported by Herbert J. Skuhra in
1831 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
1833 Don't lose top specpdl entry when memory is exhausted.
1834 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
1835 specpdl overflow here, to simplify callers; all callers changed.
1836 Always reserve an unused entry at the stack top; this avoids
1837 losing the top entry's information when memory is exhausted.
1839 2013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1841 Clean up errno reporting and fix some errno-reporting bugs.
1842 * callproc.c (Fcall_process):
1843 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1844 * process.c (create_process, Fmake_network_process):
1845 * unexaix.c (report_error):
1846 * unexcoff.c (report_error):
1847 Be more careful about reporting the errno of failed operations.
1848 The code previously reported the wrong errno sometimes.
1849 Also, prefer report_file_errno to setting errno + report_file_error.
1850 (Fcall_process): Look at openp return value rather than at path,
1851 as that's a bit faster and clearer when there's a numeric predicate.
1852 * fileio.c (report_file_errno): New function, with most of the
1853 old contents of report_file_error.
1854 (report_file_error): Use it.
1855 (Ffile_exists_p, Ffile_accessible_directory_p):
1856 Set errno to 0 when it is junk.
1857 * fileio.c (Faccess_file):
1858 * image.c (x_create_bitmap_from_file):
1859 Use faccessat rather than opening the file, to avoid the hassle of
1860 having a file descriptor open.
1861 * lisp.h (report_file_errno): New decl.
1862 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
1865 * process.c (create_process, wait_reading_process_output) [AIX]:
1866 Remove obsolete SIGHUP-related code, as Emacs no longer disables
1867 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
1868 a multithreaded environment anyway).
1869 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
1871 2013-07-12 Andreas Schwab <schwab@linux-m68k.org>
1873 * image.c (x_find_image_file): Don't close a remote file handle.
1875 2013-07-12 Paul Eggert <eggert@cs.ucla.edu>
1877 Fix races with threads and file descriptors.
1878 * callproc.c (Fcall_process_region):
1879 * dired.c (open_directory):
1880 * emacs.c (main, Fdaemon_initialized):
1881 * image.c (x_find_image_file):
1882 * inotify.c (Finotify_rm_watch):
1883 * lread.c (Flocate_file_internal):
1884 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
1885 * term.c (term_mouse_moveto, init_tty):
1886 * termcap.c (tgetent):
1887 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
1888 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
1889 * unexhp9k800.c, unexmacosx.c (unexec):
1890 * callproc.c (Fcall_process_region):
1891 Use emacs_close, not close.
1892 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
1893 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
1894 and posix_close function on current platforms (which all lack them).
1895 (emacs_close): Use it. This should fix the races on GNU/Linux and
1896 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
1897 and it should avoid closing random victim file descriptors on
1900 2013-07-11 Paul Eggert <eggert@cs.ucla.edu>
1902 * inotify.c (uninitialized): Remove. All uses replaced by -1.
1903 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
1906 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
1907 This is for .gdbinit xbacktrace.
1909 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
1910 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
1911 (emacs_set_tty): Now static.
1912 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
1913 * term.c (tty_capable_p, tty_default_color_capabilities)
1914 (get_tty_terminal, term_mouse_movement)
1915 (handle_one_term_event, init_tty, maybe_fatal):
1916 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
1917 (tgetent, scan_file, name_match, compare_contin):
1918 * terminal.c (get_terminal):
1919 Use bool for boolean.
1920 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
1921 Prefer char to unsigned char if either will do.
1922 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
1923 (tty_write_glyphs): Prefer int to unsigned.
1924 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
1925 All callers changed.
1926 * termcap.c (tprint, main) [TEST]: Remove non-working test.
1928 2013-07-10 Paul Eggert <eggert@cs.ucla.edu>
1931 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
1932 (B__dummy__): New dummy symbol, to pacify C89.
1933 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
1934 they can't grok varargs macros.
1935 * dispnew.c (add_window_display_history)
1936 (add_frame_display_history):
1937 * print.c (print_object):
1938 * xdisp.c (debug_method_add):
1939 Use %p printf format only for void pointers.
1940 * emacs.c (usage_message): New constant, replacing ...
1941 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
1942 (main): Adjust to usage reorg.
1943 * fns.c (syms_of_fns):
1944 * profiler.c (syms_of_profiler):
1945 Don't use non-constant struct initializers.
1946 * gnutls.h (gnutls_initstage_t):
1947 * lisp.h (enum Lisp_Fwd_Type):
1948 * lread.c (lisp_file_lexically_bound_p):
1949 * xsettings.c (anonymous enum):
1950 Remove trailing comma.
1951 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
1952 * lisp.h (ENUM_BF): Use unsigned if pedantic.
1953 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
1955 * regex.c (const_re_char): New type, to pacify strict C89.
1956 All uses of 'const re_char' replaced to use it.
1957 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
1958 with glibc when strict C89. This change is imported from gnulib.
1960 (_Restrict_arr_): Rename from __restrict_arr, similarly.
1961 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
1962 Omit GNU_LINUX implementation, since it requires long long.
1963 * xterm.c (x_draw_underwave):
1964 Do not assume the traditional order of struct's members.
1965 (x_term_init): Rewrite to avoid the need for non-constant structure
1968 Syntax cleanup, mostly replacing macros with functions.
1969 This removes the need for the syntax_temp hack.
1970 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
1971 * syntax.c (SYNTAX_INLINE): New macro.
1972 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
1973 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
1974 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
1975 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
1976 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
1977 (SYNTAX_COMEND_FIRST): Now functions, not macros.
1978 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
1979 Now constants, not macros.
1980 (syntax_temp) [!__GNUC__]: Remove.
1981 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
1982 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
1983 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
1984 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
1985 Move here from syntax.h; now functions, not macros. Except for the
1986 last function, these are static since only syntax.c uses them.
1987 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
1988 All uses changed. Now a function, not a macro; use this fact
1989 to simplify the code.
1990 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
1991 compiler bugs; no longer relevant.
1992 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
1993 (SYNTAX_INLINE): New macro.
1994 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
1995 for the new functions. Use bool for boolean member.
1996 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
1997 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
1998 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
1999 (SETUP_BUFFER_SYNTAX_TABLE):
2000 Now extern inline functions, not macros.
2001 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
2002 Remove; all uses replaced by implementation.
2003 (syntax_temp) [!__GNUC__]: Remove decl.
2004 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
2006 2013-07-10 Jan Djärv <jan.h.d@swipnet.se>
2008 * emacs.c (main): Fix syntax error.
2010 2013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2012 Timestamp fixes for undo (Bug#14824).
2013 * atimer.c (schedule_atimer):
2014 * fileio.c (Ffile_newer_than_file_p):
2015 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
2016 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
2017 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
2018 (syms_of_fileio): Remove Sclear_visited_file_name.
2019 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
2020 file doesn't exist; this avoids an ambiguity with negative timestamps.
2021 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
2022 * systime.h (make_emacs_time, invalid_emacs_time):
2023 Don't assume struct timespec layout; POSIX doesn't guarantee it.
2024 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
2025 * undo.c (record_first_change): Push (visited-file-modtime) onto
2026 undo list rather than reimplementing it by hand, incorrectly.
2028 2013-07-09 Ken Brown <kbrown@cornell.edu>
2030 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
2032 2013-07-09 Juanma Barranquero <lekktu@gmail.com>
2034 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
2036 2013-07-09 Paul Eggert <eggert@cs.ucla.edu>
2038 Handle errno and exit status a bit more carefully.
2039 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
2040 number into an exit status. Instead, use EXIT_CANCELED.
2041 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
2042 * callproc.c (relocate_fd):
2043 * emacs.c (close_output_streams, main):
2044 * process.c (create_process):
2045 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
2046 Use emacs_perror for simplicity.
2047 * callproc.c (relocate_fd, main):
2048 * sysdep.c (sys_subshell):
2049 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
2050 (shut_down_emacs): Use emacs_write, not write.
2051 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
2052 * fileio.c (Fcopy_file, e_write):
2053 * nsterm.m (ns_select):
2054 * process.c (send_process):
2055 * sound.c (vox_write):
2056 Use emacs_write_sig, not emacs_write.
2057 * lisp.h (emacs_write_sig, emacs_perror): New decls.
2058 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
2060 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
2062 (emacs_full_write): New function.
2063 (emacs_write): Rewrite to use it.
2064 (emacswrite_sig, emacs_perror): New functions.
2065 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
2067 2013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
2069 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
2070 on NS even if it is present. Pixmap on NS is a void*.
2072 2013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2074 Port to Ubuntu 10 (Bug#14803).
2075 Problem reported by T.V. Raman.
2076 * process.c (close_on_exec, accept4, process_socket):
2077 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
2079 2013-07-07 Eli Zaretskii <eliz@gnu.org>
2081 * w32.c (sys_dup): Declare prototype.
2085 * callproc.c [WINDOWSNT]: Include sys/socket.h.
2087 2013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2089 Make file descriptors close-on-exec when possible (Bug#14803).
2090 This simplifies Emacs a bit, since it no longer needs to worry
2091 about closing file descriptors by hand in some cases.
2092 It also fixes some unlikely races. Not all such races, as
2093 libraries often open files internally without setting
2094 close-on-exec, but it's an improvement.
2095 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
2096 * callproc.c (Fcall_process) [!MSDOS]:
2097 * emacs.c (main) [!DOS_NT]:
2098 * nsterm.m (ns_term_init):
2099 * process.c (create_process):
2100 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
2101 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
2102 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
2103 Prefer mkostemp with O_CLOEXEC to mkstemp.
2104 * callproc.c (relocate_fd) [!WINDOWSNT]:
2105 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
2106 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
2108 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
2109 Make the resulting file descriptor close-on-exec.
2110 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
2111 * lread.c (load_descriptor_list, load_descriptor_unwind):
2112 Remove; no longer needed. All uses removed.
2113 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
2114 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
2116 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
2117 (Fmake_network_process, Fnetwork_interface_list):
2118 (Fnetwork_interface_info, server_accept_connection):
2119 Make newly-created socket close-on-exec.
2120 * sysdep.c (emacs_open, emacs_fopen):
2121 Make new-created descriptor close-on-exec.
2122 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
2123 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
2125 2013-07-07 Jan Djärv <jan.h.d@swipnet.se>
2127 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
2128 for NS_IMPL_GNUSTEP.
2130 2013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2132 Fix openp errno handling.
2133 * callproc.c (Fcall_process): Preserve openp errno around close.
2134 * lread.c (openp): Set errno when returning -1, as some callers
2137 2013-07-06 Jan Djärv <jan.h.d@swipnet.se>
2139 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
2141 * nsterm.h (NSSavePanel): Update comment.
2142 (NSAPP_DATA2_RUNFILEDIALOG): Define.
2143 (ns_run_file_dialog): Declare.
2145 * nsfns.m: Remove panelOK.
2147 (ns_run_file_dialog): New function.
2148 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
2149 event loop, so file dialog is popped up by ns_run_file_dialog, called
2150 by sendEvent (Bug#14578).
2151 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
2153 2013-07-06 Eli Zaretskii <eliz@gnu.org>
2155 * xdisp.c (default_line_pixel_height): New function.
2156 (pos_visible_p, move_it_vertically_backward, try_scrolling)
2157 (try_cursor_movement, redisplay_window, try_window)
2158 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
2160 * window.c (window_scroll_pixel_based): use
2161 default_line_pixel_height.
2163 * dispextern.h (default_line_pixel_height): Add prototype.
2165 * frame.c (x_set_line_spacing): Accept a float value for
2166 line-spacing parameter, per the documentation.
2168 * data.c (Fmultibyte_string_p): Doc fix.
2170 2013-07-05 Paul Eggert <eggert@cs.ucla.edu>
2172 Use emacs_open more consistently when opening files.
2173 This handles EINTR more consistently now, and makes it easier
2174 to introduce other uniform changes to file descriptor handling.
2175 * src/systdio.h: New file.
2176 * src/buffer.c (mmap_init):
2177 * cygw32.c (chdir_to_default_directory):
2178 * dispnew.c (Fopen_termscript):
2179 * emacs.c (Fdaemon_initialized):
2180 * fileio.c (Fdo_auto_save):
2181 * image.c (slurp_file, png_load_body, jpeg_load_body):
2182 * keyboard.c (Fopen_dribble_file):
2184 * print.c (Fredirect_debugging_output):
2185 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
2186 * termcap.c (tgetent):
2187 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
2188 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
2189 * w32term.c (w32_initialize) [CYGWIN]:
2190 * xfaces.c (Fx_load_color_file):
2191 Use emacs_open instead of plain open, and emacs_fopen instead of
2193 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
2194 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
2195 * callproc.c (default_output_mode): New constant.
2196 (Fcall_process): Use it to call emacs_open instead of plain creat.
2197 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
2198 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
2199 (emacs_fopen): New function.
2200 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
2201 Include <lisp.h>, for emacs_open.
2202 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
2204 Remove duplicate #include directives.
2205 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
2207 Don't include stdio.h twice.
2208 * buffer.c [USE_MMAP_FOR_BUFFERS]:
2209 Don't include sys/types.h or stdio.h twice.
2210 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
2211 * lread.c: Don't include coding.h twice.
2212 * nsfont.m: Don't include frame.h twice.
2213 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
2214 * ralloc.c: Don't include <unistd.h> twice.
2215 * xdisp.c: Don't include font.h twice.
2216 * xterm.c: Don't include fontset.h twice.
2217 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
2219 2013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2221 Scale ImageMagick images more carefully.
2222 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
2223 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
2224 Be more careful about avoiding undefined behavior after
2225 integer overflow and division by zero.
2227 2013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2229 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
2230 (syms_of_w32fns): DEFSYM them.
2231 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
2232 (CCHDEVICENAME): Define macros if not defined.
2233 (struct MONITOR_INFO_EX): New struct.
2234 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
2235 (enum_display_monitors_fn): New variable.
2236 (globals_of_w32fns): Initialize it.
2237 (Fx_display_pixel_width, Fx_display_pixel_height)
2238 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
2239 multi-monitor setups in docstrings.
2240 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
2241 screen size by primary monitor's millimeter per pixel.
2242 (w32_monitor_enum, w32_display_monitor_attributes_list)
2243 (w32_display_monitor_attributes_list_fallback)
2244 (Fw32_display_monitor_attributes_list): New functions.
2245 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
2247 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
2249 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
2251 2013-07-04 Michael Albinus <michael.albinus@gmx.de>
2253 * fileio.c (Qfile_notify_error): New error symbol.
2255 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
2256 * inotify.c (inotify_callback, symbol_to_inotifymask)
2257 (Finotify_add_watch, Finotify_rm_watch): Use it.
2258 (inotifyevent_to_event): Exchange order of cookie and file name.
2259 (Finotify_add_watch): Adapt docstring.
2261 * lisp.h (Qfile_notify_error): Declare.
2263 2013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2265 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
2266 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2267 Do not clear _malloc_thread_enabled_p, undoing the previous change,
2268 which did not work (see <http://bugs.gnu.org/14569#307>).
2269 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
2270 && (!noninteractive || initialized)). This attempts to thread
2271 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
2273 2013-07-04 Juanma Barranquero <lekktu@gmail.com>
2275 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
2276 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
2278 2013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2280 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
2281 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2282 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
2283 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
2285 2013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2287 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
2288 Define to __sys_siglist.
2290 2013-07-02 Eli Zaretskii <eliz@gnu.org>
2292 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
2293 word-wrap, so that overflow-newline-into-fringe would work in
2294 visual-line-mode. (Bug#2749)
2295 (move_it_in_display_line_to): When the last scanned display
2296 element fits exactly on the display line, and
2297 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
2298 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
2299 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
2300 finding buffer position that corresponds to pixel coordinates,
2301 e.g. in buffer_posn_from_coords.
2303 2013-07-02 Jan Djärv <jan.h.d@swipnet.se>
2305 * process.c (handle_child_signal): Call catch_child_signal if
2308 2013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2310 Don't convert function pointers to void * and back.
2311 It isn't portable C, and it's easy enough to avoid.
2312 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
2313 (make_save_value): Add support for SAVE_FUNCPOINTER.
2314 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
2315 * print.c (print_object):
2316 Distinguish function from object pointers.
2317 * lisp.h (SAVE_FUNCPOINTER): New constant.
2318 (SAVE_SLOT_BITS): Adjust to it.
2319 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
2320 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
2321 (voidfuncptr): New typedef.
2322 (struct Lisp_Save_Value): New member data[0].funcpointer.
2323 (XSAVE_FUNCPOINTER): New function.
2325 Simplify buildobj processing.
2326 * Makefile.in (buildobj.h): Make it a sequence of strings each
2327 followed by comma, rather than a single string. Put it into a
2328 .tmp file in case there's an error while generating it.
2329 (gl-stamp): Use .tmp for temp files.
2330 (mostlyclean): Clean .tmp files.
2331 * doc.c (buildobj): Move to just the routine that needs it.
2332 It's now an array of strings, so processing is simpler.
2334 2013-07-01 Paul Eggert <eggert@cs.ucla.edu>
2336 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
2337 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
2338 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2339 Invoke malloc_enable_thread even when not interactive.
2340 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
2341 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
2342 in this case, since the underlying bug has now been fixed.
2344 2013-07-01 Juanma Barranquero <lekktu@gmail.com>
2346 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
2347 unlinking it (bug#14691).
2349 2013-06-30 Michal Nazarewicz <mina86@mina86.com>
2351 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
2352 before checking whether buffer is modified. This lets
2353 `kill-buffer-query-functions' cancel killing of the buffer or save
2354 its content before `kill-buffer' asks user the "Buffer %s
2355 modified; kill anyway?" question.
2357 2013-06-30 Jan Djärv <jan.h.d@swipnet.se>
2359 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
2360 Let the super performKeyEquivalent deal with them (Bug#14747).
2362 2013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2364 * widget.c (resize_cb): Remove unused local.
2366 Do not use GTK 3 if it exists but cannot be compiled.
2367 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2368 * xterm.c (x_error_handler) [!USE_GTK]:
2371 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
2373 2013-06-30 Eli Zaretskii <eliz@gnu.org>
2375 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2376 to the valid range of values. (Bug#14753)
2378 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
2379 when moving point by using the current glyph matrix. This avoids
2380 the need to force redisplay when this function is called in a
2383 2013-06-29 Paul Eggert <eggert@cs.ucla.edu>
2385 Fix minor problems found by static checking.
2386 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
2387 Redo the latter's body to sidestep GCC parenthesization warnings.
2388 (setup_coding_system, detect_coding, detect_coding_system): Use them.
2389 * coding.c (detect_coding, detect_coding_system):
2390 * coding.h (struct undecided_spec):
2391 Use bool for boolean.
2392 * image.c (QCmax_width, QCmax_height): Now static.
2393 * xdisp.c (Fmove_point_visually): Remove unused local.
2395 2013-06-29 Eli Zaretskii <eliz@gnu.org>
2397 * xdisp.c (Fmove_point_visually): New function.
2399 2013-06-28 Kenichi Handa <handa@gnu.org>
2401 * coding.h (define_coding_undecided_arg_index): New enum.
2402 (coding_attr_index): New members
2403 coding_attr_undecided_inhibit_null_byte_detection,
2404 coding_attr_undecided_inhibit_iso_escape_detection,
2405 coding_attr_undecided_prefer_utf_8.
2406 (undecided_spec): New struct.
2407 (struct coding_system): New member `undecided' of the member
2410 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
2411 (detect_coding): Likewise.
2412 (detect_coding_system): Likewise.
2413 (Fdefine_coding_system_internal): New coding system properties
2414 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
2416 (syms_of_coding): Adjust for coding_arg_undecided_max.
2418 2013-06-28 Paul Eggert <eggert@cs.ucla.edu>
2420 * image.c (x_from_xcolors): Remove unused local.
2422 2013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2424 Defer image data transfer between X client and server until actual
2427 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
2430 * image.c (Destroy_Image): Remove.
2431 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
2432 `mask_p', and `colors_p'. All uses changed.
2433 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
2434 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
2435 New macros for `flags' arg to x_clear_image_1.
2436 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
2437 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
2438 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
2439 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2440 (image_get_x_image, image_unget_x_image): New functions or macros.
2441 (image_background, image_background_transparent, x_to_xcolors)
2442 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2443 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2444 instead of Destroy_Image.
2445 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2446 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2447 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2448 (imagemagick_load_image, svg_load_image): Use them instead of
2449 x_create_x_image_and_pixmap, and x_put_x_image followed by
2450 x_destroy_x_image, respectively.
2451 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2452 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2453 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2454 background_transparent fields.
2455 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2456 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2458 2013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2460 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2461 This mostly consists of undoing recent changes.
2462 * callproc.c (Fcall_process):
2463 * process.c (create_process):
2464 Do not worry about catching SIGCHLD here, undoing previous change.
2465 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
2466 * process.c, process.h (catch_child_signal):
2467 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
2468 * process.c (catch_child_handler): Don't worry about being called
2469 lazily and do not assume caller has blocked SIGCHLD, undoing
2470 previous change. Move first-time stuff back to
2471 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
2472 tickle glib, as that causes Cygwin bootstrap to fail. Do not
2473 set lib_child_handler if it's already initialized, which may
2474 help avoid problems on GNUStep.
2476 2013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2478 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2479 * callproc.c (Fcall_process):
2480 * process.c (create_process):
2481 Make sure SIGCHLD is caught before we fork,
2482 since Emacs startup no arranges to catch SIGCHLD.
2483 * process.c (lib_child_handler): Initialize to null, not to
2485 (catch_child_signal): Allow self to be called lazily.
2486 Do nothing if it's already been called.
2487 Assume caller has blocked SIGCHLD (all callers do now).
2488 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2489 just before it's really needed.
2490 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2491 since it hasn't been caught yet.
2493 2013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2495 * image.c (compute_image_size): New function to implement
2496 :max-width and :max-height.
2497 (imagemagick_load_image): Use it.
2499 2013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2501 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2502 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2504 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2505 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2506 the SIGCHLD handler, since the code is not atomic and (due to glib)
2507 signals may be arriving now.
2508 * sysdep.c (init_signals): Do not catch child signals here;
2509 'main' now does that later, at a safer time.
2511 2013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2513 Clean up SIGCHLD handling a bit (Bug#14569).
2514 * process.c, process.h (catch_child_signal):
2515 Now always extern, even if !NS_IMPL_GNUSTEP.
2516 * process.c (catch_child_signal): Move glib tickler here from
2517 init_process_emacs, so that it's done earlier in Emacs
2518 initialization. Also move the noninteractive && !initialized
2519 check here from init_process_emacs. This is all a bit cleaner for
2520 GNUish platforms, and I hope it works around the Cygwin bug.
2521 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2522 that glib signal handling is tickled before glib creates threads.
2524 * process.c (wait_reading_process_output): Avoid int overflow
2525 when reading more than 2 GiB total from a process.
2527 2013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2529 * process.c (create_process): Handle a couple more cases,
2530 i.e., work even if new_argv and wait_child_setup[i] are cached.
2531 Use Fcall_process's style for volatile vars.
2533 2013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2535 * process.c (create_process): Mark PROCESS volatile.
2537 2013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2539 Use C99-style flexible array members if available.
2540 This avoids some subtle aliasing issues, which typically
2541 aren't a problem with GCC but may be a problem elsewhere.
2542 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2543 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2544 In either case, it uses a flexible array member rather than
2545 the old struct hack. All uses changed.
2546 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2547 Adjust to sdata reorganization.
2548 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2549 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2550 that ports better to pre-C99 non-GCC.
2551 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2552 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2553 as the latter has changed.
2554 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2555 and port better to pre-C99 GCC.
2556 * image.c (struct xpm_cached_color):
2557 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2558 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2559 Use FLEXIBLE_ARRAY_MEMBER.
2560 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2561 Move decl to top level so it gets checked against implementation.
2562 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2563 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2565 2013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2567 * syntax.c: Integer cleanups.
2568 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2569 All uses that need 0-or-2 changed to:
2570 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2571 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2572 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2573 (char_quoted, prev_char_comend_first, back_comment)
2574 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2575 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2576 Use bool for boolean.
2577 (update_syntax_table, skip_chars, skip_syntaxes):
2578 Prefer int to unsigned when either will do.
2579 (back_comment): Return boolean success flag, like forw_comment,
2580 instead of positive-or-minus-1 (which might have overflowed int anyway).
2581 Don't stuff ptrdiff_t into int.
2582 (syntax_spec_code, syntax_code_spec): Now const.
2583 (Fmatching_paren, scan_lists, scan_sexps_forward):
2584 Use enum syntaxcode for syntax code.
2585 (Fmatching_paren): Check that arg is a character, not just an integer.
2586 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2587 (Finternal_describe_syntax_value): Omit no-longer-needed
2589 (skip_chars): Use char, not unsigned char, when the distinction
2591 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2592 * bytecode.c (exec_byte_code):
2593 * syntax.c (syntax_spec_code, Fchar_syntax)
2594 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2596 * syntax.h (SYNTAX_WITH_FLAGS):
2597 Omit unnecessary casts.
2599 2013-06-20 Eli Zaretskii <eliz@gnu.org>
2601 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2602 line dimensions here, to avoid race conditions with the main
2603 thread. (Bug#14062, bug#14630, bug#14669)
2605 * w32term.c (w32_draw_window_cursor): Compute the header line and
2606 mode line dimensions here.
2607 <w32_system_caret_window, w32_system_caret_hdr_height>:
2608 <w32_system_caret_mode_height>: New variables.
2610 * w32term.h: Declare them.
2612 2013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2614 * alloc.c (die): Move "assertion failed" string here ...
2615 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2616 COND when SUPPRESS_CHECKING. This shrinks the executable text
2617 size by 0.8% to 2.2% when configured with --enable-checking,
2618 depending on optimization flags (GCC 4.8.1 x86-64).
2620 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2622 2013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
2624 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2625 base is 2; this is more accurate.
2627 2013-06-19 Juanma Barranquero <lekktu@gmail.com>
2629 * sound.c (string_default): Move to !WINDOWSNT section.
2630 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2632 2013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2634 * sound.c: Integer cleanups.
2635 Remove unnecessary forward decls.
2636 (struct sound_device): The 'file' member is now a Lisp_Object, not
2637 a char *, so that we needn't invoke alloca on a huge size.
2638 (Fplay_sound_internal): Adjust to this.
2639 (string_default): New function.
2640 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2641 Use it to adjust to the struct sound_device change.
2642 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2643 (be2hs) [0]: Remove.
2645 * syntax.c (skip_chars): Don't use uninitialized storage
2646 when searching a multibyte buffer for characters that are not in a
2647 unibyte string that contains non-ASCII characters.
2649 2013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2651 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2652 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2654 2013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2656 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
2658 2013-06-18 Kenichi Handa <handa@gnu.org>
2660 * font.c (Ffont_spec): Signal an error for an invalid font name
2663 2013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2665 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
2666 In particular this ports to 32-bit sparc Sun cc.
2667 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
2668 array with a dummy element at specpdl[-1], so that its address can
2670 (unbind_to): Do not copy the binding; not needed, now that we
2671 copy old_value in the one place where the copy is needed.
2672 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
2673 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
2674 (union specbinding): Rename from struct specbinding. Redo layout
2675 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
2676 which is not portable. With Sun C 5.12 32-bit sparc, the
2677 declaration causes nargs to be an unsigned bitfield, a behavior
2678 that the C standard allows; but Emacs wants nargs to be signed.
2679 The overall type is now a union of structures rather than a
2680 structure of union of structures, and the 'kind' member is now a
2681 bitfield, so that the overall type doesn't grow. All uses changed.
2682 * process.c (Fmake_serial_process): Remove unnecessary initialization.
2684 2013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2686 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
2687 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
2689 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
2691 2013-06-17 Eli Zaretskii <eliz@gnu.org>
2693 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2694 unless we know that the window w's frame is a frame object.
2695 Another attempt at solving bug#14062 and bug#14630.
2697 2013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
2699 * textprop.c (property_set_type): New enum.
2700 (add_properties): Allow appending/prepending text properties.
2701 (add_text_properties_1): Factored out of Fadd_text_properties.
2702 (Fadd_text_properties): Move all the code into
2703 add_text_properties_1.
2704 (Fadd_face_text_property): New function that calls
2705 add_text_properties_1.
2707 2013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2709 Move functions from lisp.h to individual modules when possible.
2710 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
2711 * alloc.c (XFLOAT_INIT, set_symbol_name):
2712 * buffer.c (CHECK_OVERLAY):
2713 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
2714 (set_char_table_parent):
2715 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2716 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2717 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2718 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2720 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
2721 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
2722 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
2723 (backtrace_args, backtrace_debug_on_exit):
2724 * floatfns.c (CHECK_FLOAT):
2725 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
2726 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
2727 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2728 (set_hash_index_slot):
2729 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2730 * marker.c (CHECK_MARKER):
2731 * textprop.c (CHECK_STRING_OR_BUFFER):
2732 * window.c (CHECK_WINDOW_CONFIGURATION):
2733 Move here from lisp.h, and make these functions static rather than
2735 * buffer.c (Qoverlayp):
2737 * fns.c (Qhash_table_p):
2738 * window.c (Qwindow_configuration_p):
2740 * lisp.h: Remove the abovementioned defns and decls.
2742 Use functions, not macros, for XINT etc (Bug#11935).
2743 In lisp.h, prefer functions to function-like macros, and
2744 constants to object-like macros, when either will do. This:
2745 . simplifies use, as there's no more need to worry about
2746 arguments' side effects being evaluated multiple times.
2747 . makes the code easier to debug on some platforms.
2748 However, when using gcc -O0, keep using function-like macros
2749 for a few critical operations, for performance reasons.
2750 This sort of thing isn't needed with gcc -Og, but -Og
2751 is a GCC 4.8 feature and isn't widely-enough available yet.
2752 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2753 Remove enum lsb_bits; no longer needed.
2754 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2755 * buffer.c (Qoverlap):
2757 * fns.c (Qhash_table_p):
2758 Now extern, so lisp.h can use these symbols.
2759 * dispextern.h: Include character.h, for MAX_CHAR etc.
2760 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2761 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2762 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2763 (GLYPH_CODE_P): Move here from lisp.h.
2764 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2765 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
2766 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
2767 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
2768 XUNTAG now returns void *.
2769 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
2770 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
2771 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
2772 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
2773 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
2774 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
2775 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
2776 (lisp_h_XPNTR, lisp_h_XSYMBOL):
2777 New macros, renamed from their sans-lisp_h_ counterparts.
2778 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
2779 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
2780 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
2781 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
2782 If compiling via GCC without optimization, define these as macros
2783 in addition to inline functions.
2784 To disable this, compile with -DINLINING=0.
2785 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
2786 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
2787 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
2788 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
2789 (INTMASK, VALMASK): Now macros, since static values cannot be
2790 accessed from extern inline functions.
2791 (VALMASK): Also a constant, for benefit of old GDB.
2792 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
2793 is INTEGERP, which can fold it in.
2794 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
2795 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
2796 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
2797 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
2798 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
2799 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
2800 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
2801 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
2802 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
2803 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
2804 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
2805 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
2806 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
2807 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
2808 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
2809 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
2810 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
2811 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
2812 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
2813 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
2814 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
2815 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
2816 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
2817 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
2818 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
2819 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
2820 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
2821 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
2822 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
2823 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
2824 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
2825 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
2826 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
2828 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
2829 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
2830 (VALMASK): Define in one place rather than in two, merging the
2831 USE_LSB_TAG parts; this is simpler.
2832 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
2833 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
2834 Move up, to avoid use before definition.
2835 Also include "globals.h" earlier, for the same reason.
2836 (make_natnum): New function.
2837 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
2838 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
2839 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
2840 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
2841 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
2842 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
2843 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
2844 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
2845 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
2846 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
2847 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
2848 (Qwindow_configuration_p, Qimage): New forward declarations.
2849 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
2850 (STRING_COPYIN): Remove; unused.
2851 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
2852 (xcar_addr, xcdr_addr): New functions. All uses changed.
2853 (IEEE_FLOATING_POINT): Now a constant, not a macro.
2854 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2855 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
2856 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
2857 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
2858 (TYPE_RANGED_INTEGERP): Simplify.
2859 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
2860 (setlocale, fixup_locale, synchronize_system_messages_locale)
2861 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
2862 Now empty functions, not macros.
2863 (functionp): Return bool, not int.
2864 * window.c (Qwindow_configuration_p): Now extern,
2865 so window.h can use it.
2866 * window.h (Qwindowp): Move decl back to lisp.h.
2868 2013-06-15 Eli Zaretskii <eliz@gnu.org>
2870 * xdisp.c (Fline_pixel_height): New function, required for solving
2873 2013-06-15 Paul Eggert <eggert@cs.ucla.edu>
2875 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
2877 2013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
2879 * lread.c (syms_of_lread):
2880 * fns.c (Fprovide): Adjust to new format of after-load-alist.
2882 2013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
2884 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
2886 2013-06-12 Xue Fuqiao <xfq.free@gmail.com>
2888 * fileio.c (expand_file_name): Doc fix.
2890 2013-06-11 Paul Eggert <eggert@cs.ucla.edu>
2892 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
2893 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
2894 Wait for self, not for 0. This can't hurt on GNU or similar
2895 system, and may help with Cygwin.
2897 * keyboard.c: Don't use PROP (...) as an lvalue.
2898 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
2899 Use set_prop (A, B), not PROP (A) = B.
2901 2013-06-10 Eli Zaretskii <eliz@gnu.org>
2903 * xdisp.c (get_it_property): Use it->window instead of generating
2904 a Lisp object from it->w.
2906 2013-06-09 Eli Zaretskii <eliz@gnu.org>
2908 * xdisp.c (get_it_property): If it->object is a buffer, pass to
2909 get-char-property the window that is being rendered, instead of
2910 the buffer, to support window-specific overlays. (Bug#14575)
2911 (compute_display_string_pos): When W is NULL, use the current
2912 buffer as the object to pass to get-char-property.
2913 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
2914 pointer member of the bidi iterator, since no window is pertinent
2917 2013-06-08 Eli Zaretskii <eliz@gnu.org>
2919 * bidi.c (bidi_fetch_char): Accept additional argument, the window
2920 being displayed, and pass it to compute_display_string_pos.
2921 (bidi_level_of_next_char, bidi_resolve_explicit_1)
2922 (bidi_paragraph_init): All callers changed.
2924 * xdisp.c (init_from_display_pos, init_iterator)
2925 (handle_single_display_spec, next_overlay_string)
2926 (get_overlay_strings_1, reseat_1, reseat_to_string)
2927 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
2928 Set bidi_it.w member from it->w.
2929 (compute_display_string_pos): Accept additional argument, the
2930 window being displayed, and pass it to Fget_char_property.
2933 * dispextern.h (struct bidi_it): New member w, the window being
2935 (compute_display_string_pos): Adjust prototype.
2937 2013-06-08 Jan Djärv <jan.h.d@swipnet.se>
2939 * xgselect.c: Remove unneeded include xterm.h.
2941 * process.c (wait_reading_process_output): Check for NS before GLIB.
2942 GLIB may be linked in due to rsvg, but ns_select must be called.
2944 * xgselect.c (xg_select): Remove call to window_system_available
2945 and g_main_context_pending at the top, so Gdk events (i.e. file
2946 notify) are processed when Emacs is started with -nw.
2948 2013-06-07 Eli Zaretskii <eliz@gnu.org>
2950 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
2951 (ctagsfiles3): New variable, includes only *.m files.
2952 (TAGS): Use an explicit language name in the regular expressions,
2953 to avoid transformation of '/SOMETHING' by MSYS to
2954 'c:\MSYS\SOMETHING'.
2956 2013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
2958 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
2960 2013-06-06 Eli Zaretskii <eliz@gnu.org>
2962 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
2963 still need to set the mouse pointer shape and activate help-echo.
2966 2013-06-06 Paul Eggert <eggert@cs.ucla.edu>
2968 A few porting etc. fixes for the new file monitor code.
2969 See the thread containing
2970 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
2971 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
2972 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
2973 (dir_monitor_callback, Fgfile_rm_watch):
2974 Use assq_no_quit instead of Fassoc, for speed.
2975 (dir_monitor_callback, Fgfile_rm_watch):
2976 eassert that the monitor is a fixnum.
2977 (dir_monitor_callback): No need for CDR_SAFE.
2978 Simplify building of lisp with alternative tails.
2979 (Fgfile_add_watch, Fgfile_rm_watch):
2980 Do not assume glib functions set errno reliably on failure.
2981 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
2982 and signal an error otherwise.
2983 (Fgfile_rm_watch): Prefer CONSP to !NILP.
2984 Use Fdelq instead of Fdelete, for speed.
2986 2013-06-05 Eli Zaretskii <eliz@gnu.org>
2988 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
2989 don't insist on being invoked on a highlighted tool-bar button.
2990 Avoids losing tool-bar functionality when mouse-highlight is nil.
2991 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
2992 Don't highlight when mouse-highlight is nil.
2993 (note_mouse_highlight): When mouse-highlight is nil, don't return
2994 right away; instead, run tool-bar and mode-line highlight
2995 subroutine, clear any existing highlight, and revert the mouse
2996 pointer to its default shape. (Bug#14558)
2998 2013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3000 * lisp.mk (lisp): Add prog-mode.el.
3002 2013-06-05 Paul Eggert <eggert@cs.ucla.edu>
3004 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
3005 * process.c (dummy_handler): New function.
3006 (lib_child_handler): New static var.
3007 (handle_child_signal): Invoke it.
3008 (catch_child_signal): If a library has set up a signal handler,
3009 save it into lib_child_handler.
3010 (init_process_emacs): If using glib and not on Windows, tickle glib's
3011 child-handling code so that it initializes its private SIGCHLD handler.
3012 * syssignal.h (SA_SIGINFO): Default to 0.
3013 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
3014 31; it should no longer be needed now.
3016 2013-06-05 Michael Albinus <michael.albinus@gmx.de>
3018 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
3020 * gfilenotify.c (globals_of_gfilenotify): New function.
3021 (syms_of_gfilenotify): Move global initialization there.
3023 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
3025 2013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3027 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
3028 * keyboard.c (menu_bar_items, tool_bar_items):
3029 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
3030 not override local keymaps any more.
3032 2013-06-04 Eli Zaretskii <eliz@gnu.org>
3034 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
3036 2013-06-03 Eli Zaretskii <eliz@gnu.org>
3038 * w32console.c (initialize_w32_display): Return the dimensions of
3039 the console window via 2 additional arguments, not via the current
3040 frame. This avoids crashes due to overrunning the bounds of
3041 frame's decode_mode_spec_buffer, which is not resized following
3042 the change of the frame dimensions from the initial 10x10.
3044 * w32term.h (w32_initialize_display_info): Adjust prototype.
3046 * term.c (init_tty): Take dimensions of the frame from the values
3047 returned by initialize_w32_display.
3049 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
3050 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
3051 (LIBES): Add $(GFILENOTIFY_LIBS).
3053 * w32inevt.c (handle_file_notifications): Add dummy implementation
3054 for !HAVE_W32NOTIFY.
3056 * w32term.c: Wrap code with HAVE_W32NOTIFY.
3058 2013-06-03 Jan Djärv <jan.h.d@swipnet.se>
3060 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
3062 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
3064 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
3066 2013-06-03 Paul Eggert <eggert@cs.ucla.edu>
3068 Fix minor problems found by static checking.
3069 * data.c (pure_write_error):
3070 Use xsignal2, not Fsignal, as Fsignal might return.
3071 * eval.c (set_backtrace_debug_on_exit): Now static.
3072 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
3073 No longer inline. EXTERN_INLINE is needed only for functions
3074 defined in .h files. Reindent function header as per GNU style.
3075 (backtrace_p, backtrace_top, backtrace_next):
3076 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
3077 compiler or linker. Add extern decls to pacify gcc -Wall.
3078 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3080 * frame.c (free_monitors): Define only on platforms that need it.
3081 * nsterm.m (ns_term_init):
3082 * process.c (catch_child_signal):
3083 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
3084 defined on all porting targets these days.
3085 * process.c, process.h (catch_child_signal):
3086 Make it extern only if NS_IMPL_GNUSTEP is defined.
3088 2013-06-03 Eli Zaretskii <eliz@gnu.org>
3090 * w32.c (gettimeofday): Make the signature identical to prototype
3091 in nt/inc/sys/time.h.
3093 2013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3095 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
3098 * keyboard.c (safe_run_hooks_error): Improve error message.
3100 * data.c (pure_write_error): Add `object' argument.
3101 * puresize.h (CHECK_IMPURE): Use it.
3103 2013-06-03 Michael Albinus <michael.albinus@gmx.de>
3105 * Makefile.in (NOTIFY_OBJ): New variable.
3106 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
3108 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
3109 Call syms_of_gfilenotify.
3111 * gfilenotify.c: New file.
3113 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
3114 and Qfile_w32notify.
3115 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
3116 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
3118 * lisp.h: Declare syms_of_gfilenotify.
3120 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
3122 2013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3124 Merge the specpdl and backtrace stacks. Make the structure of the
3125 specpdl entries more obvious via a tagged union of structs.
3126 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
3127 (enum specbind_tag): New enum.
3128 (struct specbinding): Make it a tagged union of structs.
3129 Add a case for backtrace records.
3130 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
3131 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
3132 (backtrace_debug_on_exit): New accessors.
3133 (struct backtrace): Remove.
3134 (struct catchtag): Remove backlist field.
3135 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3137 (Flocal_variable_p): Speed up the common case where the binding is
3139 * eval.c (backtrace_list): Remove.
3140 (set_specpdl_symbol, set_specpdl_old_value): Remove.
3141 (set_backtrace_args, set_backtrace_nargs)
3142 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
3143 (backtrace_next): New functions.
3144 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
3145 (unwind_to_catch, internal_lisp_condition_case)
3146 (internal_condition_case, internal_condition_case_1)
3147 (internal_condition_case_2, internal_condition_case_n): Don't bother
3148 with backtrace_list any more.
3149 (Fsignal): Adjust to new backtrace format.
3150 (grow_specpdl): Move up.
3151 (record_in_backtrace): New function.
3152 (eval_sub, Ffuncall): Use it.
3153 (apply_lambda): Adjust to new backtrace format.
3154 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
3156 (specbind): Adjust to new specpdl format. Simplify.
3157 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
3158 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
3160 (mark_backtrace): Remove.
3161 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
3162 * xdisp.c (redisplay_internal): Use record_in_backtrace.
3163 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
3165 * profiler.c (record_backtrace): Use get_backtrace.
3166 (handle_profiler_signal): Use backtrace_top_function.
3167 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
3170 2013-06-02 Jan Djärv <jan.h.d@swipnet.se>
3172 * process.h (catch_child_signal): Declare.
3174 * process.c (catch_child_signal): New function.
3175 (init_process_emacs): Call it.
3177 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
3178 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
3180 (x_set_cursor_type): Remove declaration.
3181 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
3182 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
3183 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
3184 (ns_get_color): Use F suffix on float.
3185 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
3186 (ns_get_rgb_color): Remove.
3187 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
3188 (note_mouse_movement): x and y are CGFloat.
3189 (ns_draw_fringe_bitmap): Remove unused rowY.
3190 Change #if to COCOA && >= 10_6.
3191 (ns_draw_window_cursor): Remove unused overspill.
3192 (ns_draw_underwave): width and x are EamcsCGFloat.
3193 (ns_draw_box): thickness is CGFloat.
3194 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
3195 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
3196 if not in main thread.
3197 (ns_get_pending_menu_title, ns_check_menu_open)
3198 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
3199 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
3200 (sendFromMainThread:): New method.
3201 (changeFont:): size is CGFloat.
3202 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
3203 Disable warning about permanent text.
3204 (characterIndexForPoint:): Adjust return type depending on GNUStep
3206 (mouseDown:): delta is CGFloat.
3207 (updateFrameSize): Remove unised variable f.
3208 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
3209 Cast float to EmacsCGFloat.
3210 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
3211 also to -1 when restoring.
3212 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
3213 inside NS_IMPL_COCOA.
3214 (toggleFullScreen:): Put call to toggleFullScreen inside
3215 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
3216 (setPosition:portion:whole:): por is CGFloat.
3217 (getMouseMotionPart:window:x:y:): Add F suffix to float.
3218 (mouseDown:): Use CGFloat.
3219 (mouseDragged:): Remove unised variable edge.
3220 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
3222 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
3224 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
3225 when NS_IMPL_GNUSTEP.
3226 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
3227 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
3228 (EmacsToolbar): Add clearAll. Add tag argument to
3229 addDisplayItemWithImage.
3230 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
3232 * nsselect.m (ns_get_local_selection): Remove unused variable type.
3234 * nsmenu.m (ns_update_menubar): Make static.
3235 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
3236 (fillWithWidgetValue:): Add cast to SEL for setAction.
3237 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
3238 (update_frame_tool_bar): Update code for GNUStep.
3239 (clearAll): New method.
3240 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
3241 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
3242 Move identifierToItem setObject and activeIdentifiers addObject before
3243 call to insertItemWithItemIdentifier.
3244 (validateVisibleItems): Fix indentation.
3245 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
3246 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
3247 UtilityWindow to aStyle, remove call to setStyleMask.
3249 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
3251 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
3252 (ns_charset_covers, ns_get_covering_families, nsfont_open):
3253 Use F suffix on floats.
3254 (ns_char_width): Returns CGFloat.
3255 (ns_ascii_average_width): w is CGFloat instead of float.
3256 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
3258 (ns_glyph_metrics): CGFloat instead of float.
3260 * nsfns.m (x_set_foreground_color, x_set_background_color):
3262 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
3263 remove unused variables.
3264 (Fns_read_file_name): Keep track if panel is for save.
3265 Use ns_filename_from_panel/ns_directory_from_panel.
3266 (Fns_list_services): delegate only used for COCOA.
3267 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
3268 Just return the input if GNUStep.
3269 (x_screen_planes): Remove.
3270 (Fxw_color_values): Use EmacsCGFloat
3271 (Fns_display_monitor_attributes_list): Only get screen number for
3273 (getDirectory, getFilename): Remove from EmacsOpenPanel and
3275 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
3276 ns_directory_from_panel.
3278 2013-06-01 Paul Eggert <eggert@cs.ucla.edu>
3280 * process.c (handle_child_signal): Also use WCONTINUED.
3281 This is so that list-processes doesn't mistakenly list the process
3282 as stopped, when the process has actually been continued and is
3285 2013-05-31 Paul Eggert <eggert@cs.ucla.edu>
3287 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
3288 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
3289 not already configured.
3291 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
3293 2013-05-29 Eli Zaretskii <eliz@gnu.org>
3295 * Makefile.in (mostlyclean): Remove *.res files.
3297 2013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
3299 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
3300 a buffer (bug#8447).
3302 2013-05-27 Eli Zaretskii <eliz@gnu.org>
3304 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
3305 display vector, and we backtrack, handle the case that the
3306 previous character position is also displayed from a display
3307 vector or covered by a display string or image. (Bug#14476)
3309 2013-05-25 Jan Djärv <jan.h.d@swipnet.se>
3311 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3312 (struct MonitorInfo, free_monitors): Remove.
3313 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
3314 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
3315 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3318 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3319 (struct MonitorInfo, free_monitors): Remove.
3320 (ns_screen_name): Make static.
3321 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
3322 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3325 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3326 (struct MonitorInfo): New struct.
3327 (free_monitors, make_monitor_attribute_list): Declare.
3329 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3331 (free_monitors, make_monitor_attribute_list): New functions.
3332 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
3335 2013-05-25 Xue Fuqiao <xfq.free@gmail.com>
3337 * callproc.c (call_process): Refine the doc string. (Bug#14045)
3339 2013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
3341 * keyboard.c: Apply keyboard decoding only to events that come directly
3342 from the tty, not from unread-command-events (bug#14368).
3343 (read_event_from_main_queue): New function, extracted from read_char).
3344 (read_decoded_char): Remove.
3345 (read_decoded_event_from_main_queue): New function to replace it.
3346 (read_char): Use it.
3347 (read_key_sequence): Use read_char rather than read_decoded_char.
3349 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
3351 2013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3353 * casetab.c (init_casetab_once): Fix last change (bug#14424).
3355 2013-05-22 Kenichi Handa <handa@gnu.org>
3357 The following changes are to fix the setting of
3358 buffer-file-coding-system on, for instance, C-x RET c unix RET
3359 _FILE_OF_DOS_EOL_TYPE_ RET.
3361 * coding.h (struct coding_system): New member detected_utf8_chars.
3363 * coding.c (detect_coding_utf_8): Count characters and check EOL
3364 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3366 (setup_coding_system): Do not initialize coding->head_ascii.
3367 (check_ascii): Do not set coding->eol_seen but update it. Do not
3368 call adjust_coding_eol_type here.
3369 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3370 If the eol-type of CODING is already specified, adjust the eol type
3371 of the found coding-system.
3372 (decode_coding_gap): Cancel previous change. Utilize the
3373 character numbers counted by detect_coding_utf_8. Fix detection
3376 2013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3378 * search.c (looking_at_1): Only set last_thing_searched if the match
3379 changed the match-data (bug#14281).
3381 2013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3383 * xdisp.c (reseat_at_previous_visible_line_start):
3384 Already declared in dispextern.h, so remove it here.
3385 (move_it_vertically_backward): Likewise.
3387 2013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3389 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
3390 (Fx_display_pixel_width, Fx_display_pixel_height)
3391 (Fx_display_mm_width, Fx_display_mm_height):
3392 Mention `display-monitor-attributes-list' in docstrings.
3394 * nsfns.m (ns_get_screen): Remove function. All uses removed.
3395 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
3396 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3397 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3398 (Fx_display_backing_store, Fx_display_visual_class)
3399 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3400 (Fx_display_grayscale_p, Fx_display_pixel_width)
3401 (Fx_display_pixel_height, Fx_display_planes)
3402 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3403 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3404 (Fx_display_mm_width, Fx_display_mm_height)
3405 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3406 height for all physical monitors as in X11.
3408 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3409 Return pixel width or height for all physical monitors as in X11.
3411 2013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3413 Port --enable-gcc-warnings to clang.
3414 * bytecode.c (exec_byte_code):
3416 Redo diagnostic pragmas to pacify clang, too.
3417 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3418 * editfns.c (Fencode_time):
3419 * fileio.c (file_accessible_directory_p):
3420 * font.c (font_unparse_xlfd):
3421 Use '&"string"[index]' instead of '"string" + (index)'.
3422 * undo.c (user_error): Remove; unused.
3424 2013-05-16 Eli Zaretskii <eliz@gnu.org>
3426 * insdel.c (insert_1_both): Document the arguments, instead of
3427 referring to insert_1, which no longer exists.
3429 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3430 some window, increment windows_or_buffers_changed, so that
3431 *Messages* display in that window is updated. (Bug#14408)
3433 * w32.c: Include epaths.h.
3434 (init_environment): Use cmdproxy.exe without leading directories.
3435 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3437 (gettimeofday): Adjust signature and return value to Posix
3440 * unexw32.c (open_output_file): Delete the existing emacs.exe
3441 before creating it, to break the hard link to the versioned
3444 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3445 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3446 (FIRSTFILE_OBJ): New variables.
3447 (W32_RES): Rename to EMACSRES. All users changed.
3448 (base_obj): Use $(CM_OBJ).
3449 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3450 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3451 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3452 $(W32_RES_LINK) before $(LIBES).
3453 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3455 2013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3457 * makefile.w32-in (DOC): Use just "DOC".
3459 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3461 * process.c: Export default filters and sentinels to Elisp.
3462 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3464 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3465 (Fset_process_sentinel, Fformat_network_address):
3466 Default to them instead of nil.
3467 (server_accept_connection): Sentinels can't be nil any more.
3468 (read_and_dispose_of_process_output): New function, extracted from
3469 read_process_output.
3470 (read_process_output): Use it; filters can't be nil.
3471 (Finternal_default_process_filter): New function, extracted from
3472 read_process_output.
3473 (exec_sentinel_unwind): Remove function.
3474 (exec_sentinel): Don't zilch sentinel while running.
3475 (status_notify): Sentinels can't be nil.
3476 (Finternal_default_process_sentinel): New function extracted from
3478 (setup_process_coding_systems): Default filter is not nil any more.
3479 (syms_of_process): Export new Elisp functions and initialize
3481 * lisp.h (make_lisp_proc): New function.
3483 2013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3485 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3487 2013-05-14 Eli Zaretskii <eliz@gnu.org>
3489 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
3490 unless we know that the window w is a leaf window.
3491 Another attempt at solving bug#14062.
3493 2013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3495 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3498 2013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3500 * image.c (gif_load): Check that subimages fit (Bug#14345).
3502 2013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3504 * lread.c (skip_dyn_eof): New function.
3505 (read1): Use it to skip the end of a file in response to #@00.
3507 * doc.c (get_doc_string): Slightly relax the sanity checking.
3509 2013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3511 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3512 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3513 (MonitorInfo): New struct.
3514 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3515 (Fns_display_monitor_attributes_list): New functions.
3516 (display-usable-bounds): Remove.
3517 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3520 2013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3522 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3523 (GTK_CHECK_VERSION): New macro, if not already defined.
3524 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3525 replaced by GTK_CHECK_VERSION.
3527 2013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3529 * xterm.h (GTK_PREREQ): New macro.
3530 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3531 to use this macro instead, for consistency and clarity.
3533 2013-05-08 Eli Zaretskii <eliz@gnu.org>
3535 * xdisp.c (row_for_charpos_p): New function, with code of
3536 cursor_row_p, but accepts an additional argument CHARPOS instead
3537 of using a hardcoded PT.
3538 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3539 (row_containing_pos): Call row_for_charpos_p instead of partially
3540 doing the same. Fixes cursor positioning under longlines-mode
3541 when longlines-show-effect includes more than one newline, when
3542 moving the cursor vertically up.
3544 2013-05-08 Juanma Barranquero <lekktu@gmail.com>
3546 * makefile.w32-in (ACL_H): New macro.
3547 ($(BLD)/fileio.$(O)): Update dependencies.
3549 2013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3551 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
3552 * Makefile.in (LIB_ACL): New macro.
3553 (LIBACL_LIBS): Remove.
3554 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3555 * fileio.c: Include <acl.h>.
3556 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3557 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3559 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3562 * unexelf.c: Don't assume ElfW (Half) fits in int.
3563 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3564 when dealing with ElfW (Half) values, since they can exceed 2**31
3565 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3566 (entry_address): Omit unused NUM arg. All uses changed.
3568 2013-05-07 Juri Linkov <juri@jurta.org>
3570 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3571 to the string converted from number with `Fnumber_to_string'.
3574 2013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3576 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3577 This fixes a problem introduced by my previous change.
3579 2013-05-07 Glenn Morris <rgm@gnu.org>
3581 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3583 2013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3585 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3587 2013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3589 Static checking by GCC 4.8.0.
3590 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3591 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3592 (x_get_monitor_attributes_fallback)
3593 (x_get_monitor_attributes_xinerama)
3594 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3595 Define only if USE_GTK.
3596 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3597 (x_get_monitor_attributes_fallback): Omit unused locals.
3598 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3599 Use double, not float, to avoid mixed-mode floating point arithmetic.
3601 2013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3602 Jan Djärv <jan.h.d@swipnet.se>
3604 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3605 (XINERAMA_CFLAGS): New macros.
3606 (ALL_CFLAGS, LIBES): Use them.
3608 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3609 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3610 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3611 (syms_of_xfns): DEFSYM them.
3612 (struct MonitorInfo): New struct.
3613 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3614 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3615 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3616 (x_get_monitor_attributes_xinerama): New functions.
3617 (Fx_display_monitor_attributes_list): New primitive.
3618 (syms_of_xfns): Defsubr it.
3620 * xterm.h (x_display_info): Add Xatom_net_workarea and
3621 Xatom_net_current_desktop.
3623 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3624 and dpyinfo->Xatom_net_current_desktop.
3626 2013-05-06 Eli Zaretskii <eliz@gnu.org>
3628 * xdisp.c (pos_visible_p): Use the special code for finding the
3629 beginning of a display property or overlay for any "replacing"
3630 display property, not just for display strings. This solves
3631 incorrect reporting of position by posn-at-point. (Bug#14241)
3633 2013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3635 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3636 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3637 Verify that ElfW (Half) fits in int.
3638 (fatal): Use same signature as lisp.h.
3639 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3640 configure and build with -DUNEXELF_DEBUG without worrying about
3641 other modules that use DEBUG.
3642 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3643 possibly-wide integers now uses it instead of plain fprintf.
3644 (entry_address): New function, which avoids problems with 32-bit
3645 overflow on 64-bit hosts.
3646 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3647 (round_up): Don't assume the remainder fits in int.
3648 (find_section): Use bool for boolean. Simplify debug code.
3649 (unexec): Don't assume file sizes fit in int or size_t.
3650 Omit unnecessary trailing newline in 'fatal' format.
3651 Use strerror rather than outputting decimal error number.
3652 Remove unused code when emacs is not defined;
3653 this file relies on Emacs now.
3654 Don't assume e_phnum and e_shnum are positive.
3656 * regex.c: Fix problems when DEBUG is defined.
3657 (extract_number, extract_number_and_incr): Define regardless of
3658 whether DEBUG is defined; that's simpler and makes the code less
3659 likely to go stale in the normal case when DEBUG is not defined.
3660 Return int rather than taking an int * arg. All callers changed.
3661 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
3662 Remove, replacing with ...
3663 (DEBUG_PRINT): New macro. All callers changed.
3664 (DEBUG_COMPILES_ARGUMENTS): New macro.
3665 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
3666 (print_compiled_pattern, print_double_string) [DEBUG]:
3667 Use prototype rather than old-style definition.
3668 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
3669 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
3670 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
3671 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
3672 Don't assume ptrdiff_t, size_t, and long are the same width as int.
3673 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
3674 This matters only when DEBUG is defined.
3676 2013-05-05 Eli Zaretskii <eliz@gnu.org>
3678 * xdisp.c (set_iterator_to_next): Set the
3679 ignore_overlay_strings_at_pos_p flag only if we are _really_
3680 iterating over an overlay string, as indicated by the
3681 current.overlay_string_index member. (Bug#14306)
3683 2013-05-05 Jan Djärv <jan.h.d@swipnet.se>
3685 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
3686 to where it is used, to avoid autorelease issues (Bug#14050).
3688 2013-05-05 Paul Eggert <eggert@cs.ucla.edu>
3690 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
3691 * fileio.c (syms_of_fileio): Implement this.
3692 * filelock.c (create_lock_file): If symbolic links don't work, so
3693 we use a regular file as a lock file, do not fsync the lock file;
3696 2013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3698 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
3699 (syms_of_minibuf): Adjust accodingly.
3701 * callint.c (Fcall_interactively): Adjust calls accordingly.
3703 2013-05-04 Eli Zaretskii <eliz@gnu.org>
3705 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
3706 w->contents is a buffer before computing everything else.
3707 Use parentheses to disambiguate last part of the condition.
3709 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
3710 assertion violations. (Bug#14062)
3712 2013-05-01 David Reitter <david.reitter@gmail.com>
3714 * nsfns.m (ns_tooltip): Initialize.
3716 2013-04-28 Eli Zaretskii <eliz@gnu.org>
3718 * coding.c (decode_coding_gap): Don't remove the character before
3719 a newline unless it's a CR character. (Bug#14287)
3721 2013-04-28 Dan Nicolaescu <dann@gnu.org>
3723 * dispextern.h (struct face): Move enum face_underline_type
3724 earlier so that bitfields can be in the same word.
3726 2013-04-28 Jan Djärv <jan.h.d@swipnet.se>
3728 * nsfns.m (handlePanelKeys): New function.
3729 (EmacsOpenPanel:performKeyEquivalent:)
3730 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3731 arrows/function/control and copy/paste keys (Bug#14296).
3733 2013-04-27 Juri Linkov <juri@jurta.org>
3735 * callint.c (Fcall_interactively): Call `Qread_number' for
3736 interactive code letter `n' instead of using duplicate code.
3739 2013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3741 * systime.h (make_timeval): Declare as 'const'.
3743 2013-04-27 Kenichi Handa <handa@gnu.org>
3745 * font.c (font_open_entity): Always open a font of manageable
3748 2013-04-26 Paul Eggert <eggert@cs.ucla.edu>
3750 Port better to AIX (Bug#14258).
3751 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3754 2013-04-24 Kenichi Handa <handa@gnu.org>
3756 * coding.c (decode_coding_iso_2022): When an invalid escape
3757 sequence is encountered, reset the invocation and designation
3758 status to the safest one.
3760 2013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3762 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
3763 Without this fix, "make distclean" leaves stamp-h1 behind.
3765 2013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
3767 * w32fns.c (w32_fullscreen_rect): New function to compute the
3768 window rectangle for the given fullscreen mode.
3769 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
3770 longer tunes the window size. This keeps the window's edges flush
3771 with the screen and allows the taskbar to hide itself in fullboth.
3773 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
3774 window decorations and uses the entire screen.
3776 * w32term.h (w32_fullscreen_rect) Add prototype.
3777 (struct w32_output): Replace normal_width, normal_height,
3778 normal_top, and normal_left members with a single normal_placement
3780 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
3782 (FRAME_NORMAL_PLACEMENT): New macro.
3784 2013-04-16 Juanma Barranquero <lekktu@gmail.com>
3786 * minibuf.c (Ftest_completion): Silence compiler warning.
3788 2013-04-15 Eli Zaretskii <eliz@gnu.org>
3790 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
3793 * frame.h (WINDOW_FRAME): Protect macro and its argument with
3796 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
3797 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
3798 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
3799 parentheses where appropriate.
3801 2013-04-14 Paul Eggert <eggert@cs.ucla.edu>
3803 * keyboard.c (timer_start_idle): Remove no-longer-used local.
3805 2013-04-14 Eli Zaretskii <eliz@gnu.org>
3807 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
3808 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
3809 Mention in the doc string that setting these variables takes
3810 effect only after a call to set-window-buffer. (Bug#14200)
3812 2013-04-13 Eli Zaretskii <eliz@gnu.org>
3814 * indent.c (Fvertical_motion): Don't consider display strings on
3815 overlay strings as display strings on the buffer position we
3816 started from. This prevents vertical cursor motion from jumping
3817 more than one line when there's an overlay string with a display
3818 property at end of line.
3819 Reported by Karl Chen <Karl.Chen@quarl.org> in
3820 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
3822 2013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
3824 * window.c (select_window): `record_buffer' even if window is
3825 already selected (bug#14191).
3827 2013-04-11 Eli Zaretskii <eliz@gnu.org>
3829 * window.c (Fwindow_end): Test more flags, including the buffer's
3830 last_overlay_modified flag, to determine whether the window's
3831 display is really up-to-date. Prevents the function from
3832 returning a stale value. (Bug#14170)
3833 (Fwindow_line_height): Fix the test for up-to-date-ness of the
3836 2013-04-10 Eli Zaretskii <eliz@gnu.org>
3838 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
3839 garbaged only if it is not already the top frame on its TTY.
3840 This prevents flickering due to constant redrawing of TTY frames when
3841 there are GUI frames open in the same session. (Bug#13864)
3843 2013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
3845 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
3846 of marking the idle timers directly.
3848 2013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
3850 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
3853 2013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
3855 * window.c (select_window): Don't record_buffer while the invariant is
3856 temporarily broken (bug#14161).
3858 * fns.c (Fdelq): Don't assume !NILP => CONSP.
3860 2013-04-07 Eli Zaretskii <eliz@gnu.org>
3862 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
3864 2013-04-07 Romain Francoise <romain@orebokech.com>
3866 Ignore additional platform-specific ACL errors (Bug#13702).
3867 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
3868 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
3870 2013-03-31 Jan Djärv <jan.h.d@swipnet.se>
3872 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
3875 2013-04-07 Paul Eggert <eggert@cs.ucla.edu>
3877 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
3878 This bug was introduced by my 2013-02-25 change that simplified
3879 data_start configuration. Without this change, on GNU/Linux
3880 an Emacs configured with --enable-profiling fails immediately
3881 due to a profiler signal.
3882 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
3883 with these flags. On platforms where special flags are needed
3884 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
3885 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
3886 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
3888 2013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
3890 Get rid of some platform-specific functions examining window
3891 system and its capabilities. This is a partial rework of the
3893 * lisp.h (have_menus_p): Remove prototype. This function is
3894 replaced with platform-independent window_system_available.
3895 (check_window_system): Move to...
3896 * frame.h (decode_window_system_frame, window_system_available):
3897 ...here, add new prototypes.
3898 * frame.c (window_system_available, decode_window_system_frame):
3900 (check_window_system): Platform-independent now.
3901 * xterm.h (x_in_use): Remove declaration.
3903 * w32term.h (check_x_frame):
3904 * nsterm.h (check_x_frame): Remove prototypes. This function
3905 is replaced with platform-independent decode_window_system_frame.
3906 * msdos.c (have_menus_p): Remove.
3907 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
3908 Remove platform-specific functions. Use check_window_system,
3909 decode_window_system_frame and check_ns_display_info where
3910 appropriate. Minor style and comment tweaks.
3911 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
3912 (check_x_frame): Likewise.
3913 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
3915 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
3916 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
3917 * xmenu.c, xselect.c: All related users changed.
3919 2013-04-03 Kenichi Handa <handa@gnu.org>
3921 The following changes is to optimize the code for reading UTF-8
3924 * coding.c (check_ascii): Rename from detect_ascii. Return value
3925 changed. Check EOL format. Do not call adjust_coding_eol_type
3927 (check_utf_8): New function.
3928 (adjust_coding_eol_type): Do nothing if already adjusted.
3929 (detect_coding): Compare the return value of check_ascii with
3930 coding->src_bytes. Call adjust_coding_eol_type if necessary.
3931 (decode_coding_gap): Optimize for valid UTF-8.
3933 2013-03-21 Kenichi Handa <handa@gnu.org>
3935 * coding.c (syms_of_coding): Cancel previous change.
3937 * insdel.c (insert_from_gap): Fix previous change.
3939 2013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
3941 Consistently use platform-specific function to detect window system.
3942 * lisp.h (check_window_system): New prototype. This function is
3943 going to replace check_x, check_w32 and check_ns.
3944 (have_menus_p): Mention msdos.c in comment.
3945 * fontset.c (check_window_system_func): Remove. Adjust all users.
3946 * fontset.h (check_window_system_func): Remove prototype.
3947 * nsterm.h (check_ns):
3948 * xterm.h (check_x):
3949 * w32term.h (check_w32): Likewise.
3950 * menu.c (Fx_popup_menu): Use check_window_system.
3951 * msdos.c (check_window_system): Define for MS-DOS.
3952 * nsfns.m (check_window_system): Define for NS. Adjust all users.
3953 * w32fns.c (check_window_system): Likewise for MS-Windows.
3954 * xfns.c (check_window_system): Likewise for X.
3955 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
3956 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
3958 2013-04-02 Paul Eggert <eggert@cs.ucla.edu>
3960 Prefer < to > in range checks such as 0 <= i && i < N.
3961 This makes it easier to visualize quantities on a number line.
3962 This patch doesn't apply to all such range checks,
3963 only to the range checks affected by the 2013-03-24 change.
3964 This patch reverts most of the 2013-03-24 change.
3965 * alloc.c (xpalloc, Fgarbage_collect):
3966 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
3967 * character.c (string_escape_byte8):
3968 * charset.c (read_hex):
3969 * data.c (cons_to_unsigned):
3970 * dispnew.c (update_frame_1):
3971 * doc.c (Fsubstitute_command_keys):
3972 * doprnt.c (doprnt):
3973 * editfns.c (hi_time, decode_time_components):
3974 * fileio.c (file_offset):
3975 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
3976 * font.c (font_intern_prop):
3977 * frame.c (x_set_alpha):
3978 * gtkutil.c (get_utf8_string):
3979 * indent.c (check_display_width):
3980 * keymap.c (Fkey_description):
3981 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
3983 * minibuf.c (read_minibuf_noninteractive):
3984 * process.c (wait_reading_process_output):
3985 * search.c (Freplace_match):
3986 * window.c (get_phys_cursor_glyph):
3987 * xdisp.c (redisplay_internal):
3988 * xsmfns.c (smc_save_yourself_CB):
3989 Prefer < to > for range checks.
3990 * dispnew.c (sit_for): Don't mishandle NaNs.
3991 This fixes a bug introduced in the 2013-03-24 change.
3992 * editfns.c (decode_time_components): Don't hoist comparison.
3993 This fixes another bug introduced in the 2013-03-24 change.
3995 2013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
3997 * frame.h (struct frame): Drop scroll_bottom_vpos
3998 member becaue all real users are dead long ago.
3999 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
4000 * xdisp.c (redisplay_internal): Adjust user.
4002 2013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
4004 * nsmenu.m (showAtX:Y:for:): setLevel to
4005 NSPopUpMenuWindowLevel (Bug#13998).
4007 2013-03-30 Jan Djärv <jan.h.d@swipnet.se>
4009 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
4010 (ns_check_pending_open_menu): Declare.
4012 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
4013 (x_activate_menubar): Update the menu with title that matches
4014 ns_get_pending_menu_title, and call
4015 ns_check_pending_openmenu (Bug#12698).
4016 (menuWillOpen:): New method.
4017 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
4019 * nsterm.m (menu_will_open_state, menu_mouse_point)
4020 (menu_pending_title): New varaibles.
4021 (ns_get_pending_menu_title, ns_check_menu_open)
4022 (ns_check_pending_open_menu): New functions.
4024 2013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
4026 * indent.c (current_column_bol_cache): Remove leftover which is not
4027 used in Fmove_to_column any more.
4028 (current_column, scan_for_column): Adjust users.
4029 * keyboard.c (last_point_position_buffer, last_point_position_window):
4030 Remove leftovers which are not used for recording undo any more.
4031 (command_loop_1, syms_of_keyboard): Adjust users.
4032 * xdisp.c (last_max_ascent): Remove leftover which is not used in
4033 redisplay_window any more.
4034 (move_it_to): Adjust user.
4036 2013-03-29 Juanma Barranquero <lekktu@gmail.com>
4038 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
4039 Update dependencies.
4041 2013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4043 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
4044 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
4047 2013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4049 * window.h (struct window): Replace hchild, vchild and buffer slots
4050 with the only contents slot. This is possible because each valid
4051 window may have either the child window (in vertical or horizontal
4052 combination) or buffer to display (for the leaf window). Using that,
4053 a lof of operations to traverse and/or change window hierarchies may
4054 be simplified. New member horizontal is used to distinguish between
4055 horizontal and vertical combinations of internal windows.
4056 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
4057 (WINDOW_VERTICAL_COMBINATION_P): New macros.
4058 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
4059 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
4060 Use contents slot, not buffer, where appropriate.
4061 (wset_combination): New function.
4062 (wset_buffer): Add eassert.
4063 (Fframe_first_window): Simplify the loop reaching first window.
4064 (Fwindow_buffer): Use WINDOW_LEAF_P.
4065 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
4066 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
4067 (unshow_buffer): Convert initial debugging check to eassert.
4068 (replace_window, recombine_windows, Fdelete_other_windows_internal)
4069 (make_parent_window, window_resize_check, window_resize_apply)
4070 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
4071 (Fset_window_configuration, delete_all_child_windows, save_window_save):
4072 Adjust to match struct window changes.
4073 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
4074 (mark_window_cursors_off, count_windows, get_leaf_windows)
4075 (foreach_window_1): Simplify the loop.
4076 * alloc.c (mark_object): Do not check for the leaf window because
4077 internal windows has no glyph matrices anyway.
4078 * dispnew.c (clear_window_matrices, showing_window_margins_p)
4079 (allocate_matrices_for_window_redisplay, fake_current_matrices)
4080 (allocate_matrices_for_frame_redisplay, free_window_matrices)
4081 (build_frame_matrix_from_window_tree, mirror_make_current)
4082 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
4083 (update_window_tree, set_window_update_flags): Simplify the loop.
4084 (sync_window_with_frame_matrix_rows): Enforce live window.
4085 Use contents slot, not buffer, where appropriate.
4086 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
4087 and WINDOW_HORIZONTAL_COMBINATION_P.
4088 (make_frame_visible_1): Simplify the loop.
4089 Use contents slot, not buffer, where appropriate.
4090 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
4091 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
4092 (expose_window_tree): Likewise.
4093 Use contents slot, not buffer, where appropriate.
4094 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
4095 to avoid deleted windows. Use contents slot instead of buffer.
4096 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
4097 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
4098 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
4099 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
4101 2013-03-28 Eli Zaretskii <eliz@gnu.org>
4103 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
4104 identify the reasons for assertion violations in bug#14062 and
4106 (Fx_show_tip): Fix compilation error under
4107 "--enable-check-lisp-object-type". (Bug#14073)
4109 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
4110 Reported by <rzl24ozi@gmail.com>.
4112 2013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4114 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
4116 (unwind_with_echo_area_buffer): ...to restore it here.
4117 This is needed to ensure that...
4118 (redisplay_window): ...both window markers are valid here,
4119 which is verified by eassert.
4120 * editfns.c (save_excursion_save): Do not assume that
4121 selected_window always displays the buffer.
4122 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
4125 2013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
4127 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
4130 2013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
4132 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
4134 2013-03-27 Eli Zaretskii <eliz@gnu.org>
4136 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
4137 since MinGW's w32api headers do. This avoids compiler warnings.
4139 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
4142 2013-03-26 Eli Zaretskii <eliz@gnu.org>
4144 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
4146 2013-03-26 Jan Djärv <jan.h.d@swipnet.se>
4148 * gtkutil.c (style_changed_cb): Check if frame is live and an
4149 X frame (Bug#14038).
4151 2013-03-26 Eli Zaretskii <eliz@gnu.org>
4153 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
4154 Define only for _WIN32_WINNT less than 0x0500.
4155 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
4157 Move inclusion of time.h before sys/time.h, so that MinGW64 could
4158 see its own definitions of 'struct timeval' and 'struct timezone'.
4160 Fix incompatibilities between MinGW.org and MinGW64 headers.
4161 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
4163 * w32.c (REPARSE_DATA_BUFFER): Guard with
4164 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
4166 2013-03-25 Jan Djärv <jan.h.d@swipnet.se>
4168 * xterm.c: Include X11/XKBlib.h
4169 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
4171 2013-03-24 Andreas Schwab <schwab@linux-m68k.org>
4173 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
4175 * blockinput.h (input_blocked_p): Likewise.
4176 * bytecode.c (exec_byte_code): Likewise.
4177 * callproc.c (call_process_kill, call_process_cleanup)
4178 (Fcall_process): Likewise.
4179 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
4180 (Fccl_execute_on_string): Likewise.
4181 * character.c (string_escape_byte8): Likewise.
4182 * charset.c (read_hex): Likewise.
4183 * cm.c (calccost): Likewise.
4184 * data.c (cons_to_unsigned): Likewise.
4185 * dired.c (directory_files_internal, file_name_completion):
4187 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
4188 (sit_for): Likewise.
4189 * doc.c (Fsubstitute_command_keys): Likewise.
4190 * doprnt.c (doprnt): Likewise.
4191 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
4192 * emacsgtkfixed.c: Likewise.
4193 * fileio.c (file_offset, Fwrite_region): Likewise.
4194 * floatfns.c (Fexpt, fmod_float): Likewise.
4195 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4197 * font.c (font_intern_prop): Likewise.
4198 * frame.c (x_set_alpha): Likewise.
4199 * gtkutil.c (get_utf8_string): Likewise.
4200 * indent.c (check_display_width): Likewise.
4201 * intervals.c (create_root_interval, rotate_right, rotate_left)
4202 (split_interval_right, split_interval_left)
4203 (adjust_intervals_for_insertion, delete_node)
4204 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4205 (merge_interval_right, merge_interval_left, copy_intervals)
4206 (set_intervals_multibyte_1): Likewise.
4207 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
4208 * keymap.c (Fkey_description): Likewise.
4209 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
4210 * lread.c (openp, read_integer, read1, string_to_number):
4212 * menu.c (ensure_menu_items): Likewise.
4213 * minibuf.c (read_minibuf_noninteractive): Likewise.
4214 * print.c (printchar, strout): Likewise.
4215 * process.c (create_process, Faccept_process_output)
4216 (wait_reading_process_output, read_process_output, send_process)
4217 (wait_reading_process_output): Likewise.
4218 * profiler.c (make_log, handle_profiler_signal): Likewise.
4219 * regex.c (re_exec): Likewise.
4220 * regex.h: Likewise.
4221 * search.c (looking_at_1, Freplace_match): Likewise.
4222 * sysdep.c (get_child_status, procfs_ttyname)
4223 (procfs_get_total_memory): Likewise.
4224 * systime.h (EMACS_TIME_VALID_P): Likewise.
4225 * term.c (dissociate_if_controlling_tty): Likewise.
4226 * window.c (get_phys_cursor_glyph): Likewise.
4227 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
4228 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
4230 * xfns.c (Fx_window_property): Likewise.
4231 * xmenu.c (set_frame_menubar): Likewise.
4232 * xselect.c (x_get_window_property, x_handle_dnd_message):
4234 * xsmfns.c (smc_save_yourself_CB): Likewise.
4235 * xterm.c (x_scroll_bar_set_handle): Likewise.
4237 2013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
4239 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
4240 to be optional or nil. Adjust comment and convert it to docstring.
4241 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
4242 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
4244 2013-03-24 Paul Eggert <eggert@cs.ucla.edu>
4246 Static checking by GCC 4.8-20130319.
4247 * image.c (gif_load): Assume pass < 3 to pacify GCC.
4248 * process.c (Fset_process_datagram_address)
4249 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
4250 * xdisp.c (get_char_face_and_encoding):
4251 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
4252 (get_glyph_face_and_encoding): Prepare face before possibly using it.
4253 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
4255 2013-03-24 Ken Brown <kbrown@cornell.edu>
4257 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
4258 fix compilation on 64-bit Cygwin, where underscores are not
4259 automatically prepended.
4261 * w32term.c (w32_initialize): Silence compiler warning.
4263 2013-03-23 Eli Zaretskii <eliz@gnu.org>
4265 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
4266 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
4267 variables, to save and restore frame dimensions.
4268 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
4269 after returning from a 'fullscreen' configuration.
4270 use SendMessage instead of PostMessage to send the SC_RESTORE message,
4271 to avoid races between the main thread and the input thread.
4273 * w32term.h (struct w32_output): New members normal_width,
4274 normal_height, normal_top, normal_left, and prev_fsmode.
4275 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
4276 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
4279 * w32term.c (w32fullscreen_hook): Record last value of the frame's
4280 'fullscreen' parameter. Always record previous width and height
4281 of the frame, except when switching out of maximized modes, so
4282 that they could be restored correctly, instead of resetting to the
4283 default frame dimensions. Send SC_RESTORE command to the frame,
4284 unless we are going to send SC_MAXIMIZE, to restore the frame
4285 resize hints in the mouse pointer shown by the window manager.
4288 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
4290 * lisp.h (get_frame_param): Adjust conditions for prototype
4293 2013-03-22 Ken Brown <kbrown@cornell.edu>
4295 * unexcw.c: Drop unneeded inclusion of w32common.h.
4296 (report_sheap_usage): Declare.
4297 (read_exe_header): Add magic numbers for x86_64.
4298 (fixup_executable): Fix printf format specifier for unsigned long
4301 2013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
4303 * frame.h (struct frame): Put menu_bar_window under #ifdef
4304 because this member is not needed when X toolkit is in use.
4305 (fset_menu_bar_window):
4306 * dispnew.c (clear_current_matrices, clear_desired_matrices)
4307 (free_glyphs, update_frame):
4308 * xdisp.c (expose_frame): Likewise.
4309 (display_menu_bar): Likewise. Remove redundant eassert.
4310 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
4313 2013-03-21 Paul Eggert <eggert@cs.ucla.edu>
4315 Use functions and constants to manipulate Lisp_Save_Value objects.
4316 This replaces code that used macros and strings and token-pasting.
4317 The change makes the C source a bit easier to follow,
4318 and shrinks the Emacs executable a bit.
4319 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
4320 (make_save_value): Change 1st arg from string to enum. All callers
4323 (mark_object): Use if, not #if, for GC_MARK_STACK.
4324 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
4325 (XSAVE_OBJECT): Now functions, not macros.
4326 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
4327 the constant was never used.
4328 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
4329 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
4330 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
4331 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
4333 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
4334 type3 with a single member save_type. All uses changed.
4335 (save_type, set_save_pointer, set_save_integer): New functions.
4336 * print.c (PRINTX): Remove.
4338 * alloc.c: Remove redundant static declarations.
4340 2013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4342 * window.h (struct window): Convert left_col, top_line, total_lines
4343 and total_cols from Lisp_Objects to integers. Adjust comments.
4344 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
4346 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
4347 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
4348 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
4349 Adjust users where appropriate.
4351 2013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4353 * frame.h (struct frame): Drop resx and resy because the same data is
4354 available from window system-specific output context. Adjust users.
4355 (default_pixels_per_inch_x, default_pixels_per_inch_y):
4356 New functions to provide defaults when no window system available.
4357 (FRAME_RES_X, FRAME_RES_Y): New macros.
4358 (NUMVAL): Move from xdisp.c.
4359 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
4360 (Ffont_face_attributes, Fopen_font):
4361 * image.c (gs_load):
4362 * w32font.c (fill_in_logfont):
4363 * xdisp.c (calc_pixel_width_or_height):
4364 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
4365 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
4367 2013-03-20 Kenichi Handa <handa@gnu.org>
4369 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4370 to 1 (temporary workaround until a bug related to ASCII
4371 optimization is fixed).
4373 2013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
4375 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4376 Signal error if window is not internal. Adjust docstring.
4377 (delete_all_child_windows): Use combination_limit to save the buffer.
4378 (Fset_window_configuration): Adjust accordingly.
4379 * print.c (syms_of_print): Initialize debugging output not here...
4380 (init_print_once): ...but in a new function here.
4381 * lisp.h (init_print_once): Add prototype.
4382 * emacs.c (main): Add call to init_print_once. Adjust comments.
4384 2013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
4386 * window.c (window_resize_check, window_resize_apply)
4387 (window_from_coordinates, recombine_windows, set_window_buffer)
4388 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4389 (Fsplit_window_internal, Fdelete_window_internal)
4390 (freeze_window_starts): Use bool for booleans.
4391 * window.h (window_frame_coordinates, resize_frame_windows)
4392 (freeze_window_starts, set_window_buffer): Adjust prototypes.
4394 2013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
4396 * dispnew.c (bitch_at_user): Use `user-error'.
4398 2013-03-17 Ken Brown <kbrown@cornell.edu>
4400 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
4401 as return type of image_background. (Bug#13981)
4402 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
4404 2013-03-16 Jan Djärv <jan.h.d@swipnet.se>
4406 * nsterm.m (updateFrameSize:): Change resize increments if needed.
4407 (ns_select): Don't return with result uninitialized.
4409 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4412 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
4414 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4415 directories. If filename is nil, get directory name (Bug#13932).
4416 Use getFilename and getDirectory.
4417 (getFilename, getDirectory): New methods for EmacsSavePanel and
4419 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4421 2013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4423 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4425 2013-03-15 Kenichi Handa <handa@gnu.org>
4427 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4428 (adjust_after_replace): Make it back to static. Delete the third
4429 arg text_at_gap_tail. Cancel the code for handling it.
4431 * coding.h (struct coding_system): New member eol_seen.
4433 * coding.c (detect_ascii): New function.
4434 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4435 when the source bytes are actually scanned. On detecting for
4436 coding_category_utf_8_auto, call detect_ascii instead of scanning
4437 source bytes directly.
4438 (produce_chars): Call insert_from_gap with the new arg 0.
4439 (encode_coding): Likewise.
4440 (decode_coding_gap): Control ASCII optimization by the variable
4441 disable_ascii_optimization instead of #ifndef .. #endif.
4442 Deccode EOL format according to coding->eol_seen.
4443 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4446 * lisp.h (adjust_after_replace): Cancel externing it.
4447 (insert_from_gap): Adjust prototype.
4449 2013-03-15 Eli Zaretskii <eliz@gnu.org>
4451 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4452 FULLSCREEN_MAXIMIZED. (Bug#13935)
4454 2013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4456 * region-cache.c (find_cache_boundary, move_cache_gap)
4457 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4458 Simplify debugging check and convert to eassert. Adjust comment.
4459 (pp_cache): Put under ENABLE_CHECKING.
4461 2013-03-14 Eli Zaretskii <eliz@gnu.org>
4463 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4464 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4466 (w32fullscreen_hook): If the frame is visible, reset
4467 f->want_fullscreen flag after changing the frame size. If the
4468 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4471 2013-03-13 Daniel Colascione <dancol@dancol.org>
4473 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
4474 too so that these builds can use Cygwin's file conversion
4475 functions. (We've been building and linking cygw32.o all along
4476 and just not using it.)
4478 2013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4480 File synchronization fixes (Bug#13944).
4481 * Makefile.in (LIB_FDATASYNC): New macro.
4483 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4484 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4485 Don't worry about HAVE_FSYNC, since a substitute fsync is
4486 available if the system lacks one.
4487 (Fwrite_regin): Retry fsync if interrupted.
4489 2013-03-13 Eli Zaretskii <eliz@gnu.org>
4491 * w32term.c (w32_read_socket): If the Emacs frame is being
4492 activated, call w32fullscreen_hook, to make sure the new frame
4493 dimensions are in effect. (Bug#13937)
4495 2013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4497 * xdisp.c (init_iterator): Simplify because both character and byte
4498 positions are either specified or -1. Add eassert. Adjust comment.
4499 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4500 character and byte positions can be obtained from marker.
4502 2013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4504 Static checking by Sun C 5.12.
4505 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4506 * bytecode.c (exec_byte_code):
4507 * dispnew.c (init_display):
4509 * fileio.c (Fsubstitute_in_file_name):
4510 * keyboard.c (Fevent_convert_list):
4511 * keymap.c (Fsingle_key_description):
4512 * term.c (maybe_fatal, fatal):
4513 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4514 * xsmfns.c (Fhandle_save_session):
4515 Omit unreachable code.
4516 * keymap.c (map_keymap_char_table_item): Cast void * to
4517 a function pointer type; the C Standard requires this.
4519 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4520 Include <sys/param.h> unconditionally, as that works elsewhere and
4521 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4522 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4525 See ChangeLog.12 for earlier changes.
4531 Copyright (C) 2011-2013 Free Software Foundation, Inc.
4533 This file is part of GNU Emacs.
4535 GNU Emacs is free software: you can redistribute it and/or modify
4536 it under the terms of the GNU General Public License as published by
4537 the Free Software Foundation, either version 3 of the License, or
4538 (at your option) any later version.
4540 GNU Emacs is distributed in the hope that it will be useful,
4541 but WITHOUT ANY WARRANTY; without even the implied warranty of
4542 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4543 GNU General Public License for more details.
4545 You should have received a copy of the GNU General Public License
4546 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.