1 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
7 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
9 2011-11-20 Martin Rudalics <rudalics@gmx.at>
11 * window.c (Fset_window_combination_limit): Rename argument
13 (Vwindow_combination_limit): Remove "status" from doc-string.
15 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
17 * m/ibms390.h: Remove.
18 * m/ibms390x.h: Don't include "ibms390.h".
20 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
22 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
23 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
25 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
27 * casetab.c (Fset_case_table):
28 * charset.c (Fcharset_after): Fix typos.
30 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
32 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
33 Otherwise, valgrind does not work on some platforms.
34 Problem reported by Andreas Schwab in
35 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
36 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
37 is set, removing the need for VIRT_ADDRESS_VARIES.
38 (PURE_P): Use a more-efficient implementation that needs just one
39 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
40 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
41 to 4 (xorl, subq, cmpq, setbe).
42 * alloc.c (pure): Always extern now, since that's the
43 VIRT_ADDR_VARIES behavior.
44 (PURE_POINTER_P): Use a single comparison, not two, for
45 consistency with the new puresize.h.
46 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
47 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
48 Remove VIRT_ADDR_VARIES no longer needed.
50 2011-11-19 Eli Zaretskii <eliz@gnu.org>
52 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
53 (erase_phys_cursor, update_window_cursor, show_mouse_face)
54 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
55 behave as if the cursor position were at the window margin.
57 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
58 and the cursor position is out of bounds, behave as if the cursor
59 position were at the window margin. (Bug#10075)
61 2011-11-18 Chong Yidong <cyd@gnu.org>
63 * window.c (Fwindow_combination_limit): Make first argument
64 non-optional, since it is meaningless for live windows like the
67 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
69 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
71 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
73 * intervals.c: Fix grafting over the whole buffer (bug#10071).
74 (graft_intervals_into_buffer): Simplify.
76 2011-11-18 Eli Zaretskii <eliz@gnu.org>
78 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
79 hash values of the two rows.
80 (copy_row_except_pointers): Preserve the used[] arrays and the
81 hash values of the two rows. (Bug#10035)
82 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
84 * xdisp.c (row_hash): New function, body extracted from
86 (compute_line_metrics): Call row_hash, instead of computing the
89 * dispnew.c (verify_row_hash): Call row_hash for computing the
90 hash code of a row, instead of duplicating code from xdisp.c.
92 * dispextern.h (row_hash): Add prototype.
94 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
96 * frame.c (delete_frame): Don't delete the terminal when the last
97 X frame is closed if emacs is built with GTK toolkit.
99 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
101 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
103 2011-11-17 Martin Rudalics <rudalics@gmx.at>
105 * window.c (Vwindow_splits): Rename to
106 Vwindow_combination_resize. Suggested by Juri Linkov.
107 (Fsplit_window_internal): Use Vwindow_combination_resize instead
110 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
112 * nsfns.m (Fns_font_name):
113 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
115 2011-11-16 Martin Rudalics <rudalics@gmx.at>
117 * window.h (window): Rename slot "nest" to "combination_limit".
118 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
119 (Fset_window_nest): Rename to Fset_window_combination_limit.
120 (Vwindow_nest): Rename to Vwindow_combination_limit.
121 (recombine_windows, make_parent_window, make_window)
122 (Fsplit_window_internal, saved_window)
123 (Fset_window_configuration, save_window_save): Rename all
124 occurrences of window_nest to window_combination_limit.
126 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
128 * image.c (imagemagick_load_image): Fix typo.
130 2011-11-14 Eli Zaretskii <eliz@gnu.org>
132 * xdisp.c (display_line): Move the call to
133 highlight_trailing_whitespace before the call to
134 compute_line_metrics, since the latter needs to see the final
135 faces of all the glyphs to compute ROW's hash value. Fixes
136 assertion violations in row_equal_p. (Bug#10035)
138 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
140 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
141 just return (bug#10044).
143 2011-11-12 Eli Zaretskii <eliz@gnu.org>
145 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
146 with user-defined heap size. Bump the default size of the temacs
147 heap to 27MB, to avoid memory warning when running temacs.
148 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
150 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
151 current_matrix and desired_matrix. (Bug#9990)
152 (verify_row_hash) [XASSERTS]: New function.
153 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
154 that the hash value of glyph rows is correct.
156 2011-11-12 Martin Rudalics <rudalics@gmx.at>
158 * window.h (window): Remove splits slot.
159 * window.c (Fwindow_splits, Fset_window_splits): Remove.
160 (Fdelete_other_windows_internal, make_parent_window)
161 (make_window, Fsplit_window_internal, Fdelete_window_internal)
162 (Fset_window_configuration, save_window_save): Don't deal with
163 split status of windows.
164 (saved_window): Remove splits slot.
165 (Vwindow_splits): Rewrite doc-string.
167 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
169 * xfns.c (unwind_create_frame):
170 * nsfns.m (unwind_create_frame):
171 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
172 Vframe_list (Bug#9999).
174 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
176 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
178 2011-11-11 Kenichi Handa <handa@m17n.org>
180 * callproc.c (Fcall_process): Set the member dst_multibyte of
183 2011-11-11 Johan Bockgård <bojohan@gnu.org>
185 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
186 avoid a crash (bug#9496).
188 2011-11-09 Chong Yidong <cyd@gnu.org>
190 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
191 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
193 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
195 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
197 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
199 Avoid some portability problems by eschewing 'extern inline' functions.
200 The trivial performance wins aren't worth the portability hassles; see
201 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
203 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
204 (window_box_width, window_box_left, window_box_left_offset)
205 (window_box_right, window_box_right_offset): Undo previous change,
206 by removing the "extern"s.
207 * intervals.c (adjust_intervals_for_insertion)
208 (adjust_intervals_for_deletion): Undo previous change,
209 making these static again.
210 (offset_intervals, temp_set_point_both, temp_set_point)
211 (copy_intervals_to_string): No longer inline.
212 * xdisp.c (window_text_bottom_y, window_box_width)
213 (window_box_height, window_box_left_offset)
214 (window_box_right_offset, window_box_left, window_box_right)
215 (window_box): No longer inline.
217 2011-11-08 Chong Yidong <cyd@gnu.org>
219 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
220 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
221 an error if not a live window.
222 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
223 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
225 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
227 * lisp.h (syms_of_abbrev): Remove declaration.
228 Reported by CHENG Gao <chenggao@royau.me>.
230 2011-11-07 Eli Zaretskii <eliz@gnu.org>
232 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
233 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
234 of temacs in GUI mode.
236 2011-11-07 Martin Rudalics <rudalics@gmx.at>
238 * window.h: Declare delete_all_child_windows instead of
239 delete_all_subwindows.
240 * window.c (Fwindow_nest, Fset_window_nest)
241 (Fset_window_new_total, Fset_window_new_normal)
242 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
243 (delete_all_subwindows): Rename to delete_all_child_windows.
244 (Fdelete_other_windows_internal, Fset_window_configuration):
245 Call delete_all_child_windows instead of delete_all_subwindows.
246 * frame.c (delete_frame): Call delete_all_child_windows instead
247 of delete_all_subwindows.
249 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
251 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
252 This is also needed for porting to any host where GC_MARK_STACK is
253 not GC_MAKE_GCPROS_NOOPS.
254 (which_symbols): Use it.
256 2011-11-07 Kenichi Handa <handa@m17n.org>
258 * coding.c (coding_set_destination): Check coding->src_pos only
259 when coding->src_object is a buffer (bug#9910).
261 * process.c (send_process): Set the member src_multibyte of coding
262 to 0 (bug#9911) when sending a unibyte text.
264 * callproc.c (Fcall_process): Set the member src_multibyte of
265 process_coding to 0 (bug#9912).
267 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
269 * xmenu.c (cleanup_widget_value_tree): New function.
270 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
271 calling free_menubar_widget_value_tree directly (Bug#9830).
273 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
275 Fix some portability problems with 'inline'.
276 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
277 (window_box_width, window_box_left, window_box_left_offset)
278 (window_box_right, window_box_right_offset): Declare extern.
279 Otherwise, these inline functions do not conform to C99 and
280 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
281 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
282 * intervals.c (adjust_intervals_for_insertion)
283 (adjust_intervals_for_deletion): Now extern, because otherwise the
284 extern inline functions 'offset_intervals' couldn't refer to it.
285 (static_offset_intervals): Remove.
286 (offset_intervals): Rewrite using the old contents of
287 static_offset_intervals. The old version didn't conform to C99
288 because an extern inline function contained a reference to an
289 identifier with static linkage.
291 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
293 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
296 2011-11-06 Eli Zaretskii <eliz@gnu.org>
298 * xdisp.c (init_iterator, reseat_to_string): Don't set the
299 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
300 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
301 return Qleft_to_right.
303 2011-11-06 Chong Yidong <cyd@gnu.org>
305 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
306 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
307 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
308 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
309 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
310 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
311 (Fwindow_vscroll): Doc fix.
312 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
313 argument, since it makes no sense to pass a live window and for
314 consistency with window-child.
316 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
318 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
321 2011-11-05 Jason Rumney <jasonr@gnu.org>
323 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
324 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
326 (add_font_entity_to_list): Fix logic errors in mixed boolean and
327 bitwise arithmetic preventing use of unicode-sip and non-truetype
330 2011-11-05 Eli Zaretskii <eliz@gnu.org>
332 * s/ms-w32.h (fstat, stat, utime): Move redirections to
335 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
336 initialization code to keep similarity to xfns.c after changes
339 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
341 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
342 (unwind_create_frame): New function (Bug#9943).
343 (Fx_create_frame): Restructure code to be more similar to the one in
344 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
345 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
346 Move terminal->reference_count++ just before making the frame official
349 * nsterm.m (x_free_frame_resources): New function.
350 (x_destroy_window): Move code to x_free_frame_resources.
352 * xfns.c (unwind_create_frame): Fix comment.
353 (Fx_create_frame, x_create_tip_frame): Move
354 terminal->reference_count++ just before making the frame
355 official. Move initialization of image_cache_refcount and
356 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
358 2011-11-05 Eli Zaretskii <eliz@gnu.org>
360 Support MSVC build with newer versions of Visual Studio.
361 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
362 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
365 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
366 which are not supported by MSVC.
367 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
368 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
370 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
372 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
374 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
376 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
378 Support MSVC build with newer versions of Visual Studio.
379 * w32.c: Don't include w32api.h for MSVC.
380 (init_environment) [_MSC_VER]: Call sys_access, not _access.
382 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
383 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
384 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
385 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
387 (alloca) [_MSC_VER]: Define to _alloca.
389 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
391 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
393 2011-11-04 Eli Zaretskii <eliz@gnu.org>
395 * xdisp.c (note_mouse_highlight): If either of
396 previous/next-single-property-change returns nil, treat that as
397 the beginning or the end of the buffer. (Bug#9955)
399 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
401 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
402 label is not null (Bug#9951).
403 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
406 2011-11-04 Eli Zaretskii <eliz@gnu.org>
408 * window.c (Fwindow_body_size): Mention in the doc string that the
409 return value is in frame's canonical units. (Bug#9949)
411 2011-11-03 Eli Zaretskii <eliz@gnu.org>
413 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
415 * w32fns.c (unwind_create_frame): If needed, free the glyph
416 matrices of the partially constructed frame. (Bug#9943)
417 * xfns.c (unwind_create_frame): Likewise.
419 2011-11-01 Eli Zaretskii <eliz@gnu.org>
421 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
422 Don't stop backward scan on the continuation glyph, even though
423 its CHARPOS is positive.
424 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
425 cover_string to disp_string.
427 2011-11-01 Martin Rudalics <rudalics@gmx.at>
429 * window.c (temp_output_buffer_show): Don't use
430 Vtemp_buffer_show_specifiers.
431 (Vtemp_buffer_show_specifiers): Remove unused variable.
433 2011-10-30 Eli Zaretskii <eliz@gnu.org>
435 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
436 past the beginning of the current glyph matrix.
438 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
440 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
441 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
442 HAVE_GTK3 (Bug#9869).
444 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
445 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
447 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
449 * xterm.c: Declare x_handle_net_wm_state to return int.
450 (handle_one_xevent): Check if we are iconified but don't have
451 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
452 (get_current_wm_state): Return non-zero if not hidden,
453 check for _NET_WM_STATE_HIDDEN (Bug#9893).
454 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
455 (x_handle_net_wm_state): Return what get_current_wm_state returns.
456 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
458 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
460 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
461 so that this new function doesn't get optimized away by a
462 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
464 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
466 * frame.h (MOUSE_HL_INFO): Remove excess parens.
468 2011-10-29 Eli Zaretskii <eliz@gnu.org>
470 Fix the `xbytecode' command.
471 * .gdbinit (xprintbytestr): New command.
472 (xwhichsymbols): Rename from `which'; all callers changed.
473 (xbytecode): Print the byte-code string as well.
475 2011-10-29 Kim Storm <storm@cua.dk>
477 * alloc.c (which_symbols): New function.
479 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
481 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
484 2011-10-29 Glenn Morris <rgm@gnu.org>
486 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
487 Not clear what it was for, and it causes various bugs. (Bug#9839)
489 2011-10-28 Eli Zaretskii <eliz@gnu.org>
491 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
492 possible random value that matches one of those tested as
493 condition to clear the mouse face.
495 2011-10-28 Chong Yidong <cyd@gnu.org>
497 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
499 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
501 * window.c (make_window): Initialize phys_cursor_on_p.
503 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
505 * lisp.h (struct Lisp_Symbol): Update comments.
507 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
509 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
511 2011-10-28 Eli Zaretskii <eliz@gnu.org>
513 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
514 <oslsachem@gmail.com> for helping to debug this.
516 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
517 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
518 (g_b_init_get_glyph_outline_w): New static variables.
519 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
520 (GetGlyphOutlineW_Proc): New typedefs.
521 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
522 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
524 (w32font_open_internal, compute_metrics):
525 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
526 instead of calling the "wide" APIs directly.
528 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
530 * w32.h (syms_of_w32font): Add prototype.
532 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
534 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
535 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
536 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
537 (Fmove_to_window_line): Doc fix.
539 2011-10-27 Chong Yidong <cyd@gnu.org>
541 * process.c (make_process): Set gnutls_state to NULL.
543 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
544 non-NULL, regardless of GNUTLS_INITSTAGE.
545 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
546 an error. Set process slots as soon as we allocate them.
548 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
550 2011-10-27 Chong Yidong <cyd@gnu.org>
552 * gnutls.c (emacs_gnutls_deinit): New function.
553 Deallocate credentials structures as well as calling gnutls_deinit.
554 (Fgnutls_deinit, Fgnutls_boot): Use it.
556 * process.c (make_process): Initialize GnuTLS credentials to NULL.
557 (deactivate_process): Call emacs_gnutls_deinit.
559 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
561 * image.c (x_create_x_image_and_pixmap):
562 * w32.c (sys_rename, w32_delayed_load):
563 * w32font.c (fill_in_logfont):
564 * w32reg.c (x_get_string_resource): Silence compiler warnings.
566 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
568 * w32fns.c (w32_default_color_map): New function,
569 extracted from Fw32_default_color_map.
570 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
572 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
574 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
576 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
578 * keyboard.c (test_undefined): New function (bug#9751).
579 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
581 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
583 * sysdep.c (init_sys_modes): Fix the check for the controlling
586 2011-10-20 Eli Zaretskii <eliz@gnu.org>
588 * dispextern.h (struct bidi_it): New member next_en_type.
590 * bidi.c (bidi_line_init): Initialize the next_en_type member.
591 (bidi_resolve_explicit_1): When next_en_pos is valid for the
592 current character, check also for next_en_type being WEAK_EN.
593 (bidi_resolve_weak): Don't enter the expensive loop if the current
594 position is before next_en_pos. Record the bidi type of the first
595 non-ET, non-BN character we find, in addition to its position.
596 (bidi_level_of_next_char): Invalidate next_en_type when
597 next_en_pos is over-stepped.
599 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
601 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
602 * editfns.c: Rewrite current-time-zone so that it invokes
603 the equivalent of (format-time-string "%Z") to get the time zone name.
604 This fixes a bug when the time zone name contains characters that
605 need converting from the system time locale to Emacs internal format.
606 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
607 that patch fixed format-time-string to do the conversion, but
608 I forgot to fix current-time-zone.
609 (format_time_string): New function, containing most of
610 what Fformat_time_string used to contain.
611 (Fformat_time_string): Rewrite in terms of format_time_string.
612 This doesn't change this function's behavior.
613 (current-time-zone): Rewrite to use format_time_string.
614 This fixes the bug reported by Michael Schierl in
615 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
616 Jason Rumney's 2007-06-07 change worked around this bug, but
618 * systime.h (tzname, timezone): Remove no-longer-used declarations.
620 2011-10-19 Eli Zaretskii <eliz@gnu.org>
622 * xdisp.c (start_display): If the character at POS is displayed
623 via a display vector, reset IT->current.dpvec_index to zero.
624 (try_window_reusing_current_matrix): If a line ends in a display
625 vector or the next line starts in a display vector, continue
626 redrawing the window even though the character position of
627 start_row was reached.
630 2011-10-18 Chong Yidong <cyd@gnu.org>
632 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
633 with nobreak-char-display too.
635 2011-10-18 Eli Zaretskii <eliz@gnu.org>
637 Fix part 3 of bug#9771.
638 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
639 (bidi_resolve_neutral): Don't enter the expensive loop looking for
640 non-neutral characters if the current character is a paragraph
641 separator (a.k.a. Newline). This avoids running the same
642 expensive loop twice, once when we consume the preceding newline
643 and the other time when the line actually needs to be displayed.
644 Avoid the loop when we see neutrals on the base embedding level
645 following a character whose directionality is the same as the
646 paragraph's. This avoids running the expensive loop when a line
647 ends in a long sequence of neutrals, like control characters.
648 Add assertion against STRONG_AL type. Slightly rearrange code
649 that determines the type of a neutral given the first non-neutral
651 (bidi_level_of_next_char): Set next_en_pos to zero when
652 invalidating its info.
654 2011-10-17 Eli Zaretskii <eliz@gnu.org>
656 * xdisp.c (push_display_prop): Determine whether to record string
657 or buffer position by IT->string, not by IT->method. Allow
658 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
659 (move_it_vertically_backward): Don't look for character position
660 immediately after the newline when in a continuation line.
663 2011-10-15 Martin Rudalics <rudalics@gmx.at>
665 * window.c (coordinates_in_window): Rewrite and delabelize
666 vertical border check. (Bug#5357) (Bug#9618)
668 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
670 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
671 errors in XSetWindowBorder (bug#9310).
673 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
675 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
676 avoid crash when xmalloc overrun checking is enabled.
678 2011-10-13 Eli Zaretskii <eliz@gnu.org>
680 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
681 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
682 cursor motion with <left> and <right> arrow keys.
684 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
685 some callers set that themselves.
687 2011-10-12 Eli Zaretskii <eliz@gnu.org>
689 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
690 display string and the previous row comes from the same string and
691 is empty. (Bug#9739) (Bug#9738)
693 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
695 * doc.c (get_doc_string): Encode file name (bug#9735).
697 2011-10-12 Eli Zaretskii <eliz@gnu.org>
699 * bidi.c (bidi_level_of_next_char):
700 * xdisp.c (get_visually_first_element): Remove old incorrect
701 comments regarding the Unicode Line Separator character.
703 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
705 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
707 * alloc.c (Fgc_status): Do not access beyond zombies array
708 boundary if nzombies > MAX_ZOMBIES.
709 * alloc.c (dump_zombies): Add missing format specifier.
711 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
713 * xdisp.c (set_cursor_from_row): Simplify conditionals,
714 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
716 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
717 Some packages use them to denote characters with modifiers.
719 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
721 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
722 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
723 matching a pp-number. Rename parameter var to var1.
725 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
727 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
729 2011-10-08 Glenn Morris <rgm@gnu.org>
731 * callint.c (Fcall_interactively): Give a more explicit error for the
732 'c' case with a non-character input. (Bug#8479)
734 2011-10-08 Eli Zaretskii <eliz@gnu.org>
736 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
738 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
739 lines that are hscrolled on the left.
741 * dispnew.c (buffer_posn_from_coords): Account for a possible
742 presence of header-line. (Bug#4426)
744 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
746 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
747 Don't advertise functionality which we discourage or doesn't work.
749 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
751 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
752 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
753 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
754 this makes Emacs dump core during garbage collection on rare
755 occasions. sizeof is obviously inferior to offsetof here, so
757 (GC_POINTER_ALIGNMENT): New macro.
758 (mark_memory): Omit 3rd (offset) arg; caller changed.
759 Don't assume EMACS_INT alignment is the same as pointer alignment.
761 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
763 * keyboard.c (read_key_sequence_remapped): New var.
764 (read_key_sequence): Compute remapping in the right buffer.
765 (command_loop_1): Use read_key_sequence's remapping directly.
767 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
769 * dired.c (file_name_completion): Don't expand file name.
770 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
771 before checking file name handler.
773 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
774 they've been requested explicitly (bug#9591).
776 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
778 * keymap.c (Fsingle_key_description): Use make_specified_string
779 instead of build_string to build string from push_key_description.
782 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
784 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
785 This fixes a Y2038 bug on 64-bit hosts.
786 * buffer.c (reset_buffer):
787 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
788 (Fclear_buffer_auto_save_failure):
789 Use 0, not -1, to represent an unset failure time, since time_t
792 Remove dependency on glibc malloc internals.
793 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
794 Move back here from lisp.h, but with their new implementations.
795 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
796 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
797 * charset.c (charset_table_init): New static var.
798 (syms_of_charset): Use it instead of xmalloc. This removes a
799 dependency on glibc malloc internals. See Eli Zaretskii's comment in
800 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
801 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
802 Move back to alloc.c.
803 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
804 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
806 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
808 * nsterm.m (windowDidResize): Call x_set_window_size only when
809 ns_in_resize is true. Otherwise set pixelwidth/height and
810 call change_frame_size (Bug#9628).
812 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
814 Port --enable-checking=all to Fedora 14 x86-64.
815 * charset.c (syms_of_charset): Also account for glibc malloc's
816 internal overhead when calculating the initial malloc maximum.
818 Port --enable-checking=all to Fedora 14 x86.
819 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
821 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
822 (overrun_check_realloc, overrun_check_free):
823 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
824 That way, xmalloc returns a properly-aligned pointer even if
825 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
826 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
827 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
828 into account when calculating the initial malloc maximum.
829 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
830 Move here from alloc.c, so that charset.c can use it too.
831 Properly align; the old code wasn't right for common 32-bit hosts
832 when configured with --enable-checking=all.
833 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
834 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
836 2011-09-29 Eli Zaretskii <eliz@gnu.org>
838 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
841 2011-09-28 Eli Zaretskii <eliz@gnu.org>
843 * xdisp.c (compute_display_string_end): If there's no display
844 string at CHARPOS, return -1.
846 * bidi.c (bidi_fetch_char): When compute_display_string_end
847 returns a negative value, treat the character as a normal
848 character not covered by a display string. (Bug#9624)
850 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
852 * lread.c (Fread_from_string): Fix typo in docstring.
854 2011-09-27 Eli Zaretskii <eliz@gnu.org>
856 * xdisp.c (handle_invisible_prop): If invisible text ends on a
857 newline, reseat the iterator instead of bidi-iterating there one
858 character at a time. (Bug#9610)
859 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
860 TO_CHARPOS if the bidi iterator is at base embedding level.
862 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
864 * lread.c (readevalloop): Use correct code for NBSP.
865 (read1): Likewise. (Bug#9608)
867 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
869 * dbusbind.c (Fdbus_register_signal): When service is not
870 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
872 2011-09-25 Glenn Morris <rgm@gnu.org>
874 * buffer.c (truncate-lines): Doc fix.
876 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
878 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
879 (Fset_window_next_buffers): Doc fix.
881 2011-09-24 Glenn Morris <rgm@gnu.org>
883 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
885 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
887 Fix minor problems found by static checking.
888 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
889 * indent.c (Fvertical_motion): Fix == vs = typo.
891 2011-09-24 Eli Zaretskii <eliz@gnu.org>
893 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
894 Default value is now t. Doc fix.
896 * indent.c (Fvertical_motion): Compute and apply the overshoot
897 logic when moving up, not only when moving down. Fix the
898 confusing name and values of the it_overshoot_expected variable;
899 logic changes accordingly. (Bug#9254) (Bug#9549)
901 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
902 CHARPOS is covered by a display string which includes newlines.
903 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
904 is covered by a display string with embedded newlines.
906 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
908 * dbusbind.c (Fdbus_register_signal): Add match rule to
909 Vdbus_registered_objects_table. (Bug#9581)
910 (Fdbus_register_method, Vdbus_registered_objects_table):
913 2011-09-24 Jim Meyering <meyering@redhat.com>
915 do not ignore write error for any output size
916 The previous change was incomplete.
917 While it makes emacs --batch detect the vast majority of stdout
918 write failures, errors were still ignored whenever the output size is
919 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
920 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
921 && echo FAIL: ignored write error
922 FAIL: ignored write error
923 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
924 && echo FAIL: ignored write error
925 FAIL: ignored write error
926 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
928 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
930 * emacs.c (Fkill_emacs): In noninteractive mode exit
931 non-successfully if a write error occurred on stdout. (Bug#9574)
933 2011-09-21 Eli Zaretskii <eliz@gnu.org>
935 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
938 * dispextern.h (struct it): Update the comment documenting what
941 2011-09-20 Eli Zaretskii <eliz@gnu.org>
943 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
944 a display string, extend search for cursor position to end of row.
945 (find_row_edges): If the row ends in a newline from a display
946 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
947 Handle the case of a display string with multiple newlines.
948 (Fcurrent_bidi_paragraph_direction): Fix search for previous
949 non-empty line. Fixes confusing cursor motion with arrow keys at
950 the beginning of a line that starts with whitespace.
952 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
954 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
957 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
959 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
962 2011-09-18 Eli Zaretskii <eliz@gnu.org>
964 * xdisp.c (display_line): Record maximum and minimum buffer
965 positions even if no glyphs were produced (e.g., by a zero-width
966 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
967 buffer positions that will be removed from the glyph row because
969 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
970 column is beyond frame width: don't subtract 1 "pixel" when
971 computing width of the stretch.
972 (reseat_at_next_visible_line_start): Undo the change made on
973 2011-09-17 that saved paragraph information and restored it after
974 the call to `reseat'. (Bug#9545)
976 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
978 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
979 and turn window cursor on if cleared (Bug#9415).
981 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
983 * search.c (boyer_moore): Take unibyte characters from pattern
984 literally. (Bug#9458)
986 2011-09-18 Eli Zaretskii <eliz@gnu.org>
988 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
990 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
992 Fix minor problem found by static checking.
993 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
994 initialized, to pacify gcc -Wuninitialized.
996 * fileio.c: Report proper errno when syscall falls.
997 (Finsert_file_contents): Save and restore errno,
998 so that report_file_error outputs the correct diagnostic.
999 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1001 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1003 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1005 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1007 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1008 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1010 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1012 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1013 about the current paragraph and restore it after the call to reseat.
1015 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1016 (bidi_find_paragraph_start): Search back for paragraph beginning
1017 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1018 (bidi_move_to_visually_next): Only trigger paragraph-related
1019 computations when the last character is a newline or at EOB, not
1020 just any NEUTRAL_B. (Bug#9470)
1022 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1023 truncated lines if point is covered by a display string. (Bug#9524)
1025 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1027 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1028 (cons_to_x_long): New function.
1029 (lisp_data_to_selection_data): Use it. Correct the test for
1030 short-versus-long data; it was negated. Break out of vector
1031 loop, for efficiency, when a long datum is discovered.
1033 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1035 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1037 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1039 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1040 GCC PR/17406) by declaring this function with external scope.
1042 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1044 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1045 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1047 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1049 * editfns.c (Fformat): Correctly handle text properties on "%%".
1051 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1053 * xterm.c (x_draw_composite_glyph_string_foreground):
1054 * w32term.c (x_draw_composite_glyph_string_foreground):
1055 * term.c (encode_terminal_code):
1056 * composite.c (composition_update_it, get_composition_id):
1057 * xdisp.c (get_next_display_element)
1058 (fill_composite_glyph_string): Add comments about special meaning
1059 of TAB characters in a composition.
1061 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1063 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1064 This occurs when processing a multibyte format.
1065 Problem reported by Wolfgang Jenker.
1067 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1069 * xdisp.c (try_cursor_movement): Only check for exact match if
1070 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1072 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1074 Remove unused external symbols.
1075 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1076 * xdisp.c (calc_pixel_width_or_height): Now static.
1077 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1078 * indent.c (check_display_width):
1079 * w32term.c: Fix comment to match code.
1080 * xterm.c, xterm.h (x_catching_errors): Remove.
1082 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1084 * xselect.c: Use signed conversions more consistently (Bug#9498).
1085 (selection_data_to_lisp_data): Assume incoming selection data are
1086 signed integers, not unsigned. This is to be consistent with
1087 outgoing selection data, which was modified to use signed integers
1088 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1089 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1090 expects long, not unsigned long.
1092 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1094 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1095 computation of loop end. Reported by Johan Bockgård
1098 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1100 * frame.c (Fother_visible_frames_p): Function deleted.
1102 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1104 * indent.c (compute_motion): Process display vector front to back
1105 rather than the other way around. (Bug#2496)
1107 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1109 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1111 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1113 * minibuf.c (Fread_from_minibuffer): Doc fix.
1115 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1117 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1118 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1120 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1122 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1123 value for non-existent files.
1125 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1127 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1128 set its "size" to -1. This will set the modtime_size field of
1129 the corresponding buffer to -1, which is what
1130 verify-visited-file-modtime expects for files that do not exist.
1133 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1135 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1137 * lisp.h: ... from here. push_key_description is no longer
1138 defined in keyboard.c, so its declaration should not be in
1139 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1140 logically belongs with push_key_description.
1142 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1144 * buffer.h: Include <sys/types.h> instead of <time.h>.
1145 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1146 Problem reported by Herbert J. Skuhra.
1148 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1150 * xml.c (parse_region): Make the parsing work for
1151 non-comment-starting XML files again (bug#9144).
1153 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1155 * image.c (gif_load): Fix calculation of bottom and right corner.
1158 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1160 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1161 redisplay in small windows.
1163 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1165 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1167 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1169 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1170 Operate on live windows only.
1172 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1174 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1176 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1178 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1179 only under bidi iteration.
1181 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1183 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1185 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1187 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1188 Without this fix, the command to link temacs failed due to an
1189 undefined symbol __builtin_isnan. This is because
1190 /usr/include/iso/math_c99.h #defines isnan(x) to
1191 __builtin_isnan(x), but the bundled gcc, which identifies itself
1192 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1194 * floatfns.c (isnan): #undef, and then #define to a clone of
1196 (Fisnan): Always define, since it's always available now.
1197 (syms_of_floatfns): Always define isnan at the Lisp level.
1199 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1201 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1203 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1205 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1206 The previous code assumed that file offsets (off_t values) fit in
1207 EMACS_INT variables, which is not true on typical 32-bit hosts.
1208 The code messed up by falsely reporting buffer overflow in cases
1209 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1210 when "big" contains more than 2**29 bytes, even though this
1211 inserts just one byte and does not overflow the buffer.
1212 (Finsert_file_contents): Store file offsets as off_t
1213 values, not as EMACS_INT values. Check for overflow when
1214 converting between EMACS_INT and off_t. When checking for
1215 buffer overflow or for overlap, take the offsets into account.
1216 Don't use EMACS_INT for small values where int suffices.
1217 When checking for overlap, fix a typo: ZV was used where
1218 ZV_BYTE was intended.
1219 (Fwrite_region): Don't assume off_t fits into 'long'.
1220 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1222 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1224 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1226 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1228 sprintf-related integer and memory overflow issues (Bug#9412).
1230 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1231 (esprintf, exprintf, evxprintf): New functions.
1232 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1233 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1234 (modify_event_symbol): Do not assume that the length of
1235 name_alist_or_stem is safe to alloca and fits in int.
1236 (Fexecute_extended_command): Likewise for function name and binding.
1237 (Frecursion_depth): Wrap around reliably on integer overflow.
1238 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1239 since some callers pass EMACS_INT values.
1240 (Fsingle_key_description): Don't crash if symbol name contains more
1241 than MAX_ALLOCA bytes.
1242 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1243 (get_minibuffer): Arg is now EMACS_INT, not int.
1244 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1245 (esprintf, exprintf, evxprintf): New decls.
1246 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1248 * dbusbind.c (signature_cat): New function.
1249 (xd_signature, Fdbus_register_signal):
1250 Do not overrun buffer; instead, report string overflow.
1252 * dispnew.c (add_window_display_history): Don't overrun buffer.
1253 Truncate instead; this is OK since it's just a log.
1255 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1256 even if the time zone offset is outlandishly large.
1257 Don't mishandle offset == INT_MIN.
1259 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1260 when creating daemon; the previous buffer-overflow check was incorrect.
1262 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1263 which has the guts of the old verror function.
1265 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1266 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1268 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1269 (font_unparse_xlfd): Don't blindly alloca long strings.
1270 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1271 fits in int, when using sprintf. Use single snprintf to count
1272 length of string rather than counting it via multiple sprintfs;
1273 that's simpler and more reliable.
1274 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1275 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1276 sprintf, in case result does not fit in int.
1278 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1279 (fontset_from_font): Print it.
1281 * frame.c (tty_frame_count): Now printmax_t, not int.
1282 (make_terminal_frame, set_term_frame_name): Print it.
1283 (x_report_frame_params): In X, window IDs are unsigned long,
1284 not signed long, so print them as unsigned.
1285 (validate_x_resource_name): Check for implausibly long names,
1286 and don't assume name length fits in 'int'.
1287 (x_get_resource_string): Don't blindly alloca invocation name;
1288 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1291 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1292 (xg_check_special_colors, xg_set_geometry):
1293 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1295 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1296 Use esprintf, not sprintf, in case result does not fit in int.
1298 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1299 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1300 it as a large positive number.
1301 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1302 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1304 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1305 in case result does not fit in int.
1307 * print.c (float_to_string): Detect width overflow more reliably.
1308 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1309 buffer overrun. Don't assume list length fits in 'int'. Treat
1310 print length of 0 as 0, not as infinity; to be consistent with other
1311 uses of print length in this function. Don't overflow print length
1312 index. Don't assume hash table size fits in 'long', or that
1313 vectorlike size fits in 'unsigned long'.
1315 * process.c (make_process): Use printmax_t, not int, to format
1316 process-name gensyms.
1318 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1320 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1321 to avoid potential buffer overrun.
1323 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1324 if X resource line is longer than 512 bytes.
1326 * xfns.c (x_window): Make sprintf buffer a bit bigger
1327 to avoid potential buffer overrun.
1329 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1331 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1333 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1335 Integer overflow fixes for scrolling, etc.
1336 Without these, Emacs silently mishandles large integers sometimes.
1337 For example, "C-u 4294967297 M-x recenter" was treated as if
1338 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1340 * xdisp.c (try_window_id): Check Emacs fixnum range before
1341 converting to 'int'.
1343 * window.c (window_scroll_line_based, Frecenter):
1344 Check that an Emacs fixnum is in range before assigning it to 'int'.
1345 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1346 values converted from Emacs fixnums.
1347 (Frecenter): Don't wrap around a line count if it is out of 'int'
1348 range; instead, treat it as an extreme value.
1349 (Fset_window_configuration, compare_window_configurations):
1350 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1352 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1353 that can exceed INT_MAX. Check that EMACS_INT value is in range
1354 before assigning it to the (possibly-narrower) index.
1355 (match_limit): Don't assume that a fixnum can fit in 'int'.
1357 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1360 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1361 (Fvertical_motion): Don't wrap around LINES values that don't fit
1362 in 'int'. Instead, treat them as extreme values. This is good
1363 enough for windows, which can't have more than INT_MAX lines anyway.
1365 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1367 * Require libxml/parser.h to avoid compilation warning.
1369 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1371 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1372 since this reportedly can destroy thread storage.
1374 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1376 * syntax.c (find_defun_start): Update all cache variables if
1377 exiting early (Bug#9401).
1379 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1381 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1383 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1384 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1385 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1387 * term.c (tty_append_glyph): New function.
1388 (produce_stretch_glyph): Static function and its prototype deleted.
1390 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1393 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1395 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1396 when checking :margin (Bug#9390).
1397 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1398 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1399 so that the name doesn't mislead. All uses changed.
1401 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1403 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1406 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1408 * xdisp.c (move_it_to): Don't bail out early when reaching
1409 position beyond to_charpos, if we are scanning backwards.
1410 (move_it_vertically_backward): When DY == 0, make sure we get to
1411 the first character in the line after the newline.
1413 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1415 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1416 (ccl_driver): Do not generate an out-of-range pointer.
1417 (Fccl_execute_on_string): Remove unnecessary check for
1418 integer overflow, noted by Stefan Monnier in
1419 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1420 Remove a FIXME that didn't need fixing.
1421 Simplify the newly-introduced buffer reallocation code.
1423 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1425 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1427 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1429 Integer and memory overflow issues (Bug#9196).
1431 * doc.c (get_doc_string): Rework so that
1432 get_doc_string_buffer_size is the actual buffer size, rather than
1433 being 1 less than the actual buffer size; this makes xpalloc more
1436 * image.c (x_allocate_bitmap_record, cache_image):
1437 * xselect.c (Fx_register_dnd_atom):
1438 Simplify previous changes by using xpalloc.
1440 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1441 since either will do and ptrdiff_t is convenient with xpalloc.
1443 * charset.c (charset_table_size)
1444 (struct charset_sort_data.priority): Now ptrdiff_t.
1445 (charset_compare): Don't overflow if priorities differ greatly.
1446 (Fsort_charsets): Don't assume list length fits in int.
1447 Check for size-calculation overflow when allocating sort data.
1448 (syms_of_charset): Allocate an initial charset table that is
1449 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1451 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1453 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1454 The actual value is always <= INT_MAX, and leaving it unsigned made
1455 overflow checking harder.
1457 * dispextern.h (struct glyph_matrix.rows_allocated)
1458 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1459 with xpalloc. The values are still always <= INT_MAX.
1461 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1463 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1464 (SAFE_NALLOCA): New macro.
1466 * region-cache.c (struct boundary.pos, find_cache_boundary)
1467 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1468 (set_cache_region, invalidate_region_cache)
1469 (revalidate_region_cache, know_region_cache, region_cache_forward)
1470 (region_cache_backward, pp_cache):
1471 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1472 so that ptrdiff_t * can be passed to xpalloc.
1473 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1474 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1475 (pp_cache): Don't assume cache_len fits in int.
1476 * region-cache.h: Adjust extern decls to match.
1478 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1479 EMACS_INT, since either will do, for xpalloc.
1481 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1482 (xnmalloc, xnrealloc, xpalloc): New functions.
1484 * bidi.c (bidi_shelve_header_size): New constant.
1485 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1486 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1488 * bidi.c (bidi_cache_shrink):
1489 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1491 Don't update size of array until after memory allocation succeeds,
1492 because xmalloc/xrealloc may not return.
1493 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1494 now that we have proper integer overflow checking.
1495 (record_overlay_string, overlay_strings): Catch overflows when
1496 calculating size of overlay_str_buf.
1498 * callproc.c (Fcall_process): Check for size overflow when
1499 calculating size of args2.
1500 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1501 Normally we prefer signed values, but sticking with ptrdiff_t would
1502 require adding more-complicated checks.
1504 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1505 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1506 Redo buffer-overflow calculations to avoid integer overflow.
1507 Add a FIXME comment where memory seems to be over-allocated.
1509 * character.c (Fstring): Check for size-calculation overflow.
1511 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1512 unnecessary integer overflow. Check for size overflow.
1513 (encode_coding_object): Don't update size until xmalloc succeeds.
1515 * composite.c (get_composition_id): Check for overflow in glyph
1516 length calculations.
1518 Integer and memory overflow fixes for display code.
1519 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1520 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1521 (scrolling_window): Check for overflow in size calculations.
1522 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1523 Don't assume glyph table len fits in int.
1524 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1525 (row_table_size): Now ptrdiff_t, not int.
1526 (scrolling_window): Avoid overflow in size calculations.
1527 Don't update size until allocation succeeds.
1528 * fns.c (concat): Check for overflow in size calculations.
1529 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1530 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1531 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1533 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1534 (get_doc_string): Check for size calculation overflow.
1535 Don't update size until allocation succeeds.
1536 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1537 EMACS_INT, where ptrdiff_t will do.
1538 (Fsubstitute_command_keys): Check for string overflow.
1540 * editfns.c (set_time_zone_rule): Don't assume environment length
1542 (message_length): Now ptrdiff_t, not int.
1543 (Fmessage_box): Don't update size until allocation succeeds.
1544 Don't assume message length fits in int.
1545 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1547 * emacs.c (main): Do not reallocate argv, since there is a null at
1548 the end that can be overwritten, and this way there's no need to
1549 worry about size-calculation overflow.
1550 (sort_args): Check for size-calculation overflow.
1552 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1554 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1556 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1557 (x_set_scroll_bar_width, x_figure_window_size):
1558 Check for integer overflow.
1559 (x_set_alpha): Do not assume XINT fits in int.
1561 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1562 This is for the members text_lines, text_cols, total_lines, total_cols,
1563 where the system imposes an 'int' limit.
1565 * fringe.c (Fdefine_fringe_bitmap):
1566 Don't update size until alloc works.
1568 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1569 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1571 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1572 Check for size-calculation overflow.
1573 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1574 do, as we prefer signed integers.
1575 (id_to_widget.max_size, id_to_widget.used)
1576 (xg_store_widget_in_map, xg_remove_widget_from_map)
1577 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1578 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1579 Use and return ptrdiff_t, not int.
1580 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1581 * gtkutil.h: Change prototypes to match the above.
1583 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1584 are duplicate now that they've been promoted to lisp.h.
1585 (x_allocate_bitmap_record, x_alloc_image_color)
1586 (make_image_cache, cache_image, xpm_load):
1587 Don't update size until alloc is done.
1588 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1590 Check for size calculation overflow.
1591 (ct_colors_allocated_max): New constant.
1592 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1595 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1596 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1597 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1598 Use ptrdiff_t, not int, to count maps.
1599 (read_char_minibuf_menu_prompt): Check for overflow in size
1600 calculations. Don't update size until allocation succeeds.
1601 Redo calculations to avoid overflow.
1602 * keyboard.h: Change prototypes to match the above.
1604 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1606 (current_minor_maps): Check for size calculation overflow.
1607 * keymap.h: Change prototypes to match the above.
1609 * lread.c (read1, init_obarray): Don't update size until alloc done.
1611 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1612 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1614 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1615 Now ptrdiff_t, not int.
1616 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1617 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1619 * process.c (Fnetwork_interface_list): Check for overflow
1620 in size calculation.
1622 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1624 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1625 overflow. Don't bother calling xmalloc when xrealloc will do.
1627 * search.c (Freplace_match): Check for size calculation overflow.
1628 (Fset_match_data): Don't assume list lengths fit in 'int'.
1630 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1631 for command line length. Do not attempt to address one before the
1632 beginning of an array, as that's not portable.
1634 * term.c (max_frame_lines): Remove; unused.
1635 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1637 (encode_terminal_code, calculate_costs): Check for size
1638 calculation overflow.
1639 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1640 table lengths and related sizes. Don't update size until alloc
1641 done. Redo calculations to avoid overflow.
1642 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1644 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1645 subtracting pointers.
1646 (gobble_line): Check for overflow more carefully. Don't update size
1649 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1650 Don't update size until alloc done.
1651 Redo size calculations to avoid overflow.
1652 Check for size calculation overflow.
1653 (main) [DEBUG]: Fix typo in invoking tparam1.
1655 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1656 Use ptrdiff_t, not int, for sizes.
1657 (store_mode_line_noprop_char): Don't update size until alloc done.
1659 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1660 Use ptrdiff_t, not int, for sizes.
1661 (Finternal_make_lisp_face, cache_face):
1662 Check for size calculation overflow.
1663 (cache_face): Treat size calculation overflows as if they were
1664 memory exhaustion (the usual treatment), rather than aborting.
1666 * xfns.c (x_encode_text, x_set_name_internal)
1667 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1668 sizes, since they can exceed INT_MAX in size. Check for size
1669 calculation overflow.
1671 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1672 (xg_select): Check for size calculation overflow.
1673 Don't update size until alloc done.
1675 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1676 as sprintf is limited to int lengths.
1678 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1679 (X_LONG_MIN): New macros.
1680 Use them to make the following changes clearer.
1681 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1682 This change doesn't affect the value now, but it may help remind
1683 future maintainers not to raise the value too much later.
1684 (SELECTION_QUANTUM): Remove, replacing with ...
1685 (selection_quantum): ... new function, which avoids overflow.
1687 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1688 assumption that selection length fits in 'int'.
1689 (x_reply_selection_request, x_handle_selection_request)
1690 (x_get_window_property, receive_incremental_selection)
1691 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1692 (lisp_data_to_selection_data, clean_local_selection_data):
1693 Use ptrdiff_t, not int, to record length of selection.
1694 (x_reply_selection_request, x_get_window_property)
1695 (receive_incremental_selection, x_property_data_to_lisp):
1696 Redo calculations to avoid overflow.
1697 (x_reply_selection_request): When sending hint, ceiling it at
1698 X_LONG_MAX rather than relying on wraparound overflow to send
1700 (x_get_window_property, receive_incremental_selection)
1701 (lisp_data_to_selection_data, x_property_data_to_lisp):
1702 Check for size-calculation overflow.
1703 (x_get_window_property, receive_incremental_selection)
1704 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1705 Don't store size until memory allocation succeeds.
1706 (x_get_window_property): Plug memory leak on memory exhaustion.
1707 Don't double-block input; malloc is safe here. Don't assume 2**34
1708 - 4 fits in unsigned long. Add an xassert to check
1709 XGetWindowProperty overflow. Be more careful about overflow
1710 calculations, and distinguish size from memory overflow better.
1711 (receive_incremental_selection): When tracing, don't assume
1712 unsigned int is less than INT_MAX.
1713 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1714 harmful) conversions of unsigned short to int.
1715 (lisp_data_to_selection_data): Don't assume that integers
1716 in the range -65535 through -1 fit in an X unsigned short.
1717 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1718 result parameters unless successful. Rely on cons_to_unsigned
1719 to report problems with elements; the old code wasn't right anyway.
1720 (x_check_property_data): Check for int overflow; we cannot use
1721 a wider type due to X limits.
1722 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1724 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1726 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1727 (x_term_init): Check for size calculation overflow.
1728 (x_color_cells): Don't store size until memory allocation succeeds.
1729 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1730 Don't assume alloca size is less than MAX_ALLOCA.
1731 (x_term_init): Don't assume length fits in int (sprintf is limited
1734 Use ptrdiff_t for composition IDs.
1735 * character.c (lisp_string_width):
1736 * composite.c (composition_table_size, n_compositions)
1737 (get_composition_id, composition_gstring_from_id):
1738 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1739 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1740 * window.c (Frecenter):
1741 Use ptrdiff_t, not int, for composition IDs.
1742 * composite.c (get_composition_id): Check for integer overflow.
1743 * composite.h: Adjust prototypes to match the above changes.
1745 Use ptrdiff_t for hash table indexes.
1746 * category.c (hash_get_category_set):
1747 * ccl.c (ccl_driver):
1748 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1749 * coding.c (coding_system_charset_list, detect_coding_system):
1750 * coding.h (struct coding_system.id):
1751 * composite.c (get_composition_id, gstring_lookup_cache):
1752 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1753 * image.c (xpm_get_color_table_h):
1754 * lisp.h (hash_lookup, hash_put):
1755 * minibuf.c (Ftest_completion):
1756 Use ptrdiff_t for hash table indexes, not int (which is too
1757 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1758 32-bit --with-wide-int hosts).
1760 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1761 Add a FIXME comment about memory leaks.
1762 (syms_of_charset): Don't assume xmalloc returns.
1764 Don't assume that stated character widths fit in int.
1765 * character.c (Fchar_width, c_string_width, lisp_string_width):
1766 * character.h (CHAR_WIDTH):
1767 * indent.c (MULTIBYTE_BYTES_WIDTH):
1768 Use sanitize_char_width to avoid undefined and/or bad behavior
1769 with outlandish widths.
1770 * character.h (sanitize_tab_width): Rename from sanitize_width,
1771 now that we have two such functions. All uses changed.
1772 (sanitize_char_width): New inline function.
1774 Don't assume that tab-width fits in int.
1775 * character.h (sanitize_width): New inline function.
1776 (SANE_TAB_WIDTH): New macro.
1777 (ASCII_CHAR_WIDTH): Use it.
1778 * indent.c (sane_tab_width): Remove. All uses replaced by
1779 SANE_TAB_WIDTH (current_buffer).
1780 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1782 * fileio.c: Integer overflow issues with file modes.
1783 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1785 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1786 Remove unreachable code.
1787 (read_hex, load_charset_map_from_file): Check for integer overflow.
1789 * xterm.c: don't go over XClientMessageEvent limit
1790 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1791 (x_send_scroll_bar_event): Likewise. Check that the size does not
1792 exceed limits imposed by XClientMessageEvent, as well as the usual
1793 ptrdiff_t and size_t limits.
1795 * keyboard.c: Overflow, signedness and related fixes.
1796 (make_lispy_movement): Use same integer type in forward decl
1797 that is used in the definition.
1798 (read_key_sequence, keyremap_step):
1799 Change bufsize argument back to int, undoing my 2011-03-30 change.
1800 We prefer signed types, and int is wide enough here.
1801 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1802 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1803 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1804 length, not size_t. Use ptrdiff_t for index, not int.
1805 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1806 possibility of integer overflow.
1808 Overflow, signedness and related fixes for images.
1810 * dispextern.h (struct it.stack[0].u.image.image_id)
1811 (struct_it.image_id, struct image.id, struct image_cache.size)
1812 (struct image_cache.used, struct image_cache.ref_count):
1813 * gtkutil.c (update_frame_tool_bar):
1814 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1815 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1816 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1817 * nsmenu.m (update_frame_tool_bar):
1818 * xdisp.c (calc_pixel_width_or_height):
1819 * xfns.c (image_cache_refcount):
1820 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1821 on typical 64-bit hosts.
1823 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1824 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1825 Omit unnecessary casts to int.
1826 (parse_image_spec): Check that integers fall into 'int' range
1827 when the callers expect that.
1828 (image_ascent): Redo ascent calculation to avoid int overflow.
1829 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1830 (lookup_image): Remove unnecessary tests.
1831 (xbm_image_p): Locals are now of int, not EMACS_INT,
1832 since parse_image_check makes sure they fit into int.
1833 (png_load, gif_load, svg_load_image):
1834 Prefer int to unsigned where either will do.
1835 (tiff_handler): New function, combining the cores of the
1836 old tiff_error_handler and tiff_warning_handler.
1837 This function is rewritten to use vsnprintf and thereby avoid
1838 stack buffer overflows. It uses only the features of vsnprintf
1839 that are common to both POSIX and native Microsoft.
1840 (tiff_error_handler, tiff_warning_handler): Use it.
1841 (tiff_load, gif_load, imagemagick_load_image):
1842 Don't assume :index value fits in 'int'.
1843 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1844 (imagemagick_load_image): Check that crop parameters fit into
1845 the integer types that MagickCropImage accepts. Don't assume
1846 Vimagemagick_render_type has a nonnegative value. Don't assume
1847 size_t fits in 'long'.
1848 (gs_load): Use printmax_t to print the widest integers possible.
1849 Check for integer overflow when computing image height and width.
1851 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1853 * xdisp.c (redisplay_window): Don't force window start if point
1854 will be invisible in the resulting window. (Bug#9324)
1856 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1858 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1859 the display spec is of the form `(space ...)'.
1860 (handle_display_spec): Return the value returned by
1861 handle_single_display_spec, not just 1 or zero.
1862 (handle_single_display_spec): If the display spec is of the form
1863 `(space ...)', and specifies display in the text area, return 2
1865 (try_cursor_movement): Check for the need to scroll more
1866 accurately, and prefer exact match for point under bidi.
1867 Don't advance `row' beyond the last row of the window.
1869 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1870 into disp_prop; all users changed.
1872 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1873 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1874 for the text covered by the display property.
1876 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1878 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1879 Change return value to nil.
1880 (Frecord_buffer): Delete unused function.
1882 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1884 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1885 buffers, return left-to-right.
1886 (set_cursor_from_row): Consider candidate row a win if its glyph
1887 represents a newline and point is on that newline. Fixes cursor
1888 positioning on the newline at EOL of R2L text within L2R
1889 paragraph, and vice versa.
1890 (try_cursor_movement): Check continued rows, in addition to
1891 continuation rows. Fixes unwarranted scroll when point enters a
1892 continued line of R2L text within an L2R paragraph, or vice versa.
1893 (cursor_row_p): Consider the case of point being equal to
1894 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1895 from the end of a short line to the beginning of a continued line
1896 of R2L text within L2R paragraph.
1897 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1898 composed characters.
1900 * bidi.c (bidi_check_type): Use xassert.
1901 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1904 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1906 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1909 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1911 * nsfont.m (ns_otf_to_script): Fix typo.
1913 2011-08-22 Kenichi Handa <handa@m17n.org>
1915 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1916 extra slot even if the purpose is char-code-property-table.
1918 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1920 * xdisp.c (redisplay_window): When computing centering_position,
1921 account for the height of the header line. (Bug#8874)
1923 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1924 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1925 candidate is selected by the mouse, and that candidate has a
1926 composed character under the mouse.
1928 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1929 coordinates reported by pos-visible-in-window-p for a composed
1930 character in column zero.
1932 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1934 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1936 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1938 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1939 consider it a hit if to_charpos is anywhere in the range of the
1940 composed buffer positions.
1942 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1944 * image.c (gif_load): Don't assume that each subimage has the same
1945 dimensions as the base image. Handle disposal method that is
1946 "undefined" by the gif spec (Bug#9335).
1948 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1950 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1951 (Fcondition_case): Document `debug' symbol in error handler.
1953 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1955 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1956 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1957 from an Org mode buffer to a Speedbar frame.
1959 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1960 a composition, take its buffer position from IT->cmp_it.charpos.
1961 Fixes cursor positioning at the beginning of a line that begins
1962 with a composed character.
1964 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1966 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1967 character bidirectional type, use STRONG_L instead. Fixes crashes
1968 in a buffer produced by `describe-categories'.
1970 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1971 members before the level stack, so they would be saved and
1972 restored when copying iterator state. Fixes incorrect reordering
1973 around TABs covered by display properties.
1975 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1977 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
1979 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1981 * eval.c (internal_condition_case, internal_condition_case_1)
1982 (internal_condition_case_2, internal_condition_case_n):
1983 Remove unnecessary aborts (Bug#9081).
1985 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1987 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1988 has no `load' handler, try opening the file locally. (Bug#9311)
1990 2011-08-16 Ken Brown <kbrown@cornell.edu>
1992 * gmalloc.c: Expand comment.
1994 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1996 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1997 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1999 2011-08-16 Ken Brown <kbrown@cornell.edu>
2001 Fix memory allocation problems in Cygwin build (Bug#9273).
2003 * unexcw.c ( __malloc_initialized): Declare external variable.
2004 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2006 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2008 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2010 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2012 [CYGWIN] (special_realloc): New function.
2013 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2014 requests to realloc storage in the static heap.
2016 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2018 * bidi.c (bidi_initialize): Remove unused local.
2020 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2023 * biditype.h: Remove file.
2024 * makefile.w32-in ($(BLD)/bidi.$(O)):
2025 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2027 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2029 * chartab.c: Improve commentary for the uniprop_table API.
2031 * bidi.c (bidi_paragraph_init): Support zero value of
2032 bidi_ignore_explicit_marks_for_paragraph_level.
2033 (bidi_initialize): Use uniprop_table instead of including
2034 biditype.h and bidimirror.h.
2036 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2037 coordinates of the iterator when restoring from ppos_it.
2040 2011-08-14 Kenichi Handa <handa@m17n.org>
2042 * process.c (create_process): Call setup_process_coding_systems
2043 after the pid of the process is set to -1 (Bug#8162).
2045 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2047 * xdisp.c (move_it_in_display_line_to): Don't invoke
2048 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2049 ppos_it. Fixes vertical cursor motion when line beginning is
2050 covered by an image. (Bug#9296)
2052 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2054 * nsterm.h (ns_run_ascript): Declare.
2055 (NSAPP_DATA2_RUNASSCRIPT): Define.
2057 * nsfns.m (as_script, as_result, as_status): New static variables.
2058 (ns_run_ascript): New function.
2059 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2060 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2061 the event loop. Get status from as_status (Bug#7276).
2063 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2064 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2065 the event loop (Bug#7276).
2067 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2069 * gnutls.c (QCgnutls_bootprop_priority)
2070 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2071 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2072 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2073 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2074 (QCgnutls_bootprop_verify_hostname_error)
2075 (QCgnutls_bootprop_callbacks_verify): Rename from
2076 Qgnutls_bootprop_..., all uses changed.
2078 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2081 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2083 * xfaces.c (Qframe_set_background_mode): Now static.
2084 * dispextern.h (Qframe_set_background_mode): Remove decl.
2086 * process.c (Fnetwork_interface_info): Declare local only if needed.
2088 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2090 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2091 (Fnetwork_interface_list): Allocate in increments of bytes instead
2092 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2093 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2095 (struct ifflag_def): notrailers is smart on OSX.
2096 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2097 Get hardware address with getifaddrs if available.
2099 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2101 * xdisp.c (iterate_out_of_display_property): xassert that
2102 IT->position is set to within IT->object's boundaries. Break from
2103 the loop as soon as EOB is reached; avoids infloops in redisplay
2104 when IT->position is set up wrongly due to some bug.
2105 Set IT->current to match the bidi iterator unconditionally.
2106 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2107 entry. Force push_it to save on the stack the current
2108 buffer/string position, to be restored by pop_it. Fix flags in
2109 the iterator structure wrt the object coming from a display
2110 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2111 properties. (Bug#9284)
2113 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2115 * fontset.c (fontset_get_font_group): Add proper type checks.
2118 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2120 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2121 and LC_VERSION_MIN_MACOSX.
2122 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2123 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2125 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2127 * xdisp.c (forward_to_next_line_start): Allow to use the
2128 no-display-properties-and-no-overlays under bidi display.
2129 Set disp_pos in the bidi iterator to avoid searches for display
2130 properties and overlays.
2132 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2134 * editfns.c (Fset_time_zone_rule): Document relationship with the
2137 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2138 the font entity extracted from the cache (Bug#8109).
2140 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2142 * composite.c (autocmp_chars): Don't reset point. That is done by
2143 restore_point_unwind (Bug#5984).
2145 2011-08-07 Juri Linkov <juri@jurta.org>
2147 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2148 to show the arg `TIME' instead of `TIMEVAL'.
2150 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2152 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2153 display property strides EOL and includes a newline, as in
2154 longlines-mode. (Bug#9254)
2155 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2156 word-wrap under bidirectional display. (Bug#9224)
2158 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2159 is non-zero, even if the data buffer is NULL. Fixes a crash in
2160 vertical-motion with longlines-mode. (Bug#9254)
2162 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2164 * bidi.c <bidi_cache_total_alloc>: Now static.
2165 (bidi_initialize): Initialize bidi_cache_total_alloc.
2167 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2170 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2171 amount allocated this far in `bidi_cache_total_alloc'.
2172 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2173 non-zero, only free the data buffer without restoring the cache
2174 contents. All callers changed.
2176 * dispextern.h (bidi_unshelve_cache): Update prototype.
2178 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2179 (move_it_in_display_line, move_it_to)
2180 (move_it_vertically_backward, move_it_by_lines): Replace the call
2181 to xfree to an equivalent call to bidi_unshelve_cache.
2182 (move_it_in_display_line_to): Fix logic of returning
2183 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2185 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2187 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2188 came from a string character with a `cursor' property. (Bug#9229)
2190 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2192 * Makefile.in (LIB_PTHREAD): New variable.
2193 (LIBES): Add LIB_PTHREAD (Bug#9216).
2195 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2196 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2198 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2200 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2202 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2204 * xterm.c (x_find_topmost_parent): New function.
2205 (x_set_frame_alpha): Find topmost parent window with
2206 x_find_topmost_parent and set the property there also (bug#9181).
2207 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2209 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2211 * callproc.c (Fcall_process): Avoid vfork clobbering
2212 the local vars buffer, coding_systems, current_dir.
2214 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2216 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2218 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2220 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2221 so that it is not optimized away.
2223 * xdisp.c (compute_display_string_pos): Remove unused local.
2225 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2227 Fix slow cursor motion and scrolling in large buffers with
2228 selective display, like Org Mode buffers. (Bug#9218)
2230 * dispextern.h (struct bidi_it): New member disp_prop_p.
2232 * xdisp.c: Remove one-slot cache of display string positions.
2233 (compute_display_string_pos): Accept an additional argument
2234 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2235 for a display string or property. If found, set DISP_PROP_P
2238 * bidi.c (bidi_fetch_char): Accept an additional argument
2239 DISP_PROP_P, and pass it to compute_display_string_pos.
2240 Only handle text covered by a display string if DISP_PROP_P is returned
2241 non-zero. All callers of bidi_fetch_char changed.
2243 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2245 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2247 2010-12-03 Don March <don@ohspite.net>
2249 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2250 last character M-[char] is translated to ESC [char] (bug#7541).
2252 2011-08-02 Kenichi Handa <handa@m17n.org>
2254 * lisp.h (uniprop_table): Extern it.
2256 * chartab.c (uniprop_table): Make it non-static.
2258 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2260 * xdisp.c (forward_to_next_line_start): Accept additional argument
2261 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2263 (reseat_at_next_visible_line_start): Use the bidi iterator state
2264 returned by forward_to_next_line_start to restore the state of
2265 it->bidi_it after backing up to previous newline. (Bug#9212)
2267 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2269 * regex.c (re_comp): Protoize.
2270 (re_exec): Fix return type.
2271 (regexec): Fix type of `ret'. (Bug#9203)
2273 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2275 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2276 This is needed if max-image-size is a floating-point number.
2278 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2280 * print.c (print_object): Print empty symbol as ##.
2282 * lread.c (read1): Read ## as empty symbol.
2284 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2286 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2287 setting frame foreground color (Bug#9175).
2288 (x_set_background_color): Likewise.
2290 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2291 contents (Bug#9176).
2292 (EmacsTooltip -init): Remove bezels and add shadows to
2295 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2296 or scroll bar (Bug#8470).
2298 * nsfont.m (nsfont_open): Remove assignment to voffset and
2299 unnecessary vars hshink, expand, hd, full_height, min_height.
2300 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2302 * nsterm.h (nsfont_info): Remove voffset field.
2304 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2306 Implement strike-through and overline on NextStep (Bug#8863).
2308 * nsfont.m (nsfont_open): Use underline position provided by font,
2309 instead of hard-coded value of 2.
2310 (nsfont_draw): Call ns_draw_text_decoration instead.
2312 * nsterm.h: Add declaration for ns_draw_text_decoration.
2314 * nsterm.m (ns_draw_text_decoration): New function for drawing
2315 underline, overline, and strike-through.
2316 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2317 ns_draw_text_decoration. Change treatment of cursor drawing to
2318 accommodate underlining, etc.
2320 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2322 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2325 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2327 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2328 Without this fix, if a signal arrives just after memory fills up,
2329 'malloc' might be invoked reentrantly.
2331 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2332 In other words, assume that every image size is allowed, on non-X
2333 hosts. This assumption is probably wrong, but it lets Emacs compile.
2335 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2337 * regex.c (re_iswctype): Convert return values to boolean.
2339 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2341 * xdisp.c (compute_display_string_pos): Don't use cached display
2342 string position if the buffer had its restriction changed.
2345 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2347 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2349 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2351 Integer signedness and overflow and related fixes. (Bug#9079)
2353 * bidi.c: Integer size and overflow fixes.
2354 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2355 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2356 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2357 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2358 (bidi_find_other_level_edge):
2359 Use ptrdiff_t instead of EMACS_INT where either will do.
2360 This works better on 32-bit hosts configured --with-wide-int.
2361 (bidi_cache_ensure_space): Check for size-calculation overflow.
2362 Use % rather than repeated addition, for better worst-case speed.
2363 Don't set bidi_cache_size until after xrealloc returns, because it
2365 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2366 (bidi_cache_ensure_space): Also check that the bidi cache size
2367 does not exceed that of the largest Lisp string or buffer. See Eli
2368 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2370 * alloc.c (__malloc_size_t): Remove.
2371 All uses replaced by size_t. See Andreas Schwab's note
2372 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2374 * image.c: Improve checking for integer overflow.
2375 (check_image_size): Assume that f is nonnull, since
2376 it is always nonnull in practice. This is one less thing to
2377 worry about when checking for integer overflow later.
2378 (x_check_image_size): New function, which checks for integer
2379 overflow issues inside X.
2380 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2381 This removes the need for a memory_full check.
2382 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2383 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2384 (xbm_read_bitmap_data): Change locals back to 'int', since
2385 their values must fit in 'int'.
2386 (xpm_load_image, png_load, tiff_load):
2387 Invoke x_create_x_image_and_pixmap earlier,
2388 to avoid much needless work if the image is too large.
2389 (tiff_load): Treat overly large images as if
2390 x_create_x_image_and_pixmap failed, not as malloc failures.
2391 (gs_load): Use x_check_image_size.
2393 * gtkutil.c: Omit integer casts.
2394 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2395 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2397 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2399 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2400 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2401 would wrongly return t on a 64-bit host.
2403 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2404 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2405 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2406 and therefore cause GCC to emit a bogus diagnostic in some cases.
2408 * image.c: Integer signedness and overflow and related fixes.
2409 This is not an exhaustive set of fixes, but it's time to
2410 record what I've got.
2411 (lookup_pixel_color, check_image_size): Remove redundant decls.
2412 (check_image_size): Don't assume that arbitrary EMACS_INT values
2413 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2414 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2415 (tiff_load, imagemagick_load_image):
2416 Check for overflow in size calculations.
2417 (x_create_x_image_and_pixmap): Remove unnecessary test for
2418 xmalloc returning NULL; that can't happen.
2419 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2420 (xpm_color_bucket): Use better integer hashing function.
2421 (xpm_cache_color): Don't possibly over-allocate memory.
2422 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2423 (gif_memory_source):
2424 Use ptrdiff_t, not int or size_t, to record sizes.
2425 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2426 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2427 either works, as we prefer signed integers.
2428 (tiff_read_from_memory, tiff_write_from_memory):
2429 Return tsize_t, not size_t, since that's what the TIFF API wants.
2430 (tiff_read_from_memory): Don't fail simply because the read would
2431 go past EOF; instead, return a short read.
2432 (tiff_load): Omit no-longer-needed casts.
2433 (Fimagemagick_types): Don't assume size fits into 'int'.
2435 Improve hashing quality when configured --with-wide-int.
2436 * fns.c (hash_string): New function, taken from sxhash_string.
2437 Do not discard information about ASCII character case; this
2438 discarding is no longer needed.
2439 (sxhash-string): Use it. Change sig to match it. Caller changed.
2440 * lisp.h: Declare it.
2441 * lread.c (hash_string): Remove, since we now use fns.c's version.
2442 The fns.c version returns a wider integer if --with-wide-int is
2443 specified, so this should help the quality of the hashing a bit.
2445 * emacs.c: Integer overflow minor fix.
2446 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2447 Define only if GNU_LINUX.
2448 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2450 * dispnew.c: Integer signedness and overflow fixes.
2451 Remove unnecessary forward decls, that were a maintenance hassle.
2452 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2454 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2455 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2456 (prepare_desired_row, line_draw_cost):
2457 Use int, not unsigned, where either works.
2458 (save_current_matrix, restore_current_matrix):
2459 Use ptrdiff_t, not size_t, where either works.
2460 (init_display): Check for overflow more accurately, and without
2461 relying on undefined behavior.
2463 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2464 Remove, replacing with the new symbols in lisp.h. All uses changed.
2465 * fileio.c (make_temp_name):
2466 * filelock.c (lock_file_1, lock_file):
2467 * xdisp.c (message_dolog):
2468 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2469 Use pMd etc. instead.
2470 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2471 replacing the pWIDE etc. symbols removed from editfns.c.
2473 * keyboard.h (num_input_events): Now uintmax_t.
2474 This is (very slightly) less likely to mess up due to wraparound.
2477 * buffer.c: Integer signedness fixes.
2478 (alloc_buffer_text, enlarge_buffer_text):
2479 Use ptrdiff_t rather than size_t when either will do, as we prefer
2482 * alloc.c: Integer signedness and overflow fixes.
2483 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2484 (__malloc_size_t): Default to size_t, not to int.
2485 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2486 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2487 Prefer ptrdiff_t to size_t when either would do, as we prefer
2489 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2490 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2491 Now const. Initialize with values that are in range even if char
2493 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2494 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2495 These functions do the right thing with sizes > 2**32.
2496 (check_depth): Now ptrdiff_t, not int.
2497 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2498 Adjust to new way of storing sizes. Check for size overflow bugs
2500 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2501 slightly wrong anyway, as it missed one instance of
2502 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2503 (refill_memory_reserve): Omit needless cast to size_t.
2504 (mark_object_loop_halt): Mark as externally visible.
2506 * xselect.c: Integer signedness and overflow fixes.
2507 (Fx_register_dnd_atom, x_handle_dnd_message):
2508 Use ptrdiff_t, not size_t, since we prefer signed.
2509 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2510 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2511 x_dnd_atoms_size and x_dnd_atoms_length.
2513 * doprnt.c: Prefer signed to unsigned when either works.
2515 * doprnt.c (doprnt):
2517 * xdisp.c (vmessage):
2518 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2519 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2520 prefer signed arithmetic to avoid comparison confusion.
2521 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2522 but is a bit tricky.
2524 Assume freestanding C89 headers, string.h, stdlib.h.
2525 * data.c, doprnt.c, floatfns.c, print.c:
2526 Include float.h unconditionally.
2527 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2528 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2529 * regex.c: Likewise for stddef.h, string.h.
2530 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2531 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2532 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2533 (STDC_HEADERS): Remove obsolete defines.
2534 * sysdep.c: Include limits.h unconditionally.
2536 Assume support for memcmp, memcpy, memmove, memset.
2537 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2538 * regex.c (memcmp, memcpy):
2539 Remove; we assume C89 now.
2541 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2542 (__malloc_safe_bcopy): Remove; no longer needed.
2544 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2545 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2546 well either way, and we prefer signed to unsigned.
2548 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2550 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2551 closes the connection while we're reading (bug#9182).
2553 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2555 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2556 are specified (Bug#9168).
2558 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2560 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2561 Found by GCC static checking and --with-wide-int on a 32-bit host.
2563 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2565 * xdisp.c (compute_display_string_pos): Fix logic of caching
2566 previous display string position. Initialize cached_prev_pos to
2567 -1. Fixes slow-down at the beginning of a buffer.
2569 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2571 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2572 for attrs[LFACE_FONTSET_INDEX].
2574 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2576 * xml.c (parse_region): Remove unused local
2577 that was recently introduced.
2579 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2581 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2582 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2584 * xdisp.c (move_it_in_display_line_to): Record the best matching
2585 position for TO_CHARPOS while scanning the line, and restore it on
2586 exit if none of the characters scanned was an exact match.
2587 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2588 when exact match is impossible due to invisible text, and the
2589 lines are truncated.
2591 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2593 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2596 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2598 Fix a significant slow-down of cursor motion with C-n, C-p,
2599 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2600 auto-repeat under bidi redisplay in fontified buffers.
2601 * xdisp.c (compute_stop_pos_backwards): New function.
2602 (next_element_from_buffer): Call compute_stop_pos_backwards to
2603 find a suitable prev_stop when we find ourselves before
2605 (reseat): Don't look for prev_stop, as that could mean a very long
2607 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2608 <cached_disp_overlay_modiff>: Cache for last found display string
2610 (compute_display_string_pos): Return the cached position if asked
2611 about the same buffer in the same area of character positions, and
2612 the buffer wasn't changed since the time the display string
2613 position was cached.
2615 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2617 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2618 is an integer, which is important for empty lines. (Bug#9149)
2620 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2622 * frame.c (Fmodify_frame_parameters): In tty case, update the
2623 default face if necessary (Bug#4238).
2625 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2627 * editfns.c (Fstring_to_char): No need to explain what a character
2628 is in the docstring (Bug#6576).
2630 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2632 * xml.c (parse_region): Make sure we always return a tree.
2634 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2636 * xml.c (parse_region): If a document contains only comments,
2639 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2641 * xml.c (make_dom): Return comments, too.
2643 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2646 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2647 and the surrounding thread.
2648 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2649 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2650 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2652 * s/openbsd.h (BROKEN_SIGIO): Define.
2653 * unexelf.c (unexec) [__OpenBSD__]:
2654 Don't update the .mdebug section of the Alpha COFF symbol table.
2656 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2658 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2661 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2663 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2664 This fixes some race conditions on the permissions of any newly
2667 * alloc.c (valid_pointer_p): Use pipe, not open.
2668 This fixes some permissions issues when debugging.
2670 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2671 If fchown fails to set both uid and gid, try to set just gid,
2672 as that is sometimes allowed. Adjust the file's mode to eliminate
2673 setuid or setgid bits that are inappropriate if fchown fails.
2675 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2677 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2678 to compare Lisp_Objects.
2679 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2680 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2681 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2683 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2685 * lread.c (read_integer): Unread even EOF character.
2686 (read1): Likewise. Properly record start position of symbol.
2688 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2689 symbol character follows.
2691 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2693 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2694 This works around a problem with the previous change to Fcopy_file.
2695 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2696 and without this change, GCC might complain about discarding
2697 fchown's return value.
2699 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2701 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2703 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2705 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2707 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2709 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2710 it's used from the C level.
2712 * process.c: Use the same condition for POLL_FOR_INPUT in both
2713 keyboard.c and process.c (bug#1858).
2715 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2717 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2718 (Fgnutls_boot): Use it.
2720 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2722 * doc.c (Fsubstitute_command_keys): Revert last change.
2724 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2726 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2727 quotes the next character, and doesn't affect other longer
2728 sequences (bug#8935).
2730 * lread.c (syms_of_lread): Clarify that is isn't only
2731 `eval-buffer' and `eval-defun' that's affected by
2732 `lexical-binding' (bug#8460).
2734 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2736 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2737 bidi redisplay when a line includes both an image and is truncated.
2739 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2741 Fix minor problems found by static checking.
2742 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2743 (elsz): Now a signed constant, not a size_t var. We prefer signed
2744 types to unsigned, to avoid integer comparison confusion. Without
2745 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2746 "cannot optimize loop, the loop counter may overflow", a symptom
2748 * indent.c (Fvertical_motion): Mark locals as initialized.
2749 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2751 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2753 * search.c (Fre_search_backward): Mention `case-fold-search' in
2754 all the re_search_* functions (bug#8138).
2756 * keyboard.c (Fopen_dribble_file): Document when the file is
2759 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2761 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2764 Support bidi reordering of display and overlay strings.
2765 * xdisp.c (compute_display_string_pos)
2766 (compute_display_string_end): Accept additional argument STRING.
2767 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2768 (reseat_to_string): Initialize bidi_it->string.s and
2769 bidi_it->string.schars.
2770 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2771 NULL (avoids a crash in bidi_paragraph_init).
2772 Initialize itb.string.lstring.
2773 (init_iterator): Call bidi_init_it only of a valid
2774 buffer position was specified. Initialize paragraph_embedding to
2776 (reseat_to_string): Initialize the bidi iterator.
2777 (display_string): If we need to ignore text properties of
2778 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2779 original value of -1 will not work with bidi.)
2780 (compute_display_string_pos): First arg is now struct
2781 `text_pos *'; all callers changed. Support display properties on
2783 (compute_display_string_end): Support display properties on Lisp
2785 (init_iterator, reseat_1, reseat_to_string): Initialize the
2786 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2787 when iterating on a string not from display properties).
2788 (compute_display_string_pos, compute_display_string_end):
2789 Fix calculation of the object to scan. Fixes an error when using
2791 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2792 base_level_stop; instead, set base_level_stop to BEGV.
2793 Fixes crashes in vertical-motion.
2794 (next_element_from_buffer): Improve commentary for when
2795 the iterator is before prev_stop.
2796 (init_iterator): Initialize bidi_p from the default value of
2797 bidi-display-reordering, not from buffer-local value. Use the
2798 buffer-local value only if initializing for buffer iteration.
2799 (handle_invisible_prop): Support invisible properties on strings
2800 that are being bidi-reordered.
2801 (set_iterator_to_next): Support bidi reordering of C strings and
2803 (next_element_from_string): Support bidi reordering of Lisp
2805 (handle_stop_backwards): Support Lisp strings as well.
2806 (display_string): Support display of R2L glyph rows.
2807 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2808 (init_iterator): Don't initialize it->bidi_p for strings
2810 (reseat_to_string): Initialize it->bidi_p for strings here.
2811 (next_element_from_string, next_element_from_c_string)
2812 (next_element_from_buffer): Add xassert's for correspondence
2813 between IT's object being iterated and it->bidi_it.string
2815 (face_before_or_after_it_pos): Support bidi iteration.
2816 (next_element_from_c_string): Handle the case of the first string
2817 character that is not the first one in the visual order.
2818 (get_visually_first_element): New function, refactored from common
2819 parts of next_element_from_buffer, next_element_from_string, and
2820 next_element_from_c_string.
2821 (tool_bar_lines_needed, redisplay_tool_bar)
2822 (display_menu_bar): Force left-to-right direction. Add a FIXME
2823 comment for making that be controlled by a user option.
2824 (push_it, pop_it): Save and restore the state of the
2825 bidi iterator. Save and restore the bidi_p flag.
2826 (pop_it): Iterate out of display property for string iteration as
2828 (iterate_out_of_display_property): Support iteration over strings.
2829 (handle_single_display_spec): Set up it->bidi_it for iteration
2830 over a display string, and call bidi_init_it.
2831 (handle_single_display_spec, next_overlay_string)
2832 (get_overlay_strings_1, push_display_prop): Set up the bidi
2833 iterator for displaying display or overlay strings.
2834 (forward_to_next_line_start): Don't use the shortcut if
2836 (back_to_previous_visible_line_start): If handle_display_prop
2837 pushed the iterator stack, restore the internal state of the bidi
2838 iterator by calling bidi_pop_it same number of times.
2839 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2840 and we are bidi-iterating, don't decrement the iterator position;
2841 instead, set the first_elt flag in the bidi iterator, to produce
2843 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2844 (push_display_prop): xassert that we are iterating a buffer.
2845 (push_it, pop_it): Save and restore paragraph_embedding member.
2846 (handle_single_display_spec, next_overlay_string)
2847 (get_overlay_strings_1, reseat_1, reseat_to_string)
2848 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2849 correctly. Don't assume unibyte strings are not bidi-reordered.
2850 (compute_display_string_pos)
2851 (compute_display_string_end): Fix handling the case of C string.
2852 (push_it, pop_it): Save and restore from_disp_prop_p.
2853 (handle_single_display_spec, push_display_prop): Set the
2854 from_disp_prop_p flag.
2855 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2856 (pop_it): Call iterate_out_of_display_property only if we are
2857 popping after iteration over a string that came from a display
2858 property. Fix a typo in popping stretch info. Add an assertion
2859 for verifying that the iterator position is in sync with the bidi
2861 (handle_single_display_spec, get_overlay_strings_1)
2862 (push_display_prop): Fix initialization of paragraph direction for
2863 string when that of the parent object is not yet determined.
2864 (reseat_1): Call bidi_init_it to resync the bidi
2865 iterator with IT's position. (Bug#7616)
2866 (find_row_edges): If ROW->start.pos gives position
2867 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2868 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2869 Reset the from_disp_prop_p flag.
2870 (SAVE_IT, RESTORE_IT): New macros.
2871 (pos_visible_p, face_before_or_after_it_pos)
2872 (back_to_previous_visible_line_start)
2873 (move_it_in_display_line_to, move_it_in_display_line)
2874 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2875 (try_scrolling, redisplay_window, display_line): Use them when
2876 saving a temporary copy of the iterator and restoring it back.
2877 (back_to_previous_visible_line_start, reseat_1)
2878 (init_iterator): Empty the bidi cache "stack".
2879 (move_it_in_display_line_to): If iterator ended up at
2880 EOL, but we never saw any buffer positions smaller than
2881 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2882 motion in bidi-reordered lines.
2883 (move_it_in_display_line_to): Record prev_method and prev_pos
2884 immediately before the call to set_iterator_to_next. Fixes cursor
2885 motion in bidi-reordered lines with stretch glyphs and strings
2886 displayed in margins. (Bug#8133) (Bug#8867)
2887 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2889 (pos_visible_p): Support positions in bidi-reordered lines.
2890 Save and restore bidi cache.
2892 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2893 (bidi_paragraph_info): Delete unused struct.
2894 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2895 (bidi_cache_start): New variable.
2896 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2898 (bidi_cache_fetch_state, bidi_cache_search)
2899 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2900 (bidi_cache_find, bidi_peek_at_next_level)
2901 (bidi_level_of_next_char, bidi_find_other_level_edge)
2902 (bidi_move_to_visually_next): Compare cache index with
2903 bidi_cache_start rather than with zero.
2904 (bidi_fetch_char): Accept new argument STRING; all callers
2905 changed. Support iteration over a string. Support strings with
2906 display properties. Support unibyte strings. Fix the type of
2907 `len' according to what STRING_CHAR_AND_LENGTH expects.
2908 (bidi_paragraph_init, bidi_resolve_explicit_1)
2909 (bidi_resolve_explicit, bidi_resolve_weak)
2910 (bidi_level_of_next_char, bidi_move_to_visually_next):
2911 Support iteration over a string.
2912 (bidi_set_sor_type, bidi_resolve_explicit_1)
2913 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2914 can now be zero (for strings); special values 0 and -1 were
2915 changed to -1 and -2, respectively.
2916 (bidi_char_at_pos): New function.
2917 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2918 Call it instead of FETCH_MULTIBYTE_CHAR.
2919 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2920 initialized to valid values.
2921 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2923 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2924 the test for valid cached positions. Fix the logic for looking up
2925 the sentinel state in the cache. GCPRO the Lisp string we are
2927 (bidi_push_it, bidi_pop_it): New functions.
2928 (bidi_initialize): Initialize the bidi cache start stack pointer.
2929 (bidi_cache_ensure_space): New function, refactored from part of
2930 bidi_cache_iterator_state. Don't assume the required size is just
2931 one BIDI_CACHE_CHUNK away.
2932 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2933 (bidi_count_bytes, bidi_char_at_pos): New functions.
2934 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2935 always valid if bidi_cache_idx is valid.
2936 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2937 is valid if it's going to be used.
2938 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2939 (bidi_cache_fetch_state, bidi_cache_search)
2940 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2941 (bidi_cache_iterator_state, bidi_cache_find)
2942 (bidi_find_other_level_edge, bidi_cache_start_stack):
2943 All variables related to cache indices are now EMACS_INT.
2945 * dispextern.h (struct bidi_string_data): New structure.
2946 (struct bidi_it): New member `string'. Make flag members be 1-bit
2947 fields, and put them last in the struct.
2948 (compute_display_string_pos, compute_display_string_end):
2950 (bidi_push_it, bidi_pop_it): Add prototypes.
2951 (struct iterator_stack_entry): New members bidi_p,
2952 paragraph_embedding, and from_disp_prop_p.
2953 (struct it): Member bidi_p is now a bit field 1 bit wide.
2954 (bidi_shelve_cache, bidi_unshelve_cache):
2957 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2958 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2959 and vector-like objects.
2961 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2962 cache around display iteration.
2964 * window.c (Fwindow_end, window_scroll_pixel_based)
2965 (displayed_window_lines, Frecenter): Save and restore the bidi
2966 cache around display iteration.
2968 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2970 * editfns.c (Fdelete_region): Clarify the use of the named
2971 parameters (bug#6788).
2973 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2975 * indent.c (Fvertical_motion): Set and restore w->pointm when
2976 saving and restoring the window's buffer (Bug#9006).
2978 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2980 * editfns.c (Fstring_to_char): Clarify just what is returned
2981 (bug#6576). Text by Eli Zaretskii.
2983 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2985 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2987 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2989 * buffer.c (mmap_find): Fix a typo.
2991 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2993 Fix execution of x selection hooks.
2994 * xselect.c (Qx_lost_selection_functions)
2995 (Qx_sent_selection_functions): New vars.
2996 (syms_of_xselect): DEFSYM them.
2997 (x_handle_selection_request): Pass Qx_sent_selection_functions
2998 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2999 (x_handle_selection_clear,x_clear_frame_selections):
3000 Pass Qx_lost_selection_functions rather than
3001 Vx_lost_selection_functions to Frun_hook_with_args.
3003 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3005 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3006 The old code sometimes used this field without initializing it.
3008 * alloc.c (gc_sweep): Don't read past end of array.
3009 In theory, the old code could also have corrupted Emacs internals,
3010 though it'd be very unlikely.
3012 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3014 * character.c (Fcharacterp): Don't advertise optional ignored
3015 argument. (Bug#4026)
3017 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3019 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3022 * window.c (Fset_window_start): Doc fix (bug#4199).
3023 (Fset_window_hscroll): Ditto.
3025 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3027 Fix minor new problems caught by GCC 4.6.1.
3028 * term.c (init_tty): Remove unused local.
3029 * xsettings.c (store_monospaced_changed): Define this function only
3030 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3033 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3035 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3037 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3039 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3040 are the mini-buffer and the echo area (bug#3320).
3042 * term.c (init_tty): Remove support for supdup, c10 and perq
3043 terminals, which are no longer supported (bug#1482).
3045 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3047 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3049 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3051 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3052 for non-popups (Bug#3642).
3054 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3056 * alloc.c (reset_malloc_hooks): Protoize.
3057 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3058 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3059 * cm.c (losecursor): Likewise.
3060 * data.c (fmod): Likewise.
3061 * dispnew.c (swap_glyphs_in_rows): Likewise.
3062 * emacs.c (memory_warning_signal): Likewise.
3063 * floatfns.c (float_error): Likewise.
3064 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3065 (otf_open, font_otf_capability, generate_otf_features)
3066 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3068 * image.c (pbm_read_file): Likewise.
3069 * indent.c (string_display_width): Likewise.
3070 * intervals.c (check_for_interval, search_for_interval)
3071 (inc_interval_count, count_intervals, root_interval)
3072 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3073 * lread.c (defalias): Likewise.
3074 * ralloc.c (r_alloc_check): Likewise.
3075 * regex.c (set_image_of_range_1, set_image_of_range)
3076 (regex_grow_registers): Likewise.
3077 * sysdep.c (strerror): Likewise.
3078 * termcap.c (valid_filename_p, tprint, main): Likewise.
3079 * tparam.c (main): Likewise.
3080 * unexhp9k800.c (run_time_remap, save_data_space)
3081 (update_file_ptrs, read_header, write_header, calculate_checksum)
3082 (copy_file, copy_rest, display_header): Likewise.
3083 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3085 * xdisp.c (check_it): Likewise.
3086 * xfaces.c (register_color, unregister_color, unregister_colors):
3088 * xfns.c (print_fontset_result): Likewise.
3089 * xrdb.c (member, fatal, main): Likewise.
3091 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3093 Fix minor problems found by static checking (Bug#9031).
3094 * chartab.c (char_table_set_range, map_sub_char_table):
3095 Remove unused locals.
3096 (uniprop_table): Now static.
3097 * composite.c (_work_char): Remove unused static var.
3099 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3101 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3103 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3105 * gtkutil.c (qttip_cb): Remove code without function.
3107 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3109 * w32.c (pthread_sigmask): New stub.
3111 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3113 Use pthread_sigmask, not sigprocmask (Bug#9010).
3114 sigprocmask is portable only for single-threaded applications, and
3115 Emacs can be multi-threaded when it uses GTK.
3116 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3118 * callproc.c (Fcall_process):
3119 * process.c (create_process):
3120 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3121 Use pthread_sigmask, not sigprocmask.
3123 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3125 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3126 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3129 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3131 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3132 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3133 (xg_hide_tooltip): Fix comment.
3135 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3136 in registerServicesMenuSendTypes.
3137 (validRequestorForSendType): Don't check ns_return_types.
3139 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3142 2011-07-08 Jason Rumney <jasonr@gnu.org>
3144 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3145 SH_SHOW for hidden windows (Bug#5482).
3147 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3148 frame struct members of non-existent frames (Bug#6284).
3150 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3152 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3153 variable firstTime not needed on OSX >= 10.6.
3154 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3155 >= 10.5. Use setKnobProportion, setDoubleValue.
3157 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3158 (MAC_OS_X_VERSION_10_5): Define if not defined.
3159 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3160 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3161 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3163 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3164 cString and lossyCString on OSX >= 10.4
3166 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3167 sizeToFit on OSX >= 10.2.
3169 * nsimage.m (allocInitFromFile): Don't use deprecated method
3170 bestRepresentationForDevice on OSX >= 10.6.
3172 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3175 * emacs.c: Declare unexec_init_emacs_zone.
3177 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3179 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3181 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3182 on svcsMenu (Bug#8842).
3184 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3186 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3188 * nsterm.m (QUTF8_STRING): Declare.
3189 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3190 (validRequestorForSendType): Return type is (id).
3191 Change indexOfObjectIdenticalTo to indexOfObject.
3192 Check if we have local selection before returning self (Bug#8842).
3193 (writeSelectionToPasteboard): Put local selection into paste board
3194 if we have a local selection (Bug#8842).
3195 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3197 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3198 (ns_get_local_selection): Declare.
3200 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3202 * keymap.c (describe_map_tree): Don't insert a double newline at
3203 the end of the buffer (bug#1169) and return whether we inserted
3206 * callint.c (Fcall_interactively): Change "reading args" to
3207 "providing args" to try to clarify what it does (bug#1010).
3209 2011-07-07 Kenichi Handa <handa@m17n.org>
3211 * composite.c (composition_compute_stop_pos): Ignore a static
3212 composition starting before CHARPOS (Bug#8915).
3214 * xdisp.c (handle_composition_prop): Likewise.
3216 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3218 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3221 2011-07-07 Kenichi Handa <handa@m17n.org>
3223 * character.h (unicode_category_t): New enum type.
3225 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3226 (Qchar_code_property_table): New variable.
3227 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3228 (UNIPROP_COMPRESSED_FORM_P): New macros.
3229 (char_table_ascii): Uncompress the compressed values.
3230 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3231 Uncompress the compressed values.
3232 (sub_char_table_ref_and_range): Likewise.
3233 (char_table_ref_and_range): Uncompress the compressed values.
3234 (sub_char_table_set): New arg is_uniprop. Callers changed.
3235 Uncompress the compressed values.
3236 (sub_char_table_set_range): Args changed. Callers changed.
3237 (char_table_set_range): Adjuted for the above change.
3238 (map_sub_char_table): Delete args default_val and parent. Add arg
3239 top. Give decoded values to a Lisp function.
3240 (map_char_table): Adjust for the above change. Give decoded
3241 values to a Lisp function. Gcpro more variables.
3242 (uniprop_table_uncompress)
3243 (uniprop_decode_value_run_length): New functions.
3244 (uniprop_decoder, uniprop_decoder_count): New variables.
3245 (uniprop_get_decoder, uniprop_encode_value_character)
3246 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3248 (uniprop_encoder, uniprop_encoder_count): New variables.
3249 (uniprop_get_encoder, uniprop_table)
3250 (Funicode_property_table_internal, Fget_unicode_property_internal)
3251 (Fput_unicode_property_internal): New functions.
3252 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3253 Sunicode_property_table_internal, Sget_unicode_property_internal,
3254 and Sput_unicode_property_internal. Defvar_lisp
3255 char-code-property-alist.
3257 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3258 Vunicode_category_table.
3260 * font.c (font_range): Adjust for the change of
3261 Vunicode_category_table.
3263 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3265 * m/iris4d.h: Remove file, move contents ...
3266 * s/irix6-5.h: ... here.
3268 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3270 Remove unportable assumption about struct layout (Bug#8884).
3271 * alloc.c (mark_buffer):
3272 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3273 (clone_per_buffer_values): Don't assume that
3274 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3275 This isn't true in general, and it's particularly not true
3276 if Emacs is configured with --with-wide-int.
3277 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3278 New macros, used in the buffer.c change.
3280 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3282 * xsettings.c: Use both GConf and GSettings if both are available.
3283 (store_config_changed_event): Add comment.
3284 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3285 (store_tool_bar_style_changed): New functions.
3286 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3287 (struct xsettings): Move font inside HAVE_XFT.
3288 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3289 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3290 Move inside HAVE_XFT.
3291 (something_changed_gsettingsCB): Rename from something_changedCB.
3292 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3294 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3295 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3296 (something_changed_gconfCB): Rename from something_changedCB.
3297 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3298 (parse_settings): Move check for font inside HAVE_XFT.
3299 (read_settings, apply_xft_settings): Add comment.
3300 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3301 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3302 call store_font_name_changed.
3303 (xft_settings_event): Add comment.
3304 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3305 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3306 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3307 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3308 (xsettings_initialize): Call init_gsettings last.
3309 (xsettings_get_system_font, xsettings_get_system_normal_font):
3312 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3314 Random fixes. E.g., (random) never returned negative values.
3315 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3316 subseconds part to the entropy, as that's a bit more random.
3317 Prefer signed to unsigned, since the signedness doesn't matter and
3318 in general we prefer signed. When given a limit, use a
3319 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3320 latter isn't right if USE_2_TAGS_FOR_INTS.
3321 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3322 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3324 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3326 * textprop.c (text_property_stickiness):
3327 Obey Vtext_property_default_nonsticky.
3328 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3329 * w32fns.c (syms_of_w32fns):
3330 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3332 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3334 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3335 This is more efficient than Ffile_directory_p and avoids a minor race.
3337 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3339 * buffer.c (Foverlay_put): Say what the return value is
3342 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3343 is a directory before asking whether to use the file name
3345 (barf_or_query_if_file_exists): Make the "File is a directory"
3346 error be more correct.
3348 * fns.c (Frequire): Remove the mention of the .gz files, since
3349 that's installation-specific, but keep the mention of
3350 `get-load-suffixes'.
3352 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3354 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3355 Report string overflow if the output is too long.
3357 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3359 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3360 (syms_of_gnutls): Remove duplicate DEFSYM for
3361 Qgnutls_bootprop_verify_hostname_error, an error for
3362 Qgnutls_bootprop_verify_error (which is no longer used).
3364 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3365 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3366 Also (re)move comments that are misplaced or no longer relevant.
3368 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3370 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3372 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3374 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3375 and background color parameters if they have been changed.
3377 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3379 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3381 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3383 * xsettings.c (SYSTEM_FONT): Define only when used.
3384 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3386 * keymap.c (access_keymap_1): Now static.
3388 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3390 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3391 leave any prefix arg for the up event (Bug#1586).
3393 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3395 * lread.c (syms_of_lread): Mention single symbols defined by
3396 `defvar' or `defconst' (bug#7154).
3398 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3399 (Frequire): Mention get-load-suffixes.
3401 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3403 * window.h (window): Remove clone_number slot.
3404 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3406 (make_parent_window, make_window, saved_window)
3407 (Fset_window_configuration, save_window_save): Don't deal with
3409 * buffer.c (Qclone_number): Remove declaration.
3410 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3412 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3414 Add multiple inheritance to keymaps.
3415 * keymap.c (Fmake_composed_keymap): New function.
3416 (Fset_keymap_parent): Simplify.
3417 (fix_submap_inheritance): Remove.
3418 (access_keymap_1): New function extracted from access_keymap to handle
3419 embedded parents and handle lists of maps.
3420 (access_keymap): Use it.
3421 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3422 (Fcopy_keymap): Handle embedded parents.
3423 (Fcommand_remapping, define_as_prefix): Simplify.
3424 (Fkey_binding): Simplify.
3425 (syms_of_keymap): Move minibuffer-local-completion-map,
3426 minibuffer-local-filename-completion-map,
3427 minibuffer-local-must-match-map, and
3428 minibuffer-local-filename-must-match-map to Elisp.
3429 (syms_of_keymap): Defsubr make-composed-keymap.
3430 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3431 (parse_menu_item): Trivial simplification.
3433 2011-07-01 Glenn Morris <rgm@gnu.org>
3435 * Makefile.in (SETTINGS_LIBS): Fix typo.
3437 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3439 * coding.c (Fencode_coding_string): Record the last coding system
3440 used, as the function doc string says (bug#8738).
3442 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3444 * xsettings.c (store_monospaced_changed): Take new font as arg and
3445 check for change against current_mono_font.
3446 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3447 (emacs_settings_constructor, emacs_settings_get_property)
3448 (emacs_settings_set_property, emacs_settings_class_init)
3449 (emacs_settings_init, gsettings_obj): Remove.
3450 (something_changedCB): New function for HAVE_GSETTINGS.
3451 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3452 with value as argument.
3453 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3454 g_settings_new (Bug#8967). Do not create gsettings_obj.
3455 Remove calls to g_settings_bind. Connect something_changedCB to
3458 * xgselect.c: Add defined (HAVE_GSETTINGS).
3459 (xgselect_initialize): Ditto.
3461 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3462 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3465 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3467 * eval.c (struct backtrace): Simplify and port the data structure.
3468 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3469 signed bit field, as this assumption is not portable and it makes
3470 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3471 "char debug_on_exit : 1" as this is not portable either; instead,
3472 use the portable "unsigned int debug_on_exit : 1". Remove unused
3473 member evalargs. Remove obsolete comments about cc bombing out.
3475 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3477 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3478 Let HAVE_GSETTINGS override HAVE_GCONF.
3479 (store_monospaced_changed): New function.
3480 (EMACS_SETTINGS): A new type derived from GObject to handle
3481 GSettings notifications.
3482 (emacs_settings_constructor, emacs_settings_get_property)
3483 (emacs_settings_set_property, emacs_settings_class_init):
3485 (gsettings_client, gsettings_obj): New variables.
3486 (GSETTINGS_SCHEMA): New define.
3487 (something_changedCB): Call store_monospaced_changed.
3488 (init_gsettings): New function.
3489 (xsettings_initialize): Call init_gsettings.
3490 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3493 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3496 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3498 * window.c (resize_root_window, grow_mini_window)
3499 (shrink_mini_window): Rename Qresize_root_window to
3500 Qwindow_resize_root_window and Qresize_root_window_vertically to
3501 Qwindow_resize_root_window_vertically.
3503 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3505 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3507 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3509 * makefile.w32-in: Redesign dependencies so they reflect more
3510 clearly which files are directly included by each source file,
3511 and not through other includes.
3513 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3515 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3516 (sort_overlays, overlay_strings): When an overlay's clone number
3517 matches the window's clone number process the overlay even if
3518 the overlay's window property doesn't match the current window.
3520 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3521 (Fwindow_hchild): Rename to Fwindow_left_child.
3522 (Fwindow_next): Rename to Fwindow_next_sibling.
3523 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3524 (resize_window_check): Rename to window_resize_check.
3525 (resize_window_apply): Rename to window_resize_apply.
3526 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3527 (Fdelete_other_windows_internal, resize_frame_windows)
3528 (Fsplit_window_internal, Fdelete_window_internal)
3529 (grow_mini_window, shrink_mini_window)
3530 (Fresize_mini_window_internal): Fix callers accordingly.
3532 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3534 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3535 (emacs_fixed_set_min_size): Remove.
3536 (emacs_fixed_new): Take frame as argument.
3538 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3539 (_EmacsFixedPrivate): Remove minwidth/height.
3540 Add struct frame *f.
3541 (emacs_fixed_init): Initialize priv->f.
3542 (get_parent_class, emacs_fixed_set_min_size): Remove.
3543 (emacs_fixed_new): Set priv->f to argument.
3544 (emacs_fixed_get_preferred_width)
3545 (emacs_fixed_get_preferred_height): Use min_width/height from
3546 frames size_hint to set minimum and natural (Bug#8919).
3547 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3548 and use min_width/height from frames size_hint to set
3549 min_width/height (Bug#8919).
3551 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3552 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3555 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3557 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3558 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3561 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3563 * process.c (wait_reading_process_output): Bypass select if
3564 waiting for a cell while ignoring keyboard input, and input is
3565 pending. Suggested by Jan Djärv (Bug#8869).
3567 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3569 Use gnulib's dup2 module instead of rolling our own.
3570 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3572 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3574 * dispnew.c (scrolling_window): Before scrolling, turn off a
3575 mouse-highlight in the window being scrolled.
3577 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3579 Move DEFSYM to lisp.h and use everywhere.
3581 * character.h (DEFSYM): Move declaration...
3582 * lisp.h (DEFSYM): ...here.
3588 * w32select.c: Don't include character.h.
3590 * alloc.c (syms_of_alloc):
3591 * buffer.c (syms_of_buffer):
3592 * bytecode.c (syms_of_bytecode):
3593 * callint.c (syms_of_callint):
3594 * casefiddle.c (syms_of_casefiddle):
3595 * casetab.c (init_casetab_once):
3596 * category.c (init_category_once, syms_of_category):
3597 * ccl.c (syms_of_ccl):
3598 * cmds.c (syms_of_cmds):
3599 * composite.c (syms_of_composite):
3600 * dbusbind.c (syms_of_dbusbind):
3601 * dired.c (syms_of_dired):
3602 * dispnew.c (syms_of_display):
3603 * doc.c (syms_of_doc):
3604 * editfns.c (syms_of_editfns):
3605 * emacs.c (syms_of_emacs):
3606 * eval.c (syms_of_eval):
3607 * fileio.c (syms_of_fileio):
3608 * fns.c (syms_of_fns):
3609 * frame.c (syms_of_frame):
3610 * fringe.c (syms_of_fringe):
3611 * insdel.c (syms_of_insdel):
3612 * keymap.c (syms_of_keymap):
3613 * lread.c (init_obarray, syms_of_lread):
3614 * macros.c (syms_of_macros):
3615 * msdos.c (syms_of_msdos):
3616 * print.c (syms_of_print):
3617 * process.c (syms_of_process):
3618 * search.c (syms_of_search):
3619 * sound.c (syms_of_sound):
3620 * syntax.c (init_syntax_once, syms_of_syntax):
3621 * terminal.c (syms_of_terminal):
3622 * textprop.c (syms_of_textprop):
3623 * undo.c (syms_of_undo):
3624 * w32.c (globals_of_w32):
3625 * window.c (syms_of_window):
3626 * xdisp.c (syms_of_xdisp):
3627 * xfaces.c (syms_of_xfaces):
3628 * xfns.c (syms_of_xfns):
3629 * xmenu.c (syms_of_xmenu):
3630 * xsettings.c (syms_of_xsettings):
3631 * xterm.c (syms_of_xterm): Use DEFSYM.
3633 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3635 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3637 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3639 Integer and buffer overflow fixes (Bug#8873).
3641 * print.c (printchar, strout): Check for string overflow.
3642 (PRINTPREPARE, printchar, strout):
3643 Don't set size unless allocation succeeds.
3645 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3646 for sizes. Check for string overflow more accurately.
3647 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3649 * macros.c: Integer and buffer overflow fixes.
3650 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3651 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3652 Use ptrdiff_t, not int, for sizes.
3653 Don't increment bufsize until after realloc succeeds.
3654 Check for size-calculation overflow.
3655 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3657 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3659 * lread.c: Integer overflow fixes.
3660 (read_integer): Radix is now EMACS_INT, not int,
3661 to improve quality of diagnostics for out-of-range radices.
3662 Calculate buffer size correctly for out-of-range radices.
3663 (read1): Check for integer overflow in radices, and in
3664 read-circle numbers.
3665 (read_escape): Avoid int overflow.
3666 (Fload, openp, read_buffer_size, read1)
3667 (substitute_object_recurse, read_vector, read_list, map_obarray):
3668 Use ptrdiff_t, not int, for sizes.
3669 (read1): Use EMACS_INT, not int, for sizes.
3670 Check for size overflow.
3672 * image.c (cache_image): Check for size arithmetic overflow.
3674 * lread.c: Integer overflow issues.
3675 (saved_doc_string_size, saved_doc_string_length)
3676 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3677 Now ptrdiff_t, not int.
3678 (read1): Don't assume doc string length fits in int. Check for
3679 out-of-range doc string lengths.
3680 (read_list): Don't assume file position fits in int.
3681 (read_escape): Check for hex character overflow.
3683 2011-06-22 Leo Liu <sdl.web@gmail.com>
3685 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3686 Move to minibuffer.el.
3688 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3690 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3691 The following patches are for when GLYPH_DEBUG && !XASSERT.
3692 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3693 * dispnew.c (flush_stdout):
3694 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3695 Mark as externally visible.
3696 * dispnew.c (check_window_matrix_pointers): Now static.
3697 * dispnew.c (window_to_frame_vpos):
3698 * xfns.c (unwind_create_frame):
3699 * xterm.c (x_check_font): Remove unused local.
3700 * scroll.c (CHECK_BOUNDS):
3701 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3702 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3703 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3704 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3705 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3707 (debug_method_add): Use va_list and vsprintf rather than relying
3708 on undefined behavior with wrong number of arguments.
3709 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3710 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3711 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3712 since we're not interested in debugging glyphs with old libraries.
3713 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3714 GCC 4.6.0's static checking.
3716 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3718 Integer overflow and signedness fixes (Bug#8873).
3719 A few related buffer overrun fixes, too.
3721 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3723 * dispextern.h (struct face.stipple):
3724 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3725 (x_bitmap_mask, x_allocate_bitmap_record)
3726 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3727 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3728 (x_create_bitmap_from_xpm_data):
3729 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3730 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3732 * xfaces.c (load_pixmap):
3733 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3734 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3735 (.bitmaps_last, struct x_output.icon_bitmap):
3736 Use ptrdiff_t, not int, for bitmap indexes.
3737 (x_allocate_bitmap_record): Check for size overflow.
3738 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3740 Use ptrdiff_t, not int, for overlay counts.
3741 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3742 * editfns.c (overlays_around, get_pos_property):
3743 * textprop.c (get_char_property_and_overlay):
3744 * xdisp.c (next_overlay_change, note_mouse_highlight):
3745 * xfaces.c (face_at_buffer_position):
3746 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3747 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3748 (Fnext_overlay_change, Fprevious_overlay_change)
3749 (mouse_face_overlay_overlaps, Foverlays_in):
3750 Use ptrdiff_t, not int, for sizes.
3751 (overlays_at, overlays_in): Check for size-calculation overflow.
3753 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3755 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3756 (x_session_initialize): Do not assume string length fits in int.
3758 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3759 This is unlikely, but can occur if DPI is outlandish.
3761 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3762 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3764 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3765 * xrdb.c (magic_file_p, search_magic_path):
3766 Omit last arg SUFFIX; it was always 0. All callers changed.
3767 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3769 * xfont.c (xfont_match): Avoid need for strlen.
3771 * xfns.c: Don't assume strlen fits in int.
3772 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3774 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3775 not unsigned long, as we prefer signed integers. All callers changed.
3776 Detect integer overflow in repeat count.
3777 (message_dolog): Don't assume print length fits in 39 bytes.
3778 (display_mode_element): Don't assume strlen fits in int.
3780 * termcap.c: Don't assume sizes fit in int and never overflow.
3781 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3782 (gobble_line): Check for size-calculation overflow.
3784 * minibuf.c (Fread_buffer):
3785 * lread.c (intern, intern_c_string):
3786 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3787 Don't assume string length fits in int.
3789 * keyboard.c (parse_tool_bar_item):
3790 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3792 * font.c: Don't assume string length fits in int.
3793 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3794 Use ptrdiff_t, not int.
3795 (font_intern_prop): Don't assume string length fits in int.
3796 Don't assume integer property fits in fixnum.
3797 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3799 * filelock.c: Fix some buffer overrun and integer overflow issues.
3800 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3801 Reformulate so as not to need the command string.
3802 Invoke gzip -cd rather than gunzip, as it's more portable.
3803 (lock_info_type, lock_file_1, lock_file):
3804 Don't assume pid_t and time_t fit in unsigned long.
3805 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3806 (current_lock_owner): Prefer signed type for sizes.
3807 Use memcpy, not strncpy, where memcpy is what is really wanted.
3808 Don't assume (via atoi) that time_t and pid_t fit in int.
3809 Check for time_t and/or pid_t out of range, e.g., via a network share.
3810 Don't alloca where an auto var works fine.
3812 * fileio.c: Fix some integer overflow issues.
3813 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3814 Don't assume string length fits in int.
3815 (directory_file_name): Don't assume string length fits in long.
3816 (make_temp_name): Don't assume pid fits in int, or that its print
3817 length is less than 20.
3819 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3821 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3823 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3825 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3826 We prefer signed integers, even for size calculations.
3828 * emacs.c: Don't assume string length fits in 'int'.
3829 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3830 (main): Don't invoke strlen when not needed.
3832 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3833 (XD_DEBUG_MESSAGE): Don't waste a byte.
3835 * callproc.c (getenv_internal_1, getenv_internal)
3837 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3839 * lread.c (invalid_syntax): Omit length argument.
3840 All uses changed. This doesn't fix a bug, but it simplifies the
3841 code away from its former Hollerith-constant appearance, and it's
3842 one less 'int' to worry about when looking at integer-overflow issues.
3843 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3845 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3846 This didn't break anything, but it didn't help either.
3847 It's confusing to put a bogus integer in a place where the actual
3848 value does not matter.
3849 (LIST_END_P): Remove unused macro and its bogus comment.
3850 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3852 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3853 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3855 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3856 We prefer signed types, and the value cannot exceed the EMACS_INT
3857 range anyway (because otherwise the length would not be representable).
3858 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3859 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3860 This avoids a GCC warning when WIDE_EMACS_INT.
3862 * indent.c (sane_tab_width): New function.
3863 (current_column, scan_for_column, Findent_to, position_indentation)
3864 (compute_motion): Use it. This is just for clarity.
3865 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3867 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3869 * lisp.h (lint_assume): New macro.
3870 * composite.c (composition_gstring_put_cache):
3871 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3873 * editfns.c, insdel.c:
3874 Omit unnecessary forward decls, to simplify future changes.
3876 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3878 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3880 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3881 Use much-faster test for byte-length change.
3882 Don't assume string byte-length fits in 'int'.
3883 Check that character arg fits in 'int'.
3884 (mapcar1): Declare byte as byte, for clarity.
3886 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3888 * fns.c (concat): Catch string overflow earlier.
3889 Do not rely on integer wraparound.
3891 * dispextern.h (struct it.overlay_strings_charpos)
3892 (struct it.selective): Now EMACS_INT, not int.
3893 * xdisp.c (forward_to_next_line_start)
3894 (back_to_previous_visible_line_start)
3895 (reseat_at_next_visible_line_start, next_element_from_buffer):
3896 Don't arbitrarily truncate the value of 'selective' to int.
3898 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3900 * composite.c: Don't truncate sizes to 'int'.
3901 (composition_gstring_p, composition_reseat_it)
3902 (composition_adjust_point): Use EMACS_INT, not int.
3903 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3904 not EMACS_UINT, for indexes.
3906 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3908 * buffer.c: Include <verify.h>.
3909 (struct sortvec.priority, struct sortstr.priority):
3910 Now EMACS_INT, not int.
3911 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3912 (struct sortstr.size, record_overlay_string)
3913 (struct sortstrlist.size, struct sortlist.used):
3914 Don't truncate size to int.
3915 (record_overlay_string): Check for size-calculation overflow.
3916 (init_buffer_once): Check at compile-time, not run-time.
3918 2011-06-22 Jim Meyering <meyering@redhat.com>
3920 Don't leak an XBM-image-sized buffer
3921 * image.c (xbm_load): Free the image buffer after using it.
3923 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3926 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3927 that Sun C diagnosed.
3928 * fns.c (secure_hash): Fix pointer signedness issue.
3929 * intervals.c (static_offset_intervals): New function.
3930 (offset_intervals): Use it.
3932 2011-06-21 Leo Liu <sdl.web@gmail.com>
3935 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3938 * fns.c (secure_hash): Rename from crypto_hash_function and change
3939 the first arg to accept symbols.
3940 (Fsecure_hash): New primitive.
3941 (syms_of_fns): New symbols.
3943 2011-06-20 Deniz Dogan <deniz@dogan.se>
3945 * process.c (Fset_process_buffer): Clarify return value in
3948 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3950 * dispnew.c (add_window_display_history): Use BVAR.
3952 * xdisp.c (debug_method_add): Use BVAR.
3953 (check_window_end, dump_glyph_matrix, dump_glyph)
3954 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3956 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3959 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3960 check till after the cache is created in init_frame_faces.
3962 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3964 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3966 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3968 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3969 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3970 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3972 Improve buffer-overflow checking (Bug#8873).
3973 * fileio.c (Finsert_file_contents):
3974 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3975 Remove the old (too-loose) buffer overflow checks.
3976 They weren't needed, since make_gap checks for buffer overflow.
3977 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3978 The old code merely checked for Emacs fixnum overflow, and relied
3979 on undefined (wraparound) behavior. The new code avoids undefined
3980 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3982 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3983 Tune. Don't use wider integers than needed. Don't use alloca.
3984 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3986 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3988 * insdel.c, lisp.h (buffer_overflow): New function.
3989 (insert_from_buffer_1, replace_range, replace_range_2):
3990 * insdel.c (make_gap_larger):
3991 * editfns.c (Finsert_char):
3992 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3994 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3996 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3998 Integer overflow and signedness fixes (Bug#8873).
4000 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4001 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4003 * fileio.c: Don't assume EMACS_INT fits in off_t.
4004 (emacs_lseek): New static function.
4005 (Finsert_file_contents, Fwrite_region): Use it.
4006 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4008 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4010 * fns.c: Don't overflow int when computing a list length.
4011 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4012 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4013 truncation on 64-bit hosts. Check for QUIT every
4014 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4015 faster and is responsive enough.
4016 (Flength): Report an error instead of overflowing an integer.
4017 (Fsafe_length): Return a float if the value is not representable
4018 as a fixnum. This shouldn't happen except in contrived situations.
4019 (Fnthcdr, Fsort): Don't assume list length fits in int.
4020 (Fcopy_sequence): Don't assume vector length fits in int.
4022 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4023 (header_size, word_size): New constants.
4024 (allocate_vectorlike): Don't check size overflow here.
4025 (allocate_vector): Check it here instead, since this is the only
4026 caller of allocate_vectorlike that could cause overflow.
4027 Check that the new vector's length is representable as a fixnum.
4029 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4030 The previous code was bogus. For example, next_almost_prime (32)
4031 returned 39, which is undesirable as it is a multiple of 3; and
4032 next_almost_prime (24) returned 25, which is a multiple of 5 so
4033 why was the code bothering to check for multiples of 7?
4035 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4037 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4039 Variadic C functions now count arguments with ptrdiff_t.
4040 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4041 Back then I didn't know that the Emacs coding style prefers signed int.
4042 Also, in the meantime I found a few more instances where arguments
4043 were being counted with int, which may truncate counts on 64-bit
4044 machines, or EMACS_INT, which may be unnecessarily wide.
4045 * lisp.h (struct Lisp_Subr.function.aMANY)
4046 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4047 Arg counts are now ptrdiff_t, not size_t.
4048 All variadic functions and their callers changed accordingly.
4049 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4050 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4051 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4052 * callint.c (Fcall_interactively): Check arg count for overflow,
4053 to avoid potential buffer overrun. Use signed char, not 'int',
4054 for 'varies' array, so that we needn't bother to check its size
4055 calculation for overflow.
4056 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4057 * eval.c (apply_lambda):
4058 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4059 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4060 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4062 * callint.c (Fcall_interactively): Don't use index var as event count.
4064 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4065 * mem-limits.h (SIZE): Remove; no longer used.
4067 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4069 Remove unnecessary casts.
4070 * xterm.c (x_term_init):
4071 * xfns.c (x_set_border_pixel):
4072 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4073 These aren't needed now that we assume ANSI C.
4075 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4076 It's more likely to cause problems (due to unsigned overflow)
4079 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4081 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4083 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4085 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4087 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4089 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4091 GLYPH_CODE_FACE returns EMACS_INT, not int.
4092 * dispextern.h (merge_faces):
4093 * xfaces.c (merge_faces):
4094 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4095 Don't assume EMACS_INT fits in int.
4097 * character.h (CHAR_VALID_P): Remove unused parameter.
4098 * fontset.c, lisp.h, xdisp.c: All uses changed.
4100 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4102 * fns.c (concat): Minor tuning based on overflow analysis.
4103 This doesn't fix any bugs. Use int to hold character, instead
4104 of constantly refetching from Emacs object. Use XFASTINT, not
4105 XINT, for value known to be a character. Don't bother comparing
4106 a single byte to 0400, as it's always less.
4108 * floatfns.c (Fexpt):
4109 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4111 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4114 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4116 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4117 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4118 incorrectly succeed when S was a string, because 4294967386 was
4119 truncated before it was used.
4121 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4122 Otherwise, an out-of-range integer could cause undefined behavior
4125 * composite.c: Use int, not EMACS_INT, for characters.
4126 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4127 EMACS_INT, for values that are known to be in character range.
4128 This doesn't fix any bugs but is the usual style inside Emacs and
4129 may generate better code on 32-bit machines.
4131 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4132 This is for reasons similar to the recent CHAR_STRING fix.
4133 * charset.c (Fencode_char): Check that character arg is actually
4134 a character. Pass an int to ENCODE_CHAR.
4135 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4136 wider than 'int', as a compile-time check to prevent future regressions
4139 * character.c (char_string): Remove unnecessary casts.
4141 Make sure a 64-bit char is never passed to CHAR_STRING.
4142 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4143 by silently ignoring the top 32 bits, allowing some values
4144 that were far too large to be valid characters.
4145 * character.h: Include <verify.h>.
4146 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4147 arguments are no wider than unsigned, as a compile-time check
4148 to prevent future regressions in this area.
4150 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4151 (Fsubst_char_in_region):
4153 * xdisp.c (decode_mode_spec_coding):
4154 Adjust to CHAR_STRING's new requirement.
4155 * editfns.c (Finsert_char, Fsubst_char_in_region):
4156 * fns.c (concat): Check that character args are actually
4157 characters. Without this test, these functions did the wrong
4158 thing with wildly out-of-range values on 64-bit hosts.
4160 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4161 These casts should not be needed on 32-bit hosts, either.
4162 * keyboard.c (read_char):
4163 * lread.c (Fload): Remove casts to unsigned.
4165 * lisp.h (UNSIGNED_CMP): New macro.
4166 This fixes comparison bugs on 64-bit hosts.
4167 (ASCII_CHAR_P): Use it.
4168 * casefiddle.c (casify_object):
4169 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4170 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4171 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4172 * dispextern.h (FACE_FROM_ID):
4173 * keyboard.c (read_char): Use UNSIGNED_CMP.
4175 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4176 not to EMACS_INT, to avoid GCC warning.
4178 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4180 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4181 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4182 isn't needed on 32-bit machines.
4184 * buffer.c (Fgenerate_new_buffer_name):
4185 Use EMACS_INT for count, not int.
4186 (advance_to_char_boundary): Return EMACS_INT, not int.
4188 * data.c (Qcompiled_function): Now static.
4190 * window.c (window_body_lines): Now static.
4192 * image.c (gif_load): Rename local to avoid shadowing.
4194 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4195 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4196 * alloc.c (make_save_value): Integer argument is now of type
4198 (mark_object): Use ptrdiff_t, not int.
4199 * lisp.h (pD): New macro.
4200 * print.c (print_object): Use it.
4202 * alloc.c: Use EMACS_INT, not int, to count objects.
4203 (total_conses, total_markers, total_symbols, total_vector_size)
4204 (total_free_conses, total_free_markers, total_free_symbols)
4205 (total_free_floats, total_floats, total_free_intervals)
4206 (total_intervals, total_strings, total_free_strings):
4207 Now EMACS_INT, not int. All uses changed.
4208 (Fgarbage_collect): Compute overall total using a double, so that
4209 integer overflow is less likely to be a problem. Check for overflow
4210 when converting back to an integer.
4211 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4212 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4213 These were 'int' variables that could overflow on 64-bit hosts;
4214 they were never used, so remove them instead of repairing them.
4215 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4216 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4217 Previously, this ceilinged at INT_MAX, but that doesn't work on
4219 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4221 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4222 (allocate_vectorlike): Check for ptrdiff_t overflow.
4223 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4224 when a (possibly-narrower) signed value would do just as well.
4225 We prefer using signed arithmetic, to avoid comparison confusion.
4227 * alloc.c: Catch some string size overflows that we were missing.
4228 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4229 for convenience in STRING_BYTES_MAX.
4230 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4231 The definition here is exact; the one in lisp.h was approximate.
4232 (allocate_string_data): Check for string overflow. This catches
4233 some instances we weren't catching before. Also, it catches
4234 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4235 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4236 and ptrdiff_t and EMACS_INT are both 64 bits.
4238 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4239 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4240 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4242 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4244 * alloc.c (Fmake_string): Check for out-of-range init.
4246 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4248 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4250 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4252 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4253 xg_get_default_scrollbar_width.
4255 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4256 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4257 (style_changed_cb): Call update_theme_scrollbar_width and call
4258 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4259 all frames (Bug#8505).
4260 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4261 Call gtk_window_set_resizable if HAVE_GTK3.
4262 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4263 and height if HAVE_GTK3 (Bug#8505).
4264 (scroll_bar_width_for_theme): New variable.
4265 (update_theme_scrollbar_width): New function.
4266 (xg_get_default_scrollbar_width): Move code to
4267 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4268 (xg_initialize): Call update_theme_scrollbar_width.
4270 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4272 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4274 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4276 * frame.c (make_frame): Call other_buffer_safely instead of
4279 * window.c (temp_output_buffer_show): Call display_buffer with
4280 second argument Vtemp_buffer_show_specifiers and reset latter
4281 immediately after the call.
4282 (Vtemp_buffer_show_specifiers): New variable.
4283 (auto_window_vscroll_p, next_screen_context_lines)
4284 (Vscroll_preserve_screen_position): Remove leading asterisks from
4287 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4289 Fix minor problems found by GCC 4.6.0 static checking.
4290 * buffer.c (Qclone_number): Remove for now, as it's unused.
4291 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4292 (record_buffer): Remove unused local.
4293 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4294 (set_frame_buffer_list): Remove; unused.
4295 * frame.h (other_visible_frames): Remove decl.
4296 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4297 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4298 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4300 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4301 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4302 Define only if HAVE_GPM.
4303 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4304 (update_hints_inhibit): Remove; never set. All uses removed.
4305 * widgetprv.h (emacsFrameClassRec): Remove decl.
4306 * window.c (delete_deletable_window): Now returns void, since it
4307 wasn't returning anything.
4308 (compare_window_configurations): Remove unused locals.
4309 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4310 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4311 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4312 the same widths as pointers. This follows up on the 2011-05-06 patch.
4313 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4314 * xterm.h: Likewise.
4315 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4317 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4319 * makefile.w32-in: Update dependencies.
4320 (LISP_H): Add lib/intprops.h.
4322 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4324 * image.c (gif_load): Add animation frame delay to the metadata.
4325 (syms_of_image): Use DEFSYM. New symbol `delay'.
4327 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4329 * window.c (delete_deletable_window): Re-add.
4330 (Fset_window_configuration): Rewrite to handle dead buffers and
4331 consequently deletable windows.
4332 (window_tree, Fwindow_tree): Remove. Supply functionality in
4334 (compare_window_configurations): Simplify code.
4336 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4338 * image.c (imagemagick_load_image): Fix type mismatch.
4339 (Fimagemagick_types): Likewise.
4341 * window.h (replace_buffer_in_windows): Declare.
4343 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4345 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4346 Qclone_number. Remove external declaration of Qdelete_window.
4347 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4349 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4350 Run Qbuffer_list_update_hook if allowed.
4351 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4352 buffer list implementation.
4353 (other_buffer_safely): New function.
4354 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4355 calls to replace_buffer_in_windows and
4356 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4358 (record_buffer): Inhibit quitting and rewrite using quittable
4359 functions. Run Qbuffer_list_update_hook if allowed.
4360 (Frecord_buffer, Funrecord_buffer): New functions.
4361 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4362 Move switch-to-buffer to window.el.
4363 (bury-buffer): Move to window.el.
4364 (Vbuffer_list_update_hook): New variable.
4366 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4369 * window.h (resize_frame_windows): Move up in code.
4370 (Fwindow_frame): Remove EXFUN.
4371 (replace_buffer_in_all_windows): Remove prototype.
4372 (replace_buffer_in_windows_safely): Add prototype.
4374 * window.c: Declare Qdelete_window static again. Move down
4375 declaration of select_count.
4376 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4377 (Fother_window): Move to window.el.
4378 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4379 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4380 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4382 (replace_buffer_in_windows): Implement by calling
4383 Qreplace_buffer_in_windows.
4384 (replace_buffer_in_all_windows): Remove with some functionality
4385 moved into replace_buffer_in_windows_safely.
4386 (replace_buffer_in_windows_safely): New function.
4387 (select_window_norecord, select_frame_norecord): Move in front
4388 of run_window_configuration_change_hook. Remove now obsolete
4390 (Fset_window_buffer): Rewrite doc-string.
4391 Call Qrecord_window_buffer.
4392 (keys_of_window): Move binding for other-window to window.el.
4394 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4396 * dispextern.h (struct image): Replace data member, whose int_val
4397 and ptr_val fields were not used by anything, with a single
4400 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4401 (gif_clear_image, gif_load, imagemagick_load_image)
4402 (gs_clear_image, gs_load): Callers changed.
4404 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4406 * buffer.h: Include <time.h>, for time_t.
4407 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4409 Fix minor problems found by static checking.
4411 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4413 Make identifiers static if they are not used in other modules.
4414 * data.c (Qcompiled_function, Qframe, Qvector):
4415 * image.c (QimageMagick, Qsvg):
4416 * minibuf.c (Qmetadata):
4417 * window.c (resize_window_check, resize_root_window): Now static.
4418 * window.h (resize_window_check, resize_root_window): Remove decls.
4420 * window.c (window_deletion_count, delete_deletable_window):
4422 (window_body_lines): Now static.
4423 (Fdelete_other_windows_internal): Mark vars as initialized.
4424 Make sure 'resize_failed' is initialized.
4425 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4426 (resize_window_apply): Remove unused local.
4427 * window.h (delete_deletable_window): Remove decl.
4429 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4430 (imagemagick_load_image): Fix pointer signedness problem by changing
4431 last arg from unsigned char * to char *. All uses changed.
4432 Also, fix a local for similar reasons.
4433 Remove unused locals. Remove locals to avoid shadowing.
4434 (fn_rsvg_handle_free): Remove; unused.
4435 (svg_load, svg_load_image): Fix pointer signedness problem.
4436 (imagemagick_load_image): Don't use garbage pointer image_wand.
4438 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4440 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4442 * image.c (gif_load): Fix omitted cast error introduced by
4445 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4447 * window.h (resize_proportionally, orig_total_lines)
4448 (orig_top_line): Remove from window structure.
4449 (set_window_height, set_window_width, change_window_heights)
4450 (Fdelete_window): Remove prototypes.
4451 (resize_frame_windows): Remove duplicate declaration.
4453 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4455 * window.h (resize_frame_windows, resize_window_check)
4456 (delete_deletable_window, resize_root_window)
4457 (resize_frame_windows): Declare prototypes.
4459 * window.c (resize_window_apply): Make definition be "static" to
4460 match the prototype.
4462 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4464 * window.c: Remove declarations of Qwindow_size_fixed,
4465 window_min_size_1, window_min_size_2, window_min_size,
4466 size_window, window_fixed_size_p, enlarge_window, delete_window.
4467 Remove static from declaration of Qdelete_window, it's
4468 temporarily needed by Fbury_buffer.
4469 (replace_window): Don't assign orig_top_line and
4471 (Fdelete_window, delete_window): Remove. Window deletion is
4472 handled by window.el.
4473 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4474 Replace Fdelete_window calls with calls to Qdelete_window.
4475 (Fdelete_other_windows): Remove. Deleting other windows is
4476 handled by window.el.
4477 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4478 handled in window.el.
4479 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4480 Window minimum sizes are handled in window.el.
4481 (shrink_windows, size_window, set_window_height)
4482 (set_window_width, change_window_heights, window_height)
4483 (window_width, CURBEG, CURSIZE, enlarge_window)
4484 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4485 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4486 handled in window.el.
4487 (make_dummy_parent): Rename to make_parent_window and give it a
4488 second argument horflag.
4489 (make_window): Don't set resize_proportionally any more.
4490 (Fsplit_window): Remove. Windows are split in window.el.
4491 (save_restore_action, save_restore_orig_size)
4492 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4493 Resize mini windows in window.el.
4494 (grow_mini_window, shrink_mini_window): Implement by calling
4495 Qresize_root_window_vertically, resize_window_check and
4496 resize_window_apply.
4497 (saved_window, Fset_window_configuration, save_window_save):
4498 Do not handle orig_top_line, orig_total_lines, and
4499 resize_proportionally.
4500 (window_min_height, window_min_width): Move to window.el.
4501 (keys_of_window): Move bindings for delete-other-windows,
4502 split-window, delete-window and enlarge-window to window.el.
4504 * buffer.c: Temporarily extern Qdelete_window.
4505 (Fbury_buffer): Temporarily call Qdelete_window instead of
4506 Fdelete_window (Fbury_buffer will move to window.el soon).
4508 * frame.c (set_menu_bar_lines_1): Remove code handling
4509 orig_top_line and orig_total_lines.
4511 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4512 set_window_height but set heights directly.
4513 (change_frame_size_1): Use resize_frame_windows.
4515 * xdisp.c (init_xdisp): Don't use set_window_height but set
4518 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4519 Use resize_frame_windows instead of change_window_heights and run
4520 run_window_configuration_change_hook.
4522 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4523 instead of change_window_heights and run
4524 run_window_configuration_change_hook.
4526 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4528 * window.c (replace_window): Rename second argument REPLACEMENT to
4529 NEW. New third argument SETFLAG. Rewrite.
4530 (delete_window, make_dummy_parent): Call replace_window with
4532 (window_list_1): Move down in code.
4533 (run_window_configuration_change_hook): Move set_buffer part
4534 before select_frame_norecord part in order to unwind correctly.
4535 Rename count1 to count.
4536 (recombine_windows, delete_deletable_window, resize_root_window)
4537 (Fdelete_other_windows_internal)
4538 (Frun_window_configuration_change_hook, make_parent_window)
4539 (resize_window_check, resize_window_apply, Fresize_window_apply)
4540 (resize_frame_windows, Fsplit_window_internal)
4541 (Fdelete_window_internal, Fresize_mini_window_internal):
4543 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4545 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4547 * window.h (window): Add some new members to window structure -
4548 normal_lines, normal_cols, new_total, new_normal, clone_number,
4549 splits, nest, prev_buffers, next_buffers.
4550 (WINDOW_TOTAL_SIZE): Move here from window.c.
4551 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4553 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4555 (make_dummy_parent): Set new members of windows structure.
4556 (make_window): Move down in code. Handle new members of window
4558 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4559 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4560 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4561 (Fset_window_prev_buffers, Fwindow_next_buffers)
4562 (Fset_window_next_buffers, Fset_window_clone_number):
4564 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4565 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4567 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4568 Argument WINDOW can be now internal window too.
4569 (Fwindow_use_time): Move up in code.
4570 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4572 (Fset_window_configuration, saved_window)
4573 (Fcurrent_window_configuration, save_window_save): Handle new
4574 members of window structure.
4575 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4576 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4577 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4578 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4579 Qget_mru_window, Qresize_root_window,
4580 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4581 Qauto_buffer_name; staticpro them.
4583 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4585 * window.c (Fwindow_total_size, Fwindow_left_column)
4586 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4587 (Fwindow_list_1): New functions.
4588 (window_box_text_cols): Replace with window_body_cols.
4589 (Fwindow_width, Fscroll_left, Fscroll_right):
4590 Use window_body_cols instead of window_box_text_cols.
4591 (delete_window, Fset_window_configuration):
4592 Call delete_all_subwindows with window as argument.
4593 (delete_all_subwindows): Take a window as argument and not a
4595 (window_loop): Remove handling of GET_LRU_WINDOW and
4597 (Fget_lru_window, Fget_largest_window): Move to window.el.
4599 * window.h: Extern window_body_cols instead of
4600 window_box_text_cols. delete_all_subwindows now takes a
4601 Lisp_Object as argument.
4603 * indent.c (compute_motion, Fcompute_motion):
4604 Use window_body_cols instead of window_box_text_cols.
4606 * frame.c (delete_frame): Call delete_all_subwindows with root
4609 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4611 * fns.c (Fputhash): Document return value.
4613 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4615 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4617 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4619 Cons<->int and similar integer overflow fixes (Bug#8794).
4621 Check for overflow when converting integer to cons and back.
4622 * charset.c (Fdefine_charset_internal, Fdecode_char):
4623 Use cons_to_unsigned to catch overflow.
4624 (Fencode_char): Use INTEGER_TO_CONS.
4625 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4626 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4627 * data.c (long_to_cons, cons_to_long): Remove.
4628 (cons_to_unsigned, cons_to_signed): New functions.
4629 These signal an error for invalid or out-of-range values.
4630 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4631 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4632 * font.c (Ffont_variation_glyphs):
4633 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4634 * lisp.h: Include <intprops.h>.
4635 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4636 (cons_to_signed, cons_to_unsigned): New decls.
4637 (long_to_cons, cons_to_long): Remove decls.
4638 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4639 (Fprimitive_undo): Use CONS_TO_INTEGER.
4640 * xfns.c (Fx_window_property): Likewise.
4641 * xselect.c: Include <limits.h>.
4642 (x_own_selection, selection_data_to_lisp_data):
4643 Use INTEGER_TO_CONS.
4644 (x_handle_selection_request, x_handle_selection_clear)
4645 (x_get_foreign_selection, Fx_disown_selection_internal)
4646 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4647 (lisp_data_to_selection_data): Use cons_to_unsigned.
4648 (x_fill_property_data): Use cons_to_signed.
4649 Report values out of range.
4651 Check for buffer and string overflow more precisely.
4652 * buffer.h (BUF_BYTES_MAX): New macro.
4653 * lisp.h (STRING_BYTES_MAX): New macro.
4654 * alloc.c (Fmake_string):
4655 * character.c (string_escape_byte8):
4656 * coding.c (coding_alloc_by_realloc):
4657 * doprnt.c (doprnt):
4658 * editfns.c (Fformat):
4660 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4661 since they may not be the same number.
4662 * editfns.c (Finsert_char):
4663 * fileio.c (Finsert_file_contents):
4664 Likewise for BUF_BYTES_MAX.
4666 * image.c: Use ptrdiff_t, not int, for sizes.
4667 (slurp_file): Switch from int to ptrdiff_t.
4669 (slurp_file): Check that file size fits in both size_t (for
4670 malloc) and ptrdiff_t (for sanity and safety).
4672 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4673 if b->modtime has its maximal value.
4675 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4677 Don't assume time_t can fit into int.
4678 * buffer.h (struct buffer.modtime): Now time_t, not int.
4679 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4680 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4682 Minor fixes for signed vs unsigned integers.
4683 * character.h (MAYBE_UNIFY_CHAR):
4684 * charset.c (maybe_unify_char):
4685 * keyboard.c (read_char, reorder_modifiers):
4686 XINT -> XFASTINT, since the integer must be nonnegative.
4687 * ftfont.c (ftfont_spec_pattern):
4688 * keymap.c (access_keymap, silly_event_symbol_error):
4689 XUINT -> XFASTINT, since the integer must be nonnegative.
4690 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4691 since it makes no difference and we prefer signed.
4692 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4693 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4696 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4698 * window.h (Fwindow_frame): Declare.
4700 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4702 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4703 (SPARE_MEMORY): Always define.
4704 (LARGE_REQUEST): Remove.
4705 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4707 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4709 * lisp.h: Move EXFUNS for Fframe_root_window,
4710 Fframe_first_window and Fset_frame_selected_window to window.h.
4712 * window.h: Move EXFUNS for Fframe_root_window,
4713 Fframe_first_window and Fset_frame_selected_window here from
4716 * frame.c (Fwindow_frame, Fframe_first_window)
4717 (Fframe_root_window, Fframe_selected_window)
4718 (Fset_frame_selected_window): Move to window.c.
4719 (Factive_minibuffer_window): Move to minibuf.c.
4720 (Fother_visible_frames_p): New function.
4722 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4724 * window.c (decode_window, decode_any_window): Move up in code.
4725 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4726 (inhibit_frame_unsplittable): Remove unused variable.
4727 (Fwindow_buffer): Move up and rewrite doc-string.
4728 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4729 (Fwindow_prev): New functions.
4730 (Fwindow_frame): Move here from frame.c. Accept any window as
4732 (Fframe_root_window, Fframe_first_window)
4733 (Fframe_selected_window): Move here from frame.c. Accept frame
4734 or arbitrary window as argument. Update doc-strings.
4735 (Fminibuffer_window): Move up in code.
4736 (Fwindow_minibuffer_p): Move up in code and simplify.
4737 (Fset_frame_selected_window): Move here from frame.c.
4739 (Fselected_window, select_window, Fselect_window): Move up in
4740 code. Minor doc-string fixes.
4742 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4744 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4745 Do not assume that spare memory exists; that assumption is valid
4746 only if SYSTEM_MALLOC.
4747 (LARGE_REQUEST): New macro, so that the issue of large requests
4748 is separated from the issue of spare memory.
4750 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4752 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4755 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4757 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4760 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4762 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4764 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4766 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4767 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4769 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4771 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4773 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4775 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4776 (x_clipboard_manager_save): Add return value.
4777 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4779 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4780 Obey Vx_select_enable_clipboard_manager. Catch errors in
4781 x_clipboard_manager_save (Bug#8779).
4782 (Vx_select_enable_clipboard_manager): New variable.
4783 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4785 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4787 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4789 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4791 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4792 in the current matrix if keep_current_p is non-zero.
4794 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4796 * bidi.c (bidi_level_of_next_char): Fix last change.
4798 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4800 Support bidi reordering of text covered by display properties.
4802 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4803 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4804 (bidi_cache_search, bidi_cache_iterator_state)
4805 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4806 (bidi_level_of_next_char, bidi_move_to_visually_next):
4807 Support character positions inside a run of characters covered by a
4809 (bidi_paragraph_init, bidi_resolve_explicit_1)
4810 (bidi_level_of_next_char): Call bidi_fetch_char and
4811 bidi_fetch_char_advance instead of FETCH_CHAR and
4813 (bidi_init_it): Initialize new members.
4814 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4816 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4817 instead of using explicit *_CHAR codes.
4818 (bidi_resolve_explicit, bidi_resolve_weak):
4819 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4820 bidirectional text is supported only in multibyte buffers.
4821 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4822 it to initialize the frame_window_p member of struct bidi_it.
4823 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4824 (bidi_resolve_explicit, bidi_resolve_weak)
4825 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4826 bidi_it->nchars is non-positive.
4827 (bidi_level_of_next_char): Don't try to lookup the cache for the
4828 next/previous character if nothing is cached there yet, or if we
4829 were just reseat()'ed to a new position.
4831 * xdisp.c (set_cursor_from_row): Set start and stop points
4832 according to the row's direction when priming the loop that looks
4833 for the glyph on which to display cursor.
4834 (single_display_spec_intangible_p): Function deleted.
4835 (display_prop_intangible_p): Reimplement to call
4836 handle_display_spec instead of single_display_spec_intangible_p.
4837 Accept 3 additional arguments needed by handle_display_spec.
4838 This fixes incorrect cursor motion across display property with complex
4839 values: lists, `(when COND...)' forms, etc.
4840 (single_display_spec_string_p): Support property values that are
4841 lists with the argument STRING its top-level element.
4842 (display_prop_string_p): Fix the condition for processing a
4843 property that is a list to be consistent with handle_display_spec.
4844 (handle_display_spec): New function, refactored from the
4845 last portion of handle_display_prop.
4846 (compute_display_string_pos): Accept additional argument
4847 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4848 value of a `display' property is a "replacing spec".
4849 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4850 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4851 the display property, but just return a value indicating whether
4852 the display property will replace the characters it covers.
4853 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4854 frame_window_p members of struct bidi_it.
4855 (compute_display_string_pos, compute_display_string_end):
4857 (push_it): Accept second argument POSITION, where pop_it should
4858 jump to continue iteration.
4859 (reseat_1): Initialize bidi_it.disp_pos.
4861 * keyboard.c (adjust_point_for_property): Adjust the call to
4862 display_prop_intangible_p to its new signature.
4864 * dispextern.h (struct bidi_it): New member frame_window_p.
4865 (bidi_init_it): Update prototypes.
4866 (display_prop_intangible_p): Update prototype.
4867 (compute_display_string_pos, compute_display_string_end):
4869 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4872 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4874 Malloc failure behavior now depends on size of allocation.
4875 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4876 * lisp.h: Change signatures accordingly.
4877 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4878 All callers changed. (Bug#8762)
4880 * gnutls.c: Use Emacs's memory allocators.
4881 Without this change, the gnutls library would invoke malloc etc.
4882 directly, which causes problems on non-SYNC_INPUT hosts, and which
4883 runs afoul of improving memory_full behavior. (Bug#8761)
4884 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4885 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4886 xfree instead of the default malloc, realloc, free.
4887 (Fgnutls_boot): No need to check for memory allocation failure,
4888 since xmalloc does that for us.
4890 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4891 * category.c (hash_get_category_set):
4892 * ccl.c (ccl_driver):
4893 * charset.c (Fdefine_charset_internal):
4894 * charset.h (struct charset.hash_index):
4895 * composite.c (get_composition_id, gstring_lookup_cache)
4896 (composition_gstring_put_cache):
4897 * composite.h (struct composition.hash_index):
4898 * dispextern.h (struct image.hash):
4899 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4900 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4901 (hashfn_equal, hashfn_user_defined, make_hash_table)
4902 (maybe_resize_hash_table, hash_lookup, hash_put)
4903 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4904 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4905 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4906 * image.c (make_image, search_image_cache, lookup_image)
4907 (xpm_put_color_table_h):
4908 * lisp.h (struct Lisp_Hash_Table):
4909 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4910 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4911 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4912 * alloc.c (allocate_vectorlike):
4913 Check for overflow in vector size calculations.
4914 * ccl.c (ccl_driver):
4915 Check for overflow when converting EMACS_INT to int.
4916 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4917 need to be updated by these changes.
4918 * fns.c (make_hash_table, maybe_resize_hash_table):
4919 Check for integer overflow with large hash tables.
4920 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4921 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4922 (SXHASH_REDUCE): New macro.
4923 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4924 Use it instead of discarding useful hash info with large hash values.
4925 (sxhash_float): New function.
4926 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4927 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4928 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4929 Rewrite to use FIXNUM_BITS, as this simplifies things.
4930 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4931 Adjust signatures to match updated version of code.
4932 (consing_since_gc): Now EMACS_INT, since a single hash table can
4933 use more than INT_MAX bytes.
4935 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4937 Make it possible to build with GCC-4.6+ -O2 -flto.
4939 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4941 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4943 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4944 Call minibuffer-inactive-mode.
4946 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4948 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4949 Update dependencies.
4951 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4953 * data.c (init_data): Remove code for UTS, this system is not
4956 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4958 Don't force ./temacs to start in terminal mode.
4960 * frame.c (make_initial_frame): Initialize faces in all cases, not
4961 only when CANNOT_DUMP is defined.
4962 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4964 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4966 * dispnew.c (add_window_display_history): Use const for the string
4967 pointer. Remove declaration, not needed.
4969 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4971 Use 'inline', not 'INLINE'.
4972 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4973 * alloc.c, fontset.c (INLINE): Remove.
4974 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4975 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4976 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4977 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4978 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4980 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4982 Make it possible to run ./temacs.
4984 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4985 syms_of_callproc does the same thing. Remove test for
4986 "initialized", do it in the caller.
4987 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4989 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4991 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4992 (read_minibuf): Use get_minibuffer.
4993 (syms_of_minibuf): Use DEFSYM.
4994 (Qmetadata): New var.
4995 * data.c (Qbuffer): Don't make it static.
4996 (syms_of_data): Use DEFSYM.
4998 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5000 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5001 (CCL_CODE_MIN): New macro.
5003 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5005 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5007 * eval.c (Qdebug): Now static.
5008 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5009 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5010 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5012 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5014 * image.c: Various fixes to ImageMagick code comments.
5015 (Fimagemagick_types): Doc fix.
5017 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5019 Minor fixes prompted by GCC 4.6.0 warnings.
5021 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5023 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5024 (x_clipboard_manager_save_all): Move extern decl to ...
5025 * xterm.h: ... here, so that it can be checked for consistency.
5027 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5029 * xselect.c (x_clipboard_manager_save_frame)
5030 (x_clipboard_manager_save_all): New functions.
5031 (Fx_clipboard_manager_save): Lisp function deleted.
5033 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5034 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5036 * xterm.h: Update prototype.
5038 2011-05-28 William Xu <william.xwl@gmail.com>
5040 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5043 2011-05-28 Jim Meyering <meyering@redhat.com>
5045 Avoid a sign-extension bug in crypto_hash_function.
5046 * fns.c (to_uchar): Define.
5047 (crypto_hash_function): Use it to convert some newly-signed
5048 variables to unsigned, to avoid sign-extension bugs. For example,
5049 without this change, (md5 "truc") would evaluate to
5050 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5051 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5052 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5054 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5056 Integer overflow fixes.
5058 * dbusbind.c: Serial number integer overflow fixes.
5059 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5060 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5061 to hold a serial number that is too large for a fixnum.
5062 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5063 Check for serial numbers out of range. Decode any serial number
5064 that was so large that it became a float. (Bug#8722)
5066 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5067 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5068 Use XFASTINT rather than XUINT when numbers are nonnegative.
5069 (xd_append_arg, Fdbus_method_return_internal):
5070 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5071 arguments, check that Lisp number is nonnegative, rather than
5072 silently wrapping negative numbers around. (Bug#8722)
5073 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5076 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5078 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5080 ccl: add integer overflow checks
5081 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5082 (IN_INT_RANGE): New macros.
5083 (ccl_driver): Use them to check for integer overflow when
5084 decoding a CCL program. Many of the new checks are whether XINT (x)
5085 fits in int; it doesn't always, on 64-bit hosts. The new version
5086 doesn't catch all possible integer overflows, but it's an
5087 improvement. (Bug#8719)
5089 * alloc.c (make_event_array): Use XINT, not XUINT.
5090 There's no need for unsigned here.
5092 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5093 This follows up to the 2011-05-06 change that substituted uintptr_t
5094 for EMACS_INT. This case wasn't caught back then.
5096 Rework Fformat to avoid integer overflow issues.
5097 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5098 now (part of C89). Include <verify.h>.
5099 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5100 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5101 (Fformat): Avoid the prepass trying to compute sizes; it was only
5102 approximate and thus did not catch overflow reliably. Instead, walk
5103 through the format just once, formatting and computing sizes as we go,
5104 checking for integer overflow at every step, and allocating a larger
5105 buffer as needed. Keep track separately whether the format is
5106 multibyte. Keep only the most-recently calculated precision, rather
5107 than them all. Record whether each argument has been converted to
5108 string. Use EMACS_INT, not int, for byte and char and arg counts.
5109 Support field widths and precisions larger than INT_MAX. Avoid
5110 sprintf's undefined behavior with conversion specifications such as %#d
5111 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5112 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5113 formatting out-of-range floating point numbers with int
5116 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5118 * data.c: Avoid integer truncation in expressions involving floats.
5119 * data.c: Include <intprops.h>.
5120 (arith_driver): When there's an integer overflow in an expression
5121 involving floating point, convert the integers to floating point
5122 so that the resulting value does not suffer from catastrophic
5123 integer truncation. For example, on a 64-bit host (* 4
5124 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5125 Do not rely on undefined behavior after integer overflow.
5127 merge count_size_as_multibyte, parse_str_to_multibyte
5128 * character.c, character.h (count_size_as_multibyte):
5129 Rename from parse_str_to_multibyte; all uses changed.
5130 Check for integer overflow.
5131 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5132 since it's now a duplicate of the other. This is more of
5133 a character than a buffer op, so better that it's in character.c.
5134 * fns.c, print.c: Adjust to above changes.
5136 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5138 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5140 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5142 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5143 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5144 (x_clipboard_manager_save): Now static.
5145 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5147 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5148 (crypto_hash_function): Now static.
5149 Fix pointer signedness problems. Avoid unnecessary initializations.
5151 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5153 * termhooks.h (Vselection_alist): Make it terminal-local.
5155 * terminal.c (create_terminal): Initialize it.
5157 * xselect.c: Support for clipboard managers.
5158 (Vselection_alist): Move to termhooks.h as terminal-local var.
5159 (LOCAL_SELECTION): New macro.
5160 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5161 (symbol_to_x_atom): Remove gratuitous arg.
5162 (x_handle_selection_request, lisp_data_to_selection_data)
5163 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5164 (x_own_selection, x_get_local_selection, x_convert_selection):
5165 New arg, specifying work frame. Use terminal-local Vselection_alist.
5166 (some_frame_on_display): Delete unused function.
5167 (Fx_own_selection_internal, Fx_get_selection_internal)
5168 (Fx_disown_selection_internal, Fx_selection_owner_p)
5169 (Fx_selection_exists_p): New optional frame arg.
5170 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5171 (x_handle_selection_clear): Don't treat other terminals with the
5172 same keyboard specially. Use the terminal-local Vselection_alist.
5173 (x_clear_frame_selections): Use Frun_hook_with_args.
5175 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5177 * xterm.h: Add support for those atoms.
5179 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5181 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5182 (converted_selections, conversion_fail_tag): New global variables.
5183 (x_selection_request_lisp_error): Free the above.
5184 (x_get_local_selection): Remove unnecessary code.
5185 (x_reply_selection_request): Args changed; handle arbitrary array
5186 of converted selections stored in converted_selections.
5187 Separate the XChangeProperty and SelectionNotify steps.
5188 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5189 (x_convert_selection): New function.
5190 (x_handle_selection_event): Simplify.
5191 (x_get_foreign_selection): Don't ignore incoming requests while
5192 waiting for an answer; this will fail when we implement
5193 SAVE_TARGETS, and seems unnecessary anyway.
5194 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5195 (Vx_sent_selection_functions): Doc fix.
5197 2011-05-26 Leo Liu <sdl.web@gmail.com>
5199 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5201 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5203 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5205 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5206 for fringe update if it has periodic bitmap.
5207 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5208 and fringe_bitmap_periodic_p.
5210 * fringe.c (get_fringe_bitmap_data): New function.
5211 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5212 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5213 row. Mark glyph row for fringe update if periodicity changed.
5215 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5216 for fringe update unless it has periodic bitmap.
5218 2011-05-25 Kenichi Handa <handa@m17n.org>
5220 * xdisp.c (get_next_display_element): Set correct it->face_id for
5221 a static composition.
5223 2011-05-24 Leo Liu <sdl.web@gmail.com>
5226 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5228 * fns.c (crypto_hash_function, Fsha1): New function.
5229 (Fmd5): Use crypto_hash_function.
5230 (syms_of_fns): Add Ssha1.
5232 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5234 * gnutls.c: Remove unused macros.
5235 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5236 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5237 Remove macros that are defined and never used.
5238 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5240 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5242 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5243 (Fx_get_selection_internal): Minor cleanup.
5244 (Fx_own_selection_internal): Rename arguments for consistency with
5247 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5249 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5251 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5253 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5255 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5257 * dispnew.c (scrolling_window): Don't exclude the case that the
5258 last enabled row in the desired matrix touches the bottom boundary.
5260 2011-05-21 Glenn Morris <rgm@gnu.org>
5262 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5263 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5264 and add some more files.
5266 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5268 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5269 report_file_error introduced by the change from 2011-05-07.
5271 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5273 * systime.h (Time): Define only if emacs is defined.
5274 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5275 where the include path doesn't have X11/X.h by default. See
5276 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5278 2011-05-20 Kenichi Handa <handa@m17n.org>
5280 * composite.c (find_automatic_composition): Fix previous change.
5282 2011-05-20 Glenn Morris <rgm@gnu.org>
5284 * lisp.mk: New file, split from Makefile.in.
5285 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5286 (shortlisp): Remove.
5287 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5289 2011-05-19 Glenn Morris <rgm@gnu.org>
5291 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5292 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5293 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5294 (lisp): Set the order to that of loadup.el.
5295 (shortlisp): Make it a copy of $lisp.
5296 (SOME_MACHINE_LISP): Remove.
5297 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5298 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5300 2011-05-18 Kenichi Handa <handa@m17n.org>
5302 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5303 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5304 (find_automatic_composition): Mostly rewrite for efficiency.
5306 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5308 * makefile.w32-in: Update dependencies.
5310 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5312 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5313 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5315 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5317 Fix some integer overflow issues, such as string length overflow.
5319 * insdel.c (count_size_as_multibyte): Check for string overflow.
5321 * character.c (lisp_string_width): Check for string overflow.
5322 Use EMACS_INT, not int, for string indexes and lengths; in
5323 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5324 the resulting string length overflows an EMACS_INT; instead,
5325 report a string overflow if no precision given. When checking for
5326 precision exhaustion, use a check that cannot possibly have
5327 integer overflow. (Bug#8675)
5328 * character.h (lisp_string_width): Adjust to new signature.
5330 * alloc.c (string_overflow): New function.
5331 (Fmake_string): Use it. This doesn't change behavior, but saves
5332 a few bytes and will simplify future changes.
5333 * character.c (string_escape_byte8): Likewise.
5334 * lisp.h (string_overflow): New decl.
5336 Fixups, following up to the user-interface timestamp change.
5337 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5338 for UI timestamps, instead of unsigned long.
5339 * msdos.c (mouse_get_pos): Likewise.
5340 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5341 * w32gui.h (Time): Define by including "systime.h" rather than by
5342 declaring it ourselves. (Bug#8664)
5344 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5345 * image.c (clear_image_cache): Likewise.
5347 * term.c (term_mouse_position): Don't assume time_t wraparound.
5349 Be more systematic about user-interface timestamps.
5350 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5351 and sometimes 'EMACS_UINT', to represent these timestamps.
5352 This change causes it to use 'Time' uniformly, as that's what X uses.
5353 This makes the code easier to follow, and makes it easier to catch
5354 integer overflow bugs such as Bug#8664.
5355 * frame.c (Fmouse_position, Fmouse_pixel_position):
5356 Use Time, not unsigned long, for user-interface timestamps.
5357 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5358 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5359 * keyboard.h (last_event_timestamp): Likewise.
5360 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5361 * menu.h (xmenu_show): Likewise.
5362 * term.c (term_mouse_position): Likewise.
5363 * termhooks.h (struct input_event.timestamp): Likewise.
5364 (struct terminal.mouse_position_hook): Likewise.
5365 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5366 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5367 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5368 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5370 * menu.h, termhooks.h: Include "systime.h", for Time.
5372 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5373 Don't assume that the difference between two unsigned long values
5374 can fit into an integer. At this point, we know button_down_time
5375 <= event->timestamp, so the difference must be nonnegative, so
5376 there's no need to cast the result if double-click-time is
5377 nonnegative, as it should be; check that it's nonnegative, just in
5378 case. This bug is triggered when events are more than 2**31 ms
5379 apart (about 25 days). (Bug#8664)
5381 * xselect.c (last_event_timestamp): Remove duplicate decl.
5382 (x_own_selection): Remove needless cast to unsigned long.
5384 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5385 that always fit in int. Use a sentinel instead of a counter, to
5386 avoid a temp and to allay GCC's concerns about possible int overflow.
5387 * frame.h (struct frame): Use int for menu_bar_items_used
5388 instead of EMACS_INT, since it always fits in int.
5390 * menu.c (grow_menu_items): Check for int overflow.
5392 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5394 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5395 Before, the code was not consistent. These values cannot exceed
5396 2**31 - 1 so there's no need to make them unsigned.
5397 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5398 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5399 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5401 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5403 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5404 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5405 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5406 presumably because the widths might not match.
5408 * window.c (size_window): Avoid needless test at loop start.
5410 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5412 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5414 2011-05-12 Drew Adams <drew.adams@oracle.com>
5416 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5418 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5420 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5421 `width' to `bar_area_x' and `bar_area_width', respectively.
5422 (x_scroll_run): Take account of fringe background extension.
5424 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5425 Rename local vars `left' and `width' to `bar_area_x' and
5426 `bar_area_width', respectively.
5427 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5428 background extension.
5430 2011-05-10 Jim Meyering <meyering@redhat.com>
5432 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5434 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5436 * image.c (Finit_image_library): Return t for built-in image types,
5437 like pbm and xbm. (Bug#8640)
5439 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5441 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5443 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5445 * w32console.c (Fset_screen_color): Doc fix.
5446 (Fget_screen_color): New function.
5447 (syms_of_ntterm): Defsubr it.
5449 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5450 unlink the temporary file if Fcall_process didn't create it in the
5452 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5453 child process will be redirected to a file specified with `:file'.
5454 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5455 cue to call_process_cleanup not to close that handle.
5457 2011-05-07 Ben Key <bkey76@gmail.com>
5459 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5460 one of two shell specific rules, either bootstrap-temacs-CMD or
5461 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5462 to the previous implementation of the bootstrap-temacs rule.
5463 The bootstrap-temacs-CMD rule is similar to the previous
5464 implementation of the bootstrap-temacs rule except that it
5465 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5468 These changes, along with some changes to nt/configure.bat,
5469 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5470 earlier fix to add support for --cflags and --ldflags options
5471 that include quotes so that it works whether make uses cmd or
5474 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5476 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5477 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5479 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5480 a string. Handle both cases.
5481 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5482 (Fdbus_register_method): Use Qinvalid_function.
5484 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5486 * makefile.w32-in: Update dependencies.
5487 (LISP_H): Add inttypes.h and stdin.h.
5488 (PROCESS_H): Add unistd.h.
5490 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5492 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5493 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5495 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5497 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5499 * term.c (vfatal): Remove stray call to va_end.
5500 It's not needed and the C Standard doesn't allow it here anyway.
5502 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5503 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5505 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5508 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5510 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5512 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5514 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5516 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5518 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5519 * charset.c (Fdefine_charset_internal): Don't initialize
5520 charset.code_space[15]. The value was garbage, on hosts with
5521 32-bit int (Bug#8600).
5523 * lread.c (read_integer): Be more consistent with string-to-number.
5524 Use string_to_number to do the actual conversion; this avoids
5525 rounding errors and fixes some other screwups. Without this fix,
5526 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5527 (digit_to_number): Move earlier, for benefit of read_integer.
5528 Return -1 if the digit is out of range for the base, -2 if it is
5529 not a digit in any supported base. (Bug#8602)
5531 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5533 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5534 to match comment at start of function. This also removes a
5535 GCC warning about overflow in a 32+64-bit port.
5537 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5539 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5540 Reported by Stefan Monnier in
5541 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5542 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5543 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5545 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5546 (EMACS_UINTPTR): Likewise, with uintptr_t.
5548 * lisp.h: Prefer 64-bit EMACS_INT if available.
5549 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5550 on 32-bit hosts that have 64-bit int, so that they can access
5552 However, temporarily disable this change unless the temporary
5553 symbol WIDE_EMACS_INT is defined.
5555 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5557 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5558 This removes an assumption that EMACS_INT and long are the same
5559 width as pointers. The assumption is true for Emacs porting targets
5560 now, but we want to make other targets possible.
5561 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5562 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5563 In the rest of the code, change types of integers that hold casted
5564 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5565 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5566 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5567 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5568 No need to cast type when ORing.
5569 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5570 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5571 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5572 assume EMACS_INT is the same width as char *.
5573 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5574 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5575 Remove no-longer-needed casts.
5576 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5577 (xg_tool_bar_help_callback, xg_make_tool_item):
5578 Use EMACS_INTPTR to hold an integer
5579 that will be cast to void *; this can avoid a GCC warning
5580 if EMACS_INT is not the same width as void *.
5581 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5582 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5583 (current_message_1, set_message_1):
5584 Use a local to convert to proper width without a cast.
5585 * xmenu.c (dialog_selection_callback): Likewise.
5587 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5588 Also, don't assume VALBITS / RAND_BITS is less than 5,
5589 and don't rely on undefined behavior when shifting a 1 left into
5591 * lisp.h (get_random): Change signature to match.
5593 * lread.c (hash_string): Use size_t, not int, for hash computation.
5594 Normally we prefer signed values; but hashing is special, because
5595 it's better to use unsigned division on hash table sizes so that
5596 the remainder is nonnegative. Also, size_t is the natural width
5597 for hashing into memory. The previous code used 'int', which doesn't
5598 retain enough info to hash well into very large tables.
5599 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5601 * dbusbind.c: Don't possibly lose pointer info when converting.
5602 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5603 Use XPNTR rather than XHASH, so that the high-order bits of
5604 the pointer aren't lost when converting through void *.
5606 * eval.c (Fautoload): Don't double-shift a pointer.
5608 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5610 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5612 * gnutls.c (DEF_GNUTLS_FN):
5613 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5615 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5617 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5620 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5622 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5623 New version that can reserve upto 2GB of heap space.
5625 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5627 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5629 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5631 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5632 `gnutls_certificate_set_x509_key_file'.
5634 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5636 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5637 Update dependencies.
5639 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5641 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5642 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5643 Remove unused parameter `fildes'.
5644 * process.c (read_process_output, send_process): Don't pass it.
5646 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5648 Fix previous change: the library cache is defined in w32.c.
5649 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5650 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5652 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5654 Implement dynamic loading of GnuTLS on Windows.
5656 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5657 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5658 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5661 * gnutls.c (Qgnutls_dll): Define.
5662 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5663 (gnutls_*): Declare function pointers.
5664 (init_gnutls_functions): New function to initialize function pointers.
5665 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5666 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5667 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5668 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5669 (emacs_gnutls_write, emacs_gnutls_read)
5670 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5671 (Fgnutls_available_p): New function.
5672 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5673 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5674 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5676 * image.c: Include w32.h.
5677 (Vimage_type_cache): Delete.
5678 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5679 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5680 (w32_delayed_load): Move to w32.c.
5682 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5684 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5685 (w32_delayed_load): Move from image.c. When loading a library, record
5686 its filename in the :loaded-from property of the library id.
5687 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5688 Initialize and staticpro them.
5689 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5691 * process.c: Include lisp.h before w32.h, not after.
5692 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5693 instead of gnutls_record_check_pending.
5695 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5697 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5699 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5700 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5703 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5705 * xterm.c (x_set_frame_alpha): Do not set property on anything
5706 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5708 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5710 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5712 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5714 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5715 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5716 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5717 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5718 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5719 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5720 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5721 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5722 (Qgnutls_bootprop_callbacks_verify): Make static.
5724 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5726 * callproc.c: Indentation fixup.
5728 * sysdep.c (wait_for_termination_1): Make static.
5729 (wait_for_termination, interruptible_wait_for_termination):
5730 Move after wait_for_termination_1.
5732 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5734 * sysdep.c (interruptible_wait_for_termination): New function
5735 which is like wait_for_termination, but allows keyboard
5738 * callproc.c (Fcall_process): Add (:file "file") as an option for
5740 (Fcall_process_region): Ditto.
5742 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5744 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5745 rather than `XVECTOR (FOO)->size'.
5747 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5748 inttypes.h, as a gnulib replacement is used if it not available in
5751 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5753 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5754 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5755 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5757 * coding.c (coding_alloc_by_realloc): Error out if destination
5758 will grow beyond MOST_POSITIVE_FIXNUM.
5759 (decode_coding_emacs_mule): Abort if there isn't enough place in
5760 charbuf for the composition carryover bytes. Reserve an extra
5761 space for up to 2 characters produced in a loop.
5762 (decode_coding_iso_2022): Abort if there isn't enough place in
5763 charbuf for the composition carryover bytes.
5765 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5767 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5768 aborting when %lld or %lll format is passed.
5769 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5770 %llo or %llx format is passed. (Bug#8545)
5772 * window.c (window_scroll_line_based): Use a marker instead of
5773 simple variables to record original value of point. (Bug#7952)
5775 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5776 produced by %s or %c overflows available buffer space. (Bug#8545)
5778 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5780 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5781 (SIZE_MAX): Move defn after all includes, as they might #define it.
5783 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5785 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5787 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5789 * keyboard.c (Qdelayed_warnings_hook): Define.
5790 (command_loop_1): Run `delayed-warnings-hook'
5791 if Vdelayed_warnings_list is non-nil.
5792 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5793 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5795 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5797 * doprnt.c (doprnt): Don't return value smaller than the buffer
5798 size if the message was truncated. (Bug#8545).
5800 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5802 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5803 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5805 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5807 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5809 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5811 * makefile.w32-in: Update dependencies.
5813 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5815 Improve `doprnt' and its usage. (Bug#8545)
5816 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5817 `format_end'. Remove support for %l as a conversion specifier.
5818 Don't use xrealloc. Improve diagnostics when the %l size modifier
5819 is used. Update the commentary.
5821 * eval.c (verror): Simplify calculation of size_t.
5823 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5826 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5828 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5831 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5833 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5834 This makes this file independent of the recent pseudovector change.
5836 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5838 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5840 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5841 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5842 Remove unused local.
5843 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5845 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5846 GCC 4.6.0 optimizes based on type-based alias analysis.
5847 For example, if b is of type struct buffer * and v of type struct
5848 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5849 != &v->size, and therefore "v->size = 1; b->size = 2; return
5850 v->size;" must therefore return 1. This assumption is incorrect
5851 for Emacs, since it type-puns struct Lisp_Vector * with many other
5852 types. To fix this problem, this patch adds a new type struct
5853 vectorlike_header that documents the constraints on layout of vectors
5854 and pseudovectors, and helps optimizing compilers not get fooled
5855 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5856 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5857 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5859 (XSETPVECTYPE): Rewrite in terms of new macro.
5860 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5861 This is a bit clearer, and further avoids the possibility of
5862 undesirable aliasing.
5863 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5864 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5865 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5866 since Lisp_Subr is a special case (no "next" field).
5867 (ASIZE): Now uses header.size rather than size.
5868 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5869 to avoid the hassle of writing XVECTOR (foo)->header.size.
5870 (struct vectorlike_header): New type.
5871 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5872 object, to help avoid aliasing.
5873 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5874 (SUBRP): Likewise, since Lisp_Subr is a special case.
5875 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5876 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5877 (struct Lisp_Hash_Table): Combine first two members into a single
5878 struct vectorlike_header member. All uses of "size" and "next" members
5879 changed to be "header.size" and "header.next".
5880 * buffer.h (struct buffer): Likewise.
5881 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5882 * frame.h (struct frame): Likewise.
5883 * process.h (struct Lisp_Process): Likewise.
5884 * termhooks.h (struct terminal): Likewise.
5885 * window.c (struct save_window_data, struct saved_window): Likewise.
5886 * window.h (struct window): Likewise.
5887 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5888 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5889 * buffer.c (init_buffer_once): Likewise.
5890 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5892 * process.c (Fformat_network_address): Use local var for size,
5895 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5897 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5898 * data.c (atof): Remove decl; no longer used or needed.
5899 (digit_to_number): Move to lread.c.
5900 (Fstring_to_number): Use new string_to_number function, to be
5901 consistent with how the Lisp reader treats infinities and NaNs.
5902 Do not assume that floating-point numbers represent EMACS_INT
5903 without losing information; this is not true on most 64-bit hosts.
5904 Avoid double-rounding errors, by insisting on integers when
5905 parsing non-base-10 numbers, as the documentation specifies.
5906 * lisp.h (string_to_number): New decl, replacing ...
5907 (isfloat_string): Remove.
5908 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5909 (read1): Do not accept +. and -. as integers; this
5910 appears to have been a coding error. Similarly, do not accept
5911 strings like +-1e0 as floating point numbers. Do not report
5912 overflow for integer overflows unless the base is not 10 which
5913 means we have no simple and reliable way to continue.
5914 Break out the floating-point parsing into a new
5915 function string_to_number, so that Fstring_to_number parses
5916 floating point numbers consistently with the Lisp reader.
5917 (digit_to_number): Move here from data.c. Make it static inline.
5918 (E_CHAR, EXP_INT): Remove, replacing with ...
5919 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5920 (string_to_number): New function, replacing isfloat_string.
5921 This function checks for valid syntax and produces the resulting
5922 Lisp float number too. Rework it so that string-to-number
5923 no longer mishandles examples like "1.0e+". Use strtoumax,
5924 so that overflow for non-base-10 numbers is reported only when
5925 there's no portable and simple way to convert to floating point.
5927 * textprop.c (set_text_properties_1): Rewrite for clarity,
5928 and to avoid GCC warning about integer overflow.
5930 * intervals.h (struct interval): Use EMACS_INT for members
5931 where EMACS_UINT might cause problems. See
5932 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5933 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5934 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5936 (offset_intervals): Tell GCC not to worry about length overflow
5937 when negating a negative length.
5939 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5940 (overrun_check_free): Likewise.
5942 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5943 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5946 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5947 (gnutls_make_error): Rename local to avoid shadowing.
5948 (gnutls_emacs_global_deinit): ifdef out; not used.
5949 (Fgnutls_boot): Use const for pointer to readonly storage.
5950 Comment out unused local. Fix pointer signedness problems.
5952 * lread.c (openp): Don't stuff size_t into an 'int'.
5953 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5954 about possible signed overflow.
5956 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5957 (GDK_KEY_g): Don't define if already defined.
5958 (xg_prepare_tooltip): Avoid pointer signedness problem.
5959 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5961 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5962 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5964 * xfns.c (Fx_window_property): Simplify a bit,
5965 to make a bit faster and to avoid GCC 4.6.0 warning.
5966 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5968 * fns.c (internal_equal): Don't assume size_t fits in int.
5970 * alloc.c (compact_small_strings): Tighten assertion a little.
5972 Replace pEd with more-general pI, and fix some printf arg casts.
5973 * lisp.h (pI): New macro, generalizing old pEd macro to other
5974 conversion specifiers. For example, use "...%"pI"d..." rather
5975 than "...%"pEd"...".
5976 (pEd): Remove. All uses replaced with similar uses of pI.
5977 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5978 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5979 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5980 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5981 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5982 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5983 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5985 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5986 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5987 * print.c (safe_debug_print, print_object): Likewise.
5988 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5990 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5991 avoiding the 0 flag, which is not portable.
5992 * process.c (Fmake_network_process): Use pI to avoid cast.
5993 * region-cache.c (pp_cache): Likewise.
5994 * xdisp.c (decode_mode_spec): Likewise.
5995 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5996 behavior on 64-bit hosts with printf arg.
5997 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5998 (x_stop_queuing_selection_requests): Likewise.
5999 (x_get_window_property): Don't truncate byte count to an 'int'
6002 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6003 here, since it parses constructs like leading '-' and spaces,
6004 which are not wanted; and it overflows with large numbers.
6005 Instead, simply match F[0-9]+, which is what is wanted anyway.
6007 * alloc.c: Remove unportable assumptions about struct layout.
6008 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6009 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6010 (allocate_vectorlike, make_pure_vector): Use the new macros,
6011 plus offsetof, to remove unportable assumptions about struct layout.
6012 These assumptions hold on all porting targets that I know of, but
6013 they are not guaranteed, they're easy to remove, and removing them
6014 makes further changes easier.
6016 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6017 This doesn't fix a bug but makes the code clearer.
6018 (string_overrun_cookie): Now const. Use initializers that
6019 don't formally overflow signed char, to avoid warnings.
6020 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6021 can cause Emacs to crash when string overrun checking is enabled.
6022 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6023 multiple of sizeof (EMACS_INT); it need not be, if
6024 alignof(EMACS_INT) < sizeof (EMACS_INT).
6025 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6027 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6029 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6031 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6033 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6034 supposed to be handshaking. (Bug#8556)
6035 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6037 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6039 * lisp.h (Qdebug): List symbol.
6040 * eval.c (Qdebug): Restore global linkage.
6041 * keyboard.c (debug-on-event): New variable.
6042 (handle_user_signal): Break into debugger when debug-on-event
6043 matches the current signal symbol.
6045 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6047 * alloc.c (check_sblock, check_string_bytes)
6048 (check_string_free_list): Convert to standard C.
6050 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6052 * w32.c (emacs_gnutls_push): Fix typo.
6054 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6056 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6057 "cast to pointer from integer of different size".
6059 Improve doprnt and its use in verror. (Bug#8545)
6060 * doprnt.c (doprnt): Document the set of format control sequences
6061 supported by the function. Use SAFE_ALLOCA instead of always
6064 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6065 is one byte too soon. Don't use xrealloc; instead xfree and
6068 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6070 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6073 * gnutls.c: Renamed global_initialized to
6074 gnutls_global_initialized. Added internals for the
6075 :verify-hostname-error, :verify-error, and :verify-flags
6076 parameters of `gnutls-boot' and documented those parameters in the
6077 docstring. Start callback support.
6078 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6079 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6080 on error. Return error code.
6081 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6082 (emacs_gnutls_read): Likewise.
6083 (Fgnutls_boot): Return handshake error code.
6084 (emacs_gnutls_handle_error): New function.
6085 (wsaerror_to_errno): Likewise.
6087 * w32.h (emacs_gnutls_pull): Add prototype.
6088 (emacs_gnutls_push): Likewise.
6090 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6091 (emacs_gnutls_push): Likewise.
6093 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6095 * process.c (wait_reading_process_output): Check if GnuTLS
6096 buffered some data internally if no FDs are set for TLS
6099 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6100 (LIBS): Link to USER_LIBS.
6101 ($(BLD)/gnutls.$(0)): New target.
6103 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6105 * xdisp.c (handle_single_display_spec): Rename the
6106 display_replaced_before_p argument into display_replaced_p, to
6107 make it consistent with the commentary. Fix typos in the
6110 * textprop.c (syms_of_textprop): Remove dead code.
6111 (copy_text_properties): Delete obsolete commentary about an
6112 interface that was deleted long ago. Fix typos in the description
6115 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6116 to changes in oldXMenu/XMenu.h from 2011-04-16.
6117 <menu_help_message, prev_menu_help_message>: Constify.
6118 (IT_menu_make_room): menu->help_text is now `const char **';
6121 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6122 to changes in oldXMenu/XMenu.h from 2011-04-16.
6123 (struct XMenu): Declare `help_text' `const char **'.
6125 * xfaces.c <Qunspecified>: Make extern again.
6127 * syntax.c: Include sys/types.h before including regex.h, as
6130 * doc.c (get_doc_string): Improve the format passed to `error'.
6132 * doprnt.c (doprnt): Improve commentary.
6134 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6136 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6139 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6140 changes in globals.h immediately force recompilation.
6141 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6142 $(CURDIR)/s/ms-w32.h.
6143 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6145 * character.c (Fchar_direction): Function deleted.
6146 (syms_of_character): Don't defsubr it.
6147 <char-direction-table>: Deleted.
6149 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6151 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6152 * doprnt.c: Include limits.h.
6153 (SIZE_MAX): New macro.
6154 (doprnt): Return a size_t value. 2nd arg is now size_t.
6155 Many local variables are now size_t instead of int or unsigned.
6156 Improve overflow protection. Support `l' modifier for integer
6157 conversions. Support %l conversion. Don't assume an EMACS_INT
6158 argument for integer conversions and for %c.
6160 * lisp.h (doprnt): Restore prototype.
6162 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6165 * Makefile.in (base_obj): Add back doprnt.o.
6167 * deps.mk (doprnt.o): Add back prerequisites.
6168 (callint.o): Depend on character.h.
6170 * eval.c (internal_lisp_condition_case): Include the handler
6171 representation in the error message.
6172 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6173 when breaking from the loop.
6175 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6177 * callint.c (Fcall_interactively): When displaying error message
6178 about invalid control letter, pass the character's codepoint, not
6179 a pointer to its multibyte form. Improve display of the character
6180 in octal and display also its hex code.
6182 * character.c (char_string): Use %x to display the (unsigned)
6183 codepoint of an invalid character, to avoid displaying a bogus
6186 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6187 `error', not SYMBOL_NAME itself.
6189 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6190 character arguments to `error'.
6192 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6193 to `error' in error message about FINAL_CHAR argument. Make sure
6194 FINAL_CHAR is a character, and use %c when it is passed as
6195 argument to `error'.
6197 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6199 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6201 * w32.c: Include <time.h>.
6202 (sys_localtime): New function.
6204 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6206 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6208 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6210 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6212 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6215 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6217 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6218 gl_state.e_property when gl_state.object is Qt.
6220 * insdel.c (make_gap_larger): Remove limitation of buffer size
6223 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6225 * xdisp.c (lookup_glyphless_char_display)
6226 (produce_glyphless_glyph): Handle cons cell entry in
6227 glyphless-char-display.
6228 (Vglyphless_char_display): Document it.
6230 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6231 glyphless-char-display.
6233 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6235 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6237 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6239 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6240 definition for no-X builds.
6242 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6244 Static checks with GCC 4.6.0 and non-default toolkits.
6246 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6248 * process.c (keyboard_bit_set): Define only if SIGIO.
6249 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6250 (send_process): Repair possible setjmp clobbering.
6252 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6254 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6256 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6258 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6259 Define only if needed.
6261 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6262 by pacifying GCC about it. Maybe it's time to retire it?
6263 * xfaces.c (USG, __TIMEVAL__): Likewise.
6265 * dispextern.h (struct redisplay_interface): Rename param
6267 * termhooks.h (struct terminal): Likewise.
6268 * xterm.c (xembed_send_message): Likewise.
6270 * insdel.c (make_gap_smaller): Define only if
6271 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6273 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6276 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6277 so that we aren't warned about unused symbols.
6279 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6281 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6283 * xfns.c (x_real_positions): Mark locals as initialized.
6285 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6287 * xterm.c: Fix problems found by static analysis with other toolkits.
6288 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6289 (x_dispatch_event): Declare static if USE_GTK, and
6290 define if USE_GTK || USE_X_TOOLKIT.
6291 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6292 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6293 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6294 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6296 * xmenu.c (menu_help_callback): Pointer type fixes.
6297 Use const pointers when pointing at readonly data. Avoid pointer
6299 (FALSE): Remove unused macro.
6300 (update_frame_menubar): Remove unused decl.
6302 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6304 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6305 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6306 (single_menu_item): Rename local to avoid shadowing.
6308 * keyboard.c (make_lispy_event): Remove unused local var.
6310 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6311 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6313 * bitmaps: Change bitmaps from unsigned char back to the X11
6314 compatible char. Avoid the old compiler warnings about
6315 out-of-range initializers by using, for example, '\xab' rather
6318 * xgselect.c (xgselect_initialize): Check vs interface
6319 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6321 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6323 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6324 to read-only memory.
6326 * fns.c (vector): Remove; this old hack is no longer needed.
6328 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6330 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6332 * xrdb.c (x_load_resources): Omit unused local.
6334 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6335 (x_window): Rename locals to avoid shadowing.
6336 (USG): Use the kludged USG macro, to pacify gcc.
6338 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6339 (x_term_init): Remove local to avoid shadowing.
6341 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6343 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6344 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6346 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6348 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6350 Fix regex.c, syntax.c and friends for buffers > 2GB.
6351 * syntax.h (struct gl_state_s): Declare character position members
6354 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6356 * textprop.c (verify_interval_modification, interval_of):
6357 Declare arguments EMACS_INT.
6359 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6362 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6364 * indent.c (Fvertical_motion): Local variable it_start is now
6367 * regex.c (re_match, re_match_2, re_match_2_internal)
6368 (bcmp_translate, regcomp, regexec, print_double_string)
6369 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6370 (re_compile_pattern, re_exec): Declare arguments and local
6371 variables `size_t' and `ssize_t' and return values `regoff_t', as
6373 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6374 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6375 <compile_stack_type>: `size' and `avail' are now `size_t'.
6377 * regex.h <regoff_t>: Use ssize_t, not int.
6378 (re_search, re_search_2, re_match, re_match_2): Arguments that
6379 specify buffer/string position and length are now ssize_t and
6380 size_t. Return type is regoff_t.
6382 2011-04-16 Ben Key <bkey76@gmail.com>
6384 * nsfont.m: Fixed bugs in ns_get_family and
6385 ns_descriptor_to_entity that were caused by using free to
6386 deallocate memory blocks that were allocated by xmalloc (via
6387 xstrdup). This caused Emacs to crash when compiled with
6388 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6389 --enable-checking=xmallocoverrun). xfree is now used to
6390 deallocate these memory blocks.
6392 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6394 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6396 emacs_write: Accept and return EMACS_INT for sizes.
6397 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6399 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6400 Accept and return EMACS_INT.
6401 (emacs_gnutls_write): Return the number of bytes written on
6403 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6404 (emacs_read, emacs_write): Remove check for negative size, as the
6405 Emacs source code has been audited now.
6406 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6407 (emacs_read, emacs_write): Use it.
6408 * process.c (send_process): Adjust to the new signatures of
6409 emacs_write and emacs_gnutls_write. Do not attempt to store
6410 a byte offset into an 'int'; it might overflow.
6411 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6413 * sound.c: Don't assume sizes fit in 'int'.
6414 (struct sound_device.period_size, alsa_period_size):
6415 Return EMACS_INT, not int.
6416 (struct sound_device.write, vox_write, alsa_write):
6417 Accept EMACS_INT, not int.
6418 (wav_play, au_play): Use EMACS_INT to store sizes and to
6419 record read return values.
6421 2011-04-15 Ben Key <bkey76@gmail.com>
6423 * keyboard.c (Qundefined): Don't declare static since it is used
6425 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6426 static since they are used in nsfont.m.
6428 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6430 * process.c (Qprocessp): Don't declare static.
6431 * lisp.h (Qprocessp): Declare again.
6433 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6435 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6437 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6439 Improve C-level modularity by making more things 'static'.
6441 Don't publish debugger-only interfaces to other modules.
6442 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6443 (verify_bytepos, count_markers): Move decls to the only modules
6445 * region-cache.h (pp_cache): Likewise.
6446 * window.h (check_all_windows): Likewise.
6447 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6449 * sysdep.c (croak): Now static, if
6450 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6451 * syssignal.h (croak): Declare only if not static.
6453 * alloc.c (refill_memory_reserve): Now static if
6454 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6455 * lisp.h (refill_memory_reserve): Declare only if not static.
6457 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6458 Define only if USE_LUCID.
6460 * xrdb.c (x_customization_string, x_rm_string): Now static.
6462 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6463 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6465 * xdisp.c (draw_row_with_mouse_face): Now static.
6466 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6468 * window.h (check_all_windows): Mark externally visible.
6470 * window.c (window_deletion_count): Now static.
6472 * undo.c: Make symbols static if they're not exported.
6473 (last_undo_buffer, last_boundary_position, pending_boundary):
6476 * textprop.c (interval_insert_behind_hooks): Now static.
6477 (interval_insert_in_front_hooks): Likewise.
6479 * term.c: Make symbols static if they're not exported.
6480 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6481 (max_frame_lines, tty_set_terminal_modes):
6482 (tty_reset_terminal_modes, tty_turn_off_highlight):
6483 (get_tty_terminal): Now static.
6484 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6485 * termhooks.h (term_mouse_moveto): Do not declare if
6487 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6488 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6490 * sysdep.c: Make symbols static if they're not exported.
6491 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6493 (sigprocmask_set, full_mask): Remove; unused.
6494 (wait_debugging): Mark as visible.
6495 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6496 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6498 * syntax.c (syntax_temp): Define only if !__GNUC__.
6500 * sound.c (current_sound_device, current_sound): Now static.
6502 * search.c (searchbufs, searchbuf_head): Now static.
6504 * scroll.c (scroll_cost): Remove; unused.
6505 * dispextern.h (scroll_cost): Remove decl.
6507 * region-cache.h (pp_cache): Mark as externally visible.
6509 * process.c: Make symbols static if they're not exported.
6510 (process_tick, update_tick, create_process, chan_process):
6511 (Vprocess_alist, proc_buffered_char, datagram_access):
6512 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6513 (deactivate_process): Mark defn as static, as well as decl.
6514 * lisp.h (create_process): Remove decl.
6515 * process.h (chan_process, Vprocess_alist): Remove decls.
6517 * print.c: Make symbols static if they're not exported.
6518 (print_depth, new_backquote_output, being_printed, print_buffer):
6519 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6520 (print_interval, print_number_index, initial_stderr_stream):
6522 * lisp.h (Fprinc): Remove decl.
6523 (debug_output_compilation_hack): Mark as externally visible.
6525 * sysdep.c (croak): Move decl from here to syssignal.h.
6526 * syssignal.h (croak): Put it here, so the API can be checked when
6527 'croak' is called from dissociate_if_controlling_tty.
6529 * minibuf.c: Make symbols static if they're not exported.
6530 (minibuf_save_list, choose_minibuf_frame): Now static.
6531 * lisp.h (choose_minibuf_frame): Remove decl.
6533 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6535 * lread.c: Make symbols static if they're not exported.
6536 (read_objects, initial_obarray, oblookup_last_bucket_number):
6538 (make_symbol): Remove; unused.
6539 * lisp.h (initial_obarray, make_symbol): Remove decls.
6541 * keyboard.c: Make symbols static if they're not exported.
6542 (single_kboard, recent_keys_index, total_keys, recent_keys):
6543 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6544 (this_single_command_key_start, echoing, last_auto_save):
6545 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6546 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6547 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6548 (Vlispy_mouse_stem, double_click_count):
6550 (force_auto_save_soon): Define only if SIGDANGER.
6551 (ignore_mouse_drag_p): Now static if
6552 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6553 (print_help): Remove; unused.
6554 (stop_character, last_timer_event): Mark as externally visible.
6555 * keyboard.h (ignore_mouse_drag_p): Declare only if
6556 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6557 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6558 * lisp.h (echoing): Remove decl.
6559 (force_auto_save_soon): Declare only if SIGDANGER.
6560 * xdisp.c (redisplay_window): Simplify code, to make it more
6561 obvious that ignore_mouse_drag_p is not accessed if !defined
6562 USE_GTK && !defined HAVE_NS.
6564 * intervals.c: Make symbols static if they're not exported.
6565 (merge_properties_sticky, merge_interval_right, delete_interval):
6567 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6569 * insdel.c: Make symbols static if they're not exported.
6570 However, leave prepare_to_modify_buffer alone. It's never
6571 called from outside this function, but that appears to be a bug.
6572 (combine_after_change_list, combine_after_change_buffer):
6573 (adjust_after_replace, signal_before_change): Now static.
6574 (adjust_after_replace_noundo): Remove; unused.
6575 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6576 (signal_before_change): Remove decls.
6578 * indent.c (val_compute_motion, val_vmotion): Now static.
6580 * image.c: Make symbols static if they're not exported.
6581 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6583 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6584 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6586 * fringe.c (standard_bitmaps): Now static.
6587 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6589 * frame.c: Make symbols static if they're not exported.
6590 (x_report_frame_params, make_terminal_frame): Now static.
6591 (get_frame_param): Now static, unless HAVE_NS.
6592 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6593 (x_get_resource_string): Remove; not used.
6594 * frame.h (make_terminal_frame, x_report_frame_params):
6595 (x_get_resource_string); Remove decls.
6596 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6597 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6599 * font.c, fontset.c: Make symbols static if they're not exported.
6600 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6601 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6602 * font.c (font_close_object): Now static.
6603 * font.h (font_close_object): Remove.
6604 * fontset.c (FONTSET_OBJLIST): Remove.
6605 (free_realized_fontset) #if-0 the body, which does nothing.
6606 (face_suitable_for_char_p): #if-0, as it's never called.
6607 * fontset.h (face_suitable_for_char_p): Remove decl.
6608 * xfaces.c (face_at_string_position):
6609 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6610 since 0 is always ASCII.
6612 * fns.c (weak_hash_tables): Now static.
6614 * fileio.c: Make symbols static if they're not exported.
6615 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6616 (Vwrite_region_annotation_buffers): Now static.
6618 * eval.c: Make symbols static if they're not exported.
6619 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6620 * lisp.h (backtrace_list): Remove decl.
6622 * emacs.c: Make symbols static if they're not exported.
6623 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6624 (fatal_error_code, fatal_error_signal_hook, standard_args):
6626 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6627 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6628 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6629 * lisp.h (fatal_error_signal_hook): Remove decl.
6630 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6632 * editfns.c: Move a (normally-unused) function to its only use.
6633 * editfns.c, lisp.h (get_operating_system_release): Remove.
6634 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6635 worth the hassle of breaking this out.
6637 * xterm.c: Make symbols static if they're not exported.
6638 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6639 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6640 (x_destroy_window, x_delete_display):
6642 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6643 (x_mouse_leave): Remove; unused.
6644 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6645 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6646 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6648 (x_mouse_leave): Declare only if WINDOWSNT.
6649 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6650 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6653 * ftxfont.c: Make symbols static if they're not exported.
6654 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6656 * font.h (ftxfont_driver): Likewise.
6658 * xfns.c: Make symbols static if they're not exported.
6659 (x_last_font_name, x_display_info_for_name):
6660 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6661 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6662 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6663 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6664 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6665 (last_show_tip_args): Now static.
6666 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6667 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6668 (x_screen_planes): Remove; unused.
6669 * dispextern.h (x_screen_planes): Remove decl.
6671 * dispnew.c: Make symbols static if they're not exported.
6672 * dispextern.h (redraw_garbaged_frames, scrolling):
6673 (increment_row_positions): Remove.
6674 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6675 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6677 (redraw_garbaged_frames): Remove; unused.
6679 * xfaces.c: Make symbols static if they're not exported.
6680 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6682 * xterm.h (defined_color): Remove decls.
6683 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6684 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6685 (menu_face_changed_default, defined_color, free_realized_face):
6686 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6687 (ascii_face_of_lisp_face): Remove; unused.
6689 * xdisp.c: Make symbols static if they're not exported.
6690 * dispextern.h (scratch_glyph_row, window_box_edges):
6691 (glyph_to_pixel_coords, set_cursor_from_row):
6692 (get_next_display_element, set_iterator_to_next):
6693 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6694 (show_mouse_face): Remove decls
6695 * frame.h (message_buf_print): Likewise.
6696 * lisp.h (pop_message, set_message, check_point_in_composition):
6698 * xterm.h (set_vertical_scroll_bar): Likewise.
6699 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6700 (message_buf_print, scratch_glyph_row, displayed_buffer):
6701 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6702 (get_next_display_element, show_mouse_face, window_box_edges):
6703 (frame_to_window_pixel_xy, check_point_in_composition):
6704 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6705 (glyph_to_pixel_coords): Remove; unused.
6707 * dired.c (file_name_completion): Now static.
6709 * dbusbind.c (xd_in_read_queued_messages): Now static.
6711 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6712 * data.c (circular_list_error): Remove.
6714 * commands.h (last_point_position, last_point_position_buffer):
6715 (last_point_position_window): Remove decls.
6716 * keyboard.c: Make these variables static.
6718 * coding.h (coding, code_convert_region, encode_coding_gap):
6720 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6721 (iso_code_class, detect_coding, code_convert_region): Now static.
6722 (encode_coding_gap): Remove; unused.
6724 * chartab.c (chartab_chars, chartab_bits): Now static.
6726 * charset.h (charset_iso_8859_1): Remove decl.
6727 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6730 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6731 * ccl.c (Vccl_program_table): Now static.
6732 (check_ccl_update): Remove; unused.
6734 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6735 * category.h: ... from here.
6736 * category.c (check_category_table, set_category_set): Now static.
6738 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6739 * lisp.h: Remove these decls.
6741 * buffer.c (buffer_count): Remove unused var.
6743 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6744 so that it's not optimized away.
6745 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6746 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6747 exported only to the debugger.
6749 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6750 * atimer.h (run_all_atimers): Remove; not exported.
6752 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6753 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6754 was inaccessible from Lisp.
6755 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6756 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6758 alloc.c: Import and export fewer symbols, and remove unused items.
6759 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6761 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6762 it's not optimized away by whole-program optimization.
6763 (message_enable_multibyte, free_misc): Remove.
6764 (catchlist, handlerlist, mark_backtrace):
6765 Declare only if BYTE_MARK_STACK.
6766 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6767 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6768 (message_enable_multibyte): Remove decl.
6769 (free_misc, interval_free_list, float_block, float_block_index):
6770 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6771 (cons_free_list, last_marked_index):
6773 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6774 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6775 (mark_backtrace): Define only if BYTE_MARK_STACK.
6776 * xdisp.c (message_enable_multibyte): Now static.
6778 Declare Lisp_Object Q* variables to be 'static' if not exported.
6779 This makes it easier for human readers (and static analyzers)
6780 to see whether these variables are used from other modules.
6781 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6782 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6783 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6784 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6785 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6786 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6787 * xmenu.c, xselect.c:
6788 Declare Q* vars static if they are not used in other modules.
6789 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6790 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6791 Remove decls of unexported vars.
6792 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6794 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6796 Make Emacs functions such as Fatom 'static' by default.
6797 This makes it easier for human readers (and static analyzers)
6798 to see whether these functions can be called from other modules.
6799 DEFUN now defines a static function. To make the function external
6800 so that it can be used in other C modules, use the new macro DEFUE.
6801 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6802 (Finit_image_library):
6803 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6804 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6805 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6806 Remove decls, since these functions are now static.
6807 (Funintern, Fget_internal_run_time): New decls, since these functions
6808 were already external.
6810 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6811 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6812 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6813 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6814 * keyboard.c, keymap.c, lread.c:
6815 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6816 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6817 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6818 Mark functions with DEFUE instead of DEFUN,
6819 if they are used in other modules.
6820 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6821 decls for now-static functions.
6822 * buffer.h (Fdelete_overlay): Remove decl.
6823 * callproc.c (Fgetenv_internal): Mark as internal.
6824 * composite.c (Fremove_list_of_text_properties): Remove decl.
6825 (Fcomposition_get_gstring): New forward static decl.
6826 * composite.h (Fcomposite_get_gstring): Remove decl.
6827 * dired.c (Ffile_attributes): New forward static decl.
6828 * doc.c (Fdocumntation_property): New forward static decl.
6829 * eval.c (Ffetch_bytecode): New forward static decl.
6830 (Funintern): Remove extern decl; now in .h file where it belongs.
6831 * fileio.c (Fmake_symbolic_link): New forward static decl.
6832 * image.c (Finit_image_library): New forward static decl.
6833 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6834 * intervals.h (Fprevious_property_change):
6835 (Fremove_list_of_text_properties): Remove decls.
6836 * keyboard.c (Fthis_command_keys): Remove decl.
6837 (Fcommand_execute): New forward static decl.
6838 * keymap.c (Flookup_key): New forward static decl.
6839 (Fcopy_keymap): Now static.
6840 * keymap.h (Flookup_key): Remove decl.
6841 * process.c (Fget_process): New forward static decl.
6842 (Fprocess_datagram_address): Mark as internal.
6843 * syntax.c (Fsyntax_table_p): New forward static decl.
6844 (skip_chars): Remove duplicate decl.
6845 * textprop.c (Fprevious_property_change): New forward static decl.
6846 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6848 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6849 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6851 * editfns.c (Fformat): Remove unreachable code.
6853 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6855 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6858 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6860 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6861 when at ZV. (Bug#8487)
6863 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6865 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6867 * keyboard.c (parse_tool_bar_item): Likewise.
6868 * sound.c (sound_cleanup, alsa_close): Likewise.
6869 * termcap.c (tgetent): Likewise.
6870 * xfns.c (x_default_font_parameter): Likewise.
6871 * xsettings.c (read_and_apply_settings): Likewise.
6873 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6874 (overrun_check_free): Protoize.
6876 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6878 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6879 since callers should never pass a negative size.
6880 Change the signature to match that of plain 'read' and 'write'; see
6881 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6882 * lisp.h: Update prototypes of emacs_write and emacs_read.
6884 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6886 * xdisp.c (redisplay_window): Don't try to determine the character
6887 position of the scroll margin if the window start point w->startp
6888 is outside the buffer's accessible region. (Bug#8468)
6890 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6892 Fix write-region and its subroutines for buffers > 2GB.
6893 * fileio.c (a_write, e_write): Modify declaration of arguments and
6894 local variables to support buffers larger than 2GB.
6895 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6897 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6898 argument, local variables, and return value.
6900 * lisp.h: Update prototypes of emacs_write and emacs_read.
6902 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6904 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6906 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6908 Fix more problems found by GCC 4.6.0's static checks.
6910 * xdisp.c (vmessage): Use a better test for character truncation.
6912 * charset.c (load_charset_map): <, not <=, for optimization,
6913 and to avoid potential problems with integer overflow.
6914 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6915 * casetab.c (set_identity, shuffle): Likewise.
6916 * editfns.c (Fformat): Likewise.
6917 * syntax.c (skip_chars): Likewise.
6919 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6920 This also lets GCC 4.6.0 generate slightly better loop code.
6922 * callint.c (Fcall_interactively): <, not <=, for optimization.
6923 (Fcall_interactively): Count the number of arguments produced,
6924 not the number of arguments given. This is simpler and lets GCC
6925 4.6.0 generate slightly better code.
6927 * ftfont.c: Distingish more carefully between FcChar8 and char.
6928 The previous code passed unsigned char * to a functions like
6929 strlen and xstrcasecmp that expect char *, which does not
6930 conform to the C standard.
6931 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6932 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6933 char * when the C standard requires it.
6935 * keyboard.c (read_char): Remove unused var.
6937 * eval.c: Port to Windows vsnprintf (Bug#8435).
6939 (SIZE_MAX): Define if the headers do not.
6940 (verror): Do not give up if vsnprintf returns a negative count.
6941 Instead, grow the buffer. This ports to Windows vsnprintf, which
6942 does not conform to C99. Problem reported by Eli Zaretskii.
6943 Also, simplify the allocation scheme, by avoiding the need for
6944 calling realloc, and removing the ALLOCATED variable.
6946 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6948 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6949 But keep the doprint source code for now, as we might revamp it
6950 and use it again (Bug#8435).
6951 * lisp.h (doprnt): Remove.
6952 * Makefile.in (base_obj): Remove doprnt.o.
6953 * deps.mk (doprnt.o): Remove.
6955 error: Print 32- and 64-bit integers portably (Bug#8435).
6956 Without this change, on typical 64-bit hosts error ("...%d...", N)
6957 was used to print both 32- and 64-bit integers N, which relied on
6959 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6961 * lisp.h (error, verror): Mark as printf-like functions.
6962 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6963 Report overflow in size calculations when allocating printf buffer.
6964 Do not truncate output string at its first null byte.
6965 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6966 Truncate the output at a character boundary, since vsnprintf does not
6968 * charset.c (check_iso_charset_parameter): Convert internal
6969 character to string before calling 'error', since %c now has the
6971 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6972 overflow when computing char to be passed to 'error'. Do not
6973 pass Lisp_Object to 'error'; pass the integer instead.
6974 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6975 formatted with plain %d.
6977 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6979 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6981 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6983 * xterm.c (x_catch_errors): Remove duplicate declaration.
6985 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6987 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6989 2011-04-10 Jim Meyering <meyering@redhat.com>
6991 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6992 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6993 return ssize_t not "int", and use size_t as the buffer length.
6994 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6995 * gnutls.h: Update declarations.
6996 * process.c (read_process_output): Use ssize_t, to match.
6997 (send_process): Likewise.
6999 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7001 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7003 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7005 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7006 Use unsigned char, to match FcChar8 type definition.
7008 * xterm.c (handle_one_xevent):
7009 * xmenu.c (create_and_show_popup_menu):
7010 * xselect.c (x_decline_selection_request)
7011 (x_reply_selection_request): Avoid type-punned deref of X events.
7013 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7015 Fix some uses of `int' instead of EMACS_INT.
7016 * search.c (string_match_1, fast_string_match)
7017 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7018 (scan_buffer, find_next_newline_no_quit)
7019 (find_before_next_newline, search_command, Freplace_match)
7020 (Fmatch_data): Make some `int' variables be EMACS_INT.
7022 * xdisp.c (display_count_lines): 3rd argument and return value now
7023 EMACS_INT. All callers changed.
7024 (pint2hrstr): Last argument is now EMACS_INT.
7026 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7027 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7028 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7029 (decode_coding_utf_16, decode_coding_emacs_mule)
7030 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7031 (decode_coding_ccl, decode_coding_charset)
7032 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7033 (decode_coding_iso_2022, decode_coding_emacs_mule)
7034 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7035 <char_offset, last_offset>: Declare EMACS_INT.
7036 (encode_coding_utf_8, encode_coding_utf_16)
7037 (encode_coding_emacs_mule, encode_invocation_designation)
7038 (encode_designation_at_bol, encode_coding_iso_2022)
7039 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7040 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7042 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7043 (encode_invocation_designation): Last argument P_NCHARS is now
7045 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7046 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7048 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7051 * ccl.c (Fccl_execute_on_string): Declare some variables
7054 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7056 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7058 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7060 * process.c (Fformat_network_address): Doc fix.
7062 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7064 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
7066 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7068 * keyboard.c (read_char): Call Lisp function help-form-show,
7069 instead of using internal_with_output_to_temp_buffer.
7070 (Qhelp_form_show): New var.
7071 (syms_of_keyboard): Use DEFSYM macro.
7073 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7075 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7077 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7079 * process.c (Flist_processes): Remove to Lisp.
7080 (list_processes_1): Delete.
7082 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7084 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7086 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7088 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7090 Fix more problems found by GCC 4.6.0's static checks.
7092 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7094 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7096 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7098 * xdisp.c (vmessage): Mark as a printf-like function.
7100 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7102 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7104 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7105 printf-like functions.
7106 (tiff_load): Add casts to remove these marks before passing them
7107 to system-supplied API.
7109 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7111 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7112 This avoids several warnings with gcc -Wstrict-overflow.
7113 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7114 directly, rather than having caller test rule sign. This avoids
7115 some unnecessary tests.
7116 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7117 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7118 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7120 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7121 (xfont_open): Avoid unnecessary tests.
7123 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7125 * composite.h, composite.c (composition_gstring_put_cache):
7126 Use EMACS_INT, not int, for length.
7128 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7129 breaking out part of COMPOSITION_DECODE_RULE.
7130 (COMPOSITION_DECODE_RULE): Use it.
7131 * composite.c (get_composition_id): Remove unused local vars,
7132 by using the new macro.
7134 * textprop.c (set_text_properties_1): Change while to do-while,
7135 since the condition is always true at first.
7137 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7138 (interval_deletion_adjustment): Return unsigned value.
7141 * process.c (list_processes_1, create_pty, read_process_output):
7142 (exec_sentinel): Remove vars that were set but not used.
7143 (create_pty): Remove unnecessary "volatile"s.
7144 (Fnetwork_interface_info): Avoid possibility of int overflow.
7145 (read_process_output): Do adaptive read buffering even if carryover.
7146 (read_process_output): Simplify nbytes computation if buffered.
7148 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7150 * syntax.c (scan_words): Remove var that was set but not used.
7151 (update_syntax_table): Use unsigned instead of int.
7153 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7154 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7155 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7157 * print.c (print_error_message): Avoid int overflow.
7159 * font.c (font_list_entities): Redo for clarity,
7160 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7162 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7163 (font_score): Avoid potential overflow in diff calculation.
7165 * fns.c (substring_both): Remove var that is set but not used.
7166 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7168 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7170 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7171 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7172 can always succeed if overflow has undefined behavior.
7174 * search.c (boyer_moore, wordify): Remove vars set but not used.
7175 (wordify): Omit three unnecessary tests.
7177 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7178 All callers changed. This avoids the need for an unused var.
7180 * casefiddle.c (casify_region): Remove var that is set but not used.
7182 * dired.c (file_name_completion): Remove var that is set but not used.
7184 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7186 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7187 (Finsert_file_contents): Remove unnecessary code checking fd.
7189 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7190 Check for integer overflow on size calculations.
7192 * buffer.c (Fprevious_overlay_change): Remove var that is set
7195 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7196 Remove vars that are set but not used.
7197 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7198 (timer_check_2): Mark vars as initialized.
7200 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7202 * image.c (lookup_image): Remove var that is set but not used.
7203 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7205 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7206 that are set but not used.
7208 * xfns.c (make_invisible_cursor): Don't return garbage
7209 if XCreateBitmapFromData fails (Bug#8410).
7211 * xselect.c (x_get_local_selection, x_handle_property_notify):
7212 Remove vars that are set but not used.
7214 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7215 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7217 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7218 Remove var that is set but not used.
7219 (scroll_bar_windows_size): Now size_t, not int.
7220 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7223 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7224 (map_tty_color) [!defined MSDOS]: Likewise.
7226 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7228 * coding.c: Remove vars that are set but not used.
7229 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7230 All callers changed.
7231 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7232 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7233 (decode_coding_charset): Remove vars that are set but not used.
7235 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7236 that is set but not used.
7238 * print.c (print_object): Remove var that is set but not used.
7240 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7241 The gnulib version avoids calling malloc in the usual case,
7242 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7243 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7244 * filelock.c (current_lock_owner): Likewise.
7245 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7246 * sysdep.c: Include allocator.h, careadlinkat.h.
7247 (emacs_no_realloc_allocator): New static constant.
7248 (emacs_readlink): New function.
7249 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7250 ../lib/careadlinkat.h.
7252 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7254 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7255 first non-nil return value).
7257 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7259 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7260 if not defined (Bug#8403).
7262 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7264 * xdisp.c (display_count_lines): Remove parameter `start',
7265 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7266 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7267 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7268 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7269 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7270 and thereabouts. All callers changed.
7271 (get_per_char_metric): Remove parameter `f', unused since
7272 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7274 2011-04-02 Jim Meyering <meyering@redhat.com>
7276 do not dereference NULL upon failed strdup
7277 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7278 (ns_get_family): Likewise.
7280 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7282 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7284 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7286 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7289 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7291 Add lexical binding.
7293 * window.c (Ftemp_output_buffer_show): New fun.
7294 (Fsave_window_excursion):
7295 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7297 * lread.c (lisp_file_lexically_bound_p): New function.
7298 (Fload): Bind Qlexical_binding.
7299 (readevalloop): Remove `evalfun' arg.
7300 Bind Qinternal_interpreter_environment.
7301 (Feval_buffer): Bind Qlexical_binding.
7302 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7304 (syms_of_lread): Declare `lexical-binding'.
7306 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7308 * keyboard.c (eval_dyn): New fun.
7309 (menu_item_eval_property): Use it.
7311 * image.c (parse_image_spec): Use Ffunctionp.
7313 * fns.c (concat, mapcar1): Accept byte-code-functions.
7315 * eval.c (Fsetq): Handle lexical vars.
7316 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7317 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7318 (FletX, Flet): Obey lexical binding.
7319 (Fcommandp): Handle closures.
7320 (Feval): New `lexical' arg.
7321 (eval_sub): New function extracted from Feval. Use it almost
7322 everywhere where Feval was used. Look up vars in lexical env.
7324 (Ffunctionp): Move from subr.el.
7325 (Ffuncall): Handle closures.
7326 (apply_lambda): Remove `eval_flags'.
7327 (funcall_lambda): Handle closures and new byte-code-functions.
7328 (Fspecial_variable_p): New function.
7329 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7330 but without exporting it to Lisp.
7332 * doc.c (Fdocumentation, store_function_docstring):
7333 * data.c (Finteractive_form): Handle closures.
7335 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7338 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7340 (exec_byte_code): New function extracted from Fbyte_code to handle new
7341 calling convention for byte-code-functions. Add new byte-codes.
7343 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7345 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7347 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7349 * xdisp.c (redisplay_internal): Fix prototype.
7351 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7353 * xdisp.c (SCROLL_LIMIT): New macro.
7354 (try_scrolling): Use it when setting scroll_limit.
7355 Limit scrolling to 100 screen lines.
7356 (redisplay_window): Even when falling back on "recentering",
7357 position point in the window according to scroll-conservatively,
7358 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7360 (try_scrolling): When point is above the window, allow searching
7361 as far as scroll_max, or one screenful, to compute vertical
7362 distance from PT to the scroll margin position. This prevents
7363 try_scrolling from unnecessarily failing when
7364 scroll-conservatively is set to a value slightly larger than the
7365 window height. Clean up the case of PT below the margin at bottom
7366 of window: scroll_max can no longer be INT_MAX. When aggressive
7367 scrolling is in use, don't let point enter the opposite scroll
7368 margin as result of the scroll.
7369 (syms_of_xdisp) <scroll-conservatively>: Document the
7370 threshold of 100 lines for never-recentering scrolling.
7372 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7374 * dispextern.h (move_it_by_lines):
7375 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7376 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7377 (message_log_check_duplicate): Remove parameters `prev_bol' and
7378 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7379 (redisplay_internal): Remove parameter `preserve_echo_area',
7380 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7382 * indent.c (Fvertical_motion):
7383 * window.c (window_scroll_pixel_based, Frecenter):
7384 Don't pass `need_y_p' to `move_it_by_lines'.
7386 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7388 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7389 steal a few bits to be more compact.
7390 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7391 Remove unneeded casts.
7393 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7395 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7397 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7398 binding" message (bug#7967).
7400 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7402 Fix more problems found by GCC 4.6.0's static checks.
7404 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7405 Remove unused local var.
7407 * editfns.c (Fmessage_box): Remove unused local var.
7409 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7410 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7411 Omit unused local vars.
7412 * window.c (shrink_windows): Omit unused local var.
7413 * menu.c (digest_single_submenu): Omit unused local var.
7414 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7415 Omit unused local var.
7417 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7418 Don't assume string length fits in int.
7419 (keyremap_step, read_key_sequence): Use size_t for sizes.
7420 (read_key_sequence): Don't check last_real_key_start redundantly.
7422 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7423 instead of alloca (Bug#8344).
7425 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7426 (Fbacktrace_frame): Don't assume nframes fits in int.
7428 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7430 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7433 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7435 * cm.c (calccost): Turn while-do into do-while, for clarity.
7437 * keyboard.c (syms_of_keyboard): Use the same style as later
7438 in this function when indexing through an array. This also
7439 works around GCC bug 48267.
7441 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7443 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7445 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7446 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7448 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7449 This avoids undefined behavior on integer overflow, and is a bit
7450 more convenient anyway since it is compared to a size_t variable.
7452 Variadic C functions now count arguments with size_t, not int.
7453 This avoids an unnecessary limitation on 64-bit machines, which
7454 caused (substring ...) to crash on large vectors (Bug#8344).
7455 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7456 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7457 All variadic functions and their callers changed accordingly.
7458 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7459 * data.c (arith_driver, float_arith_driver): Likewise.
7460 * editfns.c (general_insert_function): Likewise.
7461 * eval.c (struct backtrace.nargs, interactive_p)
7462 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7463 (funcall_lambda, mark_backtrace): Likewise.
7464 * fns.c (concat): Likewise.
7465 * frame.c (x_set_frame_parameters): Likewise.
7466 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7467 0 if not found, not -1. All callers changed.
7469 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7470 (stack_copy_size): Now size_t, not int.
7471 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7473 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7475 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7476 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7477 All callers changed.
7479 * lisp.h (multibyte_char_to_unibyte):
7480 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7481 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7482 * character.h (CHAR_TO_BYTE8):
7483 * cmds.c (internal_self_insert):
7484 * editfns.c (general_insert_function):
7485 * keymap.c (push_key_description):
7486 * search.c (Freplace_match):
7487 * xdisp.c (message_dolog, set_message_1): All callers changed.
7489 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7491 * keyboard.c (safe_run_hook_funcall): New function.
7492 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7493 don't set the hook to nil, but remove the offending function instead.
7494 (Qcommand_hook_internal): Remove, unused.
7495 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7496 Vcommand_hook_internal.
7498 * eval.c (enum run_hooks_condition): Remove.
7499 (funcall_nil, funcall_not): New functions.
7500 (run_hook_with_args): Call each function through a `funcall' argument.
7501 Remove `cond' argument, now redundant.
7502 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7503 (Frun_hook_with_args_until_failure): Adjust accordingly.
7504 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7506 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7508 * dispextern.h (string_buffer_position): Remove declaration.
7510 * print.c (strout): Remove parameter `multibyte', unused since
7511 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7513 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7514 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7515 All callers changed.
7517 * w32.c (_wsa_errlist): Use braces for struct initializers.
7519 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7520 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7521 All callers changed.
7522 (string_buffer_position): Likewise. Also, make static (it's never
7523 used outside xdisp.c).
7524 (cursor_row_p): Remove parameter `w', unused since
7525 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7526 (decode_mode_spec): Remove parameter `precision', introduced during
7527 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7528 All callers changed.
7530 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7532 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7534 2011-03-27 Anders Lindgren <andlind@gmail.com>
7536 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7537 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7538 (ns_update_auto_hide_menu_bar): New functions.
7539 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7540 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7541 ns_constrain_all_frames.
7542 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7543 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7545 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7547 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7549 2011-03-27 Glenn Morris <rgm@gnu.org>
7551 * syssignal.h: Replace RETSIGTYPE with void.
7552 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7553 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7554 Replace SIGTYPE with void everywhere.
7555 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7556 * s/template.h (SIGTYPE): Remove commented out definition.
7558 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7560 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7561 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7563 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7565 * w32.c (read_unc_volume): Use parameter `henum', instead of
7566 global variable `wget_enum_handle'.
7568 * keymap.c (describe_vector): Remove parameters `indices' and
7569 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7570 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7572 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7574 * keyboard.c (timer_check): Remove parameter `do_it_now',
7575 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7576 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7577 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7579 * keyboard.c (read_char):
7580 * w32menu.c (w32_menu_display_help):
7581 * xmenu.c (show_help_event, menu_help_callback):
7582 Adjust calls to `show_help_echo'.
7584 * gtkutil.c (xg_maybe_add_timer):
7585 * keyboard.c (readable_events):
7586 * process.c (wait_reading_process_output):
7587 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7589 * insdel.c (adjust_markers_gap_motion):
7590 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7591 (gap_left, gap_right): Don't call it.
7593 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7595 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7596 incurred during fontification.
7598 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7600 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7601 (DEFVAR_PER_BUFFER): Don't pass it.
7603 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7604 (scrolling_window): Don't pass it.
7606 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7608 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7610 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7612 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7613 of variables specific to SELinux and computation of `encoded_absname'.
7615 * image.c (XPutPixel): Remove unused variable `height'.
7617 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7619 * unexw32.c (get_section_info): Remove unused variable `section'.
7621 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7622 (system_process_attributes): Remove unused variable `sess'.
7623 (sys_read): Remove unused variable `err'.
7625 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7626 (w32_wnd_proc): Remove unused variable `isdead'.
7627 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7628 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7629 (x_create_tip_frame): Remove unused variable `tem'.
7631 * w32inevt.c (w32_console_read_socket):
7632 Remove unused variable `no_events'.
7634 * w32term.c (x_draw_composite_glyph_string_foreground):
7635 Remove unused variable `width'.
7637 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7639 * w32term.c (x_set_glyph_string_clipping):
7640 Don't pass uninitialized region to CombineRgn.
7642 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7644 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7645 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7646 (Fx_close_connection): Remove unused variable `i'.
7648 * w32font.c (w32font_draw): Return number of glyphs.
7649 (w32font_open_internal): Remove unused variable `i'.
7650 (w32font_driver): Add missing initializer.
7652 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7653 (fill_in_menu): Remove unused variable `items_added'.
7655 * w32term.c (last_mouse_press_frame): Remove static global variable.
7656 (w32_clip_to_row): Remove unused variable `f'.
7657 (x_delete_terminal): Remove unused variable `i'.
7659 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7660 (NOTHING): Remove unused static global variable.
7661 (uniscribe_check_otf): Remove unused variable `table'.
7662 (uniscribe_font_driver): Add missing initializers.
7664 2011-03-23 Julien Danjou <julien@danjou.info>
7666 * term.c (Fsuspend_tty, Fresume_tty):
7667 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7668 * window.c (temp_output_buffer_show):
7669 * insdel.c (signal_before_change):
7670 * frame.c (Fhandle_switch_frame):
7671 * fileio.c (Fdo_auto_save):
7672 * emacs.c (Fkill_emacs):
7673 * editfns.c (save_excursion_restore):
7674 * cmds.c (internal_self_insert):
7675 * callint.c (Fcall_interactively):
7676 * buffer.c (Fkill_all_local_variables):
7677 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7679 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7680 unconditionnaly since it does the check itself.
7682 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7684 Fix more problems found by GCC 4.5.2's static checks.
7686 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7687 the first time through the loop, since we know p0 < p1 then.
7688 This also avoids a gcc -Wstrict-overflow warning.
7690 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7691 leading to a memory leak, possible in functions like
7692 load_charset_map_from_file that can allocate an unbounded number
7693 of objects (Bug#8318).
7695 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7696 that could (at least in theory) be that large.
7698 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7699 This is less likely to overflow, and avoids undefined behavior if
7700 overflow does occur. All callers changed. Use strtoul to scan
7701 for the unsigned long integer.
7702 (pint2hrstr): Simplify and tune code slightly.
7703 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7705 * scroll.c (do_scrolling): Work around GCC bug 48228.
7706 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7708 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7709 This also avoids a warning with gcc -Wstrict-overflow.
7710 (validate_x_resource_name): Simplify count usage.
7711 This also avoids a warning with gcc -Wstrict-overflow.
7713 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7716 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7718 * process.c (Fmake_network_process): Use socklen_t, not int,
7719 where POSIX says socklen_t is required in portable programs.
7720 This fixes a porting bug on hosts like 64-bit HP-UX, where
7721 socklen_t is wider than int (Bug#8277).
7722 (Fmake_network_process, server_accept_connection):
7723 (wait_reading_process_output, read_process_output):
7726 * process.c: Rename or move locals to avoid shadowing.
7727 (list_processes_1, Fmake_network_process):
7728 (read_process_output_error_handler, exec_sentinel_error_handler):
7729 Rename or move locals.
7730 (Fmake_network_process): Define label "retry_connect" only if needed.
7731 (Fnetwork_interface_info): Fix pointer signedness.
7732 (process_send_signal): Add cast to avoid pointer signedness problem.
7733 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7734 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7736 Make tparam.h and terminfo.c consistent.
7737 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7738 Include tparam.h instead, since it declares them.
7739 * cm.h (PC): Remove extern decl; tparam.h now does this.
7740 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7741 * terminfo.c: Include tparam.h, to check interfaces.
7742 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7743 (tparam): Adjust signature to match interface in tparam.h;
7744 this removes some undefined behavior. Check that outstring and len
7745 are zero, which they always are with Emacs.
7746 * tparam.h (PC, BC, UP): New extern decls.
7748 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7749 (xftfont_open): Rename locals to avoid shadowing.
7751 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7752 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7753 (OTF_TAG_SYM): Omit macro if not needed.
7754 (ftfont_list): Remove unused local.
7755 (get_adstyle_property, ftfont_pattern_entity):
7756 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7757 Rename locals to avoid shadowing.
7759 * xfont.c (xfont_list_family): Mark var as initialized.
7761 * xml.c (make_dom): Now static.
7763 * composite.c (composition_compute_stop_pos): Rename local to
7765 (composition_reseat_it): Remove unused locals.
7766 (find_automatic_composition, composition_adjust_point): Likewise.
7767 (composition_update_it): Mark var as initialized.
7768 (find_automatic_composition): Mark vars as initialized,
7769 with a FIXME (Bug#8290).
7771 character.h: Rename locals to avoid shadowing.
7772 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7773 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7774 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7775 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7778 * textprop.c (property_change_between_p): Remove; unused.
7780 * intervals.c (interval_start_pos): Now static.
7782 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7784 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7785 Rename locals to avoid shadowing.
7787 * sound.c (wav_play, au_play, Fplay_sound_internal):
7788 Fix pointer signedness.
7789 (alsa_choose_format): Remove unused local var.
7790 (wav_play): Initialize a variable to 0, to prevent undefined
7791 behavior (Bug#8278).
7793 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7795 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7797 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7798 clobbering (Bug#8298).
7799 * sysdep.c (sys_subshell): Likewise.
7800 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7802 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7803 This should get cleaned up, so that child_setup has the
7804 same signature on all platforms.
7806 * callproc.c (call_process_cleanup): Now static.
7807 (relocate_fd): Rename locals to avoid shadowing.
7809 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7811 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7812 not to be necessary, and produces flickering.
7814 2011-03-20 Glenn Morris <rgm@gnu.org>
7816 * config.in: Remove file.
7818 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7820 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7821 are now in src/globals.h.
7822 (syms_of_minibuf): Remove spurious & from previous change.
7824 2011-03-20 Leo <sdl.web@gmail.com>
7826 * minibuf.c (completing-read-function): New variable.
7827 (completing-read-default): Rename from completing-read.
7828 (completing-read): Call completing-read-function.
7830 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7832 * xfaces.c (Fx_load_color_file):
7833 Read color file from absolute filename (bug#8250).
7835 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7837 * makefile.w32-in: Update dependencies.
7839 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7841 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7843 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7845 Fix more problems found by GCC 4.5.2's static checks.
7847 * process.c (make_serial_process_unwind, send_process_trap):
7848 (sigchld_handler): Now static.
7850 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7851 That way, the code declares only the vars that it needs.
7852 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7853 * s/cygwin.h (PTY_ITERATION): Likewise.
7854 * s/darwin.h (PTY_ITERATION): Likewise.
7855 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7857 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7858 * process.c (allocate_pty): Don't declare stb unless it's needed.
7860 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7861 (CONSTANTLIM): Remove; unused.
7862 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7863 Define only if needed.
7865 * unexelf.c (unexec): Name an expression,
7866 to avoid gcc -Wbad-function-cast warning.
7867 Use a different way to cause a compilation error if anyone uses
7868 n rather than nn, a way that does not involve shadowing.
7869 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7871 * deps.mk (unexalpha.o): Remove; unused.
7873 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7874 * unexec.h: New file.
7875 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7876 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7878 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7879 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7880 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7881 Change as necessary to match prototype in unexec.h.
7883 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7885 (back_comment, skip_chars): Mark vars as initialized.
7887 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7888 Rename locals to avoid shadowing.
7890 * lread.c (read1): Rewrite so as not to use empty "else".
7891 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7893 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7895 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7896 warning when compiling print.c.
7898 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7899 instead of using an uninitialized var.
7900 (font_sort_entities): Mark var as initialized.
7902 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7904 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7905 pointers to constants.
7906 (font_parse_fcname): Remove unused vars.
7907 (font_delete_unmatched): Now static.
7908 (font_get_spec): Remove; unused.
7909 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7910 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7911 Rename or move locals to avoid shadowing.
7913 * fns.c (require_nesting_list, require_unwind): Now static.
7914 (Ffillarray): Rename locals to avoid shadowing.
7916 * floatfns.c (domain_error2): Define only if needed.
7917 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7919 * alloc.c (mark_backtrace): Move decl from here ...
7920 * lisp.h: ... to here, so that it can be checked.
7922 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7923 (Fdefvar): Rewrite so as not to use empty "else".
7924 (lisp_indirect_variable): Name an expression,
7925 to avoid gcc -Wbad-function-cast warning.
7926 (Fdefvar): Rename locals to avoid shadowing.
7928 * callint.c (quotify_arg, quotify_args): Now static.
7929 (Fcall_interactively): Rename locals to avoid shadowing.
7930 Use const pointer when appropriate.
7932 * lisp.h (get_system_name, get_operating_system_release):
7933 Move decls here, to check interfaces.
7934 * process.c (get_operating_system_release): Move decl to lisp.h.
7935 * xrdb.c (get_system_name): Likewise.
7936 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7937 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7938 some of which prompt warnings from gcc -Wbad-function-cast.
7939 (Fformat_time_string, Fencode_time, Finsert_char):
7940 (Ftranslate_region_internal, Fformat):
7941 Rename or remove local vars to avoid shadowing.
7942 (Ftranslate_region_internal): Mark var as initialized.
7944 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7947 * lisp.h (eassert): Check that the argument compiles, even if
7948 ENABLE_CHECKING is not defined.
7950 * data.c (Findirect_variable): Name an expression, to avoid
7951 gcc -Wbad-function-cast warning.
7952 (default_value, arithcompare, arith_driver, arith_error): Now static.
7953 (store_symval_forwarding): Rename local to avoid shadowing.
7954 (Fmake_variable_buffer_local, Fmake_local_variable):
7955 Mark variables as initialized.
7956 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7958 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7959 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7960 Rename locals to avoid shadowing.
7961 (mark_stack): Move local variables into the #ifdef region where
7963 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7964 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7966 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7967 (GC_STRING_CHARS): Remove; not used.
7968 (Fmemory_limit): Cast sbrk's returned value to char *.
7970 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7971 avoids undefined behavior in theory.
7973 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7975 Use functions, not macros, for up- and down-casing (Bug#8254).
7976 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7977 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7978 to use the following functions instead of these macros.
7979 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7980 EMACS_INT, since callers assume the returned value fits in int.
7981 (upcase1): Likewise, for UPCASE_TABLE.
7982 (uppercasep, lowercasep, upcase): New static inline functions.
7983 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7984 the race-condition problem in the old DOWNCASE.
7986 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7987 Rename locals to avoid shadowing.
7988 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7989 (regex_compile, re_search_2, re_match_2_internal):
7990 Remove unused local vars.
7991 (FREE_VAR): Rewrite so as not to use empty "else",
7992 which gcc can warn about.
7993 (regex_compile, re_match_2_internal): Mark locals as initialized.
7994 (RETALLOC_IF): Define only if needed.
7995 (WORDCHAR_P): Likewise. This one is never needed, but is used
7996 only in a comment talking about a compiler bug, so put inside
7997 the #if 0 of that comment.
7998 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7999 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8002 * search.c (boyer_moore): Rename locals to avoid shadowing.
8003 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8004 (PREV_CHAR_BOUNDARY): Likewise.
8006 * search.c (simple_search): Remove unused var.
8008 * dired.c (compile_pattern): Move decl from here ...
8009 * lisp.h: ... to here, so that it can be checked.
8010 (struct re_registers): New forward decl.
8012 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8014 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8016 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8017 Rename locals to avoid shadowing.
8018 (Fvertical_motion): Mark locals as initialized.
8020 * casefiddle.c (casify_object, casify_region): Now static.
8021 (casify_region): Mark local as initialized.
8023 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8025 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8026 New macros, so that the caller can use some names other than
8027 gcpro1, gcpro2, etc.
8028 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8030 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8031 argument, for consistency with GCPRO2_VAR, etc: it is now the
8032 prefix of the variable, not the variable itself. All uses
8034 * dired.c (directory_files_internal, file_name_completion):
8035 Rename locals to avoid shadowing.
8037 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8038 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8039 dired.c's scmp function, had undefined behavior.
8040 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8041 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8042 * buffer.h: ... to here, because these macros use current_buffer,
8043 and the new implementation with inline functions needs to have
8044 current_buffer in scope now, rather than later when the macros
8046 (downcase, upcase1): New static inline functions.
8047 (DOWNCASE, UPCASE1): Reimplement using these functions.
8048 This avoids undefined behavior in expressions like
8049 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8050 from race conditions in accessing the global variables
8051 case_temp1 and case_temp2.
8052 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8053 * lisp.h (case_temp1, case_temp2): Remove their decls.
8054 * character.h (ASCII_CHAR_P): Move from here ...
8055 * lisp.h: ... to here, so that the inline functions mentioned
8058 * dired.c (directory_files_internal_unwind): Now static.
8060 * fileio.c (file_name_as_directory, directory_file_name):
8061 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8063 (file_name_as_directory): Use const pointers when appropriate.
8064 (Fexpand_file_name): Likewise. In particular, newdir might
8065 point at constant storage, so make it a const pointer.
8066 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8067 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8069 (Fset_file_times, Finsert_file_contents, auto_save_error):
8070 Rename locals to avoid shadowing.
8072 * minibuf.c (choose_minibuf_frame_1): Now static.
8073 (Ftry_completion, Fall_completions): Rename or remove locals
8076 * marker.c (bytepos_to_charpos): Remove; unused.
8078 * lisp.h (verify_bytepos, count_markers): New decls,
8079 so that gcc does not warn that these functions aren't declared.
8081 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8082 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8083 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8084 (copy_text): Remove unused local var.
8086 * filelock.c (within_one_second): Now static.
8087 (lock_file_1): Rename local to avoid shadowing.
8089 * buffer.c (fix_overlays_before): Mark locals as initialized.
8090 (fix_start_end_in_overlays): Likewise. This function should be
8091 simplified by using pointers-to-pointers, but that's a different
8093 (switch_to_buffer_1): Now static.
8094 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8095 (report_overlay_modification): Rename locals to avoid shadowing.
8097 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8098 Fix pointer signedness issue.
8099 (sys_subshell): Mark local as volatile if checking for lint,
8100 to suppress a gcc -Wclobbered warning that does not seem to be right.
8101 (MAXPATHLEN): Define only if needed.
8103 * process.c (serial_open, serial_configure): Move decls from here ...
8104 * systty.h: ... to here, so that they can be checked.
8106 * fns.c (get_random, seed_random): Move extern decls from here ...
8107 * lisp.h: ... to here, so that they can be checked.
8109 * sysdep.c (reset_io): Now static.
8110 (wait_for_termination_signal): Remove; unused.
8112 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8113 (copy_keymap_item, append_key, push_text_char_description):
8115 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8116 (DENSE_TABLE_SIZE): Remove; unused.
8117 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8118 (describe_map_tree):
8119 Rename locals to avoid shadowing.
8121 * keyboard.c: Declare functions static if they are not used elsewhere.
8122 (echo_char, echo_dash, cmd_error, top_level_2):
8123 (poll_for_input, handle_async_input): Now static.
8124 (read_char, kbd_buffer_get_event, make_lispy_position):
8125 (make_lispy_event, make_lispy_movement, apply_modifiers):
8126 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8127 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8128 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8129 (read_key_sequence, read_char): Mark locals as initialized.
8130 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8132 * keyboard.h (make_ctrl_char): New decl.
8133 (mark_kboards): Move decl here ...
8134 * alloc.c (mark_kboards): ... from here.
8136 * lisp.h (force_auto_save_soon): New decl.
8138 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8139 (DEFINE_DUMMY_FUNCTION): New macro.
8140 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8142 (main): Add casts to avoid warnings
8143 if GCC considers string literals to be constants.
8145 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8147 * dbusbind.c: Pointer signedness fixes.
8148 (xd_signature, xd_append_arg, xd_initialize):
8149 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8150 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8151 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8152 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8154 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8155 if GCC considers string literals to be constants.
8156 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8158 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8160 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8161 (print_preprocess, print_object): New macro to fix last change.
8163 * print.c (print_preprocess): Don't forget font objects.
8165 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8167 * emacs.c (USAGE3): Doc fixes.
8169 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8171 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8174 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8176 * lisp.h (VWindow_system, Qfile_name_history):
8177 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8178 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8179 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8181 * w32select.c: Don't #include "keyboard.h".
8182 (run_protected): Add extern declaration for waiting_for_input.
8184 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8185 * w32console.c (detect_input_pending, read_input_pending)
8186 (encode_terminal_code):
8187 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8188 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8189 (w32_system_caret_y, Qfile_name_history):
8190 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8191 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8192 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8193 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8194 * w32proc.c (Qlocal, report_file_error):
8195 * w32term.c (Vwindow_system, updating_frame):
8196 * w32uniscribe.c (initialized, uniscribe_font_driver):
8197 Remove unneeded extern declarations.
8199 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8201 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8203 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8205 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8206 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8207 These macros can no longer be used for assignment.
8209 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8210 Assign struct members directly, instead of using BUF_BEGV etc.
8211 (record_buffer_markers, fetch_buffer_markers): New functions for
8212 recording and fetching special buffer markers.
8213 (set_buffer_internal_1, set_buffer_temp): Use them.
8215 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8217 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8219 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8220 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8222 * xdisp.c (hscroll_window_tree):
8223 (reconsider_clip_changes): Use PT instead of BUF_PT.
8225 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8227 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8228 $(EMACS_ROOT)/lib/intprops.h.
8230 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8232 Fix more problems found by GCC 4.5.2's static checks.
8234 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8235 to unsigned char * to avoid compiler diagnostic.
8236 (xg_free_frame_widgets): Make it clear that a local variable is
8237 needed only if USE_GTK_TOOLTIP.
8238 (gdk_window_get_screen): Make it clear that this macro is needed
8239 only if USE_GTK_TOOLTIP.
8240 (int_gtk_range_get_value): New function, which avoids a diagnostic
8241 from gcc -Wbad-function-cast.
8242 (xg_set_toolkit_scroll_bar_thumb): Use it.
8243 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8244 diagnostic from gcc -Wbad-function-cast.
8245 (get_utf8_string, xg_get_file_with_chooser):
8246 Rename locals to avoid shadowing.
8247 (create_dialog): Move locals to avoid shadowing.
8249 * xgselect.c (xg_select): Remove unused var.
8251 * image.c (four_corners_best): Mark locals as initialized.
8252 (gif_load): Initialize transparent_p to zero (Bug#8238).
8253 Mark another local as initialized.
8254 (my_png_error, my_error_exit): Mark with NO_RETURN.
8256 * image.c (clear_image_cache): Now static.
8257 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8258 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8259 (x_edge_detection): Remove unnecessary cast that
8260 gcc -Wbad-function-cast diagnoses.
8261 (gif_load): Fix pointer signedness.
8262 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8263 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8265 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8267 Improve quality of tests for time stamp overflow.
8268 For example, without this patch (encode-time 0 0 0 1 1
8269 1152921504606846976) returns the obviously-bogus value (-948597
8270 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8271 reports time overflow. See
8272 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8273 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8274 * editfns.c: Include limits.h and intprops.h.
8275 (TIME_T_MIN, TIME_T_MAX): New macros.
8276 (time_overflow): Move earlier, to before first use.
8277 (hi_time, lo_time): New functions, for an accurate test for
8279 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8280 (Fget_internal_run_time): Don't assume time_t fits in int.
8281 (make_time): Use list2 instead of Fcons twice.
8282 (Fdecode_time): More accurate test for out-of-range times.
8283 (check_tm_member): New function.
8284 (Fencode_time): Use it, to test for out-of-range times.
8285 (lisp_time_argument): Don't rely on undefined left-shift and
8286 right-shift behavior when checking for time stamp overflow.
8288 * editfns.c (time_overflow): New function, refactoring common code.
8289 (Fformat_time_string, Fdecode_time, Fencode_time):
8290 (Fcurrent_time_string): Use it.
8292 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8293 * dired.c (make_time): Move to ...
8294 * editfns.c (make_time): ... here.
8295 * systime.h: Note the move.
8297 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8299 * fringe.c (update_window_fringes): Remove unused variables.
8301 * unexmacosx.c (copy_data_segment): Also copy __got section.
8304 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8306 * termcap.c [MSDOS]: Include "msdos.h".
8307 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8308 Constify `char *' arguments and their references according to
8309 prototypes in tparam.h.
8311 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8313 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8314 Adapt all references accordingly.
8316 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8318 2011-03-11 Tom Tromey <tromey@redhat.com>
8320 * buffer.c (syms_of_buffer): Remove obsolete comment.
8322 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8324 * termhooks.h (encode_terminal_code): Declare prototype.
8326 * msdos.c (encode_terminal_code): Don't declare prototype.
8328 * term.c (encode_terminal_code): Now external again, used by
8329 w32console.c and msdos.c.
8331 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8332 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8334 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8336 Fix some minor problems found by GCC 4.5.2's static checks.
8338 * fringe.c (update_window_fringes): Mark locals as initialized
8340 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8342 * alloc.c (mark_fringe_data): Move decl from here ...
8343 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8344 to check its interface.
8345 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8347 * fontset.c (free_realized_fontset): Now static.
8348 (Fset_fontset_font): Rename local to avoid shadowing.
8349 (fontset_font): Mark local as initialized.
8350 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8352 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8354 * xselect.c (x_disown_buffer_selections): Remove; not used.
8355 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8356 (x_own_selection, Fx_disown_selection_internal): Rename locals
8358 (x_handle_dnd_message): Remove local to avoid shadowing.
8360 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8361 so that the caller can use some name other than gcpro1.
8362 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8363 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8364 (Fx_backspace_delete_keys_p):
8365 Use them to avoid shadowing, and rename vars to avoid shadowing.
8366 (x_decode_color, x_set_name, x_window): Now static.
8367 (Fx_create_frame): Add braces to silence GCC warning.
8368 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8369 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8370 Remove unused locals.
8371 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8372 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8373 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8376 * xterm.h (x_mouse_leave): New decl.
8378 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8379 Remove unused functions.
8380 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8381 (x_calc_absolute_position): Now static.
8382 (XTread_socket): Don't define label "out" unless it's used.
8383 Don't declare local "event" unless it's used.
8384 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8385 unless they are used.
8386 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8387 (x_fatal_error_signal): Remove; not used.
8388 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8389 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8390 (x_error_catcher, x_connection_closed, x_error_handler):
8391 (x_error_quitter, xembed_send_message, x_iconify_frame):
8392 (my_log_handler): Rename locals to avoid shadowing.
8393 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8394 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8396 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8397 Rename or move locals to avoid shadowing.
8398 (tty_defined_color, merge_face_heights): Now static.
8399 (free_realized_faces_for_fontset): Remove; not used.
8400 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8401 does not deduce is never used uninitialized.
8402 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8403 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8405 * terminal.c (store_terminal_param): Now static.
8407 * xmenu.c (menu_highlight_callback): Now static.
8408 (set_frame_menubar): Remove unused local.
8409 (xmenu_show): Rename parameter to avoid shadowing.
8410 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8411 since they might point to immutable storage.
8412 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8413 since it's unused otherwise.
8415 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8416 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8417 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8418 avoids a gcc -Wuninitialized diagnostic.
8419 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8420 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8421 does not deduce are never used uninitialized.
8423 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8425 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8426 * window.c (window_loop, size_window):
8427 (run_window_configuration_change_hook, enlarge_window): Likewise.
8429 * window.c (display_buffer): Now static.
8430 (size_window): Mark variables that gcc -Wuninitialized
8431 does not deduce are never used uninitialized.
8432 * window.h (check_all_windows): New decl, to forestall
8433 gcc -Wmissing-prototypes diagnostic.
8434 * dispextern.h (bidi_dump_cached_states): Likewise.
8436 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8438 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8440 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8441 and to avoid gcc -Wuninitialized warning.
8442 (load_charset_map): Mark variables that gcc -Wuninitialized
8443 does not deduce are never used uninitialized.
8444 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8446 * coding.c (coding_set_source, coding_set_destination):
8447 Use "else { /* comment */ }" rather than "else /* comment */;"
8448 for clarity, and to avoid gcc -Wempty-body warning.
8449 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8450 a block, when the outer 'i' will do.
8451 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8452 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8453 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8454 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8455 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8456 Rename locals to avoid shadowing.
8457 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8458 * coding.c (emacs_mule_char, encode_invocation_designation):
8459 Now static, since they're not used elsewhere.
8460 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8461 (decode_coding_object, encode_coding_object, detect_coding_system):
8462 (decode_coding_emacs_mule): Mark variables that gcc
8463 -Wuninitialized does not deduce are never used uninitialized.
8464 (detect_coding_iso_2022): Initialize a local variable that might
8465 be used uninitialized. Leave a FIXME because it's not clear that
8466 this initialization is needed. (Bug#8211)
8467 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8468 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8469 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8470 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8471 Remove unused macros.
8473 * category.c (hash_get_category_set): Remove unused local var.
8474 (copy_category_table): Now static, since it's not used elsewhere.
8475 * character.c (string_count_byte8): Likewise.
8477 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8478 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8480 * chartab.c (copy_sub_char_table): Now static, since it's not used
8482 (sub_char_table_ref_and_range, char_table_ref_and_range):
8483 Rename locals to avoid shadowing.
8484 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8486 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8487 (BIDI_BOB): Remove unused macro.
8489 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8490 deduce are never used uninitialized.
8491 * term.c (encode_terminal_code): Likewise.
8493 * term.c (encode_terminal_code): Now static. Remove unused local.
8495 * tparam.h: New file.
8496 * term.c, tparam.h: Include it.
8497 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8498 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8499 Move these decls to tparam.h, and make them agree with what
8500 is actually in tparam.c. The previous trick of using incompatible
8501 decls in different modules does not conform to the C standard.
8502 All callers of tparam changed to use tparam's actual API.
8503 * tparam.c (tparam1, tparam, tgoto):
8504 Use const pointers where appropriate.
8506 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8507 * cm.h (struct cm): Likewise.
8508 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8509 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8510 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8511 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8512 (turn_on_face, init_tty): Likewise.
8513 * termchar.h (struct tty_display_info): Likewise.
8515 * term.c (term_mouse_position): Rename local to avoid shadowing.
8517 * alloc.c (mark_ttys): Move decl from here ...
8518 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8520 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8522 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8524 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8526 * search.c (compile_pattern_1): Remove argument regp, unused since
8527 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8528 (compile_pattern): Don't pass it.
8530 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8532 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8533 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8535 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8537 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8539 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8540 gdk_window_get_screen, gdk_window_get_geometry,
8541 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8542 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8543 (xg_get_pixbuf_from_pixmap): New function.
8544 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8545 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8546 Call xg_get_pixbuf_from_pixmap instead of
8547 gdk_pixbuf_get_from_drawable.
8548 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8549 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8550 (xg_check_special_colors): Use GtkStyleContext and its functions
8552 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8553 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8554 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8555 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8556 Call gtk_widget_get_preferred_size.
8557 (xg_frame_resized): gdk_window_get_geometry only takes 5
8559 (xg_win_to_widget, xg_event_is_for_menubar):
8560 Call gdk_x11_window_lookup_for_display.
8561 (xg_set_widget_bg): New function.
8562 (delete_cb): New function.
8563 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8564 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8565 (xg_set_background_color): Call xg_set_widget_bg.
8566 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8567 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8568 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8569 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8571 (update_frame_tool_bar): Call gtk_widget_hide.
8572 (xg_initialize): Use GDK_KEY_g.
8574 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8576 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8578 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8579 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8580 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8582 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8584 * w32xfns.c (select_palette): Check success of RealizePalette against
8585 GDI_ERROR, not zero.
8587 See ChangeLog.11 for earlier changes.
8593 Copyright (C) 2011 Free Software Foundation, Inc.
8595 This file is part of GNU Emacs.
8597 GNU Emacs is free software: you can redistribute it and/or modify
8598 it under the terms of the GNU General Public License as published by
8599 the Free Software Foundation, either version 3 of the License, or
8600 (at your option) any later version.
8602 GNU Emacs is distributed in the hope that it will be useful,
8603 but WITHOUT ANY WARRANTY; without even the implied warranty of
8604 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8605 GNU General Public License for more details.
8607 You should have received a copy of the GNU General Public License
8608 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.