1 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3 * gtkutil.c (qttip_cb): Remove code without function.
5 2011-07-09 Eli Zaretskii <eliz@gnu.org>
7 * w32.c (pthread_sigmask): New stub.
9 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
11 Use pthread_sigmask, not sigprocmask (Bug#9010).
12 sigprocmask is portable only for single-threaded applications, and
13 Emacs can be multi-threaded when it uses GTK.
14 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
16 * callproc.c (Fcall_process):
17 * process.c (create_process):
18 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
19 Use pthread_sigmask, not sigprocmask.
21 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
23 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
24 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
27 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
29 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
30 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
31 (xg_hide_tooltip): Fix comment.
33 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
34 in registerServicesMenuSendTypes.
35 (validRequestorForSendType): Don't check ns_return_types.
37 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
40 2011-07-08 Jason Rumney <jasonr@gnu.org>
42 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
43 frame struct members of non-existent frames (Bug#6284).
45 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
47 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
48 variable firstTime not needed on OSX >= 10.6.
49 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
50 >= 10.5. Use setKnobProportion, setDoubleValue.
52 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
53 (MAC_OS_X_VERSION_10_5): Define if not defined.
54 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
55 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
56 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
58 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
59 cString and lossyCString on OSX >= 10.4
61 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
62 sizeToFit on OSX >= 10.2.
64 * nsimage.m (allocInitFromFile): Don't use deprecated method
65 bestRepresentationForDevice on OSX >= 10.6.
67 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
70 * emacs.c: Declare unexec_init_emacs_zone.
72 * nsgui.h: Fix compiler warning about gnulib redefining verify.
74 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
76 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
77 on svcsMenu (Bug#8842).
79 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
81 (Fns_list_services): Just return Qnil on 10.6, code not working there.
83 * nsterm.m (QUTF8_STRING): Declare.
84 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
85 (validRequestorForSendType): Return type is (id).
86 Change indexOfObjectIdenticalTo to indexOfObject.
87 Check if we have local selection before returning self (Bug#8842).
88 (writeSelectionToPasteboard): Put local selection into paste board
89 if we have a local selection (Bug#8842).
90 (syms_of_nsterm): DEFSYM QUTF8_STRING.
92 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
93 (ns_get_local_selection): Declare.
95 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
97 * keymap.c (describe_map_tree): Don't insert a double newline at
98 the end of the buffer (bug#1169) and return whether we inserted
101 * callint.c (Fcall_interactively): Change "reading args" to
102 "providing args" to try to clarify what it does (bug#1010).
104 2011-07-07 Kenichi Handa <handa@m17n.org>
106 * composite.c (composition_compute_stop_pos): Ignore a static
107 composition starting before CHARPOS (Bug#8915).
109 * xdisp.c (handle_composition_prop): Likewise.
111 2011-07-07 Eli Zaretskii <eliz@gnu.org>
113 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
116 2011-07-07 Kenichi Handa <handa@m17n.org>
118 * character.h (unicode_category_t): New enum type.
120 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
121 (Qchar_code_property_table): New variable.
122 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
123 (UNIPROP_COMPRESSED_FORM_P): New macros.
124 (char_table_ascii): Uncompress the compressed values.
125 (sub_char_table_ref): New arg is_uniprop. Callers changed.
126 Uncompress the compressed values.
127 (sub_char_table_ref_and_range): Likewise.
128 (char_table_ref_and_range): Uncompress the compressed values.
129 (sub_char_table_set): New arg is_uniprop. Callers changed.
130 Uncompress the compressed values.
131 (sub_char_table_set_range): Args changed. Callers changed.
132 (char_table_set_range): Adjuted for the above change.
133 (map_sub_char_table): Delete args default_val and parent. Add arg
134 top. Give decoded values to a Lisp function.
135 (map_char_table): Adjusted for the above change. Give decoded
136 values to a Lisp function. Gcpro more variables.
137 (uniprop_table_uncompress)
138 (uniprop_decode_value_run_length): New functions.
139 (uniprop_decoder, uniprop_decoder_count): New variables.
140 (uniprop_get_decoder, uniprop_encode_value_character)
141 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
143 (uniprop_encoder, uniprop_encoder_count): New variables.
144 (uniprop_get_encoder, uniprop_table)
145 (Funicode_property_table_internal, Fget_unicode_property_internal)
146 (Fput_unicode_property_internal): New functions.
147 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
148 Sunicode_property_table_internal, Sget_unicode_property_internal,
149 and Sput_unicode_property_internal. Defvar_lisp
150 char-code-property-alist.
152 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
153 Vunicode_category_table.
155 * font.c (font_range): Adjusted for the change of
156 Vunicode_category_table.
158 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
160 * m/iris4d.h: Remove file, move contents ...
161 * s/irix6-5.h: ... here.
163 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
165 Remove unportable assumption about struct layout (Bug#8884).
166 * alloc.c (mark_buffer):
167 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
168 (clone_per_buffer_values): Don't assume that
169 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
170 This isn't true in general, and it's particularly not true
171 if Emacs is configured with --with-wide-int.
172 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
173 New macros, used in the buffer.c change.
175 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
177 * xsettings.c: Use both GConf and GSettings if both are available.
178 (store_config_changed_event): Add comment.
179 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
180 (store_tool_bar_style_changed): New functions.
181 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
182 (struct xsettings): Move font inside HAVE_XFT.
183 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
184 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
185 Move inside HAVE_XFT.
186 (something_changed_gsettingsCB): Renamed from something_changedCB.
187 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
189 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
190 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
191 (something_changed_gconfCB): Renamed from something_changedCB.
192 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
193 (parse_settings): Move check for font inside HAVE_XFT.
194 (read_settings, apply_xft_settings): Add comment.
195 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
196 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
197 call store_font_name_changed.
198 (xft_settings_event): Add comment.
199 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
200 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
201 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
202 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
203 (xsettings_initialize): Call init_gsettings last.
204 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
207 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
209 Random fixes. E.g., (random) never returned negative values.
210 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
211 subseconds part to the entropy, as that's a bit more random.
212 Prefer signed to unsigned, since the signedness doesn't matter and
213 in general we prefer signed. When given a limit, use a
214 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
215 latter isn't right if USE_2_TAGS_FOR_INTS.
216 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
217 not 0..VALMASK. Don't discard "excess" bits that random () returns.
219 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
221 * textprop.c (text_property_stickiness):
222 Obey Vtext_property_default_nonsticky.
223 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
224 * w32fns.c (syms_of_w32fns):
225 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
227 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
229 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
230 This is more efficient than Ffile_directory_p and avoids a minor race.
232 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
234 * buffer.c (Foverlay_put): Say what the return value is
237 * fileio.c (barf_or_query_if_file_exists): Check first if the file
238 is a directory before asking whether to use the file name
240 (barf_or_query_if_file_exists): Make the "File is a directory"
241 error be more correct.
243 * fns.c (Frequire): Remove the mention of the .gz files, since
244 that's installation-specific, but keep the mention of
247 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
249 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
250 Report string overflow if the output is too long.
252 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
254 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
255 (syms_of_gnutls): Remove duplicate DEFSYM for
256 Qgnutls_bootprop_verify_hostname_error, an error for
257 Qgnutls_bootprop_verify_error (which is no longer used).
259 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
260 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
261 Also (re)move comments that are misplaced or no longer relevant.
263 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
265 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
267 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
269 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
270 and background color parameters if they have been changed.
272 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
274 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
276 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
278 * xsettings.c (SYSTEM_FONT): Define only when used.
279 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
281 * keymap.c (access_keymap_1): Now static.
283 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
285 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
286 leave any prefix arg for the up event (Bug#1586).
288 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
290 * lread.c (syms_of_lread): Mention single symbols defined by
291 `defvar' or `defconst' (bug#7154).
293 * fns.c (Frequire): Mention .el.gz files (bug#7314).
294 (Frequire): Mention get-load-suffixes.
296 2011-07-02 Martin Rudalics <rudalics@gmx.at>
298 * window.h (window): Remove clone_number slot.
299 * window.c (Fwindow_clone_number, Fset_window_clone_number):
301 (make_parent_window, make_window, saved_window)
302 (Fset_window_configuration, save_window_save): Don't deal with
304 * buffer.c (Qclone_number): Remove declaration.
305 (sort_overlays, overlay_strings): Don't deal with clone numbers.
307 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
309 Add multiple inheritance to keymaps.
310 * keymap.c (Fmake_composed_keymap): New function.
311 (Fset_keymap_parent): Simplify.
312 (fix_submap_inheritance): Remove.
313 (access_keymap_1): New function extracted from access_keymap to handle
314 embedded parents and handle lists of maps.
315 (access_keymap): Use it.
316 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
317 (Fcopy_keymap): Handle embedded parents.
318 (Fcommand_remapping, define_as_prefix): Simplify.
319 (Fkey_binding): Simplify.
320 (syms_of_keymap): Move minibuffer-local-completion-map,
321 minibuffer-local-filename-completion-map,
322 minibuffer-local-must-match-map, and
323 minibuffer-local-filename-must-match-map to Elisp.
324 (syms_of_keymap): Defsubr make-composed-keymap.
325 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
326 (parse_menu_item): Trivial simplification.
328 2011-07-01 Glenn Morris <rgm@gnu.org>
330 * Makefile.in (SETTINGS_LIBS): Fix typo.
332 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
334 * coding.c (Fencode_coding_string): Record the last coding system
335 used, as the function doc string says (bug#8738).
337 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
339 * xsettings.c (store_monospaced_changed): Take new font as arg and
340 check for change against current_mono_font.
341 (EMACS_TYPE_SETTINGS): Remove this and related defines.
342 (emacs_settings_constructor, emacs_settings_get_property)
343 (emacs_settings_set_property, emacs_settings_class_init)
344 (emacs_settings_init, gsettings_obj): Remove.
345 (something_changedCB): New function for HAVE_GSETTINGS.
346 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
347 with value as argument.
348 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
349 g_settings_new (Bug#8967). Do not create gsettings_obj.
350 Remove calls to g_settings_bind. Connect something_changedCB to
353 * xgselect.c: Add defined (HAVE_GSETTINGS).
354 (xgselect_initialize): Ditto.
356 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
357 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
360 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
362 * eval.c (struct backtrace): Simplify and port the data structure.
363 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
364 signed bit field, as this assumption is not portable and it makes
365 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
366 "char debug_on_exit : 1" as this is not portable either; instead,
367 use the portable "unsigned int debug_on_exit : 1". Remove unused
368 member evalargs. Remove obsolete comments about cc bombing out.
370 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
372 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
373 Let HAVE_GSETTINGS override HAVE_GCONF.
374 (store_monospaced_changed): New function.
375 (EMACS_SETTINGS): A new type derived from GObject to handle
376 GSettings notifications.
377 (emacs_settings_constructor, emacs_settings_get_property)
378 (emacs_settings_set_property, emacs_settings_class_init):
380 (gsettings_client, gsettings_obj): New variables.
381 (GSETTINGS_SCHEMA): New define.
382 (something_changedCB): Call store_monospaced_changed.
383 (init_gsettings): New function.
384 (xsettings_initialize): Call init_gsettings.
385 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
388 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
391 2011-06-29 Martin Rudalics <rudalics@gmx.at>
393 * window.c (resize_root_window, grow_mini_window)
394 (shrink_mini_window): Rename Qresize_root_window to
395 Qwindow_resize_root_window and Qresize_root_window_vertically to
396 Qwindow_resize_root_window_vertically.
398 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
400 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
402 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
404 * makefile.w32-in: Redesign dependencies so they reflect more
405 clearly which files are directly included by each source file,
406 and not through other includes.
408 2011-06-27 Martin Rudalics <rudalics@gmx.at>
410 * buffer.c (Qclone_number): Declare static and DEFSYM it.
411 (sort_overlays, overlay_strings): When an overlay's clone number
412 matches the window's clone number process the overlay even if
413 the overlay's window property doesn't match the current window.
415 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
416 (Fwindow_hchild): Rename to Fwindow_left_child.
417 (Fwindow_next): Rename to Fwindow_next_sibling.
418 (Fwindow_prev): Rename to Fwindow_prev_sibling.
419 (resize_window_check): Rename to window_resize_check.
420 (resize_window_apply): Rename to window_resize_apply.
421 (Fresize_window_apply): Rename to Fwindow_resize_apply.
422 (Fdelete_other_windows_internal, resize_frame_windows)
423 (Fsplit_window_internal, Fdelete_window_internal)
424 (grow_mini_window, shrink_mini_window)
425 (Fresize_mini_window_internal): Fix callers accordingly.
427 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
429 * emacsgtkfixed.h: State that this is only used with Gtk+3.
430 (emacs_fixed_set_min_size): Remove.
431 (emacs_fixed_new): Take frame as argument.
433 * emacsgtkfixed.c: State that this is only used with Gtk+3.
434 (_EmacsFixedPrivate): Remove minwidth/height.
436 (emacs_fixed_init): Initialize priv->f.
437 (get_parent_class, emacs_fixed_set_min_size): Remove.
438 (emacs_fixed_new): Set priv->f to argument.
439 (emacs_fixed_get_preferred_width)
440 (emacs_fixed_get_preferred_height): Use min_width/height from
441 frames size_hint to set minimum and natural (Bug#8919).
442 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
443 and use min_width/height from frames size_hint to set
444 min_width/height (Bug#8919).
446 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
447 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
450 2011-06-26 Eli Zaretskii <eliz@gnu.org>
452 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
453 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
456 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
458 * process.c (wait_reading_process_output): Bypass select if
459 waiting for a cell while ignoring keyboard input, and input is
460 pending. Suggested by Jan Djärv (Bug#8869).
462 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
464 Use gnulib's dup2 module instead of rolling our own.
465 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
467 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
469 * dispnew.c (scrolling_window): Before scrolling, turn off a
470 mouse-highlight in the window being scrolled.
472 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
474 Move DEFSYM to lisp.h and use everywhere.
476 * character.h (DEFSYM): Move declaration...
477 * lisp.h (DEFSYM): ...here.
483 * w32select.c: Don't include character.h.
485 * alloc.c (syms_of_alloc):
486 * buffer.c (syms_of_buffer):
487 * bytecode.c (syms_of_bytecode):
488 * callint.c (syms_of_callint):
489 * casefiddle.c (syms_of_casefiddle):
490 * casetab.c (init_casetab_once):
491 * category.c (init_category_once, syms_of_category):
492 * ccl.c (syms_of_ccl):
493 * cmds.c (syms_of_cmds):
494 * composite.c (syms_of_composite):
495 * dbusbind.c (syms_of_dbusbind):
496 * dired.c (syms_of_dired):
497 * dispnew.c (syms_of_display):
498 * doc.c (syms_of_doc):
499 * editfns.c (syms_of_editfns):
500 * emacs.c (syms_of_emacs):
501 * eval.c (syms_of_eval):
502 * fileio.c (syms_of_fileio):
503 * fns.c (syms_of_fns):
504 * frame.c (syms_of_frame):
505 * fringe.c (syms_of_fringe):
506 * insdel.c (syms_of_insdel):
507 * keymap.c (syms_of_keymap):
508 * lread.c (init_obarray, syms_of_lread):
509 * macros.c (syms_of_macros):
510 * msdos.c (syms_of_msdos):
511 * print.c (syms_of_print):
512 * process.c (syms_of_process):
513 * search.c (syms_of_search):
514 * sound.c (syms_of_sound):
515 * syntax.c (init_syntax_once, syms_of_syntax):
516 * terminal.c (syms_of_terminal):
517 * textprop.c (syms_of_textprop):
518 * undo.c (syms_of_undo):
519 * w32.c (globals_of_w32):
520 * window.c (syms_of_window):
521 * xdisp.c (syms_of_xdisp):
522 * xfaces.c (syms_of_xfaces):
523 * xfns.c (syms_of_xfns):
524 * xmenu.c (syms_of_xmenu):
525 * xsettings.c (syms_of_xsettings):
526 * xterm.c (syms_of_xterm): Use DEFSYM.
528 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
530 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
532 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
534 Integer and buffer overflow fixes (Bug#8873).
536 * print.c (printchar, strout): Check for string overflow.
537 (PRINTPREPARE, printchar, strout):
538 Don't set size unless allocation succeeds.
540 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
541 for sizes. Check for string overflow more accurately.
542 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
544 * macros.c: Integer and buffer overflow fixes.
545 * keyboard.h (struct keyboard.kbd_macro_bufsize):
546 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
547 Use ptrdiff_t, not int, for sizes.
548 Don't increment bufsize until after realloc succeeds.
549 Check for size-calculation overflow.
550 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
552 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
554 * lread.c: Integer overflow fixes.
555 (read_integer): Radix is now EMACS_INT, not int,
556 to improve quality of diagnostics for out-of-range radices.
557 Calculate buffer size correctly for out-of-range radices.
558 (read1): Check for integer overflow in radices, and in
560 (read_escape): Avoid int overflow.
561 (Fload, openp, read_buffer_size, read1)
562 (substitute_object_recurse, read_vector, read_list, map_obarray):
563 Use ptrdiff_t, not int, for sizes.
564 (read1): Use EMACS_INT, not int, for sizes.
565 Check for size overflow.
567 * image.c (cache_image): Check for size arithmetic overflow.
569 * lread.c: Integer overflow issues.
570 (saved_doc_string_size, saved_doc_string_length)
571 (prev_saved_doc_string_size, prev_saved_doc_string_length):
572 Now ptrdiff_t, not int.
573 (read1): Don't assume doc string length fits in int. Check for
574 out-of-range doc string lengths.
575 (read_list): Don't assume file position fits in int.
576 (read_escape): Check for hex character overflow.
578 2011-06-22 Leo Liu <sdl.web@gmail.com>
580 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
581 Move to minibuffer.el.
583 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
585 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
586 The following patches are for when GLYPH_DEBUG && !XASSERT.
587 * dispextern.h (trace_redisplay_p, dump_glyph_string):
588 * dispnew.c (flush_stdout):
589 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
590 Mark as externally visible.
591 * dispnew.c (check_window_matrix_pointers): Now static.
592 * dispnew.c (window_to_frame_vpos):
593 * xfns.c (unwind_create_frame):
594 * xterm.c (x_check_font): Remove unused local.
595 * scroll.c (CHECK_BOUNDS):
596 * xfaces.c (cache_fache): Rename local to avoid shadowing.
597 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
598 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
599 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
600 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
602 (debug_method_add): Use va_list and vsprintf rather than relying
603 on undefined behavior with wrong number of arguments.
604 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
605 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
606 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
607 since we're not interested in debugging glyphs with old libraries.
608 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
609 GCC 4.6.0's static checking.
611 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
613 Integer overflow and signedness fixes (Bug#8873).
614 A few related buffer overrun fixes, too.
616 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
618 * dispextern.h (struct face.stipple):
619 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
620 (x_bitmap_mask, x_allocate_bitmap_record)
621 (x_create_bitmap_from_data, x_create_bitmap_from_file)
622 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
623 (x_create_bitmap_from_xpm_data):
624 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
625 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
627 * xfaces.c (load_pixmap):
628 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
629 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
630 (.bitmaps_last, struct x_output.icon_bitmap):
631 Use ptrdiff_t, not int, for bitmap indexes.
632 (x_allocate_bitmap_record): Check for size overflow.
633 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
635 Use ptrdiff_t, not int, for overlay counts.
636 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
637 * editfns.c (overlays_around, get_pos_property):
638 * textprop.c (get_char_property_and_overlay):
639 * xdisp.c (next_overlay_change, note_mouse_highlight):
640 * xfaces.c (face_at_buffer_position):
641 * buffer.c (OVERLAY_COUNT_MAX): New macro.
642 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
643 (Fnext_overlay_change, Fprevious_overlay_change)
644 (mouse_face_overlay_overlaps, Foverlays_in):
645 Use ptrdiff_t, not int, for sizes.
646 (overlays_at, overlays_in): Check for size-calculation overflow.
648 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
650 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
651 (x_session_initialize): Do not assume string length fits in int.
653 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
654 This is unlikely, but can occur if DPI is outlandish.
656 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
657 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
659 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
660 * xrdb.c (magic_file_p, search_magic_path):
661 Omit last arg SUFFIX; it was always 0. All callers changed.
662 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
664 * xfont.c (xfont_match): Avoid need for strlen.
666 * xfns.c: Don't assume strlen fits in int.
667 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
669 * xdisp.c (message_log_check_duplicate): Return intmax_t,
670 not unsigned long, as we prefer signed integers. All callers changed.
671 Detect integer overflow in repeat count.
672 (message_dolog): Don't assume print length fits in 39 bytes.
673 (display_mode_element): Don't assume strlen fits in int.
675 * termcap.c: Don't assume sizes fit in int and never overflow.
676 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
677 (gobble_line): Check for size-calculation overflow.
679 * minibuf.c (Fread_buffer):
680 * lread.c (intern, intern_c_string):
681 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
682 Don't assume string length fits in int.
684 * keyboard.c (parse_tool_bar_item):
685 * gtkutil.c (style_changed_cb): Avoid need for strlen.
687 * font.c: Don't assume string length fits in int.
688 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
689 Use ptrdiff_t, not int.
690 (font_intern_prop): Don't assume string length fits in int.
691 Don't assume integer property fits in fixnum.
692 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
694 * filelock.c: Fix some buffer overrun and integer overflow issues.
695 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
696 Reformulate so as not to need the command string.
697 Invoke gzip -cd rather than gunzip, as it's more portable.
698 (lock_info_type, lock_file_1, lock_file):
699 Don't assume pid_t and time_t fit in unsigned long.
700 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
701 (current_lock_owner): Prefer signed type for sizes.
702 Use memcpy, not strncpy, where memcpy is what is really wanted.
703 Don't assume (via atoi) that time_t and pid_t fit in int.
704 Check for time_t and/or pid_t out of range, e.g., via a network share.
705 Don't alloca where an auto var works fine.
707 * fileio.c: Fix some integer overflow issues.
708 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
709 Don't assume string length fits in int.
710 (directory_file_name): Don't assume string length fits in long.
711 (make_temp_name): Don't assume pid fits in int, or that its print
712 length is less than 20.
714 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
716 * coding.c (make_subsidiaries): Don't assume string length fits in int.
718 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
720 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
721 We prefer signed integers, even for size calculations.
723 * emacs.c: Don't assume string length fits in 'int'.
724 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
725 (main): Don't invoke strlen when not needed.
727 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
728 (XD_DEBUG_MESSAGE): Don't waste a byte.
730 * callproc.c (getenv_internal_1, getenv_internal)
732 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
734 * lread.c (invalid_syntax): Omit length argument.
735 All uses changed. This doesn't fix a bug, but it simplifies the
736 code away from its former Hollerith-constant appearance, and it's
737 one less 'int' to worry about when looking at integer-overflow issues.
738 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
740 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
741 This didn't break anything, but it didn't help either.
742 It's confusing to put a bogus integer in a place where the actual
743 value does not matter.
744 (LIST_END_P): Remove unused macro and its bogus comment.
745 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
747 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
748 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
750 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
751 We prefer signed types, and the value cannot exceed the EMACS_INT
752 range anyway (because otherwise the length would not be representable).
753 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
754 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
755 This avoids a GCC warning when WIDE_EMACS_INT.
757 * indent.c (sane_tab_width): New function.
758 (current_column, scan_for_column, Findent_to, position_indentation)
759 (compute_motion): Use it. This is just for clarity.
760 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
762 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
764 * lisp.h (lint_assume): New macro.
765 * composite.c (composition_gstring_put_cache):
766 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
768 * editfns.c, insdel.c:
769 Omit unnecessary forward decls, to simplify future changes.
771 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
773 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
775 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
776 Use much-faster test for byte-length change.
777 Don't assume string byte-length fits in 'int'.
778 Check that character arg fits in 'int'.
779 (mapcar1): Declare byte as byte, for clarity.
781 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
783 * fns.c (concat): Catch string overflow earlier.
784 Do not rely on integer wraparound.
786 * dispextern.h (struct it.overlay_strings_charpos)
787 (struct it.selective): Now EMACS_INT, not int.
788 * xdisp.c (forward_to_next_line_start)
789 (back_to_previous_visible_line_start)
790 (reseat_at_next_visible_line_start, next_element_from_buffer):
791 Don't arbitrarily truncate the value of 'selective' to int.
793 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
795 * composite.c: Don't truncate sizes to 'int'.
796 (composition_gstring_p, composition_reseat_it)
797 (composition_adjust_point): Use EMACS_INT, not int.
798 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
799 not EMACS_UINT, for indexes.
801 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
803 * buffer.c: Include <verify.h>.
804 (struct sortvec.priority, struct sortstr.priority):
805 Now EMACS_INT, not int.
806 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
807 (struct sortstr.size, record_overlay_string)
808 (struct sortstrlist.size, struct sortlist.used):
809 Don't truncate size to int.
810 (record_overlay_string): Check for size-calculation overflow.
811 (init_buffer_once): Check at compile-time, not run-time.
813 2011-06-22 Jim Meyering <meyering@redhat.com>
815 Don't leak an XBM-image-sized buffer
816 * image.c (xbm_load): Free the image buffer after using it.
818 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
821 * composite.c (find_automatic_composition): Omit needless 'return 0;'
822 that Sun C diagnosed.
823 * fns.c (secure_hash): Fix pointer signedness issue.
824 * intervals.c (static_offset_intervals): New function.
825 (offset_intervals): Use it.
827 2011-06-21 Leo Liu <sdl.web@gmail.com>
830 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
833 * fns.c (secure_hash): Rename from crypto_hash_function and change
834 the first arg to accept symbols.
835 (Fsecure_hash): New primitive.
836 (syms_of_fns): New symbols.
838 2011-06-20 Deniz Dogan <deniz@dogan.se>
840 * process.c (Fset_process_buffer): Clarify return value in
843 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
845 * dispnew.c (add_window_display_history): Use BVAR.
847 * xdisp.c (debug_method_add): Use BVAR.
848 (check_window_end, dump_glyph_matrix, dump_glyph)
849 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
851 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
854 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
855 check till after the cache is created in init_frame_faces.
857 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
859 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
861 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
863 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
864 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
865 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
867 Improve buffer-overflow checking (Bug#8873).
868 * fileio.c (Finsert_file_contents):
869 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
870 Remove the old (too-loose) buffer overflow checks.
871 They weren't needed, since make_gap checks for buffer overflow.
872 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
873 The old code merely checked for Emacs fixnum overflow, and relied
874 on undefined (wraparound) behavior. The new code avoids undefined
875 behavior, and also checks for ptrdiff_t and/or size_t overflow.
877 * editfns.c (Finsert_char): Don't dump core with very negative counts.
878 Tune. Don't use wider integers than needed. Don't use alloca.
879 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
881 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
883 * insdel.c, lisp.h (buffer_overflow): New function.
884 (insert_from_buffer_1, replace_range, replace_range_2):
885 * insdel.c (make_gap_larger):
886 * editfns.c (Finsert_char):
887 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
889 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
891 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
893 Integer overflow and signedness fixes (Bug#8873).
895 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
896 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
898 * fileio.c: Don't assume EMACS_INT fits in off_t.
899 (emacs_lseek): New static function.
900 (Finsert_file_contents, Fwrite_region): Use it.
901 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
903 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
905 * fns.c: Don't overflow int when computing a list length.
906 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
907 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
908 truncation on 64-bit hosts. Check for QUIT every
909 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
910 faster and is responsive enough.
911 (Flength): Report an error instead of overflowing an integer.
912 (Fsafe_length): Return a float if the value is not representable
913 as a fixnum. This shouldn't happen except in contrived situations.
914 (Fnthcdr, Fsort): Don't assume list length fits in int.
915 (Fcopy_sequence): Don't assume vector length fits in int.
917 * alloc.c: Check that resized vectors' lengths fit in fixnums.
918 (header_size, word_size): New constants.
919 (allocate_vectorlike): Don't check size overflow here.
920 (allocate_vector): Check it here instead, since this is the only
921 caller of allocate_vectorlike that could cause overflow.
922 Check that the new vector's length is representable as a fixnum.
924 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
925 The previous code was bogus. For example, next_almost_prime (32)
926 returned 39, which is undesirable as it is a multiple of 3; and
927 next_almost_prime (24) returned 25, which is a multiple of 5 so
928 why was the code bothering to check for multiples of 7?
930 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
932 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
934 Variadic C functions now count arguments with ptrdiff_t.
935 This partly undoes my 2011-03-30 change, which replaced int with size_t.
936 Back then I didn't know that the Emacs coding style prefers signed int.
937 Also, in the meantime I found a few more instances where arguments
938 were being counted with int, which may truncate counts on 64-bit
939 machines, or EMACS_INT, which may be unnecessarily wide.
940 * lisp.h (struct Lisp_Subr.function.aMANY)
941 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
942 Arg counts are now ptrdiff_t, not size_t.
943 All variadic functions and their callers changed accordingly.
944 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
945 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
946 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
947 * callint.c (Fcall_interactively): Check arg count for overflow,
948 to avoid potential buffer overrun. Use signed char, not 'int',
949 for 'varies' array, so that we needn't bother to check its size
950 calculation for overflow.
951 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
952 * eval.c (apply_lambda):
953 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
954 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
955 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
957 * callint.c (Fcall_interactively): Don't use index var as event count.
959 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
960 * mem-limits.h (SIZE): Remove; no longer used.
962 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
964 Remove unnecessary casts.
965 * xterm.c (x_term_init):
966 * xfns.c (x_set_border_pixel):
967 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
968 These aren't needed now that we assume ANSI C.
970 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
971 It's more likely to cause problems (due to unsigned overflow)
974 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
976 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
978 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
980 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
982 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
984 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
986 GLYPH_CODE_FACE returns EMACS_INT, not int.
987 * dispextern.h (merge_faces):
988 * xfaces.c (merge_faces):
989 * xdisp.c (get_next_display_element, next_element_from_display_vector):
990 Don't assume EMACS_INT fits in int.
992 * character.h (CHAR_VALID_P): Remove unused parameter.
993 * fontset.c, lisp.h, xdisp.c: All uses changed.
995 * editfns.c (Ftranslate_region_internal): Omit redundant test.
997 * fns.c (concat): Minor tuning based on overflow analysis.
998 This doesn't fix any bugs. Use int to hold character, instead
999 of constantly refetching from Emacs object. Use XFASTINT, not
1000 XINT, for value known to be a character. Don't bother comparing
1001 a single byte to 0400, as it's always less.
1003 * floatfns.c (Fexpt):
1004 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1006 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1009 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1011 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1012 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1013 incorrectly succeed when S was a string, because 4294967386 was
1014 truncated before it was used.
1016 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1017 Otherwise, an out-of-range integer could cause undefined behavior
1020 * composite.c: Use int, not EMACS_INT, for characters.
1021 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1022 EMACS_INT, for values that are known to be in character range.
1023 This doesn't fix any bugs but is the usual style inside Emacs and
1024 may generate better code on 32-bit machines.
1026 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1027 This is for reasons similar to the recent CHAR_STRING fix.
1028 * charset.c (Fencode_char): Check that character arg is actually
1029 a character. Pass an int to ENCODE_CHAR.
1030 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1031 wider than 'int', as a compile-time check to prevent future regressions
1034 * character.c (char_string): Remove unnecessary casts.
1036 Make sure a 64-bit char is never passed to CHAR_STRING.
1037 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1038 by silently ignoring the top 32 bits, allowing some values
1039 that were far too large to be valid characters.
1040 * character.h: Include <verify.h>.
1041 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1042 arguments are no wider than unsigned, as a compile-time check
1043 to prevent future regressions in this area.
1045 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1046 (Fsubst_char_in_region):
1048 * xdisp.c (decode_mode_spec_coding):
1049 Adjust to CHAR_STRING's new requirement.
1050 * editfns.c (Finsert_char, Fsubst_char_in_region):
1051 * fns.c (concat): Check that character args are actually
1052 characters. Without this test, these functions did the wrong
1053 thing with wildly out-of-range values on 64-bit hosts.
1055 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1056 These casts should not be needed on 32-bit hosts, either.
1057 * keyboard.c (read_char):
1058 * lread.c (Fload): Remove casts to unsigned.
1060 * lisp.h (UNSIGNED_CMP): New macro.
1061 This fixes comparison bugs on 64-bit hosts.
1062 (ASCII_CHAR_P): Use it.
1063 * casefiddle.c (casify_object):
1064 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1065 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1066 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1067 * dispextern.h (FACE_FROM_ID):
1068 * keyboard.c (read_char): Use UNSIGNED_CMP.
1070 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1071 not to EMACS_INT, to avoid GCC warning.
1073 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1075 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1076 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1077 isn't needed on 32-bit machines.
1079 * buffer.c (Fgenerate_new_buffer_name):
1080 Use EMACS_INT for count, not int.
1081 (advance_to_char_boundary): Return EMACS_INT, not int.
1083 * data.c (Qcompiled_function): Now static.
1085 * window.c (window_body_lines): Now static.
1087 * image.c (gif_load): Rename local to avoid shadowing.
1089 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1090 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1091 * alloc.c (make_save_value): Integer argument is now of type
1093 (mark_object): Use ptrdiff_t, not int.
1094 * lisp.h (pD): New macro.
1095 * print.c (print_object): Use it.
1097 * alloc.c: Use EMACS_INT, not int, to count objects.
1098 (total_conses, total_markers, total_symbols, total_vector_size)
1099 (total_free_conses, total_free_markers, total_free_symbols)
1100 (total_free_floats, total_floats, total_free_intervals)
1101 (total_intervals, total_strings, total_free_strings):
1102 Now EMACS_INT, not int. All uses changed.
1103 (Fgarbage_collect): Compute overall total using a double, so that
1104 integer overflow is less likely to be a problem. Check for overflow
1105 when converting back to an integer.
1106 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1107 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1108 These were 'int' variables that could overflow on 64-bit hosts;
1109 they were never used, so remove them instead of repairing them.
1110 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1111 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1112 Previously, this ceilinged at INT_MAX, but that doesn't work on
1114 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1116 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1117 (allocate_vectorlike): Check for ptrdiff_t overflow.
1118 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1119 when a (possibly-narrower) signed value would do just as well.
1120 We prefer using signed arithmetic, to avoid comparison confusion.
1122 * alloc.c: Catch some string size overflows that we were missing.
1123 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1124 for convenience in STRING_BYTES_MAX.
1125 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1126 The definition here is exact; the one in lisp.h was approximate.
1127 (allocate_string_data): Check for string overflow. This catches
1128 some instances we weren't catching before. Also, it catches
1129 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1130 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1131 and ptrdiff_t and EMACS_INT are both 64 bits.
1133 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1134 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1135 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1137 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1139 * alloc.c (Fmake_string): Check for out-of-range init.
1141 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1143 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1145 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1147 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1148 xg_get_default_scrollbar_width.
1150 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1151 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1152 (style_changed_cb): Call update_theme_scrollbar_width and call
1153 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1154 all frames (Bug#8505).
1155 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1156 Call gtk_window_set_resizable if HAVE_GTK3.
1157 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1158 and height if HAVE_GTK3 (Bug#8505).
1159 (scroll_bar_width_for_theme): New variable.
1160 (update_theme_scrollbar_width): New function.
1161 (xg_get_default_scrollbar_width): Move code to
1162 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1163 (xg_initialize): Call update_theme_scrollbar_width.
1165 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1167 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1169 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1171 * frame.c (make_frame): Call other_buffer_safely instead of
1174 * window.c (temp_output_buffer_show): Call display_buffer with
1175 second argument Vtemp_buffer_show_specifiers and reset latter
1176 immediately after the call.
1177 (Vtemp_buffer_show_specifiers): New variable.
1178 (auto_window_vscroll_p, next_screen_context_lines)
1179 (Vscroll_preserve_screen_position): Remove leading asterisks from
1182 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1184 Fix minor problems found by GCC 4.6.0 static checking.
1185 * buffer.c (Qclone_number): Remove for now, as it's unused.
1186 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1187 (record_buffer): Remove unused local.
1188 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1189 (set_frame_buffer_list): Remove; unused.
1190 * frame.h (other_visible_frames): Remove decl.
1191 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1192 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1193 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1195 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1196 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1197 Define only if HAVE_GPM.
1198 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1199 (update_hints_inhibit): Remove; never set. All uses removed.
1200 * widgetprv.h (emacsFrameClassRec): Remove decl.
1201 * window.c (delete_deletable_window): Now returns void, since it
1202 wasn't returning anything.
1203 (compare_window_configurations): Remove unused locals.
1204 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1205 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1206 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1207 the same widths as pointers. This follows up on the 2011-05-06 patch.
1208 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1209 * xterm.h: Likewise.
1210 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1212 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1214 * makefile.w32-in: Update dependencies.
1215 (LISP_H): Add lib/intprops.h.
1217 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1219 * image.c (gif_load): Add animation frame delay to the metadata.
1220 (syms_of_image): Use DEFSYM. New symbol `delay'.
1222 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1224 * window.c (delete_deletable_window): Re-add.
1225 (Fset_window_configuration): Rewrite to handle dead buffers and
1226 consequently deletable windows.
1227 (window_tree, Fwindow_tree): Remove. Supply functionality in
1229 (compare_window_configurations): Simplify code.
1231 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1233 * image.c (imagemagick_load_image): Fix type mismatch.
1234 (Fimagemagick_types): Likewise.
1236 * window.h (replace_buffer_in_windows): Declare.
1238 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1240 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1241 Qclone_number. Remove external declaration of Qdelete_window.
1242 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1244 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1245 Qbuffer_list_update_hook if allowed.
1246 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1247 buffer list implementation.
1248 (other_buffer_safely): New function.
1249 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1250 calls to replace_buffer_in_windows and
1251 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1253 (record_buffer): Inhibit quitting and rewrite using quittable
1254 functions. Run Qbuffer_list_update_hook if allowed.
1255 (Frecord_buffer, Funrecord_buffer): New functions.
1256 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1257 switch-to-buffer to window.el.
1258 (bury-buffer): Move to window.el.
1259 (Vbuffer_list_update_hook): New variable.
1261 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1264 * window.h (resize_frame_windows): Move up in code.
1265 (Fwindow_frame): Remove EXFUN.
1266 (replace_buffer_in_all_windows): Remove prototype.
1267 (replace_buffer_in_windows_safely): Add prototype.
1269 * window.c: Declare Qdelete_window static again. Move down
1270 declaration of select_count.
1271 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1272 (Fother_window): Move to window.el.
1273 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1274 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1275 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1277 (replace_buffer_in_windows): Implement by calling
1278 Qreplace_buffer_in_windows.
1279 (replace_buffer_in_all_windows): Remove with some functionality
1280 moved into replace_buffer_in_windows_safely.
1281 (replace_buffer_in_windows_safely): New function.
1282 (select_window_norecord, select_frame_norecord): Move in front
1283 of run_window_configuration_change_hook. Remove now obsolete
1285 (Fset_window_buffer): Rewrite doc-string. Call
1286 Qrecord_window_buffer.
1287 (keys_of_window): Move binding for other-window to window.el.
1289 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1291 * dispextern.h (struct image): Replace data member, whose int_val
1292 and ptr_val fields were not used by anything, with a single
1295 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1296 (gif_clear_image, gif_load, imagemagick_load_image)
1297 (gs_clear_image, gs_load): Callers changed.
1299 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1301 * buffer.h: Include <time.h>, for time_t.
1302 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1304 Fix minor problems found by static checking.
1306 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1308 Make identifiers static if they are not used in other modules.
1309 * data.c (Qcompiled_function, Qframe, Qvector):
1310 * image.c (QimageMagick, Qsvg):
1311 * minibuf.c (Qmetadata):
1312 * window.c (resize_window_check, resize_root_window): Now static.
1313 * window.h (resize_window_check, resize_root_window): Remove decls.
1315 * window.c (window_deletion_count, delete_deletable_window):
1317 (window_body_lines): Now static.
1318 (Fdelete_other_windows_internal): Mark vars as initialized.
1319 Make sure 'resize_failed' is initialized.
1320 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1321 (resize_window_apply): Remove unused local.
1322 * window.h (delete_deletable_window): Remove decl.
1324 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1325 (imagemagick_load_image): Fix pointer signedness problem by changing
1326 last arg from unsigned char * to char *. All uses changed.
1327 Also, fix a local for similar reasons.
1328 Remove unused locals. Remove locals to avoid shadowing.
1329 (fn_rsvg_handle_free): Remove; unused.
1330 (svg_load, svg_load_image): Fix pointer signedness problem.
1331 (imagemagick_load_image): Don't use garbage pointer image_wand.
1333 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1335 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1337 * image.c (gif_load): Fix omitted cast error introduced by
1340 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1342 * window.h (resize_proportionally, orig_total_lines)
1343 (orig_top_line): Remove from window structure.
1344 (set_window_height, set_window_width, change_window_heights)
1345 (Fdelete_window): Remove prototypes.
1346 (resize_frame_windows): Remove duplicate declaration.
1348 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1350 * window.h (resize_frame_windows, resize_window_check)
1351 (delete_deletable_window, resize_root_window)
1352 (resize_frame_windows): Declare prototypes.
1354 * window.c (resize_window_apply): Make definition be "static" to
1355 match the prototype.
1357 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1359 * window.c: Remove declarations of Qwindow_size_fixed,
1360 window_min_size_1, window_min_size_2, window_min_size,
1361 size_window, window_fixed_size_p, enlarge_window, delete_window.
1362 Remove static from declaration of Qdelete_window, it's
1363 temporarily needed by Fbury_buffer.
1364 (replace_window): Don't assign orig_top_line and
1366 (Fdelete_window, delete_window): Remove. Window deletion is
1367 handled by window.el.
1368 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1369 Fdelete_window calls with calls to Qdelete_window.
1370 (Fdelete_other_windows): Remove. Deleting other windows is
1371 handled by window.el.
1372 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1373 handled in window.el.
1374 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1375 Window minimum sizes are handled in window.el.
1376 (shrink_windows, size_window, set_window_height)
1377 (set_window_width, change_window_heights, window_height)
1378 (window_width, CURBEG, CURSIZE, enlarge_window)
1379 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1380 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1381 handled in window.el.
1382 (make_dummy_parent): Rename to make_parent_window and give it a
1383 second argument horflag.
1384 (make_window): Don't set resize_proportionally any more.
1385 (Fsplit_window): Remove. Windows are split in window.el.
1386 (save_restore_action, save_restore_orig_size)
1387 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1388 Resize mini windows in window.el.
1389 (grow_mini_window, shrink_mini_window): Implement by calling
1390 Qresize_root_window_vertically, resize_window_check and
1391 resize_window_apply.
1392 (saved_window, Fset_window_configuration, save_window_save): Do
1393 not handle orig_top_line, orig_total_lines, and
1394 resize_proportionally.
1395 (window_min_height, window_min_width): Move to window.el.
1396 (keys_of_window): Move bindings for delete-other-windows,
1397 split-window, delete-window and enlarge-window to window.el.
1399 * buffer.c: Temporarily extern Qdelete_window.
1400 (Fbury_buffer): Temporarily call Qdelete_window instead of
1401 Fdelete_window (Fbury_buffer will move to window.el soon).
1403 * frame.c (set_menu_bar_lines_1): Remove code handling
1404 orig_top_line and orig_total_lines.
1406 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1407 set_window_height but set heights directly.
1408 (change_frame_size_1): Use resize_frame_windows.
1410 * xdisp.c (init_xdisp): Don't use set_window_height but set
1413 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1414 resize_frame_windows instead of change_window_heights and run
1415 run_window_configuration_change_hook.
1417 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1418 instead of change_window_heights and run
1419 run_window_configuration_change_hook.
1421 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1423 * window.c (replace_window): Rename second argument REPLACEMENT to
1424 NEW. New third argument SETFLAG. Rewrite.
1425 (delete_window, make_dummy_parent): Call replace_window with
1427 (window_list_1): Move down in code.
1428 (run_window_configuration_change_hook): Move set_buffer part
1429 before select_frame_norecord part in order to unwind correctly.
1430 Rename count1 to count.
1431 (recombine_windows, delete_deletable_window, resize_root_window)
1432 (Fdelete_other_windows_internal)
1433 (Frun_window_configuration_change_hook, make_parent_window)
1434 (resize_window_check, resize_window_apply, Fresize_window_apply)
1435 (resize_frame_windows, Fsplit_window_internal)
1436 (Fdelete_window_internal, Fresize_mini_window_internal): New
1438 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1440 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1442 * window.h (window): Add some new members to window structure -
1443 normal_lines, normal_cols, new_total, new_normal, clone_number,
1444 splits, nest, prev_buffers, next_buffers.
1445 (WINDOW_TOTAL_SIZE): Move here from window.c.
1446 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1448 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1450 (make_dummy_parent): Set new members of windows structure.
1451 (make_window): Move down in code. Handle new members of window
1453 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1454 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1455 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1456 (Fset_window_prev_buffers, Fwindow_next_buffers)
1457 (Fset_window_next_buffers, Fset_window_clone_number): New
1459 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1460 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1462 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1463 Argument WINDOW can be now internal window too.
1464 (Fwindow_use_time): Move up in code.
1465 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1467 (Fset_window_configuration, saved_window)
1468 (Fcurrent_window_configuration, save_window_save): Handle new
1469 members of window structure.
1470 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1471 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1472 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1473 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1474 Qget_mru_window, Qresize_root_window,
1475 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1476 Qauto_buffer_name; staticpro them.
1478 2011-06-07 Martin Rudalics <rudalics@gmx.at>
1480 * window.c (Fwindow_total_size, Fwindow_left_column)
1481 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1482 (Fwindow_list_1): New functions.
1483 (window_box_text_cols): Replace with window_body_cols.
1484 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1485 window_body_cols instead of window_box_text_cols.
1486 (delete_window, Fset_window_configuration): Call
1487 delete_all_subwindows with window as argument.
1488 (delete_all_subwindows): Take a window as argument and not a
1490 (window_loop): Remove handling of GET_LRU_WINDOW and
1492 (Fget_lru_window, Fget_largest_window): Move to window.el.
1494 * window.h: Extern window_body_cols instead of
1495 window_box_text_cols. delete_all_subwindows now takes a
1496 Lisp_Object as argument.
1498 * indent.c (compute_motion, Fcompute_motion): Use
1499 window_body_cols instead of window_box_text_cols.
1501 * frame.c (delete_frame): Call delete_all_subwindows with root
1504 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1506 * fns.c (Fputhash): Document return value.
1508 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
1510 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1512 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1514 Cons<->int and similar integer overflow fixes (Bug#8794).
1516 Check for overflow when converting integer to cons and back.
1517 * charset.c (Fdefine_charset_internal, Fdecode_char):
1518 Use cons_to_unsigned to catch overflow.
1519 (Fencode_char): Use INTEGER_TO_CONS.
1520 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1521 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1522 * data.c (long_to_cons, cons_to_long): Remove.
1523 (cons_to_unsigned, cons_to_signed): New functions.
1524 These signal an error for invalid or out-of-range values.
1525 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1526 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1527 * font.c (Ffont_variation_glyphs):
1528 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1529 * lisp.h: Include <intprops.h>.
1530 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1531 (cons_to_signed, cons_to_unsigned): New decls.
1532 (long_to_cons, cons_to_long): Remove decls.
1533 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1534 (Fprimitive_undo): Use CONS_TO_INTEGER.
1535 * xfns.c (Fx_window_property): Likewise.
1536 * xselect.c: Include <limits.h>.
1537 (x_own_selection, selection_data_to_lisp_data):
1538 Use INTEGER_TO_CONS.
1539 (x_handle_selection_request, x_handle_selection_clear)
1540 (x_get_foreign_selection, Fx_disown_selection_internal)
1541 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1542 (lisp_data_to_selection_data): Use cons_to_unsigned.
1543 (x_fill_property_data): Use cons_to_signed.
1544 Report values out of range.
1546 Check for buffer and string overflow more precisely.
1547 * buffer.h (BUF_BYTES_MAX): New macro.
1548 * lisp.h (STRING_BYTES_MAX): New macro.
1549 * alloc.c (Fmake_string):
1550 * character.c (string_escape_byte8):
1551 * coding.c (coding_alloc_by_realloc):
1552 * doprnt.c (doprnt):
1553 * editfns.c (Fformat):
1555 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1556 since they may not be the same number.
1557 * editfns.c (Finsert_char):
1558 * fileio.c (Finsert_file_contents):
1559 Likewise for BUF_BYTES_MAX.
1561 * image.c: Use ptrdiff_t, not int, for sizes.
1562 (slurp_file): Switch from int to ptrdiff_t.
1564 (slurp_file): Check that file size fits in both size_t (for
1565 malloc) and ptrdiff_t (for sanity and safety).
1567 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1568 if b->modtime has its maximal value.
1570 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1572 Don't assume time_t can fit into int.
1573 * buffer.h (struct buffer.modtime): Now time_t, not int.
1574 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1575 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1577 Minor fixes for signed vs unsigned integers.
1578 * character.h (MAYBE_UNIFY_CHAR):
1579 * charset.c (maybe_unify_char):
1580 * keyboard.c (read_char, reorder_modifiers):
1581 XINT -> XFASTINT, since the integer must be nonnegative.
1582 * ftfont.c (ftfont_spec_pattern):
1583 * keymap.c (access_keymap, silly_event_symbol_error):
1584 XUINT -> XFASTINT, since the integer must be nonnegative.
1585 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1586 since it makes no difference and we prefer signed.
1587 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1588 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1591 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1593 * window.h (Fwindow_frame): Declare.
1595 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1597 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1598 (SPARE_MEMORY): Always define.
1599 (LARGE_REQUEST): Remove.
1600 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1602 2011-06-06 Martin Rudalics <rudalics@gmx.at>
1604 * lisp.h: Move EXFUNS for Fframe_root_window,
1605 Fframe_first_window and Fset_frame_selected_window to window.h.
1607 * window.h: Move EXFUNS for Fframe_root_window,
1608 Fframe_first_window and Fset_frame_selected_window here from
1611 * frame.c (Fwindow_frame, Fframe_first_window)
1612 (Fframe_root_window, Fframe_selected_window)
1613 (Fset_frame_selected_window): Move to window.c.
1614 (Factive_minibuffer_window): Move to minibuf.c.
1615 (Fother_visible_frames_p): New function.
1617 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1619 * window.c (decode_window, decode_any_window): Move up in code.
1620 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1621 (inhibit_frame_unsplittable): Remove unused variable.
1622 (Fwindow_buffer): Move up and rewrite doc-string.
1623 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1624 (Fwindow_prev): New functions.
1625 (Fwindow_frame): Move here from frame.c. Accept any window as
1627 (Fframe_root_window, Fframe_first_window)
1628 (Fframe_selected_window): Move here from frame.c. Accept frame
1629 or arbitrary window as argument. Update doc-strings.
1630 (Fminibuffer_window): Move up in code.
1631 (Fwindow_minibuffer_p): Move up in code and simplify.
1632 (Fset_frame_selected_window): Move here from frame.c.
1634 (Fselected_window, select_window, Fselect_window): Move up in
1635 code. Minor doc-string fixes.
1637 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1639 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1640 Do not assume that spare memory exists; that assumption is valid
1641 only if SYSTEM_MALLOC.
1642 (LARGE_REQUEST): New macro, so that the issue of large requests
1643 is separated from the issue of spare memory.
1645 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1647 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1650 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1652 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1655 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1657 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1659 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1661 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1662 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1664 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
1666 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1668 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
1670 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1671 (x_clipboard_manager_save): Add return value.
1672 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1674 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1675 Obey Vx_select_enable_clipboard_manager. Catch errors in
1676 x_clipboard_manager_save (Bug#8779).
1677 (Vx_select_enable_clipboard_manager): New variable.
1678 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
1680 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
1682 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1684 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1686 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1687 in the current matrix if keep_current_p is non-zero.
1689 2011-06-04 Eli Zaretskii <eliz@gnu.org>
1691 * bidi.c (bidi_level_of_next_char): Fix last change.
1693 2011-06-03 Eli Zaretskii <eliz@gnu.org>
1695 Support bidi reordering of text covered by display properties.
1697 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1698 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1699 (bidi_cache_search, bidi_cache_iterator_state)
1700 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1701 (bidi_level_of_next_char, bidi_move_to_visually_next):
1702 Support character positions inside a run of characters covered by a
1704 (bidi_paragraph_init, bidi_resolve_explicit_1)
1705 (bidi_level_of_next_char): Call bidi_fetch_char and
1706 bidi_fetch_char_advance instead of FETCH_CHAR and
1708 (bidi_init_it): Initialize new members.
1709 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1711 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1712 instead of using explicit *_CHAR codes.
1713 (bidi_resolve_explicit, bidi_resolve_weak):
1714 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
1715 bidirectional text is supported only in multibyte buffers.
1716 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1717 it to initialize the frame_window_p member of struct bidi_it.
1718 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1719 (bidi_resolve_explicit, bidi_resolve_weak)
1720 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1721 bidi_it->nchars is non-positive.
1722 (bidi_level_of_next_char): Don't try to lookup the cache for the
1723 next/previous character if nothing is cached there yet, or if we
1724 were just reseat()'ed to a new position.
1726 * xdisp.c (set_cursor_from_row): Set start and stop points
1727 according to the row's direction when priming the loop that looks
1728 for the glyph on which to display cursor.
1729 (single_display_spec_intangible_p): Function deleted.
1730 (display_prop_intangible_p): Reimplement to call
1731 handle_display_spec instead of single_display_spec_intangible_p.
1732 Accept 3 additional arguments needed by handle_display_spec.
1733 This fixes incorrect cursor motion across display property with complex
1734 values: lists, `(when COND...)' forms, etc.
1735 (single_display_spec_string_p): Support property values that are
1736 lists with the argument STRING its top-level element.
1737 (display_prop_string_p): Fix the condition for processing a
1738 property that is a list to be consistent with handle_display_spec.
1739 (handle_display_spec): New function, refactored from the
1740 last portion of handle_display_prop.
1741 (compute_display_string_pos): Accept additional argument
1742 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1743 value of a `display' property is a "replacing spec".
1744 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1745 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1746 the display property, but just return a value indicating whether
1747 the display property will replace the characters it covers.
1748 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1749 frame_window_p members of struct bidi_it.
1750 (compute_display_string_pos, compute_display_string_end):
1752 (push_it): Accept second argument POSITION, where pop_it should
1753 jump to continue iteration.
1754 (reseat_1): Initialize bidi_it.disp_pos.
1756 * keyboard.c (adjust_point_for_property): Adjust the call to
1757 display_prop_intangible_p to its new signature.
1759 * dispextern.h (struct bidi_it): New member frame_window_p.
1760 (bidi_init_it): Update prototypes.
1761 (display_prop_intangible_p): Update prototype.
1762 (compute_display_string_pos, compute_display_string_end):
1764 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1767 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
1769 Malloc failure behavior now depends on size of allocation.
1770 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1771 * lisp.h: Change signatures accordingly.
1772 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1773 All callers changed. (Bug#8762)
1775 * gnutls.c: Use Emacs's memory allocators.
1776 Without this change, the gnutls library would invoke malloc etc.
1777 directly, which causes problems on non-SYNC_INPUT hosts, and which
1778 runs afoul of improving memory_full behavior. (Bug#8761)
1779 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1780 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1781 xfree instead of the default malloc, realloc, free.
1782 (Fgnutls_boot): No need to check for memory allocation failure,
1783 since xmalloc does that for us.
1785 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
1786 * category.c (hash_get_category_set):
1787 * ccl.c (ccl_driver):
1788 * charset.c (Fdefine_charset_internal):
1789 * charset.h (struct charset.hash_index):
1790 * composite.c (get_composition_id, gstring_lookup_cache)
1791 (composition_gstring_put_cache):
1792 * composite.h (struct composition.hash_index):
1793 * dispextern.h (struct image.hash):
1794 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1795 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1796 (hashfn_equal, hashfn_user_defined, make_hash_table)
1797 (maybe_resize_hash_table, hash_lookup, hash_put)
1798 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1799 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1800 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1801 * image.c (make_image, search_image_cache, lookup_image)
1802 (xpm_put_color_table_h):
1803 * lisp.h (struct Lisp_Hash_Table):
1804 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
1805 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1806 for hashes and hash indexes, instead of 'unsigned' and 'int'.
1807 * alloc.c (allocate_vectorlike):
1808 Check for overflow in vector size calculations.
1809 * ccl.c (ccl_driver):
1810 Check for overflow when converting EMACS_INT to int.
1811 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1812 need to be updated by these changes.
1813 * fns.c (make_hash_table, maybe_resize_hash_table):
1814 Check for integer overflow with large hash tables.
1815 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1816 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1817 (SXHASH_REDUCE): New macro.
1818 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1819 Use it instead of discarding useful hash info with large hash values.
1820 (sxhash_float): New function.
1821 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1822 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1823 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1824 Rewrite to use FIXNUM_BITS, as this simplifies things.
1825 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1826 Adjust signatures to match updated version of code.
1827 (consing_since_gc): Now EMACS_INT, since a single hash table can
1828 use more than INT_MAX bytes.
1830 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1832 Make it possible to build with GCC-4.6+ -O2 -flto.
1834 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1836 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1838 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1839 Call minibuffer-inactive-mode.
1841 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1843 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1844 Update dependencies.
1846 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1848 * data.c (init_data): Remove code for UTS, this system is not
1851 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1853 Don't force ./temacs to start in terminal mode.
1855 * frame.c (make_initial_frame): Initialize faces in all cases, not
1856 only when CANNOT_DUMP is defined.
1857 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1859 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1861 * dispnew.c (add_window_display_history): Use const for the string
1862 pointer. Remove declaration, not needed.
1864 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1866 Use 'inline', not 'INLINE'.
1867 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1868 * alloc.c, fontset.c (INLINE): Remove.
1869 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1870 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1871 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1872 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1873 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1875 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1877 Make it possible to run ./temacs.
1879 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1880 syms_of_callproc does the same thing. Remove test for
1881 "initialized", do it in the caller.
1882 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1884 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1886 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1887 (read_minibuf): Use get_minibuffer.
1888 (syms_of_minibuf): Use DEFSYM.
1889 (Qmetadata): New var.
1890 * data.c (Qbuffer): Don't make it static.
1891 (syms_of_data): Use DEFSYM.
1893 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1895 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1896 (CCL_CODE_MIN): New macro.
1898 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1900 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1902 * eval.c (Qdebug): Now static.
1903 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1904 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1905 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1907 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1909 * image.c: Various fixes to ImageMagick code comments.
1910 (Fimagemagick_types): Doc fix.
1912 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1914 Minor fixes prompted by GCC 4.6.0 warnings.
1916 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1918 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1919 (x_clipboard_manager_save_all): Move extern decl to ...
1920 * xterm.h: ... here, so that it can be checked for consistency.
1922 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1924 * xselect.c (x_clipboard_manager_save_frame)
1925 (x_clipboard_manager_save_all): New functions.
1926 (Fx_clipboard_manager_save): Lisp function deleted.
1928 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1929 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1931 * xterm.h: Update prototype.
1933 2011-05-28 William Xu <william.xwl@gmail.com>
1935 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1938 2011-05-28 Jim Meyering <meyering@redhat.com>
1940 Avoid a sign-extension bug in crypto_hash_function.
1941 * fns.c (to_uchar): Define.
1942 (crypto_hash_function): Use it to convert some newly-signed
1943 variables to unsigned, to avoid sign-extension bugs. For example,
1944 without this change, (md5 "truc") would evaluate to
1945 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1946 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1947 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1949 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1951 Integer overflow fixes.
1953 * dbusbind.c: Serial number integer overflow fixes.
1954 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1955 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1956 to hold a serial number that is too large for a fixnum.
1957 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1958 Check for serial numbers out of range. Decode any serial number
1959 that was so large that it became a float. (Bug#8722)
1961 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1962 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1963 Use XFASTINT rather than XUINT when numbers are nonnegative.
1964 (xd_append_arg, Fdbus_method_return_internal):
1965 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1966 arguments, check that Lisp number is nonnegative, rather than
1967 silently wrapping negative numbers around. (Bug#8722)
1968 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1971 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1973 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1975 ccl: add integer overflow checks
1976 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1977 (IN_INT_RANGE): New macros.
1978 (ccl_driver): Use them to check for integer overflow when
1979 decoding a CCL program. Many of the new checks are whether XINT (x)
1980 fits in int; it doesn't always, on 64-bit hosts. The new version
1981 doesn't catch all possible integer overflows, but it's an
1982 improvement. (Bug#8719)
1984 * alloc.c (make_event_array): Use XINT, not XUINT.
1985 There's no need for unsigned here.
1987 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1988 This follows up to the 2011-05-06 change that substituted uintptr_t
1989 for EMACS_INT. This case wasn't caught back then.
1991 Rework Fformat to avoid integer overflow issues.
1992 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1993 now (part of C89). Include <verify.h>.
1994 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1995 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1996 (Fformat): Avoid the prepass trying to compute sizes; it was only
1997 approximate and thus did not catch overflow reliably. Instead, walk
1998 through the format just once, formatting and computing sizes as we go,
1999 checking for integer overflow at every step, and allocating a larger
2000 buffer as needed. Keep track separately whether the format is
2001 multibyte. Keep only the most-recently calculated precision, rather
2002 than them all. Record whether each argument has been converted to
2003 string. Use EMACS_INT, not int, for byte and char and arg counts.
2004 Support field widths and precisions larger than INT_MAX. Avoid
2005 sprintf's undefined behavior with conversion specifications such as %#d
2006 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2007 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2008 formatting out-of-range floating point numbers with int
2011 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2013 * data.c: Avoid integer truncation in expressions involving floats.
2014 * data.c: Include <intprops.h>.
2015 (arith_driver): When there's an integer overflow in an expression
2016 involving floating point, convert the integers to floating point
2017 so that the resulting value does not suffer from catastrophic
2018 integer truncation. For example, on a 64-bit host (* 4
2019 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2020 Do not rely on undefined behavior after integer overflow.
2022 merge count_size_as_multibyte, parse_str_to_multibyte
2023 * character.c, character.h (count_size_as_multibyte):
2024 Rename from parse_str_to_multibyte; all uses changed.
2025 Check for integer overflow.
2026 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2027 since it's now a duplicate of the other. This is more of
2028 a character than a buffer op, so better that it's in character.c.
2029 * fns.c, print.c: Adjust to above changes.
2031 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2033 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2035 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2037 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2038 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2039 (x_clipboard_manager_save): Now static.
2040 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2042 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2043 (crypto_hash_function): Now static.
2044 Fix pointer signedness problems. Avoid unnecessary initializations.
2046 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2048 * termhooks.h (Vselection_alist): Make it terminal-local.
2050 * terminal.c (create_terminal): Initialize it.
2052 * xselect.c: Support for clipboard managers.
2053 (Vselection_alist): Move to termhooks.h as terminal-local var.
2054 (LOCAL_SELECTION): New macro.
2055 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2056 (symbol_to_x_atom): Remove gratuitous arg.
2057 (x_handle_selection_request, lisp_data_to_selection_data)
2058 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2059 (x_own_selection, x_get_local_selection, x_convert_selection):
2060 New arg, specifying work frame. Use terminal-local Vselection_alist.
2061 (some_frame_on_display): Delete unused function.
2062 (Fx_own_selection_internal, Fx_get_selection_internal)
2063 (Fx_disown_selection_internal, Fx_selection_owner_p)
2064 (Fx_selection_exists_p): New optional frame arg.
2065 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2066 (x_handle_selection_clear): Don't treat other terminals with the
2067 same keyboard specially. Use the terminal-local Vselection_alist.
2068 (x_clear_frame_selections): Use Frun_hook_with_args.
2070 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2072 * xterm.h: Add support for those atoms.
2074 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2076 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2077 (converted_selections, conversion_fail_tag): New global variables.
2078 (x_selection_request_lisp_error): Free the above.
2079 (x_get_local_selection): Remove unnecessary code.
2080 (x_reply_selection_request): Args changed; handle arbitrary array
2081 of converted selections stored in converted_selections.
2082 Separate the XChangeProperty and SelectionNotify steps.
2083 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2084 (x_convert_selection): New function.
2085 (x_handle_selection_event): Simplify.
2086 (x_get_foreign_selection): Don't ignore incoming requests while
2087 waiting for an answer; this will fail when we implement
2088 SAVE_TARGETS, and seems unnecessary anyway.
2089 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2090 (Vx_sent_selection_functions): Doc fix.
2092 2011-05-26 Leo Liu <sdl.web@gmail.com>
2094 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2096 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2098 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2100 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2101 for fringe update if it has periodic bitmap.
2102 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2103 and fringe_bitmap_periodic_p.
2105 * fringe.c (get_fringe_bitmap_data): New function.
2106 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2107 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2108 row. Mark glyph row for fringe update if periodicity changed.
2110 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2111 for fringe update unless it has periodic bitmap.
2113 2011-05-25 Kenichi Handa <handa@m17n.org>
2115 * xdisp.c (get_next_display_element): Set correct it->face_id for
2116 a static composition.
2118 2011-05-24 Leo Liu <sdl.web@gmail.com>
2121 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2123 * fns.c (crypto_hash_function, Fsha1): New function.
2124 (Fmd5): Use crypto_hash_function.
2125 (syms_of_fns): Add Ssha1.
2127 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2129 * gnutls.c: Remove unused macros.
2130 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2131 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2132 Remove macros that are defined and never used.
2133 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2135 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2137 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2138 (Fx_get_selection_internal): Minor cleanup.
2139 (Fx_own_selection_internal): Rename arguments for consistency with
2142 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2144 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2146 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2148 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2150 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2152 * dispnew.c (scrolling_window): Don't exclude the case that the
2153 last enabled row in the desired matrix touches the bottom boundary.
2155 2011-05-21 Glenn Morris <rgm@gnu.org>
2157 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2158 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2159 and add some more files.
2161 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2163 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2164 report_file_error introduced by the change from 2011-05-07.
2166 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2168 * systime.h (Time): Define only if emacs is defined.
2169 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2170 where the include path doesn't have X11/X.h by default. See
2171 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2173 2011-05-20 Kenichi Handa <handa@m17n.org>
2175 * composite.c (find_automatic_composition): Fix previous change.
2177 2011-05-20 Glenn Morris <rgm@gnu.org>
2179 * lisp.mk: New file, split from Makefile.in.
2180 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2181 (shortlisp): Remove.
2182 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2184 2011-05-19 Glenn Morris <rgm@gnu.org>
2186 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2187 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2188 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2189 (lisp): Set the order to that of loadup.el.
2190 (shortlisp): Make it a copy of $lisp.
2191 (SOME_MACHINE_LISP): Remove.
2192 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2193 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2195 2011-05-18 Kenichi Handa <handa@m17n.org>
2197 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2198 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2199 (find_automatic_composition): Mostly rewrite for efficiency.
2201 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2203 * makefile.w32-in: Update dependencies.
2205 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2207 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2208 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2210 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2212 Fix some integer overflow issues, such as string length overflow.
2214 * insdel.c (count_size_as_multibyte): Check for string overflow.
2216 * character.c (lisp_string_width): Check for string overflow.
2217 Use EMACS_INT, not int, for string indexes and lengths; in
2218 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2219 the resulting string length overflows an EMACS_INT; instead,
2220 report a string overflow if no precision given. When checking for
2221 precision exhaustion, use a check that cannot possibly have
2222 integer overflow. (Bug#8675)
2223 * character.h (lisp_string_width): Adjust to new signature.
2225 * alloc.c (string_overflow): New function.
2226 (Fmake_string): Use it. This doesn't change behavior, but saves
2227 a few bytes and will simplify future changes.
2228 * character.c (string_escape_byte8): Likewise.
2229 * lisp.h (string_overflow): New decl.
2231 Fixups, following up to the user-interface timestamp change.
2232 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2233 for UI timestamps, instead of unsigned long.
2234 * msdos.c (mouse_get_pos): Likewise.
2235 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2236 * w32gui.h (Time): Define by including "systime.h" rather than by
2237 declaring it ourselves. (Bug#8664)
2239 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2240 * image.c (clear_image_cache): Likewise.
2242 * term.c (term_mouse_position): Don't assume time_t wraparound.
2244 Be more systematic about user-interface timestamps.
2245 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2246 and sometimes 'EMACS_UINT', to represent these timestamps.
2247 This change causes it to use 'Time' uniformly, as that's what X uses.
2248 This makes the code easier to follow, and makes it easier to catch
2249 integer overflow bugs such as Bug#8664.
2250 * frame.c (Fmouse_position, Fmouse_pixel_position):
2251 Use Time, not unsigned long, for user-interface timestamps.
2252 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2253 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2254 * keyboard.h (last_event_timestamp): Likewise.
2255 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2256 * menu.h (xmenu_show): Likewise.
2257 * term.c (term_mouse_position): Likewise.
2258 * termhooks.h (struct input_event.timestamp): Likewise.
2259 (struct terminal.mouse_position_hook): Likewise.
2260 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2261 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2262 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2263 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2265 * menu.h, termhooks.h: Include "systime.h", for Time.
2267 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2268 Don't assume that the difference between two unsigned long values
2269 can fit into an integer. At this point, we know button_down_time
2270 <= event->timestamp, so the difference must be nonnegative, so
2271 there's no need to cast the result if double-click-time is
2272 nonnegative, as it should be; check that it's nonnegative, just in
2273 case. This bug is triggered when events are more than 2**31 ms
2274 apart (about 25 days). (Bug#8664)
2276 * xselect.c (last_event_timestamp): Remove duplicate decl.
2277 (x_own_selection): Remove needless cast to unsigned long.
2279 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2280 that always fit in int. Use a sentinel instead of a counter, to
2281 avoid a temp and to allay GCC's concerns about possible int overflow.
2282 * frame.h (struct frame): Use int for menu_bar_items_used
2283 instead of EMACS_INT, since it always fits in int.
2285 * menu.c (grow_menu_items): Check for int overflow.
2287 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2289 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2290 Before, the code was not consistent. These values cannot exceed
2291 2**31 - 1 so there's no need to make them unsigned.
2292 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2293 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2294 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2296 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2298 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2299 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2300 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2301 presumably because the widths might not match.
2303 * window.c (size_window): Avoid needless test at loop start.
2305 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2307 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2309 2011-05-12 Drew Adams <drew.adams@oracle.com>
2311 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2313 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2315 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2316 `width' to `bar_area_x' and `bar_area_width', respectively.
2317 (x_scroll_run): Take account of fringe background extension.
2319 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2320 Rename local vars `left' and `width' to `bar_area_x' and
2321 `bar_area_width', respectively.
2322 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2323 background extension.
2325 2011-05-10 Jim Meyering <meyering@redhat.com>
2327 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2329 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2331 * image.c (Finit_image_library): Return t for built-in image types,
2332 like pbm and xbm. (Bug#8640)
2334 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2336 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2338 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2340 * w32console.c (Fset_screen_color): Doc fix.
2341 (Fget_screen_color): New function.
2342 (syms_of_ntterm): Defsubr it.
2344 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2345 unlink the temporary file if Fcall_process didn't create it in the
2347 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2348 child process will be redirected to a file specified with `:file'.
2349 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2350 cue to call_process_cleanup not to close that handle.
2352 2011-05-07 Ben Key <bkey76@gmail.com>
2354 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2355 one of two shell specific rules, either bootstrap-temacs-CMD or
2356 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2357 to the previous implementation of the bootstrap-temacs rule.
2358 The bootstrap-temacs-CMD rule is similar to the previous
2359 implementation of the bootstrap-temacs rule except that it
2360 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2363 These changes, along with some changes to nt/configure.bat,
2364 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2365 earlier fix to add support for --cflags and --ldflags options
2366 that include quotes so that it works whether make uses cmd or
2369 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2371 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2372 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2374 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2375 a string. Handle both cases.
2376 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2377 (Fdbus_register_method): Use Qinvalid_function.
2379 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2381 * makefile.w32-in: Update dependencies.
2382 (LISP_H): Add inttypes.h and stdin.h.
2383 (PROCESS_H): Add unistd.h.
2385 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2387 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2388 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2390 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2392 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2394 * term.c (vfatal): Remove stray call to va_end.
2395 It's not needed and the C Standard doesn't allow it here anyway.
2397 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2398 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2400 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2403 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2405 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2407 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2409 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2411 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2413 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2414 * charset.c (Fdefine_charset_internal): Don't initialize
2415 charset.code_space[15]. The value was garbage, on hosts with
2416 32-bit int (Bug#8600).
2418 * lread.c (read_integer): Be more consistent with string-to-number.
2419 Use string_to_number to do the actual conversion; this avoids
2420 rounding errors and fixes some other screwups. Without this fix,
2421 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2422 (digit_to_number): Move earlier, for benefit of read_integer.
2423 Return -1 if the digit is out of range for the base, -2 if it is
2424 not a digit in any supported base. (Bug#8602)
2426 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2428 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2429 to match comment at start of function. This also removes a
2430 GCC warning about overflow in a 32+64-bit port.
2432 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2434 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2435 Reported by Stefan Monnier in
2436 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2437 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2438 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2440 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2441 (EMACS_UINTPTR): Likewise, with uintptr_t.
2443 * lisp.h: Prefer 64-bit EMACS_INT if available.
2444 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2445 on 32-bit hosts that have 64-bit int, so that they can access
2447 However, temporarily disable this change unless the temporary
2448 symbol WIDE_EMACS_INT is defined.
2450 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2452 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2453 This removes an assumption that EMACS_INT and long are the same
2454 width as pointers. The assumption is true for Emacs porting targets
2455 now, but we want to make other targets possible.
2456 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2457 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2458 In the rest of the code, change types of integers that hold casted
2459 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2460 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2461 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2462 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2463 No need to cast type when ORing.
2464 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2465 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2466 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2467 assume EMACS_INT is the same width as char *.
2468 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2469 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2470 Remove no-longer-needed casts.
2471 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2472 (xg_tool_bar_help_callback, xg_make_tool_item):
2473 Use EMACS_INTPTR to hold an integer
2474 that will be cast to void *; this can avoid a GCC warning
2475 if EMACS_INT is not the same width as void *.
2476 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2477 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2478 (current_message_1, set_message_1):
2479 Use a local to convert to proper width without a cast.
2480 * xmenu.c (dialog_selection_callback): Likewise.
2482 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2483 Also, don't assume VALBITS / RAND_BITS is less than 5,
2484 and don't rely on undefined behavior when shifting a 1 left into
2486 * lisp.h (get_random): Change signature to match.
2488 * lread.c (hash_string): Use size_t, not int, for hash computation.
2489 Normally we prefer signed values; but hashing is special, because
2490 it's better to use unsigned division on hash table sizes so that
2491 the remainder is nonnegative. Also, size_t is the natural width
2492 for hashing into memory. The previous code used 'int', which doesn't
2493 retain enough info to hash well into very large tables.
2494 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2496 * dbusbind.c: Don't possibly lose pointer info when converting.
2497 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2498 Use XPNTR rather than XHASH, so that the high-order bits of
2499 the pointer aren't lost when converting through void *.
2501 * eval.c (Fautoload): Don't double-shift a pointer.
2503 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2505 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2507 * gnutls.c (DEF_GNUTLS_FN):
2508 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2510 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2512 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2515 2011-05-05 Eli Zaretskii <eliz@gnu.org>
2517 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2518 New version that can reserve upto 2GB of heap space.
2520 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
2522 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2524 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2526 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2527 `gnutls_certificate_set_x509_key_file'.
2529 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
2531 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2532 Update dependencies.
2534 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2536 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2537 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2538 Remove unused parameter `fildes'.
2539 * process.c (read_process_output, send_process): Don't pass it.
2541 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2543 Fix previous change: the library cache is defined in w32.c.
2544 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2545 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2547 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
2549 Implement dynamic loading of GnuTLS on Windows.
2551 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2552 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2553 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2556 * gnutls.c (Qgnutls_dll): Define.
2557 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2558 (gnutls_*): Declare function pointers.
2559 (init_gnutls_functions): New function to initialize function pointers.
2560 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2561 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2562 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2563 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2564 (emacs_gnutls_write, emacs_gnutls_read)
2565 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2566 (Fgnutls_available_p): New function.
2567 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2568 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2569 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2571 * image.c: Include w32.h.
2572 (Vimage_type_cache): Delete.
2573 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2574 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2575 (w32_delayed_load): Move to w32.c.
2577 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2579 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2580 (w32_delayed_load): Move from image.c. When loading a library, record
2581 its filename in the :loaded-from property of the library id.
2582 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2583 Initialize and staticpro them.
2584 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2586 * process.c: Include lisp.h before w32.h, not after.
2587 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2588 instead of gnutls_record_check_pending.
2590 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2592 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2594 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2595 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2598 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2600 * xterm.c (x_set_frame_alpha): Do not set property on anything
2601 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2603 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2605 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2607 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
2609 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2610 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2611 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2612 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2613 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2614 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2615 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2616 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2617 (Qgnutls_bootprop_callbacks_verify): Make static.
2619 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2621 * callproc.c: Indentation fixup.
2623 * sysdep.c (wait_for_termination_1): Make static.
2624 (wait_for_termination, interruptible_wait_for_termination):
2625 Move after wait_for_termination_1.
2627 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2629 * sysdep.c (interruptible_wait_for_termination): New function
2630 which is like wait_for_termination, but allows keyboard
2633 * callproc.c (Fcall_process): Add (:file "file") as an option for
2635 (Fcall_process_region): Ditto.
2637 2011-04-30 Eli Zaretskii <eliz@gnu.org>
2639 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2640 rather than `XVECTOR (FOO)->size'.
2642 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2643 inttypes.h, as a gnulib replacement is used if it not available in
2646 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2648 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2649 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2650 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2652 * coding.c (coding_alloc_by_realloc): Error out if destination
2653 will grow beyond MOST_POSITIVE_FIXNUM.
2654 (decode_coding_emacs_mule): Abort if there isn't enough place in
2655 charbuf for the composition carryover bytes. Reserve an extra
2656 space for up to 2 characters produced in a loop.
2657 (decode_coding_iso_2022): Abort if there isn't enough place in
2658 charbuf for the composition carryover bytes.
2660 2011-04-21 Eli Zaretskii <eliz@gnu.org>
2662 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2663 aborting when %lld or %lll format is passed.
2664 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2665 %llo or %llx format is passed. (Bug#8545)
2667 * window.c (window_scroll_line_based): Use a marker instead of
2668 simple variables to record original value of point. (Bug#7952)
2670 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2671 produced by %s or %c overflows available buffer space. (Bug#8545)
2673 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2675 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
2676 (SIZE_MAX): Move defn after all includes, as they might #define it.
2678 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2680 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2682 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2684 * keyboard.c (Qdelayed_warnings_hook): Define.
2685 (command_loop_1): Run `delayed-warnings-hook'
2686 if Vdelayed_warnings_list is non-nil.
2687 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2688 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2690 2011-04-28 Eli Zaretskii <eliz@gnu.org>
2692 * doprnt.c (doprnt): Don't return value smaller than the buffer
2693 size if the message was truncated. (Bug#8545).
2695 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2697 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2698 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2700 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2702 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2704 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
2706 * makefile.w32-in: Update dependencies.
2708 2011-04-27 Eli Zaretskii <eliz@gnu.org>
2710 Improve `doprnt' and its usage. (Bug#8545)
2711 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2712 `format_end'. Remove support for %l as a conversion specifier.
2713 Don't use xrealloc. Improve diagnostics when the %l size modifier
2714 is used. Update the commentary.
2716 * eval.c (verror): Simplify calculation of size_t.
2718 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2721 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2723 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2726 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2728 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2729 This makes this file independent of the recent pseudovector change.
2731 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
2733 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2735 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
2736 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
2737 Remove unused local.
2738 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
2740 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
2741 GCC 4.6.0 optimizes based on type-based alias analysis.
2742 For example, if b is of type struct buffer * and v of type struct
2743 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2744 != &v->size, and therefore "v->size = 1; b->size = 2; return
2745 v->size;" must therefore return 1. This assumption is incorrect
2746 for Emacs, since it type-puns struct Lisp_Vector * with many other
2747 types. To fix this problem, this patch adds a new type struct
2748 vectorlike_header that documents the constraints on layout of vectors
2749 and pseudovectors, and helps optimizing compilers not get fooled
2750 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2751 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
2752 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2754 (XSETPVECTYPE): Rewrite in terms of new macro.
2755 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2756 This is a bit clearer, and further avoids the possibility of
2757 undesirable aliasing.
2758 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
2759 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
2760 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2761 since Lisp_Subr is a special case (no "next" field).
2762 (ASIZE): Now uses header.size rather than size.
2763 All previous uses of XVECTOR (foo)->size replaced to use this macro,
2764 to avoid the hassle of writing XVECTOR (foo)->header.size.
2765 (struct vectorlike_header): New type.
2766 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2767 object, to help avoid aliasing.
2768 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2769 (SUBRP): Likewise, since Lisp_Subr is a special case.
2770 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2771 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2772 (struct Lisp_Hash_Table): Combine first two members into a single
2773 struct vectorlike_header member. All uses of "size" and "next" members
2774 changed to be "header.size" and "header.next".
2775 * buffer.h (struct buffer): Likewise.
2776 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2777 * frame.h (struct frame): Likewise.
2778 * process.h (struct Lisp_Process): Likewise.
2779 * termhooks.h (struct terminal): Likewise.
2780 * window.c (struct save_window_data, struct saved_window): Likewise.
2781 * window.h (struct window): Likewise.
2782 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2783 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2784 * buffer.c (init_buffer_once): Likewise.
2785 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2787 * process.c (Fformat_network_address): Use local var for size,
2790 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2792 Make the Lisp reader and string-to-float more consistent (Bug#8525)
2793 * data.c (atof): Remove decl; no longer used or needed.
2794 (digit_to_number): Move to lread.c.
2795 (Fstring_to_number): Use new string_to_number function, to be
2796 consistent with how the Lisp reader treats infinities and NaNs.
2797 Do not assume that floating-point numbers represent EMACS_INT
2798 without losing information; this is not true on most 64-bit hosts.
2799 Avoid double-rounding errors, by insisting on integers when
2800 parsing non-base-10 numbers, as the documentation specifies.
2801 * lisp.h (string_to_number): New decl, replacing ...
2802 (isfloat_string): Remove.
2803 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
2804 (read1): Do not accept +. and -. as integers; this
2805 appears to have been a coding error. Similarly, do not accept
2806 strings like +-1e0 as floating point numbers. Do not report
2807 overflow for integer overflows unless the base is not 10 which
2808 means we have no simple and reliable way to continue.
2809 Break out the floating-point parsing into a new
2810 function string_to_number, so that Fstring_to_number parses
2811 floating point numbers consistently with the Lisp reader.
2812 (digit_to_number): Move here from data.c. Make it static inline.
2813 (E_CHAR, EXP_INT): Remove, replacing with ...
2814 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2815 (string_to_number): New function, replacing isfloat_string.
2816 This function checks for valid syntax and produces the resulting
2817 Lisp float number too. Rework it so that string-to-number
2818 no longer mishandles examples like "1.0e+". Use strtoumax,
2819 so that overflow for non-base-10 numbers is reported only when
2820 there's no portable and simple way to convert to floating point.
2822 * textprop.c (set_text_properties_1): Rewrite for clarity,
2823 and to avoid GCC warning about integer overflow.
2825 * intervals.h (struct interval): Use EMACS_INT for members
2826 where EMACS_UINT might cause problems. See
2827 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2828 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2829 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2831 (offset_intervals): Tell GCC not to worry about length overflow
2832 when negating a negative length.
2834 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2835 (overrun_check_free): Likewise.
2837 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2838 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2841 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2842 (gnutls_make_error): Rename local to avoid shadowing.
2843 (gnutls_emacs_global_deinit): ifdef out; not used.
2844 (Fgnutls_boot): Use const for pointer to readonly storage.
2845 Comment out unused local. Fix pointer signedness problems.
2847 * lread.c (openp): Don't stuff size_t into an 'int'.
2848 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2849 about possible signed overflow.
2851 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2852 (GDK_KEY_g): Don't define if already defined.
2853 (xg_prepare_tooltip): Avoid pointer signedness problem.
2854 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2856 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2857 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2859 * xfns.c (Fx_window_property): Simplify a bit,
2860 to make a bit faster and to avoid GCC 4.6.0 warning.
2861 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2863 * fns.c (internal_equal): Don't assume size_t fits in int.
2865 * alloc.c (compact_small_strings): Tighten assertion a little.
2867 Replace pEd with more-general pI, and fix some printf arg casts.
2868 * lisp.h (pI): New macro, generalizing old pEd macro to other
2869 conversion specifiers. For example, use "...%"pI"d..." rather
2870 than "...%"pEd"...".
2871 (pEd): Remove. All uses replaced with similar uses of pI.
2872 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2873 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2874 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2875 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2876 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2877 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2878 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2880 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2881 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2882 * print.c (safe_debug_print, print_object): Likewise.
2883 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2885 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2886 avoiding the 0 flag, which is not portable.
2887 * process.c (Fmake_network_process): Use pI to avoid cast.
2888 * region-cache.c (pp_cache): Likewise.
2889 * xdisp.c (decode_mode_spec): Likewise.
2890 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2891 behavior on 64-bit hosts with printf arg.
2892 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2893 (x_stop_queuing_selection_requests): Likewise.
2894 (x_get_window_property): Don't truncate byte count to an 'int'
2897 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2898 here, since it parses constructs like leading '-' and spaces,
2899 which are not wanted; and it overflows with large numbers.
2900 Instead, simply match F[0-9]+, which is what is wanted anyway.
2902 * alloc.c: Remove unportable assumptions about struct layout.
2903 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2904 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2905 (allocate_vectorlike, make_pure_vector): Use the new macros,
2906 plus offsetof, to remove unportable assumptions about struct layout.
2907 These assumptions hold on all porting targets that I know of, but
2908 they are not guaranteed, they're easy to remove, and removing them
2909 makes further changes easier.
2911 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2912 This doesn't fix a bug but makes the code clearer.
2913 (string_overrun_cookie): Now const. Use initializers that
2914 don't formally overflow signed char, to avoid warnings.
2915 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2916 can cause Emacs to crash when string overrun checking is enabled.
2917 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2918 multiple of sizeof (EMACS_INT); it need not be, if
2919 alignof(EMACS_INT) < sizeof (EMACS_INT).
2920 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2922 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2924 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2926 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2928 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2929 supposed to be handshaking. (Bug#8556)
2930 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2932 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2934 * lisp.h (Qdebug): List symbol.
2935 * eval.c (Qdebug): Restore global linkage.
2936 * keyboard.c (debug-on-event): New variable.
2937 (handle_user_signal): Break into debugger when debug-on-event
2938 matches the current signal symbol.
2940 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2942 * alloc.c (check_sblock, check_string_bytes)
2943 (check_string_free_list): Convert to standard C.
2945 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2947 * w32.c (emacs_gnutls_push): Fix typo.
2949 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2951 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2952 "cast to pointer from integer of different size".
2954 Improve doprnt and its use in verror. (Bug#8545)
2955 * doprnt.c (doprnt): Document the set of format control sequences
2956 supported by the function. Use SAFE_ALLOCA instead of always
2959 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2960 is one byte too soon. Don't use xrealloc; instead xfree and
2963 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2965 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2968 * gnutls.c: Renamed global_initialized to
2969 gnutls_global_initialized. Added internals for the
2970 :verify-hostname-error, :verify-error, and :verify-flags
2971 parameters of `gnutls-boot' and documented those parameters in the
2972 docstring. Start callback support.
2973 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2974 unless a fatal error occurred. Call gnutls_alert_send_appropriate
2975 on error. Return error code.
2976 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2977 (emacs_gnutls_read): Likewise.
2978 (Fgnutls_boot): Return handshake error code.
2979 (emacs_gnutls_handle_error): New function.
2980 (wsaerror_to_errno): Likewise.
2982 * w32.h (emacs_gnutls_pull): Add prototype.
2983 (emacs_gnutls_push): Likewise.
2985 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2986 (emacs_gnutls_push): Likewise.
2988 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2990 * process.c (wait_reading_process_output): Check if GnuTLS
2991 buffered some data internally if no FDs are set for TLS
2994 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2995 (LIBS): Link to USER_LIBS.
2996 ($(BLD)/gnutls.$(0)): New target.
2998 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3000 * xdisp.c (handle_single_display_spec): Rename the
3001 display_replaced_before_p argument into display_replaced_p, to
3002 make it consistent with the commentary. Fix typos in the
3005 * textprop.c (syms_of_textprop): Remove dead code.
3006 (copy_text_properties): Delete obsolete commentary about an
3007 interface that was deleted long ago. Fix typos in the description
3010 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3011 to changes in oldXMenu/XMenu.h from 2011-04-16.
3012 <menu_help_message, prev_menu_help_message>: Constify.
3013 (IT_menu_make_room): menu->help_text is now `const char **';
3016 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3017 to changes in oldXMenu/XMenu.h from 2011-04-16.
3018 (struct XMenu): Declare `help_text' `const char **'.
3020 * xfaces.c <Qunspecified>: Make extern again.
3022 * syntax.c: Include sys/types.h before including regex.h, as
3025 * doc.c (get_doc_string): Improve the format passed to `error'.
3027 * doprnt.c (doprnt): Improve commentary.
3029 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3031 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3034 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3035 changes in globals.h immediately force recompilation.
3036 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3037 $(CURDIR)/s/ms-w32.h.
3038 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3040 * character.c (Fchar_direction): Function deleted.
3041 (syms_of_character): Don't defsubr it.
3042 <char-direction-table>: Deleted.
3044 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3046 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3047 * doprnt.c: Include limits.h.
3048 (SIZE_MAX): New macro.
3049 (doprnt): Return a size_t value. 2nd arg is now size_t.
3050 Many local variables are now size_t instead of int or unsigned.
3051 Improve overflow protection. Support `l' modifier for integer
3052 conversions. Support %l conversion. Don't assume an EMACS_INT
3053 argument for integer conversions and for %c.
3055 * lisp.h (doprnt): Restore prototype.
3057 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3060 * Makefile.in (base_obj): Add back doprnt.o.
3062 * deps.mk (doprnt.o): Add back prerequisites.
3063 (callint.o): Depend on character.h.
3065 * eval.c (internal_lisp_condition_case): Include the handler
3066 representation in the error message.
3067 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3068 when breaking from the loop.
3070 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3072 * callint.c (Fcall_interactively): When displaying error message
3073 about invalid control letter, pass the character's codepoint, not
3074 a pointer to its multibyte form. Improve display of the character
3075 in octal and display also its hex code.
3077 * character.c (char_string): Use %x to display the (unsigned)
3078 codepoint of an invalid character, to avoid displaying a bogus
3081 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3082 `error', not SYMBOL_NAME itself.
3084 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3085 character arguments to `error'.
3087 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3088 to `error' in error message about FINAL_CHAR argument. Make sure
3089 FINAL_CHAR is a character, and use %c when it is passed as
3090 argument to `error'.
3092 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3094 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3096 * w32.c: Include <time.h>.
3097 (sys_localtime): New function.
3099 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3101 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3103 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3105 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3107 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3110 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3112 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3113 gl_state.e_property when gl_state.object is Qt.
3115 * insdel.c (make_gap_larger): Remove limitation of buffer size
3118 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3120 * xdisp.c (lookup_glyphless_char_display)
3121 (produce_glyphless_glyph): Handle cons cell entry in
3122 glyphless-char-display.
3123 (Vglyphless_char_display): Document it.
3125 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3126 glyphless-char-display.
3128 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3130 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3132 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3134 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3135 definition for no-X builds.
3137 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3139 Static checks with GCC 4.6.0 and non-default toolkits.
3141 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3143 * process.c (keyboard_bit_set): Define only if SIGIO.
3144 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3145 (send_process): Repair possible setjmp clobbering.
3147 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3149 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3151 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3153 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3154 Define only if needed.
3156 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3157 by pacifying GCC about it. Maybe it's time to retire it?
3158 * xfaces.c (USG, __TIMEVAL__): Likewise.
3160 * dispextern.h (struct redisplay_interface): Rename param
3162 * termhooks.h (struct terminal): Likewise.
3163 * xterm.c (xembed_send_message): Likewise.
3165 * insdel.c (make_gap_smaller): Define only if
3166 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3168 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3171 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3172 so that we aren't warned about unused symbols.
3174 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3176 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3178 * xfns.c (x_real_positions): Mark locals as initialized.
3180 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3182 * xterm.c: Fix problems found by static analysis with other toolkits.
3183 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3184 (x_dispatch_event): Declare static if USE_GTK, and
3185 define if USE_GTK || USE_X_TOOLKIT.
3186 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3187 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3188 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3189 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3191 * xmenu.c (menu_help_callback): Pointer type fixes.
3192 Use const pointers when pointing at readonly data. Avoid pointer
3194 (FALSE): Remove unused macro.
3195 (update_frame_menubar): Remove unused decl.
3197 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3199 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3200 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3201 (single_menu_item): Rename local to avoid shadowing.
3203 * keyboard.c (make_lispy_event): Remove unused local var.
3205 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3206 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3208 * bitmaps: Change bitmaps from unsigned char back to the X11
3209 compatible char. Avoid the old compiler warnings about
3210 out-of-range initializers by using, for example, '\xab' rather
3213 * xgselect.c (xgselect_initialize): Check vs interface
3214 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3216 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3218 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3219 to read-only memory.
3221 * fns.c (vector): Remove; this old hack is no longer needed.
3223 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3225 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3227 * xrdb.c (x_load_resources): Omit unused local.
3229 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3230 (x_window): Rename locals to avoid shadowing.
3231 (USG): Use the kludged USG macro, to pacify gcc.
3233 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3234 (x_term_init): Remove local to avoid shadowing.
3236 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3238 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3239 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3241 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3243 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3245 Fix regex.c, syntax.c and friends for buffers > 2GB.
3246 * syntax.h (struct gl_state_s): Declare character position members
3249 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3251 * textprop.c (verify_interval_modification, interval_of):
3252 Declare arguments EMACS_INT.
3254 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3257 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3259 * indent.c (Fvertical_motion): Local variable it_start is now
3262 * regex.c (re_match, re_match_2, re_match_2_internal)
3263 (bcmp_translate, regcomp, regexec, print_double_string)
3264 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3265 (re_compile_pattern, re_exec): Declare arguments and local
3266 variables `size_t' and `ssize_t' and return values `regoff_t', as
3268 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3269 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3270 <compile_stack_type>: `size' and `avail' are now `size_t'.
3272 * regex.h <regoff_t>: Use ssize_t, not int.
3273 (re_search, re_search_2, re_match, re_match_2): Arguments that
3274 specify buffer/string position and length are now ssize_t and
3275 size_t. Return type is regoff_t.
3277 2011-04-16 Ben Key <bkey76@gmail.com>
3279 * nsfont.m: Fixed bugs in ns_get_family and
3280 ns_descriptor_to_entity that were caused by using free to
3281 deallocate memory blocks that were allocated by xmalloc (via
3282 xstrdup). This caused Emacs to crash when compiled with
3283 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3284 --enable-checking=xmallocoverrun). xfree is now used to
3285 deallocate these memory blocks.
3287 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3289 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3291 emacs_write: Accept and return EMACS_INT for sizes.
3292 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3294 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3295 Accept and return EMACS_INT.
3296 (emacs_gnutls_write): Return the number of bytes written on
3298 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3299 (emacs_read, emacs_write): Remove check for negative size, as the
3300 Emacs source code has been audited now.
3301 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3302 (emacs_read, emacs_write): Use it.
3303 * process.c (send_process): Adjust to the new signatures of
3304 emacs_write and emacs_gnutls_write. Do not attempt to store
3305 a byte offset into an 'int'; it might overflow.
3306 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3308 * sound.c: Don't assume sizes fit in 'int'.
3309 (struct sound_device.period_size, alsa_period_size):
3310 Return EMACS_INT, not int.
3311 (struct sound_device.write, vox_write, alsa_write):
3312 Accept EMACS_INT, not int.
3313 (wav_play, au_play): Use EMACS_INT to store sizes and to
3314 record read return values.
3316 2011-04-15 Ben Key <bkey76@gmail.com>
3318 * keyboard.c (Qundefined): Don't declare static since it is used
3320 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3321 static since they are used in nsfont.m.
3323 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3325 * process.c (Qprocessp): Don't declare static.
3326 * lisp.h (Qprocessp): Declare again.
3328 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3330 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3332 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3334 Improve C-level modularity by making more things 'static'.
3336 Don't publish debugger-only interfaces to other modules.
3337 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3338 (verify_bytepos, count_markers): Move decls to the only modules
3340 * region-cache.h (pp_cache): Likewise.
3341 * window.h (check_all_windows): Likewise.
3342 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3344 * sysdep.c (croak): Now static, if
3345 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3346 * syssignal.h (croak): Declare only if not static.
3348 * alloc.c (refill_memory_reserve): Now static if
3349 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3350 * lisp.h (refill_memory_reserve): Declare only if not static.
3352 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3353 Define only if USE_LUCID.
3355 * xrdb.c (x_customization_string, x_rm_string): Now static.
3357 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3358 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3360 * xdisp.c (draw_row_with_mouse_face): Now static.
3361 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3363 * window.h (check_all_windows): Mark externally visible.
3365 * window.c (window_deletion_count): Now static.
3367 * undo.c: Make symbols static if they're not exported.
3368 (last_undo_buffer, last_boundary_position, pending_boundary):
3371 * textprop.c (interval_insert_behind_hooks): Now static.
3372 (interval_insert_in_front_hooks): Likewise.
3374 * term.c: Make symbols static if they're not exported.
3375 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3376 (max_frame_lines, tty_set_terminal_modes):
3377 (tty_reset_terminal_modes, tty_turn_off_highlight):
3378 (get_tty_terminal): Now static.
3379 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3380 * termhooks.h (term_mouse_moveto): Do not declare if
3382 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3383 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3385 * sysdep.c: Make symbols static if they're not exported.
3386 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3388 (sigprocmask_set, full_mask): Remove; unused.
3389 (wait_debugging): Mark as visible.
3390 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3391 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3393 * syntax.c (syntax_temp): Define only if !__GNUC__.
3395 * sound.c (current_sound_device, current_sound): Now static.
3397 * search.c (searchbufs, searchbuf_head): Now static.
3399 * scroll.c (scroll_cost): Remove; unused.
3400 * dispextern.h (scroll_cost): Remove decl.
3402 * region-cache.h (pp_cache): Mark as externally visible.
3404 * process.c: Make symbols static if they're not exported.
3405 (process_tick, update_tick, create_process, chan_process):
3406 (Vprocess_alist, proc_buffered_char, datagram_access):
3407 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3408 (deactivate_process): Mark defn as static, as well as decl.
3409 * lisp.h (create_process): Remove decl.
3410 * process.h (chan_process, Vprocess_alist): Remove decls.
3412 * print.c: Make symbols static if they're not exported.
3413 (print_depth, new_backquote_output, being_printed, print_buffer):
3414 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3415 (print_interval, print_number_index, initial_stderr_stream):
3417 * lisp.h (Fprinc): Remove decl.
3418 (debug_output_compilation_hack): Mark as externally visible.
3420 * sysdep.c (croak): Move decl from here to syssignal.h.
3421 * syssignal.h (croak): Put it here, so the API can be checked when
3422 'croak' is called from dissociate_if_controlling_tty.
3424 * minibuf.c: Make symbols static if they're not exported.
3425 (minibuf_save_list, choose_minibuf_frame): Now static.
3426 * lisp.h (choose_minibuf_frame): Remove decl.
3428 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3430 * lread.c: Make symbols static if they're not exported.
3431 (read_objects, initial_obarray, oblookup_last_bucket_number):
3433 (make_symbol): Remove; unused.
3434 * lisp.h (initial_obarray, make_symbol): Remove decls.
3436 * keyboard.c: Make symbols static if they're not exported.
3437 (single_kboard, recent_keys_index, total_keys, recent_keys):
3438 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3439 (this_single_command_key_start, echoing, last_auto_save):
3440 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3441 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3442 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3443 (Vlispy_mouse_stem, double_click_count):
3445 (force_auto_save_soon): Define only if SIGDANGER.
3446 (ignore_mouse_drag_p): Now static if
3447 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3448 (print_help): Remove; unused.
3449 (stop_character, last_timer_event): Mark as externally visible.
3450 * keyboard.h (ignore_mouse_drag_p): Declare only if
3451 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3452 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3453 * lisp.h (echoing): Remove decl.
3454 (force_auto_save_soon): Declare only if SIGDANGER.
3455 * xdisp.c (redisplay_window): Simplify code, to make it more
3456 obvious that ignore_mouse_drag_p is not accessed if !defined
3457 USE_GTK && !defined HAVE_NS.
3459 * intervals.c: Make symbols static if they're not exported.
3460 (merge_properties_sticky, merge_interval_right, delete_interval):
3462 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3464 * insdel.c: Make symbols static if they're not exported.
3465 However, leave prepare_to_modify_buffer alone. It's never
3466 called from outside this function, but that appears to be a bug.
3467 (combine_after_change_list, combine_after_change_buffer):
3468 (adjust_after_replace, signal_before_change): Now static.
3469 (adjust_after_replace_noundo): Remove; unused.
3470 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
3471 (signal_before_change): Remove decls.
3473 * indent.c (val_compute_motion, val_vmotion): Now static.
3475 * image.c: Make symbols static if they're not exported.
3476 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3478 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3479 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3481 * fringe.c (standard_bitmaps): Now static.
3482 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3484 * frame.c: Make symbols static if they're not exported.
3485 (x_report_frame_params, make_terminal_frame): Now static.
3486 (get_frame_param): Now static, unless HAVE_NS.
3487 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3488 (x_get_resource_string): Remove; not used.
3489 * frame.h (make_terminal_frame, x_report_frame_params):
3490 (x_get_resource_string); Remove decls.
3491 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3492 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3494 * font.c, fontset.c: Make symbols static if they're not exported.
3495 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3496 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3497 * font.c (font_close_object): Now static.
3498 * font.h (font_close_object): Remove.
3499 * fontset.c (FONTSET_OBJLIST): Remove.
3500 (free_realized_fontset) #if-0 the body, which does nothing.
3501 (face_suitable_for_char_p): #if-0, as it's never called.
3502 * fontset.h (face_suitable_for_char_p): Remove decl.
3503 * xfaces.c (face_at_string_position):
3504 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
3505 since 0 is always ASCII.
3507 * fns.c (weak_hash_tables): Now static.
3509 * fileio.c: Make symbols static if they're not exported.
3510 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3511 (Vwrite_region_annotation_buffers): Now static.
3513 * eval.c: Make symbols static if they're not exported.
3514 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3515 * lisp.h (backtrace_list): Remove decl.
3517 * emacs.c: Make symbols static if they're not exported.
3518 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3519 (fatal_error_code, fatal_error_signal_hook, standard_args):
3521 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3522 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3523 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3524 * lisp.h (fatal_error_signal_hook): Remove decl.
3525 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3527 * editfns.c: Move a (normally-unused) function to its only use.
3528 * editfns.c, lisp.h (get_operating_system_release): Remove.
3529 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3530 worth the hassle of breaking this out.
3532 * xterm.c: Make symbols static if they're not exported.
3533 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3534 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3535 (x_destroy_window, x_delete_display):
3537 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3538 (x_mouse_leave): Remove; unused.
3539 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3540 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3541 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3543 (x_mouse_leave): Declare only if WINDOWSNT.
3544 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3545 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3548 * ftxfont.c: Make symbols static if they're not exported.
3549 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3551 * font.h (ftxfont_driver): Likewise.
3553 * xfns.c: Make symbols static if they're not exported.
3554 (x_last_font_name, x_display_info_for_name):
3555 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3556 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3557 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3558 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3559 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3560 (last_show_tip_args): Now static.
3561 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3562 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3563 (x_screen_planes): Remove; unused.
3564 * dispextern.h (x_screen_planes): Remove decl.
3566 * dispnew.c: Make symbols static if they're not exported.
3567 * dispextern.h (redraw_garbaged_frames, scrolling):
3568 (increment_row_positions): Remove.
3569 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3570 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3572 (redraw_garbaged_frames): Remove; unused.
3574 * xfaces.c: Make symbols static if they're not exported.
3575 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3577 * xterm.h (defined_color): Remove decls.
3578 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3579 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3580 (menu_face_changed_default, defined_color, free_realized_face):
3581 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3582 (ascii_face_of_lisp_face): Remove; unused.
3584 * xdisp.c: Make symbols static if they're not exported.
3585 * dispextern.h (scratch_glyph_row, window_box_edges):
3586 (glyph_to_pixel_coords, set_cursor_from_row):
3587 (get_next_display_element, set_iterator_to_next):
3588 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3589 (show_mouse_face): Remove decls
3590 * frame.h (message_buf_print): Likewise.
3591 * lisp.h (pop_message, set_message, check_point_in_composition):
3593 * xterm.h (set_vertical_scroll_bar): Likewise.
3594 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3595 (message_buf_print, scratch_glyph_row, displayed_buffer):
3596 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3597 (get_next_display_element, show_mouse_face, window_box_edges):
3598 (frame_to_window_pixel_xy, check_point_in_composition):
3599 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3600 (glyph_to_pixel_coords): Remove; unused.
3602 * dired.c (file_name_completion): Now static.
3604 * dbusbind.c (xd_in_read_queued_messages): Now static.
3606 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3607 * data.c (circular_list_error): Remove.
3609 * commands.h (last_point_position, last_point_position_buffer):
3610 (last_point_position_window): Remove decls.
3611 * keyboard.c: Make these variables static.
3613 * coding.h (coding, code_convert_region, encode_coding_gap):
3615 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3616 (iso_code_class, detect_coding, code_convert_region): Now static.
3617 (encode_coding_gap): Remove; unused.
3619 * chartab.c (chartab_chars, chartab_bits): Now static.
3621 * charset.h (charset_iso_8859_1): Remove decl.
3622 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3625 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3626 * ccl.c (Vccl_program_table): Now static.
3627 (check_ccl_update): Remove; unused.
3629 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3630 * category.h: ... from here.
3631 * category.c (check_category_table, set_category_set): Now static.
3633 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3634 * lisp.h: Remove these decls.
3636 * buffer.c (buffer_count): Remove unused var.
3638 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3639 so that it's not optimized away.
3640 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3641 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3642 exported only to the debugger.
3644 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
3645 * atimer.h (run_all_atimers): Remove; not exported.
3647 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3648 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3649 was inaccessible from Lisp.
3650 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3651 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3653 alloc.c: Import and export fewer symbols, and remove unused items.
3654 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3656 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3657 it's not optimized away by whole-program optimization.
3658 (message_enable_multibyte, free_misc): Remove.
3659 (catchlist, handlerlist, mark_backtrace):
3660 Declare only if BYTE_MARK_STACK.
3661 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3662 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3663 (message_enable_multibyte): Remove decl.
3664 (free_misc, interval_free_list, float_block, float_block_index):
3665 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3666 (cons_free_list, last_marked_index):
3668 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3669 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3670 (mark_backtrace): Define only if BYTE_MARK_STACK.
3671 * xdisp.c (message_enable_multibyte): Now static.
3673 Declare Lisp_Object Q* variables to be 'static' if not exported.
3674 This makes it easier for human readers (and static analyzers)
3675 to see whether these variables are used from other modules.
3676 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3677 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3678 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3679 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3680 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3681 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3682 * xmenu.c, xselect.c:
3683 Declare Q* vars static if they are not used in other modules.
3684 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3685 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3686 Remove decls of unexported vars.
3687 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3689 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3691 Make Emacs functions such as Fatom 'static' by default.
3692 This makes it easier for human readers (and static analyzers)
3693 to see whether these functions can be called from other modules.
3694 DEFUN now defines a static function. To make the function external
3695 so that it can be used in other C modules, use the new macro DEFUE.
3696 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3697 (Finit_image_library):
3698 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3699 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3700 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3701 Remove decls, since these functions are now static.
3702 (Funintern, Fget_internal_run_time): New decls, since these functions
3703 were already external.
3705 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3706 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3707 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3708 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3709 * keyboard.c, keymap.c, lread.c:
3710 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3711 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3712 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3713 Mark functions with DEFUE instead of DEFUN,
3714 if they are used in other modules.
3715 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3716 decls for now-static functions.
3717 * buffer.h (Fdelete_overlay): Remove decl.
3718 * callproc.c (Fgetenv_internal): Mark as internal.
3719 * composite.c (Fremove_list_of_text_properties): Remove decl.
3720 (Fcomposition_get_gstring): New forward static decl.
3721 * composite.h (Fcomposite_get_gstring): Remove decl.
3722 * dired.c (Ffile_attributes): New forward static decl.
3723 * doc.c (Fdocumntation_property): New forward static decl.
3724 * eval.c (Ffetch_bytecode): New forward static decl.
3725 (Funintern): Remove extern decl; now in .h file where it belongs.
3726 * fileio.c (Fmake_symbolic_link): New forward static decl.
3727 * image.c (Finit_image_library): New forward static decl.
3728 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3729 * intervals.h (Fprevious_property_change):
3730 (Fremove_list_of_text_properties): Remove decls.
3731 * keyboard.c (Fthis_command_keys): Remove decl.
3732 (Fcommand_execute): New forward static decl.
3733 * keymap.c (Flookup_key): New forward static decl.
3734 (Fcopy_keymap): Now static.
3735 * keymap.h (Flookup_key): Remove decl.
3736 * process.c (Fget_process): New forward static decl.
3737 (Fprocess_datagram_address): Mark as internal.
3738 * syntax.c (Fsyntax_table_p): New forward static decl.
3739 (skip_chars): Remove duplicate decl.
3740 * textprop.c (Fprevious_property_change): New forward static decl.
3741 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3743 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3744 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3746 * editfns.c (Fformat): Remove unreachable code.
3748 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3750 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3753 2011-04-13 Eli Zaretskii <eliz@gnu.org>
3755 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3756 when at ZV. (Bug#8487)
3758 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3760 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3762 * keyboard.c (parse_tool_bar_item): Likewise.
3763 * sound.c (sound_cleanup, alsa_close): Likewise.
3764 * termcap.c (tgetent): Likewise.
3765 * xfns.c (x_default_font_parameter): Likewise.
3766 * xsettings.c (read_and_apply_settings): Likewise.
3768 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3769 (overrun_check_free): Protoize.
3771 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3773 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3774 since callers should never pass a negative size.
3775 Change the signature to match that of plain 'read' and 'write'; see
3776 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3777 * lisp.h: Update prototypes of emacs_write and emacs_read.
3779 2011-04-11 Eli Zaretskii <eliz@gnu.org>
3781 * xdisp.c (redisplay_window): Don't try to determine the character
3782 position of the scroll margin if the window start point w->startp
3783 is outside the buffer's accessible region. (Bug#8468)
3785 2011-04-10 Eli Zaretskii <eliz@gnu.org>
3787 Fix write-region and its subroutines for buffers > 2GB.
3788 * fileio.c (a_write, e_write): Modify declaration of arguments and
3789 local variables to support buffers larger than 2GB.
3790 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3792 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3793 argument, local variables, and return value.
3795 * lisp.h: Update prototypes of emacs_write and emacs_read.
3797 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3799 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
3801 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3803 Fix more problems found by GCC 4.6.0's static checks.
3805 * xdisp.c (vmessage): Use a better test for character truncation.
3807 * charset.c (load_charset_map): <, not <=, for optimization,
3808 and to avoid potential problems with integer overflow.
3809 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
3810 * casetab.c (set_identity, shuffle): Likewise.
3811 * editfns.c (Fformat): Likewise.
3812 * syntax.c (skip_chars): Likewise.
3814 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3815 This also lets GCC 4.6.0 generate slightly better loop code.
3817 * callint.c (Fcall_interactively): <, not <=, for optimization.
3818 (Fcall_interactively): Count the number of arguments produced,
3819 not the number of arguments given. This is simpler and lets GCC
3820 4.6.0 generate slightly better code.
3822 * ftfont.c: Distingish more carefully between FcChar8 and char.
3823 The previous code passed unsigned char * to a functions like
3824 strlen and xstrcasecmp that expect char *, which does not
3825 conform to the C standard.
3826 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3827 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3828 char * when the C standard requires it.
3830 * keyboard.c (read_char): Remove unused var.
3832 * eval.c: Port to Windows vsnprintf (Bug#8435).
3834 (SIZE_MAX): Define if the headers do not.
3835 (verror): Do not give up if vsnprintf returns a negative count.
3836 Instead, grow the buffer. This ports to Windows vsnprintf, which
3837 does not conform to C99. Problem reported by Eli Zaretskii.
3838 Also, simplify the allocation scheme, by avoiding the need for
3839 calling realloc, and removing the ALLOCATED variable.
3841 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3843 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3844 But keep the doprint source code for now, as we might revamp it
3845 and use it again (Bug#8435).
3846 * lisp.h (doprnt): Remove.
3847 * Makefile.in (base_obj): Remove doprnt.o.
3848 * deps.mk (doprnt.o): Remove.
3850 error: Print 32- and 64-bit integers portably (Bug#8435).
3851 Without this change, on typical 64-bit hosts error ("...%d...", N)
3852 was used to print both 32- and 64-bit integers N, which relied on
3854 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3856 * lisp.h (error, verror): Mark as printf-like functions.
3857 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3858 Report overflow in size calculations when allocating printf buffer.
3859 Do not truncate output string at its first null byte.
3860 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3861 Truncate the output at a character boundary, since vsnprintf does not
3863 * charset.c (check_iso_charset_parameter): Convert internal
3864 character to string before calling 'error', since %c now has the
3866 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3867 overflow when computing char to be passed to 'error'. Do not
3868 pass Lisp_Object to 'error'; pass the integer instead.
3869 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3870 formatted with plain %d.
3872 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3874 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3876 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3878 * xterm.c (x_catch_errors): Remove duplicate declaration.
3880 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3882 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3884 2011-04-10 Jim Meyering <meyering@redhat.com>
3886 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3887 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3888 return ssize_t not "int", and use size_t as the buffer length.
3889 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3890 * gnutls.h: Update declarations.
3891 * process.c (read_process_output): Use ssize_t, to match.
3892 (send_process): Likewise.
3894 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3896 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3898 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3900 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3901 Use unsigned char, to match FcChar8 type definition.
3903 * xterm.c (handle_one_xevent):
3904 * xmenu.c (create_and_show_popup_menu):
3905 * xselect.c (x_decline_selection_request)
3906 (x_reply_selection_request): Avoid type-punned deref of X events.
3908 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3910 Fix some uses of `int' instead of EMACS_INT.
3911 * search.c (string_match_1, fast_string_match)
3912 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3913 (scan_buffer, find_next_newline_no_quit)
3914 (find_before_next_newline, search_command, Freplace_match)
3915 (Fmatch_data): Make some `int' variables be EMACS_INT.
3917 * xdisp.c (display_count_lines): 3rd argument and return value now
3918 EMACS_INT. All callers changed.
3919 (pint2hrstr): Last argument is now EMACS_INT.
3921 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3922 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3923 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3924 (decode_coding_utf_16, decode_coding_emacs_mule)
3925 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3926 (decode_coding_ccl, decode_coding_charset)
3927 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3928 (decode_coding_iso_2022, decode_coding_emacs_mule)
3929 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3930 <char_offset, last_offset>: Declare EMACS_INT.
3931 (encode_coding_utf_8, encode_coding_utf_16)
3932 (encode_coding_emacs_mule, encode_invocation_designation)
3933 (encode_designation_at_bol, encode_coding_iso_2022)
3934 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3935 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3937 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3938 (encode_invocation_designation): Last argument P_NCHARS is now
3940 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3941 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3943 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3946 * ccl.c (Fccl_execute_on_string): Declare some variables
3949 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3951 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3953 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3955 * process.c (Fformat_network_address): Doc fix.
3957 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3959 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3961 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3963 * keyboard.c (read_char): Call Lisp function help-form-show,
3964 instead of using internal_with_output_to_temp_buffer.
3965 (Qhelp_form_show): New var.
3966 (syms_of_keyboard): Use DEFSYM macro.
3968 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3970 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3972 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3974 * process.c (Flist_processes): Remove to Lisp.
3975 (list_processes_1): Delete.
3977 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3979 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3981 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3983 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3985 Fix more problems found by GCC 4.6.0's static checks.
3987 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3989 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3991 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3993 * xdisp.c (vmessage): Mark as a printf-like function.
3995 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3997 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3999 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4000 printf-like functions.
4001 (tiff_load): Add casts to remove these marks before passing them
4002 to system-supplied API.
4004 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4006 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4007 This avoids several warnings with gcc -Wstrict-overflow.
4008 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4009 directly, rather than having caller test rule sign. This avoids
4010 some unnecessary tests.
4011 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4012 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4013 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4015 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4016 (xfont_open): Avoid unnecessary tests.
4018 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4020 * composite.h, composite.c (composition_gstring_put_cache):
4021 Use EMACS_INT, not int, for length.
4023 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4024 breaking out part of COMPOSITION_DECODE_RULE.
4025 (COMPOSITION_DECODE_RULE): Use it.
4026 * composite.c (get_composition_id): Remove unused local vars,
4027 by using the new macro.
4029 * textprop.c (set_text_properties_1): Change while to do-while,
4030 since the condition is always true at first.
4032 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4033 (interval_deletion_adjustment): Return unsigned value.
4036 * process.c (list_processes_1, create_pty, read_process_output):
4037 (exec_sentinel): Remove vars that were set but not used.
4038 (create_pty): Remove unnecessary "volatile"s.
4039 (Fnetwork_interface_info): Avoid possibility of int overflow.
4040 (read_process_output): Do adaptive read buffering even if carryover.
4041 (read_process_output): Simplify nbytes computation if buffered.
4043 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4045 * syntax.c (scan_words): Remove var that was set but not used.
4046 (update_syntax_table): Use unsigned instead of int.
4048 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4049 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4050 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4052 * print.c (print_error_message): Avoid int overflow.
4054 * font.c (font_list_entities): Redo for clarity,
4055 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4057 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4058 (font_score): Avoid potential overflow in diff calculation.
4060 * fns.c (substring_both): Remove var that is set but not used.
4061 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4063 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4065 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4066 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4067 can always succeed if overflow has undefined behavior.
4069 * search.c (boyer_moore, wordify): Remove vars set but not used.
4070 (wordify): Omit three unnecessary tests.
4072 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4073 All callers changed. This avoids the need for an unused var.
4075 * casefiddle.c (casify_region): Remove var that is set but not used.
4077 * dired.c (file_name_completion): Remove var that is set but not used.
4079 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4081 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4082 (Finsert_file_contents): Remove unnecessary code checking fd.
4084 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4085 Check for integer overflow on size calculations.
4087 * buffer.c (Fprevious_overlay_change): Remove var that is set
4090 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4091 Remove vars that are set but not used.
4092 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4093 (timer_check_2): Mark vars as initialized.
4095 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4097 * image.c (lookup_image): Remove var that is set but not used.
4098 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4100 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4101 that are set but not used.
4103 * xfns.c (make_invisible_cursor): Don't return garbage
4104 if XCreateBitmapFromData fails (Bug#8410).
4106 * xselect.c (x_get_local_selection, x_handle_property_notify):
4107 Remove vars that are set but not used.
4109 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4110 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4112 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4113 Remove var that is set but not used.
4114 (scroll_bar_windows_size): Now size_t, not int.
4115 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4118 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4119 (map_tty_color) [!defined MSDOS]: Likewise.
4121 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4123 * coding.c: Remove vars that are set but not used.
4124 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4125 All callers changed.
4126 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4127 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4128 (decode_coding_charset): Remove vars that are set but not used.
4130 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4131 that is set but not used.
4133 * print.c (print_object): Remove var that is set but not used.
4135 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4136 The gnulib version avoids calling malloc in the usual case,
4137 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4138 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4139 * filelock.c (current_lock_owner): Likewise.
4140 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4141 * sysdep.c: Include allocator.h, careadlinkat.h.
4142 (emacs_no_realloc_allocator): New static constant.
4143 (emacs_readlink): New function.
4144 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4145 ../lib/careadlinkat.h.
4147 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4149 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4150 first non-nil return value).
4152 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4154 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4155 if not defined (Bug#8403).
4157 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4159 * xdisp.c (display_count_lines): Remove parameter `start',
4160 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4161 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4162 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4163 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4164 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4165 and thereabouts. All callers changed.
4166 (get_per_char_metric): Remove parameter `f', unused since
4167 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4169 2011-04-02 Jim Meyering <meyering@redhat.com>
4171 do not dereference NULL upon failed strdup
4172 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4173 (ns_get_family): Likewise.
4175 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4177 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4179 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4181 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4184 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4186 Add lexical binding.
4188 * window.c (Ftemp_output_buffer_show): New fun.
4189 (Fsave_window_excursion):
4190 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4192 * lread.c (lisp_file_lexically_bound_p): New function.
4193 (Fload): Bind Qlexical_binding.
4194 (readevalloop): Remove `evalfun' arg.
4195 Bind Qinternal_interpreter_environment.
4196 (Feval_buffer): Bind Qlexical_binding.
4197 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4199 (syms_of_lread): Declare `lexical-binding'.
4201 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4203 * keyboard.c (eval_dyn): New fun.
4204 (menu_item_eval_property): Use it.
4206 * image.c (parse_image_spec): Use Ffunctionp.
4208 * fns.c (concat, mapcar1): Accept byte-code-functions.
4210 * eval.c (Fsetq): Handle lexical vars.
4211 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4212 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4213 (FletX, Flet): Obey lexical binding.
4214 (Fcommandp): Handle closures.
4215 (Feval): New `lexical' arg.
4216 (eval_sub): New function extracted from Feval. Use it almost
4217 everywhere where Feval was used. Look up vars in lexical env.
4219 (Ffunctionp): Move from subr.el.
4220 (Ffuncall): Handle closures.
4221 (apply_lambda): Remove `eval_flags'.
4222 (funcall_lambda): Handle closures and new byte-code-functions.
4223 (Fspecial_variable_p): New function.
4224 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4225 but without exporting it to Lisp.
4227 * doc.c (Fdocumentation, store_function_docstring):
4228 * data.c (Finteractive_form): Handle closures.
4230 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4233 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4235 (exec_byte_code): New function extracted from Fbyte_code to handle new
4236 calling convention for byte-code-functions. Add new byte-codes.
4238 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4240 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4242 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4244 * xdisp.c (redisplay_internal): Fix prototype.
4246 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4248 * xdisp.c (SCROLL_LIMIT): New macro.
4249 (try_scrolling): Use it when setting scroll_limit.
4250 Limit scrolling to 100 screen lines.
4251 (redisplay_window): Even when falling back on "recentering",
4252 position point in the window according to scroll-conservatively,
4253 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4255 (try_scrolling): When point is above the window, allow searching
4256 as far as scroll_max, or one screenful, to compute vertical
4257 distance from PT to the scroll margin position. This prevents
4258 try_scrolling from unnecessarily failing when
4259 scroll-conservatively is set to a value slightly larger than the
4260 window height. Clean up the case of PT below the margin at bottom
4261 of window: scroll_max can no longer be INT_MAX. When aggressive
4262 scrolling is in use, don't let point enter the opposite scroll
4263 margin as result of the scroll.
4264 (syms_of_xdisp) <scroll-conservatively>: Document the
4265 threshold of 100 lines for never-recentering scrolling.
4267 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4269 * dispextern.h (move_it_by_lines):
4270 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4271 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4272 (message_log_check_duplicate): Remove parameters `prev_bol' and
4273 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4274 (redisplay_internal): Remove parameter `preserve_echo_area',
4275 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4277 * indent.c (Fvertical_motion):
4278 * window.c (window_scroll_pixel_based, Frecenter):
4279 Don't pass `need_y_p' to `move_it_by_lines'.
4281 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4283 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4284 steal a few bits to be more compact.
4285 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4286 Remove unneeded casts.
4288 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4290 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4292 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4293 binding" message (bug#7967).
4295 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4297 Fix more problems found by GCC 4.6.0's static checks.
4299 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4300 Remove unused local var.
4302 * editfns.c (Fmessage_box): Remove unused local var.
4304 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4305 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4306 Omit unused local vars.
4307 * window.c (shrink_windows): Omit unused local var.
4308 * menu.c (digest_single_submenu): Omit unused local var.
4309 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4310 Omit unused local var.
4312 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4313 Don't assume string length fits in int.
4314 (keyremap_step, read_key_sequence): Use size_t for sizes.
4315 (read_key_sequence): Don't check last_real_key_start redundantly.
4317 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4318 instead of alloca (Bug#8344).
4320 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4321 (Fbacktrace_frame): Don't assume nframes fits in int.
4323 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4325 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4328 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4330 * cm.c (calccost): Turn while-do into do-while, for clarity.
4332 * keyboard.c (syms_of_keyboard): Use the same style as later
4333 in this function when indexing through an array. This also
4334 works around GCC bug 48267.
4336 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4338 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4340 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4341 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4343 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4344 This avoids undefined behavior on integer overflow, and is a bit
4345 more convenient anyway since it is compared to a size_t variable.
4347 Variadic C functions now count arguments with size_t, not int.
4348 This avoids an unnecessary limitation on 64-bit machines, which
4349 caused (substring ...) to crash on large vectors (Bug#8344).
4350 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4351 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4352 All variadic functions and their callers changed accordingly.
4353 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4354 * data.c (arith_driver, float_arith_driver): Likewise.
4355 * editfns.c (general_insert_function): Likewise.
4356 * eval.c (struct backtrace.nargs, interactive_p)
4357 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4358 (funcall_lambda, mark_backtrace): Likewise.
4359 * fns.c (concat): Likewise.
4360 * frame.c (x_set_frame_parameters): Likewise.
4361 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4362 0 if not found, not -1. All callers changed.
4364 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4365 (stack_copy_size): Now size_t, not int.
4366 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4368 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4370 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4371 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4372 All callers changed.
4374 * lisp.h (multibyte_char_to_unibyte):
4375 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4376 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4377 * character.h (CHAR_TO_BYTE8):
4378 * cmds.c (internal_self_insert):
4379 * editfns.c (general_insert_function):
4380 * keymap.c (push_key_description):
4381 * search.c (Freplace_match):
4382 * xdisp.c (message_dolog, set_message_1): All callers changed.
4384 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4386 * keyboard.c (safe_run_hook_funcall): New function.
4387 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4388 don't set the hook to nil, but remove the offending function instead.
4389 (Qcommand_hook_internal): Remove, unused.
4390 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4391 Vcommand_hook_internal.
4393 * eval.c (enum run_hooks_condition): Remove.
4394 (funcall_nil, funcall_not): New functions.
4395 (run_hook_with_args): Call each function through a `funcall' argument.
4396 Remove `cond' argument, now redundant.
4397 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4398 (Frun_hook_with_args_until_failure): Adjust accordingly.
4399 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4401 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4403 * dispextern.h (string_buffer_position): Remove declaration.
4405 * print.c (strout): Remove parameter `multibyte', unused since
4406 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4408 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4409 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4410 All callers changed.
4412 * w32.c (_wsa_errlist): Use braces for struct initializers.
4414 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4415 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4416 All callers changed.
4417 (string_buffer_position): Likewise. Also, make static (it's never
4418 used outside xdisp.c).
4419 (cursor_row_p): Remove parameter `w', unused since
4420 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4421 (decode_mode_spec): Remove parameter `precision', introduced during
4422 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4423 All callers changed.
4425 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4427 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4429 2011-03-27 Anders Lindgren <andlind@gmail.com>
4431 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4432 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4433 (ns_update_auto_hide_menu_bar): New functions.
4434 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4435 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4436 ns_constrain_all_frames.
4437 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4438 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4440 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4442 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4444 2011-03-27 Glenn Morris <rgm@gnu.org>
4446 * syssignal.h: Replace RETSIGTYPE with void.
4447 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4448 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4449 Replace SIGTYPE with void everywhere.
4450 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4451 * s/template.h (SIGTYPE): Remove commented out definition.
4453 2011-03-26 Eli Zaretskii <eliz@gnu.org>
4455 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4456 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4458 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
4460 * w32.c (read_unc_volume): Use parameter `henum', instead of
4461 global variable `wget_enum_handle'.
4463 * keymap.c (describe_vector): Remove parameters `indices' and
4464 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4465 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4467 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4469 * keyboard.c (timer_check): Remove parameter `do_it_now',
4470 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4471 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4472 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4474 * keyboard.c (read_char):
4475 * w32menu.c (w32_menu_display_help):
4476 * xmenu.c (show_help_event, menu_help_callback):
4477 Adjust calls to `show_help_echo'.
4479 * gtkutil.c (xg_maybe_add_timer):
4480 * keyboard.c (readable_events):
4481 * process.c (wait_reading_process_output):
4482 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4484 * insdel.c (adjust_markers_gap_motion):
4485 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4486 (gap_left, gap_right): Don't call it.
4488 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
4490 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4491 incurred during fontification.
4493 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4495 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4496 (DEFVAR_PER_BUFFER): Don't pass it.
4498 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4499 (scrolling_window): Don't pass it.
4501 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
4503 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4505 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4507 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4508 of variables specific to SELinux and computation of `encoded_absname'.
4510 * image.c (XPutPixel): Remove unused variable `height'.
4512 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4514 * unexw32.c (get_section_info): Remove unused variable `section'.
4516 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4517 (system_process_attributes): Remove unused variable `sess'.
4518 (sys_read): Remove unused variable `err'.
4520 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4521 (w32_wnd_proc): Remove unused variable `isdead'.
4522 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4523 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4524 (x_create_tip_frame): Remove unused variable `tem'.
4526 * w32inevt.c (w32_console_read_socket):
4527 Remove unused variable `no_events'.
4529 * w32term.c (x_draw_composite_glyph_string_foreground):
4530 Remove unused variable `width'.
4532 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
4534 * w32term.c (x_set_glyph_string_clipping):
4535 Don't pass uninitialized region to CombineRgn.
4537 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
4539 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4540 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4541 (Fx_close_connection): Remove unused variable `i'.
4543 * w32font.c (w32font_draw): Return number of glyphs.
4544 (w32font_open_internal): Remove unused variable `i'.
4545 (w32font_driver): Add missing initializer.
4547 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4548 (fill_in_menu): Remove unused variable `items_added'.
4550 * w32term.c (last_mouse_press_frame): Remove static global variable.
4551 (w32_clip_to_row): Remove unused variable `f'.
4552 (x_delete_terminal): Remove unused variable `i'.
4554 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4555 (NOTHING): Remove unused static global variable.
4556 (uniscribe_check_otf): Remove unused variable `table'.
4557 (uniscribe_font_driver): Add missing initializers.
4559 2011-03-23 Julien Danjou <julien@danjou.info>
4561 * term.c (Fsuspend_tty, Fresume_tty):
4562 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4563 * window.c (temp_output_buffer_show):
4564 * insdel.c (signal_before_change):
4565 * frame.c (Fhandle_switch_frame):
4566 * fileio.c (Fdo_auto_save):
4567 * emacs.c (Fkill_emacs):
4568 * editfns.c (save_excursion_restore):
4569 * cmds.c (internal_self_insert):
4570 * callint.c (Fcall_interactively):
4571 * buffer.c (Fkill_all_local_variables):
4572 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4574 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
4575 unconditionnaly since it does the check itself.
4577 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
4579 Fix more problems found by GCC 4.5.2's static checks.
4581 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4582 the first time through the loop, since we know p0 < p1 then.
4583 This also avoids a gcc -Wstrict-overflow warning.
4585 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4586 leading to a memory leak, possible in functions like
4587 load_charset_map_from_file that can allocate an unbounded number
4588 of objects (Bug#8318).
4590 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4591 that could (at least in theory) be that large.
4593 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4594 This is less likely to overflow, and avoids undefined behavior if
4595 overflow does occur. All callers changed. Use strtoul to scan
4596 for the unsigned long integer.
4597 (pint2hrstr): Simplify and tune code slightly.
4598 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
4600 * scroll.c (do_scrolling): Work around GCC bug 48228.
4601 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4603 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4604 This also avoids a warning with gcc -Wstrict-overflow.
4605 (validate_x_resource_name): Simplify count usage.
4606 This also avoids a warning with gcc -Wstrict-overflow.
4608 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4611 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
4613 * process.c (Fmake_network_process): Use socklen_t, not int,
4614 where POSIX says socklen_t is required in portable programs.
4615 This fixes a porting bug on hosts like 64-bit HP-UX, where
4616 socklen_t is wider than int (Bug#8277).
4617 (Fmake_network_process, server_accept_connection):
4618 (wait_reading_process_output, read_process_output):
4621 * process.c: Rename or move locals to avoid shadowing.
4622 (list_processes_1, Fmake_network_process):
4623 (read_process_output_error_handler, exec_sentinel_error_handler):
4624 Rename or move locals.
4625 (Fmake_network_process): Define label "retry_connect" only if needed.
4626 (Fnetwork_interface_info): Fix pointer signedness.
4627 (process_send_signal): Add cast to avoid pointer signedness problem.
4628 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
4629 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
4631 Make tparam.h and terminfo.c consistent.
4632 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4633 Include tparam.h instead, since it declares them.
4634 * cm.h (PC): Remove extern decl; tparam.h now does this.
4635 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4636 * terminfo.c: Include tparam.h, to check interfaces.
4637 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4638 (tparam): Adjust signature to match interface in tparam.h;
4639 this removes some undefined behavior. Check that outstring and len
4640 are zero, which they always are with Emacs.
4641 * tparam.h (PC, BC, UP): New extern decls.
4643 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
4644 (xftfont_open): Rename locals to avoid shadowing.
4646 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
4647 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4648 (OTF_TAG_SYM): Omit macro if not needed.
4649 (ftfont_list): Remove unused local.
4650 (get_adstyle_property, ftfont_pattern_entity):
4651 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4652 Rename locals to avoid shadowing.
4654 * xfont.c (xfont_list_family): Mark var as initialized.
4656 * xml.c (make_dom): Now static.
4658 * composite.c (composition_compute_stop_pos): Rename local to
4660 (composition_reseat_it): Remove unused locals.
4661 (find_automatic_composition, composition_adjust_point): Likewise.
4662 (composition_update_it): Mark var as initialized.
4663 (find_automatic_composition): Mark vars as initialized,
4664 with a FIXME (Bug#8290).
4666 character.h: Rename locals to avoid shadowing.
4667 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4668 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4669 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4670 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4673 * textprop.c (property_change_between_p): Remove; unused.
4675 * intervals.c (interval_start_pos): Now static.
4677 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4679 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4680 Rename locals to avoid shadowing.
4682 * sound.c (wav_play, au_play, Fplay_sound_internal):
4683 Fix pointer signedness.
4684 (alsa_choose_format): Remove unused local var.
4685 (wav_play): Initialize a variable to 0, to prevent undefined
4686 behavior (Bug#8278).
4688 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4690 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4692 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4693 clobbering (Bug#8298).
4694 * sysdep.c (sys_subshell): Likewise.
4695 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
4697 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4698 This should get cleaned up, so that child_setup has the
4699 same signature on all platforms.
4701 * callproc.c (call_process_cleanup): Now static.
4702 (relocate_fd): Rename locals to avoid shadowing.
4704 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
4706 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4707 not to be necessary, and produces flickering.
4709 2011-03-20 Glenn Morris <rgm@gnu.org>
4711 * config.in: Remove file.
4713 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
4715 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4716 are now in src/globals.h.
4717 (syms_of_minibuf): Remove spurious & from previous change.
4719 2011-03-20 Leo <sdl.web@gmail.com>
4721 * minibuf.c (completing-read-function): New variable.
4722 (completing-read-default): Rename from completing-read.
4723 (completing-read): Call completing-read-function.
4725 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4727 * xfaces.c (Fx_load_color_file):
4728 Read color file from absolute filename (bug#8250).
4730 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
4732 * makefile.w32-in: Update dependencies.
4734 2011-03-17 Eli Zaretskii <eliz@gnu.org>
4736 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4738 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4740 Fix more problems found by GCC 4.5.2's static checks.
4742 * process.c (make_serial_process_unwind, send_process_trap):
4743 (sigchld_handler): Now static.
4745 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4746 That way, the code declares only the vars that it needs.
4747 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4748 * s/cygwin.h (PTY_ITERATION): Likewise.
4749 * s/darwin.h (PTY_ITERATION): Likewise.
4750 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4752 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4753 * process.c (allocate_pty): Don't declare stb unless it's needed.
4755 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
4756 (CONSTANTLIM): Remove; unused.
4757 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4758 Define only if needed.
4760 * unexelf.c (unexec): Name an expression,
4761 to avoid gcc -Wbad-function-cast warning.
4762 Use a different way to cause a compilation error if anyone uses
4763 n rather than nn, a way that does not involve shadowing.
4764 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
4766 * deps.mk (unexalpha.o): Remove; unused.
4768 New file unexec.h, the (simple) interface for unexec (Bug#8267).
4769 * unexec.h: New file.
4770 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4771 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4773 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4774 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4775 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
4776 Change as necessary to match prototype in unexec.h.
4778 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4780 (back_comment, skip_chars): Mark vars as initialized.
4782 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4783 Rename locals to avoid shadowing.
4785 * lread.c (read1): Rewrite so as not to use empty "else".
4786 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
4788 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4790 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4791 warning when compiling print.c.
4793 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4794 instead of using an uninitialized var.
4795 (font_sort_entities): Mark var as initialized.
4797 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4799 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4800 pointers to constants.
4801 (font_parse_fcname): Remove unused vars.
4802 (font_delete_unmatched): Now static.
4803 (font_get_spec): Remove; unused.
4804 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4805 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4806 Rename or move locals to avoid shadowing.
4808 * fns.c (require_nesting_list, require_unwind): Now static.
4809 (Ffillarray): Rename locals to avoid shadowing.
4811 * floatfns.c (domain_error2): Define only if needed.
4812 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
4814 * alloc.c (mark_backtrace): Move decl from here ...
4815 * lisp.h: ... to here, so that it can be checked.
4817 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4818 (Fdefvar): Rewrite so as not to use empty "else".
4819 (lisp_indirect_variable): Name an expression,
4820 to avoid gcc -Wbad-function-cast warning.
4821 (Fdefvar): Rename locals to avoid shadowing.
4823 * callint.c (quotify_arg, quotify_args): Now static.
4824 (Fcall_interactively): Rename locals to avoid shadowing.
4825 Use const pointer when appropriate.
4827 * lisp.h (get_system_name, get_operating_system_release):
4828 Move decls here, to check interfaces.
4829 * process.c (get_operating_system_release): Move decl to lisp.h.
4830 * xrdb.c (get_system_name): Likewise.
4831 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4832 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4833 some of which prompt warnings from gcc -Wbad-function-cast.
4834 (Fformat_time_string, Fencode_time, Finsert_char):
4835 (Ftranslate_region_internal, Fformat):
4836 Rename or remove local vars to avoid shadowing.
4837 (Ftranslate_region_internal): Mark var as initialized.
4839 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4842 * lisp.h (eassert): Check that the argument compiles, even if
4843 ENABLE_CHECKING is not defined.
4845 * data.c (Findirect_variable): Name an expression, to avoid
4846 gcc -Wbad-function-cast warning.
4847 (default_value, arithcompare, arith_driver, arith_error): Now static.
4848 (store_symval_forwarding): Rename local to avoid shadowing.
4849 (Fmake_variable_buffer_local, Fmake_local_variable):
4850 Mark variables as initialized.
4851 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4853 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4854 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4855 Rename locals to avoid shadowing.
4856 (mark_stack): Move local variables into the #ifdef region where
4858 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4859 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4861 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4862 (GC_STRING_CHARS): Remove; not used.
4863 (Fmemory_limit): Cast sbrk's returned value to char *.
4865 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4866 avoids undefined behavior in theory.
4868 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4870 Use functions, not macros, for up- and down-casing (Bug#8254).
4871 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4872 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4873 to use the following functions instead of these macros.
4874 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4875 EMACS_INT, since callers assume the returned value fits in int.
4876 (upcase1): Likewise, for UPCASE_TABLE.
4877 (uppercasep, lowercasep, upcase): New static inline functions.
4878 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4879 the race-condition problem in the old DOWNCASE.
4881 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4882 Rename locals to avoid shadowing.
4883 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4884 (regex_compile, re_search_2, re_match_2_internal):
4885 Remove unused local vars.
4886 (FREE_VAR): Rewrite so as not to use empty "else",
4887 which gcc can warn about.
4888 (regex_compile, re_match_2_internal): Mark locals as initialized.
4889 (RETALLOC_IF): Define only if needed.
4890 (WORDCHAR_P): Likewise. This one is never needed, but is used
4891 only in a comment talking about a compiler bug, so put inside
4892 the #if 0 of that comment.
4893 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4894 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4897 * search.c (boyer_moore): Rename locals to avoid shadowing.
4898 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4899 (PREV_CHAR_BOUNDARY): Likewise.
4901 * search.c (simple_search): Remove unused var.
4903 * dired.c (compile_pattern): Move decl from here ...
4904 * lisp.h: ... to here, so that it can be checked.
4905 (struct re_registers): New forward decl.
4907 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4909 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4911 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4912 Rename locals to avoid shadowing.
4913 (Fvertical_motion): Mark locals as initialized.
4915 * casefiddle.c (casify_object, casify_region): Now static.
4916 (casify_region): Mark local as initialized.
4918 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4920 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4921 New macros, so that the caller can use some names other than
4922 gcpro1, gcpro2, etc.
4923 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4925 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4926 argument, for consistency with GCPRO2_VAR, etc: it is now the
4927 prefix of the variable, not the variable itself. All uses
4929 * dired.c (directory_files_internal, file_name_completion):
4930 Rename locals to avoid shadowing.
4932 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4933 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4934 dired.c's scmp function, had undefined behavior.
4935 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4936 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4937 * buffer.h: ... to here, because these macros use current_buffer,
4938 and the new implementation with inline functions needs to have
4939 current_buffer in scope now, rather than later when the macros
4941 (downcase, upcase1): New static inline functions.
4942 (DOWNCASE, UPCASE1): Reimplement using these functions.
4943 This avoids undefined behavior in expressions like
4944 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4945 from race conditions in accessing the global variables
4946 case_temp1 and case_temp2.
4947 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4948 * lisp.h (case_temp1, case_temp2): Remove their decls.
4949 * character.h (ASCII_CHAR_P): Move from here ...
4950 * lisp.h: ... to here, so that the inline functions mentioned
4953 * dired.c (directory_files_internal_unwind): Now static.
4955 * fileio.c (file_name_as_directory, directory_file_name):
4956 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4958 (file_name_as_directory): Use const pointers when appropriate.
4959 (Fexpand_file_name): Likewise. In particular, newdir might
4960 point at constant storage, so make it a const pointer.
4961 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4962 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4964 (Fset_file_times, Finsert_file_contents, auto_save_error):
4965 Rename locals to avoid shadowing.
4967 * minibuf.c (choose_minibuf_frame_1): Now static.
4968 (Ftry_completion, Fall_completions): Rename or remove locals
4971 * marker.c (bytepos_to_charpos): Remove; unused.
4973 * lisp.h (verify_bytepos, count_markers): New decls,
4974 so that gcc does not warn that these functions aren't declared.
4976 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4977 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4978 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4979 (copy_text): Remove unused local var.
4981 * filelock.c (within_one_second): Now static.
4982 (lock_file_1): Rename local to avoid shadowing.
4984 * buffer.c (fix_overlays_before): Mark locals as initialized.
4985 (fix_start_end_in_overlays): Likewise. This function should be
4986 simplified by using pointers-to-pointers, but that's a different
4988 (switch_to_buffer_1): Now static.
4989 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4990 (report_overlay_modification): Rename locals to avoid shadowing.
4992 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4993 Fix pointer signedness issue.
4994 (sys_subshell): Mark local as volatile if checking for lint,
4995 to suppress a gcc -Wclobbered warning that does not seem to be right.
4996 (MAXPATHLEN): Define only if needed.
4998 * process.c (serial_open, serial_configure): Move decls from here ...
4999 * systty.h: ... to here, so that they can be checked.
5001 * fns.c (get_random, seed_random): Move extern decls from here ...
5002 * lisp.h: ... to here, so that they can be checked.
5004 * sysdep.c (reset_io): Now static.
5005 (wait_for_termination_signal): Remove; unused.
5007 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5008 (copy_keymap_item, append_key, push_text_char_description):
5010 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5011 (DENSE_TABLE_SIZE): Remove; unused.
5012 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5013 (describe_map_tree):
5014 Rename locals to avoid shadowing.
5016 * keyboard.c: Declare functions static if they are not used elsewhere.
5017 (echo_char, echo_dash, cmd_error, top_level_2):
5018 (poll_for_input, handle_async_input): Now static.
5019 (read_char, kbd_buffer_get_event, make_lispy_position):
5020 (make_lispy_event, make_lispy_movement, apply_modifiers):
5021 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5022 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5023 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5024 (read_key_sequence, read_char): Mark locals as initialized.
5025 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5027 * keyboard.h (make_ctrl_char): New decl.
5028 (mark_kboards): Move decl here ...
5029 * alloc.c (mark_kboards): ... from here.
5031 * lisp.h (force_auto_save_soon): New decl.
5033 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5034 (DEFINE_DUMMY_FUNCTION): New macro.
5035 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5037 (main): Add casts to avoid warnings
5038 if GCC considers string literals to be constants.
5040 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5042 * dbusbind.c: Pointer signedness fixes.
5043 (xd_signature, xd_append_arg, xd_initialize):
5044 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5045 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5046 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5047 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5049 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5050 if GCC considers string literals to be constants.
5051 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5053 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5055 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5056 (print_preprocess, print_object): New macro to fix last change.
5058 * print.c (print_preprocess): Don't forget font objects.
5060 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5062 * emacs.c (USAGE3): Doc fixes.
5064 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5066 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5069 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5071 * lisp.h (VWindow_system, Qfile_name_history):
5072 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5073 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5074 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5076 * w32select.c: Don't #include "keyboard.h".
5077 (run_protected): Add extern declaration for waiting_for_input.
5079 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5080 * w32console.c (detect_input_pending, read_input_pending)
5081 (encode_terminal_code):
5082 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5083 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5084 (w32_system_caret_y, Qfile_name_history):
5085 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5086 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5087 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5088 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5089 * w32proc.c (Qlocal, report_file_error):
5090 * w32term.c (Vwindow_system, updating_frame):
5091 * w32uniscribe.c (initialized, uniscribe_font_driver):
5092 Remove unneeded extern declarations.
5094 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5096 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5098 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5100 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5101 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5102 These macros can no longer be used for assignment.
5104 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5105 Assign struct members directly, instead of using BUF_BEGV etc.
5106 (record_buffer_markers, fetch_buffer_markers): New functions for
5107 recording and fetching special buffer markers.
5108 (set_buffer_internal_1, set_buffer_temp): Use them.
5110 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5112 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5114 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5115 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5117 * xdisp.c (hscroll_window_tree):
5118 (reconsider_clip_changes): Use PT instead of BUF_PT.
5120 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5122 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5123 $(EMACS_ROOT)/lib/intprops.h.
5125 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5127 Fix more problems found by GCC 4.5.2's static checks.
5129 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5130 to unsigned char * to avoid compiler diagnostic.
5131 (xg_free_frame_widgets): Make it clear that a local variable is
5132 needed only if USE_GTK_TOOLTIP.
5133 (gdk_window_get_screen): Make it clear that this macro is needed
5134 only if USE_GTK_TOOLTIP.
5135 (int_gtk_range_get_value): New function, which avoids a diagnostic
5136 from gcc -Wbad-function-cast.
5137 (xg_set_toolkit_scroll_bar_thumb): Use it.
5138 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5139 diagnostic from gcc -Wbad-function-cast.
5140 (get_utf8_string, xg_get_file_with_chooser):
5141 Rename locals to avoid shadowing.
5142 (create_dialog): Move locals to avoid shadowing.
5144 * xgselect.c (xg_select): Remove unused var.
5146 * image.c (four_corners_best): Mark locals as initialized.
5147 (gif_load): Initialize transparent_p to zero (Bug#8238).
5148 Mark another local as initialized.
5149 (my_png_error, my_error_exit): Mark with NO_RETURN.
5151 * image.c (clear_image_cache): Now static.
5152 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5153 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5154 (x_edge_detection): Remove unnecessary cast that
5155 gcc -Wbad-function-cast diagnoses.
5156 (gif_load): Fix pointer signedness.
5157 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5158 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5160 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5162 Improve quality of tests for time stamp overflow.
5163 For example, without this patch (encode-time 0 0 0 1 1
5164 1152921504606846976) returns the obviously-bogus value (-948597
5165 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5166 reports time overflow. See
5167 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5168 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5169 * editfns.c: Include limits.h and intprops.h.
5170 (TIME_T_MIN, TIME_T_MAX): New macros.
5171 (time_overflow): Move earlier, to before first use.
5172 (hi_time, lo_time): New functions, for an accurate test for
5174 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5175 (Fget_internal_run_time): Don't assume time_t fits in int.
5176 (make_time): Use list2 instead of Fcons twice.
5177 (Fdecode_time): More accurate test for out-of-range times.
5178 (check_tm_member): New function.
5179 (Fencode_time): Use it, to test for out-of-range times.
5180 (lisp_time_argument): Don't rely on undefined left-shift and
5181 right-shift behavior when checking for time stamp overflow.
5183 * editfns.c (time_overflow): New function, refactoring common code.
5184 (Fformat_time_string, Fdecode_time, Fencode_time):
5185 (Fcurrent_time_string): Use it.
5187 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5188 * dired.c (make_time): Move to ...
5189 * editfns.c (make_time): ... here.
5190 * systime.h: Note the move.
5192 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5194 * fringe.c (update_window_fringes): Remove unused variables.
5196 * unexmacosx.c (copy_data_segment): Also copy __got section.
5199 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5201 * termcap.c [MSDOS]: Include "msdos.h".
5202 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5203 Constify `char *' arguments and their references according to
5204 prototypes in tparam.h.
5206 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5208 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5209 Adapt all references accordingly.
5211 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5213 2011-03-11 Tom Tromey <tromey@redhat.com>
5215 * buffer.c (syms_of_buffer): Remove obsolete comment.
5217 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5219 * termhooks.h (encode_terminal_code): Declare prototype.
5221 * msdos.c (encode_terminal_code): Don't declare prototype.
5223 * term.c (encode_terminal_code): Now external again, used by
5224 w32console.c and msdos.c.
5226 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5227 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5229 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5231 Fix some minor problems found by GCC 4.5.2's static checks.
5233 * fringe.c (update_window_fringes): Mark locals as initialized
5235 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5237 * alloc.c (mark_fringe_data): Move decl from here ...
5238 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5239 to check its interface.
5240 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5242 * fontset.c (free_realized_fontset): Now static.
5243 (Fset_fontset_font): Rename local to avoid shadowing.
5244 (fontset_font): Mark local as initialized.
5245 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5247 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5249 * xselect.c (x_disown_buffer_selections): Remove; not used.
5250 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5251 (x_own_selection, Fx_disown_selection_internal): Rename locals
5253 (x_handle_dnd_message): Remove local to avoid shadowing.
5255 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5256 so that the caller can use some name other than gcpro1.
5257 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5258 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5259 (Fx_backspace_delete_keys_p):
5260 Use them to avoid shadowing, and rename vars to avoid shadowing.
5261 (x_decode_color, x_set_name, x_window): Now static.
5262 (Fx_create_frame): Add braces to silence GCC warning.
5263 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5264 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5265 Remove unused locals.
5266 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5267 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5268 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5271 * xterm.h (x_mouse_leave): New decl.
5273 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5274 Remove unused functions.
5275 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5276 (x_calc_absolute_position): Now static.
5277 (XTread_socket): Don't define label "out" unless it's used.
5278 Don't declare local "event" unless it's used.
5279 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5280 unless they are used.
5281 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5282 (x_fatal_error_signal): Remove; not used.
5283 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5284 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5285 (x_error_catcher, x_connection_closed, x_error_handler):
5286 (x_error_quitter, xembed_send_message, x_iconify_frame):
5287 (my_log_handler): Rename locals to avoid shadowing.
5288 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5289 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5291 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5292 Rename or move locals to avoid shadowing.
5293 (tty_defined_color, merge_face_heights): Now static.
5294 (free_realized_faces_for_fontset): Remove; not used.
5295 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5296 does not deduce is never used uninitialized.
5297 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5298 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5300 * terminal.c (store_terminal_param): Now static.
5302 * xmenu.c (menu_highlight_callback): Now static.
5303 (set_frame_menubar): Remove unused local.
5304 (xmenu_show): Rename parameter to avoid shadowing.
5305 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5306 since they might point to immutable storage.
5307 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5308 since it's unused otherwise.
5310 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5311 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5312 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5313 avoids a gcc -Wuninitialized diagnostic.
5314 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5315 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5316 does not deduce are never used uninitialized.
5318 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5320 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5321 * window.c (window_loop, size_window):
5322 (run_window_configuration_change_hook, enlarge_window): Likewise.
5324 * window.c (display_buffer): Now static.
5325 (size_window): Mark variables that gcc -Wuninitialized
5326 does not deduce are never used uninitialized.
5327 * window.h (check_all_windows): New decl, to forestall
5328 gcc -Wmissing-prototypes diagnostic.
5329 * dispextern.h (bidi_dump_cached_states): Likewise.
5331 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5333 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5335 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5336 and to avoid gcc -Wuninitialized warning.
5337 (load_charset_map): Mark variables that gcc -Wuninitialized
5338 does not deduce are never used uninitialized.
5339 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5341 * coding.c (coding_set_source, coding_set_destination):
5342 Use "else { /* comment */ }" rather than "else /* comment */;"
5343 for clarity, and to avoid gcc -Wempty-body warning.
5344 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5345 a block, when the outer 'i' will do.
5346 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5347 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5348 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5349 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5350 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5351 Rename locals to avoid shadowing.
5352 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5353 * coding.c (emacs_mule_char, encode_invocation_designation):
5354 Now static, since they're not used elsewhere.
5355 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5356 (decode_coding_object, encode_coding_object, detect_coding_system):
5357 (decode_coding_emacs_mule): Mark variables that gcc
5358 -Wuninitialized does not deduce are never used uninitialized.
5359 (detect_coding_iso_2022): Initialize a local variable that might
5360 be used uninitialized. Leave a FIXME because it's not clear that
5361 this initialization is needed. (Bug#8211)
5362 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5363 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5364 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5365 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5366 Remove unused macros.
5368 * category.c (hash_get_category_set): Remove unused local var.
5369 (copy_category_table): Now static, since it's not used elsewhere.
5370 * character.c (string_count_byte8): Likewise.
5372 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5373 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5375 * chartab.c (copy_sub_char_table): Now static, since it's not used
5377 (sub_char_table_ref_and_range, char_table_ref_and_range):
5378 Rename locals to avoid shadowing.
5379 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5381 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5382 (BIDI_BOB): Remove unused macro.
5384 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5385 deduce are never used uninitialized.
5386 * term.c (encode_terminal_code): Likewise.
5388 * term.c (encode_terminal_code): Now static. Remove unused local.
5390 * tparam.h: New file.
5391 * term.c, tparam.h: Include it.
5392 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5393 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5394 Move these decls to tparam.h, and make them agree with what
5395 is actually in tparam.c. The previous trick of using incompatible
5396 decls in different modules does not conform to the C standard.
5397 All callers of tparam changed to use tparam's actual API.
5398 * tparam.c (tparam1, tparam, tgoto):
5399 Use const pointers where appropriate.
5401 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5402 * cm.h (struct cm): Likewise.
5403 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5404 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5405 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5406 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5407 (turn_on_face, init_tty): Likewise.
5408 * termchar.h (struct tty_display_info): Likewise.
5410 * term.c (term_mouse_position): Rename local to avoid shadowing.
5412 * alloc.c (mark_ttys): Move decl from here ...
5413 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5415 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5417 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5419 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5421 * search.c (compile_pattern_1): Remove argument regp, unused since
5422 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5423 (compile_pattern): Don't pass it.
5425 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5427 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5428 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5430 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5432 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5434 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5435 gdk_window_get_screen, gdk_window_get_geometry,
5436 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5437 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5438 (xg_get_pixbuf_from_pixmap): New function.
5439 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5440 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5441 Call xg_get_pixbuf_from_pixmap instead of
5442 gdk_pixbuf_get_from_drawable.
5443 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5444 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5445 (xg_check_special_colors): Use GtkStyleContext and its functions
5447 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5448 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5449 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
5450 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5451 Call gtk_widget_get_preferred_size.
5452 (xg_frame_resized): gdk_window_get_geometry only takes 5
5454 (xg_win_to_widget, xg_event_is_for_menubar):
5455 Call gdk_x11_window_lookup_for_display.
5456 (xg_set_widget_bg): New function.
5457 (delete_cb): New function.
5458 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5459 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5460 (xg_set_background_color): Call xg_set_widget_bg.
5461 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5462 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5463 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5464 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5466 (update_frame_tool_bar): Call gtk_widget_hide.
5467 (xg_initialize): Use GDK_KEY_g.
5469 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5471 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5473 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5474 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5475 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5477 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
5479 * w32xfns.c (select_palette): Check success of RealizePalette against
5480 GDI_ERROR, not zero.
5482 See ChangeLog.11 for earlier changes.
5488 Copyright (C) 2011 Free Software Foundation, Inc.
5490 This file is part of GNU Emacs.
5492 GNU Emacs is free software: you can redistribute it and/or modify
5493 it under the terms of the GNU General Public License as published by
5494 the Free Software Foundation, either version 3 of the License, or
5495 (at your option) any later version.
5497 GNU Emacs is distributed in the hope that it will be useful,
5498 but WITHOUT ANY WARRANTY; without even the implied warranty of
5499 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5500 GNU General Public License for more details.
5502 You should have received a copy of the GNU General Public License
5503 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.